{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/241446540","pull_request_review_id":184721111,"id":241446540,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ0NjU0MA==","diff_hunk":"@@ -0,0 +1,152 @@\n+import * as React from 'react';\n+import { AboutModal as PfAboutModal, TextContent, TextList, TextListItem } from '@patternfly/react-core';\n+import { FLAGS, connectToFlags } from '../features';\n+import { k8sVersion } from '../module/status';\n+import { coFetchJSON } from '../co-fetch';\n+import * as okdLogoImg from '../imgs/okd-logo.svg'; // eslint-disable-line import/no-duplicates\n+import * as ocpLogoImg from '../imgs/openshift-platform-logo.svg';\n+import * as onlineLogoImg from '../imgs/openshift-online-logo.svg';\n+import * as dedicatedLogoImg from '../imgs/openshift-dedicated-logo.svg';\n+//todo: replace with new about modal rh logo\n+import * as rhLogoImg from '../imgs/okd-logo.svg'; // eslint-disable-line import/no-duplicates\n+//todo: replace with new about modal okd logo\n+import * as okdModalImg from '../imgs/okd-logo.svg'; // eslint-disable-line import/no-duplicates\n+import * as pfBg992 from '../../public/imgs/pfbg_992.jpg';\n+\n+class AboutModal extends React.Component {\n+  constructor(props) {\n+    super(props);\n+    this.state = {\n+      openshiftVersion: null,\n+      kubernetesVersion: null,\n+    };\n+  }\n+\n+  componentDidMount() {\n+    this._checkOpenShiftVersion();\n+    this._checkKubernetesVersion();\n+  }\n+\n+  componentDidUpdate(prevProps){\n+    if (prevProps.openshiftFlag !== this.props.openshiftFlag){\n+      this._checkOpenShiftVersion();\n+    }\n+  }\n+\n+  _checkOpenShiftVersion() {\n+    const openshiftFlag = this.props.openshiftFlag;\n+    if (openshiftFlag) {\n+      coFetchJSON('api/kubernetes/version/openshift')\n+        .then(data => {\n+          this.setState({ openshiftVersion: data.gitVersion });\n+        })\n+        .catch(() => this.setState({ openshiftVersion: 'unknown' }));\n+    }\n+  }\n+\n+  _checkKubernetesVersion() {\n+    k8sVersion()\n+      .then(data => this.setState({ kubernetesVersion: data.gitVersion }))\n+      .catch(() => this.setState({ kubernetesVersion: 'unknown' }));\n+  }\n+\n+  render() {\n+    const { isOpen, closeAboutModal, backgroundImg, logoAlt, logoImg, title } = this.props;\n+    const { openshiftVersion, kubernetesVersion } = this.state;\n+\n+    return (\n+      <PfAboutModal\n+        isOpen={isOpen}\n+        onClose={closeAboutModal}\n+        productName={title}\n+        trademark=\"Trademark and copyright information here\"","path":"frontend/public/components/about-modal.jsx","position":62,"original_position":62,"commit_id":"2ed461d271b3b574cbc0f22d080cd996e17e8467","original_commit_id":"41f9318c0cb002f4f9d49a22bbd78fec21bb8563","user":{"login":"rhamilto","id":895728,"node_id":"MDQ6VXNlcjg5NTcyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/895728?v=4","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"body":"Additionally, AboutModal's `productTitle` prop currently requires a string.  As currently written, the OpenShift cases are JSX in order to include a superscript registration mark after \"Red Hat\".  This works, but results in a warning the browser console. [1]  Options are to remove the superscript registration mark, change the upstream prop type to allow JSX, or do nothing and ignore the error.\r\n\r\n[1] \r\n![screen shot 2018-12-13 at 10 31 13 am](https://user-images.githubusercontent.com/895728/49949008-a0d19380-fec2-11e8-98d8-71fbdb05dc60.png)\r\n","created_at":"2018-12-13T15:35:10Z","updated_at":"2018-12-13T15:35:10Z","html_url":"https://github.com/openshift/console/pull/936#discussion_r241446540","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/936","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/241446540"},"html":{"href":"https://github.com/openshift/console/pull/936#discussion_r241446540"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/936"}},"in_reply_to_id":241034424},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/936","id":237811310,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODExMzEw","html_url":"https://github.com/openshift/console/pull/936","diff_url":"https://github.com/openshift/console/pull/936.diff","patch_url":"https://github.com/openshift/console/pull/936.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/936","number":936,"state":"open","locked":false,"title":"[WIP] Integrate PatternFly 4 nav and font-family","user":{"login":"rhamilto","id":895728,"node_id":"MDQ6VXNlcjg5NTcyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/895728?v=4","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"body":"Replaces #674, #813\r\n\r\nTODOs:\r\n\r\n- [x] Remove `nav-item-iconic` added in https://github.com/openshift/console/pull/839\r\n- [ ] Finalize About modal content\r\n- [ ] Help menu gets a caret?\r\n\r\nKNOWN ISSUES:\r\n- Dropdowns in navbar (PF4 dropdowns) behave differently than dropdowns in content\r\n  * The first menu item in the dropdown is selected on opening the dropdown, so instead of a second enter press closing the dropdown, it selects the selected menu item\r\n  * The only way to close the dropdown is using the Esc key, which is problematic for mobile (i.e., there is no way to close the dropdown)\r\n  * Cannot tab out of the dropdown menu to the next keyboard focusable item\r\n- Cluster Update Available and Help icons \r\n  * are not vertically aligned (upstream bug @matthewcarleton is investigating)\r\n  * have differing default and hover colors (gray and white vs. white and gray) (upstream bug @matthewcarleton is investigating)\r\n- Long usernames do not truncate (@matthewcarleton is investigating)","created_at":"2018-12-11T20:08:15Z","updated_at":"2018-12-13T15:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a16878eac754aa46d81eb0338b94e15afebf413","assignee":null,"assignees":[],"requested_reviewers":[{"login":"josephschorr","id":4073002,"node_id":"MDQ6VXNlcjQwNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4073002?v=4","gravatar_id":"","url":"https://api.github.com/users/josephschorr","html_url":"https://github.com/josephschorr","followers_url":"https://api.github.com/users/josephschorr/followers","following_url":"https://api.github.com/users/josephschorr/following{/other_user}","gists_url":"https://api.github.com/users/josephschorr/gists{/gist_id}","starred_url":"https://api.github.com/users/josephschorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephschorr/subscriptions","organizations_url":"https://api.github.com/users/josephschorr/orgs","repos_url":"https://api.github.com/users/josephschorr/repos","events_url":"https://api.github.com/users/josephschorr/events{/privacy}","received_events_url":"https://api.github.com/users/josephschorr/received_events","type":"User","site_admin":false},{"login":"alecmerdler","id":11700385,"node_id":"MDQ6VXNlcjExNzAwMzg1","avatar_url":"https://avatars2.githubusercontent.com/u/11700385?v=4","gravatar_id":"","url":"https://api.github.com/users/alecmerdler","html_url":"https://github.com/alecmerdler","followers_url":"https://api.github.com/users/alecmerdler/followers","following_url":"https://api.github.com/users/alecmerdler/following{/other_user}","gists_url":"https://api.github.com/users/alecmerdler/gists{/gist_id}","starred_url":"https://api.github.com/users/alecmerdler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecmerdler/subscriptions","organizations_url":"https://api.github.com/users/alecmerdler/orgs","repos_url":"https://api.github.com/users/alecmerdler/repos","events_url":"https://api.github.com/users/alecmerdler/events{/privacy}","received_events_url":"https://api.github.com/users/alecmerdler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":926924641,"node_id":"MDU6TGFiZWw5MjY5MjQ2NDE=","url":"https://api.github.com/repos/openshift/console/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":926924472,"node_id":"MDU6TGFiZWw5MjY5MjQ0NzI=","url":"https://api.github.com/repos/openshift/console/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/936/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/936/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/936/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/2ed461d271b3b574cbc0f22d080cd996e17e8467","head":{"label":"rhamilto:pf4","ref":"pf4","sha":"2ed461d271b3b574cbc0f22d080cd996e17e8467","user":{"login":"rhamilto","id":895728,"node_id":"MDQ6VXNlcjg5NTcyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/895728?v=4","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"repo":{"id":133382882,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzODI4ODI=","name":"console","full_name":"rhamilto/console","private":false,"owner":{"login":"rhamilto","id":895728,"node_id":"MDQ6VXNlcjg5NTcyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/895728?v=4","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rhamilto/console","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/rhamilto/console","forks_url":"https://api.github.com/repos/rhamilto/console/forks","keys_url":"https://api.github.com/repos/rhamilto/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhamilto/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhamilto/console/teams","hooks_url":"https://api.github.com/repos/rhamilto/console/hooks","issue_events_url":"https://api.github.com/repos/rhamilto/console/issues/events{/number}","events_url":"https://api.github.com/repos/rhamilto/console/events","assignees_url":"https://api.github.com/repos/rhamilto/console/assignees{/user}","branches_url":"https://api.github.com/repos/rhamilto/console/branches{/branch}","tags_url":"https://api.github.com/repos/rhamilto/console/tags","blobs_url":"https://api.github.com/repos/rhamilto/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhamilto/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhamilto/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhamilto/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhamilto/console/statuses/{sha}","languages_url":"https://api.github.com/repos/rhamilto/console/languages","stargazers_url":"https://api.github.com/repos/rhamilto/console/stargazers","contributors_url":"https://api.github.com/repos/rhamilto/console/contributors","subscribers_url":"https://api.github.com/repos/rhamilto/console/subscribers","subscription_url":"https://api.github.com/repos/rhamilto/console/subscription","commits_url":"https://api.github.com/repos/rhamilto/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhamilto/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhamilto/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhamilto/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhamilto/console/contents/{+path}","compare_url":"https://api.github.com/repos/rhamilto/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhamilto/console/merges","archive_url":"https://api.github.com/repos/rhamilto/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhamilto/console/downloads","issues_url":"https://api.github.com/repos/rhamilto/console/issues{/number}","pulls_url":"https://api.github.com/repos/rhamilto/console/pulls{/number}","milestones_url":"https://api.github.com/repos/rhamilto/console/milestones{/number}","notifications_url":"https://api.github.com/repos/rhamilto/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhamilto/console/labels{/name}","releases_url":"https://api.github.com/repos/rhamilto/console/releases{/id}","deployments_url":"https://api.github.com/repos/rhamilto/console/deployments","created_at":"2018-05-14T15:28:44Z","updated_at":"2018-11-20T18:59:49Z","pushed_at":"2018-12-12T23:10:32Z","git_url":"git://github.com/rhamilto/console.git","ssh_url":"git@github.com:rhamilto/console.git","clone_url":"https://github.com/rhamilto/console.git","svn_url":"https://github.com/rhamilto/console","homepage":"","size":92546,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a33dadce09acea25ae8184d4ff7b104784636daa","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-12-12T19:01:25Z","pushed_at":"2018-12-13T15:11:00Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":89558,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":48,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/936"},"html":{"href":"https://github.com/openshift/console/pull/936"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/936"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/2ed461d271b3b574cbc0f22d080cd996e17e8467"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rhamilto"}}