{"action":"created","comment":{"url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/comments/191271790","pull_request_review_id":123810258,"id":191271790,"diff_hunk":"@@ -120,9 +120,9 @@ class RendererBase : public apf::MimoProcessor<Derived\n         , reference_offset_orientation(fifo)\n         , master_volume(fifo, 1)\n         , processing(fifo, true)\n-        , decay_exponent(fifo, params.get(\"decay_exponent\", 1))\n+        , decay_exponent(fifo, params.get<sample_type>(\"decay_exponent\", 1))\n         , amplitude_reference_distance(fifo\n-            , params.get(\"amplitude_reference_distance\", 3))\n+            , params.get<sample_type>(\"amplitude_reference_distance\", 3))","path":"src/rendererbase.h","position":8,"original_position":8,"commit_id":"e306f0f33f2431be19bba6b917466fd7d510da39","original_commit_id":"e306f0f33f2431be19bba6b917466fd7d510da39","user":{"login":"JensAhrens","id":6137418,"avatar_url":"https://avatars1.githubusercontent.com/u/6137418?v=4","gravatar_id":"","url":"https://api.github.com/users/JensAhrens","html_url":"https://github.com/JensAhrens","followers_url":"https://api.github.com/users/JensAhrens/followers","following_url":"https://api.github.com/users/JensAhrens/following{/other_user}","gists_url":"https://api.github.com/users/JensAhrens/gists{/gist_id}","starred_url":"https://api.github.com/users/JensAhrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensAhrens/subscriptions","organizations_url":"https://api.github.com/users/JensAhrens/orgs","repos_url":"https://api.github.com/users/JensAhrens/repos","events_url":"https://api.github.com/users/JensAhrens/events{/privacy}","received_events_url":"https://api.github.com/users/JensAhrens/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2018-05-28T21:04:28Z","updated_at":"2018-05-28T21:04:28Z","html_url":"https://github.com/SoundScapeRenderer/ssr/pull/88#discussion_r191271790","pull_request_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/comments/191271790"},"html":{"href":"https://github.com/SoundScapeRenderer/ssr/pull/88#discussion_r191271790"},"pull_request":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88","id":168531840,"html_url":"https://github.com/SoundScapeRenderer/ssr/pull/88","diff_url":"https://github.com/SoundScapeRenderer/ssr/pull/88.diff","patch_url":"https://github.com/SoundScapeRenderer/ssr/pull/88.patch","issue_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues/88","number":88,"state":"open","locked":false,"title":"Improvements for more explicit code","user":{"login":"chris-hld","id":10830393,"avatar_url":"https://avatars3.githubusercontent.com/u/10830393?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-hld","html_url":"https://github.com/chris-hld","followers_url":"https://api.github.com/users/chris-hld/followers","following_url":"https://api.github.com/users/chris-hld/following{/other_user}","gists_url":"https://api.github.com/users/chris-hld/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-hld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-hld/subscriptions","organizations_url":"https://api.github.com/users/chris-hld/orgs","repos_url":"https://api.github.com/users/chris-hld/repos","events_url":"https://api.github.com/users/chris-hld/events{/privacy}","received_events_url":"https://api.github.com/users/chris-hld/received_events","type":"User","site_admin":false},"body":"These commits improve on code that g++ deduced as intended, but other compilers might not (in this case MSVC).\r\n","created_at":"2018-02-12T09:36:27Z","updated_at":"2018-05-28T21:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aec0f223ffe7be67b0c50e5279e5fb272fde6ad2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88/commits","review_comments_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88/comments","review_comment_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues/88/comments","statuses_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/statuses/e306f0f33f2431be19bba6b917466fd7d510da39","head":{"label":"chris-hld:PR_safety","ref":"PR_safety","sha":"e306f0f33f2431be19bba6b917466fd7d510da39","user":{"login":"chris-hld","id":10830393,"avatar_url":"https://avatars3.githubusercontent.com/u/10830393?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-hld","html_url":"https://github.com/chris-hld","followers_url":"https://api.github.com/users/chris-hld/followers","following_url":"https://api.github.com/users/chris-hld/following{/other_user}","gists_url":"https://api.github.com/users/chris-hld/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-hld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-hld/subscriptions","organizations_url":"https://api.github.com/users/chris-hld/orgs","repos_url":"https://api.github.com/users/chris-hld/repos","events_url":"https://api.github.com/users/chris-hld/events{/privacy}","received_events_url":"https://api.github.com/users/chris-hld/received_events","type":"User","site_admin":false},"repo":{"id":43308148,"name":"ssr","full_name":"chris-hld/ssr","owner":{"login":"chris-hld","id":10830393,"avatar_url":"https://avatars3.githubusercontent.com/u/10830393?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-hld","html_url":"https://github.com/chris-hld","followers_url":"https://api.github.com/users/chris-hld/followers","following_url":"https://api.github.com/users/chris-hld/following{/other_user}","gists_url":"https://api.github.com/users/chris-hld/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-hld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-hld/subscriptions","organizations_url":"https://api.github.com/users/chris-hld/orgs","repos_url":"https://api.github.com/users/chris-hld/repos","events_url":"https://api.github.com/users/chris-hld/events{/privacy}","received_events_url":"https://api.github.com/users/chris-hld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-hld/ssr","description":"Main source code repository for the SoundScape Renderer","fork":true,"url":"https://api.github.com/repos/chris-hld/ssr","forks_url":"https://api.github.com/repos/chris-hld/ssr/forks","keys_url":"https://api.github.com/repos/chris-hld/ssr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-hld/ssr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-hld/ssr/teams","hooks_url":"https://api.github.com/repos/chris-hld/ssr/hooks","issue_events_url":"https://api.github.com/repos/chris-hld/ssr/issues/events{/number}","events_url":"https://api.github.com/repos/chris-hld/ssr/events","assignees_url":"https://api.github.com/repos/chris-hld/ssr/assignees{/user}","branches_url":"https://api.github.com/repos/chris-hld/ssr/branches{/branch}","tags_url":"https://api.github.com/repos/chris-hld/ssr/tags","blobs_url":"https://api.github.com/repos/chris-hld/ssr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-hld/ssr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-hld/ssr/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-hld/ssr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-hld/ssr/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-hld/ssr/languages","stargazers_url":"https://api.github.com/repos/chris-hld/ssr/stargazers","contributors_url":"https://api.github.com/repos/chris-hld/ssr/contributors","subscribers_url":"https://api.github.com/repos/chris-hld/ssr/subscribers","subscription_url":"https://api.github.com/repos/chris-hld/ssr/subscription","commits_url":"https://api.github.com/repos/chris-hld/ssr/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-hld/ssr/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-hld/ssr/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-hld/ssr/issues/comments{/number}","contents_url":"https://api.github.com/repos/chris-hld/ssr/contents/{+path}","compare_url":"https://api.github.com/repos/chris-hld/ssr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-hld/ssr/merges","archive_url":"https://api.github.com/repos/chris-hld/ssr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-hld/ssr/downloads","issues_url":"https://api.github.com/repos/chris-hld/ssr/issues{/number}","pulls_url":"https://api.github.com/repos/chris-hld/ssr/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-hld/ssr/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-hld/ssr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-hld/ssr/labels{/name}","releases_url":"https://api.github.com/repos/chris-hld/ssr/releases{/id}","deployments_url":"https://api.github.com/repos/chris-hld/ssr/deployments","created_at":"2015-09-28T15:07:33Z","updated_at":"2018-05-13T06:43:37Z","pushed_at":"2018-05-28T18:39:14Z","git_url":"git://github.com/chris-hld/ssr.git","ssh_url":"git@github.com:chris-hld/ssr.git","clone_url":"https://github.com/chris-hld/ssr.git","svn_url":"https://github.com/chris-hld/ssr","homepage":"http://spatialaudio.net/ssr/","size":16395,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"ssr-windows"}},"base":{"label":"SoundScapeRenderer:master","ref":"master","sha":"f1e49c60b54f9e85837cd579c534bfdc09833295","user":{"login":"SoundScapeRenderer","id":1996852,"avatar_url":"https://avatars1.githubusercontent.com/u/1996852?v=4","gravatar_id":"","url":"https://api.github.com/users/SoundScapeRenderer","html_url":"https://github.com/SoundScapeRenderer","followers_url":"https://api.github.com/users/SoundScapeRenderer/followers","following_url":"https://api.github.com/users/SoundScapeRenderer/following{/other_user}","gists_url":"https://api.github.com/users/SoundScapeRenderer/gists{/gist_id}","starred_url":"https://api.github.com/users/SoundScapeRenderer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoundScapeRenderer/subscriptions","organizations_url":"https://api.github.com/users/SoundScapeRenderer/orgs","repos_url":"https://api.github.com/users/SoundScapeRenderer/repos","events_url":"https://api.github.com/users/SoundScapeRenderer/events{/privacy}","received_events_url":"https://api.github.com/users/SoundScapeRenderer/received_events","type":"Organization","site_admin":false},"repo":{"id":6763817,"name":"ssr","full_name":"SoundScapeRenderer/ssr","owner":{"login":"SoundScapeRenderer","id":1996852,"avatar_url":"https://avatars1.githubusercontent.com/u/1996852?v=4","gravatar_id":"","url":"https://api.github.com/users/SoundScapeRenderer","html_url":"https://github.com/SoundScapeRenderer","followers_url":"https://api.github.com/users/SoundScapeRenderer/followers","following_url":"https://api.github.com/users/SoundScapeRenderer/following{/other_user}","gists_url":"https://api.github.com/users/SoundScapeRenderer/gists{/gist_id}","starred_url":"https://api.github.com/users/SoundScapeRenderer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoundScapeRenderer/subscriptions","organizations_url":"https://api.github.com/users/SoundScapeRenderer/orgs","repos_url":"https://api.github.com/users/SoundScapeRenderer/repos","events_url":"https://api.github.com/users/SoundScapeRenderer/events{/privacy}","received_events_url":"https://api.github.com/users/SoundScapeRenderer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SoundScapeRenderer/ssr","description":"Main source code repository for the SoundScape Renderer","fork":false,"url":"https://api.github.com/repos/SoundScapeRenderer/ssr","forks_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/forks","keys_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/teams","hooks_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/hooks","issue_events_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues/events{/number}","events_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/events","assignees_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/assignees{/user}","branches_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/branches{/branch}","tags_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/tags","blobs_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/git/refs{/sha}","trees_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/statuses/{sha}","languages_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/languages","stargazers_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/stargazers","contributors_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/contributors","subscribers_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/subscribers","subscription_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/subscription","commits_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/commits{/sha}","git_commits_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/git/commits{/sha}","comments_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/comments{/number}","issue_comment_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues/comments{/number}","contents_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/contents/{+path}","compare_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/merges","archive_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/downloads","issues_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues{/number}","pulls_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls{/number}","milestones_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/milestones{/number}","notifications_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/labels{/name}","releases_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/releases{/id}","deployments_url":"https://api.github.com/repos/SoundScapeRenderer/ssr/deployments","created_at":"2012-11-19T16:56:50Z","updated_at":"2018-05-14T21:11:54Z","pushed_at":"2018-05-28T18:39:16Z","git_url":"git://github.com/SoundScapeRenderer/ssr.git","ssh_url":"git@github.com:SoundScapeRenderer/ssr.git","clone_url":"https://github.com/SoundScapeRenderer/ssr.git","svn_url":"https://github.com/SoundScapeRenderer/ssr","homepage":"http://spatialaudio.net/ssr/","size":5403,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":32,"open_issues":50,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88"},"html":{"href":"https://github.com/SoundScapeRenderer/ssr/pull/88"},"issue":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues/88"},"comments":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/SoundScapeRenderer/ssr/statuses/e306f0f33f2431be19bba6b917466fd7d510da39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JensAhrens"}}