{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/210671142","pull_request_review_id":146936424,"id":210671142,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDY3MTE0Mg==","diff_hunk":"@@ -49,6 +53,42 @@\n public final class OkHttpClientInteropServlet extends HttpServlet {\n   private static final String INTEROP_TEST_ADDRESS = \"grpc-test.sandbox.googleapis.com:443\";\n \n+  private static final class LogEntryRecorder extends Handler {\n+    private List<LogRecord> loggedMessages = new ArrayList<LogRecord>();\n+\n+    @Override\n+    public void publish(LogRecord logRecord) {\n+      loggedMessages.add(logRecord);\n+    }\n+\n+    @Override\n+    public void flush() {}\n+\n+    @Override\n+    public void close() {}\n+\n+    public String getLogOutput() {\n+      SimpleFormatter formatter = new SimpleFormatter();\n+      StringBuilder sb = new StringBuilder();\n+      for (LogRecord loggedMessage : loggedMessages) {\n+        sb.append(formatter.format(loggedMessage));\n+      }\n+      return sb.toString();\n+    }\n+  }\n+\n+  private final LogEntryRecorder handler = new LogEntryRecorder();\n+\n+  @Override\n+  public void init() {\n+    Logger.getLogger(\"\").addHandler(handler);","path":"gae-interop-testing/gae-jdk7/src/main/java/io/grpc/testing/integration/OkHttpClientInteropServlet.java","position":null,"original_position":43,"commit_id":"466af80ca552d105e4b949ae4fa552d817089fb5","original_commit_id":"eec340fea17061fff5385913e62ee631a7411bd1","user":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"I was thinking this is fine for the narrow use case of this servlet, but now I realize the HTTP request may be retried and we don't care about previous entries. I'll do it naively here instead of using the fancier servlet APIs.","created_at":"2018-08-16T17:04:14Z","updated_at":"2018-08-16T17:04:14Z","html_url":"https://github.com/grpc/grpc-java/pull/4765#discussion_r210671142","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4765","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/210671142"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4765#discussion_r210671142"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4765"}},"in_reply_to_id":210648772},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4765","id":208701408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzAxNDA4","html_url":"https://github.com/grpc/grpc-java/pull/4765","diff_url":"https://github.com/grpc/grpc-java/pull/4765.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4765.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4765","number":4765,"state":"open","locked":false,"title":"gae-interop-testing: increase response verbosity","user":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"for jdk7 include the passing test names in the order they were run\r\nfor both, include the JUL log output","created_at":"2018-08-15T22:43:05Z","updated_at":"2018-08-16T17:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9844d1d84f53476f2d24c06bbabe903db33c504d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4765/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4765/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4765/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/466af80ca552d105e4b949ae4fa552d817089fb5","head":{"label":"zpencer:gae-include-jul-in-http-response","ref":"gae-include-jul-in-http-response","sha":"466af80ca552d105e4b949ae4fa552d817089fb5","user":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"repo":{"id":89497167,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ5NzE2Nw==","name":"grpc-java","full_name":"zpencer/grpc-java","owner":{"login":"zpencer","id":2819812,"node_id":"MDQ6VXNlcjI4MTk4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zpencer/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/zpencer/grpc-java","forks_url":"https://api.github.com/repos/zpencer/grpc-java/forks","keys_url":"https://api.github.com/repos/zpencer/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zpencer/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zpencer/grpc-java/teams","hooks_url":"https://api.github.com/repos/zpencer/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/zpencer/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/zpencer/grpc-java/events","assignees_url":"https://api.github.com/repos/zpencer/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/zpencer/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/zpencer/grpc-java/tags","blobs_url":"https://api.github.com/repos/zpencer/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zpencer/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zpencer/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/zpencer/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zpencer/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/zpencer/grpc-java/languages","stargazers_url":"https://api.github.com/repos/zpencer/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/zpencer/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/zpencer/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/zpencer/grpc-java/subscription","commits_url":"https://api.github.com/repos/zpencer/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/zpencer/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/zpencer/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/zpencer/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/zpencer/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/zpencer/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zpencer/grpc-java/merges","archive_url":"https://api.github.com/repos/zpencer/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zpencer/grpc-java/downloads","issues_url":"https://api.github.com/repos/zpencer/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/zpencer/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/zpencer/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/zpencer/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zpencer/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/zpencer/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/zpencer/grpc-java/deployments","created_at":"2017-04-26T15:28:10Z","updated_at":"2017-04-26T15:28:13Z","pushed_at":"2018-08-16T17:00:46Z","git_url":"git://github.com/zpencer/grpc-java.git","ssh_url":"git@github.com:zpencer/grpc-java.git","clone_url":"https://github.com/zpencer/grpc-java.git","svn_url":"https://github.com/zpencer/grpc-java","homepage":"http://grpc.io","size":23294,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"3792242ae11ad9a4992ea551629fe108be128d87","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkyNg==","name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-08-16T09:40:02Z","pushed_at":"2018-08-16T17:00:48Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":26093,"stargazers_count":4696,"watchers_count":4696,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1519,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1519,"open_issues":369,"watchers":4696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4765"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4765"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4765"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4765/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4765/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4765/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/466af80ca552d105e4b949ae4fa552d817089fb5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zpencer"}}