{"action":"created","issue":{"url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/344","repository_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD","labels_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/344/comments","events_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/344/events","html_url":"https://github.com/MusicPlayerDaemon/MPD/issues/344","id":352777203,"node_id":"MDU6SXNzdWUzNTI3NzcyMDM=","number":344,"title":"opustags issues (stream finish at song change, duplicated metadata)","user":{"login":"JustArchi","id":1069029,"node_id":"MDQ6VXNlcjEwNjkwMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1069029?v=4","gravatar_id":"","url":"https://api.github.com/users/JustArchi","html_url":"https://github.com/JustArchi","followers_url":"https://api.github.com/users/JustArchi/followers","following_url":"https://api.github.com/users/JustArchi/following{/other_user}","gists_url":"https://api.github.com/users/JustArchi/gists{/gist_id}","starred_url":"https://api.github.com/users/JustArchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustArchi/subscriptions","organizations_url":"https://api.github.com/users/JustArchi/orgs","repos_url":"https://api.github.com/users/JustArchi/repos","events_url":"https://api.github.com/users/JustArchi/events{/privacy}","received_events_url":"https://api.github.com/users/JustArchi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-22T02:21:38Z","updated_at":"2018-08-26T12:04:09Z","closed_at":null,"author_association":"NONE","body":"Hi again.\r\n\r\nThis issue is very strongly connected with https://github.com/MusicPlayerDaemon/MPD/issues/70 and PR #205.\r\n\r\nI've compiled MPD from source and the feature works excellent. Metadata are nicely updated on song change and initial play, I've confirmed their availability using VLC client.\r\n\r\nThere are just two issues I've found that do not exist when `opustags` is turned off (`false`).\r\n\r\nWhen listening to opus icecast2 stream through Chrome web browser, the stream ends when the song changes, either naturally or with something like `mpc next`. So far I've reproduced it only with Chrome, as there is no such issue when using Firefox or VLC. Chrome stream also works properly when not using `opustags` feature. As you can guess, you can immediately re-start the stream after song change and it'll work properly - until the next song change.\r\n\r\nI'm not entirely sure if this is some specific Chrome behaviour that perhaps is worth reporting upstream, or MPD is updating metadata in some non-standard way that causes the stream to finish. I'd appreciate if you could take a look into this and forward the issue if needed.\r\n\r\nSecond issue that I've also noticed includes certain metadata being duplicated, in particular title, artist, album and genre. Perhaps MPD is somehow sending metadata update to icecast twice? I recall @MaxKellermann mentioning that MPD tries to update metadata also through icecast call, but it wasn't working in the past, perhaps it's doubled now together with chained metadata? I reproduced this one with VLC and foobar2000, web browsers do not really want to display what is being transmitted so I'm not sure.\r\n\r\n![vlc](https://user-images.githubusercontent.com/1069029/44439003-12a76980-a5c2-11e8-9de4-f448d4f30706.png)\r\n\r\nSadly I'm not skilled enough to look into either of those myself, so I'm leaving this issue open if perhaps somebody would be interested in digging deeper. Thank you in advance for looking into this, despite of that I'm loving metadata updates on my opus stream.\r\n\r\nCC @cathugger\r\n\r\n```\r\nMusic Player Daemon 0.21 (9151b84)\r\n```"},"comment":{"url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/comments/416034035","html_url":"https://github.com/MusicPlayerDaemon/MPD/issues/344#issuecomment-416034035","issue_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/344","id":416034035,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjAzNDAzNQ==","user":{"login":"cathugger","id":26472432,"node_id":"MDQ6VXNlcjI2NDcyNDMy","avatar_url":"https://avatars3.githubusercontent.com/u/26472432?v=4","gravatar_id":"","url":"https://api.github.com/users/cathugger","html_url":"https://github.com/cathugger","followers_url":"https://api.github.com/users/cathugger/followers","following_url":"https://api.github.com/users/cathugger/following{/other_user}","gists_url":"https://api.github.com/users/cathugger/gists{/gist_id}","starred_url":"https://api.github.com/users/cathugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathugger/subscriptions","organizations_url":"https://api.github.com/users/cathugger/orgs","repos_url":"https://api.github.com/users/cathugger/repos","events_url":"https://api.github.com/users/cathugger/events{/privacy}","received_events_url":"https://api.github.com/users/cathugger/received_events","type":"User","site_admin":false},"created_at":"2018-08-26T12:04:09Z","updated_at":"2018-08-26T12:04:09Z","author_association":"CONTRIBUTOR","body":"Oh, apparently you have no trouble with VLC. That's nicer than what I've experienced. Maybe they improved their stuff.\r\nAs for chrome, I guess they haven't tested for this case in their code. Or they use ffmpeg's code which isn't ready for this...\r\nActually I remember looking into MPD's decoder and it isn't designed to handle this either. Maybe I should bring myself to fix that sometime."}}
{"actor":{"display_login":"cathugger"}}