{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-web/pulls/comments/232455735","pull_request_review_id":173665171,"id":232455735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ1NTczNQ==","diff_hunk":"@@ -195,10 +195,10 @@ const GrpcWebClientReadableStream = function(genericTransportInterface) {\n     }\n     var responseHeaders = self.xhr_.getResponseHeaders();","path":"javascript/net/grpc/web/grpcwebclientreadablestream.js","position":2,"original_position":2,"commit_id":"2de76c62dbb9d8bcc00aa45149463042b1b5ecdf","original_commit_id":"2de76c62dbb9d8bcc00aa45149463042b1b5ecdf","user":{"login":"mitar","id":585279,"node_id":"MDQ6VXNlcjU4NTI3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/585279?v=4","gravatar_id":"","url":"https://api.github.com/users/mitar","html_url":"https://github.com/mitar","followers_url":"https://api.github.com/users/mitar/followers","following_url":"https://api.github.com/users/mitar/following{/other_user}","gists_url":"https://api.github.com/users/mitar/gists{/gist_id}","starred_url":"https://api.github.com/users/mitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitar/subscriptions","organizations_url":"https://api.github.com/users/mitar/orgs","repos_url":"https://api.github.com/users/mitar/repos","events_url":"https://api.github.com/users/mitar/events{/privacy}","received_events_url":"https://api.github.com/users/mitar/received_events","type":"User","site_admin":false},"body":"Why even use `getResponseHeaders` at all?","created_at":"2018-11-10T15:41:07Z","updated_at":"2018-11-10T15:41:07Z","html_url":"https://github.com/grpc/grpc-web/pull/365#discussion_r232455735","pull_request_url":"https://api.github.com/repos/grpc/grpc-web/pulls/365","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-web/pulls/comments/232455735"},"html":{"href":"https://github.com/grpc/grpc-web/pull/365#discussion_r232455735"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-web/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-web/pulls/365","id":229875959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODc1OTU5","html_url":"https://github.com/grpc/grpc-web/pull/365","diff_url":"https://github.com/grpc/grpc-web/pull/365.diff","patch_url":"https://github.com/grpc/grpc-web/pull/365.patch","issue_url":"https://api.github.com/repos/grpc/grpc-web/issues/365","number":365,"state":"closed","locked":false,"title":"Fix response header value with colon","user":{"login":"stanley-cheung","id":11674202,"node_id":"MDQ6VXNlcjExNjc0MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/11674202?v=4","gravatar_id":"","url":"https://api.github.com/users/stanley-cheung","html_url":"https://github.com/stanley-cheung","followers_url":"https://api.github.com/users/stanley-cheung/followers","following_url":"https://api.github.com/users/stanley-cheung/following{/other_user}","gists_url":"https://api.github.com/users/stanley-cheung/gists{/gist_id}","starred_url":"https://api.github.com/users/stanley-cheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanley-cheung/subscriptions","organizations_url":"https://api.github.com/users/stanley-cheung/orgs","repos_url":"https://api.github.com/users/stanley-cheung/repos","events_url":"https://api.github.com/users/stanley-cheung/events{/privacy}","received_events_url":"https://api.github.com/users/stanley-cheung/received_events","type":"User","site_admin":false},"body":"Fixes #318.\r\n\r\nVery strange, let's say we have this response header `grpc-message: Foo: Bar` sent back from gRPC backend service, and thru Envoy, from the browser console, the header value apparently was sent back properly.\r\n\r\nBut, if I call `xhr.getResponseHeaders()` to get the whole bag of response headers, one of the key:value pair was `grpc-message: Foo`.\r\n\r\nOTOH, if I call `xhr.getResponseHeader('grpc-message')`, I get `Foo: Bar` back properly.\r\n\r\nI couldn't find a bug from Chrome or Closure to report this strange behavior with `xhr.getResponseHeaders()`.\r\n\r\nAlso OTOH, I cannot find any HTTP spec that said that http header value cannot have a colon in it. So apparently it's OK to have header value that has a colon in it.","created_at":"2018-11-10T07:28:22Z","updated_at":"2018-11-10T15:41:07Z","closed_at":"2018-11-10T07:56:22Z","merged_at":"2018-11-10T07:56:21Z","merge_commit_sha":"def314aec4d7cb5dfbbbeb65da5d859f8170c62e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-web/pulls/365/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-web/pulls/365/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-web/issues/365/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-web/statuses/2de76c62dbb9d8bcc00aa45149463042b1b5ecdf","head":{"label":"stanley-cheung:fix-response-header","ref":"fix-response-header","sha":"2de76c62dbb9d8bcc00aa45149463042b1b5ecdf","user":{"login":"stanley-cheung","id":11674202,"node_id":"MDQ6VXNlcjExNjc0MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/11674202?v=4","gravatar_id":"","url":"https://api.github.com/users/stanley-cheung","html_url":"https://github.com/stanley-cheung","followers_url":"https://api.github.com/users/stanley-cheung/followers","following_url":"https://api.github.com/users/stanley-cheung/following{/other_user}","gists_url":"https://api.github.com/users/stanley-cheung/gists{/gist_id}","starred_url":"https://api.github.com/users/stanley-cheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanley-cheung/subscriptions","organizations_url":"https://api.github.com/users/stanley-cheung/orgs","repos_url":"https://api.github.com/users/stanley-cheung/repos","events_url":"https://api.github.com/users/stanley-cheung/events{/privacy}","received_events_url":"https://api.github.com/users/stanley-cheung/received_events","type":"User","site_admin":false},"repo":{"id":126415236,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY0MTUyMzY=","name":"grpc-web","full_name":"stanley-cheung/grpc-web","private":false,"owner":{"login":"stanley-cheung","id":11674202,"node_id":"MDQ6VXNlcjExNjc0MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/11674202?v=4","gravatar_id":"","url":"https://api.github.com/users/stanley-cheung","html_url":"https://github.com/stanley-cheung","followers_url":"https://api.github.com/users/stanley-cheung/followers","following_url":"https://api.github.com/users/stanley-cheung/following{/other_user}","gists_url":"https://api.github.com/users/stanley-cheung/gists{/gist_id}","starred_url":"https://api.github.com/users/stanley-cheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanley-cheung/subscriptions","organizations_url":"https://api.github.com/users/stanley-cheung/orgs","repos_url":"https://api.github.com/users/stanley-cheung/repos","events_url":"https://api.github.com/users/stanley-cheung/events{/privacy}","received_events_url":"https://api.github.com/users/stanley-cheung/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stanley-cheung/grpc-web","description":"gRPC for Web Clients","fork":true,"url":"https://api.github.com/repos/stanley-cheung/grpc-web","forks_url":"https://api.github.com/repos/stanley-cheung/grpc-web/forks","keys_url":"https://api.github.com/repos/stanley-cheung/grpc-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stanley-cheung/grpc-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stanley-cheung/grpc-web/teams","hooks_url":"https://api.github.com/repos/stanley-cheung/grpc-web/hooks","issue_events_url":"https://api.github.com/repos/stanley-cheung/grpc-web/issues/events{/number}","events_url":"https://api.github.com/repos/stanley-cheung/grpc-web/events","assignees_url":"https://api.github.com/repos/stanley-cheung/grpc-web/assignees{/user}","branches_url":"https://api.github.com/repos/stanley-cheung/grpc-web/branches{/branch}","tags_url":"https://api.github.com/repos/stanley-cheung/grpc-web/tags","blobs_url":"https://api.github.com/repos/stanley-cheung/grpc-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stanley-cheung/grpc-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stanley-cheung/grpc-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/stanley-cheung/grpc-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stanley-cheung/grpc-web/statuses/{sha}","languages_url":"https://api.github.com/repos/stanley-cheung/grpc-web/languages","stargazers_url":"https://api.github.com/repos/stanley-cheung/grpc-web/stargazers","contributors_url":"https://api.github.com/repos/stanley-cheung/grpc-web/contributors","subscribers_url":"https://api.github.com/repos/stanley-cheung/grpc-web/subscribers","subscription_url":"https://api.github.com/repos/stanley-cheung/grpc-web/subscription","commits_url":"https://api.github.com/repos/stanley-cheung/grpc-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/stanley-cheung/grpc-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/stanley-cheung/grpc-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/stanley-cheung/grpc-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/stanley-cheung/grpc-web/contents/{+path}","compare_url":"https://api.github.com/repos/stanley-cheung/grpc-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stanley-cheung/grpc-web/merges","archive_url":"https://api.github.com/repos/stanley-cheung/grpc-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stanley-cheung/grpc-web/downloads","issues_url":"https://api.github.com/repos/stanley-cheung/grpc-web/issues{/number}","pulls_url":"https://api.github.com/repos/stanley-cheung/grpc-web/pulls{/number}","milestones_url":"https://api.github.com/repos/stanley-cheung/grpc-web/milestones{/number}","notifications_url":"https://api.github.com/repos/stanley-cheung/grpc-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stanley-cheung/grpc-web/labels{/name}","releases_url":"https://api.github.com/repos/stanley-cheung/grpc-web/releases{/id}","deployments_url":"https://api.github.com/repos/stanley-cheung/grpc-web/deployments","created_at":"2018-03-23T01:23:12Z","updated_at":"2018-11-10T06:06:31Z","pushed_at":"2018-11-10T07:23:47Z","git_url":"git://github.com/stanley-cheung/grpc-web.git","ssh_url":"git@github.com:stanley-cheung/grpc-web.git","clone_url":"https://github.com/stanley-cheung/grpc-web.git","svn_url":"https://github.com/stanley-cheung/grpc-web","homepage":"http://grpc.io","size":544,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"f28d6cb9ed3642072085736742e07d85e8ea6ca9","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":61567304,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU2NzMwNA==","name":"grpc-web","full_name":"grpc/grpc-web","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc-web","description":"gRPC for Web Clients","fork":false,"url":"https://api.github.com/repos/grpc/grpc-web","forks_url":"https://api.github.com/repos/grpc/grpc-web/forks","keys_url":"https://api.github.com/repos/grpc/grpc-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-web/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-web/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-web/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-web/events","assignees_url":"https://api.github.com/repos/grpc/grpc-web/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-web/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-web/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-web/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-web/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-web/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-web/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-web/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-web/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-web/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-web/merges","archive_url":"https://api.github.com/repos/grpc/grpc-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-web/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-web/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-web/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-web/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-web/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-web/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-web/deployments","created_at":"2016-06-20T17:34:33Z","updated_at":"2018-11-10T14:38:46Z","pushed_at":"2018-11-10T14:00:09Z","git_url":"git://github.com/grpc/grpc-web.git","ssh_url":"git@github.com:grpc/grpc-web.git","clone_url":"https://github.com/grpc/grpc-web.git","svn_url":"https://github.com/grpc/grpc-web","homepage":"http://grpc.io","size":541,"stargazers_count":1681,"watchers_count":1681,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":89,"open_issues":41,"watchers":1681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-web/pulls/365"},"html":{"href":"https://github.com/grpc/grpc-web/pull/365"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-web/issues/365"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-web/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-web/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-web/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-web/statuses/2de76c62dbb9d8bcc00aa45149463042b1b5ecdf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mitar"}}