{"action":"created","issue":{"url":"https://api.github.com/repos/JasperFx/marten/issues/1088","repository_url":"https://api.github.com/repos/JasperFx/marten","labels_url":"https://api.github.com/repos/JasperFx/marten/issues/1088/labels{/name}","comments_url":"https://api.github.com/repos/JasperFx/marten/issues/1088/comments","events_url":"https://api.github.com/repos/JasperFx/marten/issues/1088/events","html_url":"https://github.com/JasperFx/marten/pull/1088","id":360273718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTcwMDE2","number":1088,"title":"Refactor and simplify the PagedList implementation","user":{"login":"mysticmind","id":2864208,"node_id":"MDQ6VXNlcjI4NjQyMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2864208?v=4","gravatar_id":"","url":"https://api.github.com/users/mysticmind","html_url":"https://github.com/mysticmind","followers_url":"https://api.github.com/users/mysticmind/followers","following_url":"https://api.github.com/users/mysticmind/following{/other_user}","gists_url":"https://api.github.com/users/mysticmind/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticmind/subscriptions","organizations_url":"https://api.github.com/users/mysticmind/orgs","repos_url":"https://api.github.com/users/mysticmind/repos","events_url":"https://api.github.com/users/mysticmind/events{/privacy}","received_events_url":"https://api.github.com/users/mysticmind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-14T11:52:40Z","updated_at":"2018-09-17T08:17:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JasperFx/marten/pulls/1088","html_url":"https://github.com/JasperFx/marten/pull/1088","diff_url":"https://github.com/JasperFx/marten/pull/1088.diff","patch_url":"https://github.com/JasperFx/marten/pull/1088.patch"},"body":"- Refactor and simplify the PagedList implementation to use\r\nQueryStatistics to use single db query GH-930\r\n- BREAKING CHANGE: AsPagedList and AsPagedListAsync IQueryable<T> is\r\nchanged to IMartenQueryable\r\n- BREAKING CHANGE: some of the properties in IPagedList<T> has change been\r\nchanged from int to long\r\n- Update unit tests"},"comment":{"url":"https://api.github.com/repos/JasperFx/marten/issues/comments/421923786","html_url":"https://github.com/JasperFx/marten/pull/1088#issuecomment-421923786","issue_url":"https://api.github.com/repos/JasperFx/marten/issues/1088","id":421923786,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTkyMzc4Ng==","user":{"login":"kasparkallas","id":10894666,"node_id":"MDQ6VXNlcjEwODk0NjY2","avatar_url":"https://avatars1.githubusercontent.com/u/10894666?v=4","gravatar_id":"","url":"https://api.github.com/users/kasparkallas","html_url":"https://github.com/kasparkallas","followers_url":"https://api.github.com/users/kasparkallas/followers","following_url":"https://api.github.com/users/kasparkallas/following{/other_user}","gists_url":"https://api.github.com/users/kasparkallas/gists{/gist_id}","starred_url":"https://api.github.com/users/kasparkallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasparkallas/subscriptions","organizations_url":"https://api.github.com/users/kasparkallas/orgs","repos_url":"https://api.github.com/users/kasparkallas/repos","events_url":"https://api.github.com/users/kasparkallas/events{/privacy}","received_events_url":"https://api.github.com/users/kasparkallas/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T08:17:15Z","updated_at":"2018-09-17T08:17:15Z","author_association":"NONE","body":"I believe the more correct name for the method is \"ToPagedList\" instead of \"AsPagedList\" because it executes the queryable and transfers the result to a new collection. Using \"AsSomething\" is more suitable for methods that keep the original object reference and cast it to a different shape (like \"AsQueryable\" and \"AsEnumerable\"), as far as I know."}}
{"actor":{"display_login":"kasparkallas"}}