{"action":"created","issue":{"url":"https://api.github.com/repos/theia-ide/theia/issues/1725","repository_url":"https://api.github.com/repos/theia-ide/theia","labels_url":"https://api.github.com/repos/theia-ide/theia/issues/1725/labels{/name}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/1725/comments","events_url":"https://api.github.com/repos/theia-ide/theia/issues/1725/events","html_url":"https://github.com/theia-ide/theia/pull/1725","id":315370806,"number":1725,"title":"Misc fixes related to @theia/java","user":{"login":"AlexTugarev","id":914497,"avatar_url":"https://avatars3.githubusercontent.com/u/914497?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexTugarev","html_url":"https://github.com/AlexTugarev","followers_url":"https://api.github.com/users/AlexTugarev/followers","following_url":"https://api.github.com/users/AlexTugarev/following{/other_user}","gists_url":"https://api.github.com/users/AlexTugarev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexTugarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexTugarev/subscriptions","organizations_url":"https://api.github.com/users/AlexTugarev/orgs","repos_url":"https://api.github.com/users/AlexTugarev/repos","events_url":"https://api.github.com/users/AlexTugarev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexTugarev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-18T07:58:22Z","updated_at":"2018-04-19T07:53:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/1725","html_url":"https://github.com/theia-ide/theia/pull/1725","diff_url":"https://github.com/theia-ide/theia/pull/1725.diff","patch_url":"https://github.com/theia-ide/theia/pull/1725.patch"},"body":"This PR resolves following issues\r\n\r\n1. JDT LS tries to register `java.edit.organizeImports` command, which is already done in [java-commands.ts](https://github.com/theia-ide/theia/blob/574236ee83e8bb1a6c31011ac7fc73876cc81a0c/packages/java/src/browser/java-commands.ts#L60)\r\n1. on reload with opened java editor, many rejected promise errors from `monaco-outline-contribution.ts` were logged.\r\n* it happened due to frequent calls of [updateOutline](https://github.com/theia-ide/theia/blob/947a7e79ddbdbf69d87d0e24f7acfaa290d223db/packages/monaco/src/browser/monaco-outline-contribution.ts#L69)\r\n* call of [`provideDocumentSymbols`](https://github.com/theia-ide/theia/blob/947a7e79ddbdbf69d87d0e24f7acfaa290d223db/packages/monaco/src/browser/monaco-outline-contribution.ts#L105-L116) throws with rejected promise errors on cancellation"},"comment":{"url":"https://api.github.com/repos/theia-ide/theia/issues/comments/382644314","html_url":"https://github.com/theia-ide/theia/pull/1725#issuecomment-382644314","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/1725","id":382644314,"user":{"login":"AlexTugarev","id":914497,"avatar_url":"https://avatars3.githubusercontent.com/u/914497?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexTugarev","html_url":"https://github.com/AlexTugarev","followers_url":"https://api.github.com/users/AlexTugarev/followers","following_url":"https://api.github.com/users/AlexTugarev/following{/other_user}","gists_url":"https://api.github.com/users/AlexTugarev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexTugarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexTugarev/subscriptions","organizations_url":"https://api.github.com/users/AlexTugarev/orgs","repos_url":"https://api.github.com/users/AlexTugarev/repos","events_url":"https://api.github.com/users/AlexTugarev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexTugarev/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T07:53:06Z","updated_at":"2018-04-19T07:53:06Z","author_association":"MEMBER","body":"@akosyakov could you have a look at the commands whenever possible?\r\n\r\nalso, if you see more to consider with that change to commands, I'll splitt that PR. the changes to outline are actually a different story."}}
{"actor":{"display_login":"AlexTugarev"}}