{"action":"created","comment":{"url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments/191008671","pull_request_review_id":123511935,"id":191008671,"diff_hunk":"@@ -2105,6 +2105,28 @@ xboxkrnl::NTSTATUS VMManager::XbVirtualMemoryStatistics(VAddr addr, xboxkrnl::PM\n \t\treturn STATUS_INVALID_PARAMETER;\n \t}\n \n+\t// If it's not in the XBE, report actual host allocations","path":"src/CxbxKrnl/VMManager.cpp","position":4,"original_position":4,"commit_id":"006b49937c18258c003fa74a8a04922f2b6d4fb1","original_commit_id":"006b49937c18258c003fa74a8a04922f2b6d4fb1","user":{"login":"LukeUsher","id":740003,"avatar_url":"https://avatars2.githubusercontent.com/u/740003?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeUsher","html_url":"https://github.com/LukeUsher","followers_url":"https://api.github.com/users/LukeUsher/followers","following_url":"https://api.github.com/users/LukeUsher/following{/other_user}","gists_url":"https://api.github.com/users/LukeUsher/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeUsher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeUsher/subscriptions","organizations_url":"https://api.github.com/users/LukeUsher/orgs","repos_url":"https://api.github.com/users/LukeUsher/repos","events_url":"https://api.github.com/users/LukeUsher/events{/privacy}","received_events_url":"https://api.github.com/users/LukeUsher/received_events","type":"User","site_admin":false},"body":"There is no need: The Lock is to prevent multiple threads accessing our Page Table structure simultaniously, however, VirtualQuery is not effected by this.\r\n\r\nThe race condition Ergo720 mentioned is that another thread could allocate memory at any point after VirtualQuery is called, but there's nothing we can do about that at the moment. ","created_at":"2018-05-25T21:00:53Z","updated_at":"2018-05-25T21:00:53Z","html_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1205#discussion_r191008671","pull_request_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments/191008671"},"html":{"href":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1205#discussion_r191008671"},"pull_request":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205"}},"in_reply_to_id":190954569},"pull_request":{"url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205","id":190586061,"html_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1205","diff_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1205.diff","patch_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1205.patch","issue_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1205","number":1205,"state":"open","locked":false,"title":"QueryMemory reports host allocated memory","user":{"login":"jagotu","id":2465633,"avatar_url":"https://avatars2.githubusercontent.com/u/2465633?v=4","gravatar_id":"","url":"https://api.github.com/users/jagotu","html_url":"https://github.com/jagotu","followers_url":"https://api.github.com/users/jagotu/followers","following_url":"https://api.github.com/users/jagotu/following{/other_user}","gists_url":"https://api.github.com/users/jagotu/gists{/gist_id}","starred_url":"https://api.github.com/users/jagotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagotu/subscriptions","organizations_url":"https://api.github.com/users/jagotu/orgs","repos_url":"https://api.github.com/users/jagotu/repos","events_url":"https://api.github.com/users/jagotu/events{/privacy}","received_events_url":"https://api.github.com/users/jagotu/received_events","type":"User","site_admin":false},"body":"**Do not merge yet**\r\n\r\nContinuing from discussion on #1201.\r\n\r\nWith this fix QueryMemory reports the true (host) state of VirtualMemory when queried instead of marking it as FREE. A game might be surprised by all the occupied memory, but if it's correctly written, it will not try to allocate the occupied memory and therefore will not crash.\r\n\r\nCase in point: With this fix, Splinter Cell - Double Agent boots.\r\n\r\nPlease, test this for regressions in other games and discuss.","created_at":"2018-05-25T13:18:46Z","updated_at":"2018-05-25T21:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"221ff3ae4bff771237c900279e57102bb3569669","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205/commits","review_comments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205/comments","review_comment_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1205/comments","statuses_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/statuses/006b49937c18258c003fa74a8a04922f2b6d4fb1","head":{"label":"jagotu:master","ref":"master","sha":"006b49937c18258c003fa74a8a04922f2b6d4fb1","user":{"login":"jagotu","id":2465633,"avatar_url":"https://avatars2.githubusercontent.com/u/2465633?v=4","gravatar_id":"","url":"https://api.github.com/users/jagotu","html_url":"https://github.com/jagotu","followers_url":"https://api.github.com/users/jagotu/followers","following_url":"https://api.github.com/users/jagotu/following{/other_user}","gists_url":"https://api.github.com/users/jagotu/gists{/gist_id}","starred_url":"https://api.github.com/users/jagotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagotu/subscriptions","organizations_url":"https://api.github.com/users/jagotu/orgs","repos_url":"https://api.github.com/users/jagotu/repos","events_url":"https://api.github.com/users/jagotu/events{/privacy}","received_events_url":"https://api.github.com/users/jagotu/received_events","type":"User","site_admin":false},"repo":{"id":134006595,"name":"Cxbx-Reloaded","full_name":"jagotu/Cxbx-Reloaded","owner":{"login":"jagotu","id":2465633,"avatar_url":"https://avatars2.githubusercontent.com/u/2465633?v=4","gravatar_id":"","url":"https://api.github.com/users/jagotu","html_url":"https://github.com/jagotu","followers_url":"https://api.github.com/users/jagotu/followers","following_url":"https://api.github.com/users/jagotu/following{/other_user}","gists_url":"https://api.github.com/users/jagotu/gists{/gist_id}","starred_url":"https://api.github.com/users/jagotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagotu/subscriptions","organizations_url":"https://api.github.com/users/jagotu/orgs","repos_url":"https://api.github.com/users/jagotu/repos","events_url":"https://api.github.com/users/jagotu/events{/privacy}","received_events_url":"https://api.github.com/users/jagotu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagotu/Cxbx-Reloaded","description":"Xbox (Original) Emulator","fork":true,"url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded","forks_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/forks","keys_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/teams","hooks_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/hooks","issue_events_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/issues/events{/number}","events_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/events","assignees_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/assignees{/user}","branches_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/branches{/branch}","tags_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/tags","blobs_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/statuses/{sha}","languages_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/languages","stargazers_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/stargazers","contributors_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/contributors","subscribers_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/subscribers","subscription_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/subscription","commits_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/contents/{+path}","compare_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/merges","archive_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/downloads","issues_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/issues{/number}","pulls_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/pulls{/number}","milestones_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/milestones{/number}","notifications_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/labels{/name}","releases_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/releases{/id}","deployments_url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/deployments","created_at":"2018-05-18T21:38:41Z","updated_at":"2018-05-25T13:15:47Z","pushed_at":"2018-05-25T13:15:45Z","git_url":"git://github.com/jagotu/Cxbx-Reloaded.git","ssh_url":"git@github.com:jagotu/Cxbx-Reloaded.git","clone_url":"https://github.com/jagotu/Cxbx-Reloaded.git","svn_url":"https://github.com/jagotu/Cxbx-Reloaded","homepage":"","size":62513,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Cxbx-Reloaded:master","ref":"master","sha":"aaf6579c45e10c933f7b1106732a60a3bd1fe74c","user":{"login":"Cxbx-Reloaded","id":24608560,"avatar_url":"https://avatars1.githubusercontent.com/u/24608560?v=4","gravatar_id":"","url":"https://api.github.com/users/Cxbx-Reloaded","html_url":"https://github.com/Cxbx-Reloaded","followers_url":"https://api.github.com/users/Cxbx-Reloaded/followers","following_url":"https://api.github.com/users/Cxbx-Reloaded/following{/other_user}","gists_url":"https://api.github.com/users/Cxbx-Reloaded/gists{/gist_id}","starred_url":"https://api.github.com/users/Cxbx-Reloaded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cxbx-Reloaded/subscriptions","organizations_url":"https://api.github.com/users/Cxbx-Reloaded/orgs","repos_url":"https://api.github.com/users/Cxbx-Reloaded/repos","events_url":"https://api.github.com/users/Cxbx-Reloaded/events{/privacy}","received_events_url":"https://api.github.com/users/Cxbx-Reloaded/received_events","type":"Organization","site_admin":false},"repo":{"id":55772388,"name":"Cxbx-Reloaded","full_name":"Cxbx-Reloaded/Cxbx-Reloaded","owner":{"login":"Cxbx-Reloaded","id":24608560,"avatar_url":"https://avatars1.githubusercontent.com/u/24608560?v=4","gravatar_id":"","url":"https://api.github.com/users/Cxbx-Reloaded","html_url":"https://github.com/Cxbx-Reloaded","followers_url":"https://api.github.com/users/Cxbx-Reloaded/followers","following_url":"https://api.github.com/users/Cxbx-Reloaded/following{/other_user}","gists_url":"https://api.github.com/users/Cxbx-Reloaded/gists{/gist_id}","starred_url":"https://api.github.com/users/Cxbx-Reloaded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cxbx-Reloaded/subscriptions","organizations_url":"https://api.github.com/users/Cxbx-Reloaded/orgs","repos_url":"https://api.github.com/users/Cxbx-Reloaded/repos","events_url":"https://api.github.com/users/Cxbx-Reloaded/events{/privacy}","received_events_url":"https://api.github.com/users/Cxbx-Reloaded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded","description":"Xbox (Original) Emulator","fork":false,"url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded","forks_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/forks","keys_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/teams","hooks_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/hooks","issue_events_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/events{/number}","events_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/events","assignees_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/assignees{/user}","branches_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/branches{/branch}","tags_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/tags","blobs_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/statuses/{sha}","languages_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/languages","stargazers_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/stargazers","contributors_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/contributors","subscribers_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/subscribers","subscription_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/subscription","commits_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/contents/{+path}","compare_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/merges","archive_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/downloads","issues_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues{/number}","pulls_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls{/number}","milestones_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/milestones{/number}","notifications_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/labels{/name}","releases_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/releases{/id}","deployments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/deployments","created_at":"2016-04-08T10:56:52Z","updated_at":"2018-05-25T06:57:51Z","pushed_at":"2018-05-25T16:00:13Z","git_url":"git://github.com/Cxbx-Reloaded/Cxbx-Reloaded.git","ssh_url":"git@github.com:Cxbx-Reloaded/Cxbx-Reloaded.git","clone_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded.git","svn_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded","homepage":"","size":62512,"stargazers_count":539,"watchers_count":539,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":88,"open_issues":130,"watchers":539,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205"},"html":{"href":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1205"},"issue":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1205"},"comments":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1205/comments"},"review_comments":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205/comments"},"review_comment":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1205/commits"},"statuses":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/statuses/006b49937c18258c003fa74a8a04922f2b6d4fb1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LukeUsher"}}