{"push_id":2550905625,"size":101,"distinct_size":12,"ref":"refs/heads/esm-builtin-module-namespaces","head":"60227389a317a2b79087d914ce9328ed19813694","before":"d81d44d02b3c08dfb33bbbeb8536d2730ac095b9","commits":[{"sha":"bdf5be98dd901f6c312938198439dbda0b20d517","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"n-api: test and doc napi_throw() of a primitive\n\nEnsure that napi_throw() is able to throw a primitive value, and\ndocument that it is able to throw any JavaScript value.\n\nFixes: https://github.com/nodejs/abi-stable-node/issues/309\nPR-URL: https://github.com/nodejs/node/pull/20428\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/bdf5be98dd901f6c312938198439dbda0b20d517"},{"sha":"7588ceaf353af0f257d4d832bace4600edac704e","author":{"name":"Vse Mozhet Byt","email":"39164014c1ea1d786372ed67424a3db1c9cda5d3@gmail.com"},"message":"doc: add more missing backticks\n\nAlso, fix some other nits in passing\n(formatting, punctuation, typos, redundancy, obsoleteness).\n\nPR-URL: https://github.com/nodejs/node/pull/20438\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/7588ceaf353af0f257d4d832bace4600edac704e"},{"sha":"ac6d1f20b9668d5f904d9e592bfd0ae0bfd3445e","author":{"name":"Rich Trott","email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com"},"message":"doc: remove squash guideline from onboarding doc\n\nAlthough I agree with the guideline people should generally not squash\ncommits in a pull request until the end (in other words, until it's time\nto land the PR), it is clear from comments and actions in the issue\ntracker that many do not share that view. This is fine by me, but I do\nthink that we should our documentation should reflect our practices\nrather than being an aspirational statement.\n\nIf we *do* wish to preserve this recommendation, it probably belongs in\nanother document anyway as this is not a recommendation for\nCollaborators only but for anyone opening a pull request.\n\nPR-URL: https://github.com/nodejs/node/pull/20413\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/ac6d1f20b9668d5f904d9e592bfd0ae0bfd3445e"},{"sha":"24a5ac797d6eb2431d532ddb3a9e2062490a7737","author":{"name":"Rich Trott","email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com"},"message":"doc: add squash guideline to pull-requests doc\n\nTell the contributor to generally not squash commits during the pull\nrequest review process.\n\nPR-URL: https://github.com/nodejs/node/pull/20413\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/24a5ac797d6eb2431d532ddb3a9e2062490a7737"},{"sha":"a957f248aedb89aff510fa619e80f017cf318e05","author":{"name":"Anatoli Papirovski","email":"aecb77baa64d26d49c9468c652b7b6a4504ce838@mac.com"},"message":"benchmark: fix next-tick-depth\n\nA recent change made these benchmarks fail by always finishing\nwith 0 iterations. Restore a counter variable.\n\nPR-URL: https://github.com/nodejs/node/pull/20461\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/a957f248aedb89aff510fa619e80f017cf318e05"},{"sha":"516349d99cd64448f88899485352753f847b1ae9","author":{"name":"Daiki Arai","email":"3ae9bc5eca3efc4d736134f1146f6d90d68dbb4e@yahoo.co.jp"},"message":"doc: add http.ClientRequest maxHeadersCount\n\nIn http.ClientRequest's doc, add maxHeadersCount as a public property.\nAnd in the description of server's one, change a hyphen to a comma.\n\nPR-URL: https://github.com/nodejs/node/pull/20361\nRefs: https://github.com/nodejs/node/pull/20359\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/516349d99cd64448f88899485352753f847b1ae9"},{"sha":"ab15198471cdd62b9c98619b033ac17f0f56d01e","author":{"name":"Richard Lau","email":"8193d74c06330af7778ef55510160e4e561ed6a1@uk.ibm.com"},"message":"tools: fix TypeError from `test.py --time`\n\nCalculated durations are timedelta objects but the FormatTime function\nis expecting a number in seconds.\n\nPR-URL: https://github.com/nodejs/node/pull/20368\nFixes: https://github.com/nodejs/node/issues/20341\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/ab15198471cdd62b9c98619b033ac17f0f56d01e"},{"sha":"751c2d6a8da7aae5db730d87b878dea761b384e0","author":{"name":"xsbchen","email":"a15d6b0c0ab2a9976874de874f89045c5968aa1e@qq.com"},"message":"doc: update writing-and-running-benchmarks.md\n\nRefs: https://github.com/nodejs/node/commit/368517c0dc2576e1f8f315e53d0cfebb22acf9e2\n\nPR-URL: https://github.com/nodejs/node/pull/20379\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/751c2d6a8da7aae5db730d87b878dea761b384e0"},{"sha":"482b662cb1d698a7b6dae1b31232451893c72b15","author":{"name":"Kyle Martin","email":"c8ff3bf454a3f197ede2c4501d2be736f9bf4329@hotmail.co.nz"},"message":"timers: named anonymous functions\n\nPR-URL: https://github.com/nodejs/node/pull/20397\nRefs: https://github.com/nodejs/node/issues/8913\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>\nReviewed-By: Minwoo Jung <minwoo@nodesource.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/482b662cb1d698a7b6dae1b31232451893c72b15"},{"sha":"c493b98b0bc3857340441c4ababf701288ffbd96","author":{"name":"Denis Fäcke","email":"7eb9efd9748ca83288cbcac39d0e738a684b6592@gmail.com"},"message":"child_process: name anonymous functions\n\nRefs: https://github.com/nodejs/node/issues/8913\n\nPR-URL: https://github.com/nodejs/node/pull/20399\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/c493b98b0bc3857340441c4ababf701288ffbd96"},{"sha":"aa18e22a235d75a28e8a25470b5f3b5f9be06a1f","author":{"name":"Daylor Yanes","email":"440aaaa7da2d9db54730f9c102835e25b97c7b03@gmail.com"},"message":"test: remove unnecessary strictEqual() argument from remoteClose()\n\nPR-URL: https://github.com/nodejs/node/pull/20343\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/aa18e22a235d75a28e8a25470b5f3b5f9be06a1f"},{"sha":"b457ec8437e6f4960d7862fa5a81821bf967e698","author":{"name":"Richard Lau","email":"8193d74c06330af7778ef55510160e4e561ed6a1@uk.ibm.com"},"message":"test: use fs.copyFileSync()\n\nUse the potentially more efficient fs.copyFileSync() instead of reading\nthe whole file in and writing the whole file out in JavaScript.\n\nPR-URL: https://github.com/nodejs/node/pull/20340\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: Khaidi Chu <i@2333.moe>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/b457ec8437e6f4960d7862fa5a81821bf967e698"},{"sha":"2553377d118f8762bbb665936e4ce41eb84bf3bb","author":{"name":"Vse Mozhet Byt","email":"39164014c1ea1d786372ed67424a3db1c9cda5d3@gmail.com"},"message":"doc: add missing periods in documentation.md\n\nPR-URL: https://github.com/nodejs/node/pull/20469\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/2553377d118f8762bbb665936e4ce41eb84bf3bb"},{"sha":"fe8794560a22cc62a482bf071e2050ce1ea6ea3e","author":{"name":"Anatoli Papirovski","email":"aecb77baa64d26d49c9468c652b7b6a4504ce838@mac.com"},"message":"events: optimize condition for optimal scenario\n\nInstead of always checking whether we've already warned about a\npossible EventEmitter memory leak, first run the rest of the\ncode as accessing random properties on an Array is expensive.\n\nIn addition, remove an unnecessary truthy check.\n\nPR-URL: https://github.com/nodejs/node/pull/20452\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/fe8794560a22cc62a482bf071e2050ce1ea6ea3e"},{"sha":"b04d0921aeaa70521dea5fcb27256c686157eb87","author":{"name":"Anatoli Papirovski","email":"aecb77baa64d26d49c9468c652b7b6a4504ce838@mac.com"},"message":"util: improve spliceOne perf\n\nDo less variable allocations and reassignments inside spliceOne\nsince it's relied on by some performance sensitive code.\n\nPR-URL: https://github.com/nodejs/node/pull/20453\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/b04d0921aeaa70521dea5fcb27256c686157eb87"},{"sha":"6a24c0c4d6a29a223db26469d33aa0a6f0ed2a1e","author":{"name":"Shobhit Chittora","email":"410adcb26e390d17119096471ab71c1b68e41ab6@gmail.com"},"message":"doc: update cli flag in crypto.md\n\nPR-URL: https://github.com/nodejs/node/pull/20400\nFixes: https://github.com/nodejs/node/issues/20385\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/6a24c0c4d6a29a223db26469d33aa0a6f0ed2a1e"},{"sha":"a00f76c360a223464f330b8a19612c8a0991f6c8","author":{"name":"Rich Trott","email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com"},"message":"doc: synchronize argument names for appendFile()\n\nThe documentation used `file` for the first argument to `appendFile()`\nfunctions. However, the code and (more importantly) thrown errors\nreferred to it as `path`. The latter is especially important because\ncontext is not provided. So you're looking for a function that takes\n`path` but that string doesn't appear in your code *or* in the\ndocumentation. It's not until the end user looks at the source code of\nNode.js that they can figure out what's going on. This is why it is\nimportant that the names of variables in the documentation match that in\nthe code. If we want to change this to `file`, then that's OK, but we\nneed to do it in the source code and error messages too, not just in the\ndocs. Changing the docs is the smallest change to synchronize everything\nso that's what this change does.\n\nPR-URL: https://github.com/nodejs/node/pull/20489\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/a00f76c360a223464f330b8a19612c8a0991f6c8"},{"sha":"4d8806fc407a127833d483ccd1cc8b35f33528c8","author":{"name":"Carrie Coxwell","email":"aae106100f99036c50c365d26433ef9d0232fb47@gmail.com"},"message":"util: named anonymous functions\n\nPR-URL: https://github.com/nodejs/node/pull/20408\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Weijia Wang <starkwang@126.com>\nReviewed-By: Matheus Marchini <matheus@sthima.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/4d8806fc407a127833d483ccd1cc8b35f33528c8"},{"sha":"0930d7ec05d8a0d29d7562f881ca67a959ec18a4","author":{"name":"Carrie Coxwell","email":"aae106100f99036c50c365d26433ef9d0232fb47@gmail.com"},"message":"lib: named anonymous functions\n\nPR-URL: https://github.com/nodejs/node/pull/20408\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Weijia Wang <starkwang@126.com>\nReviewed-By: Matheus Marchini <matheus@sthima.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/0930d7ec05d8a0d29d7562f881ca67a959ec18a4"},{"sha":"a59826403a76fcc7a6685a52ee82d19be323a699","author":{"name":"Gus Caplan","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@gus.host"},"message":"console: console.time() should not reset a timer when it exists\n\nPR-URL: https://github.com/nodejs/node/pull/20442\nFixes: https://github.com/nodejs/node/issues/20440\nRefs: https://console.spec.whatwg.org/#time\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>","distinct":false,"url":"https://api.github.com/repos/devsnek/node/commits/a59826403a76fcc7a6685a52ee82d19be323a699"}]}
{"actor":{"display_login":"devsnek"}}