{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/develar/ts-babel/pulls/14","id":228170259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTcwMjU5","html_url":"https://github.com/develar/ts-babel/pull/14","diff_url":"https://github.com/develar/ts-babel/pull/14.diff","patch_url":"https://github.com/develar/ts-babel/pull/14.patch","issue_url":"https://api.github.com/repos/develar/ts-babel/issues/14","number":14,"state":"closed","locked":false,"title":"fix: output files are removed on windows","user":{"login":"dscalzi","id":9703873,"node_id":"MDQ6VXNlcjk3MDM4NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9703873?v=4","gravatar_id":"","url":"https://api.github.com/users/dscalzi","html_url":"https://github.com/dscalzi","followers_url":"https://api.github.com/users/dscalzi/followers","following_url":"https://api.github.com/users/dscalzi/following{/other_user}","gists_url":"https://api.github.com/users/dscalzi/gists{/gist_id}","starred_url":"https://api.github.com/users/dscalzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscalzi/subscriptions","organizations_url":"https://api.github.com/users/dscalzi/orgs","repos_url":"https://api.github.com/users/dscalzi/repos","events_url":"https://api.github.com/users/dscalzi/events{/privacy}","received_events_url":"https://api.github.com/users/dscalzi/received_events","type":"User","site_admin":false},"body":"In the last commit you updated the `file` to use path.resolve. `fullPath` was not updated and therefore mismatches in the `!emittedFiles.has(fullPath)` check. As a result, the remove condition was always true and all output files were removed.\r\n\r\nEx.\r\n`file`: `C:\\Users\\Asus\\Desktop\\electron-builder\\test\\out\\linux\\linuxArchiveTest.js`\r\n`fullPath`: `C:\\Users\\Asus\\Desktop\\electron-builder\\test\\out/linux/linuxArchiveTest.js`\r\n\r\nMismatch existed for all processed files. This PR fixes it.","created_at":"2018-11-04T11:08:37Z","updated_at":"2018-11-04T11:10:33Z","closed_at":"2018-11-04T11:10:33Z","merged_at":"2018-11-04T11:10:33Z","merge_commit_sha":"9236931a394f01546bb9fcf3d60dcb06b1852717","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/develar/ts-babel/pulls/14/commits","review_comments_url":"https://api.github.com/repos/develar/ts-babel/pulls/14/comments","review_comment_url":"https://api.github.com/repos/develar/ts-babel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/develar/ts-babel/issues/14/comments","statuses_url":"https://api.github.com/repos/develar/ts-babel/statuses/d4f0416a1ca134e234bf6f0bf5f4d6c14e0d30cc","head":{"label":"dscalzi:master","ref":"master","sha":"d4f0416a1ca134e234bf6f0bf5f4d6c14e0d30cc","user":{"login":"dscalzi","id":9703873,"node_id":"MDQ6VXNlcjk3MDM4NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9703873?v=4","gravatar_id":"","url":"https://api.github.com/users/dscalzi","html_url":"https://github.com/dscalzi","followers_url":"https://api.github.com/users/dscalzi/followers","following_url":"https://api.github.com/users/dscalzi/following{/other_user}","gists_url":"https://api.github.com/users/dscalzi/gists{/gist_id}","starred_url":"https://api.github.com/users/dscalzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscalzi/subscriptions","organizations_url":"https://api.github.com/users/dscalzi/orgs","repos_url":"https://api.github.com/users/dscalzi/repos","events_url":"https://api.github.com/users/dscalzi/events{/privacy}","received_events_url":"https://api.github.com/users/dscalzi/received_events","type":"User","site_admin":false},"repo":{"id":156072471,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYwNzI0NzE=","name":"ts-babel","full_name":"dscalzi/ts-babel","private":false,"owner":{"login":"dscalzi","id":9703873,"node_id":"MDQ6VXNlcjk3MDM4NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9703873?v=4","gravatar_id":"","url":"https://api.github.com/users/dscalzi","html_url":"https://github.com/dscalzi","followers_url":"https://api.github.com/users/dscalzi/followers","following_url":"https://api.github.com/users/dscalzi/following{/other_user}","gists_url":"https://api.github.com/users/dscalzi/gists{/gist_id}","starred_url":"https://api.github.com/users/dscalzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscalzi/subscriptions","organizations_url":"https://api.github.com/users/dscalzi/orgs","repos_url":"https://api.github.com/users/dscalzi/repos","events_url":"https://api.github.com/users/dscalzi/events{/privacy}","received_events_url":"https://api.github.com/users/dscalzi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dscalzi/ts-babel","description":"Compile Typescript to JS","fork":true,"url":"https://api.github.com/repos/dscalzi/ts-babel","forks_url":"https://api.github.com/repos/dscalzi/ts-babel/forks","keys_url":"https://api.github.com/repos/dscalzi/ts-babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dscalzi/ts-babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dscalzi/ts-babel/teams","hooks_url":"https://api.github.com/repos/dscalzi/ts-babel/hooks","issue_events_url":"https://api.github.com/repos/dscalzi/ts-babel/issues/events{/number}","events_url":"https://api.github.com/repos/dscalzi/ts-babel/events","assignees_url":"https://api.github.com/repos/dscalzi/ts-babel/assignees{/user}","branches_url":"https://api.github.com/repos/dscalzi/ts-babel/branches{/branch}","tags_url":"https://api.github.com/repos/dscalzi/ts-babel/tags","blobs_url":"https://api.github.com/repos/dscalzi/ts-babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dscalzi/ts-babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dscalzi/ts-babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/dscalzi/ts-babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dscalzi/ts-babel/statuses/{sha}","languages_url":"https://api.github.com/repos/dscalzi/ts-babel/languages","stargazers_url":"https://api.github.com/repos/dscalzi/ts-babel/stargazers","contributors_url":"https://api.github.com/repos/dscalzi/ts-babel/contributors","subscribers_url":"https://api.github.com/repos/dscalzi/ts-babel/subscribers","subscription_url":"https://api.github.com/repos/dscalzi/ts-babel/subscription","commits_url":"https://api.github.com/repos/dscalzi/ts-babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/dscalzi/ts-babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/dscalzi/ts-babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/dscalzi/ts-babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/dscalzi/ts-babel/contents/{+path}","compare_url":"https://api.github.com/repos/dscalzi/ts-babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dscalzi/ts-babel/merges","archive_url":"https://api.github.com/repos/dscalzi/ts-babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dscalzi/ts-babel/downloads","issues_url":"https://api.github.com/repos/dscalzi/ts-babel/issues{/number}","pulls_url":"https://api.github.com/repos/dscalzi/ts-babel/pulls{/number}","milestones_url":"https://api.github.com/repos/dscalzi/ts-babel/milestones{/number}","notifications_url":"https://api.github.com/repos/dscalzi/ts-babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dscalzi/ts-babel/labels{/name}","releases_url":"https://api.github.com/repos/dscalzi/ts-babel/releases{/id}","deployments_url":"https://api.github.com/repos/dscalzi/ts-babel/deployments","created_at":"2018-11-04T10:53:08Z","updated_at":"2018-11-04T11:04:38Z","pushed_at":"2018-11-04T11:04:37Z","git_url":"git://github.com/dscalzi/ts-babel.git","ssh_url":"git@github.com:dscalzi/ts-babel.git","clone_url":"https://github.com/dscalzi/ts-babel.git","svn_url":"https://github.com/dscalzi/ts-babel","homepage":"","size":177,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"develar:master","ref":"master","sha":"6c8e34369d832e19ff961165e038a2580cc0d685","user":{"login":"develar","id":350686,"node_id":"MDQ6VXNlcjM1MDY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/350686?v=4","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"repo":{"id":49859531,"node_id":"MDEwOlJlcG9zaXRvcnk0OTg1OTUzMQ==","name":"ts-babel","full_name":"develar/ts-babel","private":false,"owner":{"login":"develar","id":350686,"node_id":"MDQ6VXNlcjM1MDY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/350686?v=4","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/develar/ts-babel","description":"Compile Typescript to JS","fork":false,"url":"https://api.github.com/repos/develar/ts-babel","forks_url":"https://api.github.com/repos/develar/ts-babel/forks","keys_url":"https://api.github.com/repos/develar/ts-babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/develar/ts-babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/develar/ts-babel/teams","hooks_url":"https://api.github.com/repos/develar/ts-babel/hooks","issue_events_url":"https://api.github.com/repos/develar/ts-babel/issues/events{/number}","events_url":"https://api.github.com/repos/develar/ts-babel/events","assignees_url":"https://api.github.com/repos/develar/ts-babel/assignees{/user}","branches_url":"https://api.github.com/repos/develar/ts-babel/branches{/branch}","tags_url":"https://api.github.com/repos/develar/ts-babel/tags","blobs_url":"https://api.github.com/repos/develar/ts-babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/develar/ts-babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/develar/ts-babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/develar/ts-babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/develar/ts-babel/statuses/{sha}","languages_url":"https://api.github.com/repos/develar/ts-babel/languages","stargazers_url":"https://api.github.com/repos/develar/ts-babel/stargazers","contributors_url":"https://api.github.com/repos/develar/ts-babel/contributors","subscribers_url":"https://api.github.com/repos/develar/ts-babel/subscribers","subscription_url":"https://api.github.com/repos/develar/ts-babel/subscription","commits_url":"https://api.github.com/repos/develar/ts-babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/develar/ts-babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/develar/ts-babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/develar/ts-babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/develar/ts-babel/contents/{+path}","compare_url":"https://api.github.com/repos/develar/ts-babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/develar/ts-babel/merges","archive_url":"https://api.github.com/repos/develar/ts-babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/develar/ts-babel/downloads","issues_url":"https://api.github.com/repos/develar/ts-babel/issues{/number}","pulls_url":"https://api.github.com/repos/develar/ts-babel/pulls{/number}","milestones_url":"https://api.github.com/repos/develar/ts-babel/milestones{/number}","notifications_url":"https://api.github.com/repos/develar/ts-babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/develar/ts-babel/labels{/name}","releases_url":"https://api.github.com/repos/develar/ts-babel/releases{/id}","deployments_url":"https://api.github.com/repos/develar/ts-babel/deployments","created_at":"2016-01-18T07:31:15Z","updated_at":"2018-10-31T08:40:13Z","pushed_at":"2018-11-04T11:10:33Z","git_url":"git://github.com/develar/ts-babel.git","ssh_url":"git@github.com:develar/ts-babel.git","clone_url":"https://github.com/develar/ts-babel.git","svn_url":"https://github.com/develar/ts-babel","homepage":"","size":177,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/develar/ts-babel/pulls/14"},"html":{"href":"https://github.com/develar/ts-babel/pull/14"},"issue":{"href":"https://api.github.com/repos/develar/ts-babel/issues/14"},"comments":{"href":"https://api.github.com/repos/develar/ts-babel/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/develar/ts-babel/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/develar/ts-babel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/develar/ts-babel/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/develar/ts-babel/statuses/d4f0416a1ca134e234bf6f0bf5f4d6c14e0d30cc"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"develar","id":350686,"node_id":"MDQ6VXNlcjM1MDY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/350686?v=4","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"develar"}}