{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/201207888","pull_request_review_id":135663125,"id":201207888,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTIwNzg4OA==","diff_hunk":"@@ -90,6 +90,27 @@ static void deriveBodyRawRepresentable_raw(AbstractFunctionDecl *toRawDecl) {\n   }\n #endif\n \n+  if (enumDecl->isObjC()) {","path":"lib/Sema/DerivedConformanceRawRepresentable.cpp","position":4,"original_position":4,"commit_id":"38e0a47fb5281577596b89637b249bfd88ba7b29","original_commit_id":"ba964d7392f38f053b154325b970a8ef60875ae8","user":{"login":"jckarter","id":147281,"node_id":"MDQ6VXNlcjE0NzI4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/147281?v=4","gravatar_id":"","url":"https://api.github.com/users/jckarter","html_url":"https://github.com/jckarter","followers_url":"https://api.github.com/users/jckarter/followers","following_url":"https://api.github.com/users/jckarter/following{/other_user}","gists_url":"https://api.github.com/users/jckarter/gists{/gist_id}","starred_url":"https://api.github.com/users/jckarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jckarter/subscriptions","organizations_url":"https://api.github.com/users/jckarter/orgs","repos_url":"https://api.github.com/users/jckarter/repos","events_url":"https://api.github.com/users/jckarter/events{/privacy}","received_events_url":"https://api.github.com/users/jckarter/received_events","type":"User","site_admin":false},"body":"Having hashing use the bitcast value feels more inherently correct to me, since an `@objc` enum can in fact be of any value of its raw type, and a hash implementation ought to feed all of the significant bits of the value to the hasher.","created_at":"2018-07-10T03:22:58Z","updated_at":"2018-07-10T03:22:59Z","html_url":"https://github.com/apple/swift/pull/17836#discussion_r201207888","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/17836","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/201207888"},"html":{"href":"https://github.com/apple/swift/pull/17836#discussion_r201207888"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/17836"}},"in_reply_to_id":201140901},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/17836","id":200181107,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTgxMTA3","html_url":"https://github.com/apple/swift/pull/17836","diff_url":"https://github.com/apple/swift/pull/17836.diff","patch_url":"https://github.com/apple/swift/pull/17836.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/17836","number":17836,"state":"open","locked":false,"title":"Handle unexpected raw values for @objc enums in derived conformances","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Because people put all sorts of nonsense into `@objc` enums (most reasonably, \"private cases\", which represent valid values that are not API), the Swift-synthesized implementation of `hash(into:)` needs to not expect a switch statement to be exhaustive. And since Swift-defined `@objc` enums are supposed to behave enough like C-defined enums, they should at least handle simple method calls with an invalid raw value, which means that `rawValue` likewise should not use a switch.\r\n\r\nThis patch provides alternate implementations that look like this:\r\n\r\n```\r\nextension ImportedEnum {\r\n  public var rawValue: Int {\r\n    return unsafeBitCast(self, to: Int.self)\r\n  }\r\n\r\n  public func hash(into hasher: inout Hasher) {\r\n    hasher.combine(self.rawValue)\r\n  }\r\n}\r\n```\r\n\r\nrdar://problem/41913284\r\n","created_at":"2018-07-09T18:22:16Z","updated_at":"2018-07-10T03:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa4eb776465203e0a705a92108e09d190a0876a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/17836/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/17836/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/17836/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/38e0a47fb5281577596b89637b249bfd88ba7b29","head":{"label":"jrose-apple:ready-for-anything","ref":"ready-for-anything","sha":"38e0a47fb5281577596b89637b249bfd88ba7b29","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"repo":{"id":47434397,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQzNDM5Nw==","name":"swift","full_name":"jrose-apple/swift","owner":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrose-apple/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jrose-apple/swift","forks_url":"https://api.github.com/repos/jrose-apple/swift/forks","keys_url":"https://api.github.com/repos/jrose-apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrose-apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrose-apple/swift/teams","hooks_url":"https://api.github.com/repos/jrose-apple/swift/hooks","issue_events_url":"https://api.github.com/repos/jrose-apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jrose-apple/swift/events","assignees_url":"https://api.github.com/repos/jrose-apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jrose-apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jrose-apple/swift/tags","blobs_url":"https://api.github.com/repos/jrose-apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrose-apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrose-apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrose-apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrose-apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jrose-apple/swift/languages","stargazers_url":"https://api.github.com/repos/jrose-apple/swift/stargazers","contributors_url":"https://api.github.com/repos/jrose-apple/swift/contributors","subscribers_url":"https://api.github.com/repos/jrose-apple/swift/subscribers","subscription_url":"https://api.github.com/repos/jrose-apple/swift/subscription","commits_url":"https://api.github.com/repos/jrose-apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrose-apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrose-apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrose-apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrose-apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jrose-apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrose-apple/swift/merges","archive_url":"https://api.github.com/repos/jrose-apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrose-apple/swift/downloads","issues_url":"https://api.github.com/repos/jrose-apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jrose-apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jrose-apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jrose-apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrose-apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/jrose-apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jrose-apple/swift/deployments","created_at":"2015-12-04T23:42:49Z","updated_at":"2017-08-31T16:24:50Z","pushed_at":"2018-07-09T23:44:12Z","git_url":"git://github.com/jrose-apple/swift.git","ssh_url":"git@github.com:jrose-apple/swift.git","clone_url":"https://github.com/jrose-apple/swift.git","svn_url":"https://github.com/jrose-apple/swift","homepage":"","size":288576,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"empty"}},"base":{"label":"apple:master","ref":"master","sha":"493136267c34fd5777ee51482996ef7e978e5bb9","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-10T03:09:34Z","pushed_at":"2018-07-10T03:17:03Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":309082,"stargazers_count":44466,"watchers_count":44466,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7016,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7016,"open_issues":377,"watchers":44466,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/17836"},"html":{"href":"https://github.com/apple/swift/pull/17836"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/17836"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/17836/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/17836/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/17836/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/38e0a47fb5281577596b89637b249bfd88ba7b29"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jckarter"}}