{"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/187762497","pull_request_review_id":119613906,"id":187762497,"diff_hunk":"@@ -15,35 +15,38 @@\n #include \"catalog/catalog.h\"\n #include \"catalog/system_catalogs.h\"\n #include \"catalog/table_catalog.h\"\n+#include \"codegen/buffering_consumer.h\"\n #include \"concurrency/transaction_context.h\"\n #include \"storage/data_table.h\"\n #include \"storage/database.h\"\n #include \"type/value_factory.h\"\n+#include \"expression/expression_util.h\"\n \n namespace peloton {\n namespace catalog {\n \n-ColumnCatalogObject::ColumnCatalogObject(executor::LogicalTile *tile,\n-                                         int tupleId)\n-    : table_oid(tile->GetValue(tupleId, ColumnCatalog::ColumnId::TABLE_OID)\n+\n+ColumnCatalogObject::ColumnCatalogObject(codegen::WrappedTuple wrapped_tuple)\n+    : table_oid(wrapped_tuple.GetValue(ColumnCatalog::ColumnId::TABLE_OID)","path":"src/catalog/column_catalog.cpp","position":19,"original_position":19,"commit_id":"90439c3555291322b2df249651a0a345c3f82630","original_commit_id":"90439c3555291322b2df249651a0a345c3f82630","user":{"login":"latelatif","id":25693934,"avatar_url":"https://avatars3.githubusercontent.com/u/25693934?v=4","gravatar_id":"","url":"https://api.github.com/users/latelatif","html_url":"https://github.com/latelatif","followers_url":"https://api.github.com/users/latelatif/followers","following_url":"https://api.github.com/users/latelatif/following{/other_user}","gists_url":"https://api.github.com/users/latelatif/gists{/gist_id}","starred_url":"https://api.github.com/users/latelatif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latelatif/subscriptions","organizations_url":"https://api.github.com/users/latelatif/orgs","repos_url":"https://api.github.com/users/latelatif/repos","events_url":"https://api.github.com/users/latelatif/events{/privacy}","received_events_url":"https://api.github.com/users/latelatif/received_events","type":"User","site_admin":false},"body":"As mentioned by @gandeevan, GetValue is deprecated now. Please talk to @poojanilangekar to make sure you can use this for a wrapped tuple object safely","created_at":"2018-05-12T03:02:06Z","updated_at":"2018-05-12T03:32:31Z","html_url":"https://github.com/cmu-db/peloton/pull/1339#discussion_r187762497","pull_request_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1339","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/187762497"},"html":{"href":"https://github.com/cmu-db/peloton/pull/1339#discussion_r187762497"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1339"}}},"pull_request":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/1339","id":186021803,"html_url":"https://github.com/cmu-db/peloton/pull/1339","diff_url":"https://github.com/cmu-db/peloton/pull/1339.diff","patch_url":"https://github.com/cmu-db/peloton/pull/1339.patch","issue_url":"https://api.github.com/repos/cmu-db/peloton/issues/1339","number":1339,"state":"open","locked":false,"title":"[15721] Compiled Catalog Query Access","user":{"login":"nwang57","id":7065997,"avatar_url":"https://avatars1.githubusercontent.com/u/7065997?v=4","gravatar_id":"","url":"https://api.github.com/users/nwang57","html_url":"https://github.com/nwang57","followers_url":"https://api.github.com/users/nwang57/followers","following_url":"https://api.github.com/users/nwang57/following{/other_user}","gists_url":"https://api.github.com/users/nwang57/gists{/gist_id}","starred_url":"https://api.github.com/users/nwang57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwang57/subscriptions","organizations_url":"https://api.github.com/users/nwang57/orgs","repos_url":"https://api.github.com/users/nwang57/repos","events_url":"https://api.github.com/users/nwang57/events{/privacy}","received_events_url":"https://api.github.com/users/nwang57/received_events","type":"User","site_admin":false},"body":"We enabled complied catalog lookup in the first pull request. Based upon this, we further support complied insert and delete queries for all catalogs. We also fix bugs for the following issues:\r\n\r\n* #1298 Need to manually bind the tuple value expression so that equality checks will work correctly.\r\n\r\n* Sequential scan assumes that the output columns should start at offset 0 otherwise PerformBinding will not correctly find the corresponding column attributes.\r\n\r\n* ZoneMapCatalog needs special care to avoid chicken and egg problem. Each sequential plan needs to check the zone map to know whether to scan the tile or not, but checking the zone map requires ZoneMap catalog access which leads to an infinity loop. So we ensure in the ZoneMap catalog manager that if the scanning table is ZoneMap catalog then it will just scan it without checking the ZoneMap","created_at":"2018-05-04T15:44:42Z","updated_at":"2018-05-12T03:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a898842255541471ce6f12d9adc461368042f8f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":898811091,"url":"https://api.github.com/repos/cmu-db/peloton/labels/class-project","name":"class-project","color":"2a55aa","default":false},{"id":325402872,"url":"https://api.github.com/repos/cmu-db/peloton/labels/do%20not%20merge","name":"do not merge","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1339/commits","review_comments_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1339/comments","review_comment_url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/peloton/issues/1339/comments","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/90439c3555291322b2df249651a0a345c3f82630","head":{"label":"nwang57:pcq-cp2","ref":"pcq-cp2","sha":"90439c3555291322b2df249651a0a345c3f82630","user":{"login":"nwang57","id":7065997,"avatar_url":"https://avatars1.githubusercontent.com/u/7065997?v=4","gravatar_id":"","url":"https://api.github.com/users/nwang57","html_url":"https://github.com/nwang57","followers_url":"https://api.github.com/users/nwang57/followers","following_url":"https://api.github.com/users/nwang57/following{/other_user}","gists_url":"https://api.github.com/users/nwang57/gists{/gist_id}","starred_url":"https://api.github.com/users/nwang57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwang57/subscriptions","organizations_url":"https://api.github.com/users/nwang57/orgs","repos_url":"https://api.github.com/users/nwang57/repos","events_url":"https://api.github.com/users/nwang57/events{/privacy}","received_events_url":"https://api.github.com/users/nwang57/received_events","type":"User","site_admin":false},"repo":{"id":118013248,"name":"peloton","full_name":"nwang57/peloton","owner":{"login":"nwang57","id":7065997,"avatar_url":"https://avatars1.githubusercontent.com/u/7065997?v=4","gravatar_id":"","url":"https://api.github.com/users/nwang57","html_url":"https://github.com/nwang57","followers_url":"https://api.github.com/users/nwang57/followers","following_url":"https://api.github.com/users/nwang57/following{/other_user}","gists_url":"https://api.github.com/users/nwang57/gists{/gist_id}","starred_url":"https://api.github.com/users/nwang57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwang57/subscriptions","organizations_url":"https://api.github.com/users/nwang57/orgs","repos_url":"https://api.github.com/users/nwang57/repos","events_url":"https://api.github.com/users/nwang57/events{/privacy}","received_events_url":"https://api.github.com/users/nwang57/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nwang57/peloton","description":"The Self-Driving Database Management System","fork":true,"url":"https://api.github.com/repos/nwang57/peloton","forks_url":"https://api.github.com/repos/nwang57/peloton/forks","keys_url":"https://api.github.com/repos/nwang57/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwang57/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwang57/peloton/teams","hooks_url":"https://api.github.com/repos/nwang57/peloton/hooks","issue_events_url":"https://api.github.com/repos/nwang57/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/nwang57/peloton/events","assignees_url":"https://api.github.com/repos/nwang57/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/nwang57/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/nwang57/peloton/tags","blobs_url":"https://api.github.com/repos/nwang57/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwang57/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwang57/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwang57/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwang57/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/nwang57/peloton/languages","stargazers_url":"https://api.github.com/repos/nwang57/peloton/stargazers","contributors_url":"https://api.github.com/repos/nwang57/peloton/contributors","subscribers_url":"https://api.github.com/repos/nwang57/peloton/subscribers","subscription_url":"https://api.github.com/repos/nwang57/peloton/subscription","commits_url":"https://api.github.com/repos/nwang57/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwang57/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwang57/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwang57/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/nwang57/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/nwang57/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwang57/peloton/merges","archive_url":"https://api.github.com/repos/nwang57/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwang57/peloton/downloads","issues_url":"https://api.github.com/repos/nwang57/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/nwang57/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/nwang57/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/nwang57/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwang57/peloton/labels{/name}","releases_url":"https://api.github.com/repos/nwang57/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/nwang57/peloton/deployments","created_at":"2018-01-18T17:10:54Z","updated_at":"2018-04-12T20:49:31Z","pushed_at":"2018-05-05T19:58:56Z","git_url":"git://github.com/nwang57/peloton.git","ssh_url":"git@github.com:nwang57/peloton.git","clone_url":"https://github.com/nwang57/peloton.git","svn_url":"https://github.com/nwang57/peloton","homepage":"http://pelotondb.io","size":68465,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmu-db:master","ref":"master","sha":"d052644e7922480ea03bceada59527997b0b9ca5","user":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":28202609,"name":"peloton","full_name":"cmu-db/peloton","owner":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/peloton","description":"The Self-Driving Database Management System","fork":false,"url":"https://api.github.com/repos/cmu-db/peloton","forks_url":"https://api.github.com/repos/cmu-db/peloton/forks","keys_url":"https://api.github.com/repos/cmu-db/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/peloton/teams","hooks_url":"https://api.github.com/repos/cmu-db/peloton/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/peloton/events","assignees_url":"https://api.github.com/repos/cmu-db/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/peloton/tags","blobs_url":"https://api.github.com/repos/cmu-db/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/peloton/languages","stargazers_url":"https://api.github.com/repos/cmu-db/peloton/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/peloton/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/peloton/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/peloton/subscription","commits_url":"https://api.github.com/repos/cmu-db/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/peloton/merges","archive_url":"https://api.github.com/repos/cmu-db/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/peloton/downloads","issues_url":"https://api.github.com/repos/cmu-db/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/peloton/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/peloton/deployments","created_at":"2014-12-18T21:35:23Z","updated_at":"2018-05-10T11:13:39Z","pushed_at":"2018-05-12T03:31:36Z","git_url":"git://github.com/cmu-db/peloton.git","ssh_url":"git@github.com:cmu-db/peloton.git","clone_url":"https://github.com/cmu-db/peloton.git","svn_url":"https://github.com/cmu-db/peloton","homepage":"http://pelotondb.io","size":68910,"stargazers_count":1246,"watchers_count":1246,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":457,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":457,"open_issues":168,"watchers":1246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1339"},"html":{"href":"https://github.com/cmu-db/peloton/pull/1339"},"issue":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/1339"},"comments":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/1339/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1339/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1339/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/peloton/statuses/90439c3555291322b2df249651a0a345c3f82630"}},"author_association":"NONE"}}
{"actor":{"display_login":"latelatif"}}