{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/comments/235840608","pull_request_review_id":177801117,"id":235840608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTg0MDYwOA==","diff_hunk":"@@ -11,7 +11,7 @@\n   },\n   \"scripts\": {\n     \"lint\": \"([ \\\"$CI\\\" = true ] && eslint --quiet -f codeframe . || eslint .)\",\n-    \"winlint\": \"( set CI=true  && eslint --quiet -f codeframe . || eslint .)\",\n+    \"winlint\": \"(if defined CI (eslint --quiet -f codeframe .) else (eslint .))\",","path":"package.json","position":4,"original_position":5,"commit_id":"453b1fc768d0ecd854025218b8a63ec7d5a1da61","original_commit_id":"453b1fc768d0ecd854025218b8a63ec7d5a1da61","user":{"login":"liudonghua123","id":2276718,"node_id":"MDQ6VXNlcjIyNzY3MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2276718?v=4","gravatar_id":"","url":"https://api.github.com/users/liudonghua123","html_url":"https://github.com/liudonghua123","followers_url":"https://api.github.com/users/liudonghua123/followers","following_url":"https://api.github.com/users/liudonghua123/following{/other_user}","gists_url":"https://api.github.com/users/liudonghua123/gists{/gist_id}","starred_url":"https://api.github.com/users/liudonghua123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liudonghua123/subscriptions","organizations_url":"https://api.github.com/users/liudonghua123/orgs","repos_url":"https://api.github.com/users/liudonghua123/repos","events_url":"https://api.github.com/users/liudonghua123/events{/privacy}","received_events_url":"https://api.github.com/users/liudonghua123/received_events","type":"User","site_admin":false},"body":"`if defined` is not correct, in your case if CI=false, then `eslint --quiet -f codeframe .` will executed.","created_at":"2018-11-23T03:19:26Z","updated_at":"2018-11-23T03:19:26Z","html_url":"https://github.com/GoogleChromeLabs/carlo/pull/94#discussion_r235840608","pull_request_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/comments/235840608"},"html":{"href":"https://github.com/GoogleChromeLabs/carlo/pull/94#discussion_r235840608"},"pull_request":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94","id":232257330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjU3MzMw","html_url":"https://github.com/GoogleChromeLabs/carlo/pull/94","diff_url":"https://github.com/GoogleChromeLabs/carlo/pull/94.diff","patch_url":"https://github.com/GoogleChromeLabs/carlo/pull/94.patch","issue_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues/94","number":94,"state":"closed","locked":false,"title":"package.json: add Windows lint command.","user":{"login":"whtiehack","id":12741016,"node_id":"MDQ6VXNlcjEyNzQxMDE2","avatar_url":"https://avatars0.githubusercontent.com/u/12741016?v=4","gravatar_id":"","url":"https://api.github.com/users/whtiehack","html_url":"https://github.com/whtiehack","followers_url":"https://api.github.com/users/whtiehack/followers","following_url":"https://api.github.com/users/whtiehack/following{/other_user}","gists_url":"https://api.github.com/users/whtiehack/gists{/gist_id}","starred_url":"https://api.github.com/users/whtiehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtiehack/subscriptions","organizations_url":"https://api.github.com/users/whtiehack/orgs","repos_url":"https://api.github.com/users/whtiehack/repos","events_url":"https://api.github.com/users/whtiehack/events{/privacy}","received_events_url":"https://api.github.com/users/whtiehack/received_events","type":"User","site_admin":false},"body":"We can't use `npm run lint`  to checks using Windows.","created_at":"2018-11-20T10:06:51Z","updated_at":"2018-11-23T03:19:26Z","closed_at":"2018-11-23T03:13:15Z","merged_at":null,"merge_commit_sha":"fad456ea8600b7b44d6fca91135179b528ed55d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94/commits","review_comments_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94/comments","review_comment_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues/94/comments","statuses_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/statuses/453b1fc768d0ecd854025218b8a63ec7d5a1da61","head":{"label":"whtiehack:fix-lint","ref":"fix-lint","sha":"453b1fc768d0ecd854025218b8a63ec7d5a1da61","user":{"login":"whtiehack","id":12741016,"node_id":"MDQ6VXNlcjEyNzQxMDE2","avatar_url":"https://avatars0.githubusercontent.com/u/12741016?v=4","gravatar_id":"","url":"https://api.github.com/users/whtiehack","html_url":"https://github.com/whtiehack","followers_url":"https://api.github.com/users/whtiehack/followers","following_url":"https://api.github.com/users/whtiehack/following{/other_user}","gists_url":"https://api.github.com/users/whtiehack/gists{/gist_id}","starred_url":"https://api.github.com/users/whtiehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtiehack/subscriptions","organizations_url":"https://api.github.com/users/whtiehack/orgs","repos_url":"https://api.github.com/users/whtiehack/repos","events_url":"https://api.github.com/users/whtiehack/events{/privacy}","received_events_url":"https://api.github.com/users/whtiehack/received_events","type":"User","site_admin":false},"repo":{"id":158318622,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgzMTg2MjI=","name":"carlo","full_name":"whtiehack/carlo","private":false,"owner":{"login":"whtiehack","id":12741016,"node_id":"MDQ6VXNlcjEyNzQxMDE2","avatar_url":"https://avatars0.githubusercontent.com/u/12741016?v=4","gravatar_id":"","url":"https://api.github.com/users/whtiehack","html_url":"https://github.com/whtiehack","followers_url":"https://api.github.com/users/whtiehack/followers","following_url":"https://api.github.com/users/whtiehack/following{/other_user}","gists_url":"https://api.github.com/users/whtiehack/gists{/gist_id}","starred_url":"https://api.github.com/users/whtiehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtiehack/subscriptions","organizations_url":"https://api.github.com/users/whtiehack/orgs","repos_url":"https://api.github.com/users/whtiehack/repos","events_url":"https://api.github.com/users/whtiehack/events{/privacy}","received_events_url":"https://api.github.com/users/whtiehack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/whtiehack/carlo","description":"Web rendering surface for Node applications","fork":true,"url":"https://api.github.com/repos/whtiehack/carlo","forks_url":"https://api.github.com/repos/whtiehack/carlo/forks","keys_url":"https://api.github.com/repos/whtiehack/carlo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whtiehack/carlo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whtiehack/carlo/teams","hooks_url":"https://api.github.com/repos/whtiehack/carlo/hooks","issue_events_url":"https://api.github.com/repos/whtiehack/carlo/issues/events{/number}","events_url":"https://api.github.com/repos/whtiehack/carlo/events","assignees_url":"https://api.github.com/repos/whtiehack/carlo/assignees{/user}","branches_url":"https://api.github.com/repos/whtiehack/carlo/branches{/branch}","tags_url":"https://api.github.com/repos/whtiehack/carlo/tags","blobs_url":"https://api.github.com/repos/whtiehack/carlo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whtiehack/carlo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whtiehack/carlo/git/refs{/sha}","trees_url":"https://api.github.com/repos/whtiehack/carlo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whtiehack/carlo/statuses/{sha}","languages_url":"https://api.github.com/repos/whtiehack/carlo/languages","stargazers_url":"https://api.github.com/repos/whtiehack/carlo/stargazers","contributors_url":"https://api.github.com/repos/whtiehack/carlo/contributors","subscribers_url":"https://api.github.com/repos/whtiehack/carlo/subscribers","subscription_url":"https://api.github.com/repos/whtiehack/carlo/subscription","commits_url":"https://api.github.com/repos/whtiehack/carlo/commits{/sha}","git_commits_url":"https://api.github.com/repos/whtiehack/carlo/git/commits{/sha}","comments_url":"https://api.github.com/repos/whtiehack/carlo/comments{/number}","issue_comment_url":"https://api.github.com/repos/whtiehack/carlo/issues/comments{/number}","contents_url":"https://api.github.com/repos/whtiehack/carlo/contents/{+path}","compare_url":"https://api.github.com/repos/whtiehack/carlo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whtiehack/carlo/merges","archive_url":"https://api.github.com/repos/whtiehack/carlo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whtiehack/carlo/downloads","issues_url":"https://api.github.com/repos/whtiehack/carlo/issues{/number}","pulls_url":"https://api.github.com/repos/whtiehack/carlo/pulls{/number}","milestones_url":"https://api.github.com/repos/whtiehack/carlo/milestones{/number}","notifications_url":"https://api.github.com/repos/whtiehack/carlo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whtiehack/carlo/labels{/name}","releases_url":"https://api.github.com/repos/whtiehack/carlo/releases{/id}","deployments_url":"https://api.github.com/repos/whtiehack/carlo/deployments","created_at":"2018-11-20T02:21:54Z","updated_at":"2018-11-20T02:21:56Z","pushed_at":"2018-11-23T03:07:39Z","git_url":"git://github.com/whtiehack/carlo.git","ssh_url":"git@github.com:whtiehack/carlo.git","clone_url":"https://github.com/whtiehack/carlo.git","svn_url":"https://github.com/whtiehack/carlo","homepage":"","size":345,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChromeLabs:master","ref":"master","sha":"ac0271a6ea21d4cefa51605e4bcba375053b7e8c","user":{"login":"GoogleChromeLabs","id":31970254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTcwMjU0","avatar_url":"https://avatars1.githubusercontent.com/u/31970254?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChromeLabs","html_url":"https://github.com/GoogleChromeLabs","followers_url":"https://api.github.com/users/GoogleChromeLabs/followers","following_url":"https://api.github.com/users/GoogleChromeLabs/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChromeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChromeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChromeLabs/subscriptions","organizations_url":"https://api.github.com/users/GoogleChromeLabs/orgs","repos_url":"https://api.github.com/users/GoogleChromeLabs/repos","events_url":"https://api.github.com/users/GoogleChromeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChromeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":155095613,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUwOTU2MTM=","name":"carlo","full_name":"GoogleChromeLabs/carlo","private":false,"owner":{"login":"GoogleChromeLabs","id":31970254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTcwMjU0","avatar_url":"https://avatars1.githubusercontent.com/u/31970254?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChromeLabs","html_url":"https://github.com/GoogleChromeLabs","followers_url":"https://api.github.com/users/GoogleChromeLabs/followers","following_url":"https://api.github.com/users/GoogleChromeLabs/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChromeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChromeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChromeLabs/subscriptions","organizations_url":"https://api.github.com/users/GoogleChromeLabs/orgs","repos_url":"https://api.github.com/users/GoogleChromeLabs/repos","events_url":"https://api.github.com/users/GoogleChromeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChromeLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChromeLabs/carlo","description":"Web rendering surface for Node applications","fork":false,"url":"https://api.github.com/repos/GoogleChromeLabs/carlo","forks_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/forks","keys_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/teams","hooks_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/hooks","issue_events_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/events","assignees_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/tags","blobs_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/languages","stargazers_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/stargazers","contributors_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/contributors","subscribers_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/subscribers","subscription_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/subscription","commits_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/merges","archive_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/downloads","issues_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChromeLabs/carlo/deployments","created_at":"2018-10-28T17:15:20Z","updated_at":"2018-11-23T03:15:36Z","pushed_at":"2018-11-23T03:07:40Z","git_url":"git://github.com/GoogleChromeLabs/carlo.git","ssh_url":"git@github.com:GoogleChromeLabs/carlo.git","clone_url":"https://github.com/GoogleChromeLabs/carlo.git","svn_url":"https://github.com/GoogleChromeLabs/carlo","homepage":"","size":341,"stargazers_count":6665,"watchers_count":6665,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":176,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":176,"open_issues":17,"watchers":6665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94"},"html":{"href":"https://github.com/GoogleChromeLabs/carlo/pull/94"},"issue":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues/94"},"comments":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChromeLabs/carlo/statuses/453b1fc768d0ecd854025218b8a63ec7d5a1da61"}},"author_association":"NONE"}}
{"actor":{"display_login":"liudonghua123"}}