{"action":"created","issue":{"url":"https://api.github.com/repos/openLRSng/openLRSng/issues/184","repository_url":"https://api.github.com/repos/openLRSng/openLRSng","labels_url":"https://api.github.com/repos/openLRSng/openLRSng/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/openLRSng/openLRSng/issues/184/comments","events_url":"https://api.github.com/repos/openLRSng/openLRSng/issues/184/events","html_url":"https://github.com/openLRSng/openLRSng/issues/184","id":293782420,"number":184,"title":"Review RFM register settings","user":{"login":"csurf","id":627526,"avatar_url":"https://avatars3.githubusercontent.com/u/627526?v=4","gravatar_id":"","url":"https://api.github.com/users/csurf","html_url":"https://github.com/csurf","followers_url":"https://api.github.com/users/csurf/followers","following_url":"https://api.github.com/users/csurf/following{/other_user}","gists_url":"https://api.github.com/users/csurf/gists{/gist_id}","starred_url":"https://api.github.com/users/csurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csurf/subscriptions","organizations_url":"https://api.github.com/users/csurf/orgs","repos_url":"https://api.github.com/users/csurf/repos","events_url":"https://api.github.com/users/csurf/events{/privacy}","received_events_url":"https://api.github.com/users/csurf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-02T06:02:34Z","updated_at":"2018-02-02T08:17:07Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"For those that have experience working with the RFM22B and/or have good experience with general RF concepts, I think it might be worthwhile to revisit & discuss the various register settings that are currently being used to configure the RFM module within the openLRSng code.\r\n\r\nhere are links to the relevant code:\r\nhttps://github.com/openLRSng/openLRSng/blob/master/openLRSng/RFM.h#L229\r\nhttps://github.com/openLRSng/openLRSng/blob/master/openLRSng/RFM.h#L185\r\nhttps://github.com/openLRSng/openLRSng/blob/master/openLRSng/binding.h#L161\r\n\r\nlink to datasheets stored in the wiki repo:\r\nhttps://github.com/openLRSng/openLRSngWiki/tree/master/datasheets\r\n\r\nAll of the current RFM settings were initially setup by kha, and I'm not sure if they were carried over from some previous version of openLRS, or if he came up with them by himself. There wasn't much documentation/comments within the code (I tried to add comments for what I could decipher), so we'd have to dig through the datasheets to figure out what the various register settings are meant to achieve.\r\n\r\nBasically, I think we should try to get a better understanding on why these settings are being used, and also if they perhaps should be tweaked for our application in order to try to achieve better performance .  Perhaps we can improve on the datarates and/or sensitivity by adjusting & testing different register settings?\r\n"},"comment":{"url":"https://api.github.com/repos/openLRSng/openLRSng/issues/comments/362516626","html_url":"https://github.com/openLRSng/openLRSng/issues/184#issuecomment-362516626","issue_url":"https://api.github.com/repos/openLRSng/openLRSng/issues/184","id":362516626,"user":{"login":"atomiclama","id":6804785,"avatar_url":"https://avatars1.githubusercontent.com/u/6804785?v=4","gravatar_id":"","url":"https://api.github.com/users/atomiclama","html_url":"https://github.com/atomiclama","followers_url":"https://api.github.com/users/atomiclama/followers","following_url":"https://api.github.com/users/atomiclama/following{/other_user}","gists_url":"https://api.github.com/users/atomiclama/gists{/gist_id}","starred_url":"https://api.github.com/users/atomiclama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomiclama/subscriptions","organizations_url":"https://api.github.com/users/atomiclama/orgs","repos_url":"https://api.github.com/users/atomiclama/repos","events_url":"https://api.github.com/users/atomiclama/events{/privacy}","received_events_url":"https://api.github.com/users/atomiclama/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T08:17:07Z","updated_at":"2018-02-02T08:17:07Z","author_association":"NONE","body":"Is the Hope chip a copy of the Si chip ?\r\n\r\nFound this a while back but never got round to comparing the register results or evaluating which was better. From code or from calculated.\r\n\r\n[Si443x-Register-Settings_RevB1.zip](https://github.com/openLRSng/openLRSng/files/1688532/Si443x-Register-Settings_RevB1.zip)\r\n\r\nI'll add it her as it maybe of help to someone."}}
{"actor":{"display_login":"atomiclama"}}