{"action":"created","issue":{"url":"https://api.github.com/repos/zold-io/zold/issues/314","repository_url":"https://api.github.com/repos/zold-io/zold","labels_url":"https://api.github.com/repos/zold-io/zold/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/zold-io/zold/issues/314/comments","events_url":"https://api.github.com/repos/zold-io/zold/issues/314/events","html_url":"https://github.com/zold-io/zold/issues/314","id":337189974,"node_id":"MDU6SXNzdWUzMzcxODk5NzQ=","number":314,"title":"Remotes.rb should ignore non-matching networks","user":{"login":"yegor256","id":526301,"node_id":"MDQ6VXNlcjUyNjMwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/526301?v=4","gravatar_id":"","url":"https://api.github.com/users/yegor256","html_url":"https://github.com/yegor256","followers_url":"https://api.github.com/users/yegor256/followers","following_url":"https://api.github.com/users/yegor256/following{/other_user}","gists_url":"https://api.github.com/users/yegor256/gists{/gist_id}","starred_url":"https://api.github.com/users/yegor256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegor256/subscriptions","organizations_url":"https://api.github.com/users/yegor256/orgs","repos_url":"https://api.github.com/users/yegor256/repos","events_url":"https://api.github.com/users/yegor256/events{/privacy}","received_events_url":"https://api.github.com/users/yegor256/received_events","type":"User","site_admin":false},"labels":[{"id":817986757,"node_id":"MDU6TGFiZWw4MTc5ODY3NTc=","url":"https://api.github.com/repos/zold-io/zold/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":937984717,"node_id":"MDU6TGFiZWw5Mzc5ODQ3MTc=","url":"https://api.github.com/repos/zold-io/zold/labels/scope","name":"scope","color":"3a6622","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-30T05:54:50Z","updated_at":"2018-07-04T09:11:48Z","closed_at":null,"author_association":"COLLABORATOR","body":"Let's add an extra validation step for `Remotes::Remote` to check that the `network` matches. If we fetch JSON that contains `network` that doesn't match what we have encapsulated, we should raise an exception."},"comment":{"url":"https://api.github.com/repos/zold-io/zold/issues/comments/402417012","html_url":"https://github.com/zold-io/zold/issues/314#issuecomment-402417012","issue_url":"https://api.github.com/repos/zold-io/zold/issues/314","id":402417012,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjQxNzAxMg==","user":{"login":"mgrassotti","id":6908677,"node_id":"MDQ6VXNlcjY5MDg2Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6908677?v=4","gravatar_id":"","url":"https://api.github.com/users/mgrassotti","html_url":"https://github.com/mgrassotti","followers_url":"https://api.github.com/users/mgrassotti/followers","following_url":"https://api.github.com/users/mgrassotti/following{/other_user}","gists_url":"https://api.github.com/users/mgrassotti/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrassotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrassotti/subscriptions","organizations_url":"https://api.github.com/users/mgrassotti/orgs","repos_url":"https://api.github.com/users/mgrassotti/repos","events_url":"https://api.github.com/users/mgrassotti/events{/privacy}","received_events_url":"https://api.github.com/users/mgrassotti/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T09:11:48Z","updated_at":"2018-07-04T09:11:48Z","author_association":"NONE","body":"hi @yegor256, sorry could you specify more _\"If we fetch JSON that contains `network` that doesn't match what we have encapsulated\"_ ? With _encapsulation_, do you mean initialization `Remote#new` at `lib/zold/remotes.rb:63`? \r\n\r\nWhere can we load a new network? Is that in `Fetch#new` at /Users/mateosky/dev/zold/lib/zold/commands/fetch.rb:41\" ? \r\n\r\nThanks"}}
{"actor":{"display_login":"mgrassotti"}}