{"action":"created","comment":{"url":"https://api.github.com/repos/lyft/verdaccio/pulls/comments/213855731","pull_request_review_id":150780301,"id":213855731,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzg1NTczMQ==","diff_hunk":"@@ -274,13 +279,29 @@ class Storage implements IStorageHandler {\n    * @property {function} options.callback Callback for receive data\n    */\n   getPackage(options: any) {\n-    this.localStorage.getPackageMetadata(options.name, (err, data) => {\n+    const self = this;\n+    cacache.get.info(self.metadataCachePath, options.name).then((data) => {\n+      if (data) {\n+        console.log(`Metadata from cache: ${options.name}`);","path":"src/lib/storage.js","position":32,"original_position":32,"commit_id":"18bd7aaa57b02a70a278bf00d84225efb51cbedb","original_commit_id":"265d97e75e4476952dda23b65e71528cfab45edc","user":{"login":"dschaller","id":1004789,"node_id":"MDQ6VXNlcjEwMDQ3ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1004789?v=4","gravatar_id":"","url":"https://api.github.com/users/dschaller","html_url":"https://github.com/dschaller","followers_url":"https://api.github.com/users/dschaller/followers","following_url":"https://api.github.com/users/dschaller/following{/other_user}","gists_url":"https://api.github.com/users/dschaller/gists{/gist_id}","starred_url":"https://api.github.com/users/dschaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschaller/subscriptions","organizations_url":"https://api.github.com/users/dschaller/orgs","repos_url":"https://api.github.com/users/dschaller/repos","events_url":"https://api.github.com/users/dschaller/events{/privacy}","received_events_url":"https://api.github.com/users/dschaller/received_events","type":"User","site_admin":false},"body":"Maybe change this to a debug log","created_at":"2018-08-29T22:34:13Z","updated_at":"2018-08-29T22:34:13Z","html_url":"https://github.com/lyft/verdaccio/pull/4#discussion_r213855731","pull_request_url":"https://api.github.com/repos/lyft/verdaccio/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lyft/verdaccio/pulls/comments/213855731"},"html":{"href":"https://github.com/lyft/verdaccio/pull/4#discussion_r213855731"},"pull_request":{"href":"https://api.github.com/repos/lyft/verdaccio/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/lyft/verdaccio/pulls/4","id":209975566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTc1NTY2","html_url":"https://github.com/lyft/verdaccio/pull/4","diff_url":"https://github.com/lyft/verdaccio/pull/4.diff","patch_url":"https://github.com/lyft/verdaccio/pull/4.patch","issue_url":"https://api.github.com/repos/lyft/verdaccio/issues/4","number":4,"state":"open","locked":false,"title":"Caching Features","user":{"login":"jackding96","id":34718243,"node_id":"MDQ6VXNlcjM0NzE4MjQz","avatar_url":"https://avatars2.githubusercontent.com/u/34718243?v=4","gravatar_id":"","url":"https://api.github.com/users/jackding96","html_url":"https://github.com/jackding96","followers_url":"https://api.github.com/users/jackding96/followers","following_url":"https://api.github.com/users/jackding96/following{/other_user}","gists_url":"https://api.github.com/users/jackding96/gists{/gist_id}","starred_url":"https://api.github.com/users/jackding96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackding96/subscriptions","organizations_url":"https://api.github.com/users/jackding96/orgs","repos_url":"https://api.github.com/users/jackding96/repos","events_url":"https://api.github.com/users/jackding96/events{/privacy}","received_events_url":"https://api.github.com/users/jackding96/received_events","type":"User","site_admin":false},"body":"<!--\r\n\r\nBefore Pull Request check whether your commits follow this convention\r\n\r\nhttps://github.com/verdaccio/verdaccio/blob/master/CONTRIBUTING.md#git-commit-guidelines\r\n\r\n  * If your PR fix an issue don't forget to update the unit test and documentation in /docs folder\r\n  * If your PR delivers a new feature, please, provide examples and why such feature should be considered.\r\n  * Document your changes /docs\r\n  * Add unit test\r\n  * Follow the commit guidelines in order to get a quick approval\r\n\r\nPick one/multiple type, if none apply please suggest one, we might be included it by default\r\n\r\neg: bug / feature / documentation / unit test / build\r\n\r\n-->\r\n**Type:**\r\n\r\nThe following has been addressed in the PR:\r\n\r\n*  There is a related issue?\r\n*  Unit or Functional tests are included in the PR\r\n\r\n**Description:**\r\n\r\n<!-- Resolves #??? -->\r\n","created_at":"2018-08-21T22:39:50Z","updated_at":"2018-08-29T22:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a3267515d27fae0cb4f059968c05997370d93c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lyft/verdaccio/pulls/4/commits","review_comments_url":"https://api.github.com/repos/lyft/verdaccio/pulls/4/comments","review_comment_url":"https://api.github.com/repos/lyft/verdaccio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lyft/verdaccio/issues/4/comments","statuses_url":"https://api.github.com/repos/lyft/verdaccio/statuses/18bd7aaa57b02a70a278bf00d84225efb51cbedb","head":{"label":"lyft:add-caching","ref":"add-caching","sha":"18bd7aaa57b02a70a278bf00d84225efb51cbedb","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":145041040,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwNDEwNDA=","name":"verdaccio","full_name":"lyft/verdaccio","owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/verdaccio","description":"📦🔐A lightweight private npm proxy registry","fork":true,"url":"https://api.github.com/repos/lyft/verdaccio","forks_url":"https://api.github.com/repos/lyft/verdaccio/forks","keys_url":"https://api.github.com/repos/lyft/verdaccio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/verdaccio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/verdaccio/teams","hooks_url":"https://api.github.com/repos/lyft/verdaccio/hooks","issue_events_url":"https://api.github.com/repos/lyft/verdaccio/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/verdaccio/events","assignees_url":"https://api.github.com/repos/lyft/verdaccio/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/verdaccio/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/verdaccio/tags","blobs_url":"https://api.github.com/repos/lyft/verdaccio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/verdaccio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/verdaccio/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/verdaccio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/verdaccio/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/verdaccio/languages","stargazers_url":"https://api.github.com/repos/lyft/verdaccio/stargazers","contributors_url":"https://api.github.com/repos/lyft/verdaccio/contributors","subscribers_url":"https://api.github.com/repos/lyft/verdaccio/subscribers","subscription_url":"https://api.github.com/repos/lyft/verdaccio/subscription","commits_url":"https://api.github.com/repos/lyft/verdaccio/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/verdaccio/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/verdaccio/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/verdaccio/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/verdaccio/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/verdaccio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/verdaccio/merges","archive_url":"https://api.github.com/repos/lyft/verdaccio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/verdaccio/downloads","issues_url":"https://api.github.com/repos/lyft/verdaccio/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/verdaccio/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/verdaccio/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/verdaccio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/verdaccio/labels{/name}","releases_url":"https://api.github.com/repos/lyft/verdaccio/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/verdaccio/deployments","created_at":"2018-08-16T21:30:58Z","updated_at":"2018-08-21T02:28:11Z","pushed_at":"2018-08-29T22:14:45Z","git_url":"git://github.com/lyft/verdaccio.git","ssh_url":"git@github.com:lyft/verdaccio.git","clone_url":"https://github.com/lyft/verdaccio.git","svn_url":"https://github.com/lyft/verdaccio","homepage":"https://www.verdaccio.org/","size":25917,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lyft:master","ref":"master","sha":"c0d935001071af5636c8bef41c929d25216a808b","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":145041040,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwNDEwNDA=","name":"verdaccio","full_name":"lyft/verdaccio","owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/verdaccio","description":"📦🔐A lightweight private npm proxy registry","fork":true,"url":"https://api.github.com/repos/lyft/verdaccio","forks_url":"https://api.github.com/repos/lyft/verdaccio/forks","keys_url":"https://api.github.com/repos/lyft/verdaccio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/verdaccio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/verdaccio/teams","hooks_url":"https://api.github.com/repos/lyft/verdaccio/hooks","issue_events_url":"https://api.github.com/repos/lyft/verdaccio/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/verdaccio/events","assignees_url":"https://api.github.com/repos/lyft/verdaccio/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/verdaccio/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/verdaccio/tags","blobs_url":"https://api.github.com/repos/lyft/verdaccio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/verdaccio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/verdaccio/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/verdaccio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/verdaccio/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/verdaccio/languages","stargazers_url":"https://api.github.com/repos/lyft/verdaccio/stargazers","contributors_url":"https://api.github.com/repos/lyft/verdaccio/contributors","subscribers_url":"https://api.github.com/repos/lyft/verdaccio/subscribers","subscription_url":"https://api.github.com/repos/lyft/verdaccio/subscription","commits_url":"https://api.github.com/repos/lyft/verdaccio/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/verdaccio/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/verdaccio/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/verdaccio/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/verdaccio/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/verdaccio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/verdaccio/merges","archive_url":"https://api.github.com/repos/lyft/verdaccio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/verdaccio/downloads","issues_url":"https://api.github.com/repos/lyft/verdaccio/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/verdaccio/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/verdaccio/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/verdaccio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/verdaccio/labels{/name}","releases_url":"https://api.github.com/repos/lyft/verdaccio/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/verdaccio/deployments","created_at":"2018-08-16T21:30:58Z","updated_at":"2018-08-21T02:28:11Z","pushed_at":"2018-08-29T22:14:45Z","git_url":"git://github.com/lyft/verdaccio.git","ssh_url":"git@github.com:lyft/verdaccio.git","clone_url":"https://github.com/lyft/verdaccio.git","svn_url":"https://github.com/lyft/verdaccio","homepage":"https://www.verdaccio.org/","size":25917,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lyft/verdaccio/pulls/4"},"html":{"href":"https://github.com/lyft/verdaccio/pull/4"},"issue":{"href":"https://api.github.com/repos/lyft/verdaccio/issues/4"},"comments":{"href":"https://api.github.com/repos/lyft/verdaccio/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/lyft/verdaccio/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/lyft/verdaccio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lyft/verdaccio/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/lyft/verdaccio/statuses/18bd7aaa57b02a70a278bf00d84225efb51cbedb"}},"author_association":"NONE"}}
{"actor":{"display_login":"dschaller"}}