{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/smart-proxy/issues/613","repository_url":"https://api.github.com/repos/theforeman/smart-proxy","labels_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/613/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/613/comments","events_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/613/events","html_url":"https://github.com/theforeman/smart-proxy/pull/613","id":369894599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzEwNTU4","number":613,"title":"Fixes #25293 - Puma support for smart proxy","user":{"login":"ik5","id":73091,"node_id":"MDQ6VXNlcjczMDkx","avatar_url":"https://avatars0.githubusercontent.com/u/73091?v=4","gravatar_id":"","url":"https://api.github.com/users/ik5","html_url":"https://github.com/ik5","followers_url":"https://api.github.com/users/ik5/followers","following_url":"https://api.github.com/users/ik5/following{/other_user}","gists_url":"https://api.github.com/users/ik5/gists{/gist_id}","starred_url":"https://api.github.com/users/ik5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ik5/subscriptions","organizations_url":"https://api.github.com/users/ik5/orgs","repos_url":"https://api.github.com/users/ik5/repos","events_url":"https://api.github.com/users/ik5/events{/privacy}","received_events_url":"https://api.github.com/users/ik5/received_events","type":"User","site_admin":false},"labels":[{"id":115870500,"node_id":"MDU6TGFiZWwxMTU4NzA1MDA=","url":"https://api.github.com/repos/theforeman/smart-proxy/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":115870557,"node_id":"MDU6TGFiZWwxMTU4NzA1NTc=","url":"https://api.github.com/repos/theforeman/smart-proxy/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-10-14T11:47:28Z","updated_at":"2018-10-24T13:01:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/613","html_url":"https://github.com/theforeman/smart-proxy/pull/613","diff_url":"https://github.com/theforeman/smart-proxy/pull/613.diff","patch_url":"https://github.com/theforeman/smart-proxy/pull/613.patch"},"body":"Work in progress (still did not test it or wrote any tests for it), loading puma (or) webrick as an HTTP Server.\r\n\r\nStarted earlier today to work on it, most of it done, but not all :) "},"comment":{"url":"https://api.github.com/repos/theforeman/smart-proxy/issues/comments/432645515","html_url":"https://github.com/theforeman/smart-proxy/pull/613#issuecomment-432645515","issue_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/613","id":432645515,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY0NTUxNQ==","user":{"login":"lzap","id":49752,"node_id":"MDQ6VXNlcjQ5NzUy","avatar_url":"https://avatars0.githubusercontent.com/u/49752?v=4","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T13:01:05Z","updated_at":"2018-10-24T13:01:05Z","author_association":"MEMBER","body":"I think the way we handle UNIX signals is incorrect in the current version, we kinda do this (`signal_handler.rb`):\r\n\r\n    trap(:INT) { exit(0) }\r\n    trap(:TERM) { exit(0) }\r\n\r\nWe should change that and do graceful shutdown. Puma server has methods for graceful stop for both Single and Cluster classes called `stop_blocked`. We should also correct this for webrick which offers method called `shutdown`. There is no need of checking a timelimit, systemd will kill the process if it takes too long (45 secs by default) to gracefully terminate."}}
{"actor":{"display_login":"lzap"}}