{"action":"closed","number":3303,"pull_request":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/3303","id":233365418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzY1NDE4","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/3303","diff_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/3303.diff","patch_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/3303.patch","issue_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/3303","number":3303,"state":"closed","locked":false,"title":"fix(AutoControlledComponent): fix behaviour when undefined it passed","user":{"login":"layershifter","id":14183168,"node_id":"MDQ6VXNlcjE0MTgzMTY4","avatar_url":"https://avatars0.githubusercontent.com/u/14183168?v=4","gravatar_id":"","url":"https://api.github.com/users/layershifter","html_url":"https://github.com/layershifter","followers_url":"https://api.github.com/users/layershifter/followers","following_url":"https://api.github.com/users/layershifter/following{/other_user}","gists_url":"https://api.github.com/users/layershifter/gists{/gist_id}","starred_url":"https://api.github.com/users/layershifter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/layershifter/subscriptions","organizations_url":"https://api.github.com/users/layershifter/orgs","repos_url":"https://api.github.com/users/layershifter/repos","events_url":"https://api.github.com/users/layershifter/events{/privacy}","received_events_url":"https://api.github.com/users/layershifter/received_events","type":"User","site_admin":false},"body":"This PR backports changes from https://github.com/stardust-ui/react/pull/499\r\n\r\n---\r\n\r\nWe discussed this changes during meetings on the previous week, we need to change the behaviour of `AutoControlledComponent` to match React's.\r\n\r\nAn example that shows issue: https://codesandbox.io/s/l20mjn74zz\r\n\r\n---\r\n\r\nAfter this PR we can safely migrate to `getDerivedStateFromProps()` 👍 ","created_at":"2018-11-25T09:36:02Z","updated_at":"2018-11-25T09:39:52Z","closed_at":"2018-11-25T09:39:52Z","merged_at":"2018-11-25T09:39:52Z","merge_commit_sha":"fca403505c3aa87b5055d4413f185d8b7023ac36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/3303/commits","review_comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/3303/comments","review_comment_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/3303/comments","statuses_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/statuses/3122aee27747e831bb246d985869f4358d296a40","head":{"label":"Semantic-Org:fix/acc-will","ref":"fix/acc-will","sha":"3122aee27747e831bb246d985869f4358d296a40","user":{"login":"Semantic-Org","id":5796209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTYyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5796209?v=4","gravatar_id":"","url":"https://api.github.com/users/Semantic-Org","html_url":"https://github.com/Semantic-Org","followers_url":"https://api.github.com/users/Semantic-Org/followers","following_url":"https://api.github.com/users/Semantic-Org/following{/other_user}","gists_url":"https://api.github.com/users/Semantic-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Semantic-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semantic-Org/subscriptions","organizations_url":"https://api.github.com/users/Semantic-Org/orgs","repos_url":"https://api.github.com/users/Semantic-Org/repos","events_url":"https://api.github.com/users/Semantic-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Semantic-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":37734226,"node_id":"MDEwOlJlcG9zaXRvcnkzNzczNDIyNg==","name":"Semantic-UI-React","full_name":"Semantic-Org/Semantic-UI-React","private":false,"owner":{"login":"Semantic-Org","id":5796209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTYyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5796209?v=4","gravatar_id":"","url":"https://api.github.com/users/Semantic-Org","html_url":"https://github.com/Semantic-Org","followers_url":"https://api.github.com/users/Semantic-Org/followers","following_url":"https://api.github.com/users/Semantic-Org/following{/other_user}","gists_url":"https://api.github.com/users/Semantic-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Semantic-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semantic-Org/subscriptions","organizations_url":"https://api.github.com/users/Semantic-Org/orgs","repos_url":"https://api.github.com/users/Semantic-Org/repos","events_url":"https://api.github.com/users/Semantic-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Semantic-Org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Semantic-Org/Semantic-UI-React","description":"The official Semantic-UI-React integration","fork":false,"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React","forks_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/forks","keys_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/teams","hooks_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/hooks","issue_events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/events{/number}","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/events","assignees_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/assignees{/user}","branches_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/branches{/branch}","tags_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/tags","blobs_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/statuses/{sha}","languages_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/languages","stargazers_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/stargazers","contributors_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/contributors","subscribers_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/subscribers","subscription_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/subscription","commits_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/contents/{+path}","compare_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/merges","archive_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/downloads","issues_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues{/number}","pulls_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls{/number}","milestones_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/milestones{/number}","notifications_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/labels{/name}","releases_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/releases{/id}","deployments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/deployments","created_at":"2015-06-19T16:47:19Z","updated_at":"2018-11-25T09:31:40Z","pushed_at":"2018-11-25T09:39:52Z","git_url":"git://github.com/Semantic-Org/Semantic-UI-React.git","ssh_url":"git@github.com:Semantic-Org/Semantic-UI-React.git","clone_url":"https://github.com/Semantic-Org/Semantic-UI-React.git","svn_url":"https://github.com/Semantic-Org/Semantic-UI-React","homepage":"https://react.semantic-ui.com","size":144950,"stargazers_count":8345,"watchers_count":8345,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2118,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2118,"open_issues":118,"watchers":8345,"default_branch":"master"}},"base":{"label":"Semantic-Org:master","ref":"master","sha":"defd9783ad62aad50178ff4be9d1ee0d4d346d85","user":{"login":"Semantic-Org","id":5796209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTYyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5796209?v=4","gravatar_id":"","url":"https://api.github.com/users/Semantic-Org","html_url":"https://github.com/Semantic-Org","followers_url":"https://api.github.com/users/Semantic-Org/followers","following_url":"https://api.github.com/users/Semantic-Org/following{/other_user}","gists_url":"https://api.github.com/users/Semantic-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Semantic-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semantic-Org/subscriptions","organizations_url":"https://api.github.com/users/Semantic-Org/orgs","repos_url":"https://api.github.com/users/Semantic-Org/repos","events_url":"https://api.github.com/users/Semantic-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Semantic-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":37734226,"node_id":"MDEwOlJlcG9zaXRvcnkzNzczNDIyNg==","name":"Semantic-UI-React","full_name":"Semantic-Org/Semantic-UI-React","private":false,"owner":{"login":"Semantic-Org","id":5796209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTYyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5796209?v=4","gravatar_id":"","url":"https://api.github.com/users/Semantic-Org","html_url":"https://github.com/Semantic-Org","followers_url":"https://api.github.com/users/Semantic-Org/followers","following_url":"https://api.github.com/users/Semantic-Org/following{/other_user}","gists_url":"https://api.github.com/users/Semantic-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Semantic-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semantic-Org/subscriptions","organizations_url":"https://api.github.com/users/Semantic-Org/orgs","repos_url":"https://api.github.com/users/Semantic-Org/repos","events_url":"https://api.github.com/users/Semantic-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Semantic-Org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Semantic-Org/Semantic-UI-React","description":"The official Semantic-UI-React integration","fork":false,"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React","forks_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/forks","keys_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/teams","hooks_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/hooks","issue_events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/events{/number}","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/events","assignees_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/assignees{/user}","branches_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/branches{/branch}","tags_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/tags","blobs_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/statuses/{sha}","languages_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/languages","stargazers_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/stargazers","contributors_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/contributors","subscribers_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/subscribers","subscription_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/subscription","commits_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/contents/{+path}","compare_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/merges","archive_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/downloads","issues_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues{/number}","pulls_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls{/number}","milestones_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/milestones{/number}","notifications_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/labels{/name}","releases_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/releases{/id}","deployments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/deployments","created_at":"2015-06-19T16:47:19Z","updated_at":"2018-11-25T09:31:40Z","pushed_at":"2018-11-25T09:39:52Z","git_url":"git://github.com/Semantic-Org/Semantic-UI-React.git","ssh_url":"git@github.com:Semantic-Org/Semantic-UI-React.git","clone_url":"https://github.com/Semantic-Org/Semantic-UI-React.git","svn_url":"https://github.com/Semantic-Org/Semantic-UI-React","homepage":"https://react.semantic-ui.com","size":144950,"stargazers_count":8345,"watchers_count":8345,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2118,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2118,"open_issues":118,"watchers":8345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/3303"},"html":{"href":"https://github.com/Semantic-Org/Semantic-UI-React/pull/3303"},"issue":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/3303"},"comments":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/3303/comments"},"review_comments":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/3303/comments"},"review_comment":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/3303/commits"},"statuses":{"href":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/statuses/3122aee27747e831bb246d985869f4358d296a40"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"layershifter","id":14183168,"node_id":"MDQ6VXNlcjE0MTgzMTY4","avatar_url":"https://avatars0.githubusercontent.com/u/14183168?v=4","gravatar_id":"","url":"https://api.github.com/users/layershifter","html_url":"https://github.com/layershifter","followers_url":"https://api.github.com/users/layershifter/followers","following_url":"https://api.github.com/users/layershifter/following{/other_user}","gists_url":"https://api.github.com/users/layershifter/gists{/gist_id}","starred_url":"https://api.github.com/users/layershifter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/layershifter/subscriptions","organizations_url":"https://api.github.com/users/layershifter/orgs","repos_url":"https://api.github.com/users/layershifter/repos","events_url":"https://api.github.com/users/layershifter/events{/privacy}","received_events_url":"https://api.github.com/users/layershifter/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":78,"deletions":127,"changed_files":2}}
{"actor":{"display_login":"layershifter"}}