{"action":"created","comment":{"url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments/230881722","pull_request_review_id":171721280,"id":230881722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDg4MTcyMg==","diff_hunk":"@@ -506,7 +520,8 @@ void PageView::resetShapeRecognizer()\n {\n \tXOJ_CHECK_TYPE(PageView);\n \n-\tthis->inputHandler->resetShapeRecognizer();\n+\t// TODO: implement this\n+\t//this->inputHandler->resetShapeRecognizer();","path":"src/gui/PageView.cpp","position":null,"original_position":115,"commit_id":"77f4c14da828660e3debaf3ddead4c5431814ffb","original_commit_id":"aa7cba78ab01cf256daed713a3f4d37b06d56780","user":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-11-05T19:30:44Z","updated_at":"2018-11-05T19:30:44Z","html_url":"https://github.com/xournalpp/xournalpp/pull/280#discussion_r230881722","pull_request_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments/230881722"},"html":{"href":"https://github.com/xournalpp/xournalpp/pull/280#discussion_r230881722"},"pull_request":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280"}},"in_reply_to_id":230566462},"pull_request":{"url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280","id":228138322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTM4MzIy","html_url":"https://github.com/xournalpp/xournalpp/pull/280","diff_url":"https://github.com/xournalpp/xournalpp/pull/280.diff","patch_url":"https://github.com/xournalpp/xournalpp/pull/280.patch","issue_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/280","number":280,"state":"open","locked":false,"title":"Gtk3 merge","user":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"body":"Merged the GTK3 branch to the master, added the Option to build to GTK2 / GTK3.\r\n\r\n**NOT FINISHED YET - WORK IN PROGRESS**\r\nCurrently builds only with GTK2, but a lot of stuff already merged / fixed","created_at":"2018-11-03T20:03:01Z","updated_at":"2018-11-05T19:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72accf16beeadbeac2857693216751d9341cbdd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280/commits","review_comments_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280/comments","review_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/280/comments","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/77f4c14da828660e3debaf3ddead4c5431814ffb","head":{"label":"andreasb242:gtk3-merge","ref":"gtk3-merge","sha":"77f4c14da828660e3debaf3ddead4c5431814ffb","user":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"repo":{"id":155748630,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3NDg2MzA=","name":"xournalpp","full_name":"andreasb242/xournalpp","private":false,"owner":{"login":"andreasb242","id":822958,"node_id":"MDQ6VXNlcjgyMjk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/822958?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasb242","html_url":"https://github.com/andreasb242","followers_url":"https://api.github.com/users/andreasb242/followers","following_url":"https://api.github.com/users/andreasb242/following{/other_user}","gists_url":"https://api.github.com/users/andreasb242/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasb242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasb242/subscriptions","organizations_url":"https://api.github.com/users/andreasb242/orgs","repos_url":"https://api.github.com/users/andreasb242/repos","events_url":"https://api.github.com/users/andreasb242/events{/privacy}","received_events_url":"https://api.github.com/users/andreasb242/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andreasb242/xournalpp","description":"Notetaking software designed around a tablet. A C++ rewrite of Xournal. Moved from Sourceforge. Check out the legacy branch if libpoppler<0.16 on your system. The development branch has the newest features.","fork":true,"url":"https://api.github.com/repos/andreasb242/xournalpp","forks_url":"https://api.github.com/repos/andreasb242/xournalpp/forks","keys_url":"https://api.github.com/repos/andreasb242/xournalpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasb242/xournalpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasb242/xournalpp/teams","hooks_url":"https://api.github.com/repos/andreasb242/xournalpp/hooks","issue_events_url":"https://api.github.com/repos/andreasb242/xournalpp/issues/events{/number}","events_url":"https://api.github.com/repos/andreasb242/xournalpp/events","assignees_url":"https://api.github.com/repos/andreasb242/xournalpp/assignees{/user}","branches_url":"https://api.github.com/repos/andreasb242/xournalpp/branches{/branch}","tags_url":"https://api.github.com/repos/andreasb242/xournalpp/tags","blobs_url":"https://api.github.com/repos/andreasb242/xournalpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasb242/xournalpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasb242/xournalpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasb242/xournalpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasb242/xournalpp/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasb242/xournalpp/languages","stargazers_url":"https://api.github.com/repos/andreasb242/xournalpp/stargazers","contributors_url":"https://api.github.com/repos/andreasb242/xournalpp/contributors","subscribers_url":"https://api.github.com/repos/andreasb242/xournalpp/subscribers","subscription_url":"https://api.github.com/repos/andreasb242/xournalpp/subscription","commits_url":"https://api.github.com/repos/andreasb242/xournalpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasb242/xournalpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasb242/xournalpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasb242/xournalpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreasb242/xournalpp/contents/{+path}","compare_url":"https://api.github.com/repos/andreasb242/xournalpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasb242/xournalpp/merges","archive_url":"https://api.github.com/repos/andreasb242/xournalpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasb242/xournalpp/downloads","issues_url":"https://api.github.com/repos/andreasb242/xournalpp/issues{/number}","pulls_url":"https://api.github.com/repos/andreasb242/xournalpp/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasb242/xournalpp/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasb242/xournalpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasb242/xournalpp/labels{/name}","releases_url":"https://api.github.com/repos/andreasb242/xournalpp/releases{/id}","deployments_url":"https://api.github.com/repos/andreasb242/xournalpp/deployments","created_at":"2018-11-01T17:06:28Z","updated_at":"2018-11-03T10:01:26Z","pushed_at":"2018-11-05T19:27:10Z","git_url":"git://github.com/andreasb242/xournalpp.git","ssh_url":"git@github.com:andreasb242/xournalpp.git","clone_url":"https://github.com/andreasb242/xournalpp.git","svn_url":"https://github.com/andreasb242/xournalpp","homepage":"","size":16419,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xournalpp:master","ref":"master","sha":"ca0d07f04f1f35c897df171d6ba0178365bbd6dc","user":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"repo":{"id":11986447,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4NjQ0Nw==","name":"xournalpp","full_name":"xournalpp/xournalpp","private":false,"owner":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xournalpp/xournalpp","description":"Notetaking software designed around a tablet. A C++ rewrite of Xournal. Moved from Sourceforge. Check out the legacy branch if libpoppler<0.16 on your system. The development branch has the newest features.","fork":false,"url":"https://api.github.com/repos/xournalpp/xournalpp","forks_url":"https://api.github.com/repos/xournalpp/xournalpp/forks","keys_url":"https://api.github.com/repos/xournalpp/xournalpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xournalpp/xournalpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xournalpp/xournalpp/teams","hooks_url":"https://api.github.com/repos/xournalpp/xournalpp/hooks","issue_events_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/events{/number}","events_url":"https://api.github.com/repos/xournalpp/xournalpp/events","assignees_url":"https://api.github.com/repos/xournalpp/xournalpp/assignees{/user}","branches_url":"https://api.github.com/repos/xournalpp/xournalpp/branches{/branch}","tags_url":"https://api.github.com/repos/xournalpp/xournalpp/tags","blobs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xournalpp/xournalpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xournalpp/xournalpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/{sha}","languages_url":"https://api.github.com/repos/xournalpp/xournalpp/languages","stargazers_url":"https://api.github.com/repos/xournalpp/xournalpp/stargazers","contributors_url":"https://api.github.com/repos/xournalpp/xournalpp/contributors","subscribers_url":"https://api.github.com/repos/xournalpp/xournalpp/subscribers","subscription_url":"https://api.github.com/repos/xournalpp/xournalpp/subscription","commits_url":"https://api.github.com/repos/xournalpp/xournalpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xournalpp/xournalpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xournalpp/xournalpp/contents/{+path}","compare_url":"https://api.github.com/repos/xournalpp/xournalpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xournalpp/xournalpp/merges","archive_url":"https://api.github.com/repos/xournalpp/xournalpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xournalpp/xournalpp/downloads","issues_url":"https://api.github.com/repos/xournalpp/xournalpp/issues{/number}","pulls_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls{/number}","milestones_url":"https://api.github.com/repos/xournalpp/xournalpp/milestones{/number}","notifications_url":"https://api.github.com/repos/xournalpp/xournalpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xournalpp/xournalpp/labels{/name}","releases_url":"https://api.github.com/repos/xournalpp/xournalpp/releases{/id}","deployments_url":"https://api.github.com/repos/xournalpp/xournalpp/deployments","created_at":"2013-08-08T20:58:27Z","updated_at":"2018-11-04T19:00:12Z","pushed_at":"2018-11-05T19:27:12Z","git_url":"git://github.com/xournalpp/xournalpp.git","ssh_url":"git@github.com:xournalpp/xournalpp.git","clone_url":"https://github.com/xournalpp/xournalpp.git","svn_url":"https://github.com/xournalpp/xournalpp","homepage":"","size":15793,"stargazers_count":158,"watchers_count":158,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":39,"open_issues":101,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280"},"html":{"href":"https://github.com/xournalpp/xournalpp/pull/280"},"issue":{"href":"https://api.github.com/repos/xournalpp/xournalpp/issues/280"},"comments":{"href":"https://api.github.com/repos/xournalpp/xournalpp/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/xournalpp/xournalpp/statuses/77f4c14da828660e3debaf3ddead4c5431814ffb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andreasb242"}}