{"action":"closed","number":24125,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/24125","id":234216063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjE2MDYz","html_url":"https://github.com/mantidproject/mantid/pull/24125","diff_url":"https://github.com/mantidproject/mantid/pull/24125.diff","patch_url":"https://github.com/mantidproject/mantid/pull/24125.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/24125","number":24125,"state":"closed","locked":false,"title":"Revert polarisation correction property names","user":{"login":"gemmaguest","id":12895056,"node_id":"MDQ6VXNlcjEyODk1MDU2","avatar_url":"https://avatars2.githubusercontent.com/u/12895056?v=4","gravatar_id":"","url":"https://api.github.com/users/gemmaguest","html_url":"https://github.com/gemmaguest","followers_url":"https://api.github.com/users/gemmaguest/followers","following_url":"https://api.github.com/users/gemmaguest/following{/other_user}","gists_url":"https://api.github.com/users/gemmaguest/gists{/gist_id}","starred_url":"https://api.github.com/users/gemmaguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemmaguest/subscriptions","organizations_url":"https://api.github.com/users/gemmaguest/orgs","repos_url":"https://api.github.com/users/gemmaguest/repos","events_url":"https://api.github.com/users/gemmaguest/events{/privacy}","received_events_url":"https://api.github.com/users/gemmaguest/received_events","type":"User","site_admin":false},"body":"The property names for polarisation correction coefficients were changed in v3.13 to be consistent with the child algorithms that perform polarisation corrections. However, the changes mean that the algorithm is no longer backwards compatible. The old names have been reinstated in the current (v2) version of the algorithm.\r\n\r\n**Description of work.**\r\n\r\n**Report to:** Jos at ISIS\r\n\r\n**To test:**\r\nThis script should work. In v3.13 it failed with an error about unknown property CRho.\r\n```\r\nLoad(Filename='INTER13460',OutputWorkspace='ws')\r\nReflectometryReductionOneAuto(InputWorkspace='ws',CRho='1',CAlpha='1',CAp='1',CPp='1')\r\n```\r\n\r\nRefs #23818\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://developer.mantidproject.org/IndividualTicketTesting/)):\r\n\r\n##### Code Review #####\r\n\r\n- Is the code of an acceptable quality?\r\n- Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)?\r\n- Are the unit tests small and test the class in isolation?\r\n- If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- Do changes function as described? Add comments below that describe the tests performed?\r\n- Do the changes handle unexpected situations, e.g. bad input?\r\n- Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-11-28T10:07:29Z","updated_at":"2018-11-30T10:19:24Z","closed_at":"2018-11-30T10:19:24Z","merged_at":"2018-11-30T10:19:24Z","merge_commit_sha":"39d07b4bf0daa67302293348a29eac06e3b388cd","assignee":{"login":"DTasev","id":9135965,"node_id":"MDQ6VXNlcjkxMzU5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/9135965?v=4","gravatar_id":"","url":"https://api.github.com/users/DTasev","html_url":"https://github.com/DTasev","followers_url":"https://api.github.com/users/DTasev/followers","following_url":"https://api.github.com/users/DTasev/following{/other_user}","gists_url":"https://api.github.com/users/DTasev/gists{/gist_id}","starred_url":"https://api.github.com/users/DTasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DTasev/subscriptions","organizations_url":"https://api.github.com/users/DTasev/orgs","repos_url":"https://api.github.com/users/DTasev/repos","events_url":"https://api.github.com/users/DTasev/events{/privacy}","received_events_url":"https://api.github.com/users/DTasev/received_events","type":"User","site_admin":false},"assignees":[{"login":"DTasev","id":9135965,"node_id":"MDQ6VXNlcjkxMzU5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/9135965?v=4","gravatar_id":"","url":"https://api.github.com/users/DTasev","html_url":"https://github.com/DTasev","followers_url":"https://api.github.com/users/DTasev/followers","following_url":"https://api.github.com/users/DTasev/following{/other_user}","gists_url":"https://api.github.com/users/DTasev/gists{/gist_id}","starred_url":"https://api.github.com/users/DTasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DTasev/subscriptions","organizations_url":"https://api.github.com/users/DTasev/orgs","repos_url":"https://api.github.com/users/DTasev/repos","events_url":"https://api.github.com/users/DTasev/events{/privacy}","received_events_url":"https://api.github.com/users/DTasev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":177607615,"node_id":"MDU6TGFiZWwxNzc2MDc2MTU=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800","default":false},{"id":40342862,"node_id":"MDU6TGFiZWw0MDM0Mjg2Mg==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800","default":false},{"id":40046083,"node_id":"MDU6TGFiZWw0MDA0NjA4Mw==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/68","html_url":"https://github.com/mantidproject/mantid/milestone/68","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/68/labels","id":3113735,"node_id":"MDk6TWlsZXN0b25lMzExMzczNQ==","number":68,"title":"Release 3.14 (4.0?)","description":"Code freeze: 1st Mar\r\nBeta test: 6th - 19th Mar","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":308,"closed_issues":762,"state":"open","created_at":"2018-02-13T15:42:17Z","updated_at":"2018-11-30T10:19:24Z","due_on":"2019-03-25T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/24125/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/24125/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/24125/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/ea273edc0f5e31e0f6539e7ccdc8b051f0142523","head":{"label":"gemmaguest:23818_revert_RROA_property_names","ref":"23818_revert_RROA_property_names","sha":"ea273edc0f5e31e0f6539e7ccdc8b051f0142523","user":{"login":"gemmaguest","id":12895056,"node_id":"MDQ6VXNlcjEyODk1MDU2","avatar_url":"https://avatars2.githubusercontent.com/u/12895056?v=4","gravatar_id":"","url":"https://api.github.com/users/gemmaguest","html_url":"https://github.com/gemmaguest","followers_url":"https://api.github.com/users/gemmaguest/followers","following_url":"https://api.github.com/users/gemmaguest/following{/other_user}","gists_url":"https://api.github.com/users/gemmaguest/gists{/gist_id}","starred_url":"https://api.github.com/users/gemmaguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemmaguest/subscriptions","organizations_url":"https://api.github.com/users/gemmaguest/orgs","repos_url":"https://api.github.com/users/gemmaguest/repos","events_url":"https://api.github.com/users/gemmaguest/events{/privacy}","received_events_url":"https://api.github.com/users/gemmaguest/received_events","type":"User","site_admin":false},"repo":{"id":97116558,"node_id":"MDEwOlJlcG9zaXRvcnk5NzExNjU1OA==","name":"mantid","full_name":"gemmaguest/mantid","private":false,"owner":{"login":"gemmaguest","id":12895056,"node_id":"MDQ6VXNlcjEyODk1MDU2","avatar_url":"https://avatars2.githubusercontent.com/u/12895056?v=4","gravatar_id":"","url":"https://api.github.com/users/gemmaguest","html_url":"https://github.com/gemmaguest","followers_url":"https://api.github.com/users/gemmaguest/followers","following_url":"https://api.github.com/users/gemmaguest/following{/other_user}","gists_url":"https://api.github.com/users/gemmaguest/gists{/gist_id}","starred_url":"https://api.github.com/users/gemmaguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemmaguest/subscriptions","organizations_url":"https://api.github.com/users/gemmaguest/orgs","repos_url":"https://api.github.com/users/gemmaguest/repos","events_url":"https://api.github.com/users/gemmaguest/events{/privacy}","received_events_url":"https://api.github.com/users/gemmaguest/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gemmaguest/mantid","description":"Main repository for Mantid code","fork":true,"url":"https://api.github.com/repos/gemmaguest/mantid","forks_url":"https://api.github.com/repos/gemmaguest/mantid/forks","keys_url":"https://api.github.com/repos/gemmaguest/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemmaguest/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemmaguest/mantid/teams","hooks_url":"https://api.github.com/repos/gemmaguest/mantid/hooks","issue_events_url":"https://api.github.com/repos/gemmaguest/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/gemmaguest/mantid/events","assignees_url":"https://api.github.com/repos/gemmaguest/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/gemmaguest/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/gemmaguest/mantid/tags","blobs_url":"https://api.github.com/repos/gemmaguest/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemmaguest/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemmaguest/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemmaguest/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemmaguest/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/gemmaguest/mantid/languages","stargazers_url":"https://api.github.com/repos/gemmaguest/mantid/stargazers","contributors_url":"https://api.github.com/repos/gemmaguest/mantid/contributors","subscribers_url":"https://api.github.com/repos/gemmaguest/mantid/subscribers","subscription_url":"https://api.github.com/repos/gemmaguest/mantid/subscription","commits_url":"https://api.github.com/repos/gemmaguest/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemmaguest/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemmaguest/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemmaguest/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemmaguest/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/gemmaguest/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemmaguest/mantid/merges","archive_url":"https://api.github.com/repos/gemmaguest/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemmaguest/mantid/downloads","issues_url":"https://api.github.com/repos/gemmaguest/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/gemmaguest/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/gemmaguest/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/gemmaguest/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemmaguest/mantid/labels{/name}","releases_url":"https://api.github.com/repos/gemmaguest/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/gemmaguest/mantid/deployments","created_at":"2017-07-13T11:46:12Z","updated_at":"2018-11-28T09:30:03Z","pushed_at":"2018-11-30T09:38:21Z","git_url":"git://github.com/gemmaguest/mantid.git","ssh_url":"git@github.com:gemmaguest/mantid.git","clone_url":"https://github.com/gemmaguest/mantid.git","svn_url":"https://github.com/gemmaguest/mantid","homepage":"www.mantidproject.org","size":518559,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"4f6f118ec526fa2a7960235749ffae8627d4daa3","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","private":false,"owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-11-30T08:36:06Z","pushed_at":"2018-11-30T10:19:24Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":523246,"stargazers_count":98,"watchers_count":98,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":1898,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":60,"open_issues":1898,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/24125"},"html":{"href":"https://github.com/mantidproject/mantid/pull/24125"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/24125"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/24125/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/24125/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/24125/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/ea273edc0f5e31e0f6539e7ccdc8b051f0142523"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"soininen","id":19147159,"node_id":"MDQ6VXNlcjE5MTQ3MTU5","avatar_url":"https://avatars3.githubusercontent.com/u/19147159?v=4","gravatar_id":"","url":"https://api.github.com/users/soininen","html_url":"https://github.com/soininen","followers_url":"https://api.github.com/users/soininen/followers","following_url":"https://api.github.com/users/soininen/following{/other_user}","gists_url":"https://api.github.com/users/soininen/gists{/gist_id}","starred_url":"https://api.github.com/users/soininen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soininen/subscriptions","organizations_url":"https://api.github.com/users/soininen/orgs","repos_url":"https://api.github.com/users/soininen/repos","events_url":"https://api.github.com/users/soininen/events{/privacy}","received_events_url":"https://api.github.com/users/soininen/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":44,"deletions":43,"changed_files":7}}
{"actor":{"display_login":"soininen"}}