{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/195481559","pull_request_review_id":128860152,"id":195481559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQ4MTU1OQ==","diff_hunk":"@@ -0,0 +1,153 @@\n+\"\"\"\n+    Base.SecretBuffer()\n+\n+An IOBuffer-like object where the contents will be securely wiped when garbage collected. However, it is\n+considered best practice to wipe the buffer using `Base.shred!(::SecretBuffer)` as soon as the\n+secure data are no longer required. Avoid initializing with converting to strings as they are","path":"base/secretbuffer.jl","position":6,"original_position":6,"commit_id":"c3c2bdcc4cbb820d0dea8acc6219430ac5b9f9b7","original_commit_id":"c3c2bdcc4cbb820d0dea8acc6219430ac5b9f9b7","user":{"login":"mbauman","id":154641,"node_id":"MDQ6VXNlcjE1NDY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/154641?v=4","gravatar_id":"","url":"https://api.github.com/users/mbauman","html_url":"https://github.com/mbauman","followers_url":"https://api.github.com/users/mbauman/followers","following_url":"https://api.github.com/users/mbauman/following{/other_user}","gists_url":"https://api.github.com/users/mbauman/gists{/gist_id}","starred_url":"https://api.github.com/users/mbauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbauman/subscriptions","organizations_url":"https://api.github.com/users/mbauman/orgs","repos_url":"https://api.github.com/users/mbauman/repos","events_url":"https://api.github.com/users/mbauman/events{/privacy}","received_events_url":"https://api.github.com/users/mbauman/received_events","type":"User","site_admin":false},"body":"Missed an \"and\" there —  I was intending: \"Avoid initializing with and converting to\".  Good point about swapping ordering here.","created_at":"2018-06-14T16:04:15Z","updated_at":"2018-06-14T16:04:15Z","html_url":"https://github.com/JuliaLang/julia/pull/27565#discussion_r195481559","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/27565","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/195481559"},"html":{"href":"https://github.com/JuliaLang/julia/pull/27565#discussion_r195481559"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27565"}},"in_reply_to_id":195281564},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/27565","id":194726829,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzI2ODI5","html_url":"https://github.com/JuliaLang/julia/pull/27565","diff_url":"https://github.com/JuliaLang/julia/pull/27565.diff","patch_url":"https://github.com/JuliaLang/julia/pull/27565.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/27565","number":27565,"state":"open","locked":false,"title":"RFC: Create SecretBuffer and use it to help keep LibGit2's secrets","user":{"login":"mbauman","id":154641,"node_id":"MDQ6VXNlcjE1NDY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/154641?v=4","gravatar_id":"","url":"https://api.github.com/users/mbauman","html_url":"https://github.com/mbauman","followers_url":"https://api.github.com/users/mbauman/followers","following_url":"https://api.github.com/users/mbauman/following{/other_user}","gists_url":"https://api.github.com/users/mbauman/gists{/gist_id}","starred_url":"https://api.github.com/users/mbauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbauman/subscriptions","organizations_url":"https://api.github.com/users/mbauman/orgs","repos_url":"https://api.github.com/users/mbauman/repos","events_url":"https://api.github.com/users/mbauman/events{/privacy}","received_events_url":"https://api.github.com/users/mbauman/received_events","type":"User","site_admin":false},"body":"This PR is building upon @omus' #24738, transitioned to using an `IO`-like API instead of an `AbstractString` one.  It definitely makes some things more awkward, but on the plus side, it also has made me vet and correct many places where we were still transitioning the secrets through `String`s in LibGit2.\r\n\r\nIt has the major downside that the returned object from `Base.prompt` changes drastically depending upon the `password` keyword.\r\n\r\nI initially tried following the approach in #24738, wherein _all_ the credential information (including usernames and key paths) is considered secret.  This proved to be horribly cumbersome and a huge dungeon of kludges and work-arounds.  This PR now only considers the passwords themselves to be secret — and that works quite well.","created_at":"2018-06-13T21:57:40Z","updated_at":"2018-06-14T16:04:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9993dfeaacc3a083780b1eebd20acd9c82c28db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":388665686,"node_id":"MDU6TGFiZWwzODg2NjU2ODY=","url":"https://api.github.com/repos/JuliaLang/julia/labels/libgit2","name":"libgit2","color":"0e8a16","default":false},{"id":608204380,"node_id":"MDU6TGFiZWw2MDgyMDQzODA=","url":"https://api.github.com/repos/JuliaLang/julia/labels/security","name":"security","color":"000000","default":false}],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/4","html_url":"https://github.com/JuliaLang/julia/milestone/4","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/4/labels","id":96266,"node_id":"MDk6TWlsZXN0b25lOTYyNjY=","number":4,"title":"0.7","description":"An intermediate release feature-equivalent to 1.0 but with deprecations.","creator":{"login":"StefanKarpinski","id":153596,"node_id":"MDQ6VXNlcjE1MzU5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/153596?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanKarpinski","html_url":"https://github.com/StefanKarpinski","followers_url":"https://api.github.com/users/StefanKarpinski/followers","following_url":"https://api.github.com/users/StefanKarpinski/following{/other_user}","gists_url":"https://api.github.com/users/StefanKarpinski/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKarpinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKarpinski/subscriptions","organizations_url":"https://api.github.com/users/StefanKarpinski/orgs","repos_url":"https://api.github.com/users/StefanKarpinski/repos","events_url":"https://api.github.com/users/StefanKarpinski/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKarpinski/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":504,"state":"open","created_at":"2012-03-15T04:57:43Z","updated_at":"2018-06-14T14:09:22Z","due_on":"2017-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/27565/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/27565/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/27565/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/c3c2bdcc4cbb820d0dea8acc6219430ac5b9f9b7","head":{"label":"JuliaLang:mb+cv/secretbuffer","ref":"mb+cv/secretbuffer","sha":"c3c2bdcc4cbb820d0dea8acc6219430ac5b9f9b7","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2018-06-14T15:11:27Z","pushed_at":"2018-06-14T15:09:58Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":407253,"stargazers_count":11250,"watchers_count":11250,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2377,"mirror_url":null,"archived":false,"open_issues_count":2608,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2377,"open_issues":2608,"watchers":11250,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"0658a119725d7347513b4cc7e1111d961cd7eb51","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2018-06-14T15:11:27Z","pushed_at":"2018-06-14T15:09:58Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":407253,"stargazers_count":11250,"watchers_count":11250,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2377,"mirror_url":null,"archived":false,"open_issues_count":2608,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2377,"open_issues":2608,"watchers":11250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27565"},"html":{"href":"https://github.com/JuliaLang/julia/pull/27565"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/27565"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/27565/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27565/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27565/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/c3c2bdcc4cbb820d0dea8acc6219430ac5b9f9b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mbauman"}}