{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/231763283","pull_request_review_id":172803517,"id":231763283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTc2MzI4Mw==","diff_hunk":"@@ -8,6 +8,7 @@ A logged warning is expected for each deprecated item that is in deprecation win\n \n ## Version 1.9.0 (pending)\n \n+* Order of execution of the write filter chain has been reversed. Prior to this release cycle it was incorrect, see [#4599](https://github.com/envoyproxy/envoy/issues/4599). In the 1.9.0 release cycle we introduced `bugfix_reverse_write_filter_order` in [lds.proto] (https://github.com/envoyproxy/envoy/blob/master/api/envoy/api/v2/lds.proto) to temporarily support both old and new behaviors. Note this boolean field is deprecated.","path":"DEPRECATED.md","position":4,"original_position":4,"commit_id":"72e1e7749cbc795537efa3aaa7af496385f0a741","original_commit_id":"72e1e7749cbc795537efa3aaa7af496385f0a741","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"Can you clarify \"network writer filter\" here and \"HTTP encoder filter\" below?","created_at":"2018-11-08T04:37:14Z","updated_at":"2018-11-08T04:37:18Z","html_url":"https://github.com/envoyproxy/envoy/pull/4889#discussion_r231763283","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/231763283"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4889#discussion_r231763283"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889","id":226437163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDM3MTYz","html_url":"https://github.com/envoyproxy/envoy/pull/4889","diff_url":"https://github.com/envoyproxy/envoy/pull/4889.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4889.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4889","number":4889,"state":"open","locked":false,"title":"api: add a field in Listener proto to be able to reverse the order of TCP write filters","user":{"login":"qiannawang","id":38573959,"node_id":"MDQ6VXNlcjM4NTczOTU5","avatar_url":"https://avatars2.githubusercontent.com/u/38573959?v=4","gravatar_id":"","url":"https://api.github.com/users/qiannawang","html_url":"https://github.com/qiannawang","followers_url":"https://api.github.com/users/qiannawang/followers","following_url":"https://api.github.com/users/qiannawang/following{/other_user}","gists_url":"https://api.github.com/users/qiannawang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiannawang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiannawang/subscriptions","organizations_url":"https://api.github.com/users/qiannawang/orgs","repos_url":"https://api.github.com/users/qiannawang/repos","events_url":"https://api.github.com/users/qiannawang/events{/privacy}","received_events_url":"https://api.github.com/users/qiannawang/received_events","type":"User","site_admin":false},"body":"*Description*: Add a field in listener proto to be able to reverse the order of TCP write filters. The field is set false by default, indicating write filters have the same order as configured in the filter chain. If true, their order will be reversed.\r\n*Risk Level*: Low\r\n*Testing*: bazel test //test/...\r\nPart of #4599\r\n","created_at":"2018-10-29T04:47:25Z","updated_at":"2018-11-08T04:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0dee3e7a393205535968e5ac2a8d883b1a4167b","assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zuercher","id":53179,"node_id":"MDQ6VXNlcjUzMTc5","avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4889/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/72e1e7749cbc795537efa3aaa7af496385f0a741","head":{"label":"qiannawang:httpfilter","ref":"httpfilter","sha":"72e1e7749cbc795537efa3aaa7af496385f0a741","user":{"login":"qiannawang","id":38573959,"node_id":"MDQ6VXNlcjM4NTczOTU5","avatar_url":"https://avatars2.githubusercontent.com/u/38573959?v=4","gravatar_id":"","url":"https://api.github.com/users/qiannawang","html_url":"https://github.com/qiannawang","followers_url":"https://api.github.com/users/qiannawang/followers","following_url":"https://api.github.com/users/qiannawang/following{/other_user}","gists_url":"https://api.github.com/users/qiannawang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiannawang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiannawang/subscriptions","organizations_url":"https://api.github.com/users/qiannawang/orgs","repos_url":"https://api.github.com/users/qiannawang/repos","events_url":"https://api.github.com/users/qiannawang/events{/privacy}","received_events_url":"https://api.github.com/users/qiannawang/received_events","type":"User","site_admin":false},"repo":{"id":155132815,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxMzI4MTU=","name":"envoy","full_name":"qiannawang/envoy","private":false,"owner":{"login":"qiannawang","id":38573959,"node_id":"MDQ6VXNlcjM4NTczOTU5","avatar_url":"https://avatars2.githubusercontent.com/u/38573959?v=4","gravatar_id":"","url":"https://api.github.com/users/qiannawang","html_url":"https://github.com/qiannawang","followers_url":"https://api.github.com/users/qiannawang/followers","following_url":"https://api.github.com/users/qiannawang/following{/other_user}","gists_url":"https://api.github.com/users/qiannawang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiannawang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiannawang/subscriptions","organizations_url":"https://api.github.com/users/qiannawang/orgs","repos_url":"https://api.github.com/users/qiannawang/repos","events_url":"https://api.github.com/users/qiannawang/events{/privacy}","received_events_url":"https://api.github.com/users/qiannawang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qiannawang/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/qiannawang/envoy","forks_url":"https://api.github.com/repos/qiannawang/envoy/forks","keys_url":"https://api.github.com/repos/qiannawang/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiannawang/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiannawang/envoy/teams","hooks_url":"https://api.github.com/repos/qiannawang/envoy/hooks","issue_events_url":"https://api.github.com/repos/qiannawang/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/qiannawang/envoy/events","assignees_url":"https://api.github.com/repos/qiannawang/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/qiannawang/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/qiannawang/envoy/tags","blobs_url":"https://api.github.com/repos/qiannawang/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiannawang/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiannawang/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiannawang/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiannawang/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/qiannawang/envoy/languages","stargazers_url":"https://api.github.com/repos/qiannawang/envoy/stargazers","contributors_url":"https://api.github.com/repos/qiannawang/envoy/contributors","subscribers_url":"https://api.github.com/repos/qiannawang/envoy/subscribers","subscription_url":"https://api.github.com/repos/qiannawang/envoy/subscription","commits_url":"https://api.github.com/repos/qiannawang/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiannawang/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiannawang/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiannawang/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiannawang/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/qiannawang/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiannawang/envoy/merges","archive_url":"https://api.github.com/repos/qiannawang/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiannawang/envoy/downloads","issues_url":"https://api.github.com/repos/qiannawang/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/qiannawang/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/qiannawang/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/qiannawang/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiannawang/envoy/labels{/name}","releases_url":"https://api.github.com/repos/qiannawang/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/qiannawang/envoy/deployments","created_at":"2018-10-29T01:13:02Z","updated_at":"2018-10-29T01:13:09Z","pushed_at":"2018-11-08T04:25:19Z","git_url":"git://github.com/qiannawang/envoy.git","ssh_url":"git@github.com:qiannawang/envoy.git","clone_url":"https://github.com/qiannawang/envoy.git","svn_url":"https://github.com/qiannawang/envoy","homepage":"https://www.envoyproxy.io","size":23125,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"f71a883b557a18cc418d4103b2f07a6780fc6576","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-11-08T04:35:07Z","pushed_at":"2018-11-08T04:25:22Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":23330,"stargazers_count":7079,"watchers_count":7079,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":976,"mirror_url":null,"archived":false,"open_issues_count":367,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":976,"open_issues":367,"watchers":7079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4889"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4889"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4889/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4889/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/72e1e7749cbc795537efa3aaa7af496385f0a741"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattklein123"}}