{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/181533290","pull_request_review_id":112187525,"id":181533290,"diff_hunk":"@@ -194,6 +194,7 @@ export class AmpLightboxGallery extends AMP.BaseElement {\n       this.element.appendChild(this.container_);\n       this.manager_.maybeInit();\n       this.buildMask_();\n+      this.registerAction('open', invocation => this.activate(invocation));","path":"extensions/amp-lightbox-gallery/0.1/amp-lightbox-gallery.js","position":4,"original_position":4,"commit_id":"3dc2452406ce23e337806c3ce5b98585dae821cc","original_commit_id":"3dc2452406ce23e337806c3ce5b98585dae821cc","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"also document in  https://github.com/ampproject/amphtml/blob/master/spec/amp-actions-and-events.md","created_at":"2018-04-14T00:07:36Z","updated_at":"2018-04-14T00:07:41Z","html_url":"https://github.com/ampproject/amphtml/pull/14618#discussion_r181533290","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14618","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/181533290"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14618#discussion_r181533290"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14618"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/14618","id":181598191,"html_url":"https://github.com/ampproject/amphtml/pull/14618","diff_url":"https://github.com/ampproject/amphtml/pull/14618.diff","patch_url":"https://github.com/ampproject/amphtml/pull/14618.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/14618","number":14618,"state":"open","locked":false,"title":"Add `open` action to `<amp-lightbox-gallery>` update demo with video, youtube, and ads ","user":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"body":"1. In preparation for QA, add `<amp-video>`, `<amp-youtube>`, `<amp-ad>` to the article demo for lightbox. \r\n2. Add the `open` action to `<amp-lightbox-gallery>`. ","created_at":"2018-04-13T21:17:00Z","updated_at":"2018-04-14T00:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3936e7b5aa03dd4772d3db290264866841217507","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14618/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14618/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/14618/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/3dc2452406ce23e337806c3ce5b98585dae821cc","head":{"label":"cathyxz:feature/demo-ads","ref":"feature/demo-ads","sha":"3dc2452406ce23e337806c3ce5b98585dae821cc","user":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"repo":{"id":108910422,"name":"amphtml","full_name":"cathyxz/amphtml","owner":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cathyxz/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/cathyxz/amphtml","forks_url":"https://api.github.com/repos/cathyxz/amphtml/forks","keys_url":"https://api.github.com/repos/cathyxz/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cathyxz/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cathyxz/amphtml/teams","hooks_url":"https://api.github.com/repos/cathyxz/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cathyxz/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cathyxz/amphtml/events","assignees_url":"https://api.github.com/repos/cathyxz/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cathyxz/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cathyxz/amphtml/tags","blobs_url":"https://api.github.com/repos/cathyxz/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cathyxz/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cathyxz/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cathyxz/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cathyxz/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cathyxz/amphtml/languages","stargazers_url":"https://api.github.com/repos/cathyxz/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cathyxz/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cathyxz/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cathyxz/amphtml/subscription","commits_url":"https://api.github.com/repos/cathyxz/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cathyxz/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cathyxz/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cathyxz/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cathyxz/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cathyxz/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cathyxz/amphtml/merges","archive_url":"https://api.github.com/repos/cathyxz/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cathyxz/amphtml/downloads","issues_url":"https://api.github.com/repos/cathyxz/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cathyxz/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cathyxz/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cathyxz/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cathyxz/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cathyxz/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cathyxz/amphtml/deployments","created_at":"2017-10-30T21:27:41Z","updated_at":"2018-04-13T20:36:02Z","pushed_at":"2018-04-13T23:32:33Z","git_url":"git://github.com/cathyxz/amphtml.git","ssh_url":"git@github.com:cathyxz/amphtml.git","clone_url":"https://github.com/cathyxz/amphtml.git","svn_url":"https://github.com/cathyxz/amphtml","homepage":"https://www.ampproject.org","size":416479,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"1d303f0dd7a6e7be6d0759ee7bbe851414293cec","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-04-13T23:23:00Z","pushed_at":"2018-04-13T23:54:27Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":417239,"stargazers_count":11434,"watchers_count":11434,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2329,"mirror_url":null,"archived":false,"open_issues_count":1278,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2329,"open_issues":1278,"watchers":11434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14618"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14618"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14618"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14618/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14618/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14618/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/3dc2452406ce23e337806c3ce5b98585dae821cc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aghassemi"}}