{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/242647547","pull_request_review_id":186209877,"id":242647547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY0NzU0Nw==","diff_hunk":"@@ -1,5 +1,5 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n-<!DOCTYPE translationbundle><translationbundle lang=\"en\">\n+<translationbundle lang=\"en\">","path":"i18n/messages-en.xtb","position":3,"original_position":3,"commit_id":"be879e2b3fd0cc68db4d875327560679bbb32e3e","original_commit_id":"be879e2b3fd0cc68db4d875327560679bbb32e3e","user":{"login":"FrenchBen","id":3965324,"node_id":"MDQ6VXNlcjM5NjUzMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3965324?v=4","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"body":"Nope - I did a rebase from master - I can rollback on that?","created_at":"2018-12-18T18:14:41Z","updated_at":"2018-12-18T18:14:41Z","html_url":"https://github.com/kubernetes/dashboard/pull/3197#discussion_r242647547","pull_request_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/242647547"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/3197#discussion_r242647547"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197"}},"in_reply_to_id":240496023},"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197","id":206174409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTc0NDA5","html_url":"https://github.com/kubernetes/dashboard/pull/3197","diff_url":"https://github.com/kubernetes/dashboard/pull/3197.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/3197.patch","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/3197","number":3197,"state":"open","locked":false,"title":"Add namespace support","user":{"login":"FrenchBen","id":3965324,"node_id":"MDQ6VXNlcjM5NjUzMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3965324?v=4","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"body":"When deploying the K8s Dashboard, it's possible to scope it to a certain namespace. Yet even within a namespace, other than `kube-system`, the dashboard will still try to add secrets to the `kube-system` ns.\r\n\r\nThis attempts to open the discussion around how to fix it. In this case, I've added a simple flag to the binary (still needs some tests and url validation).\r\n\r\nThe following flag was added:\r\n`--namespace string   When non-default namespace is used, create encryption key in the specified namespace. Default: 'kube-system'. (default \"kube-system\")`\r\n\r\nAnother idea is for the dashboard to lookup what namespace it's running in, and simply use that. :fire: and :speaking_head:  are welcome :)\r\n\r\n/assign @ianlewis \r\n","created_at":"2018-08-04T04:06:41Z","updated_at":"2018-12-18T18:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28332d76fb762ea2a967a86f7184114023296908","assignee":{"login":"jeefy","id":1394552,"node_id":"MDQ6VXNlcjEzOTQ1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1394552?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefy","html_url":"https://github.com/jeefy","followers_url":"https://api.github.com/users/jeefy/followers","following_url":"https://api.github.com/users/jeefy/following{/other_user}","gists_url":"https://api.github.com/users/jeefy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefy/subscriptions","organizations_url":"https://api.github.com/users/jeefy/orgs","repos_url":"https://api.github.com/users/jeefy/repos","events_url":"https://api.github.com/users/jeefy/events{/privacy}","received_events_url":"https://api.github.com/users/jeefy/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeefy","id":1394552,"node_id":"MDQ6VXNlcjEzOTQ1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1394552?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefy","html_url":"https://github.com/jeefy","followers_url":"https://api.github.com/users/jeefy/followers","following_url":"https://api.github.com/users/jeefy/following{/other_user}","gists_url":"https://api.github.com/users/jeefy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefy/subscriptions","organizations_url":"https://api.github.com/users/jeefy/orgs","repos_url":"https://api.github.com/users/jeefy/repos","events_url":"https://api.github.com/users/jeefy/events{/privacy}","received_events_url":"https://api.github.com/users/jeefy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":485595234,"node_id":"MDU6TGFiZWw0ODU1OTUyMzQ=","url":"https://api.github.com/repos/kubernetes/dashboard/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676234233,"node_id":"MDU6TGFiZWw2NzYyMzQyMzM=","url":"https://api.github.com/repos/kubernetes/dashboard/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197/commits","review_comments_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197/comments","review_comment_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/3197/comments","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/be879e2b3fd0cc68db4d875327560679bbb32e3e","head":{"label":"FrenchBen:key-namespace","ref":"key-namespace","sha":"be879e2b3fd0cc68db4d875327560679bbb32e3e","user":{"login":"FrenchBen","id":3965324,"node_id":"MDQ6VXNlcjM5NjUzMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3965324?v=4","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"repo":{"id":143349203,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzNDkyMDM=","name":"dashboard","full_name":"FrenchBen/dashboard","private":false,"owner":{"login":"FrenchBen","id":3965324,"node_id":"MDQ6VXNlcjM5NjUzMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3965324?v=4","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FrenchBen/dashboard","description":"General-purpose web UI for Kubernetes clusters","fork":true,"url":"https://api.github.com/repos/FrenchBen/dashboard","forks_url":"https://api.github.com/repos/FrenchBen/dashboard/forks","keys_url":"https://api.github.com/repos/FrenchBen/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrenchBen/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrenchBen/dashboard/teams","hooks_url":"https://api.github.com/repos/FrenchBen/dashboard/hooks","issue_events_url":"https://api.github.com/repos/FrenchBen/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/FrenchBen/dashboard/events","assignees_url":"https://api.github.com/repos/FrenchBen/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/FrenchBen/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/FrenchBen/dashboard/tags","blobs_url":"https://api.github.com/repos/FrenchBen/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrenchBen/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrenchBen/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrenchBen/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrenchBen/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/FrenchBen/dashboard/languages","stargazers_url":"https://api.github.com/repos/FrenchBen/dashboard/stargazers","contributors_url":"https://api.github.com/repos/FrenchBen/dashboard/contributors","subscribers_url":"https://api.github.com/repos/FrenchBen/dashboard/subscribers","subscription_url":"https://api.github.com/repos/FrenchBen/dashboard/subscription","commits_url":"https://api.github.com/repos/FrenchBen/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrenchBen/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrenchBen/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrenchBen/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrenchBen/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/FrenchBen/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrenchBen/dashboard/merges","archive_url":"https://api.github.com/repos/FrenchBen/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrenchBen/dashboard/downloads","issues_url":"https://api.github.com/repos/FrenchBen/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/FrenchBen/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/FrenchBen/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/FrenchBen/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrenchBen/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/FrenchBen/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/FrenchBen/dashboard/deployments","created_at":"2018-08-02T22:05:47Z","updated_at":"2018-12-11T03:21:16Z","pushed_at":"2018-12-11T03:21:08Z","git_url":"git://github.com/FrenchBen/dashboard.git","ssh_url":"git@github.com:FrenchBen/dashboard.git","clone_url":"https://github.com/FrenchBen/dashboard.git","svn_url":"https://github.com/FrenchBen/dashboard","homepage":"","size":117781,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e4e81bf5e4fccb96d8b128b386b3e378945cc9af","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":44350607,"node_id":"MDEwOlJlcG9zaXRvcnk0NDM1MDYwNw==","name":"dashboard","full_name":"kubernetes/dashboard","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/dashboard","description":"General-purpose web UI for Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/dashboard","forks_url":"https://api.github.com/repos/kubernetes/dashboard/forks","keys_url":"https://api.github.com/repos/kubernetes/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/dashboard/teams","hooks_url":"https://api.github.com/repos/kubernetes/dashboard/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/dashboard/events","assignees_url":"https://api.github.com/repos/kubernetes/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/dashboard/tags","blobs_url":"https://api.github.com/repos/kubernetes/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/dashboard/languages","stargazers_url":"https://api.github.com/repos/kubernetes/dashboard/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/dashboard/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/dashboard/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/dashboard/subscription","commits_url":"https://api.github.com/repos/kubernetes/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/dashboard/merges","archive_url":"https://api.github.com/repos/kubernetes/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/dashboard/downloads","issues_url":"https://api.github.com/repos/kubernetes/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/dashboard/deployments","created_at":"2015-10-15T23:09:14Z","updated_at":"2018-12-18T16:15:11Z","pushed_at":"2018-12-18T17:03:15Z","git_url":"git://github.com/kubernetes/dashboard.git","ssh_url":"git@github.com:kubernetes/dashboard.git","clone_url":"https://github.com/kubernetes/dashboard.git","svn_url":"https://github.com/kubernetes/dashboard","homepage":"","size":121593,"stargazers_count":3813,"watchers_count":3813,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1059,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1059,"open_issues":126,"watchers":3813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/3197"},"issue":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/3197"},"comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/3197/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/3197/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/dashboard/statuses/be879e2b3fd0cc68db4d875327560679bbb32e3e"}},"author_association":"NONE"}}
{"actor":{"display_login":"FrenchBen"}}