{"action":"created","issue":{"url":"https://api.github.com/repos/netdata/netdata/issues/5039","repository_url":"https://api.github.com/repos/netdata/netdata","labels_url":"https://api.github.com/repos/netdata/netdata/issues/5039/labels{/name}","comments_url":"https://api.github.com/repos/netdata/netdata/issues/5039/comments","events_url":"https://api.github.com/repos/netdata/netdata/issues/5039/events","html_url":"https://github.com/netdata/netdata/issues/5039","id":392556824,"node_id":"MDU6SXNzdWUzOTI1NTY4MjQ=","number":5039,"title":"Installer problem with config files under 'orig' symlink ","user":{"login":"cakrit","id":43294513,"node_id":"MDQ6VXNlcjQzMjk0NTEz","avatar_url":"https://avatars0.githubusercontent.com/u/43294513?v=4","gravatar_id":"","url":"https://api.github.com/users/cakrit","html_url":"https://github.com/cakrit","followers_url":"https://api.github.com/users/cakrit/followers","following_url":"https://api.github.com/users/cakrit/following{/other_user}","gists_url":"https://api.github.com/users/cakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/cakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakrit/subscriptions","organizations_url":"https://api.github.com/users/cakrit/orgs","repos_url":"https://api.github.com/users/cakrit/repos","events_url":"https://api.github.com/users/cakrit/events{/privacy}","received_events_url":"https://api.github.com/users/cakrit/received_events","type":"User","site_admin":false},"labels":[{"id":43793260,"node_id":"MDU6TGFiZWw0Mzc5MzI2MA==","url":"https://api.github.com/repos/netdata/netdata/labels/bug","name":"bug","color":"ba232a","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-19T11:26:30Z","updated_at":"2018-12-19T11:37:52Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"##### Bug report summary\r\n\r\nI ran the netdata-installer.sh today to test a PR and saw many lines like the following:\r\n\r\n```\r\nFile '/etc/netdata/orig/health.d/mysql.conf'  does not match stock of 'orig/health.d/mysql.conf'. Keeping it\r\n```\r\n\r\nThe .conf files are the same, the problem is that the filename for the stock config is wrong, because it includes `orig`. The paths in `configs.signatures`\r\n\r\nTwo additional executions didn't produce the same error, so there must be a condition that is checked before comparing the md5 sums (which do match entries in `configs.signatures`. \r\n\r\nSince the -L option is explicitly passed to `find` at https://github.com/netdata/netdata/blob/master/netdata-installer.sh#L493 the symlink should be followed. \r\ne problem is around https://github.com/netdata/netdata/blob/master/netdata-installer.sh#L499-501 where `t`, the string expected in `configs.signatures` is built. \r\n\r\n##### Component Name\r\ninstaller\r\n\r\n##### Steps To Reproduce\r\nNot sure how to run the installer to get it back. \r\n\r\n##### Expected behavior\r\nMatch the files that haven't been modified to the stock files. "},"comment":{"url":"https://api.github.com/repos/netdata/netdata/issues/comments/448564691","html_url":"https://github.com/netdata/netdata/issues/5039#issuecomment-448564691","issue_url":"https://api.github.com/repos/netdata/netdata/issues/5039","id":448564691,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODU2NDY5MQ==","user":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T11:37:52Z","updated_at":"2018-12-19T11:37:52Z","author_association":"MEMBER","body":"As far as I know we are going to remove `configs.signatures` and validation of `/etc/netdata` files since we are storing original configuration files in `/usr/...` and not in `/etc/...`. Right now we are in a transition phase when we are waiting for users to upgrade to newer netdata so we can proceed with removal of checksum file."}}
{"actor":{"display_login":"paulfantom"}}