{"action":"created","comment":{"url":"https://api.github.com/repos/dedis/cothority/pulls/comments/201641727","pull_request_review_id":136174709,"id":201641727,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY0MTcyNw==","diff_hunk":"@@ -118,7 +118,8 @@ func TestBftCoSi(t *testing.T) {\n \trequire.Nil(t, err)\n \n \tfor _, n := range []int{1, 2, 4, 9, 20} {\n-\t\trunProtocol(t, n, 0, 0, protoName)\n+\t\tnbrFault := FaultThreshold(n)\n+\t\trunProtocol(t, n, nbrFault, 0, protoName)","path":"byzcoinx/byzcoinx_test.go","position":6,"original_position":6,"commit_id":"5c981df15f8b784ae0f1641c39f1da6e96588920","original_commit_id":"5c981df15f8b784ae0f1641c39f1da6e96588920","user":{"login":"kc1212","id":1093806,"node_id":"MDQ6VXNlcjEwOTM4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1093806?v=4","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false},"body":"shouldn't this test check the scenario where we do not have any faults? because the faulty test is covered by `TestBftCoSiFault`","created_at":"2018-07-11T10:33:35Z","updated_at":"2018-07-11T10:58:16Z","html_url":"https://github.com/dedis/cothority/pull/1330#discussion_r201641727","pull_request_url":"https://api.github.com/repos/dedis/cothority/pulls/1330","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dedis/cothority/pulls/comments/201641727"},"html":{"href":"https://github.com/dedis/cothority/pull/1330#discussion_r201641727"},"pull_request":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1330"}}},"pull_request":{"url":"https://api.github.com/repos/dedis/cothority/pulls/1330","id":199005300,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDA1MzAw","html_url":"https://github.com/dedis/cothority/pull/1330","diff_url":"https://github.com/dedis/cothority/pull/1330.diff","patch_url":"https://github.com/dedis/cothority/pull/1330.patch","issue_url":"https://api.github.com/repos/dedis/cothority/issues/1330","number":1330,"state":"open","locked":false,"title":"Byzcoinx 1186","user":{"login":"ineiti","id":1545067,"node_id":"MDQ6VXNlcjE1NDUwNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"body":"This is the optimized implementation of ByzCoinX. It returns early whenever the threshold is reached. This works very well in a permissioned setting, however, in an unpermissioned setting, it can lead to censoring of slow nodes which will not get any mining reward.\r\n\r\nIt has been quite extensively tested in all test-suites, but there might still be some corner cases where it fails.","created_at":"2018-07-03T15:38:09Z","updated_at":"2018-07-11T10:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51e28bdd7f2d86c6373a4688b007a5f6acd9563f","assignee":{"login":"ineiti","id":1545067,"node_id":"MDQ6VXNlcjE1NDUwNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"assignees":[{"login":"ineiti","id":1545067,"node_id":"MDQ6VXNlcjE1NDUwNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dedis/cothority/pulls/1330/commits","review_comments_url":"https://api.github.com/repos/dedis/cothority/pulls/1330/comments","review_comment_url":"https://api.github.com/repos/dedis/cothority/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dedis/cothority/issues/1330/comments","statuses_url":"https://api.github.com/repos/dedis/cothority/statuses/5c981df15f8b784ae0f1641c39f1da6e96588920","head":{"label":"dedis:byzcoinx_1186","ref":"byzcoinx_1186","sha":"5c981df15f8b784ae0f1641c39f1da6e96588920","user":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":41791684,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc5MTY4NA==","name":"cothority","full_name":"dedis/cothority","owner":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dedis/cothority","description":"Scalable collective authority","fork":false,"url":"https://api.github.com/repos/dedis/cothority","forks_url":"https://api.github.com/repos/dedis/cothority/forks","keys_url":"https://api.github.com/repos/dedis/cothority/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/cothority/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/cothority/teams","hooks_url":"https://api.github.com/repos/dedis/cothority/hooks","issue_events_url":"https://api.github.com/repos/dedis/cothority/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/cothority/events","assignees_url":"https://api.github.com/repos/dedis/cothority/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/cothority/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/cothority/tags","blobs_url":"https://api.github.com/repos/dedis/cothority/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/cothority/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/cothority/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/cothority/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/cothority/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/cothority/languages","stargazers_url":"https://api.github.com/repos/dedis/cothority/stargazers","contributors_url":"https://api.github.com/repos/dedis/cothority/contributors","subscribers_url":"https://api.github.com/repos/dedis/cothority/subscribers","subscription_url":"https://api.github.com/repos/dedis/cothority/subscription","commits_url":"https://api.github.com/repos/dedis/cothority/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/cothority/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/cothority/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/cothority/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/cothority/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/cothority/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/cothority/merges","archive_url":"https://api.github.com/repos/dedis/cothority/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/cothority/downloads","issues_url":"https://api.github.com/repos/dedis/cothority/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/cothority/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/cothority/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/cothority/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/cothority/labels{/name}","releases_url":"https://api.github.com/repos/dedis/cothority/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/cothority/deployments","created_at":"2015-09-02T09:13:57Z","updated_at":"2018-07-10T11:23:10Z","pushed_at":"2018-07-11T09:11:17Z","git_url":"git://github.com/dedis/cothority.git","ssh_url":"git@github.com:dedis/cothority.git","clone_url":"https://github.com/dedis/cothority.git","svn_url":"https://github.com/dedis/cothority","homepage":"","size":80694,"stargazers_count":234,"watchers_count":234,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":71,"watchers":234,"default_branch":"master"}},"base":{"label":"dedis:master","ref":"master","sha":"1b622f495ff3d621c837e3afa8d40a810f9b8237","user":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":41791684,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc5MTY4NA==","name":"cothority","full_name":"dedis/cothority","owner":{"login":"dedis","id":3638331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dedis/cothority","description":"Scalable collective authority","fork":false,"url":"https://api.github.com/repos/dedis/cothority","forks_url":"https://api.github.com/repos/dedis/cothority/forks","keys_url":"https://api.github.com/repos/dedis/cothority/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/cothority/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/cothority/teams","hooks_url":"https://api.github.com/repos/dedis/cothority/hooks","issue_events_url":"https://api.github.com/repos/dedis/cothority/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/cothority/events","assignees_url":"https://api.github.com/repos/dedis/cothority/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/cothority/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/cothority/tags","blobs_url":"https://api.github.com/repos/dedis/cothority/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/cothority/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/cothority/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/cothority/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/cothority/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/cothority/languages","stargazers_url":"https://api.github.com/repos/dedis/cothority/stargazers","contributors_url":"https://api.github.com/repos/dedis/cothority/contributors","subscribers_url":"https://api.github.com/repos/dedis/cothority/subscribers","subscription_url":"https://api.github.com/repos/dedis/cothority/subscription","commits_url":"https://api.github.com/repos/dedis/cothority/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/cothority/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/cothority/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/cothority/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/cothority/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/cothority/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/cothority/merges","archive_url":"https://api.github.com/repos/dedis/cothority/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/cothority/downloads","issues_url":"https://api.github.com/repos/dedis/cothority/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/cothority/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/cothority/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/cothority/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/cothority/labels{/name}","releases_url":"https://api.github.com/repos/dedis/cothority/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/cothority/deployments","created_at":"2015-09-02T09:13:57Z","updated_at":"2018-07-10T11:23:10Z","pushed_at":"2018-07-11T09:11:17Z","git_url":"git://github.com/dedis/cothority.git","ssh_url":"git@github.com:dedis/cothority.git","clone_url":"https://github.com/dedis/cothority.git","svn_url":"https://github.com/dedis/cothority","homepage":"","size":80694,"stargazers_count":234,"watchers_count":234,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":71,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1330"},"html":{"href":"https://github.com/dedis/cothority/pull/1330"},"issue":{"href":"https://api.github.com/repos/dedis/cothority/issues/1330"},"comments":{"href":"https://api.github.com/repos/dedis/cothority/issues/1330/comments"},"review_comments":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1330/comments"},"review_comment":{"href":"https://api.github.com/repos/dedis/cothority/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dedis/cothority/pulls/1330/commits"},"statuses":{"href":"https://api.github.com/repos/dedis/cothority/statuses/5c981df15f8b784ae0f1641c39f1da6e96588920"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kc1212"}}