{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/223865392","pull_request_review_id":163099377,"id":223865392,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg2NTM5Mg==","diff_hunk":"@@ -4,8 +4,16 @@\n //-------------------------------------------------------------------------------------------------------\n #include \"ParserPch.h\"\n \n-ParseExceptionObject::ParseExceptionObject(HRESULT hr) : m_hr(hr)\n+ParseExceptionObject::ParseExceptionObject(HRESULT hr, LPCWSTR stringOneIn, LPCWSTR stringTwoIn)\n {\n+    m_hr = hr;","path":"lib/Parser/cmperr.cpp","position":7,"original_position":7,"commit_id":"1f18f53acfb5ea18a1bf1dd6678fd398a6ad4eac","original_commit_id":"1f18f53acfb5ea18a1bf1dd6678fd398a6ad4eac","user":{"login":"Penguinwizzard","id":69503,"node_id":"MDQ6VXNlcjY5NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/69503?v=4","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"body":"It's mostly stylistic, and there's no real enforced style in ChakraCore (yet, anyway). I'd be decently surprised if we get different codegen due to this in optimized builds.","created_at":"2018-10-09T21:11:49Z","updated_at":"2018-10-09T21:11:49Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/5761#discussion_r223865392","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/223865392"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/5761#discussion_r223865392"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761"}},"in_reply_to_id":223854173},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761","id":220953701,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTUzNzAx","html_url":"https://github.com/Microsoft/ChakraCore/pull/5761","diff_url":"https://github.com/Microsoft/ChakraCore/pull/5761.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/5761.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5761","number":5761,"state":"open","locked":false,"title":"Improve error messages for syntax errors","user":{"login":"rhuanjl","id":30090552,"node_id":"MDQ6VXNlcjMwMDkwNTUy","avatar_url":"https://avatars3.githubusercontent.com/u/30090552?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuanjl","html_url":"https://github.com/rhuanjl","followers_url":"https://api.github.com/users/rhuanjl/followers","following_url":"https://api.github.com/users/rhuanjl/following{/other_user}","gists_url":"https://api.github.com/users/rhuanjl/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuanjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuanjl/subscriptions","organizations_url":"https://api.github.com/users/rhuanjl/orgs","repos_url":"https://api.github.com/users/rhuanjl/repos","events_url":"https://api.github.com/users/rhuanjl/events{/privacy}","received_events_url":"https://api.github.com/users/rhuanjl/received_events","type":"User","site_admin":false},"body":"Picking up on discussion in #5178 and also issue #767\r\n\r\nThis PR:\r\n1. Adds support for %s in syntax error messages (though only up to 2 uses of it per message)\r\n1. Adds facility for getting a string representation of the token being parsed, and the previous token\r\n1. Updates some commonly encountered error messages that currently only say \"Syntax error\"\r\n\r\nI'd like to follow up and improve some other error messages but this seemed big enough for one PR.\r\n\r\nI'm slightly nervous that I may have done something wrong in my implementation of %s support - it works in my tests but I don't 100% understand all the relevant logic.\r\n\r\nfixes #5178 ","created_at":"2018-10-07T15:06:18Z","updated_at":"2018-10-09T21:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31d604cad1788fb4cc5df7cd623e5d8ee4f47876","assignee":{"login":"dilijev","id":494055,"node_id":"MDQ6VXNlcjQ5NDA1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/494055?v=4","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"assignees":[{"login":"dilijev","id":494055,"node_id":"MDQ6VXNlcjQ5NDA1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/494055?v=4","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":546598686,"node_id":"MDU6TGFiZWw1NDY1OTg2ODY=","url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/External%20Contributor","name":"External Contributor","color":"D95D00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5761/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/1f18f53acfb5ea18a1bf1dd6678fd398a6ad4eac","head":{"label":"rhuanjl:parsingErrors","ref":"parsingErrors","sha":"1f18f53acfb5ea18a1bf1dd6678fd398a6ad4eac","user":{"login":"rhuanjl","id":30090552,"node_id":"MDQ6VXNlcjMwMDkwNTUy","avatar_url":"https://avatars3.githubusercontent.com/u/30090552?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuanjl","html_url":"https://github.com/rhuanjl","followers_url":"https://api.github.com/users/rhuanjl/followers","following_url":"https://api.github.com/users/rhuanjl/following{/other_user}","gists_url":"https://api.github.com/users/rhuanjl/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuanjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuanjl/subscriptions","organizations_url":"https://api.github.com/users/rhuanjl/orgs","repos_url":"https://api.github.com/users/rhuanjl/repos","events_url":"https://api.github.com/users/rhuanjl/events{/privacy}","received_events_url":"https://api.github.com/users/rhuanjl/received_events","type":"User","site_admin":false},"repo":{"id":117721683,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MjE2ODM=","name":"ChakraCore","full_name":"rhuanjl/ChakraCore","private":false,"owner":{"login":"rhuanjl","id":30090552,"node_id":"MDQ6VXNlcjMwMDkwNTUy","avatar_url":"https://avatars3.githubusercontent.com/u/30090552?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuanjl","html_url":"https://github.com/rhuanjl","followers_url":"https://api.github.com/users/rhuanjl/followers","following_url":"https://api.github.com/users/rhuanjl/following{/other_user}","gists_url":"https://api.github.com/users/rhuanjl/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuanjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuanjl/subscriptions","organizations_url":"https://api.github.com/users/rhuanjl/orgs","repos_url":"https://api.github.com/users/rhuanjl/repos","events_url":"https://api.github.com/users/rhuanjl/events{/privacy}","received_events_url":"https://api.github.com/users/rhuanjl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rhuanjl/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/rhuanjl/ChakraCore","forks_url":"https://api.github.com/repos/rhuanjl/ChakraCore/forks","keys_url":"https://api.github.com/repos/rhuanjl/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhuanjl/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhuanjl/ChakraCore/teams","hooks_url":"https://api.github.com/repos/rhuanjl/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/rhuanjl/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/rhuanjl/ChakraCore/events","assignees_url":"https://api.github.com/repos/rhuanjl/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/rhuanjl/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/rhuanjl/ChakraCore/tags","blobs_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhuanjl/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/rhuanjl/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/rhuanjl/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/rhuanjl/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/rhuanjl/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/rhuanjl/ChakraCore/subscription","commits_url":"https://api.github.com/repos/rhuanjl/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhuanjl/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhuanjl/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhuanjl/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/rhuanjl/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhuanjl/ChakraCore/merges","archive_url":"https://api.github.com/repos/rhuanjl/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhuanjl/ChakraCore/downloads","issues_url":"https://api.github.com/repos/rhuanjl/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/rhuanjl/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/rhuanjl/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/rhuanjl/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhuanjl/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/rhuanjl/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/rhuanjl/ChakraCore/deployments","created_at":"2018-01-16T18:11:05Z","updated_at":"2018-10-06T14:51:17Z","pushed_at":"2018-10-09T20:19:39Z","git_url":"git://github.com/rhuanjl/ChakraCore.git","ssh_url":"git@github.com:rhuanjl/ChakraCore.git","clone_url":"https://github.com/rhuanjl/ChakraCore.git","svn_url":"https://github.com/rhuanjl/ChakraCore","homepage":"","size":150149,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"aa9823c336281421a1adbe9e6ce3e73cee7dcaf6","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA4NjUxMw==","name":"ChakraCore","full_name":"Microsoft/ChakraCore","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2018-10-09T20:57:18Z","pushed_at":"2018-10-09T20:47:12Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":155641,"stargazers_count":7438,"watchers_count":7438,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1017,"mirror_url":null,"archived":false,"open_issues_count":346,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1017,"open_issues":346,"watchers":7438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/5761"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5761"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5761/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5761/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/1f18f53acfb5ea18a1bf1dd6678fd398a6ad4eac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Penguinwizzard"}}