{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/19637","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19637/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19637/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19637/events","html_url":"https://github.com/joomla/joomla-cms/pull/19637","id":296116335,"number":19637,"title":"[4.0][RFC] Drop minified static files from the repo","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars0.githubusercontent.com/u/3889375?v=4","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false},{"id":31297684,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Request%20for%20Comment","name":"Request for Comment","color":"02d7e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-02-10T17:09:20Z","updated_at":"2018-02-10T18:57:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/19637","html_url":"https://github.com/joomla/joomla-cms/pull/19637","diff_url":"https://github.com/joomla/joomla-cms/pull/19637.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/19637.patch"},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\n- All minified css and js files were removed from the repo\r\n- JHTML (or better HTMLHelper) was adjusted to pick the right files depending on debug state and irrelative to the given extension (eg .min.js or .js)\r\n\r\n### Why\r\n- This will make contributors life easier as they won't have to mess with node and try to figure out how to minify js.\r\n- It's kinda unsafe to accept minified code...\r\n\r\n### Possible problems\r\n- The repo remains installable but doesn't contain the production preferred minified files, so someone downloading it from GitHub will have to run build in order to get to production mode.\r\n- Although the idea here is to help contributors by offering an easer path for involvement and there is some security issue by accepting minified code, we do increase our dependency on tools and maybe this requires some more testing. Probably the release team can shed some light here.\r\n\r\n### WIP\r\nAs I opened the PR for comments there are parts that are missing here:\r\n- For SASS we need to see if we can trigger the minifier per request, so things could be tested.\r\n- The build script needs to run the node uglifier then pack the packages and then remove the minified files again. This code is not included in the PR (it makes no sense to spent time if this won't be approved)\r\n\r\n### Testing Instructions\r\nApply patch, or better download the branch from issue tracker and install. Check debug options and that all css and js files are still loaded correctly\r\n\r\n\r\n### Expected result\r\n\r\n\r\n\r\n### Actual result\r\n\r\n\r\n\r\n### Documentation Changes Required\r\nYes but mainly this will affect the maintainers (for the rest contributors is just removing the requirement for compressing js)\r\n\r\nCalling @mbabker @wilsonge @rdeutz @dneukirchen @yvesh "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/364680570","html_url":"https://github.com/joomla/joomla-cms/pull/19637#issuecomment-364680570","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19637","id":364680570,"user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars0.githubusercontent.com/u/3889375?v=4","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"created_at":"2018-02-10T18:57:17Z","updated_at":"2018-02-10T18:57:17Z","author_association":"MEMBER","body":"@brianteeman that’s why we try to address what seems to be unimportant issues since there are no major tasks on the table :("}}
{"actor":{"display_login":"dgt41"}}