{"action":"closed","number":845,"pull_request":{"url":"https://api.github.com/repos/codebar/planner/pulls/845","id":223336808,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzM2ODA4","html_url":"https://github.com/codebar/planner/pull/845","diff_url":"https://github.com/codebar/planner/pull/845.diff","patch_url":"https://github.com/codebar/planner/pull/845.patch","issue_url":"https://api.github.com/repos/codebar/planner/issues/845","number":845,"state":"closed","locked":false,"title":"Improve footer text contrast, and add a class","user":{"login":"richardwestenra","id":1155816,"node_id":"MDQ6VXNlcjExNTU4MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1155816?v=4","gravatar_id":"","url":"https://api.github.com/users/richardwestenra","html_url":"https://github.com/richardwestenra","followers_url":"https://api.github.com/users/richardwestenra/followers","following_url":"https://api.github.com/users/richardwestenra/following{/other_user}","gists_url":"https://api.github.com/users/richardwestenra/gists{/gist_id}","starred_url":"https://api.github.com/users/richardwestenra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardwestenra/subscriptions","organizations_url":"https://api.github.com/users/richardwestenra/orgs","repos_url":"https://api.github.com/users/richardwestenra/repos","events_url":"https://api.github.com/users/richardwestenra/events{/privacy}","received_events_url":"https://api.github.com/users/richardwestenra/received_events","type":"User","site_admin":false},"body":"A couple of extra improvements that I noticed after submitting #844:\r\n\r\n1. Apply footer CSS to a class, not a generic element type.\r\nIt's valid HTML for the footer element to be used in multiple locations on a page, so it's unsafe to write CSS for the main footer and apply it globally to this element, and assume that it won't cause side-effects in the future.\r\n\r\n2. Change footer text color to 80% white to improve a11y/readability.\r\nThe contrast ratio on this existing black-on-dark-grey text was exceptionally poor.\r\n![image](https://user-images.githubusercontent.com/1155816/47035582-4e9a1d80-d172-11e8-8420-2f1194c32222.png)\r\n","created_at":"2018-10-16T17:37:19Z","updated_at":"2018-10-16T17:43:21Z","closed_at":"2018-10-16T17:43:20Z","merged_at":"2018-10-16T17:43:20Z","merge_commit_sha":"5a503cdebd470e0f248ec65f6f73e13765934f3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codebar/planner/pulls/845/commits","review_comments_url":"https://api.github.com/repos/codebar/planner/pulls/845/comments","review_comment_url":"https://api.github.com/repos/codebar/planner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codebar/planner/issues/845/comments","statuses_url":"https://api.github.com/repos/codebar/planner/statuses/5d7b1f0262a4a665752256db21528d53e7abc062","head":{"label":"richardwestenra:fix/footer","ref":"fix/footer","sha":"5d7b1f0262a4a665752256db21528d53e7abc062","user":{"login":"richardwestenra","id":1155816,"node_id":"MDQ6VXNlcjExNTU4MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1155816?v=4","gravatar_id":"","url":"https://api.github.com/users/richardwestenra","html_url":"https://github.com/richardwestenra","followers_url":"https://api.github.com/users/richardwestenra/followers","following_url":"https://api.github.com/users/richardwestenra/following{/other_user}","gists_url":"https://api.github.com/users/richardwestenra/gists{/gist_id}","starred_url":"https://api.github.com/users/richardwestenra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardwestenra/subscriptions","organizations_url":"https://api.github.com/users/richardwestenra/orgs","repos_url":"https://api.github.com/users/richardwestenra/repos","events_url":"https://api.github.com/users/richardwestenra/events{/privacy}","received_events_url":"https://api.github.com/users/richardwestenra/received_events","type":"User","site_admin":false},"repo":{"id":76547643,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU0NzY0Mw==","name":"planner","full_name":"richardwestenra/planner","private":false,"owner":{"login":"richardwestenra","id":1155816,"node_id":"MDQ6VXNlcjExNTU4MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1155816?v=4","gravatar_id":"","url":"https://api.github.com/users/richardwestenra","html_url":"https://github.com/richardwestenra","followers_url":"https://api.github.com/users/richardwestenra/followers","following_url":"https://api.github.com/users/richardwestenra/following{/other_user}","gists_url":"https://api.github.com/users/richardwestenra/gists{/gist_id}","starred_url":"https://api.github.com/users/richardwestenra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardwestenra/subscriptions","organizations_url":"https://api.github.com/users/richardwestenra/orgs","repos_url":"https://api.github.com/users/richardwestenra/repos","events_url":"https://api.github.com/users/richardwestenra/events{/privacy}","received_events_url":"https://api.github.com/users/richardwestenra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richardwestenra/planner","description":"A tool to help us keep organised","fork":true,"url":"https://api.github.com/repos/richardwestenra/planner","forks_url":"https://api.github.com/repos/richardwestenra/planner/forks","keys_url":"https://api.github.com/repos/richardwestenra/planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardwestenra/planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardwestenra/planner/teams","hooks_url":"https://api.github.com/repos/richardwestenra/planner/hooks","issue_events_url":"https://api.github.com/repos/richardwestenra/planner/issues/events{/number}","events_url":"https://api.github.com/repos/richardwestenra/planner/events","assignees_url":"https://api.github.com/repos/richardwestenra/planner/assignees{/user}","branches_url":"https://api.github.com/repos/richardwestenra/planner/branches{/branch}","tags_url":"https://api.github.com/repos/richardwestenra/planner/tags","blobs_url":"https://api.github.com/repos/richardwestenra/planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardwestenra/planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardwestenra/planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardwestenra/planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardwestenra/planner/statuses/{sha}","languages_url":"https://api.github.com/repos/richardwestenra/planner/languages","stargazers_url":"https://api.github.com/repos/richardwestenra/planner/stargazers","contributors_url":"https://api.github.com/repos/richardwestenra/planner/contributors","subscribers_url":"https://api.github.com/repos/richardwestenra/planner/subscribers","subscription_url":"https://api.github.com/repos/richardwestenra/planner/subscription","commits_url":"https://api.github.com/repos/richardwestenra/planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardwestenra/planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardwestenra/planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardwestenra/planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardwestenra/planner/contents/{+path}","compare_url":"https://api.github.com/repos/richardwestenra/planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardwestenra/planner/merges","archive_url":"https://api.github.com/repos/richardwestenra/planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardwestenra/planner/downloads","issues_url":"https://api.github.com/repos/richardwestenra/planner/issues{/number}","pulls_url":"https://api.github.com/repos/richardwestenra/planner/pulls{/number}","milestones_url":"https://api.github.com/repos/richardwestenra/planner/milestones{/number}","notifications_url":"https://api.github.com/repos/richardwestenra/planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardwestenra/planner/labels{/name}","releases_url":"https://api.github.com/repos/richardwestenra/planner/releases{/id}","deployments_url":"https://api.github.com/repos/richardwestenra/planner/deployments","created_at":"2016-12-15T09:57:14Z","updated_at":"2018-10-16T17:16:15Z","pushed_at":"2018-10-16T17:34:19Z","git_url":"git://github.com/richardwestenra/planner.git","ssh_url":"git@github.com:richardwestenra/planner.git","clone_url":"https://github.com/richardwestenra/planner.git","svn_url":"https://github.com/richardwestenra/planner","homepage":"http://codebar.io","size":5205,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codebar:master","ref":"master","sha":"c96d13602cb4486628cad45f7f894870b432d5e0","user":{"login":"codebar","id":5642384,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NDIzODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5642384?v=4","gravatar_id":"","url":"https://api.github.com/users/codebar","html_url":"https://github.com/codebar","followers_url":"https://api.github.com/users/codebar/followers","following_url":"https://api.github.com/users/codebar/following{/other_user}","gists_url":"https://api.github.com/users/codebar/gists{/gist_id}","starred_url":"https://api.github.com/users/codebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebar/subscriptions","organizations_url":"https://api.github.com/users/codebar/orgs","repos_url":"https://api.github.com/users/codebar/repos","events_url":"https://api.github.com/users/codebar/events{/privacy}","received_events_url":"https://api.github.com/users/codebar/received_events","type":"Organization","site_admin":false},"repo":{"id":13730564,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMDU2NA==","name":"planner","full_name":"codebar/planner","private":false,"owner":{"login":"codebar","id":5642384,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NDIzODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5642384?v=4","gravatar_id":"","url":"https://api.github.com/users/codebar","html_url":"https://github.com/codebar","followers_url":"https://api.github.com/users/codebar/followers","following_url":"https://api.github.com/users/codebar/following{/other_user}","gists_url":"https://api.github.com/users/codebar/gists{/gist_id}","starred_url":"https://api.github.com/users/codebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebar/subscriptions","organizations_url":"https://api.github.com/users/codebar/orgs","repos_url":"https://api.github.com/users/codebar/repos","events_url":"https://api.github.com/users/codebar/events{/privacy}","received_events_url":"https://api.github.com/users/codebar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codebar/planner","description":"🗓 the main codebar site","fork":false,"url":"https://api.github.com/repos/codebar/planner","forks_url":"https://api.github.com/repos/codebar/planner/forks","keys_url":"https://api.github.com/repos/codebar/planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codebar/planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codebar/planner/teams","hooks_url":"https://api.github.com/repos/codebar/planner/hooks","issue_events_url":"https://api.github.com/repos/codebar/planner/issues/events{/number}","events_url":"https://api.github.com/repos/codebar/planner/events","assignees_url":"https://api.github.com/repos/codebar/planner/assignees{/user}","branches_url":"https://api.github.com/repos/codebar/planner/branches{/branch}","tags_url":"https://api.github.com/repos/codebar/planner/tags","blobs_url":"https://api.github.com/repos/codebar/planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codebar/planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codebar/planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/codebar/planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codebar/planner/statuses/{sha}","languages_url":"https://api.github.com/repos/codebar/planner/languages","stargazers_url":"https://api.github.com/repos/codebar/planner/stargazers","contributors_url":"https://api.github.com/repos/codebar/planner/contributors","subscribers_url":"https://api.github.com/repos/codebar/planner/subscribers","subscription_url":"https://api.github.com/repos/codebar/planner/subscription","commits_url":"https://api.github.com/repos/codebar/planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/codebar/planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/codebar/planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/codebar/planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/codebar/planner/contents/{+path}","compare_url":"https://api.github.com/repos/codebar/planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codebar/planner/merges","archive_url":"https://api.github.com/repos/codebar/planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codebar/planner/downloads","issues_url":"https://api.github.com/repos/codebar/planner/issues{/number}","pulls_url":"https://api.github.com/repos/codebar/planner/pulls{/number}","milestones_url":"https://api.github.com/repos/codebar/planner/milestones{/number}","notifications_url":"https://api.github.com/repos/codebar/planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codebar/planner/labels{/name}","releases_url":"https://api.github.com/repos/codebar/planner/releases{/id}","deployments_url":"https://api.github.com/repos/codebar/planner/deployments","created_at":"2013-10-21T01:40:23Z","updated_at":"2018-10-16T17:25:36Z","pushed_at":"2018-10-16T17:43:20Z","git_url":"git://github.com/codebar/planner.git","ssh_url":"git@github.com:codebar/planner.git","clone_url":"https://github.com/codebar/planner.git","svn_url":"https://github.com/codebar/planner","homepage":"https://codebar.io","size":6091,"stargazers_count":54,"watchers_count":54,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":142,"open_issues":62,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codebar/planner/pulls/845"},"html":{"href":"https://github.com/codebar/planner/pull/845"},"issue":{"href":"https://api.github.com/repos/codebar/planner/issues/845"},"comments":{"href":"https://api.github.com/repos/codebar/planner/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/codebar/planner/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/codebar/planner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codebar/planner/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/codebar/planner/statuses/5d7b1f0262a4a665752256db21528d53e7abc062"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"despo","id":159200,"node_id":"MDQ6VXNlcjE1OTIwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/159200?v=4","gravatar_id":"","url":"https://api.github.com/users/despo","html_url":"https://github.com/despo","followers_url":"https://api.github.com/users/despo/followers","following_url":"https://api.github.com/users/despo/following{/other_user}","gists_url":"https://api.github.com/users/despo/gists{/gist_id}","starred_url":"https://api.github.com/users/despo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/despo/subscriptions","organizations_url":"https://api.github.com/users/despo/orgs","repos_url":"https://api.github.com/users/despo/repos","events_url":"https://api.github.com/users/despo/events{/privacy}","received_events_url":"https://api.github.com/users/despo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"despo"}}