{"action":"created","issue":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/400","repository_url":"https://api.github.com/repos/jtablesaw/tablesaw","labels_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/400/labels{/name}","comments_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/400/comments","events_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/400/events","html_url":"https://github.com/jtablesaw/tablesaw/pull/400","id":370026070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODAxNjMx","number":400,"title":"Sql number type mapping","user":{"login":"gregorco","id":31416452,"node_id":"MDQ6VXNlcjMxNDE2NDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31416452?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorco","html_url":"https://github.com/gregorco","followers_url":"https://api.github.com/users/gregorco/followers","following_url":"https://api.github.com/users/gregorco/following{/other_user}","gists_url":"https://api.github.com/users/gregorco/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorco/subscriptions","organizations_url":"https://api.github.com/users/gregorco/orgs","repos_url":"https://api.github.com/users/gregorco/repos","events_url":"https://api.github.com/users/gregorco/events{/privacy}","received_events_url":"https://api.github.com/users/gregorco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-15T07:06:42Z","updated_at":"2018-11-27T16:45:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/pulls/400","html_url":"https://github.com/jtablesaw/tablesaw/pull/400","diff_url":"https://github.com/jtablesaw/tablesaw/pull/400.diff","patch_url":"https://github.com/jtablesaw/tablesaw/pull/400.patch"},"body":"Thanks for contributing.\r\n\r\n- [X] Tick to sign-off your agreement to the [Developer Certificate of Origin (DCO) 1.1](https://developercertificate.org)\r\n\r\n## Description\r\n\r\nAdded logic to interpret NUMBER SQL type according to its precision and scale properties.  Since Oracle converts all convenient numeric types like INTEGER to the equivalent NUMBER type internally, and that NUMBER type is what is present when importing the ResultSet into a new Table instance, an improved logic for mapping the NUMBER type to the best Column type is proposed. \r\n\r\n## Testing\r\n\r\nYes.  Junit tests were added.\r\n"},"comment":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/comments/442129847","html_url":"https://github.com/jtablesaw/tablesaw/pull/400#issuecomment-442129847","issue_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/400","id":442129847,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjEyOTg0Nw==","user":{"login":"gregorco","id":31416452,"node_id":"MDQ6VXNlcjMxNDE2NDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31416452?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorco","html_url":"https://github.com/gregorco","followers_url":"https://api.github.com/users/gregorco/followers","following_url":"https://api.github.com/users/gregorco/following{/other_user}","gists_url":"https://api.github.com/users/gregorco/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorco/subscriptions","organizations_url":"https://api.github.com/users/gregorco/orgs","repos_url":"https://api.github.com/users/gregorco/repos","events_url":"https://api.github.com/users/gregorco/events{/privacy}","received_events_url":"https://api.github.com/users/gregorco/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T16:45:01Z","updated_at":"2018-11-27T16:45:01Z","author_association":"CONTRIBUTOR","body":"I believe it's ready to go."}}
{"actor":{"display_login":"gregorco"}}