{"action":"opened","number":146,"pull_request":{"url":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/146","id":218911939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTExOTM5","html_url":"https://github.com/karl/redux-saga-state-machine/pull/146","diff_url":"https://github.com/karl/redux-saga-state-machine/pull/146.diff","patch_url":"https://github.com/karl/redux-saga-state-machine/pull/146.patch","issue_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/146","number":146,"state":"open","locked":false,"title":"No longer pass dispatch to conditionals","user":{"login":"karl","id":3681,"node_id":"MDQ6VXNlcjM2ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3681?v=4","gravatar_id":"","url":"https://api.github.com/users/karl","html_url":"https://github.com/karl","followers_url":"https://api.github.com/users/karl/followers","following_url":"https://api.github.com/users/karl/following{/other_user}","gists_url":"https://api.github.com/users/karl/gists{/gist_id}","starred_url":"https://api.github.com/users/karl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karl/subscriptions","organizations_url":"https://api.github.com/users/karl/orgs","repos_url":"https://api.github.com/users/karl/repos","events_url":"https://api.github.com/users/karl/events{/privacy}","received_events_url":"https://api.github.com/users/karl/received_events","type":"User","site_admin":false},"body":"Conditionals should be pure functions, they should not have side effects.\r\n\r\nPassing in dispatch could tempt developers into dispatching actions and causing side effects!","created_at":"2018-09-28T09:47:08Z","updated_at":"2018-09-28T09:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/146/commits","review_comments_url":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/146/comments","review_comment_url":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/146/comments","statuses_url":"https://api.github.com/repos/karl/redux-saga-state-machine/statuses/19695daff40ea89bc58e5de091bda5b3e928c379","head":{"label":"karl:no-dispatch-for-cond","ref":"no-dispatch-for-cond","sha":"19695daff40ea89bc58e5de091bda5b3e928c379","user":{"login":"karl","id":3681,"node_id":"MDQ6VXNlcjM2ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3681?v=4","gravatar_id":"","url":"https://api.github.com/users/karl","html_url":"https://github.com/karl","followers_url":"https://api.github.com/users/karl/followers","following_url":"https://api.github.com/users/karl/following{/other_user}","gists_url":"https://api.github.com/users/karl/gists{/gist_id}","starred_url":"https://api.github.com/users/karl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karl/subscriptions","organizations_url":"https://api.github.com/users/karl/orgs","repos_url":"https://api.github.com/users/karl/repos","events_url":"https://api.github.com/users/karl/events{/privacy}","received_events_url":"https://api.github.com/users/karl/received_events","type":"User","site_admin":false},"repo":{"id":130120161,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAxMjAxNjE=","name":"redux-saga-state-machine","full_name":"karl/redux-saga-state-machine","private":false,"owner":{"login":"karl","id":3681,"node_id":"MDQ6VXNlcjM2ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3681?v=4","gravatar_id":"","url":"https://api.github.com/users/karl","html_url":"https://github.com/karl","followers_url":"https://api.github.com/users/karl/followers","following_url":"https://api.github.com/users/karl/following{/other_user}","gists_url":"https://api.github.com/users/karl/gists{/gist_id}","starred_url":"https://api.github.com/users/karl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karl/subscriptions","organizations_url":"https://api.github.com/users/karl/orgs","repos_url":"https://api.github.com/users/karl/repos","events_url":"https://api.github.com/users/karl/events{/privacy}","received_events_url":"https://api.github.com/users/karl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karl/redux-saga-state-machine","description":"Redux Saga based state machines","fork":false,"url":"https://api.github.com/repos/karl/redux-saga-state-machine","forks_url":"https://api.github.com/repos/karl/redux-saga-state-machine/forks","keys_url":"https://api.github.com/repos/karl/redux-saga-state-machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karl/redux-saga-state-machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karl/redux-saga-state-machine/teams","hooks_url":"https://api.github.com/repos/karl/redux-saga-state-machine/hooks","issue_events_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/events{/number}","events_url":"https://api.github.com/repos/karl/redux-saga-state-machine/events","assignees_url":"https://api.github.com/repos/karl/redux-saga-state-machine/assignees{/user}","branches_url":"https://api.github.com/repos/karl/redux-saga-state-machine/branches{/branch}","tags_url":"https://api.github.com/repos/karl/redux-saga-state-machine/tags","blobs_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karl/redux-saga-state-machine/statuses/{sha}","languages_url":"https://api.github.com/repos/karl/redux-saga-state-machine/languages","stargazers_url":"https://api.github.com/repos/karl/redux-saga-state-machine/stargazers","contributors_url":"https://api.github.com/repos/karl/redux-saga-state-machine/contributors","subscribers_url":"https://api.github.com/repos/karl/redux-saga-state-machine/subscribers","subscription_url":"https://api.github.com/repos/karl/redux-saga-state-machine/subscription","commits_url":"https://api.github.com/repos/karl/redux-saga-state-machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/karl/redux-saga-state-machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/karl/redux-saga-state-machine/contents/{+path}","compare_url":"https://api.github.com/repos/karl/redux-saga-state-machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karl/redux-saga-state-machine/merges","archive_url":"https://api.github.com/repos/karl/redux-saga-state-machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karl/redux-saga-state-machine/downloads","issues_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues{/number}","pulls_url":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls{/number}","milestones_url":"https://api.github.com/repos/karl/redux-saga-state-machine/milestones{/number}","notifications_url":"https://api.github.com/repos/karl/redux-saga-state-machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karl/redux-saga-state-machine/labels{/name}","releases_url":"https://api.github.com/repos/karl/redux-saga-state-machine/releases{/id}","deployments_url":"https://api.github.com/repos/karl/redux-saga-state-machine/deployments","created_at":"2018-04-18T20:47:24Z","updated_at":"2018-09-28T08:38:56Z","pushed_at":"2018-09-28T09:46:23Z","git_url":"git://github.com/karl/redux-saga-state-machine.git","ssh_url":"git@github.com:karl/redux-saga-state-machine.git","clone_url":"https://github.com/karl/redux-saga-state-machine.git","svn_url":"https://github.com/karl/redux-saga-state-machine","homepage":"","size":1337,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"karl:master","ref":"master","sha":"fe5761e3feb0f327f80f51e521bef778af32b7fc","user":{"login":"karl","id":3681,"node_id":"MDQ6VXNlcjM2ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3681?v=4","gravatar_id":"","url":"https://api.github.com/users/karl","html_url":"https://github.com/karl","followers_url":"https://api.github.com/users/karl/followers","following_url":"https://api.github.com/users/karl/following{/other_user}","gists_url":"https://api.github.com/users/karl/gists{/gist_id}","starred_url":"https://api.github.com/users/karl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karl/subscriptions","organizations_url":"https://api.github.com/users/karl/orgs","repos_url":"https://api.github.com/users/karl/repos","events_url":"https://api.github.com/users/karl/events{/privacy}","received_events_url":"https://api.github.com/users/karl/received_events","type":"User","site_admin":false},"repo":{"id":130120161,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAxMjAxNjE=","name":"redux-saga-state-machine","full_name":"karl/redux-saga-state-machine","private":false,"owner":{"login":"karl","id":3681,"node_id":"MDQ6VXNlcjM2ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3681?v=4","gravatar_id":"","url":"https://api.github.com/users/karl","html_url":"https://github.com/karl","followers_url":"https://api.github.com/users/karl/followers","following_url":"https://api.github.com/users/karl/following{/other_user}","gists_url":"https://api.github.com/users/karl/gists{/gist_id}","starred_url":"https://api.github.com/users/karl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karl/subscriptions","organizations_url":"https://api.github.com/users/karl/orgs","repos_url":"https://api.github.com/users/karl/repos","events_url":"https://api.github.com/users/karl/events{/privacy}","received_events_url":"https://api.github.com/users/karl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karl/redux-saga-state-machine","description":"Redux Saga based state machines","fork":false,"url":"https://api.github.com/repos/karl/redux-saga-state-machine","forks_url":"https://api.github.com/repos/karl/redux-saga-state-machine/forks","keys_url":"https://api.github.com/repos/karl/redux-saga-state-machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karl/redux-saga-state-machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karl/redux-saga-state-machine/teams","hooks_url":"https://api.github.com/repos/karl/redux-saga-state-machine/hooks","issue_events_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/events{/number}","events_url":"https://api.github.com/repos/karl/redux-saga-state-machine/events","assignees_url":"https://api.github.com/repos/karl/redux-saga-state-machine/assignees{/user}","branches_url":"https://api.github.com/repos/karl/redux-saga-state-machine/branches{/branch}","tags_url":"https://api.github.com/repos/karl/redux-saga-state-machine/tags","blobs_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karl/redux-saga-state-machine/statuses/{sha}","languages_url":"https://api.github.com/repos/karl/redux-saga-state-machine/languages","stargazers_url":"https://api.github.com/repos/karl/redux-saga-state-machine/stargazers","contributors_url":"https://api.github.com/repos/karl/redux-saga-state-machine/contributors","subscribers_url":"https://api.github.com/repos/karl/redux-saga-state-machine/subscribers","subscription_url":"https://api.github.com/repos/karl/redux-saga-state-machine/subscription","commits_url":"https://api.github.com/repos/karl/redux-saga-state-machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/karl/redux-saga-state-machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/karl/redux-saga-state-machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/karl/redux-saga-state-machine/contents/{+path}","compare_url":"https://api.github.com/repos/karl/redux-saga-state-machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karl/redux-saga-state-machine/merges","archive_url":"https://api.github.com/repos/karl/redux-saga-state-machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karl/redux-saga-state-machine/downloads","issues_url":"https://api.github.com/repos/karl/redux-saga-state-machine/issues{/number}","pulls_url":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls{/number}","milestones_url":"https://api.github.com/repos/karl/redux-saga-state-machine/milestones{/number}","notifications_url":"https://api.github.com/repos/karl/redux-saga-state-machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karl/redux-saga-state-machine/labels{/name}","releases_url":"https://api.github.com/repos/karl/redux-saga-state-machine/releases{/id}","deployments_url":"https://api.github.com/repos/karl/redux-saga-state-machine/deployments","created_at":"2018-04-18T20:47:24Z","updated_at":"2018-09-28T08:38:56Z","pushed_at":"2018-09-28T09:46:23Z","git_url":"git://github.com/karl/redux-saga-state-machine.git","ssh_url":"git@github.com:karl/redux-saga-state-machine.git","clone_url":"https://github.com/karl/redux-saga-state-machine.git","svn_url":"https://github.com/karl/redux-saga-state-machine","homepage":"","size":1337,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/146"},"html":{"href":"https://github.com/karl/redux-saga-state-machine/pull/146"},"issue":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/146"},"comments":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/karl/redux-saga-state-machine/statuses/19695daff40ea89bc58e5de091bda5b3e928c379"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"karl"}}