{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/15284","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/15284/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/15284/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/15284/events","html_url":"https://github.com/magento/magento2/pull/15284","id":324097355,"number":15284,"title":"fix: support multiple minisearch widget instances","user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"dmanners","id":1572836,"avatar_url":"https://avatars2.githubusercontent.com/u/1572836?v=4","gravatar_id":"","url":"https://api.github.com/users/dmanners","html_url":"https://github.com/dmanners","followers_url":"https://api.github.com/users/dmanners/followers","following_url":"https://api.github.com/users/dmanners/following{/other_user}","gists_url":"https://api.github.com/users/dmanners/gists{/gist_id}","starred_url":"https://api.github.com/users/dmanners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmanners/subscriptions","organizations_url":"https://api.github.com/users/dmanners/orgs","repos_url":"https://api.github.com/users/dmanners/repos","events_url":"https://api.github.com/users/dmanners/events{/privacy}","received_events_url":"https://api.github.com/users/dmanners/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmanners","id":1572836,"avatar_url":"https://avatars2.githubusercontent.com/u/1572836?v=4","gravatar_id":"","url":"https://api.github.com/users/dmanners","html_url":"https://github.com/dmanners","followers_url":"https://api.github.com/users/dmanners/followers","following_url":"https://api.github.com/users/dmanners/following{/other_user}","gists_url":"https://api.github.com/users/dmanners/gists{/gist_id}","starred_url":"https://api.github.com/users/dmanners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmanners/subscriptions","organizations_url":"https://api.github.com/users/dmanners/orgs","repos_url":"https://api.github.com/users/dmanners/repos","events_url":"https://api.github.com/users/dmanners/events{/privacy}","received_events_url":"https://api.github.com/users/dmanners/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-17T16:28:22Z","updated_at":"2018-05-24T10:42:18Z","closed_at":"2018-05-24T10:35:00Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/15284","html_url":"https://github.com/magento/magento2/pull/15284","diff_url":"https://github.com/magento/magento2/pull/15284.diff","patch_url":"https://github.com/magento/magento2/pull/15284.patch"},"body":"<!--- Provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\nWhen cloning the minisearch widget and changing the ID's and selectors they still trigger all instances as the label searchLabel is globally searched instead of in the form.\r\n\r\n\r\n### Manual testing scenarios\r\n<!--- Provide a set of unambiguous steps to test the proposed code change -->\r\n1. clone module-search/view/frontend/templates/form.mini.phtml \r\n2. add custom block with the cloned and changed minisearch widget (after changing ID's and selectors in it)\r\n3. click on search icon on mobile\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/391669543","html_url":"https://github.com/magento/magento2/pull/15284#issuecomment-391669543","issue_url":"https://api.github.com/repos/magento/magento2/issues/15284","id":391669543,"user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T10:42:18Z","updated_at":"2018-05-24T10:42:18Z","author_association":"MEMBER","body":"See https://github.com/magento/magento2/pull/15485"}}
{"actor":{"display_login":"DanielRuf"}}