{"action":"created","comment":{"url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/comments/216925295","pull_request_review_id":154517870,"id":216925295,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjkyNTI5NQ==","diff_hunk":"@@ -3,14 +3,15 @@\n \n \n class LearningRateScheduler(object):","path":"src/utils/lr_scheduler.py","position":null,"original_position":3,"commit_id":"c6e7e84d1e71265c6e6efe99fd2960d2b9a4f483","original_commit_id":"55d712a13d22447f8922daacfaf63fa91c6a2860","user":{"login":"whr94621","id":16242350,"node_id":"MDQ6VXNlcjE2MjQyMzUw","avatar_url":"https://avatars2.githubusercontent.com/u/16242350?v=4","gravatar_id":"","url":"https://api.github.com/users/whr94621","html_url":"https://github.com/whr94621","followers_url":"https://api.github.com/users/whr94621/followers","following_url":"https://api.github.com/users/whr94621/following{/other_user}","gists_url":"https://api.github.com/users/whr94621/gists{/gist_id}","starred_url":"https://api.github.com/users/whr94621/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whr94621/subscriptions","organizations_url":"https://api.github.com/users/whr94621/orgs","repos_url":"https://api.github.com/users/whr94621/repos","events_url":"https://api.github.com/users/whr94621/events{/privacy}","received_events_url":"https://api.github.com/users/whr94621/received_events","type":"User","site_admin":false},"body":"```LearningRateScheduler``` has wrong indent. ","created_at":"2018-09-12T07:37:50Z","updated_at":"2018-09-12T07:46:48Z","html_url":"https://github.com/whr94621/NJUNMT-pytorch/pull/34#discussion_r216925295","pull_request_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/comments/216925295"},"html":{"href":"https://github.com/whr94621/NJUNMT-pytorch/pull/34#discussion_r216925295"},"pull_request":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34","id":214835893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODM1ODkz","html_url":"https://github.com/whr94621/NJUNMT-pytorch/pull/34","diff_url":"https://github.com/whr94621/NJUNMT-pytorch/pull/34.diff","patch_url":"https://github.com/whr94621/NJUNMT-pytorch/pull/34.patch","issue_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues/34","number":34,"state":"open","locked":false,"title":"add adafactor from google","user":{"login":"vergilus","id":19833549,"node_id":"MDQ6VXNlcjE5ODMzNTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/19833549?v=4","gravatar_id":"","url":"https://api.github.com/users/vergilus","html_url":"https://github.com/vergilus","followers_url":"https://api.github.com/users/vergilus/followers","following_url":"https://api.github.com/users/vergilus/following{/other_user}","gists_url":"https://api.github.com/users/vergilus/gists{/gist_id}","starred_url":"https://api.github.com/users/vergilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vergilus/subscriptions","organizations_url":"https://api.github.com/users/vergilus/orgs","repos_url":"https://api.github.com/users/vergilus/repos","events_url":"https://api.github.com/users/vergilus/events{/privacy}","received_events_url":"https://api.github.com/users/vergilus/received_events","type":"User","site_admin":false},"body":"adafactor saves space dramatically.\r\nto further reduce model file: switch off momentum by setting beta1=0(default).\r\nadafactor converges quicker than adam with the proposed schedule. but suffers some BLEU loss with default setting (about 0.5-1).\r\n\r\ndetails in code","created_at":"2018-09-12T04:58:47Z","updated_at":"2018-09-12T07:46:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ccf1b9b4e8e2ebbe72409c40c1672f40d57869f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34/commits","review_comments_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34/comments","review_comment_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues/34/comments","statuses_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/statuses/c6e7e84d1e71265c6e6efe99fd2960d2b9a4f483","head":{"label":"vergilus:master","ref":"master","sha":"c6e7e84d1e71265c6e6efe99fd2960d2b9a4f483","user":{"login":"vergilus","id":19833549,"node_id":"MDQ6VXNlcjE5ODMzNTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/19833549?v=4","gravatar_id":"","url":"https://api.github.com/users/vergilus","html_url":"https://github.com/vergilus","followers_url":"https://api.github.com/users/vergilus/followers","following_url":"https://api.github.com/users/vergilus/following{/other_user}","gists_url":"https://api.github.com/users/vergilus/gists{/gist_id}","starred_url":"https://api.github.com/users/vergilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vergilus/subscriptions","organizations_url":"https://api.github.com/users/vergilus/orgs","repos_url":"https://api.github.com/users/vergilus/repos","events_url":"https://api.github.com/users/vergilus/events{/privacy}","received_events_url":"https://api.github.com/users/vergilus/received_events","type":"User","site_admin":false},"repo":{"id":144659205,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NTkyMDU=","name":"NJUNMT-pytorch","full_name":"vergilus/NJUNMT-pytorch","owner":{"login":"vergilus","id":19833549,"node_id":"MDQ6VXNlcjE5ODMzNTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/19833549?v=4","gravatar_id":"","url":"https://api.github.com/users/vergilus","html_url":"https://github.com/vergilus","followers_url":"https://api.github.com/users/vergilus/followers","following_url":"https://api.github.com/users/vergilus/following{/other_user}","gists_url":"https://api.github.com/users/vergilus/gists{/gist_id}","starred_url":"https://api.github.com/users/vergilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vergilus/subscriptions","organizations_url":"https://api.github.com/users/vergilus/orgs","repos_url":"https://api.github.com/users/vergilus/repos","events_url":"https://api.github.com/users/vergilus/events{/privacy}","received_events_url":"https://api.github.com/users/vergilus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vergilus/NJUNMT-pytorch","description":null,"fork":true,"url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch","forks_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/forks","keys_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/teams","hooks_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/hooks","issue_events_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/events","assignees_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/tags","blobs_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/languages","stargazers_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/stargazers","contributors_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/contributors","subscribers_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/subscribers","subscription_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/subscription","commits_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/merges","archive_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/downloads","issues_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/labels{/name}","releases_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/vergilus/NJUNMT-pytorch/deployments","created_at":"2018-08-14T02:40:48Z","updated_at":"2018-09-12T07:44:12Z","pushed_at":"2018-09-12T07:44:10Z","git_url":"git://github.com/vergilus/NJUNMT-pytorch.git","ssh_url":"git@github.com:vergilus/NJUNMT-pytorch.git","clone_url":"https://github.com/vergilus/NJUNMT-pytorch.git","svn_url":"https://github.com/vergilus/NJUNMT-pytorch","homepage":null,"size":1011,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whr94621:master","ref":"master","sha":"47c1e3c51333396d4de5837ff0796944a68155d7","user":{"login":"whr94621","id":16242350,"node_id":"MDQ6VXNlcjE2MjQyMzUw","avatar_url":"https://avatars2.githubusercontent.com/u/16242350?v=4","gravatar_id":"","url":"https://api.github.com/users/whr94621","html_url":"https://github.com/whr94621","followers_url":"https://api.github.com/users/whr94621/followers","following_url":"https://api.github.com/users/whr94621/following{/other_user}","gists_url":"https://api.github.com/users/whr94621/gists{/gist_id}","starred_url":"https://api.github.com/users/whr94621/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whr94621/subscriptions","organizations_url":"https://api.github.com/users/whr94621/orgs","repos_url":"https://api.github.com/users/whr94621/repos","events_url":"https://api.github.com/users/whr94621/events{/privacy}","received_events_url":"https://api.github.com/users/whr94621/received_events","type":"User","site_admin":false},"repo":{"id":127517608,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc1MTc2MDg=","name":"NJUNMT-pytorch","full_name":"whr94621/NJUNMT-pytorch","owner":{"login":"whr94621","id":16242350,"node_id":"MDQ6VXNlcjE2MjQyMzUw","avatar_url":"https://avatars2.githubusercontent.com/u/16242350?v=4","gravatar_id":"","url":"https://api.github.com/users/whr94621","html_url":"https://github.com/whr94621","followers_url":"https://api.github.com/users/whr94621/followers","following_url":"https://api.github.com/users/whr94621/following{/other_user}","gists_url":"https://api.github.com/users/whr94621/gists{/gist_id}","starred_url":"https://api.github.com/users/whr94621/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whr94621/subscriptions","organizations_url":"https://api.github.com/users/whr94621/orgs","repos_url":"https://api.github.com/users/whr94621/repos","events_url":"https://api.github.com/users/whr94621/events{/privacy}","received_events_url":"https://api.github.com/users/whr94621/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whr94621/NJUNMT-pytorch","description":null,"fork":false,"url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch","forks_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/forks","keys_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/teams","hooks_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/hooks","issue_events_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/events","assignees_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/tags","blobs_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/languages","stargazers_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/stargazers","contributors_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/contributors","subscribers_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/subscribers","subscription_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/subscription","commits_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/merges","archive_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/downloads","issues_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/labels{/name}","releases_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/deployments","created_at":"2018-03-31T09:19:51Z","updated_at":"2018-09-10T11:31:01Z","pushed_at":"2018-09-12T07:44:12Z","git_url":"git://github.com/whr94621/NJUNMT-pytorch.git","ssh_url":"git@github.com:whr94621/NJUNMT-pytorch.git","clone_url":"https://github.com/whr94621/NJUNMT-pytorch.git","svn_url":"https://github.com/whr94621/NJUNMT-pytorch","homepage":null,"size":1019,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":3,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34"},"html":{"href":"https://github.com/whr94621/NJUNMT-pytorch/pull/34"},"issue":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues/34"},"comments":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/whr94621/NJUNMT-pytorch/statuses/c6e7e84d1e71265c6e6efe99fd2960d2b9a4f483"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"whr94621"}}