{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/191737183","pull_request_review_id":124365644,"id":191737183,"diff_hunk":"@@ -88,25 +84,6 @@\n         Iterable<QueryEngineProvider> executionEngines();\n     }\n \n-    public static class Configuration implements LoadableConfig\n-    {\n-        @Internal\n-        public static final Setting<Boolean> ephemeral =\n-                setting( \"unsupported.dbms.ephemeral\", BOOLEAN, Settings.FALSE );\n-\n-        @Internal\n-        public static final Setting<String> lock_manager =\n-                setting( \"unsupported.dbms.lock_manager\", STRING, \"\" );\n-\n-        @Internal\n-        public static final Setting<String> tracer =\n-                setting( \"unsupported.dbms.tracer\", STRING, Settings.NO_DEFAULT );\n-\n-        @Internal\n-        public static final Setting<String> editionName =\n-                setting( \"unsupported.dbms.edition\", STRING, Edition.unknown.toString() );\n-    }\n-","path":"community/neo4j/src/main/java/org/neo4j/platform/GraphDatabaseFacadeFactory.java","position":75,"original_position":75,"commit_id":"ea53e0bac6d0b0faa88d6309b25216fd88981602","original_commit_id":"c32d83311bafb4eca008baffdc6fc4c1b982ec12","user":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars3.githubusercontent.com/u/7993?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"body":"I like that this is moved to GraphDatabaseSettings.","created_at":"2018-05-30T11:53:09Z","updated_at":"2018-05-30T11:53:09Z","html_url":"https://github.com/neo4j/neo4j/pull/11877#discussion_r191737183","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11877","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/191737183"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11877#discussion_r191737183"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11877"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11877","id":190990230,"html_url":"https://github.com/neo4j/neo4j/pull/11877","diff_url":"https://github.com/neo4j/neo4j/pull/11877.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11877.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11877","number":11877,"state":"open","locked":false,"title":" Prototype of moving from edition based code to a separate module","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"This prototype should show possibility of great simplification\r\nhow dependencies are handled between modules and how\r\nedition can be entirely build without any extension and\r\nservice loading.","created_at":"2018-05-28T20:04:34Z","updated_at":"2018-05-30T11:53:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars3.githubusercontent.com/u/7993?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisvest","id":7993,"avatar_url":"https://avatars3.githubusercontent.com/u/7993?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},{"login":"andreikoval","id":35685569,"avatar_url":"https://avatars2.githubusercontent.com/u/35685569?v=4","gravatar_id":"","url":"https://api.github.com/users/andreikoval","html_url":"https://github.com/andreikoval","followers_url":"https://api.github.com/users/andreikoval/followers","following_url":"https://api.github.com/users/andreikoval/following{/other_user}","gists_url":"https://api.github.com/users/andreikoval/gists{/gist_id}","starred_url":"https://api.github.com/users/andreikoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreikoval/subscriptions","organizations_url":"https://api.github.com/users/andreikoval/orgs","repos_url":"https://api.github.com/users/andreikoval/repos","events_url":"https://api.github.com/users/andreikoval/events{/privacy}","received_events_url":"https://api.github.com/users/andreikoval/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":892627553,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.5","name":"3.5","color":"ad1f3e","default":false},{"id":647068085,"url":"https://api.github.com/repos/neo4j/neo4j/labels/team-kernel","name":"team-kernel","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11877/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11877/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11877/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/ea53e0bac6d0b0faa88d6309b25216fd88981602","head":{"label":"MishaDemianenko:3.5-move-edition-construction-out-of-kernel","ref":"3.5-move-edition-construction-out-of-kernel","sha":"ea53e0bac6d0b0faa88d6309b25216fd88981602","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"repo":{"id":36607274,"name":"neo4j","full_name":"MishaDemianenko/neo4j","owner":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MishaDemianenko/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/MishaDemianenko/neo4j","forks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/forks","keys_url":"https://api.github.com/repos/MishaDemianenko/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MishaDemianenko/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MishaDemianenko/neo4j/teams","hooks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/hooks","issue_events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/events","assignees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/MishaDemianenko/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/tags","blobs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MishaDemianenko/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/MishaDemianenko/neo4j/languages","stargazers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/stargazers","contributors_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contributors","subscribers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscribers","subscription_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscription","commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/MishaDemianenko/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MishaDemianenko/neo4j/merges","archive_url":"https://api.github.com/repos/MishaDemianenko/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MishaDemianenko/neo4j/downloads","issues_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/MishaDemianenko/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/MishaDemianenko/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/MishaDemianenko/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MishaDemianenko/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/MishaDemianenko/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/deployments","created_at":"2015-05-31T14:44:24Z","updated_at":"2015-05-31T14:44:50Z","pushed_at":"2018-05-29T17:27:52Z","git_url":"git://github.com/MishaDemianenko/neo4j.git","ssh_url":"git@github.com:MishaDemianenko/neo4j.git","clone_url":"https://github.com/MishaDemianenko/neo4j.git","svn_url":"https://github.com/MishaDemianenko/neo4j","homepage":"http://neo4j.com","size":422244,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.5","ref":"3.5","sha":"2dfe98dae3ebe8152395e3aa0df46b42f73104b3","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-05-30T11:24:49Z","pushed_at":"2018-05-30T11:11:47Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":420158,"stargazers_count":5129,"watchers_count":5129,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1357,"mirror_url":null,"archived":false,"open_issues_count":318,"license":null,"forks":1357,"open_issues":318,"watchers":5129,"default_branch":"3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11877"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11877"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11877"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11877/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11877/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11877/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/ea53e0bac6d0b0faa88d6309b25216fd88981602"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chrisvest"}}