{"action":"created","comment":{"url":"https://api.github.com/repos/api-platform/core/pulls/comments/167319679","pull_request_review_id":95530520,"id":167319679,"diff_hunk":"@@ -609,7 +605,7 @@ private function computeDoc(Documentation $documentation, \\ArrayObject $definiti\n     {\n         $doc = [\n             'swagger' => self::SWAGGER_VERSION,\n-            'basePath' => $context['base_url'] ?? '/',","path":"src/Swagger/Serializer/DocumentationNormalizer.php","position":39,"original_position":39,"commit_id":"65d50da3d1c624cf7efee0e4e48868e026d33f19","original_commit_id":"65d50da3d1c624cf7efee0e4e48868e026d33f19","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"(I know for empty, it's because my version is shorter, but nitpicking, keep it as is)","created_at":"2018-02-09T19:12:21Z","updated_at":"2018-02-09T19:12:22Z","html_url":"https://github.com/api-platform/core/pull/1697#discussion_r167319679","pull_request_url":"https://api.github.com/repos/api-platform/core/pulls/1697","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments/167319679"},"html":{"href":"https://github.com/api-platform/core/pull/1697#discussion_r167319679"},"pull_request":{"href":"https://api.github.com/repos/api-platform/core/pulls/1697"}},"in_reply_to_id":167286545},"pull_request":{"url":"https://api.github.com/repos/api-platform/core/pulls/1697","id":168283304,"html_url":"https://github.com/api-platform/core/pull/1697","diff_url":"https://github.com/api-platform/core/pull/1697.diff","patch_url":"https://github.com/api-platform/core/pull/1697.patch","issue_url":"https://api.github.com/repos/api-platform/core/issues/1697","number":1697,"state":"open","locked":false,"title":"Update Swagger DocumentationNormalizer for AWS API-Gateway","user":{"login":"vincentchalamon","id":407859,"avatar_url":"https://avatars1.githubusercontent.com/u/407859?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentchalamon","html_url":"https://github.com/vincentchalamon","followers_url":"https://api.github.com/users/vincentchalamon/followers","following_url":"https://api.github.com/users/vincentchalamon/following{/other_user}","gists_url":"https://api.github.com/users/vincentchalamon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentchalamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentchalamon/subscriptions","organizations_url":"https://api.github.com/users/vincentchalamon/orgs","repos_url":"https://api.github.com/users/vincentchalamon/repos","events_url":"https://api.github.com/users/vincentchalamon/events{/privacy}","received_events_url":"https://api.github.com/users/vincentchalamon/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | ?\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        | api-platform/doc#1234\r\n\r\nThis PR represents the changes required on the `/docs.json` Swagger doc to be valid to [AWS API Gateway](https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-known-issues.html).\r\n\r\n**It's not supposed to be merged**, but to open a discussion about [API Gateway](https://aws.amazon.com/api-gateway/) compatibility.","created_at":"2018-02-09T16:25:39Z","updated_at":"2018-02-09T19:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"504bbe9515d87ccbe4fdbd15c0400b7539509a4f","assignee":{"login":"vincentchalamon","id":407859,"avatar_url":"https://avatars1.githubusercontent.com/u/407859?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentchalamon","html_url":"https://github.com/vincentchalamon","followers_url":"https://api.github.com/users/vincentchalamon/followers","following_url":"https://api.github.com/users/vincentchalamon/following{/other_user}","gists_url":"https://api.github.com/users/vincentchalamon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentchalamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentchalamon/subscriptions","organizations_url":"https://api.github.com/users/vincentchalamon/orgs","repos_url":"https://api.github.com/users/vincentchalamon/repos","events_url":"https://api.github.com/users/vincentchalamon/events{/privacy}","received_events_url":"https://api.github.com/users/vincentchalamon/received_events","type":"User","site_admin":false},"assignees":[{"login":"vincentchalamon","id":407859,"avatar_url":"https://avatars1.githubusercontent.com/u/407859?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentchalamon","html_url":"https://github.com/vincentchalamon","followers_url":"https://api.github.com/users/vincentchalamon/followers","following_url":"https://api.github.com/users/vincentchalamon/following{/other_user}","gists_url":"https://api.github.com/users/vincentchalamon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentchalamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentchalamon/subscriptions","organizations_url":"https://api.github.com/users/vincentchalamon/orgs","repos_url":"https://api.github.com/users/vincentchalamon/repos","events_url":"https://api.github.com/users/vincentchalamon/events{/privacy}","received_events_url":"https://api.github.com/users/vincentchalamon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":167974003,"url":"https://api.github.com/repos/api-platform/core/labels/question","name":"question","color":"cc317c","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/api-platform/core/pulls/1697/commits","review_comments_url":"https://api.github.com/repos/api-platform/core/pulls/1697/comments","review_comment_url":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/api-platform/core/issues/1697/comments","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/65d50da3d1c624cf7efee0e4e48868e026d33f19","head":{"label":"vincentchalamon:2.1","ref":"2.1","sha":"65d50da3d1c624cf7efee0e4e48868e026d33f19","user":{"login":"vincentchalamon","id":407859,"avatar_url":"https://avatars1.githubusercontent.com/u/407859?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentchalamon","html_url":"https://github.com/vincentchalamon","followers_url":"https://api.github.com/users/vincentchalamon/followers","following_url":"https://api.github.com/users/vincentchalamon/following{/other_user}","gists_url":"https://api.github.com/users/vincentchalamon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentchalamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentchalamon/subscriptions","organizations_url":"https://api.github.com/users/vincentchalamon/orgs","repos_url":"https://api.github.com/users/vincentchalamon/repos","events_url":"https://api.github.com/users/vincentchalamon/events{/privacy}","received_events_url":"https://api.github.com/users/vincentchalamon/received_events","type":"User","site_admin":false},"repo":{"id":114752505,"name":"core","full_name":"vincentchalamon/core","owner":{"login":"vincentchalamon","id":407859,"avatar_url":"https://avatars1.githubusercontent.com/u/407859?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentchalamon","html_url":"https://github.com/vincentchalamon","followers_url":"https://api.github.com/users/vincentchalamon/followers","following_url":"https://api.github.com/users/vincentchalamon/following{/other_user}","gists_url":"https://api.github.com/users/vincentchalamon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentchalamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentchalamon/subscriptions","organizations_url":"https://api.github.com/users/vincentchalamon/orgs","repos_url":"https://api.github.com/users/vincentchalamon/repos","events_url":"https://api.github.com/users/vincentchalamon/events{/privacy}","received_events_url":"https://api.github.com/users/vincentchalamon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vincentchalamon/core","description":"The server component of API Platform: hypermedia and GraphQL APIs in minutes","fork":true,"url":"https://api.github.com/repos/vincentchalamon/core","forks_url":"https://api.github.com/repos/vincentchalamon/core/forks","keys_url":"https://api.github.com/repos/vincentchalamon/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vincentchalamon/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vincentchalamon/core/teams","hooks_url":"https://api.github.com/repos/vincentchalamon/core/hooks","issue_events_url":"https://api.github.com/repos/vincentchalamon/core/issues/events{/number}","events_url":"https://api.github.com/repos/vincentchalamon/core/events","assignees_url":"https://api.github.com/repos/vincentchalamon/core/assignees{/user}","branches_url":"https://api.github.com/repos/vincentchalamon/core/branches{/branch}","tags_url":"https://api.github.com/repos/vincentchalamon/core/tags","blobs_url":"https://api.github.com/repos/vincentchalamon/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vincentchalamon/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vincentchalamon/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/vincentchalamon/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vincentchalamon/core/statuses/{sha}","languages_url":"https://api.github.com/repos/vincentchalamon/core/languages","stargazers_url":"https://api.github.com/repos/vincentchalamon/core/stargazers","contributors_url":"https://api.github.com/repos/vincentchalamon/core/contributors","subscribers_url":"https://api.github.com/repos/vincentchalamon/core/subscribers","subscription_url":"https://api.github.com/repos/vincentchalamon/core/subscription","commits_url":"https://api.github.com/repos/vincentchalamon/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/vincentchalamon/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/vincentchalamon/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/vincentchalamon/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/vincentchalamon/core/contents/{+path}","compare_url":"https://api.github.com/repos/vincentchalamon/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vincentchalamon/core/merges","archive_url":"https://api.github.com/repos/vincentchalamon/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vincentchalamon/core/downloads","issues_url":"https://api.github.com/repos/vincentchalamon/core/issues{/number}","pulls_url":"https://api.github.com/repos/vincentchalamon/core/pulls{/number}","milestones_url":"https://api.github.com/repos/vincentchalamon/core/milestones{/number}","notifications_url":"https://api.github.com/repos/vincentchalamon/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vincentchalamon/core/labels{/name}","releases_url":"https://api.github.com/repos/vincentchalamon/core/releases{/id}","deployments_url":"https://api.github.com/repos/vincentchalamon/core/deployments","created_at":"2017-12-19T10:37:25Z","updated_at":"2017-12-19T10:37:29Z","pushed_at":"2018-02-09T16:22:08Z","git_url":"git://github.com/vincentchalamon/core.git","ssh_url":"git@github.com:vincentchalamon/core.git","clone_url":"https://github.com/vincentchalamon/core.git","svn_url":"https://github.com/vincentchalamon/core","homepage":"https://api-platform.com","size":6606,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"api-platform:2.1","ref":"2.1","sha":"d034ede5dab4dbe2c8a151febb39c3191459e433","user":{"login":"api-platform","id":13420081,"avatar_url":"https://avatars3.githubusercontent.com/u/13420081?v=4","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":29501260,"name":"core","full_name":"api-platform/core","owner":{"login":"api-platform","id":13420081,"avatar_url":"https://avatars3.githubusercontent.com/u/13420081?v=4","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/api-platform/core","description":"The server component of API Platform: hypermedia and GraphQL APIs in minutes","fork":false,"url":"https://api.github.com/repos/api-platform/core","forks_url":"https://api.github.com/repos/api-platform/core/forks","keys_url":"https://api.github.com/repos/api-platform/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/api-platform/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/api-platform/core/teams","hooks_url":"https://api.github.com/repos/api-platform/core/hooks","issue_events_url":"https://api.github.com/repos/api-platform/core/issues/events{/number}","events_url":"https://api.github.com/repos/api-platform/core/events","assignees_url":"https://api.github.com/repos/api-platform/core/assignees{/user}","branches_url":"https://api.github.com/repos/api-platform/core/branches{/branch}","tags_url":"https://api.github.com/repos/api-platform/core/tags","blobs_url":"https://api.github.com/repos/api-platform/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/api-platform/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/api-platform/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/api-platform/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/{sha}","languages_url":"https://api.github.com/repos/api-platform/core/languages","stargazers_url":"https://api.github.com/repos/api-platform/core/stargazers","contributors_url":"https://api.github.com/repos/api-platform/core/contributors","subscribers_url":"https://api.github.com/repos/api-platform/core/subscribers","subscription_url":"https://api.github.com/repos/api-platform/core/subscription","commits_url":"https://api.github.com/repos/api-platform/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/api-platform/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/api-platform/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/api-platform/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/api-platform/core/contents/{+path}","compare_url":"https://api.github.com/repos/api-platform/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/api-platform/core/merges","archive_url":"https://api.github.com/repos/api-platform/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/api-platform/core/downloads","issues_url":"https://api.github.com/repos/api-platform/core/issues{/number}","pulls_url":"https://api.github.com/repos/api-platform/core/pulls{/number}","milestones_url":"https://api.github.com/repos/api-platform/core/milestones{/number}","notifications_url":"https://api.github.com/repos/api-platform/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/api-platform/core/labels{/name}","releases_url":"https://api.github.com/repos/api-platform/core/releases{/id}","deployments_url":"https://api.github.com/repos/api-platform/core/deployments","created_at":"2015-01-19T23:05:56Z","updated_at":"2018-02-09T16:15:26Z","pushed_at":"2018-02-09T16:25:40Z","git_url":"git://github.com/api-platform/core.git","ssh_url":"git@github.com:api-platform/core.git","clone_url":"https://github.com/api-platform/core.git","svn_url":"https://github.com/api-platform/core","homepage":"https://api-platform.com","size":7558,"stargazers_count":616,"watchers_count":616,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":204,"open_issues":192,"watchers":616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/1697"},"html":{"href":"https://github.com/api-platform/core/pull/1697"},"issue":{"href":"https://api.github.com/repos/api-platform/core/issues/1697"},"comments":{"href":"https://api.github.com/repos/api-platform/core/issues/1697/comments"},"review_comments":{"href":"https://api.github.com/repos/api-platform/core/pulls/1697/comments"},"review_comment":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/api-platform/core/pulls/1697/commits"},"statuses":{"href":"https://api.github.com/repos/api-platform/core/statuses/65d50da3d1c624cf7efee0e4e48868e026d33f19"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dunglas"}}