{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/1058","repository_url":"https://api.github.com/repos/Valloric/ycmd","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/1058/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/1058/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/1058/events","html_url":"https://github.com/Valloric/ycmd/pull/1058","id":335363671,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDgwMjYy","number":1058,"title":"[READY] Use node only if tsserver is supposed to run through it","user":{"login":"micbou","id":10026824,"node_id":"MDQ6VXNlcjEwMDI2ODI0","avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-25T11:19:02Z","updated_at":"2018-06-26T07:49:33Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/1058","html_url":"https://github.com/Valloric/ycmd/pull/1058","diff_url":"https://github.com/Valloric/ycmd/pull/1058.diff","patch_url":"https://github.com/Valloric/ycmd/pull/1058.patch"},"body":"TSServer is currently started through node to handle the case where node is installed as nodejs on Debian-based distributions. However, this doesn't work when the TSServer executable is a shim (e.g. when using [nodenv](https://github.com/nodenv/nodenv) or [asdf-nodejs](https://github.com/asdf-vm/asdf-nodejs)). See issue https://github.com/Valloric/ycmd/issues/1050. We fix that by only starting TSServer with node if it contains the line `#!/usr/bin/env node`.\r\n\r\nFixes #1050.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/1058)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/400214018","html_url":"https://github.com/Valloric/ycmd/pull/1058#issuecomment-400214018","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/1058","id":400214018,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIxNDAxOA==","user":{"login":"puremourning","id":10584846,"node_id":"MDQ6VXNlcjEwNTg0ODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/10584846?v=4","gravatar_id":"","url":"https://api.github.com/users/puremourning","html_url":"https://github.com/puremourning","followers_url":"https://api.github.com/users/puremourning/followers","following_url":"https://api.github.com/users/puremourning/following{/other_user}","gists_url":"https://api.github.com/users/puremourning/gists{/gist_id}","starred_url":"https://api.github.com/users/puremourning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puremourning/subscriptions","organizations_url":"https://api.github.com/users/puremourning/orgs","repos_url":"https://api.github.com/users/puremourning/repos","events_url":"https://api.github.com/users/puremourning/events{/privacy}","received_events_url":"https://api.github.com/users/puremourning/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T07:49:33Z","updated_at":"2018-06-26T07:49:33Z","author_association":"COLLABORATOR","body":"If it contains a shebang can’t we just execute it? If that fails, we could try with explicit node. I’m not keen on heuristics for this sort of thing . it seems brittle to me?"}}
{"actor":{"display_login":"puremourning"}}