{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/184220249","pull_request_review_id":115372030,"id":184220249,"diff_hunk":"@@ -0,0 +1,7 @@\n+<Project ToolsVersion=\"15.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">","path":"src/AzureStack/Subscriptions/AzSdk.RP.props","position":1,"original_position":1,"commit_id":"b8db2817ef0cf6336d402cb942bdec632ea963a6","original_commit_id":"940d39c679809aff6ba472bba3a62307388f5e43","user":{"login":"shahabhijeet","id":20732208,"avatar_url":"https://avatars2.githubusercontent.com/u/20732208?v=4","gravatar_id":"","url":"https://api.github.com/users/shahabhijeet","html_url":"https://github.com/shahabhijeet","followers_url":"https://api.github.com/users/shahabhijeet/followers","following_url":"https://api.github.com/users/shahabhijeet/following{/other_user}","gists_url":"https://api.github.com/users/shahabhijeet/gists{/gist_id}","starred_url":"https://api.github.com/users/shahabhijeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahabhijeet/subscriptions","organizations_url":"https://api.github.com/users/shahabhijeet/orgs","repos_url":"https://api.github.com/users/shahabhijeet/repos","events_url":"https://api.github.com/users/shahabhijeet/events{/privacy}","received_events_url":"https://api.github.com/users/shahabhijeet/received_events","type":"User","site_admin":false},"body":"@bganapa please do not make Resource Provider name plural.\r\nThis should be Subscription.\r\nThis should be changed across the namespace, directory name, package name, project name.\r\n","created_at":"2018-04-25T22:06:53Z","updated_at":"2018-04-25T22:11:54Z","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/4261#discussion_r184220249","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/184220249"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/4261#discussion_r184220249"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261","id":183582221,"html_url":"https://github.com/Azure/azure-sdk-for-net/pull/4261","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/4261.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/4261.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/4261","number":4261,"state":"open","locked":false,"title":"AzureStack User subscriptions SDK","user":{"login":"bganapa","id":12038849,"avatar_url":"https://avatars2.githubusercontent.com/u/12038849?v=4","gravatar_id":"","url":"https://api.github.com/users/bganapa","html_url":"https://github.com/bganapa","followers_url":"https://api.github.com/users/bganapa/followers","following_url":"https://api.github.com/users/bganapa/following{/other_user}","gists_url":"https://api.github.com/users/bganapa/gists{/gist_id}","starred_url":"https://api.github.com/users/bganapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bganapa/subscriptions","organizations_url":"https://api.github.com/users/bganapa/orgs","repos_url":"https://api.github.com/users/bganapa/repos","events_url":"https://api.github.com/users/bganapa/events{/privacy}","received_events_url":"https://api.github.com/users/bganapa/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\nThis is the preview version of azurestack specific subscriptions SDK. The SDK allows users to list the available offers, Offers by delegated providers, Create/Update/Suspend/Remove subscriptions\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n- [x] Please add REST spec PR link to the SDK PR\r\n- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md).**\r\n- [x] **The pull request does not introduce [breaking changes](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/Documentation/breaking-changes.md).**\r\n\r\n### [General Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#general-guidelines)\r\n- [x] Title of the pull request is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n\r\n### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#testing-guidelines)\r\n- [x] Pull request includes test coverage for the included changes.\r\n\r\n### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#sdk-generation-guidelines)\r\n- [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.\r\n- [x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.\r\n- [x] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK.\r\n","created_at":"2018-04-23T23:17:30Z","updated_at":"2018-04-25T22:11:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f36176a6c1e254453a3d9cbc4fc241340b6454f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wilcobmsft","id":31971584,"avatar_url":"https://avatars3.githubusercontent.com/u/31971584?v=4","gravatar_id":"","url":"https://api.github.com/users/wilcobmsft","html_url":"https://github.com/wilcobmsft","followers_url":"https://api.github.com/users/wilcobmsft/followers","following_url":"https://api.github.com/users/wilcobmsft/following{/other_user}","gists_url":"https://api.github.com/users/wilcobmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/wilcobmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilcobmsft/subscriptions","organizations_url":"https://api.github.com/users/wilcobmsft/orgs","repos_url":"https://api.github.com/users/wilcobmsft/repos","events_url":"https://api.github.com/users/wilcobmsft/events{/privacy}","received_events_url":"https://api.github.com/users/wilcobmsft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":495008110,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels/Changes%20Requested","name":"Changes Requested","color":"c12d9f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/4261/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/b8db2817ef0cf6336d402cb942bdec632ea963a6","head":{"label":"bganapa:user-subscriptions-pr2","ref":"user-subscriptions-pr2","sha":"b8db2817ef0cf6336d402cb942bdec632ea963a6","user":{"login":"bganapa","id":12038849,"avatar_url":"https://avatars2.githubusercontent.com/u/12038849?v=4","gravatar_id":"","url":"https://api.github.com/users/bganapa","html_url":"https://github.com/bganapa","followers_url":"https://api.github.com/users/bganapa/followers","following_url":"https://api.github.com/users/bganapa/following{/other_user}","gists_url":"https://api.github.com/users/bganapa/gists{/gist_id}","starred_url":"https://api.github.com/users/bganapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bganapa/subscriptions","organizations_url":"https://api.github.com/users/bganapa/orgs","repos_url":"https://api.github.com/users/bganapa/repos","events_url":"https://api.github.com/users/bganapa/events{/privacy}","received_events_url":"https://api.github.com/users/bganapa/received_events","type":"User","site_admin":false},"repo":{"id":50555065,"name":"azure-sdk-for-net","full_name":"bganapa/azure-sdk-for-net","owner":{"login":"bganapa","id":12038849,"avatar_url":"https://avatars2.githubusercontent.com/u/12038849?v=4","gravatar_id":"","url":"https://api.github.com/users/bganapa","html_url":"https://github.com/bganapa","followers_url":"https://api.github.com/users/bganapa/followers","following_url":"https://api.github.com/users/bganapa/following{/other_user}","gists_url":"https://api.github.com/users/bganapa/gists{/gist_id}","starred_url":"https://api.github.com/users/bganapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bganapa/subscriptions","organizations_url":"https://api.github.com/users/bganapa/orgs","repos_url":"https://api.github.com/users/bganapa/repos","events_url":"https://api.github.com/users/bganapa/events{/privacy}","received_events_url":"https://api.github.com/users/bganapa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bganapa/azure-sdk-for-net","description":"Microsoft Azure SDK for .NET","fork":true,"url":"https://api.github.com/repos/bganapa/azure-sdk-for-net","forks_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/bganapa/azure-sdk-for-net/deployments","created_at":"2016-01-28T04:24:45Z","updated_at":"2016-01-28T04:25:07Z","pushed_at":"2018-04-25T21:39:32Z","git_url":"git://github.com/bganapa/azure-sdk-for-net.git","ssh_url":"git@github.com:bganapa/azure-sdk-for-net.git","clone_url":"https://github.com/bganapa/azure-sdk-for-net.git","svn_url":"https://github.com/bganapa/azure-sdk-for-net","homepage":"http://www.windowsazure.com/en-us/develop/net/","size":199560,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:psSdkJson6","ref":"psSdkJson6","sha":"ba0d9d546393f5851be4c347942e77954f0c51c4","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-sdk-for-net","description":"Azure Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2018-04-25T21:10:58Z","pushed_at":"2018-04-25T21:42:32Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"git@github.com:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://www.visualstudio.com/features/azure-tools-vs","size":237753,"stargazers_count":1104,"watchers_count":1104,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1071,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1071,"open_issues":266,"watchers":1104,"default_branch":"psSdkJson6"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/4261"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/4261"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/4261/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/4261/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/b8db2817ef0cf6336d402cb942bdec632ea963a6"}},"author_association":"NONE"}}
{"actor":{"display_login":"shahabhijeet"}}