{"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/204212031","pull_request_review_id":139258923,"id":204212031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIxMjAzMQ==","diff_hunk":"@@ -58,6 +58,22 @@ class IterableTest {\n     Assert.assertEquals(expected, occurrences(xs))\n   }\n \n+  @Test\n+  def sizeCompare(): Unit = {\n+    val seq = Seq(1, 2, 3)\n+    assert(seq.sizeCompare(2) > 0)\n+    assert(seq.sizeCompare(3) == 0)\n+    assert(seq.sizeCompare(4) < 0)\n+  }\n+\n+  @Test\n+  def compareSizesWith(): Unit = {\n+    val seq = Seq(1, 2, 3)\n+    assert(seq.compareSizesWith(Seq(1, 2)) > 0)\n+    assert(seq.compareSizesWith(Seq(1, 2, 3)) == 0)\n+    assert(seq.compareSizesWith(Seq(1, 2, 3, 4)) < 0)","path":"test/junit/scala/collection/IterableTest.scala","position":17,"original_position":17,"commit_id":"89c5d254165543c1929f98c15974fea27d767f8b","original_commit_id":"89c5d254165543c1929f98c15974fea27d767f8b","user":{"login":"julienrf","id":332812,"node_id":"MDQ6VXNlcjMzMjgxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/332812?v=4","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"body":"I think we should explicitly use `List` here, and then write another test with a collection implementation that have a `knownSize` different from -1.","created_at":"2018-07-21T14:20:56Z","updated_at":"2018-07-21T14:21:00Z","html_url":"https://github.com/scala/scala/pull/6950#discussion_r204212031","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/6950","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/204212031"},"html":{"href":"https://github.com/scala/scala/pull/6950#discussion_r204212031"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/6950"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/6950","id":202148059,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTQ4MDU5","html_url":"https://github.com/scala/scala/pull/6950","diff_url":"https://github.com/scala/scala/pull/6950.diff","patch_url":"https://github.com/scala/scala/pull/6950.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/6950","number":6950,"state":"open","locked":false,"title":"Add size comparison methods to IterableOps","user":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"body":"Add `IterableOps.compareSizesWith`, `.sizeCompare`, and\r\n`.sizeIs`\r\n\r\nAddresses [this comment](https://github.com/scala/collection-strawman/issues/338#issuecomment-358914753) on scala/collection-strawman#338","created_at":"2018-07-18T06:14:16Z","updated_at":"2018-07-21T14:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d87084752bffaa7e13774daf1ab099400e6d1389","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Ichoran","id":2298644,"node_id":"MDQ6VXNlcjIyOTg2NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2298644?v=4","gravatar_id":"","url":"https://api.github.com/users/Ichoran","html_url":"https://github.com/Ichoran","followers_url":"https://api.github.com/users/Ichoran/followers","following_url":"https://api.github.com/users/Ichoran/following{/other_user}","gists_url":"https://api.github.com/users/Ichoran/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichoran/subscriptions","organizations_url":"https://api.github.com/users/Ichoran/orgs","repos_url":"https://api.github.com/users/Ichoran/repos","events_url":"https://api.github.com/users/Ichoran/events{/privacy}","received_events_url":"https://api.github.com/users/Ichoran/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/74","html_url":"https://github.com/scala/scala/milestone/74","labels_url":"https://api.github.com/repos/scala/scala/milestones/74/labels","id":3295287,"node_id":"MDk6TWlsZXN0b25lMzI5NTI4Nw==","number":74,"title":"2.13.0-M5","description":"Merge to 2.13.x. Last milestone (feature-frozen; aka RC0).\r\nRelease lead: @SethTisue","creator":{"login":"lrytz","id":119636,"node_id":"MDQ6VXNlcjExOTYzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/119636?v=4","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"open_issues":91,"closed_issues":272,"state":"open","created_at":"2018-04-25T07:15:17Z","updated_at":"2018-07-21T09:19:19Z","due_on":"2018-08-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/6950/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/6950/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/6950/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/89c5d254165543c1929f98c15974fea27d767f8b","head":{"label":"NthPortal:topic/sizeCompare/PR","ref":"topic/sizeCompare/PR","sha":"89c5d254165543c1929f98c15974fea27d767f8b","user":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"repo":{"id":85460181,"node_id":"MDEwOlJlcG9zaXRvcnk4NTQ2MDE4MQ==","name":"scala","full_name":"NthPortal/scala","owner":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NthPortal/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/NthPortal/scala","forks_url":"https://api.github.com/repos/NthPortal/scala/forks","keys_url":"https://api.github.com/repos/NthPortal/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NthPortal/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NthPortal/scala/teams","hooks_url":"https://api.github.com/repos/NthPortal/scala/hooks","issue_events_url":"https://api.github.com/repos/NthPortal/scala/issues/events{/number}","events_url":"https://api.github.com/repos/NthPortal/scala/events","assignees_url":"https://api.github.com/repos/NthPortal/scala/assignees{/user}","branches_url":"https://api.github.com/repos/NthPortal/scala/branches{/branch}","tags_url":"https://api.github.com/repos/NthPortal/scala/tags","blobs_url":"https://api.github.com/repos/NthPortal/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NthPortal/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NthPortal/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/NthPortal/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NthPortal/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/NthPortal/scala/languages","stargazers_url":"https://api.github.com/repos/NthPortal/scala/stargazers","contributors_url":"https://api.github.com/repos/NthPortal/scala/contributors","subscribers_url":"https://api.github.com/repos/NthPortal/scala/subscribers","subscription_url":"https://api.github.com/repos/NthPortal/scala/subscription","commits_url":"https://api.github.com/repos/NthPortal/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/NthPortal/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/NthPortal/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/NthPortal/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/NthPortal/scala/contents/{+path}","compare_url":"https://api.github.com/repos/NthPortal/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NthPortal/scala/merges","archive_url":"https://api.github.com/repos/NthPortal/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NthPortal/scala/downloads","issues_url":"https://api.github.com/repos/NthPortal/scala/issues{/number}","pulls_url":"https://api.github.com/repos/NthPortal/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/NthPortal/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/NthPortal/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NthPortal/scala/labels{/name}","releases_url":"https://api.github.com/repos/NthPortal/scala/releases{/id}","deployments_url":"https://api.github.com/repos/NthPortal/scala/deployments","created_at":"2017-03-19T08:05:23Z","updated_at":"2018-07-20T19:06:15Z","pushed_at":"2018-07-21T00:11:15Z","git_url":"git://github.com/NthPortal/scala.git","ssh_url":"git@github.com:NthPortal/scala.git","clone_url":"https://github.com/NthPortal/scala.git","svn_url":"https://github.com/NthPortal/scala","homepage":"http://www.scala-lang.org/","size":100098,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.13.x"}},"base":{"label":"scala:2.13.x","ref":"2.13.x","sha":"b24a6e03a67a53469eded1cbfd4e0dd00d1e7cff","user":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4ODE4","name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","deployments_url":"https://api.github.com/repos/scala/scala/deployments","created_at":"2011-12-01T05:02:34Z","updated_at":"2018-07-21T07:09:44Z","pushed_at":"2018-07-21T09:19:19Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":100251,"stargazers_count":10447,"watchers_count":10447,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2472,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2472,"open_issues":103,"watchers":10447,"default_branch":"2.13.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/6950"},"html":{"href":"https://github.com/scala/scala/pull/6950"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/6950"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/6950/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/6950/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/6950/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/89c5d254165543c1929f98c15974fea27d767f8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"julienrf"}}