{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/212034265","pull_request_review_id":148580746,"id":212034265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjAzNDI2NQ==","diff_hunk":"@@ -0,0 +1,37 @@\n+package utils","path":"pkg/utils/finalizer_test.go","position":1,"original_position":1,"commit_id":"17dbbd42a0b5ae4046fbd580f882846f589ba789","original_commit_id":"17dbbd42a0b5ae4046fbd580f882846f589ba789","user":{"login":"MrHohn","id":8681801,"node_id":"MDQ6VXNlcjg2ODE4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"body":"Need copyright boilerplate here.","created_at":"2018-08-22T17:09:11Z","updated_at":"2018-08-22T17:16:40Z","html_url":"https://github.com/kubernetes/ingress-gce/pull/446#discussion_r212034265","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/212034265"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/446#discussion_r212034265"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446","id":210012412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDEyNDEy","html_url":"https://github.com/kubernetes/ingress-gce/pull/446","diff_url":"https://github.com/kubernetes/ingress-gce/pull/446.diff","patch_url":"https://github.com/kubernetes/ingress-gce/pull/446.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/446","number":446,"state":"open","locked":false,"title":"Add some utility functions to support finalizers","user":{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"body":"Adding some functions needed to support finalizers. This code can easily be reused by other modules.\r\n\r\nMuch of this code was adapted from https://github.com/kubernetes/kubernetes/pull/54569\r\n\r\n/assign @bowei @MrHohn ","created_at":"2018-08-22T03:40:54Z","updated_at":"2018-08-22T17:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6941e199256050171ddaa56d64b0860c80b00453","assignee":{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"MrHohn","id":8681801,"node_id":"MDQ6VXNlcjg2ODE4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":764098218,"node_id":"MDU6TGFiZWw3NjQwOTgyMTg=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":712525210,"node_id":"MDU6TGFiZWw3MTI1MjUyMTA=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":712525281,"node_id":"MDU6TGFiZWw3MTI1MjUyODE=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/446/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/17dbbd42a0b5ae4046fbd580f882846f589ba789","head":{"label":"rramkumar1:finalizer-lib","ref":"finalizer-lib","sha":"17dbbd42a0b5ae4046fbd580f882846f589ba789","user":{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"repo":{"id":114787128,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3ODcxMjg=","name":"ingress-gce","full_name":"rramkumar1/ingress-gce","owner":{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rramkumar1/ingress-gce","description":"Ingress controller for Google Cloud","fork":true,"url":"https://api.github.com/repos/rramkumar1/ingress-gce","forks_url":"https://api.github.com/repos/rramkumar1/ingress-gce/forks","keys_url":"https://api.github.com/repos/rramkumar1/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rramkumar1/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rramkumar1/ingress-gce/teams","hooks_url":"https://api.github.com/repos/rramkumar1/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/rramkumar1/ingress-gce/events","assignees_url":"https://api.github.com/repos/rramkumar1/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/rramkumar1/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/rramkumar1/ingress-gce/tags","blobs_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rramkumar1/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/rramkumar1/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/rramkumar1/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/rramkumar1/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/rramkumar1/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/rramkumar1/ingress-gce/subscription","commits_url":"https://api.github.com/repos/rramkumar1/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/rramkumar1/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/rramkumar1/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/rramkumar1/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rramkumar1/ingress-gce/merges","archive_url":"https://api.github.com/repos/rramkumar1/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rramkumar1/ingress-gce/downloads","issues_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/rramkumar1/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/rramkumar1/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/rramkumar1/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rramkumar1/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/rramkumar1/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/rramkumar1/ingress-gce/deployments","created_at":"2017-12-19T16:25:49Z","updated_at":"2018-08-16T23:25:13Z","pushed_at":"2018-08-22T03:39:07Z","git_url":"git://github.com/rramkumar1/ingress-gce.git","ssh_url":"git@github.com:rramkumar1/ingress-gce.git","clone_url":"https://github.com/rramkumar1/ingress-gce.git","svn_url":"https://github.com/rramkumar1/ingress-gce","homepage":"","size":38123,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"85266ca56b0521402d6e4dc1f04eeb83c993cc4f","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":105967469,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5Njc0Njk=","name":"ingress-gce","full_name":"kubernetes/ingress-gce","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-gce","description":"Ingress controller for Google Cloud","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-gce","forks_url":"https://api.github.com/repos/kubernetes/ingress-gce/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-gce/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-gce/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-gce/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-gce/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-gce/deployments","created_at":"2017-10-06T04:32:12Z","updated_at":"2018-08-22T02:55:45Z","pushed_at":"2018-08-22T03:40:55Z","git_url":"git://github.com/kubernetes/ingress-gce.git","ssh_url":"git@github.com:kubernetes/ingress-gce.git","clone_url":"https://github.com/kubernetes/ingress-gce.git","svn_url":"https://github.com/kubernetes/ingress-gce","homepage":"","size":38003,"stargazers_count":370,"watchers_count":370,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":84,"open_issues":41,"watchers":370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/446"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/446"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/17dbbd42a0b5ae4046fbd580f882846f589ba789"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MrHohn"}}