{"action":"created","comment":{"url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/comments/209048372","pull_request_review_id":144987604,"id":209048372,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTA0ODM3Mg==","diff_hunk":"@@ -353,7 +353,14 @@\n                 config.getActivityConfigurations().put(act.getClassName(), act);\n                 WebtrekkLogging.log(\"activity read from xml: \"+ act.getClassName());\n             }\n-        });\n+        }),\n+        FORCE_TLS12(new ParameterAction(){","path":"webtrekk_sdk/src/main/java/com/webtrekk/webtrekksdk/Configuration/TrackingConfigurationXmlParser.java","position":6,"original_position":6,"commit_id":"1654691099d54b1a8966d0f8c28ec9e1bc093ce7","original_commit_id":"1654691099d54b1a8966d0f8c28ec9e1bc093ce7","user":{"login":"joerg04","id":41970878,"node_id":"MDQ6VXNlcjQxOTcwODc4","avatar_url":"https://avatars2.githubusercontent.com/u/41970878?v=4","gravatar_id":"","url":"https://api.github.com/users/joerg04","html_url":"https://github.com/joerg04","followers_url":"https://api.github.com/users/joerg04/followers","following_url":"https://api.github.com/users/joerg04/following{/other_user}","gists_url":"https://api.github.com/users/joerg04/gists{/gist_id}","starred_url":"https://api.github.com/users/joerg04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerg04/subscriptions","organizations_url":"https://api.github.com/users/joerg04/orgs","repos_url":"https://api.github.com/users/joerg04/repos","events_url":"https://api.github.com/users/joerg04/events{/privacy}","received_events_url":"https://api.github.com/users/joerg04/received_events","type":"User","site_admin":false},"body":"My suggestion is, that forcing the connection to use TLS1.2 should be optional. So I implemented it to be turned off per default and to turn it on on demand, by  configuring it in the config file.\r\nThe only config file I know was the one you mentioned, so I used that one.","created_at":"2018-08-09T19:17:17Z","updated_at":"2018-08-09T19:17:17Z","html_url":"https://github.com/Webtrekk/webtrekk-android-sdk/pull/23#discussion_r209048372","pull_request_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/comments/209048372"},"html":{"href":"https://github.com/Webtrekk/webtrekk-android-sdk/pull/23#discussion_r209048372"},"pull_request":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23"}},"in_reply_to_id":207804117},"pull_request":{"url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23","id":205726651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzI2NjUx","html_url":"https://github.com/Webtrekk/webtrekk-android-sdk/pull/23","diff_url":"https://github.com/Webtrekk/webtrekk-android-sdk/pull/23.diff","patch_url":"https://github.com/Webtrekk/webtrekk-android-sdk/pull/23.patch","issue_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues/23","number":23,"state":"open","locked":false,"title":"Add option to force TLSv1.2 on some Android versions.","user":{"login":"joerg04","id":41970878,"node_id":"MDQ6VXNlcjQxOTcwODc4","avatar_url":"https://avatars2.githubusercontent.com/u/41970878?v=4","gravatar_id":"","url":"https://api.github.com/users/joerg04","html_url":"https://github.com/joerg04","followers_url":"https://api.github.com/users/joerg04/followers","following_url":"https://api.github.com/users/joerg04/following{/other_user}","gists_url":"https://api.github.com/users/joerg04/gists{/gist_id}","starred_url":"https://api.github.com/users/joerg04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerg04/subscriptions","organizations_url":"https://api.github.com/users/joerg04/orgs","repos_url":"https://api.github.com/users/joerg04/repos","events_url":"https://api.github.com/users/joerg04/events{/privacy}","received_events_url":"https://api.github.com/users/joerg04/received_events","type":"User","site_admin":false},"body":"Devices have to support TLSv1.2 from API level 16 (Jelly Bean) on,\r\nbut it's not enabled per default till API level 21 (Lollipop) [1].\r\n\r\nTo use this option on such devices, provide a TrackingConfiguration\r\nelement named \"forceTls12\".\r\n\r\n[1] https://developer.android.com/reference/javax/net/ssl/SSLContext","created_at":"2018-08-02T13:01:46Z","updated_at":"2018-08-09T19:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b8fe7d93d87257b0f83481c100015a41bbaf552","assignee":{"login":"Neno0o","id":3613763,"node_id":"MDQ6VXNlcjM2MTM3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3613763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neno0o","html_url":"https://github.com/Neno0o","followers_url":"https://api.github.com/users/Neno0o/followers","following_url":"https://api.github.com/users/Neno0o/following{/other_user}","gists_url":"https://api.github.com/users/Neno0o/gists{/gist_id}","starred_url":"https://api.github.com/users/Neno0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neno0o/subscriptions","organizations_url":"https://api.github.com/users/Neno0o/orgs","repos_url":"https://api.github.com/users/Neno0o/repos","events_url":"https://api.github.com/users/Neno0o/events{/privacy}","received_events_url":"https://api.github.com/users/Neno0o/received_events","type":"User","site_admin":false},"assignees":[{"login":"Neno0o","id":3613763,"node_id":"MDQ6VXNlcjM2MTM3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3613763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neno0o","html_url":"https://github.com/Neno0o","followers_url":"https://api.github.com/users/Neno0o/followers","following_url":"https://api.github.com/users/Neno0o/following{/other_user}","gists_url":"https://api.github.com/users/Neno0o/gists{/gist_id}","starred_url":"https://api.github.com/users/Neno0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neno0o/subscriptions","organizations_url":"https://api.github.com/users/Neno0o/orgs","repos_url":"https://api.github.com/users/Neno0o/repos","events_url":"https://api.github.com/users/Neno0o/events{/privacy}","received_events_url":"https://api.github.com/users/Neno0o/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues/23/comments","statuses_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/statuses/1654691099d54b1a8966d0f8c28ec9e1bc093ce7","head":{"label":"joerg04:joerg/TLS12_support","ref":"joerg/TLS12_support","sha":"1654691099d54b1a8966d0f8c28ec9e1bc093ce7","user":{"login":"joerg04","id":41970878,"node_id":"MDQ6VXNlcjQxOTcwODc4","avatar_url":"https://avatars2.githubusercontent.com/u/41970878?v=4","gravatar_id":"","url":"https://api.github.com/users/joerg04","html_url":"https://github.com/joerg04","followers_url":"https://api.github.com/users/joerg04/followers","following_url":"https://api.github.com/users/joerg04/following{/other_user}","gists_url":"https://api.github.com/users/joerg04/gists{/gist_id}","starred_url":"https://api.github.com/users/joerg04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerg04/subscriptions","organizations_url":"https://api.github.com/users/joerg04/orgs","repos_url":"https://api.github.com/users/joerg04/repos","events_url":"https://api.github.com/users/joerg04/events{/privacy}","received_events_url":"https://api.github.com/users/joerg04/received_events","type":"User","site_admin":false},"repo":{"id":143116125,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxMTYxMjU=","name":"webtrekk-android-sdk","full_name":"joerg04/webtrekk-android-sdk","owner":{"login":"joerg04","id":41970878,"node_id":"MDQ6VXNlcjQxOTcwODc4","avatar_url":"https://avatars2.githubusercontent.com/u/41970878?v=4","gravatar_id":"","url":"https://api.github.com/users/joerg04","html_url":"https://github.com/joerg04","followers_url":"https://api.github.com/users/joerg04/followers","following_url":"https://api.github.com/users/joerg04/following{/other_user}","gists_url":"https://api.github.com/users/joerg04/gists{/gist_id}","starred_url":"https://api.github.com/users/joerg04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerg04/subscriptions","organizations_url":"https://api.github.com/users/joerg04/orgs","repos_url":"https://api.github.com/users/joerg04/repos","events_url":"https://api.github.com/users/joerg04/events{/privacy}","received_events_url":"https://api.github.com/users/joerg04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joerg04/webtrekk-android-sdk","description":"An SDK for tracking Android apps with Webtrekk","fork":true,"url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk","forks_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/forks","keys_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/teams","hooks_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/events","assignees_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/tags","blobs_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/languages","stargazers_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/subscription","commits_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/merges","archive_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/downloads","issues_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/joerg04/webtrekk-android-sdk/deployments","created_at":"2018-08-01T06:55:05Z","updated_at":"2018-08-01T06:55:08Z","pushed_at":"2018-08-02T13:07:40Z","git_url":"git://github.com/joerg04/webtrekk-android-sdk.git","ssh_url":"git@github.com:joerg04/webtrekk-android-sdk.git","clone_url":"https://github.com/joerg04/webtrekk-android-sdk.git","svn_url":"https://github.com/joerg04/webtrekk-android-sdk","homepage":"https:\\\\www.webtrekk.com","size":46526,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Webtrekk:master","ref":"master","sha":"54b6494c273f720f74ed54edf93314a1cad64396","user":{"login":"Webtrekk","id":16593775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTkzNzc1","avatar_url":"https://avatars2.githubusercontent.com/u/16593775?v=4","gravatar_id":"","url":"https://api.github.com/users/Webtrekk","html_url":"https://github.com/Webtrekk","followers_url":"https://api.github.com/users/Webtrekk/followers","following_url":"https://api.github.com/users/Webtrekk/following{/other_user}","gists_url":"https://api.github.com/users/Webtrekk/gists{/gist_id}","starred_url":"https://api.github.com/users/Webtrekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Webtrekk/subscriptions","organizations_url":"https://api.github.com/users/Webtrekk/orgs","repos_url":"https://api.github.com/users/Webtrekk/repos","events_url":"https://api.github.com/users/Webtrekk/events{/privacy}","received_events_url":"https://api.github.com/users/Webtrekk/received_events","type":"Organization","site_admin":false},"repo":{"id":91563155,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU2MzE1NQ==","name":"webtrekk-android-sdk","full_name":"Webtrekk/webtrekk-android-sdk","owner":{"login":"Webtrekk","id":16593775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTkzNzc1","avatar_url":"https://avatars2.githubusercontent.com/u/16593775?v=4","gravatar_id":"","url":"https://api.github.com/users/Webtrekk","html_url":"https://github.com/Webtrekk","followers_url":"https://api.github.com/users/Webtrekk/followers","following_url":"https://api.github.com/users/Webtrekk/following{/other_user}","gists_url":"https://api.github.com/users/Webtrekk/gists{/gist_id}","starred_url":"https://api.github.com/users/Webtrekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Webtrekk/subscriptions","organizations_url":"https://api.github.com/users/Webtrekk/orgs","repos_url":"https://api.github.com/users/Webtrekk/repos","events_url":"https://api.github.com/users/Webtrekk/events{/privacy}","received_events_url":"https://api.github.com/users/Webtrekk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Webtrekk/webtrekk-android-sdk","description":"An SDK for tracking Android apps with Webtrekk","fork":false,"url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk","forks_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/forks","keys_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/teams","hooks_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/events","assignees_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/tags","blobs_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/languages","stargazers_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/subscription","commits_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/merges","archive_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/downloads","issues_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/deployments","created_at":"2017-05-17T10:14:54Z","updated_at":"2018-07-27T08:44:13Z","pushed_at":"2018-08-03T15:25:33Z","git_url":"git://github.com/Webtrekk/webtrekk-android-sdk.git","ssh_url":"git@github.com:Webtrekk/webtrekk-android-sdk.git","clone_url":"https://github.com/Webtrekk/webtrekk-android-sdk.git","svn_url":"https://github.com/Webtrekk/webtrekk-android-sdk","homepage":"https:\\\\www.webtrekk.com","size":46524,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23"},"html":{"href":"https://github.com/Webtrekk/webtrekk-android-sdk/pull/23"},"issue":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues/23"},"comments":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Webtrekk/webtrekk-android-sdk/statuses/1654691099d54b1a8966d0f8c28ec9e1bc093ce7"}},"author_association":"NONE"}}
{"actor":{"display_login":"joerg04"}}