{"action":"created","issue":{"url":"https://api.github.com/repos/thysultan/dio.js/issues/76","repository_url":"https://api.github.com/repos/thysultan/dio.js","labels_url":"https://api.github.com/repos/thysultan/dio.js/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/thysultan/dio.js/issues/76/comments","events_url":"https://api.github.com/repos/thysultan/dio.js/issues/76/events","html_url":"https://github.com/thysultan/dio.js/issues/76","id":348066874,"node_id":"MDU6SXNzdWUzNDgwNjY4NzQ=","number":76,"title":"Adding support for prop validation (aka \"propTypes\") to DIO","user":{"login":"mcjazzyfunky","id":17143038,"node_id":"MDQ6VXNlcjE3MTQzMDM4","avatar_url":"https://avatars2.githubusercontent.com/u/17143038?v=4","gravatar_id":"","url":"https://api.github.com/users/mcjazzyfunky","html_url":"https://github.com/mcjazzyfunky","followers_url":"https://api.github.com/users/mcjazzyfunky/followers","following_url":"https://api.github.com/users/mcjazzyfunky/following{/other_user}","gists_url":"https://api.github.com/users/mcjazzyfunky/gists{/gist_id}","starred_url":"https://api.github.com/users/mcjazzyfunky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcjazzyfunky/subscriptions","organizations_url":"https://api.github.com/users/mcjazzyfunky/orgs","repos_url":"https://api.github.com/users/mcjazzyfunky/repos","events_url":"https://api.github.com/users/mcjazzyfunky/events{/privacy}","received_events_url":"https://api.github.com/users/mcjazzyfunky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mcjazzyfunky","id":17143038,"node_id":"MDQ6VXNlcjE3MTQzMDM4","avatar_url":"https://avatars2.githubusercontent.com/u/17143038?v=4","gravatar_id":"","url":"https://api.github.com/users/mcjazzyfunky","html_url":"https://github.com/mcjazzyfunky","followers_url":"https://api.github.com/users/mcjazzyfunky/followers","following_url":"https://api.github.com/users/mcjazzyfunky/following{/other_user}","gists_url":"https://api.github.com/users/mcjazzyfunky/gists{/gist_id}","starred_url":"https://api.github.com/users/mcjazzyfunky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcjazzyfunky/subscriptions","organizations_url":"https://api.github.com/users/mcjazzyfunky/orgs","repos_url":"https://api.github.com/users/mcjazzyfunky/repos","events_url":"https://api.github.com/users/mcjazzyfunky/events{/privacy}","received_events_url":"https://api.github.com/users/mcjazzyfunky/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcjazzyfunky","id":17143038,"node_id":"MDQ6VXNlcjE3MTQzMDM4","avatar_url":"https://avatars2.githubusercontent.com/u/17143038?v=4","gravatar_id":"","url":"https://api.github.com/users/mcjazzyfunky","html_url":"https://github.com/mcjazzyfunky","followers_url":"https://api.github.com/users/mcjazzyfunky/followers","following_url":"https://api.github.com/users/mcjazzyfunky/following{/other_user}","gists_url":"https://api.github.com/users/mcjazzyfunky/gists{/gist_id}","starred_url":"https://api.github.com/users/mcjazzyfunky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcjazzyfunky/subscriptions","organizations_url":"https://api.github.com/users/mcjazzyfunky/orgs","repos_url":"https://api.github.com/users/mcjazzyfunky/repos","events_url":"https://api.github.com/users/mcjazzyfunky/events{/privacy}","received_events_url":"https://api.github.com/users/mcjazzyfunky/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-06T20:15:38Z","updated_at":"2018-08-06T23:48:18Z","closed_at":null,"author_association":"COLLABORATOR","body":"As discussed in #71 it would be nice if DIO had support for propTypes validation, as React has.\r\nIn the next release of DIO there will be separated packages for DEVELOPMENT and PRODUCTION (as in React), see #72.\r\nSo it's possible to add propTypes validation to DIO that will only be performed in DEVELOPMENT mode and NOT in PRODUCTION.\r\n\r\nTask description:\r\n\r\n- Add propTypes and contextTypes validation support for DIO component classes and DIO stateless functional components (no need to implement support for \"childContextTypes\").\r\n- Add propTypes validation for ContextProviders (=> new context API)\r\n- Make sure that the above mentioned changes have the same API and behavior as in React, and also make sure that all the changes for the propType validation logic are not included in DIO's PRODUCTION packages."},"comment":{"url":"https://api.github.com/repos/thysultan/dio.js/issues/comments/410887801","html_url":"https://github.com/thysultan/dio.js/issues/76#issuecomment-410887801","issue_url":"https://api.github.com/repos/thysultan/dio.js/issues/76","id":410887801,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDg4NzgwMQ==","user":{"login":"thysultan","id":810601,"node_id":"MDQ6VXNlcjgxMDYwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/810601?v=4","gravatar_id":"","url":"https://api.github.com/users/thysultan","html_url":"https://github.com/thysultan","followers_url":"https://api.github.com/users/thysultan/followers","following_url":"https://api.github.com/users/thysultan/following{/other_user}","gists_url":"https://api.github.com/users/thysultan/gists{/gist_id}","starred_url":"https://api.github.com/users/thysultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thysultan/subscriptions","organizations_url":"https://api.github.com/users/thysultan/orgs","repos_url":"https://api.github.com/users/thysultan/repos","events_url":"https://api.github.com/users/thysultan/events{/privacy}","received_events_url":"https://api.github.com/users/thysultan/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T23:48:18Z","updated_at":"2018-08-06T23:48:18Z","author_association":"OWNER","body":">But later I was convinced by the React team that it is better if the only difference in the behavior between DEVELOPMENT and PRODUCTION is just printing warnings and NOTHING else.\r\n\r\nThe opposite is often true when considering a testing framework might not necessarily fail on `console.error` invocations and that `propTypes` are inherently linked to the concept of catching errors eagerly, of which `console.error` strikes me as introducing more gaps for these to slip through un-noticed."}}
{"actor":{"display_login":"thysultan"}}