{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/176672688","pull_request_review_id":106417481,"id":176672688,"diff_hunk":"@@ -23,30 +23,35 @@ col-sm-2\n {# Rows #}\n \n {% block form_row -%}\n+    {%- set widget_attr = {} -%}\n+    {%- if help is not empty -%}\n+        {%- set widget_attr = {attr: {'aria-describedby': id ~\"_help\"}} -%}\n+    {%- endif -%}\n     <div class=\"form-group{% if (not compound or force_error|default(false)) and not valid %} has-error{% endif %}\">\n         {{- form_label(form) -}}\n         <div class=\"{{ block('form_group_class') }}\">\n-            {{- form_widget(form) -}}\n+            {{- form_widget(form, widget_attr) -}}\n+            {{- form_help(form) -}}\n             {{- form_errors(form) -}}\n         </div>\n-{##}</div>\n+    </div>","path":"src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_horizontal_layout.html.twig","position":17,"original_position":17,"commit_id":"878373ef3a17a8f387bfe111c47f9823fdb48726","original_commit_id":"878373ef3a17a8f387bfe111c47f9823fdb48726","user":{"login":"mpiot","id":10453508,"avatar_url":"https://avatars3.githubusercontent.com/u/10453508?v=4","gravatar_id":"","url":"https://api.github.com/users/mpiot","html_url":"https://github.com/mpiot","followers_url":"https://api.github.com/users/mpiot/followers","following_url":"https://api.github.com/users/mpiot/following{/other_user}","gists_url":"https://api.github.com/users/mpiot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpiot/subscriptions","organizations_url":"https://api.github.com/users/mpiot/orgs","repos_url":"https://api.github.com/users/mpiot/repos","events_url":"https://api.github.com/users/mpiot/events{/privacy}","received_events_url":"https://api.github.com/users/mpiot/received_events","type":"User","site_admin":false},"body":"Oh okay, I cancel modifications.","created_at":"2018-03-23T09:03:31Z","updated_at":"2018-03-23T09:03:31Z","html_url":"https://github.com/symfony/symfony/pull/26332#discussion_r176672688","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/26332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/176672688"},"html":{"href":"https://github.com/symfony/symfony/pull/26332#discussion_r176672688"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26332"}},"in_reply_to_id":176667058},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/26332","id":171613395,"html_url":"https://github.com/symfony/symfony/pull/26332","diff_url":"https://github.com/symfony/symfony/pull/26332.diff","patch_url":"https://github.com/symfony/symfony/pull/26332.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/26332","number":26332,"state":"open","locked":false,"title":"Add a data_help method in Form","user":{"login":"mpiot","id":10453508,"avatar_url":"https://avatars3.githubusercontent.com/u/10453508?v=4","gravatar_id":"","url":"https://api.github.com/users/mpiot","html_url":"https://github.com/mpiot","followers_url":"https://api.github.com/users/mpiot/followers","following_url":"https://api.github.com/users/mpiot/following{/other_user}","gists_url":"https://api.github.com/users/mpiot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpiot/subscriptions","organizations_url":"https://api.github.com/users/mpiot/orgs","repos_url":"https://api.github.com/users/mpiot/repos","events_url":"https://api.github.com/users/mpiot/events{/privacy}","received_events_url":"https://api.github.com/users/mpiot/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #26331\r\n| License       | MIT\r\n| Doc PR        | symfony/symfony-docs#9361\r\n\r\nAdd a form_help method in twig to display a help message in form. A `help` keyword is added to all FormType to define the message.\r\n","created_at":"2018-02-27T10:01:40Z","updated_at":"2018-03-23T09:03:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a626398616628582bd02c1181cb1cc91d7922340","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":864126276,"url":"https://api.github.com/repos/symfony/symfony/labels/:snowflake:%20Feature%20Freeze","name":":snowflake: Feature Freeze","color":"F2F8FD","default":false},{"id":100378,"url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237550465,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/17","html_url":"https://github.com/symfony/symfony/milestone/17","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/17/labels","id":2795131,"number":17,"title":"4.1","description":"https://symfony.com/roadmap?version=4.1#checker","creator":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":127,"closed_issues":245,"state":"open","created_at":"2017-09-26T15:40:00Z","updated_at":"2018-03-23T08:14:28Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/26332/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/26332/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/26332/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/878373ef3a17a8f387bfe111c47f9823fdb48726","head":{"label":"mpiot:form_help","ref":"form_help","sha":"878373ef3a17a8f387bfe111c47f9823fdb48726","user":{"login":"mpiot","id":10453508,"avatar_url":"https://avatars3.githubusercontent.com/u/10453508?v=4","gravatar_id":"","url":"https://api.github.com/users/mpiot","html_url":"https://github.com/mpiot","followers_url":"https://api.github.com/users/mpiot/followers","following_url":"https://api.github.com/users/mpiot/following{/other_user}","gists_url":"https://api.github.com/users/mpiot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpiot/subscriptions","organizations_url":"https://api.github.com/users/mpiot/orgs","repos_url":"https://api.github.com/users/mpiot/repos","events_url":"https://api.github.com/users/mpiot/events{/privacy}","received_events_url":"https://api.github.com/users/mpiot/received_events","type":"User","site_admin":false},"repo":{"id":121660205,"name":"symfony","full_name":"mpiot/symfony","owner":{"login":"mpiot","id":10453508,"avatar_url":"https://avatars3.githubusercontent.com/u/10453508?v=4","gravatar_id":"","url":"https://api.github.com/users/mpiot","html_url":"https://github.com/mpiot","followers_url":"https://api.github.com/users/mpiot/followers","following_url":"https://api.github.com/users/mpiot/following{/other_user}","gists_url":"https://api.github.com/users/mpiot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpiot/subscriptions","organizations_url":"https://api.github.com/users/mpiot/orgs","repos_url":"https://api.github.com/users/mpiot/repos","events_url":"https://api.github.com/users/mpiot/events{/privacy}","received_events_url":"https://api.github.com/users/mpiot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpiot/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/mpiot/symfony","forks_url":"https://api.github.com/repos/mpiot/symfony/forks","keys_url":"https://api.github.com/repos/mpiot/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpiot/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpiot/symfony/teams","hooks_url":"https://api.github.com/repos/mpiot/symfony/hooks","issue_events_url":"https://api.github.com/repos/mpiot/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/mpiot/symfony/events","assignees_url":"https://api.github.com/repos/mpiot/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/mpiot/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/mpiot/symfony/tags","blobs_url":"https://api.github.com/repos/mpiot/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpiot/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpiot/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpiot/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpiot/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/mpiot/symfony/languages","stargazers_url":"https://api.github.com/repos/mpiot/symfony/stargazers","contributors_url":"https://api.github.com/repos/mpiot/symfony/contributors","subscribers_url":"https://api.github.com/repos/mpiot/symfony/subscribers","subscription_url":"https://api.github.com/repos/mpiot/symfony/subscription","commits_url":"https://api.github.com/repos/mpiot/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpiot/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpiot/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpiot/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpiot/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/mpiot/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpiot/symfony/merges","archive_url":"https://api.github.com/repos/mpiot/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpiot/symfony/downloads","issues_url":"https://api.github.com/repos/mpiot/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/mpiot/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/mpiot/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/mpiot/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpiot/symfony/labels{/name}","releases_url":"https://api.github.com/repos/mpiot/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/mpiot/symfony/deployments","created_at":"2018-02-15T17:40:35Z","updated_at":"2018-02-15T17:40:54Z","pushed_at":"2018-03-22T17:27:27Z","git_url":"git://github.com/mpiot/symfony.git","ssh_url":"git@github.com:mpiot/symfony.git","clone_url":"https://github.com/mpiot/symfony.git","svn_url":"https://github.com/mpiot/symfony","homepage":"symfony.com","size":110689,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"1fffb8554cf3a3cd1d800e66afbd00e63282123a","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-03-23T08:42:32Z","pushed_at":"2018-03-23T08:57:34Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":115295,"stargazers_count":17052,"watchers_count":17052,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6110,"mirror_url":null,"archived":false,"open_issues_count":815,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6110,"open_issues":815,"watchers":17052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26332"},"html":{"href":"https://github.com/symfony/symfony/pull/26332"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/26332"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/26332/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26332/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26332/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/878373ef3a17a8f387bfe111c47f9823fdb48726"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mpiot"}}