{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments/184074405","pull_request_review_id":115195248,"id":184074405,"diff_hunk":"@@ -15,9 +15,19 @@\n  */\n package org.springframework.cloud.config.server.environment;\n \n+import java.security.KeyManagementException;\n+import java.security.KeyStoreException;\n+import java.security.NoSuchAlgorithmException;\n+import javax.net.ssl.SSLContext;\n import javax.servlet.http.HttpServletRequest;\n \n+import org.apache.http.conn.ssl.NoopHostnameVerifier;","path":"spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/VaultEnvironmentRepositoryFactory.java","position":10,"original_position":10,"commit_id":"f47702890816bed1a985eee918dcd1252162a538","original_commit_id":"f47702890816bed1a985eee918dcd1252162a538","user":{"login":"pivotal-dylan-roberts","id":17432089,"avatar_url":"https://avatars2.githubusercontent.com/u/17432089?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-dylan-roberts","html_url":"https://github.com/pivotal-dylan-roberts","followers_url":"https://api.github.com/users/pivotal-dylan-roberts/followers","following_url":"https://api.github.com/users/pivotal-dylan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-dylan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-dylan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-dylan-roberts/subscriptions","organizations_url":"https://api.github.com/users/pivotal-dylan-roberts/orgs","repos_url":"https://api.github.com/users/pivotal-dylan-roberts/repos","events_url":"https://api.github.com/users/pivotal-dylan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-dylan-roberts/received_events","type":"User","site_admin":false},"body":"I believe so. The Spring HttpComponentsClientHttpRequestFactory depends on it and this is where I'm hooking in to configure SSL validation on the RestTemplate.","created_at":"2018-04-25T14:13:49Z","updated_at":"2018-04-25T14:13:49Z","html_url":"https://github.com/spring-cloud/spring-cloud-config/pull/989#discussion_r184074405","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments/184074405"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-config/pull/989#discussion_r184074405"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989"}},"in_reply_to_id":184071305},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989","id":184040580,"html_url":"https://github.com/spring-cloud/spring-cloud-config/pull/989","diff_url":"https://github.com/spring-cloud/spring-cloud-config/pull/989.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-config/pull/989.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/989","number":989,"state":"open","locked":false,"title":"Enable skipping ssl validation for vault","user":{"login":"pivotal-dylan-roberts","id":17432089,"avatar_url":"https://avatars2.githubusercontent.com/u/17432089?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-dylan-roberts","html_url":"https://github.com/pivotal-dylan-roberts","followers_url":"https://api.github.com/users/pivotal-dylan-roberts/followers","following_url":"https://api.github.com/users/pivotal-dylan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-dylan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-dylan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-dylan-roberts/subscriptions","organizations_url":"https://api.github.com/users/pivotal-dylan-roberts/orgs","repos_url":"https://api.github.com/users/pivotal-dylan-roberts/repos","events_url":"https://api.github.com/users/pivotal-dylan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-dylan-roberts/received_events","type":"User","site_admin":false},"body":"If skipSslValidation flag is set for a Vault environment repository, configure its RestTemplate accordingly.","created_at":"2018-04-25T13:43:27Z","updated_at":"2018-04-25T14:13:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f20faa70bb80dbe0eabc223bd93b5534cddbf9d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/989/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/statuses/f47702890816bed1a985eee918dcd1252162a538","head":{"label":"pivotal-dylan-roberts:vault-skip-ssl-validation","ref":"vault-skip-ssl-validation","sha":"f47702890816bed1a985eee918dcd1252162a538","user":{"login":"pivotal-dylan-roberts","id":17432089,"avatar_url":"https://avatars2.githubusercontent.com/u/17432089?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-dylan-roberts","html_url":"https://github.com/pivotal-dylan-roberts","followers_url":"https://api.github.com/users/pivotal-dylan-roberts/followers","following_url":"https://api.github.com/users/pivotal-dylan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-dylan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-dylan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-dylan-roberts/subscriptions","organizations_url":"https://api.github.com/users/pivotal-dylan-roberts/orgs","repos_url":"https://api.github.com/users/pivotal-dylan-roberts/repos","events_url":"https://api.github.com/users/pivotal-dylan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-dylan-roberts/received_events","type":"User","site_admin":false},"repo":{"id":120812189,"name":"spring-cloud-config","full_name":"pivotal-dylan-roberts/spring-cloud-config","owner":{"login":"pivotal-dylan-roberts","id":17432089,"avatar_url":"https://avatars2.githubusercontent.com/u/17432089?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-dylan-roberts","html_url":"https://github.com/pivotal-dylan-roberts","followers_url":"https://api.github.com/users/pivotal-dylan-roberts/followers","following_url":"https://api.github.com/users/pivotal-dylan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-dylan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-dylan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-dylan-roberts/subscriptions","organizations_url":"https://api.github.com/users/pivotal-dylan-roberts/orgs","repos_url":"https://api.github.com/users/pivotal-dylan-roberts/repos","events_url":"https://api.github.com/users/pivotal-dylan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-dylan-roberts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pivotal-dylan-roberts/spring-cloud-config","description":"External configuration (server and client) for Spring Cloud","fork":true,"url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config","forks_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/forks","keys_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/teams","hooks_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/hooks","issue_events_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/issues/events{/number}","events_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/events","assignees_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/assignees{/user}","branches_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/branches{/branch}","tags_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/tags","blobs_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/languages","stargazers_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/stargazers","contributors_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/contributors","subscribers_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/subscribers","subscription_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/subscription","commits_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/contents/{+path}","compare_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/merges","archive_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/downloads","issues_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/issues{/number}","pulls_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/labels{/name}","releases_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/releases{/id}","deployments_url":"https://api.github.com/repos/pivotal-dylan-roberts/spring-cloud-config/deployments","created_at":"2018-02-08T20:11:28Z","updated_at":"2018-04-24T16:16:29Z","pushed_at":"2018-04-25T13:54:19Z","git_url":"git://github.com/pivotal-dylan-roberts/spring-cloud-config.git","ssh_url":"git@github.com:pivotal-dylan-roberts/spring-cloud-config.git","clone_url":"https://github.com/pivotal-dylan-roberts/spring-cloud-config.git","svn_url":"https://github.com/pivotal-dylan-roberts/spring-cloud-config","homepage":"","size":33160,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"dfa1f2fa6eea7d8979e135cf7d4604d7f4c44fd1","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":20811348,"name":"spring-cloud-config","full_name":"spring-cloud/spring-cloud-config","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-config","description":"External configuration (server and client) for Spring Cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-config","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-config/deployments","created_at":"2014-06-13T16:59:44Z","updated_at":"2018-04-25T02:54:49Z","pushed_at":"2018-04-25T13:54:21Z","git_url":"git://github.com/spring-cloud/spring-cloud-config.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-config.git","clone_url":"https://github.com/spring-cloud/spring-cloud-config.git","svn_url":"https://github.com/spring-cloud/spring-cloud-config","homepage":"","size":33402,"stargazers_count":840,"watchers_count":840,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":638,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":638,"open_issues":176,"watchers":840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-config/pull/989"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/989"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/issues/989/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/pulls/989/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-config/statuses/f47702890816bed1a985eee918dcd1252162a538"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pivotal-dylan-roberts"}}