{"action":"created","comment":{"url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments/235367750","pull_request_review_id":177214810,"id":235367750,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTM2Nzc1MA==","diff_hunk":"@@ -10,29 +10,29 @@ It makes use of docker, and docker-compose.\n \n ## Installing\n \n-[Install docker and docker-compose](https://docs.docker.com/compose/install/) (make sure you install the correct versions)\n+Pre-requisites: install [Virtualbox](https://www.virtualbox.org/wiki/Downloads) first, then [Vagrant](https://www.vagrantup.com/downloads.html). Even if you have a linux box, this is *very* recommended.\n+If you decide to not do it, sigh... but don't come to cry to us. [Install docker and docker-compose](https://docs.docker.com/compose/install/) (make sure you install the correct versions)\n \n Install the web application:\n ```\n git clone --recursive https://github.com/AEGEE/oms-docker.git\n cd oms-docker\n-./oms.sh up \n+./start.sh \n ```\n \n-*This is assuming you are running a Linux installation, for other operating systems virtualization is recommended.*\n-\n-If you have a non-Linux installation, then the commands are as following (assuming you have Virtualbox and Vagrant installed as per the link below the commands)\n+If you have a non-Linux installation, then the commands are as following (assuming you have Virtualbox and Vagrant installed, as per above)\n \n ```\n git clone --recursive https://github.com/AEGEE/oms-docker.git\n cd oms-docker\n vagrant up \n ```\n+**It will take a while**, so grab a cup of some hot beverage.\n \n [**More information on the installation**](https://oms-project.atlassian.net/wiki/spaces/GENERAL/pages/17235970/Installation)\n \n ## Usage\n-After running the system, you can navigate to it in your web browser. The URLs differ based on how you run it; however no matter how you decide to run it, _it is suggested_ to edit the `/etc/hosts` file to add the entry: `192.168.168.168 appserver traefik.appserver portainer.appserver`, to be able to use advanced features.\n+After running the system, you can navigate to it in your web browser. The URLs differ based on how you run it; however no matter how you decide to run it, _it is suggested_ to edit the `/etc/hosts` file to add the entry: `192.168.168.168 my.appserver traefik.appserver portainer.appserver`, to be able to use advanced features.","path":"README.md","position":32,"original_position":32,"commit_id":"eb87b370c65ac86a6850e9fa8ae3eb3677ba66f9","original_commit_id":"eb87b370c65ac86a6850e9fa8ae3eb3677ba66f9","user":{"login":"serge1peshcoff","id":1060257,"node_id":"MDQ6VXNlcjEwNjAyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1060257?v=4","gravatar_id":"","url":"https://api.github.com/users/serge1peshcoff","html_url":"https://github.com/serge1peshcoff","followers_url":"https://api.github.com/users/serge1peshcoff/followers","following_url":"https://api.github.com/users/serge1peshcoff/following{/other_user}","gists_url":"https://api.github.com/users/serge1peshcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/serge1peshcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge1peshcoff/subscriptions","organizations_url":"https://api.github.com/users/serge1peshcoff/orgs","repos_url":"https://api.github.com/users/serge1peshcoff/repos","events_url":"https://api.github.com/users/serge1peshcoff/events{/privacy}","received_events_url":"https://api.github.com/users/serge1peshcoff/received_events","type":"User","site_admin":false},"body":"maybe just put 'to edit the `/etc/hosts` (on Windows, it's `C:/Windows/system32/drivers/etc/hosts`)' instead to Readme and let people figure that out by themselves?","created_at":"2018-11-21T12:30:05Z","updated_at":"2018-11-21T12:30:05Z","html_url":"https://github.com/AEGEE/oms-docker/pull/65#discussion_r235367750","pull_request_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments/235367750"},"html":{"href":"https://github.com/AEGEE/oms-docker/pull/65#discussion_r235367750"},"pull_request":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65"}},"in_reply_to_id":235273483},"pull_request":{"url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65","id":232468598,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDY4NTk4","html_url":"https://github.com/AEGEE/oms-docker/pull/65","diff_url":"https://github.com/AEGEE/oms-docker/pull/65.diff","patch_url":"https://github.com/AEGEE/oms-docker/pull/65.patch","issue_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/65","number":65,"state":"open","locked":false,"title":"Improve bootstrap script","user":{"login":"linuxbandit","id":3695704,"node_id":"MDQ6VXNlcjM2OTU3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3695704?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxbandit","html_url":"https://github.com/linuxbandit","followers_url":"https://api.github.com/users/linuxbandit/followers","following_url":"https://api.github.com/users/linuxbandit/following{/other_user}","gists_url":"https://api.github.com/users/linuxbandit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxbandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxbandit/subscriptions","organizations_url":"https://api.github.com/users/linuxbandit/orgs","repos_url":"https://api.github.com/users/linuxbandit/repos","events_url":"https://api.github.com/users/linuxbandit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxbandit/received_events","type":"User","site_admin":false},"body":"the ideal case is to use Make to run the target you need - no more hassle\r\n\r\nThe only limitation is when logs are called: if one wants to make logs only for a specific container, they have to use directly `helper.sh --logs containername1 containername2 ...`\r\n\r\nVagrant makes use of that makefile to bootstrap. Vagrant has now 3GB of memory since we have a bigger machine on the cloud.\r\n\r\nMakefile also has function to help bumping the submodules at once: assuming all submodules are stable at any given commit, it should be safe to call it every now and then","created_at":"2018-11-20T21:43:35Z","updated_at":"2018-11-21T12:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34d842479d902d76ba763fb62ff8ec8326e4927e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65/commits","review_comments_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65/comments","review_comment_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/65/comments","statuses_url":"https://api.github.com/repos/AEGEE/oms-docker/statuses/eb87b370c65ac86a6850e9fa8ae3eb3677ba66f9","head":{"label":"linuxbandit:improve-bootstrap_script","ref":"improve-bootstrap_script","sha":"eb87b370c65ac86a6850e9fa8ae3eb3677ba66f9","user":{"login":"linuxbandit","id":3695704,"node_id":"MDQ6VXNlcjM2OTU3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3695704?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxbandit","html_url":"https://github.com/linuxbandit","followers_url":"https://api.github.com/users/linuxbandit/followers","following_url":"https://api.github.com/users/linuxbandit/following{/other_user}","gists_url":"https://api.github.com/users/linuxbandit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxbandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxbandit/subscriptions","organizations_url":"https://api.github.com/users/linuxbandit/orgs","repos_url":"https://api.github.com/users/linuxbandit/repos","events_url":"https://api.github.com/users/linuxbandit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxbandit/received_events","type":"User","site_admin":false},"repo":{"id":87643372,"node_id":"MDEwOlJlcG9zaXRvcnk4NzY0MzM3Mg==","name":"oms-docker","full_name":"linuxbandit/oms-docker","private":false,"owner":{"login":"linuxbandit","id":3695704,"node_id":"MDQ6VXNlcjM2OTU3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3695704?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxbandit","html_url":"https://github.com/linuxbandit","followers_url":"https://api.github.com/users/linuxbandit/followers","following_url":"https://api.github.com/users/linuxbandit/following{/other_user}","gists_url":"https://api.github.com/users/linuxbandit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxbandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxbandit/subscriptions","organizations_url":"https://api.github.com/users/linuxbandit/orgs","repos_url":"https://api.github.com/users/linuxbandit/repos","events_url":"https://api.github.com/users/linuxbandit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxbandit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/linuxbandit/oms-docker","description":"A docker environment as an alternative to the homestead virtualization","fork":true,"url":"https://api.github.com/repos/linuxbandit/oms-docker","forks_url":"https://api.github.com/repos/linuxbandit/oms-docker/forks","keys_url":"https://api.github.com/repos/linuxbandit/oms-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxbandit/oms-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxbandit/oms-docker/teams","hooks_url":"https://api.github.com/repos/linuxbandit/oms-docker/hooks","issue_events_url":"https://api.github.com/repos/linuxbandit/oms-docker/issues/events{/number}","events_url":"https://api.github.com/repos/linuxbandit/oms-docker/events","assignees_url":"https://api.github.com/repos/linuxbandit/oms-docker/assignees{/user}","branches_url":"https://api.github.com/repos/linuxbandit/oms-docker/branches{/branch}","tags_url":"https://api.github.com/repos/linuxbandit/oms-docker/tags","blobs_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxbandit/oms-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxbandit/oms-docker/languages","stargazers_url":"https://api.github.com/repos/linuxbandit/oms-docker/stargazers","contributors_url":"https://api.github.com/repos/linuxbandit/oms-docker/contributors","subscribers_url":"https://api.github.com/repos/linuxbandit/oms-docker/subscribers","subscription_url":"https://api.github.com/repos/linuxbandit/oms-docker/subscription","commits_url":"https://api.github.com/repos/linuxbandit/oms-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxbandit/oms-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxbandit/oms-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxbandit/oms-docker/contents/{+path}","compare_url":"https://api.github.com/repos/linuxbandit/oms-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxbandit/oms-docker/merges","archive_url":"https://api.github.com/repos/linuxbandit/oms-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxbandit/oms-docker/downloads","issues_url":"https://api.github.com/repos/linuxbandit/oms-docker/issues{/number}","pulls_url":"https://api.github.com/repos/linuxbandit/oms-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxbandit/oms-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxbandit/oms-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxbandit/oms-docker/labels{/name}","releases_url":"https://api.github.com/repos/linuxbandit/oms-docker/releases{/id}","deployments_url":"https://api.github.com/repos/linuxbandit/oms-docker/deployments","created_at":"2017-04-08T15:22:25Z","updated_at":"2018-11-16T17:21:06Z","pushed_at":"2018-11-20T23:20:12Z","git_url":"git://github.com/linuxbandit/oms-docker.git","ssh_url":"git@github.com:linuxbandit/oms-docker.git","clone_url":"https://github.com/linuxbandit/oms-docker.git","svn_url":"https://github.com/linuxbandit/oms-docker","homepage":null,"size":1419,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AEGEE:master","ref":"master","sha":"d6aff687d1fad098e03b759c9f48b6f1c2d1b3d5","user":{"login":"AEGEE","id":15609497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjA5NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/15609497?v=4","gravatar_id":"","url":"https://api.github.com/users/AEGEE","html_url":"https://github.com/AEGEE","followers_url":"https://api.github.com/users/AEGEE/followers","following_url":"https://api.github.com/users/AEGEE/following{/other_user}","gists_url":"https://api.github.com/users/AEGEE/gists{/gist_id}","starred_url":"https://api.github.com/users/AEGEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEGEE/subscriptions","organizations_url":"https://api.github.com/users/AEGEE/orgs","repos_url":"https://api.github.com/users/AEGEE/repos","events_url":"https://api.github.com/users/AEGEE/events{/privacy}","received_events_url":"https://api.github.com/users/AEGEE/received_events","type":"Organization","site_admin":false},"repo":{"id":73822546,"node_id":"MDEwOlJlcG9zaXRvcnk3MzgyMjU0Ng==","name":"oms-docker","full_name":"AEGEE/oms-docker","private":false,"owner":{"login":"AEGEE","id":15609497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjA5NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/15609497?v=4","gravatar_id":"","url":"https://api.github.com/users/AEGEE","html_url":"https://github.com/AEGEE","followers_url":"https://api.github.com/users/AEGEE/followers","following_url":"https://api.github.com/users/AEGEE/following{/other_user}","gists_url":"https://api.github.com/users/AEGEE/gists{/gist_id}","starred_url":"https://api.github.com/users/AEGEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEGEE/subscriptions","organizations_url":"https://api.github.com/users/AEGEE/orgs","repos_url":"https://api.github.com/users/AEGEE/repos","events_url":"https://api.github.com/users/AEGEE/events{/privacy}","received_events_url":"https://api.github.com/users/AEGEE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AEGEE/oms-docker","description":"A docker environment as an alternative to the homestead virtualization","fork":false,"url":"https://api.github.com/repos/AEGEE/oms-docker","forks_url":"https://api.github.com/repos/AEGEE/oms-docker/forks","keys_url":"https://api.github.com/repos/AEGEE/oms-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AEGEE/oms-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AEGEE/oms-docker/teams","hooks_url":"https://api.github.com/repos/AEGEE/oms-docker/hooks","issue_events_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/events{/number}","events_url":"https://api.github.com/repos/AEGEE/oms-docker/events","assignees_url":"https://api.github.com/repos/AEGEE/oms-docker/assignees{/user}","branches_url":"https://api.github.com/repos/AEGEE/oms-docker/branches{/branch}","tags_url":"https://api.github.com/repos/AEGEE/oms-docker/tags","blobs_url":"https://api.github.com/repos/AEGEE/oms-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AEGEE/oms-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AEGEE/oms-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/AEGEE/oms-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AEGEE/oms-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/AEGEE/oms-docker/languages","stargazers_url":"https://api.github.com/repos/AEGEE/oms-docker/stargazers","contributors_url":"https://api.github.com/repos/AEGEE/oms-docker/contributors","subscribers_url":"https://api.github.com/repos/AEGEE/oms-docker/subscribers","subscription_url":"https://api.github.com/repos/AEGEE/oms-docker/subscription","commits_url":"https://api.github.com/repos/AEGEE/oms-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/AEGEE/oms-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/AEGEE/oms-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/AEGEE/oms-docker/contents/{+path}","compare_url":"https://api.github.com/repos/AEGEE/oms-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AEGEE/oms-docker/merges","archive_url":"https://api.github.com/repos/AEGEE/oms-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AEGEE/oms-docker/downloads","issues_url":"https://api.github.com/repos/AEGEE/oms-docker/issues{/number}","pulls_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/AEGEE/oms-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/AEGEE/oms-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AEGEE/oms-docker/labels{/name}","releases_url":"https://api.github.com/repos/AEGEE/oms-docker/releases{/id}","deployments_url":"https://api.github.com/repos/AEGEE/oms-docker/deployments","created_at":"2016-11-15T14:42:00Z","updated_at":"2018-11-09T15:32:15Z","pushed_at":"2018-11-20T23:20:13Z","git_url":"git://github.com/AEGEE/oms-docker.git","ssh_url":"git@github.com:AEGEE/oms-docker.git","clone_url":"https://github.com/AEGEE/oms-docker.git","svn_url":"https://github.com/AEGEE/oms-docker","homepage":"https://my.aegee.eu","size":1330,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65"},"html":{"href":"https://github.com/AEGEE/oms-docker/pull/65"},"issue":{"href":"https://api.github.com/repos/AEGEE/oms-docker/issues/65"},"comments":{"href":"https://api.github.com/repos/AEGEE/oms-docker/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/AEGEE/oms-docker/statuses/eb87b370c65ac86a6850e9fa8ae3eb3677ba66f9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"serge1peshcoff"}}