{"action":"created","comment":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/comments/171497348","pull_request_review_id":100356723,"id":171497348,"diff_hunk":"@@ -0,0 +1,34 @@\n+SUMMARY=\"Media assets for RetroArch\"\n+DESCRIPTION=\"RetroArch is a frontend for emulators, game engines and media \\\n+players. This package provides assets such as icons for the GUI.\"\n+HOMEPAGE=\"https://libretro.com/\"\n+COPYRIGHT=\"2010-2018 The RetroArch Team\"\n+LICENSE=\"CC-BY-4.0\"\n+REVISION=\"1\"\n+srcGitRev=\"505ad6205e5fd8a155daad02ab39953a0b15b0a9\"\n+SOURCE_URI=\"https://github.com/libretro/retroarch-assets/archive/$srcGitRev.tar.gz\"\n+CHECKSUM_SHA256=\"de37772b00b755b80aafe5d4df0713c0fe6b0e5a79017d94e43f279e798aa85d\"\n+SOURCE_FILENAME=\"retroarch-assets-$portVersion.tar.gz\"\n+SOURCE_DIR=\"retroarch-assets-$srcGitRev\"\n+\n+ARCHITECTURES=\"any\"\n+\n+PROVIDES=\"\n+\tretroarch_assets = $portVersion\n+\t\"\n+REQUIRES=\"\n+\thaiku\n+\t\"\n+\n+INSTALL()\n+{\n+\tretroarchDataDir=\"$dataDir/retroarch/assets/\"\n+\tmkdir -p \"$retroarchDataDir\"\n+\tcp -ar * \"$retroarchDataDir\"\n+\trm -rf \"$retroarchDataDir\"/Makefile \\\n+\t\t\"$retroarchDataDir\"/configure \\\n+\t\t\"$retroarchDataDir\"/COPYING \\\n+\t\t\"$retroarchDataDir\"/src \\","path":"games-emulation/retroarch-assets/retroarch_assets-git20180129.recipe","position":31,"original_position":31,"commit_id":"e96b40fb5df8c5d4ff11d689073a47120ae0eb2b","original_commit_id":"e96b40fb5df8c5d4ff11d689073a47120ae0eb2b","user":{"login":"fbrosson","id":8014660,"avatar_url":"https://avatars0.githubusercontent.com/u/8014660?v=4","gravatar_id":"","url":"https://api.github.com/users/fbrosson","html_url":"https://github.com/fbrosson","followers_url":"https://api.github.com/users/fbrosson/followers","following_url":"https://api.github.com/users/fbrosson/following{/other_user}","gists_url":"https://api.github.com/users/fbrosson/gists{/gist_id}","starred_url":"https://api.github.com/users/fbrosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbrosson/subscriptions","organizations_url":"https://api.github.com/users/fbrosson/orgs","repos_url":"https://api.github.com/users/fbrosson/repos","events_url":"https://api.github.com/users/fbrosson/events{/privacy}","received_events_url":"https://api.github.com/users/fbrosson/received_events","type":"User","site_admin":false},"body":"Oops, if we do rename the recipe then we also need to include `$srcGitRev` in `SOURCE_FILENAME`.\r\n```diff\r\n-SOURCE_FILENAME=\"retroarch-assets-$portVersion.tar.gz\"\r\n+SOURCE_FILENAME=\"retroarch-assets-$portVersion-$srcGitRev.tar.gz\"\r\n```\r\n(But I still think it's a good idea to rename the recipe.)","created_at":"2018-03-01T09:08:30Z","updated_at":"2018-03-01T09:08:31Z","html_url":"https://github.com/haikuports/haikuports/pull/2259#discussion_r171497348","pull_request_url":"https://api.github.com/repos/haikuports/haikuports/pulls/2259","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/comments/171497348"},"html":{"href":"https://github.com/haikuports/haikuports/pull/2259#discussion_r171497348"},"pull_request":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/2259"}},"in_reply_to_id":171493831},"pull_request":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/2259","id":172123408,"html_url":"https://github.com/haikuports/haikuports/pull/2259","diff_url":"https://github.com/haikuports/haikuports/pull/2259.diff","patch_url":"https://github.com/haikuports/haikuports/pull/2259.patch","issue_url":"https://api.github.com/repos/haikuports/haikuports/issues/2259","number":2259,"state":"open","locked":false,"title":"retroarch-assets: assets for the RetroArch frontend","user":{"login":"kwyxz","id":1202508,"avatar_url":"https://avatars1.githubusercontent.com/u/1202508?v=4","gravatar_id":"","url":"https://api.github.com/users/kwyxz","html_url":"https://github.com/kwyxz","followers_url":"https://api.github.com/users/kwyxz/followers","following_url":"https://api.github.com/users/kwyxz/following{/other_user}","gists_url":"https://api.github.com/users/kwyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/kwyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwyxz/subscriptions","organizations_url":"https://api.github.com/users/kwyxz/orgs","repos_url":"https://api.github.com/users/kwyxz/repos","events_url":"https://api.github.com/users/kwyxz/events{/privacy}","received_events_url":"https://api.github.com/users/kwyxz/received_events","type":"User","site_admin":false},"body":"This package installs graphical assets to use with the RetroArch frontend.\r\nNo stable release exist as of now, hence the versioning using git. \r\nThe retroarch package depends on this as, without the assets, the interface is not really usable.","created_at":"2018-03-01T01:51:02Z","updated_at":"2018-03-01T09:08:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91abc25eed1d4be3f896634f29a3f6c0fb9e432b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haikuports/haikuports/pulls/2259/commits","review_comments_url":"https://api.github.com/repos/haikuports/haikuports/pulls/2259/comments","review_comment_url":"https://api.github.com/repos/haikuports/haikuports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haikuports/haikuports/issues/2259/comments","statuses_url":"https://api.github.com/repos/haikuports/haikuports/statuses/e96b40fb5df8c5d4ff11d689073a47120ae0eb2b","head":{"label":"kwyxz:retroarch-assets","ref":"retroarch-assets","sha":"e96b40fb5df8c5d4ff11d689073a47120ae0eb2b","user":{"login":"kwyxz","id":1202508,"avatar_url":"https://avatars1.githubusercontent.com/u/1202508?v=4","gravatar_id":"","url":"https://api.github.com/users/kwyxz","html_url":"https://github.com/kwyxz","followers_url":"https://api.github.com/users/kwyxz/followers","following_url":"https://api.github.com/users/kwyxz/following{/other_user}","gists_url":"https://api.github.com/users/kwyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/kwyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwyxz/subscriptions","organizations_url":"https://api.github.com/users/kwyxz/orgs","repos_url":"https://api.github.com/users/kwyxz/repos","events_url":"https://api.github.com/users/kwyxz/events{/privacy}","received_events_url":"https://api.github.com/users/kwyxz/received_events","type":"User","site_admin":false},"repo":{"id":123347577,"name":"haikuports","full_name":"kwyxz/haikuports","owner":{"login":"kwyxz","id":1202508,"avatar_url":"https://avatars1.githubusercontent.com/u/1202508?v=4","gravatar_id":"","url":"https://api.github.com/users/kwyxz","html_url":"https://github.com/kwyxz","followers_url":"https://api.github.com/users/kwyxz/followers","following_url":"https://api.github.com/users/kwyxz/following{/other_user}","gists_url":"https://api.github.com/users/kwyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/kwyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwyxz/subscriptions","organizations_url":"https://api.github.com/users/kwyxz/orgs","repos_url":"https://api.github.com/users/kwyxz/repos","events_url":"https://api.github.com/users/kwyxz/events{/privacy}","received_events_url":"https://api.github.com/users/kwyxz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwyxz/haikuports","description":"Software ports for the Haiku operating system.","fork":true,"url":"https://api.github.com/repos/kwyxz/haikuports","forks_url":"https://api.github.com/repos/kwyxz/haikuports/forks","keys_url":"https://api.github.com/repos/kwyxz/haikuports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwyxz/haikuports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwyxz/haikuports/teams","hooks_url":"https://api.github.com/repos/kwyxz/haikuports/hooks","issue_events_url":"https://api.github.com/repos/kwyxz/haikuports/issues/events{/number}","events_url":"https://api.github.com/repos/kwyxz/haikuports/events","assignees_url":"https://api.github.com/repos/kwyxz/haikuports/assignees{/user}","branches_url":"https://api.github.com/repos/kwyxz/haikuports/branches{/branch}","tags_url":"https://api.github.com/repos/kwyxz/haikuports/tags","blobs_url":"https://api.github.com/repos/kwyxz/haikuports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwyxz/haikuports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwyxz/haikuports/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwyxz/haikuports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwyxz/haikuports/statuses/{sha}","languages_url":"https://api.github.com/repos/kwyxz/haikuports/languages","stargazers_url":"https://api.github.com/repos/kwyxz/haikuports/stargazers","contributors_url":"https://api.github.com/repos/kwyxz/haikuports/contributors","subscribers_url":"https://api.github.com/repos/kwyxz/haikuports/subscribers","subscription_url":"https://api.github.com/repos/kwyxz/haikuports/subscription","commits_url":"https://api.github.com/repos/kwyxz/haikuports/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwyxz/haikuports/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwyxz/haikuports/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwyxz/haikuports/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwyxz/haikuports/contents/{+path}","compare_url":"https://api.github.com/repos/kwyxz/haikuports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwyxz/haikuports/merges","archive_url":"https://api.github.com/repos/kwyxz/haikuports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwyxz/haikuports/downloads","issues_url":"https://api.github.com/repos/kwyxz/haikuports/issues{/number}","pulls_url":"https://api.github.com/repos/kwyxz/haikuports/pulls{/number}","milestones_url":"https://api.github.com/repos/kwyxz/haikuports/milestones{/number}","notifications_url":"https://api.github.com/repos/kwyxz/haikuports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwyxz/haikuports/labels{/name}","releases_url":"https://api.github.com/repos/kwyxz/haikuports/releases{/id}","deployments_url":"https://api.github.com/repos/kwyxz/haikuports/deployments","created_at":"2018-02-28T22:00:40Z","updated_at":"2018-02-28T22:00:47Z","pushed_at":"2018-03-01T01:46:48Z","git_url":"git://github.com/kwyxz/haikuports.git","ssh_url":"git@github.com:kwyxz/haikuports.git","clone_url":"https://github.com/kwyxz/haikuports.git","svn_url":"https://github.com/kwyxz/haikuports","homepage":"","size":31375,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haikuports:master","ref":"master","sha":"abc84686f5883ed817674fd25e17c839ced8b8a6","user":{"login":"haikuports","id":12898682,"avatar_url":"https://avatars3.githubusercontent.com/u/12898682?v=4","gravatar_id":"","url":"https://api.github.com/users/haikuports","html_url":"https://github.com/haikuports","followers_url":"https://api.github.com/users/haikuports/followers","following_url":"https://api.github.com/users/haikuports/following{/other_user}","gists_url":"https://api.github.com/users/haikuports/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuports/subscriptions","organizations_url":"https://api.github.com/users/haikuports/orgs","repos_url":"https://api.github.com/users/haikuports/repos","events_url":"https://api.github.com/users/haikuports/events{/privacy}","received_events_url":"https://api.github.com/users/haikuports/received_events","type":"Organization","site_admin":false},"repo":{"id":38278075,"name":"haikuports","full_name":"haikuports/haikuports","owner":{"login":"haikuports","id":12898682,"avatar_url":"https://avatars3.githubusercontent.com/u/12898682?v=4","gravatar_id":"","url":"https://api.github.com/users/haikuports","html_url":"https://github.com/haikuports","followers_url":"https://api.github.com/users/haikuports/followers","following_url":"https://api.github.com/users/haikuports/following{/other_user}","gists_url":"https://api.github.com/users/haikuports/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuports/subscriptions","organizations_url":"https://api.github.com/users/haikuports/orgs","repos_url":"https://api.github.com/users/haikuports/repos","events_url":"https://api.github.com/users/haikuports/events{/privacy}","received_events_url":"https://api.github.com/users/haikuports/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haikuports/haikuports","description":"Software ports for the Haiku operating system.","fork":false,"url":"https://api.github.com/repos/haikuports/haikuports","forks_url":"https://api.github.com/repos/haikuports/haikuports/forks","keys_url":"https://api.github.com/repos/haikuports/haikuports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haikuports/haikuports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haikuports/haikuports/teams","hooks_url":"https://api.github.com/repos/haikuports/haikuports/hooks","issue_events_url":"https://api.github.com/repos/haikuports/haikuports/issues/events{/number}","events_url":"https://api.github.com/repos/haikuports/haikuports/events","assignees_url":"https://api.github.com/repos/haikuports/haikuports/assignees{/user}","branches_url":"https://api.github.com/repos/haikuports/haikuports/branches{/branch}","tags_url":"https://api.github.com/repos/haikuports/haikuports/tags","blobs_url":"https://api.github.com/repos/haikuports/haikuports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haikuports/haikuports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haikuports/haikuports/git/refs{/sha}","trees_url":"https://api.github.com/repos/haikuports/haikuports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haikuports/haikuports/statuses/{sha}","languages_url":"https://api.github.com/repos/haikuports/haikuports/languages","stargazers_url":"https://api.github.com/repos/haikuports/haikuports/stargazers","contributors_url":"https://api.github.com/repos/haikuports/haikuports/contributors","subscribers_url":"https://api.github.com/repos/haikuports/haikuports/subscribers","subscription_url":"https://api.github.com/repos/haikuports/haikuports/subscription","commits_url":"https://api.github.com/repos/haikuports/haikuports/commits{/sha}","git_commits_url":"https://api.github.com/repos/haikuports/haikuports/git/commits{/sha}","comments_url":"https://api.github.com/repos/haikuports/haikuports/comments{/number}","issue_comment_url":"https://api.github.com/repos/haikuports/haikuports/issues/comments{/number}","contents_url":"https://api.github.com/repos/haikuports/haikuports/contents/{+path}","compare_url":"https://api.github.com/repos/haikuports/haikuports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haikuports/haikuports/merges","archive_url":"https://api.github.com/repos/haikuports/haikuports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haikuports/haikuports/downloads","issues_url":"https://api.github.com/repos/haikuports/haikuports/issues{/number}","pulls_url":"https://api.github.com/repos/haikuports/haikuports/pulls{/number}","milestones_url":"https://api.github.com/repos/haikuports/haikuports/milestones{/number}","notifications_url":"https://api.github.com/repos/haikuports/haikuports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haikuports/haikuports/labels{/name}","releases_url":"https://api.github.com/repos/haikuports/haikuports/releases{/id}","deployments_url":"https://api.github.com/repos/haikuports/haikuports/deployments","created_at":"2015-06-30T00:15:33Z","updated_at":"2018-02-24T09:41:23Z","pushed_at":"2018-03-01T02:01:16Z","git_url":"git://github.com/haikuports/haikuports.git","ssh_url":"git@github.com:haikuports/haikuports.git","clone_url":"https://github.com/haikuports/haikuports.git","svn_url":"https://github.com/haikuports/haikuports","homepage":"","size":31365,"stargazers_count":72,"watchers_count":72,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":122,"open_issues":254,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/2259"},"html":{"href":"https://github.com/haikuports/haikuports/pull/2259"},"issue":{"href":"https://api.github.com/repos/haikuports/haikuports/issues/2259"},"comments":{"href":"https://api.github.com/repos/haikuports/haikuports/issues/2259/comments"},"review_comments":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/2259/comments"},"review_comment":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/2259/commits"},"statuses":{"href":"https://api.github.com/repos/haikuports/haikuports/statuses/e96b40fb5df8c5d4ff11d689073a47120ae0eb2b"}},"author_association":"NONE"}}
{"actor":{"display_login":"fbrosson"}}