{"action":"created","issue":{"url":"https://api.github.com/repos/nspec/DotNetTestNSpec/issues/8","repository_url":"https://api.github.com/repos/nspec/DotNetTestNSpec","labels_url":"https://api.github.com/repos/nspec/DotNetTestNSpec/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/nspec/DotNetTestNSpec/issues/8/comments","events_url":"https://api.github.com/repos/nspec/DotNetTestNSpec/issues/8/events","html_url":"https://github.com/nspec/DotNetTestNSpec/issues/8","id":215709199,"number":8,"title":"Will nspec support netcoreapp1.1?","user":{"login":"johnnymo87","id":3466499,"avatar_url":"https://avatars3.githubusercontent.com/u/3466499?v=4","gravatar_id":"","url":"https://api.github.com/users/johnnymo87","html_url":"https://github.com/johnnymo87","followers_url":"https://api.github.com/users/johnnymo87/followers","following_url":"https://api.github.com/users/johnnymo87/following{/other_user}","gists_url":"https://api.github.com/users/johnnymo87/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnymo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnymo87/subscriptions","organizations_url":"https://api.github.com/users/johnnymo87/orgs","repos_url":"https://api.github.com/users/johnnymo87/repos","events_url":"https://api.github.com/users/johnnymo87/events{/privacy}","received_events_url":"https://api.github.com/users/johnnymo87/received_events","type":"User","site_admin":false},"labels":[{"id":531768546,"url":"https://api.github.com/repos/nspec/DotNetTestNSpec/labels/feature","name":"feature","color":"128A0C","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-03-21T11:38:33Z","updated_at":"2018-05-17T09:39:58Z","closed_at":null,"author_association":"NONE","body":"I've added the following lines to my `.csproj` file:\r\n```\r\n    <PackageReference Include=\"dotnet-test-nspec\" Version=\"*\" />\r\n    <PackageReference Include=\"nspec\" Version=\"*\" />\r\n```\r\nWhen I run `dotnet restore && dotnet test`, it builds, but it cannot detect any tests. [This blog post](http://www.natemcmaster.com/blog/2017/02/01/project-json-to-csproj-part2/#dotnet-test) mentions that `dotnet test` works differently on netcoreapp1.1. Will you all add support for netcoreapp1.1?"},"comment":{"url":"https://api.github.com/repos/nspec/DotNetTestNSpec/issues/comments/389808099","html_url":"https://github.com/nspec/DotNetTestNSpec/issues/8#issuecomment-389808099","issue_url":"https://api.github.com/repos/nspec/DotNetTestNSpec/issues/8","id":389808099,"user":{"login":"BrainCrumbz","id":3185573,"avatar_url":"https://avatars3.githubusercontent.com/u/3185573?v=4","gravatar_id":"","url":"https://api.github.com/users/BrainCrumbz","html_url":"https://github.com/BrainCrumbz","followers_url":"https://api.github.com/users/BrainCrumbz/followers","following_url":"https://api.github.com/users/BrainCrumbz/following{/other_user}","gists_url":"https://api.github.com/users/BrainCrumbz/gists{/gist_id}","starred_url":"https://api.github.com/users/BrainCrumbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrainCrumbz/subscriptions","organizations_url":"https://api.github.com/users/BrainCrumbz/orgs","repos_url":"https://api.github.com/users/BrainCrumbz/repos","events_url":"https://api.github.com/users/BrainCrumbz/events{/privacy}","received_events_url":"https://api.github.com/users/BrainCrumbz/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T09:39:58Z","updated_at":"2018-05-17T09:39:58Z","author_association":"CONTRIBUTOR","body":"Yep, rest assured Amir is well aware of all those implications. But it's a lost battle on this topic 😆 \r\n\r\nThat would be great for everyone used to work with VS Test Explorer (and VS Code too!), so yes please, feel free to move the discussion forward on this. Here's the state-of-the-art on current projects:\r\n\r\nDotNetTestNSpec adhered to the *contract* initially set for .NET Core 1.x projects, xproj-style, and thus able to work with those projects both in dotnet command line and in VS 2015 Test Explorer. It is available as a NuGet package as that is the way to be consumed by those environments.\r\n\r\nNSpec.VsAdapter adhered to the *classic* VS test adapter contract and works for .NET Framework 4.5+ projects, plain old csproj format. It is available first as a VSIX extension, being the way test adapters used to be consumed up to VS 2015. It is also available as a NuGet package, as at some point briefly during VS 2015 it was possible to distribute a kind of tooling-package, available for all projects in solution, without having them installed as a VS extension, so each solution could have its own version.\r\n\r\nOne direction to move forward could be upgrade NSpec.VsAdapter so that it can run under VS 2017 for plain old .NET Framework projects. There's loads of people still working on that framework, so they could make use of that. Not sure how it should be consumed and what has changed in Test Adapter contract.\r\n\r\nAnother direction is, as you mention at the beginning, to upgrade/evolve either one of the two to work with .NET Core 1.1+ SDK-style projects (and thus under VS 2017). Not sure from which one to pick up as in our team we have not invested a lot of time in figuring out the new test framework. It depends on which one is closer to the current requirements (e.g. does it still work with requests coming from a local TCP port or something, in a certain order? Is it back to expecting an *ITestDiscoverer* and *ITestExecutor* implementations?)\r\n\r\n-- ok, this was long, sorry about that!"}}
{"actor":{"display_login":"BrainCrumbz"}}