{"push_id":2501778799,"size":16,"distinct_size":16,"ref":"refs/heads/master","head":"4ccd2f81988115b778b4f6d7808485d82fbf458d","before":"7f85b799d9f1b8aabdc42706d88a977b186917c9","commits":[{"sha":"f329eb0db85566b238c641276c0adff637abd2e0","author":{"name":"Richard Opálka","email":"d3dfe07dfb4849902eb98b04c1b315281bd5040c@gmail.com"},"message":"Fixing FIXMEs.","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/f329eb0db85566b238c641276c0adff637abd2e0"},{"sha":"4b5ac4f608bd693be9fac9c0909e0f2db494eb61","author":{"name":"Richard Opálka","email":"d3dfe07dfb4849902eb98b04c1b315281bd5040c@gmail.com"},"message":"[WFCORE-2589] Removing useless code.\n\nDependency on 'module resolved service' already guarantees these dependencies\nare up see comment in the diff just one line above the useless code removal.","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/4b5ac4f608bd693be9fac9c0909e0f2db494eb61"},{"sha":"85e9f76f64f329ef9ae9d9f40cacc68f04c90047","author":{"name":"Richard Opálka","email":"d3dfe07dfb4849902eb98b04c1b315281bd5040c@gmail.com"},"message":"[WFCORE-2589] There are two ways how users can specify explicit optional module dependencies\nto a deployment:\n [1] via META-INF/MANIFEST.MF 'Dependencies' header\n [2] via jboss-deployment-structure/dependencies/module elements\n\nDefinition of 'optional' attribute of jboss-deployment-structure/dependencies/module element\n(which is by the way the only available description for user of how 'optional' deployment\ndependencies are handled at runtime regardless if they have been specified via [1] or [2])\nstates that:\n\n<xsd:attribute name=\"optional\" type=\"xsd:boolean\" use=\"optional\" default=\"false\">\n  <documentation>\n    Specifies whether this dependency is optional (defaults to false).\n    An optional dependency will not cause the module to fail to load\n    if not found; however if the module is added later, it will not be\n    retroactively linked into this module's dependency list.\n  </documentation>\n</xsd:attribute>\n\nThis fix eliminates these dynamic module dependencies mapping to MSC optional dependencies\nfor three reasons:\n * to make it consistent with documented 'optional module dependency' behaviour description above\n   (since upgrade to JBoss MSC 1.2.8.Final optional dependencies are behaving properly\n    and once such optional MSC dependency would appear it would cause complete reloading\n    to take appeared optional dependencies into account)\n * we would like to get rid of all MSC optional dependencies usages\n   (MSC optional dependencies are causing performance defects)\n * JBoss modules based classloading layer is capable of handling optional module dependencies on its own\n   (there is not need to emulate optionality in MSC layer too)","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/85e9f76f64f329ef9ae9d9f40cacc68f04c90047"},{"sha":"72248d57966fe4238030158a5b857867e0d3d49b","author":{"name":"Richard Opálka","email":"d3dfe07dfb4849902eb98b04c1b315281bd5040c@gmail.com"},"message":"[WFCORE-2235] Fixing race condition that appears when the following scenario happens:\n\nModule A depends on module B (optional dependency).\nBoth modules are dynamic (they're not present on the file system\nbut dynamically deployed at runtime). The following scenario exposes\nrace condition for this kind of dynamic modules:\n\n 1] Module A is starting and module B is not available yet\n 2] Module A during its initialization phase calls\n    ModuleLoader.loadModuleLocal() to resolve its optional module B dependency\n 3] Module A initialization thread registers \"newFuture\" with \"moduleMap\"\n 4] Module A initialization thread fails to find ModuleSpec of module B\n 5] ModuleLoadService representing Module B appears and is starting\n    (such service knows all its preconditions are met - its ModuleSpec is available)\n 6] MSC thread executing ModuleLoadService.start() (of module B)\n    is calling moduleLoader.loadModule(moduleB_Id)\n 7] MSC thread executing ModuleLoadService.start() (of module B)\n    enters ModuleLoader.loadModuleLocal() to find the module\n 8] MSC thread requests \"moduleMap\" and receives \"newFuture\" created in step [3]\n 9] MSC thread enters \"newFuture\" wait set and blocks (waiting for Module A\n    initialization thread to complete)\n10] Module A initialization thread wakes up and identifies that (moduleSpec == null)\n    MOduleLoader.loadModuleLocal() will return null\n11] Before method return \"finally\" sections is executed, where:\n    a) newFuture.setModule(null) is called\n    b) \"newFuture\" is removed from \"moduleMap\"\n12] MSC thread wakes up and throws ModuleNotFoundException\n\nThis fix ensures proper ordering of resolution process for dynamic modules\nand fixes aforementioned race condition.","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/72248d57966fe4238030158a5b857867e0d3d49b"},{"sha":"d301f8f787ee18fa9adef66590101dae34e61d6d","author":{"name":"Farah Juma","email":"ee7cac85feed24dc4a3c6180194d89f9a2bd6f5d@redhat.com"},"message":"[WFCORE-3749] Bump the Elytron subsystem model and schema versions to 3.0","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/d301f8f787ee18fa9adef66590101dae34e61d6d"},{"sha":"3baa8e35e12df16adab3202d784af53be2310154","author":{"name":"Lin Gao","email":"6a02aefb8d7b5b6c9a953c5824838ad15d29fe74@redhat.com"},"message":"[WFCORE-3715] JBOSS_HOME is unset in powershell scripts","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/3baa8e35e12df16adab3202d784af53be2310154"},{"sha":"69e28842db3f6af79f4da3146f86d92a8f2a49db","author":{"name":"David M. Lloyd","email":"a7fa8370f581a3882f4f926ea59836a9b395fb76@redhat.com"},"message":"[WFCORE-3705] Cleanup: add one missing dependency","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/69e28842db3f6af79f4da3146f86d92a8f2a49db"},{"sha":"ee0c3474f66639cc7dba772d6dc34941bb754e9e","author":{"name":"Jason T. Greene","email":"3b1d8a5fc3290e7672296cde7b7fbba0bd4fbfeb@redhat.com"},"message":"Add Common Cure Rights Commitment","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/ee0c3474f66639cc7dba772d6dc34941bb754e9e"},{"sha":"f55893352461ffef7ba93a451353a0c71a9ab445","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Merge pull request #3215 from dmlloyd/wfcore-3705-2\n\n[WFCORE-3705] Cleanup: add one missing dependency","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/f55893352461ffef7ba93a451353a0c71a9ab445"},{"sha":"bd25520552058bf896db89d67e9e52d419086300","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Prepare for 5.0.0.Alpha3 release","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/bd25520552058bf896db89d67e9e52d419086300"},{"sha":"ccbb236c514a832219763cb2b9b8ec43c08985fc","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Next is 5.0.0.Alpha4","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/ccbb236c514a832219763cb2b9b8ec43c08985fc"},{"sha":"21a6c950c785ad24a67cf73c16c07854b5b60234","author":{"name":"Chao Wang","email":"45e82e17d9e9123ee96c5ebe5adce506ed6aae27@redhat.com"},"message":"[WFCORE-3756] add doPrivileged block to system property get action if SM is enabled.","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/21a6c950c785ad24a67cf73c16c07854b5b60234"},{"sha":"cfd82355193b52b02f43a2aafce16ce2ac46773e","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Merge pull request #3214 from fjuma/WFCORE-3749\n\n[WFCORE-3749] Bump the Elytron subsystem model and schema versions to 3.0","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/cfd82355193b52b02f43a2aafce16ce2ac46773e"},{"sha":"248c87907cbbdbe4002ba0ba521d9c99c97c56d3","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Merge pull request #3045 from ropalka/WFCORE-2589\n\n[WFCORE-2589] Eliminating MSC Optional Dependencies in classloading layer","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/248c87907cbbdbe4002ba0ba521d9c99c97c56d3"},{"sha":"4752d5c4b7701e150bf9924f4e6101ba8234152f","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Merge pull request #3203 from gaol/WFCORE-3715\n\n[WFCORE-3715] JBOSS_HOME is unset in powershell scripts","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/4752d5c4b7701e150bf9924f4e6101ba8234152f"},{"sha":"4ccd2f81988115b778b4f6d7808485d82fbf458d","author":{"name":"Jeff Mesnil","email":"3503643d135e654b981cd46d1304f8cfa67a0b2e@gmail.com"},"message":"Merge pull request #3217 from soul2zimate/WFCORE-3756\n\n[WFCORE-3756] add doPrivileged block to system property get action if…","distinct":true,"url":"https://api.github.com/repos/darranl/wildfly-core/commits/4ccd2f81988115b778b4f6d7808485d82fbf458d"}]}
{"actor":{"display_login":"darranl"}}