{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/comments/189227236","pull_request_review_id":121366537,"id":189227236,"diff_hunk":"@@ -657,3 +665,130 @@ end\n     cache.k2 .= k1\n   end\n end\n+\n+function initialize!(integrator,cache::VCAB4ConstantCache)\n+  integrator.fsalfirst = integrator.f(integrator.uprev, integrator.p, integrator.t) # Pre-start fsal\n+  integrator.kshortsize = 2\n+  integrator.k = typeof(integrator.k)(integrator.kshortsize)\n+\n+  # Avoid undefined entries if k is an array of arrays\n+  integrator.fsallast = zero(integrator.fsalfirst)\n+  integrator.k[1] = integrator.fsalfirst\n+  integrator.k[2] = integrator.fsallast\n+end\n+\n+@muladd function perform_step!(integrator,cache::VCAB4ConstantCache,repeat_step=false)\n+  @unpack t,dt,uprev,u,f,p = integrator\n+  @unpack k2,k3,k4,dts,ϕstar_nm1,k,order,rk4constcache = cache\n+  k1 = integrator.fsalfirst\n+  if integrator.u_modified\n+    cache.step = 1\n+  end\n+  cnt = cache.step\n+  if cache.step <= 4\n+    dts[cnt] = dt\n+    cache.step += 1\n+  else\n+    dts[4] = dts[3]\n+    dts[3] = dts[2]\n+    dts[2] = dts[1]\n+    dts[1] = dt\n+  end\n+  next_point = t+dt\n+  ϕ_n, ϕstar_n = ϕ_and_ϕstar!(cache, k1)\n+  cache.ϕstar_nm1 .= ϕstar_n\n+  if cnt == 1 || cnt == 2 || cnt == 3\n+    perform_step!(integrator, rk4constcache)\n+    cache.k = min(k+1, order)\n+    if cnt == 1\n+      cache.k4 = k1\n+    elseif cnt == 2\n+      cache.k3 = k1\n+    else\n+      cache.k2 = k1\n+    end\n+  else\n+    g = g_coefs!(cache)\n+    u = uprev\n+    for i = 1:k\n+        u += dt * g[i] * ϕstar_n[i]\n+    end\n+    if integrator.opts.adaptive\n+      utilde = uprev + (dt/24)*(55*k1 - 59*k2 + 37*k3 - 9*k4) - u","path":"src/perform_step/adams_bashforth_moulton_perform_step.jl","position":85,"original_position":85,"commit_id":"f35ce96847a40237f65cca89da4b9234ffd0dc1e","original_commit_id":"f35ce96847a40237f65cca89da4b9234ffd0dc1e","user":{"login":"ChrisRackauckas","id":1814174,"avatar_url":"https://avatars2.githubusercontent.com/u/1814174?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"body":"How does Hairer I say that ddeabm defines the error estimate? @YingboMa has my book right now so I can't check the formula.","created_at":"2018-05-18T10:26:17Z","updated_at":"2018-05-18T10:26:17Z","html_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/pull/350#discussion_r189227236","pull_request_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/comments/189227236"},"html":{"href":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/pull/350#discussion_r189227236"},"pull_request":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350"}},"in_reply_to_id":189172856},"pull_request":{"url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350","id":188900786,"html_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/pull/350","diff_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/pull/350.diff","patch_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/pull/350.patch","issue_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues/350","number":350,"state":"open","locked":false,"title":"4th order Adams explicit variable step size method","user":{"login":"sipah00","id":23627932,"avatar_url":"https://avatars3.githubusercontent.com/u/23627932?v=4","gravatar_id":"","url":"https://api.github.com/users/sipah00","html_url":"https://github.com/sipah00","followers_url":"https://api.github.com/users/sipah00/followers","following_url":"https://api.github.com/users/sipah00/following{/other_user}","gists_url":"https://api.github.com/users/sipah00/gists{/gist_id}","starred_url":"https://api.github.com/users/sipah00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipah00/subscriptions","organizations_url":"https://api.github.com/users/sipah00/orgs","repos_url":"https://api.github.com/users/sipah00/repos","events_url":"https://api.github.com/users/sipah00/events{/privacy}","received_events_url":"https://api.github.com/users/sipah00/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-18T01:32:10Z","updated_at":"2018-05-18T10:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ab5efc6adffe0554d8c07587863014afe52ab4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350/commits","review_comments_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350/comments","review_comment_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues/350/comments","statuses_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/statuses/f35ce96847a40237f65cca89da4b9234ffd0dc1e","head":{"label":"sipah00:vcab4","ref":"vcab4","sha":"f35ce96847a40237f65cca89da4b9234ffd0dc1e","user":{"login":"sipah00","id":23627932,"avatar_url":"https://avatars3.githubusercontent.com/u/23627932?v=4","gravatar_id":"","url":"https://api.github.com/users/sipah00","html_url":"https://github.com/sipah00","followers_url":"https://api.github.com/users/sipah00/followers","following_url":"https://api.github.com/users/sipah00/following{/other_user}","gists_url":"https://api.github.com/users/sipah00/gists{/gist_id}","starred_url":"https://api.github.com/users/sipah00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipah00/subscriptions","organizations_url":"https://api.github.com/users/sipah00/orgs","repos_url":"https://api.github.com/users/sipah00/repos","events_url":"https://api.github.com/users/sipah00/events{/privacy}","received_events_url":"https://api.github.com/users/sipah00/received_events","type":"User","site_admin":false},"repo":{"id":121093437,"name":"OrdinaryDiffEq.jl","full_name":"sipah00/OrdinaryDiffEq.jl","owner":{"login":"sipah00","id":23627932,"avatar_url":"https://avatars3.githubusercontent.com/u/23627932?v=4","gravatar_id":"","url":"https://api.github.com/users/sipah00","html_url":"https://github.com/sipah00","followers_url":"https://api.github.com/users/sipah00/followers","following_url":"https://api.github.com/users/sipah00/following{/other_user}","gists_url":"https://api.github.com/users/sipah00/gists{/gist_id}","starred_url":"https://api.github.com/users/sipah00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipah00/subscriptions","organizations_url":"https://api.github.com/users/sipah00/orgs","repos_url":"https://api.github.com/users/sipah00/repos","events_url":"https://api.github.com/users/sipah00/events{/privacy}","received_events_url":"https://api.github.com/users/sipah00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sipah00/OrdinaryDiffEq.jl","description":"DiffEq solvers for ordinary differential equations","fork":true,"url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl","forks_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/forks","keys_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/teams","hooks_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/hooks","issue_events_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/issues/events{/number}","events_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/events","assignees_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/assignees{/user}","branches_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/branches{/branch}","tags_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/tags","blobs_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/languages","stargazers_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/stargazers","contributors_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/contributors","subscribers_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/subscribers","subscription_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/subscription","commits_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/contents/{+path}","compare_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/merges","archive_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/downloads","issues_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/issues{/number}","pulls_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/labels{/name}","releases_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/releases{/id}","deployments_url":"https://api.github.com/repos/sipah00/OrdinaryDiffEq.jl/deployments","created_at":"2018-02-11T06:34:12Z","updated_at":"2018-05-15T05:29:49Z","pushed_at":"2018-05-18T10:08:49Z","git_url":"git://github.com/sipah00/OrdinaryDiffEq.jl.git","ssh_url":"git@github.com:sipah00/OrdinaryDiffEq.jl.git","clone_url":"https://github.com/sipah00/OrdinaryDiffEq.jl.git","svn_url":"https://github.com/sipah00/OrdinaryDiffEq.jl","homepage":null,"size":2788,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaDiffEq:master","ref":"master","sha":"e50f73d42ea8f5c52e6651170daa4cccc21d0699","user":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":71651195,"name":"OrdinaryDiffEq.jl","full_name":"JuliaDiffEq/OrdinaryDiffEq.jl","owner":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl","description":"DiffEq solvers for ordinary differential equations","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/deployments","created_at":"2016-10-22T16:27:51Z","updated_at":"2018-05-14T21:07:56Z","pushed_at":"2018-05-18T10:08:50Z","git_url":"git://github.com/JuliaDiffEq/OrdinaryDiffEq.jl.git","ssh_url":"git@github.com:JuliaDiffEq/OrdinaryDiffEq.jl.git","clone_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl.git","svn_url":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl","homepage":null,"size":2768,"stargazers_count":36,"watchers_count":36,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":80,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350"},"html":{"href":"https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl/pull/350"},"issue":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues/350"},"comments":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiffEq/OrdinaryDiffEq.jl/statuses/f35ce96847a40237f65cca89da4b9234ffd0dc1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChrisRackauckas"}}