{"action":"created","issue":{"url":"https://api.github.com/repos/mitodl/open-discussions/issues/736","repository_url":"https://api.github.com/repos/mitodl/open-discussions","labels_url":"https://api.github.com/repos/mitodl/open-discussions/issues/736/labels{/name}","comments_url":"https://api.github.com/repos/mitodl/open-discussions/issues/736/comments","events_url":"https://api.github.com/repos/mitodl/open-discussions/issues/736/events","html_url":"https://github.com/mitodl/open-discussions/pull/736","id":326233789,"number":736,"title":"add user menu","user":{"login":"aliceriot","id":6207644,"avatar_url":"https://avatars0.githubusercontent.com/u/6207644?v=4","gravatar_id":"","url":"https://api.github.com/users/aliceriot","html_url":"https://github.com/aliceriot","followers_url":"https://api.github.com/users/aliceriot/followers","following_url":"https://api.github.com/users/aliceriot/following{/other_user}","gists_url":"https://api.github.com/users/aliceriot/gists{/gist_id}","starred_url":"https://api.github.com/users/aliceriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliceriot/subscriptions","organizations_url":"https://api.github.com/users/aliceriot/orgs","repos_url":"https://api.github.com/users/aliceriot/repos","events_url":"https://api.github.com/users/aliceriot/events{/privacy}","received_events_url":"https://api.github.com/users/aliceriot/received_events","type":"User","site_admin":false},"labels":[{"id":627437808,"url":"https://api.github.com/repos/mitodl/open-discussions/labels/Needs%20Review","name":"Needs Review","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-24T18:12:25Z","updated_at":"2018-05-24T18:19:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mitodl/open-discussions/pulls/736","html_url":"https://github.com/mitodl/open-discussions/pull/736","diff_url":"https://github.com/mitodl/open-discussions/pull/736.diff","patch_url":"https://github.com/mitodl/open-discussions/pull/736.patch"},"body":"#### What are the relevant tickets?\r\n\r\ncloses #679 \r\n\r\n#### What's this PR do?\r\n\r\nThis adds a little user menu in the upper right of the toolbar. It looks like this:\r\n\r\n![usermenufasdf](https://user-images.githubusercontent.com/6207644/40503822-5afceddc-5f5d-11e8-8a30-d585b97b4008.png)\r\n\r\nmobile view:\r\n\r\n![fodfodfaj4rere](https://user-images.githubusercontent.com/6207644/40503861-6f8c072e-5f5d-11e8-93b3-644ba7f08df7.png)\r\n\r\nIf you click on the profile image it will open a little dropdown:\r\n\r\n![usermenufasdfffffasdfasdfasdffasdfasdfasdfasdf](https://user-images.githubusercontent.com/6207644/40503808-570d3ede-5f5d-11e8-9721-03537fc466cd.png)\r\n\r\n\r\nIf the email auth feature flag is on it will include a logout link too. I also went ahead and remove the `> Discussions` from the toolbar and added a basic 'home' link in the sidebar, because without doing that the user menu was cutting off the text on mobile.\r\n\r\n#### How should this be manually tested?\r\n\r\nThe user menu should open when you click on the profile image, and it should close when you click outside. If you click on a link in the menu, the menu should close too. There should be a 'Home' link in the sidebar, adn teh `> Discussions` link should be gone from the toolbar.\r\n\r\nAlso, if you have the email auth feature flag enabled you should see a 'Sign Out' thing which links to `/logout`.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mitodl/open-discussions/issues/comments/391811833","html_url":"https://github.com/mitodl/open-discussions/pull/736#issuecomment-391811833","issue_url":"https://api.github.com/repos/mitodl/open-discussions/issues/736","id":391811833,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T18:19:50Z","updated_at":"2018-05-24T18:19:50Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=h1) Report\n> Merging [#736](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=desc) into [master](https://codecov.io/gh/mitodl/open-discussions/commit/e5fa1826ea09792397af0fa85bdcc3b8ed237788?src=pr&el=desc) will **increase** coverage by `2.2%`.\n> The diff coverage is `93.58%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mitodl/open-discussions/pull/736/graphs/tree.svg?token=sfB7hdSurz&height=150&width=650&src=pr)](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master     #736     +/-   ##\n=========================================\n+ Coverage   95.97%   98.18%   +2.2%     \n=========================================\n  Files         255      165     -90     \n  Lines        8368     5331   -3037     \n  Branches      322        0    -322     \n=========================================\n- Hits         8031     5234   -2797     \n+ Misses        286       97    -189     \n+ Partials       51        0     -51\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [static/js/global\\_init.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2dsb2JhbF9pbml0Lmpz) | `94.44% <ø> (ø)` | :arrow_up: |\n| [static/js/components/Navigation\\_test.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2NvbXBvbmVudHMvTmF2aWdhdGlvbl90ZXN0Lmpz) | `100% <100%> (ø)` | :arrow_up: |\n| [static/js/reducers/ui.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL3JlZHVjZXJzL3VpLmpz) | `100% <100%> (ø)` | :arrow_up: |\n| [static/js/reducers/ui\\_test.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL3JlZHVjZXJzL3VpX3Rlc3QuanM=) | `100% <100%> (ø)` | :arrow_up: |\n| [static/js/components/UserMenu\\_test.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2NvbXBvbmVudHMvVXNlck1lbnVfdGVzdC5qcw==) | `100% <100%> (ø)` | |\n| [static/js/actions/ui.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2FjdGlvbnMvdWkuanM=) | `100% <100%> (ø)` | :arrow_up: |\n| [static/js/components/Navigation.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2NvbXBvbmVudHMvTmF2aWdhdGlvbi5qcw==) | `100% <100%> (ø)` | :arrow_up: |\n| [static/js/components/Toolbar.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2NvbXBvbmVudHMvVG9vbGJhci5qcw==) | `100% <100%> (ø)` | :arrow_up: |\n| [static/js/containers/App.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2NvbnRhaW5lcnMvQXBwLmpz) | `87.5% <57.14%> (-5.84%)` | :arrow_down: |\n| [static/js/components/UserMenu.js](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree#diff-c3RhdGljL2pzL2NvbXBvbmVudHMvVXNlck1lbnUuanM=) | `83.33% <83.33%> (ø)` | |\n| ... and [93 more](https://codecov.io/gh/mitodl/open-discussions/pull/736/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=footer). Last update [e5fa182...679cbd5](https://codecov.io/gh/mitodl/open-discussions/pull/736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}