{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/barnes/pulls/comments/209319680","pull_request_review_id":145316940,"id":209319680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTMxOTY4MA==","diff_hunk":"@@ -54,7 +54,12 @@ def self.start(interval: DEFAULT_INTERVAL, aggregation_period: DEFAULT_AGGREGATI\n         panels << Barnes::ResourceUsage.new(sample_rate)\n       end\n \n-      Periodic.new reporter: reporter, sample_rate: sample_rate, panels: panels\n+      Periodic.new(\n+        reporter:    reporter,\n+        sample_rate: sample_rate,\n+        panels:      panels,\n+        debug:       ENV['BARNES_DEBUG']","path":"lib/barnes.rb","position":9,"original_position":9,"commit_id":"42cbb84d5e89607cbb8727a52c6047129e21044e","original_commit_id":"4d1a4e473f1bfc57cfbe85462926bb2db3be7b19","user":{"login":"bf4","id":142914,"node_id":"MDQ6VXNlcjE0MjkxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/142914?v=4","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"fwiw, in rails/spring\r\n\r\n```ruby\r\ndisable = ENV[\"DISABLE_SPRING\"]\r\nenabled = (disable.nil? || disable.empty? || disable == \"0\")\r\n```\r\n\r\n(I have DISABLE_SPRING=1 in my bash profile ;)","created_at":"2018-08-10T16:43:34Z","updated_at":"2018-08-10T16:43:34Z","html_url":"https://github.com/heroku/barnes/pull/17#discussion_r209319680","pull_request_url":"https://api.github.com/repos/heroku/barnes/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/heroku/barnes/pulls/comments/209319680"},"html":{"href":"https://github.com/heroku/barnes/pull/17#discussion_r209319680"},"pull_request":{"href":"https://api.github.com/repos/heroku/barnes/pulls/17"}},"in_reply_to_id":199615565},"pull_request":{"url":"https://api.github.com/repos/heroku/barnes/pulls/17","id":198746359,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzQ2MzU5","html_url":"https://github.com/heroku/barnes/pull/17","diff_url":"https://github.com/heroku/barnes/pull/17.diff","patch_url":"https://github.com/heroku/barnes/pull/17.patch","issue_url":"https://api.github.com/repos/heroku/barnes/issues/17","number":17,"state":"closed","locked":false,"title":"Add support for Puma Max threads and Spawned","user":{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"body":"- Adding “max threads” allows us to view pool capacity as a ratio of possible capacity rather than a stand alone number.\r\n- Addin “spawned” threads helps people to visualize what their actual thread count is compared to maximum. While we recommend setting min=max this will help those who choose not to do that\r\n\r\n- Adding integration tests that actually exercise puma codepaths.","created_at":"2018-07-02T17:41:21Z","updated_at":"2018-08-10T16:43:34Z","closed_at":"2018-07-03T14:51:57Z","merged_at":"2018-07-03T14:51:57Z","merge_commit_sha":"db2eabdeaeef21e5263ac945be6d249fe6c961ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heroku/barnes/pulls/17/commits","review_comments_url":"https://api.github.com/repos/heroku/barnes/pulls/17/comments","review_comment_url":"https://api.github.com/repos/heroku/barnes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/barnes/issues/17/comments","statuses_url":"https://api.github.com/repos/heroku/barnes/statuses/42cbb84d5e89607cbb8727a52c6047129e21044e","head":{"label":"heroku:schneems/puma-max-threads","ref":"schneems/puma-max-threads","sha":"42cbb84d5e89607cbb8727a52c6047129e21044e","user":{"login":"heroku","id":23211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEx","avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":99832748,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgzMjc0OA==","name":"barnes","full_name":"heroku/barnes","owner":{"login":"heroku","id":23211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEx","avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/barnes","description":"Tell StatsD about request time, GC, objects and more. Latest Rails 4 and Ruby 2.1 support, and ancient Rails 2 and Ruby 1.8 support.","fork":true,"url":"https://api.github.com/repos/heroku/barnes","forks_url":"https://api.github.com/repos/heroku/barnes/forks","keys_url":"https://api.github.com/repos/heroku/barnes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/barnes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/barnes/teams","hooks_url":"https://api.github.com/repos/heroku/barnes/hooks","issue_events_url":"https://api.github.com/repos/heroku/barnes/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/barnes/events","assignees_url":"https://api.github.com/repos/heroku/barnes/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/barnes/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/barnes/tags","blobs_url":"https://api.github.com/repos/heroku/barnes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/barnes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/barnes/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/barnes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/barnes/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/barnes/languages","stargazers_url":"https://api.github.com/repos/heroku/barnes/stargazers","contributors_url":"https://api.github.com/repos/heroku/barnes/contributors","subscribers_url":"https://api.github.com/repos/heroku/barnes/subscribers","subscription_url":"https://api.github.com/repos/heroku/barnes/subscription","commits_url":"https://api.github.com/repos/heroku/barnes/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/barnes/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/barnes/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/barnes/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/barnes/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/barnes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/barnes/merges","archive_url":"https://api.github.com/repos/heroku/barnes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/barnes/downloads","issues_url":"https://api.github.com/repos/heroku/barnes/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/barnes/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/barnes/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/barnes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/barnes/labels{/name}","releases_url":"https://api.github.com/repos/heroku/barnes/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/barnes/deployments","created_at":"2017-08-09T17:00:40Z","updated_at":"2018-07-24T20:10:42Z","pushed_at":"2018-07-24T20:10:44Z","git_url":"git://github.com/heroku/barnes.git","ssh_url":"git@github.com:heroku/barnes.git","clone_url":"https://github.com/heroku/barnes.git","svn_url":"https://github.com/heroku/barnes","homepage":"","size":139,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":10,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"e2eee5c270bd4cfb9fda5d67dab6cfa541e4a066","user":{"login":"heroku","id":23211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEx","avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":99832748,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgzMjc0OA==","name":"barnes","full_name":"heroku/barnes","owner":{"login":"heroku","id":23211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEx","avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/barnes","description":"Tell StatsD about request time, GC, objects and more. Latest Rails 4 and Ruby 2.1 support, and ancient Rails 2 and Ruby 1.8 support.","fork":true,"url":"https://api.github.com/repos/heroku/barnes","forks_url":"https://api.github.com/repos/heroku/barnes/forks","keys_url":"https://api.github.com/repos/heroku/barnes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/barnes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/barnes/teams","hooks_url":"https://api.github.com/repos/heroku/barnes/hooks","issue_events_url":"https://api.github.com/repos/heroku/barnes/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/barnes/events","assignees_url":"https://api.github.com/repos/heroku/barnes/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/barnes/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/barnes/tags","blobs_url":"https://api.github.com/repos/heroku/barnes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/barnes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/barnes/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/barnes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/barnes/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/barnes/languages","stargazers_url":"https://api.github.com/repos/heroku/barnes/stargazers","contributors_url":"https://api.github.com/repos/heroku/barnes/contributors","subscribers_url":"https://api.github.com/repos/heroku/barnes/subscribers","subscription_url":"https://api.github.com/repos/heroku/barnes/subscription","commits_url":"https://api.github.com/repos/heroku/barnes/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/barnes/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/barnes/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/barnes/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/barnes/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/barnes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/barnes/merges","archive_url":"https://api.github.com/repos/heroku/barnes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/barnes/downloads","issues_url":"https://api.github.com/repos/heroku/barnes/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/barnes/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/barnes/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/barnes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/barnes/labels{/name}","releases_url":"https://api.github.com/repos/heroku/barnes/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/barnes/deployments","created_at":"2017-08-09T17:00:40Z","updated_at":"2018-07-24T20:10:42Z","pushed_at":"2018-07-24T20:10:44Z","git_url":"git://github.com/heroku/barnes.git","ssh_url":"git@github.com:heroku/barnes.git","clone_url":"https://github.com/heroku/barnes.git","svn_url":"https://github.com/heroku/barnes","homepage":"","size":139,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/barnes/pulls/17"},"html":{"href":"https://github.com/heroku/barnes/pull/17"},"issue":{"href":"https://api.github.com/repos/heroku/barnes/issues/17"},"comments":{"href":"https://api.github.com/repos/heroku/barnes/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/barnes/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/barnes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/barnes/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/barnes/statuses/42cbb84d5e89607cbb8727a52c6047129e21044e"}},"author_association":"NONE"}}
{"actor":{"display_login":"bf4"}}