{"action":"closed","number":196,"pull_request":{"url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/196","id":208469444,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDY5NDQ0","html_url":"https://github.com/nerves-hub/nerves_hub_web/pull/196","diff_url":"https://github.com/nerves-hub/nerves_hub_web/pull/196.diff","patch_url":"https://github.com/nerves-hub/nerves_hub_web/pull/196.patch","issue_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/196","number":196,"state":"closed","locked":false,"title":"Fix channels","user":{"login":"mobileoverlord","id":1391351,"node_id":"MDQ6VXNlcjEzOTEzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1391351?v=4","gravatar_id":"","url":"https://api.github.com/users/mobileoverlord","html_url":"https://github.com/mobileoverlord","followers_url":"https://api.github.com/users/mobileoverlord/followers","following_url":"https://api.github.com/users/mobileoverlord/following{/other_user}","gists_url":"https://api.github.com/users/mobileoverlord/gists{/gist_id}","starred_url":"https://api.github.com/users/mobileoverlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobileoverlord/subscriptions","organizations_url":"https://api.github.com/users/mobileoverlord/orgs","repos_url":"https://api.github.com/users/mobileoverlord/repos","events_url":"https://api.github.com/users/mobileoverlord/events{/privacy}","received_events_url":"https://api.github.com/users/mobileoverlord/received_events","type":"User","site_admin":false},"body":"Turns out that you can only send \"disconnect\" events to socket id topics. In order to differentiate the recipients we are subscribing to a `device:#{device.id}` topic inside the channel. I have also updated the topics for connecting to represent `firmware:#{uuid}` so there are no collisions between the self subscribed devices and firmwares. I have tested this in prod and its sending update messages. ","created_at":"2018-08-15T04:18:37Z","updated_at":"2018-08-16T15:35:39Z","closed_at":"2018-08-16T15:35:39Z","merged_at":"2018-08-16T15:35:39Z","merge_commit_sha":"1338ec0c448ccbf4950905898390b51675a8e298","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jlmcgehee21","id":8727616,"node_id":"MDQ6VXNlcjg3Mjc2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8727616?v=4","gravatar_id":"","url":"https://api.github.com/users/jlmcgehee21","html_url":"https://github.com/jlmcgehee21","followers_url":"https://api.github.com/users/jlmcgehee21/followers","following_url":"https://api.github.com/users/jlmcgehee21/following{/other_user}","gists_url":"https://api.github.com/users/jlmcgehee21/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmcgehee21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmcgehee21/subscriptions","organizations_url":"https://api.github.com/users/jlmcgehee21/orgs","repos_url":"https://api.github.com/users/jlmcgehee21/repos","events_url":"https://api.github.com/users/jlmcgehee21/events{/privacy}","received_events_url":"https://api.github.com/users/jlmcgehee21/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/196/commits","review_comments_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/196/comments","review_comment_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/196/comments","statuses_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/statuses/9975f02336510edfe186f19f45a1d0c50f515b25","head":{"label":"nerves-hub:fwup-api","ref":"fwup-api","sha":"9975f02336510edfe186f19f45a1d0c50f515b25","user":{"login":"nerves-hub","id":39568345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTY4MzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/39568345?v=4","gravatar_id":"","url":"https://api.github.com/users/nerves-hub","html_url":"https://github.com/nerves-hub","followers_url":"https://api.github.com/users/nerves-hub/followers","following_url":"https://api.github.com/users/nerves-hub/following{/other_user}","gists_url":"https://api.github.com/users/nerves-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/nerves-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerves-hub/subscriptions","organizations_url":"https://api.github.com/users/nerves-hub/orgs","repos_url":"https://api.github.com/users/nerves-hub/repos","events_url":"https://api.github.com/users/nerves-hub/events{/privacy}","received_events_url":"https://api.github.com/users/nerves-hub/received_events","type":"Organization","site_admin":false},"repo":{"id":119747156,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3NDcxNTY=","name":"nerves_hub_web","full_name":"nerves-hub/nerves_hub_web","owner":{"login":"nerves-hub","id":39568345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTY4MzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/39568345?v=4","gravatar_id":"","url":"https://api.github.com/users/nerves-hub","html_url":"https://github.com/nerves-hub","followers_url":"https://api.github.com/users/nerves-hub/followers","following_url":"https://api.github.com/users/nerves-hub/following{/other_user}","gists_url":"https://api.github.com/users/nerves-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/nerves-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerves-hub/subscriptions","organizations_url":"https://api.github.com/users/nerves-hub/orgs","repos_url":"https://api.github.com/users/nerves-hub/repos","events_url":"https://api.github.com/users/nerves-hub/events{/privacy}","received_events_url":"https://api.github.com/users/nerves-hub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nerves-hub/nerves_hub_web","description":"Manage firmware updates for Nerves devices","fork":false,"url":"https://api.github.com/repos/nerves-hub/nerves_hub_web","forks_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/forks","keys_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/teams","hooks_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/hooks","issue_events_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/events{/number}","events_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/events","assignees_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/assignees{/user}","branches_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/branches{/branch}","tags_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/tags","blobs_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/statuses/{sha}","languages_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/languages","stargazers_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/stargazers","contributors_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/contributors","subscribers_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/subscribers","subscription_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/subscription","commits_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/contents/{+path}","compare_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/merges","archive_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/downloads","issues_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues{/number}","pulls_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls{/number}","milestones_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/milestones{/number}","notifications_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/labels{/name}","releases_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/releases{/id}","deployments_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/deployments","created_at":"2018-01-31T21:42:05Z","updated_at":"2018-08-16T15:32:51Z","pushed_at":"2018-08-16T15:35:39Z","git_url":"git://github.com/nerves-hub/nerves_hub_web.git","ssh_url":"git@github.com:nerves-hub/nerves_hub_web.git","clone_url":"https://github.com/nerves-hub/nerves_hub_web.git","svn_url":"https://github.com/nerves-hub/nerves_hub_web","homepage":"http://nerves-hub.org/","size":2428,"stargazers_count":20,"watchers_count":20,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":19,"watchers":20,"default_branch":"master"}},"base":{"label":"nerves-hub:master","ref":"master","sha":"b35450d2e5cda5cc4d900dc95caf81db3d9afb12","user":{"login":"nerves-hub","id":39568345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTY4MzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/39568345?v=4","gravatar_id":"","url":"https://api.github.com/users/nerves-hub","html_url":"https://github.com/nerves-hub","followers_url":"https://api.github.com/users/nerves-hub/followers","following_url":"https://api.github.com/users/nerves-hub/following{/other_user}","gists_url":"https://api.github.com/users/nerves-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/nerves-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerves-hub/subscriptions","organizations_url":"https://api.github.com/users/nerves-hub/orgs","repos_url":"https://api.github.com/users/nerves-hub/repos","events_url":"https://api.github.com/users/nerves-hub/events{/privacy}","received_events_url":"https://api.github.com/users/nerves-hub/received_events","type":"Organization","site_admin":false},"repo":{"id":119747156,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3NDcxNTY=","name":"nerves_hub_web","full_name":"nerves-hub/nerves_hub_web","owner":{"login":"nerves-hub","id":39568345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTY4MzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/39568345?v=4","gravatar_id":"","url":"https://api.github.com/users/nerves-hub","html_url":"https://github.com/nerves-hub","followers_url":"https://api.github.com/users/nerves-hub/followers","following_url":"https://api.github.com/users/nerves-hub/following{/other_user}","gists_url":"https://api.github.com/users/nerves-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/nerves-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerves-hub/subscriptions","organizations_url":"https://api.github.com/users/nerves-hub/orgs","repos_url":"https://api.github.com/users/nerves-hub/repos","events_url":"https://api.github.com/users/nerves-hub/events{/privacy}","received_events_url":"https://api.github.com/users/nerves-hub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nerves-hub/nerves_hub_web","description":"Manage firmware updates for Nerves devices","fork":false,"url":"https://api.github.com/repos/nerves-hub/nerves_hub_web","forks_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/forks","keys_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/teams","hooks_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/hooks","issue_events_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/events{/number}","events_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/events","assignees_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/assignees{/user}","branches_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/branches{/branch}","tags_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/tags","blobs_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/statuses/{sha}","languages_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/languages","stargazers_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/stargazers","contributors_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/contributors","subscribers_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/subscribers","subscription_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/subscription","commits_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/contents/{+path}","compare_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/merges","archive_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/downloads","issues_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues{/number}","pulls_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls{/number}","milestones_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/milestones{/number}","notifications_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/labels{/name}","releases_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/releases{/id}","deployments_url":"https://api.github.com/repos/nerves-hub/nerves_hub_web/deployments","created_at":"2018-01-31T21:42:05Z","updated_at":"2018-08-16T15:32:51Z","pushed_at":"2018-08-16T15:35:39Z","git_url":"git://github.com/nerves-hub/nerves_hub_web.git","ssh_url":"git@github.com:nerves-hub/nerves_hub_web.git","clone_url":"https://github.com/nerves-hub/nerves_hub_web.git","svn_url":"https://github.com/nerves-hub/nerves_hub_web","homepage":"http://nerves-hub.org/","size":2428,"stargazers_count":20,"watchers_count":20,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":19,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/196"},"html":{"href":"https://github.com/nerves-hub/nerves_hub_web/pull/196"},"issue":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/196"},"comments":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/nerves-hub/nerves_hub_web/statuses/9975f02336510edfe186f19f45a1d0c50f515b25"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mobileoverlord","id":1391351,"node_id":"MDQ6VXNlcjEzOTEzNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1391351?v=4","gravatar_id":"","url":"https://api.github.com/users/mobileoverlord","html_url":"https://github.com/mobileoverlord","followers_url":"https://api.github.com/users/mobileoverlord/followers","following_url":"https://api.github.com/users/mobileoverlord/following{/other_user}","gists_url":"https://api.github.com/users/mobileoverlord/gists{/gist_id}","starred_url":"https://api.github.com/users/mobileoverlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobileoverlord/subscriptions","organizations_url":"https://api.github.com/users/mobileoverlord/orgs","repos_url":"https://api.github.com/users/mobileoverlord/repos","events_url":"https://api.github.com/users/mobileoverlord/events{/privacy}","received_events_url":"https://api.github.com/users/mobileoverlord/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":81,"deletions":42,"changed_files":7}}
{"actor":{"display_login":"mobileoverlord"}}