{"action":"created","comment":{"url":"https://api.github.com/repos/snony/stocktracker/pulls/comments/221578732","pull_request_review_id":160258050,"id":221578732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU3ODczMg==","diff_hunk":"@@ -1,18 +1,25 @@\n interface HistoryData {\n-  date: string\n-  [key: string]: string\n+  readonly date: string\n+  readonly [key: string]: string\n }\n \n export interface HistoryProps {\n   readonly company: string\n   readonly history: HistoryData[]\n   readonly priceFilter: string\n   readonly dateFilter: string\n-  onClickFilterHistoryByDate(symbol: string, value: string): void\n-  onClickFilterHistoryByPrice(symbol: string, value: string): void\n+  readonly onClickFilterHistoryByDate: (symbol: string, value: string) => void\n+  readonly onClickFilterHistoryByPrice: (symbol: string, value: string) => void","path":"src/history/types.ts","position":16,"original_position":16,"commit_id":"042d3546e1936d6f1eae3aad9a6b8640e6a200cc","original_commit_id":"042d3546e1936d6f1eae3aad9a6b8640e6a200cc","user":{"login":"snony","id":42961027,"node_id":"MDQ6VXNlcjQyOTYxMDI3","avatar_url":"https://avatars3.githubusercontent.com/u/42961027?v=4","gravatar_id":"","url":"https://api.github.com/users/snony","html_url":"https://github.com/snony","followers_url":"https://api.github.com/users/snony/followers","following_url":"https://api.github.com/users/snony/following{/other_user}","gists_url":"https://api.github.com/users/snony/gists{/gist_id}","starred_url":"https://api.github.com/users/snony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snony/subscriptions","organizations_url":"https://api.github.com/users/snony/orgs","repos_url":"https://api.github.com/users/snony/repos","events_url":"https://api.github.com/users/snony/events{/privacy}","received_events_url":"https://api.github.com/users/snony/received_events","type":"User","site_admin":false},"body":"onClickFilterHistoryByPrice and onClickFilterHistoryByData have functions of same definition type. I suggest you create a function type ClickFilter: (symbol: string, value:string) => void, and substitute it for functions you have declared.","created_at":"2018-10-01T11:42:49Z","updated_at":"2018-10-01T11:42:49Z","html_url":"https://github.com/snony/stocktracker/pull/34#discussion_r221578732","pull_request_url":"https://api.github.com/repos/snony/stocktracker/pulls/34","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/snony/stocktracker/pulls/comments/221578732"},"html":{"href":"https://github.com/snony/stocktracker/pull/34#discussion_r221578732"},"pull_request":{"href":"https://api.github.com/repos/snony/stocktracker/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/snony/stocktracker/pulls/34","id":219327086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzI3MDg2","html_url":"https://github.com/snony/stocktracker/pull/34","diff_url":"https://github.com/snony/stocktracker/pull/34.diff","patch_url":"https://github.com/snony/stocktracker/pull/34.patch","issue_url":"https://api.github.com/repos/snony/stocktracker/issues/34","number":34,"state":"open","locked":false,"title":"[AGP-96] Convert overview JSX to TSX","user":{"login":"TobyLi96","id":10549511,"node_id":"MDQ6VXNlcjEwNTQ5NTEx","avatar_url":"https://avatars2.githubusercontent.com/u/10549511?v=4","gravatar_id":"","url":"https://api.github.com/users/TobyLi96","html_url":"https://github.com/TobyLi96","followers_url":"https://api.github.com/users/TobyLi96/followers","following_url":"https://api.github.com/users/TobyLi96/following{/other_user}","gists_url":"https://api.github.com/users/TobyLi96/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyLi96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyLi96/subscriptions","organizations_url":"https://api.github.com/users/TobyLi96/orgs","repos_url":"https://api.github.com/users/TobyLi96/repos","events_url":"https://api.github.com/users/TobyLi96/events{/privacy}","received_events_url":"https://api.github.com/users/TobyLi96/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-01T10:26:48Z","updated_at":"2018-10-01T11:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b06ff354d2c17e035b1f4a96151a18fdc3f39d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"codeaid","id":637799,"node_id":"MDQ6VXNlcjYzNzc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/637799?v=4","gravatar_id":"","url":"https://api.github.com/users/codeaid","html_url":"https://github.com/codeaid","followers_url":"https://api.github.com/users/codeaid/followers","following_url":"https://api.github.com/users/codeaid/following{/other_user}","gists_url":"https://api.github.com/users/codeaid/gists{/gist_id}","starred_url":"https://api.github.com/users/codeaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeaid/subscriptions","organizations_url":"https://api.github.com/users/codeaid/orgs","repos_url":"https://api.github.com/users/codeaid/repos","events_url":"https://api.github.com/users/codeaid/events{/privacy}","received_events_url":"https://api.github.com/users/codeaid/received_events","type":"User","site_admin":false},{"login":"ianchan035","id":26205511,"node_id":"MDQ6VXNlcjI2MjA1NTEx","avatar_url":"https://avatars3.githubusercontent.com/u/26205511?v=4","gravatar_id":"","url":"https://api.github.com/users/ianchan035","html_url":"https://github.com/ianchan035","followers_url":"https://api.github.com/users/ianchan035/followers","following_url":"https://api.github.com/users/ianchan035/following{/other_user}","gists_url":"https://api.github.com/users/ianchan035/gists{/gist_id}","starred_url":"https://api.github.com/users/ianchan035/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianchan035/subscriptions","organizations_url":"https://api.github.com/users/ianchan035/orgs","repos_url":"https://api.github.com/users/ianchan035/repos","events_url":"https://api.github.com/users/ianchan035/events{/privacy}","received_events_url":"https://api.github.com/users/ianchan035/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snony/stocktracker/pulls/34/commits","review_comments_url":"https://api.github.com/repos/snony/stocktracker/pulls/34/comments","review_comment_url":"https://api.github.com/repos/snony/stocktracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snony/stocktracker/issues/34/comments","statuses_url":"https://api.github.com/repos/snony/stocktracker/statuses/042d3546e1936d6f1eae3aad9a6b8640e6a200cc","head":{"label":"snony:react-ts-overview","ref":"react-ts-overview","sha":"042d3546e1936d6f1eae3aad9a6b8640e6a200cc","user":{"login":"snony","id":42961027,"node_id":"MDQ6VXNlcjQyOTYxMDI3","avatar_url":"https://avatars3.githubusercontent.com/u/42961027?v=4","gravatar_id":"","url":"https://api.github.com/users/snony","html_url":"https://github.com/snony","followers_url":"https://api.github.com/users/snony/followers","following_url":"https://api.github.com/users/snony/following{/other_user}","gists_url":"https://api.github.com/users/snony/gists{/gist_id}","starred_url":"https://api.github.com/users/snony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snony/subscriptions","organizations_url":"https://api.github.com/users/snony/orgs","repos_url":"https://api.github.com/users/snony/repos","events_url":"https://api.github.com/users/snony/events{/privacy}","received_events_url":"https://api.github.com/users/snony/received_events","type":"User","site_admin":false},"repo":{"id":148303831,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMDM4MzE=","name":"stocktracker","full_name":"snony/stocktracker","private":false,"owner":{"login":"snony","id":42961027,"node_id":"MDQ6VXNlcjQyOTYxMDI3","avatar_url":"https://avatars3.githubusercontent.com/u/42961027?v=4","gravatar_id":"","url":"https://api.github.com/users/snony","html_url":"https://github.com/snony","followers_url":"https://api.github.com/users/snony/followers","following_url":"https://api.github.com/users/snony/following{/other_user}","gists_url":"https://api.github.com/users/snony/gists{/gist_id}","starred_url":"https://api.github.com/users/snony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snony/subscriptions","organizations_url":"https://api.github.com/users/snony/orgs","repos_url":"https://api.github.com/users/snony/repos","events_url":"https://api.github.com/users/snony/events{/privacy}","received_events_url":"https://api.github.com/users/snony/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snony/stocktracker","description":null,"fork":false,"url":"https://api.github.com/repos/snony/stocktracker","forks_url":"https://api.github.com/repos/snony/stocktracker/forks","keys_url":"https://api.github.com/repos/snony/stocktracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snony/stocktracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snony/stocktracker/teams","hooks_url":"https://api.github.com/repos/snony/stocktracker/hooks","issue_events_url":"https://api.github.com/repos/snony/stocktracker/issues/events{/number}","events_url":"https://api.github.com/repos/snony/stocktracker/events","assignees_url":"https://api.github.com/repos/snony/stocktracker/assignees{/user}","branches_url":"https://api.github.com/repos/snony/stocktracker/branches{/branch}","tags_url":"https://api.github.com/repos/snony/stocktracker/tags","blobs_url":"https://api.github.com/repos/snony/stocktracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snony/stocktracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snony/stocktracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/snony/stocktracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snony/stocktracker/statuses/{sha}","languages_url":"https://api.github.com/repos/snony/stocktracker/languages","stargazers_url":"https://api.github.com/repos/snony/stocktracker/stargazers","contributors_url":"https://api.github.com/repos/snony/stocktracker/contributors","subscribers_url":"https://api.github.com/repos/snony/stocktracker/subscribers","subscription_url":"https://api.github.com/repos/snony/stocktracker/subscription","commits_url":"https://api.github.com/repos/snony/stocktracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/snony/stocktracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/snony/stocktracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/snony/stocktracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/snony/stocktracker/contents/{+path}","compare_url":"https://api.github.com/repos/snony/stocktracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snony/stocktracker/merges","archive_url":"https://api.github.com/repos/snony/stocktracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snony/stocktracker/downloads","issues_url":"https://api.github.com/repos/snony/stocktracker/issues{/number}","pulls_url":"https://api.github.com/repos/snony/stocktracker/pulls{/number}","milestones_url":"https://api.github.com/repos/snony/stocktracker/milestones{/number}","notifications_url":"https://api.github.com/repos/snony/stocktracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snony/stocktracker/labels{/name}","releases_url":"https://api.github.com/repos/snony/stocktracker/releases{/id}","deployments_url":"https://api.github.com/repos/snony/stocktracker/deployments","created_at":"2018-09-11T11:01:47Z","updated_at":"2018-10-01T08:26:52Z","pushed_at":"2018-10-01T11:36:36Z","git_url":"git://github.com/snony/stocktracker.git","ssh_url":"git@github.com:snony/stocktracker.git","clone_url":"https://github.com/snony/stocktracker.git","svn_url":"https://github.com/snony/stocktracker","homepage":null,"size":1895,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"snony:master","ref":"master","sha":"3fb6a53fdb0947e9fb24e0cd234ce2874ac437bd","user":{"login":"snony","id":42961027,"node_id":"MDQ6VXNlcjQyOTYxMDI3","avatar_url":"https://avatars3.githubusercontent.com/u/42961027?v=4","gravatar_id":"","url":"https://api.github.com/users/snony","html_url":"https://github.com/snony","followers_url":"https://api.github.com/users/snony/followers","following_url":"https://api.github.com/users/snony/following{/other_user}","gists_url":"https://api.github.com/users/snony/gists{/gist_id}","starred_url":"https://api.github.com/users/snony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snony/subscriptions","organizations_url":"https://api.github.com/users/snony/orgs","repos_url":"https://api.github.com/users/snony/repos","events_url":"https://api.github.com/users/snony/events{/privacy}","received_events_url":"https://api.github.com/users/snony/received_events","type":"User","site_admin":false},"repo":{"id":148303831,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMDM4MzE=","name":"stocktracker","full_name":"snony/stocktracker","private":false,"owner":{"login":"snony","id":42961027,"node_id":"MDQ6VXNlcjQyOTYxMDI3","avatar_url":"https://avatars3.githubusercontent.com/u/42961027?v=4","gravatar_id":"","url":"https://api.github.com/users/snony","html_url":"https://github.com/snony","followers_url":"https://api.github.com/users/snony/followers","following_url":"https://api.github.com/users/snony/following{/other_user}","gists_url":"https://api.github.com/users/snony/gists{/gist_id}","starred_url":"https://api.github.com/users/snony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snony/subscriptions","organizations_url":"https://api.github.com/users/snony/orgs","repos_url":"https://api.github.com/users/snony/repos","events_url":"https://api.github.com/users/snony/events{/privacy}","received_events_url":"https://api.github.com/users/snony/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snony/stocktracker","description":null,"fork":false,"url":"https://api.github.com/repos/snony/stocktracker","forks_url":"https://api.github.com/repos/snony/stocktracker/forks","keys_url":"https://api.github.com/repos/snony/stocktracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snony/stocktracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snony/stocktracker/teams","hooks_url":"https://api.github.com/repos/snony/stocktracker/hooks","issue_events_url":"https://api.github.com/repos/snony/stocktracker/issues/events{/number}","events_url":"https://api.github.com/repos/snony/stocktracker/events","assignees_url":"https://api.github.com/repos/snony/stocktracker/assignees{/user}","branches_url":"https://api.github.com/repos/snony/stocktracker/branches{/branch}","tags_url":"https://api.github.com/repos/snony/stocktracker/tags","blobs_url":"https://api.github.com/repos/snony/stocktracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snony/stocktracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snony/stocktracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/snony/stocktracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snony/stocktracker/statuses/{sha}","languages_url":"https://api.github.com/repos/snony/stocktracker/languages","stargazers_url":"https://api.github.com/repos/snony/stocktracker/stargazers","contributors_url":"https://api.github.com/repos/snony/stocktracker/contributors","subscribers_url":"https://api.github.com/repos/snony/stocktracker/subscribers","subscription_url":"https://api.github.com/repos/snony/stocktracker/subscription","commits_url":"https://api.github.com/repos/snony/stocktracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/snony/stocktracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/snony/stocktracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/snony/stocktracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/snony/stocktracker/contents/{+path}","compare_url":"https://api.github.com/repos/snony/stocktracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snony/stocktracker/merges","archive_url":"https://api.github.com/repos/snony/stocktracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snony/stocktracker/downloads","issues_url":"https://api.github.com/repos/snony/stocktracker/issues{/number}","pulls_url":"https://api.github.com/repos/snony/stocktracker/pulls{/number}","milestones_url":"https://api.github.com/repos/snony/stocktracker/milestones{/number}","notifications_url":"https://api.github.com/repos/snony/stocktracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snony/stocktracker/labels{/name}","releases_url":"https://api.github.com/repos/snony/stocktracker/releases{/id}","deployments_url":"https://api.github.com/repos/snony/stocktracker/deployments","created_at":"2018-09-11T11:01:47Z","updated_at":"2018-10-01T08:26:52Z","pushed_at":"2018-10-01T11:36:36Z","git_url":"git://github.com/snony/stocktracker.git","ssh_url":"git@github.com:snony/stocktracker.git","clone_url":"https://github.com/snony/stocktracker.git","svn_url":"https://github.com/snony/stocktracker","homepage":null,"size":1895,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snony/stocktracker/pulls/34"},"html":{"href":"https://github.com/snony/stocktracker/pull/34"},"issue":{"href":"https://api.github.com/repos/snony/stocktracker/issues/34"},"comments":{"href":"https://api.github.com/repos/snony/stocktracker/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/snony/stocktracker/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/snony/stocktracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snony/stocktracker/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/snony/stocktracker/statuses/042d3546e1936d6f1eae3aad9a6b8640e6a200cc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"snony"}}