{"action":"created","issue":{"url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/issues/9","repository_url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA","labels_url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/issues/9/comments","events_url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/issues/9/events","html_url":"https://github.com/Sinapse-Energia/EC-LC-NEMA/issues/9","id":356777101,"node_id":"MDU6SXNzdWUzNTY3NzcxMDE=","number":9,"title":"[RF Protocol][NVM] Verify current behaviour & adapt NVM management","user":{"login":"ralcaide","id":2856585,"node_id":"MDQ6VXNlcjI4NTY1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2856585?v=4","gravatar_id":"","url":"https://api.github.com/users/ralcaide","html_url":"https://github.com/ralcaide","followers_url":"https://api.github.com/users/ralcaide/followers","following_url":"https://api.github.com/users/ralcaide/following{/other_user}","gists_url":"https://api.github.com/users/ralcaide/gists{/gist_id}","starred_url":"https://api.github.com/users/ralcaide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralcaide/subscriptions","organizations_url":"https://api.github.com/users/ralcaide/orgs","repos_url":"https://api.github.com/users/ralcaide/repos","events_url":"https://api.github.com/users/ralcaide/events{/privacy}","received_events_url":"https://api.github.com/users/ralcaide/received_events","type":"User","site_admin":false},"labels":[{"id":1059228276,"node_id":"MDU6TGFiZWwxMDU5MjI4Mjc2","url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/labels/Priority:%20medium","name":"Priority: medium","color":"7F5A2D","default":false},{"id":1059228267,"node_id":"MDU6TGFiZWwxMDU5MjI4MjY3","url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/labels/Size:%205","name":"Size: 5","color":"08374C","default":false},{"id":1059228247,"node_id":"MDU6TGFiZWwxMDU5MjI4MjQ3","url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/labels/Status:%20new","name":"Status: new","color":"357F2B","default":false},{"id":1059228240,"node_id":"MDU6TGFiZWwxMDU5MjI4MjQw","url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/labels/Type:%20feature","name":"Type: feature","color":"FF6A5B","default":false}],"state":"open","locked":false,"assignee":{"login":"m-owais","id":23384558,"node_id":"MDQ6VXNlcjIzMzg0NTU4","avatar_url":"https://avatars2.githubusercontent.com/u/23384558?v=4","gravatar_id":"","url":"https://api.github.com/users/m-owais","html_url":"https://github.com/m-owais","followers_url":"https://api.github.com/users/m-owais/followers","following_url":"https://api.github.com/users/m-owais/following{/other_user}","gists_url":"https://api.github.com/users/m-owais/gists{/gist_id}","starred_url":"https://api.github.com/users/m-owais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-owais/subscriptions","organizations_url":"https://api.github.com/users/m-owais/orgs","repos_url":"https://api.github.com/users/m-owais/repos","events_url":"https://api.github.com/users/m-owais/events{/privacy}","received_events_url":"https://api.github.com/users/m-owais/received_events","type":"User","site_admin":false},"assignees":[{"login":"m-owais","id":23384558,"node_id":"MDQ6VXNlcjIzMzg0NTU4","avatar_url":"https://avatars2.githubusercontent.com/u/23384558?v=4","gravatar_id":"","url":"https://api.github.com/users/m-owais","html_url":"https://github.com/m-owais","followers_url":"https://api.github.com/users/m-owais/followers","following_url":"https://api.github.com/users/m-owais/following{/other_user}","gists_url":"https://api.github.com/users/m-owais/gists{/gist_id}","starred_url":"https://api.github.com/users/m-owais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-owais/subscriptions","organizations_url":"https://api.github.com/users/m-owais/orgs","repos_url":"https://api.github.com/users/m-owais/repos","events_url":"https://api.github.com/users/m-owais/events{/privacy}","received_events_url":"https://api.github.com/users/m-owais/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-09-04T11:58:53Z","updated_at":"2018-09-17T21:47:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The legacy code implements already the Sinapse RF Protocol. \r\nThe device have a concrete behavior depending some configuration parameters saved in the NVM. For example, a device can be a master and then will repeat the frames that arrives with transit bit = 1 or can be not master and then process only the frames with sent to it.\r\nAll the protocol was already available in the legacy code and should works fine but is necessary to check the needed values saved in the NVM are well saved, that could be read and also that could be written.\r\n\r\nTo check that everything works right it is necessary to test (and probably modify the NVM management) the setting master and then verify the behaviour.\r\n\r\nThe NVM management is explained here: #3 but we think that should be adapted to this new device. What is the best way to save these necessary parameters in the NVM (Flash). Using a page? other method?.\r\n\r\nTest TODO:\r\n\r\n1. Set the device as master using the command \"Configure Radio\" explained in the Wiki:\r\n\r\nConfigure Radio | 0x16 | P1 = Radio configuration | 0x01 |   | 0C 16 00 00 01 00 00 02 RC 01 06 CS -- 0B 01 00 00 02 00 00 01 01 06 CS\r\n-- | -- | -- | -- | -- | --\r\n\r\n\r\nThe but RC should have the master = 1 like 1000111. This RC means master enabled and time of re-emisions = 700ms\r\n\r\n2. Send a frame to other EC (other address) and verify that the EC master repeat the frame\r\n3. Set the device as not master\r\n4. Send a frame to other EC and verify that the current EC is not re-transmitting the frame.\r\n\r\nTODO:\r\n\r\n- Perform test\r\n- Improve NVM management\r\n- Perform test again until the device works as expected"},"comment":{"url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/issues/comments/422182915","html_url":"https://github.com/Sinapse-Energia/EC-LC-NEMA/issues/9#issuecomment-422182915","issue_url":"https://api.github.com/repos/Sinapse-Energia/EC-LC-NEMA/issues/9","id":422182915,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjE4MjkxNQ==","user":{"login":"m-owais","id":23384558,"node_id":"MDQ6VXNlcjIzMzg0NTU4","avatar_url":"https://avatars2.githubusercontent.com/u/23384558?v=4","gravatar_id":"","url":"https://api.github.com/users/m-owais","html_url":"https://github.com/m-owais","followers_url":"https://api.github.com/users/m-owais/followers","following_url":"https://api.github.com/users/m-owais/following{/other_user}","gists_url":"https://api.github.com/users/m-owais/gists{/gist_id}","starred_url":"https://api.github.com/users/m-owais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-owais/subscriptions","organizations_url":"https://api.github.com/users/m-owais/orgs","repos_url":"https://api.github.com/users/m-owais/repos","events_url":"https://api.github.com/users/m-owais/events{/privacy}","received_events_url":"https://api.github.com/users/m-owais/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T21:47:32Z","updated_at":"2018-09-17T21:47:32Z","author_association":"COLLABORATOR","body":"There are alot of unused defines in deficionesGlobales.h. Also there is unused code in tramas.c, can you help me identify which part will not be used in future so i can remove it. It makes the maintenance easier."}}
{"actor":{"display_login":"m-owais"}}