{"action":"created","comment":{"url":"https://api.github.com/repos/MaskRay/ccls/pulls/comments/221817774","pull_request_review_id":160557630,"id":221817774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTgxNzc3NA==","diff_hunk":"@@ -1033,10 +1033,10 @@ class IndexDataConsumer : public index::IndexDataConsumer {\n       break;\n     }\n     case Decl::CXXConstructor:\n-    case Decl::CXXConversion:\n       func->def.kind = lsSymbolKind::Constructor;\n       break;\n     case Decl::CXXDestructor:","path":"src/indexer.cc","position":7,"original_position":7,"commit_id":"960e838774338d57688f2b56d202c9f41c045912","original_commit_id":"960e838774338d57688f2b56d202c9f41c045912","user":{"login":"MaskRay","id":416322,"node_id":"MDQ6VXNlcjQxNjMyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/416322?v=4","gravatar_id":"","url":"https://api.github.com/users/MaskRay","html_url":"https://github.com/MaskRay","followers_url":"https://api.github.com/users/MaskRay/followers","following_url":"https://api.github.com/users/MaskRay/following{/other_user}","gists_url":"https://api.github.com/users/MaskRay/gists{/gist_id}","starred_url":"https://api.github.com/users/MaskRay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaskRay/subscriptions","organizations_url":"https://api.github.com/users/MaskRay/orgs","repos_url":"https://api.github.com/users/MaskRay/repos","events_url":"https://api.github.com/users/MaskRay/events{/privacy}","received_events_url":"https://api.github.com/users/MaskRay/received_events","type":"User","site_admin":false},"body":"Can you swap them?","created_at":"2018-10-02T03:34:05Z","updated_at":"2018-10-02T03:34:53Z","html_url":"https://github.com/MaskRay/ccls/pull/86#discussion_r221817774","pull_request_url":"https://api.github.com/repos/MaskRay/ccls/pulls/86","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MaskRay/ccls/pulls/comments/221817774"},"html":{"href":"https://github.com/MaskRay/ccls/pull/86#discussion_r221817774"},"pull_request":{"href":"https://api.github.com/repos/MaskRay/ccls/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/MaskRay/ccls/pulls/86","id":219575784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTc1Nzg0","html_url":"https://github.com/MaskRay/ccls/pull/86","diff_url":"https://github.com/MaskRay/ccls/pull/86.diff","patch_url":"https://github.com/MaskRay/ccls/pull/86.patch","issue_url":"https://api.github.com/repos/MaskRay/ccls/issues/86","number":86,"state":"open","locked":false,"title":" regard conversion as method instead of constructor","user":{"login":"FirstLoveLife","id":37442588,"node_id":"MDQ6VXNlcjM3NDQyNTg4","avatar_url":"https://avatars3.githubusercontent.com/u/37442588?v=4","gravatar_id":"","url":"https://api.github.com/users/FirstLoveLife","html_url":"https://github.com/FirstLoveLife","followers_url":"https://api.github.com/users/FirstLoveLife/followers","following_url":"https://api.github.com/users/FirstLoveLife/following{/other_user}","gists_url":"https://api.github.com/users/FirstLoveLife/gists{/gist_id}","starred_url":"https://api.github.com/users/FirstLoveLife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirstLoveLife/subscriptions","organizations_url":"https://api.github.com/users/FirstLoveLife/orgs","repos_url":"https://api.github.com/users/FirstLoveLife/repos","events_url":"https://api.github.com/users/FirstLoveLife/events{/privacy}","received_events_url":"https://api.github.com/users/FirstLoveLife/received_events","type":"User","site_admin":false},"body":"1. According to http://eel.is/c++draft/class.ctor and http://eel.is/c++draft/#class, user-defined implicit conversion should be regarded as the constructor. \r\n2. \r\n\r\n```\r\ncase Decl::CXXConstructor:\t   \r\n    case Decl::CXXConversion:\t\r\n      func->def.kind = lsSymbolKind::Constructor;\r\n```\r\n\r\nwill be strange in lsp-imenu:\r\n```\r\n(Class)\r\n  ┃ operator bool (Constructor)\r\n  ┃ operator& (Method)\r\n  ┃ __bit_const_reference<_Cp> (Constructor)\r\n  ┃ __bit_const_reference<_Cp> (Constructor)\r\n  ┃ __storage_pointer (Other)\r\n  ┃ __storage_type (Other)\r\n  ...\r\n```\r\n\r\nClearly, operator bool is not this class's `Constructor`. This commit changes the layout into:\r\n\r\n```\r\n(Class)\r\n  ┃ operator bool (Method)\r\n  ┃ operator& (Method)\r\n  ┃ __bit_const_reference<_Cp> (Constructor)\r\n  ┃ __bit_const_reference<_Cp> (Constructor)\r\n  ┃ __storage_pointer (Other)\r\n  ┃ __storage_type (Other)\r\n  ...\r\n```","created_at":"2018-10-02T03:29:52Z","updated_at":"2018-10-02T03:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8e48afaae17a3c44f20c6baefc4ec86f9722f3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MaskRay/ccls/pulls/86/commits","review_comments_url":"https://api.github.com/repos/MaskRay/ccls/pulls/86/comments","review_comment_url":"https://api.github.com/repos/MaskRay/ccls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MaskRay/ccls/issues/86/comments","statuses_url":"https://api.github.com/repos/MaskRay/ccls/statuses/960e838774338d57688f2b56d202c9f41c045912","head":{"label":"FirstLoveLife:fix/Constructor","ref":"fix/Constructor","sha":"960e838774338d57688f2b56d202c9f41c045912","user":{"login":"FirstLoveLife","id":37442588,"node_id":"MDQ6VXNlcjM3NDQyNTg4","avatar_url":"https://avatars3.githubusercontent.com/u/37442588?v=4","gravatar_id":"","url":"https://api.github.com/users/FirstLoveLife","html_url":"https://github.com/FirstLoveLife","followers_url":"https://api.github.com/users/FirstLoveLife/followers","following_url":"https://api.github.com/users/FirstLoveLife/following{/other_user}","gists_url":"https://api.github.com/users/FirstLoveLife/gists{/gist_id}","starred_url":"https://api.github.com/users/FirstLoveLife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirstLoveLife/subscriptions","organizations_url":"https://api.github.com/users/FirstLoveLife/orgs","repos_url":"https://api.github.com/users/FirstLoveLife/repos","events_url":"https://api.github.com/users/FirstLoveLife/events{/privacy}","received_events_url":"https://api.github.com/users/FirstLoveLife/received_events","type":"User","site_admin":false},"repo":{"id":146576956,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1NzY5NTY=","name":"ccls","full_name":"FirstLoveLife/ccls","private":false,"owner":{"login":"FirstLoveLife","id":37442588,"node_id":"MDQ6VXNlcjM3NDQyNTg4","avatar_url":"https://avatars3.githubusercontent.com/u/37442588?v=4","gravatar_id":"","url":"https://api.github.com/users/FirstLoveLife","html_url":"https://github.com/FirstLoveLife","followers_url":"https://api.github.com/users/FirstLoveLife/followers","following_url":"https://api.github.com/users/FirstLoveLife/following{/other_user}","gists_url":"https://api.github.com/users/FirstLoveLife/gists{/gist_id}","starred_url":"https://api.github.com/users/FirstLoveLife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirstLoveLife/subscriptions","organizations_url":"https://api.github.com/users/FirstLoveLife/orgs","repos_url":"https://api.github.com/users/FirstLoveLife/repos","events_url":"https://api.github.com/users/FirstLoveLife/events{/privacy}","received_events_url":"https://api.github.com/users/FirstLoveLife/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FirstLoveLife/ccls","description":"C/C++/ObjC language server supporting cross references, hierarchies, completion and semantic highlighting","fork":true,"url":"https://api.github.com/repos/FirstLoveLife/ccls","forks_url":"https://api.github.com/repos/FirstLoveLife/ccls/forks","keys_url":"https://api.github.com/repos/FirstLoveLife/ccls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirstLoveLife/ccls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirstLoveLife/ccls/teams","hooks_url":"https://api.github.com/repos/FirstLoveLife/ccls/hooks","issue_events_url":"https://api.github.com/repos/FirstLoveLife/ccls/issues/events{/number}","events_url":"https://api.github.com/repos/FirstLoveLife/ccls/events","assignees_url":"https://api.github.com/repos/FirstLoveLife/ccls/assignees{/user}","branches_url":"https://api.github.com/repos/FirstLoveLife/ccls/branches{/branch}","tags_url":"https://api.github.com/repos/FirstLoveLife/ccls/tags","blobs_url":"https://api.github.com/repos/FirstLoveLife/ccls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirstLoveLife/ccls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirstLoveLife/ccls/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirstLoveLife/ccls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirstLoveLife/ccls/statuses/{sha}","languages_url":"https://api.github.com/repos/FirstLoveLife/ccls/languages","stargazers_url":"https://api.github.com/repos/FirstLoveLife/ccls/stargazers","contributors_url":"https://api.github.com/repos/FirstLoveLife/ccls/contributors","subscribers_url":"https://api.github.com/repos/FirstLoveLife/ccls/subscribers","subscription_url":"https://api.github.com/repos/FirstLoveLife/ccls/subscription","commits_url":"https://api.github.com/repos/FirstLoveLife/ccls/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirstLoveLife/ccls/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirstLoveLife/ccls/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirstLoveLife/ccls/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirstLoveLife/ccls/contents/{+path}","compare_url":"https://api.github.com/repos/FirstLoveLife/ccls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirstLoveLife/ccls/merges","archive_url":"https://api.github.com/repos/FirstLoveLife/ccls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirstLoveLife/ccls/downloads","issues_url":"https://api.github.com/repos/FirstLoveLife/ccls/issues{/number}","pulls_url":"https://api.github.com/repos/FirstLoveLife/ccls/pulls{/number}","milestones_url":"https://api.github.com/repos/FirstLoveLife/ccls/milestones{/number}","notifications_url":"https://api.github.com/repos/FirstLoveLife/ccls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirstLoveLife/ccls/labels{/name}","releases_url":"https://api.github.com/repos/FirstLoveLife/ccls/releases{/id}","deployments_url":"https://api.github.com/repos/FirstLoveLife/ccls/deployments","created_at":"2018-08-29T09:27:58Z","updated_at":"2018-10-02T01:57:29Z","pushed_at":"2018-10-02T03:22:14Z","git_url":"git://github.com/FirstLoveLife/ccls.git","ssh_url":"git@github.com:FirstLoveLife/ccls.git","clone_url":"https://github.com/FirstLoveLife/ccls.git","svn_url":"https://github.com/FirstLoveLife/ccls","homepage":"","size":3322,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MaskRay:master","ref":"master","sha":"da07cb2da41376be488849a106271aa477c8a3e0","user":{"login":"MaskRay","id":416322,"node_id":"MDQ6VXNlcjQxNjMyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/416322?v=4","gravatar_id":"","url":"https://api.github.com/users/MaskRay","html_url":"https://github.com/MaskRay","followers_url":"https://api.github.com/users/MaskRay/followers","following_url":"https://api.github.com/users/MaskRay/following{/other_user}","gists_url":"https://api.github.com/users/MaskRay/gists{/gist_id}","starred_url":"https://api.github.com/users/MaskRay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaskRay/subscriptions","organizations_url":"https://api.github.com/users/MaskRay/orgs","repos_url":"https://api.github.com/users/MaskRay/repos","events_url":"https://api.github.com/users/MaskRay/events{/privacy}","received_events_url":"https://api.github.com/users/MaskRay/received_events","type":"User","site_admin":false},"repo":{"id":127506824,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc1MDY4MjQ=","name":"ccls","full_name":"MaskRay/ccls","private":false,"owner":{"login":"MaskRay","id":416322,"node_id":"MDQ6VXNlcjQxNjMyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/416322?v=4","gravatar_id":"","url":"https://api.github.com/users/MaskRay","html_url":"https://github.com/MaskRay","followers_url":"https://api.github.com/users/MaskRay/followers","following_url":"https://api.github.com/users/MaskRay/following{/other_user}","gists_url":"https://api.github.com/users/MaskRay/gists{/gist_id}","starred_url":"https://api.github.com/users/MaskRay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaskRay/subscriptions","organizations_url":"https://api.github.com/users/MaskRay/orgs","repos_url":"https://api.github.com/users/MaskRay/repos","events_url":"https://api.github.com/users/MaskRay/events{/privacy}","received_events_url":"https://api.github.com/users/MaskRay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MaskRay/ccls","description":"C/C++/ObjC language server supporting cross references, hierarchies, completion and semantic highlighting","fork":false,"url":"https://api.github.com/repos/MaskRay/ccls","forks_url":"https://api.github.com/repos/MaskRay/ccls/forks","keys_url":"https://api.github.com/repos/MaskRay/ccls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaskRay/ccls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaskRay/ccls/teams","hooks_url":"https://api.github.com/repos/MaskRay/ccls/hooks","issue_events_url":"https://api.github.com/repos/MaskRay/ccls/issues/events{/number}","events_url":"https://api.github.com/repos/MaskRay/ccls/events","assignees_url":"https://api.github.com/repos/MaskRay/ccls/assignees{/user}","branches_url":"https://api.github.com/repos/MaskRay/ccls/branches{/branch}","tags_url":"https://api.github.com/repos/MaskRay/ccls/tags","blobs_url":"https://api.github.com/repos/MaskRay/ccls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaskRay/ccls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaskRay/ccls/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaskRay/ccls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaskRay/ccls/statuses/{sha}","languages_url":"https://api.github.com/repos/MaskRay/ccls/languages","stargazers_url":"https://api.github.com/repos/MaskRay/ccls/stargazers","contributors_url":"https://api.github.com/repos/MaskRay/ccls/contributors","subscribers_url":"https://api.github.com/repos/MaskRay/ccls/subscribers","subscription_url":"https://api.github.com/repos/MaskRay/ccls/subscription","commits_url":"https://api.github.com/repos/MaskRay/ccls/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaskRay/ccls/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaskRay/ccls/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaskRay/ccls/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaskRay/ccls/contents/{+path}","compare_url":"https://api.github.com/repos/MaskRay/ccls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaskRay/ccls/merges","archive_url":"https://api.github.com/repos/MaskRay/ccls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaskRay/ccls/downloads","issues_url":"https://api.github.com/repos/MaskRay/ccls/issues{/number}","pulls_url":"https://api.github.com/repos/MaskRay/ccls/pulls{/number}","milestones_url":"https://api.github.com/repos/MaskRay/ccls/milestones{/number}","notifications_url":"https://api.github.com/repos/MaskRay/ccls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaskRay/ccls/labels{/name}","releases_url":"https://api.github.com/repos/MaskRay/ccls/releases{/id}","deployments_url":"https://api.github.com/repos/MaskRay/ccls/deployments","created_at":"2018-03-31T06:47:05Z","updated_at":"2018-10-01T23:56:59Z","pushed_at":"2018-10-02T03:29:53Z","git_url":"git://github.com/MaskRay/ccls.git","ssh_url":"git@github.com:MaskRay/ccls.git","clone_url":"https://github.com/MaskRay/ccls.git","svn_url":"https://github.com/MaskRay/ccls","homepage":"","size":3311,"stargazers_count":303,"watchers_count":303,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":22,"open_issues":2,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MaskRay/ccls/pulls/86"},"html":{"href":"https://github.com/MaskRay/ccls/pull/86"},"issue":{"href":"https://api.github.com/repos/MaskRay/ccls/issues/86"},"comments":{"href":"https://api.github.com/repos/MaskRay/ccls/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/MaskRay/ccls/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/MaskRay/ccls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MaskRay/ccls/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/MaskRay/ccls/statuses/960e838774338d57688f2b56d202c9f41c045912"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MaskRay"}}