{"action":"created","comment":{"url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/comments/208124344","pull_request_review_id":143869666,"id":208124344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODEyNDM0NA==","diff_hunk":"@@ -22,16 +22,15 @@ end)\n \n script.on_event(\"todolist-toggle-ui\", function(event)\n     local player = game.players[event.player_index]\n-    if todo.get_main_frame(player) then\n-        todo.minimize(player)\n-    else\n-        todo.maximize(player)\n-        todo.refresh_task_table(player)\n-    end\n+    todo.toggle_ui(player)\n end)\n \n script.on_event(defines.events.on_runtime_mod_setting_changed, function(event)\n     local player = game.players[event.player_index]\n     local key = event.setting\n     todo.on_runtime_mod_setting_changed(player, key)\n-end)\n\\ No newline at end of file\n+end)\n+\n+require(\"faketorio.core\")\n+\n+require(\"faketorio.features.UI_feature\")","path":"src/control.lua","position":23,"original_position":23,"commit_id":"10173e274261e19d58780ee76d486d3e446aa622","original_commit_id":"10173e274261e19d58780ee76d486d3e446aa622","user":{"login":"JonasJurczok","id":93300,"node_id":"MDQ6VXNlcjkzMzAw","avatar_url":"https://avatars3.githubusercontent.com/u/93300?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasJurczok","html_url":"https://github.com/JonasJurczok","followers_url":"https://api.github.com/users/JonasJurczok/followers","following_url":"https://api.github.com/users/JonasJurczok/following{/other_user}","gists_url":"https://api.github.com/users/JonasJurczok/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasJurczok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasJurczok/subscriptions","organizations_url":"https://api.github.com/users/JonasJurczok/orgs","repos_url":"https://api.github.com/users/JonasJurczok/repos","events_url":"https://api.github.com/users/JonasJurczok/events{/privacy}","received_events_url":"https://api.github.com/users/JonasJurczok/received_events","type":"User","site_admin":false},"body":"This should not be in master. Because if it is there then you can run faketorio tests, but it also requires everyone to have faketorio installed. One of the features of faketorio is to generate these lines for you when you run the `test` command :)","created_at":"2018-08-07T07:26:49Z","updated_at":"2018-08-07T07:26:49Z","html_url":"https://github.com/JonasJurczok/factorio-todo-list/pull/44#discussion_r208124344","pull_request_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/comments/208124344"},"html":{"href":"https://github.com/JonasJurczok/factorio-todo-list/pull/44#discussion_r208124344"},"pull_request":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44"}},"in_reply_to_id":208036921},"pull_request":{"url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44","id":206504562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTA0NTYy","html_url":"https://github.com/JonasJurczok/factorio-todo-list/pull/44","diff_url":"https://github.com/JonasJurczok/factorio-todo-list/pull/44.diff","patch_url":"https://github.com/JonasJurczok/factorio-todo-list/pull/44.patch","issue_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues/44","number":44,"state":"open","locked":false,"title":"Streamline the UI a bit","user":{"login":"hoylemd","id":569403,"node_id":"MDQ6VXNlcjU2OTQwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/569403?v=4","gravatar_id":"","url":"https://api.github.com/users/hoylemd","html_url":"https://github.com/hoylemd","followers_url":"https://api.github.com/users/hoylemd/followers","following_url":"https://api.github.com/users/hoylemd/following{/other_user}","gists_url":"https://api.github.com/users/hoylemd/gists{/gist_id}","starred_url":"https://api.github.com/users/hoylemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoylemd/subscriptions","organizations_url":"https://api.github.com/users/hoylemd/orgs","repos_url":"https://api.github.com/users/hoylemd/repos","events_url":"https://api.github.com/users/hoylemd/events{/privacy}","received_events_url":"https://api.github.com/users/hoylemd/received_events","type":"User","site_admin":false},"body":"While working on #40, (and, well, learning how 2 lua), I made some changes that I think improve the user and development experience.\r\n\r\nI haven't run the faketorio tests yet, mainly because I don't know how, and didn't really have internet access while working on these, so I suppose I should probably do that too.\r\n\r\nAnyways, run down of the changes:\r\n\r\nMain changes:\r\n- Localize the main todo button\r\n- Add explicit styles for UI elements, and use them\r\n- Change the 'show button when minimized' setting to just always show the button\r\n- Main Todo List button now toggles the UI, just like the hotkey\r\n- Unify add and edit UIs\r\n- Move add/edit UI init into UI module\r\n\r\nQOL:\r\n- ~todo.log also logs to main log~ Removed because lint doesn't like it and I don't think I can change the travis config to allow it. Also, not really super helpful.\r\n\r\nfixes:\r\n- Add chinese localization entries for auto-assign (in english, but at least they're there?)\r\n- squelch the 'unknown element' warning when a non-todo gui element is clicked.\r\n\r\nSee in-line github comments for some more detailed explanations. (still coming)\r\n\r\nScreenshots!\r\n\r\nBefore:\r\n<img width=\"954\" alt=\"screenshot 2018-08-06 16 04 39\" src=\"https://user-images.githubusercontent.com/569403/43738652-5bd7ca2c-9993-11e8-9a9c-b6cb0ebe7b28.png\">\r\n\r\nAfter:\r\n<img width=\"1140\" alt=\"screenshot 2018-08-06 15 51 03\" src=\"https://user-images.githubusercontent.com/569403/43738700-876ac07c-9993-11e8-978c-f145840f4413.png\">\r\n","created_at":"2018-08-06T20:14:16Z","updated_at":"2018-08-07T07:26:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c2bbaa18f8f7a99134932dccece6faa74175021","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44/commits","review_comments_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44/comments","review_comment_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues/44/comments","statuses_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/statuses/10173e274261e19d58780ee76d486d3e446aa622","head":{"label":"hoylemd:streamline-ui","ref":"streamline-ui","sha":"10173e274261e19d58780ee76d486d3e446aa622","user":{"login":"hoylemd","id":569403,"node_id":"MDQ6VXNlcjU2OTQwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/569403?v=4","gravatar_id":"","url":"https://api.github.com/users/hoylemd","html_url":"https://github.com/hoylemd","followers_url":"https://api.github.com/users/hoylemd/followers","following_url":"https://api.github.com/users/hoylemd/following{/other_user}","gists_url":"https://api.github.com/users/hoylemd/gists{/gist_id}","starred_url":"https://api.github.com/users/hoylemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoylemd/subscriptions","organizations_url":"https://api.github.com/users/hoylemd/orgs","repos_url":"https://api.github.com/users/hoylemd/repos","events_url":"https://api.github.com/users/hoylemd/events{/privacy}","received_events_url":"https://api.github.com/users/hoylemd/received_events","type":"User","site_admin":false},"repo":{"id":142794177,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3OTQxNzc=","name":"factorio-todo-list","full_name":"hoylemd/factorio-todo-list","owner":{"login":"hoylemd","id":569403,"node_id":"MDQ6VXNlcjU2OTQwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/569403?v=4","gravatar_id":"","url":"https://api.github.com/users/hoylemd","html_url":"https://github.com/hoylemd","followers_url":"https://api.github.com/users/hoylemd/followers","following_url":"https://api.github.com/users/hoylemd/following{/other_user}","gists_url":"https://api.github.com/users/hoylemd/gists{/gist_id}","starred_url":"https://api.github.com/users/hoylemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoylemd/subscriptions","organizations_url":"https://api.github.com/users/hoylemd/orgs","repos_url":"https://api.github.com/users/hoylemd/repos","events_url":"https://api.github.com/users/hoylemd/events{/privacy}","received_events_url":"https://api.github.com/users/hoylemd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoylemd/factorio-todo-list","description":"A distributed todo list mod for Factorio","fork":true,"url":"https://api.github.com/repos/hoylemd/factorio-todo-list","forks_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/forks","keys_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/teams","hooks_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/hooks","issue_events_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/issues/events{/number}","events_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/events","assignees_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/assignees{/user}","branches_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/branches{/branch}","tags_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/tags","blobs_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/statuses/{sha}","languages_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/languages","stargazers_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/stargazers","contributors_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/contributors","subscribers_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/subscribers","subscription_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/subscription","commits_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/contents/{+path}","compare_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/merges","archive_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/downloads","issues_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/issues{/number}","pulls_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/pulls{/number}","milestones_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/milestones{/number}","notifications_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/labels{/name}","releases_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/releases{/id}","deployments_url":"https://api.github.com/repos/hoylemd/factorio-todo-list/deployments","created_at":"2018-07-29T20:45:19Z","updated_at":"2018-08-06T18:27:11Z","pushed_at":"2018-08-06T22:44:39Z","git_url":"git://github.com/hoylemd/factorio-todo-list.git","ssh_url":"git@github.com:hoylemd/factorio-todo-list.git","clone_url":"https://github.com/hoylemd/factorio-todo-list.git","svn_url":"https://github.com/hoylemd/factorio-todo-list","homepage":null,"size":5012,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JonasJurczok:master","ref":"master","sha":"b3d090dff1982bcafc1bfc6a1d68f31478800ed1","user":{"login":"JonasJurczok","id":93300,"node_id":"MDQ6VXNlcjkzMzAw","avatar_url":"https://avatars3.githubusercontent.com/u/93300?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasJurczok","html_url":"https://github.com/JonasJurczok","followers_url":"https://api.github.com/users/JonasJurczok/followers","following_url":"https://api.github.com/users/JonasJurczok/following{/other_user}","gists_url":"https://api.github.com/users/JonasJurczok/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasJurczok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasJurczok/subscriptions","organizations_url":"https://api.github.com/users/JonasJurczok/orgs","repos_url":"https://api.github.com/users/JonasJurczok/repos","events_url":"https://api.github.com/users/JonasJurczok/events{/privacy}","received_events_url":"https://api.github.com/users/JonasJurczok/received_events","type":"User","site_admin":false},"repo":{"id":103747425,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM3NDc0MjU=","name":"factorio-todo-list","full_name":"JonasJurczok/factorio-todo-list","owner":{"login":"JonasJurczok","id":93300,"node_id":"MDQ6VXNlcjkzMzAw","avatar_url":"https://avatars3.githubusercontent.com/u/93300?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasJurczok","html_url":"https://github.com/JonasJurczok","followers_url":"https://api.github.com/users/JonasJurczok/followers","following_url":"https://api.github.com/users/JonasJurczok/following{/other_user}","gists_url":"https://api.github.com/users/JonasJurczok/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasJurczok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasJurczok/subscriptions","organizations_url":"https://api.github.com/users/JonasJurczok/orgs","repos_url":"https://api.github.com/users/JonasJurczok/repos","events_url":"https://api.github.com/users/JonasJurczok/events{/privacy}","received_events_url":"https://api.github.com/users/JonasJurczok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonasJurczok/factorio-todo-list","description":"A distributed todo list mod for Factorio","fork":false,"url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list","forks_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/forks","keys_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/teams","hooks_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/hooks","issue_events_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues/events{/number}","events_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/events","assignees_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/assignees{/user}","branches_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/branches{/branch}","tags_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/tags","blobs_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/statuses/{sha}","languages_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/languages","stargazers_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/stargazers","contributors_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/contributors","subscribers_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/subscribers","subscription_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/subscription","commits_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/contents/{+path}","compare_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/merges","archive_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/downloads","issues_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues{/number}","pulls_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls{/number}","milestones_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/milestones{/number}","notifications_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/labels{/name}","releases_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/releases{/id}","deployments_url":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/deployments","created_at":"2017-09-16T11:33:57Z","updated_at":"2018-08-02T08:13:06Z","pushed_at":"2018-08-06T21:29:27Z","git_url":"git://github.com/JonasJurczok/factorio-todo-list.git","ssh_url":"git@github.com:JonasJurczok/factorio-todo-list.git","clone_url":"https://github.com/JonasJurczok/factorio-todo-list.git","svn_url":"https://github.com/JonasJurczok/factorio-todo-list","homepage":null,"size":5000,"stargazers_count":3,"watchers_count":3,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":4,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44"},"html":{"href":"https://github.com/JonasJurczok/factorio-todo-list/pull/44"},"issue":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues/44"},"comments":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/JonasJurczok/factorio-todo-list/statuses/10173e274261e19d58780ee76d486d3e446aa622"}},"author_association":"NONE"}}
{"actor":{"display_login":"JonasJurczok"}}