{"action":"created","comment":{"url":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments/222206339","pull_request_review_id":161035211,"id":222206339,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjIwNjMzOQ==","diff_hunk":"@@ -9,7 +9,7 @@\n     it 'when add_to_google_cal is true without a refill date' do\n       medication.add_to_google_cal = true\n       medication.refill = nil\n-      expect(new_cal_refill_reminder_needed?(medication)).to eq(false)\n+      expect(new_cal_refill_reminder_needed?(medication)).to eq(nil)","path":"spec/helpers/calendar_helper_spec.rb","position":5,"original_position":5,"commit_id":"c6f005e60e839e7c227cbc9ebfc13a4614be3498","original_commit_id":"c6f005e60e839e7c227cbc9ebfc13a4614be3498","user":{"login":"HolyWalley","id":15906919,"node_id":"MDQ6VXNlcjE1OTA2OTE5","avatar_url":"https://avatars3.githubusercontent.com/u/15906919?v=4","gravatar_id":"","url":"https://api.github.com/users/HolyWalley","html_url":"https://github.com/HolyWalley","followers_url":"https://api.github.com/users/HolyWalley/followers","following_url":"https://api.github.com/users/HolyWalley/following{/other_user}","gists_url":"https://api.github.com/users/HolyWalley/gists{/gist_id}","starred_url":"https://api.github.com/users/HolyWalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HolyWalley/subscriptions","organizations_url":"https://api.github.com/users/HolyWalley/orgs","repos_url":"https://api.github.com/users/HolyWalley/repos","events_url":"https://api.github.com/users/HolyWalley/events{/privacy}","received_events_url":"https://api.github.com/users/HolyWalley/received_events","type":"User","site_admin":false},"body":"we can also change `#new_cal_refill_reminder_needed` to this:\r\n\r\n```\r\n!!(medication.add_to_google_cal && medication.refill &&\r\n  (medication.add_to_google_cal_changed? || medication.refill_changed?))\r\n```\r\n\r\nit will have a similar result, but I'm not sure that this is good practice.","created_at":"2018-10-03T07:20:12Z","updated_at":"2018-10-03T07:20:12Z","html_url":"https://github.com/ifmeorg/ifme/pull/1058#discussion_r222206339","pull_request_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments/222206339"},"html":{"href":"https://github.com/ifmeorg/ifme/pull/1058#discussion_r222206339"},"pull_request":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058"}},"in_reply_to_id":222061178},"pull_request":{"url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058","id":219783633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzgzNjMz","html_url":"https://github.com/ifmeorg/ifme/pull/1058","diff_url":"https://github.com/ifmeorg/ifme/pull/1058.diff","patch_url":"https://github.com/ifmeorg/ifme/pull/1058.patch","issue_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1058","number":1058,"state":"open","locked":false,"title":"[i1050] Add missing test coverage for medication_refill_helper.rb","user":{"login":"HolyWalley","id":15906919,"node_id":"MDQ6VXNlcjE1OTA2OTE5","avatar_url":"https://avatars3.githubusercontent.com/u/15906919?v=4","gravatar_id":"","url":"https://api.github.com/users/HolyWalley","html_url":"https://github.com/HolyWalley","followers_url":"https://api.github.com/users/HolyWalley/followers","following_url":"https://api.github.com/users/HolyWalley/following{/other_user}","gists_url":"https://api.github.com/users/HolyWalley/gists{/gist_id}","starred_url":"https://api.github.com/users/HolyWalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HolyWalley/subscriptions","organizations_url":"https://api.github.com/users/HolyWalley/orgs","repos_url":"https://api.github.com/users/HolyWalley/repos","events_url":"https://api.github.com/users/HolyWalley/events{/privacy}","received_events_url":"https://api.github.com/users/HolyWalley/received_events","type":"User","site_admin":false},"body":"# Description \r\n\r\nAdd tests for the medication_refill_helper.rb\r\n\r\n## Corresponding Issue\r\n\r\nhttps://github.com/ifmeorg/ifme/issues/1050\r\n\r\n# Test Coverage\r\n\r\n✅ \r\n","created_at":"2018-10-02T17:26:36Z","updated_at":"2018-10-03T07:20:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a16a144822826e2c45d46b391ae56121a79cecbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058/commits","review_comments_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058/comments","review_comment_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1058/comments","statuses_url":"https://api.github.com/repos/ifmeorg/ifme/statuses/c6f005e60e839e7c227cbc9ebfc13a4614be3498","head":{"label":"HolyWalley:issue_1050_add_missing_tests_for_medication_refill_helper","ref":"issue_1050_add_missing_tests_for_medication_refill_helper","sha":"c6f005e60e839e7c227cbc9ebfc13a4614be3498","user":{"login":"HolyWalley","id":15906919,"node_id":"MDQ6VXNlcjE1OTA2OTE5","avatar_url":"https://avatars3.githubusercontent.com/u/15906919?v=4","gravatar_id":"","url":"https://api.github.com/users/HolyWalley","html_url":"https://github.com/HolyWalley","followers_url":"https://api.github.com/users/HolyWalley/followers","following_url":"https://api.github.com/users/HolyWalley/following{/other_user}","gists_url":"https://api.github.com/users/HolyWalley/gists{/gist_id}","starred_url":"https://api.github.com/users/HolyWalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HolyWalley/subscriptions","organizations_url":"https://api.github.com/users/HolyWalley/orgs","repos_url":"https://api.github.com/users/HolyWalley/repos","events_url":"https://api.github.com/users/HolyWalley/events{/privacy}","received_events_url":"https://api.github.com/users/HolyWalley/received_events","type":"User","site_admin":false},"repo":{"id":151276729,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNzY3Mjk=","name":"ifme","full_name":"HolyWalley/ifme","private":false,"owner":{"login":"HolyWalley","id":15906919,"node_id":"MDQ6VXNlcjE1OTA2OTE5","avatar_url":"https://avatars3.githubusercontent.com/u/15906919?v=4","gravatar_id":"","url":"https://api.github.com/users/HolyWalley","html_url":"https://github.com/HolyWalley","followers_url":"https://api.github.com/users/HolyWalley/followers","following_url":"https://api.github.com/users/HolyWalley/following{/other_user}","gists_url":"https://api.github.com/users/HolyWalley/gists{/gist_id}","starred_url":"https://api.github.com/users/HolyWalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HolyWalley/subscriptions","organizations_url":"https://api.github.com/users/HolyWalley/orgs","repos_url":"https://api.github.com/users/HolyWalley/repos","events_url":"https://api.github.com/users/HolyWalley/events{/privacy}","received_events_url":"https://api.github.com/users/HolyWalley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HolyWalley/ifme","description":"Open source app to share mental health experiences with loved ones","fork":true,"url":"https://api.github.com/repos/HolyWalley/ifme","forks_url":"https://api.github.com/repos/HolyWalley/ifme/forks","keys_url":"https://api.github.com/repos/HolyWalley/ifme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HolyWalley/ifme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HolyWalley/ifme/teams","hooks_url":"https://api.github.com/repos/HolyWalley/ifme/hooks","issue_events_url":"https://api.github.com/repos/HolyWalley/ifme/issues/events{/number}","events_url":"https://api.github.com/repos/HolyWalley/ifme/events","assignees_url":"https://api.github.com/repos/HolyWalley/ifme/assignees{/user}","branches_url":"https://api.github.com/repos/HolyWalley/ifme/branches{/branch}","tags_url":"https://api.github.com/repos/HolyWalley/ifme/tags","blobs_url":"https://api.github.com/repos/HolyWalley/ifme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HolyWalley/ifme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HolyWalley/ifme/git/refs{/sha}","trees_url":"https://api.github.com/repos/HolyWalley/ifme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HolyWalley/ifme/statuses/{sha}","languages_url":"https://api.github.com/repos/HolyWalley/ifme/languages","stargazers_url":"https://api.github.com/repos/HolyWalley/ifme/stargazers","contributors_url":"https://api.github.com/repos/HolyWalley/ifme/contributors","subscribers_url":"https://api.github.com/repos/HolyWalley/ifme/subscribers","subscription_url":"https://api.github.com/repos/HolyWalley/ifme/subscription","commits_url":"https://api.github.com/repos/HolyWalley/ifme/commits{/sha}","git_commits_url":"https://api.github.com/repos/HolyWalley/ifme/git/commits{/sha}","comments_url":"https://api.github.com/repos/HolyWalley/ifme/comments{/number}","issue_comment_url":"https://api.github.com/repos/HolyWalley/ifme/issues/comments{/number}","contents_url":"https://api.github.com/repos/HolyWalley/ifme/contents/{+path}","compare_url":"https://api.github.com/repos/HolyWalley/ifme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HolyWalley/ifme/merges","archive_url":"https://api.github.com/repos/HolyWalley/ifme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HolyWalley/ifme/downloads","issues_url":"https://api.github.com/repos/HolyWalley/ifme/issues{/number}","pulls_url":"https://api.github.com/repos/HolyWalley/ifme/pulls{/number}","milestones_url":"https://api.github.com/repos/HolyWalley/ifme/milestones{/number}","notifications_url":"https://api.github.com/repos/HolyWalley/ifme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HolyWalley/ifme/labels{/name}","releases_url":"https://api.github.com/repos/HolyWalley/ifme/releases{/id}","deployments_url":"https://api.github.com/repos/HolyWalley/ifme/deployments","created_at":"2018-10-02T15:20:44Z","updated_at":"2018-10-02T15:20:47Z","pushed_at":"2018-10-03T07:06:10Z","git_url":"git://github.com/HolyWalley/ifme.git","ssh_url":"git@github.com:HolyWalley/ifme.git","clone_url":"https://github.com/HolyWalley/ifme.git","svn_url":"https://github.com/HolyWalley/ifme","homepage":"http://www.if-me.org/","size":31527,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ifmeorg:master","ref":"master","sha":"2be3d36f7b0bdf551bdb4c32281608a7939262f3","user":{"login":"ifmeorg","id":23299450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjk5NDUw","avatar_url":"https://avatars3.githubusercontent.com/u/23299450?v=4","gravatar_id":"","url":"https://api.github.com/users/ifmeorg","html_url":"https://github.com/ifmeorg","followers_url":"https://api.github.com/users/ifmeorg/followers","following_url":"https://api.github.com/users/ifmeorg/following{/other_user}","gists_url":"https://api.github.com/users/ifmeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ifmeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifmeorg/subscriptions","organizations_url":"https://api.github.com/users/ifmeorg/orgs","repos_url":"https://api.github.com/users/ifmeorg/repos","events_url":"https://api.github.com/users/ifmeorg/events{/privacy}","received_events_url":"https://api.github.com/users/ifmeorg/received_events","type":"Organization","site_admin":false},"repo":{"id":18935740,"node_id":"MDEwOlJlcG9zaXRvcnkxODkzNTc0MA==","name":"ifme","full_name":"ifmeorg/ifme","private":false,"owner":{"login":"ifmeorg","id":23299450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjk5NDUw","avatar_url":"https://avatars3.githubusercontent.com/u/23299450?v=4","gravatar_id":"","url":"https://api.github.com/users/ifmeorg","html_url":"https://github.com/ifmeorg","followers_url":"https://api.github.com/users/ifmeorg/followers","following_url":"https://api.github.com/users/ifmeorg/following{/other_user}","gists_url":"https://api.github.com/users/ifmeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ifmeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifmeorg/subscriptions","organizations_url":"https://api.github.com/users/ifmeorg/orgs","repos_url":"https://api.github.com/users/ifmeorg/repos","events_url":"https://api.github.com/users/ifmeorg/events{/privacy}","received_events_url":"https://api.github.com/users/ifmeorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ifmeorg/ifme","description":"Open source app to share mental health experiences with loved ones","fork":false,"url":"https://api.github.com/repos/ifmeorg/ifme","forks_url":"https://api.github.com/repos/ifmeorg/ifme/forks","keys_url":"https://api.github.com/repos/ifmeorg/ifme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifmeorg/ifme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifmeorg/ifme/teams","hooks_url":"https://api.github.com/repos/ifmeorg/ifme/hooks","issue_events_url":"https://api.github.com/repos/ifmeorg/ifme/issues/events{/number}","events_url":"https://api.github.com/repos/ifmeorg/ifme/events","assignees_url":"https://api.github.com/repos/ifmeorg/ifme/assignees{/user}","branches_url":"https://api.github.com/repos/ifmeorg/ifme/branches{/branch}","tags_url":"https://api.github.com/repos/ifmeorg/ifme/tags","blobs_url":"https://api.github.com/repos/ifmeorg/ifme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifmeorg/ifme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifmeorg/ifme/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifmeorg/ifme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifmeorg/ifme/statuses/{sha}","languages_url":"https://api.github.com/repos/ifmeorg/ifme/languages","stargazers_url":"https://api.github.com/repos/ifmeorg/ifme/stargazers","contributors_url":"https://api.github.com/repos/ifmeorg/ifme/contributors","subscribers_url":"https://api.github.com/repos/ifmeorg/ifme/subscribers","subscription_url":"https://api.github.com/repos/ifmeorg/ifme/subscription","commits_url":"https://api.github.com/repos/ifmeorg/ifme/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifmeorg/ifme/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifmeorg/ifme/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifmeorg/ifme/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifmeorg/ifme/contents/{+path}","compare_url":"https://api.github.com/repos/ifmeorg/ifme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifmeorg/ifme/merges","archive_url":"https://api.github.com/repos/ifmeorg/ifme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifmeorg/ifme/downloads","issues_url":"https://api.github.com/repos/ifmeorg/ifme/issues{/number}","pulls_url":"https://api.github.com/repos/ifmeorg/ifme/pulls{/number}","milestones_url":"https://api.github.com/repos/ifmeorg/ifme/milestones{/number}","notifications_url":"https://api.github.com/repos/ifmeorg/ifme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifmeorg/ifme/labels{/name}","releases_url":"https://api.github.com/repos/ifmeorg/ifme/releases{/id}","deployments_url":"https://api.github.com/repos/ifmeorg/ifme/deployments","created_at":"2014-04-19T06:58:25Z","updated_at":"2018-10-03T07:05:38Z","pushed_at":"2018-10-03T07:06:12Z","git_url":"git://github.com/ifmeorg/ifme.git","ssh_url":"git@github.com:ifmeorg/ifme.git","clone_url":"https://github.com/ifmeorg/ifme.git","svn_url":"https://github.com/ifmeorg/ifme","homepage":"http://www.if-me.org/","size":31530,"stargazers_count":682,"watchers_count":682,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":374,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":374,"open_issues":101,"watchers":682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058"},"html":{"href":"https://github.com/ifmeorg/ifme/pull/1058"},"issue":{"href":"https://api.github.com/repos/ifmeorg/ifme/issues/1058"},"comments":{"href":"https://api.github.com/repos/ifmeorg/ifme/issues/1058/comments"},"review_comments":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058/comments"},"review_comment":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1058/commits"},"statuses":{"href":"https://api.github.com/repos/ifmeorg/ifme/statuses/c6f005e60e839e7c227cbc9ebfc13a4614be3498"}},"author_association":"NONE"}}
{"actor":{"display_login":"HolyWalley"}}