{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/241646476","pull_request_review_id":184971184,"id":241646476,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY0NjQ3Ng==","diff_hunk":"@@ -213,3 +213,16 @@ test(function fastTimeout(cb) {\n     });\n   }));\n });\n+\n+test(function serverTimeout(cb) {\n+  const server = http.createServer();\n+  server.listen(common.mustCall(() => {\n+    const timeoutValue = 50;\n+    const s = server.setTimeout(timeoutValue);\n+    assert.equal(s.timeout, timeoutValue);","path":"test/parallel/test-http-set-timeout-server.js","position":10,"original_position":10,"commit_id":"4d0a49bc74815e5e039e6fd3d540e41fc3eb72f7","original_commit_id":"4d0a49bc74815e5e039e6fd3d540e41fc3eb72f7","user":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"body":"Thanks @Trott for quick review, I'll post an update in new commit","created_at":"2018-12-14T05:17:54Z","updated_at":"2018-12-14T05:17:55Z","html_url":"https://github.com/nodejs/node/pull/25030#discussion_r241646476","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/25030","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/241646476"},"html":{"href":"https://github.com/nodejs/node/pull/25030#discussion_r241646476"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/25030"}},"in_reply_to_id":241645863},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/25030","id":238612380,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjEyMzgw","html_url":"https://github.com/nodejs/node/pull/25030","diff_url":"https://github.com/nodejs/node/pull/25030.diff","patch_url":"https://github.com/nodejs/node/pull/25030.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/25030","number":25030,"state":"open","locked":false,"title":"http: test for timeout without callback","user":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"body":"Adds unit test to check else branch http://bit.ly/2zVlO90\r\n\r\nThis code was written live at [SeattleJS December Meetup](https://www.meetup.com/seattlejs/events/dczsvkyxqbrb/)\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-12-14T05:10:14Z","updated_at":"2018-12-14T05:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fc6bface2a4a15d3f7ecb658bf565ea62dc8c97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/25030/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/25030/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/25030/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/4d0a49bc74815e5e039e6fd3d540e41fc3eb72f7","head":{"label":"trivikr:test-timeout-without-callback","ref":"test-timeout-without-callback","sha":"4d0a49bc74815e5e039e6fd3d540e41fc3eb72f7","user":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"repo":{"id":104234761,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQyMzQ3NjE=","name":"node","full_name":"trivikr/node","private":false,"owner":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trivikr/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/trivikr/node","forks_url":"https://api.github.com/repos/trivikr/node/forks","keys_url":"https://api.github.com/repos/trivikr/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trivikr/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trivikr/node/teams","hooks_url":"https://api.github.com/repos/trivikr/node/hooks","issue_events_url":"https://api.github.com/repos/trivikr/node/issues/events{/number}","events_url":"https://api.github.com/repos/trivikr/node/events","assignees_url":"https://api.github.com/repos/trivikr/node/assignees{/user}","branches_url":"https://api.github.com/repos/trivikr/node/branches{/branch}","tags_url":"https://api.github.com/repos/trivikr/node/tags","blobs_url":"https://api.github.com/repos/trivikr/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trivikr/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trivikr/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/trivikr/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trivikr/node/statuses/{sha}","languages_url":"https://api.github.com/repos/trivikr/node/languages","stargazers_url":"https://api.github.com/repos/trivikr/node/stargazers","contributors_url":"https://api.github.com/repos/trivikr/node/contributors","subscribers_url":"https://api.github.com/repos/trivikr/node/subscribers","subscription_url":"https://api.github.com/repos/trivikr/node/subscription","commits_url":"https://api.github.com/repos/trivikr/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/trivikr/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/trivikr/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/trivikr/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/trivikr/node/contents/{+path}","compare_url":"https://api.github.com/repos/trivikr/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trivikr/node/merges","archive_url":"https://api.github.com/repos/trivikr/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trivikr/node/downloads","issues_url":"https://api.github.com/repos/trivikr/node/issues{/number}","pulls_url":"https://api.github.com/repos/trivikr/node/pulls{/number}","milestones_url":"https://api.github.com/repos/trivikr/node/milestones{/number}","notifications_url":"https://api.github.com/repos/trivikr/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trivikr/node/labels{/name}","releases_url":"https://api.github.com/repos/trivikr/node/releases{/id}","deployments_url":"https://api.github.com/repos/trivikr/node/deployments","created_at":"2017-09-20T15:38:29Z","updated_at":"2018-12-13T05:58:57Z","pushed_at":"2018-12-14T05:08:37Z","git_url":"git://github.com/trivikr/node.git","ssh_url":"git@github.com:trivikr/node.git","clone_url":"https://github.com/trivikr/node.git","svn_url":"https://github.com/trivikr/node","homepage":"https://nodejs.org","size":414741,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"49f1db47e2bb0fa4f2a53f4244639502688a291b","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-12-14T05:11:34Z","pushed_at":"2018-12-14T05:10:15Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":442733,"stargazers_count":56393,"watchers_count":56393,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12439,"mirror_url":null,"archived":false,"open_issues_count":742,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12439,"open_issues":742,"watchers":56393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/25030"},"html":{"href":"https://github.com/nodejs/node/pull/25030"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/25030"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/25030/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/25030/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/25030/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/4d0a49bc74815e5e039e6fd3d540e41fc3eb72f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"trivikr"}}