{"action":"created","issue":{"url":"https://api.github.com/repos/openemr/openemr/issues/1928","repository_url":"https://api.github.com/repos/openemr/openemr","labels_url":"https://api.github.com/repos/openemr/openemr/issues/1928/labels{/name}","comments_url":"https://api.github.com/repos/openemr/openemr/issues/1928/comments","events_url":"https://api.github.com/repos/openemr/openemr/issues/1928/events","html_url":"https://github.com/openemr/openemr/pull/1928","id":372258693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTA1MTYw","number":1928,"title":"log ip improve","user":{"login":"bradymiller","id":278968,"node_id":"MDQ6VXNlcjI3ODk2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/278968?v=4","gravatar_id":"","url":"https://api.github.com/users/bradymiller","html_url":"https://github.com/bradymiller","followers_url":"https://api.github.com/users/bradymiller/followers","following_url":"https://api.github.com/users/bradymiller/following{/other_user}","gists_url":"https://api.github.com/users/bradymiller/gists{/gist_id}","starred_url":"https://api.github.com/users/bradymiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradymiller/subscriptions","organizations_url":"https://api.github.com/users/bradymiller/orgs","repos_url":"https://api.github.com/users/bradymiller/repos","events_url":"https://api.github.com/users/bradymiller/events{/privacy}","received_events_url":"https://api.github.com/users/bradymiller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-20T22:28:07Z","updated_at":"2018-10-21T00:12:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openemr/openemr/pulls/1928","html_url":"https://github.com/openemr/openemr/pull/1928","diff_url":"https://github.com/openemr/openemr/pull/1928.diff","patch_url":"https://github.com/openemr/openemr/pull/1928.patch"},"body":"When collecting ip address.\r\n\r\n$_SERVER['REMOTE_ADDR'] is not always correct (for example, when behind a reverse-proxy), however it can't really be spoofed.\r\n$_SERVER['HTTP_X_FORWARDED_FOR'] will get correct ip address when behind a correctly set reverse-proxy, however it can be spoofed.\r\n\r\nSo set it up in log that $_SERVER['REMOTE_ADDR'] is always collected and then will also record if $_SERVER['HTTP_X_FORWARDED_FOR']  if exists.\r\n\r\nEncapsulated this in a function, so we can fix it up as needed in the future."},"comment":{"url":"https://api.github.com/repos/openemr/openemr/issues/comments/431627884","html_url":"https://github.com/openemr/openemr/pull/1928#issuecomment-431627884","issue_url":"https://api.github.com/repos/openemr/openemr/issues/1928","id":431627884,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTYyNzg4NA==","user":{"login":"bradymiller","id":278968,"node_id":"MDQ6VXNlcjI3ODk2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/278968?v=4","gravatar_id":"","url":"https://api.github.com/users/bradymiller","html_url":"https://github.com/bradymiller","followers_url":"https://api.github.com/users/bradymiller/followers","following_url":"https://api.github.com/users/bradymiller/following{/other_user}","gists_url":"https://api.github.com/users/bradymiller/gists{/gist_id}","starred_url":"https://api.github.com/users/bradymiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradymiller/subscriptions","organizations_url":"https://api.github.com/users/bradymiller/orgs","repos_url":"https://api.github.com/users/bradymiller/repos","events_url":"https://api.github.com/users/bradymiller/events{/privacy}","received_events_url":"https://api.github.com/users/bradymiller/received_events","type":"User","site_admin":false},"created_at":"2018-10-21T00:12:49Z","updated_at":"2018-10-21T00:12:49Z","author_association":"MEMBER","body":"testing well and will bring into codebase\r\n(btw, this will also help to pinpoint bad ip addresses that appear to be breaking some of the online demos via autoscripting)"}}
{"actor":{"display_login":"bradymiller"}}