{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/233700774","pull_request_review_id":175176779,"id":233700774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzcwMDc3NA==","diff_hunk":"@@ -0,0 +1,179 @@\n+﻿using System.Linq;\r\n+using System.Collections.Generic;\r\n+using System.Text.RegularExpressions;\r\n+using Microsoft.Recognizers.Definitions.Japanese;\r\n+using DateObject = System.DateTime;\r\n+using Microsoft.Recognizers.Text.Number;\r\n+\r\n+namespace Microsoft.Recognizers.Text.DateTime.Japanese\r\n+{\r\n+    public class DateTimeExtractorJap : IDateTimeExtractor\r","path":".NET/Microsoft.Recognizers.Text.DateTime/Japanese/Extractors/DateTimeExtractorJap.cs","position":10,"original_position":10,"commit_id":"8b62c28cd1d4aebd0ceac2ff896672cf3de6ab4d","original_commit_id":"8b62c28cd1d4aebd0ceac2ff896672cf3de6ab4d","user":{"login":"tellarin","id":628614,"node_id":"MDQ6VXNlcjYyODYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/628614?v=4","gravatar_id":"","url":"https://api.github.com/users/tellarin","html_url":"https://github.com/tellarin","followers_url":"https://api.github.com/users/tellarin/followers","following_url":"https://api.github.com/users/tellarin/following{/other_user}","gists_url":"https://api.github.com/users/tellarin/gists{/gist_id}","starred_url":"https://api.github.com/users/tellarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tellarin/subscriptions","organizations_url":"https://api.github.com/users/tellarin/orgs","repos_url":"https://api.github.com/users/tellarin/repos","events_url":"https://api.github.com/users/tellarin/events{/privacy}","received_events_url":"https://api.github.com/users/tellarin/received_events","type":"User","site_admin":false},"body":"There is no need to add the Jap suffix. Could you rename classes to remove the suffixes?\r\nI see that some classes in Chinese use it. We'll remove those too.","created_at":"2018-11-15T03:19:00Z","updated_at":"2018-11-15T03:30:21Z","html_url":"https://github.com/Microsoft/Recognizers-Text/pull/975#discussion_r233700774","pull_request_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/233700774"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/975#discussion_r233700774"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975","id":230925228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTI1MjI4","html_url":"https://github.com/Microsoft/Recognizers-Text/pull/975","diff_url":"https://github.com/Microsoft/Recognizers-Text/pull/975.diff","patch_url":"https://github.com/Microsoft/Recognizers-Text/pull/975.patch","issue_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/975","number":975,"state":"open","locked":false,"title":"[dotnet][Datetime][Japanese] Initial .net support for datetime in japanese","user":{"login":"gustavocalheiros","id":4106594,"node_id":"MDQ6VXNlcjQxMDY1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4106594?v=4","gravatar_id":"","url":"https://api.github.com/users/gustavocalheiros","html_url":"https://github.com/gustavocalheiros","followers_url":"https://api.github.com/users/gustavocalheiros/followers","following_url":"https://api.github.com/users/gustavocalheiros/following{/other_user}","gists_url":"https://api.github.com/users/gustavocalheiros/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavocalheiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavocalheiros/subscriptions","organizations_url":"https://api.github.com/users/gustavocalheiros/orgs","repos_url":"https://api.github.com/users/gustavocalheiros/repos","events_url":"https://api.github.com/users/gustavocalheiros/events{/privacy}","received_events_url":"https://api.github.com/users/gustavocalheiros/received_events","type":"User","site_admin":false},"body":"### Status\r\n- All files based on Chinese implementation\r\n- Recognition of Range of dates (from....to) like: １１月１日から１２月６日まで\r\n- Recognition of exact dates like \"２０１６年１２月１日\" \r\n- Recognition of the Japanese expressions for \"today\", \"yesterday\", months (january->december) and days of the week (monday->sunday).\r\n- Enabled 95 out of the 300 tests that were already implemented and disabled.\r\n- Added 13 new tests for DateRange\r\n- Total of 108 green tests for [dotNet].\r\n\r\n\r\n### Issues:\r\n- Still 205 tests that are disabled for [dotNet], due to lack specific implementation to make them pass.\r\n- On some existant tests, symbols like \"昨年\" (which mean \"last year\") are considered as \"date\". Maybe it should be considered as daterange. Same for \"last month\", \"next year\", etc. These tests remain disabled.\r\n","created_at":"2018-11-14T17:47:25Z","updated_at":"2018-11-15T03:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"651a0edbe4a4b13c0358fd36d18241a9ec6403ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975/commits","review_comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975/comments","review_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/975/comments","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/8b62c28cd1d4aebd0ceac2ff896672cf3de6ab4d","head":{"label":"gustavocalheiros:japanese-datetime-support","ref":"japanese-datetime-support","sha":"8b62c28cd1d4aebd0ceac2ff896672cf3de6ab4d","user":{"login":"gustavocalheiros","id":4106594,"node_id":"MDQ6VXNlcjQxMDY1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4106594?v=4","gravatar_id":"","url":"https://api.github.com/users/gustavocalheiros","html_url":"https://github.com/gustavocalheiros","followers_url":"https://api.github.com/users/gustavocalheiros/followers","following_url":"https://api.github.com/users/gustavocalheiros/following{/other_user}","gists_url":"https://api.github.com/users/gustavocalheiros/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavocalheiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavocalheiros/subscriptions","organizations_url":"https://api.github.com/users/gustavocalheiros/orgs","repos_url":"https://api.github.com/users/gustavocalheiros/repos","events_url":"https://api.github.com/users/gustavocalheiros/events{/privacy}","received_events_url":"https://api.github.com/users/gustavocalheiros/received_events","type":"User","site_admin":false},"repo":{"id":154499784,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0OTk3ODQ=","name":"Recognizers-Text","full_name":"gustavocalheiros/Recognizers-Text","private":false,"owner":{"login":"gustavocalheiros","id":4106594,"node_id":"MDQ6VXNlcjQxMDY1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4106594?v=4","gravatar_id":"","url":"https://api.github.com/users/gustavocalheiros","html_url":"https://github.com/gustavocalheiros","followers_url":"https://api.github.com/users/gustavocalheiros/followers","following_url":"https://api.github.com/users/gustavocalheiros/following{/other_user}","gists_url":"https://api.github.com/users/gustavocalheiros/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavocalheiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavocalheiros/subscriptions","organizations_url":"https://api.github.com/users/gustavocalheiros/orgs","repos_url":"https://api.github.com/users/gustavocalheiros/repos","events_url":"https://api.github.com/users/gustavocalheiros/events{/privacy}","received_events_url":"https://api.github.com/users/gustavocalheiros/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gustavocalheiros/Recognizers-Text","description":"Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, and date/time expressed in multiple languages (CN, EN, FR, ES, and PT. Partial support for DE, JA, KO, NL). Contributions are greatly welcome! Packages are available at https://www.nuget.org/profiles/Recognizers.Text and https://www.npmjs.com/~recognizers.text","fork":true,"url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text","forks_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/gustavocalheiros/Recognizers-Text/deployments","created_at":"2018-10-24T12:46:10Z","updated_at":"2018-11-14T13:21:48Z","pushed_at":"2018-11-14T15:31:26Z","git_url":"git://github.com/gustavocalheiros/Recognizers-Text.git","ssh_url":"git@github.com:gustavocalheiros/Recognizers-Text.git","clone_url":"https://github.com/gustavocalheiros/Recognizers-Text.git","svn_url":"https://github.com/gustavocalheiros/Recognizers-Text","homepage":"","size":16243,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"cd3d794d5b4477e8240d0419aa96816e3ef7adb1","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":88544417,"node_id":"MDEwOlJlcG9zaXRvcnk4ODU0NDQxNw==","name":"Recognizers-Text","full_name":"Microsoft/Recognizers-Text","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/Recognizers-Text","description":"Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, and date/time expressed in multiple languages (CN, EN, FR, ES, and PT. Partial support for DE, JA, KO, NL). Contributions are greatly welcome! Packages are available at https://www.nuget.org/profiles/Recognizers.Text and https://www.npmjs.com/~recognizers.text","fork":false,"url":"https://api.github.com/repos/Microsoft/Recognizers-Text","forks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/deployments","created_at":"2017-04-17T19:45:47Z","updated_at":"2018-11-14T00:49:15Z","pushed_at":"2018-11-14T22:32:04Z","git_url":"git://github.com/Microsoft/Recognizers-Text.git","ssh_url":"git@github.com:Microsoft/Recognizers-Text.git","clone_url":"https://github.com/Microsoft/Recognizers-Text.git","svn_url":"https://github.com/Microsoft/Recognizers-Text","homepage":"","size":16122,"stargazers_count":270,"watchers_count":270,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":144,"open_issues":66,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/975"},"issue":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/975"},"comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/975/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/975/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/8b62c28cd1d4aebd0ceac2ff896672cf3de6ab4d"}},"author_association":"NONE"}}
{"actor":{"display_login":"tellarin"}}