{"action":"closed","number":841,"pull_request":{"url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/841","id":191002841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDAyODQx","html_url":"https://github.com/StackExchange/StackExchange.Redis/pull/841","diff_url":"https://github.com/StackExchange/StackExchange.Redis/pull/841.diff","patch_url":"https://github.com/StackExchange/StackExchange.Redis/pull/841.patch","issue_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/841","number":841,"state":"closed","locked":false,"title":"Simplify SocketManager.BeginConnect() with not-used-outside-of-tests code removal.","user":{"login":"NickCraver","id":454813,"node_id":"MDQ6VXNlcjQ1NDgxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/454813?v=4","gravatar_id":"","url":"https://api.github.com/users/NickCraver","html_url":"https://github.com/NickCraver","followers_url":"https://api.github.com/users/NickCraver/followers","following_url":"https://api.github.com/users/NickCraver/following{/other_user}","gists_url":"https://api.github.com/users/NickCraver/gists{/gist_id}","starred_url":"https://api.github.com/users/NickCraver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickCraver/subscriptions","organizations_url":"https://api.github.com/users/NickCraver/orgs","repos_url":"https://api.github.com/users/NickCraver/repos","events_url":"https://api.github.com/users/NickCraver/events{/privacy}","received_events_url":"https://api.github.com/users/NickCraver/received_events","type":"User","site_admin":false},"body":"This was an expedition, but here's the history:\r\n- There are 2 forks in the connection logic\r\n  - One for Mono (the `DnsEndpoint` split, see #20 and #155)\r\n  - One for `.BeginConnect()` and one for `.ConnectAsync()` (because `netstandard1.x` was \"async all the things!\")\r\n- There's a behind-the-scenes fork on completion type, but for actual library consumers (and not tests), it was always `.Any`, which was effectively `.Sync`.\r\n\r\nThere was also a critical bug fix in #113 that unfortuantely added a lot of complexity here. The maintenance problem is this complexity wasn't even used, as far as I can tell. It was only ever exposed to even be possibly used in the test project. So we had complicated connection logic, only for the sake of testing it. Unless I'm an idiot, which is entirely possible.\r\n\r\nThis commit removes that logic and simplifies things, as a first step that's a unit in itself. It does not fix Mono. There are other issues there, but thanks to WSL I can readily run the test suite under Mono on Linux now. Mono has a littany of other issues which I'll comment on in #314.\r\n\r\nThe most important thing here is that we don't regress what was fixed in #113, as this doesn't readily show in tests. After that I'd like to discuss when we should ditch `netstandard1.5` (I'll open an issue), because it has various bits of weight I think we want to remove for the Pipelines overhaul anyway.","created_at":"2018-05-28T22:20:00Z","updated_at":"2018-05-31T00:32:14Z","closed_at":"2018-05-31T00:32:14Z","merged_at":"2018-05-31T00:32:14Z","merge_commit_sha":"bbad04921c76b543243808da5e7608d67bab1106","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mgravell","id":17328,"node_id":"MDQ6VXNlcjE3MzI4","avatar_url":"https://avatars3.githubusercontent.com/u/17328?v=4","gravatar_id":"","url":"https://api.github.com/users/mgravell","html_url":"https://github.com/mgravell","followers_url":"https://api.github.com/users/mgravell/followers","following_url":"https://api.github.com/users/mgravell/following{/other_user}","gists_url":"https://api.github.com/users/mgravell/gists{/gist_id}","starred_url":"https://api.github.com/users/mgravell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgravell/subscriptions","organizations_url":"https://api.github.com/users/mgravell/orgs","repos_url":"https://api.github.com/users/mgravell/repos","events_url":"https://api.github.com/users/mgravell/events{/privacy}","received_events_url":"https://api.github.com/users/mgravell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/841/commits","review_comments_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/841/comments","review_comment_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/841/comments","statuses_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/statuses/d7c72b05191f373434ce0eb5479a4ca780b2f859","head":{"label":"StackExchange:craver/simplify-connect","ref":"craver/simplify-connect","sha":"d7c72b05191f373434ce0eb5479a4ca780b2f859","user":{"login":"StackExchange","id":1393171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMxNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1393171?v=4","gravatar_id":"","url":"https://api.github.com/users/StackExchange","html_url":"https://github.com/StackExchange","followers_url":"https://api.github.com/users/StackExchange/followers","following_url":"https://api.github.com/users/StackExchange/following{/other_user}","gists_url":"https://api.github.com/users/StackExchange/gists{/gist_id}","starred_url":"https://api.github.com/users/StackExchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackExchange/subscriptions","organizations_url":"https://api.github.com/users/StackExchange/orgs","repos_url":"https://api.github.com/users/StackExchange/repos","events_url":"https://api.github.com/users/StackExchange/events{/privacy}","received_events_url":"https://api.github.com/users/StackExchange/received_events","type":"Organization","site_admin":false},"repo":{"id":17748183,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc0ODE4Mw==","name":"StackExchange.Redis","full_name":"StackExchange/StackExchange.Redis","owner":{"login":"StackExchange","id":1393171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMxNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1393171?v=4","gravatar_id":"","url":"https://api.github.com/users/StackExchange","html_url":"https://github.com/StackExchange","followers_url":"https://api.github.com/users/StackExchange/followers","following_url":"https://api.github.com/users/StackExchange/following{/other_user}","gists_url":"https://api.github.com/users/StackExchange/gists{/gist_id}","starred_url":"https://api.github.com/users/StackExchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackExchange/subscriptions","organizations_url":"https://api.github.com/users/StackExchange/orgs","repos_url":"https://api.github.com/users/StackExchange/repos","events_url":"https://api.github.com/users/StackExchange/events{/privacy}","received_events_url":"https://api.github.com/users/StackExchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackExchange/StackExchange.Redis","description":"General purpose redis client","fork":false,"url":"https://api.github.com/repos/StackExchange/StackExchange.Redis","forks_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/forks","keys_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/teams","hooks_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/hooks","issue_events_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/events{/number}","events_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/events","assignees_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/assignees{/user}","branches_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/branches{/branch}","tags_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/tags","blobs_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/statuses/{sha}","languages_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/languages","stargazers_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/stargazers","contributors_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/contributors","subscribers_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/subscribers","subscription_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/subscription","commits_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/contents/{+path}","compare_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/merges","archive_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/downloads","issues_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues{/number}","pulls_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls{/number}","milestones_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/milestones{/number}","notifications_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/labels{/name}","releases_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/releases{/id}","deployments_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/deployments","created_at":"2014-03-14T14:09:26Z","updated_at":"2018-05-30T12:20:23Z","pushed_at":"2018-05-31T00:32:14Z","git_url":"git://github.com/StackExchange/StackExchange.Redis.git","ssh_url":"git@github.com:StackExchange/StackExchange.Redis.git","clone_url":"https://github.com/StackExchange/StackExchange.Redis.git","svn_url":"https://github.com/StackExchange/StackExchange.Redis","homepage":"https://stackexchange.github.io/StackExchange.Redis/","size":15857,"stargazers_count":2812,"watchers_count":2812,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":891,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":891,"open_issues":139,"watchers":2812,"default_branch":"master"}},"base":{"label":"StackExchange:master","ref":"master","sha":"b987ab3ff3a66ae9eca48fc5a33f4dfdfd0e107c","user":{"login":"StackExchange","id":1393171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMxNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1393171?v=4","gravatar_id":"","url":"https://api.github.com/users/StackExchange","html_url":"https://github.com/StackExchange","followers_url":"https://api.github.com/users/StackExchange/followers","following_url":"https://api.github.com/users/StackExchange/following{/other_user}","gists_url":"https://api.github.com/users/StackExchange/gists{/gist_id}","starred_url":"https://api.github.com/users/StackExchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackExchange/subscriptions","organizations_url":"https://api.github.com/users/StackExchange/orgs","repos_url":"https://api.github.com/users/StackExchange/repos","events_url":"https://api.github.com/users/StackExchange/events{/privacy}","received_events_url":"https://api.github.com/users/StackExchange/received_events","type":"Organization","site_admin":false},"repo":{"id":17748183,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc0ODE4Mw==","name":"StackExchange.Redis","full_name":"StackExchange/StackExchange.Redis","owner":{"login":"StackExchange","id":1393171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMxNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1393171?v=4","gravatar_id":"","url":"https://api.github.com/users/StackExchange","html_url":"https://github.com/StackExchange","followers_url":"https://api.github.com/users/StackExchange/followers","following_url":"https://api.github.com/users/StackExchange/following{/other_user}","gists_url":"https://api.github.com/users/StackExchange/gists{/gist_id}","starred_url":"https://api.github.com/users/StackExchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackExchange/subscriptions","organizations_url":"https://api.github.com/users/StackExchange/orgs","repos_url":"https://api.github.com/users/StackExchange/repos","events_url":"https://api.github.com/users/StackExchange/events{/privacy}","received_events_url":"https://api.github.com/users/StackExchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackExchange/StackExchange.Redis","description":"General purpose redis client","fork":false,"url":"https://api.github.com/repos/StackExchange/StackExchange.Redis","forks_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/forks","keys_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/teams","hooks_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/hooks","issue_events_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/events{/number}","events_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/events","assignees_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/assignees{/user}","branches_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/branches{/branch}","tags_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/tags","blobs_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/statuses/{sha}","languages_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/languages","stargazers_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/stargazers","contributors_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/contributors","subscribers_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/subscribers","subscription_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/subscription","commits_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/contents/{+path}","compare_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/merges","archive_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/downloads","issues_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues{/number}","pulls_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls{/number}","milestones_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/milestones{/number}","notifications_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/labels{/name}","releases_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/releases{/id}","deployments_url":"https://api.github.com/repos/StackExchange/StackExchange.Redis/deployments","created_at":"2014-03-14T14:09:26Z","updated_at":"2018-05-30T12:20:23Z","pushed_at":"2018-05-31T00:32:14Z","git_url":"git://github.com/StackExchange/StackExchange.Redis.git","ssh_url":"git@github.com:StackExchange/StackExchange.Redis.git","clone_url":"https://github.com/StackExchange/StackExchange.Redis.git","svn_url":"https://github.com/StackExchange/StackExchange.Redis","homepage":"https://stackexchange.github.io/StackExchange.Redis/","size":15857,"stargazers_count":2812,"watchers_count":2812,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":891,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":891,"open_issues":139,"watchers":2812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/841"},"html":{"href":"https://github.com/StackExchange/StackExchange.Redis/pull/841"},"issue":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/841"},"comments":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/StackExchange/StackExchange.Redis/statuses/d7c72b05191f373434ce0eb5479a4ca780b2f859"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"NickCraver","id":454813,"node_id":"MDQ6VXNlcjQ1NDgxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/454813?v=4","gravatar_id":"","url":"https://api.github.com/users/NickCraver","html_url":"https://github.com/NickCraver","followers_url":"https://api.github.com/users/NickCraver/followers","following_url":"https://api.github.com/users/NickCraver/following{/other_user}","gists_url":"https://api.github.com/users/NickCraver/gists{/gist_id}","starred_url":"https://api.github.com/users/NickCraver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickCraver/subscriptions","organizations_url":"https://api.github.com/users/NickCraver/orgs","repos_url":"https://api.github.com/users/NickCraver/repos","events_url":"https://api.github.com/users/NickCraver/events{/privacy}","received_events_url":"https://api.github.com/users/NickCraver/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":35,"deletions":125,"changed_files":6}}
{"actor":{"display_login":"NickCraver"}}