{"action":"created","issue":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2654","repository_url":"https://api.github.com/repos/umbraco/Umbraco-CMS","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2654/labels{/name}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2654/comments","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2654/events","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2654","id":327748870,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDY2NzE1","number":2654,"title":"Fixed an unsafe test by removing the unsafe parts being tested.","user":{"login":"Mundairson","id":21087319,"node_id":"MDQ6VXNlcjIxMDg3MzE5","avatar_url":"https://avatars3.githubusercontent.com/u/21087319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mundairson","html_url":"https://github.com/Mundairson","followers_url":"https://api.github.com/users/Mundairson/followers","following_url":"https://api.github.com/users/Mundairson/following{/other_user}","gists_url":"https://api.github.com/users/Mundairson/gists{/gist_id}","starred_url":"https://api.github.com/users/Mundairson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mundairson/subscriptions","organizations_url":"https://api.github.com/users/Mundairson/orgs","repos_url":"https://api.github.com/users/Mundairson/repos","events_url":"https://api.github.com/users/Mundairson/events{/privacy}","received_events_url":"https://api.github.com/users/Mundairson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-30T14:10:01Z","updated_at":"2018-06-04T10:32:03Z","closed_at":"2018-06-04T10:32:03Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/2654","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2654","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/2654.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/2654.patch"},"body":"### Prerequisites\r\n\r\n- [X] I have written a descriptive pull-request title\r\n- [X] I have linked this PR to an issue on the tracker at http://issues.umbraco.org/issue/U4-11390\r\n\r\n### Description\r\nOne unit test for reflective property setters kills the whole NUnit test runner. This patch removes the unsafe tests because they're so unsafe they cause the runtime to crash in an untrappable way."},"comment":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments/394309252","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/2654#issuecomment-394309252","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/2654","id":394309252,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDMwOTI1Mg==","user":{"login":"nul800sebastiaan","id":304656,"node_id":"MDQ6VXNlcjMwNDY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/304656?v=4","gravatar_id":"","url":"https://api.github.com/users/nul800sebastiaan","html_url":"https://github.com/nul800sebastiaan","followers_url":"https://api.github.com/users/nul800sebastiaan/followers","following_url":"https://api.github.com/users/nul800sebastiaan/following{/other_user}","gists_url":"https://api.github.com/users/nul800sebastiaan/gists{/gist_id}","starred_url":"https://api.github.com/users/nul800sebastiaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nul800sebastiaan/subscriptions","organizations_url":"https://api.github.com/users/nul800sebastiaan/orgs","repos_url":"https://api.github.com/users/nul800sebastiaan/repos","events_url":"https://api.github.com/users/nul800sebastiaan/events{/privacy}","received_events_url":"https://api.github.com/users/nul800sebastiaan/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T10:32:03Z","updated_at":"2018-06-04T10:32:03Z","author_association":"MEMBER","body":"Hey @Mundairson these tests run fine in NUnit-Gui 0.6.0 - not sure what's going on on your machine but I'm going to assume it's a local problem.\r\n\r\n![image](https://user-images.githubusercontent.com/304656/40912907-3a85a92e-67f3-11e8-9647-a049c1e7af63.png)\r\n\r\nI'll close this PR for now until we can get a better repro of the issue."}}
{"actor":{"display_login":"nul800sebastiaan"}}