{"action":"created","issue":{"url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/issues/13","repository_url":"https://api.github.com/repos/bradleyfalzon/ghinstallation","labels_url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/issues/13/comments","events_url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/issues/13/events","html_url":"https://github.com/bradleyfalzon/ghinstallation/pull/13","id":312654569,"number":13,"title":"Robust Header Check","user":{"login":"cpheps","id":11877763,"avatar_url":"https://avatars0.githubusercontent.com/u/11877763?v=4","gravatar_id":"","url":"https://api.github.com/users/cpheps","html_url":"https://github.com/cpheps","followers_url":"https://api.github.com/users/cpheps/followers","following_url":"https://api.github.com/users/cpheps/following{/other_user}","gists_url":"https://api.github.com/users/cpheps/gists{/gist_id}","starred_url":"https://api.github.com/users/cpheps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpheps/subscriptions","organizations_url":"https://api.github.com/users/cpheps/orgs","repos_url":"https://api.github.com/users/cpheps/repos","events_url":"https://api.github.com/users/cpheps/events{/privacy}","received_events_url":"https://api.github.com/users/cpheps/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-04-09T19:23:16Z","updated_at":"2018-04-25T04:35:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/pulls/13","html_url":"https://github.com/bradleyfalzon/ghinstallation/pull/13","diff_url":"https://github.com/bradleyfalzon/ghinstallation/pull/13.diff","patch_url":"https://github.com/bradleyfalzon/ghinstallation/pull/13.patch"},"body":"Added a robust check when adding the `Accept` Header, if an `Accept` header already exists with the value `application/octet-stream` then don't add the additional `Accept` header.\r\n\r\nResolves #12"},"comment":{"url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/issues/comments/384158101","html_url":"https://github.com/bradleyfalzon/ghinstallation/pull/13#issuecomment-384158101","issue_url":"https://api.github.com/repos/bradleyfalzon/ghinstallation/issues/13","id":384158101,"user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars3.githubusercontent.com/u/1924134?v=4","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T04:35:25Z","updated_at":"2018-04-25T04:35:25Z","author_association":"NONE","body":"> for some users not setting that header, and not using `go-github`.\r\n\r\nIsn't this package for GitHub? How can users not be using `go-github`? Asking because I don't know.\r\n\r\n> @shurcooL from my understanding, `go-github` always sets the relevant accept headers? I.e. by default it sets `application/vnd.github.v3+json` or the approprite preview headers?\r\n\r\nThat's right. The GitHub REST API v3 expects the media type to be provided in order to control the format of the data to be received. See https://developer.github.com/v3/media/.\r\n\r\nYou can confirm that `go-github` always sets an `Accept` header for its JSON endpoints here:\r\n\r\nhttps://github.com/google/go-github/blob/ab468aa138652ac73874d3a924ac84b26b990142/github/github.go#L315-L318"}}
{"actor":{"display_login":"shurcooL"}}