{"push_id":2896486524,"size":25,"distinct_size":4,"ref":"refs/heads/gk_dialog_title_icon","head":"e2e039cd650561b34cbf5dbf5d78e90c54b49308","before":"4fd8d89463a42c15093d507fe95cd1b6db37f029","commits":[{"sha":"0a9206b5fd4121d6661a4e2f57cd5757199380ff","author":{"name":"featherless","email":"57c7af8498ed81c7e6034d50511a638473c427f5@gmail.com"},"message":"[FlexibleHeader] Extract height matching to a separate function. (#5162)\n\nThis is a pure refactoring/extraction of logic from one method to a new one in preparation for additional work on the implementation in support of https://github.com/material-components/material-components-ios/issues/5156","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/0a9206b5fd4121d6661a4e2f57cd5757199380ff"},{"sha":"c7c7b49a2e26257a9fb879fb2baba3f6ff092ccf","author":{"name":"Wenyu Zhang","email":"17f97948fb9ec12989dedaa30411e18362284769@users.noreply.github.com"},"message":"[BottomAppBar] clean up how bottom app bar path renders to avoid using hardcoded values (#5155)\n\nBoth floating button and the path cut depended on many position constants to decide their position. This change removes the dependency of the path cut on those constant since the path cut should follow the floating button's realtime position.\r\n\r\nBefore the change:\r\n![simulator screen shot - iphone x - 2018-09-18 at 10 47 56](https://user-images.githubusercontent.com/8836258/45695891-61e4a980-bb30-11e8-97ef-b309d91db0f8.png)\r\n\r\n\r\nAfter the change:\r\n![simulator screen shot - iphone x - 2018-09-18 at 10 46 46](https://user-images.githubusercontent.com/8836258/45695877-5c875f00-bb30-11e8-8697-7aa80948edad.png)","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/c7c7b49a2e26257a9fb879fb2baba3f6ff092ccf"},{"sha":"6e91d5889980d6ab58eec7c9b7e7ab17858afe4b","author":{"name":"Cody Weaver","email":"bb486a0dd9b6f14c669c33f225a4bd58277b7f4b@gmail.com"},"message":"[ActionSheet] Add color properties to header labels (#5168)\n\nPreviously clients had no way of setting custom colors to the title and message labels. This adds the functionality.\r\n\r\nPrevious discussions were had at #5083 #4993 #4984 #4968 \r\nRelated to #5039 #4903 \r\n\r\n| Before | After |\r\n| ------- | ------- |\r\n|![simulator screen shot - iphone x - 2018-09-10 at 22 13 58](https://user-images.githubusercontent.com/7131294/45335650-674d5d00-b54e-11e8-9e6e-34ae5bac051c.png)|![simulator screen shot - iphone x - 2018-09-10 at 22 41 43](https://user-images.githubusercontent.com/7131294/45335652-6c121100-b54e-11e8-9fca-50e0a44d099e.png)|","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/6e91d5889980d6ab58eec7c9b7e7ab17858afe4b"},{"sha":"3ea86babf14323eef6e886252eb4e2ce51314635","author":{"name":"featherless","email":"57c7af8498ed81c7e6034d50511a638473c427f5@gmail.com"},"message":"[AppBar] Add an example demonstrating manual tab management. (#5161)\n\nThis example was provided by @babakbo in https://github.com/material-components/material-components-ios/issues/5156\r\n\r\nThe purpose of this example is to be able to test the behavior of multiple tabs that are added and removed from the view controller hierarchy as the selected tab changes. This is different from the typical tabs usage, which relies on a horizontally-paging scroll view to allow the tabs to be switched between.\r\n\r\nIn addition, this example is demonstrating the use of the canAlwaysExpandToMaximumHeight API which has been provided specifically for @babako and team.\r\n\r\n## Screenshots\r\n\r\n![simulator screen shot - iphone 8 plus - 2018-09-18 at 21 18 14](https://user-images.githubusercontent.com/45670/45707744-63da5700-bb88-11e8-86e7-55bef20408ac.png)","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/3ea86babf14323eef6e886252eb4e2ce51314635"},{"sha":"8aea34564caf2a29f3fbc4b1229fb5c931c047b8","author":{"name":"Andrew Overton","email":"16e507d1b75689782421371ab7ac52086c2be3f8@google.com"},"message":"[Catalog] Fix collection view layout in MDCThemePickerViewController (#5165)\n\nThese changes fix the layout of MDCThemePickerViewController.\r\nCloses #5143","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/8aea34564caf2a29f3fbc4b1229fb5c931c047b8"},{"sha":"766a6a7697c755e6cbd012da8339e5536bd1b6ae","author":{"name":"Wenyu Zhang","email":"17f97948fb9ec12989dedaa30411e18362284769@users.noreply.github.com"},"message":"[BottomAppBar] enable customizing the vertical position of FAB   (#5138)\n\nThis change provides a `floatingButtonCenterToNavigationBarTopOffset` property in `MDCBottomAppBarView` to customize the vertical position of FAB. You can use it on an `MDCBottomAppBarView` instance once it is initialized. \r\n\r\nExample:\r\n```\r\nMDCBottomAppBarView *appBarView = [[MDCBottomAppBarView alloc] init];\r\nappBarView.floatingButtonCenterToNavigationBarTopOffset = 20.0f\r\n```\r\n\r\n\r\ncloses #5011 and #5012\r\n\r\nBefore the change:\r\n![simulator screen shot - iphone x - 2018-09-14 at 17 06 10](https://user-images.githubusercontent.com/8836258/45575161-7e3aca80-b840-11e8-9b40-31f1b7e8de68.png)\r\n\r\n\r\nAfter the change:\r\n![pc3](https://user-images.githubusercontent.com/8836258/45640281-31ddcd80-ba80-11e8-818d-eb02ecea3c02.gif)","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/766a6a7697c755e6cbd012da8339e5536bd1b6ae"},{"sha":"eebbe49e2f5ea02db09979fe89b3028f719dd751","author":{"name":"featherless","email":"57c7af8498ed81c7e6034d50511a638473c427f5@gmail.com"},"message":"[AppBar] Add frame setting recommendation to app bar view controller migration guide. (#5180)\n\nSetting the view's frame is an important part of migrating from MDCAppBar to MDCAppBarViewController. Failure to do so can result in the app bar's width not matching the parent view's width.","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/eebbe49e2f5ea02db09979fe89b3028f719dd751"},{"sha":"b6110c10487e999197affcb86c17ffb3daa50ce1","author":{"name":"Andrew Overton","email":"16e507d1b75689782421371ab7ac52086c2be3f8@google.com"},"message":"Fix Dragons content inset bug (#5173)\n\nI was trying to look at an example but it was acting really glitchy on the simulator and I couldn't scroll to it on my device! Closes #5172","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/b6110c10487e999197affcb86c17ffb3daa50ce1"},{"sha":"ebd792126341918415b0e193fe0780b61a4eb06b","author":{"name":"Cody Weaver","email":"bb486a0dd9b6f14c669c33f225a4bd58277b7f4b@gmail.com"},"message":"Remove extension check (#5182)\n\nPreviously we checked against `iOSApplicationExtension` and `iOS` but if the `iOS` version is 9.0 or above then the ApplicationExtension will be as well. This will remove a lot of warnings in our kokoro logs when trying to track down errors.\r\n\r\n| Before | After |\r\n| ------ | ------ |\r\n|![simulator screen shot - iphone xs max - 2018-09-20 at 08 30 07](https://user-images.githubusercontent.com/7131294/45818633-4a342f00-bcb0-11e8-8e36-2c8079581c30.png)|![simulator screen shot - iphone xs max - 2018-09-20 at 08 29 32](https://user-images.githubusercontent.com/7131294/45818638-4e604c80-bcb0-11e8-91ea-664443d4be0a.png)|\r\n|![simulator screen shot - iphone xs max - 2018-09-20 at 08 29 32](https://user-images.githubusercontent.com/7131294/45818703-81a2db80-bcb0-11e8-9e64-f67e6d72d063.png)|![simulator screen shot - iphone xs max - 2018-09-20 at 08 30 07](https://user-images.githubusercontent.com/7131294/45818712-8798bc80-bcb0-11e8-85ea-223859066421.png)|","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/ebd792126341918415b0e193fe0780b61a4eb06b"},{"sha":"6e5f3abab68b68511cef3b56c53dc0c1bc9b6bf2","author":{"name":"Cody Weaver","email":"bb486a0dd9b6f14c669c33f225a4bd58277b7f4b@gmail.com"},"message":"[ActionSheet] Refactor test (#5186)\n\n### Context\r\nWhen testing against colors the goal is to test against every possible way a client might create a color, this lead to me creating different test for different way to create colors. This also didn't test against all the different ways to create colors. Having a new test for all new ways to create a color will lead to having a lot of reused code.\r\n\r\n### The problem\r\nThis will lead to a lot of repeated code for testing different color spaces vs different properties.\r\n\r\n### The fix\r\nThis will allow one test for all different properties that checks all different color spaces.\r\n\r\n### Related Issues\r\n#5039","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/6e5f3abab68b68511cef3b56c53dc0c1bc9b6bf2"},{"sha":"886f2661a71a714a695073d94867f597874afd65","author":{"name":"Cody Weaver","email":"bb486a0dd9b6f14c669c33f225a4bd58277b7f4b@gmail.com"},"message":"[ActionSheet] Open to the correct height (#5184)\n\nThis will for bleeding if there are too many options to show on screen at once.\r\n\r\n_Bleeding_\r\nMy understanding after speaking to design is, list with scrollable content within a bottom sheet should open up to half of the screen height minus half of a list item or to the list height. The initial height should be the smaller of those two values. Half of the height of the view is correct. But, if there are more options that will fit on half of the height (of the view) and the list height is a factor of the super view's height then a user may not be aware it is scrollable content. This new behavior is correct and makes for a better user experience in my opinion. The term bleeding was told to be by design, my understanding is the list item bleeds onto the view.\r\n\r\nPrevious discussions at #5024 & #5175 \r\nCloses #4945 & #5038 \r\n\r\n| Before | After |\r\n| ------- | ------- |\r\n|![simulator screen shot - iphone 8 - 2018-09-05 at 15 30 55](https://user-images.githubusercontent.com/7131294/45116429-b21b3f00-b120-11e8-960e-d8e46111e3d0.png)|![simulator screen shot - iphone 8 - 2018-09-05 at 15 28 49](https://user-images.githubusercontent.com/7131294/45116395-8c8e3580-b120-11e8-9d12-2c46d9086294.png)|\r\n\r\nIn the before example there are 30 actions, you are seeing the fourth action and top of the fifth. But, in some cases it may show exactly four options even though there is 30. This looks at the amount of actions that will fit on half the screen then shifts the content down to fit the header + actions - half an action.","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/886f2661a71a714a695073d94867f597874afd65"},{"sha":"362a2f1677706b7e1ad71105bd80d9a7b4f15a92","author":{"name":"featherless","email":"57c7af8498ed81c7e6034d50511a638473c427f5@gmail.com"},"message":"[kokoro] Only post to codecov if we have a token. (#5188)\n\nWe were previously posting to codecov on all of our jobs, even when we didn't have a token. Only posting when we have a token will reduce CI turnaround times for jobs that aren't generating coverage (which is most of them).","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/362a2f1677706b7e1ad71105bd80d9a7b4f15a92"},{"sha":"a82c9000e1347414bb597b557136775c6f829cfa","author":{"name":"featherless","email":"08f28d8c95465b448dcd8d223ee2c78cee302f7e@google.com"},"message":"[releasing] Move the hotfixing section down","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/a82c9000e1347414bb597b557136775c6f829cfa"},{"sha":"75cc150e3cd5f941460fd7538d5871eae040ca3f","author":{"name":"Cody Weaver","email":"bb486a0dd9b6f14c669c33f225a4bd58277b7f4b@gmail.com"},"message":"[ActionSheet] Update cells to be testable (#5190)\n\n### The problem\r\nWhen writing test if we want to test against `imageView` or `textLabel` it will look at UITableViewCell properties because those are exposed in UITableViewCell header file and we had them as `ivars`. This makes it so we cannot get to them within test unless if we check against the `UITableViewCell.contentView.subviews`. Exposing these clashes with UITableViewCell properties.\r\n\r\n### The fix\r\nChange these properties to properties on the class instead of `ivars` therefore allowing us to expose and rename them in test.\r\n\r\n### Related issues\r\n#5039","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/75cc150e3cd5f941460fd7538d5871eae040ca3f"},{"sha":"8cdd4a6330ead570e56a0c86708f0f7e2842fa31","author":{"name":"Cody Weaver","email":"bb486a0dd9b6f14c669c33f225a4bd58277b7f4b@gmail.com"},"message":"[ActionSheet] Use correct style (#5196)\n\n### Context\r\nDuring development of MDCActionSheetController I didn't add `k` to constants.\r\n\r\n### The problem\r\nConstants don't match the style we prefer in our components.\r\n\r\n### The fix\r\nAdd `k` to all constants throughout MDCActionSheetController.\r\n\r\n### Related issues\r\nCloses #5191","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/8cdd4a6330ead570e56a0c86708f0f7e2842fa31"},{"sha":"0f1b95a9ac1bd85bd49a30532c6e72e6dac0cc27","author":{"name":"featherless","email":"57c7af8498ed81c7e6034d50511a638473c427f5@gmail.com"},"message":"[releasing] Drop client notification recommendation and clarify pull request need (#5194)","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/0f1b95a9ac1bd85bd49a30532c6e72e6dac0cc27"},{"sha":"5b34c0eb3a923560d81859f97f799f456a3bf554","author":{"name":"Galia Kaufman","email":"56105ff1a2f2a5e1c51758c700e5367d26da5747@google.com"},"message":"[Dialogs] Add/update examples for dialog themer (#5158)\n\nAdding and updating existing examples that use the new dialog themer (#5102).\r\nIssue: b/113257098.","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/5b34c0eb3a923560d81859f97f799f456a3bf554"},{"sha":"549d3f87aae8ab6b20abb2b7724bd19a31087b56","author":{"name":"Galia Kaufman","email":"56105ff1a2f2a5e1c51758c700e5367d26da5747@google.com"},"message":"[Dialogs] Customize alert title alignment","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/549d3f87aae8ab6b20abb2b7724bd19a31087b56"},{"sha":"90502d619c5d39d7a31cc483b8cf5ff5eea81cec","author":{"name":"Galia Kaufman","email":"56105ff1a2f2a5e1c51758c700e5367d26da5747@google.com"},"message":"[Dialogs] Alert customization example - title alignment","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/90502d619c5d39d7a31cc483b8cf5ff5eea81cec"},{"sha":"cb926ec0df01d6f1490639ca3d6bf856eedacd3b","author":{"name":"Galia Kaufman","email":"56105ff1a2f2a5e1c51758c700e5367d26da5747@google.com"},"message":"[Dialogs] Customize alert title alignment test","distinct":false,"url":"https://api.github.com/repos/material-components/material-components-ios/commits/cb926ec0df01d6f1490639ca3d6bf856eedacd3b"}]}
{"actor":{"display_login":"galiak11"}}