{"action":"closed","issue":{"url":"https://api.github.com/repos/apollographql/apollo-server/issues/1326","repository_url":"https://api.github.com/repos/apollographql/apollo-server","labels_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1326/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1326/comments","events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1326/events","html_url":"https://github.com/apollographql/apollo-server/issues/1326","id":339806412,"node_id":"MDU6SXNzdWUzMzk4MDY0MTI=","number":1326,"title":"ApolloServer CORS defaults can not be changed","user":{"login":"fcanela","id":1985394,"node_id":"MDQ6VXNlcjE5ODUzOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1985394?v=4","gravatar_id":"","url":"https://api.github.com/users/fcanela","html_url":"https://github.com/fcanela","followers_url":"https://api.github.com/users/fcanela/followers","following_url":"https://api.github.com/users/fcanela/following{/other_user}","gists_url":"https://api.github.com/users/fcanela/gists{/gist_id}","starred_url":"https://api.github.com/users/fcanela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcanela/subscriptions","organizations_url":"https://api.github.com/users/fcanela/orgs","repos_url":"https://api.github.com/users/fcanela/repos","events_url":"https://api.github.com/users/fcanela/events{/privacy}","received_events_url":"https://api.github.com/users/fcanela/received_events","type":"User","site_admin":false},"labels":[{"id":854170689,"node_id":"MDU6TGFiZWw4NTQxNzA2ODk=","url":"https://api.github.com/repos/apollographql/apollo-server/labels/feature","name":"feature","color":"a2eeef","default":false},{"id":854172178,"node_id":"MDU6TGFiZWw4NTQxNzIxNzg=","url":"https://api.github.com/repos/apollographql/apollo-server/labels/has-reproduction","name":"has-reproduction","color":"42f44e","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-10T11:43:58Z","updated_at":"2018-07-11T22:07:00Z","closed_at":"2018-07-11T22:07:00Z","author_association":"NONE","body":"Hello.\r\n\r\nCurrently `apollo-server` inserts  `Access-Control-Allow-Origin: *` by default to ease development (https://github.com/apollographql/apollo-server/blob/version-2/packages/apollo-server/src/index.ts#L77). \r\n\r\nThis defaults seems reasonable but for production and certain configurations you may want to change it. For example, in our company we prefer to manage CORS with a reverse proxy so our API is more secure and IT can perform changes without touching API code.\r\n\r\nCurrently, changing this CORS default seems to be impossible with `apollo-server` (https://github.com/apollographql/apollo-server/issues/1142). As Apollo Server v2 is in Release Candidate we understand this kind of features have not yet implemented.\r\n\r\nI open this issue to enable discussion and know what is the maintainers opinion about CORS management and `apollo-server` v2.\r\n\r\n<!--**Issue Labels**\r\n\r\nWhile not necessary, you can help organize our issues by labeling this issue when you open it.  To add a label automatically, simply [x] mark the appropriate box below:\r\n\r\n- [x] has-reproduction\r\n- [x] feature\r\n- [ ] docs\r\n- [ ] blocking\r\n- [ ] good first issue\r\n\r\nTo add a label not listed above, simply place `/label another-label-name` on a line by itself.\r\n-->"}}
{"actor":{"display_login":"evans"}}