{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/che/pulls/comments/221546472","pull_request_review_id":160217760,"id":221546472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU0NjQ3Mg==","diff_hunk":"@@ -55,19 +56,24 @@\n   private static final Logger LOG = LoggerFactory.getLogger(PluginMetaRetriever.class);\n   private static final String CHE_PLUGIN_OBJECT_ERROR =\n       \"Che plugin '%s:%s' configuration is invalid. %s\";\n-  private static final String PLUGIN_REGISTRY_PROPERTY = \"che.workspace.plugin_registry_url\";\n+  private static final String CHE_REGISTRY_MISSING_ERROR =\n+      String.format(\n+          \"Workspace requested ws.next plugins/editor but plugin registry is not configured. \"","path":"wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/wsplugins/PluginMetaRetriever.java","position":15,"original_position":15,"commit_id":"9c334e8298b46a9848f41f9917c9d91a8f838a4e","original_commit_id":"9c334e8298b46a9848f41f9917c9d91a8f838a4e","user":{"login":"garagatyi","id":1851863,"node_id":"MDQ6VXNlcjE4NTE4NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1851863?v=4","gravatar_id":"","url":"https://api.github.com/users/garagatyi","html_url":"https://github.com/garagatyi","followers_url":"https://api.github.com/users/garagatyi/followers","following_url":"https://api.github.com/users/garagatyi/following{/other_user}","gists_url":"https://api.github.com/users/garagatyi/gists{/gist_id}","starred_url":"https://api.github.com/users/garagatyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garagatyi/subscriptions","organizations_url":"https://api.github.com/users/garagatyi/orgs","repos_url":"https://api.github.com/users/garagatyi/repos","events_url":"https://api.github.com/users/garagatyi/events{/privacy}","received_events_url":"https://api.github.com/users/garagatyi/received_events","type":"User","site_admin":false},"body":"yeah, you are completely right! ","created_at":"2018-10-01T09:34:11Z","updated_at":"2018-10-01T09:34:12Z","html_url":"https://github.com/eclipse/che/pull/11414#discussion_r221546472","pull_request_url":"https://api.github.com/repos/eclipse/che/pulls/11414","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments/221546472"},"html":{"href":"https://github.com/eclipse/che/pull/11414#discussion_r221546472"},"pull_request":{"href":"https://api.github.com/repos/eclipse/che/pulls/11414"}},"in_reply_to_id":221534305},"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/11414","id":219252977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjUyOTc3","html_url":"https://github.com/eclipse/che/pull/11414","diff_url":"https://github.com/eclipse/che/pull/11414.diff","patch_url":"https://github.com/eclipse/che/pull/11414.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/11414","number":11414,"state":"open","locked":false,"title":"Fail workspace start if registry not configured and ws.next plugins requested","user":{"login":"amisevsk","id":16168279,"node_id":"MDQ6VXNlcjE2MTY4Mjc5","avatar_url":"https://avatars1.githubusercontent.com/u/16168279?v=4","gravatar_id":"","url":"https://api.github.com/users/amisevsk","html_url":"https://github.com/amisevsk","followers_url":"https://api.github.com/users/amisevsk/followers","following_url":"https://api.github.com/users/amisevsk/following{/other_user}","gists_url":"https://api.github.com/users/amisevsk/gists{/gist_id}","starred_url":"https://api.github.com/users/amisevsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amisevsk/subscriptions","organizations_url":"https://api.github.com/users/amisevsk/orgs","repos_url":"https://api.github.com/users/amisevsk/repos","events_url":"https://api.github.com/users/amisevsk/events{/privacy}","received_events_url":"https://api.github.com/users/amisevsk/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nFails workspace start if user tries to start workspace with ws.next plugins/editor in Che deployment not configured with plugin registry.\r\n\r\nNotes:\r\n- Note: since commit e53b34b2b1, `che.workspace.plugin_registry_url` has default value in `che.properties`, so not configuring plugin registry is pretty hard unless you manually set env var to `NULL`\r\n- If the property is set but registry is not present / url is invalid, an exception is already thrown (due to http error)\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/eclipse/che/issues/11124","created_at":"2018-10-01T03:48:11Z","updated_at":"2018-10-01T09:34:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26beb1fa5f8ce9976790bc78dd2445551626d51a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benoitf","id":436777,"node_id":"MDQ6VXNlcjQzNjc3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/436777?v=4","gravatar_id":"","url":"https://api.github.com/users/benoitf","html_url":"https://github.com/benoitf","followers_url":"https://api.github.com/users/benoitf/followers","following_url":"https://api.github.com/users/benoitf/following{/other_user}","gists_url":"https://api.github.com/users/benoitf/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitf/subscriptions","organizations_url":"https://api.github.com/users/benoitf/orgs","repos_url":"https://api.github.com/users/benoitf/repos","events_url":"https://api.github.com/users/benoitf/events{/privacy}","received_events_url":"https://api.github.com/users/benoitf/received_events","type":"User","site_admin":false},{"login":"skabashnyuk","id":1614429,"node_id":"MDQ6VXNlcjE2MTQ0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1614429?v=4","gravatar_id":"","url":"https://api.github.com/users/skabashnyuk","html_url":"https://github.com/skabashnyuk","followers_url":"https://api.github.com/users/skabashnyuk/followers","following_url":"https://api.github.com/users/skabashnyuk/following{/other_user}","gists_url":"https://api.github.com/users/skabashnyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/skabashnyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skabashnyuk/subscriptions","organizations_url":"https://api.github.com/users/skabashnyuk/orgs","repos_url":"https://api.github.com/users/skabashnyuk/repos","events_url":"https://api.github.com/users/skabashnyuk/events{/privacy}","received_events_url":"https://api.github.com/users/skabashnyuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":192367926,"node_id":"MDU6TGFiZWwxOTIzNjc5MjY=","url":"https://api.github.com/repos/eclipse/che/labels/kind/bug","name":"kind/bug","color":"fc2929","default":false},{"id":345100523,"node_id":"MDU6TGFiZWwzNDUxMDA1MjM=","url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/11414/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/11414/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/11414/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/9c334e8298b46a9848f41f9917c9d91a8f838a4e","head":{"label":"amisevsk:issue-11124","ref":"issue-11124","sha":"9c334e8298b46a9848f41f9917c9d91a8f838a4e","user":{"login":"amisevsk","id":16168279,"node_id":"MDQ6VXNlcjE2MTY4Mjc5","avatar_url":"https://avatars1.githubusercontent.com/u/16168279?v=4","gravatar_id":"","url":"https://api.github.com/users/amisevsk","html_url":"https://github.com/amisevsk","followers_url":"https://api.github.com/users/amisevsk/followers","following_url":"https://api.github.com/users/amisevsk/following{/other_user}","gists_url":"https://api.github.com/users/amisevsk/gists{/gist_id}","starred_url":"https://api.github.com/users/amisevsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amisevsk/subscriptions","organizations_url":"https://api.github.com/users/amisevsk/orgs","repos_url":"https://api.github.com/users/amisevsk/repos","events_url":"https://api.github.com/users/amisevsk/events{/privacy}","received_events_url":"https://api.github.com/users/amisevsk/received_events","type":"User","site_admin":false},"repo":{"id":68829294,"node_id":"MDEwOlJlcG9zaXRvcnk2ODgyOTI5NA==","name":"che","full_name":"amisevsk/che","private":false,"owner":{"login":"amisevsk","id":16168279,"node_id":"MDQ6VXNlcjE2MTY4Mjc5","avatar_url":"https://avatars1.githubusercontent.com/u/16168279?v=4","gravatar_id":"","url":"https://api.github.com/users/amisevsk","html_url":"https://github.com/amisevsk","followers_url":"https://api.github.com/users/amisevsk/followers","following_url":"https://api.github.com/users/amisevsk/following{/other_user}","gists_url":"https://api.github.com/users/amisevsk/gists{/gist_id}","starred_url":"https://api.github.com/users/amisevsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amisevsk/subscriptions","organizations_url":"https://api.github.com/users/amisevsk/orgs","repos_url":"https://api.github.com/users/amisevsk/repos","events_url":"https://api.github.com/users/amisevsk/events{/privacy}","received_events_url":"https://api.github.com/users/amisevsk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amisevsk/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":true,"url":"https://api.github.com/repos/amisevsk/che","forks_url":"https://api.github.com/repos/amisevsk/che/forks","keys_url":"https://api.github.com/repos/amisevsk/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amisevsk/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amisevsk/che/teams","hooks_url":"https://api.github.com/repos/amisevsk/che/hooks","issue_events_url":"https://api.github.com/repos/amisevsk/che/issues/events{/number}","events_url":"https://api.github.com/repos/amisevsk/che/events","assignees_url":"https://api.github.com/repos/amisevsk/che/assignees{/user}","branches_url":"https://api.github.com/repos/amisevsk/che/branches{/branch}","tags_url":"https://api.github.com/repos/amisevsk/che/tags","blobs_url":"https://api.github.com/repos/amisevsk/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amisevsk/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amisevsk/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/amisevsk/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amisevsk/che/statuses/{sha}","languages_url":"https://api.github.com/repos/amisevsk/che/languages","stargazers_url":"https://api.github.com/repos/amisevsk/che/stargazers","contributors_url":"https://api.github.com/repos/amisevsk/che/contributors","subscribers_url":"https://api.github.com/repos/amisevsk/che/subscribers","subscription_url":"https://api.github.com/repos/amisevsk/che/subscription","commits_url":"https://api.github.com/repos/amisevsk/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/amisevsk/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/amisevsk/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/amisevsk/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/amisevsk/che/contents/{+path}","compare_url":"https://api.github.com/repos/amisevsk/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amisevsk/che/merges","archive_url":"https://api.github.com/repos/amisevsk/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amisevsk/che/downloads","issues_url":"https://api.github.com/repos/amisevsk/che/issues{/number}","pulls_url":"https://api.github.com/repos/amisevsk/che/pulls{/number}","milestones_url":"https://api.github.com/repos/amisevsk/che/milestones{/number}","notifications_url":"https://api.github.com/repos/amisevsk/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amisevsk/che/labels{/name}","releases_url":"https://api.github.com/repos/amisevsk/che/releases{/id}","deployments_url":"https://api.github.com/repos/amisevsk/che/deployments","created_at":"2016-09-21T15:10:13Z","updated_at":"2018-09-28T21:58:51Z","pushed_at":"2018-10-01T03:43:21Z","git_url":"git://github.com/amisevsk/che.git","ssh_url":"git@github.com:amisevsk/che.git","clone_url":"https://github.com/amisevsk/che.git","svn_url":"https://github.com/amisevsk/che","homepage":"http://eclipse.org/che","size":89944,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"77a6f574878001f290afae8fb5515b731061d27d","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkzNTc0NQ==","name":"che","full_name":"eclipse/che","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2018-10-01T09:27:16Z","pushed_at":"2018-10-01T09:30:25Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":99439,"stargazers_count":5051,"watchers_count":5051,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":909,"mirror_url":null,"archived":false,"open_issues_count":893,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":909,"open_issues":893,"watchers":5051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/11414"},"html":{"href":"https://github.com/eclipse/che/pull/11414"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/11414"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/11414/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/11414/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/11414/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/9c334e8298b46a9848f41f9917c9d91a8f838a4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garagatyi"}}