{"action":"created","issue":{"url":"https://api.github.com/repos/Kruptein/PlanarAlly/issues/79","repository_url":"https://api.github.com/repos/Kruptein/PlanarAlly","labels_url":"https://api.github.com/repos/Kruptein/PlanarAlly/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/Kruptein/PlanarAlly/issues/79/comments","events_url":"https://api.github.com/repos/Kruptein/PlanarAlly/issues/79/events","html_url":"https://github.com/Kruptein/PlanarAlly/pull/79","id":367418609,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODYxNjc4","number":79,"title":"Add asset rotation support","user":{"login":"W8BSD","id":7404267,"node_id":"MDQ6VXNlcjc0MDQyNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/7404267?v=4","gravatar_id":"","url":"https://api.github.com/users/W8BSD","html_url":"https://github.com/W8BSD","followers_url":"https://api.github.com/users/W8BSD/followers","following_url":"https://api.github.com/users/W8BSD/following{/other_user}","gists_url":"https://api.github.com/users/W8BSD/gists{/gist_id}","starred_url":"https://api.github.com/users/W8BSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/W8BSD/subscriptions","organizations_url":"https://api.github.com/users/W8BSD/orgs","repos_url":"https://api.github.com/users/W8BSD/repos","events_url":"https://api.github.com/users/W8BSD/events{/privacy}","received_events_url":"https://api.github.com/users/W8BSD/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-06T03:21:22Z","updated_at":"2018-10-08T11:15:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Kruptein/PlanarAlly/pulls/79","html_url":"https://github.com/Kruptein/PlanarAlly/pull/79","diff_url":"https://github.com/Kruptein/PlanarAlly/pull/79.diff","patch_url":"https://github.com/Kruptein/PlanarAlly/pull/79.patch"},"body":"This allows for using tile sets for building maps.  Currently can only\r\nrotate 90 degrees in either direction.\r\n\r\nMake sure to do your PR on the `dev` branch and NOT on the `master` branch.  This repo uses gitflow which only uses the master branch as a release branch.\r\n\r\nMake sure to update the `CHANGELOG`."},"comment":{"url":"https://api.github.com/repos/Kruptein/PlanarAlly/issues/comments/427796888","html_url":"https://github.com/Kruptein/PlanarAlly/pull/79#issuecomment-427796888","issue_url":"https://api.github.com/repos/Kruptein/PlanarAlly/issues/79","id":427796888,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzc5Njg4OA==","user":{"login":"Kruptein","id":1814713,"node_id":"MDQ6VXNlcjE4MTQ3MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1814713?v=4","gravatar_id":"","url":"https://api.github.com/users/Kruptein","html_url":"https://github.com/Kruptein","followers_url":"https://api.github.com/users/Kruptein/followers","following_url":"https://api.github.com/users/Kruptein/following{/other_user}","gists_url":"https://api.github.com/users/Kruptein/gists{/gist_id}","starred_url":"https://api.github.com/users/Kruptein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kruptein/subscriptions","organizations_url":"https://api.github.com/users/Kruptein/orgs","repos_url":"https://api.github.com/users/Kruptein/repos","events_url":"https://api.github.com/users/Kruptein/events{/privacy}","received_events_url":"https://api.github.com/users/Kruptein/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T11:15:51Z","updated_at":"2018-10-08T11:15:51Z","author_association":"OWNER","body":"Some remarks:\r\n\r\n* The type field is protected on Shape, which results in typescript errors in your shapecontext.vue changes.  By changing the type === 'asset' check to an instanceof Asset check, these errors are gone and also immediately make sure that 'angle' actually exists on the shape object.\r\n* Your rotations are currently not synced to the server, which means that other players won't see your changes and a reload will also reset the rotation.  You'll want to use  `socket.emit(\"updateShape\", { shape: shape.asDict(), true });` the second argument tells the server whether the shape change requires a redraw which it does in this case"}}
{"actor":{"display_login":"Kruptein"}}