{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/13538","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/13538/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13538/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/13538/events","html_url":"https://github.com/highfidelity/hifi/pull/13538","id":338033639,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDY3NDQ1","number":13538,"title":"Edit handle undefined event fix","user":{"login":"dback2","id":31390055,"node_id":"MDQ6VXNlcjMxMzkwMDU1","avatar_url":"https://avatars3.githubusercontent.com/u/31390055?v=4","gravatar_id":"","url":"https://api.github.com/users/dback2","html_url":"https://github.com/dback2","followers_url":"https://api.github.com/users/dback2/followers","following_url":"https://api.github.com/users/dback2/following{/other_user}","gists_url":"https://api.github.com/users/dback2/gists{/gist_id}","starred_url":"https://api.github.com/users/dback2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dback2/subscriptions","organizations_url":"https://api.github.com/users/dback2/orgs","repos_url":"https://api.github.com/users/dback2/repos","events_url":"https://api.github.com/users/dback2/events{/privacy}","received_events_url":"https://api.github.com/users/dback2/received_events","type":"User","site_admin":false},"labels":[{"id":751510477,"node_id":"MDU6TGFiZWw3NTE1MTA0Nzc=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Create","name":"Create","color":"e288db","default":false},{"id":807119861,"node_id":"MDU6TGFiZWw4MDcxMTk4NjE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Mac%20Required","name":"Mac Required","color":"d4c5f9","default":false},{"id":314155316,"node_id":"MDU6TGFiZWwzMTQxNTUzMTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Approved%20:tada:","name":"QA Approved :tada:","color":"009800","default":false},{"id":11332862,"node_id":"MDU6TGFiZWwxMTMzMjg2Mg==","url":"https://api.github.com/repos/highfidelity/hifi/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/30","html_url":"https://github.com/highfidelity/hifi/milestone/30","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/30/labels","id":3290828,"node_id":"MDk6TWlsZXN0b25lMzI5MDgyOA==","number":30,"title":"RC70","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":119,"state":"open","created_at":"2018-04-23T19:27:01Z","updated_at":"2018-07-05T16:50:07Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2018-07-03T19:52:42Z","updated_at":"2018-07-05T17:07:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13538","html_url":"https://github.com/highfidelity/hifi/pull/13538","diff_url":"https://github.com/highfidelity/hifi/pull/13538.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13538.patch"},"body":"Don't handle any edit handle movements if the passed in event has undefined x or y.\r\n\r\nFixes: https://highfidelity.manuscript.com/f/cases/16203\r\nas well as other unexpected edit handle behavior at low framerates\r\n\r\nTest Plan:\r\n-Enter Interface in desktop mode on Mac\r\n-Go to sandbox and stand directly in front of the first moving tutorial placards (as shown in the video in the above bug)\r\n-In Create make a Cube entity and ensure it is selected\r\n-Select the scale corner cubes on the Cube entity and release them in place several times, ensuring cube stays at the same starting dimensions and avatar stays in place (this was the bug - cube dimensions in this case would become super huge and push the avatar outward before this change)\r\n-Select the scale corner cubes on the Cube entity and scale it upward and downward several times, ensuring cube remains at the expected dimensions and avatar stays in place\r\n-Verify there is no unexpected behavior (such as non-smooth/sudden entity changes that aren't related to low framerate) when using any of the translation arrows, rotation rings, and stretch cubes several times each\r\n-Repeat above steps in desktop mode on PC and ensure all edit handles continue to work as expected"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/402790495","html_url":"https://github.com/highfidelity/hifi/pull/13538#issuecomment-402790495","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13538","id":402790495,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjc5MDQ5NQ==","user":{"login":"hifi-gustavo","id":4554450,"node_id":"MDQ6VXNlcjQ1NTQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T17:07:33Z","updated_at":"2018-07-05T17:07:33Z","author_association":"NONE","body":"Android build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dandroid/11128/HighFidelity-Beta-PR13538-2e70853.apk"}}
{"actor":{"display_login":"hifi-gustavo"}}