{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/230654305","pull_request_review_id":171434200,"id":230654305,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDY1NDMwNQ==","diff_hunk":"@@ -60,6 +61,15 @@ func (s *udevMonitorSuite) TestDiscovery(c *C) {\n \t\tremInfo = inf\n \t\tcallbackChannel <- struct{}{}\n \t}\n+\tdone := func() {","path":"overlord/ifacestate/udevmonitor/udevmon_test.go","position":21,"original_position":21,"commit_id":"d0869b0ea0621718f845a9ecdb52b8fe3ff765d7","original_commit_id":"d0869b0ea0621718f845a9ecdb52b8fe3ff765d7","user":{"login":"mvo5","id":914418,"node_id":"MDQ6VXNlcjkxNDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"body":"(nitpick) would be nice to call this \"enumerateDone\" - when I looked at this I though we could change the code here to only look at done but this test also simulates hotplugs after the enumeration was done. So a slightly different name would probably have given me the extra context :)","created_at":"2018-11-05T07:41:22Z","updated_at":"2018-11-05T07:41:41Z","html_url":"https://github.com/snapcore/snapd/pull/6072#discussion_r230654305","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/6072","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/230654305"},"html":{"href":"https://github.com/snapcore/snapd/pull/6072#discussion_r230654305"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6072"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/6072","id":226965199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTY1MTk5","html_url":"https://github.com/snapcore/snapd/pull/6072","diff_url":"https://github.com/snapcore/snapd/pull/6072.diff","patch_url":"https://github.com/snapcore/snapd/pull/6072.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/6072","number":6072,"state":"open","locked":false,"title":"ifacestate/udevmonitor: added callback to signal end of enumeration","user":{"login":"stolowski","id":168604,"node_id":"MDQ6VXNlcjE2ODYwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"body":"This PR adds a callback to signal the end of initial enumeration of devices (via udevadm) to interface manager. This is required to know when to compute the \"delta\" between currently present devices and the past (not in this PR).\r\nAlso made the two existing ifacemgr hotplug callbacks private as they don't need to be exported.\r\n","created_at":"2018-10-30T15:17:49Z","updated_at":"2018-11-05T07:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6697145db58685c93e6364e36ce895aa67a0ad25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1026148731,"node_id":"MDU6TGFiZWwxMDI2MTQ4NzMx","url":"https://api.github.com/repos/snapcore/snapd/labels/Hotplug%20%F0%9F%94%8C","name":"Hotplug 🔌","color":"ecef8b","default":false},{"id":912422407,"node_id":"MDU6TGFiZWw5MTI0MjI0MDc=","url":"https://api.github.com/repos/snapcore/snapd/labels/Simple%20%F0%9F%98%83","name":"Simple 😃","color":"90ed34","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/6072/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/6072/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/6072/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/d0869b0ea0621718f845a9ecdb52b8fe3ff765d7","head":{"label":"stolowski:udevmon-enumeration-done","ref":"udevmon-enumeration-done","sha":"d0869b0ea0621718f845a9ecdb52b8fe3ff765d7","user":{"login":"stolowski","id":168604,"node_id":"MDQ6VXNlcjE2ODYwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"repo":{"id":66472850,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ3Mjg1MA==","name":"snapd","full_name":"stolowski/snapd","private":false,"owner":{"login":"stolowski","id":168604,"node_id":"MDQ6VXNlcjE2ODYwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stolowski/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/stolowski/snapd","forks_url":"https://api.github.com/repos/stolowski/snapd/forks","keys_url":"https://api.github.com/repos/stolowski/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stolowski/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stolowski/snapd/teams","hooks_url":"https://api.github.com/repos/stolowski/snapd/hooks","issue_events_url":"https://api.github.com/repos/stolowski/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/stolowski/snapd/events","assignees_url":"https://api.github.com/repos/stolowski/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/stolowski/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/stolowski/snapd/tags","blobs_url":"https://api.github.com/repos/stolowski/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stolowski/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stolowski/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stolowski/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stolowski/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/stolowski/snapd/languages","stargazers_url":"https://api.github.com/repos/stolowski/snapd/stargazers","contributors_url":"https://api.github.com/repos/stolowski/snapd/contributors","subscribers_url":"https://api.github.com/repos/stolowski/snapd/subscribers","subscription_url":"https://api.github.com/repos/stolowski/snapd/subscription","commits_url":"https://api.github.com/repos/stolowski/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stolowski/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stolowski/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stolowski/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stolowski/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/stolowski/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stolowski/snapd/merges","archive_url":"https://api.github.com/repos/stolowski/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stolowski/snapd/downloads","issues_url":"https://api.github.com/repos/stolowski/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/stolowski/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/stolowski/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/stolowski/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stolowski/snapd/labels{/name}","releases_url":"https://api.github.com/repos/stolowski/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/stolowski/snapd/deployments","created_at":"2016-08-24T14:50:18Z","updated_at":"2016-08-24T14:50:21Z","pushed_at":"2018-11-02T15:01:16Z","git_url":"git://github.com/stolowski/snapd.git","ssh_url":"git@github.com:stolowski/snapd.git","clone_url":"https://github.com/stolowski/snapd.git","svn_url":"https://github.com/stolowski/snapd","homepage":"","size":76163,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"71c69f789988bc54ecd17f0863eb36c8d6aad0ca","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-11-05T07:39:33Z","pushed_at":"2018-11-05T07:39:26Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":75013,"stargazers_count":1038,"watchers_count":1038,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":261,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":261,"open_issues":31,"watchers":1038,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6072"},"html":{"href":"https://github.com/snapcore/snapd/pull/6072"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6072"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6072/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6072/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6072/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/d0869b0ea0621718f845a9ecdb52b8fe3ff765d7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mvo5"}}