{"action":"opened","number":82,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/82","id":228240754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjQwNzU0","html_url":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/82","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/82.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/82.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues/82","number":82,"state":"open","locked":false,"title":"Fix small errors of cloud-pubsub made from #81 ","user":{"login":"lonyele","id":15892571,"node_id":"MDQ6VXNlcjE1ODkyNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/15892571?v=4","gravatar_id":"","url":"https://api.github.com/users/lonyele","html_url":"https://github.com/lonyele","followers_url":"https://api.github.com/users/lonyele/followers","following_url":"https://api.github.com/users/lonyele/following{/other_user}","gists_url":"https://api.github.com/users/lonyele/gists{/gist_id}","starred_url":"https://api.github.com/users/lonyele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonyele/subscriptions","organizations_url":"https://api.github.com/users/lonyele/orgs","repos_url":"https://api.github.com/users/lonyele/repos","events_url":"https://api.github.com/users/lonyele/events{/privacy}","received_events_url":"https://api.github.com/users/lonyele/received_events","type":"User","site_admin":false},"body":"As #81 upgrading the apiVersion, I got this error when `kubectl create -f pubsub.yaml`   --> `error validating data: ValidationError(Deployment.spec):ent.spec): missing required field \"selector\" in io.k8s.api.apps.v1.DeploymentSpec`\r\n\r\nIt seems like It has to explicitly match labels from this version. I just added the field. Also It's not a problem for now, but there is a typo on `main.py`. It seems like the image on gcr is built on top of fixed typo version. ","created_at":"2018-11-05T04:55:08Z","updated_at":"2018-11-05T04:55:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/82/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/82/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues/82/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/statuses/70e342398e84b1c850f66b1a2696589edb476c0b","head":{"label":"lonyele:master","ref":"master","sha":"70e342398e84b1c850f66b1a2696589edb476c0b","user":{"login":"lonyele","id":15892571,"node_id":"MDQ6VXNlcjE1ODkyNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/15892571?v=4","gravatar_id":"","url":"https://api.github.com/users/lonyele","html_url":"https://github.com/lonyele","followers_url":"https://api.github.com/users/lonyele/followers","following_url":"https://api.github.com/users/lonyele/following{/other_user}","gists_url":"https://api.github.com/users/lonyele/gists{/gist_id}","starred_url":"https://api.github.com/users/lonyele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonyele/subscriptions","organizations_url":"https://api.github.com/users/lonyele/orgs","repos_url":"https://api.github.com/users/lonyele/repos","events_url":"https://api.github.com/users/lonyele/events{/privacy}","received_events_url":"https://api.github.com/users/lonyele/received_events","type":"User","site_admin":false},"repo":{"id":156161017,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxNjEwMTc=","name":"kubernetes-engine-samples","full_name":"lonyele/kubernetes-engine-samples","private":false,"owner":{"login":"lonyele","id":15892571,"node_id":"MDQ6VXNlcjE1ODkyNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/15892571?v=4","gravatar_id":"","url":"https://api.github.com/users/lonyele","html_url":"https://github.com/lonyele","followers_url":"https://api.github.com/users/lonyele/followers","following_url":"https://api.github.com/users/lonyele/following{/other_user}","gists_url":"https://api.github.com/users/lonyele/gists{/gist_id}","starred_url":"https://api.github.com/users/lonyele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonyele/subscriptions","organizations_url":"https://api.github.com/users/lonyele/orgs","repos_url":"https://api.github.com/users/lonyele/repos","events_url":"https://api.github.com/users/lonyele/events{/privacy}","received_events_url":"https://api.github.com/users/lonyele/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lonyele/kubernetes-engine-samples","description":"Sample applications for Google Kubernetes Engine (GKE)","fork":true,"url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples","forks_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/forks","keys_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/teams","hooks_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/hooks","issue_events_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/issues/events{/number}","events_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/events","assignees_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/assignees{/user}","branches_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/branches{/branch}","tags_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/tags","blobs_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/languages","stargazers_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/stargazers","contributors_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/contributors","subscribers_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/subscribers","subscription_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/subscription","commits_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/contents/{+path}","compare_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/merges","archive_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/downloads","issues_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/issues{/number}","pulls_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/labels{/name}","releases_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/releases{/id}","deployments_url":"https://api.github.com/repos/lonyele/kubernetes-engine-samples/deployments","created_at":"2018-11-05T04:32:49Z","updated_at":"2018-11-05T04:46:27Z","pushed_at":"2018-11-05T04:46:25Z","git_url":"git://github.com/lonyele/kubernetes-engine-samples.git","ssh_url":"git@github.com:lonyele/kubernetes-engine-samples.git","clone_url":"https://github.com/lonyele/kubernetes-engine-samples.git","svn_url":"https://github.com/lonyele/kubernetes-engine-samples","homepage":"https://cloud.google.com/kubernetes-engine/docs/tutorials/","size":386,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"a26e90eebf40f938e40647ca301047ae575fa16e","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54142870,"node_id":"MDEwOlJlcG9zaXRvcnk1NDE0Mjg3MA==","name":"kubernetes-engine-samples","full_name":"GoogleCloudPlatform/kubernetes-engine-samples","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples","description":"Sample applications for Google Kubernetes Engine (GKE)","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/deployments","created_at":"2016-03-17T18:40:42Z","updated_at":"2018-11-05T01:45:41Z","pushed_at":"2018-10-23T00:52:11Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes-engine-samples.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes-engine-samples.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples","homepage":"https://cloud.google.com/kubernetes-engine/docs/tutorials/","size":386,"stargazers_count":273,"watchers_count":273,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":241,"open_issues":8,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/82"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/82"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues/82"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes-engine-samples/statuses/70e342398e84b1c850f66b1a2696589edb476c0b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":7,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"lonyele"}}