{"action":"closed","number":54533,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/54533","id":217701819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzAxODE5","html_url":"https://github.com/rust-lang/rust/pull/54533","diff_url":"https://github.com/rust-lang/rust/pull/54533.diff","patch_url":"https://github.com/rust-lang/rust/pull/54533.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/54533","number":54533,"state":"closed","locked":false,"title":"A few cleanups and minor improvements to typeck/check","user":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"body":"- turn a `loop` into a `while let`\r\n- turn a `push_back` loop into an `extend`\r\n- turn a few `push` loops into collected iterators\r\n- prefer `vec![x; n]` to `(0..n).map(|_| x).collect()`\r\n- combine two loops doing the same thing on 2 data sets using `chain`\r\n- use `unwrap_or` where applicable and readable\r\n- add a `potentially_plural_count` helper function to simplify several `format!()` calls\r\n- prefer `to_owned` to `to_string` for string literals\r\n- change `match` to `if let` where only one branch matters\r\n- a few other minor improvements\r\n- whitespace fixes","created_at":"2018-09-24T15:44:29Z","updated_at":"2018-09-27T19:27:15Z","closed_at":"2018-09-27T19:27:15Z","merged_at":"2018-09-27T19:27:15Z","merge_commit_sha":"3527276dba98a307976f58e269a5b193d6b8194b","assignee":{"login":"davidtwco","id":1295100,"node_id":"MDQ6VXNlcjEyOTUxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1295100?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtwco","html_url":"https://github.com/davidtwco","followers_url":"https://api.github.com/users/davidtwco/followers","following_url":"https://api.github.com/users/davidtwco/following{/other_user}","gists_url":"https://api.github.com/users/davidtwco/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtwco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtwco/subscriptions","organizations_url":"https://api.github.com/users/davidtwco/orgs","repos_url":"https://api.github.com/users/davidtwco/repos","events_url":"https://api.github.com/users/davidtwco/events{/privacy}","received_events_url":"https://api.github.com/users/davidtwco/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidtwco","id":1295100,"node_id":"MDQ6VXNlcjEyOTUxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1295100?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtwco","html_url":"https://github.com/davidtwco","followers_url":"https://api.github.com/users/davidtwco/followers","following_url":"https://api.github.com/users/davidtwco/following{/other_user}","gists_url":"https://api.github.com/users/davidtwco/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtwco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtwco/subscriptions","organizations_url":"https://api.github.com/users/davidtwco/orgs","repos_url":"https://api.github.com/users/davidtwco/repos","events_url":"https://api.github.com/users/davidtwco/events{/privacy}","received_events_url":"https://api.github.com/users/davidtwco/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583437191,"node_id":"MDU6TGFiZWw1ODM0MzcxOTE=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/54533/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/54533/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/54533/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/3527276dba98a307976f58e269a5b193d6b8194b","head":{"label":"ljedrz:cleanup_librustc_typeck_check","ref":"cleanup_librustc_typeck_check","sha":"3527276dba98a307976f58e269a5b193d6b8194b","user":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"repo":{"id":138298132,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyOTgxMzI=","name":"rust-1","full_name":"ljedrz/rust-1","private":false,"owner":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ljedrz/rust-1","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/ljedrz/rust-1","forks_url":"https://api.github.com/repos/ljedrz/rust-1/forks","keys_url":"https://api.github.com/repos/ljedrz/rust-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljedrz/rust-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljedrz/rust-1/teams","hooks_url":"https://api.github.com/repos/ljedrz/rust-1/hooks","issue_events_url":"https://api.github.com/repos/ljedrz/rust-1/issues/events{/number}","events_url":"https://api.github.com/repos/ljedrz/rust-1/events","assignees_url":"https://api.github.com/repos/ljedrz/rust-1/assignees{/user}","branches_url":"https://api.github.com/repos/ljedrz/rust-1/branches{/branch}","tags_url":"https://api.github.com/repos/ljedrz/rust-1/tags","blobs_url":"https://api.github.com/repos/ljedrz/rust-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljedrz/rust-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljedrz/rust-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljedrz/rust-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljedrz/rust-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ljedrz/rust-1/languages","stargazers_url":"https://api.github.com/repos/ljedrz/rust-1/stargazers","contributors_url":"https://api.github.com/repos/ljedrz/rust-1/contributors","subscribers_url":"https://api.github.com/repos/ljedrz/rust-1/subscribers","subscription_url":"https://api.github.com/repos/ljedrz/rust-1/subscription","commits_url":"https://api.github.com/repos/ljedrz/rust-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljedrz/rust-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljedrz/rust-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljedrz/rust-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljedrz/rust-1/contents/{+path}","compare_url":"https://api.github.com/repos/ljedrz/rust-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljedrz/rust-1/merges","archive_url":"https://api.github.com/repos/ljedrz/rust-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljedrz/rust-1/downloads","issues_url":"https://api.github.com/repos/ljedrz/rust-1/issues{/number}","pulls_url":"https://api.github.com/repos/ljedrz/rust-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ljedrz/rust-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ljedrz/rust-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljedrz/rust-1/labels{/name}","releases_url":"https://api.github.com/repos/ljedrz/rust-1/releases{/id}","deployments_url":"https://api.github.com/repos/ljedrz/rust-1/deployments","created_at":"2018-06-22T12:05:10Z","updated_at":"2018-07-13T09:38:34Z","pushed_at":"2018-09-27T08:18:45Z","git_url":"git://github.com/ljedrz/rust-1.git","ssh_url":"git@github.com:ljedrz/rust-1.git","clone_url":"https://github.com/ljedrz/rust-1.git","svn_url":"https://github.com/ljedrz/rust-1","homepage":"https://www.rust-lang.org","size":394359,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"441519536c8bd138e8c651743249acd6814747a1","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-09-27T16:55:43Z","pushed_at":"2018-09-27T19:27:04Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":394924,"stargazers_count":30876,"watchers_count":30876,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5202,"mirror_url":null,"archived":false,"open_issues_count":4371,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5202,"open_issues":4371,"watchers":30876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54533"},"html":{"href":"https://github.com/rust-lang/rust/pull/54533"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/54533"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/54533/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54533/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54533/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/3527276dba98a307976f58e269a5b193d6b8194b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"node_id":"MDQ6VXNlcjMzNzIzNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":20,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":450,"deletions":581,"changed_files":19}}
{"actor":{"display_login":"bors"}}