{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/229871224","pull_request_review_id":170476660,"id":229871224,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg3MTIyNA==","diff_hunk":"@@ -156,10 +156,10 @@ public struct DateInterval : ReferenceConvertible, Comparable, Hashable, Codable\n     }\n     \n     public var hashValue: Int {\n-        var buf: (UInt, UInt) = (UInt(start.timeIntervalSinceReferenceDate), UInt(end.timeIntervalSinceReferenceDate))\n+        var buf: (TimeInterval, TimeInterval) = (start.timeIntervalSinceReferenceDate, end.timeIntervalSinceReferenceDate)\n         return withUnsafeMutablePointer(to: &buf) {\n-            $0.withMemoryRebound(to: UInt8.self, capacity: 2 * MemoryLayout<UInt>.size / MemoryLayout<UInt8>.size) {\n-                return Int(bitPattern: CFHashBytes($0, CFIndex(MemoryLayout<UInt>.size * 2)))\n+            $0.withMemoryRebound(to: UInt8.self, capacity: 2 * MemoryLayout<TimeInterval>.size / MemoryLayout<UInt8>.size) {","path":"stdlib/public/SDK/Foundation/DateInterval.swift","position":9,"original_position":9,"commit_id":"ca14b866bd6bfc2534db3492f36a5b29ca890b87","original_commit_id":"ca14b866bd6bfc2534db3492f36a5b29ca890b87","user":{"login":"moiseev","id":64011,"node_id":"MDQ6VXNlcjY0MDEx","avatar_url":"https://avatars3.githubusercontent.com/u/64011?v=4","gravatar_id":"","url":"https://api.github.com/users/moiseev","html_url":"https://github.com/moiseev","followers_url":"https://api.github.com/users/moiseev/followers","following_url":"https://api.github.com/users/moiseev/following{/other_user}","gists_url":"https://api.github.com/users/moiseev/gists{/gist_id}","starred_url":"https://api.github.com/users/moiseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moiseev/subscriptions","organizations_url":"https://api.github.com/users/moiseev/orgs","repos_url":"https://api.github.com/users/moiseev/repos","events_url":"https://api.github.com/users/moiseev/events{/privacy}","received_events_url":"https://api.github.com/users/moiseev/received_events","type":"User","site_admin":false},"body":"https://github.com/apple/swift/blob/master/test/stdlib/TestDateInterval.swift, too.","created_at":"2018-10-31T21:17:32Z","updated_at":"2018-10-31T21:17:32Z","html_url":"https://github.com/apple/swift/pull/20106#discussion_r229871224","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/20106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/229871224"},"html":{"href":"https://github.com/apple/swift/pull/20106#discussion_r229871224"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/20106"}},"in_reply_to_id":229459804},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/20106","id":226300221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzAwMjIx","html_url":"https://github.com/apple/swift/pull/20106","diff_url":"https://github.com/apple/swift/pull/20106.diff","patch_url":"https://github.com/apple/swift/pull/20106.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/20106","number":20106,"state":"open","locked":false,"title":"Fix crash with `DateInterval`.","user":{"login":"kzaher","id":1641148,"node_id":"MDQ6VXNlcjE2NDExNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1641148?v=4","gravatar_id":"","url":"https://api.github.com/users/kzaher","html_url":"https://github.com/kzaher","followers_url":"https://api.github.com/users/kzaher/followers","following_url":"https://api.github.com/users/kzaher/following{/other_user}","gists_url":"https://api.github.com/users/kzaher/gists{/gist_id}","starred_url":"https://api.github.com/users/kzaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzaher/subscriptions","organizations_url":"https://api.github.com/users/kzaher/orgs","repos_url":"https://api.github.com/users/kzaher/repos","events_url":"https://api.github.com/users/kzaher/events{/privacy}","received_events_url":"https://api.github.com/users/kzaher/received_events","type":"User","site_admin":false},"body":"Fixes crash with DateInterval.\r\n\r\nSteps to repro:\r\n```\r\nDateInterval(start: Date(timeIntervalSince1970: 0.0), end: Date(timeIntervalSince1970: 0.0)).hashValue\r\n```\r\n\r\n@swift-ci Please smoke test","created_at":"2018-10-27T14:57:07Z","updated_at":"2018-10-31T21:17:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ca7a8cd12cb6c98be0d092af259f04e1c534e3a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"millenomi","id":44005,"node_id":"MDQ6VXNlcjQ0MDA1","avatar_url":"https://avatars0.githubusercontent.com/u/44005?v=4","gravatar_id":"","url":"https://api.github.com/users/millenomi","html_url":"https://github.com/millenomi","followers_url":"https://api.github.com/users/millenomi/followers","following_url":"https://api.github.com/users/millenomi/following{/other_user}","gists_url":"https://api.github.com/users/millenomi/gists{/gist_id}","starred_url":"https://api.github.com/users/millenomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millenomi/subscriptions","organizations_url":"https://api.github.com/users/millenomi/orgs","repos_url":"https://api.github.com/users/millenomi/repos","events_url":"https://api.github.com/users/millenomi/events{/privacy}","received_events_url":"https://api.github.com/users/millenomi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/20106/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/20106/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/20106/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/ca14b866bd6bfc2534db3492f36a5b29ca890b87","head":{"label":"kzaher:master","ref":"master","sha":"ca14b866bd6bfc2534db3492f36a5b29ca890b87","user":{"login":"kzaher","id":1641148,"node_id":"MDQ6VXNlcjE2NDExNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1641148?v=4","gravatar_id":"","url":"https://api.github.com/users/kzaher","html_url":"https://github.com/kzaher","followers_url":"https://api.github.com/users/kzaher/followers","following_url":"https://api.github.com/users/kzaher/following{/other_user}","gists_url":"https://api.github.com/users/kzaher/gists{/gist_id}","starred_url":"https://api.github.com/users/kzaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzaher/subscriptions","organizations_url":"https://api.github.com/users/kzaher/orgs","repos_url":"https://api.github.com/users/kzaher/repos","events_url":"https://api.github.com/users/kzaher/events{/privacy}","received_events_url":"https://api.github.com/users/kzaher/received_events","type":"User","site_admin":false},"repo":{"id":47345919,"node_id":"MDEwOlJlcG9zaXRvcnk0NzM0NTkxOQ==","name":"swift","full_name":"kzaher/swift","private":false,"owner":{"login":"kzaher","id":1641148,"node_id":"MDQ6VXNlcjE2NDExNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1641148?v=4","gravatar_id":"","url":"https://api.github.com/users/kzaher","html_url":"https://github.com/kzaher","followers_url":"https://api.github.com/users/kzaher/followers","following_url":"https://api.github.com/users/kzaher/following{/other_user}","gists_url":"https://api.github.com/users/kzaher/gists{/gist_id}","starred_url":"https://api.github.com/users/kzaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzaher/subscriptions","organizations_url":"https://api.github.com/users/kzaher/orgs","repos_url":"https://api.github.com/users/kzaher/repos","events_url":"https://api.github.com/users/kzaher/events{/privacy}","received_events_url":"https://api.github.com/users/kzaher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kzaher/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/kzaher/swift","forks_url":"https://api.github.com/repos/kzaher/swift/forks","keys_url":"https://api.github.com/repos/kzaher/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kzaher/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kzaher/swift/teams","hooks_url":"https://api.github.com/repos/kzaher/swift/hooks","issue_events_url":"https://api.github.com/repos/kzaher/swift/issues/events{/number}","events_url":"https://api.github.com/repos/kzaher/swift/events","assignees_url":"https://api.github.com/repos/kzaher/swift/assignees{/user}","branches_url":"https://api.github.com/repos/kzaher/swift/branches{/branch}","tags_url":"https://api.github.com/repos/kzaher/swift/tags","blobs_url":"https://api.github.com/repos/kzaher/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kzaher/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kzaher/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/kzaher/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kzaher/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/kzaher/swift/languages","stargazers_url":"https://api.github.com/repos/kzaher/swift/stargazers","contributors_url":"https://api.github.com/repos/kzaher/swift/contributors","subscribers_url":"https://api.github.com/repos/kzaher/swift/subscribers","subscription_url":"https://api.github.com/repos/kzaher/swift/subscription","commits_url":"https://api.github.com/repos/kzaher/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/kzaher/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/kzaher/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/kzaher/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/kzaher/swift/contents/{+path}","compare_url":"https://api.github.com/repos/kzaher/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kzaher/swift/merges","archive_url":"https://api.github.com/repos/kzaher/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kzaher/swift/downloads","issues_url":"https://api.github.com/repos/kzaher/swift/issues{/number}","pulls_url":"https://api.github.com/repos/kzaher/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/kzaher/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/kzaher/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kzaher/swift/labels{/name}","releases_url":"https://api.github.com/repos/kzaher/swift/releases{/id}","deployments_url":"https://api.github.com/repos/kzaher/swift/deployments","created_at":"2015-12-03T16:47:43Z","updated_at":"2018-10-27T14:59:20Z","pushed_at":"2018-10-27T14:59:17Z","git_url":"git://github.com/kzaher/swift.git","ssh_url":"git@github.com:kzaher/swift.git","clone_url":"https://github.com/kzaher/swift.git","svn_url":"https://github.com/kzaher/swift","homepage":"","size":319342,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"1982d024a93b3246edecf6bf42530a835ffc479f","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-10-31T21:12:10Z","pushed_at":"2018-10-31T21:15:22Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":358116,"stargazers_count":45649,"watchers_count":45649,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7240,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7240,"open_issues":425,"watchers":45649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/20106"},"html":{"href":"https://github.com/apple/swift/pull/20106"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/20106"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/20106/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/20106/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/20106/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/ca14b866bd6bfc2534db3492f36a5b29ca890b87"}},"author_association":"NONE"}}
{"actor":{"display_login":"moiseev"}}