{"push_id":2759736615,"size":1,"distinct_size":1,"ref":"refs/heads/async-peer-start","head":"976bdd45b1c0905dcd30b0bd783da2c7c9cd1fbe","before":"ea2cda55f1d6b5eb14edaf3e6a4c2cf264fc95f6","commits":[{"sha":"976bdd45b1c0905dcd30b0bd783da2c7c9cd1fbe","author":{"name":"Conner Fromknecht","email":"88caef71c5fc50c400c509a91fcde24c4907f749@lightning.engineering"},"message":"server: add async peer Start() + safer cleanup\n\nThis commit adds asynchronous starting of peers,\nin order to avoid potential DOS vectors. Currently,\nwe block with the server's mutex while peers exchange\nInit messages and perform other setup. Thus, a remote\npeer that does not reply with an init message will\ncause server to block for 15s per attempt.\n\nWe also modify the startup behavior to spawn\npeerTerminationWatchers before starting the\npeer itself, ensuring that a peer is properly\ncleaned up if the initialization fails. Currently,\nfailing to start a peer does not execute the bulk\nof the teardown logic, since it is not spawned\nuntil after a successful Start occurs.","distinct":true,"url":"https://api.github.com/repos/cfromknecht/lnd/commits/976bdd45b1c0905dcd30b0bd783da2c7c9cd1fbe"}]}
{"actor":{"display_login":"cfromknecht"}}