{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/209461578","pull_request_review_id":145480708,"id":209461578,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ2MTU3OA==","diff_hunk":"@@ -465,7 +471,7 @@ seastar::future<> SocketConnection::handle_connect()\n       }\n       h.connect_seq = h.connect.connect_seq + 1;\n       h.peer_global_seq = h.connect.global_seq;\n-      set_features((uint64_t)h.reply.features & (uint64_t)h.connect.features);\n+      set_features((uint64_t)policy.features_supported & (uint64_t)h.connect.features);","path":"src/crimson/net/SocketConnection.cc","position":29,"original_position":29,"commit_id":"df44f94ce80463905630e1c1eb97e0aed5dbacda","original_commit_id":"df44f94ce80463905630e1c1eb97e0aed5dbacda","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"i think `h.reply.features` at this moment is \r\n```c\r\n(h.connect.features & policy.features_supported) |\r\n policy.features_required\r\n```\r\n\r\nand `h.connect.features` should always contain all `policy.features_required`. \r\n\r\nso the existing code should be correct. am i right?","created_at":"2018-08-12T16:55:27Z","updated_at":"2018-08-12T16:55:27Z","html_url":"https://github.com/ceph/ceph/pull/23539#discussion_r209461578","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/23539","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/209461578"},"html":{"href":"https://github.com/ceph/ceph/pull/23539#discussion_r209461578"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23539"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/23539","id":207828575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODI4NTc1","html_url":"https://github.com/ceph/ceph/pull/23539","diff_url":"https://github.com/ceph/ceph/pull/23539.diff","patch_url":"https://github.com/ceph/ceph/pull/23539.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/23539","number":23539,"state":"open","locked":false,"title":"crimson/net: fix unittest_seastar_messenger errors","user":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"body":"fix several bugs that may fail unittest_seastar_messenger:\r\n1. correct destruction order: unregister the connection after close streams.\r\n2. zero h.reply before start to use it.\r\n3. set server-side features correctly.\r\n4. add missing return to link write with flush.\r\n5. remove an empty lambda operation.\r\n\r\nSigned-off-by: Yingxin <yingxin.cheng@intel.com>\r\n\r\n\r\n<!--\r\nThank you for opening a pull request!  Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin.  For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview.  More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [ ] References tracker ticket\r\n- [ ] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-08-12T16:19:46Z","updated_at":"2018-08-12T16:55:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcffdae1484be41f03a58ba1eb69267ddb0bebac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":959692411,"node_id":"MDU6TGFiZWw5NTk2OTI0MTE=","url":"https://api.github.com/repos/ceph/ceph/labels/crimson","name":"crimson","color":"B80f0a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/23539/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/23539/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/23539/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/df44f94ce80463905630e1c1eb97e0aed5dbacda","head":{"label":"cyx1231st:wip-seastar-msgr-cyx","ref":"wip-seastar-msgr-cyx","sha":"df44f94ce80463905630e1c1eb97e0aed5dbacda","user":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"repo":{"id":100563652,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1NjM2NTI=","name":"ceph","full_name":"cyx1231st/ceph","owner":{"login":"cyx1231st","id":7736006,"node_id":"MDQ6VXNlcjc3MzYwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7736006?v=4","gravatar_id":"","url":"https://api.github.com/users/cyx1231st","html_url":"https://github.com/cyx1231st","followers_url":"https://api.github.com/users/cyx1231st/followers","following_url":"https://api.github.com/users/cyx1231st/following{/other_user}","gists_url":"https://api.github.com/users/cyx1231st/gists{/gist_id}","starred_url":"https://api.github.com/users/cyx1231st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyx1231st/subscriptions","organizations_url":"https://api.github.com/users/cyx1231st/orgs","repos_url":"https://api.github.com/users/cyx1231st/repos","events_url":"https://api.github.com/users/cyx1231st/events{/privacy}","received_events_url":"https://api.github.com/users/cyx1231st/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyx1231st/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/cyx1231st/ceph","forks_url":"https://api.github.com/repos/cyx1231st/ceph/forks","keys_url":"https://api.github.com/repos/cyx1231st/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyx1231st/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyx1231st/ceph/teams","hooks_url":"https://api.github.com/repos/cyx1231st/ceph/hooks","issue_events_url":"https://api.github.com/repos/cyx1231st/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/cyx1231st/ceph/events","assignees_url":"https://api.github.com/repos/cyx1231st/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/cyx1231st/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/cyx1231st/ceph/tags","blobs_url":"https://api.github.com/repos/cyx1231st/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyx1231st/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyx1231st/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyx1231st/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyx1231st/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/cyx1231st/ceph/languages","stargazers_url":"https://api.github.com/repos/cyx1231st/ceph/stargazers","contributors_url":"https://api.github.com/repos/cyx1231st/ceph/contributors","subscribers_url":"https://api.github.com/repos/cyx1231st/ceph/subscribers","subscription_url":"https://api.github.com/repos/cyx1231st/ceph/subscription","commits_url":"https://api.github.com/repos/cyx1231st/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyx1231st/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyx1231st/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyx1231st/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyx1231st/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/cyx1231st/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyx1231st/ceph/merges","archive_url":"https://api.github.com/repos/cyx1231st/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyx1231st/ceph/downloads","issues_url":"https://api.github.com/repos/cyx1231st/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/cyx1231st/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/cyx1231st/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/cyx1231st/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyx1231st/ceph/labels{/name}","releases_url":"https://api.github.com/repos/cyx1231st/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/cyx1231st/ceph/deployments","created_at":"2017-08-17T05:07:10Z","updated_at":"2018-08-12T16:13:24Z","pushed_at":"2018-08-12T16:14:40Z","git_url":"git://github.com/cyx1231st/ceph.git","ssh_url":"git@github.com:cyx1231st/ceph.git","clone_url":"https://github.com/cyx1231st/ceph.git","svn_url":"https://github.com/cyx1231st/ceph","homepage":"http://ceph.com","size":288553,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"e0abbb7d1c396d91a659e9d2207ecf6e27339e7c","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-08-12T09:32:24Z","pushed_at":"2018-08-12T16:41:21Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":303661,"stargazers_count":4914,"watchers_count":4914,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2576,"mirror_url":null,"archived":false,"open_issues_count":716,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2576,"open_issues":716,"watchers":4914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23539"},"html":{"href":"https://github.com/ceph/ceph/pull/23539"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/23539"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/23539/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23539/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23539/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/df44f94ce80463905630e1c1eb97e0aed5dbacda"}},"author_association":"NONE"}}
{"actor":{"display_login":"tchaikov"}}