{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/maintainer-tools/issues/397","repository_url":"https://api.github.com/repos/OCA/maintainer-tools","labels_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/397/labels{/name}","comments_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/397/comments","events_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/397/events","html_url":"https://github.com/OCA/maintainer-tools/pull/397","id":384568011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzQwOTcx","number":397,"title":"[IMP] oca-gen-addon-readme : make organization name configurable and fix images URL","user":{"login":"legalsylvain","id":3407482,"node_id":"MDQ6VXNlcjM0MDc0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3407482?v=4","gravatar_id":"","url":"https://api.github.com/users/legalsylvain","html_url":"https://github.com/legalsylvain","followers_url":"https://api.github.com/users/legalsylvain/followers","following_url":"https://api.github.com/users/legalsylvain/following{/other_user}","gists_url":"https://api.github.com/users/legalsylvain/gists{/gist_id}","starred_url":"https://api.github.com/users/legalsylvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legalsylvain/subscriptions","organizations_url":"https://api.github.com/users/legalsylvain/orgs","repos_url":"https://api.github.com/users/legalsylvain/repos","events_url":"https://api.github.com/users/legalsylvain/events{/privacy}","received_events_url":"https://api.github.com/users/legalsylvain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-27T00:27:03Z","updated_at":"2018-11-27T13:15:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OCA/maintainer-tools/pulls/397","html_url":"https://github.com/OCA/maintainer-tools/pull/397","diff_url":"https://github.com/OCA/maintainer-tools/pull/397.diff","patch_url":"https://github.com/OCA/maintainer-tools/pull/397.patch"},"body":"Hi all, \r\n\r\nFirst, thanks for this great tool.\r\n\r\nThis PR adds 2 improvements on oca-gen-addon-readme (the second depends on the first).\r\n\r\nCommit 1 : make the organization name configurable, to let the possibility to generate readme for incubator / custom repositories. (= non OCA repo)\r\n\r\nfor that purpose, \r\n-> add a new argument ``--org-name`` with default value set to ``OCA``\r\n-> replace hard coded 'OCA' by the org_name, in all the URLs\r\n-> hide some parts of the template, if the organization is not OCA\r\n\r\nCommit 2 : Fix a recurring trouble on figures. In a few words, relative path of figures are not working in the same time on github, on odoo, and on odoo appstore. So, add a little script to translate relative path into full github path. (using rawcontent).\r\nFor the time being, to make the image available in all places, maintainers has to write absolute url. (sample in mis-builder : https://raw.githubusercontent.com/OCA/mis-builder/10.0/mis_builder/readme/USAGE.rst)\r\nbut the problem are : \r\n- the url depends on version, so should be changed in each new release ;\r\n- doesnt work on github, when the PR is not merged ; (harder to review)\r\n- longer url ;\r\n\r\nsample of the generated code, for a non OCA module : \r\nhttps://github.com/grap/grap-odoo-incubator/tree/8.0/account_invoice_supplierinfo_update_triple_discount\r\n\r\n(DESCRIPTION.rst contains relative path, and generated readme contains absolute path)\r\n\r\n\r\nthanks for your review. CC : @sbidoul \r\n"},"comment":{"url":"https://api.github.com/repos/OCA/maintainer-tools/issues/comments/442053962","html_url":"https://github.com/OCA/maintainer-tools/pull/397#issuecomment-442053962","issue_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/397","id":442053962,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjA1Mzk2Mg==","user":{"login":"legalsylvain","id":3407482,"node_id":"MDQ6VXNlcjM0MDc0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3407482?v=4","gravatar_id":"","url":"https://api.github.com/users/legalsylvain","html_url":"https://github.com/legalsylvain","followers_url":"https://api.github.com/users/legalsylvain/followers","following_url":"https://api.github.com/users/legalsylvain/following{/other_user}","gists_url":"https://api.github.com/users/legalsylvain/gists{/gist_id}","starred_url":"https://api.github.com/users/legalsylvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legalsylvain/subscriptions","organizations_url":"https://api.github.com/users/legalsylvain/orgs","repos_url":"https://api.github.com/users/legalsylvain/repos","events_url":"https://api.github.com/users/legalsylvain/events{/privacy}","received_events_url":"https://api.github.com/users/legalsylvain/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T13:15:23Z","updated_at":"2018-11-27T13:15:23Z","author_association":"CONTRIBUTOR","body":"OK, thanks for the precisions. so unrelated with that PR.\r\nIs it now all OK for you ?\r\nthanks for all the reviewers."}}
{"actor":{"display_login":"legalsylvain"}}