{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/ethereum/lahja/pulls/21","id":233314448,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzE0NDQ4","html_url":"https://github.com/ethereum/lahja/pull/21","diff_url":"https://github.com/ethereum/lahja/pull/21.diff","patch_url":"https://github.com/ethereum/lahja/pull/21.patch","issue_url":"https://api.github.com/repos/ethereum/lahja/issues/21","number":21,"state":"closed","locked":false,"title":"Christoph/feat/request with broadcast config","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"body":"## What was wrong?\r\n\r\nThe `request` API did not accept a `BroadcastConfig` yet. That's quite unfortunate because, often when we do a `request` we have a specific `Endpoint` in mind that would answer that request. However, without specifying a `BroadcastConfig`, the request is relayed to each and every connected `Endpoint` which obviously causes more inter process traffic than needed.\r\n\r\n## How was it fixed?\r\n\r\n- Make `request` API accept a `BroadcastConfig`\r\n- added tests\r\n- cleaned up test\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses](https://amazinganimalphotos.com/wp-content/uploads/2013/05/adorable-lion-cub-photo.jpg)\r\n","created_at":"2018-11-24T11:20:13Z","updated_at":"2018-11-27T09:43:50Z","closed_at":"2018-11-27T09:43:50Z","merged_at":"2018-11-27T09:43:50Z","merge_commit_sha":"710be2b67ebfc18deeabfcc0548be7f051d98669","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/lahja/pulls/21/commits","review_comments_url":"https://api.github.com/repos/ethereum/lahja/pulls/21/comments","review_comment_url":"https://api.github.com/repos/ethereum/lahja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/lahja/issues/21/comments","statuses_url":"https://api.github.com/repos/ethereum/lahja/statuses/7f1f5a1c7dac2e3e20bea6c16b165f9f1f3f12e5","head":{"label":"cburgdorf:christoph/feat/request-with-broadcast-config","ref":"christoph/feat/request-with-broadcast-config","sha":"7f1f5a1c7dac2e3e20bea6c16b165f9f1f3f12e5","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"repo":{"id":148504935,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MDQ5MzU=","name":"lahja-1","full_name":"cburgdorf/lahja-1","private":false,"owner":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cburgdorf/lahja-1","description":"Lahja is a generic multi process event bus implementation written in Python 3.6+ to enable lightweight inter-process communication, based on non-blocking asyncio","fork":true,"url":"https://api.github.com/repos/cburgdorf/lahja-1","forks_url":"https://api.github.com/repos/cburgdorf/lahja-1/forks","keys_url":"https://api.github.com/repos/cburgdorf/lahja-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cburgdorf/lahja-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cburgdorf/lahja-1/teams","hooks_url":"https://api.github.com/repos/cburgdorf/lahja-1/hooks","issue_events_url":"https://api.github.com/repos/cburgdorf/lahja-1/issues/events{/number}","events_url":"https://api.github.com/repos/cburgdorf/lahja-1/events","assignees_url":"https://api.github.com/repos/cburgdorf/lahja-1/assignees{/user}","branches_url":"https://api.github.com/repos/cburgdorf/lahja-1/branches{/branch}","tags_url":"https://api.github.com/repos/cburgdorf/lahja-1/tags","blobs_url":"https://api.github.com/repos/cburgdorf/lahja-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cburgdorf/lahja-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cburgdorf/lahja-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/cburgdorf/lahja-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cburgdorf/lahja-1/statuses/{sha}","languages_url":"https://api.github.com/repos/cburgdorf/lahja-1/languages","stargazers_url":"https://api.github.com/repos/cburgdorf/lahja-1/stargazers","contributors_url":"https://api.github.com/repos/cburgdorf/lahja-1/contributors","subscribers_url":"https://api.github.com/repos/cburgdorf/lahja-1/subscribers","subscription_url":"https://api.github.com/repos/cburgdorf/lahja-1/subscription","commits_url":"https://api.github.com/repos/cburgdorf/lahja-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/cburgdorf/lahja-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/cburgdorf/lahja-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/cburgdorf/lahja-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/cburgdorf/lahja-1/contents/{+path}","compare_url":"https://api.github.com/repos/cburgdorf/lahja-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cburgdorf/lahja-1/merges","archive_url":"https://api.github.com/repos/cburgdorf/lahja-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cburgdorf/lahja-1/downloads","issues_url":"https://api.github.com/repos/cburgdorf/lahja-1/issues{/number}","pulls_url":"https://api.github.com/repos/cburgdorf/lahja-1/pulls{/number}","milestones_url":"https://api.github.com/repos/cburgdorf/lahja-1/milestones{/number}","notifications_url":"https://api.github.com/repos/cburgdorf/lahja-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cburgdorf/lahja-1/labels{/name}","releases_url":"https://api.github.com/repos/cburgdorf/lahja-1/releases{/id}","deployments_url":"https://api.github.com/repos/cburgdorf/lahja-1/deployments","created_at":"2018-09-12T15:50:40Z","updated_at":"2018-09-12T15:50:42Z","pushed_at":"2018-11-26T20:05:57Z","git_url":"git://github.com/cburgdorf/lahja-1.git","ssh_url":"git@github.com:cburgdorf/lahja-1.git","clone_url":"https://github.com/cburgdorf/lahja-1.git","svn_url":"https://github.com/cburgdorf/lahja-1","homepage":"","size":111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"6a1a45439c9eaac301a08991cec60d54940767be","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":146730940,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3MzA5NDA=","name":"lahja","full_name":"ethereum/lahja","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/lahja","description":"Lahja is a generic multi process event bus implementation written in Python 3.6+ to enable lightweight inter-process communication, based on non-blocking asyncio","fork":false,"url":"https://api.github.com/repos/ethereum/lahja","forks_url":"https://api.github.com/repos/ethereum/lahja/forks","keys_url":"https://api.github.com/repos/ethereum/lahja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/lahja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/lahja/teams","hooks_url":"https://api.github.com/repos/ethereum/lahja/hooks","issue_events_url":"https://api.github.com/repos/ethereum/lahja/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/lahja/events","assignees_url":"https://api.github.com/repos/ethereum/lahja/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/lahja/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/lahja/tags","blobs_url":"https://api.github.com/repos/ethereum/lahja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/lahja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/lahja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/lahja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/lahja/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/lahja/languages","stargazers_url":"https://api.github.com/repos/ethereum/lahja/stargazers","contributors_url":"https://api.github.com/repos/ethereum/lahja/contributors","subscribers_url":"https://api.github.com/repos/ethereum/lahja/subscribers","subscription_url":"https://api.github.com/repos/ethereum/lahja/subscription","commits_url":"https://api.github.com/repos/ethereum/lahja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/lahja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/lahja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/lahja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/lahja/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/lahja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/lahja/merges","archive_url":"https://api.github.com/repos/ethereum/lahja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/lahja/downloads","issues_url":"https://api.github.com/repos/ethereum/lahja/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/lahja/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/lahja/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/lahja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/lahja/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/lahja/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/lahja/deployments","created_at":"2018-08-30T10:02:06Z","updated_at":"2018-11-19T18:53:25Z","pushed_at":"2018-11-27T09:43:50Z","git_url":"git://github.com/ethereum/lahja.git","ssh_url":"git@github.com:ethereum/lahja.git","clone_url":"https://github.com/ethereum/lahja.git","svn_url":"https://github.com/ethereum/lahja","homepage":"","size":91,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/21"},"html":{"href":"https://github.com/ethereum/lahja/pull/21"},"issue":{"href":"https://api.github.com/repos/ethereum/lahja/issues/21"},"comments":{"href":"https://api.github.com/repos/ethereum/lahja/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/lahja/statuses/7f1f5a1c7dac2e3e20bea6c16b165f9f1f3f12e5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":176,"deletions":39,"changed_files":7}}
{"actor":{"display_login":"cburgdorf"}}