{"action":"closed","issue":{"url":"https://api.github.com/repos/SaturnFramework/Saturn/issues/81","repository_url":"https://api.github.com/repos/SaturnFramework/Saturn","labels_url":"https://api.github.com/repos/SaturnFramework/Saturn/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/SaturnFramework/Saturn/issues/81/comments","events_url":"https://api.github.com/repos/SaturnFramework/Saturn/issues/81/events","html_url":"https://github.com/SaturnFramework/Saturn/issues/81","id":338108695,"node_id":"MDU6SXNzdWUzMzgxMDg2OTU=","number":81,"title":"GitHub OAuth doesn't work","user":{"login":"rmunn","id":90762,"node_id":"MDQ6VXNlcjkwNzYy","avatar_url":"https://avatars2.githubusercontent.com/u/90762?v=4","gravatar_id":"","url":"https://api.github.com/users/rmunn","html_url":"https://github.com/rmunn","followers_url":"https://api.github.com/users/rmunn/followers","following_url":"https://api.github.com/users/rmunn/following{/other_user}","gists_url":"https://api.github.com/users/rmunn/gists{/gist_id}","starred_url":"https://api.github.com/users/rmunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmunn/subscriptions","organizations_url":"https://api.github.com/users/rmunn/orgs","repos_url":"https://api.github.com/users/rmunn/repos","events_url":"https://api.github.com/users/rmunn/events{/privacy}","received_events_url":"https://api.github.com/users/rmunn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-04T02:19:27Z","updated_at":"2018-07-04T10:09:15Z","closed_at":"2018-07-04T10:09:15Z","author_association":"NONE","body":"The `use_github_oauth` operation in the `application` CE doesn't work, because the `OnCreatingTicket` event is never handled. After a bit of debugging, I figured out the reason: the code creates a new `OAuthEvents` instance and registers the `OnCreatingTicket` event on that instance, but what it *should* be doing is getting the `OAuthEvents` instance from the `opt.Events` property. With this one change, the `use_github_oauth` operation works.\r\n"}}
{"actor":{"display_login":"Krzysztof-Cieslak"}}