{"action":"created","comment":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/175988698","pull_request_review_id":105610999,"id":175988698,"diff_hunk":"@@ -110,7 +111,7 @@ static void json_invoice(struct command *cmd,\n \tstruct invoice_details details;\n \tjsmntok_t *msatoshi, *label, *desc, *exp, *fallback;\n \tu64 *msatoshi_val;\n-\tconst char *label_val;\n+\tconst struct json_escaped *label_val;\n \tconst char *desc_val;","path":"lightningd/invoice.c","position":null,"original_position":14,"commit_id":"e66277e31664fd950318f87aa8e9f09b2233b294","original_commit_id":"c769caa009355ed65a3c9ea2bcd46bbb3d62f3d0","user":{"login":"ZmnSCPxj","id":28175207,"avatar_url":"https://avatars0.githubusercontent.com/u/28175207?v=4","gravatar_id":"","url":"https://api.github.com/users/ZmnSCPxj","html_url":"https://github.com/ZmnSCPxj","followers_url":"https://api.github.com/users/ZmnSCPxj/followers","following_url":"https://api.github.com/users/ZmnSCPxj/following{/other_user}","gists_url":"https://api.github.com/users/ZmnSCPxj/gists{/gist_id}","starred_url":"https://api.github.com/users/ZmnSCPxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZmnSCPxj/subscriptions","organizations_url":"https://api.github.com/users/ZmnSCPxj/orgs","repos_url":"https://api.github.com/users/ZmnSCPxj/repos","events_url":"https://api.github.com/users/ZmnSCPxj/events{/privacy}","received_events_url":"https://api.github.com/users/ZmnSCPxj/received_events","type":"User","site_admin":false},"body":"Why not description too?","created_at":"2018-03-21T05:48:39Z","updated_at":"2018-03-21T06:01:03Z","html_url":"https://github.com/ElementsProject/lightning/pull/1254#discussion_r175988698","pull_request_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/175988698"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/1254#discussion_r175988698"},"pull_request":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254"}}},"pull_request":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254","id":176377161,"html_url":"https://github.com/ElementsProject/lightning/pull/1254","diff_url":"https://github.com/ElementsProject/lightning/pull/1254.diff","patch_url":"https://github.com/ElementsProject/lightning/pull/1254.patch","issue_url":"https://api.github.com/repos/ElementsProject/lightning/issues/1254","number":1254,"state":"open","locked":false,"title":"Cleanup jsonrpc stringhandling","user":{"login":"rustyrussell","id":775844,"avatar_url":"https://avatars2.githubusercontent.com/u/775844?v=4","gravatar_id":"","url":"https://api.github.com/users/rustyrussell","html_url":"https://github.com/rustyrussell","followers_url":"https://api.github.com/users/rustyrussell/followers","following_url":"https://api.github.com/users/rustyrussell/following{/other_user}","gists_url":"https://api.github.com/users/rustyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrussell/subscriptions","organizations_url":"https://api.github.com/users/rustyrussell/orgs","repos_url":"https://api.github.com/users/rustyrussell/repos","events_url":"https://api.github.com/users/rustyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrussell/received_events","type":"User","site_admin":false},"body":"This introduces a new type for things we know are JSON escaped, to try to maintain a safety net.  I then audited all the uses, and found some places which needed patching.  Finally, this gets rid of the JSON input restriction we had, and does more intelligent escaping for output (particularly for logs).\r\n\r\n(I have a more ambitious rework of json parameter parsing, but it's a big job that can wait)","created_at":"2018-03-21T03:51:47Z","updated_at":"2018-03-21T06:01:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a07674c22f7a7f79da4a3628e6a8d20e3d51566","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cdecker","id":120117,"avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254/commits","review_comments_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254/comments","review_comment_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/issues/1254/comments","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/e66277e31664fd950318f87aa8e9f09b2233b294","head":{"label":"rustyrussell:cleanup-jsonrpc-stringhandling","ref":"cleanup-jsonrpc-stringhandling","sha":"e66277e31664fd950318f87aa8e9f09b2233b294","user":{"login":"rustyrussell","id":775844,"avatar_url":"https://avatars2.githubusercontent.com/u/775844?v=4","gravatar_id":"","url":"https://api.github.com/users/rustyrussell","html_url":"https://github.com/rustyrussell","followers_url":"https://api.github.com/users/rustyrussell/followers","following_url":"https://api.github.com/users/rustyrussell/following{/other_user}","gists_url":"https://api.github.com/users/rustyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrussell/subscriptions","organizations_url":"https://api.github.com/users/rustyrussell/orgs","repos_url":"https://api.github.com/users/rustyrussell/repos","events_url":"https://api.github.com/users/rustyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrussell/received_events","type":"User","site_admin":false},"repo":{"id":87036919,"name":"lightning","full_name":"rustyrussell/lightning","owner":{"login":"rustyrussell","id":775844,"avatar_url":"https://avatars2.githubusercontent.com/u/775844?v=4","gravatar_id":"","url":"https://api.github.com/users/rustyrussell","html_url":"https://github.com/rustyrussell","followers_url":"https://api.github.com/users/rustyrussell/followers","following_url":"https://api.github.com/users/rustyrussell/following{/other_user}","gists_url":"https://api.github.com/users/rustyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrussell/subscriptions","organizations_url":"https://api.github.com/users/rustyrussell/orgs","repos_url":"https://api.github.com/users/rustyrussell/repos","events_url":"https://api.github.com/users/rustyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rustyrussell/lightning","description":"Lightning network","fork":true,"url":"https://api.github.com/repos/rustyrussell/lightning","forks_url":"https://api.github.com/repos/rustyrussell/lightning/forks","keys_url":"https://api.github.com/repos/rustyrussell/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustyrussell/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustyrussell/lightning/teams","hooks_url":"https://api.github.com/repos/rustyrussell/lightning/hooks","issue_events_url":"https://api.github.com/repos/rustyrussell/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/rustyrussell/lightning/events","assignees_url":"https://api.github.com/repos/rustyrussell/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/rustyrussell/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/rustyrussell/lightning/tags","blobs_url":"https://api.github.com/repos/rustyrussell/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustyrussell/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustyrussell/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustyrussell/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustyrussell/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/rustyrussell/lightning/languages","stargazers_url":"https://api.github.com/repos/rustyrussell/lightning/stargazers","contributors_url":"https://api.github.com/repos/rustyrussell/lightning/contributors","subscribers_url":"https://api.github.com/repos/rustyrussell/lightning/subscribers","subscription_url":"https://api.github.com/repos/rustyrussell/lightning/subscription","commits_url":"https://api.github.com/repos/rustyrussell/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustyrussell/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustyrussell/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustyrussell/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustyrussell/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/rustyrussell/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustyrussell/lightning/merges","archive_url":"https://api.github.com/repos/rustyrussell/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustyrussell/lightning/downloads","issues_url":"https://api.github.com/repos/rustyrussell/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/rustyrussell/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/rustyrussell/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/rustyrussell/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustyrussell/lightning/labels{/name}","releases_url":"https://api.github.com/repos/rustyrussell/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/rustyrussell/lightning/deployments","created_at":"2017-04-03T04:06:02Z","updated_at":"2017-06-02T15:07:55Z","pushed_at":"2018-03-21T03:50:18Z","git_url":"git://github.com/rustyrussell/lightning.git","ssh_url":"git@github.com:rustyrussell/lightning.git","clone_url":"https://github.com/rustyrussell/lightning.git","svn_url":"https://github.com/rustyrussell/lightning","homepage":null,"size":14466,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ElementsProject:master","ref":"master","sha":"489d8d04a68fe2aabf145dfb411bc78b27fa4166","user":{"login":"ElementsProject","id":12729539,"avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":37350472,"name":"lightning","full_name":"ElementsProject/lightning","owner":{"login":"ElementsProject","id":12729539,"avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElementsProject/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":false,"url":"https://api.github.com/repos/ElementsProject/lightning","forks_url":"https://api.github.com/repos/ElementsProject/lightning/forks","keys_url":"https://api.github.com/repos/ElementsProject/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementsProject/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementsProject/lightning/teams","hooks_url":"https://api.github.com/repos/ElementsProject/lightning/hooks","issue_events_url":"https://api.github.com/repos/ElementsProject/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ElementsProject/lightning/events","assignees_url":"https://api.github.com/repos/ElementsProject/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ElementsProject/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ElementsProject/lightning/tags","blobs_url":"https://api.github.com/repos/ElementsProject/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementsProject/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementsProject/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementsProject/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementsProject/lightning/languages","stargazers_url":"https://api.github.com/repos/ElementsProject/lightning/stargazers","contributors_url":"https://api.github.com/repos/ElementsProject/lightning/contributors","subscribers_url":"https://api.github.com/repos/ElementsProject/lightning/subscribers","subscription_url":"https://api.github.com/repos/ElementsProject/lightning/subscription","commits_url":"https://api.github.com/repos/ElementsProject/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementsProject/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementsProject/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElementsProject/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ElementsProject/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementsProject/lightning/merges","archive_url":"https://api.github.com/repos/ElementsProject/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementsProject/lightning/downloads","issues_url":"https://api.github.com/repos/ElementsProject/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ElementsProject/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementsProject/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementsProject/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementsProject/lightning/labels{/name}","releases_url":"https://api.github.com/repos/ElementsProject/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ElementsProject/lightning/deployments","created_at":"2015-06-13T00:04:22Z","updated_at":"2018-03-20T23:06:07Z","pushed_at":"2018-03-21T03:51:48Z","git_url":"git://github.com/ElementsProject/lightning.git","ssh_url":"git@github.com:ElementsProject/lightning.git","clone_url":"https://github.com/ElementsProject/lightning.git","svn_url":"https://github.com/ElementsProject/lightning","homepage":"","size":14101,"stargazers_count":820,"watchers_count":820,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":224,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":224,"open_issues":110,"watchers":820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/1254"},"issue":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/1254"},"comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/1254/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1254/commits"},"statuses":{"href":"https://api.github.com/repos/ElementsProject/lightning/statuses/e66277e31664fd950318f87aa8e9f09b2233b294"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ZmnSCPxj"}}