{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew-cask/issues/52565","repository_url":"https://api.github.com/repos/Homebrew/homebrew-cask","labels_url":"https://api.github.com/repos/Homebrew/homebrew-cask/issues/52565/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-cask/issues/52565/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew-cask/issues/52565/events","html_url":"https://github.com/Homebrew/homebrew-cask/pull/52565","id":364672610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODAzNTEx","number":52565,"title":"Add OpenJFX 11","user":{"login":"claudionieder","id":19993979,"node_id":"MDQ6VXNlcjE5OTkzOTc5","avatar_url":"https://avatars2.githubusercontent.com/u/19993979?v=4","gravatar_id":"","url":"https://api.github.com/users/claudionieder","html_url":"https://github.com/claudionieder","followers_url":"https://api.github.com/users/claudionieder/followers","following_url":"https://api.github.com/users/claudionieder/following{/other_user}","gists_url":"https://api.github.com/users/claudionieder/gists{/gist_id}","starred_url":"https://api.github.com/users/claudionieder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudionieder/subscriptions","organizations_url":"https://api.github.com/users/claudionieder/orgs","repos_url":"https://api.github.com/users/claudionieder/repos","events_url":"https://api.github.com/users/claudionieder/events{/privacy}","received_events_url":"https://api.github.com/users/claudionieder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-27T22:12:18Z","updated_at":"2018-09-28T09:51:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-cask/pulls/52565","html_url":"https://github.com/Homebrew/homebrew-cask/pull/52565","diff_url":"https://github.com/Homebrew/homebrew-cask/pull/52565.diff","patch_url":"https://github.com/Homebrew/homebrew-cask/pull/52565.patch"},"body":"<!-- If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so. -->\r\n\r\nAfter making all changes to the cask:\r\n\r\n- [X] `brew cask audit --download {{cask_file}}` is error-free.\r\n- [X] `brew cask style --fix {{cask_file}}` reports no offenses.\r\n- [X] The commit message includes the cask’s name and version.\r\n- [X] The submission is for [a stable version](https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#finding-a-home-for-your-cask) or [documented exception](https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#but-there-is-no-stable-version).\r\n\r\nAdditionally, if **adding a new cask**:\r\n\r\n- [X] Named the cask according to the [token reference].\r\n- [X] `brew cask install {{cask_file}}` worked successfully.\r\n- [X] `brew cask uninstall {{cask_file}}` worked successfully.\r\n- [X] Checked there are no [open pull requests] for the same cask.\r\n- [X] Checked the cask was not [already refused].\r\n- [X] Checked the cask is submitted to [the correct repo].\r\n\r\n[token reference]: https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/token_reference.md\r\n[open pull requests]: https://github.com/Homebrew/homebrew-cask/pulls\r\n[already refused]: https://github.com/Homebrew/homebrew-cask/search?q=is%3Aclosed&type=Issues\r\n[the correct repo]: https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md#finding-a-home-for-your-cask\r\n[version-checksum]: https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md#updating-the-sha256\r\n"},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-cask/issues/comments/425384804","html_url":"https://github.com/Homebrew/homebrew-cask/pull/52565#issuecomment-425384804","issue_url":"https://api.github.com/repos/Homebrew/homebrew-cask/issues/52565","id":425384804,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTM4NDgwNA==","user":{"login":"claudionieder","id":19993979,"node_id":"MDQ6VXNlcjE5OTkzOTc5","avatar_url":"https://avatars2.githubusercontent.com/u/19993979?v=4","gravatar_id":"","url":"https://api.github.com/users/claudionieder","html_url":"https://github.com/claudionieder","followers_url":"https://api.github.com/users/claudionieder/followers","following_url":"https://api.github.com/users/claudionieder/following{/other_user}","gists_url":"https://api.github.com/users/claudionieder/gists{/gist_id}","starred_url":"https://api.github.com/users/claudionieder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudionieder/subscriptions","organizations_url":"https://api.github.com/users/claudionieder/orgs","repos_url":"https://api.github.com/users/claudionieder/repos","events_url":"https://api.github.com/users/claudionieder/events{/privacy}","received_events_url":"https://api.github.com/users/claudionieder/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T09:51:52Z","updated_at":"2018-09-28T09:51:52Z","author_association":"CONTRIBUTOR","body":"Hi,\n\nas I am new to this, please allow me two questions:\n\n1. I have added the caveat and now when it is installed it puts out a warning. Even though it is unsubstantiated, because brew doctor does not complain about anything this made me wonder, if my selection to install it to /usr/local/lib/OpenJFX is a wise one? Do you think there would be a better place where to put OpenJFX?\n\n2. As I am not so versed in git and especially github: After I have fixed the issues is it the same\n\n\tgit commit -v\n\tgit push <my-github-username> my-new-cask\n\tHit \"Compare & pull request\" in github\n\nsequence as described in adding_a_cask.md or do I need to modify any of above commands?\n\nThank you very much for your help,\nclaudio\n\n> On 28. Sep. 2018, at 00:40, commitay <notifications@github.com> wrote:\n> \n> @commitay commented on this pull request.\n> \n> In Casks/openjfx.rb <https://github.com/Homebrew/homebrew-cask/pull/52565#discussion_r221098784>:\n> \n> > +  url \"http://download2.gluonhq.com/openjfx/#{version}/openjfx-#{version}_osx-x64_bin-sdk.zip\"\n> +  name 'OpenJFX'\n> +  homepage 'https://openjfx.io/'\n> +\n> +  postflight do\n> +    system_command '/bin/cp',\n> +                   args: ['-rp', staged_path.to_s, '/usr/local/lib/OpenJFX']\n> +  end\n> +\n> +  uninstall_postflight do\n> +    next unless File.exist?('/usr/local/lib/OpenJFX')\n> +\n> +    system_command '/bin/rm',\n> +                   args: ['-rf', '/usr/local/lib/OpenJFX']\n> +  end\n> +end\n> Add a caveat:\n> https://github.com/Homebrew/homebrew-cask/blob/6ec7d441cd810a588a1ba24f4d77da636c987928/Casks/gpg-suite.rb#L73-L75 <https://github.com/Homebrew/homebrew-cask/blob/6ec7d441cd810a588a1ba24f4d77da636c987928/Casks/gpg-suite.rb#L73-L75>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub <https://github.com/Homebrew/homebrew-cask/pull/52565#pullrequestreview-159668138>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATEVe5yof-jf2UFCybUIJ9VUILZHJoEdks5ufVPygaJpZM4W9ix_>.\n> \n\n"}}
{"actor":{"display_login":"claudionieder"}}