{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/20","id":232002198,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDAyMTk4","html_url":"https://github.com/openshift/cluster-api-actuator-pkg/pull/20","diff_url":"https://github.com/openshift/cluster-api-actuator-pkg/pull/20.diff","patch_url":"https://github.com/openshift/cluster-api-actuator-pkg/pull/20.patch","issue_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues/20","number":20,"state":"closed","locked":false,"title":"Allow the machine-role clusterrole to list secrest as well","user":{"login":"ingvagabund","id":8055242,"node_id":"MDQ6VXNlcjgwNTUyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8055242?v=4","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"body":"The machine controller reads a user data from a secret.\r\nThus, the pod running the machine controller must be allowed to list secrets.\r\n\r\n/hold\r\nuntil verified in https://github.com/openshift/cluster-api-provider-libvirt/pull/92","created_at":"2018-11-19T14:57:13Z","updated_at":"2018-11-19T15:51:29Z","closed_at":"2018-11-19T15:51:29Z","merged_at":"2018-11-19T15:51:29Z","merge_commit_sha":"a8a0cc0155b33e6f07aa9678dfccf7aea0523cf6","assignee":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"assignees":[{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},{"login":"trawler","id":8340149,"node_id":"MDQ6VXNlcjgzNDAxNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/8340149?v=4","gravatar_id":"","url":"https://api.github.com/users/trawler","html_url":"https://github.com/trawler","followers_url":"https://api.github.com/users/trawler/followers","following_url":"https://api.github.com/users/trawler/following{/other_user}","gists_url":"https://api.github.com/users/trawler/gists{/gist_id}","starred_url":"https://api.github.com/users/trawler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trawler/subscriptions","organizations_url":"https://api.github.com/users/trawler/orgs","repos_url":"https://api.github.com/users/trawler/repos","events_url":"https://api.github.com/users/trawler/events{/privacy}","received_events_url":"https://api.github.com/users/trawler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1087998103,"node_id":"MDU6TGFiZWwxMDg3OTk4MTAz","url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1086477873,"node_id":"MDU6TGFiZWwxMDg2NDc3ODcz","url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1086579972,"node_id":"MDU6TGFiZWwxMDg2NTc5OTcy","url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/20/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/20/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues/20/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/statuses/808f96d972f8a93f8d583d399ee0c908fc7cc354","head":{"label":"ingvagabund:allow-cluster-role-to-list-secrets","ref":"allow-cluster-role-to-list-secrets","sha":"808f96d972f8a93f8d583d399ee0c908fc7cc354","user":{"login":"ingvagabund","id":8055242,"node_id":"MDQ6VXNlcjgwNTUyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8055242?v=4","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"repo":{"id":152470826,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NzA4MjY=","name":"cluster-api-actuator-pkg","full_name":"ingvagabund/cluster-api-actuator-pkg","private":false,"owner":{"login":"ingvagabund","id":8055242,"node_id":"MDQ6VXNlcjgwNTUyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8055242?v=4","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ingvagabund/cluster-api-actuator-pkg","description":null,"fork":true,"url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg","forks_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/forks","keys_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/teams","hooks_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/hooks","issue_events_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/issues/events{/number}","events_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/events","assignees_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/assignees{/user}","branches_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/branches{/branch}","tags_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/tags","blobs_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/statuses/{sha}","languages_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/languages","stargazers_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/stargazers","contributors_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/contributors","subscribers_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/subscribers","subscription_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/subscription","commits_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/contents/{+path}","compare_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/merges","archive_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/downloads","issues_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/issues{/number}","pulls_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/pulls{/number}","milestones_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/milestones{/number}","notifications_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/labels{/name}","releases_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/releases{/id}","deployments_url":"https://api.github.com/repos/ingvagabund/cluster-api-actuator-pkg/deployments","created_at":"2018-10-10T18:29:07Z","updated_at":"2018-10-10T18:29:10Z","pushed_at":"2018-11-19T14:55:45Z","git_url":"git://github.com/ingvagabund/cluster-api-actuator-pkg.git","ssh_url":"git@github.com:ingvagabund/cluster-api-actuator-pkg.git","clone_url":"https://github.com/ingvagabund/cluster-api-actuator-pkg.git","svn_url":"https://github.com/ingvagabund/cluster-api-actuator-pkg","homepage":null,"size":32981,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7a158e52e0e85180ad5b29847f8a30c19bb3ff6c","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":152441092,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NDEwOTI=","name":"cluster-api-actuator-pkg","full_name":"openshift/cluster-api-actuator-pkg","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-api-actuator-pkg","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg","forks_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/forks","keys_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/events","assignees_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/merges","archive_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/deployments","created_at":"2018-10-10T14:53:45Z","updated_at":"2018-11-01T12:59:56Z","pushed_at":"2018-11-19T15:51:29Z","git_url":"git://github.com/openshift/cluster-api-actuator-pkg.git","ssh_url":"git@github.com:openshift/cluster-api-actuator-pkg.git","clone_url":"https://github.com/openshift/cluster-api-actuator-pkg.git","svn_url":"https://github.com/openshift/cluster-api-actuator-pkg","homepage":null,"size":40439,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/20"},"html":{"href":"https://github.com/openshift/cluster-api-actuator-pkg/pull/20"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues/20"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-api-actuator-pkg/statuses/808f96d972f8a93f8d583d399ee0c908fc7cc354"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"openshift-merge-robot","id":30189218,"node_id":"MDQ6VXNlcjMwMTg5MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"openshift-merge-robot"}}