{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/234836189","pull_request_review_id":176562082,"id":234836189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgzNjE4OQ==","diff_hunk":"@@ -535,7 +535,10 @@\n       \"in\": \"query\",\n       \"description\": \"Version of API to invoke.\",\n       \"required\": true,\n-      \"type\": \"string\"\n+      \"type\": \"string\",\n+      \"enum\": [\n+        \"2018-11-30\"\n+      ]","path":"specification/msi/resource-manager/Microsoft.ManagedIdentity/2018-11-30/ManagedIdentity.json","position":541,"original_position":26,"commit_id":"c5e3d7fb237ee96094a2198b3515dc48c03ceded","original_commit_id":"c5e3d7fb237ee96094a2198b3515dc48c03ceded","user":{"login":"amarzavery","id":4521223,"node_id":"MDQ6VXNlcjQ1MjEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4521223?v=4","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"I am not sure if the enum for the api-version parameter is required.\r\n\r\n@veronicagg - Is this allowed?\r\n\r\nIf not then please remove it.","created_at":"2018-11-20T00:52:08Z","updated_at":"2018-11-20T00:52:16Z","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/4492#discussion_r234836189","pull_request_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/234836189"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/4492#discussion_r234836189"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492","id":231639747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjM5NzQ3","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/4492","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/4492.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/4492.patch","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4492","number":4492,"state":"open","locked":false,"title":"Update manage service identity api version","user":{"login":"wendyNEU","id":8632622,"node_id":"MDQ6VXNlcjg2MzI2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/8632622?v=4","gravatar_id":"","url":"https://api.github.com/users/wendyNEU","html_url":"https://github.com/wendyNEU","followers_url":"https://api.github.com/users/wendyNEU/followers","following_url":"https://api.github.com/users/wendyNEU/following{/other_user}","gists_url":"https://api.github.com/users/wendyNEU/gists{/gist_id}","starred_url":"https://api.github.com/users/wendyNEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendyNEU/subscriptions","organizations_url":"https://api.github.com/users/wendyNEU/orgs","repos_url":"https://api.github.com/users/wendyNEU/repos","events_url":"https://api.github.com/users/wendyNEU/events{/privacy}","received_events_url":"https://api.github.com/users/wendyNEU/received_events","type":"User","site_admin":false},"body":"### Latest improvements:\r\n<i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. \r\n</i><br>\r\n### Contribution checklist:\r\n- [x] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow.\r\n- [x] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.\r\n- [x] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.\r\n\r\n### Important Note: \r\n**1. The new version in Managed Service Identity just check in to master branch, and start deployment on 11/16/2018, we can review this pr, but do not merge to master until the Managed Service identity new version have fully global deployment.\r\n2. The first commit directly copy the old version swagger folder, the second commit modify the copy folder to new api-version, it is easy to review the different between old and new api-version in second commit.** \r\n\r\nautorest generate code:\r\n![image](https://user-images.githubusercontent.com/8632622/48643387-6f81a880-e994-11e8-892f-87961e030a53.png)\r\n\r\nautorest validator:\r\n![image](https://user-images.githubusercontent.com/8632622/48643547-da32e400-e994-11e8-8103-706b68cf52e9.png)\r\n\r\nvalidate with oav\r\n![image](https://user-images.githubusercontent.com/8632622/48643750-66450b80-e995-11e8-8c8f-64b0ed0e427f.png)\r\n\r\nvalidate with OpenAPI Hub\r\n![image](https://user-images.githubusercontent.com/8632622/48643837-bcb24a00-e995-11e8-9629-66f79a86247d.png)\r\n\r\n\r\n","created_at":"2018-11-16T19:58:54Z","updated_at":"2018-11-20T00:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4613291babeae0895931f8015eb6d382e5b4047","assignee":{"login":"amarzavery","id":4521223,"node_id":"MDQ6VXNlcjQ1MjEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4521223?v=4","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"assignees":[{"login":"amarzavery","id":4521223,"node_id":"MDQ6VXNlcjQ1MjEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4521223?v=4","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4492/comments","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/c5e3d7fb237ee96094a2198b3515dc48c03ceded","head":{"label":"wendyNEU:UpdateManageServiceIdentityApiVersion","ref":"UpdateManageServiceIdentityApiVersion","sha":"c5e3d7fb237ee96094a2198b3515dc48c03ceded","user":{"login":"wendyNEU","id":8632622,"node_id":"MDQ6VXNlcjg2MzI2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/8632622?v=4","gravatar_id":"","url":"https://api.github.com/users/wendyNEU","html_url":"https://github.com/wendyNEU","followers_url":"https://api.github.com/users/wendyNEU/followers","following_url":"https://api.github.com/users/wendyNEU/following{/other_user}","gists_url":"https://api.github.com/users/wendyNEU/gists{/gist_id}","starred_url":"https://api.github.com/users/wendyNEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendyNEU/subscriptions","organizations_url":"https://api.github.com/users/wendyNEU/orgs","repos_url":"https://api.github.com/users/wendyNEU/repos","events_url":"https://api.github.com/users/wendyNEU/events{/privacy}","received_events_url":"https://api.github.com/users/wendyNEU/received_events","type":"User","site_admin":false},"repo":{"id":157907373,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc5MDczNzM=","name":"azure-rest-api-specs","full_name":"wendyNEU/azure-rest-api-specs","private":false,"owner":{"login":"wendyNEU","id":8632622,"node_id":"MDQ6VXNlcjg2MzI2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/8632622?v=4","gravatar_id":"","url":"https://api.github.com/users/wendyNEU","html_url":"https://github.com/wendyNEU","followers_url":"https://api.github.com/users/wendyNEU/followers","following_url":"https://api.github.com/users/wendyNEU/following{/other_user}","gists_url":"https://api.github.com/users/wendyNEU/gists{/gist_id}","starred_url":"https://api.github.com/users/wendyNEU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendyNEU/subscriptions","organizations_url":"https://api.github.com/users/wendyNEU/orgs","repos_url":"https://api.github.com/users/wendyNEU/repos","events_url":"https://api.github.com/users/wendyNEU/events{/privacy}","received_events_url":"https://api.github.com/users/wendyNEU/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wendyNEU/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":true,"url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs","forks_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/wendyNEU/azure-rest-api-specs/deployments","created_at":"2018-11-16T18:39:12Z","updated_at":"2018-11-16T18:39:39Z","pushed_at":"2018-11-16T19:05:18Z","git_url":"git://github.com/wendyNEU/azure-rest-api-specs.git","ssh_url":"git@github.com:wendyNEU/azure-rest-api-specs.git","clone_url":"https://github.com/wendyNEU/azure-rest-api-specs.git","svn_url":"https://github.com/wendyNEU/azure-rest-api-specs","homepage":"","size":25185,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fa24c3ee2969ff29bca73f4b646045fb2a93ed07","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":39093389,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA5MzM4OQ==","name":"azure-rest-api-specs","full_name":"Azure/azure-rest-api-specs","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs","forks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/deployments","created_at":"2015-07-14T18:37:13Z","updated_at":"2018-11-19T22:29:49Z","pushed_at":"2018-11-20T00:46:28Z","git_url":"git://github.com/Azure/azure-rest-api-specs.git","ssh_url":"git@github.com:Azure/azure-rest-api-specs.git","clone_url":"https://github.com/Azure/azure-rest-api-specs.git","svn_url":"https://github.com/Azure/azure-rest-api-specs","homepage":"","size":25926,"stargazers_count":362,"watchers_count":362,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1025,"mirror_url":null,"archived":false,"open_issues_count":332,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1025,"open_issues":332,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/4492"},"issue":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4492"},"comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4492/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4492/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/c5e3d7fb237ee96094a2198b3515dc48c03ceded"}},"author_association":"NONE"}}
{"actor":{"display_login":"amarzavery"}}