{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/23047","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/23047/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23047/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/23047/events","html_url":"https://github.com/mantidproject/mantid/pull/23047","id":343531468,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTQwOTc5","number":23047,"title":"Add polarization correction data to parameters file","user":{"login":"gemmaguest","id":12895056,"node_id":"MDQ6VXNlcjEyODk1MDU2","avatar_url":"https://avatars2.githubusercontent.com/u/12895056?v=4","gravatar_id":"","url":"https://api.github.com/users/gemmaguest","html_url":"https://github.com/gemmaguest","followers_url":"https://api.github.com/users/gemmaguest/followers","following_url":"https://api.github.com/users/gemmaguest/following{/other_user}","gists_url":"https://api.github.com/users/gemmaguest/gists{/gist_id}","starred_url":"https://api.github.com/users/gemmaguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemmaguest/subscriptions","organizations_url":"https://api.github.com/users/gemmaguest/orgs","repos_url":"https://api.github.com/users/gemmaguest/repos","events_url":"https://api.github.com/users/gemmaguest/events{/privacy}","received_events_url":"https://api.github.com/users/gemmaguest/received_events","type":"User","site_admin":false},"labels":[{"id":40342862,"node_id":"MDU6TGFiZWw0MDM0Mjg2Mg==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"Mantid-Matthew","id":32058966,"node_id":"MDQ6VXNlcjMyMDU4OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/32058966?v=4","gravatar_id":"","url":"https://api.github.com/users/Mantid-Matthew","html_url":"https://github.com/Mantid-Matthew","followers_url":"https://api.github.com/users/Mantid-Matthew/followers","following_url":"https://api.github.com/users/Mantid-Matthew/following{/other_user}","gists_url":"https://api.github.com/users/Mantid-Matthew/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantid-Matthew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantid-Matthew/subscriptions","organizations_url":"https://api.github.com/users/Mantid-Matthew/orgs","repos_url":"https://api.github.com/users/Mantid-Matthew/repos","events_url":"https://api.github.com/users/Mantid-Matthew/events{/privacy}","received_events_url":"https://api.github.com/users/Mantid-Matthew/received_events","type":"User","site_admin":false},"assignees":[{"login":"Mantid-Matthew","id":32058966,"node_id":"MDQ6VXNlcjMyMDU4OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/32058966?v=4","gravatar_id":"","url":"https://api.github.com/users/Mantid-Matthew","html_url":"https://github.com/Mantid-Matthew","followers_url":"https://api.github.com/users/Mantid-Matthew/followers","following_url":"https://api.github.com/users/Mantid-Matthew/following{/other_user}","gists_url":"https://api.github.com/users/Mantid-Matthew/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantid-Matthew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantid-Matthew/subscriptions","organizations_url":"https://api.github.com/users/Mantid-Matthew/orgs","repos_url":"https://api.github.com/users/Mantid-Matthew/repos","events_url":"https://api.github.com/users/Mantid-Matthew/events{/privacy}","received_events_url":"https://api.github.com/users/Mantid-Matthew/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/68","html_url":"https://github.com/mantidproject/mantid/milestone/68","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/68/labels","id":3113735,"node_id":"MDk6TWlsZXN0b25lMzExMzczNQ==","number":68,"title":"Release 3.14 (4.0?)","description":"Code freeze: 23rd Nov\r\nBeta test: 27th Nov - 11th Dec","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":256,"closed_issues":145,"state":"open","created_at":"2018-02-13T15:42:17Z","updated_at":"2018-08-15T15:33:07Z","due_on":"2018-12-17T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-07-23T08:14:54Z","updated_at":"2018-08-15T17:06:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23047","html_url":"https://github.com/mantidproject/mantid/pull/23047","diff_url":"https://github.com/mantidproject/mantid/pull/23047.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23047.patch"},"body":"**Report to:** Jos at ISIS\r\n\r\nThis PR adds polarization correction data to the offspec parameters file so that it can be used with the new polarization correction functionality in v3.13. It also adds a default for dQ/Q.\r\n\r\nFixes #23045\r\n\r\n**To test:**\r\n\r\n- Start MantidPlot and open ISIS Reflectometry interface.\r\n- Change instrument to OFFSPEC\r\n- From the Reflectometry menu, select `Import .tbl` and load this file (use any workspace name you like): [gui_test_table.zip](https://github.com/mantidproject/mantid/files/2218632/gui_test_table.zip)\r\n- Go to Settings tab and click the two \"Get Defaults\" buttons. **Check that the `dQ/Q` field in the first row in the table gets populated with the new default of `0.03`**\r\n- Select `ParameterFile` in PolarizationCorrection dropdown.\r\n- Return to Runs tab and click Process.\r\n- When reduction has finished (it will take a little while), click the \"Plot the selected group\" button. The results should look like this, with the red and green curves very close to zero:\r\n![23045_results_pol_cor_offspec](https://user-images.githubusercontent.com/12895056/43068282-efbaa8fa-8e61-11e8-94f5-7baffe42527e.png)\r\n\r\nDoes this update require release notes?\r\n- [ ] Yes\r\n- [x] No\r\n<!--\r\nIf yes, edit the file docs/source/release/... \r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/413265508","html_url":"https://github.com/mantidproject/mantid/pull/23047#issuecomment-413265508","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23047","id":413265508,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzI2NTUwOA==","user":{"login":"Mantid-Matthew","id":32058966,"node_id":"MDQ6VXNlcjMyMDU4OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/32058966?v=4","gravatar_id":"","url":"https://api.github.com/users/Mantid-Matthew","html_url":"https://github.com/Mantid-Matthew","followers_url":"https://api.github.com/users/Mantid-Matthew/followers","following_url":"https://api.github.com/users/Mantid-Matthew/following{/other_user}","gists_url":"https://api.github.com/users/Mantid-Matthew/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantid-Matthew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantid-Matthew/subscriptions","organizations_url":"https://api.github.com/users/Mantid-Matthew/orgs","repos_url":"https://api.github.com/users/Mantid-Matthew/repos","events_url":"https://api.github.com/users/Mantid-Matthew/events{/privacy}","received_events_url":"https://api.github.com/users/Mantid-Matthew/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T17:06:22Z","updated_at":"2018-08-15T17:06:22Z","author_association":"CONTRIBUTOR","body":"I see the correct value for dQ/Q get but not quite the same graph as it has two strange spikes in ?\r\n\r\n![image](https://user-images.githubusercontent.com/32058966/44161656-e5d0ef00-a0b5-11e8-872d-0388227bef84.png)\r\n\r\n\r\n"}}
{"actor":{"display_login":"Mantid-Matthew"}}