{"action":"closed","number":18851,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18851","id":226248266,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjQ4MjY2","html_url":"https://github.com/magento/magento2/pull/18851","diff_url":"https://github.com/magento/magento2/pull/18851.diff","patch_url":"https://github.com/magento/magento2/pull/18851.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/18851","number":18851,"state":"closed","locked":false,"title":"Fixes theme header logo and icon upload","user":{"login":"wiardvanrij","id":5786097,"node_id":"MDQ6VXNlcjU3ODYwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5786097?v=4","gravatar_id":"","url":"https://api.github.com/users/wiardvanrij","html_url":"https://github.com/wiardvanrij","followers_url":"https://api.github.com/users/wiardvanrij/followers","following_url":"https://api.github.com/users/wiardvanrij/following{/other_user}","gists_url":"https://api.github.com/users/wiardvanrij/gists{/gist_id}","starred_url":"https://api.github.com/users/wiardvanrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiardvanrij/subscriptions","organizations_url":"https://api.github.com/users/wiardvanrij/orgs","repos_url":"https://api.github.com/users/wiardvanrij/repos","events_url":"https://api.github.com/users/wiardvanrij/events{/privacy}","received_events_url":"https://api.github.com/users/wiardvanrij/received_events","type":"User","site_admin":false},"body":"### Description (*)\r\nWith the change of \"fileuploader\" to \"imageuploader\" the correct formElement was not updated to match the new \"imageuploader\". \r\n\r\n### Fixed Issues (if relevant)\r\n\r\n1. magento/magento2#18688: Unable to upload Logo, Magento 2.3.0 Beta18\r\n2. ...\r\n\r\n### Manual testing scenarios (*)\r\n\r\n1. Use magento2.3 development branche\r\n2. Content -> Design -> Configuration -> edit any Default Store View\r\n3. Other Settings -> Header -> try to upload a favicon or logo\r\n\r\n### Contribution checklist (*)\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-10-26T23:11:38Z","updated_at":"2018-10-31T20:11:08Z","closed_at":"2018-10-31T20:11:07Z","merged_at":"2018-10-31T20:11:07Z","merge_commit_sha":"ba69bfec127bed8c39c7d9e7b73d10b54449b158","assignee":{"login":"rogyar","id":2148959,"node_id":"MDQ6VXNlcjIxNDg5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2148959?v=4","gravatar_id":"","url":"https://api.github.com/users/rogyar","html_url":"https://github.com/rogyar","followers_url":"https://api.github.com/users/rogyar/followers","following_url":"https://api.github.com/users/rogyar/following{/other_user}","gists_url":"https://api.github.com/users/rogyar/gists{/gist_id}","starred_url":"https://api.github.com/users/rogyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogyar/subscriptions","organizations_url":"https://api.github.com/users/rogyar/orgs","repos_url":"https://api.github.com/users/rogyar/repos","events_url":"https://api.github.com/users/rogyar/events{/privacy}","received_events_url":"https://api.github.com/users/rogyar/received_events","type":"User","site_admin":false},"assignees":[{"login":"rogyar","id":2148959,"node_id":"MDQ6VXNlcjIxNDg5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2148959?v=4","gravatar_id":"","url":"https://api.github.com/users/rogyar","html_url":"https://github.com/rogyar","followers_url":"https://api.github.com/users/rogyar/followers","following_url":"https://api.github.com/users/rogyar/following{/other_user}","gists_url":"https://api.github.com/users/rogyar/gists{/gist_id}","starred_url":"https://api.github.com/users/rogyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogyar/subscriptions","organizations_url":"https://api.github.com/users/rogyar/orgs","repos_url":"https://api.github.com/users/rogyar/repos","events_url":"https://api.github.com/users/rogyar/events{/privacy}","received_events_url":"https://api.github.com/users/rogyar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":949392140,"node_id":"MDU6TGFiZWw5NDkzOTIxNDA=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Theme","name":"Component: Theme","color":"7fb703","default":false},{"id":1106054143,"node_id":"MDU6TGFiZWwxMTA2MDU0MTQz","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Redkiwi","name":"Partner: Redkiwi","color":"ededed","default":false},{"id":164491159,"node_id":"MDU6TGFiZWwxNjQ0OTExNTk=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20accept","name":"Progress: accept","color":"009800","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/23","html_url":"https://github.com/magento/magento2/milestone/23","labels_url":"https://api.github.com/repos/magento/magento2/milestones/23/labels","id":3664445,"node_id":"MDk6TWlsZXN0b25lMzY2NDQ0NQ==","number":23,"title":"Release: 2.3.1","description":"Community pull requests delivered to Release: 2.3.1 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":167,"state":"open","created_at":"2018-09-18T07:31:32Z","updated_at":"2018-10-31T20:11:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/magento/magento2/pulls/18851/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/18851/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18851/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/ba69bfec127bed8c39c7d9e7b73d10b54449b158","head":{"label":"wiardvanrij:logo-favicon-fix","ref":"logo-favicon-fix","sha":"ba69bfec127bed8c39c7d9e7b73d10b54449b158","user":{"login":"wiardvanrij","id":5786097,"node_id":"MDQ6VXNlcjU3ODYwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5786097?v=4","gravatar_id":"","url":"https://api.github.com/users/wiardvanrij","html_url":"https://github.com/wiardvanrij","followers_url":"https://api.github.com/users/wiardvanrij/followers","following_url":"https://api.github.com/users/wiardvanrij/following{/other_user}","gists_url":"https://api.github.com/users/wiardvanrij/gists{/gist_id}","starred_url":"https://api.github.com/users/wiardvanrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiardvanrij/subscriptions","organizations_url":"https://api.github.com/users/wiardvanrij/orgs","repos_url":"https://api.github.com/users/wiardvanrij/repos","events_url":"https://api.github.com/users/wiardvanrij/events{/privacy}","received_events_url":"https://api.github.com/users/wiardvanrij/received_events","type":"User","site_admin":false},"repo":{"id":103793127,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM3OTMxMjc=","name":"magento2","full_name":"wiardvanrij/magento2","private":false,"owner":{"login":"wiardvanrij","id":5786097,"node_id":"MDQ6VXNlcjU3ODYwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5786097?v=4","gravatar_id":"","url":"https://api.github.com/users/wiardvanrij","html_url":"https://github.com/wiardvanrij","followers_url":"https://api.github.com/users/wiardvanrij/followers","following_url":"https://api.github.com/users/wiardvanrij/following{/other_user}","gists_url":"https://api.github.com/users/wiardvanrij/gists{/gist_id}","starred_url":"https://api.github.com/users/wiardvanrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiardvanrij/subscriptions","organizations_url":"https://api.github.com/users/wiardvanrij/orgs","repos_url":"https://api.github.com/users/wiardvanrij/repos","events_url":"https://api.github.com/users/wiardvanrij/events{/privacy}","received_events_url":"https://api.github.com/users/wiardvanrij/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wiardvanrij/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/wiardvanrij/magento2","forks_url":"https://api.github.com/repos/wiardvanrij/magento2/forks","keys_url":"https://api.github.com/repos/wiardvanrij/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiardvanrij/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiardvanrij/magento2/teams","hooks_url":"https://api.github.com/repos/wiardvanrij/magento2/hooks","issue_events_url":"https://api.github.com/repos/wiardvanrij/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/wiardvanrij/magento2/events","assignees_url":"https://api.github.com/repos/wiardvanrij/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/wiardvanrij/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/wiardvanrij/magento2/tags","blobs_url":"https://api.github.com/repos/wiardvanrij/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiardvanrij/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiardvanrij/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiardvanrij/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiardvanrij/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/wiardvanrij/magento2/languages","stargazers_url":"https://api.github.com/repos/wiardvanrij/magento2/stargazers","contributors_url":"https://api.github.com/repos/wiardvanrij/magento2/contributors","subscribers_url":"https://api.github.com/repos/wiardvanrij/magento2/subscribers","subscription_url":"https://api.github.com/repos/wiardvanrij/magento2/subscription","commits_url":"https://api.github.com/repos/wiardvanrij/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiardvanrij/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiardvanrij/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiardvanrij/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiardvanrij/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/wiardvanrij/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiardvanrij/magento2/merges","archive_url":"https://api.github.com/repos/wiardvanrij/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiardvanrij/magento2/downloads","issues_url":"https://api.github.com/repos/wiardvanrij/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/wiardvanrij/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/wiardvanrij/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/wiardvanrij/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiardvanrij/magento2/labels{/name}","releases_url":"https://api.github.com/repos/wiardvanrij/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/wiardvanrij/magento2/deployments","created_at":"2017-09-17T00:45:18Z","updated_at":"2017-09-17T00:46:18Z","pushed_at":"2018-10-27T15:23:49Z","git_url":"git://github.com/wiardvanrij/magento2.git","ssh_url":"git@github.com:wiardvanrij/magento2.git","clone_url":"https://github.com/wiardvanrij/magento2.git","svn_url":"https://github.com/wiardvanrij/magento2","homepage":"http://www.magento.com","size":458374,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"eb27ac2c990a5f9d857b889d9f1fbdcd6a7d1de2","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-10-31T18:28:44Z","pushed_at":"2018-10-31T20:10:22Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":489366,"stargazers_count":6278,"watchers_count":6278,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5481,"mirror_url":null,"archived":false,"open_issues_count":1401,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5481,"open_issues":1401,"watchers":6278,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/18851"},"html":{"href":"https://github.com/magento/magento2/pull/18851"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/18851"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/18851/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/18851/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/18851/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/ba69bfec127bed8c39c7d9e7b73d10b54449b158"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"magento-engcom-team"}}