{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/14019","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/14019/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/14019/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/14019/events","html_url":"https://github.com/magento/magento2/pull/14019","id":303675883,"node_id":"MDExOlB1bGxSZXF1ZXN0MTczODg0NDI4","number":14019,"title":"12073 product repo get different sku case","user":{"login":"josh-carter","id":10022769,"node_id":"MDQ6VXNlcjEwMDIyNzY5","avatar_url":"https://avatars2.githubusercontent.com/u/10022769?v=4","gravatar_id":"","url":"https://api.github.com/users/josh-carter","html_url":"https://github.com/josh-carter","followers_url":"https://api.github.com/users/josh-carter/followers","following_url":"https://api.github.com/users/josh-carter/following{/other_user}","gists_url":"https://api.github.com/users/josh-carter/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-carter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-carter/subscriptions","organizations_url":"https://api.github.com/users/josh-carter/orgs","repos_url":"https://api.github.com/users/josh-carter/repos","events_url":"https://api.github.com/users/josh-carter/events{/privacy}","received_events_url":"https://api.github.com/users/josh-carter/received_events","type":"User","site_admin":false},"labels":[{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/needs%20update","name":"needs update","color":"b60205","default":false}],"state":"closed","locked":false,"assignee":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"assignees":[{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/20","html_url":"https://github.com/magento/magento2/milestone/20","labels_url":"https://api.github.com/repos/magento/magento2/milestones/20/labels","id":3383796,"node_id":"MDk6TWlsZXN0b25lMzM4Mzc5Ng==","number":20,"title":"Release: 2.2.6","description":"Community pull requests delivered to Release: 2.2.6 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":84,"state":"open","created_at":"2018-05-29T11:52:10Z","updated_at":"2018-06-18T14:52:40Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-03-08T23:54:37Z","updated_at":"2018-06-18T14:56:06Z","closed_at":"2018-06-18T14:48:36Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/14019","html_url":"https://github.com/magento/magento2/pull/14019","diff_url":"https://github.com/magento/magento2/pull/14019.diff","patch_url":"https://github.com/magento/magento2/pull/14019.patch"},"body":"<!--- Provide a general summary of the Pull Request in the Title above -->\r\n### Description\r\nTake an example Product with SKU `test_sku`\r\n\r\nIn ProductRepository currently, if we're using get() and pass the SKU `TesT_SKu` we would get an undefined index as described inside #12073.\r\n\r\nHowever It makes sense to be able to retrieve product using different cased SKU as the database is case insensitive and SKU is unique. But the PHP is case sensitive, therefore, to fix the problem we can lowercase the SKU in the PHP code.\r\n\r\n<!--- Provide a description of the changes proposed in the pull request -->\r\n\r\n### Fixed Issues (if relevant)\r\n<!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant  -->\r\n1. [magento/magento2#12073: ProductRepository fails to load product with camelcase SKU](https://github.com/magento/magento2/issues/12073)\r\n\r\n### Manual testing scenarios\r\n<!--- Provide a set of unambiguous steps to test the proposed code change -->\r\n1. Create Product with SKU `test_sku`\r\n2. Make a call to `ProductRepository::get('tESt_sKu')`\r\n3. Successfully retrieve created Product \r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/398083144","html_url":"https://github.com/magento/magento2/pull/14019#issuecomment-398083144","issue_url":"https://api.github.com/repos/magento/magento2/issues/14019","id":398083144,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODA4MzE0NA==","user":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T14:56:05Z","updated_at":"2018-06-18T14:56:05Z","author_association":"CONTRIBUTOR","body":"Sorry @josh-carter, my bad, I was supposed to help you with test here, I remember we started a talk in Slack. Will do it this week."}}
{"actor":{"display_login":"orlangur"}}