{"action":"created","comment":{"url":"https://api.github.com/repos/freshbooks/sqlcop/pulls/comments/207063380","pull_request_review_id":142599725,"id":207063380,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA2MzM4MA==","diff_hunk":"@@ -39,7 +40,8 @@ def __call__(self, stmt):\n                     tok.match(sqlparse.tokens.Keyword.DML, 'SELECT') or\n                     tok.match(sqlparse.tokens.Keyword, 'INNER JOIN') or\n                     tok.match(sqlparse.tokens.Keyword, 'GROUP') or\n-                    tok.match(sqlparse.tokens.Keyword, 'LEFT OUTER JOIN')):\n+                    tok.match(sqlparse.tokens.Keyword, 'LEFT OUTER JOIN') or\n+                    (isinstance(tok, sqlparse.sql.Identifier) and tok.value == 'LIMIT')):","path":"sqlcop/checks/cross_join.py","position":14,"original_position":14,"commit_id":"b7481ff1f03ae10b237b87f8ad7f2b034d1a896e","original_commit_id":"b7481ff1f03ae10b237b87f8ad7f2b034d1a896e","user":{"login":"wcarss","id":435879,"node_id":"MDQ6VXNlcjQzNTg3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/435879?v=4","gravatar_id":"","url":"https://api.github.com/users/wcarss","html_url":"https://github.com/wcarss","followers_url":"https://api.github.com/users/wcarss/followers","following_url":"https://api.github.com/users/wcarss/following{/other_user}","gists_url":"https://api.github.com/users/wcarss/gists{/gist_id}","starred_url":"https://api.github.com/users/wcarss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcarss/subscriptions","organizations_url":"https://api.github.com/users/wcarss/orgs","repos_url":"https://api.github.com/users/wcarss/repos","events_url":"https://api.github.com/users/wcarss/events{/privacy}","received_events_url":"https://api.github.com/users/wcarss/received_events","type":"User","site_admin":false},"body":"why does this pattern have to be so different?\r\n\r\n(I'm just curious because I don't really know much about sqlcop -- also, hi Jill!)","created_at":"2018-08-01T23:33:31Z","updated_at":"2018-08-01T23:33:39Z","html_url":"https://github.com/freshbooks/sqlcop/pull/5#discussion_r207063380","pull_request_url":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/freshbooks/sqlcop/pulls/comments/207063380"},"html":{"href":"https://github.com/freshbooks/sqlcop/pull/5#discussion_r207063380"},"pull_request":{"href":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5","id":205579777,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTc5Nzc3","html_url":"https://github.com/freshbooks/sqlcop/pull/5","diff_url":"https://github.com/freshbooks/sqlcop/pull/5.diff","patch_url":"https://github.com/freshbooks/sqlcop/pull/5.patch","issue_url":"https://api.github.com/repos/freshbooks/sqlcop/issues/5","number":5,"state":"open","locked":false,"title":"The LIMIT clause should not trigger cross join.","user":{"login":"iamjillsanluis","id":20261008,"node_id":"MDQ6VXNlcjIwMjYxMDA4","avatar_url":"https://avatars3.githubusercontent.com/u/20261008?v=4","gravatar_id":"","url":"https://api.github.com/users/iamjillsanluis","html_url":"https://github.com/iamjillsanluis","followers_url":"https://api.github.com/users/iamjillsanluis/followers","following_url":"https://api.github.com/users/iamjillsanluis/following{/other_user}","gists_url":"https://api.github.com/users/iamjillsanluis/gists{/gist_id}","starred_url":"https://api.github.com/users/iamjillsanluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamjillsanluis/subscriptions","organizations_url":"https://api.github.com/users/iamjillsanluis/orgs","repos_url":"https://api.github.com/users/iamjillsanluis/repos","events_url":"https://api.github.com/users/iamjillsanluis/events{/privacy}","received_events_url":"https://api.github.com/users/iamjillsanluis/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-01T23:21:15Z","updated_at":"2018-08-01T23:33:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c3f13dda1c3d6ebe6a5b734bf755509a3dfbdc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5/commits","review_comments_url":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5/comments","review_comment_url":"https://api.github.com/repos/freshbooks/sqlcop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freshbooks/sqlcop/issues/5/comments","statuses_url":"https://api.github.com/repos/freshbooks/sqlcop/statuses/b7481ff1f03ae10b237b87f8ad7f2b034d1a896e","head":{"label":"freshbooks:limit-cross-join-check","ref":"limit-cross-join-check","sha":"b7481ff1f03ae10b237b87f8ad7f2b034d1a896e","user":{"login":"freshbooks","id":22058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22058?v=4","gravatar_id":"","url":"https://api.github.com/users/freshbooks","html_url":"https://github.com/freshbooks","followers_url":"https://api.github.com/users/freshbooks/followers","following_url":"https://api.github.com/users/freshbooks/following{/other_user}","gists_url":"https://api.github.com/users/freshbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/freshbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freshbooks/subscriptions","organizations_url":"https://api.github.com/users/freshbooks/orgs","repos_url":"https://api.github.com/users/freshbooks/repos","events_url":"https://api.github.com/users/freshbooks/events{/privacy}","received_events_url":"https://api.github.com/users/freshbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":28151670,"node_id":"MDEwOlJlcG9zaXRvcnkyODE1MTY3MA==","name":"sqlcop","full_name":"freshbooks/sqlcop","owner":{"login":"freshbooks","id":22058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22058?v=4","gravatar_id":"","url":"https://api.github.com/users/freshbooks","html_url":"https://github.com/freshbooks","followers_url":"https://api.github.com/users/freshbooks/followers","following_url":"https://api.github.com/users/freshbooks/following{/other_user}","gists_url":"https://api.github.com/users/freshbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/freshbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freshbooks/subscriptions","organizations_url":"https://api.github.com/users/freshbooks/orgs","repos_url":"https://api.github.com/users/freshbooks/repos","events_url":"https://api.github.com/users/freshbooks/events{/privacy}","received_events_url":"https://api.github.com/users/freshbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freshbooks/sqlcop","description":"A cli tool that checks against common SQL anti-patterns","fork":false,"url":"https://api.github.com/repos/freshbooks/sqlcop","forks_url":"https://api.github.com/repos/freshbooks/sqlcop/forks","keys_url":"https://api.github.com/repos/freshbooks/sqlcop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freshbooks/sqlcop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freshbooks/sqlcop/teams","hooks_url":"https://api.github.com/repos/freshbooks/sqlcop/hooks","issue_events_url":"https://api.github.com/repos/freshbooks/sqlcop/issues/events{/number}","events_url":"https://api.github.com/repos/freshbooks/sqlcop/events","assignees_url":"https://api.github.com/repos/freshbooks/sqlcop/assignees{/user}","branches_url":"https://api.github.com/repos/freshbooks/sqlcop/branches{/branch}","tags_url":"https://api.github.com/repos/freshbooks/sqlcop/tags","blobs_url":"https://api.github.com/repos/freshbooks/sqlcop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freshbooks/sqlcop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freshbooks/sqlcop/git/refs{/sha}","trees_url":"https://api.github.com/repos/freshbooks/sqlcop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freshbooks/sqlcop/statuses/{sha}","languages_url":"https://api.github.com/repos/freshbooks/sqlcop/languages","stargazers_url":"https://api.github.com/repos/freshbooks/sqlcop/stargazers","contributors_url":"https://api.github.com/repos/freshbooks/sqlcop/contributors","subscribers_url":"https://api.github.com/repos/freshbooks/sqlcop/subscribers","subscription_url":"https://api.github.com/repos/freshbooks/sqlcop/subscription","commits_url":"https://api.github.com/repos/freshbooks/sqlcop/commits{/sha}","git_commits_url":"https://api.github.com/repos/freshbooks/sqlcop/git/commits{/sha}","comments_url":"https://api.github.com/repos/freshbooks/sqlcop/comments{/number}","issue_comment_url":"https://api.github.com/repos/freshbooks/sqlcop/issues/comments{/number}","contents_url":"https://api.github.com/repos/freshbooks/sqlcop/contents/{+path}","compare_url":"https://api.github.com/repos/freshbooks/sqlcop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freshbooks/sqlcop/merges","archive_url":"https://api.github.com/repos/freshbooks/sqlcop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freshbooks/sqlcop/downloads","issues_url":"https://api.github.com/repos/freshbooks/sqlcop/issues{/number}","pulls_url":"https://api.github.com/repos/freshbooks/sqlcop/pulls{/number}","milestones_url":"https://api.github.com/repos/freshbooks/sqlcop/milestones{/number}","notifications_url":"https://api.github.com/repos/freshbooks/sqlcop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freshbooks/sqlcop/labels{/name}","releases_url":"https://api.github.com/repos/freshbooks/sqlcop/releases{/id}","deployments_url":"https://api.github.com/repos/freshbooks/sqlcop/deployments","created_at":"2014-12-17T19:20:11Z","updated_at":"2018-05-24T19:50:49Z","pushed_at":"2018-08-01T23:21:15Z","git_url":"git://github.com/freshbooks/sqlcop.git","ssh_url":"git@github.com:freshbooks/sqlcop.git","clone_url":"https://github.com/freshbooks/sqlcop.git","svn_url":"https://github.com/freshbooks/sqlcop","homepage":null,"size":51,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"freshbooks:master","ref":"master","sha":"941d8fd71be682741d641bfae92d3a31547e3032","user":{"login":"freshbooks","id":22058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22058?v=4","gravatar_id":"","url":"https://api.github.com/users/freshbooks","html_url":"https://github.com/freshbooks","followers_url":"https://api.github.com/users/freshbooks/followers","following_url":"https://api.github.com/users/freshbooks/following{/other_user}","gists_url":"https://api.github.com/users/freshbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/freshbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freshbooks/subscriptions","organizations_url":"https://api.github.com/users/freshbooks/orgs","repos_url":"https://api.github.com/users/freshbooks/repos","events_url":"https://api.github.com/users/freshbooks/events{/privacy}","received_events_url":"https://api.github.com/users/freshbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":28151670,"node_id":"MDEwOlJlcG9zaXRvcnkyODE1MTY3MA==","name":"sqlcop","full_name":"freshbooks/sqlcop","owner":{"login":"freshbooks","id":22058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22058?v=4","gravatar_id":"","url":"https://api.github.com/users/freshbooks","html_url":"https://github.com/freshbooks","followers_url":"https://api.github.com/users/freshbooks/followers","following_url":"https://api.github.com/users/freshbooks/following{/other_user}","gists_url":"https://api.github.com/users/freshbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/freshbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freshbooks/subscriptions","organizations_url":"https://api.github.com/users/freshbooks/orgs","repos_url":"https://api.github.com/users/freshbooks/repos","events_url":"https://api.github.com/users/freshbooks/events{/privacy}","received_events_url":"https://api.github.com/users/freshbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freshbooks/sqlcop","description":"A cli tool that checks against common SQL anti-patterns","fork":false,"url":"https://api.github.com/repos/freshbooks/sqlcop","forks_url":"https://api.github.com/repos/freshbooks/sqlcop/forks","keys_url":"https://api.github.com/repos/freshbooks/sqlcop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freshbooks/sqlcop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freshbooks/sqlcop/teams","hooks_url":"https://api.github.com/repos/freshbooks/sqlcop/hooks","issue_events_url":"https://api.github.com/repos/freshbooks/sqlcop/issues/events{/number}","events_url":"https://api.github.com/repos/freshbooks/sqlcop/events","assignees_url":"https://api.github.com/repos/freshbooks/sqlcop/assignees{/user}","branches_url":"https://api.github.com/repos/freshbooks/sqlcop/branches{/branch}","tags_url":"https://api.github.com/repos/freshbooks/sqlcop/tags","blobs_url":"https://api.github.com/repos/freshbooks/sqlcop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freshbooks/sqlcop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freshbooks/sqlcop/git/refs{/sha}","trees_url":"https://api.github.com/repos/freshbooks/sqlcop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freshbooks/sqlcop/statuses/{sha}","languages_url":"https://api.github.com/repos/freshbooks/sqlcop/languages","stargazers_url":"https://api.github.com/repos/freshbooks/sqlcop/stargazers","contributors_url":"https://api.github.com/repos/freshbooks/sqlcop/contributors","subscribers_url":"https://api.github.com/repos/freshbooks/sqlcop/subscribers","subscription_url":"https://api.github.com/repos/freshbooks/sqlcop/subscription","commits_url":"https://api.github.com/repos/freshbooks/sqlcop/commits{/sha}","git_commits_url":"https://api.github.com/repos/freshbooks/sqlcop/git/commits{/sha}","comments_url":"https://api.github.com/repos/freshbooks/sqlcop/comments{/number}","issue_comment_url":"https://api.github.com/repos/freshbooks/sqlcop/issues/comments{/number}","contents_url":"https://api.github.com/repos/freshbooks/sqlcop/contents/{+path}","compare_url":"https://api.github.com/repos/freshbooks/sqlcop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freshbooks/sqlcop/merges","archive_url":"https://api.github.com/repos/freshbooks/sqlcop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freshbooks/sqlcop/downloads","issues_url":"https://api.github.com/repos/freshbooks/sqlcop/issues{/number}","pulls_url":"https://api.github.com/repos/freshbooks/sqlcop/pulls{/number}","milestones_url":"https://api.github.com/repos/freshbooks/sqlcop/milestones{/number}","notifications_url":"https://api.github.com/repos/freshbooks/sqlcop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freshbooks/sqlcop/labels{/name}","releases_url":"https://api.github.com/repos/freshbooks/sqlcop/releases{/id}","deployments_url":"https://api.github.com/repos/freshbooks/sqlcop/deployments","created_at":"2014-12-17T19:20:11Z","updated_at":"2018-05-24T19:50:49Z","pushed_at":"2018-08-01T23:21:15Z","git_url":"git://github.com/freshbooks/sqlcop.git","ssh_url":"git@github.com:freshbooks/sqlcop.git","clone_url":"https://github.com/freshbooks/sqlcop.git","svn_url":"https://github.com/freshbooks/sqlcop","homepage":null,"size":51,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5"},"html":{"href":"https://github.com/freshbooks/sqlcop/pull/5"},"issue":{"href":"https://api.github.com/repos/freshbooks/sqlcop/issues/5"},"comments":{"href":"https://api.github.com/repos/freshbooks/sqlcop/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/freshbooks/sqlcop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freshbooks/sqlcop/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/freshbooks/sqlcop/statuses/b7481ff1f03ae10b237b87f8ad7f2b034d1a896e"}},"author_association":"NONE"}}
{"actor":{"display_login":"wcarss"}}