{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/blurts-server/pulls/comments/219294897","pull_request_review_id":157437878,"id":219294897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTI5NDg5Nw==","diff_hunk":"@@ -44,3 +44,7 @@ HIBP_RELOAD_BREACHES_TIMER=600\n # HIBP API for range search and subscription\n HIBP_KANON_API_ROOT=\"https://api.haveibeenpwned.com\"\n HIBP_KANON_API_TOKEN=\"\"\n+# How many seconds to wait before retrying an HIBP request","path":".env-dist","position":4,"original_position":4,"commit_id":"088a243e416f0c4b8ac09bf83d2a33441b256773","original_commit_id":"088a243e416f0c4b8ac09bf83d2a33441b256773","user":{"login":"pdehaan","id":557895,"node_id":"MDQ6VXNlcjU1Nzg5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/557895?v=4","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"body":"Sorry, small nit/question...\r\n\r\nDid you mean \"seconds\" or \"milliseconds\"? I believe the code below implies milliseconds, whereas if it's seconds, we're talking about a 33.33 minute backoff.","created_at":"2018-09-20T19:47:09Z","updated_at":"2018-09-20T19:47:09Z","html_url":"https://github.com/mozilla/blurts-server/pull/432#discussion_r219294897","pull_request_url":"https://api.github.com/repos/mozilla/blurts-server/pulls/432","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/blurts-server/pulls/comments/219294897"},"html":{"href":"https://github.com/mozilla/blurts-server/pull/432#discussion_r219294897"},"pull_request":{"href":"https://api.github.com/repos/mozilla/blurts-server/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/blurts-server/pulls/432","id":217002216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDAyMjE2","html_url":"https://github.com/mozilla/blurts-server/pull/432","diff_url":"https://github.com/mozilla/blurts-server/pull/432.diff","patch_url":"https://github.com/mozilla/blurts-server/pull/432.patch","issue_url":"https://api.github.com/repos/mozilla/blurts-server/issues/432","number":432,"state":"open","locked":false,"title":"Check hibp scan response 415","user":{"login":"groovecoder","id":71928,"node_id":"MDQ6VXNlcjcxOTI4","avatar_url":"https://avatars0.githubusercontent.com/u/71928?v=4","gravatar_id":"","url":"https://api.github.com/users/groovecoder","html_url":"https://github.com/groovecoder","followers_url":"https://api.github.com/users/groovecoder/followers","following_url":"https://api.github.com/users/groovecoder/following{/other_user}","gists_url":"https://api.github.com/users/groovecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/groovecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groovecoder/subscriptions","organizations_url":"https://api.github.com/users/groovecoder/orgs","repos_url":"https://api.github.com/users/groovecoder/repos","events_url":"https://api.github.com/users/groovecoder/events{/privacy}","received_events_url":"https://api.github.com/users/groovecoder/received_events","type":"User","site_admin":false},"body":"Previously, the `hibp` module code caught and logged errors but didn't throw them up to calling code.\r\n\r\nThis meant that, for example, a `kAnonReq` scan that encountered an error connecting to HIBP (as we saw when our load test was throttled by Cloudflare) returned an `undefined` response, which was taken by the calling code to mean 0 breach results!\r\n\r\nThis PR:\r\n\r\n* Introduces `HIBP._throttledGot` which adds a configurable throttle on HIBP requests to help respect throttled responses\r\n* Throws HIBP connection errors up to calling code with a friendly message: \"Error connecting to HIBP.\"","created_at":"2018-09-20T14:52:52Z","updated_at":"2018-09-20T19:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be64d6c605827f6c7d80666efc669674d4785bef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/blurts-server/pulls/432/commits","review_comments_url":"https://api.github.com/repos/mozilla/blurts-server/pulls/432/comments","review_comment_url":"https://api.github.com/repos/mozilla/blurts-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/blurts-server/issues/432/comments","statuses_url":"https://api.github.com/repos/mozilla/blurts-server/statuses/088a243e416f0c4b8ac09bf83d2a33441b256773","head":{"label":"mozilla:check-hibp-scan-response-415","ref":"check-hibp-scan-response-415","sha":"088a243e416f0c4b8ac09bf83d2a33441b256773","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":109599429,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1OTk0Mjk=","name":"blurts-server","full_name":"mozilla/blurts-server","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/blurts-server","description":"Have your accounts been leaked or stolen in a data breach? Find out with Firefox Monitor, by Mozilla. This is the Firefox Monitor server-side code.","fork":false,"url":"https://api.github.com/repos/mozilla/blurts-server","forks_url":"https://api.github.com/repos/mozilla/blurts-server/forks","keys_url":"https://api.github.com/repos/mozilla/blurts-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/blurts-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/blurts-server/teams","hooks_url":"https://api.github.com/repos/mozilla/blurts-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/blurts-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/blurts-server/events","assignees_url":"https://api.github.com/repos/mozilla/blurts-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/blurts-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/blurts-server/tags","blobs_url":"https://api.github.com/repos/mozilla/blurts-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/blurts-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/blurts-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/blurts-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/blurts-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/blurts-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/blurts-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/blurts-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/blurts-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/blurts-server/subscription","commits_url":"https://api.github.com/repos/mozilla/blurts-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/blurts-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/blurts-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/blurts-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/blurts-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/blurts-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/blurts-server/merges","archive_url":"https://api.github.com/repos/mozilla/blurts-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/blurts-server/downloads","issues_url":"https://api.github.com/repos/mozilla/blurts-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/blurts-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/blurts-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/blurts-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/blurts-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/blurts-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/blurts-server/deployments","created_at":"2017-11-05T17:13:37Z","updated_at":"2018-09-20T17:25:17Z","pushed_at":"2018-09-20T19:41:17Z","git_url":"git://github.com/mozilla/blurts-server.git","ssh_url":"git@github.com:mozilla/blurts-server.git","clone_url":"https://github.com/mozilla/blurts-server.git","svn_url":"https://github.com/mozilla/blurts-server","homepage":"https://monitor.firefox.com/","size":8089,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":21,"open_issues":58,"watchers":108,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c46d049c8599d384617e4ce2d0b7840d7d6cce6f","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":109599429,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1OTk0Mjk=","name":"blurts-server","full_name":"mozilla/blurts-server","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/blurts-server","description":"Have your accounts been leaked or stolen in a data breach? Find out with Firefox Monitor, by Mozilla. This is the Firefox Monitor server-side code.","fork":false,"url":"https://api.github.com/repos/mozilla/blurts-server","forks_url":"https://api.github.com/repos/mozilla/blurts-server/forks","keys_url":"https://api.github.com/repos/mozilla/blurts-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/blurts-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/blurts-server/teams","hooks_url":"https://api.github.com/repos/mozilla/blurts-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/blurts-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/blurts-server/events","assignees_url":"https://api.github.com/repos/mozilla/blurts-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/blurts-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/blurts-server/tags","blobs_url":"https://api.github.com/repos/mozilla/blurts-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/blurts-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/blurts-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/blurts-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/blurts-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/blurts-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/blurts-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/blurts-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/blurts-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/blurts-server/subscription","commits_url":"https://api.github.com/repos/mozilla/blurts-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/blurts-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/blurts-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/blurts-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/blurts-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/blurts-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/blurts-server/merges","archive_url":"https://api.github.com/repos/mozilla/blurts-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/blurts-server/downloads","issues_url":"https://api.github.com/repos/mozilla/blurts-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/blurts-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/blurts-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/blurts-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/blurts-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/blurts-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/blurts-server/deployments","created_at":"2017-11-05T17:13:37Z","updated_at":"2018-09-20T17:25:17Z","pushed_at":"2018-09-20T19:41:17Z","git_url":"git://github.com/mozilla/blurts-server.git","ssh_url":"git@github.com:mozilla/blurts-server.git","clone_url":"https://github.com/mozilla/blurts-server.git","svn_url":"https://github.com/mozilla/blurts-server","homepage":"https://monitor.firefox.com/","size":8089,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":21,"open_issues":58,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/blurts-server/pulls/432"},"html":{"href":"https://github.com/mozilla/blurts-server/pull/432"},"issue":{"href":"https://api.github.com/repos/mozilla/blurts-server/issues/432"},"comments":{"href":"https://api.github.com/repos/mozilla/blurts-server/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/blurts-server/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/blurts-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/blurts-server/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/blurts-server/statuses/088a243e416f0c4b8ac09bf83d2a33441b256773"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pdehaan"}}