{"action":"created","comment":{"url":"https://api.github.com/repos/theupdateframework/notary/pulls/comments/225338470","pull_request_review_id":164922441,"id":225338470,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTMzODQ3MA==","diff_hunk":"@@ -0,0 +1,123 @@\n+syntax = \"proto3\";\n+\n+package grpckeystore;\n+\n+import \"google/protobuf/Empty.proto\";\n+\n+service GRPCKeyStore {\n+\n+    // NewKey allows they GRPC keystore to provide keypair\n+    // used for keystores that generate and never divulge private key\n+    rpc NewKey (NewKeyReq) returns (NewKeyRsp) {\n+    }\n+\n+    // Add a key to the GRPC keystore\n+    // AddKey maps to KeyStore.AddKey()\n+    rpc AddKey (AddKeyReq) returns (AddKeyRsp) {\n+    }\n+\n+    // Get a previously stored key from the GRPC keystore\n+    // GetKey maps to KeyStore.GetKey()\n+    rpc GetKey (GetKeyReq) returns (GetKeyRsp) {\n+    }\n+\n+    // Get specific key information from the GRPC keystore\n+    // GetKeyInfo maps to KeyStore.GetKeyInfo()\n+    rpc GetKeyInfo (GetKeyInfoReq) returns (GetKeyInfoRsp) {\n+    }\n+\n+    // List keys available in the GRPC keystore\n+    // ListKeys maps to KeyStore.ListKeys()\n+    rpc ListKeys (google.protobuf.Empty) returns (ListKeysRsp) {\n+    }\n+\n+    // Remove a key from the keystore\n+    // RemoveKey maps to KeyStore.RemoveKey()\n+    rpc RemoveKey (RemoveKeyReq) returns (RemoveKeyRsp) {\n+    }\n+\n+    // Sign a message with the specified key\n+    // Sign maps to PrivateKey.Sign()\n+    rpc Sign (SignReq) returns (SignRsp) {\n+    }\n+}\n+\n+\n+message NewKeyReq {\n+    string Gun = 1;          // see notary/tuf/data/types.go -> GUN type\n+    string Role = 2;         // see notary/tuf/data/types.go -> TUFTypes\n+    string Algorithm = 3;    // see notary/tuf/data/types.go -> Key types\n+    string SignatureAlgorithm = 4; // see notary/tuf/data/types.go -> Signature types\n+}\n+\n+message NewKeyRsp {\n+    string KeyId = 1;       // for NewKey, KeyId is generated by remote store\n+    string PublicKey = 2;   // Public Key in PEM format, Private Key is never shared\n+    string DebugMsg = 3;    // Optional informational string returned from remote\n+}\n+\n+message AddKeyReq {\n+    string KeyId = 1;","path":"trustmanager/grpckeystore/grpckeystore.proto","position":60,"original_position":60,"commit_id":"f2ff2c1848527c5582938fac18620f3e4235d405","original_commit_id":"f2ff2c1848527c5582938fac18620f3e4235d405","user":{"login":"endophage","id":1302091,"node_id":"MDQ6VXNlcjEzMDIwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1302091?v=4","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"body":"As the key ID is the TUF key ID, we'd probably always want the client to specify it, otherwise the server would have to understand how to generate a TUF key ID. \r\n\r\nThat being said, the ID would need to be generated by the GRPC client wrapper as the `KeyStore.AddKey` method doesn't take an ID. That's how all the other concrete `KeyStore` implementers work though so nothing strange there (https://github.com/theupdateframework/notary/blob/master/trustmanager/keystore.go#L105).","created_at":"2018-10-15T22:32:47Z","updated_at":"2018-10-15T22:32:48Z","html_url":"https://github.com/theupdateframework/notary/pull/1393#discussion_r225338470","pull_request_url":"https://api.github.com/repos/theupdateframework/notary/pulls/1393","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/theupdateframework/notary/pulls/comments/225338470"},"html":{"href":"https://github.com/theupdateframework/notary/pull/1393#discussion_r225338470"},"pull_request":{"href":"https://api.github.com/repos/theupdateframework/notary/pulls/1393"}},"in_reply_to_id":224387861},"pull_request":{"url":"https://api.github.com/repos/theupdateframework/notary/pulls/1393","id":221922419,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTIyNDE5","html_url":"https://github.com/theupdateframework/notary/pull/1393","diff_url":"https://github.com/theupdateframework/notary/pull/1393.diff","patch_url":"https://github.com/theupdateframework/notary/pull/1393.patch","issue_url":"https://api.github.com/repos/theupdateframework/notary/issues/1393","number":1393,"state":"open","locked":false,"title":"Proposed interface for GRPC remote keystore","user":{"login":"dbilling","id":11949638,"node_id":"MDQ6VXNlcjExOTQ5NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/11949638?v=4","gravatar_id":"","url":"https://api.github.com/users/dbilling","html_url":"https://github.com/dbilling","followers_url":"https://api.github.com/users/dbilling/followers","following_url":"https://api.github.com/users/dbilling/following{/other_user}","gists_url":"https://api.github.com/users/dbilling/gists{/gist_id}","starred_url":"https://api.github.com/users/dbilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbilling/subscriptions","organizations_url":"https://api.github.com/users/dbilling/orgs","repos_url":"https://api.github.com/users/dbilling/repos","events_url":"https://api.github.com/users/dbilling/events{/privacy}","received_events_url":"https://api.github.com/users/dbilling/received_events","type":"User","site_admin":false},"body":"Submitting this PR for initial review and discussion (not for merging)  of a grpc .proto service definition for a remote keystore as discussed in #1388\r\n\r\nMost of this .proto facilitates a remote implementation of the current notary Keystore interface.  NewKey() however is designed to be used by new proposed notary functionality as discussed in #1388 , which would allow a HSM to generate keypairs and never expose the private key.\r\n\r\nrelated issues: #1388\r\nSigned-off-by: Dave Billing <dave@davebilling.com>","created_at":"2018-10-10T20:28:09Z","updated_at":"2018-10-15T22:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0759d11b53531de34a2b45d2a7ca96d58b3b699","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theupdateframework/notary/pulls/1393/commits","review_comments_url":"https://api.github.com/repos/theupdateframework/notary/pulls/1393/comments","review_comment_url":"https://api.github.com/repos/theupdateframework/notary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theupdateframework/notary/issues/1393/comments","statuses_url":"https://api.github.com/repos/theupdateframework/notary/statuses/f2ff2c1848527c5582938fac18620f3e4235d405","head":{"label":"dbilling:1388-grpc-keystore-proto","ref":"1388-grpc-keystore-proto","sha":"f2ff2c1848527c5582938fac18620f3e4235d405","user":{"login":"dbilling","id":11949638,"node_id":"MDQ6VXNlcjExOTQ5NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/11949638?v=4","gravatar_id":"","url":"https://api.github.com/users/dbilling","html_url":"https://github.com/dbilling","followers_url":"https://api.github.com/users/dbilling/followers","following_url":"https://api.github.com/users/dbilling/following{/other_user}","gists_url":"https://api.github.com/users/dbilling/gists{/gist_id}","starred_url":"https://api.github.com/users/dbilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbilling/subscriptions","organizations_url":"https://api.github.com/users/dbilling/orgs","repos_url":"https://api.github.com/users/dbilling/repos","events_url":"https://api.github.com/users/dbilling/events{/privacy}","received_events_url":"https://api.github.com/users/dbilling/received_events","type":"User","site_admin":false},"repo":{"id":145763559,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NjM1NTk=","name":"notary","full_name":"dbilling/notary","private":false,"owner":{"login":"dbilling","id":11949638,"node_id":"MDQ6VXNlcjExOTQ5NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/11949638?v=4","gravatar_id":"","url":"https://api.github.com/users/dbilling","html_url":"https://github.com/dbilling","followers_url":"https://api.github.com/users/dbilling/followers","following_url":"https://api.github.com/users/dbilling/following{/other_user}","gists_url":"https://api.github.com/users/dbilling/gists{/gist_id}","starred_url":"https://api.github.com/users/dbilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbilling/subscriptions","organizations_url":"https://api.github.com/users/dbilling/orgs","repos_url":"https://api.github.com/users/dbilling/repos","events_url":"https://api.github.com/users/dbilling/events{/privacy}","received_events_url":"https://api.github.com/users/dbilling/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbilling/notary","description":"Notary is a project that allows anyone to have trust over arbitrary collections of data","fork":true,"url":"https://api.github.com/repos/dbilling/notary","forks_url":"https://api.github.com/repos/dbilling/notary/forks","keys_url":"https://api.github.com/repos/dbilling/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbilling/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbilling/notary/teams","hooks_url":"https://api.github.com/repos/dbilling/notary/hooks","issue_events_url":"https://api.github.com/repos/dbilling/notary/issues/events{/number}","events_url":"https://api.github.com/repos/dbilling/notary/events","assignees_url":"https://api.github.com/repos/dbilling/notary/assignees{/user}","branches_url":"https://api.github.com/repos/dbilling/notary/branches{/branch}","tags_url":"https://api.github.com/repos/dbilling/notary/tags","blobs_url":"https://api.github.com/repos/dbilling/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbilling/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbilling/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbilling/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbilling/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/dbilling/notary/languages","stargazers_url":"https://api.github.com/repos/dbilling/notary/stargazers","contributors_url":"https://api.github.com/repos/dbilling/notary/contributors","subscribers_url":"https://api.github.com/repos/dbilling/notary/subscribers","subscription_url":"https://api.github.com/repos/dbilling/notary/subscription","commits_url":"https://api.github.com/repos/dbilling/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbilling/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbilling/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbilling/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbilling/notary/contents/{+path}","compare_url":"https://api.github.com/repos/dbilling/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbilling/notary/merges","archive_url":"https://api.github.com/repos/dbilling/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbilling/notary/downloads","issues_url":"https://api.github.com/repos/dbilling/notary/issues{/number}","pulls_url":"https://api.github.com/repos/dbilling/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/dbilling/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/dbilling/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbilling/notary/labels{/name}","releases_url":"https://api.github.com/repos/dbilling/notary/releases{/id}","deployments_url":"https://api.github.com/repos/dbilling/notary/deployments","created_at":"2018-08-22T21:14:44Z","updated_at":"2018-08-22T21:14:47Z","pushed_at":"2018-10-10T19:40:43Z","git_url":"git://github.com/dbilling/notary.git","ssh_url":"git@github.com:dbilling/notary.git","clone_url":"https://github.com/dbilling/notary.git","svn_url":"https://github.com/dbilling/notary","homepage":"","size":32380,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theupdateframework:master","ref":"master","sha":"fb795b0bc868746ed2efa2cd7109346bc7ddf0a4","user":{"login":"theupdateframework","id":4633028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzMwMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4633028?v=4","gravatar_id":"","url":"https://api.github.com/users/theupdateframework","html_url":"https://github.com/theupdateframework","followers_url":"https://api.github.com/users/theupdateframework/followers","following_url":"https://api.github.com/users/theupdateframework/following{/other_user}","gists_url":"https://api.github.com/users/theupdateframework/gists{/gist_id}","starred_url":"https://api.github.com/users/theupdateframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theupdateframework/subscriptions","organizations_url":"https://api.github.com/users/theupdateframework/orgs","repos_url":"https://api.github.com/users/theupdateframework/repos","events_url":"https://api.github.com/users/theupdateframework/events{/privacy}","received_events_url":"https://api.github.com/users/theupdateframework/received_events","type":"Organization","site_admin":false},"repo":{"id":37743436,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc0MzQzNg==","name":"notary","full_name":"theupdateframework/notary","private":false,"owner":{"login":"theupdateframework","id":4633028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzMwMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4633028?v=4","gravatar_id":"","url":"https://api.github.com/users/theupdateframework","html_url":"https://github.com/theupdateframework","followers_url":"https://api.github.com/users/theupdateframework/followers","following_url":"https://api.github.com/users/theupdateframework/following{/other_user}","gists_url":"https://api.github.com/users/theupdateframework/gists{/gist_id}","starred_url":"https://api.github.com/users/theupdateframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theupdateframework/subscriptions","organizations_url":"https://api.github.com/users/theupdateframework/orgs","repos_url":"https://api.github.com/users/theupdateframework/repos","events_url":"https://api.github.com/users/theupdateframework/events{/privacy}","received_events_url":"https://api.github.com/users/theupdateframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theupdateframework/notary","description":"Notary is a project that allows anyone to have trust over arbitrary collections of data","fork":false,"url":"https://api.github.com/repos/theupdateframework/notary","forks_url":"https://api.github.com/repos/theupdateframework/notary/forks","keys_url":"https://api.github.com/repos/theupdateframework/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theupdateframework/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theupdateframework/notary/teams","hooks_url":"https://api.github.com/repos/theupdateframework/notary/hooks","issue_events_url":"https://api.github.com/repos/theupdateframework/notary/issues/events{/number}","events_url":"https://api.github.com/repos/theupdateframework/notary/events","assignees_url":"https://api.github.com/repos/theupdateframework/notary/assignees{/user}","branches_url":"https://api.github.com/repos/theupdateframework/notary/branches{/branch}","tags_url":"https://api.github.com/repos/theupdateframework/notary/tags","blobs_url":"https://api.github.com/repos/theupdateframework/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theupdateframework/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theupdateframework/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/theupdateframework/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theupdateframework/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/theupdateframework/notary/languages","stargazers_url":"https://api.github.com/repos/theupdateframework/notary/stargazers","contributors_url":"https://api.github.com/repos/theupdateframework/notary/contributors","subscribers_url":"https://api.github.com/repos/theupdateframework/notary/subscribers","subscription_url":"https://api.github.com/repos/theupdateframework/notary/subscription","commits_url":"https://api.github.com/repos/theupdateframework/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/theupdateframework/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/theupdateframework/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/theupdateframework/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/theupdateframework/notary/contents/{+path}","compare_url":"https://api.github.com/repos/theupdateframework/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theupdateframework/notary/merges","archive_url":"https://api.github.com/repos/theupdateframework/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theupdateframework/notary/downloads","issues_url":"https://api.github.com/repos/theupdateframework/notary/issues{/number}","pulls_url":"https://api.github.com/repos/theupdateframework/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/theupdateframework/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/theupdateframework/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theupdateframework/notary/labels{/name}","releases_url":"https://api.github.com/repos/theupdateframework/notary/releases{/id}","deployments_url":"https://api.github.com/repos/theupdateframework/notary/deployments","created_at":"2015-06-19T20:07:53Z","updated_at":"2018-10-15T02:20:07Z","pushed_at":"2018-10-15T15:07:14Z","git_url":"git://github.com/theupdateframework/notary.git","ssh_url":"git@github.com:theupdateframework/notary.git","clone_url":"https://github.com/theupdateframework/notary.git","svn_url":"https://github.com/theupdateframework/notary","homepage":"","size":32393,"stargazers_count":1550,"watchers_count":1550,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"archived":false,"open_issues_count":193,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":275,"open_issues":193,"watchers":1550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theupdateframework/notary/pulls/1393"},"html":{"href":"https://github.com/theupdateframework/notary/pull/1393"},"issue":{"href":"https://api.github.com/repos/theupdateframework/notary/issues/1393"},"comments":{"href":"https://api.github.com/repos/theupdateframework/notary/issues/1393/comments"},"review_comments":{"href":"https://api.github.com/repos/theupdateframework/notary/pulls/1393/comments"},"review_comment":{"href":"https://api.github.com/repos/theupdateframework/notary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theupdateframework/notary/pulls/1393/commits"},"statuses":{"href":"https://api.github.com/repos/theupdateframework/notary/statuses/f2ff2c1848527c5582938fac18620f3e4235d405"}},"author_association":"NONE"}}
{"actor":{"display_login":"endophage"}}