{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/comments/221604326","pull_request_review_id":160290374,"id":221604326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTYwNDMyNg==","diff_hunk":"@@ -52,4 +56,16 @@ public CartService(SphereClient client) {\n         // TODO 5.1 Add discount code to cart\n         return null;\n     }\n+    \n+\t/**\n+\t * Add shipping address to the cart\n+\t * \n+\t * @param cart\n+\t *            the cart\n+\t * @return completion state that sets the shipping address\n+\t */\n+\tpublic CompletionStage<Cart> addShippingAddress(final Cart cart) {","path":"src/main/java/handson/impl/CartService.java","position":29,"original_position":29,"commit_id":"fc73b6d90bf0dbaa1fc2c4c83083bec216dca0da","original_commit_id":"fc73b6d90bf0dbaa1fc2c4c83083bec216dca0da","user":{"login":"willemevertse","id":3184885,"node_id":"MDQ6VXNlcjMxODQ4ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3184885?v=4","gravatar_id":"","url":"https://api.github.com/users/willemevertse","html_url":"https://github.com/willemevertse","followers_url":"https://api.github.com/users/willemevertse/followers","following_url":"https://api.github.com/users/willemevertse/following{/other_user}","gists_url":"https://api.github.com/users/willemevertse/gists{/gist_id}","starred_url":"https://api.github.com/users/willemevertse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemevertse/subscriptions","organizations_url":"https://api.github.com/users/willemevertse/orgs","repos_url":"https://api.github.com/users/willemevertse/repos","events_url":"https://api.github.com/users/willemevertse/events{/privacy}","received_events_url":"https://api.github.com/users/willemevertse/received_events","type":"User","site_admin":false},"body":"yes that would be more efficient, but then i would have to give the answer to the exercise 3.1, which i think you want to leave open to students to answer. This is just a fix that prevents you from creating an order after u completed all the exercises because of the missing shipping address. See issue : https://github.com/commercetools/commercetools-jvm-sdk-training/issues/10","created_at":"2018-10-01T13:17:37Z","updated_at":"2018-10-01T13:17:37Z","html_url":"https://github.com/commercetools/commercetools-jvm-sdk-training/pull/15#discussion_r221604326","pull_request_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/comments/221604326"},"html":{"href":"https://github.com/commercetools/commercetools-jvm-sdk-training/pull/15#discussion_r221604326"},"pull_request":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15"}},"in_reply_to_id":221580189},"pull_request":{"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15","id":219299332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Mjk5MzMy","html_url":"https://github.com/commercetools/commercetools-jvm-sdk-training/pull/15","diff_url":"https://github.com/commercetools/commercetools-jvm-sdk-training/pull/15.diff","patch_url":"https://github.com/commercetools/commercetools-jvm-sdk-training/pull/15.patch","issue_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues/15","number":15,"state":"open","locked":false,"title":"fix missing shipping address error","user":{"login":"willemevertse","id":3184885,"node_id":"MDQ6VXNlcjMxODQ4ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3184885?v=4","gravatar_id":"","url":"https://api.github.com/users/willemevertse","html_url":"https://github.com/willemevertse","followers_url":"https://api.github.com/users/willemevertse/followers","following_url":"https://api.github.com/users/willemevertse/following{/other_user}","gists_url":"https://api.github.com/users/willemevertse/gists{/gist_id}","starred_url":"https://api.github.com/users/willemevertse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemevertse/subscriptions","organizations_url":"https://api.github.com/users/willemevertse/orgs","repos_url":"https://api.github.com/users/willemevertse/repos","events_url":"https://api.github.com/users/willemevertse/events{/privacy}","received_events_url":"https://api.github.com/users/willemevertse/received_events","type":"User","site_admin":false},"body":"fix missing shipping address error when creating an order from the cart.\r\nThis fix this issue : https://github.com/commercetools/commercetools-jvm-sdk-training/issues/10\r\n","created_at":"2018-10-01T08:46:05Z","updated_at":"2018-10-01T13:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b20c15316b8053db842d60f199022d9b2931905c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15/commits","review_comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15/comments","review_comment_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues/15/comments","statuses_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/statuses/fc73b6d90bf0dbaa1fc2c4c83083bec216dca0da","head":{"label":"willemevertse:fix-shipping-address","ref":"fix-shipping-address","sha":"fc73b6d90bf0dbaa1fc2c4c83083bec216dca0da","user":{"login":"willemevertse","id":3184885,"node_id":"MDQ6VXNlcjMxODQ4ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3184885?v=4","gravatar_id":"","url":"https://api.github.com/users/willemevertse","html_url":"https://github.com/willemevertse","followers_url":"https://api.github.com/users/willemevertse/followers","following_url":"https://api.github.com/users/willemevertse/following{/other_user}","gists_url":"https://api.github.com/users/willemevertse/gists{/gist_id}","starred_url":"https://api.github.com/users/willemevertse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemevertse/subscriptions","organizations_url":"https://api.github.com/users/willemevertse/orgs","repos_url":"https://api.github.com/users/willemevertse/repos","events_url":"https://api.github.com/users/willemevertse/events{/privacy}","received_events_url":"https://api.github.com/users/willemevertse/received_events","type":"User","site_admin":false},"repo":{"id":151057674,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwNTc2NzQ=","name":"commercetools-jvm-sdk-training","full_name":"willemevertse/commercetools-jvm-sdk-training","private":false,"owner":{"login":"willemevertse","id":3184885,"node_id":"MDQ6VXNlcjMxODQ4ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3184885?v=4","gravatar_id":"","url":"https://api.github.com/users/willemevertse","html_url":"https://github.com/willemevertse","followers_url":"https://api.github.com/users/willemevertse/followers","following_url":"https://api.github.com/users/willemevertse/following{/other_user}","gists_url":"https://api.github.com/users/willemevertse/gists{/gist_id}","starred_url":"https://api.github.com/users/willemevertse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemevertse/subscriptions","organizations_url":"https://api.github.com/users/willemevertse/orgs","repos_url":"https://api.github.com/users/willemevertse/repos","events_url":"https://api.github.com/users/willemevertse/events{/privacy}","received_events_url":"https://api.github.com/users/willemevertse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/willemevertse/commercetools-jvm-sdk-training","description":"Java project to learn the commercetools JVM SDK in a training","fork":true,"url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training","forks_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/forks","keys_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/teams","hooks_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/hooks","issue_events_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/issues/events{/number}","events_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/events","assignees_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/assignees{/user}","branches_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/branches{/branch}","tags_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/tags","blobs_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/git/refs{/sha}","trees_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/statuses/{sha}","languages_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/languages","stargazers_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/stargazers","contributors_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/contributors","subscribers_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/subscribers","subscription_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/subscription","commits_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/commits{/sha}","git_commits_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/git/commits{/sha}","comments_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/comments{/number}","issue_comment_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/issues/comments{/number}","contents_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/contents/{+path}","compare_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/merges","archive_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/downloads","issues_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/issues{/number}","pulls_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/pulls{/number}","milestones_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/milestones{/number}","notifications_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/labels{/name}","releases_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/releases{/id}","deployments_url":"https://api.github.com/repos/willemevertse/commercetools-jvm-sdk-training/deployments","created_at":"2018-10-01T08:28:50Z","updated_at":"2018-10-01T08:28:52Z","pushed_at":"2018-10-01T08:42:15Z","git_url":"git://github.com/willemevertse/commercetools-jvm-sdk-training.git","ssh_url":"git@github.com:willemevertse/commercetools-jvm-sdk-training.git","clone_url":"https://github.com/willemevertse/commercetools-jvm-sdk-training.git","svn_url":"https://github.com/willemevertse/commercetools-jvm-sdk-training","homepage":"","size":142,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"starter-project-exercises"}},"base":{"label":"commercetools:starter-project-exercises","ref":"starter-project-exercises","sha":"447d9572e86148b7e026f42e71e239d259883775","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":46560785,"node_id":"MDEwOlJlcG9zaXRvcnk0NjU2MDc4NQ==","name":"commercetools-jvm-sdk-training","full_name":"commercetools/commercetools-jvm-sdk-training","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/commercetools-jvm-sdk-training","description":"Java project to learn the commercetools JVM SDK in a training","fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training","forks_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/deployments","created_at":"2015-11-20T12:31:26Z","updated_at":"2018-09-26T16:06:01Z","pushed_at":"2018-10-01T08:46:06Z","git_url":"git://github.com/commercetools/commercetools-jvm-sdk-training.git","ssh_url":"git@github.com:commercetools/commercetools-jvm-sdk-training.git","clone_url":"https://github.com/commercetools/commercetools-jvm-sdk-training.git","svn_url":"https://github.com/commercetools/commercetools-jvm-sdk-training","homepage":"","size":142,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":7,"watchers":4,"default_branch":"starter-project-exercises"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15"},"html":{"href":"https://github.com/commercetools/commercetools-jvm-sdk-training/pull/15"},"issue":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues/15"},"comments":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/commercetools-jvm-sdk-training/statuses/fc73b6d90bf0dbaa1fc2c4c83083bec216dca0da"}},"author_association":"NONE"}}
{"actor":{"display_login":"willemevertse"}}