{"action":"created","issue":{"url":"https://api.github.com/repos/radare/radare2/issues/11522","repository_url":"https://api.github.com/repos/radare/radare2","labels_url":"https://api.github.com/repos/radare/radare2/issues/11522/labels{/name}","comments_url":"https://api.github.com/repos/radare/radare2/issues/11522/comments","events_url":"https://api.github.com/repos/radare/radare2/issues/11522/events","html_url":"https://github.com/radare/radare2/pull/11522","id":360256204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTU2NDQ1","number":11522,"title":"Fix signature of printf-like function (pointer) types","user":{"login":"nsajko","id":4944410,"node_id":"MDQ6VXNlcjQ5NDQ0MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4944410?v=4","gravatar_id":"","url":"https://api.github.com/users/nsajko","html_url":"https://github.com/nsajko","followers_url":"https://api.github.com/users/nsajko/followers","following_url":"https://api.github.com/users/nsajko/following{/other_user}","gists_url":"https://api.github.com/users/nsajko/gists{/gist_id}","starred_url":"https://api.github.com/users/nsajko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsajko/subscriptions","organizations_url":"https://api.github.com/users/nsajko/orgs","repos_url":"https://api.github.com/users/nsajko/repos","events_url":"https://api.github.com/users/nsajko/events{/privacy}","received_events_url":"https://api.github.com/users/nsajko/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2018-09-14T10:53:28Z","updated_at":"2018-09-15T21:15:10Z","closed_at":"2018-09-15T09:41:06Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/11522","html_url":"https://github.com/radare/radare2/pull/11522","diff_url":"https://github.com/radare/radare2/pull/11522.diff","patch_url":"https://github.com/radare/radare2/pull/11522.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/radare/radare2/issues/comments/421635897","html_url":"https://github.com/radare/radare2/pull/11522#issuecomment-421635897","issue_url":"https://api.github.com/repos/radare/radare2/issues/11522","id":421635897,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTYzNTg5Nw==","user":{"login":"nsajko","id":4944410,"node_id":"MDQ6VXNlcjQ5NDQ0MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4944410?v=4","gravatar_id":"","url":"https://api.github.com/users/nsajko","html_url":"https://github.com/nsajko","followers_url":"https://api.github.com/users/nsajko/followers","following_url":"https://api.github.com/users/nsajko/following{/other_user}","gists_url":"https://api.github.com/users/nsajko/gists{/gist_id}","starred_url":"https://api.github.com/users/nsajko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsajko/subscriptions","organizations_url":"https://api.github.com/users/nsajko/orgs","repos_url":"https://api.github.com/users/nsajko/repos","events_url":"https://api.github.com/users/nsajko/events{/privacy}","received_events_url":"https://api.github.com/users/nsajko/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T21:15:10Z","updated_at":"2018-09-15T21:15:10Z","author_association":"CONTRIBUTOR","body":"> I’m not a big fan of the restrict keyword, in fact it has been removed from the C++ standard because it is ignored by most compilers.\r\n\r\nI, too, think using `restrict` without a good reason in r2 would probably amount to premature optimization; but this is a case where we basically have to assume `restrict` is being used even if `restrict` is not in radare2 code, because PrintfCallback sometimes holds a pointer to `printf`, which has `restrict` in the type of the format string. Thus it would be more clear and documentary to use `restrict` in PrintfCallback, too.\r\n\r\nBTW, `restrict` is not ignored, see https://stackoverflow.com/questions/1965487/does-the-restrict-keyword-provide-significant-benefits-in-gcc-g"}}
{"actor":{"display_login":"nsajko"}}