{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tfjs/issues/332","repository_url":"https://api.github.com/repos/tensorflow/tfjs","labels_url":"https://api.github.com/repos/tensorflow/tfjs/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tfjs/issues/332/comments","events_url":"https://api.github.com/repos/tensorflow/tfjs/issues/332/events","html_url":"https://github.com/tensorflow/tfjs/issues/332","id":325798676,"number":332,"title":"Prevent users from converting a model that has no topology","user":{"login":"timotheebernard","id":910644,"avatar_url":"https://avatars2.githubusercontent.com/u/910644?v=4","gravatar_id":"","url":"https://api.github.com/users/timotheebernard","html_url":"https://github.com/timotheebernard","followers_url":"https://api.github.com/users/timotheebernard/followers","following_url":"https://api.github.com/users/timotheebernard/following{/other_user}","gists_url":"https://api.github.com/users/timotheebernard/gists{/gist_id}","starred_url":"https://api.github.com/users/timotheebernard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timotheebernard/subscriptions","organizations_url":"https://api.github.com/users/timotheebernard/orgs","repos_url":"https://api.github.com/users/timotheebernard/repos","events_url":"https://api.github.com/users/timotheebernard/events{/privacy}","received_events_url":"https://api.github.com/users/timotheebernard/received_events","type":"User","site_admin":false},"labels":[{"id":887851634,"url":"https://api.github.com/repos/tensorflow/tfjs/labels/converter","name":"converter","color":"7c2aa8","default":false}],"state":"open","locked":false,"assignee":{"login":"pyu10055","id":4018,"avatar_url":"https://avatars3.githubusercontent.com/u/4018?v=4","gravatar_id":"","url":"https://api.github.com/users/pyu10055","html_url":"https://github.com/pyu10055","followers_url":"https://api.github.com/users/pyu10055/followers","following_url":"https://api.github.com/users/pyu10055/following{/other_user}","gists_url":"https://api.github.com/users/pyu10055/gists{/gist_id}","starred_url":"https://api.github.com/users/pyu10055/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyu10055/subscriptions","organizations_url":"https://api.github.com/users/pyu10055/orgs","repos_url":"https://api.github.com/users/pyu10055/repos","events_url":"https://api.github.com/users/pyu10055/events{/privacy}","received_events_url":"https://api.github.com/users/pyu10055/received_events","type":"User","site_admin":false},"assignees":[{"login":"pyu10055","id":4018,"avatar_url":"https://avatars3.githubusercontent.com/u/4018?v=4","gravatar_id":"","url":"https://api.github.com/users/pyu10055","html_url":"https://github.com/pyu10055","followers_url":"https://api.github.com/users/pyu10055/followers","following_url":"https://api.github.com/users/pyu10055/following{/other_user}","gists_url":"https://api.github.com/users/pyu10055/gists{/gist_id}","starred_url":"https://api.github.com/users/pyu10055/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyu10055/subscriptions","organizations_url":"https://api.github.com/users/pyu10055/orgs","repos_url":"https://api.github.com/users/pyu10055/repos","events_url":"https://api.github.com/users/pyu10055/events{/privacy}","received_events_url":"https://api.github.com/users/pyu10055/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-05-23T17:14:27Z","updated_at":"2018-05-26T02:34:18Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"To get help from the community, check out our [Google group](https://groups.google.com/a/tensorflow.org/forum/#!forum/tfjs).\r\n\r\nHi everyone and thanks for the great work!\r\n\r\nFollowing this discussion https://groups.google.com/a/tensorflow.org/d/msg/tfjs/QV3n4NBDi70/pg2gCtdhCAAJ I'm creating this issue.\r\n\r\n#### Describe the problem or feature request\r\n\r\ntensorflowjs_converter does not prevent the user from exporting a keras h5 that only contains the weights (ex: keras save_weights_only=True). \r\nI've been able to export my \"weights only\" h5 to the web format, it resulted in a \"modelTopology: null\" in the model.json and an error when calling loadModel() (missing topology).\r\n\r\nAccording to @caisq, it is a bug as the converter expects both the topology and the weights to be present.\r\n\r\nIf no one has any objection, I think I will be able to come up with a pull request by the end of this week.\r\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tfjs/issues/comments/392229613","html_url":"https://github.com/tensorflow/tfjs/issues/332#issuecomment-392229613","issue_url":"https://api.github.com/repos/tensorflow/tfjs/issues/332","id":392229613,"user":{"login":"timotheebernard","id":910644,"avatar_url":"https://avatars2.githubusercontent.com/u/910644?v=4","gravatar_id":"","url":"https://api.github.com/users/timotheebernard","html_url":"https://github.com/timotheebernard","followers_url":"https://api.github.com/users/timotheebernard/followers","following_url":"https://api.github.com/users/timotheebernard/following{/other_user}","gists_url":"https://api.github.com/users/timotheebernard/gists{/gist_id}","starred_url":"https://api.github.com/users/timotheebernard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timotheebernard/subscriptions","organizations_url":"https://api.github.com/users/timotheebernard/orgs","repos_url":"https://api.github.com/users/timotheebernard/repos","events_url":"https://api.github.com/users/timotheebernard/events{/privacy}","received_events_url":"https://api.github.com/users/timotheebernard/received_events","type":"User","site_admin":false},"created_at":"2018-05-26T02:34:18Z","updated_at":"2018-05-26T02:34:18Z","author_association":"CONTRIBUTOR","body":"Hi @caisq, thanks for the precision.\r\nSo, if my understanding is correct, one should be able to export a model without topology but tfjs should check the presence of the topology for every IO (which is currently not the case).\r\n\r\nSince the issue name is \"Prevent users from converting a model that has no topology\", do you want me to close it or rename it \"Ensure model has topology for every IO\"?\r\n"}}
{"actor":{"display_login":"timotheebernard"}}