{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/176591811","pull_request_review_id":106325169,"id":176591811,"diff_hunk":"@@ -22,6 +22,8 @@ namespace Router {\n //   b.regex_match: Match will succeed if header value matches the value specified here.\n //   c.range_match: Match will succeed if header value lies within the range specified\n //     here, using half open interval semantics [start,end).\n+// For a regex match the configured regex string is stored on the 'value_' member to aid\n+// in debugging.","path":"source/common/router/config_utility.cc","position":5,"original_position":5,"commit_id":"d895cd21e829090a18290306a3e4c0d1fd23cdd1","original_commit_id":"d895cd21e829090a18290306a3e4c0d1fd23cdd1","user":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"body":"Won't logging be sufficient? I think it's generally better to avoid adding debug stuff to release builds like this, despite the fact it's mostly harmless here.","created_at":"2018-03-22T22:31:46Z","updated_at":"2018-03-22T22:31:46Z","html_url":"https://github.com/envoyproxy/envoy/pull/2876#discussion_r176591811","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/176591811"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2876#discussion_r176591811"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876","id":176866566,"html_url":"https://github.com/envoyproxy/envoy/pull/2876","diff_url":"https://github.com/envoyproxy/envoy/pull/2876.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2876.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2876","number":2876,"state":"open","locked":false,"title":"config_utility: Keep configured regex string for debug logging.","user":{"login":"jrajahalme","id":6518235,"avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"body":"Use the HeaderData value_ member to store the configured regex string\r\nfor debugging purposes.\r\n\r\nSigned-off-by: Jarno Rajahalme <jarno@covalent.io>\r\nRisk Level: Low\r\n","created_at":"2018-03-22T18:14:49Z","updated_at":"2018-03-22T22:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e93f44f8cdd85d1bdcf9fc5c836b90174c1247e3","assignee":{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"assignees":[{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2876/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/d895cd21e829090a18290306a3e4c0d1fd23cdd1","head":{"label":"jrajahalme:utility-keep-regex-string","ref":"utility-keep-regex-string","sha":"d895cd21e829090a18290306a3e4c0d1fd23cdd1","user":{"login":"jrajahalme","id":6518235,"avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"repo":{"id":93890834,"name":"envoy","full_name":"jrajahalme/envoy","owner":{"login":"jrajahalme","id":6518235,"avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrajahalme/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/jrajahalme/envoy","forks_url":"https://api.github.com/repos/jrajahalme/envoy/forks","keys_url":"https://api.github.com/repos/jrajahalme/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrajahalme/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrajahalme/envoy/teams","hooks_url":"https://api.github.com/repos/jrajahalme/envoy/hooks","issue_events_url":"https://api.github.com/repos/jrajahalme/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/jrajahalme/envoy/events","assignees_url":"https://api.github.com/repos/jrajahalme/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/jrajahalme/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/jrajahalme/envoy/tags","blobs_url":"https://api.github.com/repos/jrajahalme/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrajahalme/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrajahalme/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrajahalme/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrajahalme/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/jrajahalme/envoy/languages","stargazers_url":"https://api.github.com/repos/jrajahalme/envoy/stargazers","contributors_url":"https://api.github.com/repos/jrajahalme/envoy/contributors","subscribers_url":"https://api.github.com/repos/jrajahalme/envoy/subscribers","subscription_url":"https://api.github.com/repos/jrajahalme/envoy/subscription","commits_url":"https://api.github.com/repos/jrajahalme/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrajahalme/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrajahalme/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrajahalme/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrajahalme/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/jrajahalme/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrajahalme/envoy/merges","archive_url":"https://api.github.com/repos/jrajahalme/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrajahalme/envoy/downloads","issues_url":"https://api.github.com/repos/jrajahalme/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/jrajahalme/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/jrajahalme/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/jrajahalme/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrajahalme/envoy/labels{/name}","releases_url":"https://api.github.com/repos/jrajahalme/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/jrajahalme/envoy/deployments","created_at":"2017-06-09T19:31:57Z","updated_at":"2018-03-22T22:31:02Z","pushed_at":"2018-03-22T22:31:00Z","git_url":"git://github.com/jrajahalme/envoy.git","ssh_url":"git@github.com:jrajahalme/envoy.git","clone_url":"https://github.com/jrajahalme/envoy.git","svn_url":"https://github.com/jrajahalme/envoy","homepage":"https://lyft.github.io/envoy","size":33041,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"7241be40a3e1cdb450a8a1feb4f468dd3e695f00","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-03-22T22:12:36Z","pushed_at":"2018-03-22T22:27:59Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://envoyproxy.github.io/","size":13037,"stargazers_count":4239,"watchers_count":4239,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":522,"mirror_url":null,"archived":false,"open_issues_count":264,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":522,"open_issues":264,"watchers":4239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2876"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2876"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2876/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2876/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/d895cd21e829090a18290306a3e4c0d1fd23cdd1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"htuch"}}