{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-go/issues/1932","repository_url":"https://api.github.com/repos/Microsoft/vscode-go","labels_url":"https://api.github.com/repos/Microsoft/vscode-go/issues/1932/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-go/issues/1932/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-go/issues/1932/events","html_url":"https://github.com/Microsoft/vscode-go/pull/1932","id":361084071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTQ1NTU2","number":1932,"title":"add support for the experimental version of gocode running on go/packages","user":{"login":"stamblerre","id":5856771,"node_id":"MDQ6VXNlcjU4NTY3NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5856771?v=4","gravatar_id":"","url":"https://api.github.com/users/stamblerre","html_url":"https://github.com/stamblerre","followers_url":"https://api.github.com/users/stamblerre/followers","following_url":"https://api.github.com/users/stamblerre/following{/other_user}","gists_url":"https://api.github.com/users/stamblerre/gists{/gist_id}","starred_url":"https://api.github.com/users/stamblerre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stamblerre/subscriptions","organizations_url":"https://api.github.com/users/stamblerre/orgs","repos_url":"https://api.github.com/users/stamblerre/repos","events_url":"https://api.github.com/users/stamblerre/events{/privacy}","received_events_url":"https://api.github.com/users/stamblerre/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-09-17T23:44:39Z","updated_at":"2018-09-25T01:59:09Z","closed_at":"2018-09-21T19:38:19Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-go/pulls/1932","html_url":"https://github.com/Microsoft/vscode-go/pull/1932","diff_url":"https://github.com/Microsoft/vscode-go/pull/1932.diff","patch_url":"https://github.com/Microsoft/vscode-go/pull/1932.patch"},"body":"This PR adds support for installing and switching between the regular version of certain Go tools and the versions that run on-top of [go/packages](https://godoc.org/golang.org/x/tools/go/packages) (which works with Modules). \r\n\r\nIf the user is in a directory with a go.mod file, `gocode-gomod` will be executed, whereas if the user is in a normal `$GOPATH` workspace, the normal version will be executed. This allows users to test out their usual Go tools with Modules, while avoiding any bugs that may still be present, since these tools are still quite new.\r\n\r\nFor now, only gocode switches between `gocode-gomod` and `gocode`. `godef-gomod` can be downloaded, but it's not yet added in this change. Ideally, the version of the tool to run should be decided in a function like `getBinPath`, but I wanted to test one tool before using that approach."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-go/issues/comments/424182022","html_url":"https://github.com/Microsoft/vscode-go/pull/1932#issuecomment-424182022","issue_url":"https://api.github.com/repos/Microsoft/vscode-go/issues/1932","id":424182022,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDE4MjAyMg==","user":{"login":"stamblerre","id":5856771,"node_id":"MDQ6VXNlcjU4NTY3NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5856771?v=4","gravatar_id":"","url":"https://api.github.com/users/stamblerre","html_url":"https://github.com/stamblerre","followers_url":"https://api.github.com/users/stamblerre/followers","following_url":"https://api.github.com/users/stamblerre/following{/other_user}","gists_url":"https://api.github.com/users/stamblerre/gists{/gist_id}","starred_url":"https://api.github.com/users/stamblerre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stamblerre/subscriptions","organizations_url":"https://api.github.com/users/stamblerre/orgs","repos_url":"https://api.github.com/users/stamblerre/repos","events_url":"https://api.github.com/users/stamblerre/events{/privacy}","received_events_url":"https://api.github.com/users/stamblerre/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T01:59:09Z","updated_at":"2018-09-25T01:59:09Z","author_association":"CONTRIBUTOR","body":"Oh, so is the only problem you're seeing related to completing with unsaved imports?"}}
{"actor":{"display_login":"stamblerre"}}