{"action":"created","comment":{"url":"https://api.github.com/repos/airtasker/web-components/pulls/comments/211138976","pull_request_review_id":147498522,"id":211138976,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEzODk3Ng==","diff_hunk":"@@ -0,0 +1,169 @@\n+import componentFromProp from 'recompose/componentFromProp';\n+import React, { PureComponent } from 'react';\n+import PropTypes from 'prop-types';\n+import { ifProp, prop } from 'styled-tools';\n+import styled, { css } from 'styled-components';\n+import { font } from '../styles/typography';\n+import { margin, padding } from '../styles/spacing';\n+\n+const typographyStyles = {\n+  h1: css`\n+    ${font(21, 5)};\n+    line-height: 52px;\n+    letter-spacing: -0.25;\n+  `,\n+  h2: css`\n+    ${font(16, 5)};\n+    line-height: 40px;\n+    letter-spacing: -0.15;\n+  `,\n+  h3: css`\n+    ${font(11, 5)};\n+    line-height: 32px;\n+    letter-spacing: -0.15;\n+  `,\n+  h4: css`\n+    ${font(8, 7)};\n+    line-height: 32px;\n+    letter-spacing: 0.15;\n+  `,\n+  h5: css`\n+    ${ifProp('isBold', font(6, 9), font(6, 5))};\n+    letter-spacing: 0.15px;\n+    line-height: 24px;\n+  `,\n+  body: css`\n+    ${ifProp('isBold', font(4, 7), font(4, 5))};\n+    letter-spacing: 0.2px;\n+    line-height: 24px;\n+  `,\n+  caption1: css`\n+    ${font(2, 5)};\n+    letter-spacing: 0.25px;\n+    line-height: 20px;\n+  `,\n+  caption2: css`\n+    ${font(0, 5)};\n+    letter-spacing: 0.25px;\n+    line-height: 16px;\n+  `,\n+  overline: css`\n+    ${font(0, 9)};\n+    letter-spacing: 1px;\n+    line-height: 16px;\n+    text-transform: uppercase;\n+  `,\n+};\n+\n+const TypographyComponent = componentFromProp('component');\n+\n+const StyledTypographyComponent = styled(TypographyComponent)`\n+  ${prop('customstyle')};\n+  ${margin(0)};\n+  ${padding(0)};\n+`;\n+\n+class Text extends PureComponent {","path":"src/Text/index.js","position":177,"original_position":66,"commit_id":"fa2007574185734ea9a9cadca44b33af84626d1f","original_commit_id":"b16e1cf0f84bc6c95d8f95d59aedf12cca8f99d5","user":{"login":"ericchenak","id":33011010,"node_id":"MDQ6VXNlcjMzMDExMDEw","avatar_url":"https://avatars1.githubusercontent.com/u/33011010?v=4","gravatar_id":"","url":"https://api.github.com/users/ericchenak","html_url":"https://github.com/ericchenak","followers_url":"https://api.github.com/users/ericchenak/followers","following_url":"https://api.github.com/users/ericchenak/following{/other_user}","gists_url":"https://api.github.com/users/ericchenak/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchenak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchenak/subscriptions","organizations_url":"https://api.github.com/users/ericchenak/orgs","repos_url":"https://api.github.com/users/ericchenak/repos","events_url":"https://api.github.com/users/ericchenak/events{/privacy}","received_events_url":"https://api.github.com/users/ericchenak/received_events","type":"User","site_admin":false},"body":"@driesg No global CSS, I think this should be a hard rule. \r\nImagine if we want build vision project as mini components to integrate in our current project, and both have different global `H3` style...","created_at":"2018-08-20T04:32:18Z","updated_at":"2018-08-20T04:32:18Z","html_url":"https://github.com/airtasker/web-components/pull/17#discussion_r211138976","pull_request_url":"https://api.github.com/repos/airtasker/web-components/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/airtasker/web-components/pulls/comments/211138976"},"html":{"href":"https://github.com/airtasker/web-components/pull/17#discussion_r211138976"},"pull_request":{"href":"https://api.github.com/repos/airtasker/web-components/pulls/17"}},"in_reply_to_id":207418261},"pull_request":{"url":"https://api.github.com/repos/airtasker/web-components/pulls/17","id":199967026,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTY3MDI2","html_url":"https://github.com/airtasker/web-components/pull/17","diff_url":"https://github.com/airtasker/web-components/pull/17.diff","patch_url":"https://github.com/airtasker/web-components/pull/17.patch","issue_url":"https://api.github.com/repos/airtasker/web-components/issues/17","number":17,"state":"open","locked":false,"title":"[DES-178] Update typography to new set #feature","user":{"login":"bssmain","id":6108586,"node_id":"MDQ6VXNlcjYxMDg1ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/6108586?v=4","gravatar_id":"","url":"https://api.github.com/users/bssmain","html_url":"https://github.com/bssmain","followers_url":"https://api.github.com/users/bssmain/followers","following_url":"https://api.github.com/users/bssmain/following{/other_user}","gists_url":"https://api.github.com/users/bssmain/gists{/gist_id}","starred_url":"https://api.github.com/users/bssmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bssmain/subscriptions","organizations_url":"https://api.github.com/users/bssmain/orgs","repos_url":"https://api.github.com/users/bssmain/repos","events_url":"https://api.github.com/users/bssmain/events{/privacy}","received_events_url":"https://api.github.com/users/bssmain/received_events","type":"User","site_admin":false},"body":"Quick and dirty implementation on typography. Can you guys think of a better way to do this? Seems like it doesnt really have a rhythm to it so it cant fit into modular scale.\r\n\r\nView https://airtasker.atlassian.net/browse/DES-178 for the font sizing and line heights. Does not seem like it will fit into a modular scale type format. Worried that applying modular scale onto it will cause final products to not match design 100%","created_at":"2018-07-08T23:38:01Z","updated_at":"2018-08-20T04:32:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e61e708fe308e6213766e6efd8476129487dbc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"barbyq","id":1483946,"node_id":"MDQ6VXNlcjE0ODM5NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1483946?v=4","gravatar_id":"","url":"https://api.github.com/users/barbyq","html_url":"https://github.com/barbyq","followers_url":"https://api.github.com/users/barbyq/followers","following_url":"https://api.github.com/users/barbyq/following{/other_user}","gists_url":"https://api.github.com/users/barbyq/gists{/gist_id}","starred_url":"https://api.github.com/users/barbyq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barbyq/subscriptions","organizations_url":"https://api.github.com/users/barbyq/orgs","repos_url":"https://api.github.com/users/barbyq/repos","events_url":"https://api.github.com/users/barbyq/events{/privacy}","received_events_url":"https://api.github.com/users/barbyq/received_events","type":"User","site_admin":false},{"login":"nigelwtf","id":4311224,"node_id":"MDQ6VXNlcjQzMTEyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4311224?v=4","gravatar_id":"","url":"https://api.github.com/users/nigelwtf","html_url":"https://github.com/nigelwtf","followers_url":"https://api.github.com/users/nigelwtf/followers","following_url":"https://api.github.com/users/nigelwtf/following{/other_user}","gists_url":"https://api.github.com/users/nigelwtf/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelwtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelwtf/subscriptions","organizations_url":"https://api.github.com/users/nigelwtf/orgs","repos_url":"https://api.github.com/users/nigelwtf/repos","events_url":"https://api.github.com/users/nigelwtf/events{/privacy}","received_events_url":"https://api.github.com/users/nigelwtf/received_events","type":"User","site_admin":false},{"login":"hbhrugubanda","id":8406185,"node_id":"MDQ6VXNlcjg0MDYxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/8406185?v=4","gravatar_id":"","url":"https://api.github.com/users/hbhrugubanda","html_url":"https://github.com/hbhrugubanda","followers_url":"https://api.github.com/users/hbhrugubanda/followers","following_url":"https://api.github.com/users/hbhrugubanda/following{/other_user}","gists_url":"https://api.github.com/users/hbhrugubanda/gists{/gist_id}","starred_url":"https://api.github.com/users/hbhrugubanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbhrugubanda/subscriptions","organizations_url":"https://api.github.com/users/hbhrugubanda/orgs","repos_url":"https://api.github.com/users/hbhrugubanda/repos","events_url":"https://api.github.com/users/hbhrugubanda/events{/privacy}","received_events_url":"https://api.github.com/users/hbhrugubanda/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/airtasker/web-components/pulls/17/commits","review_comments_url":"https://api.github.com/repos/airtasker/web-components/pulls/17/comments","review_comment_url":"https://api.github.com/repos/airtasker/web-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airtasker/web-components/issues/17/comments","statuses_url":"https://api.github.com/repos/airtasker/web-components/statuses/fa2007574185734ea9a9cadca44b33af84626d1f","head":{"label":"airtasker:DES-178-Update-typography-to-new-set","ref":"DES-178-Update-typography-to-new-set","sha":"fa2007574185734ea9a9cadca44b33af84626d1f","user":{"login":"airtasker","id":1745680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDU2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1745680?v=4","gravatar_id":"","url":"https://api.github.com/users/airtasker","html_url":"https://github.com/airtasker","followers_url":"https://api.github.com/users/airtasker/followers","following_url":"https://api.github.com/users/airtasker/following{/other_user}","gists_url":"https://api.github.com/users/airtasker/gists{/gist_id}","starred_url":"https://api.github.com/users/airtasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airtasker/subscriptions","organizations_url":"https://api.github.com/users/airtasker/orgs","repos_url":"https://api.github.com/users/airtasker/repos","events_url":"https://api.github.com/users/airtasker/events{/privacy}","received_events_url":"https://api.github.com/users/airtasker/received_events","type":"Organization","site_admin":false},"repo":{"id":122567879,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1Njc4Nzk=","name":"web-components","full_name":"airtasker/web-components","owner":{"login":"airtasker","id":1745680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDU2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1745680?v=4","gravatar_id":"","url":"https://api.github.com/users/airtasker","html_url":"https://github.com/airtasker","followers_url":"https://api.github.com/users/airtasker/followers","following_url":"https://api.github.com/users/airtasker/following{/other_user}","gists_url":"https://api.github.com/users/airtasker/gists{/gist_id}","starred_url":"https://api.github.com/users/airtasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airtasker/subscriptions","organizations_url":"https://api.github.com/users/airtasker/orgs","repos_url":"https://api.github.com/users/airtasker/repos","events_url":"https://api.github.com/users/airtasker/events{/privacy}","received_events_url":"https://api.github.com/users/airtasker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airtasker/web-components","description":"Web Components","fork":false,"url":"https://api.github.com/repos/airtasker/web-components","forks_url":"https://api.github.com/repos/airtasker/web-components/forks","keys_url":"https://api.github.com/repos/airtasker/web-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airtasker/web-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airtasker/web-components/teams","hooks_url":"https://api.github.com/repos/airtasker/web-components/hooks","issue_events_url":"https://api.github.com/repos/airtasker/web-components/issues/events{/number}","events_url":"https://api.github.com/repos/airtasker/web-components/events","assignees_url":"https://api.github.com/repos/airtasker/web-components/assignees{/user}","branches_url":"https://api.github.com/repos/airtasker/web-components/branches{/branch}","tags_url":"https://api.github.com/repos/airtasker/web-components/tags","blobs_url":"https://api.github.com/repos/airtasker/web-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airtasker/web-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airtasker/web-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/airtasker/web-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airtasker/web-components/statuses/{sha}","languages_url":"https://api.github.com/repos/airtasker/web-components/languages","stargazers_url":"https://api.github.com/repos/airtasker/web-components/stargazers","contributors_url":"https://api.github.com/repos/airtasker/web-components/contributors","subscribers_url":"https://api.github.com/repos/airtasker/web-components/subscribers","subscription_url":"https://api.github.com/repos/airtasker/web-components/subscription","commits_url":"https://api.github.com/repos/airtasker/web-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/airtasker/web-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/airtasker/web-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/airtasker/web-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/airtasker/web-components/contents/{+path}","compare_url":"https://api.github.com/repos/airtasker/web-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airtasker/web-components/merges","archive_url":"https://api.github.com/repos/airtasker/web-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airtasker/web-components/downloads","issues_url":"https://api.github.com/repos/airtasker/web-components/issues{/number}","pulls_url":"https://api.github.com/repos/airtasker/web-components/pulls{/number}","milestones_url":"https://api.github.com/repos/airtasker/web-components/milestones{/number}","notifications_url":"https://api.github.com/repos/airtasker/web-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airtasker/web-components/labels{/name}","releases_url":"https://api.github.com/repos/airtasker/web-components/releases{/id}","deployments_url":"https://api.github.com/repos/airtasker/web-components/deployments","created_at":"2018-02-23T03:19:38Z","updated_at":"2018-08-14T01:07:54Z","pushed_at":"2018-08-17T06:29:51Z","git_url":"git://github.com/airtasker/web-components.git","ssh_url":"git@github.com:airtasker/web-components.git","clone_url":"https://github.com/airtasker/web-components.git","svn_url":"https://github.com/airtasker/web-components","homepage":null,"size":6146,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"airtasker:master","ref":"master","sha":"07fc9de69ca20ff45fd008d4ac2859b02f5c32ff","user":{"login":"airtasker","id":1745680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDU2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1745680?v=4","gravatar_id":"","url":"https://api.github.com/users/airtasker","html_url":"https://github.com/airtasker","followers_url":"https://api.github.com/users/airtasker/followers","following_url":"https://api.github.com/users/airtasker/following{/other_user}","gists_url":"https://api.github.com/users/airtasker/gists{/gist_id}","starred_url":"https://api.github.com/users/airtasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airtasker/subscriptions","organizations_url":"https://api.github.com/users/airtasker/orgs","repos_url":"https://api.github.com/users/airtasker/repos","events_url":"https://api.github.com/users/airtasker/events{/privacy}","received_events_url":"https://api.github.com/users/airtasker/received_events","type":"Organization","site_admin":false},"repo":{"id":122567879,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1Njc4Nzk=","name":"web-components","full_name":"airtasker/web-components","owner":{"login":"airtasker","id":1745680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDU2ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1745680?v=4","gravatar_id":"","url":"https://api.github.com/users/airtasker","html_url":"https://github.com/airtasker","followers_url":"https://api.github.com/users/airtasker/followers","following_url":"https://api.github.com/users/airtasker/following{/other_user}","gists_url":"https://api.github.com/users/airtasker/gists{/gist_id}","starred_url":"https://api.github.com/users/airtasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airtasker/subscriptions","organizations_url":"https://api.github.com/users/airtasker/orgs","repos_url":"https://api.github.com/users/airtasker/repos","events_url":"https://api.github.com/users/airtasker/events{/privacy}","received_events_url":"https://api.github.com/users/airtasker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airtasker/web-components","description":"Web Components","fork":false,"url":"https://api.github.com/repos/airtasker/web-components","forks_url":"https://api.github.com/repos/airtasker/web-components/forks","keys_url":"https://api.github.com/repos/airtasker/web-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airtasker/web-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airtasker/web-components/teams","hooks_url":"https://api.github.com/repos/airtasker/web-components/hooks","issue_events_url":"https://api.github.com/repos/airtasker/web-components/issues/events{/number}","events_url":"https://api.github.com/repos/airtasker/web-components/events","assignees_url":"https://api.github.com/repos/airtasker/web-components/assignees{/user}","branches_url":"https://api.github.com/repos/airtasker/web-components/branches{/branch}","tags_url":"https://api.github.com/repos/airtasker/web-components/tags","blobs_url":"https://api.github.com/repos/airtasker/web-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airtasker/web-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airtasker/web-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/airtasker/web-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airtasker/web-components/statuses/{sha}","languages_url":"https://api.github.com/repos/airtasker/web-components/languages","stargazers_url":"https://api.github.com/repos/airtasker/web-components/stargazers","contributors_url":"https://api.github.com/repos/airtasker/web-components/contributors","subscribers_url":"https://api.github.com/repos/airtasker/web-components/subscribers","subscription_url":"https://api.github.com/repos/airtasker/web-components/subscription","commits_url":"https://api.github.com/repos/airtasker/web-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/airtasker/web-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/airtasker/web-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/airtasker/web-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/airtasker/web-components/contents/{+path}","compare_url":"https://api.github.com/repos/airtasker/web-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airtasker/web-components/merges","archive_url":"https://api.github.com/repos/airtasker/web-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airtasker/web-components/downloads","issues_url":"https://api.github.com/repos/airtasker/web-components/issues{/number}","pulls_url":"https://api.github.com/repos/airtasker/web-components/pulls{/number}","milestones_url":"https://api.github.com/repos/airtasker/web-components/milestones{/number}","notifications_url":"https://api.github.com/repos/airtasker/web-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airtasker/web-components/labels{/name}","releases_url":"https://api.github.com/repos/airtasker/web-components/releases{/id}","deployments_url":"https://api.github.com/repos/airtasker/web-components/deployments","created_at":"2018-02-23T03:19:38Z","updated_at":"2018-08-14T01:07:54Z","pushed_at":"2018-08-17T06:29:51Z","git_url":"git://github.com/airtasker/web-components.git","ssh_url":"git@github.com:airtasker/web-components.git","clone_url":"https://github.com/airtasker/web-components.git","svn_url":"https://github.com/airtasker/web-components","homepage":null,"size":6146,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airtasker/web-components/pulls/17"},"html":{"href":"https://github.com/airtasker/web-components/pull/17"},"issue":{"href":"https://api.github.com/repos/airtasker/web-components/issues/17"},"comments":{"href":"https://api.github.com/repos/airtasker/web-components/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/airtasker/web-components/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/airtasker/web-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airtasker/web-components/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/airtasker/web-components/statuses/fa2007574185734ea9a9cadca44b33af84626d1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ericchenak"}}