{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/204588361","pull_request_review_id":139694419,"id":204588361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU4ODM2MQ==","diff_hunk":"@@ -18,13 +18,57 @@ import * as lolex from 'lolex';\n import {poll} from '../../../../../testing/iframe';\n \n const config = describe.configure().ifNewChrome();\n-config.skip('amp-date-picker', function() {\n-  this.skip(); // TODO(cvializ): unskip\n+config.run('amp-date-picker', function() {\n   this.timeout(10000);\n \n   const extensions = ['amp-date-picker'];\n   const experiments = ['amp-date-picker'];\n \n+  const singlePickerWithDateBody = `\n+    <amp-date-picker\n+      layout=\"fixed-height\"\n+      height=\"360\"\n+      id=\"picker\"\n+      date=\"2018-01-01\"\n+    ></amp-date-picker>\n+  `;\n+\n+  const clearButtonBody = `\n+    <button id=\"clear\" on=\"tap:picker.clear\">Clear</button>\n+  `;\n+\n+  describes.integration('picker.clear', {\n+    body: singlePickerWithDateBody + clearButtonBody,\n+    extensions,\n+    experiments,\n+  }, env => {\n+    let clock;\n+    let win;\n+    let document;\n+\n+    beforeEach(() => {\n+      win = env.win;\n+      document = env.win.document;\n+      clock = lolex.install({\n+        target: win,\n+        now: new Date('2018-01-01T08:00:00Z'),\n+      });\n+    });\n+\n+    afterEach(() => {\n+      clock.uninstall();\n+    });\n+\n+    it('clears the current day', () => {","path":"extensions/amp-date-picker/0.1/test/integration/test-integration-amp-date-picker-actions.js","position":47,"original_position":47,"commit_id":"916dd3a1b1a881e00193f4414ef118ba1f203f03","original_commit_id":"916dd3a1b1a881e00193f4414ef118ba1f203f03","user":{"login":"cvializ","id":2363700,"node_id":"MDQ6VXNlcjIzNjM3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2363700?v=4","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"body":"Looks like Travis says yes : P","created_at":"2018-07-23T23:56:44Z","updated_at":"2018-07-23T23:56:44Z","html_url":"https://github.com/ampproject/amphtml/pull/17031#discussion_r204588361","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17031","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/204588361"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17031#discussion_r204588361"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17031"}},"in_reply_to_id":204583586},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/17031","id":203368220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzY4MjIw","html_url":"https://github.com/ampproject/amphtml/pull/17031","diff_url":"https://github.com/ampproject/amphtml/pull/17031.diff","patch_url":"https://github.com/ampproject/amphtml/pull/17031.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/17031","number":17031,"state":"open","locked":false,"title":"🐛Prevent overlay flash on clear","user":{"login":"cvializ","id":2363700,"node_id":"MDQ6VXNlcjIzNjM3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2363700?v=4","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"body":"Addresses overlay opening behavior mentioned in #16716 \r\n\r\n","created_at":"2018-07-23T23:09:14Z","updated_at":"2018-07-23T23:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf2a832cdd8a2d9ad8e52fabf3f5f6767c23b1f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sparhami","id":1410321,"node_id":"MDQ6VXNlcjE0MTAzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1410321?v=4","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17031/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17031/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/17031/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/916dd3a1b1a881e00193f4414ef118ba1f203f03","head":{"label":"cvializ:bug/overlay-close","ref":"bug/overlay-close","sha":"916dd3a1b1a881e00193f4414ef118ba1f203f03","user":{"login":"cvializ","id":2363700,"node_id":"MDQ6VXNlcjIzNjM3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2363700?v=4","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"repo":{"id":81481773,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQ4MTc3Mw==","name":"amphtml","full_name":"cvializ/amphtml","owner":{"login":"cvializ","id":2363700,"node_id":"MDQ6VXNlcjIzNjM3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2363700?v=4","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cvializ/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/cvializ/amphtml","forks_url":"https://api.github.com/repos/cvializ/amphtml/forks","keys_url":"https://api.github.com/repos/cvializ/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cvializ/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cvializ/amphtml/teams","hooks_url":"https://api.github.com/repos/cvializ/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cvializ/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cvializ/amphtml/events","assignees_url":"https://api.github.com/repos/cvializ/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cvializ/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cvializ/amphtml/tags","blobs_url":"https://api.github.com/repos/cvializ/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cvializ/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cvializ/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cvializ/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cvializ/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cvializ/amphtml/languages","stargazers_url":"https://api.github.com/repos/cvializ/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cvializ/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cvializ/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cvializ/amphtml/subscription","commits_url":"https://api.github.com/repos/cvializ/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cvializ/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cvializ/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cvializ/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cvializ/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cvializ/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cvializ/amphtml/merges","archive_url":"https://api.github.com/repos/cvializ/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cvializ/amphtml/downloads","issues_url":"https://api.github.com/repos/cvializ/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cvializ/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cvializ/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cvializ/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cvializ/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cvializ/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cvializ/amphtml/deployments","created_at":"2017-02-09T18:32:30Z","updated_at":"2018-06-22T19:56:06Z","pushed_at":"2018-07-23T23:01:04Z","git_url":"git://github.com/cvializ/amphtml.git","ssh_url":"git@github.com:cvializ/amphtml.git","clone_url":"https://github.com/cvializ/amphtml.git","svn_url":"https://github.com/cvializ/amphtml","homepage":"https://ampproject.org","size":487294,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"c1762997f9b1ee208e81bc3f905bf42f2b1e209a","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-07-23T23:09:32Z","pushed_at":"2018-07-23T23:39:06Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":486183,"stargazers_count":11787,"watchers_count":11787,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2501,"mirror_url":null,"archived":false,"open_issues_count":1316,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2501,"open_issues":1316,"watchers":11787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17031"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17031"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17031"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17031/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17031/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17031/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/916dd3a1b1a881e00193f4414ef118ba1f203f03"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cvializ"}}