{"action":"created","comment":{"url":"https://api.github.com/repos/chipsec/chipsec/pulls/comments/180181668","pull_request_review_id":110557847,"id":180181668,"diff_hunk":"@@ -544,6 +544,13 @@ int __weak phys_mem_access_prot_allowed(struct file *file,\n         return 1;\n }\n \n+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,15,4)","path":"drivers/linux/chipsec_km.c","position":4,"original_position":4,"commit_id":"c55d1ff163e084e091653400cd7b64a70259fe15","original_commit_id":"c55d1ff163e084e091653400cd7b64a70259fe15","user":{"login":"ErikBjorge","id":15640056,"avatar_url":"https://avatars1.githubusercontent.com/u/15640056?v=4","gravatar_id":"","url":"https://api.github.com/users/ErikBjorge","html_url":"https://github.com/ErikBjorge","followers_url":"https://api.github.com/users/ErikBjorge/followers","following_url":"https://api.github.com/users/ErikBjorge/following{/other_user}","gists_url":"https://api.github.com/users/ErikBjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikBjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikBjorge/subscriptions","organizations_url":"https://api.github.com/users/ErikBjorge/orgs","repos_url":"https://api.github.com/users/ErikBjorge/repos","events_url":"https://api.github.com/users/ErikBjorge/events{/privacy}","received_events_url":"https://api.github.com/users/ErikBjorge/received_events","type":"User","site_admin":false},"body":"Yes, update the change to check the kernel version and that ARCH_HAS_VALID_PHYS_ADDR_RANGE is defined before adding your function definition.","created_at":"2018-04-09T18:07:23Z","updated_at":"2018-04-09T18:07:28Z","html_url":"https://github.com/chipsec/chipsec/pull/371#discussion_r180181668","pull_request_url":"https://api.github.com/repos/chipsec/chipsec/pulls/371","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/comments/180181668"},"html":{"href":"https://github.com/chipsec/chipsec/pull/371#discussion_r180181668"},"pull_request":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/371"}},"in_reply_to_id":178998721},"pull_request":{"url":"https://api.github.com/repos/chipsec/chipsec/pulls/371","id":179168459,"html_url":"https://github.com/chipsec/chipsec/pull/371","diff_url":"https://github.com/chipsec/chipsec/pull/371.diff","patch_url":"https://github.com/chipsec/chipsec/pull/371.patch","issue_url":"https://api.github.com/repos/chipsec/chipsec/issues/371","number":371,"state":"open","locked":false,"title":"Fix for issue #363","user":{"login":"BrentHoltsclaw","id":29214623,"avatar_url":"https://avatars3.githubusercontent.com/u/29214623?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentHoltsclaw","html_url":"https://github.com/BrentHoltsclaw","followers_url":"https://api.github.com/users/BrentHoltsclaw/followers","following_url":"https://api.github.com/users/BrentHoltsclaw/following{/other_user}","gists_url":"https://api.github.com/users/BrentHoltsclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentHoltsclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentHoltsclaw/subscriptions","organizations_url":"https://api.github.com/users/BrentHoltsclaw/orgs","repos_url":"https://api.github.com/users/BrentHoltsclaw/repos","events_url":"https://api.github.com/users/BrentHoltsclaw/events{/privacy}","received_events_url":"https://api.github.com/users/BrentHoltsclaw/received_events","type":"User","site_admin":false},"body":"Defined function valid_mmap_phys_addr_range within linux driver if\r\nkernel version is greater than 4.15.4","created_at":"2018-04-03T17:33:10Z","updated_at":"2018-04-09T18:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd4b13e6cc3eb471b8376b7f7b9992b108c45caa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chipsec/chipsec/pulls/371/commits","review_comments_url":"https://api.github.com/repos/chipsec/chipsec/pulls/371/comments","review_comment_url":"https://api.github.com/repos/chipsec/chipsec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chipsec/chipsec/issues/371/comments","statuses_url":"https://api.github.com/repos/chipsec/chipsec/statuses/c55d1ff163e084e091653400cd7b64a70259fe15","head":{"label":"BrentHoltsclaw:issue_363","ref":"issue_363","sha":"c55d1ff163e084e091653400cd7b64a70259fe15","user":{"login":"BrentHoltsclaw","id":29214623,"avatar_url":"https://avatars3.githubusercontent.com/u/29214623?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentHoltsclaw","html_url":"https://github.com/BrentHoltsclaw","followers_url":"https://api.github.com/users/BrentHoltsclaw/followers","following_url":"https://api.github.com/users/BrentHoltsclaw/following{/other_user}","gists_url":"https://api.github.com/users/BrentHoltsclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentHoltsclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentHoltsclaw/subscriptions","organizations_url":"https://api.github.com/users/BrentHoltsclaw/orgs","repos_url":"https://api.github.com/users/BrentHoltsclaw/repos","events_url":"https://api.github.com/users/BrentHoltsclaw/events{/privacy}","received_events_url":"https://api.github.com/users/BrentHoltsclaw/received_events","type":"User","site_admin":false},"repo":{"id":93550510,"name":"chipsec","full_name":"BrentHoltsclaw/chipsec","owner":{"login":"BrentHoltsclaw","id":29214623,"avatar_url":"https://avatars3.githubusercontent.com/u/29214623?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentHoltsclaw","html_url":"https://github.com/BrentHoltsclaw","followers_url":"https://api.github.com/users/BrentHoltsclaw/followers","following_url":"https://api.github.com/users/BrentHoltsclaw/following{/other_user}","gists_url":"https://api.github.com/users/BrentHoltsclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentHoltsclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentHoltsclaw/subscriptions","organizations_url":"https://api.github.com/users/BrentHoltsclaw/orgs","repos_url":"https://api.github.com/users/BrentHoltsclaw/repos","events_url":"https://api.github.com/users/BrentHoltsclaw/events{/privacy}","received_events_url":"https://api.github.com/users/BrentHoltsclaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrentHoltsclaw/chipsec","description":"Platform Security Assessment Framework","fork":true,"url":"https://api.github.com/repos/BrentHoltsclaw/chipsec","forks_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/forks","keys_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/teams","hooks_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/hooks","issue_events_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/issues/events{/number}","events_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/events","assignees_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/assignees{/user}","branches_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/branches{/branch}","tags_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/tags","blobs_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/statuses/{sha}","languages_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/languages","stargazers_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/stargazers","contributors_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/contributors","subscribers_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/subscribers","subscription_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/subscription","commits_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/contents/{+path}","compare_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/merges","archive_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/downloads","issues_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/issues{/number}","pulls_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/pulls{/number}","milestones_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/milestones{/number}","notifications_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/labels{/name}","releases_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/releases{/id}","deployments_url":"https://api.github.com/repos/BrentHoltsclaw/chipsec/deployments","created_at":"2017-06-06T18:27:20Z","updated_at":"2018-04-03T17:24:14Z","pushed_at":"2018-04-03T17:32:39Z","git_url":"git://github.com/BrentHoltsclaw/chipsec.git","ssh_url":"git@github.com:BrentHoltsclaw/chipsec.git","clone_url":"https://github.com/BrentHoltsclaw/chipsec.git","svn_url":"https://github.com/BrentHoltsclaw/chipsec","homepage":"","size":43690,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chipsec:master","ref":"master","sha":"6820651a9e0cd1806854f79ed0a0902b09daea65","user":{"login":"chipsec","id":6620051,"avatar_url":"https://avatars2.githubusercontent.com/u/6620051?v=4","gravatar_id":"","url":"https://api.github.com/users/chipsec","html_url":"https://github.com/chipsec","followers_url":"https://api.github.com/users/chipsec/followers","following_url":"https://api.github.com/users/chipsec/following{/other_user}","gists_url":"https://api.github.com/users/chipsec/gists{/gist_id}","starred_url":"https://api.github.com/users/chipsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipsec/subscriptions","organizations_url":"https://api.github.com/users/chipsec/orgs","repos_url":"https://api.github.com/users/chipsec/repos","events_url":"https://api.github.com/users/chipsec/events{/privacy}","received_events_url":"https://api.github.com/users/chipsec/received_events","type":"Organization","site_admin":false},"repo":{"id":17494082,"name":"chipsec","full_name":"chipsec/chipsec","owner":{"login":"chipsec","id":6620051,"avatar_url":"https://avatars2.githubusercontent.com/u/6620051?v=4","gravatar_id":"","url":"https://api.github.com/users/chipsec","html_url":"https://github.com/chipsec","followers_url":"https://api.github.com/users/chipsec/followers","following_url":"https://api.github.com/users/chipsec/following{/other_user}","gists_url":"https://api.github.com/users/chipsec/gists{/gist_id}","starred_url":"https://api.github.com/users/chipsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipsec/subscriptions","organizations_url":"https://api.github.com/users/chipsec/orgs","repos_url":"https://api.github.com/users/chipsec/repos","events_url":"https://api.github.com/users/chipsec/events{/privacy}","received_events_url":"https://api.github.com/users/chipsec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chipsec/chipsec","description":"Platform Security Assessment Framework","fork":false,"url":"https://api.github.com/repos/chipsec/chipsec","forks_url":"https://api.github.com/repos/chipsec/chipsec/forks","keys_url":"https://api.github.com/repos/chipsec/chipsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chipsec/chipsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chipsec/chipsec/teams","hooks_url":"https://api.github.com/repos/chipsec/chipsec/hooks","issue_events_url":"https://api.github.com/repos/chipsec/chipsec/issues/events{/number}","events_url":"https://api.github.com/repos/chipsec/chipsec/events","assignees_url":"https://api.github.com/repos/chipsec/chipsec/assignees{/user}","branches_url":"https://api.github.com/repos/chipsec/chipsec/branches{/branch}","tags_url":"https://api.github.com/repos/chipsec/chipsec/tags","blobs_url":"https://api.github.com/repos/chipsec/chipsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chipsec/chipsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chipsec/chipsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/chipsec/chipsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chipsec/chipsec/statuses/{sha}","languages_url":"https://api.github.com/repos/chipsec/chipsec/languages","stargazers_url":"https://api.github.com/repos/chipsec/chipsec/stargazers","contributors_url":"https://api.github.com/repos/chipsec/chipsec/contributors","subscribers_url":"https://api.github.com/repos/chipsec/chipsec/subscribers","subscription_url":"https://api.github.com/repos/chipsec/chipsec/subscription","commits_url":"https://api.github.com/repos/chipsec/chipsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/chipsec/chipsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/chipsec/chipsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/chipsec/chipsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/chipsec/chipsec/contents/{+path}","compare_url":"https://api.github.com/repos/chipsec/chipsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chipsec/chipsec/merges","archive_url":"https://api.github.com/repos/chipsec/chipsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chipsec/chipsec/downloads","issues_url":"https://api.github.com/repos/chipsec/chipsec/issues{/number}","pulls_url":"https://api.github.com/repos/chipsec/chipsec/pulls{/number}","milestones_url":"https://api.github.com/repos/chipsec/chipsec/milestones{/number}","notifications_url":"https://api.github.com/repos/chipsec/chipsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chipsec/chipsec/labels{/name}","releases_url":"https://api.github.com/repos/chipsec/chipsec/releases{/id}","deployments_url":"https://api.github.com/repos/chipsec/chipsec/deployments","created_at":"2014-03-06T21:57:10Z","updated_at":"2018-04-08T10:21:42Z","pushed_at":"2018-04-09T16:18:56Z","git_url":"git://github.com/chipsec/chipsec.git","ssh_url":"git@github.com:chipsec/chipsec.git","clone_url":"https://github.com/chipsec/chipsec.git","svn_url":"https://github.com/chipsec/chipsec","homepage":"","size":43674,"stargazers_count":1338,"watchers_count":1338,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":244,"open_issues":70,"watchers":1338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/371"},"html":{"href":"https://github.com/chipsec/chipsec/pull/371"},"issue":{"href":"https://api.github.com/repos/chipsec/chipsec/issues/371"},"comments":{"href":"https://api.github.com/repos/chipsec/chipsec/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/chipsec/chipsec/statuses/c55d1ff163e084e091653400cd7b64a70259fe15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ErikBjorge"}}