{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments/199961055","pull_request_review_id":134182464,"id":199961055,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk2MTA1NQ==","diff_hunk":"@@ -1,5 +1,44 @@\n require 'rails_helper'\n \n RSpec.describe ArchivePreservedCopy, type: :model do\n-  pending \"add some examples to (or delete) #{__FILE__}\"\n+  let(:po) { build(:preserved_object) }\n+  let(:pc) { build(:preserved_copy) }\n+  let(:archive_endpoint) { build(:archive_endpoint) }\n+  let(:apc) { build(:archive_preserved_copy, preserved_copy: pc, archive_endpoint: archive_endpoint) }\n+\n+  it 'is not valid without all required valid attributes' do\n+    expect(described_class.new).not_to be_valid\n+    expect(described_class.new(preserved_copy: pc)).not_to be_valid\n+    expect(archive_endpoint).to be_valid","path":"spec/models/archive_preserved_copy_spec.rb","position":13,"original_position":13,"commit_id":"0e83217e89aa52ddebaa12547d652018b8ccab0d","original_commit_id":"0e83217e89aa52ddebaa12547d652018b8ccab0d","user":{"login":"jmartin-sul","id":7741604,"node_id":"MDQ6VXNlcjc3NDE2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7741604?v=4","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"body":"i think you might want this to be `expect(described_class.new(...)).to be_valid`, where `.new()` gets passed all the required params.","created_at":"2018-07-03T21:54:48Z","updated_at":"2018-07-03T21:58:14Z","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/948#discussion_r199961055","pull_request_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments/199961055"},"html":{"href":"https://github.com/sul-dlss/preservation_catalog/pull/948#discussion_r199961055"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948","id":198814857,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODE0ODU3","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/948","diff_url":"https://github.com/sul-dlss/preservation_catalog/pull/948.diff","patch_url":"https://github.com/sul-dlss/preservation_catalog/pull/948.patch","issue_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/948","number":948,"state":"open","locked":false,"title":"ArchivePreservedCopy Model Rspec tests","user":{"login":"SaravShah","id":7877303,"node_id":"MDQ6VXNlcjc4NzczMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7877303?v=4","gravatar_id":"","url":"https://api.github.com/users/SaravShah","html_url":"https://github.com/SaravShah","followers_url":"https://api.github.com/users/SaravShah/followers","following_url":"https://api.github.com/users/SaravShah/following{/other_user}","gists_url":"https://api.github.com/users/SaravShah/gists{/gist_id}","starred_url":"https://api.github.com/users/SaravShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaravShah/subscriptions","organizations_url":"https://api.github.com/users/SaravShah/orgs","repos_url":"https://api.github.com/users/SaravShah/repos","events_url":"https://api.github.com/users/SaravShah/events{/privacy}","received_events_url":"https://api.github.com/users/SaravShah/received_events","type":"User","site_admin":false},"body":"connects #944 ","created_at":"2018-07-02T23:36:45Z","updated_at":"2018-07-03T21:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0667f54e36c913e22ac347bb73e19ce5d255d2bc","assignee":{"login":"SaravShah","id":7877303,"node_id":"MDQ6VXNlcjc4NzczMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7877303?v=4","gravatar_id":"","url":"https://api.github.com/users/SaravShah","html_url":"https://github.com/SaravShah","followers_url":"https://api.github.com/users/SaravShah/followers","following_url":"https://api.github.com/users/SaravShah/following{/other_user}","gists_url":"https://api.github.com/users/SaravShah/gists{/gist_id}","starred_url":"https://api.github.com/users/SaravShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaravShah/subscriptions","organizations_url":"https://api.github.com/users/SaravShah/orgs","repos_url":"https://api.github.com/users/SaravShah/repos","events_url":"https://api.github.com/users/SaravShah/events{/privacy}","received_events_url":"https://api.github.com/users/SaravShah/received_events","type":"User","site_admin":false},"assignees":[{"login":"SaravShah","id":7877303,"node_id":"MDQ6VXNlcjc4NzczMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7877303?v=4","gravatar_id":"","url":"https://api.github.com/users/SaravShah","html_url":"https://github.com/SaravShah","followers_url":"https://api.github.com/users/SaravShah/followers","following_url":"https://api.github.com/users/SaravShah/following{/other_user}","gists_url":"https://api.github.com/users/SaravShah/gists{/gist_id}","starred_url":"https://api.github.com/users/SaravShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaravShah/subscriptions","organizations_url":"https://api.github.com/users/SaravShah/orgs","repos_url":"https://api.github.com/users/SaravShah/repos","events_url":"https://api.github.com/users/SaravShah/events{/privacy}","received_events_url":"https://api.github.com/users/SaravShah/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":719133329,"node_id":"MDU6TGFiZWw3MTkxMzMzMjk=","url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels/needs%20review","name":"needs review","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/948/comments","statuses_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/0e83217e89aa52ddebaa12547d652018b8ccab0d","head":{"label":"sul-dlss:archive-pres-copy-rpsec","ref":"archive-pres-copy-rpsec","sha":"0e83217e89aa52ddebaa12547d652018b8ccab0d","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":100517453,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MTc0NTM=","name":"preservation_catalog","full_name":"sul-dlss/preservation_catalog","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/preservation_catalog","description":"Rails application to track, audit and replicate archival artifacts associated with SDR objects.","fork":false,"url":"https://api.github.com/repos/sul-dlss/preservation_catalog","forks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/forks","keys_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/teams","hooks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/events","assignees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/tags","blobs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscription","commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/merges","archive_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/downloads","issues_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/deployments","created_at":"2017-08-16T17:55:52Z","updated_at":"2018-07-02T23:34:58Z","pushed_at":"2018-07-03T16:57:11Z","git_url":"git://github.com/sul-dlss/preservation_catalog.git","ssh_url":"git@github.com:sul-dlss/preservation_catalog.git","clone_url":"https://github.com/sul-dlss/preservation_catalog.git","svn_url":"https://github.com/sul-dlss/preservation_catalog","homepage":"","size":271820,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":97,"watchers":1,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"b4fadf7a2760566b3df233ba614659e4bf61cc0a","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":100517453,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MTc0NTM=","name":"preservation_catalog","full_name":"sul-dlss/preservation_catalog","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/preservation_catalog","description":"Rails application to track, audit and replicate archival artifacts associated with SDR objects.","fork":false,"url":"https://api.github.com/repos/sul-dlss/preservation_catalog","forks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/forks","keys_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/teams","hooks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/events","assignees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/tags","blobs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscription","commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/merges","archive_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/downloads","issues_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/deployments","created_at":"2017-08-16T17:55:52Z","updated_at":"2018-07-02T23:34:58Z","pushed_at":"2018-07-03T16:57:11Z","git_url":"git://github.com/sul-dlss/preservation_catalog.git","ssh_url":"git@github.com:sul-dlss/preservation_catalog.git","clone_url":"https://github.com/sul-dlss/preservation_catalog.git","svn_url":"https://github.com/sul-dlss/preservation_catalog","homepage":"","size":271820,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":97,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948"},"html":{"href":"https://github.com/sul-dlss/preservation_catalog/pull/948"},"issue":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/948"},"comments":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/0e83217e89aa52ddebaa12547d652018b8ccab0d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmartin-sul"}}