{"action":"closed","number":52,"pull_request":{"url":"https://api.github.com/repos/MITLibraries/mario/pulls/52","id":231342045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzQyMDQ1","html_url":"https://github.com/MITLibraries/mario/pull/52","diff_url":"https://github.com/MITLibraries/mario/pull/52.diff","patch_url":"https://github.com/MITLibraries/mario/pull/52.patch","issue_url":"https://api.github.com/repos/MITLibraries/mario/issues/52","number":52,"state":"closed","locked":false,"title":"Deal with remaining empty fields in output from MARC records","user":{"login":"hakbailey","id":5618369,"node_id":"MDQ6VXNlcjU2MTgzNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5618369?v=4","gravatar_id":"","url":"https://api.github.com/users/hakbailey","html_url":"https://github.com/hakbailey","followers_url":"https://api.github.com/users/hakbailey/followers","following_url":"https://api.github.com/users/hakbailey/following{/other_user}","gists_url":"https://api.github.com/users/hakbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/hakbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakbailey/subscriptions","organizations_url":"https://api.github.com/users/hakbailey/orgs","repos_url":"https://api.github.com/users/hakbailey/repos","events_url":"https://api.github.com/users/hakbailey/events{/privacy}","received_events_url":"https://api.github.com/users/hakbailey/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nRemoves empty language fields from record in MARC parser.\r\nLogs error if MARC record has no title (this is an indication of an invalid record).\r\n\r\n#### How can a reviewer manually see the effects of these changes?\r\n\r\nRun MARC parser with JSON consumer on test record set. There will no longer be empty strings in the languages arrays.\r\n\r\n#### What are the relevant tickets?\r\n\r\n- https://mitlibraries.atlassian.net/browse/DIP-168\r\n\r\n#### Requires Full Reindexing of all Sources?\r\nYES\r\n\r\n#### Includes new or updated dependencies?\r\nNO\r\n\r\n#### Todo:\r\n- [ ] Tests\r\n- [ ] Documentation\r\n- [ ] Stakeholder approval\r\n","created_at":"2018-11-15T21:35:57Z","updated_at":"2018-11-16T15:05:56Z","closed_at":"2018-11-16T15:05:56Z","merged_at":"2018-11-16T15:05:56Z","merge_commit_sha":"a05ac5c6b0fe43f51857f3cf537e4e1fb4838744","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gravesm","id":1382348,"node_id":"MDQ6VXNlcjEzODIzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1382348?v=4","gravatar_id":"","url":"https://api.github.com/users/gravesm","html_url":"https://github.com/gravesm","followers_url":"https://api.github.com/users/gravesm/followers","following_url":"https://api.github.com/users/gravesm/following{/other_user}","gists_url":"https://api.github.com/users/gravesm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravesm/subscriptions","organizations_url":"https://api.github.com/users/gravesm/orgs","repos_url":"https://api.github.com/users/gravesm/repos","events_url":"https://api.github.com/users/gravesm/events{/privacy}","received_events_url":"https://api.github.com/users/gravesm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MITLibraries/mario/pulls/52/commits","review_comments_url":"https://api.github.com/repos/MITLibraries/mario/pulls/52/comments","review_comment_url":"https://api.github.com/repos/MITLibraries/mario/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MITLibraries/mario/issues/52/comments","statuses_url":"https://api.github.com/repos/MITLibraries/mario/statuses/7e13cd8028aac57432d1252cc3e61b1f949ad14c","head":{"label":"MITLibraries:DIP-168_blank_fields","ref":"DIP-168_blank_fields","sha":"7e13cd8028aac57432d1252cc3e61b1f949ad14c","user":{"login":"MITLibraries","id":2176469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzY0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":139605088,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MDUwODg=","name":"mario","full_name":"MITLibraries/mario","private":false,"owner":{"login":"MITLibraries","id":2176469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzY0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MITLibraries/mario","description":"Mario is a metadata processing pipeline that will process data from various sources and write to Elasticsearch","fork":false,"url":"https://api.github.com/repos/MITLibraries/mario","forks_url":"https://api.github.com/repos/MITLibraries/mario/forks","keys_url":"https://api.github.com/repos/MITLibraries/mario/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MITLibraries/mario/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MITLibraries/mario/teams","hooks_url":"https://api.github.com/repos/MITLibraries/mario/hooks","issue_events_url":"https://api.github.com/repos/MITLibraries/mario/issues/events{/number}","events_url":"https://api.github.com/repos/MITLibraries/mario/events","assignees_url":"https://api.github.com/repos/MITLibraries/mario/assignees{/user}","branches_url":"https://api.github.com/repos/MITLibraries/mario/branches{/branch}","tags_url":"https://api.github.com/repos/MITLibraries/mario/tags","blobs_url":"https://api.github.com/repos/MITLibraries/mario/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MITLibraries/mario/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MITLibraries/mario/git/refs{/sha}","trees_url":"https://api.github.com/repos/MITLibraries/mario/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MITLibraries/mario/statuses/{sha}","languages_url":"https://api.github.com/repos/MITLibraries/mario/languages","stargazers_url":"https://api.github.com/repos/MITLibraries/mario/stargazers","contributors_url":"https://api.github.com/repos/MITLibraries/mario/contributors","subscribers_url":"https://api.github.com/repos/MITLibraries/mario/subscribers","subscription_url":"https://api.github.com/repos/MITLibraries/mario/subscription","commits_url":"https://api.github.com/repos/MITLibraries/mario/commits{/sha}","git_commits_url":"https://api.github.com/repos/MITLibraries/mario/git/commits{/sha}","comments_url":"https://api.github.com/repos/MITLibraries/mario/comments{/number}","issue_comment_url":"https://api.github.com/repos/MITLibraries/mario/issues/comments{/number}","contents_url":"https://api.github.com/repos/MITLibraries/mario/contents/{+path}","compare_url":"https://api.github.com/repos/MITLibraries/mario/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MITLibraries/mario/merges","archive_url":"https://api.github.com/repos/MITLibraries/mario/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MITLibraries/mario/downloads","issues_url":"https://api.github.com/repos/MITLibraries/mario/issues{/number}","pulls_url":"https://api.github.com/repos/MITLibraries/mario/pulls{/number}","milestones_url":"https://api.github.com/repos/MITLibraries/mario/milestones{/number}","notifications_url":"https://api.github.com/repos/MITLibraries/mario/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MITLibraries/mario/labels{/name}","releases_url":"https://api.github.com/repos/MITLibraries/mario/releases{/id}","deployments_url":"https://api.github.com/repos/MITLibraries/mario/deployments","created_at":"2018-07-03T15:41:14Z","updated_at":"2018-11-09T16:24:29Z","pushed_at":"2018-11-16T15:05:56Z","git_url":"git://github.com/MITLibraries/mario.git","ssh_url":"git@github.com:MITLibraries/mario.git","clone_url":"https://github.com/MITLibraries/mario.git","svn_url":"https://github.com/MITLibraries/mario","homepage":"","size":2385,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"MITLibraries:master","ref":"master","sha":"ea525f6e83c3b0638a7721326bea75801a6f7fb5","user":{"login":"MITLibraries","id":2176469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzY0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":139605088,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MDUwODg=","name":"mario","full_name":"MITLibraries/mario","private":false,"owner":{"login":"MITLibraries","id":2176469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzY0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/2176469?v=4","gravatar_id":"","url":"https://api.github.com/users/MITLibraries","html_url":"https://github.com/MITLibraries","followers_url":"https://api.github.com/users/MITLibraries/followers","following_url":"https://api.github.com/users/MITLibraries/following{/other_user}","gists_url":"https://api.github.com/users/MITLibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/MITLibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MITLibraries/subscriptions","organizations_url":"https://api.github.com/users/MITLibraries/orgs","repos_url":"https://api.github.com/users/MITLibraries/repos","events_url":"https://api.github.com/users/MITLibraries/events{/privacy}","received_events_url":"https://api.github.com/users/MITLibraries/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MITLibraries/mario","description":"Mario is a metadata processing pipeline that will process data from various sources and write to Elasticsearch","fork":false,"url":"https://api.github.com/repos/MITLibraries/mario","forks_url":"https://api.github.com/repos/MITLibraries/mario/forks","keys_url":"https://api.github.com/repos/MITLibraries/mario/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MITLibraries/mario/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MITLibraries/mario/teams","hooks_url":"https://api.github.com/repos/MITLibraries/mario/hooks","issue_events_url":"https://api.github.com/repos/MITLibraries/mario/issues/events{/number}","events_url":"https://api.github.com/repos/MITLibraries/mario/events","assignees_url":"https://api.github.com/repos/MITLibraries/mario/assignees{/user}","branches_url":"https://api.github.com/repos/MITLibraries/mario/branches{/branch}","tags_url":"https://api.github.com/repos/MITLibraries/mario/tags","blobs_url":"https://api.github.com/repos/MITLibraries/mario/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MITLibraries/mario/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MITLibraries/mario/git/refs{/sha}","trees_url":"https://api.github.com/repos/MITLibraries/mario/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MITLibraries/mario/statuses/{sha}","languages_url":"https://api.github.com/repos/MITLibraries/mario/languages","stargazers_url":"https://api.github.com/repos/MITLibraries/mario/stargazers","contributors_url":"https://api.github.com/repos/MITLibraries/mario/contributors","subscribers_url":"https://api.github.com/repos/MITLibraries/mario/subscribers","subscription_url":"https://api.github.com/repos/MITLibraries/mario/subscription","commits_url":"https://api.github.com/repos/MITLibraries/mario/commits{/sha}","git_commits_url":"https://api.github.com/repos/MITLibraries/mario/git/commits{/sha}","comments_url":"https://api.github.com/repos/MITLibraries/mario/comments{/number}","issue_comment_url":"https://api.github.com/repos/MITLibraries/mario/issues/comments{/number}","contents_url":"https://api.github.com/repos/MITLibraries/mario/contents/{+path}","compare_url":"https://api.github.com/repos/MITLibraries/mario/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MITLibraries/mario/merges","archive_url":"https://api.github.com/repos/MITLibraries/mario/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MITLibraries/mario/downloads","issues_url":"https://api.github.com/repos/MITLibraries/mario/issues{/number}","pulls_url":"https://api.github.com/repos/MITLibraries/mario/pulls{/number}","milestones_url":"https://api.github.com/repos/MITLibraries/mario/milestones{/number}","notifications_url":"https://api.github.com/repos/MITLibraries/mario/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MITLibraries/mario/labels{/name}","releases_url":"https://api.github.com/repos/MITLibraries/mario/releases{/id}","deployments_url":"https://api.github.com/repos/MITLibraries/mario/deployments","created_at":"2018-07-03T15:41:14Z","updated_at":"2018-11-09T16:24:29Z","pushed_at":"2018-11-16T15:05:56Z","git_url":"git://github.com/MITLibraries/mario.git","ssh_url":"git@github.com:MITLibraries/mario.git","clone_url":"https://github.com/MITLibraries/mario.git","svn_url":"https://github.com/MITLibraries/mario","homepage":"","size":2385,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MITLibraries/mario/pulls/52"},"html":{"href":"https://github.com/MITLibraries/mario/pull/52"},"issue":{"href":"https://api.github.com/repos/MITLibraries/mario/issues/52"},"comments":{"href":"https://api.github.com/repos/MITLibraries/mario/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/MITLibraries/mario/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/MITLibraries/mario/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MITLibraries/mario/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/MITLibraries/mario/statuses/7e13cd8028aac57432d1252cc3e61b1f949ad14c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hakbailey","id":5618369,"node_id":"MDQ6VXNlcjU2MTgzNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5618369?v=4","gravatar_id":"","url":"https://api.github.com/users/hakbailey","html_url":"https://github.com/hakbailey","followers_url":"https://api.github.com/users/hakbailey/followers","following_url":"https://api.github.com/users/hakbailey/following{/other_user}","gists_url":"https://api.github.com/users/hakbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/hakbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakbailey/subscriptions","organizations_url":"https://api.github.com/users/hakbailey/orgs","repos_url":"https://api.github.com/users/hakbailey/repos","events_url":"https://api.github.com/users/hakbailey/events{/privacy}","received_events_url":"https://api.github.com/users/hakbailey/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"hakbailey"}}