{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/24812","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24812/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24812/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24812/events","html_url":"https://github.com/cms-sw/cmssw/pull/24812","id":367183902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjgwNTIw","number":24812,"title":"SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes)","user":{"login":"pieterdavid","id":8883677,"node_id":"MDQ6VXNlcjg4ODM2Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/8883677?v=4","gravatar_id":"","url":"https://api.github.com/users/pieterdavid","html_url":"https://github.com/pieterdavid","followers_url":"https://api.github.com/users/pieterdavid/followers","following_url":"https://api.github.com/users/pieterdavid/following{/other_user}","gists_url":"https://api.github.com/users/pieterdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterdavid/subscriptions","organizations_url":"https://api.github.com/users/pieterdavid/orgs","repos_url":"https://api.github.com/users/pieterdavid/repos","events_url":"https://api.github.com/users/pieterdavid/events{/privacy}","received_events_url":"https://api.github.com/users/pieterdavid/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"node_id":"MDU6TGFiZWw4ODY0NTQ3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":53149121,"node_id":"MDU6TGFiZWw1MzE0OTEyMQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"2cbe4e","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":52882429,"node_id":"MDU6TGFiZWw1Mjg4MjQyOQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"2cbe4e","default":false},{"id":56131195,"node_id":"MDU6TGFiZWw1NjEzMTE5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78","html_url":"https://github.com/cms-sw/cmssw/milestone/78","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78/labels","id":3727036,"node_id":"MDk6TWlsZXN0b25lMzcyNzAzNg==","number":78,"title":"CMSSW_10_4_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":34,"state":"open","created_at":"2018-10-10T09:27:21Z","updated_at":"2018-10-12T20:26:24Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2018-10-05T12:11:29Z","updated_at":"2018-10-12T20:36:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24812","html_url":"https://github.com/cms-sw/cmssw/pull/24812","diff_url":"https://github.com/cms-sw/cmssw/pull/24812.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/24812.patch"},"body":"This is a bug fix for the method that extracts the CM medians from ZS raw data. It contains a protection to prevent extracting CM medians for non-ZS modes (because they are not present then), but that did not take the nonstandard packet codes into account yet, so an exception was thrown (and caught and converted into warning by the calling code) when unpacking with `UnpackCommonModeValues = True`.\r\nAs far as I know this feature is only used for specific studies of the zero-suppression settings, so there is no urgent need to have this in a release.\r\n\r\nCC: @CesarBernardes @alesaggio "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/429454960","html_url":"https://github.com/cms-sw/cmssw/pull/24812#issuecomment-429454960","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24812","id":429454960,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQ1NDk2MA==","user":{"login":"fabiocos","id":4058194,"node_id":"MDQ6VXNlcjQwNTgxOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4058194?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocos","html_url":"https://github.com/fabiocos","followers_url":"https://api.github.com/users/fabiocos/followers","following_url":"https://api.github.com/users/fabiocos/following{/other_user}","gists_url":"https://api.github.com/users/fabiocos/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocos/subscriptions","organizations_url":"https://api.github.com/users/fabiocos/orgs","repos_url":"https://api.github.com/users/fabiocos/repos","events_url":"https://api.github.com/users/fabiocos/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocos/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T20:36:51Z","updated_at":"2018-10-12T20:36:51Z","author_association":"CONTRIBUTOR","body":"@slava77 @pieterdavid I understand this is not effectively tested in the regular procedure, was a test done offline?"}}
{"actor":{"display_login":"fabiocos"}}