{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/Tron/pulls/comments/191972232","pull_request_review_id":124651004,"id":191972232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTk3MjIzMg==","diff_hunk":"@@ -275,43 +306,81 @@ def valid_action_name(value, config_context):\n )\n \n \n+def valid_mesos_action(action, config_context):\n+    required_keys = {'cpus', 'mem', 'docker_image', 'mesos_address'}\n+    if action.get('executor') == schema.ExecutorTypes.mesos:\n+        missing_keys = required_keys - set(action.keys())\n+        if missing_keys:\n+            raise ConfigError(\n+                'Mesos executor for action {id} is missing these required keys: {keys}'.\n+                format(\n+                    id=action['name'],\n+                    keys=missing_keys,\n+                ),\n+            )\n+\n+\n class ValidateAction(Validator):\n     \"\"\"Validate an action.\"\"\"\n     config_class = ConfigAction\n \n     defaults = {\n         'node': None,\n         'requires': (),\n+        'retries': None,\n+        'expected_runtime': datetime.timedelta(hours=24),\n         'executor': schema.ExecutorTypes.ssh,\n-        'cluster': None,","path":"tron/config/config_parse.py","position":95,"original_position":95,"commit_id":"0929121b56742dbd485dd210c2157d4d88359ff7","original_commit_id":"edd76ca25faeb5c5ccec4bfa0cfbd746410e9dbd","user":{"login":"qui","id":1322636,"node_id":"MDQ6VXNlcjEzMjI2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1322636?v=4","gravatar_id":"","url":"https://api.github.com/users/qui","html_url":"https://github.com/qui","followers_url":"https://api.github.com/users/qui/followers","following_url":"https://api.github.com/users/qui/following{/other_user}","gists_url":"https://api.github.com/users/qui/gists{/gist_id}","starred_url":"https://api.github.com/users/qui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qui/subscriptions","organizations_url":"https://api.github.com/users/qui/orgs","repos_url":"https://api.github.com/users/qui/repos","events_url":"https://api.github.com/users/qui/events{/privacy}","received_events_url":"https://api.github.com/users/qui/received_events","type":"User","site_admin":false},"body":"Yeah, I *think* this will be fine. Config parsing is only for current tronfig, so works as long as the old fields don't exist in tronfig.\r\n\r\nFor objects from state, we use restore_state, and that should just ignore fields that it doesn't use.","created_at":"2018-05-31T02:07:52Z","updated_at":"2018-05-31T02:07:52Z","html_url":"https://github.com/Yelp/Tron/pull/448#discussion_r191972232","pull_request_url":"https://api.github.com/repos/Yelp/Tron/pulls/448","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/comments/191972232"},"html":{"href":"https://github.com/Yelp/Tron/pull/448#discussion_r191972232"},"pull_request":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/448"}},"in_reply_to_id":190869150},"pull_request":{"url":"https://api.github.com/repos/Yelp/Tron/pulls/448","id":190159638,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMTU5NjM4","html_url":"https://github.com/Yelp/Tron/pull/448","diff_url":"https://github.com/Yelp/Tron/pull/448.diff","patch_url":"https://github.com/Yelp/Tron/pull/448.patch","issue_url":"https://api.github.com/repos/Yelp/Tron/issues/448","number":448,"state":"open","locked":false,"title":"run tasks on Mesos","user":{"login":"qui","id":1322636,"node_id":"MDQ6VXNlcjEzMjI2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1322636?v=4","gravatar_id":"","url":"https://api.github.com/users/qui","html_url":"https://github.com/qui","followers_url":"https://api.github.com/users/qui/followers","following_url":"https://api.github.com/users/qui/following{/other_user}","gists_url":"https://api.github.com/users/qui/gists{/gist_id}","starred_url":"https://api.github.com/users/qui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qui/subscriptions","organizations_url":"https://api.github.com/users/qui/orgs","repos_url":"https://api.github.com/users/qui/repos","events_url":"https://api.github.com/users/qui/events{/privacy}","received_events_url":"https://api.github.com/users/qui/received_events","type":"User","site_admin":false},"body":"Updates the API to be more general (no more paasta, just mesos and docker arguments) and uses taskproc to submit tasks to the mesos cluster.\r\n\r\nWorks for the action configurations I've tried so far. To do:\r\n- [x] unit tests\r\n- [ ] ~~error handling/retries when creating the framework~~ I want to make a follow-up change for this, since the diff is big already.\r\n- [x] more manual testing","created_at":"2018-05-24T03:22:15Z","updated_at":"2018-05-31T02:07:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e28153d3b4daa2512f59ec6e9f6ffcc9b3972fe8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":817666841,"node_id":"MDU6TGFiZWw4MTc2NjY4NDE=","url":"https://api.github.com/repos/Yelp/Tron/labels/in%20review","name":"in review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/Tron/pulls/448/commits","review_comments_url":"https://api.github.com/repos/Yelp/Tron/pulls/448/comments","review_comment_url":"https://api.github.com/repos/Yelp/Tron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/Tron/issues/448/comments","statuses_url":"https://api.github.com/repos/Yelp/Tron/statuses/0929121b56742dbd485dd210c2157d4d88359ff7","head":{"label":"Yelp:mesos-runs","ref":"mesos-runs","sha":"0929121b56742dbd485dd210c2157d4d88359ff7","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":899771,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk3NzE=","name":"Tron","full_name":"Yelp/Tron","owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/Tron","description":"Next generation batch process scheduling and management","fork":false,"url":"https://api.github.com/repos/Yelp/Tron","forks_url":"https://api.github.com/repos/Yelp/Tron/forks","keys_url":"https://api.github.com/repos/Yelp/Tron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/Tron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/Tron/teams","hooks_url":"https://api.github.com/repos/Yelp/Tron/hooks","issue_events_url":"https://api.github.com/repos/Yelp/Tron/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/Tron/events","assignees_url":"https://api.github.com/repos/Yelp/Tron/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/Tron/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/Tron/tags","blobs_url":"https://api.github.com/repos/Yelp/Tron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/Tron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/Tron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/Tron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/Tron/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/Tron/languages","stargazers_url":"https://api.github.com/repos/Yelp/Tron/stargazers","contributors_url":"https://api.github.com/repos/Yelp/Tron/contributors","subscribers_url":"https://api.github.com/repos/Yelp/Tron/subscribers","subscription_url":"https://api.github.com/repos/Yelp/Tron/subscription","commits_url":"https://api.github.com/repos/Yelp/Tron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/Tron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/Tron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/Tron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/Tron/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/Tron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/Tron/merges","archive_url":"https://api.github.com/repos/Yelp/Tron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/Tron/downloads","issues_url":"https://api.github.com/repos/Yelp/Tron/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/Tron/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/Tron/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/Tron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/Tron/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/Tron/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/Tron/deployments","created_at":"2010-09-09T20:54:04Z","updated_at":"2018-05-30T10:59:15Z","pushed_at":"2018-05-31T00:53:26Z","git_url":"git://github.com/Yelp/Tron.git","ssh_url":"git@github.com:Yelp/Tron.git","clone_url":"https://github.com/Yelp/Tron.git","svn_url":"https://github.com/Yelp/Tron","homepage":"","size":8346,"stargazers_count":271,"watchers_count":271,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":53,"open_issues":32,"watchers":271,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"22670aeccbc41624fda000bd5c22b943c7966c4c","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":899771,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk3NzE=","name":"Tron","full_name":"Yelp/Tron","owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/Tron","description":"Next generation batch process scheduling and management","fork":false,"url":"https://api.github.com/repos/Yelp/Tron","forks_url":"https://api.github.com/repos/Yelp/Tron/forks","keys_url":"https://api.github.com/repos/Yelp/Tron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/Tron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/Tron/teams","hooks_url":"https://api.github.com/repos/Yelp/Tron/hooks","issue_events_url":"https://api.github.com/repos/Yelp/Tron/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/Tron/events","assignees_url":"https://api.github.com/repos/Yelp/Tron/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/Tron/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/Tron/tags","blobs_url":"https://api.github.com/repos/Yelp/Tron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/Tron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/Tron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/Tron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/Tron/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/Tron/languages","stargazers_url":"https://api.github.com/repos/Yelp/Tron/stargazers","contributors_url":"https://api.github.com/repos/Yelp/Tron/contributors","subscribers_url":"https://api.github.com/repos/Yelp/Tron/subscribers","subscription_url":"https://api.github.com/repos/Yelp/Tron/subscription","commits_url":"https://api.github.com/repos/Yelp/Tron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/Tron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/Tron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/Tron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/Tron/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/Tron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/Tron/merges","archive_url":"https://api.github.com/repos/Yelp/Tron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/Tron/downloads","issues_url":"https://api.github.com/repos/Yelp/Tron/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/Tron/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/Tron/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/Tron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/Tron/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/Tron/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/Tron/deployments","created_at":"2010-09-09T20:54:04Z","updated_at":"2018-05-30T10:59:15Z","pushed_at":"2018-05-31T00:53:26Z","git_url":"git://github.com/Yelp/Tron.git","ssh_url":"git@github.com:Yelp/Tron.git","clone_url":"https://github.com/Yelp/Tron.git","svn_url":"https://github.com/Yelp/Tron","homepage":"","size":8346,"stargazers_count":271,"watchers_count":271,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":53,"open_issues":32,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/448"},"html":{"href":"https://github.com/Yelp/Tron/pull/448"},"issue":{"href":"https://api.github.com/repos/Yelp/Tron/issues/448"},"comments":{"href":"https://api.github.com/repos/Yelp/Tron/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/Tron/statuses/0929121b56742dbd485dd210c2157d4d88359ff7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"qui"}}