{"action":"created","comment":{"url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/comments/180776416","pull_request_review_id":111249805,"id":180776416,"diff_hunk":"@@ -891,16 +891,16 @@ void thsvsGetVulkanImageMemoryBarrier(\n                 break;\r\n         }\r\n \r\n+        pVkBarrier->newLayout = layout;\r\n #ifdef THSVS_ERROR_CHECK_MIXED_IMAGE_LAYOUT\r\n         assert(pVkBarrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED ||\r\n                pVkBarrier->newLayout == layout);\r\n #endif\r\n-        pVkBarrier->newLayout = layout;\r","path":"thsvs_simpler_vulkan_synchronization.h","position":131,"original_position":131,"commit_id":"38ed7ece5aa5559bf603b01251500575e14166c3","original_commit_id":"38ed7ece5aa5559bf603b01251500575e14166c3","user":{"login":"Tobski","id":3466723,"avatar_url":"https://avatars0.githubusercontent.com/u/3466723?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobski","html_url":"https://github.com/Tobski","followers_url":"https://api.github.com/users/Tobski/followers","following_url":"https://api.github.com/users/Tobski/following{/other_user}","gists_url":"https://api.github.com/users/Tobski/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobski/subscriptions","organizations_url":"https://api.github.com/users/Tobski/orgs","repos_url":"https://api.github.com/users/Tobski/repos","events_url":"https://api.github.com/users/Tobski/events{/privacy}","received_events_url":"https://api.github.com/users/Tobski/received_events","type":"User","site_admin":false},"body":"Same comment as above - newLayout should just be initialised to VK_IMAGE_LAYOUT_UNDEFINED.","created_at":"2018-04-11T14:34:11Z","updated_at":"2018-04-11T14:34:40Z","html_url":"https://github.com/Tobski/simple_vulkan_synchronization/pull/7#discussion_r180776416","pull_request_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/comments/180776416"},"html":{"href":"https://github.com/Tobski/simple_vulkan_synchronization/pull/7#discussion_r180776416"},"pull_request":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7","id":180915976,"html_url":"https://github.com/Tobski/simple_vulkan_synchronization/pull/7","diff_url":"https://github.com/Tobski/simple_vulkan_synchronization/pull/7.diff","patch_url":"https://github.com/Tobski/simple_vulkan_synchronization/pull/7.patch","issue_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues/7","number":7,"state":"open","locked":false,"title":"Fixes to hazard checking and some documentation typos","user":{"login":"gwihlidal","id":564042,"avatar_url":"https://avatars1.githubusercontent.com/u/564042?v=4","gravatar_id":"","url":"https://api.github.com/users/gwihlidal","html_url":"https://github.com/gwihlidal","followers_url":"https://api.github.com/users/gwihlidal/followers","following_url":"https://api.github.com/users/gwihlidal/following{/other_user}","gists_url":"https://api.github.com/users/gwihlidal/gists{/gist_id}","starred_url":"https://api.github.com/users/gwihlidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwihlidal/subscriptions","organizations_url":"https://api.github.com/users/gwihlidal/orgs","repos_url":"https://api.github.com/users/gwihlidal/repos","events_url":"https://api.github.com/users/gwihlidal/events{/privacy}","received_events_url":"https://api.github.com/users/gwihlidal/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-11T14:07:00Z","updated_at":"2018-04-11T14:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f376ccfc2081ed476796793ec50b4f0eef123a21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues/7/comments","statuses_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/statuses/38ed7ece5aa5559bf603b01251500575e14166c3","head":{"label":"gwihlidal:master","ref":"master","sha":"38ed7ece5aa5559bf603b01251500575e14166c3","user":{"login":"gwihlidal","id":564042,"avatar_url":"https://avatars1.githubusercontent.com/u/564042?v=4","gravatar_id":"","url":"https://api.github.com/users/gwihlidal","html_url":"https://github.com/gwihlidal","followers_url":"https://api.github.com/users/gwihlidal/followers","following_url":"https://api.github.com/users/gwihlidal/following{/other_user}","gists_url":"https://api.github.com/users/gwihlidal/gists{/gist_id}","starred_url":"https://api.github.com/users/gwihlidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwihlidal/subscriptions","organizations_url":"https://api.github.com/users/gwihlidal/orgs","repos_url":"https://api.github.com/users/gwihlidal/repos","events_url":"https://api.github.com/users/gwihlidal/events{/privacy}","received_events_url":"https://api.github.com/users/gwihlidal/received_events","type":"User","site_admin":false},"repo":{"id":103115917,"name":"simple_vulkan_synchronization","full_name":"gwihlidal/simple_vulkan_synchronization","owner":{"login":"gwihlidal","id":564042,"avatar_url":"https://avatars1.githubusercontent.com/u/564042?v=4","gravatar_id":"","url":"https://api.github.com/users/gwihlidal","html_url":"https://github.com/gwihlidal","followers_url":"https://api.github.com/users/gwihlidal/followers","following_url":"https://api.github.com/users/gwihlidal/following{/other_user}","gists_url":"https://api.github.com/users/gwihlidal/gists{/gist_id}","starred_url":"https://api.github.com/users/gwihlidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwihlidal/subscriptions","organizations_url":"https://api.github.com/users/gwihlidal/orgs","repos_url":"https://api.github.com/users/gwihlidal/repos","events_url":"https://api.github.com/users/gwihlidal/events{/privacy}","received_events_url":"https://api.github.com/users/gwihlidal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwihlidal/simple_vulkan_synchronization","description":"A single-header library with a simplified interface for Vulkan synchronization","fork":true,"url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization","forks_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/forks","keys_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/teams","hooks_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/hooks","issue_events_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/issues/events{/number}","events_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/events","assignees_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/assignees{/user}","branches_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/branches{/branch}","tags_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/tags","blobs_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/statuses/{sha}","languages_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/languages","stargazers_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/stargazers","contributors_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/contributors","subscribers_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/subscribers","subscription_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/subscription","commits_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/contents/{+path}","compare_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/merges","archive_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/downloads","issues_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/issues{/number}","pulls_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/pulls{/number}","milestones_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/milestones{/number}","notifications_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/labels{/name}","releases_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/releases{/id}","deployments_url":"https://api.github.com/repos/gwihlidal/simple_vulkan_synchronization/deployments","created_at":"2017-09-11T09:21:54Z","updated_at":"2018-04-11T14:05:50Z","pushed_at":"2018-04-11T14:05:49Z","git_url":"git://github.com/gwihlidal/simple_vulkan_synchronization.git","ssh_url":"git@github.com:gwihlidal/simple_vulkan_synchronization.git","clone_url":"https://github.com/gwihlidal/simple_vulkan_synchronization.git","svn_url":"https://github.com/gwihlidal/simple_vulkan_synchronization","homepage":"","size":68,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Tobski:master","ref":"master","sha":"ed303bb7b6a463ca258438e1dcfc09de59792853","user":{"login":"Tobski","id":3466723,"avatar_url":"https://avatars0.githubusercontent.com/u/3466723?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobski","html_url":"https://github.com/Tobski","followers_url":"https://api.github.com/users/Tobski/followers","following_url":"https://api.github.com/users/Tobski/following{/other_user}","gists_url":"https://api.github.com/users/Tobski/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobski/subscriptions","organizations_url":"https://api.github.com/users/Tobski/orgs","repos_url":"https://api.github.com/users/Tobski/repos","events_url":"https://api.github.com/users/Tobski/events{/privacy}","received_events_url":"https://api.github.com/users/Tobski/received_events","type":"User","site_admin":false},"repo":{"id":100269088,"name":"simple_vulkan_synchronization","full_name":"Tobski/simple_vulkan_synchronization","owner":{"login":"Tobski","id":3466723,"avatar_url":"https://avatars0.githubusercontent.com/u/3466723?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobski","html_url":"https://github.com/Tobski","followers_url":"https://api.github.com/users/Tobski/followers","following_url":"https://api.github.com/users/Tobski/following{/other_user}","gists_url":"https://api.github.com/users/Tobski/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobski/subscriptions","organizations_url":"https://api.github.com/users/Tobski/orgs","repos_url":"https://api.github.com/users/Tobski/repos","events_url":"https://api.github.com/users/Tobski/events{/privacy}","received_events_url":"https://api.github.com/users/Tobski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tobski/simple_vulkan_synchronization","description":"A single-header library with a simplified interface for Vulkan synchronization","fork":false,"url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization","forks_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/forks","keys_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/teams","hooks_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/hooks","issue_events_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues/events{/number}","events_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/events","assignees_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/assignees{/user}","branches_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/branches{/branch}","tags_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/tags","blobs_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/statuses/{sha}","languages_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/languages","stargazers_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/stargazers","contributors_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/contributors","subscribers_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/subscribers","subscription_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/subscription","commits_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/contents/{+path}","compare_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/merges","archive_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/downloads","issues_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues{/number}","pulls_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls{/number}","milestones_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/milestones{/number}","notifications_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/labels{/name}","releases_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/releases{/id}","deployments_url":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/deployments","created_at":"2017-08-14T13:12:32Z","updated_at":"2018-04-11T13:59:22Z","pushed_at":"2018-04-11T14:07:00Z","git_url":"git://github.com/Tobski/simple_vulkan_synchronization.git","ssh_url":"git@github.com:Tobski/simple_vulkan_synchronization.git","clone_url":"https://github.com/Tobski/simple_vulkan_synchronization.git","svn_url":"https://github.com/Tobski/simple_vulkan_synchronization","homepage":"","size":44,"stargazers_count":48,"watchers_count":48,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7"},"html":{"href":"https://github.com/Tobski/simple_vulkan_synchronization/pull/7"},"issue":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues/7"},"comments":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Tobski/simple_vulkan_synchronization/statuses/38ed7ece5aa5559bf603b01251500575e14166c3"}},"author_association":"NONE"}}
{"actor":{"display_login":"Tobski"}}