{"action":"created","issue":{"url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320","repository_url":"https://api.github.com/repos/spacetelescope/hstcal","labels_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320/comments","events_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320/events","html_url":"https://github.com/spacetelescope/hstcal/issues/320","id":334297685,"node_id":"MDU6SXNzdWUzMzQyOTc2ODU=","number":320,"title":"CTE related OS dependent runtime floating point precision differences ","user":{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"labels":[{"id":341367995,"node_id":"MDU6TGFiZWwzNDEzNjc5OTU=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/WFC3","name":"WFC3","color":"bfd4f2","default":false},{"id":722555292,"node_id":"MDU6TGFiZWw3MjI1NTUyOTI=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/changes-data","name":"changes-data","color":"ea8aac","default":false},{"id":725008568,"node_id":"MDU6TGFiZWw3MjUwMDg1Njg=","url":"https://api.github.com/repos/spacetelescope/hstcal/labels/regression","name":"regression","color":"8055b2","default":false}],"state":"open","locked":false,"assignee":{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},{"login":"mdlpstsci","id":30087326,"node_id":"MDQ6VXNlcjMwMDg3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/30087326?v=4","gravatar_id":"","url":"https://api.github.com/users/mdlpstsci","html_url":"https://github.com/mdlpstsci","followers_url":"https://api.github.com/users/mdlpstsci/followers","following_url":"https://api.github.com/users/mdlpstsci/following{/other_user}","gists_url":"https://api.github.com/users/mdlpstsci/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlpstsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlpstsci/subscriptions","organizations_url":"https://api.github.com/users/mdlpstsci/orgs","repos_url":"https://api.github.com/users/mdlpstsci/repos","events_url":"https://api.github.com/users/mdlpstsci/events{/privacy}","received_events_url":"https://api.github.com/users/mdlpstsci/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-21T00:47:53Z","updated_at":"2018-06-21T16:03:17Z","closed_at":null,"author_association":"MEMBER","body":"There exist 2 failing regression tests on Pandokia for WFC3. These only exist on the Linux box. @mdlpstsci checked the input files on both machines (OSX & Linux), they are identical.\r\n\r\n * ``wf3/onorbit/uvis/calwf3_uv_01.calwf3_uv_01``\r\n * ``wf3/onorbit/uvis/calwf3_uv_05.calwf3_uv_05``\r\n\r\nDiffs found only in CTE corrected output files, ``crc.fits`` & ``flc.fits`` where 56 - 97% pixels differ in the last 1-3 last sig. figs.\r\n\r\nThe failing tests date back to [3/29/18](https://ssb.stsci.edu/steuermann/s21.cgi?action=log&name=conda_tests_py3_2018-03-29-10:30:02/nott:conda_testing3/dev_tests) corresponding with #306 and its associated change in the HSTCAL conda build recipe https://github.com/astroconda/astroconda-dev/pull/122.\r\n\r\nLooking through the diffs the following might be the culprit:\r\n\r\n https://github.com/spacetelescope/hstcal/commit/fad902e4b3d7aeb80ee741e3b3755e5e48f2ce5f\r\n where ``rpath``s were added to all ``wscript`` build scripts, ``rpath=bld.env.LIBPATH_CFITSIO``.\r\n\r\nIn the astroconda recipe, the removal of the OS ``[osx]`` specifier for the ``libgcc`` build and runtime dependencies might also be the cause.\r\n\r\nThe related changes are contextually related to the removal of the ``cfitsio`` library src from being contained within the hstcal repo. Instead, hstcal is built against the astroconda distribution of ``cfitsio``. These fpp diffs may be related to this, however, since ``cfitsio`` is an IO ilb it should only be related to reading & writing files and therefore one would expect to see diffs across all output data and not just the CTE (unless the CTE code is calling something that nothing else does).\r\n\r\nMore to come...\r\n \r\n\r\n\r\n \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/spacetelescope/hstcal/issues/comments/399156379","html_url":"https://github.com/spacetelescope/hstcal/issues/320#issuecomment-399156379","issue_url":"https://api.github.com/repos/spacetelescope/hstcal/issues/320","id":399156379,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTE1NjM3OQ==","user":{"login":"jamienoss","id":5013975,"node_id":"MDQ6VXNlcjUwMTM5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/5013975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamienoss","html_url":"https://github.com/jamienoss","followers_url":"https://api.github.com/users/jamienoss/followers","following_url":"https://api.github.com/users/jamienoss/following{/other_user}","gists_url":"https://api.github.com/users/jamienoss/gists{/gist_id}","starred_url":"https://api.github.com/users/jamienoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamienoss/subscriptions","organizations_url":"https://api.github.com/users/jamienoss/orgs","repos_url":"https://api.github.com/users/jamienoss/repos","events_url":"https://api.github.com/users/jamienoss/events{/privacy}","received_events_url":"https://api.github.com/users/jamienoss/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T16:03:17Z","updated_at":"2018-06-21T16:03:17Z","author_association":"MEMBER","body":"## Before (ce7fe09)\r\n\r\n[03/28/18 pandokia install log](https://ssb.stsci.edu/steuermann/s21.cgi?action=log&name=conda_tests_py3_2018-03-28-10:30:01/nott:conda_testing3/dev_tests) installs ``hstcal=2.0.0.dev0+gce7fe09-2``. When doing a ``conda install hstcal=2.0.0.dev0+gce7fe09`` you get:\r\n```\r\n## Package Plan ##\r\n\r\n\r\n\r\n  environment location: /home/jnoss/.conda/envs/issue320-28th\r\n\r\n\r\n\r\n  added / updated specs: \r\n\r\n    - hstcal=2.0.0.dev0+gce7fe09\r\n\r\n\r\n\r\n\r\n\r\nThe following packages will be downloaded:\r\n\r\n\r\n\r\n    package                    |            build\r\n\r\n    ---------------------------|-----------------\r\n\r\n    hstcal-2.0.0.dev0+gce7fe09 |                2        26.1 MB  http://ssb.stsci.edu/astroconda-dev\r\n\r\n\r\n\r\nThe following NEW packages will be INSTALLED:\r\n\r\n\r\n\r\n    hstcal: 2.0.0.dev0+gce7fe09-2 http://ssb.stsci.edu/astroconda-dev\r\n\r\n\r\n\r\nProceed ([y]/n)? \r\n```\r\nThere are no installed dependencies as expected from that [build recipe](https://github.com/astroconda/astroconda-dev/blame/b46f46f5c49609017d1e0d97985d0cfb0bbaadf7/hstcal/meta.yaml) (we're bonly concerned about the Linux build):\r\n```yml\r\n...\r\nrequirements:\r\n    build:\r\n    - gcc >=4.7 [osx]\r\n\r\n    run:\r\n    - libgcc >=4.7 [osx]\r\n...\r\n```\r\n``ldd <path>acscte.e`` yields:\r\n```\r\nlinux-vdso.so.1 =>  (0x00007fffa8bfd000)\r\n\tlibm.so.6 => /lib64/libm.so.6 (0x0000003639a00000)\r\n\tlibgomp.so.1 => /usr/lib64/libgomp.so.1 (0x0000003269c00000)\r\n\tlibpthread.so.0 => /lib64/libpthread.so.0 (0x0000003639200000)\r\n\tlibc.so.6 => /lib64/libc.so.6 (0x0000003638e00000)\r\n\tlibrt.so.1 => /lib64/librt.so.1 (0x0000003639e00000)\r\n\t/lib64/ld-linux-x86-64.so.2 (0x0000003638a00000)\r\n```\r\n\r\n ## After (d741b49)\r\n\r\n[03/29/18 pandokia install log](https://ssb.stsci.edu/steuermann/s21.cgi?action=log&name=conda_tests_py3_2018-03-29-10:30:02/nott:conda_testing3/dev_tests) installs ``hstcal=2.0.0.dev12+gd741b49-3``. When doing a ``conda install hstcal=2.0.0.dev12+gd741b49`` you get:\r\n```\r\n## Package Plan ##\r\n\r\n  environment location: /home/jnoss/.conda/envs/issue320-29th\r\n\r\n  added / updated specs: \r\n    - hstcal=2.0.0.dev12+gd741b49\r\n\r\n\r\nThe following packages will be downloaded:\r\n\r\n    package                    |            build\r\n    ---------------------------|-----------------\r\n    curl-7.60.0                |       h84994c4_0         140 KB\r\n    libcurl-7.60.0             |       h1ad7b7a_0         495 KB\r\n    openssl-1.0.2o             |       h20670df_0         3.4 MB\r\n    ca-certificates-2018.03.07 |                0         124 KB\r\n    hstcal-2.0.0.dev12+gd741b49|                4         7.0 MB  http://ssb.stsci.edu/astroconda-dev\r\n    libgcc-7.2.0               |       h69d50b8_2         304 KB\r\n    cfitsio-3.440              |                3         2.8 MB  http://ssb.stsci.edu/astroconda-dev\r\n    ------------------------------------------------------------\r\n                                           Total:        14.3 MB\r\n\r\nThe following NEW packages will be INSTALLED:\r\n\r\n    ca-certificates: 2018.03.07-0                                              \r\n    cfitsio:         3.440-3                http://ssb.stsci.edu/astroconda-dev\r\n    curl:            7.60.0-h84994c4_0                                         \r\n    hstcal:          2.0.0.dev12+gd741b49-4 http://ssb.stsci.edu/astroconda-dev\r\n    libcurl:         7.60.0-h1ad7b7a_0                                         \r\n    libgcc:          7.2.0-h69d50b8_2                                          \r\n    libgcc-ng:       7.2.0-hdf63c60_3                                          \r\n    libssh2:         1.8.0-h9cfc8f7_4                                          \r\n    libstdcxx-ng:    7.2.0-hdf63c60_3                                          \r\n    openssl:         1.0.2o-h20670df_0                                         \r\n    zlib:            1.2.11-ha838bed_2                                         \r\n\r\nProceed ([y]/n)?\r\n```\r\nNow there _are_ installed dependencies as expected from the new [build recipe](https://github.com/astroconda/astroconda-dev/blame/master/hstcal/meta.yaml):\r\n```yml\r\n...\r\nrequirements:\r\n    build:\r\n      - cfitsio\r\n      - pkg-config\r\n      - gcc >=4.7\r\n\r\n    run:\r\n      - cfitsio\r\n      - libgcc >=4.7\r\n```\r\n``ldd <path>acscte.e`` yields:\r\n```\r\nlinux-vdso.so.1 =>  (0x00007ffc553eb000)\r\n\tlibm.so.6 => /lib64/libm.so.6 (0x0000003639a00000)\r\n\tlibcfitsio.so.6 => /home/jnoss/.conda/envs/issue320-29th/bin/../lib/libcfitsio.so.6 (0x00007f33cfb3f000)\r\n\tlibpthread.so.0 => /lib64/libpthread.so.0 (0x0000003639200000)\r\n\tlibcurl.so.4 => /home/jnoss/.conda/envs/issue320-29th/bin/../lib/libcurl.so.4 (0x00007f33cf8ca000)\r\n\tlibgomp.so.1 => /home/jnoss/.conda/envs/issue320-29th/bin/../lib/libgomp.so.1 (0x00007f33cf6a6000)\r\n\tlibc.so.6 => /lib64/libc.so.6 (0x0000003638e00000)\r\n\t/lib64/ld-linux-x86-64.so.2 (0x0000003638a00000)\r\n\tlibssl.so.1.0.0 => /home/jnoss/.conda/envs/issue320-29th/bin/../lib/./libssl.so.1.0.0 (0x00007f33cf42f000)\r\n\tlibcrypto.so.1.0.0 => /home/jnoss/.conda/envs/issue320-29th/bin/../lib/./libcrypto.so.1.0.0 (0x00007f33cefef000)\r\n\tlibz.so.1 => /home/jnoss/.conda/envs/issue320-29th/bin/../lib/./libz.so.1 (0x00007f33cedd8000)\r\n\tlibrt.so.1 => /lib64/librt.so.1 (0x0000003639e00000)\r\n\tlibdl.so.2 => /lib64/libdl.so.2 (0x0000003639600000)\r\n```\r\n\r\n ## Summary\r\n\r\nThe differences are that ``libgcc=7.2.0`` is now being installed as a dependency were it was not before and now new conda installs are linked against for:\r\n * libcfitsio\r\n * libcurl\r\n * libssl\r\n * libcrypto\r\n * libz\r\n * ligomp\r\n\r\nThe last one, ``libgomp``, could be the cuplrit, only the CTE code usese it, however, I'm not sure why only this was linked to thenew conda install and _not_ the rest of ``libgcc`` which it gets packaged with. I'm also not sure of why a ``libgomp`` change would cause the observed fpp diffs - either I coded something wrong and created a race or there's a bug in that GNU implementation of OpenMP. \r\n\r\n"}}
{"actor":{"display_login":"jamienoss"}}