{"action":"opened","number":22356,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22356","id":210731656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzMxNjU2","html_url":"https://github.com/elastic/kibana/pull/22356","diff_url":"https://github.com/elastic/kibana/pull/22356.diff","patch_url":"https://github.com/elastic/kibana/pull/22356.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22356","number":22356,"state":"open","locked":false,"title":"[WIP] Fix possible flakiness of saveVisualization test action","user":{"login":"markov00","id":1421091,"node_id":"MDQ6VXNlcjE0MjEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1421091?v=4","gravatar_id":"","url":"https://api.github.com/users/markov00","html_url":"https://github.com/markov00","followers_url":"https://api.github.com/users/markov00/followers","following_url":"https://api.github.com/users/markov00/following{/other_user}","gists_url":"https://api.github.com/users/markov00/gists{/gist_id}","starred_url":"https://api.github.com/users/markov00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markov00/subscriptions","organizations_url":"https://api.github.com/users/markov00/orgs","repos_url":"https://api.github.com/users/markov00/repos","events_url":"https://api.github.com/users/markov00/events{/privacy}","received_events_url":"https://api.github.com/users/markov00/received_events","type":"User","site_admin":false},"body":"I've tried to reproduce the same error  https://github.com/elastic/kibana/issues/22228 but without success. Working on that case I've found that `saveVisualization` doesn't wait for right completion of the saving, in details:\r\n- `waitUntilLoadingHasFinished` wait for the disappear of `globalLoaderIndicator`: not sure why but we don't have any global indicator during the saving of a visualization (can be better visualized if testing with 'slow 3g' network setting is ON on chrome dev tool. Now the `visualize` action waits for the `saveVisualizationSuccess` toast popup to appear before continue or timeouts in 10 seconds (or the defaultFindTimeout value.\r\n- `saveVisualization ` saveAsNew argument was used in a wrong way (we don't have code that execute this, but just in case I've inverted the sequence.","created_at":"2018-08-24T12:51:57Z","updated_at":"2018-08-24T12:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":462161355,"node_id":"MDU6TGFiZWw0NjIxNjEzNTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Visualizations","name":":Visualizations","color":"fef2c0","default":false},{"id":409457688,"node_id":"MDU6TGFiZWw0MDk0NTc2ODg=","url":"https://api.github.com/repos/elastic/kibana/labels/WIP","name":"WIP","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/22356/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/22356/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22356/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/0d903738908dd61b692a3c7f637f01c5514f01b5","head":{"label":"markov00:test/fix-flaky-22228","ref":"test/fix-flaky-22228","sha":"0d903738908dd61b692a3c7f637f01c5514f01b5","user":{"login":"markov00","id":1421091,"node_id":"MDQ6VXNlcjE0MjEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1421091?v=4","gravatar_id":"","url":"https://api.github.com/users/markov00","html_url":"https://github.com/markov00","followers_url":"https://api.github.com/users/markov00/followers","following_url":"https://api.github.com/users/markov00/following{/other_user}","gists_url":"https://api.github.com/users/markov00/gists{/gist_id}","starred_url":"https://api.github.com/users/markov00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markov00/subscriptions","organizations_url":"https://api.github.com/users/markov00/orgs","repos_url":"https://api.github.com/users/markov00/repos","events_url":"https://api.github.com/users/markov00/events{/privacy}","received_events_url":"https://api.github.com/users/markov00/received_events","type":"User","site_admin":false},"repo":{"id":134275375,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyNzUzNzU=","name":"kibana","full_name":"markov00/kibana","owner":{"login":"markov00","id":1421091,"node_id":"MDQ6VXNlcjE0MjEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1421091?v=4","gravatar_id":"","url":"https://api.github.com/users/markov00","html_url":"https://github.com/markov00","followers_url":"https://api.github.com/users/markov00/followers","following_url":"https://api.github.com/users/markov00/following{/other_user}","gists_url":"https://api.github.com/users/markov00/gists{/gist_id}","starred_url":"https://api.github.com/users/markov00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markov00/subscriptions","organizations_url":"https://api.github.com/users/markov00/orgs","repos_url":"https://api.github.com/users/markov00/repos","events_url":"https://api.github.com/users/markov00/events{/privacy}","received_events_url":"https://api.github.com/users/markov00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markov00/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/markov00/kibana","forks_url":"https://api.github.com/repos/markov00/kibana/forks","keys_url":"https://api.github.com/repos/markov00/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markov00/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markov00/kibana/teams","hooks_url":"https://api.github.com/repos/markov00/kibana/hooks","issue_events_url":"https://api.github.com/repos/markov00/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/markov00/kibana/events","assignees_url":"https://api.github.com/repos/markov00/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/markov00/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/markov00/kibana/tags","blobs_url":"https://api.github.com/repos/markov00/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markov00/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markov00/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/markov00/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markov00/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/markov00/kibana/languages","stargazers_url":"https://api.github.com/repos/markov00/kibana/stargazers","contributors_url":"https://api.github.com/repos/markov00/kibana/contributors","subscribers_url":"https://api.github.com/repos/markov00/kibana/subscribers","subscription_url":"https://api.github.com/repos/markov00/kibana/subscription","commits_url":"https://api.github.com/repos/markov00/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/markov00/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/markov00/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/markov00/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/markov00/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/markov00/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markov00/kibana/merges","archive_url":"https://api.github.com/repos/markov00/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markov00/kibana/downloads","issues_url":"https://api.github.com/repos/markov00/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/markov00/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/markov00/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/markov00/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markov00/kibana/labels{/name}","releases_url":"https://api.github.com/repos/markov00/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/markov00/kibana/deployments","created_at":"2018-05-21T13:47:32Z","updated_at":"2018-08-14T07:34:40Z","pushed_at":"2018-08-24T12:40:49Z","git_url":"git://github.com/markov00/kibana.git","ssh_url":"git@github.com:markov00/kibana.git","clone_url":"https://github.com/markov00/kibana.git","svn_url":"https://github.com/markov00/kibana","homepage":"https://www.elastic.co/products/kibana","size":443516,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1cf1fb7ca0a65239388e5c60e9bd53f630c2683e","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-08-24T11:43:28Z","pushed_at":"2018-08-24T12:42:11Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":447242,"stargazers_count":9933,"watchers_count":9933,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3873,"mirror_url":null,"archived":false,"open_issues_count":3329,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3873,"open_issues":3329,"watchers":9933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22356"},"html":{"href":"https://github.com/elastic/kibana/pull/22356"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/22356"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/22356/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22356/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22356/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/0d903738908dd61b692a3c7f637f01c5514f01b5"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"markov00"}}