{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/190970106","pull_request_review_id":123464872,"id":190970106,"diff_hunk":"@@ -40,18 +40,17 @@ Glossary\n       ABCs with the :mod:`abc` module.\n \n    annotation\n-      A metadata value associated with a variable, a class attribute or a\n-      function or method parameter or return value, with no defined semantics.\n+      A label associated with a variable, a class\n+      attribute or a function parameter or return value,\n+      used, by convention, for :term:`type hints <type hint>`.","path":"Doc/glossary.rst","position":null,"original_position":8,"commit_id":"e8e1b364c1faf77d413c37155642b13694b89dbc","original_commit_id":"26af7a2e3d93dcb61a6914e496a2ed45a042332e","user":{"login":"gvanrossum","id":2894642,"avatar_url":"https://avatars3.githubusercontent.com/u/2894642?v=4","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"body":"there's no need for commas around \"by convention\".","created_at":"2018-05-25T18:06:17Z","updated_at":"2018-05-25T18:06:47Z","html_url":"https://github.com/python/cpython/pull/6829#discussion_r190970106","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/6829","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/190970106"},"html":{"href":"https://github.com/python/cpython/pull/6829#discussion_r190970106"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/6829"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/6829","id":187940080,"html_url":"https://github.com/python/cpython/pull/6829","diff_url":"https://github.com/python/cpython/pull/6829.diff","patch_url":"https://github.com/python/cpython/pull/6829.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/6829","number":6829,"state":"open","locked":false,"title":"bpo-32769: A new take on annotations/type hinting glossary entries","user":{"login":"andresdelfino","id":34587441,"avatar_url":"https://avatars2.githubusercontent.com/u/34587441?v=4","gravatar_id":"","url":"https://api.github.com/users/andresdelfino","html_url":"https://github.com/andresdelfino","followers_url":"https://api.github.com/users/andresdelfino/followers","following_url":"https://api.github.com/users/andresdelfino/following{/other_user}","gists_url":"https://api.github.com/users/andresdelfino/gists{/gist_id}","starred_url":"https://api.github.com/users/andresdelfino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresdelfino/subscriptions","organizations_url":"https://api.github.com/users/andresdelfino/orgs","repos_url":"https://api.github.com/users/andresdelfino/repos","events_url":"https://api.github.com/users/andresdelfino/events{/privacy}","received_events_url":"https://api.github.com/users/andresdelfino/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\n\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\n\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n\n\n<!-- issue-number: bpo-32769 -->\nhttps://bugs.python.org/issue32769\n<!-- /issue-number -->\n","created_at":"2018-05-14T20:22:43Z","updated_at":"2018-05-25T18:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac8d0ae3ffea7818f38a9a84c20714624a1d560a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false},{"id":667924166,"url":"https://api.github.com/repos/python/cpython/labels/skip%20news","name":"skip news","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/6829/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/6829/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/6829/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/e8e1b364c1faf77d413c37155642b13694b89dbc","head":{"label":"andresdelfino:type-hints","ref":"type-hints","sha":"e8e1b364c1faf77d413c37155642b13694b89dbc","user":{"login":"andresdelfino","id":34587441,"avatar_url":"https://avatars2.githubusercontent.com/u/34587441?v=4","gravatar_id":"","url":"https://api.github.com/users/andresdelfino","html_url":"https://github.com/andresdelfino","followers_url":"https://api.github.com/users/andresdelfino/followers","following_url":"https://api.github.com/users/andresdelfino/following{/other_user}","gists_url":"https://api.github.com/users/andresdelfino/gists{/gist_id}","starred_url":"https://api.github.com/users/andresdelfino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresdelfino/subscriptions","organizations_url":"https://api.github.com/users/andresdelfino/orgs","repos_url":"https://api.github.com/users/andresdelfino/repos","events_url":"https://api.github.com/users/andresdelfino/events{/privacy}","received_events_url":"https://api.github.com/users/andresdelfino/received_events","type":"User","site_admin":false},"repo":{"id":131356336,"name":"cpython","full_name":"andresdelfino/cpython","owner":{"login":"andresdelfino","id":34587441,"avatar_url":"https://avatars2.githubusercontent.com/u/34587441?v=4","gravatar_id":"","url":"https://api.github.com/users/andresdelfino","html_url":"https://github.com/andresdelfino","followers_url":"https://api.github.com/users/andresdelfino/followers","following_url":"https://api.github.com/users/andresdelfino/following{/other_user}","gists_url":"https://api.github.com/users/andresdelfino/gists{/gist_id}","starred_url":"https://api.github.com/users/andresdelfino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresdelfino/subscriptions","organizations_url":"https://api.github.com/users/andresdelfino/orgs","repos_url":"https://api.github.com/users/andresdelfino/repos","events_url":"https://api.github.com/users/andresdelfino/events{/privacy}","received_events_url":"https://api.github.com/users/andresdelfino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresdelfino/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/andresdelfino/cpython","forks_url":"https://api.github.com/repos/andresdelfino/cpython/forks","keys_url":"https://api.github.com/repos/andresdelfino/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresdelfino/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresdelfino/cpython/teams","hooks_url":"https://api.github.com/repos/andresdelfino/cpython/hooks","issue_events_url":"https://api.github.com/repos/andresdelfino/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/andresdelfino/cpython/events","assignees_url":"https://api.github.com/repos/andresdelfino/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/andresdelfino/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/andresdelfino/cpython/tags","blobs_url":"https://api.github.com/repos/andresdelfino/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresdelfino/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresdelfino/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresdelfino/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresdelfino/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/andresdelfino/cpython/languages","stargazers_url":"https://api.github.com/repos/andresdelfino/cpython/stargazers","contributors_url":"https://api.github.com/repos/andresdelfino/cpython/contributors","subscribers_url":"https://api.github.com/repos/andresdelfino/cpython/subscribers","subscription_url":"https://api.github.com/repos/andresdelfino/cpython/subscription","commits_url":"https://api.github.com/repos/andresdelfino/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresdelfino/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresdelfino/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresdelfino/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresdelfino/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/andresdelfino/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresdelfino/cpython/merges","archive_url":"https://api.github.com/repos/andresdelfino/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresdelfino/cpython/downloads","issues_url":"https://api.github.com/repos/andresdelfino/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/andresdelfino/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/andresdelfino/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/andresdelfino/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresdelfino/cpython/labels{/name}","releases_url":"https://api.github.com/repos/andresdelfino/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/andresdelfino/cpython/deployments","created_at":"2018-04-28T00:25:38Z","updated_at":"2018-05-24T02:53:40Z","pushed_at":"2018-05-25T15:55:55Z","git_url":"git://github.com/andresdelfino/cpython.git","ssh_url":"git@github.com:andresdelfino/cpython.git","clone_url":"https://github.com/andresdelfino/cpython.git","svn_url":"https://github.com/andresdelfino/cpython","homepage":"https://www.python.org/","size":236916,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"5e6312c39e1fc32ecef18d340bcd5f7e314170e1","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-05-25T17:29:48Z","pushed_at":"2018-05-25T17:08:24Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":237175,"stargazers_count":17846,"watchers_count":17846,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5469,"mirror_url":null,"archived":false,"open_issues_count":723,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5469,"open_issues":723,"watchers":17846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/6829"},"html":{"href":"https://github.com/python/cpython/pull/6829"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/6829"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/6829/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/6829/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/6829/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/e8e1b364c1faf77d413c37155642b13694b89dbc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gvanrossum"}}