{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/174953338","pull_request_review_id":104404894,"id":174953338,"diff_hunk":"@@ -46,18 +48,44 @@ class CanaryStage implements StageDefinitionBuilder, CancellableStage {\n   @Override\n   def List<Stage> aroundStages(Stage stage) {\n     Map canaryStageId = [\n-      canaryStageId: stage.id,\n-      failPipeline: stage.context.failPipeline,\n+      canaryStageId   : stage.id,\n+      failPipeline    : stage.context.failPipeline,\n       continuePipeline: stage.context.continuePipeline\n     ]\n \n     Map<String, Object> deployContext = canaryStageId + stage.context\n     Map<String, Object> monitorContext = canaryStageId + [scaleUp: stage.context.scaleUp ?: [:]]\n \n     return [\n-      newStage(stage.execution, deployCanaryStage.type, \"Deploy Canary\", deployContext, stage, SyntheticStageOwner.STAGE_AFTER),\n-      newStage(stage.execution, monitorCanaryStage.type, \"Monitor Canary\", monitorContext, stage, SyntheticStageOwner.STAGE_AFTER)\n+      newStage(stage.execution, deployCanaryStage.type, \"Deploy Canary\", deployContext, stage, STAGE_AFTER),\n+      newStage(stage.execution, monitorCanaryStage.type, \"Monitor Canary\", monitorContext, stage, STAGE_AFTER)\n+    ]\n+  }\n+\n+  @Override\n+  void afterStages(@Nonnull Stage parent, @Nonnull StageGraphBuilder builder) {","path":"orca-mine/src/main/groovy/com/netflix/spinnaker/orca/mine/pipeline/CanaryStage.groovy","position":null,"original_position":47,"commit_id":"033c0f5b250e1bdb4cee02c98f88666c534b95b1","original_commit_id":"e5d105092300ea14c9bcd3cc2846e3564c7753ef","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"body":"I think I just forgot to delete the old one.","created_at":"2018-03-15T22:36:29Z","updated_at":"2018-03-15T22:36:29Z","html_url":"https://github.com/spinnaker/orca/pull/2052#discussion_r174953338","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/2052","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/174953338"},"html":{"href":"https://github.com/spinnaker/orca/pull/2052#discussion_r174953338"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2052"}},"in_reply_to_id":174876353},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/2052","id":174752553,"html_url":"https://github.com/spinnaker/orca/pull/2052","diff_url":"https://github.com/spinnaker/orca/pull/2052.diff","patch_url":"https://github.com/spinnaker/orca/pull/2052.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/2052","number":2052,"state":"open","locked":false,"title":"Synthetic stage graphs","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"body":"This change means all \"after\" stages are planned just in time. It also unifies the old parallel and serial synthetic stages. The graph for synthetics can now be arbitrarily complex.","created_at":"2018-03-13T18:35:51Z","updated_at":"2018-03-15T22:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8450cf11e0982ef7a88520fbd1b63cb45a1dfde0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/2052/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/2052/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/2052/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/033c0f5b250e1bdb4cee02c98f88666c534b95b1","head":{"label":"robfletcher:synthetic-stage-graphs","ref":"synthetic-stage-graphs","sha":"033c0f5b250e1bdb4cee02c98f88666c534b95b1","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"repo":{"id":46739117,"name":"orca","full_name":"robfletcher/orca","owner":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robfletcher/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/robfletcher/orca","forks_url":"https://api.github.com/repos/robfletcher/orca/forks","keys_url":"https://api.github.com/repos/robfletcher/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robfletcher/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robfletcher/orca/teams","hooks_url":"https://api.github.com/repos/robfletcher/orca/hooks","issue_events_url":"https://api.github.com/repos/robfletcher/orca/issues/events{/number}","events_url":"https://api.github.com/repos/robfletcher/orca/events","assignees_url":"https://api.github.com/repos/robfletcher/orca/assignees{/user}","branches_url":"https://api.github.com/repos/robfletcher/orca/branches{/branch}","tags_url":"https://api.github.com/repos/robfletcher/orca/tags","blobs_url":"https://api.github.com/repos/robfletcher/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robfletcher/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robfletcher/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/robfletcher/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robfletcher/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/robfletcher/orca/languages","stargazers_url":"https://api.github.com/repos/robfletcher/orca/stargazers","contributors_url":"https://api.github.com/repos/robfletcher/orca/contributors","subscribers_url":"https://api.github.com/repos/robfletcher/orca/subscribers","subscription_url":"https://api.github.com/repos/robfletcher/orca/subscription","commits_url":"https://api.github.com/repos/robfletcher/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/robfletcher/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/robfletcher/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/robfletcher/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/robfletcher/orca/contents/{+path}","compare_url":"https://api.github.com/repos/robfletcher/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robfletcher/orca/merges","archive_url":"https://api.github.com/repos/robfletcher/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robfletcher/orca/downloads","issues_url":"https://api.github.com/repos/robfletcher/orca/issues{/number}","pulls_url":"https://api.github.com/repos/robfletcher/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/robfletcher/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/robfletcher/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robfletcher/orca/labels{/name}","releases_url":"https://api.github.com/repos/robfletcher/orca/releases{/id}","deployments_url":"https://api.github.com/repos/robfletcher/orca/deployments","created_at":"2015-11-23T18:15:19Z","updated_at":"2018-03-15T17:07:23Z","pushed_at":"2018-03-15T22:21:37Z","git_url":"git://github.com/robfletcher/orca.git","ssh_url":"git@github.com:robfletcher/orca.git","clone_url":"https://github.com/robfletcher/orca.git","svn_url":"https://github.com/robfletcher/orca","homepage":"","size":11968,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"b97d74188d1f5ba045fd134bbe4c280e254b514c","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2018-03-15T16:54:18Z","pushed_at":"2018-03-15T22:21:39Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"git@github.com:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":11468,"stargazers_count":88,"watchers_count":88,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":192,"open_issues":55,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2052"},"html":{"href":"https://github.com/spinnaker/orca/pull/2052"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/2052"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/2052/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2052/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/2052/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/033c0f5b250e1bdb4cee02c98f88666c534b95b1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robfletcher"}}