{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-dns/pulls/130","id":232944168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTQ0MTY4","html_url":"https://github.com/theforeman/puppet-dns/pull/130","diff_url":"https://github.com/theforeman/puppet-dns/pull/130.diff","patch_url":"https://github.com/theforeman/puppet-dns/pull/130.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-dns/issues/130","number":130,"state":"closed","locked":false,"title":"feat: add keys parameter and create_resources accordingly","user":{"login":"marcdeop","id":3227746,"node_id":"MDQ6VXNlcjMyMjc3NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3227746?v=4","gravatar_id":"","url":"https://api.github.com/users/marcdeop","html_url":"https://github.com/marcdeop","followers_url":"https://api.github.com/users/marcdeop/followers","following_url":"https://api.github.com/users/marcdeop/following{/other_user}","gists_url":"https://api.github.com/users/marcdeop/gists{/gist_id}","starred_url":"https://api.github.com/users/marcdeop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcdeop/subscriptions","organizations_url":"https://api.github.com/users/marcdeop/orgs","repos_url":"https://api.github.com/users/marcdeop/repos","events_url":"https://api.github.com/users/marcdeop/events{/privacy}","received_events_url":"https://api.github.com/users/marcdeop/received_events","type":"User","site_admin":false},"body":"Thanks to #108 we can use custom keys :+1: \r\n\r\nWe wanted to take it a step further and use the same method for the keys that exists for the zones: `create_resources` via a hash.\r\n\r\nThis PR achieves this.\r\n\r\nThanks to [Erasys GmbH](http://www.erasys.de/) for their support","created_at":"2018-11-22T11:20:01Z","updated_at":"2018-11-22T12:33:07Z","closed_at":"2018-11-22T12:33:07Z","merged_at":"2018-11-22T12:33:07Z","merge_commit_sha":"7fda3ab63e18f3ca631f82c22510d9a753f3a8d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":2342932,"node_id":"MDU6TGFiZWwyMzQyOTMy","url":"https://api.github.com/repos/theforeman/puppet-dns/labels/Enhancement","name":"Enhancement","color":"b5edf2","default":false},{"id":794030030,"node_id":"MDU6TGFiZWw3OTQwMzAwMzA=","url":"https://api.github.com/repos/theforeman/puppet-dns/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-dns/pulls/130/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-dns/pulls/130/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-dns/issues/130/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-dns/statuses/7fda3ab63e18f3ca631f82c22510d9a753f3a8d4","head":{"label":"erasys:feature/createKeys","ref":"feature/createKeys","sha":"7fda3ab63e18f3ca631f82c22510d9a753f3a8d4","user":{"login":"erasys","id":1845621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDU2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1845621?v=4","gravatar_id":"","url":"https://api.github.com/users/erasys","html_url":"https://github.com/erasys","followers_url":"https://api.github.com/users/erasys/followers","following_url":"https://api.github.com/users/erasys/following{/other_user}","gists_url":"https://api.github.com/users/erasys/gists{/gist_id}","starred_url":"https://api.github.com/users/erasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasys/subscriptions","organizations_url":"https://api.github.com/users/erasys/orgs","repos_url":"https://api.github.com/users/erasys/repos","events_url":"https://api.github.com/users/erasys/events{/privacy}","received_events_url":"https://api.github.com/users/erasys/received_events","type":"Organization","site_admin":false},"repo":{"id":126184574,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxODQ1NzQ=","name":"puppet-dns","full_name":"erasys/puppet-dns","private":false,"owner":{"login":"erasys","id":1845621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDU2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1845621?v=4","gravatar_id":"","url":"https://api.github.com/users/erasys","html_url":"https://github.com/erasys","followers_url":"https://api.github.com/users/erasys/followers","following_url":"https://api.github.com/users/erasys/following{/other_user}","gists_url":"https://api.github.com/users/erasys/gists{/gist_id}","starred_url":"https://api.github.com/users/erasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasys/subscriptions","organizations_url":"https://api.github.com/users/erasys/orgs","repos_url":"https://api.github.com/users/erasys/repos","events_url":"https://api.github.com/users/erasys/events{/privacy}","received_events_url":"https://api.github.com/users/erasys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/erasys/puppet-dns","description":"Installs and manages an ISC BIND DNS server with zones","fork":true,"url":"https://api.github.com/repos/erasys/puppet-dns","forks_url":"https://api.github.com/repos/erasys/puppet-dns/forks","keys_url":"https://api.github.com/repos/erasys/puppet-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erasys/puppet-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erasys/puppet-dns/teams","hooks_url":"https://api.github.com/repos/erasys/puppet-dns/hooks","issue_events_url":"https://api.github.com/repos/erasys/puppet-dns/issues/events{/number}","events_url":"https://api.github.com/repos/erasys/puppet-dns/events","assignees_url":"https://api.github.com/repos/erasys/puppet-dns/assignees{/user}","branches_url":"https://api.github.com/repos/erasys/puppet-dns/branches{/branch}","tags_url":"https://api.github.com/repos/erasys/puppet-dns/tags","blobs_url":"https://api.github.com/repos/erasys/puppet-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erasys/puppet-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erasys/puppet-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/erasys/puppet-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erasys/puppet-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/erasys/puppet-dns/languages","stargazers_url":"https://api.github.com/repos/erasys/puppet-dns/stargazers","contributors_url":"https://api.github.com/repos/erasys/puppet-dns/contributors","subscribers_url":"https://api.github.com/repos/erasys/puppet-dns/subscribers","subscription_url":"https://api.github.com/repos/erasys/puppet-dns/subscription","commits_url":"https://api.github.com/repos/erasys/puppet-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/erasys/puppet-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/erasys/puppet-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/erasys/puppet-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/erasys/puppet-dns/contents/{+path}","compare_url":"https://api.github.com/repos/erasys/puppet-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erasys/puppet-dns/merges","archive_url":"https://api.github.com/repos/erasys/puppet-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erasys/puppet-dns/downloads","issues_url":"https://api.github.com/repos/erasys/puppet-dns/issues{/number}","pulls_url":"https://api.github.com/repos/erasys/puppet-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/erasys/puppet-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/erasys/puppet-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erasys/puppet-dns/labels{/name}","releases_url":"https://api.github.com/repos/erasys/puppet-dns/releases{/id}","deployments_url":"https://api.github.com/repos/erasys/puppet-dns/deployments","created_at":"2018-03-21T13:40:05Z","updated_at":"2018-11-22T10:06:21Z","pushed_at":"2018-11-22T10:28:24Z","git_url":"git://github.com/erasys/puppet-dns.git","ssh_url":"git@github.com:erasys/puppet-dns.git","clone_url":"https://github.com/erasys/puppet-dns.git","svn_url":"https://github.com/erasys/puppet-dns","homepage":"","size":198,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"5dc954d4e3c41d23f52786728df5e5912bbf5a3c","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3885618,"node_id":"MDEwOlJlcG9zaXRvcnkzODg1NjE4","name":"puppet-dns","full_name":"theforeman/puppet-dns","private":false,"owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theforeman/puppet-dns","description":"Installs and manages an ISC BIND DNS server with zones","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-dns","forks_url":"https://api.github.com/repos/theforeman/puppet-dns/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-dns/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-dns/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-dns/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-dns/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-dns/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-dns/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-dns/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-dns/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-dns/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-dns/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-dns/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-dns/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-dns/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-dns/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-dns/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-dns/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-dns/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-dns/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-dns/deployments","created_at":"2012-03-31T13:20:52Z","updated_at":"2018-11-19T18:08:07Z","pushed_at":"2018-11-22T12:33:07Z","git_url":"git://github.com/theforeman/puppet-dns.git","ssh_url":"git@github.com:theforeman/puppet-dns.git","clone_url":"https://github.com/theforeman/puppet-dns.git","svn_url":"https://github.com/theforeman/puppet-dns","homepage":"","size":196,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":48,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-dns/pulls/130"},"html":{"href":"https://github.com/theforeman/puppet-dns/pull/130"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-dns/issues/130"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-dns/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-dns/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-dns/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-dns/statuses/7fda3ab63e18f3ca631f82c22510d9a753f3a8d4"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ekohl","id":155810,"node_id":"MDQ6VXNlcjE1NTgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"ekohl"}}