{"action":"opened","number":813,"pull_request":{"url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/813","id":226444637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDQ0NjM3","html_url":"https://github.com/predixdesignsystem/px-data-grid/pull/813","diff_url":"https://github.com/predixdesignsystem/px-data-grid/pull/813.diff","patch_url":"https://github.com/predixdesignsystem/px-data-grid/pull/813.patch","issue_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues/813","number":813,"state":"open","locked":false,"title":"Add icon support to table/row actions, split column selector and action dropdowns","user":{"login":"evanjd","id":4055224,"node_id":"MDQ6VXNlcjQwNTUyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4055224?v=4","gravatar_id":"","url":"https://api.github.com/users/evanjd","html_url":"https://github.com/evanjd","followers_url":"https://api.github.com/users/evanjd/followers","following_url":"https://api.github.com/users/evanjd/following{/other_user}","gists_url":"https://api.github.com/users/evanjd/gists{/gist_id}","starred_url":"https://api.github.com/users/evanjd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanjd/subscriptions","organizations_url":"https://api.github.com/users/evanjd/orgs","repos_url":"https://api.github.com/users/evanjd/repos","events_url":"https://api.github.com/users/evanjd/events{/privacy}","received_events_url":"https://api.github.com/users/evanjd/received_events","type":"User","site_admin":false},"body":"Both table and item actions now support an optional `icon` attribute.\r\n\r\n**Item action example:**\r\n<img width=\"791\" alt=\"screen shot 2018-10-29 at 4 40 54 pm\" src=\"https://user-images.githubusercontent.com/4055224/47631247-712c2d80-db99-11e8-9b56-bc6357226ef7.png\">\r\n\r\n**Table action example:**\r\n<img width=\"130\" alt=\"screen shot 2018-10-29 at 4 41 35 pm\" src=\"https://user-images.githubusercontent.com/4055224/47631261-86a15780-db99-11e8-8886-1814060a3534.png\">\r\n\r\n---\r\n\r\nI've also split the table actions and column selector into separate dropdowns.\r\n<img width=\"299\" alt=\"screen shot 2018-10-29 at 4 42 22 pm\" src=\"https://user-images.githubusercontent.com/4055224/47631438-27901280-db9a-11e8-9347-a7ffea2e0e73.png\">\r\n\r\nThe mixing of table actions and column selections has been creating some confusion for users (at least on App Engine). Some of the issues are:\r\n* There's no way to differentiate between a table action and a hidden column selection without clicking on it (or matching the column name to a column shown). It's only once you click on the dropdown entry does its behaviour become known (if it's a table action, the action is performed. If it's a hidden column selection, a tick appears and the column is rendered in the grid).\r\n* With adding icon support, mixing column ticks and custom icons looked... awkward. \r\n\r\nIf anyone feels strongly for keeping these column selections and table actions merged in a single dropdown, please let me know! :)","created_at":"2018-10-29T05:47:46Z","updated_at":"2018-10-29T05:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/813/commits","review_comments_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/813/comments","review_comment_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues/813/comments","statuses_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/statuses/f0a60ea26c391dcedca1d3301eca5850e44cd7bc","head":{"label":"evanjd:action-menu-icons","ref":"action-menu-icons","sha":"f0a60ea26c391dcedca1d3301eca5850e44cd7bc","user":{"login":"evanjd","id":4055224,"node_id":"MDQ6VXNlcjQwNTUyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4055224?v=4","gravatar_id":"","url":"https://api.github.com/users/evanjd","html_url":"https://github.com/evanjd","followers_url":"https://api.github.com/users/evanjd/followers","following_url":"https://api.github.com/users/evanjd/following{/other_user}","gists_url":"https://api.github.com/users/evanjd/gists{/gist_id}","starred_url":"https://api.github.com/users/evanjd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanjd/subscriptions","organizations_url":"https://api.github.com/users/evanjd/orgs","repos_url":"https://api.github.com/users/evanjd/repos","events_url":"https://api.github.com/users/evanjd/events{/privacy}","received_events_url":"https://api.github.com/users/evanjd/received_events","type":"User","site_admin":false},"repo":{"id":155144655,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxNDQ2NTU=","name":"px-data-grid","full_name":"evanjd/px-data-grid","private":false,"owner":{"login":"evanjd","id":4055224,"node_id":"MDQ6VXNlcjQwNTUyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4055224?v=4","gravatar_id":"","url":"https://api.github.com/users/evanjd","html_url":"https://github.com/evanjd","followers_url":"https://api.github.com/users/evanjd/followers","following_url":"https://api.github.com/users/evanjd/following{/other_user}","gists_url":"https://api.github.com/users/evanjd/gists{/gist_id}","starred_url":"https://api.github.com/users/evanjd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanjd/subscriptions","organizations_url":"https://api.github.com/users/evanjd/orgs","repos_url":"https://api.github.com/users/evanjd/repos","events_url":"https://api.github.com/users/evanjd/events{/privacy}","received_events_url":"https://api.github.com/users/evanjd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/evanjd/px-data-grid","description":"Predix UI component which defines a data grid","fork":true,"url":"https://api.github.com/repos/evanjd/px-data-grid","forks_url":"https://api.github.com/repos/evanjd/px-data-grid/forks","keys_url":"https://api.github.com/repos/evanjd/px-data-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evanjd/px-data-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evanjd/px-data-grid/teams","hooks_url":"https://api.github.com/repos/evanjd/px-data-grid/hooks","issue_events_url":"https://api.github.com/repos/evanjd/px-data-grid/issues/events{/number}","events_url":"https://api.github.com/repos/evanjd/px-data-grid/events","assignees_url":"https://api.github.com/repos/evanjd/px-data-grid/assignees{/user}","branches_url":"https://api.github.com/repos/evanjd/px-data-grid/branches{/branch}","tags_url":"https://api.github.com/repos/evanjd/px-data-grid/tags","blobs_url":"https://api.github.com/repos/evanjd/px-data-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evanjd/px-data-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evanjd/px-data-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/evanjd/px-data-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evanjd/px-data-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/evanjd/px-data-grid/languages","stargazers_url":"https://api.github.com/repos/evanjd/px-data-grid/stargazers","contributors_url":"https://api.github.com/repos/evanjd/px-data-grid/contributors","subscribers_url":"https://api.github.com/repos/evanjd/px-data-grid/subscribers","subscription_url":"https://api.github.com/repos/evanjd/px-data-grid/subscription","commits_url":"https://api.github.com/repos/evanjd/px-data-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/evanjd/px-data-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/evanjd/px-data-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/evanjd/px-data-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/evanjd/px-data-grid/contents/{+path}","compare_url":"https://api.github.com/repos/evanjd/px-data-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evanjd/px-data-grid/merges","archive_url":"https://api.github.com/repos/evanjd/px-data-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evanjd/px-data-grid/downloads","issues_url":"https://api.github.com/repos/evanjd/px-data-grid/issues{/number}","pulls_url":"https://api.github.com/repos/evanjd/px-data-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/evanjd/px-data-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/evanjd/px-data-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evanjd/px-data-grid/labels{/name}","releases_url":"https://api.github.com/repos/evanjd/px-data-grid/releases{/id}","deployments_url":"https://api.github.com/repos/evanjd/px-data-grid/deployments","created_at":"2018-10-29T03:11:20Z","updated_at":"2018-10-29T03:11:22Z","pushed_at":"2018-10-29T05:39:38Z","git_url":"git://github.com/evanjd/px-data-grid.git","ssh_url":"git@github.com:evanjd/px-data-grid.git","clone_url":"https://github.com/evanjd/px-data-grid.git","svn_url":"https://github.com/evanjd/px-data-grid","homepage":"https://www.predix-ui.com/#/elements/px-data-grid","size":2813,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"predixdesignsystem:master","ref":"master","sha":"065faee973903e2d65cea5dc3dcb415618cb6498","user":{"login":"predixdesignsystem","id":32078779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDc4Nzc5","avatar_url":"https://avatars2.githubusercontent.com/u/32078779?v=4","gravatar_id":"","url":"https://api.github.com/users/predixdesignsystem","html_url":"https://github.com/predixdesignsystem","followers_url":"https://api.github.com/users/predixdesignsystem/followers","following_url":"https://api.github.com/users/predixdesignsystem/following{/other_user}","gists_url":"https://api.github.com/users/predixdesignsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/predixdesignsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predixdesignsystem/subscriptions","organizations_url":"https://api.github.com/users/predixdesignsystem/orgs","repos_url":"https://api.github.com/users/predixdesignsystem/repos","events_url":"https://api.github.com/users/predixdesignsystem/events{/privacy}","received_events_url":"https://api.github.com/users/predixdesignsystem/received_events","type":"Organization","site_admin":false},"repo":{"id":109969268,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NjkyNjg=","name":"px-data-grid","full_name":"predixdesignsystem/px-data-grid","private":false,"owner":{"login":"predixdesignsystem","id":32078779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDc4Nzc5","avatar_url":"https://avatars2.githubusercontent.com/u/32078779?v=4","gravatar_id":"","url":"https://api.github.com/users/predixdesignsystem","html_url":"https://github.com/predixdesignsystem","followers_url":"https://api.github.com/users/predixdesignsystem/followers","following_url":"https://api.github.com/users/predixdesignsystem/following{/other_user}","gists_url":"https://api.github.com/users/predixdesignsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/predixdesignsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predixdesignsystem/subscriptions","organizations_url":"https://api.github.com/users/predixdesignsystem/orgs","repos_url":"https://api.github.com/users/predixdesignsystem/repos","events_url":"https://api.github.com/users/predixdesignsystem/events{/privacy}","received_events_url":"https://api.github.com/users/predixdesignsystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/predixdesignsystem/px-data-grid","description":"Predix UI component which defines a data grid","fork":false,"url":"https://api.github.com/repos/predixdesignsystem/px-data-grid","forks_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/forks","keys_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/teams","hooks_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/hooks","issue_events_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues/events{/number}","events_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/events","assignees_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/assignees{/user}","branches_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/branches{/branch}","tags_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/tags","blobs_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/languages","stargazers_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/stargazers","contributors_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/contributors","subscribers_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/subscribers","subscription_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/subscription","commits_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/contents/{+path}","compare_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/merges","archive_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/downloads","issues_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues{/number}","pulls_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/labels{/name}","releases_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/releases{/id}","deployments_url":"https://api.github.com/repos/predixdesignsystem/px-data-grid/deployments","created_at":"2017-11-08T11:50:20Z","updated_at":"2018-10-15T21:51:49Z","pushed_at":"2018-10-15T21:52:12Z","git_url":"git://github.com/predixdesignsystem/px-data-grid.git","ssh_url":"git@github.com:predixdesignsystem/px-data-grid.git","clone_url":"https://github.com/predixdesignsystem/px-data-grid.git","svn_url":"https://github.com/predixdesignsystem/px-data-grid","homepage":"https://www.predix-ui.com/#/elements/px-data-grid","size":3363,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":78,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/813"},"html":{"href":"https://github.com/predixdesignsystem/px-data-grid/pull/813"},"issue":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues/813"},"comments":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/predixdesignsystem/px-data-grid/statuses/f0a60ea26c391dcedca1d3301eca5850e44cd7bc"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":953,"deletions":743,"changed_files":8}}
{"actor":{"display_login":"evanjd"}}