{"action":"created","comment":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/comments/220735194","pull_request_review_id":159213283,"id":220735194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDczNTE5NA==","diff_hunk":"@@ -35,6 +35,7 @@ type HTTPClient struct {\n \tBaseURL        string\n \tDefaultHeaders map[string]string\n \tloggers        map[string]*zap.Logger\n+\tScopes         map[string]tally.Scope","path":"runtime/http_client.go","position":4,"original_position":4,"commit_id":"22442575f04f1054586c837abf55599a4384ba20","original_commit_id":"22442575f04f1054586c837abf55599a4384ba20","user":{"login":"jacobgreenleaf","id":2646558,"node_id":"MDQ6VXNlcjI2NDY1NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2646558?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobgreenleaf","html_url":"https://github.com/jacobgreenleaf","followers_url":"https://api.github.com/users/jacobgreenleaf/followers","following_url":"https://api.github.com/users/jacobgreenleaf/following{/other_user}","gists_url":"https://api.github.com/users/jacobgreenleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobgreenleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobgreenleaf/subscriptions","organizations_url":"https://api.github.com/users/jacobgreenleaf/orgs","repos_url":"https://api.github.com/users/jacobgreenleaf/repos","events_url":"https://api.github.com/users/jacobgreenleaf/events{/privacy}","received_events_url":"https://api.github.com/users/jacobgreenleaf/received_events","type":"User","site_admin":false},"body":"You should expose the singleton scope. These properties are going away in the future. I will probably mark them as deprecated soon. ","created_at":"2018-09-26T21:51:24Z","updated_at":"2018-09-26T21:51:24Z","html_url":"https://github.com/uber/zanzibar/pull/470#discussion_r220735194","pull_request_url":"https://api.github.com/repos/uber/zanzibar/pulls/470","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments/220735194"},"html":{"href":"https://github.com/uber/zanzibar/pull/470#discussion_r220735194"},"pull_request":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/470"}}},"pull_request":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/470","id":218460562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDYwNTYy","html_url":"https://github.com/uber/zanzibar/pull/470","diff_url":"https://github.com/uber/zanzibar/pull/470.diff","patch_url":"https://github.com/uber/zanzibar/pull/470.patch","issue_url":"https://api.github.com/repos/uber/zanzibar/issues/470","number":470,"state":"open","locked":false,"title":"Expose Scopes for HTTPClient","user":{"login":"edwinzg","id":3210346,"node_id":"MDQ6VXNlcjMyMTAzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3210346?v=4","gravatar_id":"","url":"https://api.github.com/users/edwinzg","html_url":"https://github.com/edwinzg","followers_url":"https://api.github.com/users/edwinzg/followers","following_url":"https://api.github.com/users/edwinzg/following{/other_user}","gists_url":"https://api.github.com/users/edwinzg/gists{/gist_id}","starred_url":"https://api.github.com/users/edwinzg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwinzg/subscriptions","organizations_url":"https://api.github.com/users/edwinzg/orgs","repos_url":"https://api.github.com/users/edwinzg/repos","events_url":"https://api.github.com/users/edwinzg/events{/privacy}","received_events_url":"https://api.github.com/users/edwinzg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-26T21:28:33Z","updated_at":"2018-09-26T21:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e53c472953c20193d8d85f9c83dee1aa203fa436","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/zanzibar/pulls/470/commits","review_comments_url":"https://api.github.com/repos/uber/zanzibar/pulls/470/comments","review_comment_url":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/zanzibar/issues/470/comments","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/22442575f04f1054586c837abf55599a4384ba20","head":{"label":"uber:edwin.httpScope","ref":"edwin.httpScope","sha":"22442575f04f1054586c837abf55599a4384ba20","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYyODY1NQ==","name":"zanzibar","full_name":"uber/zanzibar","private":false,"owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versioned API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2018-09-26T13:34:46Z","pushed_at":"2018-09-26T21:28:33Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":14448,"stargazers_count":86,"watchers_count":86,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":28,"watchers":86,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"2939c4d101d891ea788e8e378eebca1b0f915801","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYyODY1NQ==","name":"zanzibar","full_name":"uber/zanzibar","private":false,"owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versioned API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2018-09-26T13:34:46Z","pushed_at":"2018-09-26T21:28:33Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":14448,"stargazers_count":86,"watchers_count":86,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":28,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/470"},"html":{"href":"https://github.com/uber/zanzibar/pull/470"},"issue":{"href":"https://api.github.com/repos/uber/zanzibar/issues/470"},"comments":{"href":"https://api.github.com/repos/uber/zanzibar/issues/470/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/470/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/470/commits"},"statuses":{"href":"https://api.github.com/repos/uber/zanzibar/statuses/22442575f04f1054586c837abf55599a4384ba20"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jacobgreenleaf"}}