{"action":"created","comment":{"url":"https://api.github.com/repos/watir/watir/pulls/comments/236004903","pull_request_review_id":177384962,"id":236004903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAwNDkwMw==","diff_hunk":"@@ -1,8 +1,12 @@\n module Watir\n   class Radio < Input\n-    def initialize(query_scope, selector)\n-      super\n+    def build\n       @selector[:label] = @selector.delete(:text) if @selector.key?(:text)\n+      super\n+    end\n+\n+    def driver_scope","path":"lib/watir/elements/radio.rb","position":10,"original_position":10,"commit_id":"943b81d4d3c111c0db448d1d8ebd0fb5e10fa8ee","original_commit_id":"943b81d4d3c111c0db448d1d8ebd0fb5e10fa8ee","user":{"login":"jkotests","id":2652587,"node_id":"MDQ6VXNlcjI2NTI1ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2652587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotests","html_url":"https://github.com/jkotests","followers_url":"https://api.github.com/users/jkotests/followers","following_url":"https://api.github.com/users/jkotests/following{/other_user}","gists_url":"https://api.github.com/users/jkotests/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotests/subscriptions","organizations_url":"https://api.github.com/users/jkotests/orgs","repos_url":"https://api.github.com/users/jkotests/repos","events_url":"https://api.github.com/users/jkotests/events{/privacy}","received_events_url":"https://api.github.com/users/jkotests/received_events","type":"User","site_admin":false},"body":"What is different about `Radio` that requires this?","created_at":"2018-11-23T18:36:01Z","updated_at":"2018-11-23T18:37:33Z","html_url":"https://github.com/watir/watir/pull/822#discussion_r236004903","pull_request_url":"https://api.github.com/repos/watir/watir/pulls/822","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/watir/watir/pulls/comments/236004903"},"html":{"href":"https://github.com/watir/watir/pull/822#discussion_r236004903"},"pull_request":{"href":"https://api.github.com/repos/watir/watir/pulls/822"}}},"pull_request":{"url":"https://api.github.com/repos/watir/watir/pulls/822","id":231810880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODEwODgw","html_url":"https://github.com/watir/watir/pull/822","diff_url":"https://github.com/watir/watir/pull/822.diff","patch_url":"https://github.com/watir/watir/pull/822.patch","issue_url":"https://api.github.com/repos/watir/watir/issues/822","number":822,"state":"open","locked":false,"title":"Nested elements","user":{"login":"titusfortner","id":777185,"node_id":"MDQ6VXNlcjc3NzE4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777185?v=4","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"body":"Ok, so this is where things start getting interesting...\r\n\r\n`#cache=` is supposed to allow for distinguishing between\r\n1. > This element is defined as a wrapping of a Selenium Element and can not be relocated\r\n2. > This element can be relocated by the provided Selector, but the Selenium Element is already located, so we add it as cached.\r\n\r\nThis PR builds the selector when Element is initialized rather than when it is located.\r\nThis allows us to determine on initialization if a single XPath can be created for nested elements, and allows us to bypass recursion during location.","created_at":"2018-11-18T20:13:45Z","updated_at":"2018-11-23T18:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db8cbed87cade3ab1266f4172a2a720acdd027e5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lmtierney","id":4405962,"node_id":"MDQ6VXNlcjQ0MDU5NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4405962?v=4","gravatar_id":"","url":"https://api.github.com/users/lmtierney","html_url":"https://github.com/lmtierney","followers_url":"https://api.github.com/users/lmtierney/followers","following_url":"https://api.github.com/users/lmtierney/following{/other_user}","gists_url":"https://api.github.com/users/lmtierney/gists{/gist_id}","starred_url":"https://api.github.com/users/lmtierney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmtierney/subscriptions","organizations_url":"https://api.github.com/users/lmtierney/orgs","repos_url":"https://api.github.com/users/lmtierney/repos","events_url":"https://api.github.com/users/lmtierney/events{/privacy}","received_events_url":"https://api.github.com/users/lmtierney/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/watir/watir/pulls/822/commits","review_comments_url":"https://api.github.com/repos/watir/watir/pulls/822/comments","review_comment_url":"https://api.github.com/repos/watir/watir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/watir/watir/issues/822/comments","statuses_url":"https://api.github.com/repos/watir/watir/statuses/943b81d4d3c111c0db448d1d8ebd0fb5e10fa8ee","head":{"label":"titusfortner:nested_elements","ref":"nested_elements","sha":"943b81d4d3c111c0db448d1d8ebd0fb5e10fa8ee","user":{"login":"titusfortner","id":777185,"node_id":"MDQ6VXNlcjc3NzE4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777185?v=4","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"repo":{"id":23891829,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTgyOQ==","name":"watir","full_name":"titusfortner/watir","private":false,"owner":{"login":"titusfortner","id":777185,"node_id":"MDQ6VXNlcjc3NzE4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777185?v=4","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/titusfortner/watir","description":"Watir implementation on WebDriver","fork":true,"url":"https://api.github.com/repos/titusfortner/watir","forks_url":"https://api.github.com/repos/titusfortner/watir/forks","keys_url":"https://api.github.com/repos/titusfortner/watir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/titusfortner/watir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/titusfortner/watir/teams","hooks_url":"https://api.github.com/repos/titusfortner/watir/hooks","issue_events_url":"https://api.github.com/repos/titusfortner/watir/issues/events{/number}","events_url":"https://api.github.com/repos/titusfortner/watir/events","assignees_url":"https://api.github.com/repos/titusfortner/watir/assignees{/user}","branches_url":"https://api.github.com/repos/titusfortner/watir/branches{/branch}","tags_url":"https://api.github.com/repos/titusfortner/watir/tags","blobs_url":"https://api.github.com/repos/titusfortner/watir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/titusfortner/watir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/titusfortner/watir/git/refs{/sha}","trees_url":"https://api.github.com/repos/titusfortner/watir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/titusfortner/watir/statuses/{sha}","languages_url":"https://api.github.com/repos/titusfortner/watir/languages","stargazers_url":"https://api.github.com/repos/titusfortner/watir/stargazers","contributors_url":"https://api.github.com/repos/titusfortner/watir/contributors","subscribers_url":"https://api.github.com/repos/titusfortner/watir/subscribers","subscription_url":"https://api.github.com/repos/titusfortner/watir/subscription","commits_url":"https://api.github.com/repos/titusfortner/watir/commits{/sha}","git_commits_url":"https://api.github.com/repos/titusfortner/watir/git/commits{/sha}","comments_url":"https://api.github.com/repos/titusfortner/watir/comments{/number}","issue_comment_url":"https://api.github.com/repos/titusfortner/watir/issues/comments{/number}","contents_url":"https://api.github.com/repos/titusfortner/watir/contents/{+path}","compare_url":"https://api.github.com/repos/titusfortner/watir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/titusfortner/watir/merges","archive_url":"https://api.github.com/repos/titusfortner/watir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/titusfortner/watir/downloads","issues_url":"https://api.github.com/repos/titusfortner/watir/issues{/number}","pulls_url":"https://api.github.com/repos/titusfortner/watir/pulls{/number}","milestones_url":"https://api.github.com/repos/titusfortner/watir/milestones{/number}","notifications_url":"https://api.github.com/repos/titusfortner/watir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/titusfortner/watir/labels{/name}","releases_url":"https://api.github.com/repos/titusfortner/watir/releases{/id}","deployments_url":"https://api.github.com/repos/titusfortner/watir/deployments","created_at":"2014-09-10T20:53:36Z","updated_at":"2018-10-26T12:39:40Z","pushed_at":"2018-11-22T20:53:24Z","git_url":"git://github.com/titusfortner/watir.git","ssh_url":"git@github.com:titusfortner/watir.git","clone_url":"https://github.com/titusfortner/watir.git","svn_url":"https://github.com/titusfortner/watir","homepage":"http://watirwebdriver.com","size":8767,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"watir:master","ref":"master","sha":"593a7f3a16361cb239013318c1e4b9c859a617a1","user":{"login":"watir","id":1331009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzEwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1331009?v=4","gravatar_id":"","url":"https://api.github.com/users/watir","html_url":"https://github.com/watir","followers_url":"https://api.github.com/users/watir/followers","following_url":"https://api.github.com/users/watir/following{/other_user}","gists_url":"https://api.github.com/users/watir/gists{/gist_id}","starred_url":"https://api.github.com/users/watir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watir/subscriptions","organizations_url":"https://api.github.com/users/watir/orgs","repos_url":"https://api.github.com/users/watir/repos","events_url":"https://api.github.com/users/watir/events{/privacy}","received_events_url":"https://api.github.com/users/watir/received_events","type":"Organization","site_admin":false},"repo":{"id":366200,"node_id":"MDEwOlJlcG9zaXRvcnkzNjYyMDA=","name":"watir","full_name":"watir/watir","private":false,"owner":{"login":"watir","id":1331009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzEwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1331009?v=4","gravatar_id":"","url":"https://api.github.com/users/watir","html_url":"https://github.com/watir","followers_url":"https://api.github.com/users/watir/followers","following_url":"https://api.github.com/users/watir/following{/other_user}","gists_url":"https://api.github.com/users/watir/gists{/gist_id}","starred_url":"https://api.github.com/users/watir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watir/subscriptions","organizations_url":"https://api.github.com/users/watir/orgs","repos_url":"https://api.github.com/users/watir/repos","events_url":"https://api.github.com/users/watir/events{/privacy}","received_events_url":"https://api.github.com/users/watir/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/watir/watir","description":"Watir Powered By Selenium","fork":false,"url":"https://api.github.com/repos/watir/watir","forks_url":"https://api.github.com/repos/watir/watir/forks","keys_url":"https://api.github.com/repos/watir/watir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watir/watir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watir/watir/teams","hooks_url":"https://api.github.com/repos/watir/watir/hooks","issue_events_url":"https://api.github.com/repos/watir/watir/issues/events{/number}","events_url":"https://api.github.com/repos/watir/watir/events","assignees_url":"https://api.github.com/repos/watir/watir/assignees{/user}","branches_url":"https://api.github.com/repos/watir/watir/branches{/branch}","tags_url":"https://api.github.com/repos/watir/watir/tags","blobs_url":"https://api.github.com/repos/watir/watir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watir/watir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watir/watir/git/refs{/sha}","trees_url":"https://api.github.com/repos/watir/watir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watir/watir/statuses/{sha}","languages_url":"https://api.github.com/repos/watir/watir/languages","stargazers_url":"https://api.github.com/repos/watir/watir/stargazers","contributors_url":"https://api.github.com/repos/watir/watir/contributors","subscribers_url":"https://api.github.com/repos/watir/watir/subscribers","subscription_url":"https://api.github.com/repos/watir/watir/subscription","commits_url":"https://api.github.com/repos/watir/watir/commits{/sha}","git_commits_url":"https://api.github.com/repos/watir/watir/git/commits{/sha}","comments_url":"https://api.github.com/repos/watir/watir/comments{/number}","issue_comment_url":"https://api.github.com/repos/watir/watir/issues/comments{/number}","contents_url":"https://api.github.com/repos/watir/watir/contents/{+path}","compare_url":"https://api.github.com/repos/watir/watir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watir/watir/merges","archive_url":"https://api.github.com/repos/watir/watir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watir/watir/downloads","issues_url":"https://api.github.com/repos/watir/watir/issues{/number}","pulls_url":"https://api.github.com/repos/watir/watir/pulls{/number}","milestones_url":"https://api.github.com/repos/watir/watir/milestones{/number}","notifications_url":"https://api.github.com/repos/watir/watir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watir/watir/labels{/name}","releases_url":"https://api.github.com/repos/watir/watir/releases{/id}","deployments_url":"https://api.github.com/repos/watir/watir/deployments","created_at":"2009-11-09T11:40:46Z","updated_at":"2018-11-23T11:10:39Z","pushed_at":"2018-11-21T18:48:09Z","git_url":"git://github.com/watir/watir.git","ssh_url":"git@github.com:watir/watir.git","clone_url":"https://github.com/watir/watir.git","svn_url":"https://github.com/watir/watir","homepage":"http://watir.github.io","size":7973,"stargazers_count":1178,"watchers_count":1178,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":201,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":201,"open_issues":35,"watchers":1178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/watir/watir/pulls/822"},"html":{"href":"https://github.com/watir/watir/pull/822"},"issue":{"href":"https://api.github.com/repos/watir/watir/issues/822"},"comments":{"href":"https://api.github.com/repos/watir/watir/issues/822/comments"},"review_comments":{"href":"https://api.github.com/repos/watir/watir/pulls/822/comments"},"review_comment":{"href":"https://api.github.com/repos/watir/watir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/watir/watir/pulls/822/commits"},"statuses":{"href":"https://api.github.com/repos/watir/watir/statuses/943b81d4d3c111c0db448d1d8ebd0fb5e10fa8ee"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotests"}}