{"action":"created","comment":{"url":"https://api.github.com/repos/srittau/type-stub-pep/pulls/comments/242390965","pull_request_review_id":185887679,"id":242390965,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM5MDk2NQ==","diff_hunk":"@@ -259,6 +259,73 @@ No::\n         forward_reference: 'OtherClass'\n     class OtherClass: ...\n \n+Version and Platform Checks\n+---------------------------\n+\n+Type stubs for libraries that support multiple Python versions can use version\n+checks to supply version-specific type hints. Type stubs for different Python\n+versions should still conform to the most recent Python version's syntax, as\n+explain in the Syntax_ section above.\n+\n+Version checks are if-statements that use ``sys.version_info`` to determine the\n+current Python version. Version checks should only check against the ``major`` and\n+``minor`` parts of ``sys.version_info``.\n+\n+Yes::\n+\n+    if sys.version_info >= (3,):\n+      # Python 3-specific type hints.\n+    else:\n+      # Python 2-specific type hints.\n+\n+    if sys.version_info.major >= 3:","path":"pep-9999.rst","position":23,"original_position":23,"commit_id":"045e60f610bd162030a615c72fea81e703090abf","original_commit_id":"045e60f610bd162030a615c72fea81e703090abf","user":{"login":"JelleZijlstra","id":906600,"node_id":"MDQ6VXNlcjkwNjYwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/906600?v=4","gravatar_id":"","url":"https://api.github.com/users/JelleZijlstra","html_url":"https://github.com/JelleZijlstra","followers_url":"https://api.github.com/users/JelleZijlstra/followers","following_url":"https://api.github.com/users/JelleZijlstra/following{/other_user}","gists_url":"https://api.github.com/users/JelleZijlstra/gists{/gist_id}","starred_url":"https://api.github.com/users/JelleZijlstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JelleZijlstra/subscriptions","organizations_url":"https://api.github.com/users/JelleZijlstra/orgs","repos_url":"https://api.github.com/users/JelleZijlstra/repos","events_url":"https://api.github.com/users/JelleZijlstra/events{/privacy}","received_events_url":"https://api.github.com/users/JelleZijlstra/received_events","type":"User","site_admin":false},"body":"Does this currently work? I think I prefer that we allow *only* tuple-based comparisons, so that type checkers don't have to support tuple and `.major`-based operations.","created_at":"2018-12-18T02:45:32Z","updated_at":"2018-12-18T02:46:49Z","html_url":"https://github.com/srittau/type-stub-pep/pull/25#discussion_r242390965","pull_request_url":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/srittau/type-stub-pep/pulls/comments/242390965"},"html":{"href":"https://github.com/srittau/type-stub-pep/pull/25#discussion_r242390965"},"pull_request":{"href":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25","id":239325186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzI1MTg2","html_url":"https://github.com/srittau/type-stub-pep/pull/25","diff_url":"https://github.com/srittau/type-stub-pep/pull/25.diff","patch_url":"https://github.com/srittau/type-stub-pep/pull/25.patch","issue_url":"https://api.github.com/repos/srittau/type-stub-pep/issues/25","number":25,"state":"open","locked":false,"title":"[WIP] Add Version and Platform Checks section","user":{"login":"Solumin","id":930857,"node_id":"MDQ6VXNlcjkzMDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/930857?v=4","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false},"body":"Version check requirements drawn from PEP 484 and stub files in typeshed.","created_at":"2018-12-18T00:12:17Z","updated_at":"2018-12-18T02:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59717e94ff6e2055bf158c58a4b3967444bc9a16","assignee":{"login":"Solumin","id":930857,"node_id":"MDQ6VXNlcjkzMDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/930857?v=4","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false},"assignees":[{"login":"Solumin","id":930857,"node_id":"MDQ6VXNlcjkzMDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/930857?v=4","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25/commits","review_comments_url":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25/comments","review_comment_url":"https://api.github.com/repos/srittau/type-stub-pep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/srittau/type-stub-pep/issues/25/comments","statuses_url":"https://api.github.com/repos/srittau/type-stub-pep/statuses/045e60f610bd162030a615c72fea81e703090abf","head":{"label":"srittau:version-checks-style-1","ref":"version-checks-style-1","sha":"045e60f610bd162030a615c72fea81e703090abf","user":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"repo":{"id":141568290,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NjgyOTA=","name":"type-stub-pep","full_name":"srittau/type-stub-pep","private":false,"owner":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/srittau/type-stub-pep","description":"Python Enhancement Proposals","fork":true,"url":"https://api.github.com/repos/srittau/type-stub-pep","forks_url":"https://api.github.com/repos/srittau/type-stub-pep/forks","keys_url":"https://api.github.com/repos/srittau/type-stub-pep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srittau/type-stub-pep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srittau/type-stub-pep/teams","hooks_url":"https://api.github.com/repos/srittau/type-stub-pep/hooks","issue_events_url":"https://api.github.com/repos/srittau/type-stub-pep/issues/events{/number}","events_url":"https://api.github.com/repos/srittau/type-stub-pep/events","assignees_url":"https://api.github.com/repos/srittau/type-stub-pep/assignees{/user}","branches_url":"https://api.github.com/repos/srittau/type-stub-pep/branches{/branch}","tags_url":"https://api.github.com/repos/srittau/type-stub-pep/tags","blobs_url":"https://api.github.com/repos/srittau/type-stub-pep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srittau/type-stub-pep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srittau/type-stub-pep/git/refs{/sha}","trees_url":"https://api.github.com/repos/srittau/type-stub-pep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srittau/type-stub-pep/statuses/{sha}","languages_url":"https://api.github.com/repos/srittau/type-stub-pep/languages","stargazers_url":"https://api.github.com/repos/srittau/type-stub-pep/stargazers","contributors_url":"https://api.github.com/repos/srittau/type-stub-pep/contributors","subscribers_url":"https://api.github.com/repos/srittau/type-stub-pep/subscribers","subscription_url":"https://api.github.com/repos/srittau/type-stub-pep/subscription","commits_url":"https://api.github.com/repos/srittau/type-stub-pep/commits{/sha}","git_commits_url":"https://api.github.com/repos/srittau/type-stub-pep/git/commits{/sha}","comments_url":"https://api.github.com/repos/srittau/type-stub-pep/comments{/number}","issue_comment_url":"https://api.github.com/repos/srittau/type-stub-pep/issues/comments{/number}","contents_url":"https://api.github.com/repos/srittau/type-stub-pep/contents/{+path}","compare_url":"https://api.github.com/repos/srittau/type-stub-pep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srittau/type-stub-pep/merges","archive_url":"https://api.github.com/repos/srittau/type-stub-pep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srittau/type-stub-pep/downloads","issues_url":"https://api.github.com/repos/srittau/type-stub-pep/issues{/number}","pulls_url":"https://api.github.com/repos/srittau/type-stub-pep/pulls{/number}","milestones_url":"https://api.github.com/repos/srittau/type-stub-pep/milestones{/number}","notifications_url":"https://api.github.com/repos/srittau/type-stub-pep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srittau/type-stub-pep/labels{/name}","releases_url":"https://api.github.com/repos/srittau/type-stub-pep/releases{/id}","deployments_url":"https://api.github.com/repos/srittau/type-stub-pep/deployments","created_at":"2018-07-19T11:11:44Z","updated_at":"2018-11-15T18:43:06Z","pushed_at":"2018-12-18T00:12:18Z","git_url":"git://github.com/srittau/type-stub-pep.git","ssh_url":"git@github.com:srittau/type-stub-pep.git","clone_url":"https://github.com/srittau/type-stub-pep.git","svn_url":"https://github.com/srittau/type-stub-pep","homepage":"https://www.python.org/dev/peps/","size":11246,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"srittau:type-stub-pep","ref":"type-stub-pep","sha":"0be0c4e3776e4c4f6781e58fab8a4caea1b51ed3","user":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"repo":{"id":141568290,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NjgyOTA=","name":"type-stub-pep","full_name":"srittau/type-stub-pep","private":false,"owner":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/srittau/type-stub-pep","description":"Python Enhancement Proposals","fork":true,"url":"https://api.github.com/repos/srittau/type-stub-pep","forks_url":"https://api.github.com/repos/srittau/type-stub-pep/forks","keys_url":"https://api.github.com/repos/srittau/type-stub-pep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srittau/type-stub-pep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srittau/type-stub-pep/teams","hooks_url":"https://api.github.com/repos/srittau/type-stub-pep/hooks","issue_events_url":"https://api.github.com/repos/srittau/type-stub-pep/issues/events{/number}","events_url":"https://api.github.com/repos/srittau/type-stub-pep/events","assignees_url":"https://api.github.com/repos/srittau/type-stub-pep/assignees{/user}","branches_url":"https://api.github.com/repos/srittau/type-stub-pep/branches{/branch}","tags_url":"https://api.github.com/repos/srittau/type-stub-pep/tags","blobs_url":"https://api.github.com/repos/srittau/type-stub-pep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srittau/type-stub-pep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srittau/type-stub-pep/git/refs{/sha}","trees_url":"https://api.github.com/repos/srittau/type-stub-pep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srittau/type-stub-pep/statuses/{sha}","languages_url":"https://api.github.com/repos/srittau/type-stub-pep/languages","stargazers_url":"https://api.github.com/repos/srittau/type-stub-pep/stargazers","contributors_url":"https://api.github.com/repos/srittau/type-stub-pep/contributors","subscribers_url":"https://api.github.com/repos/srittau/type-stub-pep/subscribers","subscription_url":"https://api.github.com/repos/srittau/type-stub-pep/subscription","commits_url":"https://api.github.com/repos/srittau/type-stub-pep/commits{/sha}","git_commits_url":"https://api.github.com/repos/srittau/type-stub-pep/git/commits{/sha}","comments_url":"https://api.github.com/repos/srittau/type-stub-pep/comments{/number}","issue_comment_url":"https://api.github.com/repos/srittau/type-stub-pep/issues/comments{/number}","contents_url":"https://api.github.com/repos/srittau/type-stub-pep/contents/{+path}","compare_url":"https://api.github.com/repos/srittau/type-stub-pep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srittau/type-stub-pep/merges","archive_url":"https://api.github.com/repos/srittau/type-stub-pep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srittau/type-stub-pep/downloads","issues_url":"https://api.github.com/repos/srittau/type-stub-pep/issues{/number}","pulls_url":"https://api.github.com/repos/srittau/type-stub-pep/pulls{/number}","milestones_url":"https://api.github.com/repos/srittau/type-stub-pep/milestones{/number}","notifications_url":"https://api.github.com/repos/srittau/type-stub-pep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srittau/type-stub-pep/labels{/name}","releases_url":"https://api.github.com/repos/srittau/type-stub-pep/releases{/id}","deployments_url":"https://api.github.com/repos/srittau/type-stub-pep/deployments","created_at":"2018-07-19T11:11:44Z","updated_at":"2018-11-15T18:43:06Z","pushed_at":"2018-12-18T00:12:18Z","git_url":"git://github.com/srittau/type-stub-pep.git","ssh_url":"git@github.com:srittau/type-stub-pep.git","clone_url":"https://github.com/srittau/type-stub-pep.git","svn_url":"https://github.com/srittau/type-stub-pep","homepage":"https://www.python.org/dev/peps/","size":11246,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25"},"html":{"href":"https://github.com/srittau/type-stub-pep/pull/25"},"issue":{"href":"https://api.github.com/repos/srittau/type-stub-pep/issues/25"},"comments":{"href":"https://api.github.com/repos/srittau/type-stub-pep/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/srittau/type-stub-pep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/srittau/type-stub-pep/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/srittau/type-stub-pep/statuses/045e60f610bd162030a615c72fea81e703090abf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"JelleZijlstra"}}