{"action":"created","comment":{"url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/comments/195813234","pull_request_review_id":129257306,"id":195813234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTgxMzIzNA==","diff_hunk":"@@ -841,7 +847,11 @@ void* mqtt_sn_wait_for(uint8_t type, int sock)\n             if (packet) {\n                 switch(packet[1]) {\n                     case MQTT_SN_TYPE_PUBLISH:\n-                        mqtt_sn_print_publish_packet((publish_packet_t *)packet);\n+                        rc = mqtt_sn_print_publish_packet((publish_packet_t *)packet);\n+                        if(type == packet[1]){\n+                        \treturn packet;\n+                        }\n+                        mqtt_sn_send_puback(sock,(publish_packet_t *)packet,rc);","path":"mqtt-sn.c","position":46,"original_position":46,"commit_id":"8a01fe7e0df204b1f7a1a59c4ea972ee583aed65","original_commit_id":"8a01fe7e0df204b1f7a1a59c4ea972ee583aed65","user":{"login":"njh","id":38734,"node_id":"MDQ6VXNlcjM4NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/38734?v=4","gravatar_id":"","url":"https://api.github.com/users/njh","html_url":"https://github.com/njh","followers_url":"https://api.github.com/users/njh/followers","following_url":"https://api.github.com/users/njh/following{/other_user}","gists_url":"https://api.github.com/users/njh/gists{/gist_id}","starred_url":"https://api.github.com/users/njh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njh/subscriptions","organizations_url":"https://api.github.com/users/njh/orgs","repos_url":"https://api.github.com/users/njh/repos","events_url":"https://api.github.com/users/njh/events{/privacy}","received_events_url":"https://api.github.com/users/njh/received_events","type":"User","site_admin":false},"body":"Puback is sent in https://github.com/njh/mqtt-sn-tools/blob/ff65892a1c6755cc9eb2762bc3099e43a4ce1f8b/mqtt-sn-sub.c#L260\r\n\r\nI am trying to remember why `mqtt_sn_print_publish_packet()` is inside `mqtt_sn_wait_for()`\r\n\r\nBut I guess that is the same reason why you are missing some PUBACKs.\r\n","created_at":"2018-06-15T17:31:30Z","updated_at":"2018-06-15T17:31:30Z","html_url":"https://github.com/njh/mqtt-sn-tools/pull/31#discussion_r195813234","pull_request_url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/comments/195813234"},"html":{"href":"https://github.com/njh/mqtt-sn-tools/pull/31#discussion_r195813234"},"pull_request":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31","id":192974216,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTc0MjE2","html_url":"https://github.com/njh/mqtt-sn-tools/pull/31","diff_url":"https://github.com/njh/mqtt-sn-tools/pull/31.diff","patch_url":"https://github.com/njh/mqtt-sn-tools/pull/31.patch","issue_url":"https://api.github.com/repos/njh/mqtt-sn-tools/issues/31","number":31,"state":"open","locked":false,"title":"Reply with PUBACK when receiving a QoS1 PUBLISH","user":{"login":"RohithS98","id":36558130,"node_id":"MDQ6VXNlcjM2NTU4MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/36558130?v=4","gravatar_id":"","url":"https://api.github.com/users/RohithS98","html_url":"https://github.com/RohithS98","followers_url":"https://api.github.com/users/RohithS98/followers","following_url":"https://api.github.com/users/RohithS98/following{/other_user}","gists_url":"https://api.github.com/users/RohithS98/gists{/gist_id}","starred_url":"https://api.github.com/users/RohithS98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohithS98/subscriptions","organizations_url":"https://api.github.com/users/RohithS98/orgs","repos_url":"https://api.github.com/users/RohithS98/repos","events_url":"https://api.github.com/users/RohithS98/events{/privacy}","received_events_url":"https://api.github.com/users/RohithS98/received_events","type":"User","site_admin":false},"body":"Client automatically replies with PUBACK when receiving a PUBLISH of QoS 1 while waiting for another message\r\n#30 - Bug fix","created_at":"2018-06-06T10:54:52Z","updated_at":"2018-06-15T17:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"238c5892bed569f8037a14b9e9723faddb1a34f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31/commits","review_comments_url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31/comments","review_comment_url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/njh/mqtt-sn-tools/issues/31/comments","statuses_url":"https://api.github.com/repos/njh/mqtt-sn-tools/statuses/8a01fe7e0df204b1f7a1a59c4ea972ee583aed65","head":{"label":"RohithS98:master","ref":"master","sha":"8a01fe7e0df204b1f7a1a59c4ea972ee583aed65","user":{"login":"RohithS98","id":36558130,"node_id":"MDQ6VXNlcjM2NTU4MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/36558130?v=4","gravatar_id":"","url":"https://api.github.com/users/RohithS98","html_url":"https://github.com/RohithS98","followers_url":"https://api.github.com/users/RohithS98/followers","following_url":"https://api.github.com/users/RohithS98/following{/other_user}","gists_url":"https://api.github.com/users/RohithS98/gists{/gist_id}","starred_url":"https://api.github.com/users/RohithS98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohithS98/subscriptions","organizations_url":"https://api.github.com/users/RohithS98/orgs","repos_url":"https://api.github.com/users/RohithS98/repos","events_url":"https://api.github.com/users/RohithS98/events{/privacy}","received_events_url":"https://api.github.com/users/RohithS98/received_events","type":"User","site_admin":false},"repo":{"id":136310925,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMTA5MjU=","name":"mqtt-sn-tools","full_name":"RohithS98/mqtt-sn-tools","owner":{"login":"RohithS98","id":36558130,"node_id":"MDQ6VXNlcjM2NTU4MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/36558130?v=4","gravatar_id":"","url":"https://api.github.com/users/RohithS98","html_url":"https://github.com/RohithS98","followers_url":"https://api.github.com/users/RohithS98/followers","following_url":"https://api.github.com/users/RohithS98/following{/other_user}","gists_url":"https://api.github.com/users/RohithS98/gists{/gist_id}","starred_url":"https://api.github.com/users/RohithS98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohithS98/subscriptions","organizations_url":"https://api.github.com/users/RohithS98/orgs","repos_url":"https://api.github.com/users/RohithS98/repos","events_url":"https://api.github.com/users/RohithS98/events{/privacy}","received_events_url":"https://api.github.com/users/RohithS98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RohithS98/mqtt-sn-tools","description":"Command line tools written in C for the MQTT-SN (MQTT For Sensor Networks) protocol","fork":true,"url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools","forks_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/forks","keys_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/teams","hooks_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/hooks","issue_events_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/issues/events{/number}","events_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/events","assignees_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/assignees{/user}","branches_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/branches{/branch}","tags_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/tags","blobs_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/languages","stargazers_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/stargazers","contributors_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/contributors","subscribers_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/subscribers","subscription_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/subscription","commits_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/contents/{+path}","compare_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/merges","archive_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/downloads","issues_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/issues{/number}","pulls_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/labels{/name}","releases_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/releases{/id}","deployments_url":"https://api.github.com/repos/RohithS98/mqtt-sn-tools/deployments","created_at":"2018-06-06T10:11:01Z","updated_at":"2018-06-06T10:53:43Z","pushed_at":"2018-06-06T10:53:42Z","git_url":"git://github.com/RohithS98/mqtt-sn-tools.git","ssh_url":"git@github.com:RohithS98/mqtt-sn-tools.git","clone_url":"https://github.com/RohithS98/mqtt-sn-tools.git","svn_url":"https://github.com/RohithS98/mqtt-sn-tools","homepage":null,"size":608,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"njh:master","ref":"master","sha":"9c7e17b1499de1e48da6b8d98e8a4c570936caaa","user":{"login":"njh","id":38734,"node_id":"MDQ6VXNlcjM4NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/38734?v=4","gravatar_id":"","url":"https://api.github.com/users/njh","html_url":"https://github.com/njh","followers_url":"https://api.github.com/users/njh/followers","following_url":"https://api.github.com/users/njh/following{/other_user}","gists_url":"https://api.github.com/users/njh/gists{/gist_id}","starred_url":"https://api.github.com/users/njh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njh/subscriptions","organizations_url":"https://api.github.com/users/njh/orgs","repos_url":"https://api.github.com/users/njh/repos","events_url":"https://api.github.com/users/njh/events{/privacy}","received_events_url":"https://api.github.com/users/njh/received_events","type":"User","site_admin":false},"repo":{"id":14865723,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2NTcyMw==","name":"mqtt-sn-tools","full_name":"njh/mqtt-sn-tools","owner":{"login":"njh","id":38734,"node_id":"MDQ6VXNlcjM4NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/38734?v=4","gravatar_id":"","url":"https://api.github.com/users/njh","html_url":"https://github.com/njh","followers_url":"https://api.github.com/users/njh/followers","following_url":"https://api.github.com/users/njh/following{/other_user}","gists_url":"https://api.github.com/users/njh/gists{/gist_id}","starred_url":"https://api.github.com/users/njh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njh/subscriptions","organizations_url":"https://api.github.com/users/njh/orgs","repos_url":"https://api.github.com/users/njh/repos","events_url":"https://api.github.com/users/njh/events{/privacy}","received_events_url":"https://api.github.com/users/njh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njh/mqtt-sn-tools","description":"Command line tools written in C for the MQTT-SN (MQTT for Sensor Networks) protocol","fork":false,"url":"https://api.github.com/repos/njh/mqtt-sn-tools","forks_url":"https://api.github.com/repos/njh/mqtt-sn-tools/forks","keys_url":"https://api.github.com/repos/njh/mqtt-sn-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njh/mqtt-sn-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njh/mqtt-sn-tools/teams","hooks_url":"https://api.github.com/repos/njh/mqtt-sn-tools/hooks","issue_events_url":"https://api.github.com/repos/njh/mqtt-sn-tools/issues/events{/number}","events_url":"https://api.github.com/repos/njh/mqtt-sn-tools/events","assignees_url":"https://api.github.com/repos/njh/mqtt-sn-tools/assignees{/user}","branches_url":"https://api.github.com/repos/njh/mqtt-sn-tools/branches{/branch}","tags_url":"https://api.github.com/repos/njh/mqtt-sn-tools/tags","blobs_url":"https://api.github.com/repos/njh/mqtt-sn-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njh/mqtt-sn-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njh/mqtt-sn-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/njh/mqtt-sn-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njh/mqtt-sn-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/njh/mqtt-sn-tools/languages","stargazers_url":"https://api.github.com/repos/njh/mqtt-sn-tools/stargazers","contributors_url":"https://api.github.com/repos/njh/mqtt-sn-tools/contributors","subscribers_url":"https://api.github.com/repos/njh/mqtt-sn-tools/subscribers","subscription_url":"https://api.github.com/repos/njh/mqtt-sn-tools/subscription","commits_url":"https://api.github.com/repos/njh/mqtt-sn-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/njh/mqtt-sn-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/njh/mqtt-sn-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/njh/mqtt-sn-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/njh/mqtt-sn-tools/contents/{+path}","compare_url":"https://api.github.com/repos/njh/mqtt-sn-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njh/mqtt-sn-tools/merges","archive_url":"https://api.github.com/repos/njh/mqtt-sn-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njh/mqtt-sn-tools/downloads","issues_url":"https://api.github.com/repos/njh/mqtt-sn-tools/issues{/number}","pulls_url":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/njh/mqtt-sn-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/njh/mqtt-sn-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njh/mqtt-sn-tools/labels{/name}","releases_url":"https://api.github.com/repos/njh/mqtt-sn-tools/releases{/id}","deployments_url":"https://api.github.com/repos/njh/mqtt-sn-tools/deployments","created_at":"2013-12-02T15:13:48Z","updated_at":"2018-06-15T16:29:26Z","pushed_at":"2018-06-15T16:29:23Z","git_url":"git://github.com/njh/mqtt-sn-tools.git","ssh_url":"git@github.com:njh/mqtt-sn-tools.git","clone_url":"https://github.com/njh/mqtt-sn-tools.git","svn_url":"https://github.com/njh/mqtt-sn-tools","homepage":"","size":608,"stargazers_count":108,"watchers_count":108,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":57,"open_issues":3,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31"},"html":{"href":"https://github.com/njh/mqtt-sn-tools/pull/31"},"issue":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/issues/31"},"comments":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/njh/mqtt-sn-tools/statuses/8a01fe7e0df204b1f7a1a59c4ea972ee583aed65"}},"author_association":"NONE"}}
{"actor":{"display_login":"njh"}}