{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tla-plus/pulls/comments/176000964","pull_request_review_id":105625075,"id":176000964,"diff_hunk":"@@ -230,6 +235,7 @@ InternalRequest(i, r, log) ==\n \\* Send merge request to the leader of Region B.\n ProposeMergeRequest(i) ==\n   /\\ raft[i][RegionB].is_leader\n+  /\\ region[i][RegionB] = RegionNormal","path":"RaftMerge/RaftMerge.tla","position":34,"original_position":34,"commit_id":"b08ff513d69992b32d7b0c7b3b80bb54cb59e73d","original_commit_id":"b08ff513d69992b32d7b0c7b3b80bb54cb59e73d","user":{"login":"foreverbell","id":3240173,"avatar_url":"https://avatars3.githubusercontent.com/u/3240173?v=4","gravatar_id":"","url":"https://api.github.com/users/foreverbell","html_url":"https://github.com/foreverbell","followers_url":"https://api.github.com/users/foreverbell/followers","following_url":"https://api.github.com/users/foreverbell/following{/other_user}","gists_url":"https://api.github.com/users/foreverbell/gists{/gist_id}","starred_url":"https://api.github.com/users/foreverbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foreverbell/subscriptions","organizations_url":"https://api.github.com/users/foreverbell/orgs","repos_url":"https://api.github.com/users/foreverbell/repos","events_url":"https://api.github.com/users/foreverbell/events{/privacy}","received_events_url":"https://api.github.com/users/foreverbell/received_events","type":"User","site_admin":false},"body":"I add this line just to keep symmetry with L252. In fact it should not affect anything, because merge request will be proposed only once, and once applied, it will turn to `RegionMerging` state.","created_at":"2018-03-21T07:49:13Z","updated_at":"2018-03-21T07:49:13Z","html_url":"https://github.com/pingcap/tla-plus/pull/11#discussion_r176000964","pull_request_url":"https://api.github.com/repos/pingcap/tla-plus/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tla-plus/pulls/comments/176000964"},"html":{"href":"https://github.com/pingcap/tla-plus/pull/11#discussion_r176000964"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tla-plus/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tla-plus/pulls/11","id":176400706,"html_url":"https://github.com/pingcap/tla-plus/pull/11","diff_url":"https://github.com/pingcap/tla-plus/pull/11.diff","patch_url":"https://github.com/pingcap/tla-plus/pull/11.patch","issue_url":"https://api.github.com/repos/pingcap/tla-plus/issues/11","number":11,"state":"open","locked":false,"title":"RaftMerge: rollback and TLC models.","user":{"login":"foreverbell","id":3240173,"avatar_url":"https://avatars3.githubusercontent.com/u/3240173?v=4","gravatar_id":"","url":"https://api.github.com/users/foreverbell","html_url":"https://github.com/foreverbell","followers_url":"https://api.github.com/users/foreverbell/followers","following_url":"https://api.github.com/users/foreverbell/following{/other_user}","gists_url":"https://api.github.com/users/foreverbell/gists{/gist_id}","starred_url":"https://api.github.com/users/foreverbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foreverbell/subscriptions","organizations_url":"https://api.github.com/users/foreverbell/orgs","repos_url":"https://api.github.com/users/foreverbell/repos","events_url":"https://api.github.com/users/foreverbell/events{/privacy}","received_events_url":"https://api.github.com/users/foreverbell/received_events","type":"User","site_admin":false},"body":"Implemented rollback. This is controlled by a flag rather than epoch change. When rollback is enabled, merging will never happen, and leader A will try to perform rollback on B.\r\n\r\nAlso add 4 TLC models.\r\n* No rollback, leader A and B not on the same store.\r\n* No rollback, leader A and B on the same store.\r\n* Rollback, leader A and B not on the same store.\r\n* Rollback, leader A and B on the same store.\r\n\r\nThis PR concludes everything.","created_at":"2018-03-21T07:47:09Z","updated_at":"2018-03-21T07:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86fa15291e3e4d36a57061bd118ad71b651c538e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tla-plus/pulls/11/commits","review_comments_url":"https://api.github.com/repos/pingcap/tla-plus/pulls/11/comments","review_comment_url":"https://api.github.com/repos/pingcap/tla-plus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tla-plus/issues/11/comments","statuses_url":"https://api.github.com/repos/pingcap/tla-plus/statuses/b08ff513d69992b32d7b0c7b3b80bb54cb59e73d","head":{"label":"foreverbell:rollback","ref":"rollback","sha":"b08ff513d69992b32d7b0c7b3b80bb54cb59e73d","user":{"login":"foreverbell","id":3240173,"avatar_url":"https://avatars3.githubusercontent.com/u/3240173?v=4","gravatar_id":"","url":"https://api.github.com/users/foreverbell","html_url":"https://github.com/foreverbell","followers_url":"https://api.github.com/users/foreverbell/followers","following_url":"https://api.github.com/users/foreverbell/following{/other_user}","gists_url":"https://api.github.com/users/foreverbell/gists{/gist_id}","starred_url":"https://api.github.com/users/foreverbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foreverbell/subscriptions","organizations_url":"https://api.github.com/users/foreverbell/orgs","repos_url":"https://api.github.com/users/foreverbell/repos","events_url":"https://api.github.com/users/foreverbell/events{/privacy}","received_events_url":"https://api.github.com/users/foreverbell/received_events","type":"User","site_admin":false},"repo":{"id":117944719,"name":"tla-plus","full_name":"foreverbell/tla-plus","owner":{"login":"foreverbell","id":3240173,"avatar_url":"https://avatars3.githubusercontent.com/u/3240173?v=4","gravatar_id":"","url":"https://api.github.com/users/foreverbell","html_url":"https://github.com/foreverbell","followers_url":"https://api.github.com/users/foreverbell/followers","following_url":"https://api.github.com/users/foreverbell/following{/other_user}","gists_url":"https://api.github.com/users/foreverbell/gists{/gist_id}","starred_url":"https://api.github.com/users/foreverbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foreverbell/subscriptions","organizations_url":"https://api.github.com/users/foreverbell/orgs","repos_url":"https://api.github.com/users/foreverbell/repos","events_url":"https://api.github.com/users/foreverbell/events{/privacy}","received_events_url":"https://api.github.com/users/foreverbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foreverbell/tla-plus","description":null,"fork":true,"url":"https://api.github.com/repos/foreverbell/tla-plus","forks_url":"https://api.github.com/repos/foreverbell/tla-plus/forks","keys_url":"https://api.github.com/repos/foreverbell/tla-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foreverbell/tla-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foreverbell/tla-plus/teams","hooks_url":"https://api.github.com/repos/foreverbell/tla-plus/hooks","issue_events_url":"https://api.github.com/repos/foreverbell/tla-plus/issues/events{/number}","events_url":"https://api.github.com/repos/foreverbell/tla-plus/events","assignees_url":"https://api.github.com/repos/foreverbell/tla-plus/assignees{/user}","branches_url":"https://api.github.com/repos/foreverbell/tla-plus/branches{/branch}","tags_url":"https://api.github.com/repos/foreverbell/tla-plus/tags","blobs_url":"https://api.github.com/repos/foreverbell/tla-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foreverbell/tla-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foreverbell/tla-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/foreverbell/tla-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foreverbell/tla-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/foreverbell/tla-plus/languages","stargazers_url":"https://api.github.com/repos/foreverbell/tla-plus/stargazers","contributors_url":"https://api.github.com/repos/foreverbell/tla-plus/contributors","subscribers_url":"https://api.github.com/repos/foreverbell/tla-plus/subscribers","subscription_url":"https://api.github.com/repos/foreverbell/tla-plus/subscription","commits_url":"https://api.github.com/repos/foreverbell/tla-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/foreverbell/tla-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/foreverbell/tla-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/foreverbell/tla-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/foreverbell/tla-plus/contents/{+path}","compare_url":"https://api.github.com/repos/foreverbell/tla-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foreverbell/tla-plus/merges","archive_url":"https://api.github.com/repos/foreverbell/tla-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foreverbell/tla-plus/downloads","issues_url":"https://api.github.com/repos/foreverbell/tla-plus/issues{/number}","pulls_url":"https://api.github.com/repos/foreverbell/tla-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/foreverbell/tla-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/foreverbell/tla-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foreverbell/tla-plus/labels{/name}","releases_url":"https://api.github.com/repos/foreverbell/tla-plus/releases{/id}","deployments_url":"https://api.github.com/repos/foreverbell/tla-plus/deployments","created_at":"2018-01-18T06:54:57Z","updated_at":"2018-03-07T03:49:29Z","pushed_at":"2018-03-21T07:43:55Z","git_url":"git://github.com/foreverbell/tla-plus.git","ssh_url":"git@github.com:foreverbell/tla-plus.git","clone_url":"https://github.com/foreverbell/tla-plus.git","svn_url":"https://github.com/foreverbell/tla-plus","homepage":null,"size":86,"stargazers_count":2,"watchers_count":2,"language":"TLA","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"b66286b0ddab8619a6fe994580cc2f73c980b105","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":114755704,"name":"tla-plus","full_name":"pingcap/tla-plus","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tla-plus","description":null,"fork":false,"url":"https://api.github.com/repos/pingcap/tla-plus","forks_url":"https://api.github.com/repos/pingcap/tla-plus/forks","keys_url":"https://api.github.com/repos/pingcap/tla-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tla-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tla-plus/teams","hooks_url":"https://api.github.com/repos/pingcap/tla-plus/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tla-plus/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tla-plus/events","assignees_url":"https://api.github.com/repos/pingcap/tla-plus/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tla-plus/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tla-plus/tags","blobs_url":"https://api.github.com/repos/pingcap/tla-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tla-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tla-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tla-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tla-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tla-plus/languages","stargazers_url":"https://api.github.com/repos/pingcap/tla-plus/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tla-plus/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tla-plus/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tla-plus/subscription","commits_url":"https://api.github.com/repos/pingcap/tla-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tla-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tla-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tla-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tla-plus/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tla-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tla-plus/merges","archive_url":"https://api.github.com/repos/pingcap/tla-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tla-plus/downloads","issues_url":"https://api.github.com/repos/pingcap/tla-plus/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tla-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tla-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tla-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tla-plus/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tla-plus/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tla-plus/deployments","created_at":"2017-12-19T11:12:24Z","updated_at":"2018-03-21T07:10:19Z","pushed_at":"2018-03-21T07:47:10Z","git_url":"git://github.com/pingcap/tla-plus.git","ssh_url":"git@github.com:pingcap/tla-plus.git","clone_url":"https://github.com/pingcap/tla-plus.git","svn_url":"https://github.com/pingcap/tla-plus","homepage":null,"size":33,"stargazers_count":7,"watchers_count":7,"language":"TLA","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tla-plus/pulls/11"},"html":{"href":"https://github.com/pingcap/tla-plus/pull/11"},"issue":{"href":"https://api.github.com/repos/pingcap/tla-plus/issues/11"},"comments":{"href":"https://api.github.com/repos/pingcap/tla-plus/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tla-plus/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tla-plus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tla-plus/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tla-plus/statuses/b08ff513d69992b32d7b0c7b3b80bb54cb59e73d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"foreverbell"}}