{"action":"closed","number":22247,"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22247","id":215205090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjA1MDkw","html_url":"https://github.com/tensorflow/tensorflow/pull/22247","diff_url":"https://github.com/tensorflow/tensorflow/pull/22247.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/22247.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22247","number":22247,"state":"closed","locked":false,"title":"Use the last char instead of the first in prediction","user":{"login":"leondgarse","id":5744524,"node_id":"MDQ6VXNlcjU3NDQ1MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5744524?v=4","gravatar_id":"","url":"https://api.github.com/users/leondgarse","html_url":"https://github.com/leondgarse","followers_url":"https://api.github.com/users/leondgarse/followers","following_url":"https://api.github.com/users/leondgarse/following{/other_user}","gists_url":"https://api.github.com/users/leondgarse/gists{/gist_id}","starred_url":"https://api.github.com/users/leondgarse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leondgarse/subscriptions","organizations_url":"https://api.github.com/users/leondgarse/orgs","repos_url":"https://api.github.com/users/leondgarse/repos","events_url":"https://api.github.com/users/leondgarse/events{/privacy}","received_events_url":"https://api.github.com/users/leondgarse/received_events","type":"User","site_admin":false},"body":"1. As it's mentioned the `start_string` could be a string here, in my understanding, the correctly predicted next character should be the last one in `predictions`.\r\n2. As `tf.multinomial` is not used any more here, `temperature` has no effect either.\r\n\r\n- i.e.\r\n  - With `start_string = 'QUEEN'`, the model prediction string is `UEEN:`, so the next char should be `:`\r\n  - In the loop run `for i in range(num_generate):`\r\n    - With `predicted_id = tf.argmax(predictions[0]).numpy()`, output is `QUEENUS:\\nI think so ...`\r\n    - With `predicted_id = tf.argmax(predictions[-1]).numpy()`, output is `QUEEN:\\nThe grand the ...`\r\n","created_at":"2018-09-13T08:38:27Z","updated_at":"2018-10-16T17:11:24Z","closed_at":"2018-10-16T17:11:24Z","merged_at":"2018-10-16T17:11:24Z","merge_commit_sha":"a1cd5c271670afe441116c95679bbaf10fe4110e","assignee":{"login":"yifeif","id":1192265,"node_id":"MDQ6VXNlcjExOTIyNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1192265?v=4","gravatar_id":"","url":"https://api.github.com/users/yifeif","html_url":"https://github.com/yifeif","followers_url":"https://api.github.com/users/yifeif/followers","following_url":"https://api.github.com/users/yifeif/following{/other_user}","gists_url":"https://api.github.com/users/yifeif/gists{/gist_id}","starred_url":"https://api.github.com/users/yifeif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifeif/subscriptions","organizations_url":"https://api.github.com/users/yifeif/orgs","repos_url":"https://api.github.com/users/yifeif/repos","events_url":"https://api.github.com/users/yifeif/events{/privacy}","received_events_url":"https://api.github.com/users/yifeif/received_events","type":"User","site_admin":false},"assignees":[{"login":"yifeif","id":1192265,"node_id":"MDQ6VXNlcjExOTIyNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1192265?v=4","gravatar_id":"","url":"https://api.github.com/users/yifeif","html_url":"https://github.com/yifeif","followers_url":"https://api.github.com/users/yifeif/followers","following_url":"https://api.github.com/users/yifeif/following{/other_user}","gists_url":"https://api.github.com/users/yifeif/gists{/gist_id}","starred_url":"https://api.github.com/users/yifeif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifeif/subscriptions","organizations_url":"https://api.github.com/users/yifeif/orgs","repos_url":"https://api.github.com/users/yifeif/repos","events_url":"https://api.github.com/users/yifeif/events{/privacy}","received_events_url":"https://api.github.com/users/yifeif/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":419840263,"node_id":"MDU6TGFiZWw0MTk4NDAyNjM=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20testing%20(then%20merge)","name":"awaiting testing (then merge)","color":"c2e0c6","default":false},{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":987666414,"node_id":"MDU6TGFiZWw5ODc2NjY0MTQ=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull","name":"ready to pull","color":"2cd643","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22247/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22247/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22247/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/a1cd5c271670afe441116c95679bbaf10fe4110e","head":{"label":"leondgarse:master","ref":"master","sha":"a1cd5c271670afe441116c95679bbaf10fe4110e","user":{"login":"leondgarse","id":5744524,"node_id":"MDQ6VXNlcjU3NDQ1MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5744524?v=4","gravatar_id":"","url":"https://api.github.com/users/leondgarse","html_url":"https://github.com/leondgarse","followers_url":"https://api.github.com/users/leondgarse/followers","following_url":"https://api.github.com/users/leondgarse/following{/other_user}","gists_url":"https://api.github.com/users/leondgarse/gists{/gist_id}","starred_url":"https://api.github.com/users/leondgarse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leondgarse/subscriptions","organizations_url":"https://api.github.com/users/leondgarse/orgs","repos_url":"https://api.github.com/users/leondgarse/repos","events_url":"https://api.github.com/users/leondgarse/events{/privacy}","received_events_url":"https://api.github.com/users/leondgarse/received_events","type":"User","site_admin":false},"repo":{"id":146413948,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0MTM5NDg=","name":"tensorflow","full_name":"leondgarse/tensorflow","private":false,"owner":{"login":"leondgarse","id":5744524,"node_id":"MDQ6VXNlcjU3NDQ1MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5744524?v=4","gravatar_id":"","url":"https://api.github.com/users/leondgarse","html_url":"https://github.com/leondgarse","followers_url":"https://api.github.com/users/leondgarse/followers","following_url":"https://api.github.com/users/leondgarse/following{/other_user}","gists_url":"https://api.github.com/users/leondgarse/gists{/gist_id}","starred_url":"https://api.github.com/users/leondgarse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leondgarse/subscriptions","organizations_url":"https://api.github.com/users/leondgarse/orgs","repos_url":"https://api.github.com/users/leondgarse/repos","events_url":"https://api.github.com/users/leondgarse/events{/privacy}","received_events_url":"https://api.github.com/users/leondgarse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/leondgarse/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/leondgarse/tensorflow","forks_url":"https://api.github.com/repos/leondgarse/tensorflow/forks","keys_url":"https://api.github.com/repos/leondgarse/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leondgarse/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leondgarse/tensorflow/teams","hooks_url":"https://api.github.com/repos/leondgarse/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/leondgarse/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/leondgarse/tensorflow/events","assignees_url":"https://api.github.com/repos/leondgarse/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/leondgarse/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/leondgarse/tensorflow/tags","blobs_url":"https://api.github.com/repos/leondgarse/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leondgarse/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leondgarse/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/leondgarse/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leondgarse/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/leondgarse/tensorflow/languages","stargazers_url":"https://api.github.com/repos/leondgarse/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/leondgarse/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/leondgarse/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/leondgarse/tensorflow/subscription","commits_url":"https://api.github.com/repos/leondgarse/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/leondgarse/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/leondgarse/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/leondgarse/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/leondgarse/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/leondgarse/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leondgarse/tensorflow/merges","archive_url":"https://api.github.com/repos/leondgarse/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leondgarse/tensorflow/downloads","issues_url":"https://api.github.com/repos/leondgarse/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/leondgarse/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/leondgarse/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/leondgarse/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leondgarse/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/leondgarse/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/leondgarse/tensorflow/deployments","created_at":"2018-08-28T08:10:00Z","updated_at":"2018-09-25T01:46:53Z","pushed_at":"2018-09-25T01:45:31Z","git_url":"git://github.com/leondgarse/tensorflow.git","ssh_url":"git@github.com:leondgarse/tensorflow.git","clone_url":"https://github.com/leondgarse/tensorflow.git","svn_url":"https://github.com/leondgarse/tensorflow","homepage":"https://tensorflow.org","size":257504,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"d5c5f8ecc124ee9a866318f2bd7082df9e38ebf2","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/tensorflow","description":"An Open Source Machine Learning Framework for Everyone","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-10-16T17:09:55Z","pushed_at":"2018-10-16T17:11:11Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":267508,"stargazers_count":112133,"watchers_count":112133,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68588,"mirror_url":null,"archived":false,"open_issues_count":1732,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":68588,"open_issues":1732,"watchers":112133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22247"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/22247"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/22247"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/22247/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22247/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22247/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/a1cd5c271670afe441116c95679bbaf10fe4110e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tensorflow-copybara","id":33434372,"node_id":"MDQ6VXNlcjMzNDM0Mzcy","avatar_url":"https://avatars1.githubusercontent.com/u/33434372?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow-copybara","html_url":"https://github.com/tensorflow-copybara","followers_url":"https://api.github.com/users/tensorflow-copybara/followers","following_url":"https://api.github.com/users/tensorflow-copybara/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow-copybara/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow-copybara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow-copybara/subscriptions","organizations_url":"https://api.github.com/users/tensorflow-copybara/orgs","repos_url":"https://api.github.com/users/tensorflow-copybara/repos","events_url":"https://api.github.com/users/tensorflow-copybara/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow-copybara/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":3,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"tensorflow-copybara"}}