{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/171233733","pull_request_review_id":100049056,"id":171233733,"diff_hunk":"@@ -41,9 +42,9 @@ class Pool\n     protected $adminClasses = [];\n \n     /**\n-     * @var string[]\n+     * @var MutableTemplateRegistryInterface\n      */\n-    protected $templates = [];\n+    protected $templateRegistry;","path":"src/Admin/Pool.php","position":16,"original_position":16,"commit_id":"9cf611ac081deb8acf6c578610c7f3c8604c208c","original_commit_id":"9cf611ac081deb8acf6c578610c7f3c8604c208c","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"Should be private","created_at":"2018-02-28T12:49:50Z","updated_at":"2018-02-28T12:49:50Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4980#discussion_r171233733","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/171233733"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/4980#discussion_r171233733"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980","id":171761576,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4980","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4980.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4980.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4980","number":4980,"state":"open","locked":false,"title":"Move templates from AbstractAdmin and Pool to TemplateRegistry","user":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"body":"I am targeting this branch, because these changes are backwards compatible.\r\n\r\nRelated to #3947\r\n\r\n## Changelog\r\n\r\n```markdown\r\n### Added\r\n- Added `TemplateRegistry` to handle all template registration related functionality from both `AbstractAdmin` and `Pool`.\r\n\r\n### Deprecated\r\n- Deprecated `AbstractAdmin` methods `getTemplate`, `setTemplate`, `getTemplates` and `setTemplates`.\r\n- Deprecated `Pool` methods `getTemplate`, `setTemplates` and `getTemplates`.\r\n\r\n```\r\n\r\n## To do\r\n\r\n- [X] Update the tests\r\n- [x] Update the documentation\r\n- [X] Add an upgrade note\r\n\r\n## Subject\r\n\r\nThis PR is part of a series of PRs to eventually move all admin template related functionality to a separate component.\r\n\r\nThis PR itself moves all template registration functionality from `AbstractAdmin` and `Pool` and moves it into the class `TemplateRegistry` and separate services (one per admin and a general one).\r\n\r\n## Next steps\r\n\r\n- After this PR, a PR to the master should be made to use a separate Service Locator instead of the general container to find the correct admin template registries. This needs to have the dependency on Symfony DependencyInjection to be set to 3.3 or higher (currently `^2.8 || ^3.2 || ^4.0`), which is not BC.\r\n- After that, a way to set admin templates through the configuration should be added (to replace the `setTemplate` and `setTemplates` method calls defined within the Admin service definition.","created_at":"2018-02-27T19:30:32Z","updated_at":"2018-02-28T12:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e649978f9543bd8273a28cb8c64cb513ec8bc830","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4980/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/9cf611ac081deb8acf6c578610c7f3c8604c208c","head":{"label":"TimoBakx:template-registry","ref":"template-registry","sha":"9cf611ac081deb8acf6c578610c7f3c8604c208c","user":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"repo":{"id":121227685,"name":"SonataAdminBundle","full_name":"TimoBakx/SonataAdminBundle","owner":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimoBakx/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle","forks_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/deployments","created_at":"2018-02-12T09:41:23Z","updated_at":"2018-02-12T09:41:26Z","pushed_at":"2018-02-28T12:42:11Z","git_url":"git://github.com/TimoBakx/SonataAdminBundle.git","ssh_url":"git@github.com:TimoBakx/SonataAdminBundle.git","clone_url":"https://github.com/TimoBakx/SonataAdminBundle.git","svn_url":"https://github.com/TimoBakx/SonataAdminBundle","homepage":"https://sonata-project.org/","size":21065,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"405c5b2e0fb49d070b73783631352bf57f5ae5fa","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2018-02-27T03:12:35Z","pushed_at":"2018-02-28T12:42:15Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"https://sonata-project.org/","size":21056,"stargazers_count":1619,"watchers_count":1619,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1138,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1138,"open_issues":321,"watchers":1619,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/4980"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4980"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4980/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4980/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/9cf611ac081deb8acf6c578610c7f3c8604c208c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"greg0ire"}}