{"action":"created","issue":{"url":"https://api.github.com/repos/swaywm/sway/issues/1817","repository_url":"https://api.github.com/repos/swaywm/sway","labels_url":"https://api.github.com/repos/swaywm/sway/issues/1817/labels{/name}","comments_url":"https://api.github.com/repos/swaywm/sway/issues/1817/comments","events_url":"https://api.github.com/repos/swaywm/sway/issues/1817/events","html_url":"https://github.com/swaywm/sway/pull/1817","id":314594768,"number":1817,"title":"Implement fullscreen","user":{"login":"RyanDwyer","id":2436833,"avatar_url":"https://avatars3.githubusercontent.com/u/2436833?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanDwyer","html_url":"https://github.com/RyanDwyer","followers_url":"https://api.github.com/users/RyanDwyer/followers","following_url":"https://api.github.com/users/RyanDwyer/following{/other_user}","gists_url":"https://api.github.com/users/RyanDwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanDwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanDwyer/subscriptions","organizations_url":"https://api.github.com/users/RyanDwyer/orgs","repos_url":"https://api.github.com/users/RyanDwyer/repos","events_url":"https://api.github.com/users/RyanDwyer/events{/privacy}","received_events_url":"https://api.github.com/users/RyanDwyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-04-16T10:41:57Z","updated_at":"2018-04-19T14:03:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/swaywm/sway/pulls/1817","html_url":"https://github.com/swaywm/sway/pull/1817","diff_url":"https://github.com/swaywm/sway/pull/1817.diff","patch_url":"https://github.com/swaywm/sway/pull/1817.patch"},"body":"This implements `fullscreen enable`, `fullscreen disable`, `fullscreen toggle`, and allows views to request fullscreen.\r\n\r\nThis is my first significant PR for sway and I've had to learn a lot about how everything works, so please scrutinise this carefully.\r\n\r\nNote that sway 0.15 allows the command `fullscreen` without any arguments which acts as toggle, but this is different to the i3 user guide so I've implemented it as described above. As a result, if you're porting config from sway 0.15 you may need to update your command to be `fullscreen toggle`.\r\n\r\nwl_shell seems a bit lacking with its fullscreen ability, and from what I understand wl_shell is deprecated anyway, so I've not implemented fullscreen for that. If someone could confirm then that'd be appreciated.\r\n\r\nThere is one known issue, and that is that popups don't show when the parent view is fullscreen, but I'd like to either resolve that in a separate PR or leave it for someone else to look into.\r\n\r\nTests:\r\n\r\n* Run fullscreen enable, fullscreen disable, fullscreen toggle on an xdg_v6 view\r\n* Run fullscreen enable, fullscreen disable, fullscreen toggle on an xwayland view\r\n* Attempt to fullscreen a container - should be ignored \r\n* Fullscreen a view, then kill it\r\n* Open two views on one workspace, fullscreen one, then attempt to focus the other - focus should remain on fullscreen view\r\n* Open two views on different workspaces, fullscreen one, then attempt to focus the other and back again - workspaces should focus correctly\r\n* Fullscreen view, then move view to another workspace - view should be unfullscreened\r\n* Make an xwayland view request fullscreen, eg. launch firefox and press F11\r\n* Make an xdg_v6 view request fullscreen, eg. launch `mpv --opengl-backend=wayland` and press f"},"comment":{"url":"https://api.github.com/repos/swaywm/sway/issues/comments/382748192","html_url":"https://github.com/swaywm/sway/pull/1817#issuecomment-382748192","issue_url":"https://api.github.com/repos/swaywm/sway/issues/1817","id":382748192,"user":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars0.githubusercontent.com/u/1310872?v=4","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T14:03:18Z","updated_at":"2018-04-19T14:03:18Z","author_association":"OWNER","body":">Also, moving fullscreen window to another output still un-fullscreens it.\r\n\r\nWe can take this to a separate patch\r\n\r\n@emersion merge it if you like it"}}
{"actor":{"display_login":"SirCmpwn"}}