{"action":"created","issue":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2438","repository_url":"https://api.github.com/repos/easybuilders/easybuild-framework","labels_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2438/labels{/name}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2438/comments","events_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2438/events","html_url":"https://github.com/easybuilders/easybuild-framework/pull/2438","id":305095013,"number":2438,"title":"loosen commit message requirements w.r.t. to patches as long as all easyconfigs are new","user":{"login":"migueldiascosta","id":7159063,"avatar_url":"https://avatars3.githubusercontent.com/u/7159063?v=4","gravatar_id":"","url":"https://api.github.com/users/migueldiascosta","html_url":"https://github.com/migueldiascosta","followers_url":"https://api.github.com/users/migueldiascosta/followers","following_url":"https://api.github.com/users/migueldiascosta/following{/other_user}","gists_url":"https://api.github.com/users/migueldiascosta/gists{/gist_id}","starred_url":"https://api.github.com/users/migueldiascosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migueldiascosta/subscriptions","organizations_url":"https://api.github.com/users/migueldiascosta/orgs","repos_url":"https://api.github.com/users/migueldiascosta/repos","events_url":"https://api.github.com/users/migueldiascosta/events{/privacy}","received_events_url":"https://api.github.com/users/migueldiascosta/received_events","type":"User","site_admin":false},"labels":[{"id":989297,"url":"https://api.github.com/repos/easybuilders/easybuild-framework/labels/enhancement","name":"enhancement","color":"ffaa00","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones/54","html_url":"https://github.com/easybuilders/easybuild-framework/milestone/54","labels_url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones/54/labels","id":3137238,"number":54,"title":"3.6.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":7,"state":"open","created_at":"2018-02-22T19:46:25Z","updated_at":"2018-03-14T20:55:37Z","due_on":"2018-04-18T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-03-14T10:10:47Z","updated_at":"2018-03-14T21:29:31Z","closed_at":"2018-03-14T20:55:37Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2438","html_url":"https://github.com/easybuilders/easybuild-framework/pull/2438","diff_url":"https://github.com/easybuilders/easybuild-framework/pull/2438.diff","patch_url":"https://github.com/easybuilders/easybuild-framework/pull/2438.patch"},"body":"It seems to me that as long as all easyconfigs are new, the commit message could still be automatically generated\r\n\r\nIf a new patch being added applies to an existing easyconfig, that easyconfig would need to be modified so a meaningful commit message is still needed, this change only affects the cases where all easyconfig files are new\r\n\r\ndo close if I'm missing something"},"comment":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/comments/373181203","html_url":"https://github.com/easybuilders/easybuild-framework/pull/2438#issuecomment-373181203","issue_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2438","id":373181203,"user":{"login":"boegel","id":620876,"avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T21:29:31Z","updated_at":"2018-03-14T21:29:31Z","author_association":"OWNER","body":"Ugh, seems like I wasn't careful enough, I didn't check the GitHub-related tests in `test/options.py`...\r\n\r\n@migueldiascosta Can you look into fixing this broken test?\r\n\r\n```\r\nFAIL: Test use of --new-pr (dry run only).\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/tmp/353536935/lib/python2.6/site-packages/easybuild_framework-3.6.0.dev0-py2.6.egg/test/framework/options.py\", line 2508, in test_new_update_pr\r\n    self.assertErrorRegex(EasyBuildError, error_msg, self.eb_main, args, raise_error=True, testing=False)\r\n  File \"/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/vsc_install-0.10.32-py2.6.egg/vsc/install/testing.py\", line 122, in assertErrorRegex\r\n    self.assertTrue(False, \"Expected errors with %s(%s) call should occur\" % (call.__name__, str_args))\r\nAssertionError: Expected errors with eb_main(['--new-pr', '--github-user=easybuild_test', '/tmp/eb-OQQvWe/eb-qGd7yf/eb-QxtCZq/toy.eb', '-D', '--disable-cleanup-tmpdir', '--git-working-dirs-path=/tmp/eb-OQQvWe/eb-qGd7yf/eb-QxtCZq/eb-k2lenT/eb-uNqV__/git-working-dir8H5nMe', '/tmp/353536935/lib/python2.6/site-packages/easybuild_framework-3.6.0.dev0-py2.6.egg/test/framework/sandbox/sources/toy/toy-0.0_fix-silly-typo-in-printf-statement.patch'], raise_error=True, testing=False) call should occur\r\n```"}}
{"actor":{"display_login":"boegel"}}