{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/comments/243229586","pull_request_review_id":186941589,"id":243229586,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzIyOTU4Ng==","diff_hunk":"@@ -267,3 +268,67 @@ def test_check_smb_port_error(self, command, logger):\n         self.hyperv._check_smb_port()\n         command.assert_called_once()\n         logger.error.assert_called_once()\n+\n+    def test_restore_vm_ok(self):\n+        with patch.object(self.hyperv, '_check_memory') as check_memory, \\","path":"tests/golem/docker/test_hyperv.py","position":20,"original_position":20,"commit_id":"adfbc85bdc1526a7787775473250e07ccaf6bb58","original_commit_id":"adfbc85bdc1526a7787775473250e07ccaf6bb58","user":{"login":"maaktweluit","id":10008353,"node_id":"MDQ6VXNlcjEwMDA4MzUz","avatar_url":"https://avatars0.githubusercontent.com/u/10008353?v=4","gravatar_id":"","url":"https://api.github.com/users/maaktweluit","html_url":"https://github.com/maaktweluit","followers_url":"https://api.github.com/users/maaktweluit/followers","following_url":"https://api.github.com/users/maaktweluit/following{/other_user}","gists_url":"https://api.github.com/users/maaktweluit/gists{/gist_id}","starred_url":"https://api.github.com/users/maaktweluit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaktweluit/subscriptions","organizations_url":"https://api.github.com/users/maaktweluit/orgs","repos_url":"https://api.github.com/users/maaktweluit/repos","events_url":"https://api.github.com/users/maaktweluit/events{/privacy}","received_events_url":"https://api.github.com/users/maaktweluit/received_events","type":"User","site_admin":false},"body":"good one, did not see that..\r\n\r\ncan only think of patching `HyperVHypervisor._check_memory`, but i am not sure if that works","created_at":"2018-12-20T10:51:48Z","updated_at":"2018-12-20T10:58:06Z","html_url":"https://github.com/golemfactory/golem/pull/3690#discussion_r243229586","pull_request_url":"https://api.github.com/repos/golemfactory/golem/pulls/3690","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments/243229586"},"html":{"href":"https://github.com/golemfactory/golem/pull/3690#discussion_r243229586"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3690"}},"in_reply_to_id":243219155},"pull_request":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/3690","id":240110300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMTEwMzAw","html_url":"https://github.com/golemfactory/golem/pull/3690","diff_url":"https://github.com/golemfactory/golem/pull/3690.diff","patch_url":"https://github.com/golemfactory/golem/pull/3690.patch","issue_url":"https://api.github.com/repos/golemfactory/golem/issues/3690","number":3690,"state":"open","locked":false,"title":"Fixed HyperVHypervisor.restore_vm()","user":{"login":"Wiezzel","id":9394821,"node_id":"MDQ6VXNlcjkzOTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9394821?v=4","gravatar_id":"","url":"https://api.github.com/users/Wiezzel","html_url":"https://github.com/Wiezzel","followers_url":"https://api.github.com/users/Wiezzel/followers","following_url":"https://api.github.com/users/Wiezzel/following{/other_user}","gists_url":"https://api.github.com/users/Wiezzel/gists{/gist_id}","starred_url":"https://api.github.com/users/Wiezzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wiezzel/subscriptions","organizations_url":"https://api.github.com/users/Wiezzel/orgs","repos_url":"https://api.github.com/users/Wiezzel/repos","events_url":"https://api.github.com/users/Wiezzel/events{/privacy}","received_events_url":"https://api.github.com/users/Wiezzel/received_events","type":"User","site_admin":false},"body":"Restoring VM would fail in case of insufficient RAM available. A memory check was added to shut down the VM in such situation (i.e. remove the saved state) and boot it normally.","created_at":"2018-12-20T09:53:58Z","updated_at":"2018-12-20T10:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3384ddc7aec6d3e479660e6fe197b5cac4eeb182","assignee":{"login":"Wiezzel","id":9394821,"node_id":"MDQ6VXNlcjkzOTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9394821?v=4","gravatar_id":"","url":"https://api.github.com/users/Wiezzel","html_url":"https://github.com/Wiezzel","followers_url":"https://api.github.com/users/Wiezzel/followers","following_url":"https://api.github.com/users/Wiezzel/following{/other_user}","gists_url":"https://api.github.com/users/Wiezzel/gists{/gist_id}","starred_url":"https://api.github.com/users/Wiezzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wiezzel/subscriptions","organizations_url":"https://api.github.com/users/Wiezzel/orgs","repos_url":"https://api.github.com/users/Wiezzel/repos","events_url":"https://api.github.com/users/Wiezzel/events{/privacy}","received_events_url":"https://api.github.com/users/Wiezzel/received_events","type":"User","site_admin":false},"assignees":[{"login":"Wiezzel","id":9394821,"node_id":"MDQ6VXNlcjkzOTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9394821?v=4","gravatar_id":"","url":"https://api.github.com/users/Wiezzel","html_url":"https://github.com/Wiezzel","followers_url":"https://api.github.com/users/Wiezzel/followers","following_url":"https://api.github.com/users/Wiezzel/following{/other_user}","gists_url":"https://api.github.com/users/Wiezzel/gists{/gist_id}","starred_url":"https://api.github.com/users/Wiezzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wiezzel/subscriptions","organizations_url":"https://api.github.com/users/Wiezzel/orgs","repos_url":"https://api.github.com/users/Wiezzel/repos","events_url":"https://api.github.com/users/Wiezzel/events{/privacy}","received_events_url":"https://api.github.com/users/Wiezzel/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mfranciszkiewicz","id":3238836,"node_id":"MDQ6VXNlcjMyMzg4MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3238836?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranciszkiewicz","html_url":"https://github.com/mfranciszkiewicz","followers_url":"https://api.github.com/users/mfranciszkiewicz/followers","following_url":"https://api.github.com/users/mfranciszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/mfranciszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranciszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranciszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/mfranciszkiewicz/orgs","repos_url":"https://api.github.com/users/mfranciszkiewicz/repos","events_url":"https://api.github.com/users/mfranciszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/mfranciszkiewicz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":288489133,"node_id":"MDU6TGFiZWwyODg0ODkxMzM=","url":"https://api.github.com/repos/golemfactory/golem/labels/bug","name":"bug","color":"fc2929","default":true},{"id":983912883,"node_id":"MDU6TGFiZWw5ODM5MTI4ODM=","url":"https://api.github.com/repos/golemfactory/golem/labels/clay","name":"clay","color":"e99695","default":false},{"id":842729910,"node_id":"MDU6TGFiZWw4NDI3Mjk5MTA=","url":"https://api.github.com/repos/golemfactory/golem/labels/docker","name":"docker","color":"2808b2","default":false},{"id":288910350,"node_id":"MDU6TGFiZWwyODg5MTAzNTA=","url":"https://api.github.com/repos/golemfactory/golem/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":288910793,"node_id":"MDU6TGFiZWwyODg5MTA3OTM=","url":"https://api.github.com/repos/golemfactory/golem/labels/needs%20review","name":"needs review","color":"d4c5f9","default":false},{"id":575410081,"node_id":"MDU6TGFiZWw1NzU0MTAwODE=","url":"https://api.github.com/repos/golemfactory/golem/labels/windows","name":"windows","color":"316c92","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/golem/pulls/3690/commits","review_comments_url":"https://api.github.com/repos/golemfactory/golem/pulls/3690/comments","review_comment_url":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/golem/issues/3690/comments","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/adfbc85bdc1526a7787775473250e07ccaf6bb58","head":{"label":"golemfactory:hyperv-restore-vm-fix","ref":"hyperv-restore-vm-fix","sha":"adfbc85bdc1526a7787775473250e07ccaf6bb58","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQzMzkzNw==","name":"golem","full_name":"golemfactory/golem","private":false,"owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/golemfactory/golem","description":"Golem is creating a global market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2018-12-20T09:45:39Z","pushed_at":"2018-12-20T10:26:51Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":144641,"stargazers_count":2691,"watchers_count":2691,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":288,"open_issues":383,"watchers":2691,"default_branch":"develop"}},"base":{"label":"golemfactory:develop","ref":"develop","sha":"cbb60e5a26223004a8d7681a08ce267d201293c9","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQzMzkzNw==","name":"golem","full_name":"golemfactory/golem","private":false,"owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/golemfactory/golem","description":"Golem is creating a global market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2018-12-20T09:45:39Z","pushed_at":"2018-12-20T10:26:51Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":144641,"stargazers_count":2691,"watchers_count":2691,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":288,"open_issues":383,"watchers":2691,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3690"},"html":{"href":"https://github.com/golemfactory/golem/pull/3690"},"issue":{"href":"https://api.github.com/repos/golemfactory/golem/issues/3690"},"comments":{"href":"https://api.github.com/repos/golemfactory/golem/issues/3690/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3690/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3690/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/golem/statuses/adfbc85bdc1526a7787775473250e07ccaf6bb58"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maaktweluit"}}