{"action":"closed","number":9273,"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9273","id":199697888,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Njk3ODg4","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9273","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/9273.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/9273.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9273","number":9273,"state":"closed","locked":false,"title":"Localization downloads does not work without allow_url_fopen","user":{"login":"petero-dk","id":2478689,"node_id":"MDQ6VXNlcjI0Nzg2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/2478689?v=4","gravatar_id":"","url":"https://api.github.com/users/petero-dk","html_url":"https://github.com/petero-dk","followers_url":"https://api.github.com/users/petero-dk/followers","following_url":"https://api.github.com/users/petero-dk/following{/other_user}","gists_url":"https://api.github.com/users/petero-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/petero-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petero-dk/subscriptions","organizations_url":"https://api.github.com/users/petero-dk/orgs","repos_url":"https://api.github.com/users/petero-dk/repos","events_url":"https://api.github.com/users/petero-dk/events{/privacy}","received_events_url":"https://api.github.com/users/petero-dk/received_events","type":"User","site_admin":false},"body":"\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       |  1.7.4.x\r\n| Description?  | The localization package download only worked with fopen and not curl. This commit includes a curl implementation for the package download, and in alignment with #7114 curl is the default and fopen is the fallback.\r\n| Type?         | bug fix \r\n| Category?     | BO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed ticket? | \r\n| How to test?  | Disable allow_url_fopen and notice that downloads of packages still works. Without this commit the download of packages will fail with a 500 or with debug enabled an error message.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/9273)\n<!-- Reviewable:end -->\n","created_at":"2018-07-06T09:48:31Z","updated_at":"2018-07-18T15:51:03Z","closed_at":"2018-07-18T15:51:03Z","merged_at":null,"merge_commit_sha":"aa24380bf2f5a969d60557cbe032eaee02ad5a9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":925512081,"node_id":"MDU6TGFiZWw5MjU1MTIwODE=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/1.7.4.x","name":"1.7.4.x","color":"6270ea","default":false},{"id":19737369,"node_id":"MDU6TGFiZWwxOTczNzM2OQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Bug","name":"Bug","color":"d4c5f9","default":false},{"id":353493136,"node_id":"MDU6TGFiZWwzNTM0OTMxMzY=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Needs%20refactoring","name":"Needs refactoring","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9273/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9273/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9273/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/29a50c51547149ceb5abd097fd01674960bc73d9","head":{"label":"ecomerc:bugfix/fopeninlocalization174x","ref":"bugfix/fopeninlocalization174x","sha":"29a50c51547149ceb5abd097fd01674960bc73d9","user":{"login":"ecomerc","id":3417073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3417073?v=4","gravatar_id":"","url":"https://api.github.com/users/ecomerc","html_url":"https://github.com/ecomerc","followers_url":"https://api.github.com/users/ecomerc/followers","following_url":"https://api.github.com/users/ecomerc/following{/other_user}","gists_url":"https://api.github.com/users/ecomerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ecomerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecomerc/subscriptions","organizations_url":"https://api.github.com/users/ecomerc/orgs","repos_url":"https://api.github.com/users/ecomerc/repos","events_url":"https://api.github.com/users/ecomerc/events{/privacy}","received_events_url":"https://api.github.com/users/ecomerc/received_events","type":"Organization","site_admin":false},"repo":{"id":139959779,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5NTk3Nzk=","name":"PrestaShop","full_name":"ecomerc/PrestaShop","owner":{"login":"ecomerc","id":3417073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3417073?v=4","gravatar_id":"","url":"https://api.github.com/users/ecomerc","html_url":"https://github.com/ecomerc","followers_url":"https://api.github.com/users/ecomerc/followers","following_url":"https://api.github.com/users/ecomerc/following{/other_user}","gists_url":"https://api.github.com/users/ecomerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ecomerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecomerc/subscriptions","organizations_url":"https://api.github.com/users/ecomerc/orgs","repos_url":"https://api.github.com/users/ecomerc/repos","events_url":"https://api.github.com/users/ecomerc/events{/privacy}","received_events_url":"https://api.github.com/users/ecomerc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ecomerc/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":true,"url":"https://api.github.com/repos/ecomerc/PrestaShop","forks_url":"https://api.github.com/repos/ecomerc/PrestaShop/forks","keys_url":"https://api.github.com/repos/ecomerc/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecomerc/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecomerc/PrestaShop/teams","hooks_url":"https://api.github.com/repos/ecomerc/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/ecomerc/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/ecomerc/PrestaShop/events","assignees_url":"https://api.github.com/repos/ecomerc/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/ecomerc/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/ecomerc/PrestaShop/tags","blobs_url":"https://api.github.com/repos/ecomerc/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecomerc/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecomerc/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecomerc/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecomerc/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/ecomerc/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/ecomerc/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/ecomerc/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/ecomerc/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/ecomerc/PrestaShop/subscription","commits_url":"https://api.github.com/repos/ecomerc/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecomerc/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecomerc/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecomerc/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecomerc/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/ecomerc/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecomerc/PrestaShop/merges","archive_url":"https://api.github.com/repos/ecomerc/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecomerc/PrestaShop/downloads","issues_url":"https://api.github.com/repos/ecomerc/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/ecomerc/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/ecomerc/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/ecomerc/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecomerc/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/ecomerc/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/ecomerc/PrestaShop/deployments","created_at":"2018-07-06T08:57:20Z","updated_at":"2018-07-06T08:57:39Z","pushed_at":"2018-07-06T13:22:37Z","git_url":"git://github.com/ecomerc/PrestaShop.git","ssh_url":"git@github.com:ecomerc/PrestaShop.git","clone_url":"https://github.com/ecomerc/PrestaShop.git","svn_url":"https://github.com/ecomerc/PrestaShop","homepage":"http://www.prestashop.com/","size":327939,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:1.7.4.x","ref":"1.7.4.x","sha":"aa63364848e25335f7bf4c0ebd1dccc21164a9f3","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-07-18T15:07:23Z","pushed_at":"2018-07-18T15:38:39Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":351968,"stargazers_count":3101,"watchers_count":3101,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2823,"mirror_url":null,"archived":false,"open_issues_count":376,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2823,"open_issues":376,"watchers":3101,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9273"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9273"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9273"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9273/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9273/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9273/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/29a50c51547149ceb5abd097fd01674960bc73d9"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":34,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"Quetzacoalt91"}}