{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/176807052","pull_request_review_id":106581527,"id":176807052,"diff_hunk":"@@ -36,17 +36,24 @@ function formatNode(location, types) {\n function onEnter(node, ancestors, state) {\n   const parent = ancestors[ancestors.length - 1];\n \n-  if (\n-    isAssignment(node) ||\n-    isImport(node) ||\n-    isControlFlow(node) ||\n-    isReturn(node)\n-  ) {\n+  if (isAssignment(node) || isImport(node) || isControlFlow(node)) {\n     state.push(\n       formatNode(node.loc.start, { breakpoint: true, stepOver: true })\n     );\n   }\n \n+  if (isReturn(node)) {\n+    if (t.isCallExpression(node.argument)) {\n+      state.push(\n+        formatNode(node.loc.start, { breakpoint: false, stepOver: false })\n+      );\n+    } else {\n+      state.push(\n+        formatNode(node.loc.start, { breakpoint: true, stepOver: true })\n+      );\n+    }\n+  }","path":"src/workers/parser/pausePoints.js","position":26,"original_position":26,"commit_id":"f3bea6d2c7f07a751515f55846c70dd228e06d38","original_commit_id":"f3bea6d2c7f07a751515f55846c70dd228e06d38","user":{"login":"darkwing","id":46655,"avatar_url":"https://avatars0.githubusercontent.com/u/46655?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwing","html_url":"https://github.com/darkwing","followers_url":"https://api.github.com/users/darkwing/followers","following_url":"https://api.github.com/users/darkwing/following{/other_user}","gists_url":"https://api.github.com/users/darkwing/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwing/subscriptions","organizations_url":"https://api.github.com/users/darkwing/orgs","repos_url":"https://api.github.com/users/darkwing/repos","events_url":"https://api.github.com/users/darkwing/events{/privacy}","received_events_url":"https://api.github.com/users/darkwing/received_events","type":"User","site_admin":false},"body":"Should we try to shorten this code a bit, like:\r\n\r\n```js\r\nconst shouldBreakStep = !t.isCallExpression(node.argument);\r\n\r\nstate.push(formatNode(node.loc.start, { breakpoint: shouldBreakStep, stepOver: shouldBreakStep }))\r\n```","created_at":"2018-03-23T17:21:59Z","updated_at":"2018-03-23T17:22:07Z","html_url":"https://github.com/devtools-html/debugger.html/pull/5771#discussion_r176807052","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/176807052"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/5771#discussion_r176807052"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771"}}},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771","id":177113513,"html_url":"https://github.com/devtools-html/debugger.html/pull/5771","diff_url":"https://github.com/devtools-html/debugger.html/pull/5771.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/5771.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/5771","number":5771,"state":"open","locked":false,"title":"Pause points tweaks","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars1.githubusercontent.com/u/254562?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\n\r\n* fixes up two tests whose behavior changed (largely) for the better\r\n* removes a check about adding a breakpoint w/ sliding bc pausepoints prevents users from adding bps in that spot\r\n* added a `return foo()` check in pause points to prevent pausing at a return when there is a subsequent call\r\n","created_at":"2018-03-23T15:59:57Z","updated_at":"2018-03-23T17:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4a9bd356c6e71b9966e3a877549e674a5df294c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/5771/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/f3bea6d2c7f07a751515f55846c70dd228e06d38","head":{"label":"jasonLaster:pause-point-tweaks","ref":"pause-point-tweaks","sha":"f3bea6d2c7f07a751515f55846c70dd228e06d38","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars1.githubusercontent.com/u/254562?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"repo":{"id":55007537,"name":"debugger.html","full_name":"jasonLaster/debugger.html","owner":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars1.githubusercontent.com/u/254562?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonLaster/debugger.html","description":"Experimental something something.","fork":true,"url":"https://api.github.com/repos/jasonLaster/debugger.html","forks_url":"https://api.github.com/repos/jasonLaster/debugger.html/forks","keys_url":"https://api.github.com/repos/jasonLaster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonLaster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonLaster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jasonLaster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jasonLaster/debugger.html/events","assignees_url":"https://api.github.com/repos/jasonLaster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jasonLaster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonLaster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonLaster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jasonLaster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jasonLaster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonLaster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonLaster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jasonLaster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonLaster/debugger.html/merges","archive_url":"https://api.github.com/repos/jasonLaster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonLaster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jasonLaster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonLaster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonLaster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonLaster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jasonLaster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jasonLaster/debugger.html/deployments","created_at":"2016-03-29T20:14:57Z","updated_at":"2018-02-08T23:51:15Z","pushed_at":"2018-03-23T15:58:34Z","git_url":"git://github.com/jasonLaster/debugger.html.git","ssh_url":"git@github.com:jasonLaster/debugger.html.git","clone_url":"https://github.com/jasonLaster/debugger.html.git","svn_url":"https://github.com/jasonLaster/debugger.html","homepage":null,"size":33832,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"e06cf1ef540fe6231ec731243a01887c1367a708","user":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"devtools-html/debugger.html","owner":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2018-03-23T16:54:04Z","pushed_at":"2018-03-23T16:54:01Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"git@github.com:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":18744,"stargazers_count":3580,"watchers_count":3580,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":574,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":574,"open_issues":141,"watchers":3580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/5771"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/5771"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/5771/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5771/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/f3bea6d2c7f07a751515f55846c70dd228e06d38"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"darkwing"}}