{"action":"created","issue":{"url":"https://api.github.com/repos/google/jsonapi/issues/99","repository_url":"https://api.github.com/repos/google/jsonapi","labels_url":"https://api.github.com/repos/google/jsonapi/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/google/jsonapi/issues/99/comments","events_url":"https://api.github.com/repos/google/jsonapi/issues/99/events","html_url":"https://github.com/google/jsonapi/pull/99","id":243176519,"number":99,"title":"Unmarshalling of nested structs","user":{"login":"Slemgrim","id":4717157,"avatar_url":"https://avatars1.githubusercontent.com/u/4717157?v=4","gravatar_id":"","url":"https://api.github.com/users/Slemgrim","html_url":"https://github.com/Slemgrim","followers_url":"https://api.github.com/users/Slemgrim/followers","following_url":"https://api.github.com/users/Slemgrim/following{/other_user}","gists_url":"https://api.github.com/users/Slemgrim/gists{/gist_id}","starred_url":"https://api.github.com/users/Slemgrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slemgrim/subscriptions","organizations_url":"https://api.github.com/users/Slemgrim/orgs","repos_url":"https://api.github.com/users/Slemgrim/repos","events_url":"https://api.github.com/users/Slemgrim/events{/privacy}","received_events_url":"https://api.github.com/users/Slemgrim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2017-07-15T13:52:10Z","updated_at":"2018-04-11T13:25:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/google/jsonapi/pulls/99","html_url":"https://github.com/google/jsonapi/pull/99","diff_url":"https://github.com/google/jsonapi/pull/99.diff","patch_url":"https://github.com/google/jsonapi/pull/99.patch"},"body":"This mainly addresses #49 and has nothing todo with #21 \r\n\r\nThe marshalling function is able to convert a nested struct into a valid json:api representation but you can't use the output for the unmarshalPayload function since it fails when a struct is used as an attribute. \r\n\r\nThis should be possible according to the json:api spec: http://jsonapi.org/format/#document-resource-object-attributes\r\n\r\nThe PR adds this functionality with the limitation of pointers. At the moment this only works with values (as shown in the added tests)\r\n\r\nI also had to restructure the unmarshalNode function in order to convert the attributes recursively. This should simplify the implementation of #95\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/google/jsonapi/issues/comments/380450754","html_url":"https://github.com/google/jsonapi/pull/99#issuecomment-380450754","issue_url":"https://api.github.com/repos/google/jsonapi/issues/99","id":380450754,"user":{"login":"valentindotxyz","id":1806511,"avatar_url":"https://avatars2.githubusercontent.com/u/1806511?v=4","gravatar_id":"","url":"https://api.github.com/users/valentindotxyz","html_url":"https://github.com/valentindotxyz","followers_url":"https://api.github.com/users/valentindotxyz/followers","following_url":"https://api.github.com/users/valentindotxyz/following{/other_user}","gists_url":"https://api.github.com/users/valentindotxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/valentindotxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentindotxyz/subscriptions","organizations_url":"https://api.github.com/users/valentindotxyz/orgs","repos_url":"https://api.github.com/users/valentindotxyz/repos","events_url":"https://api.github.com/users/valentindotxyz/events{/privacy}","received_events_url":"https://api.github.com/users/valentindotxyz/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T13:25:40Z","updated_at":"2018-04-11T13:25:40Z","author_association":"NONE","body":"Hoping it will be merged soon too! 🙏🏻"}}
{"actor":{"display_login":"valentindotxyz"}}