{"action":"created","issue":{"url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec/issues/4","repository_url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec","labels_url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec/issues/4/comments","events_url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec/issues/4/events","html_url":"https://github.com/labstreaminglayer/App-g.Tec/issues/4","id":384973055,"node_id":"MDU6SXNzdWUzODQ5NzMwNTU=","number":4,"title":"gUSBamp filter configuration","user":{"login":"cboulay","id":303797,"node_id":"MDQ6VXNlcjMwMzc5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/303797?v=4","gravatar_id":"","url":"https://api.github.com/users/cboulay","html_url":"https://github.com/cboulay","followers_url":"https://api.github.com/users/cboulay/followers","following_url":"https://api.github.com/users/cboulay/following{/other_user}","gists_url":"https://api.github.com/users/cboulay/gists{/gist_id}","starred_url":"https://api.github.com/users/cboulay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboulay/subscriptions","organizations_url":"https://api.github.com/users/cboulay/orgs","repos_url":"https://api.github.com/users/cboulay/repos","events_url":"https://api.github.com/users/cboulay/events{/privacy}","received_events_url":"https://api.github.com/users/cboulay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-27T20:30:23Z","updated_at":"2018-11-27T20:30:24Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"_From @delozath on February 25, 2016 14:22_\n\nHello everyone,\n\nI've been searching in forums and code examples, but I haven't figured out how to configure the hardware filters of the g.USBamp using the lsl\\Apps\\g.Tec\\g.USBamp app. I guess, it is related to the .cgf file. Does anybody have some idea?\n\nThank you in advanced!\n\n\n_Copied from original issue: sccn/lsl_archived#94_"},"comment":{"url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec/issues/comments/442205960","html_url":"https://github.com/labstreaminglayer/App-g.Tec/issues/4#issuecomment-442205960","issue_url":"https://api.github.com/repos/labstreaminglayer/App-g.Tec/issues/4","id":442205960,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjIwNTk2MA==","user":{"login":"cboulay","id":303797,"node_id":"MDQ6VXNlcjMwMzc5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/303797?v=4","gravatar_id":"","url":"https://api.github.com/users/cboulay","html_url":"https://github.com/cboulay","followers_url":"https://api.github.com/users/cboulay/followers","following_url":"https://api.github.com/users/cboulay/following{/other_user}","gists_url":"https://api.github.com/users/cboulay/gists{/gist_id}","starred_url":"https://api.github.com/users/cboulay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboulay/subscriptions","organizations_url":"https://api.github.com/users/cboulay/orgs","repos_url":"https://api.github.com/users/cboulay/repos","events_url":"https://api.github.com/users/cboulay/events{/privacy}","received_events_url":"https://api.github.com/users/cboulay/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T20:30:24Z","updated_at":"2018-11-27T20:30:24Z","author_association":"CONTRIBUTOR","body":"[This code segment](https://github.com/sccn/labstreaminglayer/blob/master/Apps/g.Tec/g.USBamp/mainwindow.cpp#L185-L211) shows that the filters are disabled by default. I [searched the repository](https://github.com/sccn/labstreaminglayer/search?utf8=%E2%9C%93&q=GT_SetBandPass) for any other mention of `GT_SetBandPass` and there was none other than the vendor-supplied header file. I guess the LSL app is not yet capable of setting the filters, though it shouldn't be too difficult.\n\nThe simplest solution for you would be to hard code which filter type you want to use by replacing the `-1` with the filter number.\n\nThe second-easiest solution would require several modifications:\n1. Add a ui element [like this one](https://github.com/sccn/labstreaminglayer/blob/master/Apps/g.Tec/g.USBamp/mainwindow.ui#L75-L89) for storing the filter number as an integer.\n2. Modify how the [config files are read](https://github.com/sccn/labstreaminglayer/blob/master/Apps/g.Tec/g.USBamp/mainwindow.cpp#L57-L66) and saved to use the filter number ui element.\n3. During initialization, somewhere around [here](https://github.com/sccn/labstreaminglayer/blob/master/Apps/g.Tec/g.USBamp/mainwindow.cpp#L139), read the filter number from the ui into an int.\n4. During filter setup, replace the `-1` with the int filter number in the call to `GT_SetBandPass`.\n\nAlso do the above for `GT_SetNotch` while you're at it.\n\nThis will set all channels to use the same bandpass and notch filter types.\n\nProbably the better long-term solution would be to create a table widget with a row for each channel and columns corresponding to channel_label, band_pass_filter_id, notch_filter_id, is_bipolar, is_DRL\n\nI don't have access to a g.USBamp and coding these things without hardware to test on is pretty difficult.\n"}}
{"actor":{"display_login":"cboulay"}}