{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/comments/165470009","pull_request_review_id":93416066,"id":165470009,"diff_hunk":"@@ -36,14 +36,15 @@\n  *\n  * @author Artem Bilan\n  * @author Ivan Ursul\n+ * @author Soby Chacko\n  *\n  * @since 1.1.4\n  */\n public class StreamsBuilderFactoryBean extends AbstractFactoryBean<StreamsBuilder> implements SmartLifecycle {\n \n \tprivate static final int DEFAULT_CLOSE_TIMEOUT = 10;\n \n-\tprivate final StreamsConfig streamsConfig;\n+\tprivate StreamsConfig streamsConfig;\n \n \tprivate final CleanupConfig cleanupConfig;","path":"spring-kafka/src/main/java/org/springframework/kafka/core/StreamsBuilderFactoryBean.java","position":15,"original_position":15,"commit_id":"a1be5573a08482f3559b210755d328ee9bff117f","original_commit_id":"a1be5573a08482f3559b210755d328ee9bff117f","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars3.githubusercontent.com/u/1071590?v=4","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"Nit-pick: the fields order should be like:\r\n`static final`\r\n`static`\r\n`final`\r\nnon-`volatile`\r\n`volatile`\r\n\r\nSo, since the `streamsConfig` isn't `final` any more should be moved below `cleanupConfig`.\r\n","created_at":"2018-02-01T19:54:49Z","updated_at":"2018-02-01T20:01:46Z","html_url":"https://github.com/spring-projects/spring-kafka/pull/551#discussion_r165470009","pull_request_url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/comments/165470009"},"html":{"href":"https://github.com/spring-projects/spring-kafka/pull/551#discussion_r165470009"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551","id":166618683,"html_url":"https://github.com/spring-projects/spring-kafka/pull/551","diff_url":"https://github.com/spring-projects/spring-kafka/pull/551.diff","patch_url":"https://github.com/spring-projects/spring-kafka/pull/551.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/551","number":551,"state":"open","locked":false,"title":"GH-548: StreamsBuilderFactoryBean enhancements","user":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars3.githubusercontent.com/u/827682?v=4","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"body":"Make StreamsConfig customizable in StreamsBuilderFactoryBean\r\nSet the phase on StreamsBuilderFactoryBean to Integer.MAX_VALUE - 1000\r\nAdding tests","created_at":"2018-02-01T18:40:41Z","updated_at":"2018-02-01T20:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df802ce9efb26b43fb814f0869e4249d86dd460e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/551/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-kafka/statuses/a1be5573a08482f3559b210755d328ee9bff117f","head":{"label":"sobychacko:gh-548","ref":"gh-548","sha":"a1be5573a08482f3559b210755d328ee9bff117f","user":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars3.githubusercontent.com/u/827682?v=4","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"repo":{"id":61745103,"name":"spring-kafka","full_name":"sobychacko/spring-kafka","owner":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars3.githubusercontent.com/u/827682?v=4","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sobychacko/spring-kafka","description":"Provides Familiar Spring Abstractions for Apache Kafka","fork":true,"url":"https://api.github.com/repos/sobychacko/spring-kafka","forks_url":"https://api.github.com/repos/sobychacko/spring-kafka/forks","keys_url":"https://api.github.com/repos/sobychacko/spring-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sobychacko/spring-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sobychacko/spring-kafka/teams","hooks_url":"https://api.github.com/repos/sobychacko/spring-kafka/hooks","issue_events_url":"https://api.github.com/repos/sobychacko/spring-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/sobychacko/spring-kafka/events","assignees_url":"https://api.github.com/repos/sobychacko/spring-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/sobychacko/spring-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/sobychacko/spring-kafka/tags","blobs_url":"https://api.github.com/repos/sobychacko/spring-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sobychacko/spring-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sobychacko/spring-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/sobychacko/spring-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sobychacko/spring-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/sobychacko/spring-kafka/languages","stargazers_url":"https://api.github.com/repos/sobychacko/spring-kafka/stargazers","contributors_url":"https://api.github.com/repos/sobychacko/spring-kafka/contributors","subscribers_url":"https://api.github.com/repos/sobychacko/spring-kafka/subscribers","subscription_url":"https://api.github.com/repos/sobychacko/spring-kafka/subscription","commits_url":"https://api.github.com/repos/sobychacko/spring-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/sobychacko/spring-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/sobychacko/spring-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/sobychacko/spring-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/sobychacko/spring-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/sobychacko/spring-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sobychacko/spring-kafka/merges","archive_url":"https://api.github.com/repos/sobychacko/spring-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sobychacko/spring-kafka/downloads","issues_url":"https://api.github.com/repos/sobychacko/spring-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/sobychacko/spring-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/sobychacko/spring-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/sobychacko/spring-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sobychacko/spring-kafka/labels{/name}","releases_url":"https://api.github.com/repos/sobychacko/spring-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/sobychacko/spring-kafka/deployments","created_at":"2016-06-22T19:14:56Z","updated_at":"2016-06-22T19:14:57Z","pushed_at":"2018-02-01T18:39:59Z","git_url":"git://github.com/sobychacko/spring-kafka.git","ssh_url":"git@github.com:sobychacko/spring-kafka.git","clone_url":"https://github.com/sobychacko/spring-kafka.git","svn_url":"https://github.com/sobychacko/spring-kafka","homepage":"https://projects.spring.io/spring-kafka","size":2307,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"3771e2a5e615dc2fc34f200b5d7074b5fe7367f3","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":52980493,"name":"spring-kafka","full_name":"spring-projects/spring-kafka","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-kafka","description":"Provides Familiar Spring Abstractions for Apache Kafka","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-kafka","forks_url":"https://api.github.com/repos/spring-projects/spring-kafka/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-kafka/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-kafka/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-kafka/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-kafka/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-kafka/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-kafka/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-kafka/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-kafka/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-kafka/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-kafka/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-kafka/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-kafka/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-kafka/deployments","created_at":"2016-03-02T17:01:33Z","updated_at":"2018-02-01T04:57:57Z","pushed_at":"2018-02-01T18:40:41Z","git_url":"git://github.com/spring-projects/spring-kafka.git","ssh_url":"git@github.com:spring-projects/spring-kafka.git","clone_url":"https://github.com/spring-projects/spring-kafka.git","svn_url":"https://github.com/spring-projects/spring-kafka","homepage":"https://projects.spring.io/spring-kafka","size":2680,"stargazers_count":364,"watchers_count":364,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":233,"open_issues":30,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551"},"html":{"href":"https://github.com/spring-projects/spring-kafka/pull/551"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/issues/551"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-kafka/statuses/a1be5573a08482f3559b210755d328ee9bff117f"}},"author_association":"NONE"}}
{"actor":{"display_login":"artembilan"}}