{"action":"created","comment":{"url":"https://api.github.com/repos/angular/preboot/pulls/comments/168220912","pull_request_review_id":96552658,"id":168220912,"diff_hunk":"@@ -12,7 +12,7 @@\n     \"pretest\": \"npm run build-test\",\n     \"test\": \"concurrently \\\"npm run build-test:watch\\\" \\\"karma start karma.conf.js\\\"\",\n     \"pretest:once\": \"npm run build-test\",\n-    \"test:once\": \"karma start karma.conf.js --single-run\",\n+    \"test:once\": \"karma start karma.conf.js --single-run --no-auto-watch\",","path":"package.json","position":5,"original_position":5,"commit_id":"215cd05d5f57fd56573904602b81052a0f1aaf75","original_commit_id":"215cd05d5f57fd56573904602b81052a0f1aaf75","user":{"login":"CaerusKaru","id":416563,"avatar_url":"https://avatars3.githubusercontent.com/u/416563?v=4","gravatar_id":"","url":"https://api.github.com/users/CaerusKaru","html_url":"https://github.com/CaerusKaru","followers_url":"https://api.github.com/users/CaerusKaru/followers","following_url":"https://api.github.com/users/CaerusKaru/following{/other_user}","gists_url":"https://api.github.com/users/CaerusKaru/gists{/gist_id}","starred_url":"https://api.github.com/users/CaerusKaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaerusKaru/subscriptions","organizations_url":"https://api.github.com/users/CaerusKaru/orgs","repos_url":"https://api.github.com/users/CaerusKaru/repos","events_url":"https://api.github.com/users/CaerusKaru/events{/privacy}","received_events_url":"https://api.github.com/users/CaerusKaru/received_events","type":"User","site_admin":false},"body":"This is not necessary","created_at":"2018-02-14T16:02:00Z","updated_at":"2018-02-14T16:02:05Z","html_url":"https://github.com/angular/preboot/pull/70#discussion_r168220912","pull_request_url":"https://api.github.com/repos/angular/preboot/pulls/70","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/preboot/pulls/comments/168220912"},"html":{"href":"https://github.com/angular/preboot/pull/70#discussion_r168220912"},"pull_request":{"href":"https://api.github.com/repos/angular/preboot/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/angular/preboot/pulls/70","id":169091801,"html_url":"https://github.com/angular/preboot/pull/70","diff_url":"https://github.com/angular/preboot/pull/70.diff","patch_url":"https://github.com/angular/preboot/pull/70.patch","issue_url":"https://api.github.com/repos/angular/preboot/issues/70","number":70,"state":"open","locked":false,"title":"test: enable autoWatch in karma.conf.js","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"Without this change `npm test` fires up Karma but does nothing further with it.\r\n\r\n* **Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/preboot/blob/master/CONTRIBUTING.md#commit-message-format\r\n- ~~Tests for the changes have been added (for bug fixes / features)~~\r\n- ~~Docs have been added / updated (for bug fixes / features)~~\r\n\r\n* **What modules are related to this pull-request**\r\n- [ ] server side\r\n- [ ] client side\r\n- [ ] inline\r\n- [ ] build process\r\n- [ ] docs\r\n- [x] tests\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\nremove unused proxy imports from some test files\r\n\r\nA test setup fix.\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\n\r\n`npm test` fires up Karma but does nothing further with it.\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\n\r\n`npm test` fires up Karma & re-runs unit tests on every file modification.\r\n\r\n* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)\r\n\r\nNo.\r\n\r\n* **Other information**:\r\n","created_at":"2018-02-14T12:02:35Z","updated_at":"2018-02-14T16:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c727ed3aa14225becacfe6081d0ca01dc4fc2d6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/preboot/pulls/70/commits","review_comments_url":"https://api.github.com/repos/angular/preboot/pulls/70/comments","review_comment_url":"https://api.github.com/repos/angular/preboot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/preboot/issues/70/comments","statuses_url":"https://api.github.com/repos/angular/preboot/statuses/215cd05d5f57fd56573904602b81052a0f1aaf75","head":{"label":"mgol:karma","ref":"karma","sha":"215cd05d5f57fd56573904602b81052a0f1aaf75","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"repo":{"id":120895799,"name":"preboot","full_name":"mgol/preboot","owner":{"login":"mgol","id":1758366,"avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgol/preboot","description":"Coordinate transfer of state from server to client view for isomorphic/universal JavaScript web applications","fork":true,"url":"https://api.github.com/repos/mgol/preboot","forks_url":"https://api.github.com/repos/mgol/preboot/forks","keys_url":"https://api.github.com/repos/mgol/preboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgol/preboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgol/preboot/teams","hooks_url":"https://api.github.com/repos/mgol/preboot/hooks","issue_events_url":"https://api.github.com/repos/mgol/preboot/issues/events{/number}","events_url":"https://api.github.com/repos/mgol/preboot/events","assignees_url":"https://api.github.com/repos/mgol/preboot/assignees{/user}","branches_url":"https://api.github.com/repos/mgol/preboot/branches{/branch}","tags_url":"https://api.github.com/repos/mgol/preboot/tags","blobs_url":"https://api.github.com/repos/mgol/preboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgol/preboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgol/preboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgol/preboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgol/preboot/statuses/{sha}","languages_url":"https://api.github.com/repos/mgol/preboot/languages","stargazers_url":"https://api.github.com/repos/mgol/preboot/stargazers","contributors_url":"https://api.github.com/repos/mgol/preboot/contributors","subscribers_url":"https://api.github.com/repos/mgol/preboot/subscribers","subscription_url":"https://api.github.com/repos/mgol/preboot/subscription","commits_url":"https://api.github.com/repos/mgol/preboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgol/preboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgol/preboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgol/preboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgol/preboot/contents/{+path}","compare_url":"https://api.github.com/repos/mgol/preboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgol/preboot/merges","archive_url":"https://api.github.com/repos/mgol/preboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgol/preboot/downloads","issues_url":"https://api.github.com/repos/mgol/preboot/issues{/number}","pulls_url":"https://api.github.com/repos/mgol/preboot/pulls{/number}","milestones_url":"https://api.github.com/repos/mgol/preboot/milestones{/number}","notifications_url":"https://api.github.com/repos/mgol/preboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgol/preboot/labels{/name}","releases_url":"https://api.github.com/repos/mgol/preboot/releases{/id}","deployments_url":"https://api.github.com/repos/mgol/preboot/deployments","created_at":"2018-02-09T11:06:21Z","updated_at":"2018-02-09T11:06:23Z","pushed_at":"2018-02-14T14:32:36Z","git_url":"git://github.com/mgol/preboot.git","ssh_url":"git@github.com:mgol/preboot.git","clone_url":"https://github.com/mgol/preboot.git","svn_url":"https://github.com/mgol/preboot","homepage":"","size":1619,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"a10e4af9e2867098974ddf790b3fed9b2fbb9b26","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":62827997,"name":"preboot","full_name":"angular/preboot","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/preboot","description":"Coordinate transfer of state from server to client view for isomorphic/universal JavaScript web applications","fork":false,"url":"https://api.github.com/repos/angular/preboot","forks_url":"https://api.github.com/repos/angular/preboot/forks","keys_url":"https://api.github.com/repos/angular/preboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/preboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/preboot/teams","hooks_url":"https://api.github.com/repos/angular/preboot/hooks","issue_events_url":"https://api.github.com/repos/angular/preboot/issues/events{/number}","events_url":"https://api.github.com/repos/angular/preboot/events","assignees_url":"https://api.github.com/repos/angular/preboot/assignees{/user}","branches_url":"https://api.github.com/repos/angular/preboot/branches{/branch}","tags_url":"https://api.github.com/repos/angular/preboot/tags","blobs_url":"https://api.github.com/repos/angular/preboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/preboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/preboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/preboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/preboot/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/preboot/languages","stargazers_url":"https://api.github.com/repos/angular/preboot/stargazers","contributors_url":"https://api.github.com/repos/angular/preboot/contributors","subscribers_url":"https://api.github.com/repos/angular/preboot/subscribers","subscription_url":"https://api.github.com/repos/angular/preboot/subscription","commits_url":"https://api.github.com/repos/angular/preboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/preboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/preboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/preboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/preboot/contents/{+path}","compare_url":"https://api.github.com/repos/angular/preboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/preboot/merges","archive_url":"https://api.github.com/repos/angular/preboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/preboot/downloads","issues_url":"https://api.github.com/repos/angular/preboot/issues{/number}","pulls_url":"https://api.github.com/repos/angular/preboot/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/preboot/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/preboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/preboot/labels{/name}","releases_url":"https://api.github.com/repos/angular/preboot/releases{/id}","deployments_url":"https://api.github.com/repos/angular/preboot/deployments","created_at":"2016-07-07T18:04:56Z","updated_at":"2018-02-12T17:52:10Z","pushed_at":"2018-02-14T15:57:36Z","git_url":"git://github.com/angular/preboot.git","ssh_url":"git@github.com:angular/preboot.git","clone_url":"https://github.com/angular/preboot.git","svn_url":"https://github.com/angular/preboot","homepage":"","size":1612,"stargazers_count":226,"watchers_count":226,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":36,"open_issues":5,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/preboot/pulls/70"},"html":{"href":"https://github.com/angular/preboot/pull/70"},"issue":{"href":"https://api.github.com/repos/angular/preboot/issues/70"},"comments":{"href":"https://api.github.com/repos/angular/preboot/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/preboot/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/preboot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/preboot/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/angular/preboot/statuses/215cd05d5f57fd56573904602b81052a0f1aaf75"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CaerusKaru"}}