{"action":"created","comment":{"url":"https://api.github.com/repos/runelite/runelite/pulls/comments/181600328","pull_request_review_id":112254443,"id":181600328,"diff_hunk":"@@ -80,7 +81,9 @@\n \n \tprivate static final Injector injector = RuneLite.getInjector();\n \tprivate static final Client client = injector.getInstance(Client.class);\n-\tpublic static final EventBus eventBus = injector.getInstance(EventBus.class);\n+\tpublic static final EventBus eventBus = injector.getInstance(EventBus.class); // symbol must match mixin Hook","path":"runelite-client/src/main/java/net/runelite/client/callback/Hooks.java","position":13,"original_position":13,"commit_id":"a635de28f891e5a33f6d10ae14e7216dd53010da","original_commit_id":"6c87df6fb7154885646f1f1a713a1ae448ec1616","user":{"login":"Adam-","id":309739,"avatar_url":"https://avatars2.githubusercontent.com/u/309739?v=4","gravatar_id":"","url":"https://api.github.com/users/Adam-","html_url":"https://github.com/Adam-","followers_url":"https://api.github.com/users/Adam-/followers","following_url":"https://api.github.com/users/Adam-/following{/other_user}","gists_url":"https://api.github.com/users/Adam-/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam-/subscriptions","organizations_url":"https://api.github.com/users/Adam-/orgs","repos_url":"https://api.github.com/users/Adam-/repos","events_url":"https://api.github.com/users/Adam-/events{/privacy}","received_events_url":"https://api.github.com/users/Adam-/received_events","type":"User","site_admin":false},"body":"It must be public because it is accessed directly from code injected into the client, which is in a different package. But the type and name must be equivalent as it is compiled against the one in the mixing and actually runs against this one.","created_at":"2018-04-15T22:55:36Z","updated_at":"2018-04-15T22:55:36Z","html_url":"https://github.com/runelite/runelite/pull/1569#discussion_r181600328","pull_request_url":"https://api.github.com/repos/runelite/runelite/pulls/1569","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments/181600328"},"html":{"href":"https://github.com/runelite/runelite/pull/1569#discussion_r181600328"},"pull_request":{"href":"https://api.github.com/repos/runelite/runelite/pulls/1569"}},"in_reply_to_id":181590119},"pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/1569","id":181707118,"html_url":"https://github.com/runelite/runelite/pull/1569","diff_url":"https://github.com/runelite/runelite/pull/1569.diff","patch_url":"https://github.com/runelite/runelite/pull/1569.patch","issue_url":"https://api.github.com/repos/runelite/runelite/issues/1569","number":1569,"state":"open","locked":false,"title":"Deferred events, add item container changed event, and actor spawn events","user":{"login":"Adam-","id":309739,"avatar_url":"https://avatars2.githubusercontent.com/u/309739?v=4","gravatar_id":"","url":"https://api.github.com/users/Adam-","html_url":"https://github.com/Adam-","followers_url":"https://api.github.com/users/Adam-/followers","following_url":"https://api.github.com/users/Adam-/following{/other_user}","gists_url":"https://api.github.com/users/Adam-/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam-/subscriptions","organizations_url":"https://api.github.com/users/Adam-/orgs","repos_url":"https://api.github.com/users/Adam-/repos","events_url":"https://api.github.com/users/Adam-/events{/privacy}","received_events_url":"https://api.github.com/users/Adam-/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-15T16:17:04Z","updated_at":"2018-04-15T22:55:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68dcbf10364cb1b5f0eb75cbd2e15fa03446c90c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Abextm","id":12366911,"avatar_url":"https://avatars2.githubusercontent.com/u/12366911?v=4","gravatar_id":"","url":"https://api.github.com/users/Abextm","html_url":"https://github.com/Abextm","followers_url":"https://api.github.com/users/Abextm/followers","following_url":"https://api.github.com/users/Abextm/following{/other_user}","gists_url":"https://api.github.com/users/Abextm/gists{/gist_id}","starred_url":"https://api.github.com/users/Abextm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abextm/subscriptions","organizations_url":"https://api.github.com/users/Abextm/orgs","repos_url":"https://api.github.com/users/Abextm/repos","events_url":"https://api.github.com/users/Abextm/events{/privacy}","received_events_url":"https://api.github.com/users/Abextm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":366780282,"url":"https://api.github.com/repos/runelite/runelite/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/runelite/runelite/pulls/1569/commits","review_comments_url":"https://api.github.com/repos/runelite/runelite/pulls/1569/comments","review_comment_url":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/1569/comments","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/a635de28f891e5a33f6d10ae14e7216dd53010da","head":{"label":"Adam-:deferred-events","ref":"deferred-events","sha":"a635de28f891e5a33f6d10ae14e7216dd53010da","user":{"login":"Adam-","id":309739,"avatar_url":"https://avatars2.githubusercontent.com/u/309739?v=4","gravatar_id":"","url":"https://api.github.com/users/Adam-","html_url":"https://github.com/Adam-","followers_url":"https://api.github.com/users/Adam-/followers","following_url":"https://api.github.com/users/Adam-/following{/other_user}","gists_url":"https://api.github.com/users/Adam-/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam-/subscriptions","organizations_url":"https://api.github.com/users/Adam-/orgs","repos_url":"https://api.github.com/users/Adam-/repos","events_url":"https://api.github.com/users/Adam-/events{/privacy}","received_events_url":"https://api.github.com/users/Adam-/received_events","type":"User","site_admin":false},"repo":{"id":114504849,"name":"runelite","full_name":"Adam-/runelite","owner":{"login":"Adam-","id":309739,"avatar_url":"https://avatars2.githubusercontent.com/u/309739?v=4","gravatar_id":"","url":"https://api.github.com/users/Adam-","html_url":"https://github.com/Adam-","followers_url":"https://api.github.com/users/Adam-/followers","following_url":"https://api.github.com/users/Adam-/following{/other_user}","gists_url":"https://api.github.com/users/Adam-/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam-/subscriptions","organizations_url":"https://api.github.com/users/Adam-/orgs","repos_url":"https://api.github.com/users/Adam-/repos","events_url":"https://api.github.com/users/Adam-/events{/privacy}","received_events_url":"https://api.github.com/users/Adam-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Adam-/runelite","description":"Open source RuneScape client and deobfuscator","fork":true,"url":"https://api.github.com/repos/Adam-/runelite","forks_url":"https://api.github.com/repos/Adam-/runelite/forks","keys_url":"https://api.github.com/repos/Adam-/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adam-/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adam-/runelite/teams","hooks_url":"https://api.github.com/repos/Adam-/runelite/hooks","issue_events_url":"https://api.github.com/repos/Adam-/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/Adam-/runelite/events","assignees_url":"https://api.github.com/repos/Adam-/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/Adam-/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/Adam-/runelite/tags","blobs_url":"https://api.github.com/repos/Adam-/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adam-/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adam-/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adam-/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adam-/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/Adam-/runelite/languages","stargazers_url":"https://api.github.com/repos/Adam-/runelite/stargazers","contributors_url":"https://api.github.com/repos/Adam-/runelite/contributors","subscribers_url":"https://api.github.com/repos/Adam-/runelite/subscribers","subscription_url":"https://api.github.com/repos/Adam-/runelite/subscription","commits_url":"https://api.github.com/repos/Adam-/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adam-/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adam-/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adam-/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adam-/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/Adam-/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adam-/runelite/merges","archive_url":"https://api.github.com/repos/Adam-/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adam-/runelite/downloads","issues_url":"https://api.github.com/repos/Adam-/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/Adam-/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/Adam-/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/Adam-/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adam-/runelite/labels{/name}","releases_url":"https://api.github.com/repos/Adam-/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/Adam-/runelite/deployments","created_at":"2017-12-17T02:48:04Z","updated_at":"2018-04-15T15:36:23Z","pushed_at":"2018-04-15T22:53:58Z","git_url":"git://github.com/Adam-/runelite.git","ssh_url":"git@github.com:Adam-/runelite.git","clone_url":"https://github.com/Adam-/runelite.git","svn_url":"https://github.com/Adam-/runelite","homepage":"https://runelite.net","size":37669,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"runelite:master","ref":"master","sha":"2d111dca37c13b7a652f557282f874b18aa55469","user":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"repo":{"id":57461213,"name":"runelite","full_name":"runelite/runelite","owner":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runelite/runelite","description":"Open source Old School RuneScape client","fork":false,"url":"https://api.github.com/repos/runelite/runelite","forks_url":"https://api.github.com/repos/runelite/runelite/forks","keys_url":"https://api.github.com/repos/runelite/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runelite/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runelite/runelite/teams","hooks_url":"https://api.github.com/repos/runelite/runelite/hooks","issue_events_url":"https://api.github.com/repos/runelite/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/runelite/runelite/events","assignees_url":"https://api.github.com/repos/runelite/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/runelite/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/runelite/runelite/tags","blobs_url":"https://api.github.com/repos/runelite/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runelite/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runelite/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/runelite/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/runelite/runelite/languages","stargazers_url":"https://api.github.com/repos/runelite/runelite/stargazers","contributors_url":"https://api.github.com/repos/runelite/runelite/contributors","subscribers_url":"https://api.github.com/repos/runelite/runelite/subscribers","subscription_url":"https://api.github.com/repos/runelite/runelite/subscription","commits_url":"https://api.github.com/repos/runelite/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/runelite/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/runelite/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/runelite/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/runelite/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/runelite/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runelite/runelite/merges","archive_url":"https://api.github.com/repos/runelite/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runelite/runelite/downloads","issues_url":"https://api.github.com/repos/runelite/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/runelite/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/runelite/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/runelite/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runelite/runelite/labels{/name}","releases_url":"https://api.github.com/repos/runelite/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/runelite/runelite/deployments","created_at":"2016-04-30T20:48:02Z","updated_at":"2018-04-15T22:39:44Z","pushed_at":"2018-04-15T22:54:01Z","git_url":"git://github.com/runelite/runelite.git","ssh_url":"git@github.com:runelite/runelite.git","clone_url":"https://github.com/runelite/runelite.git","svn_url":"https://github.com/runelite/runelite","homepage":"https://runelite.net","size":37379,"stargazers_count":313,"watchers_count":313,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"archived":false,"open_issues_count":392,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":234,"open_issues":392,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/1569"},"html":{"href":"https://github.com/runelite/runelite/pull/1569"},"issue":{"href":"https://api.github.com/repos/runelite/runelite/issues/1569"},"comments":{"href":"https://api.github.com/repos/runelite/runelite/issues/1569/comments"},"review_comments":{"href":"https://api.github.com/repos/runelite/runelite/pulls/1569/comments"},"review_comment":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runelite/runelite/pulls/1569/commits"},"statuses":{"href":"https://api.github.com/repos/runelite/runelite/statuses/a635de28f891e5a33f6d10ae14e7216dd53010da"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Adam-"}}