{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8022","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8022/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8022/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8022/events","html_url":"https://github.com/PrestaShop/PrestaShop/pull/8022","id":236712319,"number":8022,"title":"[WIP] FO: Bootstrap v4-beta upgrade for Classic theme","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars0.githubusercontent.com/u/1698357?v=4","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"labels":[{"id":268030897,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/WIP","name":"WIP","color":"eb6420","default":false},{"id":186105912,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/waiting%20for%20author%20feedback","name":"waiting for author feedback","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones/41","html_url":"https://github.com/PrestaShop/PrestaShop/milestone/41","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones/41/labels","id":3265652,"number":41,"title":"1.7.5.0","description":null,"creator":{"login":"eternoendless","id":1009343,"avatar_url":"https://avatars3.githubusercontent.com/u/1009343?v=4","gravatar_id":"","url":"https://api.github.com/users/eternoendless","html_url":"https://github.com/eternoendless","followers_url":"https://api.github.com/users/eternoendless/followers","following_url":"https://api.github.com/users/eternoendless/following{/other_user}","gists_url":"https://api.github.com/users/eternoendless/gists{/gist_id}","starred_url":"https://api.github.com/users/eternoendless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eternoendless/subscriptions","organizations_url":"https://api.github.com/users/eternoendless/orgs","repos_url":"https://api.github.com/users/eternoendless/repos","events_url":"https://api.github.com/users/eternoendless/events{/privacy}","received_events_url":"https://api.github.com/users/eternoendless/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2018-04-13T12:40:06Z","updated_at":"2018-04-26T16:11:27Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2017-06-18T10:10:56Z","updated_at":"2018-04-26T16:41:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/8022","html_url":"https://github.com/PrestaShop/PrestaShop/pull/8022","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/8022.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/8022.patch"},"body":"| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | Bootstrap v4-beta upgrade with theme fixes\r\n| Type?         | improvement\r\n| Category?     | FO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| How to test?  | Install and see. :wink: \r\n\r\nThis is a **WIP** for now. Please test my PR and send me any remark or founded bug under comment. :+1: \r\n\r\nSee also: https://github.com/PrestaShop/PrestaShop/pull/8017#issuecomment-308964227\r\n\r\nNotes:\r\n\r\n* ps_banner default image should be redone to fit 1140px width.\r\n\r\nTODOs:\r\n\r\n- [x] Fix navbar desktop view\r\n- [ ] Fix navbar mobile view (with menu dropdown)\r\n- [x] Fix carrousel desktop view\r\n- [x] Fix Wrapper/Footer blank separation on desktop view\r\n- [x] Fix newsletter form on footer desktop view\r\n- [x] Resize product miniatures image size for desktop view\r\n- [x] Fix broken category page desktop view\r\n- [ ] Fix broken category page mobile view\r\n- [ ] Fix broken footer menus (disappears after de-collasping)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/8022)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/384709282","html_url":"https://github.com/PrestaShop/PrestaShop/pull/8022#issuecomment-384709282","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8022","id":384709282,"user":{"login":"johanlantz","id":7461655,"avatar_url":"https://avatars3.githubusercontent.com/u/7461655?v=4","gravatar_id":"","url":"https://api.github.com/users/johanlantz","html_url":"https://github.com/johanlantz","followers_url":"https://api.github.com/users/johanlantz/followers","following_url":"https://api.github.com/users/johanlantz/following{/other_user}","gists_url":"https://api.github.com/users/johanlantz/gists{/gist_id}","starred_url":"https://api.github.com/users/johanlantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanlantz/subscriptions","organizations_url":"https://api.github.com/users/johanlantz/orgs","repos_url":"https://api.github.com/users/johanlantz/repos","events_url":"https://api.github.com/users/johanlantz/events{/privacy}","received_events_url":"https://api.github.com/users/johanlantz/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T16:41:38Z","updated_at":"2018-04-26T16:41:38Z","author_association":"NONE","body":"I also got hit by this today. Some features I wanted from bootstrap 4 was not available in the Alpha. \r\n\r\nIf I am not mistaken existing themes can still ship their own bootstrap version. At some point you have to take the leap and it seems as with increased installations and modules for 1.7 it will only get worse by waiting. \r\n\r\nIf existing themes continue or update this would only affect modules expecting a certain behavior, maybe these modules are not as common as we think. I assume a lot of functionality in bootstrap will be unaffected by the post alpha 5 changes. "}}
{"actor":{"display_login":"johanlantz"}}