{"action":"created","comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/175963231","pull_request_review_id":105583411,"id":175963231,"diff_hunk":"@@ -969,6 +970,15 @@\n       marker-file: url('symbols/shop/variety_store.svg');\n     }\n   }\n+  \n+  [feature = 'advertising']{\n+    [advertising = 'column'][zoom >= 19] {","path":"amenity-points.mss","position":14,"original_position":14,"commit_id":"95d88561f3e80b4d90e0adb7774f3bf3d4c5dfdf","original_commit_id":"95d88561f3e80b4d90e0adb7774f3bf3d4c5dfdf","user":{"login":"kocio-pl","id":5439713,"avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"body":"Currently we use single features like `[feature = 'advertising_column']`. It is a text concatenation in project.mml.","created_at":"2018-03-21T00:37:18Z","updated_at":"2018-03-21T00:37:18Z","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3136#discussion_r175963231","pull_request_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/175963231"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/3136#discussion_r175963231"},"pull_request":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136"}}},"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136","id":176228140,"html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3136","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3136.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3136.patch","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3136","number":3136,"state":"open","locked":false,"title":"Adding advertising column icon and support for advertising key","user":{"login":"james2432","id":498547,"avatar_url":"https://avatars2.githubusercontent.com/u/498547?v=4","gravatar_id":"","url":"https://api.github.com/users/james2432","html_url":"https://github.com/james2432","followers_url":"https://api.github.com/users/james2432/followers","following_url":"https://api.github.com/users/james2432/following{/other_user}","gists_url":"https://api.github.com/users/james2432/gists{/gist_id}","starred_url":"https://api.github.com/users/james2432/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james2432/subscriptions","organizations_url":"https://api.github.com/users/james2432/orgs","repos_url":"https://api.github.com/users/james2432/repos","events_url":"https://api.github.com/users/james2432/events{/privacy}","received_events_url":"https://api.github.com/users/james2432/received_events","type":"User","site_admin":false},"body":"Fixes #3002 \r\n\r\nFrom https://www.openstreetmap.org/#map=19/45.51028/-73.61213 (node):\r\nZ19:\r\n![image](https://user-images.githubusercontent.com/498547/37687662-d3a5f59e-2c72-11e8-97c2-778b49129d39.png)\r\nZ18:\r\n![image](https://user-images.githubusercontent.com/498547/37687687-e493cb60-2c72-11e8-9e27-b6c587479db0.png)\r\n\r\n\r\nFrom https://www.openstreetmap.org/#map=19/48.53969/2.65847 (way):\r\n\r\n![image](https://user-images.githubusercontent.com/498547/37688486-c5307260-2c76-11e8-8d48-ffc22bab2fcc.png)\r\n","created_at":"2018-03-20T15:25:58Z","updated_at":"2018-03-21T00:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ef480051c0914d93bbf8196c0b8016611c63cd6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136/commits","review_comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136/comments","review_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3136/comments","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/95d88561f3e80b4d90e0adb7774f3bf3d4c5dfdf","head":{"label":"james2432:avertising_column","ref":"avertising_column","sha":"95d88561f3e80b4d90e0adb7774f3bf3d4c5dfdf","user":{"login":"james2432","id":498547,"avatar_url":"https://avatars2.githubusercontent.com/u/498547?v=4","gravatar_id":"","url":"https://api.github.com/users/james2432","html_url":"https://github.com/james2432","followers_url":"https://api.github.com/users/james2432/followers","following_url":"https://api.github.com/users/james2432/following{/other_user}","gists_url":"https://api.github.com/users/james2432/gists{/gist_id}","starred_url":"https://api.github.com/users/james2432/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james2432/subscriptions","organizations_url":"https://api.github.com/users/james2432/orgs","repos_url":"https://api.github.com/users/james2432/repos","events_url":"https://api.github.com/users/james2432/events{/privacy}","received_events_url":"https://api.github.com/users/james2432/received_events","type":"User","site_admin":false},"repo":{"id":125619273,"name":"openstreetmap-carto","full_name":"james2432/openstreetmap-carto","owner":{"login":"james2432","id":498547,"avatar_url":"https://avatars2.githubusercontent.com/u/498547?v=4","gravatar_id":"","url":"https://api.github.com/users/james2432","html_url":"https://github.com/james2432","followers_url":"https://api.github.com/users/james2432/followers","following_url":"https://api.github.com/users/james2432/following{/other_user}","gists_url":"https://api.github.com/users/james2432/gists{/gist_id}","starred_url":"https://api.github.com/users/james2432/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james2432/subscriptions","organizations_url":"https://api.github.com/users/james2432/orgs","repos_url":"https://api.github.com/users/james2432/repos","events_url":"https://api.github.com/users/james2432/events{/privacy}","received_events_url":"https://api.github.com/users/james2432/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james2432/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":true,"url":"https://api.github.com/repos/james2432/openstreetmap-carto","forks_url":"https://api.github.com/repos/james2432/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/james2432/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james2432/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james2432/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/james2432/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/james2432/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/james2432/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/james2432/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/james2432/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/james2432/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/james2432/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james2432/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james2432/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/james2432/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james2432/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/james2432/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/james2432/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/james2432/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/james2432/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/james2432/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/james2432/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/james2432/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/james2432/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/james2432/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/james2432/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/james2432/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james2432/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/james2432/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james2432/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/james2432/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/james2432/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/james2432/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/james2432/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james2432/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/james2432/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/james2432/openstreetmap-carto/deployments","created_at":"2018-03-17T10:42:04Z","updated_at":"2018-03-20T12:33:06Z","pushed_at":"2018-03-20T23:41:12Z","git_url":"git://github.com/james2432/openstreetmap-carto.git","ssh_url":"git@github.com:james2432/openstreetmap-carto.git","clone_url":"https://github.com/james2432/openstreetmap-carto.git","svn_url":"https://github.com/james2432/openstreetmap-carto","homepage":"","size":10650,"stargazers_count":0,"watchers_count":0,"language":"CartoCSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gravitystorm:master","ref":"master","sha":"a9b0d4916a1a6e2cf899b3e1a9daaf5f77fada50","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":6707453,"name":"openstreetmap-carto","full_name":"gravitystorm/openstreetmap-carto","owner":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gravitystorm/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":false,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/deployments","created_at":"2012-11-15T16:06:16Z","updated_at":"2018-03-20T11:00:27Z","pushed_at":"2018-03-20T23:41:13Z","git_url":"git://github.com/gravitystorm/openstreetmap-carto.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-carto.git","clone_url":"https://github.com/gravitystorm/openstreetmap-carto.git","svn_url":"https://github.com/gravitystorm/openstreetmap-carto","homepage":"","size":10627,"stargazers_count":645,"watchers_count":645,"language":"CartoCSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"archived":false,"open_issues_count":401,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":350,"open_issues":401,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/3136"},"issue":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3136"},"comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3136/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3136/commits"},"statuses":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/95d88561f3e80b4d90e0adb7774f3bf3d4c5dfdf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kocio-pl"}}