{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/176534094","pull_request_review_id":106255132,"id":176534094,"diff_hunk":"@@ -44,7 +44,7 @@ resource \"aws_appautoscaling_target\" \"dynamodb_index_read_target\" {\n resource \"aws_appautoscaling_target\" \"ecs_target\" {\n   max_capacity       = 4\n   min_capacity       = 1\n-  resource_id        = \"service/clusterName/serviceName\"\n+  resource_id        = \"service/${var.cluster_name}/${var.service_name}\"","path":"website/docs/r/appautoscaling_target.html.markdown","position":23,"original_position":23,"commit_id":"3cc4ed47944eb5e2b66e5d5004310c08e8d22327","original_commit_id":"3cc4ed47944eb5e2b66e5d5004310c08e8d22327","user":{"login":"bflad","id":189114,"avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"body":"We should probably provide the resource references here as well: `service/${aws_ecs_cluster.example.name}/${aws_ecs_service.example.name}`","created_at":"2018-03-22T18:49:16Z","updated_at":"2018-03-22T18:50:01Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3881#discussion_r176534094","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/176534094"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/3881#discussion_r176534094"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881","id":176823660,"html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3881","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3881.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/3881.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3881","number":3881,"state":"open","locked":false,"title":"changed docs of aws_appautoscaling_target","user":{"login":"GriffithBeliever","id":26068664,"avatar_url":"https://avatars0.githubusercontent.com/u/26068664?v=4","gravatar_id":"","url":"https://api.github.com/users/GriffithBeliever","html_url":"https://github.com/GriffithBeliever","followers_url":"https://api.github.com/users/GriffithBeliever/followers","following_url":"https://api.github.com/users/GriffithBeliever/following{/other_user}","gists_url":"https://api.github.com/users/GriffithBeliever/gists{/gist_id}","starred_url":"https://api.github.com/users/GriffithBeliever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GriffithBeliever/subscriptions","organizations_url":"https://api.github.com/users/GriffithBeliever/orgs","repos_url":"https://api.github.com/users/GriffithBeliever/repos","events_url":"https://api.github.com/users/GriffithBeliever/events{/privacy}","received_events_url":"https://api.github.com/users/GriffithBeliever/received_events","type":"User","site_admin":false},"body":"changed docs of aws_appautoscaling_target to show which parts of the resource_id need to be inputed by the user","created_at":"2018-03-22T15:49:55Z","updated_at":"2018-03-22T18:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f4222d6aa12874b00c0e0f3df17748a58e23f85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620316276,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/documentation","name":"documentation","color":"fef2c0","default":false},{"id":737832219,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/XS","name":"size/XS","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3881/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/3cc4ed47944eb5e2b66e5d5004310c08e8d22327","head":{"label":"GriffithBeliever:master","ref":"master","sha":"3cc4ed47944eb5e2b66e5d5004310c08e8d22327","user":{"login":"GriffithBeliever","id":26068664,"avatar_url":"https://avatars0.githubusercontent.com/u/26068664?v=4","gravatar_id":"","url":"https://api.github.com/users/GriffithBeliever","html_url":"https://github.com/GriffithBeliever","followers_url":"https://api.github.com/users/GriffithBeliever/followers","following_url":"https://api.github.com/users/GriffithBeliever/following{/other_user}","gists_url":"https://api.github.com/users/GriffithBeliever/gists{/gist_id}","starred_url":"https://api.github.com/users/GriffithBeliever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GriffithBeliever/subscriptions","organizations_url":"https://api.github.com/users/GriffithBeliever/orgs","repos_url":"https://api.github.com/users/GriffithBeliever/repos","events_url":"https://api.github.com/users/GriffithBeliever/events{/privacy}","received_events_url":"https://api.github.com/users/GriffithBeliever/received_events","type":"User","site_admin":false},"repo":{"id":126357403,"name":"terraform-provider-aws","full_name":"GriffithBeliever/terraform-provider-aws","owner":{"login":"GriffithBeliever","id":26068664,"avatar_url":"https://avatars0.githubusercontent.com/u/26068664?v=4","gravatar_id":"","url":"https://api.github.com/users/GriffithBeliever","html_url":"https://github.com/GriffithBeliever","followers_url":"https://api.github.com/users/GriffithBeliever/followers","following_url":"https://api.github.com/users/GriffithBeliever/following{/other_user}","gists_url":"https://api.github.com/users/GriffithBeliever/gists{/gist_id}","starred_url":"https://api.github.com/users/GriffithBeliever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GriffithBeliever/subscriptions","organizations_url":"https://api.github.com/users/GriffithBeliever/orgs","repos_url":"https://api.github.com/users/GriffithBeliever/repos","events_url":"https://api.github.com/users/GriffithBeliever/events{/privacy}","received_events_url":"https://api.github.com/users/GriffithBeliever/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GriffithBeliever/terraform-provider-aws","description":"Terraform AWS provider","fork":true,"url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws","forks_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/GriffithBeliever/terraform-provider-aws/deployments","created_at":"2018-03-22T15:38:35Z","updated_at":"2018-03-22T15:48:59Z","pushed_at":"2018-03-22T15:48:57Z","git_url":"git://github.com/GriffithBeliever/terraform-provider-aws.git","ssh_url":"git@github.com:GriffithBeliever/terraform-provider-aws.git","clone_url":"https://github.com/GriffithBeliever/terraform-provider-aws.git","svn_url":"https://github.com/GriffithBeliever/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":32263,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"89876a47b98d55f7a91b8e745c15246a3bcbf390","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-03-22T18:17:39Z","pushed_at":"2018-03-22T18:17:12Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":32247,"stargazers_count":933,"watchers_count":933,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":848,"mirror_url":null,"archived":false,"open_issues_count":1794,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":848,"open_issues":1794,"watchers":933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/3881"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3881"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/3881/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/3881/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/3cc4ed47944eb5e2b66e5d5004310c08e8d22327"}},"author_association":"NONE"}}
{"actor":{"display_login":"bflad"}}