{"action":"created","comment":{"url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/comments/175297918","pull_request_review_id":104805891,"id":175297918,"diff_hunk":"@@ -9,4 +15,34 @@\n     end\n   end\n \n+  describe \"GET #index\" do\n+    render_views\n+\n+    let!(:enabled_number)  { create(:phone_number, enabled: true) }\n+    let!(:disabled_number) { create(:phone_number, enabled: false) }\n+\n+    it \"returns http success\" do\n+      get :index\n+      expect(response).to have_http_status(:success)\n+    end\n+\n+    it 'returns enabled and disabled numbers' do\n+      get :index\n+      expect(response.body).to include enabled_number.number\n+      expect(response.body).to include disabled_number.number","path":"spec/controllers/settings_controller_spec.rb","position":null,"original_position":30,"commit_id":"81fd4a0a05d81ac25156a6fe72ff82183e53b8aa","original_commit_id":"7a31eeb5f44733cd987c6bb0518a415b17156a71","user":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"body":"I would recommend to test the `@phone_numbers`, because it's where the information is stored and you can really know whether the arrays `@phone_number` are being populated accurately or not.\r\n\r\n```ruby\r\nit 'populates an array of enabled and disabled numbers @phone_numbers' do\r\n   expect(assigns(:phone_numbers)).to match_array([enabled_number, disabled_number])\r\nend\r\n```","created_at":"2018-03-18T18:05:07Z","updated_at":"2018-03-18T18:05:07Z","html_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge/pull/5#discussion_r175297918","pull_request_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/comments/175297918"},"html":{"href":"https://github.com/vbrazo/zendesk-talk-technical-challenge/pull/5#discussion_r175297918"},"pull_request":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5","id":175715777,"html_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge/pull/5","diff_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge/pull/5.diff","patch_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge/pull/5.patch","issue_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/5","number":5,"state":"open","locked":false,"title":"Add filters to list all/enabled/disabled numbers","user":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"body":"- [x] Review the commit `Commit pushed by Paul Boxley`\r\n- [x] Add capybara gem\r\n- [x] Add scopes and their specs\r\n- [x] Add specs for these scenarios:\r\n- Click `enabled` - you should only see numbers that are enabled\r\n- Click `disabled` - you should only see numbers that are disabled\r\n- Click `all` - you should see all numbers\r\n- [x] Add capybara specs in the `features` folder\r\n- [x] Code refactoring: add phone presenter and search concern","created_at":"2018-03-17T19:00:44Z","updated_at":"2018-03-18T18:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482a923664aceb7e4a83b7e0d8e53f031a12507b","assignee":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"assignees":[{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5/commits","review_comments_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5/comments","review_comment_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/5/comments","statuses_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/statuses/81fd4a0a05d81ac25156a6fe72ff82183e53b8aa","head":{"label":"vbrazo:features/add_filters","ref":"features/add_filters","sha":"81fd4a0a05d81ac25156a6fe72ff82183e53b8aa","user":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"repo":{"id":125396360,"name":"zendesk-talk-technical-challenge","full_name":"vbrazo/zendesk-talk-technical-challenge","owner":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge","description":"Zendesk Talk Interview","fork":false,"url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge","forks_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/forks","keys_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/teams","hooks_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/hooks","issue_events_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/events","assignees_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/tags","blobs_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/languages","stargazers_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/stargazers","contributors_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/contributors","subscribers_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/subscribers","subscription_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/subscription","commits_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/merges","archive_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/downloads","issues_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/labels{/name}","releases_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/deployments","created_at":"2018-03-15T16:32:33Z","updated_at":"2018-03-18T01:14:35Z","pushed_at":"2018-03-18T17:04:20Z","git_url":"git://github.com/vbrazo/zendesk-talk-technical-challenge.git","ssh_url":"git@github.com:vbrazo/zendesk-talk-technical-challenge.git","clone_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge.git","svn_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vbrazo:master","ref":"master","sha":"53ee69a0cafccfcf734cd9e4b880f92104df4854","user":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"repo":{"id":125396360,"name":"zendesk-talk-technical-challenge","full_name":"vbrazo/zendesk-talk-technical-challenge","owner":{"login":"vbrazo","id":1292556,"avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge","description":"Zendesk Talk Interview","fork":false,"url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge","forks_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/forks","keys_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/teams","hooks_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/hooks","issue_events_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/events","assignees_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/tags","blobs_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/languages","stargazers_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/stargazers","contributors_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/contributors","subscribers_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/subscribers","subscription_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/subscription","commits_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/merges","archive_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/downloads","issues_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/labels{/name}","releases_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/deployments","created_at":"2018-03-15T16:32:33Z","updated_at":"2018-03-18T01:14:35Z","pushed_at":"2018-03-18T17:04:20Z","git_url":"git://github.com/vbrazo/zendesk-talk-technical-challenge.git","ssh_url":"git@github.com:vbrazo/zendesk-talk-technical-challenge.git","clone_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge.git","svn_url":"https://github.com/vbrazo/zendesk-talk-technical-challenge","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5"},"html":{"href":"https://github.com/vbrazo/zendesk-talk-technical-challenge/pull/5"},"issue":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/5"},"comments":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/vbrazo/zendesk-talk-technical-challenge/statuses/81fd4a0a05d81ac25156a6fe72ff82183e53b8aa"}},"author_association":"OWNER"}}
{"actor":{"display_login":"vbrazo"}}