{"action":"opened","number":8411,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/8411","id":228149745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTQ5NzQ1","html_url":"https://github.com/qgis/QGIS/pull/8411","diff_url":"https://github.com/qgis/QGIS/pull/8411.diff","patch_url":"https://github.com/qgis/QGIS/pull/8411.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/8411","number":8411,"state":"open","locked":false,"title":"Fix a bunch of MS SQL provider issues","user":{"login":"wonder-sk","id":193367,"node_id":"MDQ6VXNlcjE5MzM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/193367?v=4","gravatar_id":"","url":"https://api.github.com/users/wonder-sk","html_url":"https://github.com/wonder-sk","followers_url":"https://api.github.com/users/wonder-sk/followers","following_url":"https://api.github.com/users/wonder-sk/following{/other_user}","gists_url":"https://api.github.com/users/wonder-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/wonder-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonder-sk/subscriptions","organizations_url":"https://api.github.com/users/wonder-sk/orgs","repos_url":"https://api.github.com/users/wonder-sk/repos","events_url":"https://api.github.com/users/wonder-sk/events{/privacy}","received_events_url":"https://api.github.com/users/wonder-sk/received_events","type":"User","site_admin":false},"body":"Testing MS SQL Server container running on Linux, I have quickly run into a combination of bugs in MS SQL provider that made it unusable in my quick tests (import a layer, display it on the map).\r\n\r\nThe bugs fixed in this PR:\r\n- after import of a layer in QGIS, the layer does not show up in browser and in data sources dialog it shows up but can't be loaded (need explicit choice of geometry type + srid). Caused by invalid geometries (but valid according to QGIS)\r\n- after import of a layer in QGIS, when loaded it will have wrong CRS assigned\r\n- features not showing up on the map or in attribute table (low TEXTSIZE value due to old TDS version)\r\n\r\nThere are still few things that make MS SQL provider annoying, but at least I they are not complete blockers:\r\n- importing a layer with valid geometries may get MS SQL scream about invalid geometries. Not sure yet why, but at least those can be fixed with a SQL query `update [my_table] set [geom] = [geom].MakeValid() where [geom].STIsValid()=0`  ... maybe something we could have available on right-click in browser :-)\r\n- when importing layers to MS SQL, the logic for handling SRIDs is wrong. Provider uses internal SRS ID from srs.db for SRIDs and assumes if a particular SRID already exists, it is the one we need for the layer.\r\n- importing attributes with international characters fails https://issues.qgis.org/issues/20123","created_at":"2018-11-04T00:32:29Z","updated_at":"2018-11-04T00:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/8411/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/8411/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/8411/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/923adf2ff78228b31ed5042fd367d95fee2f09a2","head":{"label":"wonder-sk:slap-mssql-around-with-a-trout","ref":"slap-mssql-around-with-a-trout","sha":"923adf2ff78228b31ed5042fd367d95fee2f09a2","user":{"login":"wonder-sk","id":193367,"node_id":"MDQ6VXNlcjE5MzM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/193367?v=4","gravatar_id":"","url":"https://api.github.com/users/wonder-sk","html_url":"https://github.com/wonder-sk","followers_url":"https://api.github.com/users/wonder-sk/followers","following_url":"https://api.github.com/users/wonder-sk/following{/other_user}","gists_url":"https://api.github.com/users/wonder-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/wonder-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonder-sk/subscriptions","organizations_url":"https://api.github.com/users/wonder-sk/orgs","repos_url":"https://api.github.com/users/wonder-sk/repos","events_url":"https://api.github.com/users/wonder-sk/events{/privacy}","received_events_url":"https://api.github.com/users/wonder-sk/received_events","type":"User","site_admin":false},"repo":{"id":14973687,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3MzY4Nw==","name":"QGIS","full_name":"wonder-sk/QGIS","private":false,"owner":{"login":"wonder-sk","id":193367,"node_id":"MDQ6VXNlcjE5MzM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/193367?v=4","gravatar_id":"","url":"https://api.github.com/users/wonder-sk","html_url":"https://github.com/wonder-sk","followers_url":"https://api.github.com/users/wonder-sk/followers","following_url":"https://api.github.com/users/wonder-sk/following{/other_user}","gists_url":"https://api.github.com/users/wonder-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/wonder-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonder-sk/subscriptions","organizations_url":"https://api.github.com/users/wonder-sk/orgs","repos_url":"https://api.github.com/users/wonder-sk/repos","events_url":"https://api.github.com/users/wonder-sk/events{/privacy}","received_events_url":"https://api.github.com/users/wonder-sk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wonder-sk/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/wonder-sk/QGIS","forks_url":"https://api.github.com/repos/wonder-sk/QGIS/forks","keys_url":"https://api.github.com/repos/wonder-sk/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wonder-sk/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wonder-sk/QGIS/teams","hooks_url":"https://api.github.com/repos/wonder-sk/QGIS/hooks","issue_events_url":"https://api.github.com/repos/wonder-sk/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/wonder-sk/QGIS/events","assignees_url":"https://api.github.com/repos/wonder-sk/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/wonder-sk/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/wonder-sk/QGIS/tags","blobs_url":"https://api.github.com/repos/wonder-sk/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wonder-sk/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wonder-sk/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wonder-sk/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wonder-sk/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/wonder-sk/QGIS/languages","stargazers_url":"https://api.github.com/repos/wonder-sk/QGIS/stargazers","contributors_url":"https://api.github.com/repos/wonder-sk/QGIS/contributors","subscribers_url":"https://api.github.com/repos/wonder-sk/QGIS/subscribers","subscription_url":"https://api.github.com/repos/wonder-sk/QGIS/subscription","commits_url":"https://api.github.com/repos/wonder-sk/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wonder-sk/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wonder-sk/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wonder-sk/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wonder-sk/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/wonder-sk/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wonder-sk/QGIS/merges","archive_url":"https://api.github.com/repos/wonder-sk/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wonder-sk/QGIS/downloads","issues_url":"https://api.github.com/repos/wonder-sk/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/wonder-sk/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/wonder-sk/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/wonder-sk/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wonder-sk/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/wonder-sk/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/wonder-sk/QGIS/deployments","created_at":"2013-12-06T04:11:56Z","updated_at":"2017-07-23T20:56:56Z","pushed_at":"2018-11-04T00:12:06Z","git_url":"git://github.com/wonder-sk/QGIS.git","ssh_url":"git@github.com:wonder-sk/QGIS.git","clone_url":"https://github.com/wonder-sk/QGIS.git","svn_url":"https://github.com/wonder-sk/QGIS","homepage":"http://qgis.org","size":1385633,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"15b2352ea2532f4bc8ab99e3919e0b0cedbc2253","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","private":false,"owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-11-03T19:01:39Z","pushed_at":"2018-11-03T22:05:27Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1479748,"stargazers_count":2281,"watchers_count":2281,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1342,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1342,"open_issues":37,"watchers":2281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8411"},"html":{"href":"https://github.com/qgis/QGIS/pull/8411"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8411"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8411/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8411/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8411/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/923adf2ff78228b31ed5042fd367d95fee2f09a2"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":19,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"wonder-sk"}}