{"action":"created","comment":{"url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/comments/207835116","pull_request_review_id":143525082,"id":207835116,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgzNTExNg==","diff_hunk":"@@ -0,0 +1,1109 @@\n+[","path":"generated-sources.json","position":1,"original_position":1,"commit_id":"1ee8af18e9bf960e68582db517df2f0ad6c7459d","original_commit_id":"1ee8af18e9bf960e68582db517df2f0ad6c7459d","user":{"login":"SolarLiner","id":4302963,"node_id":"MDQ6VXNlcjQzMDI5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4302963?v=4","gravatar_id":"","url":"https://api.github.com/users/SolarLiner","html_url":"https://github.com/SolarLiner","followers_url":"https://api.github.com/users/SolarLiner/followers","following_url":"https://api.github.com/users/SolarLiner/following{/other_user}","gists_url":"https://api.github.com/users/SolarLiner/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarLiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarLiner/subscriptions","organizations_url":"https://api.github.com/users/SolarLiner/orgs","repos_url":"https://api.github.com/users/SolarLiner/repos","events_url":"https://api.github.com/users/SolarLiner/events{/privacy}","received_events_url":"https://api.github.com/users/SolarLiner/received_events","type":"User","site_admin":false},"body":"Uh, this is embarrassing. It *was* on the root folder, and overwriting it with the actual yarn generate sources shows there is no difference, which I guess is a good regression test.","created_at":"2018-08-06T09:56:44Z","updated_at":"2018-08-06T09:56:45Z","html_url":"https://github.com/flatpak/flatpak-builder-tools/pull/31#discussion_r207835116","pull_request_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/comments/207835116"},"html":{"href":"https://github.com/flatpak/flatpak-builder-tools/pull/31#discussion_r207835116"},"pull_request":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31"}},"in_reply_to_id":207749509},"pull_request":{"url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31","id":206245817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjQ1ODE3","html_url":"https://github.com/flatpak/flatpak-builder-tools/pull/31","diff_url":"https://github.com/flatpak/flatpak-builder-tools/pull/31.diff","patch_url":"https://github.com/flatpak/flatpak-builder-tools/pull/31.patch","issue_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues/31","number":31,"state":"open","locked":false,"title":"Replace list(set()) trick with actual remove_duplicates function","user":{"login":"SolarLiner","id":4302963,"node_id":"MDQ6VXNlcjQzMDI5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4302963?v=4","gravatar_id":"","url":"https://api.github.com/users/SolarLiner","html_url":"https://github.com/SolarLiner","followers_url":"https://api.github.com/users/SolarLiner/followers","following_url":"https://api.github.com/users/SolarLiner/following{/other_user}","gists_url":"https://api.github.com/users/SolarLiner/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarLiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarLiner/subscriptions","organizations_url":"https://api.github.com/users/SolarLiner/orgs","repos_url":"https://api.github.com/users/SolarLiner/repos","events_url":"https://api.github.com/users/SolarLiner/events{/privacy}","received_events_url":"https://api.github.com/users/SolarLiner/received_events","type":"User","site_admin":false},"body":"Sets only allow hashable objects, allowing for a more efficient\r\ncomparison and management of itself. Dict objects aren't\r\nhashable, therefore can't be turned into set items. We replace that\r\ntrick with an actual function that reconstructs the list but only adds\r\nitems not already present. This function uses \"obj not in list\" notation\r\nwhich uses `__eq__` and not `__hash__` interface, which `dict`\r\nimplements.\r\n\r\nIncluded is a the resulting `generated-sources`.py which show the\r\nresulting generated sources.","created_at":"2018-08-05T16:00:39Z","updated_at":"2018-08-06T09:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7213cc55e2db55a70a9c661eebf3e85d02f3eb84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31/commits","review_comments_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31/comments","review_comment_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues/31/comments","statuses_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/statuses/1ee8af18e9bf960e68582db517df2f0ad6c7459d","head":{"label":"SolarLiner:master","ref":"master","sha":"1ee8af18e9bf960e68582db517df2f0ad6c7459d","user":{"login":"SolarLiner","id":4302963,"node_id":"MDQ6VXNlcjQzMDI5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4302963?v=4","gravatar_id":"","url":"https://api.github.com/users/SolarLiner","html_url":"https://github.com/SolarLiner","followers_url":"https://api.github.com/users/SolarLiner/followers","following_url":"https://api.github.com/users/SolarLiner/following{/other_user}","gists_url":"https://api.github.com/users/SolarLiner/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarLiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarLiner/subscriptions","organizations_url":"https://api.github.com/users/SolarLiner/orgs","repos_url":"https://api.github.com/users/SolarLiner/repos","events_url":"https://api.github.com/users/SolarLiner/events{/privacy}","received_events_url":"https://api.github.com/users/SolarLiner/received_events","type":"User","site_admin":false},"repo":{"id":143625459,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MjU0NTk=","name":"flatpak-builder-tools","full_name":"SolarLiner/flatpak-builder-tools","owner":{"login":"SolarLiner","id":4302963,"node_id":"MDQ6VXNlcjQzMDI5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4302963?v=4","gravatar_id":"","url":"https://api.github.com/users/SolarLiner","html_url":"https://github.com/SolarLiner","followers_url":"https://api.github.com/users/SolarLiner/followers","following_url":"https://api.github.com/users/SolarLiner/following{/other_user}","gists_url":"https://api.github.com/users/SolarLiner/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarLiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarLiner/subscriptions","organizations_url":"https://api.github.com/users/SolarLiner/orgs","repos_url":"https://api.github.com/users/SolarLiner/repos","events_url":"https://api.github.com/users/SolarLiner/events{/privacy}","received_events_url":"https://api.github.com/users/SolarLiner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SolarLiner/flatpak-builder-tools","description":"Various helper tools for flatpak-builder","fork":true,"url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools","forks_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/forks","keys_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/teams","hooks_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/hooks","issue_events_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/issues/events{/number}","events_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/events","assignees_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/assignees{/user}","branches_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/branches{/branch}","tags_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/tags","blobs_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/languages","stargazers_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/stargazers","contributors_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/contributors","subscribers_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/subscribers","subscription_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/subscription","commits_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/contents/{+path}","compare_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/merges","archive_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/downloads","issues_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/issues{/number}","pulls_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/labels{/name}","releases_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/releases{/id}","deployments_url":"https://api.github.com/repos/SolarLiner/flatpak-builder-tools/deployments","created_at":"2018-08-05T15:35:23Z","updated_at":"2018-08-05T15:45:34Z","pushed_at":"2018-08-05T15:45:32Z","git_url":"git://github.com/SolarLiner/flatpak-builder-tools.git","ssh_url":"git@github.com:SolarLiner/flatpak-builder-tools.git","clone_url":"https://github.com/SolarLiner/flatpak-builder-tools.git","svn_url":"https://github.com/SolarLiner/flatpak-builder-tools","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flatpak:master","ref":"master","sha":"38e432dc266abcac724f682cbafb329bc57182d2","user":{"login":"flatpak","id":19473042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMDQy","avatar_url":"https://avatars0.githubusercontent.com/u/19473042?v=4","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"repo":{"id":114991815,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5OTE4MTU=","name":"flatpak-builder-tools","full_name":"flatpak/flatpak-builder-tools","owner":{"login":"flatpak","id":19473042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDczMDQy","avatar_url":"https://avatars0.githubusercontent.com/u/19473042?v=4","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flatpak/flatpak-builder-tools","description":"Various helper tools for flatpak-builder","fork":false,"url":"https://api.github.com/repos/flatpak/flatpak-builder-tools","forks_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/forks","keys_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/teams","hooks_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/hooks","issue_events_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues/events{/number}","events_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/events","assignees_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/assignees{/user}","branches_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/branches{/branch}","tags_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/tags","blobs_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/languages","stargazers_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/stargazers","contributors_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/contributors","subscribers_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/subscribers","subscription_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/subscription","commits_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/contents/{+path}","compare_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/merges","archive_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/downloads","issues_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues{/number}","pulls_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/labels{/name}","releases_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/releases{/id}","deployments_url":"https://api.github.com/repos/flatpak/flatpak-builder-tools/deployments","created_at":"2017-12-21T10:08:07Z","updated_at":"2018-08-03T21:08:21Z","pushed_at":"2018-08-05T16:00:40Z","git_url":"git://github.com/flatpak/flatpak-builder-tools.git","ssh_url":"git@github.com:flatpak/flatpak-builder-tools.git","clone_url":"https://github.com/flatpak/flatpak-builder-tools.git","svn_url":"https://github.com/flatpak/flatpak-builder-tools","homepage":null,"size":71,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":12,"open_issues":9,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31"},"html":{"href":"https://github.com/flatpak/flatpak-builder-tools/pull/31"},"issue":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues/31"},"comments":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/flatpak/flatpak-builder-tools/statuses/1ee8af18e9bf960e68582db517df2f0ad6c7459d"}},"author_association":"NONE"}}
{"actor":{"display_login":"SolarLiner"}}