{"action":"created","comment":{"url":"https://api.github.com/repos/analogdevicesinc/linux/pulls/comments/236019398","pull_request_review_id":178025532,"id":236019398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAxOTM5OA==","diff_hunk":"@@ -90,7 +92,7 @@ int iio_dmaengine_buffer_submit_block(struct iio_dma_buffer_queue *queue,\n \t\tif (!desc)\n \t\t\treturn -ENOMEM;\n \n-\t\tdesc->callback = iio_dmaengine_buffer_block_done;\n+\t\tdesc->callback_result = iio_dmaengine_buffer_block_done;","path":"drivers/iio/buffer/industrialio-buffer-dmaengine.c","position":23,"original_position":23,"commit_id":"b74d64773fce4301ed53e5a962a1fff2341b168b","original_commit_id":"b74d64773fce4301ed53e5a962a1fff2341b168b","user":{"login":"commodo","id":2766732,"node_id":"MDQ6VXNlcjI3NjY3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2766732?v=4","gravatar_id":"","url":"https://api.github.com/users/commodo","html_url":"https://github.com/commodo","followers_url":"https://api.github.com/users/commodo/followers","following_url":"https://api.github.com/users/commodo/following{/other_user}","gists_url":"https://api.github.com/users/commodo/gists{/gist_id}","starred_url":"https://api.github.com/users/commodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commodo/subscriptions","organizations_url":"https://api.github.com/users/commodo/orgs","repos_url":"https://api.github.com/users/commodo/repos","events_url":"https://api.github.com/users/commodo/events{/privacy}","received_events_url":"https://api.github.com/users/commodo/received_events","type":"User","site_admin":false},"body":"yep: the signature of `iio_dmaengine_buffer_block_done()` changes by having a new parameter being added (i.e. `result`) ; the type of `callback_result` [ which is a function pointer ] differs from the original type by that parameter","created_at":"2018-11-23T21:18:27Z","updated_at":"2018-11-23T21:18:28Z","html_url":"https://github.com/analogdevicesinc/linux/pull/258#discussion_r236019398","pull_request_url":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/analogdevicesinc/linux/pulls/comments/236019398"},"html":{"href":"https://github.com/analogdevicesinc/linux/pull/258#discussion_r236019398"},"pull_request":{"href":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258"}},"in_reply_to_id":235985773},"pull_request":{"url":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258","id":233195308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTk1MzA4","html_url":"https://github.com/analogdevicesinc/linux/pull/258","diff_url":"https://github.com/analogdevicesinc/linux/pull/258.diff","patch_url":"https://github.com/analogdevicesinc/linux/pull/258.patch","issue_url":"https://api.github.com/repos/analogdevicesinc/linux/issues/258","number":258,"state":"open","locked":false,"title":"iio: buffer-dmaengine: adjust `bytes_used` with residue info","user":{"login":"commodo","id":2766732,"node_id":"MDQ6VXNlcjI3NjY3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2766732?v=4","gravatar_id":"","url":"https://api.github.com/users/commodo","html_url":"https://github.com/commodo","followers_url":"https://api.github.com/users/commodo/followers","following_url":"https://api.github.com/users/commodo/following{/other_user}","gists_url":"https://api.github.com/users/commodo/gists{/gist_id}","starred_url":"https://api.github.com/users/commodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commodo/subscriptions","organizations_url":"https://api.github.com/users/commodo/orgs","repos_url":"https://api.github.com/users/commodo/repos","events_url":"https://api.github.com/users/commodo/events{/privacy}","received_events_url":"https://api.github.com/users/commodo/received_events","type":"User","site_admin":false},"body":"A transfer may fall shorter than the bytes in the block.\r\nThis information is available in the residue from the DMA engine, so we can\r\ncompute actual `bytes_used` with that by subtracting the residue.\r\n\r\nSigned-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>","created_at":"2018-11-23T13:04:04Z","updated_at":"2018-11-23T21:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1c906bdd54d8c71593db25a323ce868f1c1bbe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258/commits","review_comments_url":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258/comments","review_comment_url":"https://api.github.com/repos/analogdevicesinc/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/analogdevicesinc/linux/issues/258/comments","statuses_url":"https://api.github.com/repos/analogdevicesinc/linux/statuses/b74d64773fce4301ed53e5a962a1fff2341b168b","head":{"label":"analogdevicesinc:iio-dma","ref":"iio-dma","sha":"b74d64773fce4301ed53e5a962a1fff2341b168b","user":{"login":"analogdevicesinc","id":2465527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2465527?v=4","gravatar_id":"","url":"https://api.github.com/users/analogdevicesinc","html_url":"https://github.com/analogdevicesinc","followers_url":"https://api.github.com/users/analogdevicesinc/followers","following_url":"https://api.github.com/users/analogdevicesinc/following{/other_user}","gists_url":"https://api.github.com/users/analogdevicesinc/gists{/gist_id}","starred_url":"https://api.github.com/users/analogdevicesinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogdevicesinc/subscriptions","organizations_url":"https://api.github.com/users/analogdevicesinc/orgs","repos_url":"https://api.github.com/users/analogdevicesinc/repos","events_url":"https://api.github.com/users/analogdevicesinc/events{/privacy}","received_events_url":"https://api.github.com/users/analogdevicesinc/received_events","type":"Organization","site_admin":false},"repo":{"id":6124250,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI0MjUw","name":"linux","full_name":"analogdevicesinc/linux","private":false,"owner":{"login":"analogdevicesinc","id":2465527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2465527?v=4","gravatar_id":"","url":"https://api.github.com/users/analogdevicesinc","html_url":"https://github.com/analogdevicesinc","followers_url":"https://api.github.com/users/analogdevicesinc/followers","following_url":"https://api.github.com/users/analogdevicesinc/following{/other_user}","gists_url":"https://api.github.com/users/analogdevicesinc/gists{/gist_id}","starred_url":"https://api.github.com/users/analogdevicesinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogdevicesinc/subscriptions","organizations_url":"https://api.github.com/users/analogdevicesinc/orgs","repos_url":"https://api.github.com/users/analogdevicesinc/repos","events_url":"https://api.github.com/users/analogdevicesinc/events{/privacy}","received_events_url":"https://api.github.com/users/analogdevicesinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/analogdevicesinc/linux","description":"Mirror of Linus Torvald's Kernel Tree","fork":false,"url":"https://api.github.com/repos/analogdevicesinc/linux","forks_url":"https://api.github.com/repos/analogdevicesinc/linux/forks","keys_url":"https://api.github.com/repos/analogdevicesinc/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analogdevicesinc/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analogdevicesinc/linux/teams","hooks_url":"https://api.github.com/repos/analogdevicesinc/linux/hooks","issue_events_url":"https://api.github.com/repos/analogdevicesinc/linux/issues/events{/number}","events_url":"https://api.github.com/repos/analogdevicesinc/linux/events","assignees_url":"https://api.github.com/repos/analogdevicesinc/linux/assignees{/user}","branches_url":"https://api.github.com/repos/analogdevicesinc/linux/branches{/branch}","tags_url":"https://api.github.com/repos/analogdevicesinc/linux/tags","blobs_url":"https://api.github.com/repos/analogdevicesinc/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analogdevicesinc/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analogdevicesinc/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/analogdevicesinc/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analogdevicesinc/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/analogdevicesinc/linux/languages","stargazers_url":"https://api.github.com/repos/analogdevicesinc/linux/stargazers","contributors_url":"https://api.github.com/repos/analogdevicesinc/linux/contributors","subscribers_url":"https://api.github.com/repos/analogdevicesinc/linux/subscribers","subscription_url":"https://api.github.com/repos/analogdevicesinc/linux/subscription","commits_url":"https://api.github.com/repos/analogdevicesinc/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/analogdevicesinc/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/analogdevicesinc/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/analogdevicesinc/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/analogdevicesinc/linux/contents/{+path}","compare_url":"https://api.github.com/repos/analogdevicesinc/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analogdevicesinc/linux/merges","archive_url":"https://api.github.com/repos/analogdevicesinc/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analogdevicesinc/linux/downloads","issues_url":"https://api.github.com/repos/analogdevicesinc/linux/issues{/number}","pulls_url":"https://api.github.com/repos/analogdevicesinc/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/analogdevicesinc/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/analogdevicesinc/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analogdevicesinc/linux/labels{/name}","releases_url":"https://api.github.com/repos/analogdevicesinc/linux/releases{/id}","deployments_url":"https://api.github.com/repos/analogdevicesinc/linux/deployments","created_at":"2012-10-08T12:49:16Z","updated_at":"2018-11-23T07:20:50Z","pushed_at":"2018-11-23T15:53:34Z","git_url":"git://github.com/analogdevicesinc/linux.git","ssh_url":"git@github.com:analogdevicesinc/linux.git","clone_url":"https://github.com/analogdevicesinc/linux.git","svn_url":"https://github.com/analogdevicesinc/linux","homepage":"http://kernel.org/","size":1845148,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":291,"open_issues":6,"watchers":98,"default_branch":"master"}},"base":{"label":"analogdevicesinc:master","ref":"master","sha":"a9401f2674694dd3f1e7c114ca9a8b6c6ad395f6","user":{"login":"analogdevicesinc","id":2465527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2465527?v=4","gravatar_id":"","url":"https://api.github.com/users/analogdevicesinc","html_url":"https://github.com/analogdevicesinc","followers_url":"https://api.github.com/users/analogdevicesinc/followers","following_url":"https://api.github.com/users/analogdevicesinc/following{/other_user}","gists_url":"https://api.github.com/users/analogdevicesinc/gists{/gist_id}","starred_url":"https://api.github.com/users/analogdevicesinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogdevicesinc/subscriptions","organizations_url":"https://api.github.com/users/analogdevicesinc/orgs","repos_url":"https://api.github.com/users/analogdevicesinc/repos","events_url":"https://api.github.com/users/analogdevicesinc/events{/privacy}","received_events_url":"https://api.github.com/users/analogdevicesinc/received_events","type":"Organization","site_admin":false},"repo":{"id":6124250,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI0MjUw","name":"linux","full_name":"analogdevicesinc/linux","private":false,"owner":{"login":"analogdevicesinc","id":2465527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2465527?v=4","gravatar_id":"","url":"https://api.github.com/users/analogdevicesinc","html_url":"https://github.com/analogdevicesinc","followers_url":"https://api.github.com/users/analogdevicesinc/followers","following_url":"https://api.github.com/users/analogdevicesinc/following{/other_user}","gists_url":"https://api.github.com/users/analogdevicesinc/gists{/gist_id}","starred_url":"https://api.github.com/users/analogdevicesinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogdevicesinc/subscriptions","organizations_url":"https://api.github.com/users/analogdevicesinc/orgs","repos_url":"https://api.github.com/users/analogdevicesinc/repos","events_url":"https://api.github.com/users/analogdevicesinc/events{/privacy}","received_events_url":"https://api.github.com/users/analogdevicesinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/analogdevicesinc/linux","description":"Mirror of Linus Torvald's Kernel Tree","fork":false,"url":"https://api.github.com/repos/analogdevicesinc/linux","forks_url":"https://api.github.com/repos/analogdevicesinc/linux/forks","keys_url":"https://api.github.com/repos/analogdevicesinc/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analogdevicesinc/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analogdevicesinc/linux/teams","hooks_url":"https://api.github.com/repos/analogdevicesinc/linux/hooks","issue_events_url":"https://api.github.com/repos/analogdevicesinc/linux/issues/events{/number}","events_url":"https://api.github.com/repos/analogdevicesinc/linux/events","assignees_url":"https://api.github.com/repos/analogdevicesinc/linux/assignees{/user}","branches_url":"https://api.github.com/repos/analogdevicesinc/linux/branches{/branch}","tags_url":"https://api.github.com/repos/analogdevicesinc/linux/tags","blobs_url":"https://api.github.com/repos/analogdevicesinc/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analogdevicesinc/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analogdevicesinc/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/analogdevicesinc/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analogdevicesinc/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/analogdevicesinc/linux/languages","stargazers_url":"https://api.github.com/repos/analogdevicesinc/linux/stargazers","contributors_url":"https://api.github.com/repos/analogdevicesinc/linux/contributors","subscribers_url":"https://api.github.com/repos/analogdevicesinc/linux/subscribers","subscription_url":"https://api.github.com/repos/analogdevicesinc/linux/subscription","commits_url":"https://api.github.com/repos/analogdevicesinc/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/analogdevicesinc/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/analogdevicesinc/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/analogdevicesinc/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/analogdevicesinc/linux/contents/{+path}","compare_url":"https://api.github.com/repos/analogdevicesinc/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analogdevicesinc/linux/merges","archive_url":"https://api.github.com/repos/analogdevicesinc/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analogdevicesinc/linux/downloads","issues_url":"https://api.github.com/repos/analogdevicesinc/linux/issues{/number}","pulls_url":"https://api.github.com/repos/analogdevicesinc/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/analogdevicesinc/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/analogdevicesinc/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analogdevicesinc/linux/labels{/name}","releases_url":"https://api.github.com/repos/analogdevicesinc/linux/releases{/id}","deployments_url":"https://api.github.com/repos/analogdevicesinc/linux/deployments","created_at":"2012-10-08T12:49:16Z","updated_at":"2018-11-23T07:20:50Z","pushed_at":"2018-11-23T15:53:34Z","git_url":"git://github.com/analogdevicesinc/linux.git","ssh_url":"git@github.com:analogdevicesinc/linux.git","clone_url":"https://github.com/analogdevicesinc/linux.git","svn_url":"https://github.com/analogdevicesinc/linux","homepage":"http://kernel.org/","size":1845148,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":291,"open_issues":6,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258"},"html":{"href":"https://github.com/analogdevicesinc/linux/pull/258"},"issue":{"href":"https://api.github.com/repos/analogdevicesinc/linux/issues/258"},"comments":{"href":"https://api.github.com/repos/analogdevicesinc/linux/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/analogdevicesinc/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/analogdevicesinc/linux/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/analogdevicesinc/linux/statuses/b74d64773fce4301ed53e5a962a1fff2341b168b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"commodo"}}