{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/227090263","pull_request_review_id":167051817,"id":227090263,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA5MDI2Mw==","diff_hunk":"@@ -128,12 +128,18 @@ private void addAttributeValue(Metacard metacard, Map.Entry<String, Object> entr\n         entry.getKey(),\n         value);\n \n-    if (value instanceof Serializable) {\n-      metacard.setAttribute(new AttributeImpl(entry.getKey(), (Serializable) value));\n-    } else if (value instanceof List) {\n-      metacard.setAttribute(new AttributeImpl(entry.getKey(), (List<Serializable>) value));\n-    } else {\n-      LOGGER.debug(\"The value was expected to be Serializable or a list of Serializable items.\");\n+    try {\n+      if (value instanceof Serializable) {\n+        metacard.setAttribute(new AttributeImpl(entry.getKey(), (Serializable) value));\n+      } else if (value instanceof List) {\n+        metacard.setAttribute(new AttributeImpl(entry.getKey(), (List<Serializable>) value));","path":"catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/metacard/workspace/transformer/impl/WorkspaceTransformerImpl.java","position":14,"original_position":14,"commit_id":"9a7697066006e8cad2afa93ce57e73ff85061357","original_commit_id":"9a7697066006e8cad2afa93ce57e73ff85061357","user":{"login":"jrnorth","id":4495447,"node_id":"MDQ6VXNlcjQ0OTU0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4495447?v=4","gravatar_id":"","url":"https://api.github.com/users/jrnorth","html_url":"https://github.com/jrnorth","followers_url":"https://api.github.com/users/jrnorth/followers","following_url":"https://api.github.com/users/jrnorth/following{/other_user}","gists_url":"https://api.github.com/users/jrnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/jrnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrnorth/subscriptions","organizations_url":"https://api.github.com/users/jrnorth/orgs","repos_url":"https://api.github.com/users/jrnorth/repos","events_url":"https://api.github.com/users/jrnorth/events{/privacy}","received_events_url":"https://api.github.com/users/jrnorth/received_events","type":"User","site_admin":false},"body":"Seems like the scope of the try/catch could be reduced to just this line.","created_at":"2018-10-22T18:43:59Z","updated_at":"2018-10-22T18:49:02Z","html_url":"https://github.com/codice/ddf/pull/3714#discussion_r227090263","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/3714","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/227090263"},"html":{"href":"https://github.com/codice/ddf/pull/3714#discussion_r227090263"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/3714"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3714","id":214116431,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTE2NDMx","html_url":"https://github.com/codice/ddf/pull/3714","diff_url":"https://github.com/codice/ddf/pull/3714.diff","patch_url":"https://github.com/codice/ddf/pull/3714.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3714","number":3714,"state":"open","locked":false,"title":"DDF-4127 Made workspace and endpointUtil a little more forgiven when parsing attributes","user":{"login":"millerw8","id":4419422,"node_id":"MDQ6VXNlcjQ0MTk0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4419422?v=4","gravatar_id":"","url":"https://api.github.com/users/millerw8","html_url":"https://github.com/millerw8","followers_url":"https://api.github.com/users/millerw8/followers","following_url":"https://api.github.com/users/millerw8/following{/other_user}","gists_url":"https://api.github.com/users/millerw8/gists{/gist_id}","starred_url":"https://api.github.com/users/millerw8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerw8/subscriptions","organizations_url":"https://api.github.com/users/millerw8/orgs","repos_url":"https://api.github.com/users/millerw8/repos","events_url":"https://api.github.com/users/millerw8/events{/privacy}","received_events_url":"https://api.github.com/users/millerw8/received_events","type":"User","site_admin":false},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\nMakes reading dates more forgive in endpointUtils parseToDate.  Also makes it consistently return Instant.\r\n\r\nAlso catches exceptions when writing attributes in WorkspaceTransformerImpl so that it will not automatically fail to save a workspace when it has a bad attribute.\r\n\r\n#### Who is reviewing it? \r\n\r\n@Variadicism \r\n@troymohl \r\n\r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n#### Select relevant component teams: \r\nhttps://github.com/orgs/codice/teams/ui\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@andrewkfiedler\r\n@bdeining\r\n\r\n#### How should this be tested?\r\nCreate workspaces, Confirm with various queries they can be saved, modified, saved, refreshed and return again.  Also consider downstream products that may inject additional attributes into workspaces.\r\n\r\n<!--(List steps with links to updated documentation)-->\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4127](https://codice.atlassian.net/browse/DDF-4127)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [x] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-09-08T21:56:47Z","updated_at":"2018-10-22T18:49:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"025cb204a4b2b6495bb3c3afd49ad75592483d19","assignee":{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3714/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3714/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3714/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/9a7697066006e8cad2afa93ce57e73ff85061357","head":{"label":"millerw8:DDF-4127","ref":"DDF-4127","sha":"9a7697066006e8cad2afa93ce57e73ff85061357","user":{"login":"millerw8","id":4419422,"node_id":"MDQ6VXNlcjQ0MTk0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4419422?v=4","gravatar_id":"","url":"https://api.github.com/users/millerw8","html_url":"https://github.com/millerw8","followers_url":"https://api.github.com/users/millerw8/followers","following_url":"https://api.github.com/users/millerw8/following{/other_user}","gists_url":"https://api.github.com/users/millerw8/gists{/gist_id}","starred_url":"https://api.github.com/users/millerw8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerw8/subscriptions","organizations_url":"https://api.github.com/users/millerw8/orgs","repos_url":"https://api.github.com/users/millerw8/repos","events_url":"https://api.github.com/users/millerw8/events{/privacy}","received_events_url":"https://api.github.com/users/millerw8/received_events","type":"User","site_admin":false},"repo":{"id":51782531,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc4MjUzMQ==","name":"ddf","full_name":"millerw8/ddf","private":false,"owner":{"login":"millerw8","id":4419422,"node_id":"MDQ6VXNlcjQ0MTk0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4419422?v=4","gravatar_id":"","url":"https://api.github.com/users/millerw8","html_url":"https://github.com/millerw8","followers_url":"https://api.github.com/users/millerw8/followers","following_url":"https://api.github.com/users/millerw8/following{/other_user}","gists_url":"https://api.github.com/users/millerw8/gists{/gist_id}","starred_url":"https://api.github.com/users/millerw8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerw8/subscriptions","organizations_url":"https://api.github.com/users/millerw8/orgs","repos_url":"https://api.github.com/users/millerw8/repos","events_url":"https://api.github.com/users/millerw8/events{/privacy}","received_events_url":"https://api.github.com/users/millerw8/received_events","type":"User","site_admin":false},"html_url":"https://github.com/millerw8/ddf","description":"The Distributed Data Framework - Federated Open Geospatial Consortium (OGC) filter powered metadata catalog with SAML Web SSO secured container","fork":true,"url":"https://api.github.com/repos/millerw8/ddf","forks_url":"https://api.github.com/repos/millerw8/ddf/forks","keys_url":"https://api.github.com/repos/millerw8/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/millerw8/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/millerw8/ddf/teams","hooks_url":"https://api.github.com/repos/millerw8/ddf/hooks","issue_events_url":"https://api.github.com/repos/millerw8/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/millerw8/ddf/events","assignees_url":"https://api.github.com/repos/millerw8/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/millerw8/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/millerw8/ddf/tags","blobs_url":"https://api.github.com/repos/millerw8/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/millerw8/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/millerw8/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/millerw8/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/millerw8/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/millerw8/ddf/languages","stargazers_url":"https://api.github.com/repos/millerw8/ddf/stargazers","contributors_url":"https://api.github.com/repos/millerw8/ddf/contributors","subscribers_url":"https://api.github.com/repos/millerw8/ddf/subscribers","subscription_url":"https://api.github.com/repos/millerw8/ddf/subscription","commits_url":"https://api.github.com/repos/millerw8/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/millerw8/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/millerw8/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/millerw8/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/millerw8/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/millerw8/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/millerw8/ddf/merges","archive_url":"https://api.github.com/repos/millerw8/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/millerw8/ddf/downloads","issues_url":"https://api.github.com/repos/millerw8/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/millerw8/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/millerw8/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/millerw8/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/millerw8/ddf/labels{/name}","releases_url":"https://api.github.com/repos/millerw8/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/millerw8/ddf/deployments","created_at":"2016-02-15T20:15:26Z","updated_at":"2016-02-15T20:15:37Z","pushed_at":"2018-10-19T20:36:08Z","git_url":"git://github.com/millerw8/ddf.git","ssh_url":"git@github.com:millerw8/ddf.git","clone_url":"https://github.com/millerw8/ddf.git","svn_url":"https://github.com/millerw8/ddf","homepage":"","size":211206,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"a26aabb920c289c878ec53039fbc2e7b6a7ac1af","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-10-22T16:15:28Z","pushed_at":"2018-10-22T18:07:30Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":412174,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":156,"open_issues":35,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3714"},"html":{"href":"https://github.com/codice/ddf/pull/3714"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3714"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3714/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3714/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3714/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/9a7697066006e8cad2afa93ce57e73ff85061357"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrnorth"}}