{"action":"created","issue":{"url":"https://api.github.com/repos/apache/couchdb/issues/1803","repository_url":"https://api.github.com/repos/apache/couchdb","labels_url":"https://api.github.com/repos/apache/couchdb/issues/1803/labels{/name}","comments_url":"https://api.github.com/repos/apache/couchdb/issues/1803/comments","events_url":"https://api.github.com/repos/apache/couchdb/issues/1803/events","html_url":"https://github.com/apache/couchdb/pull/1803","id":389175816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjIzNzAy","number":1803,"title":"Sync admin passwords at cluster setup finish","user":{"login":"jaydoane","id":51209,"node_id":"MDQ6VXNlcjUxMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/51209?v=4","gravatar_id":"","url":"https://api.github.com/users/jaydoane","html_url":"https://github.com/jaydoane","followers_url":"https://api.github.com/users/jaydoane/followers","following_url":"https://api.github.com/users/jaydoane/following{/other_user}","gists_url":"https://api.github.com/users/jaydoane/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydoane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydoane/subscriptions","organizations_url":"https://api.github.com/users/jaydoane/orgs","repos_url":"https://api.github.com/users/jaydoane/repos","events_url":"https://api.github.com/users/jaydoane/events{/privacy}","received_events_url":"https://api.github.com/users/jaydoane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-10T07:39:08Z","updated_at":"2018-12-10T18:24:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/couchdb/pulls/1803","html_url":"https://github.com/apache/couchdb/pull/1803","diff_url":"https://github.com/apache/couchdb/pull/1803.diff","patch_url":"https://github.com/apache/couchdb/pull/1803.patch"},"body":"<!-- Thank you for your contribution!\r\n\r\n     Please file this form by replacing the Markdown comments\r\n     with your text. If a section needs no action - remove it.\r\n\r\n     Also remember, that CouchDB uses the Review-Then-Commit (RTC) model\r\n     of code collaboration. Positive feedback is represented +1 from committers\r\n     and negative is a -1. The -1 also means veto, and needs to be addressed\r\n     to proceed. Once there are no objections, the PR can be merged by a\r\n     CouchDB committer.\r\n\r\n     See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->\r\n\r\n## Overview\r\n\r\nSync admin passwords at cluster setup finish\r\n\r\nIf password salt is not configured, randomly generate one and sync it\r\nalso.\r\n\r\n<!-- Please give a short brief for the pull request,\r\n     what problem it solves or how it makes things better. -->\r\n\r\n## Testing recommendations\r\n\r\nStart dev cluster with `dev/run --admin=adm:pass` and attach to running cluster with `remsh`.\r\n\r\n1. Confirm all admin users have same hashed passwords via `rpc:multicall(config, get, [\"admins\"]).`\r\n\r\n2. Confirm salt has been synced via `rpc:multicall(config, get, [\"couch_httpd_auth\", \"salt\"]).`\r\n\r\n3. Add a new admin user via `rpc:multicall(config, set, [\"admins\", \"my-admin\", \"pass\"]).` and then confirm the hashed passwords hashed are the same on all nodes with `rpc:multicall(config, get, [\"admins\", \"my-admin\"]).`\r\n\r\n<!-- Describe how we can test your changes.\r\n     Does it provides any behaviour that the end users\r\n     could notice? -->\r\n\r\n## Related Issues or Pull Requests\r\n\r\n<!-- If your changes affects multiple components in different\r\n     repositories please put links to those issues or pull requests here.  -->\r\n\r\nFixes #1781\r\n\r\n## Checklist\r\n\r\n- [x] Code is written and works correctly;\r\n- [ ] Changes are covered by tests;\r\n- [ ] Documentation reflects the changes;\r\n"},"comment":{"url":"https://api.github.com/repos/apache/couchdb/issues/comments/445919194","html_url":"https://github.com/apache/couchdb/pull/1803#issuecomment-445919194","issue_url":"https://api.github.com/repos/apache/couchdb/issues/1803","id":445919194,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTkxOTE5NA==","user":{"login":"wohali","id":112292,"node_id":"MDQ6VXNlcjExMjI5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/112292?v=4","gravatar_id":"","url":"https://api.github.com/users/wohali","html_url":"https://github.com/wohali","followers_url":"https://api.github.com/users/wohali/followers","following_url":"https://api.github.com/users/wohali/following{/other_user}","gists_url":"https://api.github.com/users/wohali/gists{/gist_id}","starred_url":"https://api.github.com/users/wohali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wohali/subscriptions","organizations_url":"https://api.github.com/users/wohali/orgs","repos_url":"https://api.github.com/users/wohali/repos","events_url":"https://api.github.com/users/wohali/events{/privacy}","received_events_url":"https://api.github.com/users/wohali/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T18:24:26Z","updated_at":"2018-12-10T18:24:26Z","author_association":"MEMBER","body":"Hi @jaydoane ,\r\n\r\nThis doesn't fix the problems in #1781.\r\n\r\nPlease read the use cases in https://github.com/apache/couchdb/issues/1781#issuecomment-445315292 and comment (either here or there).\r\n\r\nI am also not sure you want to use the exact same salt for all newly created admins - that would reduce security, unless I'm misunderstanding the patch?"}}
{"actor":{"display_login":"wohali"}}