{"action":"closed","number":1175,"pull_request":{"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1175","id":212950435,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTUwNDM1","html_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1175","diff_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1175.diff","patch_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1175.patch","issue_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1175","number":1175,"state":"closed","locked":false,"title":"Fix Unit tests in relying on language","user":{"login":"Amstutz","id":1866896,"node_id":"MDQ6VXNlcjE4NjY4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1866896?v=4","gravatar_id":"","url":"https://api.github.com/users/Amstutz","html_url":"https://github.com/Amstutz","followers_url":"https://api.github.com/users/Amstutz/followers","following_url":"https://api.github.com/users/Amstutz/following{/other_user}","gists_url":"https://api.github.com/users/Amstutz/gists{/gist_id}","starred_url":"https://api.github.com/users/Amstutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amstutz/subscriptions","organizations_url":"https://api.github.com/users/Amstutz/orgs","repos_url":"https://api.github.com/users/Amstutz/repos","events_url":"https://api.github.com/users/Amstutz/events{/privacy}","received_events_url":"https://api.github.com/users/Amstutz/received_events","type":"User","site_admin":false},"body":"Hi @fneumann \r\n\r\nCurrently the UI tests fail due to the following commit: \"Fix \"WholeIliasCodebaseExceptInitialisation cannot depend on GlobalsExceptDIC \" violations\". I did not check what else will fail as well. This PR resolves the issue for the UI tests. Thx for merging quickly or resolving otherwise.","created_at":"2018-09-04T11:56:27Z","updated_at":"2018-09-04T13:49:00Z","closed_at":"2018-09-04T13:49:00Z","merged_at":null,"merge_commit_sha":"bce753de9b3707e8045c2acbb0d38eac97fcc7be","assignee":{"login":"fneumann","id":7509046,"node_id":"MDQ6VXNlcjc1MDkwNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7509046?v=4","gravatar_id":"","url":"https://api.github.com/users/fneumann","html_url":"https://github.com/fneumann","followers_url":"https://api.github.com/users/fneumann/followers","following_url":"https://api.github.com/users/fneumann/following{/other_user}","gists_url":"https://api.github.com/users/fneumann/gists{/gist_id}","starred_url":"https://api.github.com/users/fneumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneumann/subscriptions","organizations_url":"https://api.github.com/users/fneumann/orgs","repos_url":"https://api.github.com/users/fneumann/repos","events_url":"https://api.github.com/users/fneumann/events{/privacy}","received_events_url":"https://api.github.com/users/fneumann/received_events","type":"User","site_admin":false},"assignees":[{"login":"fneumann","id":7509046,"node_id":"MDQ6VXNlcjc1MDkwNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7509046?v=4","gravatar_id":"","url":"https://api.github.com/users/fneumann","html_url":"https://github.com/fneumann","followers_url":"https://api.github.com/users/fneumann/followers","following_url":"https://api.github.com/users/fneumann/following{/other_user}","gists_url":"https://api.github.com/users/fneumann/gists{/gist_id}","starred_url":"https://api.github.com/users/fneumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneumann/subscriptions","organizations_url":"https://api.github.com/users/fneumann/orgs","repos_url":"https://api.github.com/users/fneumann/repos","events_url":"https://api.github.com/users/fneumann/events{/privacy}","received_events_url":"https://api.github.com/users/fneumann/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fneumann","id":7509046,"node_id":"MDQ6VXNlcjc1MDkwNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7509046?v=4","gravatar_id":"","url":"https://api.github.com/users/fneumann","html_url":"https://github.com/fneumann","followers_url":"https://api.github.com/users/fneumann/followers","following_url":"https://api.github.com/users/fneumann/following{/other_user}","gists_url":"https://api.github.com/users/fneumann/gists{/gist_id}","starred_url":"https://api.github.com/users/fneumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fneumann/subscriptions","organizations_url":"https://api.github.com/users/fneumann/orgs","repos_url":"https://api.github.com/users/fneumann/repos","events_url":"https://api.github.com/users/fneumann/events{/privacy}","received_events_url":"https://api.github.com/users/fneumann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":546850796,"node_id":"MDU6TGFiZWw1NDY4NTA3OTY=","url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/labels/improvement","name":"improvement","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1175/commits","review_comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1175/comments","review_comment_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1175/comments","statuses_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/statuses/46d2b32e132bd9172f35a01520de8ad97a25ecea","head":{"label":"Amstutz:Fix_Language_Test","ref":"Fix_Language_Test","sha":"46d2b32e132bd9172f35a01520de8ad97a25ecea","user":{"login":"Amstutz","id":1866896,"node_id":"MDQ6VXNlcjE4NjY4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1866896?v=4","gravatar_id":"","url":"https://api.github.com/users/Amstutz","html_url":"https://github.com/Amstutz","followers_url":"https://api.github.com/users/Amstutz/followers","following_url":"https://api.github.com/users/Amstutz/following{/other_user}","gists_url":"https://api.github.com/users/Amstutz/gists{/gist_id}","starred_url":"https://api.github.com/users/Amstutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amstutz/subscriptions","organizations_url":"https://api.github.com/users/Amstutz/orgs","repos_url":"https://api.github.com/users/Amstutz/repos","events_url":"https://api.github.com/users/Amstutz/events{/privacy}","received_events_url":"https://api.github.com/users/Amstutz/received_events","type":"User","site_admin":false},"repo":{"id":88879504,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg3OTUwNA==","name":"ILIAS","full_name":"Amstutz/ILIAS","owner":{"login":"Amstutz","id":1866896,"node_id":"MDQ6VXNlcjE4NjY4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1866896?v=4","gravatar_id":"","url":"https://api.github.com/users/Amstutz","html_url":"https://github.com/Amstutz","followers_url":"https://api.github.com/users/Amstutz/followers","following_url":"https://api.github.com/users/Amstutz/following{/other_user}","gists_url":"https://api.github.com/users/Amstutz/gists{/gist_id}","starred_url":"https://api.github.com/users/Amstutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amstutz/subscriptions","organizations_url":"https://api.github.com/users/Amstutz/orgs","repos_url":"https://api.github.com/users/Amstutz/repos","events_url":"https://api.github.com/users/Amstutz/events{/privacy}","received_events_url":"https://api.github.com/users/Amstutz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Amstutz/ILIAS","description":"GitHub repository for official ILIAS release branches and development branches (trunk)","fork":true,"url":"https://api.github.com/repos/Amstutz/ILIAS","forks_url":"https://api.github.com/repos/Amstutz/ILIAS/forks","keys_url":"https://api.github.com/repos/Amstutz/ILIAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amstutz/ILIAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amstutz/ILIAS/teams","hooks_url":"https://api.github.com/repos/Amstutz/ILIAS/hooks","issue_events_url":"https://api.github.com/repos/Amstutz/ILIAS/issues/events{/number}","events_url":"https://api.github.com/repos/Amstutz/ILIAS/events","assignees_url":"https://api.github.com/repos/Amstutz/ILIAS/assignees{/user}","branches_url":"https://api.github.com/repos/Amstutz/ILIAS/branches{/branch}","tags_url":"https://api.github.com/repos/Amstutz/ILIAS/tags","blobs_url":"https://api.github.com/repos/Amstutz/ILIAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amstutz/ILIAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amstutz/ILIAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amstutz/ILIAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amstutz/ILIAS/statuses/{sha}","languages_url":"https://api.github.com/repos/Amstutz/ILIAS/languages","stargazers_url":"https://api.github.com/repos/Amstutz/ILIAS/stargazers","contributors_url":"https://api.github.com/repos/Amstutz/ILIAS/contributors","subscribers_url":"https://api.github.com/repos/Amstutz/ILIAS/subscribers","subscription_url":"https://api.github.com/repos/Amstutz/ILIAS/subscription","commits_url":"https://api.github.com/repos/Amstutz/ILIAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amstutz/ILIAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amstutz/ILIAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amstutz/ILIAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amstutz/ILIAS/contents/{+path}","compare_url":"https://api.github.com/repos/Amstutz/ILIAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amstutz/ILIAS/merges","archive_url":"https://api.github.com/repos/Amstutz/ILIAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amstutz/ILIAS/downloads","issues_url":"https://api.github.com/repos/Amstutz/ILIAS/issues{/number}","pulls_url":"https://api.github.com/repos/Amstutz/ILIAS/pulls{/number}","milestones_url":"https://api.github.com/repos/Amstutz/ILIAS/milestones{/number}","notifications_url":"https://api.github.com/repos/Amstutz/ILIAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amstutz/ILIAS/labels{/name}","releases_url":"https://api.github.com/repos/Amstutz/ILIAS/releases{/id}","deployments_url":"https://api.github.com/repos/Amstutz/ILIAS/deployments","created_at":"2017-04-20T15:09:54Z","updated_at":"2017-04-20T15:10:25Z","pushed_at":"2018-09-04T12:23:10Z","git_url":"git://github.com/Amstutz/ILIAS.git","ssh_url":"git@github.com:Amstutz/ILIAS.git","clone_url":"https://github.com/Amstutz/ILIAS.git","svn_url":"https://github.com/Amstutz/ILIAS","homepage":"http://www.ilias.de/docu/goto_docu_cat_582.html","size":885045,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"release_5-2"}},"base":{"label":"ILIAS-eLearning:trunk","ref":"trunk","sha":"f706df70bcc5f9f4f88b458eba9197ed5ccefcf5","user":{"login":"ILIAS-eLearning","id":8789134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODkxMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8789134?v=4","gravatar_id":"","url":"https://api.github.com/users/ILIAS-eLearning","html_url":"https://github.com/ILIAS-eLearning","followers_url":"https://api.github.com/users/ILIAS-eLearning/followers","following_url":"https://api.github.com/users/ILIAS-eLearning/following{/other_user}","gists_url":"https://api.github.com/users/ILIAS-eLearning/gists{/gist_id}","starred_url":"https://api.github.com/users/ILIAS-eLearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ILIAS-eLearning/subscriptions","organizations_url":"https://api.github.com/users/ILIAS-eLearning/orgs","repos_url":"https://api.github.com/users/ILIAS-eLearning/repos","events_url":"https://api.github.com/users/ILIAS-eLearning/events{/privacy}","received_events_url":"https://api.github.com/users/ILIAS-eLearning/received_events","type":"Organization","site_admin":false},"repo":{"id":30634542,"node_id":"MDEwOlJlcG9zaXRvcnkzMDYzNDU0Mg==","name":"ILIAS","full_name":"ILIAS-eLearning/ILIAS","owner":{"login":"ILIAS-eLearning","id":8789134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODkxMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8789134?v=4","gravatar_id":"","url":"https://api.github.com/users/ILIAS-eLearning","html_url":"https://github.com/ILIAS-eLearning","followers_url":"https://api.github.com/users/ILIAS-eLearning/followers","following_url":"https://api.github.com/users/ILIAS-eLearning/following{/other_user}","gists_url":"https://api.github.com/users/ILIAS-eLearning/gists{/gist_id}","starred_url":"https://api.github.com/users/ILIAS-eLearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ILIAS-eLearning/subscriptions","organizations_url":"https://api.github.com/users/ILIAS-eLearning/orgs","repos_url":"https://api.github.com/users/ILIAS-eLearning/repos","events_url":"https://api.github.com/users/ILIAS-eLearning/events{/privacy}","received_events_url":"https://api.github.com/users/ILIAS-eLearning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ILIAS-eLearning/ILIAS","description":"GitHub repository for official ILIAS release branches and development branches (trunk)","fork":false,"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS","forks_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/forks","keys_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/teams","hooks_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/hooks","issue_events_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/events{/number}","events_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/events","assignees_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/assignees{/user}","branches_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/branches{/branch}","tags_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/tags","blobs_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/statuses/{sha}","languages_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/languages","stargazers_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/stargazers","contributors_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/contributors","subscribers_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/subscribers","subscription_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/subscription","commits_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/contents/{+path}","compare_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/merges","archive_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/downloads","issues_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues{/number}","pulls_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls{/number}","milestones_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/milestones{/number}","notifications_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/labels{/name}","releases_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/releases{/id}","deployments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/deployments","created_at":"2015-02-11T06:44:39Z","updated_at":"2018-09-02T23:42:06Z","pushed_at":"2018-09-04T13:43:00Z","git_url":"git://github.com/ILIAS-eLearning/ILIAS.git","ssh_url":"git@github.com:ILIAS-eLearning/ILIAS.git","clone_url":"https://github.com/ILIAS-eLearning/ILIAS.git","svn_url":"https://github.com/ILIAS-eLearning/ILIAS","homepage":"http://www.ilias.de/docu/goto_docu_cat_582.html","size":890539,"stargazers_count":117,"watchers_count":117,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":142,"open_issues":53,"watchers":117,"default_branch":"release_5-3"}},"_links":{"self":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1175"},"html":{"href":"https://github.com/ILIAS-eLearning/ILIAS/pull/1175"},"issue":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1175"},"comments":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1175/comments"},"review_comments":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1175/comments"},"review_comment":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1175/commits"},"statuses":{"href":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/statuses/46d2b32e132bd9172f35a01520de8ad97a25ecea"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Amstutz"}}