{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/241214041","pull_request_review_id":184431599,"id":241214041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTIxNDA0MQ==","diff_hunk":"@@ -138,6 +138,16 @@ export class HistoryCommandListener implements IDataScienceCommandListener {\n                             await this.fileSystem.writeFile(uri.fsPath, JSON.stringify(notebook));\r\n                         }\r\n                     }, localize.DataScience.exportingFormat(), file);\r\n+\r\n+                    // When all done, show a notice that it completed.\r\n+                    const openQuestion = localize.DataScience.exportOpenQuestion();\r\n+                    this.applicationShell.showInformationMessage(localize.DataScience.exportDialogComplete().format(uri.fsPath), openQuestion).then((str: string | undefined) => {\r\n+                        if (str === openQuestion && uri.fsPath) {\r","path":"src/client/datascience/historycommandlistener.ts","position":8,"original_position":8,"commit_id":"fe6551d25072eee9eb83868d84c4031d67bef013","original_commit_id":"fe6551d25072eee9eb83868d84c4031d67bef013","user":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"body":"What's the point of displaying the message in the first place if `uri.fsPath` is `undefined`?","created_at":"2018-12-12T22:47:45Z","updated_at":"2018-12-12T22:51:12Z","html_url":"https://github.com/Microsoft/vscode-python/pull/3666#discussion_r241214041","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments/241214041"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/3666#discussion_r241214041"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666","id":238193585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTkzNTg1","html_url":"https://github.com/Microsoft/vscode-python/pull/3666","diff_url":"https://github.com/Microsoft/vscode-python/pull/3666.diff","patch_url":"https://github.com/Microsoft/vscode-python/pull/3666.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/3666","number":3666,"state":"open","locked":false,"title":"Make sure exporting a plain file also asks to open a browser","user":{"login":"rchiodo","id":19672699,"node_id":"MDQ6VXNlcjE5NjcyNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19672699?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiodo","html_url":"https://github.com/rchiodo","followers_url":"https://api.github.com/users/rchiodo/followers","following_url":"https://api.github.com/users/rchiodo/following{/other_user}","gists_url":"https://api.github.com/users/rchiodo/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiodo/subscriptions","organizations_url":"https://api.github.com/users/rchiodo/orgs","repos_url":"https://api.github.com/users/rchiodo/repos","events_url":"https://api.github.com/users/rchiodo/events{/privacy}","received_events_url":"https://api.github.com/users/rchiodo/received_events","type":"User","site_admin":false},"body":"<!--\r\n  If an item below does not apply to you, then go ahead and check it off as \"done\" and strikethrough the text, e.g.:\r\n    - [x] ~Has unit tests & system/integration tests~\r\n-->\r\n- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)\r\n- [x] Title summarizes what is changing\r\n- [ ] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)\r\n- [ ] Unit tests & system/integration tests are added/updated\r\n- [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate\r\n- [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)\r\n","created_at":"2018-12-12T21:49:01Z","updated_at":"2018-12-12T22:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b0033b7d4fcafba689935f3a115d103c46a9eb7","assignee":{"login":"rchiodo","id":19672699,"node_id":"MDQ6VXNlcjE5NjcyNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19672699?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiodo","html_url":"https://github.com/rchiodo","followers_url":"https://api.github.com/users/rchiodo/followers","following_url":"https://api.github.com/users/rchiodo/following{/other_user}","gists_url":"https://api.github.com/users/rchiodo/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiodo/subscriptions","organizations_url":"https://api.github.com/users/rchiodo/orgs","repos_url":"https://api.github.com/users/rchiodo/repos","events_url":"https://api.github.com/users/rchiodo/events{/privacy}","received_events_url":"https://api.github.com/users/rchiodo/received_events","type":"User","site_admin":false},"assignees":[{"login":"rchiodo","id":19672699,"node_id":"MDQ6VXNlcjE5NjcyNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19672699?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiodo","html_url":"https://github.com/rchiodo","followers_url":"https://api.github.com/users/rchiodo/followers","following_url":"https://api.github.com/users/rchiodo/following{/other_user}","gists_url":"https://api.github.com/users/rchiodo/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiodo/subscriptions","organizations_url":"https://api.github.com/users/rchiodo/orgs","repos_url":"https://api.github.com/users/rchiodo/repos","events_url":"https://api.github.com/users/rchiodo/events{/privacy}","received_events_url":"https://api.github.com/users/rchiodo/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"IanMatthewHuff","id":812783,"node_id":"MDQ6VXNlcjgxMjc4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/812783?v=4","gravatar_id":"","url":"https://api.github.com/users/IanMatthewHuff","html_url":"https://github.com/IanMatthewHuff","followers_url":"https://api.github.com/users/IanMatthewHuff/followers","following_url":"https://api.github.com/users/IanMatthewHuff/following{/other_user}","gists_url":"https://api.github.com/users/IanMatthewHuff/gists{/gist_id}","starred_url":"https://api.github.com/users/IanMatthewHuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanMatthewHuff/subscriptions","organizations_url":"https://api.github.com/users/IanMatthewHuff/orgs","repos_url":"https://api.github.com/users/IanMatthewHuff/repos","events_url":"https://api.github.com/users/IanMatthewHuff/events{/privacy}","received_events_url":"https://api.github.com/users/IanMatthewHuff/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/3666/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/fe6551d25072eee9eb83868d84c4031d67bef013","head":{"label":"Microsoft:rchiodo/export_open_browser","ref":"rchiodo/export_open_browser","sha":"fe6551d25072eee9eb83868d84c4031d67bef013","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"Microsoft/vscode-python","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/Microsoft/vscode-python","forks_url":"https://api.github.com/repos/Microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2018-12-12T22:05:41Z","pushed_at":"2018-12-12T22:21:42Z","git_url":"git://github.com/Microsoft/vscode-python.git","ssh_url":"git@github.com:Microsoft/vscode-python.git","clone_url":"https://github.com/Microsoft/vscode-python.git","svn_url":"https://github.com/Microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":61184,"stargazers_count":1012,"watchers_count":1012,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":581,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":204,"open_issues":581,"watchers":1012,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1d292d8c06fac4fd78dee7b7bce27b2d0cb3906c","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"Microsoft/vscode-python","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/Microsoft/vscode-python","forks_url":"https://api.github.com/repos/Microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2018-12-12T22:05:41Z","pushed_at":"2018-12-12T22:21:42Z","git_url":"git://github.com/Microsoft/vscode-python.git","ssh_url":"git@github.com:Microsoft/vscode-python.git","clone_url":"https://github.com/Microsoft/vscode-python.git","svn_url":"https://github.com/Microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":61184,"stargazers_count":1012,"watchers_count":1012,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":581,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":204,"open_issues":581,"watchers":1012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666"},"html":{"href":"https://github.com/Microsoft/vscode-python/pull/3666"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/3666"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/issues/3666/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-python/pulls/3666/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-python/statuses/fe6551d25072eee9eb83868d84c4031d67bef013"}},"author_association":"NONE"}}
{"actor":{"display_login":"DonJayamanne"}}