{"action":"created","comment":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments/234501752","pull_request_review_id":176152072,"id":234501752,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDUwMTc1Mg==","diff_hunk":"@@ -1,44 +1,39 @@\n package main\n \n import (\n-\t\"io/ioutil\"\n-\t\"path\"\n+\t\"log\"\n \t\"testing\"\n \n-\t\"github.com/go-yaml/yaml\"\n \t\"github.com/prysmaticlabs/prysm/beacon-chain/chaintest/backend\"\n )\n \n-func TestYamls(t *testing.T) {\n-\tsb, err := backend.NewSimulatedBackend()\n-\tif err != nil {\n-\t\tt.Fatalf(\"Could not create backend: %v\", err)\n+// TestReadTestsFromYaml tests constructing test cases from yaml file\n+func TestReadTestsFromYaml(t *testing.T) {\n+\tif _, err := readTestsFromYaml(string(\"./tests\")); err != nil {\n+\t\tt.Fatalf(\"Failed to read yaml files\")","path":"beacon-chain/chaintest/yaml_test.go","position":20,"original_position":20,"commit_id":"712004508ff61f6644d9a5bb393bb9bd074b232f","original_commit_id":"712004508ff61f6644d9a5bb393bb9bd074b232f","user":{"login":"rauljordan","id":5572669,"node_id":"MDQ6VXNlcjU1NzI2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/5572669?v=4","gravatar_id":"","url":"https://api.github.com/users/rauljordan","html_url":"https://github.com/rauljordan","followers_url":"https://api.github.com/users/rauljordan/followers","following_url":"https://api.github.com/users/rauljordan/following{/other_user}","gists_url":"https://api.github.com/users/rauljordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rauljordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauljordan/subscriptions","organizations_url":"https://api.github.com/users/rauljordan/orgs","repos_url":"https://api.github.com/users/rauljordan/repos","events_url":"https://api.github.com/users/rauljordan/events{/privacy}","received_events_url":"https://api.github.com/users/rauljordan/received_events","type":"User","site_admin":false},"body":"make sure to add the err to the fatalf call","created_at":"2018-11-19T06:06:58Z","updated_at":"2018-11-19T06:08:29Z","html_url":"https://github.com/prysmaticlabs/prysm/pull/815#discussion_r234501752","pull_request_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments/234501752"},"html":{"href":"https://github.com/prysmaticlabs/prysm/pull/815#discussion_r234501752"},"pull_request":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815"}}},"pull_request":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815","id":231722848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzIyODQ4","html_url":"https://github.com/prysmaticlabs/prysm/pull/815","diff_url":"https://github.com/prysmaticlabs/prysm/pull/815.diff","patch_url":"https://github.com/prysmaticlabs/prysm/pull/815.patch","issue_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/815","number":815,"state":"open","locked":false,"title":"Implement yaml based shuffle test","user":{"login":"houjieth","id":1228840,"node_id":"MDQ6VXNlcjEyMjg4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1228840?v=4","gravatar_id":"","url":"https://api.github.com/users/houjieth","html_url":"https://github.com/houjieth","followers_url":"https://api.github.com/users/houjieth/followers","following_url":"https://api.github.com/users/houjieth/following{/other_user}","gists_url":"https://api.github.com/users/houjieth/gists{/gist_id}","starred_url":"https://api.github.com/users/houjieth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houjieth/subscriptions","organizations_url":"https://api.github.com/users/houjieth/orgs","repos_url":"https://api.github.com/users/houjieth/repos","events_url":"https://api.github.com/users/houjieth/events{/privacy}","received_events_url":"https://api.github.com/users/houjieth/received_events","type":"User","site_admin":false},"body":"This resolves #738 \r\n\r\n---\r\n\r\n# Description\r\n\r\nAdded validator shuffle tests based Raul's prior work on yaml-based test case specifications.\r\n","created_at":"2018-11-17T11:34:47Z","updated_at":"2018-11-19T06:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdeede3ca797480b337c29c2e62f8c2db2484aa4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1039139798,"node_id":"MDU6TGFiZWwxMDM5MTM5Nzk4","url":"https://api.github.com/repos/prysmaticlabs/prysm/labels/Ready%20For%20Review","name":"Ready For Review","color":"f4ad6b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815/commits","review_comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815/comments","review_comment_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/815/comments","statuses_url":"https://api.github.com/repos/prysmaticlabs/prysm/statuses/712004508ff61f6644d9a5bb393bb9bd074b232f","head":{"label":"houjieth:yaml_shuffle_test","ref":"yaml_shuffle_test","sha":"712004508ff61f6644d9a5bb393bb9bd074b232f","user":{"login":"houjieth","id":1228840,"node_id":"MDQ6VXNlcjEyMjg4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1228840?v=4","gravatar_id":"","url":"https://api.github.com/users/houjieth","html_url":"https://github.com/houjieth","followers_url":"https://api.github.com/users/houjieth/followers","following_url":"https://api.github.com/users/houjieth/following{/other_user}","gists_url":"https://api.github.com/users/houjieth/gists{/gist_id}","starred_url":"https://api.github.com/users/houjieth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houjieth/subscriptions","organizations_url":"https://api.github.com/users/houjieth/orgs","repos_url":"https://api.github.com/users/houjieth/repos","events_url":"https://api.github.com/users/houjieth/events{/privacy}","received_events_url":"https://api.github.com/users/houjieth/received_events","type":"User","site_admin":false},"repo":{"id":145103317,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxMDMzMTc=","name":"prysm","full_name":"houjieth/prysm","private":false,"owner":{"login":"houjieth","id":1228840,"node_id":"MDQ6VXNlcjEyMjg4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1228840?v=4","gravatar_id":"","url":"https://api.github.com/users/houjieth","html_url":"https://github.com/houjieth","followers_url":"https://api.github.com/users/houjieth/followers","following_url":"https://api.github.com/users/houjieth/following{/other_user}","gists_url":"https://api.github.com/users/houjieth/gists{/gist_id}","starred_url":"https://api.github.com/users/houjieth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houjieth/subscriptions","organizations_url":"https://api.github.com/users/houjieth/orgs","repos_url":"https://api.github.com/users/houjieth/repos","events_url":"https://api.github.com/users/houjieth/events{/privacy}","received_events_url":"https://api.github.com/users/houjieth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/houjieth/prysm","description":"Go implementation of Ethereum 2.0 - casper & sharding","fork":true,"url":"https://api.github.com/repos/houjieth/prysm","forks_url":"https://api.github.com/repos/houjieth/prysm/forks","keys_url":"https://api.github.com/repos/houjieth/prysm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/houjieth/prysm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/houjieth/prysm/teams","hooks_url":"https://api.github.com/repos/houjieth/prysm/hooks","issue_events_url":"https://api.github.com/repos/houjieth/prysm/issues/events{/number}","events_url":"https://api.github.com/repos/houjieth/prysm/events","assignees_url":"https://api.github.com/repos/houjieth/prysm/assignees{/user}","branches_url":"https://api.github.com/repos/houjieth/prysm/branches{/branch}","tags_url":"https://api.github.com/repos/houjieth/prysm/tags","blobs_url":"https://api.github.com/repos/houjieth/prysm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/houjieth/prysm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/houjieth/prysm/git/refs{/sha}","trees_url":"https://api.github.com/repos/houjieth/prysm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/houjieth/prysm/statuses/{sha}","languages_url":"https://api.github.com/repos/houjieth/prysm/languages","stargazers_url":"https://api.github.com/repos/houjieth/prysm/stargazers","contributors_url":"https://api.github.com/repos/houjieth/prysm/contributors","subscribers_url":"https://api.github.com/repos/houjieth/prysm/subscribers","subscription_url":"https://api.github.com/repos/houjieth/prysm/subscription","commits_url":"https://api.github.com/repos/houjieth/prysm/commits{/sha}","git_commits_url":"https://api.github.com/repos/houjieth/prysm/git/commits{/sha}","comments_url":"https://api.github.com/repos/houjieth/prysm/comments{/number}","issue_comment_url":"https://api.github.com/repos/houjieth/prysm/issues/comments{/number}","contents_url":"https://api.github.com/repos/houjieth/prysm/contents/{+path}","compare_url":"https://api.github.com/repos/houjieth/prysm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/houjieth/prysm/merges","archive_url":"https://api.github.com/repos/houjieth/prysm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/houjieth/prysm/downloads","issues_url":"https://api.github.com/repos/houjieth/prysm/issues{/number}","pulls_url":"https://api.github.com/repos/houjieth/prysm/pulls{/number}","milestones_url":"https://api.github.com/repos/houjieth/prysm/milestones{/number}","notifications_url":"https://api.github.com/repos/houjieth/prysm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/houjieth/prysm/labels{/name}","releases_url":"https://api.github.com/repos/houjieth/prysm/releases{/id}","deployments_url":"https://api.github.com/repos/houjieth/prysm/deployments","created_at":"2018-08-17T09:49:53Z","updated_at":"2018-11-10T06:18:53Z","pushed_at":"2018-11-19T05:24:51Z","git_url":"git://github.com/houjieth/prysm.git","ssh_url":"git@github.com:houjieth/prysm.git","clone_url":"https://github.com/houjieth/prysm.git","svn_url":"https://github.com/houjieth/prysm","homepage":"https://prysmaticlabs.com/","size":84663,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prysmaticlabs:master","ref":"master","sha":"f46ee335bdb587dd3cafbb3d83d3e983154b34b5","user":{"login":"prysmaticlabs","id":35349758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQ5NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/35349758?v=4","gravatar_id":"","url":"https://api.github.com/users/prysmaticlabs","html_url":"https://github.com/prysmaticlabs","followers_url":"https://api.github.com/users/prysmaticlabs/followers","following_url":"https://api.github.com/users/prysmaticlabs/following{/other_user}","gists_url":"https://api.github.com/users/prysmaticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prysmaticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prysmaticlabs/subscriptions","organizations_url":"https://api.github.com/users/prysmaticlabs/orgs","repos_url":"https://api.github.com/users/prysmaticlabs/repos","events_url":"https://api.github.com/users/prysmaticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/prysmaticlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":117156031,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNTYwMzE=","name":"prysm","full_name":"prysmaticlabs/prysm","private":false,"owner":{"login":"prysmaticlabs","id":35349758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQ5NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/35349758?v=4","gravatar_id":"","url":"https://api.github.com/users/prysmaticlabs","html_url":"https://github.com/prysmaticlabs","followers_url":"https://api.github.com/users/prysmaticlabs/followers","following_url":"https://api.github.com/users/prysmaticlabs/following{/other_user}","gists_url":"https://api.github.com/users/prysmaticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prysmaticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prysmaticlabs/subscriptions","organizations_url":"https://api.github.com/users/prysmaticlabs/orgs","repos_url":"https://api.github.com/users/prysmaticlabs/repos","events_url":"https://api.github.com/users/prysmaticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/prysmaticlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prysmaticlabs/prysm","description":"Go implementation of Ethereum 2.0 - casper & sharding","fork":false,"url":"https://api.github.com/repos/prysmaticlabs/prysm","forks_url":"https://api.github.com/repos/prysmaticlabs/prysm/forks","keys_url":"https://api.github.com/repos/prysmaticlabs/prysm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prysmaticlabs/prysm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prysmaticlabs/prysm/teams","hooks_url":"https://api.github.com/repos/prysmaticlabs/prysm/hooks","issue_events_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/events{/number}","events_url":"https://api.github.com/repos/prysmaticlabs/prysm/events","assignees_url":"https://api.github.com/repos/prysmaticlabs/prysm/assignees{/user}","branches_url":"https://api.github.com/repos/prysmaticlabs/prysm/branches{/branch}","tags_url":"https://api.github.com/repos/prysmaticlabs/prysm/tags","blobs_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/refs{/sha}","trees_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prysmaticlabs/prysm/statuses/{sha}","languages_url":"https://api.github.com/repos/prysmaticlabs/prysm/languages","stargazers_url":"https://api.github.com/repos/prysmaticlabs/prysm/stargazers","contributors_url":"https://api.github.com/repos/prysmaticlabs/prysm/contributors","subscribers_url":"https://api.github.com/repos/prysmaticlabs/prysm/subscribers","subscription_url":"https://api.github.com/repos/prysmaticlabs/prysm/subscription","commits_url":"https://api.github.com/repos/prysmaticlabs/prysm/commits{/sha}","git_commits_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/commits{/sha}","comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/comments{/number}","issue_comment_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/comments{/number}","contents_url":"https://api.github.com/repos/prysmaticlabs/prysm/contents/{+path}","compare_url":"https://api.github.com/repos/prysmaticlabs/prysm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prysmaticlabs/prysm/merges","archive_url":"https://api.github.com/repos/prysmaticlabs/prysm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prysmaticlabs/prysm/downloads","issues_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues{/number}","pulls_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls{/number}","milestones_url":"https://api.github.com/repos/prysmaticlabs/prysm/milestones{/number}","notifications_url":"https://api.github.com/repos/prysmaticlabs/prysm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prysmaticlabs/prysm/labels{/name}","releases_url":"https://api.github.com/repos/prysmaticlabs/prysm/releases{/id}","deployments_url":"https://api.github.com/repos/prysmaticlabs/prysm/deployments","created_at":"2018-01-11T21:31:33Z","updated_at":"2018-11-19T01:59:15Z","pushed_at":"2018-11-19T05:50:51Z","git_url":"git://github.com/prysmaticlabs/prysm.git","ssh_url":"git@github.com:prysmaticlabs/prysm.git","clone_url":"https://github.com/prysmaticlabs/prysm.git","svn_url":"https://github.com/prysmaticlabs/prysm","homepage":"https://prysmaticlabs.com/","size":84856,"stargazers_count":386,"watchers_count":386,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":80,"open_issues":56,"watchers":386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815"},"html":{"href":"https://github.com/prysmaticlabs/prysm/pull/815"},"issue":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/issues/815"},"comments":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/issues/815/comments"},"review_comments":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815/comments"},"review_comment":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/815/commits"},"statuses":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/statuses/712004508ff61f6644d9a5bb393bb9bd074b232f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rauljordan"}}