{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/170818498","pull_request_review_id":99561803,"id":170818498,"diff_hunk":"@@ -0,0 +1,17 @@\n+#!/usr/bin/pwsh\n+#\n+# Simple helper script to get a localhost dcos-image development environment up\n+# and running with clone of pkgpanda.\n+#\n+# Expects that it is being run inside of a virtual environment.\n+#\n+\n+if (!$env:VIRTUAL_ENV) {\n+   $env:VIRTUAL_ENV = \"Must be run in a python virtual environment\"","path":"prep_local_windows.ps1","position":10,"original_position":10,"commit_id":"0bfeaf5daa0f947283883954140f02401e77afca","original_commit_id":"0bfeaf5daa0f947283883954140f02401e77afca","user":{"login":"paulcallen","id":16545334,"avatar_url":"https://avatars3.githubusercontent.com/u/16545334?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcallen","html_url":"https://github.com/paulcallen","followers_url":"https://api.github.com/users/paulcallen/followers","following_url":"https://api.github.com/users/paulcallen/following{/other_user}","gists_url":"https://api.github.com/users/paulcallen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcallen/subscriptions","organizations_url":"https://api.github.com/users/paulcallen/orgs","repos_url":"https://api.github.com/users/paulcallen/repos","events_url":"https://api.github.com/users/paulcallen/events{/privacy}","received_events_url":"https://api.github.com/users/paulcallen/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-02-27T05:25:40Z","updated_at":"2018-02-27T05:25:40Z","html_url":"https://github.com/dcos/dcos/pull/2445#discussion_r170818498","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/2445","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/170818498"},"html":{"href":"https://github.com/dcos/dcos/pull/2445#discussion_r170818498"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2445"}},"in_reply_to_id":170791995},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/2445","id":168359340,"html_url":"https://github.com/dcos/dcos/pull/2445","diff_url":"https://github.com/dcos/dcos/pull/2445.diff","patch_url":"https://github.com/dcos/dcos/pull/2445.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/2445","number":2445,"state":"open","locked":false,"title":"pkgpanda building on windows","user":{"login":"paulcallen","id":16545334,"avatar_url":"https://avatars3.githubusercontent.com/u/16545334?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcallen","html_url":"https://github.com/paulcallen","followers_url":"https://api.github.com/users/paulcallen/followers","following_url":"https://api.github.com/users/paulcallen/following{/other_user}","gists_url":"https://api.github.com/users/paulcallen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcallen/subscriptions","organizations_url":"https://api.github.com/users/paulcallen/orgs","repos_url":"https://api.github.com/users/paulcallen/repos","events_url":"https://api.github.com/users/paulcallen/events{/privacy}","received_events_url":"https://api.github.com/users/paulcallen/received_events","type":"User","site_admin":false},"body":"## High-level description\r\n\r\nMake pkgpanda build packages on Windows. This is done by:\r\n* porting a set of bash scripts to powershell\r\n* Add global constants for directory paths that vary between windows and other platforms\r\n* Copy configuration files that are going to be very different between windows and other platforms\r\n* create a windows docker file for building the packages\r\n* created a windows variant of the packages directory.\r\n* achieved about 80 tox test so far on windows\r\n\r\n**note** This runs build_local.ps1 to completion without problems. What is produces is not finished and will be the subject of future check-ins.\r\n\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - [DCOS_OSS-1899](https://jira.mesosphere.com/browse/DCOS_OSS-1899) Build dcos in a windows environment..\r\n\r\n\r\n## Related tickets (optional)\r\n\r\nOther tickets related to this change:\r\n\r\n - none\r\n\r\n## Checklist for all PRs\r\n\r\n  - [X] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [X] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [X] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n\r\n## Instructions and review process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using GitHub's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).\r\n","created_at":"2018-02-09T22:39:45Z","updated_at":"2018-02-27T05:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f8ddd005340ff0b3373efb2b0855be312a2a09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":364877915,"url":"https://api.github.com/repos/dcos/dcos/labels/Work%20In%20Progress","name":"Work In Progress","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/2445/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/2445/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/2445/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/0bfeaf5daa0f947283883954140f02401e77afca","head":{"label":"paulcallen:windows-stable","ref":"windows-stable","sha":"0bfeaf5daa0f947283883954140f02401e77afca","user":{"login":"paulcallen","id":16545334,"avatar_url":"https://avatars3.githubusercontent.com/u/16545334?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcallen","html_url":"https://github.com/paulcallen","followers_url":"https://api.github.com/users/paulcallen/followers","following_url":"https://api.github.com/users/paulcallen/following{/other_user}","gists_url":"https://api.github.com/users/paulcallen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcallen/subscriptions","organizations_url":"https://api.github.com/users/paulcallen/orgs","repos_url":"https://api.github.com/users/paulcallen/repos","events_url":"https://api.github.com/users/paulcallen/events{/privacy}","received_events_url":"https://api.github.com/users/paulcallen/received_events","type":"User","site_admin":false},"repo":{"id":100738396,"name":"dcos","full_name":"paulcallen/dcos","owner":{"login":"paulcallen","id":16545334,"avatar_url":"https://avatars3.githubusercontent.com/u/16545334?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcallen","html_url":"https://github.com/paulcallen","followers_url":"https://api.github.com/users/paulcallen/followers","following_url":"https://api.github.com/users/paulcallen/following{/other_user}","gists_url":"https://api.github.com/users/paulcallen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcallen/subscriptions","organizations_url":"https://api.github.com/users/paulcallen/orgs","repos_url":"https://api.github.com/users/paulcallen/repos","events_url":"https://api.github.com/users/paulcallen/events{/privacy}","received_events_url":"https://api.github.com/users/paulcallen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulcallen/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/paulcallen/dcos","forks_url":"https://api.github.com/repos/paulcallen/dcos/forks","keys_url":"https://api.github.com/repos/paulcallen/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulcallen/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulcallen/dcos/teams","hooks_url":"https://api.github.com/repos/paulcallen/dcos/hooks","issue_events_url":"https://api.github.com/repos/paulcallen/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/paulcallen/dcos/events","assignees_url":"https://api.github.com/repos/paulcallen/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/paulcallen/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/paulcallen/dcos/tags","blobs_url":"https://api.github.com/repos/paulcallen/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulcallen/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulcallen/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulcallen/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulcallen/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/paulcallen/dcos/languages","stargazers_url":"https://api.github.com/repos/paulcallen/dcos/stargazers","contributors_url":"https://api.github.com/repos/paulcallen/dcos/contributors","subscribers_url":"https://api.github.com/repos/paulcallen/dcos/subscribers","subscription_url":"https://api.github.com/repos/paulcallen/dcos/subscription","commits_url":"https://api.github.com/repos/paulcallen/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulcallen/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulcallen/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulcallen/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulcallen/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/paulcallen/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulcallen/dcos/merges","archive_url":"https://api.github.com/repos/paulcallen/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulcallen/dcos/downloads","issues_url":"https://api.github.com/repos/paulcallen/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/paulcallen/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/paulcallen/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/paulcallen/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulcallen/dcos/labels{/name}","releases_url":"https://api.github.com/repos/paulcallen/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/paulcallen/dcos/deployments","created_at":"2017-08-18T18:09:30Z","updated_at":"2017-08-18T18:09:32Z","pushed_at":"2018-02-27T00:33:57Z","git_url":"git://github.com/paulcallen/dcos.git","ssh_url":"git@github.com:paulcallen/dcos.git","clone_url":"https://github.com/paulcallen/dcos.git","svn_url":"https://github.com/paulcallen/dcos","homepage":"https://dcos.io","size":5841,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"a57effea6f9a68b81f565013a9944dc0091621c3","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2018-02-24T21:20:39Z","pushed_at":"2018-02-27T02:46:23Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":5732,"stargazers_count":1903,"watchers_count":1903,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":377,"open_issues":95,"watchers":1903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2445"},"html":{"href":"https://github.com/dcos/dcos/pull/2445"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/2445"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/2445/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2445/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2445/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/0bfeaf5daa0f947283883954140f02401e77afca"}},"author_association":"NONE"}}
{"actor":{"display_login":"paulcallen"}}