{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/220627400","pull_request_review_id":159078045,"id":220627400,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDYyNzQwMA==","diff_hunk":"@@ -418,6 +418,8 @@ grafana:\n   image: grafana\n   persist: false\n   storageClassName: \"\"\n+  accessModes:","path":"install/kubernetes/helm/istio/values.yaml","position":4,"original_position":4,"commit_id":"484e72374892a2886274cc55b871f9f1193c830c","original_commit_id":"484e72374892a2886274cc55b871f9f1193c830c","user":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"body":"For Kubernetes the PV list makes perfect sense in that I'd want to be able to access for Azure 1 of the 3 access modes Azure supports.  In AWS, the list that can be specified is only 1.  This results in either case (multiple options available, 1 option available) that only 1 option can be specified to the PV.  I guess a string array makes sense for the PVC (e.g. to specify two options when only one will be usable and let the backend sort it out).  I think anyone that uses this advanced functionality however will surely know what backend they are using and know how to specify the correct access mode.\r\n\r\nCan you explain a use case that would (work) with specification of multiple access modes ?  AFAIK the only access mode that works for this particular case is readwritemany (when horizontal scaling is applied to the grafana deployment).\r\n\r\nCheers\r\n-steve","created_at":"2018-09-26T16:06:35Z","updated_at":"2018-09-26T16:06:35Z","html_url":"https://github.com/istio/istio/pull/8416#discussion_r220627400","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/8416","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/220627400"},"html":{"href":"https://github.com/istio/istio/pull/8416#discussion_r220627400"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/8416"}},"in_reply_to_id":217893463},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8416","id":212476915,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDc2OTE1","html_url":"https://github.com/istio/istio/pull/8416","diff_url":"https://github.com/istio/istio/pull/8416.diff","patch_url":"https://github.com/istio/istio/pull/8416.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/8416","number":8416,"state":"open","locked":false,"title":"Add accessModes option to helm grafana chart","user":{"login":"k","id":2452636,"node_id":"MDQ6VXNlcjI0NTI2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2452636?v=4","gravatar_id":"","url":"https://api.github.com/users/k","html_url":"https://github.com/k","followers_url":"https://api.github.com/users/k/followers","following_url":"https://api.github.com/users/k/following{/other_user}","gists_url":"https://api.github.com/users/k/gists{/gist_id}","starred_url":"https://api.github.com/users/k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k/subscriptions","organizations_url":"https://api.github.com/users/k/orgs","repos_url":"https://api.github.com/users/k/repos","events_url":"https://api.github.com/users/k/events{/privacy}","received_events_url":"https://api.github.com/users/k/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-31T19:38:04Z","updated_at":"2018-09-26T16:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffae1ffb8dfbaea796d3013e6566c5bd5358690b","assignee":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"assignees":[{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sbezverk","id":16273360,"node_id":"MDQ6VXNlcjE2MjczMzYw","avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},{"login":"ostromart","id":30089849,"node_id":"MDQ6VXNlcjMwMDg5ODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/30089849?v=4","gravatar_id":"","url":"https://api.github.com/users/ostromart","html_url":"https://github.com/ostromart","followers_url":"https://api.github.com/users/ostromart/followers","following_url":"https://api.github.com/users/ostromart/following{/other_user}","gists_url":"https://api.github.com/users/ostromart/gists{/gist_id}","starred_url":"https://api.github.com/users/ostromart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostromart/subscriptions","organizations_url":"https://api.github.com/users/ostromart/orgs","repos_url":"https://api.github.com/users/ostromart/repos","events_url":"https://api.github.com/users/ostromart/events{/privacy}","received_events_url":"https://api.github.com/users/ostromart/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/8416/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/8416/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/8416/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/484e72374892a2886274cc55b871f9f1193c830c","head":{"label":"k:k/pvc-rwm","ref":"k/pvc-rwm","sha":"484e72374892a2886274cc55b871f9f1193c830c","user":{"login":"k","id":2452636,"node_id":"MDQ6VXNlcjI0NTI2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2452636?v=4","gravatar_id":"","url":"https://api.github.com/users/k","html_url":"https://github.com/k","followers_url":"https://api.github.com/users/k/followers","following_url":"https://api.github.com/users/k/following{/other_user}","gists_url":"https://api.github.com/users/k/gists{/gist_id}","starred_url":"https://api.github.com/users/k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k/subscriptions","organizations_url":"https://api.github.com/users/k/orgs","repos_url":"https://api.github.com/users/k/repos","events_url":"https://api.github.com/users/k/events{/privacy}","received_events_url":"https://api.github.com/users/k/received_events","type":"User","site_admin":false},"repo":{"id":143086509,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwODY1MDk=","name":"istio","full_name":"k/istio","private":false,"owner":{"login":"k","id":2452636,"node_id":"MDQ6VXNlcjI0NTI2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2452636?v=4","gravatar_id":"","url":"https://api.github.com/users/k","html_url":"https://github.com/k","followers_url":"https://api.github.com/users/k/followers","following_url":"https://api.github.com/users/k/following{/other_user}","gists_url":"https://api.github.com/users/k/gists{/gist_id}","starred_url":"https://api.github.com/users/k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k/subscriptions","organizations_url":"https://api.github.com/users/k/orgs","repos_url":"https://api.github.com/users/k/repos","events_url":"https://api.github.com/users/k/events{/privacy}","received_events_url":"https://api.github.com/users/k/received_events","type":"User","site_admin":false},"html_url":"https://github.com/k/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/k/istio","forks_url":"https://api.github.com/repos/k/istio/forks","keys_url":"https://api.github.com/repos/k/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k/istio/teams","hooks_url":"https://api.github.com/repos/k/istio/hooks","issue_events_url":"https://api.github.com/repos/k/istio/issues/events{/number}","events_url":"https://api.github.com/repos/k/istio/events","assignees_url":"https://api.github.com/repos/k/istio/assignees{/user}","branches_url":"https://api.github.com/repos/k/istio/branches{/branch}","tags_url":"https://api.github.com/repos/k/istio/tags","blobs_url":"https://api.github.com/repos/k/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/k/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/k/istio/languages","stargazers_url":"https://api.github.com/repos/k/istio/stargazers","contributors_url":"https://api.github.com/repos/k/istio/contributors","subscribers_url":"https://api.github.com/repos/k/istio/subscribers","subscription_url":"https://api.github.com/repos/k/istio/subscription","commits_url":"https://api.github.com/repos/k/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/k/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/k/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/k/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/k/istio/contents/{+path}","compare_url":"https://api.github.com/repos/k/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k/istio/merges","archive_url":"https://api.github.com/repos/k/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k/istio/downloads","issues_url":"https://api.github.com/repos/k/istio/issues{/number}","pulls_url":"https://api.github.com/repos/k/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/k/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/k/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k/istio/labels{/name}","releases_url":"https://api.github.com/repos/k/istio/releases{/id}","deployments_url":"https://api.github.com/repos/k/istio/deployments","created_at":"2018-08-01T01:09:35Z","updated_at":"2018-08-06T18:32:13Z","pushed_at":"2018-09-21T15:09:18Z","git_url":"git://github.com/k/istio.git","ssh_url":"git@github.com:k/istio.git","clone_url":"https://github.com/k/istio.git","svn_url":"https://github.com/k/istio","homepage":"https://istio.io","size":47193,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"5a40d18ead3744a88cc89acbb7c99b8bfd739a69","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-09-26T15:41:10Z","pushed_at":"2018-09-26T16:03:50Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":49462,"stargazers_count":11957,"watchers_count":11957,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1750,"mirror_url":null,"archived":false,"open_issues_count":946,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1750,"open_issues":946,"watchers":11957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/8416"},"html":{"href":"https://github.com/istio/istio/pull/8416"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/8416"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/8416/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/8416/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/8416/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/484e72374892a2886274cc55b871f9f1193c830c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sdake"}}