{"action":"created","comment":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments/214792296","pull_request_review_id":151917813,"id":214792296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc5MjI5Ng==","diff_hunk":"@@ -857,12 +853,22 @@ bool DirectoryService::RunConsensusOnFinalBlockWhenDSBackup()\n     return true;\n }\n \n-void DirectoryService::RunConsensusOnFinalBlock()\n+void DirectoryService::RunConsensusOnFinalBlock(bool revertStateDelta)\n {\n     LOG_MARKER();\n \n     SetState(FINALBLOCK_CONSENSUS_PREP);\n \n+    if (revertStateDelta)\n+    {\n+        LOG_GENERAL(WARNING,\n+                    \"Failed DS microblock consensus, revert state delta\");\n+        AccountStore::GetInstance().InitTemp();\n+        AccountStore::GetInstance().DeserializeDeltaTemp(m_stateDeltaFromShards,\n+                                                         0);\n+    }\n+    CommitFinalBlockConsensusBuffer();","path":"src/libDirectoryService/FinalBlockPreProcessing.cpp","position":48,"original_position":48,"commit_id":"4189acb4bddb491d55d0728a1e6eb1511b71afa5","original_commit_id":"4189acb4bddb491d55d0728a1e6eb1511b71afa5","user":{"login":"kaikawaliu","id":12387256,"node_id":"MDQ6VXNlcjEyMzg3MjU2","avatar_url":"https://avatars2.githubusercontent.com/u/12387256?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikawaliu","html_url":"https://github.com/kaikawaliu","followers_url":"https://api.github.com/users/kaikawaliu/followers","following_url":"https://api.github.com/users/kaikawaliu/following{/other_user}","gists_url":"https://api.github.com/users/kaikawaliu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikawaliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikawaliu/subscriptions","organizations_url":"https://api.github.com/users/kaikawaliu/orgs","repos_url":"https://api.github.com/users/kaikawaliu/repos","events_url":"https://api.github.com/users/kaikawaliu/events{/privacy}","received_events_url":"https://api.github.com/users/kaikawaliu/received_events","type":"User","site_admin":false},"body":"I think this should be called after `if(ConsensusObjCreation)`","created_at":"2018-09-04T05:47:45Z","updated_at":"2018-09-04T05:47:45Z","html_url":"https://github.com/Zilliqa/Zilliqa/pull/556#discussion_r214792296","pull_request_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments/214792296"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/556#discussion_r214792296"},"pull_request":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556","id":212852305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODUyMzA1","html_url":"https://github.com/Zilliqa/Zilliqa/pull/556","diff_url":"https://github.com/Zilliqa/Zilliqa/pull/556.diff","patch_url":"https://github.com/Zilliqa/Zilliqa/pull/556.patch","issue_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/556","number":556,"state":"open","locked":false,"title":"Final Block Consensus Buffer","user":{"login":"KaustubhShamshery","id":10321682,"node_id":"MDQ6VXNlcjEwMzIxNjgy","avatar_url":"https://avatars3.githubusercontent.com/u/10321682?v=4","gravatar_id":"","url":"https://api.github.com/users/KaustubhShamshery","html_url":"https://github.com/KaustubhShamshery","followers_url":"https://api.github.com/users/KaustubhShamshery/followers","following_url":"https://api.github.com/users/KaustubhShamshery/following{/other_user}","gists_url":"https://api.github.com/users/KaustubhShamshery/gists{/gist_id}","starred_url":"https://api.github.com/users/KaustubhShamshery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaustubhShamshery/subscriptions","organizations_url":"https://api.github.com/users/KaustubhShamshery/orgs","repos_url":"https://api.github.com/users/KaustubhShamshery/repos","events_url":"https://api.github.com/users/KaustubhShamshery/events{/privacy}","received_events_url":"https://api.github.com/users/KaustubhShamshery/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!-- What is the overall goals of your pull request? -->\r\n<!-- What is the context of your pull request? -->\r\n<!-- What are the related issues and pull requests? -->\r\n\r\n## Review Suggestion\r\n<!-- How should the reviewers get started on reviewing your pull request-->\r\n<!-- How can the reviewers verify the pull request is working as expected -->\r\n\r\n## Status\r\n\r\n### Implementation\r\n<!-- Add more TODOs before \"ready for review\", if any  -->\r\n- [ ] **ready for review**\r\n\r\n### Integration Test (Core Team)\r\n<!-- This is for core team only, ignore this if you are a community contributor -->\r\n\r\n<!-- append the commit digest to inform the others of the versions you have tested -->\r\n- [ ] local machine test\r\n<!-- - [ ] local machine test (commit: bbbbbbbb) -->\r\n<!-- - [ ] local machine test (commit: cccccccc) -->\r\n<!-- - [ ] local machine test (commit: dddddddd) -->\r\n- [ ] small-scale cloud test\r\n<!-- - [ ] small-scale cloud test (commit: bbbbbbbb) -->\r\n<!-- - [ ] small-scale cloud test (commit: cccccccc) -->\r\n<!-- - [ ] small-scale cloud test (commit: dddddddd) -->\r\n","created_at":"2018-09-04T04:21:57Z","updated_at":"2018-09-04T05:47:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9013d017a69ba3b1c0af9051cd62ae81bd1a040","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bb111189","id":4401980,"node_id":"MDQ6VXNlcjQ0MDE5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/4401980?v=4","gravatar_id":"","url":"https://api.github.com/users/bb111189","html_url":"https://github.com/bb111189","followers_url":"https://api.github.com/users/bb111189/followers","following_url":"https://api.github.com/users/bb111189/following{/other_user}","gists_url":"https://api.github.com/users/bb111189/gists{/gist_id}","starred_url":"https://api.github.com/users/bb111189/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb111189/subscriptions","organizations_url":"https://api.github.com/users/bb111189/orgs","repos_url":"https://api.github.com/users/bb111189/repos","events_url":"https://api.github.com/users/bb111189/events{/privacy}","received_events_url":"https://api.github.com/users/bb111189/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556/commits","review_comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556/comments","review_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/556/comments","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/4189acb4bddb491d55d0728a1e6eb1511b71afa5","head":{"label":"Zilliqa:fix/FinalBlockConsensusMessage","ref":"fix/FinalBlockConsensusMessage","sha":"4189acb4bddb491d55d0728a1e6eb1511b71afa5","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-09-03T11:46:56Z","pushed_at":"2018-09-04T04:40:12Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":18080,"stargazers_count":634,"watchers_count":634,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":135,"open_issues":74,"watchers":634,"default_branch":"master"}},"base":{"label":"Zilliqa:master","ref":"master","sha":"39a8c054e58094f0116f8d09075ba398c371326e","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-09-03T11:46:56Z","pushed_at":"2018-09-04T04:40:12Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":18080,"stargazers_count":634,"watchers_count":634,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":135,"open_issues":74,"watchers":634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/556"},"issue":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/556"},"comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/4189acb4bddb491d55d0728a1e6eb1511b71afa5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kaikawaliu"}}