{"action":"created","comment":{"url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/comments/188742183","pull_request_review_id":120781879,"id":188742183,"diff_hunk":"@@ -89,7 +90,19 @@ class SortingStuffGeneratorBasedTest extends WordSpec with Matchers with Propert\n \n     \"find knife\" which {\n       \"was occasionally disposed\" in {\n+        val ms = generatorDrivenConfig.minSuccessful\n+        val books = (1 to ms) flatMap { _ => interestingBookGen.sample }\n+        val watches = (1 to ms) flatMap { _ => cheepWatchGen.sample }\n+        var knifeOpt:Option[Knife.type ] = None\n+        for (knife <- knifeGenerator) yield {\n+          knifeOpt = knife\n+        }\n+\n+        val knifeOrBook = knifeOpt.getOrElse(books.head)\n+\n+        val st = StuffBox(Nil, Nil, Nil, (books ++ watches ++ List(knifeOrBook)).toList)","path":"src/test/scala/lectures/matching/SortingStuffGeneratorBasedTest.scala","position":51,"original_position":22,"commit_id":"bd66f40a5fa65a931046ec9ec4b4c87df0285786","original_commit_id":"5d760656f282ad554e314cf720b0876ca9be05d1","user":{"login":"sergeypopov83","id":20317475,"avatar_url":"https://avatars1.githubusercontent.com/u/20317475?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeypopov83","html_url":"https://github.com/sergeypopov83","followers_url":"https://api.github.com/users/sergeypopov83/followers","following_url":"https://api.github.com/users/sergeypopov83/following{/other_user}","gists_url":"https://api.github.com/users/sergeypopov83/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeypopov83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeypopov83/subscriptions","organizations_url":"https://api.github.com/users/sergeypopov83/orgs","repos_url":"https://api.github.com/users/sergeypopov83/repos","events_url":"https://api.github.com/users/sergeypopov83/events{/privacy}","received_events_url":"https://api.github.com/users/sergeypopov83/received_events","type":"User","site_admin":false},"body":"одна и та же книжка попадет в StuffBox \r\nлучше knifeOpt.toList","created_at":"2018-05-16T19:17:49Z","updated_at":"2018-05-16T19:17:57Z","html_url":"https://github.com/Andrianov96/Scala-complete-course/pull/15#discussion_r188742183","pull_request_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/comments/188742183"},"html":{"href":"https://github.com/Andrianov96/Scala-complete-course/pull/15#discussion_r188742183"},"pull_request":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15","id":188385611,"html_url":"https://github.com/Andrianov96/Scala-complete-course/pull/15","diff_url":"https://github.com/Andrianov96/Scala-complete-course/pull/15.diff","patch_url":"https://github.com/Andrianov96/Scala-complete-course/pull/15.patch","issue_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/15","number":15,"state":"open","locked":false,"title":"Hw14","user":{"login":"Andrianov96","id":17764996,"avatar_url":"https://avatars2.githubusercontent.com/u/17764996?v=4","gravatar_id":"","url":"https://api.github.com/users/Andrianov96","html_url":"https://github.com/Andrianov96","followers_url":"https://api.github.com/users/Andrianov96/followers","following_url":"https://api.github.com/users/Andrianov96/following{/other_user}","gists_url":"https://api.github.com/users/Andrianov96/gists{/gist_id}","starred_url":"https://api.github.com/users/Andrianov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andrianov96/subscriptions","organizations_url":"https://api.github.com/users/Andrianov96/orgs","repos_url":"https://api.github.com/users/Andrianov96/repos","events_url":"https://api.github.com/users/Andrianov96/events{/privacy}","received_events_url":"https://api.github.com/users/Andrianov96/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-16T10:22:53Z","updated_at":"2018-05-16T19:17:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd056c18204cc5cd0a839c1f88f7d57ccb841d7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/15/comments","statuses_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/statuses/bd66f40a5fa65a931046ec9ec4b4c87df0285786","head":{"label":"Andrianov96:HW14","ref":"HW14","sha":"bd66f40a5fa65a931046ec9ec4b4c87df0285786","user":{"login":"Andrianov96","id":17764996,"avatar_url":"https://avatars2.githubusercontent.com/u/17764996?v=4","gravatar_id":"","url":"https://api.github.com/users/Andrianov96","html_url":"https://github.com/Andrianov96","followers_url":"https://api.github.com/users/Andrianov96/followers","following_url":"https://api.github.com/users/Andrianov96/following{/other_user}","gists_url":"https://api.github.com/users/Andrianov96/gists{/gist_id}","starred_url":"https://api.github.com/users/Andrianov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andrianov96/subscriptions","organizations_url":"https://api.github.com/users/Andrianov96/orgs","repos_url":"https://api.github.com/users/Andrianov96/repos","events_url":"https://api.github.com/users/Andrianov96/events{/privacy}","received_events_url":"https://api.github.com/users/Andrianov96/received_events","type":"User","site_admin":false},"repo":{"id":104178314,"name":"Scala-complete-course","full_name":"Andrianov96/Scala-complete-course","owner":{"login":"Andrianov96","id":17764996,"avatar_url":"https://avatars2.githubusercontent.com/u/17764996?v=4","gravatar_id":"","url":"https://api.github.com/users/Andrianov96","html_url":"https://github.com/Andrianov96","followers_url":"https://api.github.com/users/Andrianov96/followers","following_url":"https://api.github.com/users/Andrianov96/following{/other_user}","gists_url":"https://api.github.com/users/Andrianov96/gists{/gist_id}","starred_url":"https://api.github.com/users/Andrianov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andrianov96/subscriptions","organizations_url":"https://api.github.com/users/Andrianov96/orgs","repos_url":"https://api.github.com/users/Andrianov96/repos","events_url":"https://api.github.com/users/Andrianov96/events{/privacy}","received_events_url":"https://api.github.com/users/Andrianov96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andrianov96/Scala-complete-course","description":"Full scala 1.5 year scala course ","fork":true,"url":"https://api.github.com/repos/Andrianov96/Scala-complete-course","forks_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/forks","keys_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/teams","hooks_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/hooks","issue_events_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/events{/number}","events_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/events","assignees_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/assignees{/user}","branches_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/branches{/branch}","tags_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/tags","blobs_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/statuses/{sha}","languages_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/languages","stargazers_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/stargazers","contributors_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/contributors","subscribers_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/subscribers","subscription_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/subscription","commits_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/contents/{+path}","compare_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/merges","archive_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/downloads","issues_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues{/number}","pulls_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls{/number}","milestones_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/milestones{/number}","notifications_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/labels{/name}","releases_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/releases{/id}","deployments_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/deployments","created_at":"2017-09-20T06:59:27Z","updated_at":"2018-05-16T18:22:10Z","pushed_at":"2018-05-16T18:22:09Z","git_url":"git://github.com/Andrianov96/Scala-complete-course.git","ssh_url":"git@github.com:Andrianov96/Scala-complete-course.git","clone_url":"https://github.com/Andrianov96/Scala-complete-course.git","svn_url":"https://github.com/Andrianov96/Scala-complete-course","homepage":null,"size":39842,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Andrianov96:master","ref":"master","sha":"bdf103e5c6afc35fb8ed0306ea76cf99faafd48f","user":{"login":"Andrianov96","id":17764996,"avatar_url":"https://avatars2.githubusercontent.com/u/17764996?v=4","gravatar_id":"","url":"https://api.github.com/users/Andrianov96","html_url":"https://github.com/Andrianov96","followers_url":"https://api.github.com/users/Andrianov96/followers","following_url":"https://api.github.com/users/Andrianov96/following{/other_user}","gists_url":"https://api.github.com/users/Andrianov96/gists{/gist_id}","starred_url":"https://api.github.com/users/Andrianov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andrianov96/subscriptions","organizations_url":"https://api.github.com/users/Andrianov96/orgs","repos_url":"https://api.github.com/users/Andrianov96/repos","events_url":"https://api.github.com/users/Andrianov96/events{/privacy}","received_events_url":"https://api.github.com/users/Andrianov96/received_events","type":"User","site_admin":false},"repo":{"id":104178314,"name":"Scala-complete-course","full_name":"Andrianov96/Scala-complete-course","owner":{"login":"Andrianov96","id":17764996,"avatar_url":"https://avatars2.githubusercontent.com/u/17764996?v=4","gravatar_id":"","url":"https://api.github.com/users/Andrianov96","html_url":"https://github.com/Andrianov96","followers_url":"https://api.github.com/users/Andrianov96/followers","following_url":"https://api.github.com/users/Andrianov96/following{/other_user}","gists_url":"https://api.github.com/users/Andrianov96/gists{/gist_id}","starred_url":"https://api.github.com/users/Andrianov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andrianov96/subscriptions","organizations_url":"https://api.github.com/users/Andrianov96/orgs","repos_url":"https://api.github.com/users/Andrianov96/repos","events_url":"https://api.github.com/users/Andrianov96/events{/privacy}","received_events_url":"https://api.github.com/users/Andrianov96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andrianov96/Scala-complete-course","description":"Full scala 1.5 year scala course ","fork":true,"url":"https://api.github.com/repos/Andrianov96/Scala-complete-course","forks_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/forks","keys_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/teams","hooks_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/hooks","issue_events_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/events{/number}","events_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/events","assignees_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/assignees{/user}","branches_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/branches{/branch}","tags_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/tags","blobs_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/statuses/{sha}","languages_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/languages","stargazers_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/stargazers","contributors_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/contributors","subscribers_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/subscribers","subscription_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/subscription","commits_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/contents/{+path}","compare_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/merges","archive_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/downloads","issues_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues{/number}","pulls_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls{/number}","milestones_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/milestones{/number}","notifications_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/labels{/name}","releases_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/releases{/id}","deployments_url":"https://api.github.com/repos/Andrianov96/Scala-complete-course/deployments","created_at":"2017-09-20T06:59:27Z","updated_at":"2018-05-16T18:22:10Z","pushed_at":"2018-05-16T18:22:09Z","git_url":"git://github.com/Andrianov96/Scala-complete-course.git","ssh_url":"git@github.com:Andrianov96/Scala-complete-course.git","clone_url":"https://github.com/Andrianov96/Scala-complete-course.git","svn_url":"https://github.com/Andrianov96/Scala-complete-course","homepage":null,"size":39842,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15"},"html":{"href":"https://github.com/Andrianov96/Scala-complete-course/pull/15"},"issue":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/15"},"comments":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Andrianov96/Scala-complete-course/statuses/bd66f40a5fa65a931046ec9ec4b4c87df0285786"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sergeypopov83"}}