{"action":"created","issue":{"url":"https://api.github.com/repos/libretro/mame2003-libretro/issues/383","repository_url":"https://api.github.com/repos/libretro/mame2003-libretro","labels_url":"https://api.github.com/repos/libretro/mame2003-libretro/issues/383/labels{/name}","comments_url":"https://api.github.com/repos/libretro/mame2003-libretro/issues/383/comments","events_url":"https://api.github.com/repos/libretro/mame2003-libretro/issues/383/events","html_url":"https://github.com/libretro/mame2003-libretro/pull/383","id":370831482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDIwNDQ4","number":383,"title":"change core name as reported to the libretro API to match the RA .info file","user":{"login":"gblues","id":1912149,"node_id":"MDQ6VXNlcjE5MTIxNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1912149?v=4","gravatar_id":"","url":"https://api.github.com/users/gblues","html_url":"https://github.com/gblues","followers_url":"https://api.github.com/users/gblues/followers","following_url":"https://api.github.com/users/gblues/following{/other_user}","gists_url":"https://api.github.com/users/gblues/gists{/gist_id}","starred_url":"https://api.github.com/users/gblues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gblues/subscriptions","organizations_url":"https://api.github.com/users/gblues/orgs","repos_url":"https://api.github.com/users/gblues/repos","events_url":"https://api.github.com/users/gblues/events{/privacy}","received_events_url":"https://api.github.com/users/gblues/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-10-16T22:53:02Z","updated_at":"2018-11-07T00:49:08Z","closed_at":"2018-10-17T06:08:40Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/libretro/mame2003-libretro/pulls/383","html_url":"https://github.com/libretro/mame2003-libretro/pull/383","diff_url":"https://github.com/libretro/mame2003-libretro/pull/383.diff","patch_url":"https://github.com/libretro/mame2003-libretro/pull/383.patch"},"body":"== DETAILS\r\nWhen the APPNAME macro was added, the libretro code was included\r\nin the change and doing so broke netplay in RetroArch.\r\n\r\nRetroArch stores core information in *.info files, and the `corename`\r\nfield of the info file is expected to match what the core self-reports.\r\nThe result of the APPNAME macro work is that it changed the self-reporting\r\ncore name as \"mame2003\".\r\n\r\nThis commit changes the core self-reported name (and JUST that name) back\r\nto the expected value.\r\n\r\n== TESTING\r\nTested locally and confirmed that the content matching in netplay is now\r\nsuccessful.\r\n\r\n@twinaphex \r\n\r\nThank you wanting to make a contribution to this project!\r\n\r\nPlease note that by contributing code or other intellectual to this project you are allowing the project to make unlimited use of your contribution. As with the rest of the project, new contributions will be made available freely under the classic MAME Non-Commercial License.\r\n\r\n**This license can be viewed at https://raw.githubusercontent.com/libretro/mame2003-libretro/master/LICENSE.md**.\r\n"},"comment":{"url":"https://api.github.com/repos/libretro/mame2003-libretro/issues/comments/436463301","html_url":"https://github.com/libretro/mame2003-libretro/pull/383#issuecomment-436463301","issue_url":"https://api.github.com/repos/libretro/mame2003-libretro/issues/383","id":436463301,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjQ2MzMwMQ==","user":{"login":"dankcushions","id":13054748,"node_id":"MDQ6VXNlcjEzMDU0NzQ4","avatar_url":"https://avatars2.githubusercontent.com/u/13054748?v=4","gravatar_id":"","url":"https://api.github.com/users/dankcushions","html_url":"https://github.com/dankcushions","followers_url":"https://api.github.com/users/dankcushions/followers","following_url":"https://api.github.com/users/dankcushions/following{/other_user}","gists_url":"https://api.github.com/users/dankcushions/gists{/gist_id}","starred_url":"https://api.github.com/users/dankcushions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankcushions/subscriptions","organizations_url":"https://api.github.com/users/dankcushions/orgs","repos_url":"https://api.github.com/users/dankcushions/repos","events_url":"https://api.github.com/users/dankcushions/events{/privacy}","received_events_url":"https://api.github.com/users/dankcushions/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T00:49:08Z","updated_at":"2018-11-07T00:49:08Z","author_association":"CONTRIBUTOR","body":"no dice, that's to do with save files, not override folder locations. in any case, i don't have that setting in my version of retroarch.\r\n\r\nanyways, i'd picked up on this issue from user feedback, so figured i'd try to recreate the scenario myself. latest binary version in retropie - save game override... usual `/mame2003/` location. OK!\r\n\r\nupdate mame2003 from source - save game override... it's now in a new `/MAME 2003 (0.78)/` location. FAIL!\r\n\r\nso i guess that more or less proves that this commit breaks all users pre-existing core or game overrides.\r\n\r\nwould a solution be to change retroarch so instead of using the library_name in the override paths, it instead uses the APPNAME? i agree with @gblues:\r\n> APPNAME is clearly intended to be a short identifier, not a pretty user-facing string.\r\nwith this in mind, it doesn't seem to be me that the library_name should be used in this override path. plus, it would mean that this change wouldn't break any config paths. a win-win!\r\n\r\nit sounds like a retroarch issue may be brewing."}}
{"actor":{"display_login":"dankcushions"}}