{"action":"opened","number":81,"pull_request":{"url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/81","id":174231674,"html_url":"https://github.com/FreeRADIUS/freeradius-client/pull/81","diff_url":"https://github.com/FreeRADIUS/freeradius-client/pull/81.diff","patch_url":"https://github.com/FreeRADIUS/freeradius-client/pull/81.patch","issue_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues/81","number":81,"state":"open","locked":false,"title":"rc_ipaddr_local should use a temporary sockaddr_storage","user":{"login":"fxdupont","id":4550307,"avatar_url":"https://avatars3.githubusercontent.com/u/4550307?v=4","gravatar_id":"","url":"https://api.github.com/users/fxdupont","html_url":"https://github.com/fxdupont","followers_url":"https://api.github.com/users/fxdupont/followers","following_url":"https://api.github.com/users/fxdupont/following{/other_user}","gists_url":"https://api.github.com/users/fxdupont/gists{/gist_id}","starred_url":"https://api.github.com/users/fxdupont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxdupont/subscriptions","organizations_url":"https://api.github.com/users/fxdupont/orgs","repos_url":"https://api.github.com/users/fxdupont/repos","events_url":"https://api.github.com/users/fxdupont/events{/privacy}","received_events_url":"https://api.github.com/users/fxdupont/received_events","type":"User","site_admin":false},"body":"The code was written before the IPv6 support was added so it left a sockaddr (16 byte long) where a sockaddr_in (16 byte long) or a sockaddr_in6 (28 byte long) is copied using for the length the SA_LEN macro.\r\nOn my macOS localhost is resolved into IPv6 ::1 so a trivial test triggers a buffer overflow which was detected by the runtime.\r\nThe fix is trivial: just use a sockaddr_storage (as it was already done at other places in the code, for instance in sendserver.c).\r\n","created_at":"2018-03-11T17:20:31Z","updated_at":"2018-03-11T17:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/81/commits","review_comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/81/comments","review_comment_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues/81/comments","statuses_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/statuses/1ee15ac8612e8bdfb9b35d08773a6a5290518270","head":{"label":"fxdupont:sa_storage","ref":"sa_storage","sha":"1ee15ac8612e8bdfb9b35d08773a6a5290518270","user":{"login":"fxdupont","id":4550307,"avatar_url":"https://avatars3.githubusercontent.com/u/4550307?v=4","gravatar_id":"","url":"https://api.github.com/users/fxdupont","html_url":"https://github.com/fxdupont","followers_url":"https://api.github.com/users/fxdupont/followers","following_url":"https://api.github.com/users/fxdupont/following{/other_user}","gists_url":"https://api.github.com/users/fxdupont/gists{/gist_id}","starred_url":"https://api.github.com/users/fxdupont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxdupont/subscriptions","organizations_url":"https://api.github.com/users/fxdupont/orgs","repos_url":"https://api.github.com/users/fxdupont/repos","events_url":"https://api.github.com/users/fxdupont/events{/privacy}","received_events_url":"https://api.github.com/users/fxdupont/received_events","type":"User","site_admin":false},"repo":{"id":123199674,"name":"freeradius-client","full_name":"fxdupont/freeradius-client","owner":{"login":"fxdupont","id":4550307,"avatar_url":"https://avatars3.githubusercontent.com/u/4550307?v=4","gravatar_id":"","url":"https://api.github.com/users/fxdupont","html_url":"https://github.com/fxdupont","followers_url":"https://api.github.com/users/fxdupont/followers","following_url":"https://api.github.com/users/fxdupont/following{/other_user}","gists_url":"https://api.github.com/users/fxdupont/gists{/gist_id}","starred_url":"https://api.github.com/users/fxdupont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxdupont/subscriptions","organizations_url":"https://api.github.com/users/fxdupont/orgs","repos_url":"https://api.github.com/users/fxdupont/repos","events_url":"https://api.github.com/users/fxdupont/events{/privacy}","received_events_url":"https://api.github.com/users/fxdupont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fxdupont/freeradius-client","description":"A BSD licenced RADIUS client library","fork":true,"url":"https://api.github.com/repos/fxdupont/freeradius-client","forks_url":"https://api.github.com/repos/fxdupont/freeradius-client/forks","keys_url":"https://api.github.com/repos/fxdupont/freeradius-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxdupont/freeradius-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxdupont/freeradius-client/teams","hooks_url":"https://api.github.com/repos/fxdupont/freeradius-client/hooks","issue_events_url":"https://api.github.com/repos/fxdupont/freeradius-client/issues/events{/number}","events_url":"https://api.github.com/repos/fxdupont/freeradius-client/events","assignees_url":"https://api.github.com/repos/fxdupont/freeradius-client/assignees{/user}","branches_url":"https://api.github.com/repos/fxdupont/freeradius-client/branches{/branch}","tags_url":"https://api.github.com/repos/fxdupont/freeradius-client/tags","blobs_url":"https://api.github.com/repos/fxdupont/freeradius-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxdupont/freeradius-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxdupont/freeradius-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxdupont/freeradius-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxdupont/freeradius-client/statuses/{sha}","languages_url":"https://api.github.com/repos/fxdupont/freeradius-client/languages","stargazers_url":"https://api.github.com/repos/fxdupont/freeradius-client/stargazers","contributors_url":"https://api.github.com/repos/fxdupont/freeradius-client/contributors","subscribers_url":"https://api.github.com/repos/fxdupont/freeradius-client/subscribers","subscription_url":"https://api.github.com/repos/fxdupont/freeradius-client/subscription","commits_url":"https://api.github.com/repos/fxdupont/freeradius-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxdupont/freeradius-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxdupont/freeradius-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxdupont/freeradius-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxdupont/freeradius-client/contents/{+path}","compare_url":"https://api.github.com/repos/fxdupont/freeradius-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxdupont/freeradius-client/merges","archive_url":"https://api.github.com/repos/fxdupont/freeradius-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxdupont/freeradius-client/downloads","issues_url":"https://api.github.com/repos/fxdupont/freeradius-client/issues{/number}","pulls_url":"https://api.github.com/repos/fxdupont/freeradius-client/pulls{/number}","milestones_url":"https://api.github.com/repos/fxdupont/freeradius-client/milestones{/number}","notifications_url":"https://api.github.com/repos/fxdupont/freeradius-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxdupont/freeradius-client/labels{/name}","releases_url":"https://api.github.com/repos/fxdupont/freeradius-client/releases{/id}","deployments_url":"https://api.github.com/repos/fxdupont/freeradius-client/deployments","created_at":"2018-02-27T23:06:32Z","updated_at":"2018-02-27T23:06:34Z","pushed_at":"2018-03-11T17:05:16Z","git_url":"git://github.com/fxdupont/freeradius-client.git","ssh_url":"git@github.com:fxdupont/freeradius-client.git","clone_url":"https://github.com/fxdupont/freeradius-client.git","svn_url":"https://github.com/fxdupont/freeradius-client","homepage":"http://freeradius.org/freeradius-client/","size":1351,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRADIUS:master","ref":"master","sha":"f2367f18cb103005dd4593a8b78233fa2e18f855","user":{"login":"FreeRADIUS","id":2430370,"avatar_url":"https://avatars0.githubusercontent.com/u/2430370?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeRADIUS","html_url":"https://github.com/FreeRADIUS","followers_url":"https://api.github.com/users/FreeRADIUS/followers","following_url":"https://api.github.com/users/FreeRADIUS/following{/other_user}","gists_url":"https://api.github.com/users/FreeRADIUS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRADIUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRADIUS/subscriptions","organizations_url":"https://api.github.com/users/FreeRADIUS/orgs","repos_url":"https://api.github.com/users/FreeRADIUS/repos","events_url":"https://api.github.com/users/FreeRADIUS/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRADIUS/received_events","type":"Organization","site_admin":false},"repo":{"id":2007170,"name":"freeradius-client","full_name":"FreeRADIUS/freeradius-client","owner":{"login":"FreeRADIUS","id":2430370,"avatar_url":"https://avatars0.githubusercontent.com/u/2430370?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeRADIUS","html_url":"https://github.com/FreeRADIUS","followers_url":"https://api.github.com/users/FreeRADIUS/followers","following_url":"https://api.github.com/users/FreeRADIUS/following{/other_user}","gists_url":"https://api.github.com/users/FreeRADIUS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRADIUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRADIUS/subscriptions","organizations_url":"https://api.github.com/users/FreeRADIUS/orgs","repos_url":"https://api.github.com/users/FreeRADIUS/repos","events_url":"https://api.github.com/users/FreeRADIUS/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRADIUS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRADIUS/freeradius-client","description":"A BSD licenced RADIUS client library","fork":false,"url":"https://api.github.com/repos/FreeRADIUS/freeradius-client","forks_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/forks","keys_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/teams","hooks_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/hooks","issue_events_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/events","assignees_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/tags","blobs_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/languages","stargazers_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/stargazers","contributors_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/contributors","subscribers_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/subscribers","subscription_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/subscription","commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/merges","archive_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/downloads","issues_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/labels{/name}","releases_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/releases{/id}","deployments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-client/deployments","created_at":"2011-07-06T15:19:55Z","updated_at":"2018-03-11T09:23:23Z","pushed_at":"2018-03-01T14:15:25Z","git_url":"git://github.com/FreeRADIUS/freeradius-client.git","ssh_url":"git@github.com:FreeRADIUS/freeradius-client.git","clone_url":"https://github.com/FreeRADIUS/freeradius-client.git","svn_url":"https://github.com/FreeRADIUS/freeradius-client","homepage":"http://freeradius.org/freeradius-client/","size":1341,"stargazers_count":64,"watchers_count":64,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":18,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/81"},"html":{"href":"https://github.com/FreeRADIUS/freeradius-client/pull/81"},"issue":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues/81"},"comments":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-client/statuses/1ee15ac8612e8bdfb9b35d08773a6a5290518270"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"fxdupont"}}