{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3373","repository_url":"https://api.github.com/repos/OpenMS/OpenMS","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3373/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3373/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3373/events","html_url":"https://github.com/OpenMS/OpenMS/issues/3373","id":312453913,"number":3373,"title":"python setuptools implicitly links to zlib","user":{"login":"jpfeuffer","id":8102638,"avatar_url":"https://avatars0.githubusercontent.com/u/8102638?v=4","gravatar_id":"","url":"https://api.github.com/users/jpfeuffer","html_url":"https://github.com/jpfeuffer","followers_url":"https://api.github.com/users/jpfeuffer/followers","following_url":"https://api.github.com/users/jpfeuffer/following{/other_user}","gists_url":"https://api.github.com/users/jpfeuffer/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfeuffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfeuffer/subscriptions","organizations_url":"https://api.github.com/users/jpfeuffer/orgs","repos_url":"https://api.github.com/users/jpfeuffer/repos","events_url":"https://api.github.com/users/jpfeuffer/events{/privacy}","received_events_url":"https://api.github.com/users/jpfeuffer/received_events","type":"User","site_admin":false},"labels":[{"id":74106646,"url":"https://api.github.com/repos/OpenMS/OpenMS/labels/Build%20System","name":"Build System","color":"207de5","default":false},{"id":74312421,"url":"https://api.github.com/repos/OpenMS/OpenMS/labels/Documentation","name":"Documentation","color":"207de5","default":false},{"id":74111089,"url":"https://api.github.com/repos/OpenMS/OpenMS/labels/pyOpenMS","name":"pyOpenMS","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-09T09:17:09Z","updated_at":"2018-04-11T02:54:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Since standard python usually links to it. Forcing us to use a compatible version again.\r\nI encountered problems when trying to link a static zlib on windows.\r\nJust to let people know. Is this somewhere in the pyOpenMS docu?\r\n\r\nRelated:\r\nhttps://stackoverflow.com/questions/16841674/python-c-extension-link-with-a-custom-shared-library"},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/380310437","html_url":"https://github.com/OpenMS/OpenMS/issues/3373#issuecomment-380310437","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3373","id":380310437,"user":{"login":"hroest","id":464014,"avatar_url":"https://avatars0.githubusercontent.com/u/464014?v=4","gravatar_id":"","url":"https://api.github.com/users/hroest","html_url":"https://github.com/hroest","followers_url":"https://api.github.com/users/hroest/followers","following_url":"https://api.github.com/users/hroest/following{/other_user}","gists_url":"https://api.github.com/users/hroest/gists{/gist_id}","starred_url":"https://api.github.com/users/hroest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroest/subscriptions","organizations_url":"https://api.github.com/users/hroest/orgs","repos_url":"https://api.github.com/users/hroest/repos","events_url":"https://api.github.com/users/hroest/events{/privacy}","received_events_url":"https://api.github.com/users/hroest/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T02:54:51Z","updated_at":"2018-04-11T02:54:51Z","author_association":"CONTRIBUTOR","body":"in any case we probably should write a small class that abstracts code like this:\r\n\r\nhttps://github.com/OpenMS/OpenMS/blob/b3c4e72094a1211942d207ebaa285d39d87b6165/src/openms/include/OpenMS/FORMAT/Base64.h#L557\r\n\r\nand only includes zlib in the .cpp and keeps the headers clean"}}
{"actor":{"display_login":"hroest"}}