{"action":"created","issue":{"url":"https://api.github.com/repos/browsh-org/browsh/issues/236","repository_url":"https://api.github.com/repos/browsh-org/browsh","labels_url":"https://api.github.com/repos/browsh-org/browsh/issues/236/labels{/name}","comments_url":"https://api.github.com/repos/browsh-org/browsh/issues/236/comments","events_url":"https://api.github.com/repos/browsh-org/browsh/issues/236/events","html_url":"https://github.com/browsh-org/browsh/pull/236","id":379074159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjI1ODM2","number":236,"title":"Vim mode","user":{"login":"tombh","id":160835,"node_id":"MDQ6VXNlcjE2MDgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/160835?v=4","gravatar_id":"","url":"https://api.github.com/users/tombh","html_url":"https://github.com/tombh","followers_url":"https://api.github.com/users/tombh/followers","following_url":"https://api.github.com/users/tombh/following{/other_user}","gists_url":"https://api.github.com/users/tombh/gists{/gist_id}","starred_url":"https://api.github.com/users/tombh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombh/subscriptions","organizations_url":"https://api.github.com/users/tombh/orgs","repos_url":"https://api.github.com/users/tombh/repos","events_url":"https://api.github.com/users/tombh/events{/privacy}","received_events_url":"https://api.github.com/users/tombh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-11-09T08:54:19Z","updated_at":"2018-12-31T16:13:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/browsh-org/browsh/pulls/236","html_url":"https://github.com/browsh-org/browsh/pull/236","diff_url":"https://github.com/browsh-org/browsh/pull/236.diff","patch_url":"https://github.com/browsh-org/browsh/pull/236.patch"},"body":"Relates to #31 \r\n\r\nThis still needs a lot of work, but I want to start a PR anyway for somewhere to have the discussion.\r\n\r\n@tobimensch I've had a play with this and it's AMAZING! Hats off to you, this can't have been easy - you've made changes right across the spectrum from the CLI to the webextension code.\r\n\r\nThe main thing that needs to be done is fixing the tests that this breaks and adding new tests. I've already added a new test file specifically for Vim tests. Following links by link hints doesn't seem to be consistently passing its test - should the first link always be hinted with `a`? Also `gt` doesn't work for me. There may be other things that don't work, I didn't comprehensively go through everything. Which reminds me, we can start a new docs page for this, just have it hidden on the main site for now.\r\n\r\nI'll leave my other feedback as comments on the PR's diffs."},"comment":{"url":"https://api.github.com/repos/browsh-org/browsh/issues/comments/450663382","html_url":"https://github.com/browsh-org/browsh/pull/236#issuecomment-450663382","issue_url":"https://api.github.com/repos/browsh-org/browsh/issues/236","id":450663382,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDY2MzM4Mg==","user":{"login":"j-rewerts","id":8295080,"node_id":"MDQ6VXNlcjgyOTUwODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8295080?v=4","gravatar_id":"","url":"https://api.github.com/users/j-rewerts","html_url":"https://github.com/j-rewerts","followers_url":"https://api.github.com/users/j-rewerts/followers","following_url":"https://api.github.com/users/j-rewerts/following{/other_user}","gists_url":"https://api.github.com/users/j-rewerts/gists{/gist_id}","starred_url":"https://api.github.com/users/j-rewerts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-rewerts/subscriptions","organizations_url":"https://api.github.com/users/j-rewerts/orgs","repos_url":"https://api.github.com/users/j-rewerts/repos","events_url":"https://api.github.com/users/j-rewerts/events{/privacy}","received_events_url":"https://api.github.com/users/j-rewerts/received_events","type":"User","site_admin":false},"created_at":"2018-12-31T16:13:26Z","updated_at":"2018-12-31T16:13:26Z","author_association":"MEMBER","body":"What would be the best way for me to contribute to this PR? I don't have write access to this branch, but I could submit a separate PR to this branch, which if it was accepted would probably affect this PR. Any advice?"}}
{"actor":{"display_login":"j-rewerts"}}