{"action":"created","comment":{"url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments/202191766","pull_request_review_id":136844495,"id":202191766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE5MTc2Ng==","diff_hunk":"@@ -79,6 +84,17 @@ fn it_creates_a_package_json_provided_path() {\n     assert!(utils::read_package_json(&path).is_ok());\n     let pkg = utils::read_package_json(&path).unwrap();\n     assert_eq!(pkg.name, \"js-hello-world\");\n+    assert_eq!(pkg.main, \"js_hello_world.js\");","path":"tests/manifest/main.rs","position":34,"original_position":34,"commit_id":"042ef9b0269944f5224d6abb350c9c01e1e931bd","original_commit_id":"042ef9b0269944f5224d6abb350c9c01e1e931bd","user":{"login":"ashleygwilliams","id":1163554,"node_id":"MDQ6VXNlcjExNjM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1163554?v=4","gravatar_id":"","url":"https://api.github.com/users/ashleygwilliams","html_url":"https://github.com/ashleygwilliams","followers_url":"https://api.github.com/users/ashleygwilliams/followers","following_url":"https://api.github.com/users/ashleygwilliams/following{/other_user}","gists_url":"https://api.github.com/users/ashleygwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleygwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleygwilliams/subscriptions","organizations_url":"https://api.github.com/users/ashleygwilliams/orgs","repos_url":"https://api.github.com/users/ashleygwilliams/repos","events_url":"https://api.github.com/users/ashleygwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/ashleygwilliams/received_events","type":"User","site_admin":false},"body":"sorry for the confusion around this. i'm honestly baffled about how this bug happened but feels like something i might just need to sort out. thank you so much for all your patience and hard work. i'll pull this down and take it from here so you don't have to worry about it <3<3","created_at":"2018-07-12T21:56:20Z","updated_at":"2018-07-12T21:56:20Z","html_url":"https://github.com/rustwasm/wasm-pack/pull/200#discussion_r202191766","pull_request_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments/202191766"},"html":{"href":"https://github.com/rustwasm/wasm-pack/pull/200#discussion_r202191766"},"pull_request":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200"}},"in_reply_to_id":202191527},"pull_request":{"url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200","id":199868723,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODY4NzIz","html_url":"https://github.com/rustwasm/wasm-pack/pull/200","diff_url":"https://github.com/rustwasm/wasm-pack/pull/200.diff","patch_url":"https://github.com/rustwasm/wasm-pack/pull/200.patch","issue_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/200","number":200,"state":"open","locked":false,"title":"Include *_bg.js wasm-bindgen outputs in package.json","user":{"login":"mciantyre","id":7933926,"node_id":"MDQ6VXNlcjc5MzM5MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/7933926?v=4","gravatar_id":"","url":"https://api.github.com/users/mciantyre","html_url":"https://github.com/mciantyre","followers_url":"https://api.github.com/users/mciantyre/followers","following_url":"https://api.github.com/users/mciantyre/following{/other_user}","gists_url":"https://api.github.com/users/mciantyre/gists{/gist_id}","starred_url":"https://api.github.com/users/mciantyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mciantyre/subscriptions","organizations_url":"https://api.github.com/users/mciantyre/orgs","repos_url":"https://api.github.com/users/mciantyre/repos","events_url":"https://api.github.com/users/mciantyre/events{/privacy}","received_events_url":"https://api.github.com/users/mciantyre/received_events","type":"User","site_admin":false},"body":"Fixes #199!\r\n\r\nAs @ashleygwilliams suggested, I updated the manifest module to add the `*_bg.js`-qualified output in `package.json`'s `files` attribute. I updated existing tests to expect the new file. I added a few other asserts in existing tests to expect the files in `package.json`.\r\n\r\nI came upon this issue after taking a `wasm-pack pack` output and using it in a new node project. Would we want an automated test to make sure that use-case always works? I'm not sure what that kind of test might look like, but if we feel its valuable I'd be happy to dig deeper!\r\n\r\nI haven't looked into how this issue came to be. Did something change in `wasm-bindgen`; would our solution here be sufficient for any future changes? If there's a need, I'd be happy to help build a more resilient fix.\r\n\r\nThanks for all of your help and effort in building `wasm-pack`!\r\n\r\n---\r\n\r\nMake sure these boxes are checked! 📦✅\r\n\r\n- [x] You have the latest version of `rustfmt` installed and have your \r\n      cloned directory set to nightly\r\n```bash\r\n$ rustup override set nightly\r\n$ rustup component add rustfmt-preview --toolchain nightly\r\n```\r\n- [x] You ran `rustfmt` on the code base before submitting\r\n- [x] You reference which issue is being closed in the PR text\r\n\r\n✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨\r\n","created_at":"2018-07-06T23:56:56Z","updated_at":"2018-07-12T21:56:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f10cc0313533c4e7ead267193f4468edb60b61ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":858391339,"node_id":"MDU6TGFiZWw4NTgzOTEzMzk=","url":"https://api.github.com/repos/rustwasm/wasm-pack/labels/changes%20requested","name":"changes requested","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/rustwasm/wasm-pack/milestones/8","html_url":"https://github.com/rustwasm/wasm-pack/milestone/8","labels_url":"https://api.github.com/repos/rustwasm/wasm-pack/milestones/8/labels","id":3436955,"node_id":"MDk6TWlsZXN0b25lMzQzNjk1NQ==","number":8,"title":"0.4.1","description":null,"creator":{"login":"ashleygwilliams","id":1163554,"node_id":"MDQ6VXNlcjExNjM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1163554?v=4","gravatar_id":"","url":"https://api.github.com/users/ashleygwilliams","html_url":"https://github.com/ashleygwilliams","followers_url":"https://api.github.com/users/ashleygwilliams/followers","following_url":"https://api.github.com/users/ashleygwilliams/following{/other_user}","gists_url":"https://api.github.com/users/ashleygwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleygwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleygwilliams/subscriptions","organizations_url":"https://api.github.com/users/ashleygwilliams/orgs","repos_url":"https://api.github.com/users/ashleygwilliams/repos","events_url":"https://api.github.com/users/ashleygwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/ashleygwilliams/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2018-06-19T20:27:02Z","updated_at":"2018-07-10T20:23:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200/commits","review_comments_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200/comments","review_comment_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/200/comments","statuses_url":"https://api.github.com/repos/rustwasm/wasm-pack/statuses/042ef9b0269944f5224d6abb350c9c01e1e931bd","head":{"label":"mciantyre:master","ref":"master","sha":"042ef9b0269944f5224d6abb350c9c01e1e931bd","user":{"login":"mciantyre","id":7933926,"node_id":"MDQ6VXNlcjc5MzM5MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/7933926?v=4","gravatar_id":"","url":"https://api.github.com/users/mciantyre","html_url":"https://github.com/mciantyre","followers_url":"https://api.github.com/users/mciantyre/followers","following_url":"https://api.github.com/users/mciantyre/following{/other_user}","gists_url":"https://api.github.com/users/mciantyre/gists{/gist_id}","starred_url":"https://api.github.com/users/mciantyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mciantyre/subscriptions","organizations_url":"https://api.github.com/users/mciantyre/orgs","repos_url":"https://api.github.com/users/mciantyre/repos","events_url":"https://api.github.com/users/mciantyre/events{/privacy}","received_events_url":"https://api.github.com/users/mciantyre/received_events","type":"User","site_admin":false},"repo":{"id":140034869,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMzQ4Njk=","name":"wasm-pack","full_name":"mciantyre/wasm-pack","owner":{"login":"mciantyre","id":7933926,"node_id":"MDQ6VXNlcjc5MzM5MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/7933926?v=4","gravatar_id":"","url":"https://api.github.com/users/mciantyre","html_url":"https://github.com/mciantyre","followers_url":"https://api.github.com/users/mciantyre/followers","following_url":"https://api.github.com/users/mciantyre/following{/other_user}","gists_url":"https://api.github.com/users/mciantyre/gists{/gist_id}","starred_url":"https://api.github.com/users/mciantyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mciantyre/subscriptions","organizations_url":"https://api.github.com/users/mciantyre/orgs","repos_url":"https://api.github.com/users/mciantyre/repos","events_url":"https://api.github.com/users/mciantyre/events{/privacy}","received_events_url":"https://api.github.com/users/mciantyre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mciantyre/wasm-pack","description":"📦✨ your favorite rust -> wasm workflow tool!","fork":true,"url":"https://api.github.com/repos/mciantyre/wasm-pack","forks_url":"https://api.github.com/repos/mciantyre/wasm-pack/forks","keys_url":"https://api.github.com/repos/mciantyre/wasm-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mciantyre/wasm-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mciantyre/wasm-pack/teams","hooks_url":"https://api.github.com/repos/mciantyre/wasm-pack/hooks","issue_events_url":"https://api.github.com/repos/mciantyre/wasm-pack/issues/events{/number}","events_url":"https://api.github.com/repos/mciantyre/wasm-pack/events","assignees_url":"https://api.github.com/repos/mciantyre/wasm-pack/assignees{/user}","branches_url":"https://api.github.com/repos/mciantyre/wasm-pack/branches{/branch}","tags_url":"https://api.github.com/repos/mciantyre/wasm-pack/tags","blobs_url":"https://api.github.com/repos/mciantyre/wasm-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mciantyre/wasm-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mciantyre/wasm-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mciantyre/wasm-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mciantyre/wasm-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/mciantyre/wasm-pack/languages","stargazers_url":"https://api.github.com/repos/mciantyre/wasm-pack/stargazers","contributors_url":"https://api.github.com/repos/mciantyre/wasm-pack/contributors","subscribers_url":"https://api.github.com/repos/mciantyre/wasm-pack/subscribers","subscription_url":"https://api.github.com/repos/mciantyre/wasm-pack/subscription","commits_url":"https://api.github.com/repos/mciantyre/wasm-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mciantyre/wasm-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mciantyre/wasm-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mciantyre/wasm-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mciantyre/wasm-pack/contents/{+path}","compare_url":"https://api.github.com/repos/mciantyre/wasm-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mciantyre/wasm-pack/merges","archive_url":"https://api.github.com/repos/mciantyre/wasm-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mciantyre/wasm-pack/downloads","issues_url":"https://api.github.com/repos/mciantyre/wasm-pack/issues{/number}","pulls_url":"https://api.github.com/repos/mciantyre/wasm-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/mciantyre/wasm-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/mciantyre/wasm-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mciantyre/wasm-pack/labels{/name}","releases_url":"https://api.github.com/repos/mciantyre/wasm-pack/releases{/id}","deployments_url":"https://api.github.com/repos/mciantyre/wasm-pack/deployments","created_at":"2018-07-06T22:25:38Z","updated_at":"2018-07-11T00:03:49Z","pushed_at":"2018-07-11T00:03:47Z","git_url":"git://github.com/mciantyre/wasm-pack.git","ssh_url":"git@github.com:mciantyre/wasm-pack.git","clone_url":"https://github.com/mciantyre/wasm-pack.git","svn_url":"https://github.com/mciantyre/wasm-pack","homepage":"https://crates.io/crates/wasm-pack","size":888,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rustwasm:master","ref":"master","sha":"a7324f7528b6cb3c68d6ef565a12c3810d365e20","user":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"repo":{"id":121253762,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNTM3NjI=","name":"wasm-pack","full_name":"rustwasm/wasm-pack","owner":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rustwasm/wasm-pack","description":"📦✨ your favorite rust -> wasm workflow tool!","fork":false,"url":"https://api.github.com/repos/rustwasm/wasm-pack","forks_url":"https://api.github.com/repos/rustwasm/wasm-pack/forks","keys_url":"https://api.github.com/repos/rustwasm/wasm-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustwasm/wasm-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustwasm/wasm-pack/teams","hooks_url":"https://api.github.com/repos/rustwasm/wasm-pack/hooks","issue_events_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/events{/number}","events_url":"https://api.github.com/repos/rustwasm/wasm-pack/events","assignees_url":"https://api.github.com/repos/rustwasm/wasm-pack/assignees{/user}","branches_url":"https://api.github.com/repos/rustwasm/wasm-pack/branches{/branch}","tags_url":"https://api.github.com/repos/rustwasm/wasm-pack/tags","blobs_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustwasm/wasm-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/rustwasm/wasm-pack/languages","stargazers_url":"https://api.github.com/repos/rustwasm/wasm-pack/stargazers","contributors_url":"https://api.github.com/repos/rustwasm/wasm-pack/contributors","subscribers_url":"https://api.github.com/repos/rustwasm/wasm-pack/subscribers","subscription_url":"https://api.github.com/repos/rustwasm/wasm-pack/subscription","commits_url":"https://api.github.com/repos/rustwasm/wasm-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustwasm/wasm-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustwasm/wasm-pack/contents/{+path}","compare_url":"https://api.github.com/repos/rustwasm/wasm-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustwasm/wasm-pack/merges","archive_url":"https://api.github.com/repos/rustwasm/wasm-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustwasm/wasm-pack/downloads","issues_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues{/number}","pulls_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/rustwasm/wasm-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/rustwasm/wasm-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustwasm/wasm-pack/labels{/name}","releases_url":"https://api.github.com/repos/rustwasm/wasm-pack/releases{/id}","deployments_url":"https://api.github.com/repos/rustwasm/wasm-pack/deployments","created_at":"2018-02-12T14:04:34Z","updated_at":"2018-07-12T21:52:43Z","pushed_at":"2018-07-11T00:03:48Z","git_url":"git://github.com/rustwasm/wasm-pack.git","ssh_url":"git@github.com:rustwasm/wasm-pack.git","clone_url":"https://github.com/rustwasm/wasm-pack.git","svn_url":"https://github.com/rustwasm/wasm-pack","homepage":"https://crates.io/crates/wasm-pack","size":883,"stargazers_count":763,"watchers_count":763,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":44,"open_issues":28,"watchers":763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200"},"html":{"href":"https://github.com/rustwasm/wasm-pack/pull/200"},"issue":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/issues/200"},"comments":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/statuses/042ef9b0269944f5224d6abb350c9c01e1e931bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"ashleygwilliams"}}