{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7684","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7684/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7684/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7684/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7684","id":319040541,"number":7684,"title":"Issue/7540 followed blog notifications","user":{"login":"theck13","id":3827611,"avatar_url":"https://avatars2.githubusercontent.com/u/3827611?v=4","gravatar_id":"","url":"https://api.github.com/users/theck13","html_url":"https://github.com/theck13","followers_url":"https://api.github.com/users/theck13/followers","following_url":"https://api.github.com/users/theck13/following{/other_user}","gists_url":"https://api.github.com/users/theck13/gists{/gist_id}","starred_url":"https://api.github.com/users/theck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theck13/subscriptions","organizations_url":"https://api.github.com/users/theck13/orgs","repos_url":"https://api.github.com/users/theck13/repos","events_url":"https://api.github.com/users/theck13/events{/privacy}","received_events_url":"https://api.github.com/users/theck13/received_events","type":"User","site_admin":false},"labels":[{"id":90791782,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Notifications","name":"Notifications","color":"006b75","default":false},{"id":88251544,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Reader","name":"Reader","color":"006b75","default":false},{"id":538686626,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Status]%20Needs%20Design%20Review","name":"[Status] Needs Design Review","color":"13CDF7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-30T21:22:12Z","updated_at":"2018-05-03T13:35:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/7684","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7684","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7684.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7684.patch"},"body":"### Fix\r\nThis is only ***Part 2 of 2*** for the [Notification for Followed Blogs issue](https://github.com/wordpress-mobile/WordPress-Android/issues/7540).  I divided the issue into two parts so the pull requests aren't too big.\r\n\r\nIn the Reader, add an item to followed blogs' overflow menu to allow toggling post notifications as well as an actionable message to enable post notifications when a blog is followed.  See the screenshots below for illustration.\r\n\r\n![reader_follow](https://user-images.githubusercontent.com/3827611/39450532-e89f33c6-4c88-11e8-8b15-f79c20b38e21.png)\r\n\r\n![reader_menu_on](https://user-images.githubusercontent.com/3827611/39450539-ead6c5d2-4c88-11e8-95e8-b297bb4f2392.png)\r\n\r\n![reader_menu_off](https://user-images.githubusercontent.com/3827611/39450540-ec639542-4c88-11e8-87a7-939a24d4a248.png)\r\n\r\n### Test\r\n#### Follow Button\r\n1. Go to ***Reader*** tab.\r\n2. Tap ***Follow*** button.\r\n3. Notice message and action at bottom of screen.\r\n4. Tap ***Enable*** button.\r\n5. Go to ***Me*** tab.\r\n6. Tap ***Notification Settings*** item.\r\n7. Tap site followed in Step 2 under ***Followed Sites*** section.\r\n8. Notice ***New Posts*** item is enabled.\r\n\r\n#### Overflow Menu\r\n1. Go to ***Reader*** tab.\r\n2. Tap overflow menu button of followed site without notifications.\r\n3. Tap ***Turn on site notifications*** item.\r\n4. Go to ***Me*** tab.\r\n5. Tap ***Notification Settings*** item.\r\n6. Tap site followed in Step 2 under ***Followed Sites*** section.\r\n7. Notice ***New Posts*** item is enabled.\r\n8. Go to ***Reader*** tab.\r\n9. Tap overflow menu button of followed site with notifications.\r\n10. Tap ***Turn off site notifications*** item.\r\n11. Go to ***Me*** tab.\r\n12. Tap ***Notification Settings*** item.\r\n13. Tap site followed in Step 9 under ***Followed Sites*** section.\r\n14. Notice ***New Posts*** item is disabled."},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/386297429","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7684#issuecomment-386297429","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7684","id":386297429,"user":{"login":"theck13","id":3827611,"avatar_url":"https://avatars2.githubusercontent.com/u/3827611?v=4","gravatar_id":"","url":"https://api.github.com/users/theck13","html_url":"https://github.com/theck13","followers_url":"https://api.github.com/users/theck13/followers","following_url":"https://api.github.com/users/theck13/following{/other_user}","gists_url":"https://api.github.com/users/theck13/gists{/gist_id}","starred_url":"https://api.github.com/users/theck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theck13/subscriptions","organizations_url":"https://api.github.com/users/theck13/orgs","repos_url":"https://api.github.com/users/theck13/repos","events_url":"https://api.github.com/users/theck13/events{/privacy}","received_events_url":"https://api.github.com/users/theck13/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T13:35:21Z","updated_at":"2018-05-03T13:35:21Z","author_association":"CONTRIBUTOR","body":"> Can we add the missing 8dp top/bottom paddings on the menu itself per:\r\nhttps://storage.googleapis.com/material-design/publish/material_v_12/assets/0Bzhp5Z4wHba3aEFjbTF1T1FjQTQ/components-menus-specs1.png\r\n\r\nThe style used for the popup menu was change from [Holo](https://github.com/wordpress-mobile/WordPress-Android/pull/7684/files#diff-f192db36c795cee49fabc173724ad0f7L75) (i.e. circa 2007) to [AppCompat](https://github.com/wordpress-mobile/WordPress-Android/pull/7684/files#diff-f192db36c795cee49fabc173724ad0f7R75) (i.e. Material-like compatibility version).\r\n\r\n> And let's also change the menu background colour to white. Not sure why we use the egg shell colour for these.\r\n\r\nIt uses the default/standard [ListPopupWindow](https://github.com/wordpress-mobile/WordPress-Android/pull/7684/files#diff-6c7a325968c55524fd50f1a8ee490c51R1570), which uses `#fafafa` as the background color.  I changed the [style for all dropdown](https://github.com/wordpress-mobile/WordPress-Android/pull/7684/files#diff-f192db36c795cee49fabc173724ad0f7R76) lists to `#ffffff` in 51c6ac0.  See the screenshots below for illustration.\r\n\r\n![popup_background](https://user-images.githubusercontent.com/3827611/39560526-fb577ef4-4e5b-11e8-8e91-6b3ab1782449.png)\r\n\r\n> Is it also possible to move the menu away from the edge of the screen by 16dp? As it's sitting exactly flush to the edge now.\r\n\r\nI can't offset it relative to the screen in a non-hacky way, but I forced the popup view (i.e. action list) gravity to the end of the anchor view (i.e. ellipsis icon) since the anchor view is `16dp` from the edge of the screen, which is effectively the same result, in 4c3bfbf.  See the screenshots below for illustration.\r\n\r\n![popup_margin](https://user-images.githubusercontent.com/3827611/39560529-ff6650c4-4e5b-11e8-8914-69a67c87b4be.png)"}}
{"actor":{"display_login":"theck13"}}