{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24815","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24815/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24815/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24815/events","html_url":"https://github.com/cockroachdb/cockroach/pull/24815","id":314449671,"number":24815,"title":"opt: inherit ordering for aggregations","user":{"login":"justinj","id":409075,"avatar_url":"https://avatars2.githubusercontent.com/u/409075?v=4","gravatar_id":"","url":"https://api.github.com/users/justinj","html_url":"https://github.com/justinj","followers_url":"https://api.github.com/users/justinj/followers","following_url":"https://api.github.com/users/justinj/following{/other_user}","gists_url":"https://api.github.com/users/justinj/gists{/gist_id}","starred_url":"https://api.github.com/users/justinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinj/subscriptions","organizations_url":"https://api.github.com/users/justinj/orgs","repos_url":"https://api.github.com/users/justinj/repos","events_url":"https://api.github.com/users/justinj/events{/privacy}","received_events_url":"https://api.github.com/users/justinj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-15T20:37:27Z","updated_at":"2018-05-14T16:59:02Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24815","html_url":"https://github.com/cockroachdb/cockroach/pull/24815","diff_url":"https://github.com/cockroachdb/cockroach/pull/24815.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/24815.patch"},"body":"Certain aggregates are non-commutative, and thus their inputs can\r\nrequire particular orderings.\r\n\r\nThis commit allows inputs which have an explicit ordering to have that\r\nordering be passed up to the group by.\r\n\r\nThis removed ColSet from any explicit expr, which means its struct is no\r\nlonger generated and there doesn't seem to be an easy way to keep around\r\nits intern and associated tests. I figure we can always grab if out of\r\nversion control if we re-introduce it.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/388888922","html_url":"https://github.com/cockroachdb/cockroach/pull/24815#issuecomment-388888922","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24815","id":388888922,"user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T16:59:01Z","updated_at":"2018-05-14T16:59:01Z","author_association":"OWNER","body":"@justinj any update on this? With enabling distsql, I'm finding I have to disable certain execbuilder testcases (like `SELECT CONCAT_AGG(s) FROM (SELECT s FROM kv ORDER BY k)`)."}}
{"actor":{"display_login":"RaduBerinde"}}