{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/comments/184472205","pull_request_review_id":115676692,"id":184472205,"diff_hunk":"@@ -0,0 +1,12 @@\n+---\n+ath:\n+  athRevision: \"dad333092159cb368efc2f9869572f0a05d255ac\"\n+  tests:\n+    - \"GitPluginTest\"\n+    - \"GitUserContentTest\"\n+    - \"MultipleScmsPluginTest\"\n+    - \"WorkflowPluginTest#hello_world_from_git\"\n+    - \"WorkflowPluginTest#testSharedLibraryFromGithub\"","path":"essentials.yml","position":9,"original_position":9,"commit_id":"81c9601120e5b0c4862afc13769601fa326e87ce","original_commit_id":"81c9601120e5b0c4862afc13769601fa326e87ce","user":{"login":"raul-arabaolaza","id":642531,"avatar_url":"https://avatars0.githubusercontent.com/u/642531?v=4","gravatar_id":"","url":"https://api.github.com/users/raul-arabaolaza","html_url":"https://github.com/raul-arabaolaza","followers_url":"https://api.github.com/users/raul-arabaolaza/followers","following_url":"https://api.github.com/users/raul-arabaolaza/following{/other_user}","gists_url":"https://api.github.com/users/raul-arabaolaza/gists{/gist_id}","starred_url":"https://api.github.com/users/raul-arabaolaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raul-arabaolaza/subscriptions","organizations_url":"https://api.github.com/users/raul-arabaolaza/orgs","repos_url":"https://api.github.com/users/raul-arabaolaza/repos","events_url":"https://api.github.com/users/raul-arabaolaza/events{/privacy}","received_events_url":"https://api.github.com/users/raul-arabaolaza/received_events","type":"User","site_admin":false},"body":"And what is the value to test against an old version of {{workflow-multibranch}} in a PR?, in the case that you comment, and I agree is possible, IMO the PR has fulfilled its objective of finding a problem with the latest released version of {{workflow-multibranch}} and should be fixed.\r\n\r\nOnce all the work related to JEP-305 is in place and there is a way to deterministically  use the latest versions of plugins under test I heartily agree that CWP is the way to go, that is the reason I have created JENKINS-51008 ","created_at":"2018-04-26T17:33:26Z","updated_at":"2018-04-26T17:33:27Z","html_url":"https://github.com/jenkinsci/git-plugin/pull/585#discussion_r184472205","pull_request_url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/comments/184472205"},"html":{"href":"https://github.com/jenkinsci/git-plugin/pull/585#discussion_r184472205"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585"}},"in_reply_to_id":184466446},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585","id":184274384,"html_url":"https://github.com/jenkinsci/git-plugin/pull/585","diff_url":"https://github.com/jenkinsci/git-plugin/pull/585.diff","patch_url":"https://github.com/jenkinsci/git-plugin/pull/585.patch","issue_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585","number":585,"state":"open","locked":false,"title":"[WIP] [JENKINS-50621] Essentials Flow - Part 1","user":{"login":"raul-arabaolaza","id":642531,"avatar_url":"https://avatars0.githubusercontent.com/u/642531?v=4","gravatar_id":"","url":"https://api.github.com/users/raul-arabaolaza","html_url":"https://github.com/raul-arabaolaza","followers_url":"https://api.github.com/users/raul-arabaolaza/followers","following_url":"https://api.github.com/users/raul-arabaolaza/following{/other_user}","gists_url":"https://api.github.com/users/raul-arabaolaza/gists{/gist_id}","starred_url":"https://api.github.com/users/raul-arabaolaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raul-arabaolaza/subscriptions","organizations_url":"https://api.github.com/users/raul-arabaolaza/orgs","repos_url":"https://api.github.com/users/raul-arabaolaza/repos","events_url":"https://api.github.com/users/raul-arabaolaza/events{/privacy}","received_events_url":"https://api.github.com/users/raul-arabaolaza/received_events","type":"User","site_admin":false},"body":"## JENKINS-50621 - Add ATH and PCT to the development flow\r\n\r\nSee the comments on JENKINS-50540,  this is going to be augmented via the Custom War Packager and JEP-305 in follow up PRs\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [X] I have read the [CONTRIBUTING](https://github.com/jenkinsci/git-plugin/blob/master/CONTRIBUTING.md) doc\r\n- [X] I have referenced the Jira issue related to my changes in one or more commit messages\r\n- [ ] I have added tests that verify my changes\r\n- [X] Unit tests pass locally with my changes\r\n- [ ] I have added documentation as necessary\r\n- [ ] No Javadoc warnings were introduced with my changes\r\n- [ ] No findbugs warnings were introduced with my changes\r\n- [X] I have interactively tested my changes\r\n- [ ] Any dependent changes have been merged and published in upstream modules (like git-client-plugin)\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce? _Put an `x` in the boxes that apply_\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [X] Development flow changes\r\n\r\n## Further comments\r\n\r\nThis PR can not be merged until [pipeline-library#48](https://github.com/jenkins-infra/pipeline-library/pull/48) is merged\r\n\r\n*Note that as I am not a trusted source the PR Builder is not going to use the changes in the Jenkinsfile, I hope for some maintainer to be able to do a Replay to test it, I have tested it successfully on my development environment*","created_at":"2018-04-26T09:14:01Z","updated_at":"2018-04-26T17:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb87cf3dca02c693de33b8800a46e5fce6b9aec6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585/comments","statuses_url":"https://api.github.com/repos/jenkinsci/git-plugin/statuses/81c9601120e5b0c4862afc13769601fa326e87ce","head":{"label":"raul-arabaolaza:JENKINS-50621-2","ref":"JENKINS-50621-2","sha":"81c9601120e5b0c4862afc13769601fa326e87ce","user":{"login":"raul-arabaolaza","id":642531,"avatar_url":"https://avatars0.githubusercontent.com/u/642531?v=4","gravatar_id":"","url":"https://api.github.com/users/raul-arabaolaza","html_url":"https://github.com/raul-arabaolaza","followers_url":"https://api.github.com/users/raul-arabaolaza/followers","following_url":"https://api.github.com/users/raul-arabaolaza/following{/other_user}","gists_url":"https://api.github.com/users/raul-arabaolaza/gists{/gist_id}","starred_url":"https://api.github.com/users/raul-arabaolaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raul-arabaolaza/subscriptions","organizations_url":"https://api.github.com/users/raul-arabaolaza/orgs","repos_url":"https://api.github.com/users/raul-arabaolaza/repos","events_url":"https://api.github.com/users/raul-arabaolaza/events{/privacy}","received_events_url":"https://api.github.com/users/raul-arabaolaza/received_events","type":"User","site_admin":false},"repo":{"id":73092119,"name":"git-plugin","full_name":"raul-arabaolaza/git-plugin","owner":{"login":"raul-arabaolaza","id":642531,"avatar_url":"https://avatars0.githubusercontent.com/u/642531?v=4","gravatar_id":"","url":"https://api.github.com/users/raul-arabaolaza","html_url":"https://github.com/raul-arabaolaza","followers_url":"https://api.github.com/users/raul-arabaolaza/followers","following_url":"https://api.github.com/users/raul-arabaolaza/following{/other_user}","gists_url":"https://api.github.com/users/raul-arabaolaza/gists{/gist_id}","starred_url":"https://api.github.com/users/raul-arabaolaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raul-arabaolaza/subscriptions","organizations_url":"https://api.github.com/users/raul-arabaolaza/orgs","repos_url":"https://api.github.com/users/raul-arabaolaza/repos","events_url":"https://api.github.com/users/raul-arabaolaza/events{/privacy}","received_events_url":"https://api.github.com/users/raul-arabaolaza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raul-arabaolaza/git-plugin","description":"Git plugin for Jenkins","fork":true,"url":"https://api.github.com/repos/raul-arabaolaza/git-plugin","forks_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/forks","keys_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/teams","hooks_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/hooks","issue_events_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/events","assignees_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/tags","blobs_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/languages","stargazers_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/stargazers","contributors_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/contributors","subscribers_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/subscribers","subscription_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/subscription","commits_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/merges","archive_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/downloads","issues_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/labels{/name}","releases_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/raul-arabaolaza/git-plugin/deployments","created_at":"2016-11-07T15:26:52Z","updated_at":"2018-04-24T09:49:38Z","pushed_at":"2018-04-26T17:02:24Z","git_url":"git://github.com/raul-arabaolaza/git-plugin.git","ssh_url":"git@github.com:raul-arabaolaza/git-plugin.git","clone_url":"https://github.com/raul-arabaolaza/git-plugin.git","svn_url":"https://github.com/raul-arabaolaza/git-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/Git Plugin","size":5527,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"44e9eb0716165de33f277fd2552d6a4de2961bb0","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":612587,"name":"git-plugin","full_name":"jenkinsci/git-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/git-plugin","description":"Jenkins Git plugin ","fork":true,"url":"https://api.github.com/repos/jenkinsci/git-plugin","forks_url":"https://api.github.com/repos/jenkinsci/git-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/git-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/git-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/git-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/git-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/git-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/git-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/git-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/git-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/git-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/git-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/git-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/git-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/git-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/git-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/git-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/git-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/git-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/git-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/git-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/git-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/git-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/git-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/git-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/git-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/git-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/git-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/git-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/git-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/git-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/git-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/git-plugin/deployments","created_at":"2010-04-15T21:07:21Z","updated_at":"2018-04-25T03:57:11Z","pushed_at":"2018-04-26T17:02:28Z","git_url":"git://github.com/jenkinsci/git-plugin.git","ssh_url":"git@github.com:jenkinsci/git-plugin.git","clone_url":"https://github.com/jenkinsci/git-plugin.git","svn_url":"https://github.com/jenkinsci/git-plugin","homepage":"https://plugins.jenkins.io/git","size":5647,"stargazers_count":483,"watchers_count":483,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":732,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":732,"open_issues":67,"watchers":483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585"},"html":{"href":"https://github.com/jenkinsci/git-plugin/pull/585"},"issue":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585"},"comments":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/git-plugin/statuses/81c9601120e5b0c4862afc13769601fa326e87ce"}},"author_association":"NONE"}}
{"actor":{"display_login":"raul-arabaolaza"}}