{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/2632","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/2632/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/2632/comments","events_url":"https://api.github.com/repos/knative/serving/issues/2632/events","html_url":"https://github.com/knative/serving/pull/2632","id":387585234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDQwNDU4","number":2632,"title":"This change makes Revision reconcile Deployments.","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"greghaynes","id":42657,"node_id":"MDQ6VXNlcjQyNjU3","avatar_url":"https://avatars2.githubusercontent.com/u/42657?v=4","gravatar_id":"","url":"https://api.github.com/users/greghaynes","html_url":"https://github.com/greghaynes","followers_url":"https://api.github.com/users/greghaynes/followers","following_url":"https://api.github.com/users/greghaynes/following{/other_user}","gists_url":"https://api.github.com/users/greghaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/greghaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghaynes/subscriptions","organizations_url":"https://api.github.com/users/greghaynes/orgs","repos_url":"https://api.github.com/users/greghaynes/repos","events_url":"https://api.github.com/users/greghaynes/events{/privacy}","received_events_url":"https://api.github.com/users/greghaynes/received_events","type":"User","site_admin":false},"assignees":[{"login":"greghaynes","id":42657,"node_id":"MDQ6VXNlcjQyNjU3","avatar_url":"https://avatars2.githubusercontent.com/u/42657?v=4","gravatar_id":"","url":"https://api.github.com/users/greghaynes","html_url":"https://github.com/greghaynes","followers_url":"https://api.github.com/users/greghaynes/followers","following_url":"https://api.github.com/users/greghaynes/following{/other_user}","gists_url":"https://api.github.com/users/greghaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/greghaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghaynes/subscriptions","organizations_url":"https://api.github.com/users/greghaynes/orgs","repos_url":"https://api.github.com/users/greghaynes/repos","events_url":"https://api.github.com/users/greghaynes/events{/privacy}","received_events_url":"https://api.github.com/users/greghaynes/received_events","type":"User","site_admin":false},{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},{"login":"dgerd","id":43425586,"node_id":"MDQ6VXNlcjQzNDI1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/43425586?v=4","gravatar_id":"","url":"https://api.github.com/users/dgerd","html_url":"https://github.com/dgerd","followers_url":"https://api.github.com/users/dgerd/followers","following_url":"https://api.github.com/users/dgerd/following{/other_user}","gists_url":"https://api.github.com/users/dgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/dgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgerd/subscriptions","organizations_url":"https://api.github.com/users/dgerd/orgs","repos_url":"https://api.github.com/users/dgerd/repos","events_url":"https://api.github.com/users/dgerd/events{/privacy}","received_events_url":"https://api.github.com/users/dgerd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":27,"created_at":"2018-12-05T04:10:21Z","updated_at":"2018-12-10T07:01:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2632","html_url":"https://github.com/knative/serving/pull/2632","diff_url":"https://github.com/knative/serving/pull/2632.diff","patch_url":"https://github.com/knative/serving/pull/2632.patch"},"body":"Previously we had problems with Deployment reconciliation because of the defaulting performed in the API Server.  With this change we attempt an Update if the Spec is not what we think it should be, but only treat it as a change if the Deployment we get back from the update is different from what we started from.  In this way, we avoid actually changing the deployment and triggering infinite reconciliations.\r\n\r\nThis change is sufficient for us to trigger Deployment reconciles (e.g. to replace sidecars) when folks apply a new version, but we will need https://github.com/knative/serving/issues/2332 as well for ConfigMap only changes to trigger a similar global resync.\r\n\r\nFixes: https://github.com/knative/serving/issues/639\r\n\r\n<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/445707734","html_url":"https://github.com/knative/serving/pull/2632#issuecomment-445707734","issue_url":"https://api.github.com/repos/knative/serving/issues/2632","id":445707734,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTcwNzczNA==","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T07:01:28Z","updated_at":"2018-12-10T07:01:28Z","author_association":"CONTRIBUTOR","body":"/lgtm"}}
{"actor":{"display_login":"markusthoemmes"}}