{"push_id":2396489613,"size":8,"distinct_size":1,"ref":"refs/heads/master","head":"41b8941402d669d53a72db42bcc273c20feb513d","before":"c8d198020717b8bbb4c3be4e47c06aab4085c7fc","commits":[{"sha":"8e98d84076984c8f4775387054ae22df85b8bdc1","author":{"name":"Tiago Martinho","email":"098da8dc424b05e2445e25e2e5097c269bbc469f@thoughtworks.com"},"message":"Set Swift version to 4.0.3 in Docker configuration (#89)\n\nMotivation:\r\nIn order to target the latest version of Swift and address this issue https://github.com/apple/swift-nio/issues/83\r\n\r\nModifications:\r\nSet the Swift version to the latest (4.0.3)\r\n\r\nResult:\r\nUniform version of Swift across the Ubuntu Docker image and a passing\r\ntest suite on all target platforms","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/8e98d84076984c8f4775387054ae22df85b8bdc1"},{"sha":"4deeaf6365075781641c149af6e994b0bc78ae1a","author":{"name":"Jason Toffaletti","email":"49f3372d00b4e908a78a39de90af1394c7c1ccdf@gmail.com"},"message":"make isOpen a computed property (#123)\n\nMotivation:\r\n\r\nReduce memory footprint of BaseSocket and FileHandle\r\n\r\nModifications:\r\n\r\n- made isOpen a computed var from 'descriptor >= 0'\r\n- add withSocketpair to TestUtils\r\n- use real pipe and socketpair file descriptors for tests\r\n- BaseSocket and FileHandle init check precondition 'descriptor >= 0'\r\n\r\nResult:\r\n\r\n- isOpen no longer requires storage space\r\n- close() sets descriptor to -1\r\n- descriptor property changed from let to var\r\n- tests will need to use valid file descriptors","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/4deeaf6365075781641c149af6e994b0bc78ae1a"},{"sha":"fee84ed63ae7618fabba661cea9d5e1fa96ff74e","author":{"name":"Cory Benfield","email":"2f0399c33984b400df0a08901c1cdb5c4abc104c@gmail.com"},"message":"Revert \"make isOpen a computed property (#123)\" (#129)\n\nThis reverts commit 4deeaf6365075781641c149af6e994b0bc78ae1a.","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/fee84ed63ae7618fabba661cea9d5e1fa96ff74e"},{"sha":"9ed09c0a5c632c07d8b5d59edbbe4a0e0329d934","author":{"name":"Cory Benfield","email":"2f0399c33984b400df0a08901c1cdb5c4abc104c@gmail.com"},"message":"Our sample HTTP server should respect HTTP keep-alive. (#115)\n\nMotivation:\r\n\r\nCurrently our HTTP server almost always just assumes that keep-alive\r\nis enabled. It really shouldn't, it should validate more carefully.\r\nAdditionally, it mishandles TCP half-close in a way that breaks with\r\nnetcat.\r\n\r\nModifications:\r\n\r\nAdded keep-alive tracking to all handlers and ensured that connections\r\nwill be closed after a response to a keep-alive request has been sent.\r\nAlso add support for handling TCP half-close.\r\n\r\nResult:\r\n\r\nNon-keep-alive connections will be closed by the server in all cases.\r\nHalf-closed connections will be appropriately managed.","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/9ed09c0a5c632c07d8b5d59edbbe4a0e0329d934"},{"sha":"ee60aa62c075c7e6de7ae140b0ea2a5af51f10b7","author":{"name":"Jason Toffaletti","email":"49f3372d00b4e908a78a39de90af1394c7c1ccdf@gmail.com"},"message":"properly destroy pthread mutex and cond (#133)\n\nproperly destroy pthread mutex and cond\r\n\r\nMotivation:\r\n\r\nproperly destroy pthread mutex and cond\r\n\r\nModifications:\r\n\r\ncall pthread_mutex_destroy in Lock deinit\r\ncall pthread_cond_destroy in ConditionLock deinit\r\n\r\nResult:\r\n\r\nLock and ConditionLock deinit may crash if locks are still in use.","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/ee60aa62c075c7e6de7ae140b0ea2a5af51f10b7"},{"sha":"1065c9d38e208980221f8f643652eced728e153e","author":{"name":"Johannes Weiß","email":"f27a17fc90c00d8c248d8510a1084221738b492b@tux4u.de"},"message":"add license headers for shell scripts (#135)\n\nMotivation:\r\n\r\nOur shell scripts didn't have license headers but they should.\r\n\r\nModifications:\r\n\r\nAdd licensing headers to all shell scripts\r\n\r\nResult:\r\n\r\nLicensing clear for shell scripts too.","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/1065c9d38e208980221f8f643652eced728e153e"},{"sha":"3cfbd075e42d33b62bb32d4db8636b1c885313f2","author":{"name":"Johannes Weiß","email":"f27a17fc90c00d8c248d8510a1084221738b492b@tux4u.de"},"message":"improve license header checking (#131)\n\nMotivation:\r\n\r\nWe need license headers at the top of all files but we didn't\r\nautomatically check for it in all source files.\r\n\r\nModifications:\r\n\r\nCheck for the full licensing header in all files (Swift, C & Shell).\r\n\r\nResult:\r\n\r\nIf we're missing a licensing header a PR won't turn green.","distinct":false,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/3cfbd075e42d33b62bb32d4db8636b1c885313f2"},{"sha":"41b8941402d669d53a72db42bcc273c20feb513d","author":{"name":"Ben Cohen","email":"e936d79561e1fec49cb70825b3709397e34e98af@users.noreply.github.com"},"message":"Nest HTTPHeaderIterator inside HTTPHeader, un-erase makeIterator() return type. (#94)\n\nMotivation:\r\n\r\nSimplifies the code by putting the iterator in HTTPHeader's namespace.\r\n\r\nAdditionally, removing the type erasure should result in more performant code as `AnyIterator` is an optimization barrier. The type erasure did not appear to be adding an abstraction benefit.\r\n\r\nModifications:\r\n\r\nNested (internal) type `HTTPHeaderIterator` as `HTTPHeader.Iterator`\r\nExplicit rather than inferred types for `Element` and `Iterator`.\r\nEliminated `AnyIterator` wrapper from `makeIterator()`\r\nAdded lower-priority version that still returns `AnyIterator` for source compatibility.\r\n\r\nResult:\r\n\r\nUnless caller was explicitly typing the iterator, should have no noticeable impact other than performance.","distinct":true,"url":"https://api.github.com/repos/toffaletti/swift-nio/commits/41b8941402d669d53a72db42bcc273c20feb513d"}]}
{"actor":{"display_login":"toffaletti"}}