{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/216067007","pull_request_review_id":153477234,"id":216067007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA2NzAwNw==","diff_hunk":"@@ -26,6 +26,42 @@\n   @include text-truncate;\n }\n \n+.oo-absolute-centered {\n+  @include absolute-center;\n+}\n+\n+.oo-flex-row-parent {\n+  @include flex-center-children(row);\n+  white-space: nowrap;\n+  flex-flow: row nowrap;\n+}\n+\n+.oo-flex-row {\n+  @include flexbox;\n+  @include flex-direction(row);\n+  flex: 1;\n+}\n+\n+.oo-flex-row:first-child > * { margin-right: auto; }\n+\n+.oo-flex-row:last-child > * { margin-left: auto; }\n+\n+.oo-flex-column-parent {\n+  @include flex-center-children(column);\n+  white-space: nowrap;\n+  flex-flow: column nowrap;\n+}\n+\n+.oo-flex-column {\n+  @include flexbox;\n+  @include flex-direction(column);\n+  flex: 1;\n+}\n+\n+.oo-flex-column:first-child > * { margin-bottom: auto; }\n+\n+.oo-flex-column:last-child > * { margin-top: auto; }","path":"scss/base/_utilities.scss","position":38,"original_position":38,"commit_id":"c5ea5e71f2fd39b8872ef99dc7df98a39d662f10","original_commit_id":"c5ea5e71f2fd39b8872ef99dc7df98a39d662f10","user":{"login":"jpfranco","id":1322503,"node_id":"MDQ6VXNlcjEzMjI1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1322503?v=4","gravatar_id":"","url":"https://api.github.com/users/jpfranco","html_url":"https://github.com/jpfranco","followers_url":"https://api.github.com/users/jpfranco/followers","following_url":"https://api.github.com/users/jpfranco/following{/other_user}","gists_url":"https://api.github.com/users/jpfranco/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfranco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfranco/subscriptions","organizations_url":"https://api.github.com/users/jpfranco/orgs","repos_url":"https://api.github.com/users/jpfranco/repos","events_url":"https://api.github.com/users/jpfranco/events{/privacy}","received_events_url":"https://api.github.com/users/jpfranco/received_events","type":"User","site_admin":false},"body":"Same as previous comment, I think it would better to avoid the `*` selector if possible","created_at":"2018-09-07T19:38:15Z","updated_at":"2018-09-07T19:38:15Z","html_url":"https://github.com/ooyala/html5-skin/pull/1126#discussion_r216067007","pull_request_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/216067007"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/1126#discussion_r216067007"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126","id":213788591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzg4NTkx","html_url":"https://github.com/ooyala/html5-skin/pull/1126","diff_url":"https://github.com/ooyala/html5-skin/pull/1126.diff","patch_url":"https://github.com/ooyala/html5-skin/pull/1126.patch","issue_url":"https://api.github.com/repos/ooyala/html5-skin/issues/1126","number":1126,"state":"open","locked":false,"title":"Player 4170 - Audio Only Player","user":{"login":"aeng7","id":14931241,"node_id":"MDQ6VXNlcjE0OTMxMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/14931241?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng7","html_url":"https://github.com/aeng7","followers_url":"https://api.github.com/users/aeng7/followers","following_url":"https://api.github.com/users/aeng7/following{/other_user}","gists_url":"https://api.github.com/users/aeng7/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng7/subscriptions","organizations_url":"https://api.github.com/users/aeng7/orgs","repos_url":"https://api.github.com/users/aeng7/repos","events_url":"https://api.github.com/users/aeng7/events{/privacy}","received_events_url":"https://api.github.com/users/aeng7/received_events","type":"User","site_admin":false},"body":"Main changes:\r\n\r\n-There is a new controller state ```audioOnly```, which is set to true if the skin config has it set to true\r\n-There is a new screen ```AudioOnlyScreen``` that is used if the player state is ```PLAYING```, ```PAUSED``` ,```END``` ,```START``` ,```INITIAL```\r\n-Control Bar now has a ```skipControls``` item definition. The scrubber bar is now an optional part of the Control Bar.\r\n-Skip Controls now have a ```playPause``` item definition\r\n-Various video only styles have been moved to classes with the suffix ```-video```. These were styles that were marked with ```!important``` or any other styles I did not want to spend too much time working around for the audio only player. These can be looked into in the future\r\n\r\nThere are a few open questions in the PLAYER-4170 ticket for Fernando. Work on these questions will start once he has answered them.","created_at":"2018-09-07T00:52:29Z","updated_at":"2018-09-07T19:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2352af4e2be3c0022c1fb37f915f03458f8846c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/issues/1126/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/c5ea5e71f2fd39b8872ef99dc7df98a39d662f10","head":{"label":"ooyala:player-4170","ref":"player-4170","sha":"c5ea5e71f2fd39b8872ef99dc7df98a39d662f10","user":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"node_id":"MDEwOlJlcG9zaXRvcnkzMjgzMDc3MA==","name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2018-09-05T20:57:27Z","pushed_at":"2018-09-07T17:11:16Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":6598,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":41,"open_issues":10,"watchers":22,"default_branch":"master"}},"base":{"label":"ooyala:master","ref":"master","sha":"6dc199e3951c47fd8fd94cf00e69ac0fd1b536c5","user":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"node_id":"MDEwOlJlcG9zaXRvcnkzMjgzMDc3MA==","name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2018-09-05T20:57:27Z","pushed_at":"2018-09-07T17:11:16Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":6598,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":41,"open_issues":10,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/1126"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/1126"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-skin/statuses/c5ea5e71f2fd39b8872ef99dc7df98a39d662f10"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jpfranco"}}