{"action":"created","comment":{"url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/comments/185419329","pull_request_review_id":116568117,"id":185419329,"diff_hunk":"@@ -0,0 +1,137 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.metamodel.hbase;\n+\n+import java.io.IOException;\n+\n+import org.apache.metamodel.AbstractUpdateCallback;\n+import org.apache.metamodel.UpdateCallback;\n+import org.apache.metamodel.create.TableCreationBuilder;\n+import org.apache.metamodel.delete.RowDeletionBuilder;\n+import org.apache.metamodel.drop.TableDropBuilder;\n+import org.apache.metamodel.insert.RowInsertionBuilder;\n+import org.apache.metamodel.schema.MutableSchema;\n+import org.apache.metamodel.schema.Schema;\n+import org.apache.metamodel.schema.Table;\n+\n+public class HBaseUpdateCallback extends AbstractUpdateCallback implements UpdateCallback {\n+\n+    private final HBaseConfiguration _configuration;\n+\n+    private final HBaseDataContext _dataContext;","path":"hbase/src/main/java/org/apache/metamodel/hbase/HBaseUpdateCallback.java","position":37,"original_position":37,"commit_id":"0ffeeb20af4d58061d042bb6ebccafb2ab7d6502","original_commit_id":"0ffeeb20af4d58061d042bb6ebccafb2ab7d6502","user":{"login":"arjansh","id":16542747,"avatar_url":"https://avatars1.githubusercontent.com/u/16542747?v=4","gravatar_id":"","url":"https://api.github.com/users/arjansh","html_url":"https://github.com/arjansh","followers_url":"https://api.github.com/users/arjansh/followers","following_url":"https://api.github.com/users/arjansh/following{/other_user}","gists_url":"https://api.github.com/users/arjansh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansh/subscriptions","organizations_url":"https://api.github.com/users/arjansh/orgs","repos_url":"https://api.github.com/users/arjansh/repos","events_url":"https://api.github.com/users/arjansh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansh/received_events","type":"User","site_admin":false},"body":"The `_dataContext` is already stored in the parent's class and accessible through the `AbstractUpdateCallback#getDataContext` method, so I would remove the field here. You can override the `getDataContext` method in this class with one that casts the returned `DataContext` object to the `HBaseDataContext` class.","created_at":"2018-05-02T08:05:05Z","updated_at":"2018-05-02T08:45:27Z","html_url":"https://github.com/GerardDellemann/metamodel/pull/2#discussion_r185419329","pull_request_url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/comments/185419329"},"html":{"href":"https://github.com/GerardDellemann/metamodel/pull/2#discussion_r185419329"},"pull_request":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2","id":185170929,"html_url":"https://github.com/GerardDellemann/metamodel/pull/2","diff_url":"https://github.com/GerardDellemann/metamodel/pull/2.diff","patch_url":"https://github.com/GerardDellemann/metamodel/pull/2.patch","issue_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues/2","number":2,"state":"open","locked":false,"title":"HBase improvements","user":{"login":"GerardDellemann","id":10583318,"avatar_url":"https://avatars1.githubusercontent.com/u/10583318?v=4","gravatar_id":"","url":"https://api.github.com/users/GerardDellemann","html_url":"https://github.com/GerardDellemann","followers_url":"https://api.github.com/users/GerardDellemann/followers","following_url":"https://api.github.com/users/GerardDellemann/following{/other_user}","gists_url":"https://api.github.com/users/GerardDellemann/gists{/gist_id}","starred_url":"https://api.github.com/users/GerardDellemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerardDellemann/subscriptions","organizations_url":"https://api.github.com/users/GerardDellemann/orgs","repos_url":"https://api.github.com/users/GerardDellemann/repos","events_url":"https://api.github.com/users/GerardDellemann/events{/privacy}","received_events_url":"https://api.github.com/users/GerardDellemann/received_events","type":"User","site_admin":false},"body":"HBase improvements - Added row-deletion functionality, also made HBaseDataContext implement UpdateableDataContext","created_at":"2018-05-01T12:39:41Z","updated_at":"2018-05-02T08:45:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"357d1495c06793d06610d03c7e930fc662ca8aaf","assignee":{"login":"arjansh","id":16542747,"avatar_url":"https://avatars1.githubusercontent.com/u/16542747?v=4","gravatar_id":"","url":"https://api.github.com/users/arjansh","html_url":"https://github.com/arjansh","followers_url":"https://api.github.com/users/arjansh/followers","following_url":"https://api.github.com/users/arjansh/following{/other_user}","gists_url":"https://api.github.com/users/arjansh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansh/subscriptions","organizations_url":"https://api.github.com/users/arjansh/orgs","repos_url":"https://api.github.com/users/arjansh/repos","events_url":"https://api.github.com/users/arjansh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansh/received_events","type":"User","site_admin":false},"assignees":[{"login":"arjansh","id":16542747,"avatar_url":"https://avatars1.githubusercontent.com/u/16542747?v=4","gravatar_id":"","url":"https://api.github.com/users/arjansh","html_url":"https://github.com/arjansh","followers_url":"https://api.github.com/users/arjansh/followers","following_url":"https://api.github.com/users/arjansh/following{/other_user}","gists_url":"https://api.github.com/users/arjansh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansh/subscriptions","organizations_url":"https://api.github.com/users/arjansh/orgs","repos_url":"https://api.github.com/users/arjansh/repos","events_url":"https://api.github.com/users/arjansh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2/commits","review_comments_url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2/comments","review_comment_url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues/2/comments","statuses_url":"https://api.github.com/repos/GerardDellemann/metamodel/statuses/0ffeeb20af4d58061d042bb6ebccafb2ab7d6502","head":{"label":"GerardDellemann:feature/hbase-improvements","ref":"feature/hbase-improvements","sha":"0ffeeb20af4d58061d042bb6ebccafb2ab7d6502","user":{"login":"GerardDellemann","id":10583318,"avatar_url":"https://avatars1.githubusercontent.com/u/10583318?v=4","gravatar_id":"","url":"https://api.github.com/users/GerardDellemann","html_url":"https://github.com/GerardDellemann","followers_url":"https://api.github.com/users/GerardDellemann/followers","following_url":"https://api.github.com/users/GerardDellemann/following{/other_user}","gists_url":"https://api.github.com/users/GerardDellemann/gists{/gist_id}","starred_url":"https://api.github.com/users/GerardDellemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerardDellemann/subscriptions","organizations_url":"https://api.github.com/users/GerardDellemann/orgs","repos_url":"https://api.github.com/users/GerardDellemann/repos","events_url":"https://api.github.com/users/GerardDellemann/events{/privacy}","received_events_url":"https://api.github.com/users/GerardDellemann/received_events","type":"User","site_admin":false},"repo":{"id":130360169,"name":"metamodel","full_name":"GerardDellemann/metamodel","owner":{"login":"GerardDellemann","id":10583318,"avatar_url":"https://avatars1.githubusercontent.com/u/10583318?v=4","gravatar_id":"","url":"https://api.github.com/users/GerardDellemann","html_url":"https://github.com/GerardDellemann","followers_url":"https://api.github.com/users/GerardDellemann/followers","following_url":"https://api.github.com/users/GerardDellemann/following{/other_user}","gists_url":"https://api.github.com/users/GerardDellemann/gists{/gist_id}","starred_url":"https://api.github.com/users/GerardDellemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerardDellemann/subscriptions","organizations_url":"https://api.github.com/users/GerardDellemann/orgs","repos_url":"https://api.github.com/users/GerardDellemann/repos","events_url":"https://api.github.com/users/GerardDellemann/events{/privacy}","received_events_url":"https://api.github.com/users/GerardDellemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GerardDellemann/metamodel","description":"Mirror of Apache Metamodel","fork":true,"url":"https://api.github.com/repos/GerardDellemann/metamodel","forks_url":"https://api.github.com/repos/GerardDellemann/metamodel/forks","keys_url":"https://api.github.com/repos/GerardDellemann/metamodel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GerardDellemann/metamodel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GerardDellemann/metamodel/teams","hooks_url":"https://api.github.com/repos/GerardDellemann/metamodel/hooks","issue_events_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues/events{/number}","events_url":"https://api.github.com/repos/GerardDellemann/metamodel/events","assignees_url":"https://api.github.com/repos/GerardDellemann/metamodel/assignees{/user}","branches_url":"https://api.github.com/repos/GerardDellemann/metamodel/branches{/branch}","tags_url":"https://api.github.com/repos/GerardDellemann/metamodel/tags","blobs_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/refs{/sha}","trees_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GerardDellemann/metamodel/statuses/{sha}","languages_url":"https://api.github.com/repos/GerardDellemann/metamodel/languages","stargazers_url":"https://api.github.com/repos/GerardDellemann/metamodel/stargazers","contributors_url":"https://api.github.com/repos/GerardDellemann/metamodel/contributors","subscribers_url":"https://api.github.com/repos/GerardDellemann/metamodel/subscribers","subscription_url":"https://api.github.com/repos/GerardDellemann/metamodel/subscription","commits_url":"https://api.github.com/repos/GerardDellemann/metamodel/commits{/sha}","git_commits_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/commits{/sha}","comments_url":"https://api.github.com/repos/GerardDellemann/metamodel/comments{/number}","issue_comment_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues/comments{/number}","contents_url":"https://api.github.com/repos/GerardDellemann/metamodel/contents/{+path}","compare_url":"https://api.github.com/repos/GerardDellemann/metamodel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GerardDellemann/metamodel/merges","archive_url":"https://api.github.com/repos/GerardDellemann/metamodel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GerardDellemann/metamodel/downloads","issues_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues{/number}","pulls_url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls{/number}","milestones_url":"https://api.github.com/repos/GerardDellemann/metamodel/milestones{/number}","notifications_url":"https://api.github.com/repos/GerardDellemann/metamodel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GerardDellemann/metamodel/labels{/name}","releases_url":"https://api.github.com/repos/GerardDellemann/metamodel/releases{/id}","deployments_url":"https://api.github.com/repos/GerardDellemann/metamodel/deployments","created_at":"2018-04-20T12:37:42Z","updated_at":"2018-04-20T12:37:48Z","pushed_at":"2018-05-01T12:39:42Z","git_url":"git://github.com/GerardDellemann/metamodel.git","ssh_url":"git@github.com:GerardDellemann/metamodel.git","clone_url":"https://github.com/GerardDellemann/metamodel.git","svn_url":"https://github.com/GerardDellemann/metamodel","homepage":null,"size":5024,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"GerardDellemann:master","ref":"master","sha":"fe02a59b8746e9988c3121cc6f5d03ca444dc8d3","user":{"login":"GerardDellemann","id":10583318,"avatar_url":"https://avatars1.githubusercontent.com/u/10583318?v=4","gravatar_id":"","url":"https://api.github.com/users/GerardDellemann","html_url":"https://github.com/GerardDellemann","followers_url":"https://api.github.com/users/GerardDellemann/followers","following_url":"https://api.github.com/users/GerardDellemann/following{/other_user}","gists_url":"https://api.github.com/users/GerardDellemann/gists{/gist_id}","starred_url":"https://api.github.com/users/GerardDellemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerardDellemann/subscriptions","organizations_url":"https://api.github.com/users/GerardDellemann/orgs","repos_url":"https://api.github.com/users/GerardDellemann/repos","events_url":"https://api.github.com/users/GerardDellemann/events{/privacy}","received_events_url":"https://api.github.com/users/GerardDellemann/received_events","type":"User","site_admin":false},"repo":{"id":130360169,"name":"metamodel","full_name":"GerardDellemann/metamodel","owner":{"login":"GerardDellemann","id":10583318,"avatar_url":"https://avatars1.githubusercontent.com/u/10583318?v=4","gravatar_id":"","url":"https://api.github.com/users/GerardDellemann","html_url":"https://github.com/GerardDellemann","followers_url":"https://api.github.com/users/GerardDellemann/followers","following_url":"https://api.github.com/users/GerardDellemann/following{/other_user}","gists_url":"https://api.github.com/users/GerardDellemann/gists{/gist_id}","starred_url":"https://api.github.com/users/GerardDellemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerardDellemann/subscriptions","organizations_url":"https://api.github.com/users/GerardDellemann/orgs","repos_url":"https://api.github.com/users/GerardDellemann/repos","events_url":"https://api.github.com/users/GerardDellemann/events{/privacy}","received_events_url":"https://api.github.com/users/GerardDellemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GerardDellemann/metamodel","description":"Mirror of Apache Metamodel","fork":true,"url":"https://api.github.com/repos/GerardDellemann/metamodel","forks_url":"https://api.github.com/repos/GerardDellemann/metamodel/forks","keys_url":"https://api.github.com/repos/GerardDellemann/metamodel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GerardDellemann/metamodel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GerardDellemann/metamodel/teams","hooks_url":"https://api.github.com/repos/GerardDellemann/metamodel/hooks","issue_events_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues/events{/number}","events_url":"https://api.github.com/repos/GerardDellemann/metamodel/events","assignees_url":"https://api.github.com/repos/GerardDellemann/metamodel/assignees{/user}","branches_url":"https://api.github.com/repos/GerardDellemann/metamodel/branches{/branch}","tags_url":"https://api.github.com/repos/GerardDellemann/metamodel/tags","blobs_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/refs{/sha}","trees_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GerardDellemann/metamodel/statuses/{sha}","languages_url":"https://api.github.com/repos/GerardDellemann/metamodel/languages","stargazers_url":"https://api.github.com/repos/GerardDellemann/metamodel/stargazers","contributors_url":"https://api.github.com/repos/GerardDellemann/metamodel/contributors","subscribers_url":"https://api.github.com/repos/GerardDellemann/metamodel/subscribers","subscription_url":"https://api.github.com/repos/GerardDellemann/metamodel/subscription","commits_url":"https://api.github.com/repos/GerardDellemann/metamodel/commits{/sha}","git_commits_url":"https://api.github.com/repos/GerardDellemann/metamodel/git/commits{/sha}","comments_url":"https://api.github.com/repos/GerardDellemann/metamodel/comments{/number}","issue_comment_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues/comments{/number}","contents_url":"https://api.github.com/repos/GerardDellemann/metamodel/contents/{+path}","compare_url":"https://api.github.com/repos/GerardDellemann/metamodel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GerardDellemann/metamodel/merges","archive_url":"https://api.github.com/repos/GerardDellemann/metamodel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GerardDellemann/metamodel/downloads","issues_url":"https://api.github.com/repos/GerardDellemann/metamodel/issues{/number}","pulls_url":"https://api.github.com/repos/GerardDellemann/metamodel/pulls{/number}","milestones_url":"https://api.github.com/repos/GerardDellemann/metamodel/milestones{/number}","notifications_url":"https://api.github.com/repos/GerardDellemann/metamodel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GerardDellemann/metamodel/labels{/name}","releases_url":"https://api.github.com/repos/GerardDellemann/metamodel/releases{/id}","deployments_url":"https://api.github.com/repos/GerardDellemann/metamodel/deployments","created_at":"2018-04-20T12:37:42Z","updated_at":"2018-04-20T12:37:48Z","pushed_at":"2018-05-01T12:39:42Z","git_url":"git://github.com/GerardDellemann/metamodel.git","ssh_url":"git@github.com:GerardDellemann/metamodel.git","clone_url":"https://github.com/GerardDellemann/metamodel.git","svn_url":"https://github.com/GerardDellemann/metamodel","homepage":null,"size":5024,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2"},"html":{"href":"https://github.com/GerardDellemann/metamodel/pull/2"},"issue":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/issues/2"},"comments":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/GerardDellemann/metamodel/statuses/0ffeeb20af4d58061d042bb6ebccafb2ab7d6502"}},"author_association":"OWNER"}}
{"actor":{"display_login":"arjansh"}}