{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/236079182","pull_request_review_id":178087430,"id":236079182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA3OTE4Mg==","diff_hunk":"@@ -131,7 +131,7 @@ static int _algorithm_central_counter(struct oshmem_group_t *group,\n                   group->my_pe, pSync[0], PE_root);\n \n     /* Check if this PE is the root */\n-    if (PE_root == group->my_pe) {\n+    if ((PE_root == group->my_pe) && nlong) {","path":"oshmem/mca/scoll/basic/scoll_basic_broadcast.c","position":5,"original_position":5,"commit_id":"9de128afaf5224193a88f00c897f5d5c94336f99","original_commit_id":"9de128afaf5224193a88f00c897f5d5c94336f99","user":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"body":"But it seems I'm wrong... Will fix tomorrow","created_at":"2018-11-25T16:04:29Z","updated_at":"2018-11-25T16:04:30Z","html_url":"https://github.com/open-mpi/ompi/pull/6104#discussion_r236079182","pull_request_url":"https://api.github.com/repos/open-mpi/ompi/pulls/6104","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/236079182"},"html":{"href":"https://github.com/open-mpi/ompi/pull/6104#discussion_r236079182"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/6104"}},"in_reply_to_id":236043822},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/6104","id":233153571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTUzNTcx","html_url":"https://github.com/open-mpi/ompi/pull/6104","diff_url":"https://github.com/open-mpi/ompi/pull/6104.diff","patch_url":"https://github.com/open-mpi/ompi/pull/6104.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/6104","number":6104,"state":"open","locked":false,"title":"OSHMEM: added processing of zero-length collectives","user":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"body":"- according spec 1.4, annex C shmem collectives should process\r\n  calls where number of elements is zero independently from pointer value\r\n- added zero-count processing - it just call barrier to\r\n  sync ranks\r\n\r\nSigned-off-by: Sergey Oblomov <sergeyo@mellanox.com>","created_at":"2018-11-23T10:10:31Z","updated_at":"2018-11-25T16:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daee2fcf8cd855d6f19a6b5bf71cc9c995a31f76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":659687073,"node_id":"MDU6TGFiZWw2NTk2ODcwNzM=","url":"https://api.github.com/repos/open-mpi/ompi/labels/Target:%20master","name":"Target: master","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/6104/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/6104/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/6104/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/9de128afaf5224193a88f00c897f5d5c94336f99","head":{"label":"hoopoepg:topic/oshmem-zero-len-coll","ref":"topic/oshmem-zero-len-coll","sha":"9de128afaf5224193a88f00c897f5d5c94336f99","user":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"repo":{"id":119408699,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDg2OTk=","name":"ompi","full_name":"hoopoepg/ompi","private":false,"owner":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hoopoepg/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/hoopoepg/ompi","forks_url":"https://api.github.com/repos/hoopoepg/ompi/forks","keys_url":"https://api.github.com/repos/hoopoepg/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoopoepg/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoopoepg/ompi/teams","hooks_url":"https://api.github.com/repos/hoopoepg/ompi/hooks","issue_events_url":"https://api.github.com/repos/hoopoepg/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/hoopoepg/ompi/events","assignees_url":"https://api.github.com/repos/hoopoepg/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/hoopoepg/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/hoopoepg/ompi/tags","blobs_url":"https://api.github.com/repos/hoopoepg/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoopoepg/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoopoepg/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoopoepg/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoopoepg/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/hoopoepg/ompi/languages","stargazers_url":"https://api.github.com/repos/hoopoepg/ompi/stargazers","contributors_url":"https://api.github.com/repos/hoopoepg/ompi/contributors","subscribers_url":"https://api.github.com/repos/hoopoepg/ompi/subscribers","subscription_url":"https://api.github.com/repos/hoopoepg/ompi/subscription","commits_url":"https://api.github.com/repos/hoopoepg/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoopoepg/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoopoepg/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoopoepg/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoopoepg/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/hoopoepg/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoopoepg/ompi/merges","archive_url":"https://api.github.com/repos/hoopoepg/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoopoepg/ompi/downloads","issues_url":"https://api.github.com/repos/hoopoepg/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/hoopoepg/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/hoopoepg/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/hoopoepg/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoopoepg/ompi/labels{/name}","releases_url":"https://api.github.com/repos/hoopoepg/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/hoopoepg/ompi/deployments","created_at":"2018-01-29T16:27:39Z","updated_at":"2018-01-29T16:28:02Z","pushed_at":"2018-11-23T12:35:22Z","git_url":"git://github.com/hoopoepg/ompi.git","ssh_url":"git@github.com:hoopoepg/ompi.git","clone_url":"https://github.com/hoopoepg/ompi.git","svn_url":"https://github.com/hoopoepg/ompi","homepage":null,"size":119993,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"f05ebe82d324ceef364bde779c588abea98fbb6f","user":{"login":"open-mpi","id":2165682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNjU2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"node_id":"MDEwOlJlcG9zaXRvcnkyNDEwNzAwMQ==","name":"ompi","full_name":"open-mpi/ompi","private":false,"owner":{"login":"open-mpi","id":2165682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNjU2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2018-11-24T12:52:00Z","pushed_at":"2018-11-23T12:35:24Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":120069,"stargazers_count":648,"watchers_count":648,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":360,"open_issues":387,"watchers":648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/6104"},"html":{"href":"https://github.com/open-mpi/ompi/pull/6104"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/6104"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/6104/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/6104/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/6104/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/9de128afaf5224193a88f00c897f5d5c94336f99"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hoopoepg"}}