{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/220525411","pull_request_review_id":158950566,"id":220525411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDUyNTQxMQ==","diff_hunk":"@@ -0,0 +1,184 @@\n+/*\n+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one\n+ * or more contributor license agreements. Licensed under the Elastic License;\n+ * you may not use this file except in compliance with the Elastic License.\n+ */\n+\n+import { EuiButton, EuiCallOut, EuiFieldText, EuiFormRow, EuiPanel, EuiSpacer } from '@elastic/eui';\n+import React, { ChangeEvent, Component, Fragment } from 'react';\n+import { LoginState } from '../../../../common/login_state';\n+\n+interface Props {\n+  http: any;\n+  window: any;\n+  infoMessage?: string;\n+  loginState: LoginState;\n+  next: string;\n+}\n+\n+interface State {\n+  hasError: boolean;\n+  isLoading: boolean;\n+  username: string;\n+  password: string;\n+  message: string;\n+}\n+\n+export class BasicLoginForm extends Component<Props, State> {\n+  public state = {\n+    hasError: false,\n+    isLoading: false,\n+    username: '',\n+    password: '',\n+    message: '',\n+  };\n+\n+  public componentDidMount() {\n+    document.addEventListener('keydown', this.submitOnEnter);\n+  }\n+\n+  public componentWillUnmount() {\n+    document.removeEventListener('keydown', this.submitOnEnter);\n+  }\n+\n+  public render() {\n+    return (\n+      <Fragment>\n+        {this.renderMessage()}\n+        <EuiPanel>\n+          <EuiFormRow label=\"Username\">\n+            <EuiFieldText\n+              name=\"username\"\n+              title=\"username\"\n+              data-test-subj=\"loginUsername\"\n+              value={this.state.username}\n+              onChange={this.onUsernameChange}\n+              disabled={this.state.isLoading}\n+              aria-required={true}","path":"x-pack/plugins/security/public/views/login/components/basic_login_form.tsx","position":57,"original_position":57,"commit_id":"4fe457859f781cef793600e49e3c2a763b5fb8b4","original_commit_id":"4fe457859f781cef793600e49e3c2a763b5fb8b4","user":{"login":"legrego","id":3493255,"node_id":"MDQ6VXNlcjM0OTMyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3493255?v=4","gravatar_id":"","url":"https://api.github.com/users/legrego","html_url":"https://github.com/legrego","followers_url":"https://api.github.com/users/legrego/followers","following_url":"https://api.github.com/users/legrego/following{/other_user}","gists_url":"https://api.github.com/users/legrego/gists{/gist_id}","starred_url":"https://api.github.com/users/legrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legrego/subscriptions","organizations_url":"https://api.github.com/users/legrego/orgs","repos_url":"https://api.github.com/users/legrego/repos","events_url":"https://api.github.com/users/legrego/events{/privacy}","received_events_url":"https://api.github.com/users/legrego/received_events","type":"User","site_admin":false},"body":"Changing `aria-required` to `required` marks the html form as invalid, which we are styling with a red background image. Since the user hasn't done anything wrong when first visiting the login page, this feels wrong to me. My first instinct is to override the EUI styles for this, but I wanted to get some other opinions before I took that rather blunt approach\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/3493255/46077364-95da5300-c15e-11e8-9323-9ceb1891db96.png)\r\n","created_at":"2018-09-26T11:34:52Z","updated_at":"2018-09-26T11:34:52Z","html_url":"https://github.com/elastic/kibana/pull/23512#discussion_r220525411","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/23512","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/220525411"},"html":{"href":"https://github.com/elastic/kibana/pull/23512#discussion_r220525411"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23512"}},"in_reply_to_id":220496154},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/23512","id":218112835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTEyODM1","html_url":"https://github.com/elastic/kibana/pull/23512","diff_url":"https://github.com/elastic/kibana/pull/23512.diff","patch_url":"https://github.com/elastic/kibana/pull/23512.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/23512","number":23512,"state":"open","locked":false,"title":"[WIP] - K7 Login screen","user":{"login":"legrego","id":3493255,"node_id":"MDQ6VXNlcjM0OTMyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3493255?v=4","gravatar_id":"","url":"https://api.github.com/users/legrego","html_url":"https://github.com/legrego","followers_url":"https://api.github.com/users/legrego/followers","following_url":"https://api.github.com/users/legrego/following{/other_user}","gists_url":"https://api.github.com/users/legrego/gists{/gist_id}","starred_url":"https://api.github.com/users/legrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legrego/subscriptions","organizations_url":"https://api.github.com/users/legrego/orgs","repos_url":"https://api.github.com/users/legrego/repos","events_url":"https://api.github.com/users/legrego/events{/privacy}","received_events_url":"https://api.github.com/users/legrego/received_events","type":"User","site_admin":false},"body":"[skip ci]\r\nThis PR is a POC for the K7 Login screen to start a design discussion. There are no tests yet, and I have a lot of cleanup to do.\r\n\r\n@ryankeairns @snide @kobelb \r\n\r\n## Login form\r\n<img width=\"1310\" alt=\"login\" src=\"https://user-images.githubusercontent.com/3493255/46048123-d9e53d80-c0f5-11e8-9e56-acbe3a8f2b5a.png\">\r\n\r\n## Invalid credentials\r\n<img width=\"1310\" alt=\"invalid creds\" src=\"https://user-images.githubusercontent.com/3493255/46048130-e10c4b80-c0f5-11e8-8645-8b143fc38de6.png\">\r\n\r\n## Session expired\r\n<img width=\"1310\" alt=\"session expired\" src=\"https://user-images.githubusercontent.com/3493255/46048143-eb2e4a00-c0f5-11e8-974e-8e1effe7a41a.png\">\r\n\r\n\r\n## No connection to Elasticsearch\r\n<img width=\"1418\" alt=\"no es\" src=\"https://user-images.githubusercontent.com/3493255/46041726-823cd700-c0e1-11e8-8e67-cc19387670d4.png\">\r\n\r\n## Insecure connection\r\n<img width=\"1418\" alt=\"insecure connection\" src=\"https://user-images.githubusercontent.com/3493255/46041748-8e289900-c0e1-11e8-95a8-eec5c35ab75a.png\">\r\n\r\n\r\n\r\nCloses #20015","created_at":"2018-09-25T20:42:42Z","updated_at":"2018-09-26T11:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83b147b489604dc0a53f6e6be32b34f6ba1007d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":820277882,"node_id":"MDU6TGFiZWw4MjAyNzc4ODI=","url":"https://api.github.com/repos/elastic/kibana/labels/:Security","name":":Security","color":"fef2c0","default":false},{"id":409457688,"node_id":"MDU6TGFiZWw0MDk0NTc2ODg=","url":"https://api.github.com/repos/elastic/kibana/labels/WIP","name":"WIP","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/23512/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/23512/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/23512/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/4fe457859f781cef793600e49e3c2a763b5fb8b4","head":{"label":"legrego:k7-login","ref":"k7-login","sha":"4fe457859f781cef793600e49e3c2a763b5fb8b4","user":{"login":"legrego","id":3493255,"node_id":"MDQ6VXNlcjM0OTMyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3493255?v=4","gravatar_id":"","url":"https://api.github.com/users/legrego","html_url":"https://github.com/legrego","followers_url":"https://api.github.com/users/legrego/followers","following_url":"https://api.github.com/users/legrego/following{/other_user}","gists_url":"https://api.github.com/users/legrego/gists{/gist_id}","starred_url":"https://api.github.com/users/legrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legrego/subscriptions","organizations_url":"https://api.github.com/users/legrego/orgs","repos_url":"https://api.github.com/users/legrego/repos","events_url":"https://api.github.com/users/legrego/events{/privacy}","received_events_url":"https://api.github.com/users/legrego/received_events","type":"User","site_admin":false},"repo":{"id":122997624,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5OTc2MjQ=","name":"kibana","full_name":"legrego/kibana","private":false,"owner":{"login":"legrego","id":3493255,"node_id":"MDQ6VXNlcjM0OTMyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3493255?v=4","gravatar_id":"","url":"https://api.github.com/users/legrego","html_url":"https://github.com/legrego","followers_url":"https://api.github.com/users/legrego/followers","following_url":"https://api.github.com/users/legrego/following{/other_user}","gists_url":"https://api.github.com/users/legrego/gists{/gist_id}","starred_url":"https://api.github.com/users/legrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legrego/subscriptions","organizations_url":"https://api.github.com/users/legrego/orgs","repos_url":"https://api.github.com/users/legrego/repos","events_url":"https://api.github.com/users/legrego/events{/privacy}","received_events_url":"https://api.github.com/users/legrego/received_events","type":"User","site_admin":false},"html_url":"https://github.com/legrego/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/legrego/kibana","forks_url":"https://api.github.com/repos/legrego/kibana/forks","keys_url":"https://api.github.com/repos/legrego/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legrego/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legrego/kibana/teams","hooks_url":"https://api.github.com/repos/legrego/kibana/hooks","issue_events_url":"https://api.github.com/repos/legrego/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/legrego/kibana/events","assignees_url":"https://api.github.com/repos/legrego/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/legrego/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/legrego/kibana/tags","blobs_url":"https://api.github.com/repos/legrego/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legrego/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legrego/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/legrego/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legrego/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/legrego/kibana/languages","stargazers_url":"https://api.github.com/repos/legrego/kibana/stargazers","contributors_url":"https://api.github.com/repos/legrego/kibana/contributors","subscribers_url":"https://api.github.com/repos/legrego/kibana/subscribers","subscription_url":"https://api.github.com/repos/legrego/kibana/subscription","commits_url":"https://api.github.com/repos/legrego/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/legrego/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/legrego/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/legrego/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/legrego/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/legrego/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legrego/kibana/merges","archive_url":"https://api.github.com/repos/legrego/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legrego/kibana/downloads","issues_url":"https://api.github.com/repos/legrego/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/legrego/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/legrego/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/legrego/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legrego/kibana/labels{/name}","releases_url":"https://api.github.com/repos/legrego/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/legrego/kibana/deployments","created_at":"2018-02-26T16:34:03Z","updated_at":"2018-09-21T12:39:30Z","pushed_at":"2018-09-25T23:16:16Z","git_url":"git://github.com/legrego/kibana.git","ssh_url":"git@github.com:legrego/kibana.git","clone_url":"https://github.com/legrego/kibana.git","svn_url":"https://github.com/legrego/kibana","homepage":"https://www.elastic.co/products/kibana","size":467707,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"3c6b382b061b299f03d121a6f07c8a5265d6a7f5","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-09-26T10:46:09Z","pushed_at":"2018-09-26T10:46:05Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":473914,"stargazers_count":10148,"watchers_count":10148,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3945,"mirror_url":null,"archived":false,"open_issues_count":3595,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3945,"open_issues":3595,"watchers":10148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23512"},"html":{"href":"https://github.com/elastic/kibana/pull/23512"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/23512"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/23512/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23512/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23512/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/4fe457859f781cef793600e49e3c2a763b5fb8b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"legrego"}}