{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/7631","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/7631/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/7631/comments","events_url":"https://api.github.com/repos/istio/istio/issues/7631/events","html_url":"https://github.com/istio/istio/pull/7631","id":347486076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDk5NDI5","number":7631,"title":"[WIP] Pilot client mcp integration","user":{"login":"Nino-K","id":10409174,"node_id":"MDQ6VXNlcjEwNDA5MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10409174?v=4","gravatar_id":"","url":"https://api.github.com/users/Nino-K","html_url":"https://github.com/Nino-K","followers_url":"https://api.github.com/users/Nino-K/followers","following_url":"https://api.github.com/users/Nino-K/following{/other_user}","gists_url":"https://api.github.com/users/Nino-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Nino-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nino-K/subscriptions","organizations_url":"https://api.github.com/users/Nino-K/orgs","repos_url":"https://api.github.com/users/Nino-K/repos","events_url":"https://api.github.com/users/Nino-K/events{/privacy}","received_events_url":"https://api.github.com/users/Nino-K/received_events","type":"User","site_admin":false},"labels":[{"id":491318041,"node_id":"MDU6TGFiZWw0OTEzMTgwNDE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20no","name":"cla: no","color":"bfdadc","default":false},{"id":957605109,"node_id":"MDU6TGFiZWw5NTc2MDUxMDk=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-03T17:59:15Z","updated_at":"2018-08-06T17:39:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7631","html_url":"https://github.com/istio/istio/pull/7631","diff_url":"https://github.com/istio/istio/pull/7631.diff","patch_url":"https://github.com/istio/istio/pull/7631.patch"},"body":"PLEASE DO NOT MERGE THIS PR.\r\n\r\nThis PR is the first draft of mcp client integration in pilot bootstrap server and is meant to gather feedback on the work that is currently in progress. \r\n\r\nTODO items: \r\n- Updated still needs to handle serviceDiscovery as this PR only demonstrates configStore\r\n\r\nKnown errors, currently when mcp client and server support all the types (mirrored all types in configDescriptor) but when server sends envelopes only for a single type (e.g only Gateway) the following errors are seen in the logs.\r\n```\r\n2018-08-03T17:09:00.717530Z     error   MCP: sending NACK for version= nonce=1: error=\"rpc error: code = InvalidArgument desc = 3 errors occurred:\\n\\n* domain name \\\"\\\\n\\\\x0f\\\\b\\\\xa3?\\\\x12\\\\x04HTTP\\\\x1a\\\\x04http\\\\x12\\\\x01*\\\" invalid (label \\\"\\\\n\\\\x0f\\\\b\\\\xa3?\\\\x12\\\\x04HTTP\\\\x1a\\\\x04http\\\\x12\\\\x01*\\\" invalid)\\n* \\n\\x0f\\b\\xa3?\\x12\\x04HTTP\\x1a\\x04http\\x12\\x01* is not a valid IP\\n* http, tcp or tls must be provided in virtual service\"\r\n2018-08-03T17:09:00.717602Z     error   MCP: sending NACK for version= nonce=2: error=\"mismatched message type: got \\\"istio.routing.v1alpha1.EgressRule\\\" want \\\"\\\"\"\r\n2018-08-03T17:09:00.717635Z     error   MCP: sending NACK for version= nonce=3: error=\"rpc error: code = InvalidArgument desc = invalid host \\n\\x0f\\b\\xa3?\\x12\\x04HTTP\\x1a\\x04http\\x12\\x01*\"\r\n2018-08-03T17:09:00.717648Z     error   MCP: sending NACK for version= nonce=4: error=\"mismatched message type: got \\\"istio.rbac.v1alpha1.ServiceRole\\\" want \\\"\\\"\"\r\n2018-08-03T17:09:00.717669Z     error   MCP: sending NACK for version= nonce=5: error=\"mismatched message type: got \\\"istio.rbac.v1alpha1.ServiceRoleBinding\\\" want \\\"\\\"\"\r\n2018-08-03T17:09:00.717684Z     error   MCP: sending NACK for version= nonce=6: error=\"mismatched message type: got \\\"istio.routing.v1alpha1.RouteRule\\\" want \\\"\\\"\"\r\n2018-08-03T17:09:00.717742Z     error   MCP: sending NACK for version= nonce=8: error=\"rpc error: code = InvalidArgument desc = 2 errors occurred:\\n\\n* domain name \\\"\\\\n\\\\x0f\\\\b\\\\xa3?\\\\x12\\\\x04HTTP\\\\x1a\\\\x04http\\\\x12\\\\x01*\\\" invalid (label \\\"\\\\n\\\\x0f\\\\b\\\\xa3?\\\\x12\\\\x04HTTP\\\\x1a\\\\x04http\\\\x12\\\\x01*\\\" invalid)\\n* \\n\\x0f\\b\\xa3?\\x12\\x04HTTP\\x1a\\x04http\\x12\\x01* is not a valid IP\"\r\n2018-08-03T17:09:00.717786Z     error   MCP: sending NACK for version= nonce=9: error=\"rpc error: code = InvalidArgument desc = 3 errors occurred:\\n\\n* name \\\"\\\\b\\\\xa3?\\\\x12\\\\x04HTTP\\\\x1a\\\\x04http\\\" must be a valid label\\n* namespace \\\"*\\\" must be a valid label\\n* at least one spec must be specified\"\r\n```"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/410790133","html_url":"https://github.com/istio/istio/pull/7631#issuecomment-410790133","issue_url":"https://api.github.com/repos/istio/istio/issues/7631","id":410790133,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDc5MDEzMw==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T17:39:55Z","updated_at":"2018-08-06T17:39:55Z","author_association":"COLLABORATOR","body":"@Nino-K: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/istio-unit-tests.sh | a63f121ab7eb037f448d459fc18e5badf0394842 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/7631/istio-unit-tests/11014/) | `/test istio-unit-tests`\nprow/istio-presubmit.sh | a63f121ab7eb037f448d459fc18e5badf0394842 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/7631/istio-presubmit/15303/) | `/test istio-presubmit`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}