{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/17","id":220105627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTA1NjI3","html_url":"https://github.com/alphagov/cf_app_discovery/pull/17","diff_url":"https://github.com/alphagov/cf_app_discovery/pull/17.diff","patch_url":"https://github.com/alphagov/cf_app_discovery/pull/17.patch","issue_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/17","number":17,"state":"closed","locked":false,"title":"Add instrumentation","user":{"login":"philandstuff","id":581269,"node_id":"MDQ6VXNlcjU4MTI2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/581269?v=4","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"body":"This adds prometheus instrumentation to the service broker.\r\n\r\nThere are a few things I did:\r\n\r\n - add prometheus instrumentation to the service broker http server\r\n - move the target-updater functionality from the clockwork app to the main service broker http server, so that it can be more easily instrumented\r\n - added instrumentation to the cloud foundry client code, so that we can see how many of each API call we are making\r\n\r\nThis has already been deployed to the staging service broker for testing purposes, so if you want to see what it looks like, have a look at staging prometheus.","created_at":"2018-10-03T16:43:36Z","updated_at":"2018-10-05T10:12:59Z","closed_at":"2018-10-05T10:12:59Z","merged_at":"2018-10-05T10:12:59Z","merge_commit_sha":"2f06691aa6a621d65929c0d19d428f4277bb4778","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/17/commits","review_comments_url":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/17/comments","review_comment_url":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/17/comments","statuses_url":"https://api.github.com/repos/alphagov/cf_app_discovery/statuses/964bdd142a59a383162e601c0e28f15c75ebdcfd","head":{"label":"alphagov:instrumentation","ref":"instrumentation","sha":"964bdd142a59a383162e601c0e28f15c75ebdcfd","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":120009318,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwMDkzMTg=","name":"cf_app_discovery","full_name":"alphagov/cf_app_discovery","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/cf_app_discovery","description":"A Cloud Foundry Service Broker that can be bound to apps on the GOV.UK PaaS so they can be discovered by Prometheus.","fork":false,"url":"https://api.github.com/repos/alphagov/cf_app_discovery","forks_url":"https://api.github.com/repos/alphagov/cf_app_discovery/forks","keys_url":"https://api.github.com/repos/alphagov/cf_app_discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/cf_app_discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/cf_app_discovery/teams","hooks_url":"https://api.github.com/repos/alphagov/cf_app_discovery/hooks","issue_events_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/cf_app_discovery/events","assignees_url":"https://api.github.com/repos/alphagov/cf_app_discovery/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/cf_app_discovery/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/cf_app_discovery/tags","blobs_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/cf_app_discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/cf_app_discovery/languages","stargazers_url":"https://api.github.com/repos/alphagov/cf_app_discovery/stargazers","contributors_url":"https://api.github.com/repos/alphagov/cf_app_discovery/contributors","subscribers_url":"https://api.github.com/repos/alphagov/cf_app_discovery/subscribers","subscription_url":"https://api.github.com/repos/alphagov/cf_app_discovery/subscription","commits_url":"https://api.github.com/repos/alphagov/cf_app_discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/cf_app_discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/cf_app_discovery/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/cf_app_discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/cf_app_discovery/merges","archive_url":"https://api.github.com/repos/alphagov/cf_app_discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/cf_app_discovery/downloads","issues_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/cf_app_discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/cf_app_discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/cf_app_discovery/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/cf_app_discovery/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/cf_app_discovery/deployments","created_at":"2018-02-02T17:15:55Z","updated_at":"2018-10-05T08:08:59Z","pushed_at":"2018-10-05T10:12:59Z","git_url":"git://github.com/alphagov/cf_app_discovery.git","ssh_url":"git@github.com:alphagov/cf_app_discovery.git","clone_url":"https://github.com/alphagov/cf_app_discovery.git","svn_url":"https://github.com/alphagov/cf_app_discovery","homepage":"","size":152,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"8d05942e59c4bb5dbf4d0d74e95529409baaf8ba","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":120009318,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwMDkzMTg=","name":"cf_app_discovery","full_name":"alphagov/cf_app_discovery","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/cf_app_discovery","description":"A Cloud Foundry Service Broker that can be bound to apps on the GOV.UK PaaS so they can be discovered by Prometheus.","fork":false,"url":"https://api.github.com/repos/alphagov/cf_app_discovery","forks_url":"https://api.github.com/repos/alphagov/cf_app_discovery/forks","keys_url":"https://api.github.com/repos/alphagov/cf_app_discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/cf_app_discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/cf_app_discovery/teams","hooks_url":"https://api.github.com/repos/alphagov/cf_app_discovery/hooks","issue_events_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/cf_app_discovery/events","assignees_url":"https://api.github.com/repos/alphagov/cf_app_discovery/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/cf_app_discovery/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/cf_app_discovery/tags","blobs_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/cf_app_discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/cf_app_discovery/languages","stargazers_url":"https://api.github.com/repos/alphagov/cf_app_discovery/stargazers","contributors_url":"https://api.github.com/repos/alphagov/cf_app_discovery/contributors","subscribers_url":"https://api.github.com/repos/alphagov/cf_app_discovery/subscribers","subscription_url":"https://api.github.com/repos/alphagov/cf_app_discovery/subscription","commits_url":"https://api.github.com/repos/alphagov/cf_app_discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/cf_app_discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/cf_app_discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/cf_app_discovery/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/cf_app_discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/cf_app_discovery/merges","archive_url":"https://api.github.com/repos/alphagov/cf_app_discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/cf_app_discovery/downloads","issues_url":"https://api.github.com/repos/alphagov/cf_app_discovery/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/cf_app_discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/cf_app_discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/cf_app_discovery/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/cf_app_discovery/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/cf_app_discovery/deployments","created_at":"2018-02-02T17:15:55Z","updated_at":"2018-10-05T08:08:59Z","pushed_at":"2018-10-05T10:12:59Z","git_url":"git://github.com/alphagov/cf_app_discovery.git","ssh_url":"git@github.com:alphagov/cf_app_discovery.git","clone_url":"https://github.com/alphagov/cf_app_discovery.git","svn_url":"https://github.com/alphagov/cf_app_discovery","homepage":"","size":152,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/17"},"html":{"href":"https://github.com/alphagov/cf_app_discovery/pull/17"},"issue":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/17"},"comments":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/cf_app_discovery/statuses/964bdd142a59a383162e601c0e28f15c75ebdcfd"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"philandstuff","id":581269,"node_id":"MDQ6VXNlcjU4MTI2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/581269?v=4","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":25,"deletions":8,"changed_files":9}}
{"actor":{"display_login":"philandstuff"}}