{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/issues/114","repository_url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl","labels_url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/issues/114/comments","events_url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/issues/114/events","html_url":"https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114","id":347286626,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTQ1Nzg4","number":114,"title":"Change the safety condition that a path is going","user":{"login":"saschatimme","id":4854317,"node_id":"MDQ6VXNlcjQ4NTQzMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4854317?v=4","gravatar_id":"","url":"https://api.github.com/users/saschatimme","html_url":"https://github.com/saschatimme","followers_url":"https://api.github.com/users/saschatimme/followers","following_url":"https://api.github.com/users/saschatimme/following{/other_user}","gists_url":"https://api.github.com/users/saschatimme/gists{/gist_id}","starred_url":"https://api.github.com/users/saschatimme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschatimme/subscriptions","organizations_url":"https://api.github.com/users/saschatimme/orgs","repos_url":"https://api.github.com/users/saschatimme/repos","events_url":"https://api.github.com/users/saschatimme/events{/privacy}","received_events_url":"https://api.github.com/users/saschatimme/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-03T07:20:14Z","updated_at":"2018-08-03T12:52:33Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/pulls/114","html_url":"https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114","diff_url":"https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114.diff","patch_url":"https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114.patch"},"body":"Previously we just used the absolute value of the homogenous coordinate.\r\nBut this can yield wrong results if one coordinate of the solution is\r\nmuch larger than all others. A less sensitive check is to require\r\na certain minimal norm of the affine \"solution\" before declaring it at\r\ninfinity. This is now `minimal_maxnorm=1e3` (compard to `maxnorm=1e5`)."},"comment":{"url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/issues/comments/410244023","html_url":"https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114#issuecomment-410244023","issue_url":"https://api.github.com/repos/JuliaHomotopyContinuation/HomotopyContinuation.jl/issues/114","id":410244023,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDI0NDAyMw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-08-03T12:52:33Z","updated_at":"2018-08-03T12:52:33Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=h1) Report\n> Merging [#114](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=desc) into [master](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/commit/090579d923715c82f5db6402a02026fc0ca5c18d?src=pr&el=desc) will **decrease** coverage by `0.05%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114/graphs/tree.svg?width=650&src=pr&token=Iq88NoMNeq&height=150)](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #114      +/-   ##\n==========================================\n- Coverage   95.71%   95.65%   -0.06%     \n==========================================\n  Files          47       47              \n  Lines        1752     1751       -1     \n==========================================\n- Hits         1677     1675       -2     \n- Misses         75       76       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/endgaming/types.jl](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114/diff?src=pr&el=tree#diff-c3JjL2VuZGdhbWluZy90eXBlcy5qbA==) | `100% <100%> (ø)` | :arrow_up: |\n| [src/endgaming/runendgame.jl](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114/diff?src=pr&el=tree#diff-c3JjL2VuZGdhbWluZy9ydW5lbmRnYW1lLmps) | `96.61% <100%> (-0.03%)` | :arrow_down: |\n| [src/prediction\\_correction.jl](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114/diff?src=pr&el=tree#diff-c3JjL3ByZWRpY3Rpb25fY29ycmVjdGlvbi5qbA==) | `71.42% <0%> (-3.58%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=footer). Last update [090579d...975d7e1](https://codecov.io/gh/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}