{"action":"closed","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/47089","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/47089/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47089/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/47089/events","html_url":"https://github.com/saltstack/salt/issues/47089","id":314537302,"number":47089,"title":"UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 404: ordinal not in range(128)","user":{"login":"syphernl","id":639906,"avatar_url":"https://avatars1.githubusercontent.com/u/639906?v=4","gravatar_id":"","url":"https://api.github.com/users/syphernl","html_url":"https://github.com/syphernl","followers_url":"https://api.github.com/users/syphernl/followers","following_url":"https://api.github.com/users/syphernl/following{/other_user}","gists_url":"https://api.github.com/users/syphernl/gists{/gist_id}","starred_url":"https://api.github.com/users/syphernl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syphernl/subscriptions","organizations_url":"https://api.github.com/users/syphernl/orgs","repos_url":"https://api.github.com/users/syphernl/repos","events_url":"https://api.github.com/users/syphernl/events{/privacy}","received_events_url":"https://api.github.com/users/syphernl/received_events","type":"User","site_admin":false},"labels":[{"id":853105682,"url":"https://api.github.com/repos/saltstack/salt/labels/2018.3.1","name":"2018.3.1","color":"fbca04","default":false},{"id":143273337,"url":"https://api.github.com/repos/saltstack/salt/labels/Blocker","name":"Blocker","color":"e11d21","default":false},{"id":67287385,"url":"https://api.github.com/repos/saltstack/salt/labels/Core","name":"Core","color":"fef2c0","default":false},{"id":41389957,"url":"https://api.github.com/repos/saltstack/salt/labels/Fixed%20Pending%20Verification","name":"Fixed Pending Verification","color":"d4c5f9","default":false},{"id":194766164,"url":"https://api.github.com/repos/saltstack/salt/labels/P1","name":"P1","color":"2181ee","default":false},{"id":43087608,"url":"https://api.github.com/repos/saltstack/salt/labels/Regression","name":"Regression","color":"e11d21","default":false},{"id":279790660,"url":"https://api.github.com/repos/saltstack/salt/labels/TEAM%20Core","name":"TEAM Core","color":"A9A9A9","default":false},{"id":681622101,"url":"https://api.github.com/repos/saltstack/salt/labels/team-core","name":"team-core","color":"e99695","default":false}],"state":"closed","locked":false,"assignee":{"login":"terminalmage","id":328598,"avatar_url":"https://avatars1.githubusercontent.com/u/328598?v=4","gravatar_id":"","url":"https://api.github.com/users/terminalmage","html_url":"https://github.com/terminalmage","followers_url":"https://api.github.com/users/terminalmage/followers","following_url":"https://api.github.com/users/terminalmage/following{/other_user}","gists_url":"https://api.github.com/users/terminalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/terminalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terminalmage/subscriptions","organizations_url":"https://api.github.com/users/terminalmage/orgs","repos_url":"https://api.github.com/users/terminalmage/repos","events_url":"https://api.github.com/users/terminalmage/events{/privacy}","received_events_url":"https://api.github.com/users/terminalmage/received_events","type":"User","site_admin":false},"assignees":[{"login":"terminalmage","id":328598,"avatar_url":"https://avatars1.githubusercontent.com/u/328598?v=4","gravatar_id":"","url":"https://api.github.com/users/terminalmage","html_url":"https://github.com/terminalmage","followers_url":"https://api.github.com/users/terminalmage/followers","following_url":"https://api.github.com/users/terminalmage/following{/other_user}","gists_url":"https://api.github.com/users/terminalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/terminalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terminalmage/subscriptions","organizations_url":"https://api.github.com/users/terminalmage/orgs","repos_url":"https://api.github.com/users/terminalmage/repos","events_url":"https://api.github.com/users/terminalmage/events{/privacy}","received_events_url":"https://api.github.com/users/terminalmage/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestone/13","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars0.githubusercontent.com/u/507599?v=4","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":2334,"closed_issues":7155,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2018-04-25T14:54:14Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-04-16T07:52:28Z","updated_at":"2018-04-25T14:54:15Z","closed_at":"2018-04-25T14:54:14Z","author_association":"CONTRIBUTOR","body":"### Description of Issue/Question\r\n\r\nAfter upgrading to Salt 2018.3.0 a minion on 16.04 started having issues with the `ssh` module which is being through `ssh_auth.present`:\r\n```\r\n          ID: my_ssh_key\r\n    Function: ssh_auth.present\r\n      Result: False\r\n     Comment: An exception occurred in this state: Traceback (most recent call last):\r\n                File \"/usr/lib/python2.7/dist-packages/salt/state.py\", line 1878, in call\r\n                  **cdata['kwargs'])\r\n                File \"/usr/lib/python2.7/dist-packages/salt/loader.py\", line 1823, in wrapper\r\n                  return f(*args, **kwargs)\r\n                File \"/usr/lib/python2.7/dist-packages/salt/states/ssh_auth.py\", line 340, in present\r\n                  fingerprint_hash_type=fingerprint_hash_type)\r\n                File \"/usr/lib/python2.7/dist-packages/salt/modules/ssh.py\", line 738, in set_auth_key\r\n                  fingerprint_hash_type=fingerprint_hash_type)\r\n                File \"/usr/lib/python2.7/dist-packages/salt/modules/ssh.py\", line 476, in check_key\r\n                  fingerprint_hash_type=fingerprint_hash_type)\r\n                File \"/usr/lib/python2.7/dist-packages/salt/modules/ssh.py\", line 404, in auth_keys\r\n                  keys[u] = _validate_keys(full, fingerprint_hash_type)\r\n                File \"/usr/lib/python2.7/dist-packages/salt/modules/ssh.py\", line 197, in _validate_keys\r\n                  line += '\\n'\r\n              UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 404: ordinal not in range(128)\r\n     Started: 09:44:07.019787\r\n    Duration: 14.039 ms\r\n     Changes:   \r\n```\r\n\r\nOne of the SSH pubkeys we have contains a diacritic (a `ë` to be exact)\r\n\r\nThis works fine in `2017.7.4`, but breaks once we upgrade to `2018.3.0`.\r\n\r\n`locale` output:\r\n```\r\nroot@qa:~# locale\r\nLANG=en_US.UTF-8\r\nLANGUAGE=\r\nLC_CTYPE=en_US.UTF-8\r\nLC_NUMERIC=nl_NL.UTF-8\r\nLC_TIME=nl_NL.UTF-8\r\nLC_COLLATE=\"en_US.UTF-8\"\r\nLC_MONETARY=nl_NL.UTF-8\r\nLC_MESSAGES=\"en_US.UTF-8\"\r\nLC_PAPER=nl_NL.UTF-8\r\nLC_NAME=nl_NL.UTF-8\r\nLC_ADDRESS=nl_NL.UTF-8\r\nLC_TELEPHONE=nl_NL.UTF-8\r\nLC_MEASUREMENT=nl_NL.UTF-8\r\nLC_IDENTIFICATION=nl_NL.UTF-8\r\nLC_ALL=\r\n\r\n```\r\n\r\n### Versions Report\r\n\r\nMaster\r\n```\r\nSalt Version:\r\n           Salt: 2018.3.0\r\n \r\nDependency Versions:\r\n           cffi: Not Installed\r\n       cherrypy: Not Installed\r\n       dateutil: 2.4.2\r\n      docker-py: Not Installed\r\n          gitdb: 0.6.4\r\n      gitpython: 1.0.1\r\n          ioflo: Not Installed\r\n         Jinja2: 2.8\r\n        libgit2: Not Installed\r\n        libnacl: 1.6.1\r\n       M2Crypto: Not Installed\r\n           Mako: 1.0.3\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.4.6\r\n   mysql-python: 1.3.7\r\n      pycparser: Not Installed\r\n       pycrypto: 2.6.1\r\n   pycryptodome: Not Installed\r\n         pygit2: Not Installed\r\n         Python: 2.7.12 (default, Dec  4 2017, 14:50:18)\r\n   python-gnupg: Not Installed\r\n         PyYAML: 3.11\r\n          PyZMQ: 15.2.0\r\n           RAET: Not Installed\r\n          smmap: 0.9.0\r\n        timelib: Not Installed\r\n        Tornado: 4.2.1\r\n            ZMQ: 4.1.4\r\n \r\nSystem Versions:\r\n           dist: Ubuntu 16.04 xenial\r\n         locale: UTF-8\r\n        machine: x86_64\r\n        release: 4.4.0-1031-aws\r\n         system: Linux\r\n        version: Ubuntu 16.04 xenial\r\n```\r\n\r\nMinion\r\n```\r\nSalt Version:\r\n           Salt: 2018.3.0\r\n \r\nDependency Versions:\r\n           cffi: Not Installed\r\n       cherrypy: Not Installed\r\n       dateutil: 2.4.2\r\n      docker-py: Not Installed\r\n          gitdb: Not Installed\r\n      gitpython: Not Installed\r\n          ioflo: Not Installed\r\n         Jinja2: 2.8\r\n        libgit2: Not Installed\r\n        libnacl: Not Installed\r\n       M2Crypto: Not Installed\r\n           Mako: 1.0.3\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.4.6\r\n   mysql-python: 1.3.7\r\n      pycparser: Not Installed\r\n       pycrypto: 2.6.1\r\n   pycryptodome: Not Installed\r\n         pygit2: Not Installed\r\n         Python: 2.7.12 (default, Dec  4 2017, 14:50:18)\r\n   python-gnupg: Not Installed\r\n         PyYAML: 3.11\r\n          PyZMQ: 15.2.0\r\n           RAET: Not Installed\r\n          smmap: Not Installed\r\n        timelib: Not Installed\r\n        Tornado: 4.2.1\r\n            ZMQ: 4.2.3\r\n \r\nSystem Versions:\r\n           dist: Ubuntu 16.04 xenial\r\n         locale: UTF-8\r\n        machine: x86_64\r\n        release: 4.4.0-119-generic\r\n         system: Linux\r\n        version: Ubuntu 16.04 xenial\r\n```\r\n\r\nThis also seems to affect `12.04`."}}
{"actor":{"display_login":"rallytime"}}