{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/5674","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/5674/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/5674/comments","events_url":"https://api.github.com/repos/istio/istio/issues/5674/events","html_url":"https://github.com/istio/istio/pull/5674","id":324114246,"number":5674,"title":"Quick fix for istio gen-deploy.","user":{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-17T17:21:30Z","updated_at":"2018-05-18T00:08:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5674","html_url":"https://github.com/istio/istio/pull/5674","diff_url":"https://github.com/istio/istio/pull/5674.diff","patch_url":"https://github.com/istio/istio/pull/5674.patch"},"body":"The helm feature never really worked, we'll edit the values.yaml\r\ninstead. Feature selection doesn't work and probably never really\r\nworked.\r\n\r\nWhat remains is a minimal helm template renderer, with one optional\r\nvalues.yaml"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/390052373","html_url":"https://github.com/istio/istio/pull/5674#issuecomment-390052373","issue_url":"https://api.github.com/repos/istio/istio/issues/5674","id":390052373,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-18T00:08:36Z","updated_at":"2018-05-18T00:08:36Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=h1) Report\n> Merging [#5674](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=desc) into [release-0.8](https://codecov.io/gh/istio/istio/commit/17a0bc5f17a2a4495ce24ba1efe43ade54f6a52e?src=pr&el=desc) will **decrease** coverage by `1%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/istio/istio/pull/5674/graphs/tree.svg?src=pr&token=nYtepj7fDQ&width=650&height=150)](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##           release-0.8   #5674    +/-   ##\n============================================\n- Coverage           73%     73%   -<1%     \n============================================\n  Files              322     321     -1     \n  Lines            27639   27597    -42     \n============================================\n- Hits             20152   20119    -33     \n+ Misses            6691    6688     -3     \n+ Partials           796     790     -6\n```\n\n\n| [Impacted Files](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [istioctl/cmd/istioctl/gendeployment/cmd.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-aXN0aW9jdGwvY21kL2lzdGlvY3RsL2dlbmRlcGxveW1lbnQvY21kLmdv) | `30% <0%> (-10%)` | :arrow_down: |\n| [pilot/pkg/config/memory/monitor.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2NvbmZpZy9tZW1vcnkvbW9uaXRvci5nbw==) | `82% <0%> (-9%)` | :arrow_down: |\n| [mixer/adapter/opa/opa.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9vcGEvb3BhLmdv) | `79% <0%> (-3%)` | :arrow_down: |\n| [mixer/adapter/kubernetesenv/kubernetesenv.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9rdWJlcm5ldGVzZW52L2t1YmVybmV0ZXNlbnYuZ28=) | `69% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/stackdriver/log/log.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zdGFja2RyaXZlci9sb2cvbG9nLmdv) | `68% <0%> (ø)` | :arrow_down: |\n| [mixer/adapter/list/ipList.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9saXN0L2lwTGlzdC5nbw==) | `100% <0%> (ø)` | :arrow_up: |\n| [mixer/adapter/dogstatsd/dogstatsd.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9kb2dzdGF0c2QvZG9nc3RhdHNkLmdv) | `100% <0%> (ø)` | :arrow_up: |\n| [mixer/adapter/denier/denier.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9kZW5pZXIvZGVuaWVyLmdv) | `100% <0%> (ø)` | :arrow_up: |\n| [mixer/adapter/prometheus/prometheus.go](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9wcm9tZXRoZXVzL3Byb21ldGhldXMuZ28=) | `100% <0%> (ø)` | :arrow_up: |\n| ... and [15 more](https://codecov.io/gh/istio/istio/pull/5674/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=footer). Last update [17a0bc5...a5d7c06](https://codecov.io/gh/istio/istio/pull/5674?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}