{"action":"closed","number":192,"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/192","id":197538590,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTM4NTkw","html_url":"https://github.com/jaegertracing/jaeger-client-python/pull/192","diff_url":"https://github.com/jaegertracing/jaeger-client-python/pull/192.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-python/pull/192.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/192","number":192,"state":"closed","locked":false,"title":"Improve handling of config values and default arguments","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"Fix for:\r\n```\r\nFile \"/usr/local/lib/python2.7/dist-packages/jaeger_client/sampler.py\", line 312, in __str__\r\n    self.max_operations)\r\nTypeError: %d format: a number is required, not NoneType\r\nLogged from file sampler.py, line 428\r\n```\r\n\r\nSigned-off-by: Isaac Hier <ihier@uber.com>","created_at":"2018-06-26T20:16:51Z","updated_at":"2018-06-27T19:36:14Z","closed_at":"2018-06-27T19:36:13Z","merged_at":"2018-06-27T19:36:13Z","merge_commit_sha":"7613f7ff3aa4876c3b3c3234758409e21d610d7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/192/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/192/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/192/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/statuses/ef080a67714f7acc5c3ac3a1ab68bbb77008e8af","head":{"label":"isaachier:fix-max-operations","ref":"fix-max-operations","sha":"ef080a67714f7acc5c3ac3a1ab68bbb77008e8af","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"repo":{"id":104790879,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3OTA4Nzk=","name":"jaeger-client-python","full_name":"isaachier/jaeger-client-python","owner":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaachier/jaeger-client-python","description":"Jaeger Bindings for Python OpenTracing API","fork":true,"url":"https://api.github.com/repos/isaachier/jaeger-client-python","forks_url":"https://api.github.com/repos/isaachier/jaeger-client-python/forks","keys_url":"https://api.github.com/repos/isaachier/jaeger-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaachier/jaeger-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaachier/jaeger-client-python/teams","hooks_url":"https://api.github.com/repos/isaachier/jaeger-client-python/hooks","issue_events_url":"https://api.github.com/repos/isaachier/jaeger-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/isaachier/jaeger-client-python/events","assignees_url":"https://api.github.com/repos/isaachier/jaeger-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/isaachier/jaeger-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/isaachier/jaeger-client-python/tags","blobs_url":"https://api.github.com/repos/isaachier/jaeger-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaachier/jaeger-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaachier/jaeger-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaachier/jaeger-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaachier/jaeger-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/isaachier/jaeger-client-python/languages","stargazers_url":"https://api.github.com/repos/isaachier/jaeger-client-python/stargazers","contributors_url":"https://api.github.com/repos/isaachier/jaeger-client-python/contributors","subscribers_url":"https://api.github.com/repos/isaachier/jaeger-client-python/subscribers","subscription_url":"https://api.github.com/repos/isaachier/jaeger-client-python/subscription","commits_url":"https://api.github.com/repos/isaachier/jaeger-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaachier/jaeger-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaachier/jaeger-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaachier/jaeger-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaachier/jaeger-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/isaachier/jaeger-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaachier/jaeger-client-python/merges","archive_url":"https://api.github.com/repos/isaachier/jaeger-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaachier/jaeger-client-python/downloads","issues_url":"https://api.github.com/repos/isaachier/jaeger-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/isaachier/jaeger-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/isaachier/jaeger-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/isaachier/jaeger-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaachier/jaeger-client-python/labels{/name}","releases_url":"https://api.github.com/repos/isaachier/jaeger-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/isaachier/jaeger-client-python/deployments","created_at":"2017-09-25T19:08:00Z","updated_at":"2018-06-27T17:59:37Z","pushed_at":"2018-06-27T18:36:38Z","git_url":"git://github.com/isaachier/jaeger-client-python.git","ssh_url":"git@github.com:isaachier/jaeger-client-python.git","clone_url":"https://github.com/isaachier/jaeger-client-python.git","svn_url":"https://github.com/isaachier/jaeger-client-python","homepage":"http://uber.github.io/jaeger/","size":493,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"cb507453948a780cdfb1bc845090ec502b5e52d1","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56551019,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU1MTAxOQ==","name":"jaeger-client-python","full_name":"jaegertracing/jaeger-client-python","owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-python","description":"Jaeger Bindings for Python OpenTracing API","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-python","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/deployments","created_at":"2016-04-19T00:10:38Z","updated_at":"2018-06-27T17:37:48Z","pushed_at":"2018-06-27T19:36:13Z","git_url":"git://github.com/jaegertracing/jaeger-client-python.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-python.git","clone_url":"https://github.com/jaegertracing/jaeger-client-python.git","svn_url":"https://github.com/jaegertracing/jaeger-client-python","homepage":"https://jaegertracing.io/","size":481,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":39,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/192"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-python/pull/192"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/192"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-python/statuses/ef080a67714f7acc5c3ac3a1ab68bbb77008e8af"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"black-adder","id":791791,"node_id":"MDQ6VXNlcjc5MTc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},"comments":6,"review_comments":5,"maintainer_can_modify":false,"commits":4,"additions":76,"deletions":31,"changed_files":4}}
{"actor":{"display_login":"black-adder"}}