{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/241949190","pull_request_review_id":185354360,"id":241949190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk0OTE5MA==","diff_hunk":"@@ -171,7 +172,7 @@ def setUp(self):\n         self.cubelist2 = iris.cube.CubeList([self.cube2])\n \n     def test_pass(self):\n-        cubelist = self.cubelist1.copy()\n+        cubelist = copy.copy(self.cubelist1)\n         cubelist += self.cubelist2","path":"lib/iris/tests/unit/cube/test_CubeList.py","position":80,"original_position":34,"commit_id":"3265a65ffdb63f83f1ffb864206fe9b1d0354307","original_commit_id":"3265a65ffdb63f83f1ffb864206fe9b1d0354307","user":{"login":"rcomer","id":10599679,"node_id":"MDQ6VXNlcjEwNTk5Njc5","avatar_url":"https://avatars0.githubusercontent.com/u/10599679?v=4","gravatar_id":"","url":"https://api.github.com/users/rcomer","html_url":"https://github.com/rcomer","followers_url":"https://api.github.com/users/rcomer/followers","following_url":"https://api.github.com/users/rcomer/following{/other_user}","gists_url":"https://api.github.com/users/rcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/rcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcomer/subscriptions","organizations_url":"https://api.github.com/users/rcomer/orgs","repos_url":"https://api.github.com/users/rcomer/repos","events_url":"https://api.github.com/users/rcomer/events{/privacy}","received_events_url":"https://api.github.com/users/rcomer/received_events","type":"User","site_admin":false},"body":"Travis output showing the above:\r\n[Python2.7](https://travis-ci.org/SciTools/iris/jobs/468127937#L7398)\r\n```\r\nFAIL: test_pass (iris.tests.unit.cube.test_CubeList.Test_iadd)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/scitools_iris-2.3.0.dev0-py2.7.egg/iris/tests/unit/cube/test_CubeList.py\", line 177, in test_pass\r\n    self.assertEqual(cubelist, self.cubelist1 + self.cubelist2)\r\nAssertionError: None != [<iris 'Cube' of foo / (unknown) (scalar cube)>,\r\n<iris 'Cube' of bar / (unknown) (scalar cube)>]\r\n```\r\n\r\n[Python3.6](https://travis-ci.org/SciTools/iris/jobs/468127938#L7257)\r\n```\r\nFAIL: test_pass (iris.tests.unit.cube.test_CubeList.Test_iadd)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/scitools_iris-2.3.0.dev0-py3.6.egg/iris/tests/unit/cube/test_CubeList.py\", line 177, in test_pass\r\n    self.assertEqual(cubelist, self.cubelist1 + self.cubelist2)\r\nAssertionError: None != [<iris 'Cube' of foo / (unknown) (scalar [50 chars]be)>]\r\n```","created_at":"2018-12-15T13:07:28Z","updated_at":"2018-12-15T13:07:28Z","html_url":"https://github.com/SciTools/iris/pull/3238#discussion_r241949190","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/3238","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/241949190"},"html":{"href":"https://github.com/SciTools/iris/pull/3238#discussion_r241949190"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/3238"}},"in_reply_to_id":241853437},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/3238","id":236837454,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODM3NDU0","html_url":"https://github.com/SciTools/iris/pull/3238","diff_url":"https://github.com/SciTools/iris/pull/3238.diff","patch_url":"https://github.com/SciTools/iris/pull/3238.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/3238","number":3238,"state":"open","locked":false,"title":"Ensure cubelists only contain cubes","user":{"login":"rcomer","id":10599679,"node_id":"MDQ6VXNlcjEwNTk5Njc5","avatar_url":"https://avatars0.githubusercontent.com/u/10599679?v=4","gravatar_id":"","url":"https://api.github.com/users/rcomer","html_url":"https://github.com/rcomer","followers_url":"https://api.github.com/users/rcomer/followers","following_url":"https://api.github.com/users/rcomer/following{/other_user}","gists_url":"https://api.github.com/users/rcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/rcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcomer/subscriptions","organizations_url":"https://api.github.com/users/rcomer/orgs","repos_url":"https://api.github.com/users/rcomer/repos","events_url":"https://api.github.com/users/rcomer/events{/privacy}","received_events_url":"https://api.github.com/users/rcomer/received_events","type":"User","site_admin":false},"body":"See #1897.\r\n\r\nFor completeness, I have addressed `insert` and `extend` as well as `append` (have I missed any?), although\r\n   * I can't think of a reason to ever use `insert`.\r\n   * I'm not sure I've quite got the behaviour right for `extend`, particularly in the case where a cube is passed.  Would the distinction between `append` and `extend` seem a bit arbitrary to a new Python user?","created_at":"2018-12-07T11:28:55Z","updated_at":"2018-12-15T13:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"def843f7b1734af1fcaf445e8f211712c50c20d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/3238/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/3238/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/3238/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/3265a65ffdb63f83f1ffb864206fe9b1d0354307","head":{"label":"rcomer:cubelist-contain-only-cubes","ref":"cubelist-contain-only-cubes","sha":"3265a65ffdb63f83f1ffb864206fe9b1d0354307","user":{"login":"rcomer","id":10599679,"node_id":"MDQ6VXNlcjEwNTk5Njc5","avatar_url":"https://avatars0.githubusercontent.com/u/10599679?v=4","gravatar_id":"","url":"https://api.github.com/users/rcomer","html_url":"https://github.com/rcomer","followers_url":"https://api.github.com/users/rcomer/followers","following_url":"https://api.github.com/users/rcomer/following{/other_user}","gists_url":"https://api.github.com/users/rcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/rcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcomer/subscriptions","organizations_url":"https://api.github.com/users/rcomer/orgs","repos_url":"https://api.github.com/users/rcomer/repos","events_url":"https://api.github.com/users/rcomer/events{/privacy}","received_events_url":"https://api.github.com/users/rcomer/received_events","type":"User","site_admin":false},"repo":{"id":37473888,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ3Mzg4OA==","name":"iris","full_name":"rcomer/iris","private":false,"owner":{"login":"rcomer","id":10599679,"node_id":"MDQ6VXNlcjEwNTk5Njc5","avatar_url":"https://avatars0.githubusercontent.com/u/10599679?v=4","gravatar_id":"","url":"https://api.github.com/users/rcomer","html_url":"https://github.com/rcomer","followers_url":"https://api.github.com/users/rcomer/followers","following_url":"https://api.github.com/users/rcomer/following{/other_user}","gists_url":"https://api.github.com/users/rcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/rcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcomer/subscriptions","organizations_url":"https://api.github.com/users/rcomer/orgs","repos_url":"https://api.github.com/users/rcomer/repos","events_url":"https://api.github.com/users/rcomer/events{/privacy}","received_events_url":"https://api.github.com/users/rcomer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rcomer/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":true,"url":"https://api.github.com/repos/rcomer/iris","forks_url":"https://api.github.com/repos/rcomer/iris/forks","keys_url":"https://api.github.com/repos/rcomer/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcomer/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcomer/iris/teams","hooks_url":"https://api.github.com/repos/rcomer/iris/hooks","issue_events_url":"https://api.github.com/repos/rcomer/iris/issues/events{/number}","events_url":"https://api.github.com/repos/rcomer/iris/events","assignees_url":"https://api.github.com/repos/rcomer/iris/assignees{/user}","branches_url":"https://api.github.com/repos/rcomer/iris/branches{/branch}","tags_url":"https://api.github.com/repos/rcomer/iris/tags","blobs_url":"https://api.github.com/repos/rcomer/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcomer/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcomer/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcomer/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcomer/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/rcomer/iris/languages","stargazers_url":"https://api.github.com/repos/rcomer/iris/stargazers","contributors_url":"https://api.github.com/repos/rcomer/iris/contributors","subscribers_url":"https://api.github.com/repos/rcomer/iris/subscribers","subscription_url":"https://api.github.com/repos/rcomer/iris/subscription","commits_url":"https://api.github.com/repos/rcomer/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcomer/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcomer/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcomer/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcomer/iris/contents/{+path}","compare_url":"https://api.github.com/repos/rcomer/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcomer/iris/merges","archive_url":"https://api.github.com/repos/rcomer/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcomer/iris/downloads","issues_url":"https://api.github.com/repos/rcomer/iris/issues{/number}","pulls_url":"https://api.github.com/repos/rcomer/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/rcomer/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/rcomer/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcomer/iris/labels{/name}","releases_url":"https://api.github.com/repos/rcomer/iris/releases{/id}","deployments_url":"https://api.github.com/repos/rcomer/iris/deployments","created_at":"2015-06-15T15:31:04Z","updated_at":"2015-06-15T15:31:09Z","pushed_at":"2018-12-14T18:43:15Z","git_url":"git://github.com/rcomer/iris.git","ssh_url":"git@github.com:rcomer/iris.git","clone_url":"https://github.com/rcomer/iris.git","svn_url":"https://github.com/rcomer/iris","homepage":"http://scitools.org.uk/iris/","size":105966,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"SciTools:master","ref":"master","sha":"c9cd8f034c5e497abd1e785f88e3fdaab7db0505","user":{"login":"SciTools","id":1391487,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1391487?v=4","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"node_id":"MDEwOlJlcG9zaXRvcnk1MzEyNjQ4","name":"iris","full_name":"SciTools/iris","private":false,"owner":{"login":"SciTools","id":1391487,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1391487?v=4","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SciTools/iris","description":"A powerful, format-agnostic, and community-driven Python library for analysing and visualising Earth science data","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/iris/deployments","created_at":"2012-08-06T10:09:14Z","updated_at":"2018-12-15T05:42:57Z","pushed_at":"2018-12-14T18:43:17Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"https://scitools.org.uk/iris/docs/latest","size":105871,"stargazers_count":254,"watchers_count":254,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":155,"open_issues":250,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/3238"},"html":{"href":"https://github.com/SciTools/iris/pull/3238"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/3238"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/3238/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/3238/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/3238/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/3265a65ffdb63f83f1ffb864206fe9b1d0354307"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rcomer"}}