{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/204996611","pull_request_review_id":140178018,"id":204996611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk5NjYxMQ==","diff_hunk":"@@ -273,21 +274,28 @@ def _gen_xml(name,\n         else:\n             context['telnet_port'] = 23023  # FIXME: use random unused port\n     if 'serial_type' in context:\n+        if context['serial_type'] == 'nmdm' and 'nmdm_id' in kwargs:\n+            context['nmdm_id'] = kwargs['nmdm_id']","path":"salt/modules/virt.py","position":42,"original_position":42,"commit_id":"e2399baa9436afcf4ab30a5a2d99aba7fff2f151","original_commit_id":"818f7b1242d36b349c19ce5ee949095bcb06b6f8","user":{"login":"jeroen92","id":3180588,"node_id":"MDQ6VXNlcjMxODA1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3180588?v=4","gravatar_id":"","url":"https://api.github.com/users/jeroen92","html_url":"https://github.com/jeroen92","followers_url":"https://api.github.com/users/jeroen92/followers","following_url":"https://api.github.com/users/jeroen92/following{/other_user}","gists_url":"https://api.github.com/users/jeroen92/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroen92/subscriptions","organizations_url":"https://api.github.com/users/jeroen92/orgs","repos_url":"https://api.github.com/users/jeroen92/repos","events_url":"https://api.github.com/users/jeroen92/events{/privacy}","received_events_url":"https://api.github.com/users/jeroen92/received_events","type":"User","site_admin":false},"body":"Now bhyve has good support for VNC I'd suggest to omit the nmdm serial type.","created_at":"2018-07-25T06:45:45Z","updated_at":"2018-07-25T06:45:46Z","html_url":"https://github.com/saltstack/salt/pull/47620#discussion_r204996611","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/47620","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/204996611"},"html":{"href":"https://github.com/saltstack/salt/pull/47620#discussion_r204996611"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47620"}},"in_reply_to_id":190849245},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47620","id":187571721,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NTcxNzIx","html_url":"https://github.com/saltstack/salt/pull/47620","diff_url":"https://github.com/saltstack/salt/pull/47620.diff","patch_url":"https://github.com/saltstack/salt/pull/47620.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47620","number":47620,"state":"open","locked":false,"title":"Add bhyve support to virt","user":{"login":"jeroen92","id":3180588,"node_id":"MDQ6VXNlcjMxODA1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3180588?v=4","gravatar_id":"","url":"https://api.github.com/users/jeroen92","html_url":"https://github.com/jeroen92","followers_url":"https://api.github.com/users/jeroen92/followers","following_url":"https://api.github.com/users/jeroen92/following{/other_user}","gists_url":"https://api.github.com/users/jeroen92/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroen92/subscriptions","organizations_url":"https://api.github.com/users/jeroen92/orgs","repos_url":"https://api.github.com/users/jeroen92/repos","events_url":"https://api.github.com/users/jeroen92/events{/privacy}","received_events_url":"https://api.github.com/users/jeroen92/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nAdd bhyve support to the virt module, and add ZFS compatibility for cloning/creating zvols when using bhyve as a hypervisor.\r\n\r\n### What issues does this PR fix or reference?\r\n#47619\r\n\r\n### Previous Behavior\r\nNot implemented. Crashes when performing virt.init for a bhyve hypervisor.\r\n\r\n### New Behavior\r\nUsing virt.init for a bhyve hypervisor will create a VM with (multiple) ZFS provisioned disks. Using virt.purge will destroy the VM and the corresponding ZFS datasets.\r\n\r\n### Tests written?\r\nNo\r\n\r\n### Commits signed with GPG?\r\nNo\r\n","created_at":"2018-05-11T21:15:38Z","updated_at":"2018-07-25T06:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a8ab8e67a2905b2ac46812be1b3643451bbcbb4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47620/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47620/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47620/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/e2399baa9436afcf4ab30a5a2d99aba7fff2f151","head":{"label":"jeroen92:virt_bhyve","ref":"virt_bhyve","sha":"e2399baa9436afcf4ab30a5a2d99aba7fff2f151","user":{"login":"jeroen92","id":3180588,"node_id":"MDQ6VXNlcjMxODA1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3180588?v=4","gravatar_id":"","url":"https://api.github.com/users/jeroen92","html_url":"https://github.com/jeroen92","followers_url":"https://api.github.com/users/jeroen92/followers","following_url":"https://api.github.com/users/jeroen92/following{/other_user}","gists_url":"https://api.github.com/users/jeroen92/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroen92/subscriptions","organizations_url":"https://api.github.com/users/jeroen92/orgs","repos_url":"https://api.github.com/users/jeroen92/repos","events_url":"https://api.github.com/users/jeroen92/events{/privacy}","received_events_url":"https://api.github.com/users/jeroen92/received_events","type":"User","site_admin":false},"repo":{"id":125732252,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MzIyNTI=","name":"salt","full_name":"jeroen92/salt","owner":{"login":"jeroen92","id":3180588,"node_id":"MDQ6VXNlcjMxODA1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3180588?v=4","gravatar_id":"","url":"https://api.github.com/users/jeroen92","html_url":"https://github.com/jeroen92","followers_url":"https://api.github.com/users/jeroen92/followers","following_url":"https://api.github.com/users/jeroen92/following{/other_user}","gists_url":"https://api.github.com/users/jeroen92/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroen92/subscriptions","organizations_url":"https://api.github.com/users/jeroen92/orgs","repos_url":"https://api.github.com/users/jeroen92/repos","events_url":"https://api.github.com/users/jeroen92/events{/privacy}","received_events_url":"https://api.github.com/users/jeroen92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeroen92/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/jeroen92/salt","forks_url":"https://api.github.com/repos/jeroen92/salt/forks","keys_url":"https://api.github.com/repos/jeroen92/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeroen92/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeroen92/salt/teams","hooks_url":"https://api.github.com/repos/jeroen92/salt/hooks","issue_events_url":"https://api.github.com/repos/jeroen92/salt/issues/events{/number}","events_url":"https://api.github.com/repos/jeroen92/salt/events","assignees_url":"https://api.github.com/repos/jeroen92/salt/assignees{/user}","branches_url":"https://api.github.com/repos/jeroen92/salt/branches{/branch}","tags_url":"https://api.github.com/repos/jeroen92/salt/tags","blobs_url":"https://api.github.com/repos/jeroen92/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeroen92/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeroen92/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeroen92/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeroen92/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/jeroen92/salt/languages","stargazers_url":"https://api.github.com/repos/jeroen92/salt/stargazers","contributors_url":"https://api.github.com/repos/jeroen92/salt/contributors","subscribers_url":"https://api.github.com/repos/jeroen92/salt/subscribers","subscription_url":"https://api.github.com/repos/jeroen92/salt/subscription","commits_url":"https://api.github.com/repos/jeroen92/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeroen92/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeroen92/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeroen92/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeroen92/salt/contents/{+path}","compare_url":"https://api.github.com/repos/jeroen92/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeroen92/salt/merges","archive_url":"https://api.github.com/repos/jeroen92/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeroen92/salt/downloads","issues_url":"https://api.github.com/repos/jeroen92/salt/issues{/number}","pulls_url":"https://api.github.com/repos/jeroen92/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/jeroen92/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/jeroen92/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeroen92/salt/labels{/name}","releases_url":"https://api.github.com/repos/jeroen92/salt/releases{/id}","deployments_url":"https://api.github.com/repos/jeroen92/salt/deployments","created_at":"2018-03-18T14:17:58Z","updated_at":"2018-06-18T20:15:17Z","pushed_at":"2018-07-18T21:28:55Z","git_url":"git://github.com/jeroen92/salt.git","ssh_url":"git@github.com:jeroen92/salt.git","clone_url":"https://github.com/jeroen92/salt.git","svn_url":"https://github.com/jeroen92/salt","homepage":"https://repo.saltstack.com/","size":409757,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"2c2f790e070b8bd678281ba8b9d264e7447e24a2","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-07-25T04:28:20Z","pushed_at":"2018-07-25T06:09:40Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":411232,"stargazers_count":9069,"watchers_count":9069,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4225,"mirror_url":null,"archived":false,"open_issues_count":2972,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4225,"open_issues":2972,"watchers":9069,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47620"},"html":{"href":"https://github.com/saltstack/salt/pull/47620"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47620"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47620/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47620/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47620/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/e2399baa9436afcf4ab30a5a2d99aba7fff2f151"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeroen92"}}