{"action":"created","issue":{"url":"https://api.github.com/repos/DHTMLX/scheduler/issues/22","repository_url":"https://api.github.com/repos/DHTMLX/scheduler","labels_url":"https://api.github.com/repos/DHTMLX/scheduler/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/DHTMLX/scheduler/issues/22/comments","events_url":"https://api.github.com/repos/DHTMLX/scheduler/issues/22/events","html_url":"https://github.com/DHTMLX/scheduler/pull/22","id":157603563,"number":22,"title":"added checks for null","user":{"login":"kraaden","id":16059078,"avatar_url":"https://avatars1.githubusercontent.com/u/16059078?v=4","gravatar_id":"","url":"https://api.github.com/users/kraaden","html_url":"https://github.com/kraaden","followers_url":"https://api.github.com/users/kraaden/followers","following_url":"https://api.github.com/users/kraaden/following{/other_user}","gists_url":"https://api.github.com/users/kraaden/gists{/gist_id}","starred_url":"https://api.github.com/users/kraaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraaden/subscriptions","organizations_url":"https://api.github.com/users/kraaden/orgs","repos_url":"https://api.github.com/users/kraaden/repos","events_url":"https://api.github.com/users/kraaden/events{/privacy}","received_events_url":"https://api.github.com/users/kraaden/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-05-31T07:07:40Z","updated_at":"2018-02-01T14:15:11Z","closed_at":"2018-02-01T13:37:13Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DHTMLX/scheduler/pulls/22","html_url":"https://github.com/DHTMLX/scheduler/pull/22","diff_url":"https://github.com/DHTMLX/scheduler/pull/22.diff","patch_url":"https://github.com/DHTMLX/scheduler/pull/22.patch"},"body":"Added checks for null/undefined value on 2 places. In some rare cases it may cause exceptions because the method `scheduler.getEvent(...)` return null value and it was not checked.\n"},"comment":{"url":"https://api.github.com/repos/DHTMLX/scheduler/issues/comments/362277927","html_url":"https://github.com/DHTMLX/scheduler/pull/22#issuecomment-362277927","issue_url":"https://api.github.com/repos/DHTMLX/scheduler/issues/22","id":362277927,"user":{"login":"AlexKlimenkov","id":988260,"avatar_url":"https://avatars0.githubusercontent.com/u/988260?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKlimenkov","html_url":"https://github.com/AlexKlimenkov","followers_url":"https://api.github.com/users/AlexKlimenkov/followers","following_url":"https://api.github.com/users/AlexKlimenkov/following{/other_user}","gists_url":"https://api.github.com/users/AlexKlimenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKlimenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKlimenkov/subscriptions","organizations_url":"https://api.github.com/users/AlexKlimenkov/orgs","repos_url":"https://api.github.com/users/AlexKlimenkov/repos","events_url":"https://api.github.com/users/AlexKlimenkov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKlimenkov/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T14:15:11Z","updated_at":"2018-02-01T14:15:11Z","author_association":"CONTRIBUTOR","body":"Added null check from scheduler.addEvent to the main version - new event can be immediately deleted from onEventAdded, so probably non-existing record here is a valid scenario. changes will be included in the next version of scheduler, this repo will be updated at next release.\r\nDidn't add changes from scheduler._is_modified_occurence, I can't see an expected scenario for a null/undefined argument there (thus a js exception will be an expected behavior). Please reopen if you can share some use case when an empty value there is expected.\r\n\r\n"}}
{"actor":{"display_login":"AlexKlimenkov"}}