{"action":"created","issue":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/7729","repository_url":"https://api.github.com/repos/bokeh/bokeh","labels_url":"https://api.github.com/repos/bokeh/bokeh/issues/7729/labels{/name}","comments_url":"https://api.github.com/repos/bokeh/bokeh/issues/7729/comments","events_url":"https://api.github.com/repos/bokeh/bokeh/issues/7729/events","html_url":"https://github.com/bokeh/bokeh/issues/7729","id":310629470,"number":7729,"title":"Update of ipython to 6.3.0 breaks unit tests","user":{"login":"bryevdv","id":1078448,"avatar_url":"https://avatars3.githubusercontent.com/u/1078448?v=4","gravatar_id":"","url":"https://api.github.com/users/bryevdv","html_url":"https://github.com/bryevdv","followers_url":"https://api.github.com/users/bryevdv/followers","following_url":"https://api.github.com/users/bryevdv/following{/other_user}","gists_url":"https://api.github.com/users/bryevdv/gists{/gist_id}","starred_url":"https://api.github.com/users/bryevdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryevdv/subscriptions","organizations_url":"https://api.github.com/users/bryevdv/orgs","repos_url":"https://api.github.com/users/bryevdv/repos","events_url":"https://api.github.com/users/bryevdv/events{/privacy}","received_events_url":"https://api.github.com/users/bryevdv/received_events","type":"User","site_admin":false},"labels":[{"id":515235265,"url":"https://api.github.com/repos/bokeh/bokeh/labels/CRITICAL","name":"CRITICAL","color":"FF69B4","default":false},{"id":127605054,"url":"https://api.github.com/repos/bokeh/bokeh/labels/tag:%20component:%20build","name":"tag: component: build","color":"D0CBB8","default":false},{"id":106468141,"url":"https://api.github.com/repos/bokeh/bokeh/labels/type:%20task","name":"type: task","color":"872A50","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bokeh/bokeh/milestones/40","html_url":"https://github.com/bokeh/bokeh/milestone/40","labels_url":"https://api.github.com/repos/bokeh/bokeh/milestones/40/labels","id":3195384,"number":40,"title":"0.12.16","description":"","creator":{"login":"bryevdv","id":1078448,"avatar_url":"https://avatars3.githubusercontent.com/u/1078448?v=4","gravatar_id":"","url":"https://api.github.com/users/bryevdv","html_url":"https://github.com/bryevdv","followers_url":"https://api.github.com/users/bryevdv/followers","following_url":"https://api.github.com/users/bryevdv/following{/other_user}","gists_url":"https://api.github.com/users/bryevdv/gists{/gist_id}","starred_url":"https://api.github.com/users/bryevdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryevdv/subscriptions","organizations_url":"https://api.github.com/users/bryevdv/orgs","repos_url":"https://api.github.com/users/bryevdv/repos","events_url":"https://api.github.com/users/bryevdv/events{/privacy}","received_events_url":"https://api.github.com/users/bryevdv/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":4,"state":"open","created_at":"2018-03-17T21:49:18Z","updated_at":"2018-04-02T22:15:37Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2018-04-02T22:15:37Z","updated_at":"2018-04-03T13:21:45Z","closed_at":null,"author_association":"OWNER","body":"CI unit test build suddenly failing after recent update to ipython 6.3:\r\n```\r\n______________________________ test_Model_pretty _______________________________\r\n    def test_Model_pretty():\r\n>       class Foo1(Model):\r\nbokeh/tests/test_model.py:8: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\nmeta_cls = <class 'bokeh.model.MetaModel'>, class_name = 'Foo1'\r\nbases = (<class 'bokeh.model.Model'>,)\r\nclass_dict = {'__container_props__': set(), '__module__': 'bokeh.tests.test_model', '__properties__': set(), '__properties_with_refs__': set(), ...}\r\n    def __new__(meta_cls, class_name, bases, class_dict):\r\n        '''\r\n    \r\n            Raises:\r\n                Warning\r\n    \r\n            '''\r\n    \r\n        # use an explicitly provided view model name if there is one\r\n        if \"__view_model__\" not in class_dict:\r\n            class_dict[\"__view_model__\"] = class_name\r\n    \r\n        # call the parent metaclass to create the new model type\r\n        newcls = super(MetaModel, meta_cls).__new__(meta_cls, class_name, bases, class_dict)\r\n    \r\n        # update the mapping of view model names to classes, checking for any duplicates\r\n        # and handling any subtype relationships or custom implementations\r\n        entry = class_dict.get(\"__subtype__\", class_dict[\"__view_model__\"])\r\n        if entry in MetaModel.model_class_reverse_map and not hasattr(newcls, \"__implementation__\"):\r\n            raise Warning(\"Duplicate __view_model__ or __subtype__ declaration of '%s' for \" \\\r\n                          \"class %s.  Previous definition: %s\" % \\\r\n                          (entry, class_name,\r\n>                          MetaModel.model_class_reverse_map[entry]))\r\nE           Warning: Duplicate __view_model__ or __subtype__ declaration of 'Foo1' for class Foo1.  Previous definition: <class 'bokeh.tests.test_model.test_Model_pretty.<locals>.Foo1'>\r\n\r\n```\r\nconfirmed locally that this package difference triggers the failure.\r\n\r\nOne option is to pin the version but would like to identify the root cause as this connection is surprising and unexpected. "},"comment":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/comments/378247775","html_url":"https://github.com/bokeh/bokeh/issues/7729#issuecomment-378247775","issue_url":"https://api.github.com/repos/bokeh/bokeh/issues/7729","id":378247775,"user":{"login":"mattpap","id":27475,"avatar_url":"https://avatars2.githubusercontent.com/u/27475?v=4","gravatar_id":"","url":"https://api.github.com/users/mattpap","html_url":"https://github.com/mattpap","followers_url":"https://api.github.com/users/mattpap/followers","following_url":"https://api.github.com/users/mattpap/following{/other_user}","gists_url":"https://api.github.com/users/mattpap/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpap/subscriptions","organizations_url":"https://api.github.com/users/mattpap/orgs","repos_url":"https://api.github.com/users/mattpap/repos","events_url":"https://api.github.com/users/mattpap/events{/privacy}","received_events_url":"https://api.github.com/users/mattpap/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T13:21:45Z","updated_at":"2018-04-03T13:21:45Z","author_association":"CONTRIBUTOR","body":"> Is it deliberate that IPython pretty-printing of bokeh classes is disabled by using `_repr_pretty()` instead?\r\n\r\nIt was deliberate, because, assuming IPython is available, we don't want pretty representation by default in any frontend. Maybe there were better ways to achieve this. Based on your suggestions in #7732, I think, we will proceed with registering every bokeh model in `type_pprinters`."}}
{"actor":{"display_login":"mattpap"}}