{"action":"created","issue":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/578","repository_url":"https://api.github.com/repos/sakura-editor/sakura","labels_url":"https://api.github.com/repos/sakura-editor/sakura/issues/578/labels{/name}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/578/comments","events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/578/events","html_url":"https://github.com/sakura-editor/sakura/pull/578","id":372299212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTMwOTU3","number":578,"title":"DEBUG_SETPIXELを無効化する","user":{"login":"berryzplus","id":3253151,"node_id":"MDQ6VXNlcjMyNTMxNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3253151?v=4","gravatar_id":"","url":"https://api.github.com/users/berryzplus","html_url":"https://github.com/berryzplus","followers_url":"https://api.github.com/users/berryzplus/followers","following_url":"https://api.github.com/users/berryzplus/following{/other_user}","gists_url":"https://api.github.com/users/berryzplus/gists{/gist_id}","starred_url":"https://api.github.com/users/berryzplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berryzplus/subscriptions","organizations_url":"https://api.github.com/users/berryzplus/orgs","repos_url":"https://api.github.com/users/berryzplus/repos","events_url":"https://api.github.com/users/berryzplus/events{/privacy}","received_events_url":"https://api.github.com/users/berryzplus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-21T10:14:59Z","updated_at":"2018-10-28T15:30:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/578","html_url":"https://github.com/sakura-editor/sakura/pull/578","diff_url":"https://github.com/sakura-editor/sakura/pull/578.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/578.patch"},"body":"issue #568 「バージョン情報」のURL部分の1文字目より前の左上にドットがある を参照。\r\n\r\nDEBUG_SETPIXELはvista以降で描画のデバッグをする際に発生した不具合の対策関数。\r\n点を打つ命令(~~実際には2pxの線を引いている~~)を発行することで描画を即時反映させる目的のもの。\r\nこの関数の利用箇所は4箇所あるが、うち2箇所はデッドコード(ANSI版関数)。\r\n\r\naliveな関数呼出しが塗りつぶし処理の後にあるため、\r\n描画結果にゴミが見えてしまっているバグの対策として、\r\n~~点を打つ処理と塗りつぶし処理の呼出し順を入れ替える対応を行う。~~\r\n\r\n追記：\r\n現行windowsではDEBUG_SETPIXELの効果がまったくないことが判明。\r\nただ無駄に点を打つ処理と化しているので無効化するように修正します。\r\n"},"comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments/433715616","html_url":"https://github.com/sakura-editor/sakura/pull/578#issuecomment-433715616","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/578","id":433715616,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzcxNTYxNg==","user":{"login":"ds14050","id":23469385,"node_id":"MDQ6VXNlcjIzNDY5Mzg1","avatar_url":"https://avatars1.githubusercontent.com/u/23469385?v=4","gravatar_id":"","url":"https://api.github.com/users/ds14050","html_url":"https://github.com/ds14050","followers_url":"https://api.github.com/users/ds14050/followers","following_url":"https://api.github.com/users/ds14050/following{/other_user}","gists_url":"https://api.github.com/users/ds14050/gists{/gist_id}","starred_url":"https://api.github.com/users/ds14050/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ds14050/subscriptions","organizations_url":"https://api.github.com/users/ds14050/orgs","repos_url":"https://api.github.com/users/ds14050/repos","events_url":"https://api.github.com/users/ds14050/events{/privacy}","received_events_url":"https://api.github.com/users/ds14050/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T15:30:36Z","updated_at":"2018-10-28T15:30:36Z","author_association":"MEMBER","body":">もしかすると、vistaでは描画領域外に点を打つ処理が描画トランザクションを終了させるのかも知れません。実際の処理で描画終了後に何か処理があるわけではないので、描画トランザクションを強制終了させる意味はないように感じられますが、効果があった可能性はゼロじゃないです。\r\n\r\nトランザクションの強制終了によりステップバイステップで描画結果がデスクトップに反映されたのではないでしょうか。berryzplus さんの文章を読んでの感想ですが。\r\n\r\n----\r\n\r\n元からそういう考えではあったのですが、Vista より新しい Windows では効果が見られない不十分なデバッグ用の手段であることから、他の人の承認の元にコードを取り除くことに反対しているわけではありません。困るのが自分一人なら自分が困ったときに対処を考えれば済むことですので。\r\n"}}
{"actor":{"display_login":"ds14050"}}