{"action":"closed","number":330,"pull_request":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/330","id":206942232,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTQyMjMy","html_url":"https://github.com/ethereumjs/ethereumjs-vm/pull/330","diff_url":"https://github.com/ethereumjs/ethereumjs-vm/pull/330.diff","patch_url":"https://github.com/ethereumjs/ethereumjs-vm/pull/330.patch","issue_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/330","number":330,"state":"closed","locked":false,"title":"API Tests for the bloom module","user":{"login":"s1na","id":1591639,"node_id":"MDQ6VXNlcjE1OTE2Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1591639?v=4","gravatar_id":"","url":"https://api.github.com/users/s1na","html_url":"https://github.com/s1na","followers_url":"https://api.github.com/users/s1na/followers","following_url":"https://api.github.com/users/s1na/following{/other_user}","gists_url":"https://api.github.com/users/s1na/gists{/gist_id}","starred_url":"https://api.github.com/users/s1na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1na/subscriptions","organizations_url":"https://api.github.com/users/s1na/orgs","repos_url":"https://api.github.com/users/s1na/repos","events_url":"https://api.github.com/users/s1na/events{/privacy}","received_events_url":"https://api.github.com/users/s1na/received_events","type":"User","site_admin":false},"body":"This is the first sub-PR of #315, and contains only the tests added for `bloom`. I've cherry-picked commits from the other branch. Please let me know if you'd rather have it done some other way.\r\n\r\nOne case which is meant to test bloom's multiCheck fails. `multiCheck` converts inputs via hex to buffer, although `check` itself doesn't do such a thing.\r\n\r\nThis PR also fixes #333 ","created_at":"2018-08-08T09:17:06Z","updated_at":"2018-08-08T19:45:48Z","closed_at":"2018-08-08T19:45:48Z","merged_at":"2018-08-08T19:45:48Z","merge_commit_sha":"48d33dca39b56b54eab54cffcb20d3ba6991d2c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/330/commits","review_comments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/330/comments","review_comment_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/330/comments","statuses_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/statuses/2a63762bc15e4730bba2de23ec365eb3ce42e7ec","head":{"label":"s1na:api-tests-1","ref":"api-tests-1","sha":"2a63762bc15e4730bba2de23ec365eb3ce42e7ec","user":{"login":"s1na","id":1591639,"node_id":"MDQ6VXNlcjE1OTE2Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1591639?v=4","gravatar_id":"","url":"https://api.github.com/users/s1na","html_url":"https://github.com/s1na","followers_url":"https://api.github.com/users/s1na/followers","following_url":"https://api.github.com/users/s1na/following{/other_user}","gists_url":"https://api.github.com/users/s1na/gists{/gist_id}","starred_url":"https://api.github.com/users/s1na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1na/subscriptions","organizations_url":"https://api.github.com/users/s1na/orgs","repos_url":"https://api.github.com/users/s1na/repos","events_url":"https://api.github.com/users/s1na/events{/privacy}","received_events_url":"https://api.github.com/users/s1na/received_events","type":"User","site_admin":false},"repo":{"id":140938053,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA5MzgwNTM=","name":"ethereumjs-vm","full_name":"s1na/ethereumjs-vm","owner":{"login":"s1na","id":1591639,"node_id":"MDQ6VXNlcjE1OTE2Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1591639?v=4","gravatar_id":"","url":"https://api.github.com/users/s1na","html_url":"https://github.com/s1na","followers_url":"https://api.github.com/users/s1na/followers","following_url":"https://api.github.com/users/s1na/following{/other_user}","gists_url":"https://api.github.com/users/s1na/gists{/gist_id}","starred_url":"https://api.github.com/users/s1na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1na/subscriptions","organizations_url":"https://api.github.com/users/s1na/orgs","repos_url":"https://api.github.com/users/s1na/repos","events_url":"https://api.github.com/users/s1na/events{/privacy}","received_events_url":"https://api.github.com/users/s1na/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s1na/ethereumjs-vm","description":"The Ethereum VM implemented in JS","fork":true,"url":"https://api.github.com/repos/s1na/ethereumjs-vm","forks_url":"https://api.github.com/repos/s1na/ethereumjs-vm/forks","keys_url":"https://api.github.com/repos/s1na/ethereumjs-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s1na/ethereumjs-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s1na/ethereumjs-vm/teams","hooks_url":"https://api.github.com/repos/s1na/ethereumjs-vm/hooks","issue_events_url":"https://api.github.com/repos/s1na/ethereumjs-vm/issues/events{/number}","events_url":"https://api.github.com/repos/s1na/ethereumjs-vm/events","assignees_url":"https://api.github.com/repos/s1na/ethereumjs-vm/assignees{/user}","branches_url":"https://api.github.com/repos/s1na/ethereumjs-vm/branches{/branch}","tags_url":"https://api.github.com/repos/s1na/ethereumjs-vm/tags","blobs_url":"https://api.github.com/repos/s1na/ethereumjs-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s1na/ethereumjs-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s1na/ethereumjs-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/s1na/ethereumjs-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s1na/ethereumjs-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/s1na/ethereumjs-vm/languages","stargazers_url":"https://api.github.com/repos/s1na/ethereumjs-vm/stargazers","contributors_url":"https://api.github.com/repos/s1na/ethereumjs-vm/contributors","subscribers_url":"https://api.github.com/repos/s1na/ethereumjs-vm/subscribers","subscription_url":"https://api.github.com/repos/s1na/ethereumjs-vm/subscription","commits_url":"https://api.github.com/repos/s1na/ethereumjs-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/s1na/ethereumjs-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/s1na/ethereumjs-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/s1na/ethereumjs-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/s1na/ethereumjs-vm/contents/{+path}","compare_url":"https://api.github.com/repos/s1na/ethereumjs-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s1na/ethereumjs-vm/merges","archive_url":"https://api.github.com/repos/s1na/ethereumjs-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s1na/ethereumjs-vm/downloads","issues_url":"https://api.github.com/repos/s1na/ethereumjs-vm/issues{/number}","pulls_url":"https://api.github.com/repos/s1na/ethereumjs-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/s1na/ethereumjs-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/s1na/ethereumjs-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s1na/ethereumjs-vm/labels{/name}","releases_url":"https://api.github.com/repos/s1na/ethereumjs-vm/releases{/id}","deployments_url":"https://api.github.com/repos/s1na/ethereumjs-vm/deployments","created_at":"2018-07-14T10:45:25Z","updated_at":"2018-07-31T14:04:12Z","pushed_at":"2018-08-08T15:31:00Z","git_url":"git://github.com/s1na/ethereumjs-vm.git","ssh_url":"git@github.com:s1na/ethereumjs-vm.git","clone_url":"https://github.com/s1na/ethereumjs-vm.git","svn_url":"https://github.com/s1na/ethereumjs-vm","homepage":"","size":2291,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereumjs:master","ref":"master","sha":"742830096b600e4d825b5472eea66547c6424078","user":{"login":"ethereumjs","id":16297473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"repo":{"id":38885825,"node_id":"MDEwOlJlcG9zaXRvcnkzODg4NTgyNQ==","name":"ethereumjs-vm","full_name":"ethereumjs/ethereumjs-vm","owner":{"login":"ethereumjs","id":16297473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereumjs/ethereumjs-vm","description":"The Ethereum VM implemented in Javascript","fork":false,"url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm","forks_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/forks","keys_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/teams","hooks_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/hooks","issue_events_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/events{/number}","events_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/events","assignees_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/assignees{/user}","branches_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/branches{/branch}","tags_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/tags","blobs_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/languages","stargazers_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/stargazers","contributors_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/contributors","subscribers_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/subscribers","subscription_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/subscription","commits_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/contents/{+path}","compare_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/merges","archive_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/downloads","issues_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues{/number}","pulls_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/labels{/name}","releases_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/releases{/id}","deployments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/deployments","created_at":"2015-07-10T14:54:03Z","updated_at":"2018-08-08T10:09:42Z","pushed_at":"2018-08-08T19:45:48Z","git_url":"git://github.com/ethereumjs/ethereumjs-vm.git","ssh_url":"git@github.com:ethereumjs/ethereumjs-vm.git","clone_url":"https://github.com/ethereumjs/ethereumjs-vm.git","svn_url":"https://github.com/ethereumjs/ethereumjs-vm","homepage":"","size":2274,"stargazers_count":464,"watchers_count":464,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":151,"open_issues":38,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/330"},"html":{"href":"https://github.com/ethereumjs/ethereumjs-vm/pull/330"},"issue":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/330"},"comments":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/statuses/2a63762bc15e4730bba2de23ec365eb3ce42e7ec"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"holgerd77","id":931137,"node_id":"MDQ6VXNlcjkzMTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/931137?v=4","gravatar_id":"","url":"https://api.github.com/users/holgerd77","html_url":"https://github.com/holgerd77","followers_url":"https://api.github.com/users/holgerd77/followers","following_url":"https://api.github.com/users/holgerd77/following{/other_user}","gists_url":"https://api.github.com/users/holgerd77/gists{/gist_id}","starred_url":"https://api.github.com/users/holgerd77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holgerd77/subscriptions","organizations_url":"https://api.github.com/users/holgerd77/orgs","repos_url":"https://api.github.com/users/holgerd77/repos","events_url":"https://api.github.com/users/holgerd77/events{/privacy}","received_events_url":"https://api.github.com/users/holgerd77/received_events","type":"User","site_admin":false},"comments":1,"review_comments":10,"maintainer_can_modify":false,"commits":5,"additions":76,"deletions":21,"changed_files":4}}
{"actor":{"display_login":"holgerd77"}}