{"action":"created","comment":{"url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments/197294296","pull_request_review_id":131012684,"id":197294296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzI5NDI5Ng==","diff_hunk":"@@ -350,11 +348,21 @@ def body(*args) -> LoopState:\n \n             new_histories = RNNHistories(\n                 attention_histories=list(att_loop_states),\n-                logits=loop_state.histories.logits.write(step, logits),\n-                decoder_outputs=loop_state.histories.decoder_outputs.write(\n-                    step, cell_output),\n-                outputs=loop_state.histories.outputs.write(step, next_symbols),\n-                mask=loop_state.histories.mask.write(step, not_finished))\n+                logits=tf.concat(","path":"neuralmonkey/decoders/decoder.py","position":38,"original_position":38,"commit_id":"712caf325c15d736f8be06c8c7b1c5787110cacb","original_commit_id":"712caf325c15d736f8be06c8c7b1c5787110cacb","user":{"login":"jlibovicky","id":1221979,"node_id":"MDQ6VXNlcjEyMjE5Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1221979?v=4","gravatar_id":"","url":"https://api.github.com/users/jlibovicky","html_url":"https://github.com/jlibovicky","followers_url":"https://api.github.com/users/jlibovicky/followers","following_url":"https://api.github.com/users/jlibovicky/following{/other_user}","gists_url":"https://api.github.com/users/jlibovicky/gists{/gist_id}","starred_url":"https://api.github.com/users/jlibovicky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlibovicky/subscriptions","organizations_url":"https://api.github.com/users/jlibovicky/orgs","repos_url":"https://api.github.com/users/jlibovicky/repos","events_url":"https://api.github.com/users/jlibovicky/events{/privacy}","received_events_url":"https://api.github.com/users/jlibovicky/received_events","type":"User","site_admin":false},"body":"Tady bych udělal nějakou funkcičku `append` a zavolal 4krát místo psaní dokola.\r\n```python\r\ndef append(x: tf.Tensor, y: tf.Tensor) -> tf.Tensor:\r\n     return tf.concat([x, tf.exand_dims(y, 0)], axis=0)\r\n```","created_at":"2018-06-21T22:18:52Z","updated_at":"2018-06-21T22:28:54Z","html_url":"https://github.com/ufal/neuralmonkey/pull/695#discussion_r197294296","pull_request_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments/197294296"},"html":{"href":"https://github.com/ufal/neuralmonkey/pull/695#discussion_r197294296"},"pull_request":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695"}}},"pull_request":{"url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695","id":181137183,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgxMTM3MTgz","html_url":"https://github.com/ufal/neuralmonkey/pull/695","diff_url":"https://github.com/ufal/neuralmonkey/pull/695.diff","patch_url":"https://github.com/ufal/neuralmonkey/pull/695.patch","issue_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/695","number":695,"state":"open","locked":false,"title":"Batched Beam Search with Attentive Models","user":{"login":"varisd","id":13119757,"node_id":"MDQ6VXNlcjEzMTE5NzU3","avatar_url":"https://avatars1.githubusercontent.com/u/13119757?v=4","gravatar_id":"","url":"https://api.github.com/users/varisd","html_url":"https://github.com/varisd","followers_url":"https://api.github.com/users/varisd/followers","following_url":"https://api.github.com/users/varisd/following{/other_user}","gists_url":"https://api.github.com/users/varisd/gists{/gist_id}","starred_url":"https://api.github.com/users/varisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varisd/subscriptions","organizations_url":"https://api.github.com/users/varisd/orgs","repos_url":"https://api.github.com/users/varisd/repos","events_url":"https://api.github.com/users/varisd/events{/privacy}","received_events_url":"https://api.github.com/users/varisd/received_events","type":"User","site_admin":false},"body":"Fixed beamsearch_decoder.py. Now it works with the attention models even when using runners_batch_size > 1.\r\nThe BeamSearchDecoder assumes that the parent_decoder has attributes 'encoder_states' and 'encoder_mask' which are created during parent_decoder initialization via get_attention* methods.","created_at":"2018-04-12T09:12:58Z","updated_at":"2018-06-21T22:28:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"013190ba37f408f829ce85f28087287f14040d8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695/commits","review_comments_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695/comments","review_comment_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/695/comments","statuses_url":"https://api.github.com/repos/ufal/neuralmonkey/statuses/712caf325c15d736f8be06c8c7b1c5787110cacb","head":{"label":"ufal:beamsearch_fix","ref":"beamsearch_fix","sha":"712caf325c15d736f8be06c8c7b1c5787110cacb","user":{"login":"ufal","id":5220747,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjA3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5220747?v=4","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"repo":{"id":61285083,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI4NTA4Mw==","name":"neuralmonkey","full_name":"ufal/neuralmonkey","owner":{"login":"ufal","id":5220747,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjA3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5220747?v=4","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufal/neuralmonkey","description":"An open-source tool for sequence learning in NLP built on TensorFlow.","fork":false,"url":"https://api.github.com/repos/ufal/neuralmonkey","forks_url":"https://api.github.com/repos/ufal/neuralmonkey/forks","keys_url":"https://api.github.com/repos/ufal/neuralmonkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufal/neuralmonkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufal/neuralmonkey/teams","hooks_url":"https://api.github.com/repos/ufal/neuralmonkey/hooks","issue_events_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/events{/number}","events_url":"https://api.github.com/repos/ufal/neuralmonkey/events","assignees_url":"https://api.github.com/repos/ufal/neuralmonkey/assignees{/user}","branches_url":"https://api.github.com/repos/ufal/neuralmonkey/branches{/branch}","tags_url":"https://api.github.com/repos/ufal/neuralmonkey/tags","blobs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufal/neuralmonkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufal/neuralmonkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufal/neuralmonkey/statuses/{sha}","languages_url":"https://api.github.com/repos/ufal/neuralmonkey/languages","stargazers_url":"https://api.github.com/repos/ufal/neuralmonkey/stargazers","contributors_url":"https://api.github.com/repos/ufal/neuralmonkey/contributors","subscribers_url":"https://api.github.com/repos/ufal/neuralmonkey/subscribers","subscription_url":"https://api.github.com/repos/ufal/neuralmonkey/subscription","commits_url":"https://api.github.com/repos/ufal/neuralmonkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufal/neuralmonkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufal/neuralmonkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufal/neuralmonkey/contents/{+path}","compare_url":"https://api.github.com/repos/ufal/neuralmonkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufal/neuralmonkey/merges","archive_url":"https://api.github.com/repos/ufal/neuralmonkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufal/neuralmonkey/downloads","issues_url":"https://api.github.com/repos/ufal/neuralmonkey/issues{/number}","pulls_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls{/number}","milestones_url":"https://api.github.com/repos/ufal/neuralmonkey/milestones{/number}","notifications_url":"https://api.github.com/repos/ufal/neuralmonkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufal/neuralmonkey/labels{/name}","releases_url":"https://api.github.com/repos/ufal/neuralmonkey/releases{/id}","deployments_url":"https://api.github.com/repos/ufal/neuralmonkey/deployments","created_at":"2016-06-16T10:46:43Z","updated_at":"2018-06-21T10:59:55Z","pushed_at":"2018-06-21T11:27:49Z","git_url":"git://github.com/ufal/neuralmonkey.git","ssh_url":"git@github.com:ufal/neuralmonkey.git","clone_url":"https://github.com/ufal/neuralmonkey.git","svn_url":"https://github.com/ufal/neuralmonkey","homepage":"","size":7083,"stargazers_count":296,"watchers_count":296,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":76,"open_issues":96,"watchers":296,"default_branch":"master"}},"base":{"label":"ufal:master","ref":"master","sha":"702adc9cec2a78c8fa7be6cf0ad4cf3c0d9e5935","user":{"login":"ufal","id":5220747,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjA3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5220747?v=4","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"repo":{"id":61285083,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI4NTA4Mw==","name":"neuralmonkey","full_name":"ufal/neuralmonkey","owner":{"login":"ufal","id":5220747,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjA3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5220747?v=4","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufal/neuralmonkey","description":"An open-source tool for sequence learning in NLP built on TensorFlow.","fork":false,"url":"https://api.github.com/repos/ufal/neuralmonkey","forks_url":"https://api.github.com/repos/ufal/neuralmonkey/forks","keys_url":"https://api.github.com/repos/ufal/neuralmonkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufal/neuralmonkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufal/neuralmonkey/teams","hooks_url":"https://api.github.com/repos/ufal/neuralmonkey/hooks","issue_events_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/events{/number}","events_url":"https://api.github.com/repos/ufal/neuralmonkey/events","assignees_url":"https://api.github.com/repos/ufal/neuralmonkey/assignees{/user}","branches_url":"https://api.github.com/repos/ufal/neuralmonkey/branches{/branch}","tags_url":"https://api.github.com/repos/ufal/neuralmonkey/tags","blobs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufal/neuralmonkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufal/neuralmonkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufal/neuralmonkey/statuses/{sha}","languages_url":"https://api.github.com/repos/ufal/neuralmonkey/languages","stargazers_url":"https://api.github.com/repos/ufal/neuralmonkey/stargazers","contributors_url":"https://api.github.com/repos/ufal/neuralmonkey/contributors","subscribers_url":"https://api.github.com/repos/ufal/neuralmonkey/subscribers","subscription_url":"https://api.github.com/repos/ufal/neuralmonkey/subscription","commits_url":"https://api.github.com/repos/ufal/neuralmonkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufal/neuralmonkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufal/neuralmonkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufal/neuralmonkey/contents/{+path}","compare_url":"https://api.github.com/repos/ufal/neuralmonkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufal/neuralmonkey/merges","archive_url":"https://api.github.com/repos/ufal/neuralmonkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufal/neuralmonkey/downloads","issues_url":"https://api.github.com/repos/ufal/neuralmonkey/issues{/number}","pulls_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls{/number}","milestones_url":"https://api.github.com/repos/ufal/neuralmonkey/milestones{/number}","notifications_url":"https://api.github.com/repos/ufal/neuralmonkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufal/neuralmonkey/labels{/name}","releases_url":"https://api.github.com/repos/ufal/neuralmonkey/releases{/id}","deployments_url":"https://api.github.com/repos/ufal/neuralmonkey/deployments","created_at":"2016-06-16T10:46:43Z","updated_at":"2018-06-21T10:59:55Z","pushed_at":"2018-06-21T11:27:49Z","git_url":"git://github.com/ufal/neuralmonkey.git","ssh_url":"git@github.com:ufal/neuralmonkey.git","clone_url":"https://github.com/ufal/neuralmonkey.git","svn_url":"https://github.com/ufal/neuralmonkey","homepage":"","size":7083,"stargazers_count":296,"watchers_count":296,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":76,"open_issues":96,"watchers":296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695"},"html":{"href":"https://github.com/ufal/neuralmonkey/pull/695"},"issue":{"href":"https://api.github.com/repos/ufal/neuralmonkey/issues/695"},"comments":{"href":"https://api.github.com/repos/ufal/neuralmonkey/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/ufal/neuralmonkey/statuses/712caf325c15d736f8be06c8c7b1c5787110cacb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlibovicky"}}