{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59214","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59214/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59214/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59214/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59214","id":293649701,"number":59214,"title":"Migrate cpumanager to use checkpointing manager","user":{"login":"kdembler","id":12646744,"avatar_url":"https://avatars2.githubusercontent.com/u/12646744?v=4","gravatar_id":"","url":"https://api.github.com/users/kdembler","html_url":"https://github.com/kdembler","followers_url":"https://api.github.com/users/kdembler/followers","following_url":"https://api.github.com/users/kdembler/following{/other_user}","gists_url":"https://api.github.com/users/kdembler/gists{/gist_id}","starred_url":"https://api.github.com/users/kdembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdembler/subscriptions","organizations_url":"https://api.github.com/users/kdembler/orgs","repos_url":"https://api.github.com/users/kdembler/repos","events_url":"https://api.github.com/users/kdembler/events{/privacy}","received_events_url":"https://api.github.com/users/kdembler/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":267761362,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars3.githubusercontent.com/u/379372?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"assignees":[{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars3.githubusercontent.com/u/379372?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},{"login":"balajismaniam","id":4707353,"avatar_url":"https://avatars3.githubusercontent.com/u/4707353?v=4","gravatar_id":"","url":"https://api.github.com/users/balajismaniam","html_url":"https://github.com/balajismaniam","followers_url":"https://api.github.com/users/balajismaniam/followers","following_url":"https://api.github.com/users/balajismaniam/following{/other_user}","gists_url":"https://api.github.com/users/balajismaniam/gists{/gist_id}","starred_url":"https://api.github.com/users/balajismaniam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajismaniam/subscriptions","organizations_url":"https://api.github.com/users/balajismaniam/orgs","repos_url":"https://api.github.com/users/balajismaniam/repos","events_url":"https://api.github.com/users/balajismaniam/events{/privacy}","received_events_url":"https://api.github.com/users/balajismaniam/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-01T19:13:15Z","updated_at":"2018-02-09T10:02:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59214","html_url":"https://github.com/kubernetes/kubernetes/pull/59214","diff_url":"https://github.com/kubernetes/kubernetes/pull/59214.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59214.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR migrates `cpumanager` to use new kubelet level node checkpointing feature (#56040) to decrease code redundancy and improve consistency.\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #58339\r\n\r\n**Notes**:\r\nAt point of submitting PR the most straightforward approach was used - `state_checkpoint` implementation of `State` interface was added. However, with checkpointing implementation there might be no point to keep `State` interface and just use single implementation with checkpoint backend and in case of different backend than filestore needed just supply `cpumanager` with custom `CheckpointManager` implementation.\r\n\r\n/kind feature\r\n/sig node\r\ncc @flyingcougar @ConnorDoyle "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/364389734","html_url":"https://github.com/kubernetes/kubernetes/pull/59214#issuecomment-364389734","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59214","id":364389734,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T10:02:40Z","updated_at":"2018-02-09T10:02:40Z","author_association":"COLLABORATOR","body":"@kdembler: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-e2e-gce/20237/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-e2e-gce-device-plugin-gpu/17920/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-kops-aws | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-e2e-kops-aws/73865/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-kubemark-e2e-gce | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-kubemark-e2e-gce/75921/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-bazel-build | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-bazel-build/28582/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-bazel-test | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-bazel-test/30348/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-unit | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-unit/79624/) | `/test pull-kubernetes-unit`\npull-kubernetes-node-e2e | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-node-e2e/75072/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-verify | 9ad6f82fac6293968f96daa1b5c66f51fd41d3c5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59214/pull-kubernetes-verify/76310/) | `/test pull-kubernetes-verify`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/59214). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/kdembler). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}