{"action":"created","comment":{"url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/comments/242726445","pull_request_review_id":186308358,"id":242726445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjcyNjQ0NQ==","diff_hunk":"@@ -195,6 +201,33 @@ static bool prompt_transaction(const void *data, size_t length, cx_curve_t curve\n         default:\n             THROW(EXC_PARSE_ERROR);\n \n+        case OPERATION_TAG_PROPOSAL:\n+            {\n+                static const uint32_t TYPE_INDEX = 0;\n+                static const uint32_t SOURCE_INDEX = 1;\n+                static const uint32_t PERIOD_INDEX = 2;\n+                static const uint32_t PROTOCOL_HASH_INDEX = 3;\n+\n+                static const char *const proposal_prompts[] = {\n+                    \"Confirm\",\n+                    \"Source\",\n+                    \"Period\",\n+                    \"Protocol\",\n+                    NULL,\n+                };\n+\n+                if (!parsed_contract_to_string(get_value_buffer(SOURCE_INDEX), VALUE_WIDTH,\n+                                               &ops->operation.source)) return false;\n+                if (!number_to_string(get_value_buffer(PERIOD_INDEX),\n+                                      ops->operation.proposal.voting_period)) return false;\n+\n+                protocol_hash_to_string(get_value_buffer(PROTOCOL_HASH_INDEX), VALUE_WIDTH,","path":"src/apdu_sign.c","position":58,"original_position":58,"commit_id":"c5d871743554c2776d3286797396cd5fe0651ab4","original_commit_id":"c5d871743554c2776d3286797396cd5fe0651ab4","user":{"login":"3noch","id":882455,"node_id":"MDQ6VXNlcjg4MjQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/882455?v=4","gravatar_id":"","url":"https://api.github.com/users/3noch","html_url":"https://github.com/3noch","followers_url":"https://api.github.com/users/3noch/followers","following_url":"https://api.github.com/users/3noch/following{/other_user}","gists_url":"https://api.github.com/users/3noch/gists{/gist_id}","starred_url":"https://api.github.com/users/3noch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3noch/subscriptions","organizations_url":"https://api.github.com/users/3noch/orgs","repos_url":"https://api.github.com/users/3noch/repos","events_url":"https://api.github.com/users/3noch/events{/privacy}","received_events_url":"https://api.github.com/users/3noch/received_events","type":"User","site_admin":false},"body":"Should add `if (!` before this like elsewhere.","created_at":"2018-12-18T22:16:16Z","updated_at":"2018-12-18T22:21:29Z","html_url":"https://github.com/obsidiansystems/ledger-app-tezos/pull/34#discussion_r242726445","pull_request_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/comments/242726445"},"html":{"href":"https://github.com/obsidiansystems/ledger-app-tezos/pull/34#discussion_r242726445"},"pull_request":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34","id":239649884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjQ5ODg0","html_url":"https://github.com/obsidiansystems/ledger-app-tezos/pull/34","diff_url":"https://github.com/obsidiansystems/ledger-app-tezos/pull/34.diff","patch_url":"https://github.com/obsidiansystems/ledger-app-tezos/pull/34.patch","issue_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/34","number":34,"state":"open","locked":false,"title":"Sign proposals","user":{"login":"3noch","id":882455,"node_id":"MDQ6VXNlcjg4MjQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/882455?v=4","gravatar_id":"","url":"https://api.github.com/users/3noch","html_url":"https://github.com/3noch","followers_url":"https://api.github.com/users/3noch/followers","following_url":"https://api.github.com/users/3noch/following{/other_user}","gists_url":"https://api.github.com/users/3noch/gists{/gist_id}","starred_url":"https://api.github.com/users/3noch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3noch/subscriptions","organizations_url":"https://api.github.com/users/3noch/orgs","repos_url":"https://api.github.com/users/3noch/repos","events_url":"https://api.github.com/users/3noch/events{/privacy}","received_events_url":"https://api.github.com/users/3noch/received_events","type":"User","site_admin":false},"body":"This includes numerous changes to save on memory, as it turns out we were very near the edge of our limit and had several setbacks due to hard-to-track-down crashes.","created_at":"2018-12-18T22:15:26Z","updated_at":"2018-12-18T22:21:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d1da8b5d8af842c05abf5647937a3522d47a7cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34/commits","review_comments_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34/comments","review_comment_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/34/comments","statuses_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/statuses/c5d871743554c2776d3286797396cd5fe0651ab4","head":{"label":"obsidiansystems:eac-sign-proposals","ref":"eac-sign-proposals","sha":"c5d871743554c2776d3286797396cd5fe0651ab4","user":{"login":"obsidiansystems","id":11916262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTE2MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/11916262?v=4","gravatar_id":"","url":"https://api.github.com/users/obsidiansystems","html_url":"https://github.com/obsidiansystems","followers_url":"https://api.github.com/users/obsidiansystems/followers","following_url":"https://api.github.com/users/obsidiansystems/following{/other_user}","gists_url":"https://api.github.com/users/obsidiansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/obsidiansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsidiansystems/subscriptions","organizations_url":"https://api.github.com/users/obsidiansystems/orgs","repos_url":"https://api.github.com/users/obsidiansystems/repos","events_url":"https://api.github.com/users/obsidiansystems/events{/privacy}","received_events_url":"https://api.github.com/users/obsidiansystems/received_events","type":"Organization","site_admin":false},"repo":{"id":135602726,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MDI3MjY=","name":"ledger-app-tezos","full_name":"obsidiansystems/ledger-app-tezos","private":false,"owner":{"login":"obsidiansystems","id":11916262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTE2MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/11916262?v=4","gravatar_id":"","url":"https://api.github.com/users/obsidiansystems","html_url":"https://github.com/obsidiansystems","followers_url":"https://api.github.com/users/obsidiansystems/followers","following_url":"https://api.github.com/users/obsidiansystems/following{/other_user}","gists_url":"https://api.github.com/users/obsidiansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/obsidiansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsidiansystems/subscriptions","organizations_url":"https://api.github.com/users/obsidiansystems/orgs","repos_url":"https://api.github.com/users/obsidiansystems/repos","events_url":"https://api.github.com/users/obsidiansystems/events{/privacy}","received_events_url":"https://api.github.com/users/obsidiansystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/obsidiansystems/ledger-app-tezos","description":"Ledger app for Tezos","fork":false,"url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos","forks_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/forks","keys_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/teams","hooks_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/hooks","issue_events_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/events{/number}","events_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/events","assignees_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/assignees{/user}","branches_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/branches{/branch}","tags_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/tags","blobs_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/refs{/sha}","trees_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/statuses/{sha}","languages_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/languages","stargazers_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/stargazers","contributors_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/contributors","subscribers_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/subscribers","subscription_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/subscription","commits_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/commits{/sha}","git_commits_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/commits{/sha}","comments_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/comments{/number}","issue_comment_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/comments{/number}","contents_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/contents/{+path}","compare_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/merges","archive_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/downloads","issues_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues{/number}","pulls_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls{/number}","milestones_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/milestones{/number}","notifications_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/labels{/name}","releases_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/releases{/id}","deployments_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/deployments","created_at":"2018-05-31T15:32:34Z","updated_at":"2018-12-13T17:05:34Z","pushed_at":"2018-12-18T22:15:27Z","git_url":"git://github.com/obsidiansystems/ledger-app-tezos.git","ssh_url":"git@github.com:obsidiansystems/ledger-app-tezos.git","clone_url":"https://github.com/obsidiansystems/ledger-app-tezos.git","svn_url":"https://github.com/obsidiansystems/ledger-app-tezos","homepage":null,"size":464,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":10,"watchers":53,"default_branch":"master"}},"base":{"label":"obsidiansystems:master","ref":"master","sha":"601c69f6c6f675dc653e8e19785967a1e5d9ff4a","user":{"login":"obsidiansystems","id":11916262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTE2MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/11916262?v=4","gravatar_id":"","url":"https://api.github.com/users/obsidiansystems","html_url":"https://github.com/obsidiansystems","followers_url":"https://api.github.com/users/obsidiansystems/followers","following_url":"https://api.github.com/users/obsidiansystems/following{/other_user}","gists_url":"https://api.github.com/users/obsidiansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/obsidiansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsidiansystems/subscriptions","organizations_url":"https://api.github.com/users/obsidiansystems/orgs","repos_url":"https://api.github.com/users/obsidiansystems/repos","events_url":"https://api.github.com/users/obsidiansystems/events{/privacy}","received_events_url":"https://api.github.com/users/obsidiansystems/received_events","type":"Organization","site_admin":false},"repo":{"id":135602726,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MDI3MjY=","name":"ledger-app-tezos","full_name":"obsidiansystems/ledger-app-tezos","private":false,"owner":{"login":"obsidiansystems","id":11916262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTE2MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/11916262?v=4","gravatar_id":"","url":"https://api.github.com/users/obsidiansystems","html_url":"https://github.com/obsidiansystems","followers_url":"https://api.github.com/users/obsidiansystems/followers","following_url":"https://api.github.com/users/obsidiansystems/following{/other_user}","gists_url":"https://api.github.com/users/obsidiansystems/gists{/gist_id}","starred_url":"https://api.github.com/users/obsidiansystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsidiansystems/subscriptions","organizations_url":"https://api.github.com/users/obsidiansystems/orgs","repos_url":"https://api.github.com/users/obsidiansystems/repos","events_url":"https://api.github.com/users/obsidiansystems/events{/privacy}","received_events_url":"https://api.github.com/users/obsidiansystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/obsidiansystems/ledger-app-tezos","description":"Ledger app for Tezos","fork":false,"url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos","forks_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/forks","keys_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/teams","hooks_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/hooks","issue_events_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/events{/number}","events_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/events","assignees_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/assignees{/user}","branches_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/branches{/branch}","tags_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/tags","blobs_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/refs{/sha}","trees_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/statuses/{sha}","languages_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/languages","stargazers_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/stargazers","contributors_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/contributors","subscribers_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/subscribers","subscription_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/subscription","commits_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/commits{/sha}","git_commits_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/git/commits{/sha}","comments_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/comments{/number}","issue_comment_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/comments{/number}","contents_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/contents/{+path}","compare_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/merges","archive_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/downloads","issues_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues{/number}","pulls_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls{/number}","milestones_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/milestones{/number}","notifications_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/labels{/name}","releases_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/releases{/id}","deployments_url":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/deployments","created_at":"2018-05-31T15:32:34Z","updated_at":"2018-12-13T17:05:34Z","pushed_at":"2018-12-18T22:15:27Z","git_url":"git://github.com/obsidiansystems/ledger-app-tezos.git","ssh_url":"git@github.com:obsidiansystems/ledger-app-tezos.git","clone_url":"https://github.com/obsidiansystems/ledger-app-tezos.git","svn_url":"https://github.com/obsidiansystems/ledger-app-tezos","homepage":null,"size":464,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":10,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34"},"html":{"href":"https://github.com/obsidiansystems/ledger-app-tezos/pull/34"},"issue":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/34"},"comments":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/obsidiansystems/ledger-app-tezos/statuses/c5d871743554c2776d3286797396cd5fe0651ab4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"3noch"}}