{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack-cli/issues/377","repository_url":"https://api.github.com/repos/webpack/webpack-cli","labels_url":"https://api.github.com/repos/webpack/webpack-cli/issues/377/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/issues/377/comments","events_url":"https://api.github.com/repos/webpack/webpack-cli/issues/377/events","html_url":"https://github.com/webpack/webpack-cli/pull/377","id":312164150,"number":377,"title":"Add node flags to CLI","user":{"login":"PlayMa256","id":831308,"avatar_url":"https://avatars0.githubusercontent.com/u/831308?v=4","gravatar_id":"","url":"https://api.github.com/users/PlayMa256","html_url":"https://github.com/PlayMa256","followers_url":"https://api.github.com/users/PlayMa256/followers","following_url":"https://api.github.com/users/PlayMa256/following{/other_user}","gists_url":"https://api.github.com/users/PlayMa256/gists{/gist_id}","starred_url":"https://api.github.com/users/PlayMa256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlayMa256/subscriptions","organizations_url":"https://api.github.com/users/PlayMa256/orgs","repos_url":"https://api.github.com/users/PlayMa256/repos","events_url":"https://api.github.com/users/PlayMa256/events{/privacy}","received_events_url":"https://api.github.com/users/PlayMa256/received_events","type":"User","site_admin":false},"labels":[{"id":796805016,"url":"https://api.github.com/repos/webpack/webpack-cli/labels/PR:%20CI-ok","name":"PR: CI-ok","color":"0e8a16","default":false},{"id":796833141,"url":"https://api.github.com/repos/webpack/webpack-cli/labels/PR:%20reviewed-approved","name":"PR: reviewed-approved","color":"0e8a16","default":false},{"id":891044554,"url":"https://api.github.com/repos/webpack/webpack-cli/labels/Semver:%20minor%20%E2%9A%99%EF%B8%8F","name":"Semver: minor ⚙️","color":"f9d1a2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-04-07T02:43:38Z","updated_at":"2018-04-10T13:47:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/377","html_url":"https://github.com/webpack/webpack-cli/pull/377","diff_url":"https://github.com/webpack/webpack-cli/pull/377.diff","patch_url":"https://github.com/webpack/webpack-cli/pull/377.patch"},"body":"**What kind of change does this PR introduce?**\r\nFeature\r\n\r\n**Did you add tests for your changes?**\r\nTest added, i'm not really sure if that it is enough. If it is not, let me know. Since node has quite a few flags, i don't think testing each of them is a good thing.\r\n\r\n**If relevant, did you update the documentation?**\r\nTo be updated. Just double checking: this update has to go in the webpack docs, or internal docs?\r\n\r\n**Summary**\r\nThis is a feature implementation based on #289. \r\nThis pr introduces a way to pass down node flags to execute the cli. To be able to differenciate these flags, a prefix is added to them. E.g. `--node.max_old_value=2048`. At the end, this allows us to accept every single node flag, without having to compare every single one.\r\n\r\n**Does this PR introduce a breaking change?**\r\nno\r\n"},"comment":{"url":"https://api.github.com/repos/webpack/webpack-cli/issues/comments/380104190","html_url":"https://github.com/webpack/webpack-cli/pull/377#issuecomment-380104190","issue_url":"https://api.github.com/repos/webpack/webpack-cli/issues/377","id":380104190,"user":{"login":"ev1stensberg","id":16735925,"avatar_url":"https://avatars0.githubusercontent.com/u/16735925?v=4","gravatar_id":"","url":"https://api.github.com/users/ev1stensberg","html_url":"https://github.com/ev1stensberg","followers_url":"https://api.github.com/users/ev1stensberg/followers","following_url":"https://api.github.com/users/ev1stensberg/following{/other_user}","gists_url":"https://api.github.com/users/ev1stensberg/gists{/gist_id}","starred_url":"https://api.github.com/users/ev1stensberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev1stensberg/subscriptions","organizations_url":"https://api.github.com/users/ev1stensberg/orgs","repos_url":"https://api.github.com/users/ev1stensberg/repos","events_url":"https://api.github.com/users/ev1stensberg/events{/privacy}","received_events_url":"https://api.github.com/users/ev1stensberg/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T13:47:23Z","updated_at":"2018-04-10T13:47:23Z","author_association":"MEMBER","body":"@montogeek not necessarily. The process won't pick the flags up"}}
{"actor":{"display_login":"ev1stensberg"}}