{"action":"created","issue":{"url":"https://api.github.com/repos/ARM-software/tf-issues/issues/513","repository_url":"https://api.github.com/repos/ARM-software/tf-issues","labels_url":"https://api.github.com/repos/ARM-software/tf-issues/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/ARM-software/tf-issues/issues/513/comments","events_url":"https://api.github.com/repos/ARM-software/tf-issues/issues/513/events","html_url":"https://github.com/ARM-software/tf-issues/issues/513","id":253757986,"number":513,"title":"RK3399 redundant assigment of \"twr_tmp\"","user":{"login":"JoseRivas-R","id":7201717,"avatar_url":"https://avatars0.githubusercontent.com/u/7201717?v=4","gravatar_id":"","url":"https://api.github.com/users/JoseRivas-R","html_url":"https://github.com/JoseRivas-R","followers_url":"https://api.github.com/users/JoseRivas-R/followers","following_url":"https://api.github.com/users/JoseRivas-R/following{/other_user}","gists_url":"https://api.github.com/users/JoseRivas-R/gists{/gist_id}","starred_url":"https://api.github.com/users/JoseRivas-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoseRivas-R/subscriptions","organizations_url":"https://api.github.com/users/JoseRivas-R/orgs","repos_url":"https://api.github.com/users/JoseRivas-R/repos","events_url":"https://api.github.com/users/JoseRivas-R/events{/privacy}","received_events_url":"https://api.github.com/users/JoseRivas-R/received_events","type":"User","site_admin":false},"labels":[{"id":74922110,"url":"https://api.github.com/repos/ARM-software/tf-issues/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-29T18:21:21Z","updated_at":"2018-02-03T00:42:04Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nI was reviewing the code and I found a \"twr_tmp = twr_tmp\" on line 778 of rk3399/drivers/dram/dram_spec_timing.c \r\n\r\nComparing to the rest of lines (see image), I think is not the expected assignment. It seems it should be \"twr_tmp=12\".\r\n\r\n![rockchip_rk3399](https://user-images.githubusercontent.com/7201717/29837087-80318aa6-8cf7-11e7-95da-845cb82d64c1.png)\r\n\r\nThank you,\r\nRegards\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ARM-software/tf-issues/issues/comments/362753064","html_url":"https://github.com/ARM-software/tf-issues/issues/513#issuecomment-362753064","issue_url":"https://api.github.com/repos/ARM-software/tf-issues/issues/513","id":362753064,"user":{"login":"dbasehore","id":29614261,"avatar_url":"https://avatars0.githubusercontent.com/u/29614261?v=4","gravatar_id":"","url":"https://api.github.com/users/dbasehore","html_url":"https://github.com/dbasehore","followers_url":"https://api.github.com/users/dbasehore/followers","following_url":"https://api.github.com/users/dbasehore/following{/other_user}","gists_url":"https://api.github.com/users/dbasehore/gists{/gist_id}","starred_url":"https://api.github.com/users/dbasehore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbasehore/subscriptions","organizations_url":"https://api.github.com/users/dbasehore/orgs","repos_url":"https://api.github.com/users/dbasehore/repos","events_url":"https://api.github.com/users/dbasehore/events{/privacy}","received_events_url":"https://api.github.com/users/dbasehore/received_events","type":"User","site_admin":false},"created_at":"2018-02-03T00:42:04Z","updated_at":"2018-02-03T00:42:04Z","author_association":"NONE","body":"I read through MR1 and MR2 documentation (which this value affects), and the twr_tmp = twr_tmp statement isn't a bug. 8-12 is the range where the nWR value isn't rounded to certain values such as 6, 14, and 16."}}
{"actor":{"display_login":"dbasehore"}}