{"action":"opened","number":873,"pull_request":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/873","id":209699520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Njk5NTIw","html_url":"https://github.com/alliedmodders/sourcemod/pull/873","diff_url":"https://github.com/alliedmodders/sourcemod/pull/873.diff","patch_url":"https://github.com/alliedmodders/sourcemod/pull/873.patch","issue_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/873","number":873,"state":"open","locked":false,"title":"Make CheckConfig default fallback opt-in","user":{"login":"Headline","id":11095737,"node_id":"MDQ6VXNlcjExMDk1NzM3","avatar_url":"https://avatars0.githubusercontent.com/u/11095737?v=4","gravatar_id":"","url":"https://api.github.com/users/Headline","html_url":"https://github.com/Headline","followers_url":"https://api.github.com/users/Headline/followers","following_url":"https://api.github.com/users/Headline/following{/other_user}","gists_url":"https://api.github.com/users/Headline/gists{/gist_id}","starred_url":"https://api.github.com/users/Headline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Headline/subscriptions","organizations_url":"https://api.github.com/users/Headline/orgs","repos_url":"https://api.github.com/users/Headline/repos","events_url":"https://api.github.com/users/Headline/events{/privacy}","received_events_url":"https://api.github.com/users/Headline/received_events","type":"User","site_admin":false},"body":"This is a minimal change, more can be done.\r\n\r\nBasically, `SQL_CheckConfig` used to fallback to \"default\" configuration and return true. This is different from old behavior and would break older plugins. Contrary to what we thought, DBManager::Connect doesn't fall-back to default configuration.\r\n\r\nBecause of this, I'm not opposed to removing the default parameter in SQL_CheckConfig entirely and just make it always pass true into the FindDatabaseConf method (which now disables default fallback), but I decided to throw this up here and get the conversation started.\r\n","created_at":"2018-08-21T03:33:40Z","updated_at":"2018-08-21T03:33:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/873/commits","review_comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/873/comments","review_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/873/comments","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/a279d584f57c84695a4f7f286d0cbf692fdca1c8","head":{"label":"alliedmodders:dpconfig-opt-in","ref":"dpconfig-opt-in","sha":"a279d584f57c84695a4f7f286d0cbf692fdca1c8","user":{"login":"alliedmodders","id":6601917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MDE5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6601917?v=4","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE0NTI3NA==","name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MDE5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6601917?v=4","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","deployments_url":"https://api.github.com/repos/alliedmodders/sourcemod/deployments","created_at":"2014-05-25T02:58:39Z","updated_at":"2018-08-20T04:23:06Z","pushed_at":"2018-08-21T03:30:14Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":38838,"stargazers_count":371,"watchers_count":371,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":183,"open_issues":47,"watchers":371,"default_branch":"master"}},"base":{"label":"alliedmodders:master","ref":"master","sha":"caf09142898688cedbe5da1c8a18eb70c2afaf79","user":{"login":"alliedmodders","id":6601917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MDE5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6601917?v=4","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE0NTI3NA==","name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MDE5MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6601917?v=4","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","deployments_url":"https://api.github.com/repos/alliedmodders/sourcemod/deployments","created_at":"2014-05-25T02:58:39Z","updated_at":"2018-08-20T04:23:06Z","pushed_at":"2018-08-21T03:30:14Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":38838,"stargazers_count":371,"watchers_count":371,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":183,"open_issues":47,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/873"},"html":{"href":"https://github.com/alliedmodders/sourcemod/pull/873"},"issue":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/873"},"comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/873/comments"},"review_comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/873/comments"},"review_comment":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/873/commits"},"statuses":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/a279d584f57c84695a4f7f286d0cbf692fdca1c8"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":8,"changed_files":5}}
{"actor":{"display_login":"Headline"}}