{"action":"created","comment":{"url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/comments/212503523","pull_request_review_id":149153285,"id":212503523,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjUwMzUyMw==","diff_hunk":"@@ -71,57 +69,111 @@\n   end\n \n   describe 'GET /todos/:id' do\n-    subject { get \"/todos/#{todo.id}\" }\n+    subject { get path }","path":"spec/requests/todos_spec.rb","position":null,"original_position":21,"commit_id":"b83c8ca59bb313d68ee784f2b9881d144b5fee72","original_commit_id":"bfbf4611e171ce3af1c51dfde81065a664aaaafc","user":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"body":"ご指摘内容ありがとうございます！私もここは書いてて違和感があったものの、 describe 直下に subject を記述するという引き出ししか持ち合わせていなかったため、 `path` という変数を使っていました😭\r\n\r\n> 一番内側のグループ(describe/context)単位で subject を書き、中身では極力変数を使わない、くらいがちょうどよいかもしれない\r\n\r\nこちらのコメントを見て、私もそちらの方がいいと感じたので、 b83c8ca で修正させていただきました✨","created_at":"2018-08-24T01:54:54Z","updated_at":"2018-08-24T01:54:54Z","html_url":"https://github.com/chionyan/simple-todo-api/pull/14#discussion_r212503523","pull_request_url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/comments/212503523"},"html":{"href":"https://github.com/chionyan/simple-todo-api/pull/14#discussion_r212503523"},"pull_request":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14"}},"in_reply_to_id":212478060},"pull_request":{"url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14","id":210377628,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzc3NjI4","html_url":"https://github.com/chionyan/simple-todo-api/pull/14","diff_url":"https://github.com/chionyan/simple-todo-api/pull/14.diff","patch_url":"https://github.com/chionyan/simple-todo-api/pull/14.patch","issue_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues/14","number":14,"state":"open","locked":false,"title":"Not found 時のテストの追加","user":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"body":"このPRにおける目的\r\n----\r\n- [#11](https://github.com/chionyan/simple-todo-api/pull/11)でスコープ外としていた、`todos#show` `todos#update` で捕捉できる `ActiveRecord::RecordNotFound` の例外処理のテストの追加する。\r\n\r\nやったこと\r\n----\r\n- `'GET /todos/:id'` `PATCH /todos/:id` の describe にレコードが存在しなかった時のテストを追加\r\n\r\n動作確認\r\n----\r\n\r\n- [ ] RSpec\r\n  - `$ bundle exec rspec` を実行\r\n  - [ ] `0 failures` が出力されることを確認\r\n- [ ] Rubocop\r\n  - `$ bundle exec rubocop` を実行\r\n  - [ ] `no offenses detected` が出力されることを確認\r\n","created_at":"2018-08-23T09:01:17Z","updated_at":"2018-08-24T01:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fabe124e9665fb0cf1134fdc96f3011600f6185","assignee":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"assignees":[{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pokotyamu","id":3479317,"node_id":"MDQ6VXNlcjM0NzkzMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3479317?v=4","gravatar_id":"","url":"https://api.github.com/users/pokotyamu","html_url":"https://github.com/pokotyamu","followers_url":"https://api.github.com/users/pokotyamu/followers","following_url":"https://api.github.com/users/pokotyamu/following{/other_user}","gists_url":"https://api.github.com/users/pokotyamu/gists{/gist_id}","starred_url":"https://api.github.com/users/pokotyamu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pokotyamu/subscriptions","organizations_url":"https://api.github.com/users/pokotyamu/orgs","repos_url":"https://api.github.com/users/pokotyamu/repos","events_url":"https://api.github.com/users/pokotyamu/events{/privacy}","received_events_url":"https://api.github.com/users/pokotyamu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1022447001,"node_id":"MDU6TGFiZWwxMDIyNDQ3MDAx","url":"https://api.github.com/repos/chionyan/simple-todo-api/labels/Ready%20for%20Review","name":"Ready for Review","color":"ffc6dc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14/commits","review_comments_url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14/comments","review_comment_url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues/14/comments","statuses_url":"https://api.github.com/repos/chionyan/simple-todo-api/statuses/b83c8ca59bb313d68ee784f2b9881d144b5fee72","head":{"label":"chionyan:error-not-found","ref":"error-not-found","sha":"b83c8ca59bb313d68ee784f2b9881d144b5fee72","user":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"repo":{"id":144514820,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1MTQ4MjA=","name":"simple-todo-api","full_name":"chionyan/simple-todo-api","owner":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chionyan/simple-todo-api","description":null,"fork":false,"url":"https://api.github.com/repos/chionyan/simple-todo-api","forks_url":"https://api.github.com/repos/chionyan/simple-todo-api/forks","keys_url":"https://api.github.com/repos/chionyan/simple-todo-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chionyan/simple-todo-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chionyan/simple-todo-api/teams","hooks_url":"https://api.github.com/repos/chionyan/simple-todo-api/hooks","issue_events_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues/events{/number}","events_url":"https://api.github.com/repos/chionyan/simple-todo-api/events","assignees_url":"https://api.github.com/repos/chionyan/simple-todo-api/assignees{/user}","branches_url":"https://api.github.com/repos/chionyan/simple-todo-api/branches{/branch}","tags_url":"https://api.github.com/repos/chionyan/simple-todo-api/tags","blobs_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chionyan/simple-todo-api/statuses/{sha}","languages_url":"https://api.github.com/repos/chionyan/simple-todo-api/languages","stargazers_url":"https://api.github.com/repos/chionyan/simple-todo-api/stargazers","contributors_url":"https://api.github.com/repos/chionyan/simple-todo-api/contributors","subscribers_url":"https://api.github.com/repos/chionyan/simple-todo-api/subscribers","subscription_url":"https://api.github.com/repos/chionyan/simple-todo-api/subscription","commits_url":"https://api.github.com/repos/chionyan/simple-todo-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/chionyan/simple-todo-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/chionyan/simple-todo-api/contents/{+path}","compare_url":"https://api.github.com/repos/chionyan/simple-todo-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chionyan/simple-todo-api/merges","archive_url":"https://api.github.com/repos/chionyan/simple-todo-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chionyan/simple-todo-api/downloads","issues_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues{/number}","pulls_url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls{/number}","milestones_url":"https://api.github.com/repos/chionyan/simple-todo-api/milestones{/number}","notifications_url":"https://api.github.com/repos/chionyan/simple-todo-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chionyan/simple-todo-api/labels{/name}","releases_url":"https://api.github.com/repos/chionyan/simple-todo-api/releases{/id}","deployments_url":"https://api.github.com/repos/chionyan/simple-todo-api/deployments","created_at":"2018-08-13T01:29:40Z","updated_at":"2018-08-23T09:23:07Z","pushed_at":"2018-08-24T01:51:51Z","git_url":"git://github.com/chionyan/simple-todo-api.git","ssh_url":"git@github.com:chionyan/simple-todo-api.git","clone_url":"https://github.com/chionyan/simple-todo-api.git","svn_url":"https://github.com/chionyan/simple-todo-api","homepage":"","size":68,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"chionyan:master","ref":"master","sha":"4051bf1a6161581620f6039d1aacb4d8a35f4ebb","user":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"repo":{"id":144514820,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1MTQ4MjA=","name":"simple-todo-api","full_name":"chionyan/simple-todo-api","owner":{"login":"chionyan","id":26681827,"node_id":"MDQ6VXNlcjI2NjgxODI3","avatar_url":"https://avatars1.githubusercontent.com/u/26681827?v=4","gravatar_id":"","url":"https://api.github.com/users/chionyan","html_url":"https://github.com/chionyan","followers_url":"https://api.github.com/users/chionyan/followers","following_url":"https://api.github.com/users/chionyan/following{/other_user}","gists_url":"https://api.github.com/users/chionyan/gists{/gist_id}","starred_url":"https://api.github.com/users/chionyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chionyan/subscriptions","organizations_url":"https://api.github.com/users/chionyan/orgs","repos_url":"https://api.github.com/users/chionyan/repos","events_url":"https://api.github.com/users/chionyan/events{/privacy}","received_events_url":"https://api.github.com/users/chionyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chionyan/simple-todo-api","description":null,"fork":false,"url":"https://api.github.com/repos/chionyan/simple-todo-api","forks_url":"https://api.github.com/repos/chionyan/simple-todo-api/forks","keys_url":"https://api.github.com/repos/chionyan/simple-todo-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chionyan/simple-todo-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chionyan/simple-todo-api/teams","hooks_url":"https://api.github.com/repos/chionyan/simple-todo-api/hooks","issue_events_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues/events{/number}","events_url":"https://api.github.com/repos/chionyan/simple-todo-api/events","assignees_url":"https://api.github.com/repos/chionyan/simple-todo-api/assignees{/user}","branches_url":"https://api.github.com/repos/chionyan/simple-todo-api/branches{/branch}","tags_url":"https://api.github.com/repos/chionyan/simple-todo-api/tags","blobs_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chionyan/simple-todo-api/statuses/{sha}","languages_url":"https://api.github.com/repos/chionyan/simple-todo-api/languages","stargazers_url":"https://api.github.com/repos/chionyan/simple-todo-api/stargazers","contributors_url":"https://api.github.com/repos/chionyan/simple-todo-api/contributors","subscribers_url":"https://api.github.com/repos/chionyan/simple-todo-api/subscribers","subscription_url":"https://api.github.com/repos/chionyan/simple-todo-api/subscription","commits_url":"https://api.github.com/repos/chionyan/simple-todo-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/chionyan/simple-todo-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/chionyan/simple-todo-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/chionyan/simple-todo-api/contents/{+path}","compare_url":"https://api.github.com/repos/chionyan/simple-todo-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chionyan/simple-todo-api/merges","archive_url":"https://api.github.com/repos/chionyan/simple-todo-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chionyan/simple-todo-api/downloads","issues_url":"https://api.github.com/repos/chionyan/simple-todo-api/issues{/number}","pulls_url":"https://api.github.com/repos/chionyan/simple-todo-api/pulls{/number}","milestones_url":"https://api.github.com/repos/chionyan/simple-todo-api/milestones{/number}","notifications_url":"https://api.github.com/repos/chionyan/simple-todo-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chionyan/simple-todo-api/labels{/name}","releases_url":"https://api.github.com/repos/chionyan/simple-todo-api/releases{/id}","deployments_url":"https://api.github.com/repos/chionyan/simple-todo-api/deployments","created_at":"2018-08-13T01:29:40Z","updated_at":"2018-08-23T09:23:07Z","pushed_at":"2018-08-24T01:51:51Z","git_url":"git://github.com/chionyan/simple-todo-api.git","ssh_url":"git@github.com:chionyan/simple-todo-api.git","clone_url":"https://github.com/chionyan/simple-todo-api.git","svn_url":"https://github.com/chionyan/simple-todo-api","homepage":"","size":68,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14"},"html":{"href":"https://github.com/chionyan/simple-todo-api/pull/14"},"issue":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/issues/14"},"comments":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/chionyan/simple-todo-api/statuses/b83c8ca59bb313d68ee784f2b9881d144b5fee72"}},"author_association":"OWNER"}}
{"actor":{"display_login":"chionyan"}}