{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/parsec/pulls/comments/212545431","pull_request_review_id":149203033,"id":212545431,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjU0NTQzMQ==","diff_hunk":"@@ -14,12 +14,12 @@ use vote::Vote;\n #[serde(bound = \"\")]\n #[derive(Serialize, Deserialize, Debug, Clone)]\n pub(super) enum Cause<T: NetworkEvent, P: PublicId> {\n-    // Hash is of the latest `Event` of the peer which sent the request.\n-    Request(Hash),\n-    // Hash is of the latest `Event` of the peer which sent the response.\n-    Response(Hash),\n-    // Vote for a single network event of type `T`.\n-    Observation(Vote<T, P>),\n+    // Hashes are the latest `Event` of own and the peer which sent the request (self, other).\n+    Request(Hash, Hash),","path":"src/gossip/cause.rs","position":11,"original_position":11,"commit_id":"cd55edc91045e8f0c8ce86841947d21edfa213dc","original_commit_id":"cd55edc91045e8f0c8ce86841947d21edfa213dc","user":{"login":"pierrechevalier83","id":5790907,"node_id":"MDQ6VXNlcjU3OTA5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5790907?v=4","gravatar_id":"","url":"https://api.github.com/users/pierrechevalier83","html_url":"https://github.com/pierrechevalier83","followers_url":"https://api.github.com/users/pierrechevalier83/followers","following_url":"https://api.github.com/users/pierrechevalier83/following{/other_user}","gists_url":"https://api.github.com/users/pierrechevalier83/gists{/gist_id}","starred_url":"https://api.github.com/users/pierrechevalier83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierrechevalier83/subscriptions","organizations_url":"https://api.github.com/users/pierrechevalier83/orgs","repos_url":"https://api.github.com/users/pierrechevalier83/repos","events_url":"https://api.github.com/users/pierrechevalier83/events{/privacy}","received_events_url":"https://api.github.com/users/pierrechevalier83/received_events","type":"User","site_admin":false},"body":"Potentially, the other_parent could be in an Option so that the Observation can also use this type. I'm a bit undecided on that, so your call :)","created_at":"2018-08-24T07:41:51Z","updated_at":"2018-08-24T07:41:51Z","html_url":"https://github.com/maidsafe/parsec/pull/67#discussion_r212545431","pull_request_url":"https://api.github.com/repos/maidsafe/parsec/pulls/67","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/parsec/pulls/comments/212545431"},"html":{"href":"https://github.com/maidsafe/parsec/pull/67#discussion_r212545431"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/parsec/pulls/67"}},"in_reply_to_id":212544951},"pull_request":{"url":"https://api.github.com/repos/maidsafe/parsec/pulls/67","id":210495112,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDk1MTEy","html_url":"https://github.com/maidsafe/parsec/pull/67","diff_url":"https://github.com/maidsafe/parsec/pull/67.diff","patch_url":"https://github.com/maidsafe/parsec/pull/67.patch","issue_url":"https://api.github.com/repos/maidsafe/parsec/issues/67","number":67,"state":"open","locked":false,"title":"MAID-3042 chore/parsec: make initial event more type safer","user":{"login":"maqi","id":568777,"node_id":"MDQ6VXNlcjU2ODc3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/568777?v=4","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-23T15:50:25Z","updated_at":"2018-08-24T07:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7da1890dfbdaa437b2c4f892498920c578143d6b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/parsec/pulls/67/commits","review_comments_url":"https://api.github.com/repos/maidsafe/parsec/pulls/67/comments","review_comment_url":"https://api.github.com/repos/maidsafe/parsec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/parsec/issues/67/comments","statuses_url":"https://api.github.com/repos/maidsafe/parsec/statuses/cd55edc91045e8f0c8ce86841947d21edfa213dc","head":{"label":"maqi:MAID-3042_impl","ref":"MAID-3042_impl","sha":"cd55edc91045e8f0c8ce86841947d21edfa213dc","user":{"login":"maqi","id":568777,"node_id":"MDQ6VXNlcjU2ODc3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/568777?v=4","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"repo":{"id":136035868,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzU4Njg=","name":"parsec","full_name":"maqi/parsec","owner":{"login":"maqi","id":568777,"node_id":"MDQ6VXNlcjU2ODc3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/568777?v=4","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maqi/parsec","description":"Protocol for Asynchronous, Reliable, Secure and Efficient Consensus","fork":true,"url":"https://api.github.com/repos/maqi/parsec","forks_url":"https://api.github.com/repos/maqi/parsec/forks","keys_url":"https://api.github.com/repos/maqi/parsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maqi/parsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maqi/parsec/teams","hooks_url":"https://api.github.com/repos/maqi/parsec/hooks","issue_events_url":"https://api.github.com/repos/maqi/parsec/issues/events{/number}","events_url":"https://api.github.com/repos/maqi/parsec/events","assignees_url":"https://api.github.com/repos/maqi/parsec/assignees{/user}","branches_url":"https://api.github.com/repos/maqi/parsec/branches{/branch}","tags_url":"https://api.github.com/repos/maqi/parsec/tags","blobs_url":"https://api.github.com/repos/maqi/parsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maqi/parsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maqi/parsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/maqi/parsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maqi/parsec/statuses/{sha}","languages_url":"https://api.github.com/repos/maqi/parsec/languages","stargazers_url":"https://api.github.com/repos/maqi/parsec/stargazers","contributors_url":"https://api.github.com/repos/maqi/parsec/contributors","subscribers_url":"https://api.github.com/repos/maqi/parsec/subscribers","subscription_url":"https://api.github.com/repos/maqi/parsec/subscription","commits_url":"https://api.github.com/repos/maqi/parsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/maqi/parsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/maqi/parsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/maqi/parsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/maqi/parsec/contents/{+path}","compare_url":"https://api.github.com/repos/maqi/parsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maqi/parsec/merges","archive_url":"https://api.github.com/repos/maqi/parsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maqi/parsec/downloads","issues_url":"https://api.github.com/repos/maqi/parsec/issues{/number}","pulls_url":"https://api.github.com/repos/maqi/parsec/pulls{/number}","milestones_url":"https://api.github.com/repos/maqi/parsec/milestones{/number}","notifications_url":"https://api.github.com/repos/maqi/parsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maqi/parsec/labels{/name}","releases_url":"https://api.github.com/repos/maqi/parsec/releases{/id}","deployments_url":"https://api.github.com/repos/maqi/parsec/deployments","created_at":"2018-06-04T14:17:51Z","updated_at":"2018-06-04T14:17:53Z","pushed_at":"2018-08-23T15:45:31Z","git_url":"git://github.com/maqi/parsec.git","ssh_url":"git@github.com:maqi/parsec.git","clone_url":"https://github.com/maqi/parsec.git","svn_url":"https://github.com/maqi/parsec","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"887d027b039f13e5084c8d863cac2ddc487deda3","user":{"login":"maidsafe","id":536423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/536423?v=4","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":136022756,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMjI3NTY=","name":"parsec","full_name":"maidsafe/parsec","owner":{"login":"maidsafe","id":536423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/536423?v=4","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/parsec","description":"Protocol for Asynchronous, Reliable, Secure and Efficient Consensus","fork":false,"url":"https://api.github.com/repos/maidsafe/parsec","forks_url":"https://api.github.com/repos/maidsafe/parsec/forks","keys_url":"https://api.github.com/repos/maidsafe/parsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/parsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/parsec/teams","hooks_url":"https://api.github.com/repos/maidsafe/parsec/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/parsec/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/parsec/events","assignees_url":"https://api.github.com/repos/maidsafe/parsec/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/parsec/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/parsec/tags","blobs_url":"https://api.github.com/repos/maidsafe/parsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/parsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/parsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/parsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/parsec/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/parsec/languages","stargazers_url":"https://api.github.com/repos/maidsafe/parsec/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/parsec/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/parsec/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/parsec/subscription","commits_url":"https://api.github.com/repos/maidsafe/parsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/parsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/parsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/parsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/parsec/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/parsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/parsec/merges","archive_url":"https://api.github.com/repos/maidsafe/parsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/parsec/downloads","issues_url":"https://api.github.com/repos/maidsafe/parsec/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/parsec/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/parsec/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/parsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/parsec/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/parsec/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/parsec/deployments","created_at":"2018-06-04T12:36:27Z","updated_at":"2018-08-23T15:43:00Z","pushed_at":"2018-08-23T15:50:25Z","git_url":"git://github.com/maidsafe/parsec.git","ssh_url":"git@github.com:maidsafe/parsec.git","clone_url":"https://github.com/maidsafe/parsec.git","svn_url":"https://github.com/maidsafe/parsec","homepage":null,"size":299,"stargazers_count":73,"watchers_count":73,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":2,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/parsec/pulls/67"},"html":{"href":"https://github.com/maidsafe/parsec/pull/67"},"issue":{"href":"https://api.github.com/repos/maidsafe/parsec/issues/67"},"comments":{"href":"https://api.github.com/repos/maidsafe/parsec/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/parsec/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/parsec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/parsec/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/parsec/statuses/cd55edc91045e8f0c8ce86841947d21edfa213dc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pierrechevalier83"}}