{"action":"created","comment":{"url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/comments/237913555","pull_request_review_id":180335011,"id":237913555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzkxMzU1NQ==","diff_hunk":"@@ -63,27 +63,27 @@ def store_correspondence\n   end\n \n   def set_attachment\n-    @file_blob, * = load_file_attachments\n+    @transcript_blob, * = load_file_attachments\n   end\n \n   def update_attachment\n-    update_blob_metadata @file_blob, file_metadata\n+    update_blob_metadata @transcript_blob, file_metadata\n   end\n \n   def correspondence_valid?\n     @correspondence.validate(step || steps.last)\n-    @correspondence.validate_transcript_and_content(@file_blob) if step == :content\n-    validate_blob_size(@file_blob, @correspondence.errors, \"file\")\n+    @correspondence.validate_transcript_and_content(@transcript_blob) if step == :content\n+    validate_blob_size(@transcript_blob, @correspondence.errors, \"file\")\n     @correspondence.errors.empty?\n   end\n \n   def attach_file\n-    attach_blobs_to_list(@file_blob, @correspondence.documents)\n-    attach_blobs_to_list(@file_blob, @investigation.documents)\n+    attach_blobs_to_list(@transcript_blob, @correspondence.documents)","path":"web/app/controllers/investigations/phone_calls_controller.rb","position":81,"original_position":33,"commit_id":"362e4db996c5f2841b755fea2f93c8d0f735b583","original_commit_id":"18e50beafba0dba180a03fdb1f7a89322e0b255b","user":{"login":"tom-bell-softwire","id":7525573,"node_id":"MDQ6VXNlcjc1MjU1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7525573?v=4","gravatar_id":"","url":"https://api.github.com/users/tom-bell-softwire","html_url":"https://github.com/tom-bell-softwire","followers_url":"https://api.github.com/users/tom-bell-softwire/followers","following_url":"https://api.github.com/users/tom-bell-softwire/following{/other_user}","gists_url":"https://api.github.com/users/tom-bell-softwire/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-bell-softwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-bell-softwire/subscriptions","organizations_url":"https://api.github.com/users/tom-bell-softwire/orgs","repos_url":"https://api.github.com/users/tom-bell-softwire/repos","events_url":"https://api.github.com/users/tom-bell-softwire/events{/privacy}","received_events_url":"https://api.github.com/users/tom-bell-softwire/received_events","type":"User","site_admin":false},"body":"Should this be `attach_blob_to_attachment_slot(@transcript_blob, @correspondence.transcript)` instead?","created_at":"2018-11-30T16:11:41Z","updated_at":"2018-11-30T16:53:59Z","html_url":"https://github.com/UKGovernmentBEIS/beis-mspsds/pull/311#discussion_r237913555","pull_request_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/comments/237913555"},"html":{"href":"https://github.com/UKGovernmentBEIS/beis-mspsds/pull/311#discussion_r237913555"},"pull_request":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311"}}},"pull_request":{"url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311","id":233552064,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTUyMDY0","html_url":"https://github.com/UKGovernmentBEIS/beis-mspsds/pull/311","diff_url":"https://github.com/UKGovernmentBEIS/beis-mspsds/pull/311.diff","patch_url":"https://github.com/UKGovernmentBEIS/beis-mspsds/pull/311.patch","issue_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/311","number":311,"state":"open","locked":false,"title":"MSPSDS-690 and MSPSDS-691 record phone and meeting","user":{"login":"MatthewBurstein","id":28791798,"node_id":"MDQ6VXNlcjI4NzkxNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/28791798?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewBurstein","html_url":"https://github.com/MatthewBurstein","followers_url":"https://api.github.com/users/MatthewBurstein/followers","following_url":"https://api.github.com/users/MatthewBurstein/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBurstein/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBurstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBurstein/subscriptions","organizations_url":"https://api.github.com/users/MatthewBurstein/orgs","repos_url":"https://api.github.com/users/MatthewBurstein/repos","events_url":"https://api.github.com/users/MatthewBurstein/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBurstein/received_events","type":"User","site_admin":false},"body":"Add functionality to investigations for recording phone calls and meetings. Approach will be commonised in a separate PR.","created_at":"2018-11-26T13:10:04Z","updated_at":"2018-11-30T16:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18bdb894f9febbc7f62966c878c3219e0e2df97f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311/commits","review_comments_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311/comments","review_comment_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/311/comments","statuses_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/statuses/362e4db996c5f2841b755fea2f93c8d0f735b583","head":{"label":"UKGovernmentBEIS:MSPSDS-690_and_MSPSDS-691_record_phone_and_meeting","ref":"MSPSDS-690_and_MSPSDS-691_record_phone_and_meeting","sha":"362e4db996c5f2841b755fea2f93c8d0f735b583","user":{"login":"UKGovernmentBEIS","id":19221939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjIxOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19221939?v=4","gravatar_id":"","url":"https://api.github.com/users/UKGovernmentBEIS","html_url":"https://github.com/UKGovernmentBEIS","followers_url":"https://api.github.com/users/UKGovernmentBEIS/followers","following_url":"https://api.github.com/users/UKGovernmentBEIS/following{/other_user}","gists_url":"https://api.github.com/users/UKGovernmentBEIS/gists{/gist_id}","starred_url":"https://api.github.com/users/UKGovernmentBEIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKGovernmentBEIS/subscriptions","organizations_url":"https://api.github.com/users/UKGovernmentBEIS/orgs","repos_url":"https://api.github.com/users/UKGovernmentBEIS/repos","events_url":"https://api.github.com/users/UKGovernmentBEIS/events{/privacy}","received_events_url":"https://api.github.com/users/UKGovernmentBEIS/received_events","type":"Organization","site_admin":false},"repo":{"id":134414102,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0MTQxMDI=","name":"beis-mspsds","full_name":"UKGovernmentBEIS/beis-mspsds","private":false,"owner":{"login":"UKGovernmentBEIS","id":19221939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjIxOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19221939?v=4","gravatar_id":"","url":"https://api.github.com/users/UKGovernmentBEIS","html_url":"https://github.com/UKGovernmentBEIS","followers_url":"https://api.github.com/users/UKGovernmentBEIS/followers","following_url":"https://api.github.com/users/UKGovernmentBEIS/following{/other_user}","gists_url":"https://api.github.com/users/UKGovernmentBEIS/gists{/gist_id}","starred_url":"https://api.github.com/users/UKGovernmentBEIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKGovernmentBEIS/subscriptions","organizations_url":"https://api.github.com/users/UKGovernmentBEIS/orgs","repos_url":"https://api.github.com/users/UKGovernmentBEIS/repos","events_url":"https://api.github.com/users/UKGovernmentBEIS/events{/privacy}","received_events_url":"https://api.github.com/users/UKGovernmentBEIS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UKGovernmentBEIS/beis-mspsds","description":"Market Surveillance and Product Safety Digital Service","fork":false,"url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds","forks_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/forks","keys_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/teams","hooks_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/hooks","issue_events_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/events{/number}","events_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/events","assignees_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/assignees{/user}","branches_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/branches{/branch}","tags_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/tags","blobs_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/statuses/{sha}","languages_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/languages","stargazers_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/stargazers","contributors_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/contributors","subscribers_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/subscribers","subscription_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/subscription","commits_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/contents/{+path}","compare_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/merges","archive_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/downloads","issues_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues{/number}","pulls_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls{/number}","milestones_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/milestones{/number}","notifications_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/labels{/name}","releases_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/releases{/id}","deployments_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/deployments","created_at":"2018-05-22T12:48:15Z","updated_at":"2018-11-30T12:52:53Z","pushed_at":"2018-11-30T16:51:12Z","git_url":"git://github.com/UKGovernmentBEIS/beis-mspsds.git","ssh_url":"git@github.com:UKGovernmentBEIS/beis-mspsds.git","clone_url":"https://github.com/UKGovernmentBEIS/beis-mspsds.git","svn_url":"https://github.com/UKGovernmentBEIS/beis-mspsds","homepage":null,"size":2807,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"UKGovernmentBEIS:master","ref":"master","sha":"3b87bf08ee0087a36bb6e2267f2bb05cf66a6f8c","user":{"login":"UKGovernmentBEIS","id":19221939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjIxOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19221939?v=4","gravatar_id":"","url":"https://api.github.com/users/UKGovernmentBEIS","html_url":"https://github.com/UKGovernmentBEIS","followers_url":"https://api.github.com/users/UKGovernmentBEIS/followers","following_url":"https://api.github.com/users/UKGovernmentBEIS/following{/other_user}","gists_url":"https://api.github.com/users/UKGovernmentBEIS/gists{/gist_id}","starred_url":"https://api.github.com/users/UKGovernmentBEIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKGovernmentBEIS/subscriptions","organizations_url":"https://api.github.com/users/UKGovernmentBEIS/orgs","repos_url":"https://api.github.com/users/UKGovernmentBEIS/repos","events_url":"https://api.github.com/users/UKGovernmentBEIS/events{/privacy}","received_events_url":"https://api.github.com/users/UKGovernmentBEIS/received_events","type":"Organization","site_admin":false},"repo":{"id":134414102,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0MTQxMDI=","name":"beis-mspsds","full_name":"UKGovernmentBEIS/beis-mspsds","private":false,"owner":{"login":"UKGovernmentBEIS","id":19221939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjIxOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19221939?v=4","gravatar_id":"","url":"https://api.github.com/users/UKGovernmentBEIS","html_url":"https://github.com/UKGovernmentBEIS","followers_url":"https://api.github.com/users/UKGovernmentBEIS/followers","following_url":"https://api.github.com/users/UKGovernmentBEIS/following{/other_user}","gists_url":"https://api.github.com/users/UKGovernmentBEIS/gists{/gist_id}","starred_url":"https://api.github.com/users/UKGovernmentBEIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKGovernmentBEIS/subscriptions","organizations_url":"https://api.github.com/users/UKGovernmentBEIS/orgs","repos_url":"https://api.github.com/users/UKGovernmentBEIS/repos","events_url":"https://api.github.com/users/UKGovernmentBEIS/events{/privacy}","received_events_url":"https://api.github.com/users/UKGovernmentBEIS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UKGovernmentBEIS/beis-mspsds","description":"Market Surveillance and Product Safety Digital Service","fork":false,"url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds","forks_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/forks","keys_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/teams","hooks_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/hooks","issue_events_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/events{/number}","events_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/events","assignees_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/assignees{/user}","branches_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/branches{/branch}","tags_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/tags","blobs_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/statuses/{sha}","languages_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/languages","stargazers_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/stargazers","contributors_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/contributors","subscribers_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/subscribers","subscription_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/subscription","commits_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/contents/{+path}","compare_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/merges","archive_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/downloads","issues_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues{/number}","pulls_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls{/number}","milestones_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/milestones{/number}","notifications_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/labels{/name}","releases_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/releases{/id}","deployments_url":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/deployments","created_at":"2018-05-22T12:48:15Z","updated_at":"2018-11-30T12:52:53Z","pushed_at":"2018-11-30T16:51:12Z","git_url":"git://github.com/UKGovernmentBEIS/beis-mspsds.git","ssh_url":"git@github.com:UKGovernmentBEIS/beis-mspsds.git","clone_url":"https://github.com/UKGovernmentBEIS/beis-mspsds.git","svn_url":"https://github.com/UKGovernmentBEIS/beis-mspsds","homepage":null,"size":2807,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311"},"html":{"href":"https://github.com/UKGovernmentBEIS/beis-mspsds/pull/311"},"issue":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/311"},"comments":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/UKGovernmentBEIS/beis-mspsds/statuses/362e4db996c5f2841b755fea2f93c8d0f735b583"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tom-bell-softwire"}}