{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments/241056533","pull_request_review_id":184231819,"id":241056533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTA1NjUzMw==","diff_hunk":"@@ -0,0 +1,201 @@\n+                                 Apache License","path":"ts/src/sourcemapper/LICENSE","position":null,"original_position":1,"commit_id":"e193bb16aeeb87fe338c55bd07317088d2e8e36e","original_commit_id":"173360b4004619ab01e877ba62126df8c09f363f","user":{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"body":"I forgot to remove the LICENSE and README after rebasing. \r\n\r\nsourcemapper.ts will show changes to reverse the mapping,","created_at":"2018-12-12T15:20:04Z","updated_at":"2018-12-12T15:20:04Z","html_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/268#discussion_r241056533","pull_request_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments/241056533"},"html":{"href":"https://github.com/googleapis/cloud-profiler-nodejs/pull/268#discussion_r241056533"},"pull_request":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268"}},"in_reply_to_id":240867293},"pull_request":{"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268","id":206844908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODQ0OTA4","html_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/268","diff_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/268.diff","patch_url":"https://github.com/googleapis/cloud-profiler-nodejs/pull/268.patch","issue_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/268","number":268,"state":"open","locked":false,"title":"feat: add source map support","user":{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"body":"Adding source map support, which will fix #204.\r\n\r\nThis approach seems to work (at least when running on my desktop), but makes cases when line numbers aren't present more apparent. For example, in the attached script we get zero as the line number for asyncSqrt, so in profiles the function is attributed to the js file.\r\n\r\n[busybench.txt](https://github.com/googleapis/cloud-profiler-nodejs/files/2520367/busybench.txt)\r\n\r\n\r\nWait to review until #345 is merged.","created_at":"2018-08-07T22:31:27Z","updated_at":"2018-12-12T15:20:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"886d77fd6903b4c7359d680e0b23faf49ca123d2","assignee":{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"assignees":[{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":318684021,"node_id":"MDU6TGFiZWwzMTg2ODQwMjE=","url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268/commits","review_comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268/comments","review_comment_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/268/comments","statuses_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/e193bb16aeeb87fe338c55bd07317088d2e8e36e","head":{"label":"nolanmar511:source-map","ref":"source-map","sha":"e193bb16aeeb87fe338c55bd07317088d2e8e36e","user":{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"repo":{"id":100729494,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3Mjk0OTQ=","name":"cloud-profiler-nodejs","full_name":"nolanmar511/cloud-profiler-nodejs","private":false,"owner":{"login":"nolanmar511","id":14046562,"node_id":"MDQ6VXNlcjE0MDQ2NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nolanmar511/cloud-profiler-nodejs","description":null,"fork":true,"url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs","forks_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/forks","keys_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/teams","hooks_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/hooks","issue_events_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/events","assignees_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/tags","blobs_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/languages","stargazers_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/stargazers","contributors_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/contributors","subscribers_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/subscribers","subscription_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/subscription","commits_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/merges","archive_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/downloads","issues_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/nolanmar511/cloud-profiler-nodejs/deployments","created_at":"2017-08-18T16:11:07Z","updated_at":"2018-12-04T00:29:21Z","pushed_at":"2018-12-12T15:18:51Z","git_url":"git://github.com/nolanmar511/cloud-profiler-nodejs.git","ssh_url":"git@github.com:nolanmar511/cloud-profiler-nodejs.git","clone_url":"https://github.com/nolanmar511/cloud-profiler-nodejs.git","svn_url":"https://github.com/nolanmar511/cloud-profiler-nodejs","homepage":null,"size":3946,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"f794a35d040ea21a0aca349f574861a777104526","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50680973,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY4MDk3Mw==","name":"cloud-profiler-nodejs","full_name":"googleapis/cloud-profiler-nodejs","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/cloud-profiler-nodejs","description":"Node.js library for Stackdriver Profiler.  Continuous CPU and heap profiling to improve performance and reduce costs.","fork":false,"url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs","forks_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/forks","keys_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/teams","hooks_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/hooks","issue_events_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/events","assignees_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/tags","blobs_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/languages","stargazers_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/stargazers","contributors_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/contributors","subscribers_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/subscribers","subscription_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/subscription","commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/merges","archive_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/downloads","issues_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/deployments","created_at":"2016-01-29T18:06:50Z","updated_at":"2018-12-11T18:36:08Z","pushed_at":"2018-12-12T15:18:53Z","git_url":"git://github.com/googleapis/cloud-profiler-nodejs.git","ssh_url":"git@github.com:googleapis/cloud-profiler-nodejs.git","clone_url":"https://github.com/googleapis/cloud-profiler-nodejs.git","svn_url":"https://github.com/googleapis/cloud-profiler-nodejs","homepage":"https://cloud.google.com/profiler/","size":2466,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":22,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268"},"html":{"href":"https://github.com/googleapis/cloud-profiler-nodejs/pull/268"},"issue":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/268"},"comments":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/cloud-profiler-nodejs/statuses/e193bb16aeeb87fe338c55bd07317088d2e8e36e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nolanmar511"}}