{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/171233254","pull_request_review_id":100048479,"id":171233254,"diff_hunk":"@@ -369,6 +369,8 @@ void SendCoinsDialog::on_sendButton_clicked()\n         accept();\n         CoinControlDialog::coinControl()->UnSelectAll();\n         coinControlUpdateLabels();\n+        const uint256 txid = currentTransaction.getTransaction()->GetHash();","path":"src/qt/sendcoinsdialog.cpp","position":4,"original_position":4,"commit_id":"1dc5cfcec5ab1089ed8fc7087e027ecc9af048b5","original_commit_id":"1dc5cfcec5ab1089ed8fc7087e027ecc9af048b5","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars0.githubusercontent.com/u/126646?v=4","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"Or roll it into the Q_EMIT, as txid is not used after this. YMMV. For performance I'd be surprised it makes any difference.\r\n```\r\nQ_EMIT coinsSent(currentTransaction.getTransaction()->GetHash());\r\n```","created_at":"2018-02-28T12:47:39Z","updated_at":"2018-02-28T12:48:43Z","html_url":"https://github.com/bitcoin/bitcoin/pull/12421#discussion_r171233254","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/171233254"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12421#discussion_r171233254"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421"}},"in_reply_to_id":171227817},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421","id":168814579,"html_url":"https://github.com/bitcoin/bitcoin/pull/12421","diff_url":"https://github.com/bitcoin/bitcoin/pull/12421.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12421.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12421","number":12421,"state":"open","locked":false,"title":"[qt] navigate to  transaction history page after send","user":{"login":"Sjors","id":10217,"avatar_url":"https://avatars1.githubusercontent.com/u/10217?v=4","gravatar_id":"","url":"https://api.github.com/users/Sjors","html_url":"https://github.com/Sjors","followers_url":"https://api.github.com/users/Sjors/followers","following_url":"https://api.github.com/users/Sjors/following{/other_user}","gists_url":"https://api.github.com/users/Sjors/gists{/gist_id}","starred_url":"https://api.github.com/users/Sjors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sjors/subscriptions","organizations_url":"https://api.github.com/users/Sjors/orgs","repos_url":"https://api.github.com/users/Sjors/repos","events_url":"https://api.github.com/users/Sjors/events{/privacy}","received_events_url":"https://api.github.com/users/Sjors/received_events","type":"User","site_admin":false},"body":"Before this change QT just remained on the Send tab, which I found confusing. Now it switches to the Transactions tab. This makes it more clear to the user that the send actually succeeded, and here they can monitor progress.\r\n\r\nIdeally I would like to highlight the transaction, e.g. by refactoring `TransactionView::focusTransaction(const QModelIndex &idx)` to accept a transaction hash, but I'm not sure how to do that.","created_at":"2018-02-13T11:03:26Z","updated_at":"2018-02-28T12:48:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"161acf997452c74827d9539d25008c9a92d59d33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135946,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/GUI","name":"GUI","color":"02d7e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12421/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1dc5cfcec5ab1089ed8fc7087e027ecc9af048b5","head":{"label":"Sjors:2018/02/qt-goto-transactions-after-send","ref":"2018/02/qt-goto-transactions-after-send","sha":"1dc5cfcec5ab1089ed8fc7087e027ecc9af048b5","user":{"login":"Sjors","id":10217,"avatar_url":"https://avatars1.githubusercontent.com/u/10217?v=4","gravatar_id":"","url":"https://api.github.com/users/Sjors","html_url":"https://github.com/Sjors","followers_url":"https://api.github.com/users/Sjors/followers","following_url":"https://api.github.com/users/Sjors/following{/other_user}","gists_url":"https://api.github.com/users/Sjors/gists{/gist_id}","starred_url":"https://api.github.com/users/Sjors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sjors/subscriptions","organizations_url":"https://api.github.com/users/Sjors/orgs","repos_url":"https://api.github.com/users/Sjors/repos","events_url":"https://api.github.com/users/Sjors/events{/privacy}","received_events_url":"https://api.github.com/users/Sjors/received_events","type":"User","site_admin":false},"repo":{"id":92390696,"name":"bitcoin","full_name":"Sjors/bitcoin","owner":{"login":"Sjors","id":10217,"avatar_url":"https://avatars1.githubusercontent.com/u/10217?v=4","gravatar_id":"","url":"https://api.github.com/users/Sjors","html_url":"https://github.com/Sjors","followers_url":"https://api.github.com/users/Sjors/followers","following_url":"https://api.github.com/users/Sjors/following{/other_user}","gists_url":"https://api.github.com/users/Sjors/gists{/gist_id}","starred_url":"https://api.github.com/users/Sjors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sjors/subscriptions","organizations_url":"https://api.github.com/users/Sjors/orgs","repos_url":"https://api.github.com/users/Sjors/repos","events_url":"https://api.github.com/users/Sjors/events{/privacy}","received_events_url":"https://api.github.com/users/Sjors/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sjors/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/Sjors/bitcoin","forks_url":"https://api.github.com/repos/Sjors/bitcoin/forks","keys_url":"https://api.github.com/repos/Sjors/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sjors/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sjors/bitcoin/teams","hooks_url":"https://api.github.com/repos/Sjors/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/Sjors/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/Sjors/bitcoin/events","assignees_url":"https://api.github.com/repos/Sjors/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/Sjors/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/Sjors/bitcoin/tags","blobs_url":"https://api.github.com/repos/Sjors/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sjors/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sjors/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sjors/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sjors/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/Sjors/bitcoin/languages","stargazers_url":"https://api.github.com/repos/Sjors/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/Sjors/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/Sjors/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/Sjors/bitcoin/subscription","commits_url":"https://api.github.com/repos/Sjors/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sjors/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sjors/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sjors/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sjors/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/Sjors/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sjors/bitcoin/merges","archive_url":"https://api.github.com/repos/Sjors/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sjors/bitcoin/downloads","issues_url":"https://api.github.com/repos/Sjors/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/Sjors/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/Sjors/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/Sjors/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sjors/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/Sjors/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/Sjors/bitcoin/deployments","created_at":"2017-05-25T10:05:54Z","updated_at":"2017-09-02T08:09:09Z","pushed_at":"2018-02-28T12:40:58Z","git_url":"git://github.com/Sjors/bitcoin.git","ssh_url":"git@github.com:Sjors/bitcoin.git","clone_url":"https://github.com/Sjors/bitcoin.git","svn_url":"https://github.com/Sjors/bitcoin","homepage":"https://bitcoin.org/en/download","size":88606,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"ffc6e48b2983189dc0ce7de0a038e5329bc07b1b","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-02-28T12:45:04Z","pushed_at":"2018-02-28T11:19:45Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":85755,"stargazers_count":28460,"watchers_count":28460,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":16874,"mirror_url":null,"archived":false,"open_issues_count":899,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":16874,"open_issues":899,"watchers":28460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12421"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12421"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12421/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12421/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1dc5cfcec5ab1089ed8fc7087e027ecc9af048b5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"laanwj"}}