{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/project-system/issues/3913","repository_url":"https://api.github.com/repos/dotnet/project-system","labels_url":"https://api.github.com/repos/dotnet/project-system/issues/3913/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/3913/comments","events_url":"https://api.github.com/repos/dotnet/project-system/issues/3913/events","html_url":"https://github.com/dotnet/project-system/pull/3913","id":354878358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTM3NzYx","number":3913,"title":"Never report up-to-date if CopyAlways item exists","user":{"login":"drewnoakes","id":350947,"node_id":"MDQ6VXNlcjM1MDk0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/350947?v=4","gravatar_id":"","url":"https://api.github.com/users/drewnoakes","html_url":"https://github.com/drewnoakes","followers_url":"https://api.github.com/users/drewnoakes/followers","following_url":"https://api.github.com/users/drewnoakes/following{/other_user}","gists_url":"https://api.github.com/users/drewnoakes/gists{/gist_id}","starred_url":"https://api.github.com/users/drewnoakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewnoakes/subscriptions","organizations_url":"https://api.github.com/users/drewnoakes/orgs","repos_url":"https://api.github.com/users/drewnoakes/repos","events_url":"https://api.github.com/users/drewnoakes/events{/privacy}","received_events_url":"https://api.github.com/users/drewnoakes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-28T19:50:43Z","updated_at":"2018-08-29T15:58:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/3913","html_url":"https://github.com/dotnet/project-system/pull/3913","diff_url":"https://github.com/dotnet/project-system/pull/3913.diff","patch_url":"https://github.com/dotnet/project-system/pull/3913.patch"},"body":"Fixes #3568 \r\n\r\nPrior code logged the fact that the project was not up to date, but didn't signal that information back to the calling method. If any items are `CopyAlways` then the up-to-date check can be short circuited.\r\n\r\nQuestions for reviewers:\r\n\r\n1. Code in checks immediately above this change use the `Fail` method to capture a telemetry event. Should this also happen when we detect a `CopyAlways` item?\r\n1. Unit tests... I looked into adding tests for this class. It's quite a meaty one with substantial dependencies, and I'm new to the code. Please advise!"},"comment":{"url":"https://api.github.com/repos/dotnet/project-system/issues/comments/417006150","html_url":"https://github.com/dotnet/project-system/pull/3913#issuecomment-417006150","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/3913","id":417006150,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzAwNjE1MA==","user":{"login":"drewnoakes","id":350947,"node_id":"MDQ6VXNlcjM1MDk0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/350947?v=4","gravatar_id":"","url":"https://api.github.com/users/drewnoakes","html_url":"https://github.com/drewnoakes","followers_url":"https://api.github.com/users/drewnoakes/followers","following_url":"https://api.github.com/users/drewnoakes/following{/other_user}","gists_url":"https://api.github.com/users/drewnoakes/gists{/gist_id}","starred_url":"https://api.github.com/users/drewnoakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewnoakes/subscriptions","organizations_url":"https://api.github.com/users/drewnoakes/orgs","repos_url":"https://api.github.com/users/drewnoakes/repos","events_url":"https://api.github.com/users/drewnoakes/events{/privacy}","received_events_url":"https://api.github.com/users/drewnoakes/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T15:58:21Z","updated_at":"2018-08-29T15:58:21Z","author_association":"MEMBER","body":"Merging this to base another PR off it related to #3918."}}
{"actor":{"display_login":"drewnoakes"}}