{"comment":{"url":"https://api.github.com/repos/OttoWinter/esphomeyaml/comments/31795541","html_url":"https://github.com/OttoWinter/esphomeyaml/commit/b5cdb9f5c5496fba0c60e1c358cece9ba62adcc6#commitcomment-31795541","id":31795541,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMTc5NTU0MQ==","user":{"login":"voicevon","id":1651143,"node_id":"MDQ6VXNlcjE2NTExNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1651143?v=4","gravatar_id":"","url":"https://api.github.com/users/voicevon","html_url":"https://github.com/voicevon","followers_url":"https://api.github.com/users/voicevon/followers","following_url":"https://api.github.com/users/voicevon/following{/other_user}","gists_url":"https://api.github.com/users/voicevon/gists{/gist_id}","starred_url":"https://api.github.com/users/voicevon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voicevon/subscriptions","organizations_url":"https://api.github.com/users/voicevon/orgs","repos_url":"https://api.github.com/users/voicevon/repos","events_url":"https://api.github.com/users/voicevon/events{/privacy}","received_events_url":"https://api.github.com/users/voicevon/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"b5cdb9f5c5496fba0c60e1c358cece9ba62adcc6","created_at":"2018-12-28T12:09:24Z","updated_at":"2018-12-28T12:09:24Z","author_association":"NONE","body":"First , I did some studying on esphomelib's  code, but have never touched esphomeyaml yet.  I fully agree with you the first paragraph. \r\n\r\nBased on all of my known, \r\n1) In this case, the registering of trigger should be done once it created. \r\n2) As a rule, every components(at least sensor, switch, trigger. ) will be registered once it's created.\r\n3) In this case,the registering should be in (or deeper than this)  ` MQTTMessageTrigger *make_message_trigger(const std::string &topic);`\r\n4) esphomeyaml does manage the source code  of main.cpp in esphomelib only,   can't register any component.\r\n\r\nConclusion: \r\nI am still confused. The above item at least one is wrong, I can't find out it."}}
{"actor":{"display_login":"voicevon"}}