{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/214326981","pull_request_review_id":151358470,"id":214326981,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDMyNjk4MQ==","diff_hunk":"@@ -0,0 +1,46 @@\n+/*\n+ * Copyright (C) 2018 Freie Universität Berlin\n+ *\n+ * This file is subject to the terms and conditions of the GNU Lesser\n+ * General Public License v2.1. See the file LICENSE in the top level\n+ * directory for more details.\n+ */\n+\n+/**\n+ * @ingroup tests\n+ * @{\n+ *\n+ * @file\n+ * @brief       Test for srf04 ultra sonic range finder driver\n+ *\n+ * @author      Semjon Kerner <semjon.kerner@fu-berlin.de>\n+ *\n+ * @}\n+ */\n+\n+#include <stdio.h>\n+#include <stdlib.h>\n+#include <string.h>\n+\n+#include \"srf04_params.h\"\n+#include \"srf04.h\"\n+\n+int main(void)\n+{\n+    puts(\"SRF04 range finder example\");\n+\n+    srf04_t dev;\n+    srf04_init(&dev, &srf04_params[0]);\n+    int distance;","path":"tests/driver_srf04/main.c","position":34,"original_position":34,"commit_id":"6d65ccedf06418576b17793f7b1caa8c47b29636","original_commit_id":"6d65ccedf06418576b17793f7b1caa8c47b29636","user":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"body":"scope: cppcheck will probably complain that `distance` should be define inside the while loop below","created_at":"2018-08-31T11:42:43Z","updated_at":"2018-08-31T11:47:30Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/9035#discussion_r214326981","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/214326981"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9035#discussion_r214326981"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035","id":184398858,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0Mzk4ODU4","html_url":"https://github.com/RIOT-OS/RIOT/pull/9035","diff_url":"https://github.com/RIOT-OS/RIOT/pull/9035.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/9035.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9035","number":9035,"state":"open","locked":false,"title":"drivers/srf04: range finder sensor","user":{"login":"SemjonKerner","id":1882648,"node_id":"MDQ6VXNlcjE4ODI2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1882648?v=4","gravatar_id":"","url":"https://api.github.com/users/SemjonKerner","html_url":"https://github.com/SemjonKerner","followers_url":"https://api.github.com/users/SemjonKerner/followers","following_url":"https://api.github.com/users/SemjonKerner/following{/other_user}","gists_url":"https://api.github.com/users/SemjonKerner/gists{/gist_id}","starred_url":"https://api.github.com/users/SemjonKerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemjonKerner/subscriptions","organizations_url":"https://api.github.com/users/SemjonKerner/orgs","repos_url":"https://api.github.com/users/SemjonKerner/repos","events_url":"https://api.github.com/users/SemjonKerner/events{/privacy}","received_events_url":"https://api.github.com/users/SemjonKerner/received_events","type":"User","site_admin":false},"body":"This is an initial driver implementation for the srf04 ultra sonic range finder. The driver provides functions for initializing the gpio, triggering a measurement and reading out the measured data. This PR also provides a very simple test.","created_at":"2018-04-26T16:37:45Z","updated_at":"2018-08-31T11:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1df59f1bf623f39be67d0cab57253686bdaaf0e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135467271,"node_id":"MDU6TGFiZWwxMzU0NjcyNzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false},{"id":97458574,"node_id":"MDU6TGFiZWw5NzQ1ODU3NA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/new%20feature","name":"new feature","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9035/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/6d65ccedf06418576b17793f7b1caa8c47b29636","head":{"label":"SemjonKerner:driver_sensor_srf04","ref":"driver_sensor_srf04","sha":"6d65ccedf06418576b17793f7b1caa8c47b29636","user":{"login":"SemjonKerner","id":1882648,"node_id":"MDQ6VXNlcjE4ODI2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1882648?v=4","gravatar_id":"","url":"https://api.github.com/users/SemjonKerner","html_url":"https://github.com/SemjonKerner","followers_url":"https://api.github.com/users/SemjonKerner/followers","following_url":"https://api.github.com/users/SemjonKerner/following{/other_user}","gists_url":"https://api.github.com/users/SemjonKerner/gists{/gist_id}","starred_url":"https://api.github.com/users/SemjonKerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemjonKerner/subscriptions","organizations_url":"https://api.github.com/users/SemjonKerner/orgs","repos_url":"https://api.github.com/users/SemjonKerner/repos","events_url":"https://api.github.com/users/SemjonKerner/events{/privacy}","received_events_url":"https://api.github.com/users/SemjonKerner/received_events","type":"User","site_admin":false},"repo":{"id":107261086,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyNjEwODY=","name":"RIOT","full_name":"SemjonKerner/RIOT","owner":{"login":"SemjonKerner","id":1882648,"node_id":"MDQ6VXNlcjE4ODI2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1882648?v=4","gravatar_id":"","url":"https://api.github.com/users/SemjonKerner","html_url":"https://github.com/SemjonKerner","followers_url":"https://api.github.com/users/SemjonKerner/followers","following_url":"https://api.github.com/users/SemjonKerner/following{/other_user}","gists_url":"https://api.github.com/users/SemjonKerner/gists{/gist_id}","starred_url":"https://api.github.com/users/SemjonKerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemjonKerner/subscriptions","organizations_url":"https://api.github.com/users/SemjonKerner/orgs","repos_url":"https://api.github.com/users/SemjonKerner/repos","events_url":"https://api.github.com/users/SemjonKerner/events{/privacy}","received_events_url":"https://api.github.com/users/SemjonKerner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SemjonKerner/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/SemjonKerner/RIOT","forks_url":"https://api.github.com/repos/SemjonKerner/RIOT/forks","keys_url":"https://api.github.com/repos/SemjonKerner/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SemjonKerner/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SemjonKerner/RIOT/teams","hooks_url":"https://api.github.com/repos/SemjonKerner/RIOT/hooks","issue_events_url":"https://api.github.com/repos/SemjonKerner/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/SemjonKerner/RIOT/events","assignees_url":"https://api.github.com/repos/SemjonKerner/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/SemjonKerner/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/SemjonKerner/RIOT/tags","blobs_url":"https://api.github.com/repos/SemjonKerner/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SemjonKerner/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SemjonKerner/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/SemjonKerner/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SemjonKerner/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/SemjonKerner/RIOT/languages","stargazers_url":"https://api.github.com/repos/SemjonKerner/RIOT/stargazers","contributors_url":"https://api.github.com/repos/SemjonKerner/RIOT/contributors","subscribers_url":"https://api.github.com/repos/SemjonKerner/RIOT/subscribers","subscription_url":"https://api.github.com/repos/SemjonKerner/RIOT/subscription","commits_url":"https://api.github.com/repos/SemjonKerner/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/SemjonKerner/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/SemjonKerner/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/SemjonKerner/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/SemjonKerner/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/SemjonKerner/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SemjonKerner/RIOT/merges","archive_url":"https://api.github.com/repos/SemjonKerner/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SemjonKerner/RIOT/downloads","issues_url":"https://api.github.com/repos/SemjonKerner/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/SemjonKerner/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/SemjonKerner/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/SemjonKerner/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SemjonKerner/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/SemjonKerner/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/SemjonKerner/RIOT/deployments","created_at":"2017-10-17T11:46:48Z","updated_at":"2018-08-21T11:18:33Z","pushed_at":"2018-08-31T08:29:52Z","git_url":"git://github.com/SemjonKerner/RIOT.git","ssh_url":"git@github.com:SemjonKerner/RIOT.git","clone_url":"https://github.com/SemjonKerner/RIOT.git","svn_url":"https://github.com/SemjonKerner/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":56068,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"ba6d386c5e453e4a84569bf7611e7ddf0b1d3a64","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwMjQx","name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-08-31T10:05:26Z","pushed_at":"2018-08-31T10:25:41Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":56514,"stargazers_count":1954,"watchers_count":1954,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1121,"mirror_url":null,"archived":false,"open_issues_count":790,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1121,"open_issues":790,"watchers":1954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9035"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9035"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9035/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9035/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/6d65ccedf06418576b17793f7b1caa8c47b29636"}},"author_association":"NONE"}}
{"actor":{"display_login":"haukepetersen"}}