{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/reflectable/pulls/comments/213949258","pull_request_review_id":150893199,"id":213949258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk0OTI1OA==","diff_hunk":"@@ -941,6 +941,8 @@ class _ReflectorDomain {\n       classesToAdd.forEach(addClass);\n     }\n \n+    // Add","path":"lib/src/builder_implementation.dart","position":4,"original_position":4,"commit_id":"b3f5b0b7f642e36d5cef64ac9371fc5efa95d1a4","original_commit_id":"b3f5b0b7f642e36d5cef64ac9371fc5efa95d1a4","user":{"login":"eernstg","id":9606994,"node_id":"MDQ6VXNlcjk2MDY5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9606994?v=4","gravatar_id":"","url":"https://api.github.com/users/eernstg","html_url":"https://github.com/eernstg","followers_url":"https://api.github.com/users/eernstg/followers","following_url":"https://api.github.com/users/eernstg/following{/other_user}","gists_url":"https://api.github.com/users/eernstg/gists{/gist_id}","starred_url":"https://api.github.com/users/eernstg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eernstg/subscriptions","organizations_url":"https://api.github.com/users/eernstg/orgs","repos_url":"https://api.github.com/users/eernstg/repos","events_url":"https://api.github.com/users/eernstg/events{/privacy}","received_events_url":"https://api.github.com/users/eernstg/received_events","type":"User","site_admin":false},"body":"Deleted, thanks!","created_at":"2018-08-30T08:44:38Z","updated_at":"2018-08-30T08:44:38Z","html_url":"https://github.com/dart-lang/reflectable/pull/148#discussion_r213949258","pull_request_url":"https://api.github.com/repos/dart-lang/reflectable/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/reflectable/pulls/comments/213949258"},"html":{"href":"https://github.com/dart-lang/reflectable/pull/148#discussion_r213949258"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/reflectable/pulls/148"}},"in_reply_to_id":213925045},"pull_request":{"url":"https://api.github.com/repos/dart-lang/reflectable/pulls/148","id":211483316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDgzMzE2","html_url":"https://github.com/dart-lang/reflectable/pull/148","diff_url":"https://github.com/dart-lang/reflectable/pull/148.diff","patch_url":"https://github.com/dart-lang/reflectable/pull/148.patch","issue_url":"https://api.github.com/repos/dart-lang/reflectable/issues/148","number":148,"state":"open","locked":false,"title":"Support static type arguments aug18","user":{"login":"eernstg","id":9606994,"node_id":"MDQ6VXNlcjk2MDY5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9606994?v=4","gravatar_id":"","url":"https://api.github.com/users/eernstg","html_url":"https://github.com/eernstg","followers_url":"https://api.github.com/users/eernstg/followers","following_url":"https://api.github.com/users/eernstg/following{/other_user}","gists_url":"https://api.github.com/users/eernstg/gists{/gist_id}","starred_url":"https://api.github.com/users/eernstg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eernstg/subscriptions","organizations_url":"https://api.github.com/users/eernstg/orgs","repos_url":"https://api.github.com/users/eernstg/repos","events_url":"https://api.github.com/users/eernstg/events{/privacy}","received_events_url":"https://api.github.com/users/eernstg/received_events","type":"User","site_admin":false},"body":"This is a revival of a branch from 2017, porting it such that it works as part of reflectable 2.0.4. It adds support for some statically resolved type arguments. It is possible to detect via reflection that a given parameter has type `List<int>` or a similar fully resolved type. There is no support for the case where a type annotation contains a formal type parameter from an enclosing function or class (say, the parameter type of `List.addAll` which is declared as `Iterable<E>` where `E` is only known at run time). Attempts to retrieve such a type will cause an `UnimplementedError` to be thrown.\r\n\r\nPS: I'll make test_reflectable a properly reviewed repo _real soon now_. However, the test case for this feature is available there now at https://github.com/dart-lang/test_reflectable/blob/master/test/static_type_arguments_test.dart.","created_at":"2018-08-28T16:28:02Z","updated_at":"2018-08-30T08:44:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db4cd636310fbbd0db2d4bf78451d3b4c2ba006d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":284771968,"node_id":"MDU6TGFiZWwyODQ3NzE5Njg=","url":"https://api.github.com/repos/dart-lang/reflectable/labels/cla:%20yes","name":"cla: yes","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/reflectable/pulls/148/commits","review_comments_url":"https://api.github.com/repos/dart-lang/reflectable/pulls/148/comments","review_comment_url":"https://api.github.com/repos/dart-lang/reflectable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/reflectable/issues/148/comments","statuses_url":"https://api.github.com/repos/dart-lang/reflectable/statuses/b3f5b0b7f642e36d5cef64ac9371fc5efa95d1a4","head":{"label":"dart-lang:support_static_type_arguments_aug18","ref":"support_static_type_arguments_aug18","sha":"b3f5b0b7f642e36d5cef64ac9371fc5efa95d1a4","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":29348813,"node_id":"MDEwOlJlcG9zaXRvcnkyOTM0ODgxMw==","name":"reflectable","full_name":"dart-lang/reflectable","owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/reflectable","description":"Reflectable is a Dart library that allows programmers to eliminate certain usages of dynamic reflection by specialization of reflective code to an equivalent implementation using only static techniques. The use of dynamic reflection is constrained in order to ensure that the specialized code can be generated and will have a reasonable size.","fork":false,"url":"https://api.github.com/repos/dart-lang/reflectable","forks_url":"https://api.github.com/repos/dart-lang/reflectable/forks","keys_url":"https://api.github.com/repos/dart-lang/reflectable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/reflectable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/reflectable/teams","hooks_url":"https://api.github.com/repos/dart-lang/reflectable/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/reflectable/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/reflectable/events","assignees_url":"https://api.github.com/repos/dart-lang/reflectable/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/reflectable/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/reflectable/tags","blobs_url":"https://api.github.com/repos/dart-lang/reflectable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/reflectable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/reflectable/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/reflectable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/reflectable/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/reflectable/languages","stargazers_url":"https://api.github.com/repos/dart-lang/reflectable/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/reflectable/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/reflectable/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/reflectable/subscription","commits_url":"https://api.github.com/repos/dart-lang/reflectable/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/reflectable/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/reflectable/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/reflectable/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/reflectable/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/reflectable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/reflectable/merges","archive_url":"https://api.github.com/repos/dart-lang/reflectable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/reflectable/downloads","issues_url":"https://api.github.com/repos/dart-lang/reflectable/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/reflectable/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/reflectable/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/reflectable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/reflectable/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/reflectable/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/reflectable/deployments","created_at":"2015-01-16T13:09:05Z","updated_at":"2018-08-28T19:19:08Z","pushed_at":"2018-08-29T12:41:41Z","git_url":"git://github.com/dart-lang/reflectable.git","ssh_url":"git@github.com:dart-lang/reflectable.git","clone_url":"https://github.com/dart-lang/reflectable.git","svn_url":"https://github.com/dart-lang/reflectable","homepage":"https://pub.dartlang.org/packages/reflectable","size":2123,"stargazers_count":64,"watchers_count":64,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":18,"open_issues":12,"watchers":64,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"935fcf4e7ba957159e36e189f56a897301f77229","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":29348813,"node_id":"MDEwOlJlcG9zaXRvcnkyOTM0ODgxMw==","name":"reflectable","full_name":"dart-lang/reflectable","owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/reflectable","description":"Reflectable is a Dart library that allows programmers to eliminate certain usages of dynamic reflection by specialization of reflective code to an equivalent implementation using only static techniques. The use of dynamic reflection is constrained in order to ensure that the specialized code can be generated and will have a reasonable size.","fork":false,"url":"https://api.github.com/repos/dart-lang/reflectable","forks_url":"https://api.github.com/repos/dart-lang/reflectable/forks","keys_url":"https://api.github.com/repos/dart-lang/reflectable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/reflectable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/reflectable/teams","hooks_url":"https://api.github.com/repos/dart-lang/reflectable/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/reflectable/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/reflectable/events","assignees_url":"https://api.github.com/repos/dart-lang/reflectable/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/reflectable/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/reflectable/tags","blobs_url":"https://api.github.com/repos/dart-lang/reflectable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/reflectable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/reflectable/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/reflectable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/reflectable/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/reflectable/languages","stargazers_url":"https://api.github.com/repos/dart-lang/reflectable/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/reflectable/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/reflectable/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/reflectable/subscription","commits_url":"https://api.github.com/repos/dart-lang/reflectable/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/reflectable/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/reflectable/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/reflectable/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/reflectable/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/reflectable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/reflectable/merges","archive_url":"https://api.github.com/repos/dart-lang/reflectable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/reflectable/downloads","issues_url":"https://api.github.com/repos/dart-lang/reflectable/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/reflectable/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/reflectable/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/reflectable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/reflectable/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/reflectable/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/reflectable/deployments","created_at":"2015-01-16T13:09:05Z","updated_at":"2018-08-28T19:19:08Z","pushed_at":"2018-08-29T12:41:41Z","git_url":"git://github.com/dart-lang/reflectable.git","ssh_url":"git@github.com:dart-lang/reflectable.git","clone_url":"https://github.com/dart-lang/reflectable.git","svn_url":"https://github.com/dart-lang/reflectable","homepage":"https://pub.dartlang.org/packages/reflectable","size":2123,"stargazers_count":64,"watchers_count":64,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":18,"open_issues":12,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/reflectable/pulls/148"},"html":{"href":"https://github.com/dart-lang/reflectable/pull/148"},"issue":{"href":"https://api.github.com/repos/dart-lang/reflectable/issues/148"},"comments":{"href":"https://api.github.com/repos/dart-lang/reflectable/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/reflectable/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/reflectable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/reflectable/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/reflectable/statuses/b3f5b0b7f642e36d5cef64ac9371fc5efa95d1a4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eernstg"}}