{"action":"created","comment":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/209568885","pull_request_review_id":145604815,"id":209568885,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTU2ODg4NQ==","diff_hunk":"@@ -32,6 +32,9 @@ func NewNode(\n \tnodePrivateKey primitives.Ed25519PrivateKey,\n \tfederationNodes map[string]config.FederationNode,\n \tblockSyncCommitTimeoutMillis uint32,\n+\tblockTransactionReceiptQueryStartGraceSec uint32,","path":"bootstrap/node.go","position":4,"original_position":4,"commit_id":"146a5e4d4bb6fa01daf1415bcf9efe52fa5d4a5a","original_commit_id":"146a5e4d4bb6fa01daf1415bcf9efe52fa5d4a5a","user":{"login":"jlevison","id":1667420,"node_id":"MDQ6VXNlcjE2Njc0MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1667420?v=4","gravatar_id":"","url":"https://api.github.com/users/jlevison","html_url":"https://github.com/jlevison","followers_url":"https://api.github.com/users/jlevison/followers","following_url":"https://api.github.com/users/jlevison/following{/other_user}","gists_url":"https://api.github.com/users/jlevison/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevison/subscriptions","organizations_url":"https://api.github.com/users/jlevison/orgs","repos_url":"https://api.github.com/users/jlevison/repos","events_url":"https://api.github.com/users/jlevison/events{/privacy}","received_events_url":"https://api.github.com/users/jlevison/received_events","type":"User","site_admin":false},"body":"correct\r\nbut maybe we can try and do a fuel tank test on it, i.e. how low can it go before the car stops, so how many can we accumulate here until no-one can add anything because its too big? :) (talking to ido)","created_at":"2018-08-13T11:02:31Z","updated_at":"2018-08-13T11:02:31Z","html_url":"https://github.com/orbs-network/orbs-network-go/pull/88#discussion_r209568885","pull_request_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/209568885"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/88#discussion_r209568885"},"pull_request":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88"}},"in_reply_to_id":209462515},"pull_request":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88","id":207789874,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Nzg5ODc0","html_url":"https://github.com/orbs-network/orbs-network-go/pull/88","diff_url":"https://github.com/orbs-network/orbs-network-go/pull/88.diff","patch_url":"https://github.com/orbs-network/orbs-network-go/pull/88.patch","issue_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/88","number":88,"state":"open","locked":false,"title":"Block storage transaction receipt query #1","user":{"login":"jlevison","id":1667420,"node_id":"MDQ6VXNlcjE2Njc0MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1667420?v=4","gravatar_id":"","url":"https://api.github.com/users/jlevison","html_url":"https://github.com/jlevison","followers_url":"https://api.github.com/users/jlevison/followers","following_url":"https://api.github.com/users/jlevison/following{/other_user}","gists_url":"https://api.github.com/users/jlevison/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevison/subscriptions","organizations_url":"https://api.github.com/users/jlevison/orgs","repos_url":"https://api.github.com/users/jlevison/repos","events_url":"https://api.github.com/users/jlevison/events{/privacy}","received_events_url":"https://api.github.com/users/jlevison/received_events","type":"User","site_admin":false},"body":"this is a large feature, and will be in parts to ease up on the review process\r\n\r\nincluded:\r\n* basic bloom filter - to be changed in the next pr around this feature - the spec requires two bloom filters and after discussing with Oded this may not be the right course of action, so the implementation is on an extremely naive bloom filter right now\r\n* added more configuration values for block storage\r\n* added the initial logic for querying by time on the persistence storage\r\n","created_at":"2018-08-11T19:48:18Z","updated_at":"2018-08-13T11:02:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cb61c626cecb078e8d29dc51873ae3824318c71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88/commits","review_comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88/comments","review_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/88/comments","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/146a5e4d4bb6fa01daf1415bcf9efe52fa5d4a5a","head":{"label":"orbs-network:feature/block-storage-tx-receipt","ref":"feature/block-storage-tx-receipt","sha":"146a5e4d4bb6fa01daf1415bcf9efe52fa5d4a5a","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-08-12T07:22:37Z","pushed_at":"2018-08-13T10:40:48Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":1174,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":21,"watchers":6,"default_branch":"master"}},"base":{"label":"orbs-network:master","ref":"master","sha":"2cb6a347cc390633afcbc532db2449f1d8a97eaf","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-08-12T07:22:37Z","pushed_at":"2018-08-13T10:40:48Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":1174,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":21,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/88"},"issue":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/88"},"comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/146a5e4d4bb6fa01daf1415bcf9efe52fa5d4a5a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlevison"}}