{"action":"created","issue":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/1221","repository_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter","labels_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/1221/labels{/name}","comments_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/1221/comments","events_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/1221/events","html_url":"https://github.com/SublimeLinter/SublimeLinter/pull/1221","id":305690618,"number":1221,"title":"loadsave/manual: show panel on_lint_end if errors","user":{"login":"braver","id":2543659,"avatar_url":"https://avatars1.githubusercontent.com/u/2543659?v=4","gravatar_id":"","url":"https://api.github.com/users/braver","html_url":"https://github.com/braver","followers_url":"https://api.github.com/users/braver/followers","following_url":"https://api.github.com/users/braver/following{/other_user}","gists_url":"https://api.github.com/users/braver/gists{/gist_id}","starred_url":"https://api.github.com/users/braver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braver/subscriptions","organizations_url":"https://api.github.com/users/braver/orgs","repos_url":"https://api.github.com/users/braver/repos","events_url":"https://api.github.com/users/braver/events{/privacy}","received_events_url":"https://api.github.com/users/braver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-15T19:32:35Z","updated_at":"2018-03-16T17:12:52Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/pulls/1221","html_url":"https://github.com/SublimeLinter/SublimeLinter/pull/1221","diff_url":"https://github.com/SublimeLinter/SublimeLinter/pull/1221.diff","patch_url":"https://github.com/SublimeLinter/SublimeLinter/pull/1221.patch"},"body":"This might take some more commits, but attempts to fix #1200.\r\n\r\n- [ ] show the panel for load_save and manual modes (ie. on `events.LINT_END`)\r\n- [ ] show the panel if results come in after `on_post_save_async` for background linting\r\n- [ ] show the panel if the panel if there is a lint-only linter active\r\n\r\nMy first attempt addresses the first issue here by showing the panel if results come in and `lint_mode` is not \"background\". It should however not show `on_load` I think.\r\n\r\nThe second issue seems really tricky to me. If you're editing immediately after saving, how do we know if those errors are related to saving? When do we unsubscribe from LINT_END? Asynchronicity breaks my brain, so perhaps someone else should try to tackle that, or perhaps point me in the right direction.\r\n\r\n-----\r\n\r\nEdit: ok, that's as far as I get right now."},"comment":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/comments/373782439","html_url":"https://github.com/SublimeLinter/SublimeLinter/pull/1221#issuecomment-373782439","issue_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter/issues/1221","id":373782439,"user":{"login":"braver","id":2543659,"avatar_url":"https://avatars1.githubusercontent.com/u/2543659?v=4","gravatar_id":"","url":"https://api.github.com/users/braver","html_url":"https://github.com/braver","followers_url":"https://api.github.com/users/braver/followers","following_url":"https://api.github.com/users/braver/following{/other_user}","gists_url":"https://api.github.com/users/braver/gists{/gist_id}","starred_url":"https://api.github.com/users/braver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braver/subscriptions","organizations_url":"https://api.github.com/users/braver/orgs","repos_url":"https://api.github.com/users/braver/repos","events_url":"https://api.github.com/users/braver/events{/privacy}","received_events_url":"https://api.github.com/users/braver/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T17:12:52Z","updated_at":"2018-03-16T17:12:52Z","author_association":"OWNER","body":"> Also we popup in manual mode, no?\r\n\r\nYeah, for both `load_save` and `manual` we don't have to look at the `on_post_save_async` event. We can just show the panel if stuff comes in on lint_end."}}
{"actor":{"display_login":"braver"}}