{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/216750746","pull_request_review_id":154307183,"id":216750746,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc1MDc0Ng==","diff_hunk":"@@ -74,9 +74,14 @@ class StateStoreRDD[T: ClassTag, U: ClassTag](\n \n     // If we're in continuous processing mode, we should get the store version for the current\n     // epoch rather than the one at planning time.\n-    val currentVersion = EpochTracker.getCurrentEpoch match {\n-      case None => storeVersion\n-      case Some(value) => value\n+    val isContinuous = Option(ctxt.getLocalProperty(ContinuousExecution.IS_CONTINUOUS_PROCESSING))","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDD.scala","position":16,"original_position":16,"commit_id":"c2f813bb46bd08ee808ef35ad9569fb9dc7194a6","original_commit_id":"c2f813bb46bd08ee808ef35ad9569fb9dc7194a6","user":{"login":"mukulmurthy","id":38224594,"node_id":"MDQ6VXNlcjM4MjI0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/38224594?v=4","gravatar_id":"","url":"https://api.github.com/users/mukulmurthy","html_url":"https://github.com/mukulmurthy","followers_url":"https://api.github.com/users/mukulmurthy/followers","following_url":"https://api.github.com/users/mukulmurthy/following{/other_user}","gists_url":"https://api.github.com/users/mukulmurthy/gists{/gist_id}","starred_url":"https://api.github.com/users/mukulmurthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mukulmurthy/subscriptions","organizations_url":"https://api.github.com/users/mukulmurthy/orgs","repos_url":"https://api.github.com/users/mukulmurthy/repos","events_url":"https://api.github.com/users/mukulmurthy/events{/privacy}","received_events_url":"https://api.github.com/users/mukulmurthy/received_events","type":"User","site_admin":false},"body":"I think I'd rather keep it as is to be more resilient for the future.","created_at":"2018-09-11T17:19:21Z","updated_at":"2018-09-11T17:19:21Z","html_url":"https://github.com/apache/spark/pull/22386#discussion_r216750746","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22386","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/216750746"},"html":{"href":"https://github.com/apache/spark/pull/22386#discussion_r216750746"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22386"}},"in_reply_to_id":216730172},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22386","id":214476419,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDc2NDE5","html_url":"https://github.com/apache/spark/pull/22386","diff_url":"https://github.com/apache/spark/pull/22386.diff","patch_url":"https://github.com/apache/spark/pull/22386.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22386","number":22386,"state":"open","locked":false,"title":"[SPARK-25399] Continuous processing state should not affect microbatch execution jobs","user":{"login":"mukulmurthy","id":38224594,"node_id":"MDQ6VXNlcjM4MjI0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/38224594?v=4","gravatar_id":"","url":"https://api.github.com/users/mukulmurthy","html_url":"https://github.com/mukulmurthy","followers_url":"https://api.github.com/users/mukulmurthy/followers","following_url":"https://api.github.com/users/mukulmurthy/following{/other_user}","gists_url":"https://api.github.com/users/mukulmurthy/gists{/gist_id}","starred_url":"https://api.github.com/users/mukulmurthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mukulmurthy/subscriptions","organizations_url":"https://api.github.com/users/mukulmurthy/orgs","repos_url":"https://api.github.com/users/mukulmurthy/repos","events_url":"https://api.github.com/users/mukulmurthy/events{/privacy}","received_events_url":"https://api.github.com/users/mukulmurthy/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThe leftover state from running a continuous processing streaming job should not affect later microbatch execution jobs. If a continuous processing job runs and the same thread gets reused for a microbatch execution job in the same environment, the microbatch job could get wrong answers because it can attempt to load the wrong version of the state.\r\n\r\n## How was this patch tested?\r\n\r\nNew and existing unit tests","created_at":"2018-09-10T23:57:10Z","updated_at":"2018-09-11T17:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794e4a6fa3a2baef481a89939ca6a57848da6520","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22386/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22386/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22386/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/c2f813bb46bd08ee808ef35ad9569fb9dc7194a6","head":{"label":"mukulmurthy:25399-streamthread","ref":"25399-streamthread","sha":"c2f813bb46bd08ee808ef35ad9569fb9dc7194a6","user":{"login":"mukulmurthy","id":38224594,"node_id":"MDQ6VXNlcjM4MjI0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/38224594?v=4","gravatar_id":"","url":"https://api.github.com/users/mukulmurthy","html_url":"https://github.com/mukulmurthy","followers_url":"https://api.github.com/users/mukulmurthy/followers","following_url":"https://api.github.com/users/mukulmurthy/following{/other_user}","gists_url":"https://api.github.com/users/mukulmurthy/gists{/gist_id}","starred_url":"https://api.github.com/users/mukulmurthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mukulmurthy/subscriptions","organizations_url":"https://api.github.com/users/mukulmurthy/orgs","repos_url":"https://api.github.com/users/mukulmurthy/repos","events_url":"https://api.github.com/users/mukulmurthy/events{/privacy}","received_events_url":"https://api.github.com/users/mukulmurthy/received_events","type":"User","site_admin":false},"repo":{"id":137130984,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzA5ODQ=","name":"oss-spark","full_name":"mukulmurthy/oss-spark","owner":{"login":"mukulmurthy","id":38224594,"node_id":"MDQ6VXNlcjM4MjI0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/38224594?v=4","gravatar_id":"","url":"https://api.github.com/users/mukulmurthy","html_url":"https://github.com/mukulmurthy","followers_url":"https://api.github.com/users/mukulmurthy/followers","following_url":"https://api.github.com/users/mukulmurthy/following{/other_user}","gists_url":"https://api.github.com/users/mukulmurthy/gists{/gist_id}","starred_url":"https://api.github.com/users/mukulmurthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mukulmurthy/subscriptions","organizations_url":"https://api.github.com/users/mukulmurthy/orgs","repos_url":"https://api.github.com/users/mukulmurthy/repos","events_url":"https://api.github.com/users/mukulmurthy/events{/privacy}","received_events_url":"https://api.github.com/users/mukulmurthy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mukulmurthy/oss-spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/mukulmurthy/oss-spark","forks_url":"https://api.github.com/repos/mukulmurthy/oss-spark/forks","keys_url":"https://api.github.com/repos/mukulmurthy/oss-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mukulmurthy/oss-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mukulmurthy/oss-spark/teams","hooks_url":"https://api.github.com/repos/mukulmurthy/oss-spark/hooks","issue_events_url":"https://api.github.com/repos/mukulmurthy/oss-spark/issues/events{/number}","events_url":"https://api.github.com/repos/mukulmurthy/oss-spark/events","assignees_url":"https://api.github.com/repos/mukulmurthy/oss-spark/assignees{/user}","branches_url":"https://api.github.com/repos/mukulmurthy/oss-spark/branches{/branch}","tags_url":"https://api.github.com/repos/mukulmurthy/oss-spark/tags","blobs_url":"https://api.github.com/repos/mukulmurthy/oss-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mukulmurthy/oss-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mukulmurthy/oss-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/mukulmurthy/oss-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mukulmurthy/oss-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/mukulmurthy/oss-spark/languages","stargazers_url":"https://api.github.com/repos/mukulmurthy/oss-spark/stargazers","contributors_url":"https://api.github.com/repos/mukulmurthy/oss-spark/contributors","subscribers_url":"https://api.github.com/repos/mukulmurthy/oss-spark/subscribers","subscription_url":"https://api.github.com/repos/mukulmurthy/oss-spark/subscription","commits_url":"https://api.github.com/repos/mukulmurthy/oss-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/mukulmurthy/oss-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/mukulmurthy/oss-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/mukulmurthy/oss-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/mukulmurthy/oss-spark/contents/{+path}","compare_url":"https://api.github.com/repos/mukulmurthy/oss-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mukulmurthy/oss-spark/merges","archive_url":"https://api.github.com/repos/mukulmurthy/oss-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mukulmurthy/oss-spark/downloads","issues_url":"https://api.github.com/repos/mukulmurthy/oss-spark/issues{/number}","pulls_url":"https://api.github.com/repos/mukulmurthy/oss-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/mukulmurthy/oss-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/mukulmurthy/oss-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mukulmurthy/oss-spark/labels{/name}","releases_url":"https://api.github.com/repos/mukulmurthy/oss-spark/releases{/id}","deployments_url":"https://api.github.com/repos/mukulmurthy/oss-spark/deployments","created_at":"2018-06-12T21:42:51Z","updated_at":"2018-09-10T21:32:29Z","pushed_at":"2018-09-10T23:52:07Z","git_url":"git://github.com/mukulmurthy/oss-spark.git","ssh_url":"git@github.com:mukulmurthy/oss-spark.git","clone_url":"https://github.com/mukulmurthy/oss-spark.git","svn_url":"https://github.com/mukulmurthy/oss-spark","homepage":null,"size":280668,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"da5685b5bb9ee7daaeb4e8f99c488ebd50c7aac3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-09-11T17:16:39Z","pushed_at":"2018-09-11T16:29:16Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":281414,"stargazers_count":18727,"watchers_count":18727,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16876,"mirror_url":null,"archived":false,"open_issues_count":495,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16876,"open_issues":495,"watchers":18727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22386"},"html":{"href":"https://github.com/apache/spark/pull/22386"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22386"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22386/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22386/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22386/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/c2f813bb46bd08ee808ef35ad9569fb9dc7194a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mukulmurthy"}}