{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/244185645","pull_request_review_id":188124012,"id":244185645,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDE4NTY0NQ==","diff_hunk":"@@ -1128,18 +1167,20 @@ sys_getwindowsversion(PyObject *self)\n \n #pragma warning(pop)\n \n-PyDoc_STRVAR(enablelegacywindowsfsencoding_doc,\n-\"_enablelegacywindowsfsencoding()\\n\\\n-\\n\\\n-Changes the default filesystem encoding to mbcs:replace for consistency\\n\\\n-with earlier versions of Python. See PEP 529 for more information.\\n\\\n-\\n\\\n-This is equivalent to defining the PYTHONLEGACYWINDOWSFSENCODING\\n\\\n-environment variable before launching Python.\"\n-);\n+/*[clinic input]\n+sys._enablelegacywindowsfsencoding\n+\n+Changes the default filesystem encoding to mbcs:replace for consistency with earlier versions of Python.","path":"Python/sysmodule.c","position":689,"original_position":689,"commit_id":"25377db8b11a14f243ca52a6eedb72492d2bb6b4","original_commit_id":"25377db8b11a14f243ca52a6eedb72492d2bb6b4","user":{"login":"serhiy-storchaka","id":3659035,"node_id":"MDQ6VXNlcjM2NTkwMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3659035?v=4","gravatar_id":"","url":"https://api.github.com/users/serhiy-storchaka","html_url":"https://github.com/serhiy-storchaka","followers_url":"https://api.github.com/users/serhiy-storchaka/followers","following_url":"https://api.github.com/users/serhiy-storchaka/following{/other_user}","gists_url":"https://api.github.com/users/serhiy-storchaka/gists{/gist_id}","starred_url":"https://api.github.com/users/serhiy-storchaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhiy-storchaka/subscriptions","organizations_url":"https://api.github.com/users/serhiy-storchaka/orgs","repos_url":"https://api.github.com/users/serhiy-storchaka/repos","events_url":"https://api.github.com/users/serhiy-storchaka/events{/privacy}","received_events_url":"https://api.github.com/users/serhiy-storchaka/received_events","type":"User","site_admin":false},"body":"Too long line. I suggest to add a dot after \"mbcs:replace\". And reword the rest as a separate sentence.","created_at":"2018-12-27T16:35:55Z","updated_at":"2018-12-27T16:45:28Z","html_url":"https://github.com/python/cpython/pull/11328#discussion_r244185645","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/11328","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/244185645"},"html":{"href":"https://github.com/python/cpython/pull/11328#discussion_r244185645"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/11328"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/11328","id":241181041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTgxMDQx","html_url":"https://github.com/python/cpython/pull/11328","diff_url":"https://github.com/python/cpython/pull/11328.diff","patch_url":"https://github.com/python/cpython/pull/11328.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/11328","number":11328,"state":"open","locked":false,"title":"bpo-20182: AC convert Python/sysmodule.c","user":{"login":"taleinat","id":532281,"node_id":"MDQ6VXNlcjUzMjI4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532281?v=4","gravatar_id":"","url":"https://api.github.com/users/taleinat","html_url":"https://github.com/taleinat","followers_url":"https://api.github.com/users/taleinat/followers","following_url":"https://api.github.com/users/taleinat/following{/other_user}","gists_url":"https://api.github.com/users/taleinat/gists{/gist_id}","starred_url":"https://api.github.com/users/taleinat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taleinat/subscriptions","organizations_url":"https://api.github.com/users/taleinat/orgs","repos_url":"https://api.github.com/users/taleinat/repos","events_url":"https://api.github.com/users/taleinat/events{/privacy}","received_events_url":"https://api.github.com/users/taleinat/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: [bpo-20182](https://bugs.python.org/issue20182) -->\nhttps://bugs.python.org/issue20182\n<!-- /issue-number -->\n","created_at":"2018-12-27T16:05:18Z","updated_at":"2018-12-27T16:45:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbae696b2f508031dc19cb778ee8928c64a55629","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"node_id":"MDU6TGFiZWw2NjY5ODAwNTk=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false},{"id":667924166,"node_id":"MDU6TGFiZWw2Njc5MjQxNjY=","url":"https://api.github.com/repos/python/cpython/labels/skip%20news","name":"skip news","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/11328/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/11328/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/11328/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/25377db8b11a14f243ca52a6eedb72492d2bb6b4","head":{"label":"taleinat:bpo-20182/AC_convert_sysmodule","ref":"bpo-20182/AC_convert_sysmodule","sha":"25377db8b11a14f243ca52a6eedb72492d2bb6b4","user":{"login":"taleinat","id":532281,"node_id":"MDQ6VXNlcjUzMjI4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532281?v=4","gravatar_id":"","url":"https://api.github.com/users/taleinat","html_url":"https://github.com/taleinat","followers_url":"https://api.github.com/users/taleinat/followers","following_url":"https://api.github.com/users/taleinat/following{/other_user}","gists_url":"https://api.github.com/users/taleinat/gists{/gist_id}","starred_url":"https://api.github.com/users/taleinat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taleinat/subscriptions","organizations_url":"https://api.github.com/users/taleinat/orgs","repos_url":"https://api.github.com/users/taleinat/repos","events_url":"https://api.github.com/users/taleinat/events{/privacy}","received_events_url":"https://api.github.com/users/taleinat/received_events","type":"User","site_admin":false},"repo":{"id":108264439,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNjQ0Mzk=","name":"cpython","full_name":"taleinat/cpython","private":false,"owner":{"login":"taleinat","id":532281,"node_id":"MDQ6VXNlcjUzMjI4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/532281?v=4","gravatar_id":"","url":"https://api.github.com/users/taleinat","html_url":"https://github.com/taleinat","followers_url":"https://api.github.com/users/taleinat/followers","following_url":"https://api.github.com/users/taleinat/following{/other_user}","gists_url":"https://api.github.com/users/taleinat/gists{/gist_id}","starred_url":"https://api.github.com/users/taleinat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taleinat/subscriptions","organizations_url":"https://api.github.com/users/taleinat/orgs","repos_url":"https://api.github.com/users/taleinat/repos","events_url":"https://api.github.com/users/taleinat/events{/privacy}","received_events_url":"https://api.github.com/users/taleinat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/taleinat/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/taleinat/cpython","forks_url":"https://api.github.com/repos/taleinat/cpython/forks","keys_url":"https://api.github.com/repos/taleinat/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taleinat/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taleinat/cpython/teams","hooks_url":"https://api.github.com/repos/taleinat/cpython/hooks","issue_events_url":"https://api.github.com/repos/taleinat/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/taleinat/cpython/events","assignees_url":"https://api.github.com/repos/taleinat/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/taleinat/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/taleinat/cpython/tags","blobs_url":"https://api.github.com/repos/taleinat/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taleinat/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taleinat/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/taleinat/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taleinat/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/taleinat/cpython/languages","stargazers_url":"https://api.github.com/repos/taleinat/cpython/stargazers","contributors_url":"https://api.github.com/repos/taleinat/cpython/contributors","subscribers_url":"https://api.github.com/repos/taleinat/cpython/subscribers","subscription_url":"https://api.github.com/repos/taleinat/cpython/subscription","commits_url":"https://api.github.com/repos/taleinat/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/taleinat/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/taleinat/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/taleinat/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/taleinat/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/taleinat/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taleinat/cpython/merges","archive_url":"https://api.github.com/repos/taleinat/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taleinat/cpython/downloads","issues_url":"https://api.github.com/repos/taleinat/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/taleinat/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/taleinat/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/taleinat/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taleinat/cpython/labels{/name}","releases_url":"https://api.github.com/repos/taleinat/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/taleinat/cpython/deployments","created_at":"2017-10-25T12:06:03Z","updated_at":"2018-09-22T17:48:54Z","pushed_at":"2018-12-27T16:03:48Z","git_url":"git://github.com/taleinat/cpython.git","ssh_url":"git@github.com:taleinat/cpython.git","clone_url":"https://github.com/taleinat/cpython.git","svn_url":"https://github.com/taleinat/cpython","homepage":"https://www.python.org/","size":260130,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"c6c7237272499b2c528acb5f62601421f329e92a","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-12-27T16:37:53Z","pushed_at":"2018-12-27T16:05:18Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":262957,"stargazers_count":21610,"watchers_count":21610,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8092,"mirror_url":null,"archived":false,"open_issues_count":952,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8092,"open_issues":952,"watchers":21610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/11328"},"html":{"href":"https://github.com/python/cpython/pull/11328"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/11328"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/11328/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/11328/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/11328/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/25377db8b11a14f243ca52a6eedb72492d2bb6b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"serhiy-storchaka"}}