{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1365","repository_url":"https://api.github.com/repos/kubernetes-incubator/cri-o","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1365/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1365/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1365/events","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1365","id":299680422,"number":1365,"title":"conmon: open+rename the log file instead of unlink+open","user":{"login":"giuseppe","id":67430,"avatar_url":"https://avatars0.githubusercontent.com/u/67430?v=4","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"labels":[{"id":484626496,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":677441502,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/size/S","name":"size/S","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-23T11:23:52Z","updated_at":"2018-02-23T17:37:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1365","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1365","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/1365.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/1365.patch"},"body":"**- What I did**\r\nchange the way the log file is replaced once it reaches the maximum size\r\n\r\n**- How I did it**\r\nI first create a new file, then rename it to the old one; instead of deleting the old one then creating a new one.\r\n\r\n**- How to verify it**\r\ntail -F $LOG_FILE will not warn with \"$LOG_FILE has become inaccessible\" when the log file is recreated.\r\n\r\n**- Description for the changelog**\r\nconmon will never leave the log file inaccessible.\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments/368082150","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1365#issuecomment-368082150","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1365","id":368082150,"user":{"login":"openshift-ci-robot","id":30189103,"avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T17:37:18Z","updated_at":"2018-02-23T17:37:18Z","author_association":"COLLABORATOR","body":"@giuseppe: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/e2e_rhel | e9ebc3a195600aad69523f071482886ccba035e8 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/kubernetes-incubator_cri-o/1365/test_pull_request_crio_e2e_rhel/671/) | `/test e2e_rhel`\nci/openshift-jenkins/e2e_fedora | e9ebc3a195600aad69523f071482886ccba035e8 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/kubernetes-incubator_cri-o/1365/test_pull_request_crio_e2e_fedora/652/) | `/test e2e_fedora`\nci/openshift-jenkins/integration_rhel | e9ebc3a195600aad69523f071482886ccba035e8 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/kubernetes-incubator_cri-o/1365/test_pull_request_crio_integration_rhel/517/) | `/test integration_rhel`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/kubernetes-incubator_cri-o/1365). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/giuseppe). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes-incubator/cri-o/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}