{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/196365954","pull_request_review_id":129902072,"id":196365954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjM2NTk1NA==","diff_hunk":"@@ -208,7 +213,8 @@ const\n     (name: \"sparc64\", intSize: 64, endian: bigEndian, floatSize: 64, bit: 64),\n     (name: \"mips64\", intSize: 64, endian: bigEndian, floatSize: 64, bit: 64),\n     (name: \"mips64el\", intSize: 64, endian: littleEndian, floatSize: 64, bit: 64),\n-    (name: \"riscv64\", intSize: 64, endian: littleEndian, floatSize: 64, bit: 64)]\n+    (name: \"riscv64\", intSize: 64, endian: littleEndian, floatSize: 64, bit: 64),\n+    (name: \"armv8a57\", intSize: 64, endian: bigEndian, floatSize: 64, bit: 64)]","path":"compiler/platform.nim","position":38,"original_position":38,"commit_id":"e4dff3a4416a437cf564d584604f937ca1ca3155","original_commit_id":"e4dff3a4416a437cf564d584604f937ca1ca3155","user":{"login":"jyapayne","id":2645657,"node_id":"MDQ6VXNlcjI2NDU2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2645657?v=4","gravatar_id":"","url":"https://api.github.com/users/jyapayne","html_url":"https://github.com/jyapayne","followers_url":"https://api.github.com/users/jyapayne/followers","following_url":"https://api.github.com/users/jyapayne/following{/other_user}","gists_url":"https://api.github.com/users/jyapayne/gists{/gist_id}","starred_url":"https://api.github.com/users/jyapayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyapayne/subscriptions","organizations_url":"https://api.github.com/users/jyapayne/orgs","repos_url":"https://api.github.com/users/jyapayne/repos","events_url":"https://api.github.com/users/jyapayne/events{/privacy}","received_events_url":"https://api.github.com/users/jyapayne/received_events","type":"User","site_admin":false},"body":"Yep, you're right. Checked the switch's cpu mode and it can be either.","created_at":"2018-06-19T10:09:39Z","updated_at":"2018-06-19T10:11:59Z","html_url":"https://github.com/nim-lang/Nim/pull/8069#discussion_r196365954","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/8069","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/196365954"},"html":{"href":"https://github.com/nim-lang/Nim/pull/8069#discussion_r196365954"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/8069"}},"in_reply_to_id":196359601},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/8069","id":195748997,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzQ4OTk3","html_url":"https://github.com/nim-lang/Nim/pull/8069","diff_url":"https://github.com/nim-lang/Nim/pull/8069.diff","patch_url":"https://github.com/nim-lang/Nim/pull/8069.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/8069","number":8069,"state":"open","locked":false,"title":"Nintendo switch support","user":{"login":"jyapayne","id":2645657,"node_id":"MDQ6VXNlcjI2NDU2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2645657?v=4","gravatar_id":"","url":"https://api.github.com/users/jyapayne","html_url":"https://github.com/jyapayne","followers_url":"https://api.github.com/users/jyapayne/followers","following_url":"https://api.github.com/users/jyapayne/following{/other_user}","gists_url":"https://api.github.com/users/jyapayne/gists{/gist_id}","starred_url":"https://api.github.com/users/jyapayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyapayne/subscriptions","organizations_url":"https://api.github.com/users/jyapayne/orgs","repos_url":"https://api.github.com/users/jyapayne/repos","events_url":"https://api.github.com/users/jyapayne/events{/privacy}","received_events_url":"https://api.github.com/users/jyapayne/received_events","type":"User","site_admin":false},"body":"The long-awaited Nintendo Switch support! This allows compilation of Nintendo Switch architecture compatible `elf` files using the `--os:nintendoswitch` flag.\r\n\r\nEnvironment vars required: `DEVKITPRO` which is the path to the root of your devkit pro installation. There are some directories expected to exist in a specific structure for now until I figure out a better way to specify them. They are: \r\n\r\n- DEVKITPRO/portlibs/switch/lib\r\n- DEVKITPRO/libnx/lib\r\n- DEVKITPRO/portlibs/switch/include\r\n- DEVKITPRO/libnx/include\r\n\r\nOther environment variables that are not required: ``SWITCH_LIBS`` for any extra libraries required by your application (``-lLIBNAME`` or ``-LLIBPATH``), and ``SWITCH_INCLUDES`` for any extra include files (``-IINCLUDE_PATH``)","created_at":"2018-06-19T08:32:49Z","updated_at":"2018-06-19T10:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7ccefb4745a4d329d395f344626d89e7d5764a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/8069/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/8069/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/8069/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/e4dff3a4416a437cf564d584604f937ca1ca3155","head":{"label":"jyapayne:nintendo_switch_support","ref":"nintendo_switch_support","sha":"e4dff3a4416a437cf564d584604f937ca1ca3155","user":{"login":"jyapayne","id":2645657,"node_id":"MDQ6VXNlcjI2NDU2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2645657?v=4","gravatar_id":"","url":"https://api.github.com/users/jyapayne","html_url":"https://github.com/jyapayne","followers_url":"https://api.github.com/users/jyapayne/followers","following_url":"https://api.github.com/users/jyapayne/following{/other_user}","gists_url":"https://api.github.com/users/jyapayne/gists{/gist_id}","starred_url":"https://api.github.com/users/jyapayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyapayne/subscriptions","organizations_url":"https://api.github.com/users/jyapayne/orgs","repos_url":"https://api.github.com/users/jyapayne/repos","events_url":"https://api.github.com/users/jyapayne/events{/privacy}","received_events_url":"https://api.github.com/users/jyapayne/received_events","type":"User","site_admin":false},"repo":{"id":38901579,"node_id":"MDEwOlJlcG9zaXRvcnkzODkwMTU3OQ==","name":"Nim","full_name":"jyapayne/Nim","owner":{"login":"jyapayne","id":2645657,"node_id":"MDQ6VXNlcjI2NDU2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2645657?v=4","gravatar_id":"","url":"https://api.github.com/users/jyapayne","html_url":"https://github.com/jyapayne","followers_url":"https://api.github.com/users/jyapayne/followers","following_url":"https://api.github.com/users/jyapayne/following{/other_user}","gists_url":"https://api.github.com/users/jyapayne/gists{/gist_id}","starred_url":"https://api.github.com/users/jyapayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyapayne/subscriptions","organizations_url":"https://api.github.com/users/jyapayne/orgs","repos_url":"https://api.github.com/users/jyapayne/repos","events_url":"https://api.github.com/users/jyapayne/events{/privacy}","received_events_url":"https://api.github.com/users/jyapayne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jyapayne/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":true,"url":"https://api.github.com/repos/jyapayne/Nim","forks_url":"https://api.github.com/repos/jyapayne/Nim/forks","keys_url":"https://api.github.com/repos/jyapayne/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jyapayne/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jyapayne/Nim/teams","hooks_url":"https://api.github.com/repos/jyapayne/Nim/hooks","issue_events_url":"https://api.github.com/repos/jyapayne/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/jyapayne/Nim/events","assignees_url":"https://api.github.com/repos/jyapayne/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/jyapayne/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/jyapayne/Nim/tags","blobs_url":"https://api.github.com/repos/jyapayne/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jyapayne/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jyapayne/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/jyapayne/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jyapayne/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/jyapayne/Nim/languages","stargazers_url":"https://api.github.com/repos/jyapayne/Nim/stargazers","contributors_url":"https://api.github.com/repos/jyapayne/Nim/contributors","subscribers_url":"https://api.github.com/repos/jyapayne/Nim/subscribers","subscription_url":"https://api.github.com/repos/jyapayne/Nim/subscription","commits_url":"https://api.github.com/repos/jyapayne/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/jyapayne/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/jyapayne/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/jyapayne/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/jyapayne/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/jyapayne/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jyapayne/Nim/merges","archive_url":"https://api.github.com/repos/jyapayne/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jyapayne/Nim/downloads","issues_url":"https://api.github.com/repos/jyapayne/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/jyapayne/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/jyapayne/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/jyapayne/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jyapayne/Nim/labels{/name}","releases_url":"https://api.github.com/repos/jyapayne/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/jyapayne/Nim/deployments","created_at":"2015-07-10T20:52:00Z","updated_at":"2018-06-18T12:30:26Z","pushed_at":"2018-06-19T08:33:26Z","git_url":"git://github.com/jyapayne/Nim.git","ssh_url":"git@github.com:jyapayne/Nim.git","clone_url":"https://github.com/jyapayne/Nim.git","svn_url":"https://github.com/jyapayne/Nim","homepage":"http://nim-lang.org/","size":68441,"stargazers_count":0,"watchers_count":0,"language":"Nim","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"70664bd1a25cac6ce1a3d49ff82796153abbbc4f","user":{"login":"nim-lang","id":603863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMzg2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/603863?v=4","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"node_id":"MDEwOlJlcG9zaXRvcnk4NDIwMzc=","name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMzg2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/603863?v=4","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in that order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/nim-lang/Nim/deployments","created_at":"2010-08-16T20:38:58Z","updated_at":"2018-06-19T03:51:45Z","pushed_at":"2018-06-19T08:33:27Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"https://nim-lang.org/","size":68810,"stargazers_count":5078,"watchers_count":5078,"language":"Nim","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":670,"mirror_url":null,"archived":false,"open_issues_count":1438,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":670,"open_issues":1438,"watchers":5078,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/8069"},"html":{"href":"https://github.com/nim-lang/Nim/pull/8069"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/8069"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/8069/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/8069/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/8069/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/e4dff3a4416a437cf564d584604f937ca1ca3155"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jyapayne"}}