{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/react-with-direction/pulls/comments/194768779","pull_request_review_id":128001832,"id":194768779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDc2ODc3OQ==","diff_hunk":"@@ -40,7 +49,7 @@ describe('<DirectionProvider>', () => {\n   it('broadcasts the direction when the direction prop changes', () => {\n     const direction = DIRECTIONS.LTR;\n     const nextDirection = DIRECTIONS.RTL;\n-    const wrapper = shallow(\n+    const wrapper = mount(","path":"tests/DirectionProvider_test.jsx","position":22,"original_position":22,"commit_id":"fbf324565dad08837b60eb812e9a5e700088540a","original_commit_id":"fbf324565dad08837b60eb812e9a5e700088540a","user":{"login":"dclowd9901","id":1314066,"node_id":"MDQ6VXNlcjEzMTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1314066?v=4","gravatar_id":"","url":"https://api.github.com/users/dclowd9901","html_url":"https://github.com/dclowd9901","followers_url":"https://api.github.com/users/dclowd9901/followers","following_url":"https://api.github.com/users/dclowd9901/following{/other_user}","gists_url":"https://api.github.com/users/dclowd9901/gists{/gist_id}","starred_url":"https://api.github.com/users/dclowd9901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclowd9901/subscriptions","organizations_url":"https://api.github.com/users/dclowd9901/orgs","repos_url":"https://api.github.com/users/dclowd9901/repos","events_url":"https://api.github.com/users/dclowd9901/events{/privacy}","received_events_url":"https://api.github.com/users/dclowd9901/received_events","type":"User","site_admin":false},"body":"Meant to include it in my notes above. Here it is (I'll add it above as well): https://github.com/airbnb/enzyme/issues/1452","created_at":"2018-06-12T14:50:03Z","updated_at":"2018-06-12T14:50:04Z","html_url":"https://github.com/airbnb/react-with-direction/pull/14#discussion_r194768779","pull_request_url":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/airbnb/react-with-direction/pulls/comments/194768779"},"html":{"href":"https://github.com/airbnb/react-with-direction/pull/14#discussion_r194768779"},"pull_request":{"href":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14"}},"in_reply_to_id":194565073},"pull_request":{"url":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14","id":194118319,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTE4MzE5","html_url":"https://github.com/airbnb/react-with-direction/pull/14","diff_url":"https://github.com/airbnb/react-with-direction/pull/14.diff","patch_url":"https://github.com/airbnb/react-with-direction/pull/14.patch","issue_url":"https://api.github.com/repos/airbnb/react-with-direction/issues/14","number":14,"state":"open","locked":false,"title":"Updates DirectionProvider to use componentDidUpdate instead of UNSAFE_componentWillMount","user":{"login":"dclowd9901","id":1314066,"node_id":"MDQ6VXNlcjEzMTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1314066?v=4","gravatar_id":"","url":"https://api.github.com/users/dclowd9901","html_url":"https://github.com/dclowd9901","followers_url":"https://api.github.com/users/dclowd9901/followers","following_url":"https://api.github.com/users/dclowd9901/following{/other_user}","gists_url":"https://api.github.com/users/dclowd9901/gists{/gist_id}","starred_url":"https://api.github.com/users/dclowd9901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclowd9901/subscriptions","organizations_url":"https://api.github.com/users/dclowd9901/orgs","repos_url":"https://api.github.com/users/dclowd9901/repos","events_url":"https://api.github.com/users/dclowd9901/events{/privacy}","received_events_url":"https://api.github.com/users/dclowd9901/received_events","type":"User","site_admin":false},"body":"This change migrates DirectionProvider to cease using `UNSAFE_componentWillMount` in favor of `componentDidUpdate` in accordance with\r\n\r\n> If you need to perform a side effect (for example, data fetching or an animation) in response to a change in props, use componentDidUpdate lifecycle instead.\r\n_from: https://reactjs.org/docs/react-component.html_\r\n\r\nUnfortunately, since Enzyme lacks support for shallow mounting that fires `componentDidUpdate`, there is also a tangential change that includes `jsdom` as the environment that DirectionProvider's test is run in. And further, because this causes a warning to appear in the test regarding `requestAnimationFrame`, I used a method found in this thread to quell the warning: https://github.com/facebook/jest/issues/4545","created_at":"2018-06-11T22:16:09Z","updated_at":"2018-06-12T14:50:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e21ce7ead1b4b100b5cdf4cfa7faae7588e30249","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14/commits","review_comments_url":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14/comments","review_comment_url":"https://api.github.com/repos/airbnb/react-with-direction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/react-with-direction/issues/14/comments","statuses_url":"https://api.github.com/repos/airbnb/react-with-direction/statuses/fbf324565dad08837b60eb812e9a5e700088540a","head":{"label":"dclowd9901:ddrew/migrate-componentWillReceiveProps","ref":"ddrew/migrate-componentWillReceiveProps","sha":"fbf324565dad08837b60eb812e9a5e700088540a","user":{"login":"dclowd9901","id":1314066,"node_id":"MDQ6VXNlcjEzMTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1314066?v=4","gravatar_id":"","url":"https://api.github.com/users/dclowd9901","html_url":"https://github.com/dclowd9901","followers_url":"https://api.github.com/users/dclowd9901/followers","following_url":"https://api.github.com/users/dclowd9901/following{/other_user}","gists_url":"https://api.github.com/users/dclowd9901/gists{/gist_id}","starred_url":"https://api.github.com/users/dclowd9901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclowd9901/subscriptions","organizations_url":"https://api.github.com/users/dclowd9901/orgs","repos_url":"https://api.github.com/users/dclowd9901/repos","events_url":"https://api.github.com/users/dclowd9901/events{/privacy}","received_events_url":"https://api.github.com/users/dclowd9901/received_events","type":"User","site_admin":false},"repo":{"id":136986119,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5ODYxMTk=","name":"react-with-direction","full_name":"dclowd9901/react-with-direction","owner":{"login":"dclowd9901","id":1314066,"node_id":"MDQ6VXNlcjEzMTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1314066?v=4","gravatar_id":"","url":"https://api.github.com/users/dclowd9901","html_url":"https://github.com/dclowd9901","followers_url":"https://api.github.com/users/dclowd9901/followers","following_url":"https://api.github.com/users/dclowd9901/following{/other_user}","gists_url":"https://api.github.com/users/dclowd9901/gists{/gist_id}","starred_url":"https://api.github.com/users/dclowd9901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclowd9901/subscriptions","organizations_url":"https://api.github.com/users/dclowd9901/orgs","repos_url":"https://api.github.com/users/dclowd9901/repos","events_url":"https://api.github.com/users/dclowd9901/events{/privacy}","received_events_url":"https://api.github.com/users/dclowd9901/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dclowd9901/react-with-direction","description":"Components to provide and consume RTL or LTR direction in React","fork":true,"url":"https://api.github.com/repos/dclowd9901/react-with-direction","forks_url":"https://api.github.com/repos/dclowd9901/react-with-direction/forks","keys_url":"https://api.github.com/repos/dclowd9901/react-with-direction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dclowd9901/react-with-direction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dclowd9901/react-with-direction/teams","hooks_url":"https://api.github.com/repos/dclowd9901/react-with-direction/hooks","issue_events_url":"https://api.github.com/repos/dclowd9901/react-with-direction/issues/events{/number}","events_url":"https://api.github.com/repos/dclowd9901/react-with-direction/events","assignees_url":"https://api.github.com/repos/dclowd9901/react-with-direction/assignees{/user}","branches_url":"https://api.github.com/repos/dclowd9901/react-with-direction/branches{/branch}","tags_url":"https://api.github.com/repos/dclowd9901/react-with-direction/tags","blobs_url":"https://api.github.com/repos/dclowd9901/react-with-direction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dclowd9901/react-with-direction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dclowd9901/react-with-direction/git/refs{/sha}","trees_url":"https://api.github.com/repos/dclowd9901/react-with-direction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dclowd9901/react-with-direction/statuses/{sha}","languages_url":"https://api.github.com/repos/dclowd9901/react-with-direction/languages","stargazers_url":"https://api.github.com/repos/dclowd9901/react-with-direction/stargazers","contributors_url":"https://api.github.com/repos/dclowd9901/react-with-direction/contributors","subscribers_url":"https://api.github.com/repos/dclowd9901/react-with-direction/subscribers","subscription_url":"https://api.github.com/repos/dclowd9901/react-with-direction/subscription","commits_url":"https://api.github.com/repos/dclowd9901/react-with-direction/commits{/sha}","git_commits_url":"https://api.github.com/repos/dclowd9901/react-with-direction/git/commits{/sha}","comments_url":"https://api.github.com/repos/dclowd9901/react-with-direction/comments{/number}","issue_comment_url":"https://api.github.com/repos/dclowd9901/react-with-direction/issues/comments{/number}","contents_url":"https://api.github.com/repos/dclowd9901/react-with-direction/contents/{+path}","compare_url":"https://api.github.com/repos/dclowd9901/react-with-direction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dclowd9901/react-with-direction/merges","archive_url":"https://api.github.com/repos/dclowd9901/react-with-direction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dclowd9901/react-with-direction/downloads","issues_url":"https://api.github.com/repos/dclowd9901/react-with-direction/issues{/number}","pulls_url":"https://api.github.com/repos/dclowd9901/react-with-direction/pulls{/number}","milestones_url":"https://api.github.com/repos/dclowd9901/react-with-direction/milestones{/number}","notifications_url":"https://api.github.com/repos/dclowd9901/react-with-direction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dclowd9901/react-with-direction/labels{/name}","releases_url":"https://api.github.com/repos/dclowd9901/react-with-direction/releases{/id}","deployments_url":"https://api.github.com/repos/dclowd9901/react-with-direction/deployments","created_at":"2018-06-11T22:07:20Z","updated_at":"2018-06-11T22:07:22Z","pushed_at":"2018-06-11T22:10:25Z","git_url":"git://github.com/dclowd9901/react-with-direction.git","ssh_url":"git@github.com:dclowd9901/react-with-direction.git","clone_url":"https://github.com/dclowd9901/react-with-direction.git","svn_url":"https://github.com/dclowd9901/react-with-direction","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"0b6625cb9979514bb0042ffc6487bc5203e69054","user":{"login":"airbnb","id":698437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":99744178,"node_id":"MDEwOlJlcG9zaXRvcnk5OTc0NDE3OA==","name":"react-with-direction","full_name":"airbnb/react-with-direction","owner":{"login":"airbnb","id":698437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/react-with-direction","description":"Components to provide and consume RTL or LTR direction in React","fork":false,"url":"https://api.github.com/repos/airbnb/react-with-direction","forks_url":"https://api.github.com/repos/airbnb/react-with-direction/forks","keys_url":"https://api.github.com/repos/airbnb/react-with-direction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/react-with-direction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/react-with-direction/teams","hooks_url":"https://api.github.com/repos/airbnb/react-with-direction/hooks","issue_events_url":"https://api.github.com/repos/airbnb/react-with-direction/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/react-with-direction/events","assignees_url":"https://api.github.com/repos/airbnb/react-with-direction/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/react-with-direction/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/react-with-direction/tags","blobs_url":"https://api.github.com/repos/airbnb/react-with-direction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/react-with-direction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/react-with-direction/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/react-with-direction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/react-with-direction/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/react-with-direction/languages","stargazers_url":"https://api.github.com/repos/airbnb/react-with-direction/stargazers","contributors_url":"https://api.github.com/repos/airbnb/react-with-direction/contributors","subscribers_url":"https://api.github.com/repos/airbnb/react-with-direction/subscribers","subscription_url":"https://api.github.com/repos/airbnb/react-with-direction/subscription","commits_url":"https://api.github.com/repos/airbnb/react-with-direction/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/react-with-direction/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/react-with-direction/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/react-with-direction/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/react-with-direction/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/react-with-direction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/react-with-direction/merges","archive_url":"https://api.github.com/repos/airbnb/react-with-direction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/react-with-direction/downloads","issues_url":"https://api.github.com/repos/airbnb/react-with-direction/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/react-with-direction/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/react-with-direction/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/react-with-direction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/react-with-direction/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/react-with-direction/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/react-with-direction/deployments","created_at":"2017-08-08T23:15:17Z","updated_at":"2018-06-12T06:03:24Z","pushed_at":"2018-06-11T22:16:10Z","git_url":"git://github.com/airbnb/react-with-direction.git","ssh_url":"git@github.com:airbnb/react-with-direction.git","clone_url":"https://github.com/airbnb/react-with-direction.git","svn_url":"https://github.com/airbnb/react-with-direction","homepage":null,"size":39,"stargazers_count":100,"watchers_count":100,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":3,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14"},"html":{"href":"https://github.com/airbnb/react-with-direction/pull/14"},"issue":{"href":"https://api.github.com/repos/airbnb/react-with-direction/issues/14"},"comments":{"href":"https://api.github.com/repos/airbnb/react-with-direction/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/react-with-direction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/react-with-direction/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/react-with-direction/statuses/fbf324565dad08837b60eb812e9a5e700088540a"}},"author_association":"NONE"}}
{"actor":{"display_login":"dclowd9901"}}