{"action":"created","issue":{"url":"https://api.github.com/repos/containers/buildah/issues/1132","repository_url":"https://api.github.com/repos/containers/buildah","labels_url":"https://api.github.com/repos/containers/buildah/issues/1132/labels{/name}","comments_url":"https://api.github.com/repos/containers/buildah/issues/1132/comments","events_url":"https://api.github.com/repos/containers/buildah/issues/1132/events","html_url":"https://github.com/containers/buildah/pull/1132","id":374682485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzE5NDc3","number":1132,"title":"Handle directories better in bud -f","user":{"login":"TomSweeneyRedHat","id":25613829,"node_id":"MDQ6VXNlcjI1NjEzODI5","avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-27T19:55:25Z","updated_at":"2018-10-28T12:36:41Z","closed_at":"2018-10-28T12:33:18Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/containers/buildah/pulls/1132","html_url":"https://github.com/containers/buildah/pull/1132","diff_url":"https://github.com/containers/buildah/pull/1132.diff","patch_url":"https://github.com/containers/buildah/pull/1132.patch"},"body":"Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>\r\n\r\nA number of other commits addressed #1104, this finishes that up.  If a directory was given in the --file parameter for `buildah bud` a panic would occur.  With this change if a directory only is given as the argument, the code will append '/Dockerfile' to it and attempt to read the file.  If it can't read the file, it fails with an appropriate error.  If it finds the file, it processes it as appropriate.\r\n\r\nTesting:\r\n\r\n```\r\n# ls tools/Dockerfiles\r\nDockerfile.hold\r\n\r\n#  buildah bud -t tom -f 'tools/Dockerfiles' .\r\nerror reading \"tools/Dockerfiles/Dockerfile\": open tools/Dockerfiles/Dockerfile: no such file or directory\r\n\r\n# cp tools/Dockerfiles/Dockerfile.hold tools/Dockerfiles/Dockerfile\r\n#  buildah bud -t tom -f 'tools/Dockerfiles' .\r\nSTEP 1: FROM alpine\r\nSTEP 2: COMMIT containers-storage:[overlay@/var/lib/containers/storage+/var/run/containers/storage:overlay.override_kernel_check=true]localhost/tom:latest\r\nGetting image source signatures\r\nSkipping fetch of repeat blob sha256:df64d3292fd6194b7865d7326af5255db6d81e9df29f48adde61a918fbd8c332\r\nSkipping fetch of repeat blob sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1\r\nCopying config sha256:bb64f9b02d069cc1fa5534d3ca9703c5bbe99467165ac75ca24a8809435a8bd6\r\n 702 B / 702 B [============================================================] 0s\r\nWriting manifest to image destination\r\nStoring signatures\r\n--> bb64f9b02d069cc1fa5534d3ca9703c5bbe99467165ac75ca24a8809435a8bd6\r\n\r\n# buildah bud -t tom -f \"reallybaddir\" .\r\nerror reading info about \"/root/tsweeney/workspaces/buildah/src/github.com/containers/buildah/reallybaddir\": stat /root/tsweeney/workspaces/buildah/src/github.com/containers/buildah/reallybaddir: no such file or directory\r\n```"},"comment":{"url":"https://api.github.com/repos/containers/buildah/issues/comments/433701463","html_url":"https://github.com/containers/buildah/pull/1132#issuecomment-433701463","issue_url":"https://api.github.com/repos/containers/buildah/issues/1132","id":433701463,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzcwMTQ2Mw==","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T12:36:41Z","updated_at":"2018-10-28T12:36:41Z","author_association":"MEMBER","body":"@TomSweeneyRedHat, if this PR fixes #1104, can you close it? I am not 100 percent sure."}}
{"actor":{"display_login":"vrothberg"}}