{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/168005736","pull_request_review_id":96305428,"id":168005736,"diff_hunk":"@@ -0,0 +1,32 @@\n+{ config, lib, pkgs, ... }:\n+\n+with lib;\n+\n+let\n+  cfg = config.programs.plotinus;\n+in\n+{\n+  ###### interface\n+\n+  options = {\n+    programs.plotinus = {\n+      enable = mkOption {\n+        default = false;\n+        description = ''\n+          Whether to enable the Plotinus GTK+3 plugin.  Plotinus provides a\n+          popup (triggered by Ctrl-Shift-P) to search the menus of a\n+          compatible application.\n+        '';\n+        type = types.bool;\n+      };\n+    };\n+  };\n+\n+  ###### implementation\n+\n+  config = mkIf cfg.enable {\n+","path":"nixos/modules/programs/plotinus.nix","position":28,"original_position":28,"commit_id":"04ea1813b32fde5a7a294dc332156f0669c86a47","original_commit_id":"04ea1813b32fde5a7a294dc332156f0669c86a47","user":{"login":"jtojnar","id":705123,"avatar_url":"https://avatars1.githubusercontent.com/u/705123?v=4","gravatar_id":"","url":"https://api.github.com/users/jtojnar","html_url":"https://github.com/jtojnar","followers_url":"https://api.github.com/users/jtojnar/followers","following_url":"https://api.github.com/users/jtojnar/following{/other_user}","gists_url":"https://api.github.com/users/jtojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/jtojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtojnar/subscriptions","organizations_url":"https://api.github.com/users/jtojnar/orgs","repos_url":"https://api.github.com/users/jtojnar/repos","events_url":"https://api.github.com/users/jtojnar/events{/privacy}","received_events_url":"https://api.github.com/users/jtojnar/received_events","type":"User","site_admin":false},"body":"This space bugs me :)","created_at":"2018-02-13T21:24:46Z","updated_at":"2018-02-13T21:38:57Z","html_url":"https://github.com/NixOS/nixpkgs/pull/34919#discussion_r168005736","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/168005736"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/34919#discussion_r168005736"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919","id":168794102,"html_url":"https://github.com/NixOS/nixpkgs/pull/34919","diff_url":"https://github.com/NixOS/nixpkgs/pull/34919.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/34919.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34919","number":34919,"state":"open","locked":false,"title":"add plotinus and module","user":{"login":"samdroid-apps","id":6022042,"avatar_url":"https://avatars1.githubusercontent.com/u/6022042?v=4","gravatar_id":"","url":"https://api.github.com/users/samdroid-apps","html_url":"https://github.com/samdroid-apps","followers_url":"https://api.github.com/users/samdroid-apps/followers","following_url":"https://api.github.com/users/samdroid-apps/following{/other_user}","gists_url":"https://api.github.com/users/samdroid-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/samdroid-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdroid-apps/subscriptions","organizations_url":"https://api.github.com/users/samdroid-apps/orgs","repos_url":"https://api.github.com/users/samdroid-apps/repos","events_url":"https://api.github.com/users/samdroid-apps/events{/privacy}","received_events_url":"https://api.github.com/users/samdroid-apps/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\n[Plotinus](https://github.com/p-e-w/plotinus) add a menu search feature to all Gtk+3 applications.  Packaging the app is quite simple.  However, users of plotinus usually want to enable it for all applications; and add it to the environment in some way.\r\n\r\nThis PR is marked as WIP because I'm not sure if this is the best/correct way to add something to the environment.\r\n\r\nCurrently, the approach is to add the required variables (eg. `GTK3_MODULES`) to the environment when starting session via the display manager.  This was chosen as it would not affect other packages (eg. conditionally compiling it into GTK3 would cause mass rebuilds). \r\n\r\nLooking for an opinion on if this is the correct way to do it.\r\n\r\n###### Testing\r\n\r\n`vm.nix`:\r\n```nix\r\n{ pkgs, config, ... }:\r\n{\r\n  services.xserver = {\r\n    autorun = true;\r\n    enable = true;\r\n\r\n    windowManager.openbox.enable = true;\r\n    displayManager.auto = {\r\n      enable = true;\r\n      user = \"test\";\r\n    };\r\n  };\r\n\r\n  programs.plotinus.enable = true;\r\n\r\n  users.extraUsers.test = {\r\n    isNormalUser = true;\r\n    uid = 1000;\r\n    extraGroups = [ \"wheel\" ];\r\n    password = \"\";\r\n  };\r\n\r\n  environment.systemPackages = with pkgs; [\r\n    xterm\r\n    gnome3.gnome-calculator\r\n  ];\r\n}\r\n```\r\n\r\nThen run:\r\n\r\n```sh\r\nnixos-rebuild build-vm -I nixpkgs=$HOME/nixpkgs -I nixos-config=vm.nix\r\n./result/bin/run-nixos-vm\r\n```\r\n\r\nInside the VM, open gnome-calculator.  Press `Ctrl-Shift-P` to open the menu searcher.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`) -- N/A\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-02-13T09:35:07Z","updated_at":"2018-02-13T21:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25fc23637a957d5f476408f1ee6c077137554810","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false},{"id":290122734,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34919/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/04ea1813b32fde5a7a294dc332156f0669c86a47","head":{"label":"samdroid-apps:wip-plotinus","ref":"wip-plotinus","sha":"04ea1813b32fde5a7a294dc332156f0669c86a47","user":{"login":"samdroid-apps","id":6022042,"avatar_url":"https://avatars1.githubusercontent.com/u/6022042?v=4","gravatar_id":"","url":"https://api.github.com/users/samdroid-apps","html_url":"https://github.com/samdroid-apps","followers_url":"https://api.github.com/users/samdroid-apps/followers","following_url":"https://api.github.com/users/samdroid-apps/following{/other_user}","gists_url":"https://api.github.com/users/samdroid-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/samdroid-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdroid-apps/subscriptions","organizations_url":"https://api.github.com/users/samdroid-apps/orgs","repos_url":"https://api.github.com/users/samdroid-apps/repos","events_url":"https://api.github.com/users/samdroid-apps/events{/privacy}","received_events_url":"https://api.github.com/users/samdroid-apps/received_events","type":"User","site_admin":false},"repo":{"id":107181908,"name":"nixpkgs","full_name":"samdroid-apps/nixpkgs","owner":{"login":"samdroid-apps","id":6022042,"avatar_url":"https://avatars1.githubusercontent.com/u/6022042?v=4","gravatar_id":"","url":"https://api.github.com/users/samdroid-apps","html_url":"https://github.com/samdroid-apps","followers_url":"https://api.github.com/users/samdroid-apps/followers","following_url":"https://api.github.com/users/samdroid-apps/following{/other_user}","gists_url":"https://api.github.com/users/samdroid-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/samdroid-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdroid-apps/subscriptions","organizations_url":"https://api.github.com/users/samdroid-apps/orgs","repos_url":"https://api.github.com/users/samdroid-apps/repos","events_url":"https://api.github.com/users/samdroid-apps/events{/privacy}","received_events_url":"https://api.github.com/users/samdroid-apps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samdroid-apps/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/samdroid-apps/nixpkgs","forks_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/forks","keys_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/teams","hooks_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/events","assignees_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/tags","blobs_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/subscription","commits_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/merges","archive_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/downloads","issues_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/samdroid-apps/nixpkgs/deployments","created_at":"2017-10-16T20:53:55Z","updated_at":"2017-10-16T20:54:24Z","pushed_at":"2018-02-13T21:13:30Z","git_url":"git://github.com/samdroid-apps/nixpkgs.git","ssh_url":"git@github.com:samdroid-apps/nixpkgs.git","clone_url":"https://github.com/samdroid-apps/nixpkgs.git","svn_url":"https://github.com/samdroid-apps/nixpkgs","homepage":null,"size":677931,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"49a24afaa91dfb76cf3b111a59a4d79a637c3dd9","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-02-13T18:07:25Z","pushed_at":"2018-02-13T21:18:18Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":727851,"stargazers_count":2209,"watchers_count":2209,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2551,"mirror_url":null,"archived":false,"open_issues_count":2858,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2551,"open_issues":2858,"watchers":2209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/34919"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/34919"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/34919/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34919/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/04ea1813b32fde5a7a294dc332156f0669c86a47"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jtojnar"}}