{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments/174996213","pull_request_review_id":104453337,"id":174996213,"diff_hunk":"@@ -154,7 +154,10 @@ class AzureClient extends BaseCloudClient {\n           .snapshots\n           .deleteMethodAsync(this.settings.resource_group, snapshotName)\n           .then(retval => logger.info(`Deleted snapshot ${snapshotName}`, retval))\n-          .catch(err => logger.error(`Error occured while deleting snapshot ${snapshotName}`, err));\n+          .catch(err => {\n+            logger.error('Error occured while deleting snapshot', err);\n+            throw err;","path":"lib/iaas/AzureClient.js","position":7,"original_position":7,"commit_id":"5b07c0bd66fbf122dfc36f37cb5578f7b34f1f7b","original_commit_id":"5b07c0bd66fbf122dfc36f37cb5578f7b34f1f7b","user":{"login":"muralisc","id":1837249,"avatar_url":"https://avatars1.githubusercontent.com/u/1837249?v=4","gravatar_id":"","url":"https://api.github.com/users/muralisc","html_url":"https://github.com/muralisc","followers_url":"https://api.github.com/users/muralisc/followers","following_url":"https://api.github.com/users/muralisc/following{/other_user}","gists_url":"https://api.github.com/users/muralisc/gists{/gist_id}","starred_url":"https://api.github.com/users/muralisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muralisc/subscriptions","organizations_url":"https://api.github.com/users/muralisc/orgs","repos_url":"https://api.github.com/users/muralisc/repos","events_url":"https://api.github.com/users/muralisc/events{/privacy}","received_events_url":"https://api.github.com/users/muralisc/received_events","type":"User","site_admin":false},"body":"@kamath-prasad  the exact error is InvalidSnapshot.NotFound and is aws-sdk specific error.\r\nwe here catch for all errors , errors which we are not still aware of .\r\n@jagadish-kb wanted to log the error. Easier to search the log with known string. Not necessary ?  ","created_at":"2018-03-16T04:39:20Z","updated_at":"2018-03-16T04:39:21Z","html_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/229#discussion_r174996213","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments/174996213"},"html":{"href":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/229#discussion_r174996213"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229"}},"in_reply_to_id":174978557},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229","id":175269560,"html_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/229","diff_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/229.diff","patch_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/229.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/229","number":229,"state":"open","locked":false,"title":"Bubble up iaas error","user":{"login":"muralisc","id":1837249,"avatar_url":"https://avatars1.githubusercontent.com/u/1837249?v=4","gravatar_id":"","url":"https://api.github.com/users/muralisc","html_url":"https://github.com/muralisc","followers_url":"https://api.github.com/users/muralisc/followers","following_url":"https://api.github.com/users/muralisc/following{/other_user}","gists_url":"https://api.github.com/users/muralisc/gists{/gist_id}","starred_url":"https://api.github.com/users/muralisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muralisc/subscriptions","organizations_url":"https://api.github.com/users/muralisc/orgs","repos_url":"https://api.github.com/users/muralisc/repos","events_url":"https://api.github.com/users/muralisc/events{/privacy}","received_events_url":"https://api.github.com/users/muralisc/received_events","type":"User","site_admin":false},"body":"During delete of a backup metadata, an attempt to delete the snapshot whose id \r\nis stored in the metadata made.\r\nIn the event of failure of the delete operation the error thrown will be bubbled up.\r\nCloses Issue #228 ","created_at":"2018-03-15T14:33:38Z","updated_at":"2018-03-16T04:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c57e8d02975a8e52ec7698ec932c62b5547bbe58","assignee":null,"assignees":[],"requested_reviewers":[{"login":"subhankarc","id":3734410,"avatar_url":"https://avatars2.githubusercontent.com/u/3734410?v=4","gravatar_id":"","url":"https://api.github.com/users/subhankarc","html_url":"https://github.com/subhankarc","followers_url":"https://api.github.com/users/subhankarc/followers","following_url":"https://api.github.com/users/subhankarc/following{/other_user}","gists_url":"https://api.github.com/users/subhankarc/gists{/gist_id}","starred_url":"https://api.github.com/users/subhankarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhankarc/subscriptions","organizations_url":"https://api.github.com/users/subhankarc/orgs","repos_url":"https://api.github.com/users/subhankarc/repos","events_url":"https://api.github.com/users/subhankarc/events{/privacy}","received_events_url":"https://api.github.com/users/subhankarc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":776019882,"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/229/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/statuses/5b07c0bd66fbf122dfc36f37cb5578f7b34f1f7b","head":{"label":"muralisc:bubble-iaas-error","ref":"bubble-iaas-error","sha":"5b07c0bd66fbf122dfc36f37cb5578f7b34f1f7b","user":{"login":"muralisc","id":1837249,"avatar_url":"https://avatars1.githubusercontent.com/u/1837249?v=4","gravatar_id":"","url":"https://api.github.com/users/muralisc","html_url":"https://github.com/muralisc","followers_url":"https://api.github.com/users/muralisc/followers","following_url":"https://api.github.com/users/muralisc/following{/other_user}","gists_url":"https://api.github.com/users/muralisc/gists{/gist_id}","starred_url":"https://api.github.com/users/muralisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muralisc/subscriptions","organizations_url":"https://api.github.com/users/muralisc/orgs","repos_url":"https://api.github.com/users/muralisc/repos","events_url":"https://api.github.com/users/muralisc/events{/privacy}","received_events_url":"https://api.github.com/users/muralisc/received_events","type":"User","site_admin":false},"repo":{"id":122465765,"name":"service-fabrik-broker","full_name":"muralisc/service-fabrik-broker","owner":{"login":"muralisc","id":1837249,"avatar_url":"https://avatars1.githubusercontent.com/u/1837249?v=4","gravatar_id":"","url":"https://api.github.com/users/muralisc","html_url":"https://github.com/muralisc","followers_url":"https://api.github.com/users/muralisc/followers","following_url":"https://api.github.com/users/muralisc/following{/other_user}","gists_url":"https://api.github.com/users/muralisc/gists{/gist_id}","starred_url":"https://api.github.com/users/muralisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muralisc/subscriptions","organizations_url":"https://api.github.com/users/muralisc/orgs","repos_url":"https://api.github.com/users/muralisc/repos","events_url":"https://api.github.com/users/muralisc/events{/privacy}","received_events_url":"https://api.github.com/users/muralisc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muralisc/service-fabrik-broker","description":"Cloud Foundry service broker which provisions service instances as Docker containers and BOSH deployments.","fork":true,"url":"https://api.github.com/repos/muralisc/service-fabrik-broker","forks_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/forks","keys_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/teams","hooks_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/hooks","issue_events_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/issues/events{/number}","events_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/events","assignees_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/assignees{/user}","branches_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/branches{/branch}","tags_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/tags","blobs_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/languages","stargazers_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/stargazers","contributors_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/contributors","subscribers_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/subscribers","subscription_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/subscription","commits_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/contents/{+path}","compare_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/merges","archive_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/downloads","issues_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/issues{/number}","pulls_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/labels{/name}","releases_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/releases{/id}","deployments_url":"https://api.github.com/repos/muralisc/service-fabrik-broker/deployments","created_at":"2018-02-22T10:46:04Z","updated_at":"2018-03-15T04:35:11Z","pushed_at":"2018-03-15T14:25:52Z","git_url":"git://github.com/muralisc/service-fabrik-broker.git","ssh_url":"git@github.com:muralisc/service-fabrik-broker.git","clone_url":"https://github.com/muralisc/service-fabrik-broker.git","svn_url":"https://github.com/muralisc/service-fabrik-broker","homepage":"","size":3824,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudfoundry-incubator:master","ref":"master","sha":"8563ea6bf9001bfa1d200fc3c29c02d2f2a613c3","user":{"login":"cloudfoundry-incubator","id":5680605,"avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68716409,"name":"service-fabrik-broker","full_name":"cloudfoundry-incubator/service-fabrik-broker","owner":{"login":"cloudfoundry-incubator","id":5680605,"avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker","description":"Cloud Foundry service broker which provisions service instances as Docker containers and BOSH deployments.","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/deployments","created_at":"2016-09-20T13:48:13Z","updated_at":"2018-03-16T04:22:00Z","pushed_at":"2018-03-16T04:21:58Z","git_url":"git://github.com/cloudfoundry-incubator/service-fabrik-broker.git","ssh_url":"git@github.com:cloudfoundry-incubator/service-fabrik-broker.git","clone_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker.git","svn_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker","homepage":"","size":3822,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":28,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229"},"html":{"href":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/229"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/229"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/statuses/5b07c0bd66fbf122dfc36f37cb5578f7b34f1f7b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"muralisc"}}