{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/changelog-v5/pulls/comments/243769703","pull_request_review_id":187626615,"id":243769703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc2OTcwMw==","diff_hunk":"@@ -182,70 +182,70 @@ MIGRATION: Upgrade to latest node.js version.\n   - `[base]`\n   - `[path]`\n   - `[ext]`\n-- `externals` when passing a function it has now a different signature `({ context, request }, callback)`\n+- `externals` when passing a function, it has now a different signature `({ context, request }, callback)`\n   - MIGRATION: Change signature\n \n-## Changes to the defaults\n+## Changes to the Defaults\n \n - `module.unsafeCache` is now only enabled for `node_modules` by default\n-- `optimization.moduleIds` defaults to `deterministic` in production mode instead of `size`\n-- `optimization.chunkIds` defaults to `deterministic` in production mode instead of `total-size`\n+- `optimization.moduleIds` defaults to `deterministic` in production mode, instead of `size`\n+- `optimization.chunkIds` defaults to `deterministic` in production mode, instead of `total-size`\n - `optimization.nodeEnv` defaults to `false` in `none` mode\n-- `resolve(Loader).cache` defaults to `true` when a `cache` is used\n+- `resolve(Loader).cache` defaults to `true` when `cache` is used\n - `resolve(Loader).cacheWithContext` defaults to `false`\n - `node.global` defaults to `false`\n \n-# Major internal Changes\n+# Major Internal Changes\n \n-The following changes are only relavant when writing plugins:\n+The following changes are only relavant for plugin authors:\n \n ## Runtime Modules\n \n-A large part of runtime code was moved into so called \"runtime modules\". These special modules add runtime code. They can be added in any chunk, but are currently always added to the runtime chunk. \"Runtime requirements\" control which runtime modules are added to the bundle. This ensures that only runtime code that is used is added to the bundle. In future runtime modules could also added to on-demand-loaded chunk to load runtime code when needed.\n+A large part of the runtime code was moved into the so called \"runtime modules\". These special modules are in-charge of adding runtime code. They can be added in to any chunk, but are currently always added to the runtime chunk. \"Runtime Requirements\" control which runtime modules are added to the bundle. This ensures that only runtime code that is used is added to the bundle. In the future, runtime modules could also added to an on-demand-loaded chunk, to load runtime code when needed.\n \n-The core runtime is now very small and only includes the `__webpack_require__` function, module factories and module instance cache. In future an alternative code runtime can be used to avoid wrapping the bundle in a IIFE and allow ESM style exports. This will allow ESM as target.\n+The core runtime is now very small and only includes the `__webpack_require__` function, module factories and the module instance cache. In the future, an alternative code runtime can be used to avoid wrapping the bundle in a IIFE and allow ESM style exports. This will allow ESM as target.\n \n-As some responsibilities from Main and ChunkTemplate were removed, also are some hooks.\n+As some responsibilities from Main and ChunkTemplate were removed, several associated hooks were removed respectively.","path":"README.md","position":200,"original_position":204,"commit_id":"fd23f83cfd3b027a95defa28ca36e46bb4e336eb","original_commit_id":"d6bf45d184a5d799a9c55e044b8df9146413915a","user":{"login":"hemal7735","id":13718176,"node_id":"MDQ6VXNlcjEzNzE4MTc2","avatar_url":"https://avatars1.githubusercontent.com/u/13718176?v=4","gravatar_id":"","url":"https://api.github.com/users/hemal7735","html_url":"https://github.com/hemal7735","followers_url":"https://api.github.com/users/hemal7735/followers","following_url":"https://api.github.com/users/hemal7735/following{/other_user}","gists_url":"https://api.github.com/users/hemal7735/gists{/gist_id}","starred_url":"https://api.github.com/users/hemal7735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemal7735/subscriptions","organizations_url":"https://api.github.com/users/hemal7735/orgs","repos_url":"https://api.github.com/users/hemal7735/repos","events_url":"https://api.github.com/users/hemal7735/events{/privacy}","received_events_url":"https://api.github.com/users/hemal7735/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nAs some responsibilities from Main and ChunkTemplate were removed, several associated hooks were removed as well.\r\n```","created_at":"2018-12-23T16:43:14Z","updated_at":"2018-12-23T16:43:14Z","html_url":"https://github.com/webpack/changelog-v5/pull/1#discussion_r243769703","pull_request_url":"https://api.github.com/repos/webpack/changelog-v5/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/webpack/changelog-v5/pulls/comments/243769703"},"html":{"href":"https://github.com/webpack/changelog-v5/pull/1#discussion_r243769703"},"pull_request":{"href":"https://api.github.com/repos/webpack/changelog-v5/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/changelog-v5/pulls/1","id":240688047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjg4MDQ3","html_url":"https://github.com/webpack/changelog-v5/pull/1","diff_url":"https://github.com/webpack/changelog-v5/pull/1.diff","patch_url":"https://github.com/webpack/changelog-v5/pull/1.patch","issue_url":"https://api.github.com/repos/webpack/changelog-v5/issues/1","number":1,"state":"open","locked":false,"title":"Update README.md","user":{"login":"ApeNox","id":30292793,"node_id":"MDQ6VXNlcjMwMjkyNzkz","avatar_url":"https://avatars1.githubusercontent.com/u/30292793?v=4","gravatar_id":"","url":"https://api.github.com/users/ApeNox","html_url":"https://github.com/ApeNox","followers_url":"https://api.github.com/users/ApeNox/followers","following_url":"https://api.github.com/users/ApeNox/following{/other_user}","gists_url":"https://api.github.com/users/ApeNox/gists{/gist_id}","starred_url":"https://api.github.com/users/ApeNox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApeNox/subscriptions","organizations_url":"https://api.github.com/users/ApeNox/orgs","repos_url":"https://api.github.com/users/ApeNox/repos","events_url":"https://api.github.com/users/ApeNox/events{/privacy}","received_events_url":"https://api.github.com/users/ApeNox/received_events","type":"User","site_admin":false},"body":"- Fixed numerous grammar mistakes.\r\n- Fixed several typos.\r\n- Added code wrapping on multiple words with programmatic context.","created_at":"2018-12-23T15:42:16Z","updated_at":"2018-12-23T16:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73a2450d5caabd5efaf76fffd33c1936aac54774","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/changelog-v5/pulls/1/commits","review_comments_url":"https://api.github.com/repos/webpack/changelog-v5/pulls/1/comments","review_comment_url":"https://api.github.com/repos/webpack/changelog-v5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/changelog-v5/issues/1/comments","statuses_url":"https://api.github.com/repos/webpack/changelog-v5/statuses/fd23f83cfd3b027a95defa28ca36e46bb4e336eb","head":{"label":"ApeNox:patch-1","ref":"patch-1","sha":"fd23f83cfd3b027a95defa28ca36e46bb4e336eb","user":{"login":"ApeNox","id":30292793,"node_id":"MDQ6VXNlcjMwMjkyNzkz","avatar_url":"https://avatars1.githubusercontent.com/u/30292793?v=4","gravatar_id":"","url":"https://api.github.com/users/ApeNox","html_url":"https://github.com/ApeNox","followers_url":"https://api.github.com/users/ApeNox/followers","following_url":"https://api.github.com/users/ApeNox/following{/other_user}","gists_url":"https://api.github.com/users/ApeNox/gists{/gist_id}","starred_url":"https://api.github.com/users/ApeNox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApeNox/subscriptions","organizations_url":"https://api.github.com/users/ApeNox/orgs","repos_url":"https://api.github.com/users/ApeNox/repos","events_url":"https://api.github.com/users/ApeNox/events{/privacy}","received_events_url":"https://api.github.com/users/ApeNox/received_events","type":"User","site_admin":false},"repo":{"id":162881400,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4ODE0MDA=","name":"changelog-v5","full_name":"ApeNox/changelog-v5","private":false,"owner":{"login":"ApeNox","id":30292793,"node_id":"MDQ6VXNlcjMwMjkyNzkz","avatar_url":"https://avatars1.githubusercontent.com/u/30292793?v=4","gravatar_id":"","url":"https://api.github.com/users/ApeNox","html_url":"https://github.com/ApeNox","followers_url":"https://api.github.com/users/ApeNox/followers","following_url":"https://api.github.com/users/ApeNox/following{/other_user}","gists_url":"https://api.github.com/users/ApeNox/gists{/gist_id}","starred_url":"https://api.github.com/users/ApeNox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApeNox/subscriptions","organizations_url":"https://api.github.com/users/ApeNox/orgs","repos_url":"https://api.github.com/users/ApeNox/repos","events_url":"https://api.github.com/users/ApeNox/events{/privacy}","received_events_url":"https://api.github.com/users/ApeNox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ApeNox/changelog-v5","description":"Temporary repo for the changelog for webpack 5","fork":true,"url":"https://api.github.com/repos/ApeNox/changelog-v5","forks_url":"https://api.github.com/repos/ApeNox/changelog-v5/forks","keys_url":"https://api.github.com/repos/ApeNox/changelog-v5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ApeNox/changelog-v5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ApeNox/changelog-v5/teams","hooks_url":"https://api.github.com/repos/ApeNox/changelog-v5/hooks","issue_events_url":"https://api.github.com/repos/ApeNox/changelog-v5/issues/events{/number}","events_url":"https://api.github.com/repos/ApeNox/changelog-v5/events","assignees_url":"https://api.github.com/repos/ApeNox/changelog-v5/assignees{/user}","branches_url":"https://api.github.com/repos/ApeNox/changelog-v5/branches{/branch}","tags_url":"https://api.github.com/repos/ApeNox/changelog-v5/tags","blobs_url":"https://api.github.com/repos/ApeNox/changelog-v5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ApeNox/changelog-v5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ApeNox/changelog-v5/git/refs{/sha}","trees_url":"https://api.github.com/repos/ApeNox/changelog-v5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ApeNox/changelog-v5/statuses/{sha}","languages_url":"https://api.github.com/repos/ApeNox/changelog-v5/languages","stargazers_url":"https://api.github.com/repos/ApeNox/changelog-v5/stargazers","contributors_url":"https://api.github.com/repos/ApeNox/changelog-v5/contributors","subscribers_url":"https://api.github.com/repos/ApeNox/changelog-v5/subscribers","subscription_url":"https://api.github.com/repos/ApeNox/changelog-v5/subscription","commits_url":"https://api.github.com/repos/ApeNox/changelog-v5/commits{/sha}","git_commits_url":"https://api.github.com/repos/ApeNox/changelog-v5/git/commits{/sha}","comments_url":"https://api.github.com/repos/ApeNox/changelog-v5/comments{/number}","issue_comment_url":"https://api.github.com/repos/ApeNox/changelog-v5/issues/comments{/number}","contents_url":"https://api.github.com/repos/ApeNox/changelog-v5/contents/{+path}","compare_url":"https://api.github.com/repos/ApeNox/changelog-v5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ApeNox/changelog-v5/merges","archive_url":"https://api.github.com/repos/ApeNox/changelog-v5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ApeNox/changelog-v5/downloads","issues_url":"https://api.github.com/repos/ApeNox/changelog-v5/issues{/number}","pulls_url":"https://api.github.com/repos/ApeNox/changelog-v5/pulls{/number}","milestones_url":"https://api.github.com/repos/ApeNox/changelog-v5/milestones{/number}","notifications_url":"https://api.github.com/repos/ApeNox/changelog-v5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ApeNox/changelog-v5/labels{/name}","releases_url":"https://api.github.com/repos/ApeNox/changelog-v5/releases{/id}","deployments_url":"https://api.github.com/repos/ApeNox/changelog-v5/deployments","created_at":"2018-12-23T10:26:49Z","updated_at":"2018-12-23T10:26:51Z","pushed_at":"2018-12-23T16:14:50Z","git_url":"git://github.com/ApeNox/changelog-v5.git","ssh_url":"git@github.com:ApeNox/changelog-v5.git","clone_url":"https://github.com/ApeNox/changelog-v5.git","svn_url":"https://github.com/ApeNox/changelog-v5","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"0ff90bda9207936855c87b08f5268cd5dda00c08","user":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":162720011,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3MjAwMTE=","name":"changelog-v5","full_name":"webpack/changelog-v5","private":false,"owner":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webpack/changelog-v5","description":"Temporary repo for the changelog for webpack 5","fork":false,"url":"https://api.github.com/repos/webpack/changelog-v5","forks_url":"https://api.github.com/repos/webpack/changelog-v5/forks","keys_url":"https://api.github.com/repos/webpack/changelog-v5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/changelog-v5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/changelog-v5/teams","hooks_url":"https://api.github.com/repos/webpack/changelog-v5/hooks","issue_events_url":"https://api.github.com/repos/webpack/changelog-v5/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/changelog-v5/events","assignees_url":"https://api.github.com/repos/webpack/changelog-v5/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/changelog-v5/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/changelog-v5/tags","blobs_url":"https://api.github.com/repos/webpack/changelog-v5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/changelog-v5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/changelog-v5/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/changelog-v5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/changelog-v5/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/changelog-v5/languages","stargazers_url":"https://api.github.com/repos/webpack/changelog-v5/stargazers","contributors_url":"https://api.github.com/repos/webpack/changelog-v5/contributors","subscribers_url":"https://api.github.com/repos/webpack/changelog-v5/subscribers","subscription_url":"https://api.github.com/repos/webpack/changelog-v5/subscription","commits_url":"https://api.github.com/repos/webpack/changelog-v5/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/changelog-v5/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/changelog-v5/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/changelog-v5/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/changelog-v5/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/changelog-v5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/changelog-v5/merges","archive_url":"https://api.github.com/repos/webpack/changelog-v5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/changelog-v5/downloads","issues_url":"https://api.github.com/repos/webpack/changelog-v5/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/changelog-v5/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/changelog-v5/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/changelog-v5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/changelog-v5/labels{/name}","releases_url":"https://api.github.com/repos/webpack/changelog-v5/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/changelog-v5/deployments","created_at":"2018-12-21T13:55:54Z","updated_at":"2018-12-23T14:44:49Z","pushed_at":"2018-12-23T16:14:51Z","git_url":"git://github.com/webpack/changelog-v5.git","ssh_url":"git@github.com:webpack/changelog-v5.git","clone_url":"https://github.com/webpack/changelog-v5.git","svn_url":"https://github.com/webpack/changelog-v5","homepage":null,"size":41,"stargazers_count":32,"watchers_count":32,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":1,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/changelog-v5/pulls/1"},"html":{"href":"https://github.com/webpack/changelog-v5/pull/1"},"issue":{"href":"https://api.github.com/repos/webpack/changelog-v5/issues/1"},"comments":{"href":"https://api.github.com/repos/webpack/changelog-v5/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/changelog-v5/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/changelog-v5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/changelog-v5/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/changelog-v5/statuses/fd23f83cfd3b027a95defa28ca36e46bb4e336eb"}},"author_association":"NONE"}}
{"actor":{"display_login":"hemal7735"}}