{"action":"created","comment":{"url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/comments/236557578","pull_request_review_id":178652679,"id":236557578,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjU1NzU3OA==","diff_hunk":"@@ -79,4 +79,30 @@ def initialize(*args)\n       expect(instance.one).to eq \"dep 1\"\n     end\n   end\n+\n+  describe \"passing dependencies where superclass has a splat in arguments\" do\n+    let(:parent_class) {\n+      Class.new do\n+        attr_reader :dep, :args\n+\n+        def initialize(*args)\n+          @dep = args[0].fetch(:one)\n+          @args = args\n+        end\n+      end\n+    }\n+\n+    let(:child_class) {\n+      Class.new(parent_class) do\n+        include Test::AutoInject[:one]\n+      end\n+    }\n+\n+    it \"passes dependencies assuming the parent class can take them\" do\n+      instance = child_class.new\n+","path":"spec/integration/kwargs/super_initialize_spec.rb","position":25,"original_position":25,"commit_id":"38d57030d0a5e496a85778591ddeaac225800525","original_commit_id":"575c94a09fe3ad2a652d833d9f40389e7cadf63a","user":{"login":"flash-gordon","id":802486,"node_id":"MDQ6VXNlcjgwMjQ4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/802486?v=4","gravatar_id":"","url":"https://api.github.com/users/flash-gordon","html_url":"https://github.com/flash-gordon","followers_url":"https://api.github.com/users/flash-gordon/followers","following_url":"https://api.github.com/users/flash-gordon/following{/other_user}","gists_url":"https://api.github.com/users/flash-gordon/gists{/gist_id}","starred_url":"https://api.github.com/users/flash-gordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flash-gordon/subscriptions","organizations_url":"https://api.github.com/users/flash-gordon/orgs","repos_url":"https://api.github.com/users/flash-gordon/repos","events_url":"https://api.github.com/users/flash-gordon/events{/privacy}","received_events_url":"https://api.github.com/users/flash-gordon/received_events","type":"User","site_admin":false},"body":"✅ ","created_at":"2018-11-27T08:20:31Z","updated_at":"2018-11-27T08:20:31Z","html_url":"https://github.com/dry-rb/dry-auto_inject/pull/48#discussion_r236557578","pull_request_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/comments/236557578"},"html":{"href":"https://github.com/dry-rb/dry-auto_inject/pull/48#discussion_r236557578"},"pull_request":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48"}},"in_reply_to_id":236091916},"pull_request":{"url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48","id":233367955,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzY3OTU1","html_url":"https://github.com/dry-rb/dry-auto_inject/pull/48","diff_url":"https://github.com/dry-rb/dry-auto_inject/pull/48.diff","patch_url":"https://github.com/dry-rb/dry-auto_inject/pull/48.patch","issue_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/48","number":48,"state":"open","locked":false,"title":"Pass keyword dependencies if super constructor accepts arguments with the splat operator","user":{"login":"flash-gordon","id":802486,"node_id":"MDQ6VXNlcjgwMjQ4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/802486?v=4","gravatar_id":"","url":"https://api.github.com/users/flash-gordon","html_url":"https://github.com/flash-gordon","followers_url":"https://api.github.com/users/flash-gordon/followers","following_url":"https://api.github.com/users/flash-gordon/following{/other_user}","gists_url":"https://api.github.com/users/flash-gordon/gists{/gist_id}","starred_url":"https://api.github.com/users/flash-gordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flash-gordon/subscriptions","organizations_url":"https://api.github.com/users/flash-gordon/orgs","repos_url":"https://api.github.com/users/flash-gordon/repos","events_url":"https://api.github.com/users/flash-gordon/events{/privacy}","received_events_url":"https://api.github.com/users/flash-gordon/received_events","type":"User","site_admin":false},"body":"Now the keyword strategy will pass dependencies to an existing `initialize` method if it accepts an arbitrary number of arguments. This enables seamless integration with ROM's repositories. The required changes in ROM have been applied already so we're going to have it in ROM 5.","created_at":"2018-11-25T10:36:55Z","updated_at":"2018-11-27T08:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3580b1d96c0cc1c2a47c1e9fe0636ce6f7b17c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48/commits","review_comments_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48/comments","review_comment_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/48/comments","statuses_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/statuses/38d57030d0a5e496a85778591ddeaac225800525","head":{"label":"dry-rb:passing-deps-when-splat-present","ref":"passing-deps-when-splat-present","sha":"38d57030d0a5e496a85778591ddeaac225800525","user":{"login":"dry-rb","id":11280820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjgwODIw","avatar_url":"https://avatars2.githubusercontent.com/u/11280820?v=4","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"repo":{"id":41091175,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5MTE3NQ==","name":"dry-auto_inject","full_name":"dry-rb/dry-auto_inject","private":false,"owner":{"login":"dry-rb","id":11280820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjgwODIw","avatar_url":"https://avatars2.githubusercontent.com/u/11280820?v=4","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dry-rb/dry-auto_inject","description":"Container-agnostic constructor injection mixin","fork":false,"url":"https://api.github.com/repos/dry-rb/dry-auto_inject","forks_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/forks","keys_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/teams","hooks_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/hooks","issue_events_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/events{/number}","events_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/events","assignees_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/assignees{/user}","branches_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/branches{/branch}","tags_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/tags","blobs_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/refs{/sha}","trees_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/statuses/{sha}","languages_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/languages","stargazers_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/stargazers","contributors_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/contributors","subscribers_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/subscribers","subscription_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/subscription","commits_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/commits{/sha}","git_commits_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/commits{/sha}","comments_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/comments{/number}","issue_comment_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/comments{/number}","contents_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/contents/{+path}","compare_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/merges","archive_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/downloads","issues_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues{/number}","pulls_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls{/number}","milestones_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/milestones{/number}","notifications_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/labels{/name}","releases_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/releases{/id}","deployments_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/deployments","created_at":"2015-08-20T10:59:06Z","updated_at":"2018-11-18T08:43:32Z","pushed_at":"2018-11-26T08:49:00Z","git_url":"git://github.com/dry-rb/dry-auto_inject.git","ssh_url":"git@github.com:dry-rb/dry-auto_inject.git","clone_url":"https://github.com/dry-rb/dry-auto_inject.git","svn_url":"https://github.com/dry-rb/dry-auto_inject","homepage":"http://dry-rb.org","size":142,"stargazers_count":113,"watchers_count":113,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":5,"watchers":113,"default_branch":"master"}},"base":{"label":"dry-rb:master","ref":"master","sha":"4f26d8b849f1030184d3fc0b3ccd0cb330f4b1be","user":{"login":"dry-rb","id":11280820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjgwODIw","avatar_url":"https://avatars2.githubusercontent.com/u/11280820?v=4","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"repo":{"id":41091175,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5MTE3NQ==","name":"dry-auto_inject","full_name":"dry-rb/dry-auto_inject","private":false,"owner":{"login":"dry-rb","id":11280820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjgwODIw","avatar_url":"https://avatars2.githubusercontent.com/u/11280820?v=4","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dry-rb/dry-auto_inject","description":"Container-agnostic constructor injection mixin","fork":false,"url":"https://api.github.com/repos/dry-rb/dry-auto_inject","forks_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/forks","keys_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/teams","hooks_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/hooks","issue_events_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/events{/number}","events_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/events","assignees_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/assignees{/user}","branches_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/branches{/branch}","tags_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/tags","blobs_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/refs{/sha}","trees_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/statuses/{sha}","languages_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/languages","stargazers_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/stargazers","contributors_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/contributors","subscribers_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/subscribers","subscription_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/subscription","commits_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/commits{/sha}","git_commits_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/git/commits{/sha}","comments_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/comments{/number}","issue_comment_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/comments{/number}","contents_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/contents/{+path}","compare_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/merges","archive_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/downloads","issues_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues{/number}","pulls_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls{/number}","milestones_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/milestones{/number}","notifications_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/labels{/name}","releases_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/releases{/id}","deployments_url":"https://api.github.com/repos/dry-rb/dry-auto_inject/deployments","created_at":"2015-08-20T10:59:06Z","updated_at":"2018-11-18T08:43:32Z","pushed_at":"2018-11-26T08:49:00Z","git_url":"git://github.com/dry-rb/dry-auto_inject.git","ssh_url":"git@github.com:dry-rb/dry-auto_inject.git","clone_url":"https://github.com/dry-rb/dry-auto_inject.git","svn_url":"https://github.com/dry-rb/dry-auto_inject","homepage":"http://dry-rb.org","size":142,"stargazers_count":113,"watchers_count":113,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":5,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48"},"html":{"href":"https://github.com/dry-rb/dry-auto_inject/pull/48"},"issue":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/48"},"comments":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/dry-rb/dry-auto_inject/statuses/38d57030d0a5e496a85778591ddeaac225800525"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"flash-gordon"}}