{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/165934200","pull_request_review_id":93944791,"id":165934200,"diff_hunk":"@@ -45,6 +45,7 @@ interface NodeConfiguration : NodeSSLConfiguration {\n     val detectPublicIp: Boolean get() = true\n     val sshd: SSHDConfiguration?\n     val database: DatabaseConfig\n+    val noLocalShell: Boolean get() = false","path":"node/src/main/kotlin/net/corda/node/services/config/NodeConfiguration.kt","position":4,"original_position":4,"commit_id":"2083d5077acc45d8c18002faa4dd5790446e504d","original_commit_id":"2083d5077acc45d8c18002faa4dd5790446e504d","user":{"login":"m4ksio","id":120831,"avatar_url":"https://avatars2.githubusercontent.com/u/120831?v=4","gravatar_id":"","url":"https://api.github.com/users/m4ksio","html_url":"https://github.com/m4ksio","followers_url":"https://api.github.com/users/m4ksio/followers","following_url":"https://api.github.com/users/m4ksio/following{/other_user}","gists_url":"https://api.github.com/users/m4ksio/gists{/gist_id}","starred_url":"https://api.github.com/users/m4ksio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4ksio/subscriptions","organizations_url":"https://api.github.com/users/m4ksio/orgs","repos_url":"https://api.github.com/users/m4ksio/repos","events_url":"https://api.github.com/users/m4ksio/events{/privacy}","received_events_url":"https://api.github.com/users/m4ksio/received_events","type":"User","site_admin":false},"body":"We use --no-local-shell flag, so I would like to keep it consistent","created_at":"2018-02-05T10:36:29Z","updated_at":"2018-02-05T10:36:29Z","html_url":"https://github.com/corda/corda/pull/2448#discussion_r165934200","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/2448","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/165934200"},"html":{"href":"https://github.com/corda/corda/pull/2448#discussion_r165934200"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/2448"}},"in_reply_to_id":165407660},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/2448","id":166582333,"html_url":"https://github.com/corda/corda/pull/2448","diff_url":"https://github.com/corda/corda/pull/2448.diff","patch_url":"https://github.com/corda/corda/pull/2448.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/2448","number":2448,"state":"open","locked":false,"title":"Init CRaSH shell only when it's really needed","user":{"login":"m4ksio","id":120831,"avatar_url":"https://avatars2.githubusercontent.com/u/120831?v=4","gravatar_id":"","url":"https://api.github.com/users/m4ksio","html_url":"https://github.com/m4ksio","followers_url":"https://api.github.com/users/m4ksio/followers","following_url":"https://api.github.com/users/m4ksio/following{/other_user}","gists_url":"https://api.github.com/users/m4ksio/gists{/gist_id}","starred_url":"https://api.github.com/users/m4ksio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4ksio/subscriptions","organizations_url":"https://api.github.com/users/m4ksio/orgs","repos_url":"https://api.github.com/users/m4ksio/repos","events_url":"https://api.github.com/users/m4ksio/events{/privacy}","received_events_url":"https://api.github.com/users/m4ksio/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-01T16:15:20Z","updated_at":"2018-02-05T10:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ed225e982c302dd7bdddba33a2ada5399c666a3","assignee":{"login":"m4ksio","id":120831,"avatar_url":"https://avatars2.githubusercontent.com/u/120831?v=4","gravatar_id":"","url":"https://api.github.com/users/m4ksio","html_url":"https://github.com/m4ksio","followers_url":"https://api.github.com/users/m4ksio/followers","following_url":"https://api.github.com/users/m4ksio/following{/other_user}","gists_url":"https://api.github.com/users/m4ksio/gists{/gist_id}","starred_url":"https://api.github.com/users/m4ksio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4ksio/subscriptions","organizations_url":"https://api.github.com/users/m4ksio/orgs","repos_url":"https://api.github.com/users/m4ksio/repos","events_url":"https://api.github.com/users/m4ksio/events{/privacy}","received_events_url":"https://api.github.com/users/m4ksio/received_events","type":"User","site_admin":false},"assignees":[{"login":"m4ksio","id":120831,"avatar_url":"https://avatars2.githubusercontent.com/u/120831?v=4","gravatar_id":"","url":"https://api.github.com/users/m4ksio","html_url":"https://github.com/m4ksio","followers_url":"https://api.github.com/users/m4ksio/followers","following_url":"https://api.github.com/users/m4ksio/following{/other_user}","gists_url":"https://api.github.com/users/m4ksio/gists{/gist_id}","starred_url":"https://api.github.com/users/m4ksio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4ksio/subscriptions","organizations_url":"https://api.github.com/users/m4ksio/orgs","repos_url":"https://api.github.com/users/m4ksio/repos","events_url":"https://api.github.com/users/m4ksio/events{/privacy}","received_events_url":"https://api.github.com/users/m4ksio/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shamsasari","id":3883563,"avatar_url":"https://avatars3.githubusercontent.com/u/3883563?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsasari","html_url":"https://github.com/shamsasari","followers_url":"https://api.github.com/users/shamsasari/followers","following_url":"https://api.github.com/users/shamsasari/following{/other_user}","gists_url":"https://api.github.com/users/shamsasari/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsasari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsasari/subscriptions","organizations_url":"https://api.github.com/users/shamsasari/orgs","repos_url":"https://api.github.com/users/shamsasari/repos","events_url":"https://api.github.com/users/shamsasari/events{/privacy}","received_events_url":"https://api.github.com/users/shamsasari/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/2448/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/2448/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/2448/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/2083d5077acc45d8c18002faa4dd5790446e504d","head":{"label":"corda:m4ksio_better_crash_init","ref":"m4ksio_better_crash_init","sha":"2083d5077acc45d8c18002faa4dd5790446e504d","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-05T03:36:18Z","pushed_at":"2018-02-05T10:33:05Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":106181,"stargazers_count":1419,"watchers_count":1419,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":384,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":384,"open_issues":119,"watchers":1419,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"258b562e161834a64a88a40dc022cbf4e12ec181","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-05T03:36:18Z","pushed_at":"2018-02-05T10:33:05Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":106181,"stargazers_count":1419,"watchers_count":1419,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":384,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":384,"open_issues":119,"watchers":1419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/2448"},"html":{"href":"https://github.com/corda/corda/pull/2448"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/2448"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/2448/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/2448/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/2448/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/2083d5077acc45d8c18002faa4dd5790446e504d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"m4ksio"}}