{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/192597964","pull_request_review_id":125403736,"id":192597964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU5Nzk2NA==","diff_hunk":"@@ -163,7 +164,7 @@ export interface AreaProps extends EventAttributes, Partial<PresentationAttribut\n     connectNulls?: boolean;\n     activeDot?: boolean | object | React.ReactElement<any> | ContentRenderer<any>;\n     dot?: boolean | object | React.ReactElement<any> | ContentRenderer<DotProps>;\n-    label?: boolean | object | React.ReactElement<any> | LabelProps['content'];\n+    label?: boolean | object | ContentRenderer<any> | React.ReactElement<any> | LabelProps['content'];","path":"types/recharts/index.d.ts","position":null,"original_position":13,"commit_id":"8d935f62f677c2d317fae9830349a29614374fea","original_commit_id":"5f9d43f6ea13b7bafeba115ec5f29f32d3665271","user":{"login":"pkeuter","id":433441,"node_id":"MDQ6VXNlcjQzMzQ0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/433441?v=4","gravatar_id":"","url":"https://api.github.com/users/pkeuter","html_url":"https://github.com/pkeuter","followers_url":"https://api.github.com/users/pkeuter/followers","following_url":"https://api.github.com/users/pkeuter/following{/other_user}","gists_url":"https://api.github.com/users/pkeuter/gists{/gist_id}","starred_url":"https://api.github.com/users/pkeuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkeuter/subscriptions","organizations_url":"https://api.github.com/users/pkeuter/orgs","repos_url":"https://api.github.com/users/pkeuter/repos","events_url":"https://api.github.com/users/pkeuter/events{/privacy}","received_events_url":"https://api.github.com/users/pkeuter/received_events","type":"User","site_admin":false},"body":"Hehe yeah that could be the thing here. I've tested removing the `LabelProps['content']` typing and it seems to work fine, so I've commited it! Please review :-)","created_at":"2018-06-03T18:09:30Z","updated_at":"2018-06-03T18:09:30Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26101#discussion_r192597964","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/192597964"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26101#discussion_r192597964"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101"}},"in_reply_to_id":192586472},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101","id":191093032,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDkzMDMy","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26101","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26101.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26101.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/26101","number":26101,"state":"open","locked":false,"title":"Add label render function","user":{"login":"pkeuter","id":433441,"node_id":"MDQ6VXNlcjQzMzQ0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/433441?v=4","gravatar_id":"","url":"https://api.github.com/users/pkeuter","html_url":"https://github.com/pkeuter","followers_url":"https://api.github.com/users/pkeuter/followers","following_url":"https://api.github.com/users/pkeuter/following{/other_user}","gists_url":"https://api.github.com/users/pkeuter/gists{/gist_id}","starred_url":"https://api.github.com/users/pkeuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkeuter/subscriptions","organizations_url":"https://api.github.com/users/pkeuter/orgs","repos_url":"https://api.github.com/users/pkeuter/repos","events_url":"https://api.github.com/users/pkeuter/events{/privacy}","received_events_url":"https://api.github.com/users/pkeuter/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: http://recharts.org/en-US/api/Bar#label, http://recharts.org/en-US/api/Pie#label, etc..\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-05-29T10:00:43Z","updated_at":"2018-06-03T18:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a21bf583857c06f85723d3656996cd8b4ce24971","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644095882,"node_id":"MDU6TGFiZWw2NDQwOTU4ODI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:YSYL","name":"Merge:YSYL","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/26101/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8d935f62f677c2d317fae9830349a29614374fea","head":{"label":"pkeuter:add-label-function","ref":"add-label-function","sha":"8d935f62f677c2d317fae9830349a29614374fea","user":{"login":"pkeuter","id":433441,"node_id":"MDQ6VXNlcjQzMzQ0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/433441?v=4","gravatar_id":"","url":"https://api.github.com/users/pkeuter","html_url":"https://github.com/pkeuter","followers_url":"https://api.github.com/users/pkeuter/followers","following_url":"https://api.github.com/users/pkeuter/following{/other_user}","gists_url":"https://api.github.com/users/pkeuter/gists{/gist_id}","starred_url":"https://api.github.com/users/pkeuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkeuter/subscriptions","organizations_url":"https://api.github.com/users/pkeuter/orgs","repos_url":"https://api.github.com/users/pkeuter/repos","events_url":"https://api.github.com/users/pkeuter/events{/privacy}","received_events_url":"https://api.github.com/users/pkeuter/received_events","type":"User","site_admin":false},"repo":{"id":90014135,"node_id":"MDEwOlJlcG9zaXRvcnk5MDAxNDEzNQ==","name":"DefinitelyTyped","full_name":"pkeuter/DefinitelyTyped","owner":{"login":"pkeuter","id":433441,"node_id":"MDQ6VXNlcjQzMzQ0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/433441?v=4","gravatar_id":"","url":"https://api.github.com/users/pkeuter","html_url":"https://github.com/pkeuter","followers_url":"https://api.github.com/users/pkeuter/followers","following_url":"https://api.github.com/users/pkeuter/following{/other_user}","gists_url":"https://api.github.com/users/pkeuter/gists{/gist_id}","starred_url":"https://api.github.com/users/pkeuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkeuter/subscriptions","organizations_url":"https://api.github.com/users/pkeuter/orgs","repos_url":"https://api.github.com/users/pkeuter/repos","events_url":"https://api.github.com/users/pkeuter/events{/privacy}","received_events_url":"https://api.github.com/users/pkeuter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkeuter/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/pkeuter/DefinitelyTyped","forks_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/pkeuter/DefinitelyTyped/deployments","created_at":"2017-05-02T09:16:48Z","updated_at":"2017-05-02T09:17:02Z","pushed_at":"2018-06-03T18:07:57Z","git_url":"git://github.com/pkeuter/DefinitelyTyped.git","ssh_url":"git@github.com:pkeuter/DefinitelyTyped.git","clone_url":"https://github.com/pkeuter/DefinitelyTyped.git","svn_url":"https://github.com/pkeuter/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":317253,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"86fa899b1f403106cc30817dc38994013894820c","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-06-03T17:35:49Z","pushed_at":"2018-06-03T18:08:19Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":320489,"stargazers_count":15813,"watchers_count":15813,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13191,"mirror_url":null,"archived":false,"open_issues_count":2192,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13191,"open_issues":2192,"watchers":15813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26101"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/26101"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/26101/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/26101/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8d935f62f677c2d317fae9830349a29614374fea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pkeuter"}}