{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/231373183","pull_request_review_id":172331428,"id":231373183,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTM3MzE4Mw==","diff_hunk":"@@ -112,21 +112,27 @@ ln -s /usr/local/opt/openssl/lib/pkgconfig/openssl.pc /usr/local/lib/pkgconfig/\n \n Alternatively, to avoid modifying /usr/local/ you can invoke cmake with the `OPENSSL_ROOT_DIR` env var set. The value to be passed in the directory where openssl is installed. Use `brew info openssl` to determine it. For example:\n \n-```\n-$brew info openssl\n-openssl: stable 1.0.2l (bottled) [keg-only]\n+```none\n+$ brew info openssl\n+openssl: stable 1.0.2p (bottled) [keg-only]\n SSL/TLS cryptography library\n https://openssl.org/\n-/usr/local/Cellar/openssl/1.0.1f (1,229 files, 10.8MB)\n-  Poured from bottle on 2014-01-20 at 19:25:30\n-/usr/local/Cellar/openssl/1.0.1g (1,229 files, 10.6MB)\n-  Poured from bottle on 2014-04-07 at 11:26:41\n+/usr/local/Cellar/openssl/1.0.2l (1,709 files, 12.3MB)\n+  Poured from bottle on 2017-10-10 at 21:30:10\n+/usr/local/Cellar/openssl/1.0.2m (1,792 files, 12.3MB)\n+  Poured from bottle on 2017-11-06 at 17:45:21\n+/usr/local/Cellar/openssl/1.0.2n (1,792 files, 12.3MB)\n+  Poured from bottle on 2018-01-25 at 20:22:45\n+/usr/local/Cellar/openssl/1.0.2o_2 (1,792 files, 12.3MB)\n+  Poured from bottle on 2018-07-15 at 16:59:46\n+/usr/local/Cellar/openssl/1.0.2p (1,793 files, 12.3MB)\n+  Poured from bottle on 2018-08-31 at 19:37:10\n ```\n \n-With the above example, we'd pick the latest version `1.0.1g` and invoke cmake like the following:\n+With the above example, use the latest version path for `1.0.2p`:\n \n-```\n-OPENSSL_ROOT_DIR=\"/usr/local/Cellar/openssl/1.0.1g cmake\n+```none\n+$ export OPENSSL_ROOT_DIR=/usr/local/Cellar/openssl/1.0.2p","path":"Documentation/building/unix-instructions.md","position":43,"original_position":43,"commit_id":"176f7729e4cf80a763012b50061ea66445b7b3eb","original_commit_id":"176f7729e4cf80a763012b50061ea66445b7b3eb","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"body":"it will work for subprocesses but it needs to be specified on every command invocation. \r\n(it may be possible that build would cache it so subsequent build would work without proper value)\r\nexport OPENSSL_ROOT_DIR=XX would allow to set it once and be used for all commands on given shell session.","created_at":"2018-11-07T03:47:15Z","updated_at":"2018-11-07T03:47:15Z","html_url":"https://github.com/dotnet/corefx/pull/32783#discussion_r231373183","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/32783","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/231373183"},"html":{"href":"https://github.com/dotnet/corefx/pull/32783#discussion_r231373183"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32783"}},"in_reply_to_id":225662239},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/32783","id":222352255,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzUyMjU1","html_url":"https://github.com/dotnet/corefx/pull/32783","diff_url":"https://github.com/dotnet/corefx/pull/32783.diff","patch_url":"https://github.com/dotnet/corefx/pull/32783.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/32783","number":32783,"state":"open","locked":false,"title":"Correct OPENSSL_ROOT_DIR environment variable.","user":{"login":"thezim","id":14023826,"node_id":"MDQ6VXNlcjE0MDIzODI2","avatar_url":"https://avatars0.githubusercontent.com/u/14023826?v=4","gravatar_id":"","url":"https://api.github.com/users/thezim","html_url":"https://github.com/thezim","followers_url":"https://api.github.com/users/thezim/followers","following_url":"https://api.github.com/users/thezim/following{/other_user}","gists_url":"https://api.github.com/users/thezim/gists{/gist_id}","starred_url":"https://api.github.com/users/thezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezim/subscriptions","organizations_url":"https://api.github.com/users/thezim/orgs","repos_url":"https://api.github.com/users/thezim/repos","events_url":"https://api.github.com/users/thezim/events{/privacy}","received_events_url":"https://api.github.com/users/thezim/received_events","type":"User","site_admin":false},"body":"cmake should not be included as part of environment variable. Var must also be properly end quoted.","created_at":"2018-10-12T05:19:19Z","updated_at":"2018-11-07T03:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fedeefe52b3d4d7c569974401e0f14f7fa2a05ff","assignee":{"login":"bartonjs","id":10642668,"node_id":"MDQ6VXNlcjEwNjQyNjY4","avatar_url":"https://avatars3.githubusercontent.com/u/10642668?v=4","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"assignees":[{"login":"bartonjs","id":10642668,"node_id":"MDQ6VXNlcjEwNjQyNjY4","avatar_url":"https://avatars3.githubusercontent.com/u/10642668?v=4","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},{"login":"thezim","id":14023826,"node_id":"MDQ6VXNlcjE0MDIzODI2","avatar_url":"https://avatars0.githubusercontent.com/u/14023826?v=4","gravatar_id":"","url":"https://api.github.com/users/thezim","html_url":"https://github.com/thezim","followers_url":"https://api.github.com/users/thezim/followers","following_url":"https://api.github.com/users/thezim/following{/other_user}","gists_url":"https://api.github.com/users/thezim/gists{/gist_id}","starred_url":"https://api.github.com/users/thezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezim/subscriptions","organizations_url":"https://api.github.com/users/thezim/orgs","repos_url":"https://api.github.com/users/thezim/repos","events_url":"https://api.github.com/users/thezim/events{/privacy}","received_events_url":"https://api.github.com/users/thezim/received_events","type":"User","site_admin":false},{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":174888041,"node_id":"MDU6TGFiZWwxNzQ4ODgwNDE=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-Infrastructure","name":"area-Infrastructure","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/32783/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/32783/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/32783/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/176f7729e4cf80a763012b50061ea66445b7b3eb","head":{"label":"thezim:openssl-root-dir-doc-fix","ref":"openssl-root-dir-doc-fix","sha":"176f7729e4cf80a763012b50061ea66445b7b3eb","user":{"login":"thezim","id":14023826,"node_id":"MDQ6VXNlcjE0MDIzODI2","avatar_url":"https://avatars0.githubusercontent.com/u/14023826?v=4","gravatar_id":"","url":"https://api.github.com/users/thezim","html_url":"https://github.com/thezim","followers_url":"https://api.github.com/users/thezim/followers","following_url":"https://api.github.com/users/thezim/following{/other_user}","gists_url":"https://api.github.com/users/thezim/gists{/gist_id}","starred_url":"https://api.github.com/users/thezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezim/subscriptions","organizations_url":"https://api.github.com/users/thezim/orgs","repos_url":"https://api.github.com/users/thezim/repos","events_url":"https://api.github.com/users/thezim/events{/privacy}","received_events_url":"https://api.github.com/users/thezim/received_events","type":"User","site_admin":false},"repo":{"id":152697072,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2OTcwNzI=","name":"corefx","full_name":"thezim/corefx","private":false,"owner":{"login":"thezim","id":14023826,"node_id":"MDQ6VXNlcjE0MDIzODI2","avatar_url":"https://avatars0.githubusercontent.com/u/14023826?v=4","gravatar_id":"","url":"https://api.github.com/users/thezim","html_url":"https://github.com/thezim","followers_url":"https://api.github.com/users/thezim/followers","following_url":"https://api.github.com/users/thezim/following{/other_user}","gists_url":"https://api.github.com/users/thezim/gists{/gist_id}","starred_url":"https://api.github.com/users/thezim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezim/subscriptions","organizations_url":"https://api.github.com/users/thezim/orgs","repos_url":"https://api.github.com/users/thezim/repos","events_url":"https://api.github.com/users/thezim/events{/privacy}","received_events_url":"https://api.github.com/users/thezim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thezim/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/thezim/corefx","forks_url":"https://api.github.com/repos/thezim/corefx/forks","keys_url":"https://api.github.com/repos/thezim/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thezim/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thezim/corefx/teams","hooks_url":"https://api.github.com/repos/thezim/corefx/hooks","issue_events_url":"https://api.github.com/repos/thezim/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/thezim/corefx/events","assignees_url":"https://api.github.com/repos/thezim/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/thezim/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/thezim/corefx/tags","blobs_url":"https://api.github.com/repos/thezim/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thezim/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thezim/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/thezim/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thezim/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/thezim/corefx/languages","stargazers_url":"https://api.github.com/repos/thezim/corefx/stargazers","contributors_url":"https://api.github.com/repos/thezim/corefx/contributors","subscribers_url":"https://api.github.com/repos/thezim/corefx/subscribers","subscription_url":"https://api.github.com/repos/thezim/corefx/subscription","commits_url":"https://api.github.com/repos/thezim/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/thezim/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/thezim/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/thezim/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/thezim/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/thezim/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thezim/corefx/merges","archive_url":"https://api.github.com/repos/thezim/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thezim/corefx/downloads","issues_url":"https://api.github.com/repos/thezim/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/thezim/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/thezim/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/thezim/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thezim/corefx/labels{/name}","releases_url":"https://api.github.com/repos/thezim/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/thezim/corefx/deployments","created_at":"2018-10-12T05:11:14Z","updated_at":"2018-10-12T05:18:17Z","pushed_at":"2018-10-14T18:04:10Z","git_url":"git://github.com/thezim/corefx.git","ssh_url":"git@github.com:thezim/corefx.git","clone_url":"https://github.com/thezim/corefx.git","svn_url":"https://github.com/thezim/corefx","homepage":"https://github.com/dotnet/core","size":189261,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"83ad4d3e5d14ba585dea88abb515f3bcca63ff94","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-07T02:08:59Z","pushed_at":"2018-11-07T03:04:48Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":190844,"stargazers_count":15095,"watchers_count":15095,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4469,"mirror_url":null,"archived":false,"open_issues_count":2592,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4469,"open_issues":2592,"watchers":15095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32783"},"html":{"href":"https://github.com/dotnet/corefx/pull/32783"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/32783"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/32783/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32783/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32783/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/176f7729e4cf80a763012b50061ea66445b7b3eb"}},"author_association":"NONE"}}
{"actor":{"display_login":"wfurt"}}