{"action":"created","comment":{"url":"https://api.github.com/repos/transcom/mymove/pulls/comments/177510574","pull_request_review_id":107394332,"id":177510574,"diff_hunk":"@@ -137,9 +142,19 @@ func main() {\n \t// And request logging\n \troot.Use(requestLogger)\n \n-\taddress := fmt.Sprintf(\"%s:%s\", *listenInterface, *port)\n-\tzap.L().Info(\"Starting the server listening\", zap.String(\"address\", address))\n-\tlog.Fatal(http.ListenAndServe(address, root))\n+\t// Start http/https listener(s)\n+\terrChan := make(chan error)","path":"cmd/webserver/main.go","position":36,"original_position":36,"commit_id":"458b99979ee2e5a34b974ba19f5afe81c7bfe07d","original_commit_id":"458b99979ee2e5a34b974ba19f5afe81c7bfe07d","user":{"login":"ntwyman","id":317739,"avatar_url":"https://avatars3.githubusercontent.com/u/317739?v=4","gravatar_id":"","url":"https://api.github.com/users/ntwyman","html_url":"https://github.com/ntwyman","followers_url":"https://api.github.com/users/ntwyman/followers","following_url":"https://api.github.com/users/ntwyman/following{/other_user}","gists_url":"https://api.github.com/users/ntwyman/gists{/gist_id}","starred_url":"https://api.github.com/users/ntwyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntwyman/subscriptions","organizations_url":"https://api.github.com/users/ntwyman/orgs","repos_url":"https://api.github.com/users/ntwyman/repos","events_url":"https://api.github.com/users/ntwyman/events{/privacy}","received_events_url":"https://api.github.com/users/ntwyman/received_events","type":"User","site_admin":false},"body":"Why make this channel? Can you not just call log.Fatal() at lines 150 and 155?\r\n\r\nSeems like the channel is just making things more complex","created_at":"2018-03-27T17:38:45Z","updated_at":"2018-03-27T17:38:52Z","html_url":"https://github.com/transcom/mymove/pull/296#discussion_r177510574","pull_request_url":"https://api.github.com/repos/transcom/mymove/pulls/296","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments/177510574"},"html":{"href":"https://github.com/transcom/mymove/pull/296#discussion_r177510574"},"pull_request":{"href":"https://api.github.com/repos/transcom/mymove/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/296","id":177599665,"html_url":"https://github.com/transcom/mymove/pull/296","diff_url":"https://github.com/transcom/mymove/pull/296.diff","patch_url":"https://github.com/transcom/mymove/pull/296.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/296","number":296,"state":"open","locked":false,"title":"Add a TLS listener to the webserver.","user":{"login":"brainsik","id":162998,"avatar_url":"https://avatars0.githubusercontent.com/u/162998?v=4","gravatar_id":"","url":"https://api.github.com/users/brainsik","html_url":"https://github.com/brainsik","followers_url":"https://api.github.com/users/brainsik/followers","following_url":"https://api.github.com/users/brainsik/following{/other_user}","gists_url":"https://api.github.com/users/brainsik/gists{/gist_id}","starred_url":"https://api.github.com/users/brainsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainsik/subscriptions","organizations_url":"https://api.github.com/users/brainsik/orgs","repos_url":"https://api.github.com/users/brainsik/repos","events_url":"https://api.github.com/users/brainsik/events{/privacy}","received_events_url":"https://api.github.com/users/brainsik/received_events","type":"User","site_admin":false},"body":"The cert/key pair is read from environment variables.","created_at":"2018-03-27T00:07:10Z","updated_at":"2018-03-27T17:38:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f2c4140948106ff0c76a5eb477a626de412043b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jim","id":3331,"avatar_url":"https://avatars1.githubusercontent.com/u/3331?v=4","gravatar_id":"","url":"https://api.github.com/users/jim","html_url":"https://github.com/jim","followers_url":"https://api.github.com/users/jim/followers","following_url":"https://api.github.com/users/jim/following{/other_user}","gists_url":"https://api.github.com/users/jim/gists{/gist_id}","starred_url":"https://api.github.com/users/jim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim/subscriptions","organizations_url":"https://api.github.com/users/jim/orgs","repos_url":"https://api.github.com/users/jim/repos","events_url":"https://api.github.com/users/jim/events{/privacy}","received_events_url":"https://api.github.com/users/jim/received_events","type":"User","site_admin":false},{"login":"macrael","id":55759,"avatar_url":"https://avatars1.githubusercontent.com/u/55759?v=4","gravatar_id":"","url":"https://api.github.com/users/macrael","html_url":"https://github.com/macrael","followers_url":"https://api.github.com/users/macrael/followers","following_url":"https://api.github.com/users/macrael/following{/other_user}","gists_url":"https://api.github.com/users/macrael/gists{/gist_id}","starred_url":"https://api.github.com/users/macrael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrael/subscriptions","organizations_url":"https://api.github.com/users/macrael/orgs","repos_url":"https://api.github.com/users/macrael/repos","events_url":"https://api.github.com/users/macrael/events{/privacy}","received_events_url":"https://api.github.com/users/macrael/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/296/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/296/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/296/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/458b99979ee2e5a34b974ba19f5afe81c7bfe07d","head":{"label":"transcom:bsik-https","ref":"bsik-https","sha":"458b99979ee2e5a34b974ba19f5afe81c7bfe07d","user":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"name":"mymove","full_name":"transcom/mymove","owner":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-03-27T17:28:58Z","pushed_at":"2018-03-27T17:28:59Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":9298,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"8f33dd906a1968b309aefd85d8176b34661c4a3f","user":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"name":"mymove","full_name":"transcom/mymove","owner":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-03-27T17:28:58Z","pushed_at":"2018-03-27T17:28:59Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":9298,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/296"},"html":{"href":"https://github.com/transcom/mymove/pull/296"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/296"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/458b99979ee2e5a34b974ba19f5afe81c7bfe07d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ntwyman"}}