{"action":"created","comment":{"url":"https://api.github.com/repos/bondhugula/pluto/pulls/comments/181658206","pull_request_review_id":112320814,"id":181658206,"diff_hunk":"@@ -1,12 +1,13 @@\n-#!/bin/sh\n+#!/bin/bash\n # getversion.h will be automatically generated from this\n # Output of getversion.h goes into src/version.h\n \n-githead=@SOURCE_DIR@/.git/HEAD\n-version=@PACKAGE_VERSION@\n+  githead=@SOURCE_DIR@/.git/HEAD\n+  version=@PACKAGE_VERSION@\n+\n+  if [ -f $githead ]; then\n+    git describe --tags --always\n+  else\n+    echo \"$version\"\n+  fi","path":"getversion.sh.in","position":15,"original_position":15,"commit_id":"d8b9c91e3f36730dfe6fdfb26e38dde4c943e26d","original_commit_id":"d8b9c91e3f36730dfe6fdfb26e38dde4c943e26d","user":{"login":"cristianrcv","id":25862334,"avatar_url":"https://avatars1.githubusercontent.com/u/25862334?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianrcv","html_url":"https://github.com/cristianrcv","followers_url":"https://api.github.com/users/cristianrcv/followers","following_url":"https://api.github.com/users/cristianrcv/following{/other_user}","gists_url":"https://api.github.com/users/cristianrcv/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianrcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianrcv/subscriptions","organizations_url":"https://api.github.com/users/cristianrcv/orgs","repos_url":"https://api.github.com/users/cristianrcv/repos","events_url":"https://api.github.com/users/cristianrcv/events{/privacy}","received_events_url":"https://api.github.com/users/cristianrcv/received_events","type":"User","site_admin":false},"body":"I have already removed the trailing whitespaces. The changes on this script concern the `git describe` command which is output as it is rather than using `echo` and a subshell. ","created_at":"2018-04-16T08:33:27Z","updated_at":"2018-04-16T08:33:27Z","html_url":"https://github.com/bondhugula/pluto/pull/22#discussion_r181658206","pull_request_url":"https://api.github.com/repos/bondhugula/pluto/pulls/22","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bondhugula/pluto/pulls/comments/181658206"},"html":{"href":"https://github.com/bondhugula/pluto/pull/22#discussion_r181658206"},"pull_request":{"href":"https://api.github.com/repos/bondhugula/pluto/pulls/22"}},"in_reply_to_id":181602027},"pull_request":{"url":"https://api.github.com/repos/bondhugula/pluto/pulls/22","id":180642064,"html_url":"https://github.com/bondhugula/pluto/pull/22","diff_url":"https://github.com/bondhugula/pluto/pull/22.diff","patch_url":"https://github.com/bondhugula/pluto/pull/22.patch","issue_url":"https://api.github.com/repos/bondhugula/pluto/issues/22","number":22,"state":"open","locked":false,"title":"[WIP] Add language propagation through PLUTO","user":{"login":"cristianrcv","id":25862334,"avatar_url":"https://avatars1.githubusercontent.com/u/25862334?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianrcv","html_url":"https://github.com/cristianrcv","followers_url":"https://api.github.com/users/cristianrcv/followers","following_url":"https://api.github.com/users/cristianrcv/following{/other_user}","gists_url":"https://api.github.com/users/cristianrcv/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianrcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianrcv/subscriptions","organizations_url":"https://api.github.com/users/cristianrcv/orgs","repos_url":"https://api.github.com/users/cristianrcv/repos","events_url":"https://api.github.com/users/cristianrcv/events{/privacy}","received_events_url":"https://api.github.com/users/cristianrcv/received_events","type":"User","site_admin":false},"body":"In the context of a bigger project, I have extended PLUTO and CLooG to generate Python code,and developed a new tool to parse from Python to OpenSCOP code (which is left outside this PR). Although the main modifications are on CLooG, I needed to *propagate the program language through PLUTO* (from the parsed source to the CLooG invocation). \r\n\r\nThus, this PR mainly contributes in adding the PYTHON language constant and propagating the language value up to the CLooG intermediate file. \r\n\r\nAside from the main contribution, I propose some other modifications:\r\n- Update `.gitignore` file with build files and remove obsolete entries\r\n- Ignore untracked files from submodules (basically, build files)\r\n- Deploy the `inscop` script on the installation folder since `polycc` uses it\r\n- Update and format `apply_patches`, `get_version.sh`, `test-iss.sh`, `test.sh`, `inscop`, and `polycc` scripts. Among other things, the scripts now fail if any error is raised in internal commands. \r\n- Add scripts to handle submodules (`submodules_get.sh` and `submodules_update.sh`) making them to fail if any subcommand fails. The submodules update script is meant to update the internal modules to its latest version so this should be used only by developers (because the compatibilities between tools must be checked manually upon update). \r\n- Make the `autogen.sh` script call the submodules `autogen.sh` file instead of a custom command. Also, make it fail on any submodule build error. \r\n- Add a script to fully install pluto (`install_pluto`) which easiest the installation of PLUTO in bigger projects (as my case). \r\n- Update README to markdown and modify `configure.ac` to accept it\r\n\r\nThis PR also updates the PLUTO submodules since supporting Python language relies on the latest version of them (specially CLooG and OpenSCOP). \r\n\r\nThe PR is WorkInProgress because the submodules are pointing to non-official repositories while the PRs are being reviewed.","created_at":"2018-04-10T15:30:10Z","updated_at":"2018-04-16T08:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47dbd9753ddfdcb770229cf78927a5fbdd701054","assignee":{"login":"bondhugula","id":7008401,"avatar_url":"https://avatars2.githubusercontent.com/u/7008401?v=4","gravatar_id":"","url":"https://api.github.com/users/bondhugula","html_url":"https://github.com/bondhugula","followers_url":"https://api.github.com/users/bondhugula/followers","following_url":"https://api.github.com/users/bondhugula/following{/other_user}","gists_url":"https://api.github.com/users/bondhugula/gists{/gist_id}","starred_url":"https://api.github.com/users/bondhugula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bondhugula/subscriptions","organizations_url":"https://api.github.com/users/bondhugula/orgs","repos_url":"https://api.github.com/users/bondhugula/repos","events_url":"https://api.github.com/users/bondhugula/events{/privacy}","received_events_url":"https://api.github.com/users/bondhugula/received_events","type":"User","site_admin":false},"assignees":[{"login":"bondhugula","id":7008401,"avatar_url":"https://avatars2.githubusercontent.com/u/7008401?v=4","gravatar_id":"","url":"https://api.github.com/users/bondhugula","html_url":"https://github.com/bondhugula","followers_url":"https://api.github.com/users/bondhugula/followers","following_url":"https://api.github.com/users/bondhugula/following{/other_user}","gists_url":"https://api.github.com/users/bondhugula/gists{/gist_id}","starred_url":"https://api.github.com/users/bondhugula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bondhugula/subscriptions","organizations_url":"https://api.github.com/users/bondhugula/orgs","repos_url":"https://api.github.com/users/bondhugula/repos","events_url":"https://api.github.com/users/bondhugula/events{/privacy}","received_events_url":"https://api.github.com/users/bondhugula/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bondhugula/pluto/pulls/22/commits","review_comments_url":"https://api.github.com/repos/bondhugula/pluto/pulls/22/comments","review_comment_url":"https://api.github.com/repos/bondhugula/pluto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bondhugula/pluto/issues/22/comments","statuses_url":"https://api.github.com/repos/bondhugula/pluto/statuses/d8b9c91e3f36730dfe6fdfb26e38dde4c943e26d","head":{"label":"cristianrcv:master","ref":"master","sha":"d8b9c91e3f36730dfe6fdfb26e38dde4c943e26d","user":{"login":"cristianrcv","id":25862334,"avatar_url":"https://avatars1.githubusercontent.com/u/25862334?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianrcv","html_url":"https://github.com/cristianrcv","followers_url":"https://api.github.com/users/cristianrcv/followers","following_url":"https://api.github.com/users/cristianrcv/following{/other_user}","gists_url":"https://api.github.com/users/cristianrcv/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianrcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianrcv/subscriptions","organizations_url":"https://api.github.com/users/cristianrcv/orgs","repos_url":"https://api.github.com/users/cristianrcv/repos","events_url":"https://api.github.com/users/cristianrcv/events{/privacy}","received_events_url":"https://api.github.com/users/cristianrcv/received_events","type":"User","site_admin":false},"repo":{"id":117521681,"name":"pluto","full_name":"cristianrcv/pluto","owner":{"login":"cristianrcv","id":25862334,"avatar_url":"https://avatars1.githubusercontent.com/u/25862334?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianrcv","html_url":"https://github.com/cristianrcv","followers_url":"https://api.github.com/users/cristianrcv/followers","following_url":"https://api.github.com/users/cristianrcv/following{/other_user}","gists_url":"https://api.github.com/users/cristianrcv/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianrcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianrcv/subscriptions","organizations_url":"https://api.github.com/users/cristianrcv/orgs","repos_url":"https://api.github.com/users/cristianrcv/repos","events_url":"https://api.github.com/users/cristianrcv/events{/privacy}","received_events_url":"https://api.github.com/users/cristianrcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristianrcv/pluto","description":"Pluto: An automatic polyhedral parallelizer and locality optimizer","fork":true,"url":"https://api.github.com/repos/cristianrcv/pluto","forks_url":"https://api.github.com/repos/cristianrcv/pluto/forks","keys_url":"https://api.github.com/repos/cristianrcv/pluto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristianrcv/pluto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristianrcv/pluto/teams","hooks_url":"https://api.github.com/repos/cristianrcv/pluto/hooks","issue_events_url":"https://api.github.com/repos/cristianrcv/pluto/issues/events{/number}","events_url":"https://api.github.com/repos/cristianrcv/pluto/events","assignees_url":"https://api.github.com/repos/cristianrcv/pluto/assignees{/user}","branches_url":"https://api.github.com/repos/cristianrcv/pluto/branches{/branch}","tags_url":"https://api.github.com/repos/cristianrcv/pluto/tags","blobs_url":"https://api.github.com/repos/cristianrcv/pluto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristianrcv/pluto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristianrcv/pluto/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristianrcv/pluto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristianrcv/pluto/statuses/{sha}","languages_url":"https://api.github.com/repos/cristianrcv/pluto/languages","stargazers_url":"https://api.github.com/repos/cristianrcv/pluto/stargazers","contributors_url":"https://api.github.com/repos/cristianrcv/pluto/contributors","subscribers_url":"https://api.github.com/repos/cristianrcv/pluto/subscribers","subscription_url":"https://api.github.com/repos/cristianrcv/pluto/subscription","commits_url":"https://api.github.com/repos/cristianrcv/pluto/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristianrcv/pluto/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristianrcv/pluto/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristianrcv/pluto/issues/comments{/number}","contents_url":"https://api.github.com/repos/cristianrcv/pluto/contents/{+path}","compare_url":"https://api.github.com/repos/cristianrcv/pluto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristianrcv/pluto/merges","archive_url":"https://api.github.com/repos/cristianrcv/pluto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristianrcv/pluto/downloads","issues_url":"https://api.github.com/repos/cristianrcv/pluto/issues{/number}","pulls_url":"https://api.github.com/repos/cristianrcv/pluto/pulls{/number}","milestones_url":"https://api.github.com/repos/cristianrcv/pluto/milestones{/number}","notifications_url":"https://api.github.com/repos/cristianrcv/pluto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristianrcv/pluto/labels{/name}","releases_url":"https://api.github.com/repos/cristianrcv/pluto/releases{/id}","deployments_url":"https://api.github.com/repos/cristianrcv/pluto/deployments","created_at":"2018-01-15T09:00:54Z","updated_at":"2018-04-10T12:28:00Z","pushed_at":"2018-04-10T12:27:58Z","git_url":"git://github.com/cristianrcv/pluto.git","ssh_url":"git@github.com:cristianrcv/pluto.git","clone_url":"https://github.com/cristianrcv/pluto.git","svn_url":"https://github.com/cristianrcv/pluto","homepage":"http://pluto-compiler.sourceforge.net","size":26984,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bondhugula:master","ref":"master","sha":"3004cda953012ab98ab22433cda6605040d370e1","user":{"login":"bondhugula","id":7008401,"avatar_url":"https://avatars2.githubusercontent.com/u/7008401?v=4","gravatar_id":"","url":"https://api.github.com/users/bondhugula","html_url":"https://github.com/bondhugula","followers_url":"https://api.github.com/users/bondhugula/followers","following_url":"https://api.github.com/users/bondhugula/following{/other_user}","gists_url":"https://api.github.com/users/bondhugula/gists{/gist_id}","starred_url":"https://api.github.com/users/bondhugula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bondhugula/subscriptions","organizations_url":"https://api.github.com/users/bondhugula/orgs","repos_url":"https://api.github.com/users/bondhugula/repos","events_url":"https://api.github.com/users/bondhugula/events{/privacy}","received_events_url":"https://api.github.com/users/bondhugula/received_events","type":"User","site_admin":false},"repo":{"id":76021818,"name":"pluto","full_name":"bondhugula/pluto","owner":{"login":"bondhugula","id":7008401,"avatar_url":"https://avatars2.githubusercontent.com/u/7008401?v=4","gravatar_id":"","url":"https://api.github.com/users/bondhugula","html_url":"https://github.com/bondhugula","followers_url":"https://api.github.com/users/bondhugula/followers","following_url":"https://api.github.com/users/bondhugula/following{/other_user}","gists_url":"https://api.github.com/users/bondhugula/gists{/gist_id}","starred_url":"https://api.github.com/users/bondhugula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bondhugula/subscriptions","organizations_url":"https://api.github.com/users/bondhugula/orgs","repos_url":"https://api.github.com/users/bondhugula/repos","events_url":"https://api.github.com/users/bondhugula/events{/privacy}","received_events_url":"https://api.github.com/users/bondhugula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bondhugula/pluto","description":"Pluto: An automatic polyhedral parallelizer and locality optimizer","fork":false,"url":"https://api.github.com/repos/bondhugula/pluto","forks_url":"https://api.github.com/repos/bondhugula/pluto/forks","keys_url":"https://api.github.com/repos/bondhugula/pluto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bondhugula/pluto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bondhugula/pluto/teams","hooks_url":"https://api.github.com/repos/bondhugula/pluto/hooks","issue_events_url":"https://api.github.com/repos/bondhugula/pluto/issues/events{/number}","events_url":"https://api.github.com/repos/bondhugula/pluto/events","assignees_url":"https://api.github.com/repos/bondhugula/pluto/assignees{/user}","branches_url":"https://api.github.com/repos/bondhugula/pluto/branches{/branch}","tags_url":"https://api.github.com/repos/bondhugula/pluto/tags","blobs_url":"https://api.github.com/repos/bondhugula/pluto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bondhugula/pluto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bondhugula/pluto/git/refs{/sha}","trees_url":"https://api.github.com/repos/bondhugula/pluto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bondhugula/pluto/statuses/{sha}","languages_url":"https://api.github.com/repos/bondhugula/pluto/languages","stargazers_url":"https://api.github.com/repos/bondhugula/pluto/stargazers","contributors_url":"https://api.github.com/repos/bondhugula/pluto/contributors","subscribers_url":"https://api.github.com/repos/bondhugula/pluto/subscribers","subscription_url":"https://api.github.com/repos/bondhugula/pluto/subscription","commits_url":"https://api.github.com/repos/bondhugula/pluto/commits{/sha}","git_commits_url":"https://api.github.com/repos/bondhugula/pluto/git/commits{/sha}","comments_url":"https://api.github.com/repos/bondhugula/pluto/comments{/number}","issue_comment_url":"https://api.github.com/repos/bondhugula/pluto/issues/comments{/number}","contents_url":"https://api.github.com/repos/bondhugula/pluto/contents/{+path}","compare_url":"https://api.github.com/repos/bondhugula/pluto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bondhugula/pluto/merges","archive_url":"https://api.github.com/repos/bondhugula/pluto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bondhugula/pluto/downloads","issues_url":"https://api.github.com/repos/bondhugula/pluto/issues{/number}","pulls_url":"https://api.github.com/repos/bondhugula/pluto/pulls{/number}","milestones_url":"https://api.github.com/repos/bondhugula/pluto/milestones{/number}","notifications_url":"https://api.github.com/repos/bondhugula/pluto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bondhugula/pluto/labels{/name}","releases_url":"https://api.github.com/repos/bondhugula/pluto/releases{/id}","deployments_url":"https://api.github.com/repos/bondhugula/pluto/deployments","created_at":"2016-12-09T09:35:40Z","updated_at":"2018-03-31T11:18:37Z","pushed_at":"2018-04-10T15:30:11Z","git_url":"git://github.com/bondhugula/pluto.git","ssh_url":"git@github.com:bondhugula/pluto.git","clone_url":"https://github.com/bondhugula/pluto.git","svn_url":"https://github.com/bondhugula/pluto","homepage":"http://pluto-compiler.sourceforge.net","size":27127,"stargazers_count":21,"watchers_count":21,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":5,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bondhugula/pluto/pulls/22"},"html":{"href":"https://github.com/bondhugula/pluto/pull/22"},"issue":{"href":"https://api.github.com/repos/bondhugula/pluto/issues/22"},"comments":{"href":"https://api.github.com/repos/bondhugula/pluto/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/bondhugula/pluto/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/bondhugula/pluto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bondhugula/pluto/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/bondhugula/pluto/statuses/d8b9c91e3f36730dfe6fdfb26e38dde4c943e26d"}},"author_association":"NONE"}}
{"actor":{"display_login":"cristianrcv"}}