{"action":"opened","number":48399,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/48399","id":198539039,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTM5MDM5","html_url":"https://github.com/saltstack/salt/pull/48399","diff_url":"https://github.com/saltstack/salt/pull/48399.diff","patch_url":"https://github.com/saltstack/salt/pull/48399.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/48399","number":48399,"state":"open","locked":false,"title":"[2017.7] fixes to module/file.py","user":{"login":"garethgreenaway","id":718525,"node_id":"MDQ6VXNlcjcxODUyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nSetting the mode with setuid or setgid bits in addition to setting the owner and group will force the setuid & setgid bits to reset.  This change ensures that we set the mode after setting the owner & group.\r\n\r\n### What issues does this PR fix or reference?\r\n#48336 \r\n\r\n### Previous Behavior\r\nSetuid and setgid bits were wiped out with the chown action.\r\n\r\n### New Behavior\r\nChown is done last, preserving the chmod actions.\r\n\r\n### Tests written?\r\nYes\r\n\r\n### Commits signed with GPG?\r\nYes\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n","created_at":"2018-07-01T19:34:50Z","updated_at":"2018-07-01T19:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/48399/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/48399/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/48399/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/f894f0ecb82a93b3a1f9b5844b4bbbba72e4e0b2","head":{"label":"garethgreenaway:48336_2017_7_ensure_chmod_setuid_with_chown","ref":"48336_2017_7_ensure_chmod_setuid_with_chown","sha":"f894f0ecb82a93b3a1f9b5844b4bbbba72e4e0b2","user":{"login":"garethgreenaway","id":718525,"node_id":"MDQ6VXNlcjcxODUyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"repo":{"id":29325120,"node_id":"MDEwOlJlcG9zaXRvcnkyOTMyNTEyMA==","name":"salt","full_name":"garethgreenaway/salt","owner":{"login":"garethgreenaway","id":718525,"node_id":"MDQ6VXNlcjcxODUyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethgreenaway/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/garethgreenaway/salt","forks_url":"https://api.github.com/repos/garethgreenaway/salt/forks","keys_url":"https://api.github.com/repos/garethgreenaway/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethgreenaway/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethgreenaway/salt/teams","hooks_url":"https://api.github.com/repos/garethgreenaway/salt/hooks","issue_events_url":"https://api.github.com/repos/garethgreenaway/salt/issues/events{/number}","events_url":"https://api.github.com/repos/garethgreenaway/salt/events","assignees_url":"https://api.github.com/repos/garethgreenaway/salt/assignees{/user}","branches_url":"https://api.github.com/repos/garethgreenaway/salt/branches{/branch}","tags_url":"https://api.github.com/repos/garethgreenaway/salt/tags","blobs_url":"https://api.github.com/repos/garethgreenaway/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethgreenaway/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethgreenaway/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethgreenaway/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethgreenaway/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/garethgreenaway/salt/languages","stargazers_url":"https://api.github.com/repos/garethgreenaway/salt/stargazers","contributors_url":"https://api.github.com/repos/garethgreenaway/salt/contributors","subscribers_url":"https://api.github.com/repos/garethgreenaway/salt/subscribers","subscription_url":"https://api.github.com/repos/garethgreenaway/salt/subscription","commits_url":"https://api.github.com/repos/garethgreenaway/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethgreenaway/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethgreenaway/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethgreenaway/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/garethgreenaway/salt/contents/{+path}","compare_url":"https://api.github.com/repos/garethgreenaway/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethgreenaway/salt/merges","archive_url":"https://api.github.com/repos/garethgreenaway/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethgreenaway/salt/downloads","issues_url":"https://api.github.com/repos/garethgreenaway/salt/issues{/number}","pulls_url":"https://api.github.com/repos/garethgreenaway/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/garethgreenaway/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/garethgreenaway/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethgreenaway/salt/labels{/name}","releases_url":"https://api.github.com/repos/garethgreenaway/salt/releases{/id}","deployments_url":"https://api.github.com/repos/garethgreenaway/salt/deployments","created_at":"2015-01-16T00:28:10Z","updated_at":"2017-12-01T19:20:49Z","pushed_at":"2018-07-01T19:33:21Z","git_url":"git://github.com/garethgreenaway/salt.git","ssh_url":"git@github.com:garethgreenaway/salt.git","clone_url":"https://github.com/garethgreenaway/salt.git","svn_url":"https://github.com/garethgreenaway/salt","homepage":"saltstack.com","size":404407,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"saltstack:2017.7","ref":"2017.7","sha":"7e25f26837f104a81376c926b50386b6f3bc7da5","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-07-01T08:38:12Z","pushed_at":"2018-07-01T19:21:49Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":407247,"stargazers_count":8955,"watchers_count":8955,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4194,"mirror_url":null,"archived":false,"open_issues_count":3156,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4194,"open_issues":3156,"watchers":8955,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48399"},"html":{"href":"https://github.com/saltstack/salt/pull/48399"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/48399"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/48399/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48399/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48399/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/f894f0ecb82a93b3a1f9b5844b4bbbba72e4e0b2"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":47,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"garethgreenaway"}}