{"action":"created","comment":{"url":"https://api.github.com/repos/Crunch-io/scrunch/pulls/comments/211426860","pull_request_review_id":147845630,"id":211426860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQyNjg2MA==","diff_hunk":"@@ -1218,10 +1218,26 @@ def test_edit_alias(self):\n         ds.resource.body['streaming'] = 'no'\n         var = ds['var1_alias']\n         var.edit(alias='test1')\n-        # Reading another variable breaks because `alias` has been removed(0\n-        # from _IMMUTABLE_ATTRIBUTES already. Use .discard()\n         var2 = ds['var2_alias']\n \n+    def test_edit_resolution(self):\n+        variables = {\n+            '001': {\n+                'id': '001',\n+                'alias': 'datetime_var',\n+                'name': 'Datetime Variable',\n+                'type': 'datetime',\n+                'is_subvar': False,\n+                'view': {'rollup_resolution': 'ms'}","path":"scrunch/tests/test_datasets.py","position":16,"original_position":16,"commit_id":"97c376e79bb278115856fadd398e733ec55ff5e5","original_commit_id":"97c376e79bb278115856fadd398e733ec55ff5e5","user":{"login":"jjdelc","id":59393,"node_id":"MDQ6VXNlcjU5Mzkz","avatar_url":"https://avatars3.githubusercontent.com/u/59393?v=4","gravatar_id":"","url":"https://api.github.com/users/jjdelc","html_url":"https://github.com/jjdelc","followers_url":"https://api.github.com/users/jjdelc/followers","following_url":"https://api.github.com/users/jjdelc/following{/other_user}","gists_url":"https://api.github.com/users/jjdelc/gists{/gist_id}","starred_url":"https://api.github.com/users/jjdelc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjdelc/subscriptions","organizations_url":"https://api.github.com/users/jjdelc/orgs","repos_url":"https://api.github.com/users/jjdelc/repos","events_url":"https://api.github.com/users/jjdelc/events{/privacy}","received_events_url":"https://api.github.com/users/jjdelc/received_events","type":"User","site_admin":false},"body":"In order to make the test verify that it's not overwriting other attributes you need to have this initial `view` value contain some other key. And then assert that both keys are indeed still there.","created_at":"2018-08-20T22:26:18Z","updated_at":"2018-08-20T22:26:18Z","html_url":"https://github.com/Crunch-io/scrunch/pull/283#discussion_r211426860","pull_request_url":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Crunch-io/scrunch/pulls/comments/211426860"},"html":{"href":"https://github.com/Crunch-io/scrunch/pull/283#discussion_r211426860"},"pull_request":{"href":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283","id":209530766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTMwNzY2","html_url":"https://github.com/Crunch-io/scrunch/pull/283","diff_url":"https://github.com/Crunch-io/scrunch/pull/283.diff","patch_url":"https://github.com/Crunch-io/scrunch/pull/283.patch","issue_url":"https://api.github.com/repos/Crunch-io/scrunch/issues/283","number":283,"state":"open","locked":false,"title":"closes 282","user":{"login":"mathiasbc","id":1334386,"node_id":"MDQ6VXNlcjEzMzQzODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1334386?v=4","gravatar_id":"","url":"https://api.github.com/users/mathiasbc","html_url":"https://github.com/mathiasbc","followers_url":"https://api.github.com/users/mathiasbc/followers","following_url":"https://api.github.com/users/mathiasbc/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbc/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbc/subscriptions","organizations_url":"https://api.github.com/users/mathiasbc/orgs","repos_url":"https://api.github.com/users/mathiasbc/repos","events_url":"https://api.github.com/users/mathiasbc/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-20T13:59:55Z","updated_at":"2018-08-20T22:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"082fb03ca929a5629cce281c6efda63d5e79c081","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283/commits","review_comments_url":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283/comments","review_comment_url":"https://api.github.com/repos/Crunch-io/scrunch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Crunch-io/scrunch/issues/283/comments","statuses_url":"https://api.github.com/repos/Crunch-io/scrunch/statuses/97c376e79bb278115856fadd398e733ec55ff5e5","head":{"label":"Crunch-io:fix-282/patch-rollup-resolution","ref":"fix-282/patch-rollup-resolution","sha":"97c376e79bb278115856fadd398e733ec55ff5e5","user":{"login":"Crunch-io","id":2966429,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjY0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2966429?v=4","gravatar_id":"","url":"https://api.github.com/users/Crunch-io","html_url":"https://github.com/Crunch-io","followers_url":"https://api.github.com/users/Crunch-io/followers","following_url":"https://api.github.com/users/Crunch-io/following{/other_user}","gists_url":"https://api.github.com/users/Crunch-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Crunch-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crunch-io/subscriptions","organizations_url":"https://api.github.com/users/Crunch-io/orgs","repos_url":"https://api.github.com/users/Crunch-io/repos","events_url":"https://api.github.com/users/Crunch-io/events{/privacy}","received_events_url":"https://api.github.com/users/Crunch-io/received_events","type":"Organization","site_admin":false},"repo":{"id":75415230,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQxNTIzMA==","name":"scrunch","full_name":"Crunch-io/scrunch","owner":{"login":"Crunch-io","id":2966429,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjY0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2966429?v=4","gravatar_id":"","url":"https://api.github.com/users/Crunch-io","html_url":"https://github.com/Crunch-io","followers_url":"https://api.github.com/users/Crunch-io/followers","following_url":"https://api.github.com/users/Crunch-io/following{/other_user}","gists_url":"https://api.github.com/users/Crunch-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Crunch-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crunch-io/subscriptions","organizations_url":"https://api.github.com/users/Crunch-io/orgs","repos_url":"https://api.github.com/users/Crunch-io/repos","events_url":"https://api.github.com/users/Crunch-io/events{/privacy}","received_events_url":"https://api.github.com/users/Crunch-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Crunch-io/scrunch","description":"Pythonic scripting library for cleaning data in Crunch","fork":false,"url":"https://api.github.com/repos/Crunch-io/scrunch","forks_url":"https://api.github.com/repos/Crunch-io/scrunch/forks","keys_url":"https://api.github.com/repos/Crunch-io/scrunch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crunch-io/scrunch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crunch-io/scrunch/teams","hooks_url":"https://api.github.com/repos/Crunch-io/scrunch/hooks","issue_events_url":"https://api.github.com/repos/Crunch-io/scrunch/issues/events{/number}","events_url":"https://api.github.com/repos/Crunch-io/scrunch/events","assignees_url":"https://api.github.com/repos/Crunch-io/scrunch/assignees{/user}","branches_url":"https://api.github.com/repos/Crunch-io/scrunch/branches{/branch}","tags_url":"https://api.github.com/repos/Crunch-io/scrunch/tags","blobs_url":"https://api.github.com/repos/Crunch-io/scrunch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crunch-io/scrunch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crunch-io/scrunch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crunch-io/scrunch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crunch-io/scrunch/statuses/{sha}","languages_url":"https://api.github.com/repos/Crunch-io/scrunch/languages","stargazers_url":"https://api.github.com/repos/Crunch-io/scrunch/stargazers","contributors_url":"https://api.github.com/repos/Crunch-io/scrunch/contributors","subscribers_url":"https://api.github.com/repos/Crunch-io/scrunch/subscribers","subscription_url":"https://api.github.com/repos/Crunch-io/scrunch/subscription","commits_url":"https://api.github.com/repos/Crunch-io/scrunch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crunch-io/scrunch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crunch-io/scrunch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crunch-io/scrunch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crunch-io/scrunch/contents/{+path}","compare_url":"https://api.github.com/repos/Crunch-io/scrunch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crunch-io/scrunch/merges","archive_url":"https://api.github.com/repos/Crunch-io/scrunch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crunch-io/scrunch/downloads","issues_url":"https://api.github.com/repos/Crunch-io/scrunch/issues{/number}","pulls_url":"https://api.github.com/repos/Crunch-io/scrunch/pulls{/number}","milestones_url":"https://api.github.com/repos/Crunch-io/scrunch/milestones{/number}","notifications_url":"https://api.github.com/repos/Crunch-io/scrunch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crunch-io/scrunch/labels{/name}","releases_url":"https://api.github.com/repos/Crunch-io/scrunch/releases{/id}","deployments_url":"https://api.github.com/repos/Crunch-io/scrunch/deployments","created_at":"2016-12-02T17:09:20Z","updated_at":"2018-08-17T17:45:52Z","pushed_at":"2018-08-20T20:10:37Z","git_url":"git://github.com/Crunch-io/scrunch.git","ssh_url":"git@github.com:Crunch-io/scrunch.git","clone_url":"https://github.com/Crunch-io/scrunch.git","svn_url":"https://github.com/Crunch-io/scrunch","homepage":null,"size":1563,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":26,"watchers":2,"default_branch":"master"}},"base":{"label":"Crunch-io:master","ref":"master","sha":"9639edd203509d8514a8443c56cb876a91d4356e","user":{"login":"Crunch-io","id":2966429,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjY0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2966429?v=4","gravatar_id":"","url":"https://api.github.com/users/Crunch-io","html_url":"https://github.com/Crunch-io","followers_url":"https://api.github.com/users/Crunch-io/followers","following_url":"https://api.github.com/users/Crunch-io/following{/other_user}","gists_url":"https://api.github.com/users/Crunch-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Crunch-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crunch-io/subscriptions","organizations_url":"https://api.github.com/users/Crunch-io/orgs","repos_url":"https://api.github.com/users/Crunch-io/repos","events_url":"https://api.github.com/users/Crunch-io/events{/privacy}","received_events_url":"https://api.github.com/users/Crunch-io/received_events","type":"Organization","site_admin":false},"repo":{"id":75415230,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQxNTIzMA==","name":"scrunch","full_name":"Crunch-io/scrunch","owner":{"login":"Crunch-io","id":2966429,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjY0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2966429?v=4","gravatar_id":"","url":"https://api.github.com/users/Crunch-io","html_url":"https://github.com/Crunch-io","followers_url":"https://api.github.com/users/Crunch-io/followers","following_url":"https://api.github.com/users/Crunch-io/following{/other_user}","gists_url":"https://api.github.com/users/Crunch-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Crunch-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crunch-io/subscriptions","organizations_url":"https://api.github.com/users/Crunch-io/orgs","repos_url":"https://api.github.com/users/Crunch-io/repos","events_url":"https://api.github.com/users/Crunch-io/events{/privacy}","received_events_url":"https://api.github.com/users/Crunch-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Crunch-io/scrunch","description":"Pythonic scripting library for cleaning data in Crunch","fork":false,"url":"https://api.github.com/repos/Crunch-io/scrunch","forks_url":"https://api.github.com/repos/Crunch-io/scrunch/forks","keys_url":"https://api.github.com/repos/Crunch-io/scrunch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crunch-io/scrunch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crunch-io/scrunch/teams","hooks_url":"https://api.github.com/repos/Crunch-io/scrunch/hooks","issue_events_url":"https://api.github.com/repos/Crunch-io/scrunch/issues/events{/number}","events_url":"https://api.github.com/repos/Crunch-io/scrunch/events","assignees_url":"https://api.github.com/repos/Crunch-io/scrunch/assignees{/user}","branches_url":"https://api.github.com/repos/Crunch-io/scrunch/branches{/branch}","tags_url":"https://api.github.com/repos/Crunch-io/scrunch/tags","blobs_url":"https://api.github.com/repos/Crunch-io/scrunch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crunch-io/scrunch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crunch-io/scrunch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crunch-io/scrunch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crunch-io/scrunch/statuses/{sha}","languages_url":"https://api.github.com/repos/Crunch-io/scrunch/languages","stargazers_url":"https://api.github.com/repos/Crunch-io/scrunch/stargazers","contributors_url":"https://api.github.com/repos/Crunch-io/scrunch/contributors","subscribers_url":"https://api.github.com/repos/Crunch-io/scrunch/subscribers","subscription_url":"https://api.github.com/repos/Crunch-io/scrunch/subscription","commits_url":"https://api.github.com/repos/Crunch-io/scrunch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crunch-io/scrunch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crunch-io/scrunch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crunch-io/scrunch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crunch-io/scrunch/contents/{+path}","compare_url":"https://api.github.com/repos/Crunch-io/scrunch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crunch-io/scrunch/merges","archive_url":"https://api.github.com/repos/Crunch-io/scrunch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crunch-io/scrunch/downloads","issues_url":"https://api.github.com/repos/Crunch-io/scrunch/issues{/number}","pulls_url":"https://api.github.com/repos/Crunch-io/scrunch/pulls{/number}","milestones_url":"https://api.github.com/repos/Crunch-io/scrunch/milestones{/number}","notifications_url":"https://api.github.com/repos/Crunch-io/scrunch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crunch-io/scrunch/labels{/name}","releases_url":"https://api.github.com/repos/Crunch-io/scrunch/releases{/id}","deployments_url":"https://api.github.com/repos/Crunch-io/scrunch/deployments","created_at":"2016-12-02T17:09:20Z","updated_at":"2018-08-17T17:45:52Z","pushed_at":"2018-08-20T20:10:37Z","git_url":"git://github.com/Crunch-io/scrunch.git","ssh_url":"git@github.com:Crunch-io/scrunch.git","clone_url":"https://github.com/Crunch-io/scrunch.git","svn_url":"https://github.com/Crunch-io/scrunch","homepage":null,"size":1563,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":26,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283"},"html":{"href":"https://github.com/Crunch-io/scrunch/pull/283"},"issue":{"href":"https://api.github.com/repos/Crunch-io/scrunch/issues/283"},"comments":{"href":"https://api.github.com/repos/Crunch-io/scrunch/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/Crunch-io/scrunch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Crunch-io/scrunch/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/Crunch-io/scrunch/statuses/97c376e79bb278115856fadd398e733ec55ff5e5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jjdelc"}}