{"action":"created","comment":{"url":"https://api.github.com/repos/magento/magento2/pulls/comments/229909703","pull_request_review_id":170520497,"id":229909703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTkwOTcwMw==","diff_hunk":"@@ -13,26 +13,57 @@\n  */\n class Amqp\n {\n+    const CONFIG_PATH_QUEUE_AMQP_HOST = 'queue/amqp/host';\n+    const CONFIG_PATH_QUEUE_AMQP_USER = 'queue/amqp/user';\n+    const CONFIG_PATH_QUEUE_AMQP_PASSWORD = 'queue/amqp/password';\n+\n     /**\n      * @var Curl\n      */\n     private $curl;\n \n+    /**\n+     * @var \\Magento\\Framework\\App\\DeploymentConfig\n+     */\n+    private $deploymentConfig;\n+\n     /**\n      * RabbitMQ API host\n      *\n      * @var string\n      */\n-    private $host = 'http://localhost:15672/api/';\n+    private $host;\n \n     /**\n      * Initialize dependencies.\n+     * @param \\Magento\\Framework\\App\\DeploymentConfig $deploymentConfig\n      */\n-    public function __construct()\n-    {\n+    public function __construct(\n+        \\Magento\\Framework\\App\\DeploymentConfig $deploymentConfig\n+    ) {\n+        $this->deploymentConfig = $deploymentConfig;\n         $this->curl = new Curl();\n-        $this->curl->setCredentials('guest', 'guest');\n+        $this->curl->setCredentials(\n+            $this->deploymentConfig->get(self::CONFIG_PATH_QUEUE_AMQP_USER),\n+            $this->deploymentConfig->get(self::CONFIG_PATH_QUEUE_AMQP_PASSWORD)\n+        );\n         $this->curl->addHeader('content-type', 'application/json');\n+        $this->host = sprintf('http://%s:15672/api/', $this->deploymentConfig->get(self::CONFIG_PATH_QUEUE_AMQP_HOST));\n+    }\n+\n+    /**\n+     * Check that the rabbitmq instance has the management plugin installed and the api","path":"dev/tests/integration/framework/Magento/TestFramework/Helper/Amqp.php","position":47,"original_position":47,"commit_id":"7fe0f56627ff2a5378ee0a678810e50acba0ff51","original_commit_id":"7fe0f56627ff2a5378ee0a678810e50acba0ff51","user":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"body":"`RabbitMQ` please","created_at":"2018-11-01T00:34:05Z","updated_at":"2018-11-01T00:41:33Z","html_url":"https://github.com/magento/magento2/pull/18978#discussion_r229909703","pull_request_url":"https://api.github.com/repos/magento/magento2/pulls/18978","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments/229909703"},"html":{"href":"https://github.com/magento/magento2/pull/18978#discussion_r229909703"},"pull_request":{"href":"https://api.github.com/repos/magento/magento2/pulls/18978"}}},"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18978","id":227408131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDA4MTMx","html_url":"https://github.com/magento/magento2/pull/18978","diff_url":"https://github.com/magento/magento2/pull/18978.diff","patch_url":"https://github.com/magento/magento2/pull/18978.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/18978","number":18978,"state":"open","locked":false,"title":"Integration Test Framework AMQP Helper Flexibility","user":{"login":"pmclain","id":12674247,"node_id":"MDQ6VXNlcjEyNjc0MjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12674247?v=4","gravatar_id":"","url":"https://api.github.com/users/pmclain","html_url":"https://github.com/pmclain","followers_url":"https://api.github.com/users/pmclain/followers","following_url":"https://api.github.com/users/pmclain/following{/other_user}","gists_url":"https://api.github.com/users/pmclain/gists{/gist_id}","starred_url":"https://api.github.com/users/pmclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmclain/subscriptions","organizations_url":"https://api.github.com/users/pmclain/orgs","repos_url":"https://api.github.com/users/pmclain/repos","events_url":"https://api.github.com/users/pmclain/events{/privacy}","received_events_url":"https://api.github.com/users/pmclain/received_events","type":"User","site_admin":false},"body":"### Description (*)\r\n* Update AMQP helper to use host, username, and password configuration from the instance under test. This allows tests to run when the AMQP service is not using default credentials or available on localhost.\r\n* Mark tests skipped when the RabbitMQ management plugin is not available.\r\n* Unset exchange response property added in v3.7.0 of the management plugin. This allows integration tests to be run beyond the v3.6.x version currently used by Travis.\r\n\r\n### Fixed Issues (if relevant)\r\n1. magento/magento2#18953 Integration Test AMQP Helper Hardcoded Host\r\n\r\n### Manual testing scenarios (*)\r\n#### Scenario 1\r\n1. Install RabbitMQ anywhere other than `localhost`\r\n2. Create `dev/tests/integration/etc/install-config-mysql.php` with correct AMQP configuration\r\n3. Execute Integration tests\r\n4. Expect tests to pass\r\n\r\n#### Scenario 2\r\n1. Install RabbitMQ without management plugin\r\n3. Execute Integration tests\r\n4. Expect tests depending on the management plugin are skipped\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-10-31T19:06:14Z","updated_at":"2018-11-01T00:41:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e2b92d22d8a0184b4d35fd51018c750dedafcf5","assignee":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"assignees":[{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":903623678,"node_id":"MDU6TGFiZWw5MDM2MjM2Nzg=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Something%20Digital","name":"Partner: Something Digital","color":"f9d0c4","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/18978/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/18978/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18978/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/7fe0f56627ff2a5378ee0a678810e50acba0ff51","head":{"label":"pmclain:issue/18953","ref":"issue/18953","sha":"7fe0f56627ff2a5378ee0a678810e50acba0ff51","user":{"login":"pmclain","id":12674247,"node_id":"MDQ6VXNlcjEyNjc0MjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12674247?v=4","gravatar_id":"","url":"https://api.github.com/users/pmclain","html_url":"https://github.com/pmclain","followers_url":"https://api.github.com/users/pmclain/followers","following_url":"https://api.github.com/users/pmclain/following{/other_user}","gists_url":"https://api.github.com/users/pmclain/gists{/gist_id}","starred_url":"https://api.github.com/users/pmclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmclain/subscriptions","organizations_url":"https://api.github.com/users/pmclain/orgs","repos_url":"https://api.github.com/users/pmclain/repos","events_url":"https://api.github.com/users/pmclain/events{/privacy}","received_events_url":"https://api.github.com/users/pmclain/received_events","type":"User","site_admin":false},"repo":{"id":110693618,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2OTM2MTg=","name":"magento2","full_name":"pmclain/magento2","private":false,"owner":{"login":"pmclain","id":12674247,"node_id":"MDQ6VXNlcjEyNjc0MjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12674247?v=4","gravatar_id":"","url":"https://api.github.com/users/pmclain","html_url":"https://github.com/pmclain","followers_url":"https://api.github.com/users/pmclain/followers","following_url":"https://api.github.com/users/pmclain/following{/other_user}","gists_url":"https://api.github.com/users/pmclain/gists{/gist_id}","starred_url":"https://api.github.com/users/pmclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmclain/subscriptions","organizations_url":"https://api.github.com/users/pmclain/orgs","repos_url":"https://api.github.com/users/pmclain/repos","events_url":"https://api.github.com/users/pmclain/events{/privacy}","received_events_url":"https://api.github.com/users/pmclain/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmclain/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/pmclain/magento2","forks_url":"https://api.github.com/repos/pmclain/magento2/forks","keys_url":"https://api.github.com/repos/pmclain/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmclain/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmclain/magento2/teams","hooks_url":"https://api.github.com/repos/pmclain/magento2/hooks","issue_events_url":"https://api.github.com/repos/pmclain/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/pmclain/magento2/events","assignees_url":"https://api.github.com/repos/pmclain/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/pmclain/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/pmclain/magento2/tags","blobs_url":"https://api.github.com/repos/pmclain/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmclain/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmclain/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmclain/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmclain/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/pmclain/magento2/languages","stargazers_url":"https://api.github.com/repos/pmclain/magento2/stargazers","contributors_url":"https://api.github.com/repos/pmclain/magento2/contributors","subscribers_url":"https://api.github.com/repos/pmclain/magento2/subscribers","subscription_url":"https://api.github.com/repos/pmclain/magento2/subscription","commits_url":"https://api.github.com/repos/pmclain/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmclain/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmclain/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmclain/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmclain/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/pmclain/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmclain/magento2/merges","archive_url":"https://api.github.com/repos/pmclain/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmclain/magento2/downloads","issues_url":"https://api.github.com/repos/pmclain/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/pmclain/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/pmclain/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/pmclain/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmclain/magento2/labels{/name}","releases_url":"https://api.github.com/repos/pmclain/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/pmclain/magento2/deployments","created_at":"2017-11-14T13:26:56Z","updated_at":"2017-11-14T13:27:57Z","pushed_at":"2018-11-01T00:19:17Z","git_url":"git://github.com/pmclain/magento2.git","ssh_url":"git@github.com:pmclain/magento2.git","clone_url":"https://github.com/pmclain/magento2.git","svn_url":"https://github.com/pmclain/magento2","homepage":"http://www.magento.com","size":467240,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"ec5fcb50c266f561ba148bf0eb0ce3748df8265b","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-10-31T20:11:27Z","pushed_at":"2018-10-31T22:42:40Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":489450,"stargazers_count":6278,"watchers_count":6278,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5484,"mirror_url":null,"archived":false,"open_issues_count":1398,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5484,"open_issues":1398,"watchers":6278,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/18978"},"html":{"href":"https://github.com/magento/magento2/pull/18978"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/18978"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/18978/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/18978/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/18978/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/7fe0f56627ff2a5378ee0a678810e50acba0ff51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"orlangur"}}