{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/vtcomposite/pulls/comments/190114530","pull_request_review_id":122423551,"id":190114530,"diff_hunk":"@@ -6,6 +6,16 @@ var zlib = require('zlib');\n var mvtFixtures = require('@mapbox/mvt-fixtures');\n var vt = require('@mapbox/vector-tile').VectorTile;\n var pbf = require('pbf');\n+var geoData = require('./fixtures/four-points.js');\n+\n+\n+function long2tile(lon,zoom) { ","path":"test/vtcomposite.test.js","position":7,"original_position":7,"commit_id":"3ef8a80801f9790671d8bd3fa0215acb94c1d40f","original_commit_id":"3ef8a80801f9790671d8bd3fa0215acb94c1d40f","user":{"login":"mapsam","id":1943001,"avatar_url":"https://avatars2.githubusercontent.com/u/1943001?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsam","html_url":"https://github.com/mapsam","followers_url":"https://api.github.com/users/mapsam/followers","following_url":"https://api.github.com/users/mapsam/following{/other_user}","gists_url":"https://api.github.com/users/mapsam/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsam/subscriptions","organizations_url":"https://api.github.com/users/mapsam/orgs","repos_url":"https://api.github.com/users/mapsam/repos","events_url":"https://api.github.com/users/mapsam/events{/privacy}","received_events_url":"https://api.github.com/users/mapsam/received_events","type":"User","site_admin":false},"body":"@millzpaugh [sphericalmercator](https://github.com/mapbox/sphericalmercator#pxll-zoom) might have functions that'll do this for you!","created_at":"2018-05-23T03:38:08Z","updated_at":"2018-05-23T03:38:08Z","html_url":"https://github.com/mapbox/vtcomposite/pull/27#discussion_r190114530","pull_request_url":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/vtcomposite/pulls/comments/190114530"},"html":{"href":"https://github.com/mapbox/vtcomposite/pull/27#discussion_r190114530"},"pull_request":{"href":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27","id":189818084,"html_url":"https://github.com/mapbox/vtcomposite/pull/27","diff_url":"https://github.com/mapbox/vtcomposite/pull/27.diff","patch_url":"https://github.com/mapbox/vtcomposite/pull/27.patch","issue_url":"https://api.github.com/repos/mapbox/vtcomposite/issues/27","number":27,"state":"open","locked":false,"title":"[WIP don't merge] adding more tests","user":{"login":"millzpaugh","id":4648295,"avatar_url":"https://avatars2.githubusercontent.com/u/4648295?v=4","gravatar_id":"","url":"https://api.github.com/users/millzpaugh","html_url":"https://github.com/millzpaugh","followers_url":"https://api.github.com/users/millzpaugh/followers","following_url":"https://api.github.com/users/millzpaugh/following{/other_user}","gists_url":"https://api.github.com/users/millzpaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/millzpaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millzpaugh/subscriptions","organizations_url":"https://api.github.com/users/millzpaugh/orgs","repos_url":"https://api.github.com/users/millzpaugh/repos","events_url":"https://api.github.com/users/millzpaugh/events{/privacy}","received_events_url":"https://api.github.com/users/millzpaugh/received_events","type":"User","site_admin":false},"body":"This PR: \r\n- uses the correct formula to check overzooming calculation, as defined via OSM: https://wiki.openstreetmap.org/wiki/Slippy_map_tilenames\r\n- adds overzooming tests for all geometries \r\n\r\nAddresses #28 \r\n\r\ncc @artemp @mapsam \r\n","created_at":"2018-05-22T23:20:04Z","updated_at":"2018-05-23T03:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08b3b337bb56b672921caf201a4c16e63a4585e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27/commits","review_comments_url":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27/comments","review_comment_url":"https://api.github.com/repos/mapbox/vtcomposite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/vtcomposite/issues/27/comments","statuses_url":"https://api.github.com/repos/mapbox/vtcomposite/statuses/3ef8a80801f9790671d8bd3fa0215acb94c1d40f","head":{"label":"mapbox:adds_more_tests","ref":"adds_more_tests","sha":"3ef8a80801f9790671d8bd3fa0215acb94c1d40f","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":131032537,"name":"vtcomposite","full_name":"mapbox/vtcomposite","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/vtcomposite","description":"vtzero-based vector tile compositor (supporting overzooming)","fork":false,"url":"https://api.github.com/repos/mapbox/vtcomposite","forks_url":"https://api.github.com/repos/mapbox/vtcomposite/forks","keys_url":"https://api.github.com/repos/mapbox/vtcomposite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/vtcomposite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/vtcomposite/teams","hooks_url":"https://api.github.com/repos/mapbox/vtcomposite/hooks","issue_events_url":"https://api.github.com/repos/mapbox/vtcomposite/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/vtcomposite/events","assignees_url":"https://api.github.com/repos/mapbox/vtcomposite/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/vtcomposite/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/vtcomposite/tags","blobs_url":"https://api.github.com/repos/mapbox/vtcomposite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/vtcomposite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/vtcomposite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/vtcomposite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/vtcomposite/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/vtcomposite/languages","stargazers_url":"https://api.github.com/repos/mapbox/vtcomposite/stargazers","contributors_url":"https://api.github.com/repos/mapbox/vtcomposite/contributors","subscribers_url":"https://api.github.com/repos/mapbox/vtcomposite/subscribers","subscription_url":"https://api.github.com/repos/mapbox/vtcomposite/subscription","commits_url":"https://api.github.com/repos/mapbox/vtcomposite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/vtcomposite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/vtcomposite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/vtcomposite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/vtcomposite/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/vtcomposite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/vtcomposite/merges","archive_url":"https://api.github.com/repos/mapbox/vtcomposite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/vtcomposite/downloads","issues_url":"https://api.github.com/repos/mapbox/vtcomposite/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/vtcomposite/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/vtcomposite/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/vtcomposite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/vtcomposite/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/vtcomposite/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/vtcomposite/deployments","created_at":"2018-04-25T16:11:45Z","updated_at":"2018-05-22T15:07:23Z","pushed_at":"2018-05-22T23:20:05Z","git_url":"git://github.com/mapbox/vtcomposite.git","ssh_url":"git@github.com:mapbox/vtcomposite.git","clone_url":"https://github.com/mapbox/vtcomposite.git","svn_url":"https://github.com/mapbox/vtcomposite","homepage":null,"size":265,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":0,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"7103231ae30cd5139399547c5d0945fd6e97b7cd","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":131032537,"name":"vtcomposite","full_name":"mapbox/vtcomposite","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/vtcomposite","description":"vtzero-based vector tile compositor (supporting overzooming)","fork":false,"url":"https://api.github.com/repos/mapbox/vtcomposite","forks_url":"https://api.github.com/repos/mapbox/vtcomposite/forks","keys_url":"https://api.github.com/repos/mapbox/vtcomposite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/vtcomposite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/vtcomposite/teams","hooks_url":"https://api.github.com/repos/mapbox/vtcomposite/hooks","issue_events_url":"https://api.github.com/repos/mapbox/vtcomposite/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/vtcomposite/events","assignees_url":"https://api.github.com/repos/mapbox/vtcomposite/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/vtcomposite/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/vtcomposite/tags","blobs_url":"https://api.github.com/repos/mapbox/vtcomposite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/vtcomposite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/vtcomposite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/vtcomposite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/vtcomposite/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/vtcomposite/languages","stargazers_url":"https://api.github.com/repos/mapbox/vtcomposite/stargazers","contributors_url":"https://api.github.com/repos/mapbox/vtcomposite/contributors","subscribers_url":"https://api.github.com/repos/mapbox/vtcomposite/subscribers","subscription_url":"https://api.github.com/repos/mapbox/vtcomposite/subscription","commits_url":"https://api.github.com/repos/mapbox/vtcomposite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/vtcomposite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/vtcomposite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/vtcomposite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/vtcomposite/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/vtcomposite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/vtcomposite/merges","archive_url":"https://api.github.com/repos/mapbox/vtcomposite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/vtcomposite/downloads","issues_url":"https://api.github.com/repos/mapbox/vtcomposite/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/vtcomposite/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/vtcomposite/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/vtcomposite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/vtcomposite/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/vtcomposite/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/vtcomposite/deployments","created_at":"2018-04-25T16:11:45Z","updated_at":"2018-05-22T15:07:23Z","pushed_at":"2018-05-22T23:20:05Z","git_url":"git://github.com/mapbox/vtcomposite.git","ssh_url":"git@github.com:mapbox/vtcomposite.git","clone_url":"https://github.com/mapbox/vtcomposite.git","svn_url":"https://github.com/mapbox/vtcomposite","homepage":null,"size":265,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":0,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27"},"html":{"href":"https://github.com/mapbox/vtcomposite/pull/27"},"issue":{"href":"https://api.github.com/repos/mapbox/vtcomposite/issues/27"},"comments":{"href":"https://api.github.com/repos/mapbox/vtcomposite/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/vtcomposite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/vtcomposite/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/vtcomposite/statuses/3ef8a80801f9790671d8bd3fa0215acb94c1d40f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mapsam"}}