{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/jasper/pulls/comments/218987134","pull_request_review_id":157050737,"id":218987134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk4NzEzNA==","diff_hunk":"@@ -5,6 +5,25 @@ option go_package = \"internal\";\n \n import \"google/protobuf/empty.proto\";\n \n+message Logger {\n+    LogType log_type = 1;\n+}\n+\n+message OutputOptions {\n+  repeated Logger loggers = 1;\n+}","path":"jasper.proto","position":null,"original_position":10,"commit_id":"c061fcbb31b3548b6fe7a1b7bc237923fa4822c2","original_commit_id":"147b3b503df9801de6e0794a2352a29a530f6c10","user":{"login":"Kimchelly","id":8785663,"node_id":"MDQ6VXNlcjg3ODU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8785663?v=4","gravatar_id":"","url":"https://api.github.com/users/Kimchelly","html_url":"https://github.com/Kimchelly","followers_url":"https://api.github.com/users/Kimchelly/followers","following_url":"https://api.github.com/users/Kimchelly/following{/other_user}","gists_url":"https://api.github.com/users/Kimchelly/gists{/gist_id}","starred_url":"https://api.github.com/users/Kimchelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kimchelly/subscriptions","organizations_url":"https://api.github.com/users/Kimchelly/orgs","repos_url":"https://api.github.com/users/Kimchelly/repos","events_url":"https://api.github.com/users/Kimchelly/events{/privacy}","received_events_url":"https://api.github.com/users/Kimchelly/received_events","type":"User","site_admin":false},"body":"I added the other options. Should the LogOptions also be exported?","created_at":"2018-09-19T22:41:49Z","updated_at":"2018-09-19T22:41:49Z","html_url":"https://github.com/mongodb/jasper/pull/2#discussion_r218987134","pull_request_url":"https://api.github.com/repos/mongodb/jasper/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mongodb/jasper/pulls/comments/218987134"},"html":{"href":"https://github.com/mongodb/jasper/pull/2#discussion_r218987134"},"pull_request":{"href":"https://api.github.com/repos/mongodb/jasper/pulls/2"}},"in_reply_to_id":218960903},"pull_request":{"url":"https://api.github.com/repos/mongodb/jasper/pulls/2","id":216103550,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTAzNTUw","html_url":"https://github.com/mongodb/jasper/pull/2","diff_url":"https://github.com/mongodb/jasper/pull/2.diff","patch_url":"https://github.com/mongodb/jasper/pull/2.patch","issue_url":"https://api.github.com/repos/mongodb/jasper/issues/2","number":2,"state":"open","locked":false,"title":"Add logging to different endpoints","user":{"login":"Kimchelly","id":8785663,"node_id":"MDQ6VXNlcjg3ODU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8785663?v=4","gravatar_id":"","url":"https://api.github.com/users/Kimchelly","html_url":"https://github.com/Kimchelly","followers_url":"https://api.github.com/users/Kimchelly/followers","following_url":"https://api.github.com/users/Kimchelly/following{/other_user}","gists_url":"https://api.github.com/users/Kimchelly/gists{/gist_id}","starred_url":"https://api.github.com/users/Kimchelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kimchelly/subscriptions","organizations_url":"https://api.github.com/users/Kimchelly/orgs","repos_url":"https://api.github.com/users/Kimchelly/repos","events_url":"https://api.github.com/users/Kimchelly/events{/privacy}","received_events_url":"https://api.github.com/users/Kimchelly/received_events","type":"User","site_admin":false},"body":"* Can log to different endpoints\r\n* Can configure whether logger reads from stdout and stderr\r\n* Validate() check that output/error redirects aren't cyclical","created_at":"2018-09-17T20:23:28Z","updated_at":"2018-09-19T22:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e702e0b91ca48b3cd4eb26d8b922873ca21efa43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/jasper/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mongodb/jasper/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mongodb/jasper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/jasper/issues/2/comments","statuses_url":"https://api.github.com/repos/mongodb/jasper/statuses/c061fcbb31b3548b6fe7a1b7bc237923fa4822c2","head":{"label":"Kimchelly:logging","ref":"logging","sha":"c061fcbb31b3548b6fe7a1b7bc237923fa4822c2","user":{"login":"Kimchelly","id":8785663,"node_id":"MDQ6VXNlcjg3ODU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8785663?v=4","gravatar_id":"","url":"https://api.github.com/users/Kimchelly","html_url":"https://github.com/Kimchelly","followers_url":"https://api.github.com/users/Kimchelly/followers","following_url":"https://api.github.com/users/Kimchelly/following{/other_user}","gists_url":"https://api.github.com/users/Kimchelly/gists{/gist_id}","starred_url":"https://api.github.com/users/Kimchelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kimchelly/subscriptions","organizations_url":"https://api.github.com/users/Kimchelly/orgs","repos_url":"https://api.github.com/users/Kimchelly/repos","events_url":"https://api.github.com/users/Kimchelly/events{/privacy}","received_events_url":"https://api.github.com/users/Kimchelly/received_events","type":"User","site_admin":false},"repo":{"id":147695423,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2OTU0MjM=","name":"jasper","full_name":"Kimchelly/jasper","private":false,"owner":{"login":"Kimchelly","id":8785663,"node_id":"MDQ6VXNlcjg3ODU2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8785663?v=4","gravatar_id":"","url":"https://api.github.com/users/Kimchelly","html_url":"https://github.com/Kimchelly","followers_url":"https://api.github.com/users/Kimchelly/followers","following_url":"https://api.github.com/users/Kimchelly/following{/other_user}","gists_url":"https://api.github.com/users/Kimchelly/gists{/gist_id}","starred_url":"https://api.github.com/users/Kimchelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kimchelly/subscriptions","organizations_url":"https://api.github.com/users/Kimchelly/orgs","repos_url":"https://api.github.com/users/Kimchelly/repos","events_url":"https://api.github.com/users/Kimchelly/events{/privacy}","received_events_url":"https://api.github.com/users/Kimchelly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kimchelly/jasper","description":"Jasper is a Process Management Framework","fork":true,"url":"https://api.github.com/repos/Kimchelly/jasper","forks_url":"https://api.github.com/repos/Kimchelly/jasper/forks","keys_url":"https://api.github.com/repos/Kimchelly/jasper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kimchelly/jasper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kimchelly/jasper/teams","hooks_url":"https://api.github.com/repos/Kimchelly/jasper/hooks","issue_events_url":"https://api.github.com/repos/Kimchelly/jasper/issues/events{/number}","events_url":"https://api.github.com/repos/Kimchelly/jasper/events","assignees_url":"https://api.github.com/repos/Kimchelly/jasper/assignees{/user}","branches_url":"https://api.github.com/repos/Kimchelly/jasper/branches{/branch}","tags_url":"https://api.github.com/repos/Kimchelly/jasper/tags","blobs_url":"https://api.github.com/repos/Kimchelly/jasper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kimchelly/jasper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kimchelly/jasper/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kimchelly/jasper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kimchelly/jasper/statuses/{sha}","languages_url":"https://api.github.com/repos/Kimchelly/jasper/languages","stargazers_url":"https://api.github.com/repos/Kimchelly/jasper/stargazers","contributors_url":"https://api.github.com/repos/Kimchelly/jasper/contributors","subscribers_url":"https://api.github.com/repos/Kimchelly/jasper/subscribers","subscription_url":"https://api.github.com/repos/Kimchelly/jasper/subscription","commits_url":"https://api.github.com/repos/Kimchelly/jasper/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kimchelly/jasper/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kimchelly/jasper/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kimchelly/jasper/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kimchelly/jasper/contents/{+path}","compare_url":"https://api.github.com/repos/Kimchelly/jasper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kimchelly/jasper/merges","archive_url":"https://api.github.com/repos/Kimchelly/jasper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kimchelly/jasper/downloads","issues_url":"https://api.github.com/repos/Kimchelly/jasper/issues{/number}","pulls_url":"https://api.github.com/repos/Kimchelly/jasper/pulls{/number}","milestones_url":"https://api.github.com/repos/Kimchelly/jasper/milestones{/number}","notifications_url":"https://api.github.com/repos/Kimchelly/jasper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kimchelly/jasper/labels{/name}","releases_url":"https://api.github.com/repos/Kimchelly/jasper/releases{/id}","deployments_url":"https://api.github.com/repos/Kimchelly/jasper/deployments","created_at":"2018-09-06T15:34:02Z","updated_at":"2018-09-19T16:26:44Z","pushed_at":"2018-09-19T22:40:38Z","git_url":"git://github.com/Kimchelly/jasper.git","ssh_url":"git@github.com:Kimchelly/jasper.git","clone_url":"https://github.com/Kimchelly/jasper.git","svn_url":"https://github.com/Kimchelly/jasper","homepage":"","size":17637,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"728b1886606d2174408b1ff82efe6a2ea0fb2445","user":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":143887688,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4ODc2ODg=","name":"jasper","full_name":"mongodb/jasper","private":false,"owner":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mongodb/jasper","description":"Jasper is a Process Management Framework","fork":false,"url":"https://api.github.com/repos/mongodb/jasper","forks_url":"https://api.github.com/repos/mongodb/jasper/forks","keys_url":"https://api.github.com/repos/mongodb/jasper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/jasper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/jasper/teams","hooks_url":"https://api.github.com/repos/mongodb/jasper/hooks","issue_events_url":"https://api.github.com/repos/mongodb/jasper/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/jasper/events","assignees_url":"https://api.github.com/repos/mongodb/jasper/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/jasper/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/jasper/tags","blobs_url":"https://api.github.com/repos/mongodb/jasper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/jasper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/jasper/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/jasper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/jasper/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/jasper/languages","stargazers_url":"https://api.github.com/repos/mongodb/jasper/stargazers","contributors_url":"https://api.github.com/repos/mongodb/jasper/contributors","subscribers_url":"https://api.github.com/repos/mongodb/jasper/subscribers","subscription_url":"https://api.github.com/repos/mongodb/jasper/subscription","commits_url":"https://api.github.com/repos/mongodb/jasper/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/jasper/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/jasper/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/jasper/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/jasper/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/jasper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/jasper/merges","archive_url":"https://api.github.com/repos/mongodb/jasper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/jasper/downloads","issues_url":"https://api.github.com/repos/mongodb/jasper/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/jasper/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/jasper/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/jasper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/jasper/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/jasper/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/jasper/deployments","created_at":"2018-08-07T14:47:40Z","updated_at":"2018-09-11T20:34:35Z","pushed_at":"2018-09-19T22:40:39Z","git_url":"git://github.com/mongodb/jasper.git","ssh_url":"git@github.com:mongodb/jasper.git","clone_url":"https://github.com/mongodb/jasper.git","svn_url":"https://github.com/mongodb/jasper","homepage":"","size":18181,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/jasper/pulls/2"},"html":{"href":"https://github.com/mongodb/jasper/pull/2"},"issue":{"href":"https://api.github.com/repos/mongodb/jasper/issues/2"},"comments":{"href":"https://api.github.com/repos/mongodb/jasper/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/jasper/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/jasper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/jasper/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/jasper/statuses/c061fcbb31b3548b6fe7a1b7bc237923fa4822c2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Kimchelly"}}