{"action":"opened","number":7730,"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/7730","id":184776202,"html_url":"https://github.com/google/ggrc-core/pull/7730","diff_url":"https://github.com/google/ggrc-core/pull/7730.diff","patch_url":"https://github.com/google/ggrc-core/pull/7730.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/7730","number":7730,"state":"open","locked":false,"title":"GGRC-4767 Check if it is audit page before redirect after Assessment Template creation","user":{"login":"Klim711","id":10946494,"avatar_url":"https://avatars1.githubusercontent.com/u/10946494?v=4","gravatar_id":"","url":"https://api.github.com/users/Klim711","html_url":"https://github.com/Klim711","followers_url":"https://api.github.com/users/Klim711/followers","following_url":"https://api.github.com/users/Klim711/following{/other_user}","gists_url":"https://api.github.com/users/Klim711/gists{/gist_id}","starred_url":"https://api.github.com/users/Klim711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klim711/subscriptions","organizations_url":"https://api.github.com/users/Klim711/orgs","repos_url":"https://api.github.com/users/Klim711/repos","events_url":"https://api.github.com/users/Klim711/events{/privacy}","received_events_url":"https://api.github.com/users/Klim711/received_events","type":"User","site_admin":false},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nRedirection to another tab after user has defined assessment template on dashboard page (any page except Audit page).\r\n\r\n# Steps to test the changes\r\n\r\nSteps to reproduce:\r\n1. Open My work page > Audit tab\r\n2. Click on any audit in tree view\r\n3. Click Define Assessment template in 3 dots menu\r\n4. Create Assessment template \r\n\r\nActual Result: User is redirected to Info tab after Assessment template creation\r\nExpected Result:\r\n- Audit tab should be displayed after AT creation;\r\n- Audit Info panel should be displayed after AT creation.\r\n\r\n# Solution description\r\n\r\nAdd `isAuditPage` computable property for `assessment-template-clone` component.\r\nSet `updateHash` property to modal only If `isAuditPage` equals to true.\r\n\r\n# Sanity checklist\r\n\r\n- [ ] I have clicked through the app to make sure my changes work and not break the app.\r\n- [ ] I have applied the correct milestone and labels.\r\n- [ ] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [ ] My changes are covered by tests.\r\n- [ ] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [ ] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [ ] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2018-04-28T09:41:20Z","updated_at":"2018-04-28T09:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":608286139,"url":"https://api.github.com/repos/google/ggrc-core/labels/kokoro:run","name":"kokoro:run","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/87","html_url":"https://github.com/google/ggrc-core/milestone/87","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/87/labels","id":3301561,"number":87,"title":"1.11.0-Strawberry","description":"","creator":{"login":"IlyaTsupryk","id":9151434,"avatar_url":"https://avatars0.githubusercontent.com/u/9151434?v=4","gravatar_id":"","url":"https://api.github.com/users/IlyaTsupryk","html_url":"https://github.com/IlyaTsupryk","followers_url":"https://api.github.com/users/IlyaTsupryk/followers","following_url":"https://api.github.com/users/IlyaTsupryk/following{/other_user}","gists_url":"https://api.github.com/users/IlyaTsupryk/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaTsupryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaTsupryk/subscriptions","organizations_url":"https://api.github.com/users/IlyaTsupryk/orgs","repos_url":"https://api.github.com/users/IlyaTsupryk/repos","events_url":"https://api.github.com/users/IlyaTsupryk/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaTsupryk/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":2,"state":"open","created_at":"2018-04-26T14:59:38Z","updated_at":"2018-04-28T09:41:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/7730/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/7730/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/7730/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/be897fba3e81f9406b23be0e4a23d7803246b9aa","head":{"label":"Klim711:ggrc-4767","ref":"ggrc-4767","sha":"be897fba3e81f9406b23be0e4a23d7803246b9aa","user":{"login":"Klim711","id":10946494,"avatar_url":"https://avatars1.githubusercontent.com/u/10946494?v=4","gravatar_id":"","url":"https://api.github.com/users/Klim711","html_url":"https://github.com/Klim711","followers_url":"https://api.github.com/users/Klim711/followers","following_url":"https://api.github.com/users/Klim711/following{/other_user}","gists_url":"https://api.github.com/users/Klim711/gists{/gist_id}","starred_url":"https://api.github.com/users/Klim711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klim711/subscriptions","organizations_url":"https://api.github.com/users/Klim711/orgs","repos_url":"https://api.github.com/users/Klim711/repos","events_url":"https://api.github.com/users/Klim711/events{/privacy}","received_events_url":"https://api.github.com/users/Klim711/received_events","type":"User","site_admin":false},"repo":{"id":88605759,"name":"ggrc-core","full_name":"Klim711/ggrc-core","owner":{"login":"Klim711","id":10946494,"avatar_url":"https://avatars1.githubusercontent.com/u/10946494?v=4","gravatar_id":"","url":"https://api.github.com/users/Klim711","html_url":"https://github.com/Klim711","followers_url":"https://api.github.com/users/Klim711/followers","following_url":"https://api.github.com/users/Klim711/following{/other_user}","gists_url":"https://api.github.com/users/Klim711/gists{/gist_id}","starred_url":"https://api.github.com/users/Klim711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klim711/subscriptions","organizations_url":"https://api.github.com/users/Klim711/orgs","repos_url":"https://api.github.com/users/Klim711/repos","events_url":"https://api.github.com/users/Klim711/events{/privacy}","received_events_url":"https://api.github.com/users/Klim711/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Klim711/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/Klim711/ggrc-core","forks_url":"https://api.github.com/repos/Klim711/ggrc-core/forks","keys_url":"https://api.github.com/repos/Klim711/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Klim711/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Klim711/ggrc-core/teams","hooks_url":"https://api.github.com/repos/Klim711/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/Klim711/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/Klim711/ggrc-core/events","assignees_url":"https://api.github.com/repos/Klim711/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/Klim711/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/Klim711/ggrc-core/tags","blobs_url":"https://api.github.com/repos/Klim711/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Klim711/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Klim711/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Klim711/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Klim711/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Klim711/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/Klim711/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/Klim711/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/Klim711/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/Klim711/ggrc-core/subscription","commits_url":"https://api.github.com/repos/Klim711/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Klim711/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Klim711/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Klim711/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Klim711/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/Klim711/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Klim711/ggrc-core/merges","archive_url":"https://api.github.com/repos/Klim711/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Klim711/ggrc-core/downloads","issues_url":"https://api.github.com/repos/Klim711/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/Klim711/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Klim711/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Klim711/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Klim711/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/Klim711/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/Klim711/ggrc-core/deployments","created_at":"2017-04-18T09:15:05Z","updated_at":"2017-04-18T09:15:12Z","pushed_at":"2018-04-28T09:33:47Z","git_url":"git://github.com/Klim711/ggrc-core.git","ssh_url":"git@github.com:Klim711/ggrc-core.git","clone_url":"https://github.com/Klim711/ggrc-core.git","svn_url":"https://github.com/Klim711/ggrc-core","homepage":null,"size":74721,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:dev","ref":"dev","sha":"e897c4b94d7d0909fd6c2fb62ccfe8d5011c62e3","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2018-04-27T14:15:54Z","pushed_at":"2018-04-28T08:41:36Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":76681,"stargazers_count":276,"watchers_count":276,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":208,"open_issues":44,"watchers":276,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7730"},"html":{"href":"https://github.com/google/ggrc-core/pull/7730"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/7730"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/7730/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7730/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7730/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/be897fba3e81f9406b23be0e4a23d7803246b9aa"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"Klim711"}}