{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/comments/212494818","pull_request_review_id":149143116,"id":212494818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQ5NDgxOA==","diff_hunk":"@@ -72,33 +81,27 @@ func (cs *Clientset) resource(apiResource *dynamicdiscovery.APIResource, namespa\n \tif gv.Group != \"\" {\n \t\tconfig.APIPath = \"/apis\"\n \t}\n-\tdc, err := dynamic.NewClient(&config)\n+\tdc, err := dynamic.NewForConfig(&config)\n \tif err != nil {\n \t\treturn nil, fmt.Errorf(\"can't create dynamic client for resource %v in apiVersion %v: %v\", apiResource.Name, apiResource.APIVersion, err)\n \t}\n+\tresourceGVR := getResourceGVR(apiResource)\n \treturn &ResourceClient{\n-\t\tResourceInterface: dc.Resource(&apiResource.APIResource, namespace),\n-\t\tdc:                dc,\n-\t\tgv:                gv,\n-\t\tresource:          apiResource,\n+\t\tNamespaceableResourceInterface: dc.Resource(resourceGVR),\n+\t\tdc:                             dc,\n+\t\tgv:                             gv,\n+\t\tresource:                       apiResource,\n \t}, nil\n }\n \n type ResourceClient struct {\n-\tdynamic.ResourceInterface\n+\tdynamic.NamespaceableResourceInterface\n \n-\tdc       *dynamic.Client\n+\tdc       dynamic.Interface","path":"dynamic/clientset/dynamic_clientset.go","position":43,"original_position":43,"commit_id":"c3e639d15e17c02a00c43fb8ded751d82779f7b7","original_commit_id":"c3e639d15e17c02a00c43fb8ded751d82779f7b7","user":{"login":"crimsonfaith91","id":13921630,"node_id":"MDQ6VXNlcjEzOTIxNjMw","avatar_url":"https://avatars0.githubusercontent.com/u/13921630?v=4","gravatar_id":"","url":"https://api.github.com/users/crimsonfaith91","html_url":"https://github.com/crimsonfaith91","followers_url":"https://api.github.com/users/crimsonfaith91/followers","following_url":"https://api.github.com/users/crimsonfaith91/following{/other_user}","gists_url":"https://api.github.com/users/crimsonfaith91/gists{/gist_id}","starred_url":"https://api.github.com/users/crimsonfaith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crimsonfaith91/subscriptions","organizations_url":"https://api.github.com/users/crimsonfaith91/orgs","repos_url":"https://api.github.com/users/crimsonfaith91/repos","events_url":"https://api.github.com/users/crimsonfaith91/events{/privacy}","received_events_url":"https://api.github.com/users/crimsonfaith91/received_events","type":"User","site_admin":false},"body":"Removal of `dc` means we have to find another way of initializing `ResourceClient.NamespaceableResourceInterface`. I will see what is the possible workaround. This will take me some time because I am basically have zero knowledge on API machinery.","created_at":"2018-08-24T00:37:04Z","updated_at":"2018-08-24T00:37:04Z","html_url":"https://github.com/GoogleCloudPlatform/metacontroller/pull/80#discussion_r212494818","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/comments/212494818"},"html":{"href":"https://github.com/GoogleCloudPlatform/metacontroller/pull/80#discussion_r212494818"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80"}},"in_reply_to_id":212449325},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80","id":210303267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzAzMjY3","html_url":"https://github.com/GoogleCloudPlatform/metacontroller/pull/80","diff_url":"https://github.com/GoogleCloudPlatform/metacontroller/pull/80.diff","patch_url":"https://github.com/GoogleCloudPlatform/metacontroller/pull/80.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues/80","number":80,"state":"open","locked":false,"title":"use new dynamic client","user":{"login":"crimsonfaith91","id":13921630,"node_id":"MDQ6VXNlcjEzOTIxNjMw","avatar_url":"https://avatars0.githubusercontent.com/u/13921630?v=4","gravatar_id":"","url":"https://api.github.com/users/crimsonfaith91","html_url":"https://github.com/crimsonfaith91","followers_url":"https://api.github.com/users/crimsonfaith91/followers","following_url":"https://api.github.com/users/crimsonfaith91/following{/other_user}","gists_url":"https://api.github.com/users/crimsonfaith91/gists{/gist_id}","starred_url":"https://api.github.com/users/crimsonfaith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crimsonfaith91/subscriptions","organizations_url":"https://api.github.com/users/crimsonfaith91/orgs","repos_url":"https://api.github.com/users/crimsonfaith91/repos","events_url":"https://api.github.com/users/crimsonfaith91/events{/privacy}","received_events_url":"https://api.github.com/users/crimsonfaith91/received_events","type":"User","site_admin":false},"body":"This PR addresses issue #47. It changes the codebase to use new dynamic client.","created_at":"2018-08-23T00:59:48Z","updated_at":"2018-08-24T00:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a430409afba4242c725430d22fd73b3cd68d2cad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues/80/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/statuses/c3e639d15e17c02a00c43fb8ded751d82779f7b7","head":{"label":"crimsonfaith91:client","ref":"client","sha":"c3e639d15e17c02a00c43fb8ded751d82779f7b7","user":{"login":"crimsonfaith91","id":13921630,"node_id":"MDQ6VXNlcjEzOTIxNjMw","avatar_url":"https://avatars0.githubusercontent.com/u/13921630?v=4","gravatar_id":"","url":"https://api.github.com/users/crimsonfaith91","html_url":"https://github.com/crimsonfaith91","followers_url":"https://api.github.com/users/crimsonfaith91/followers","following_url":"https://api.github.com/users/crimsonfaith91/following{/other_user}","gists_url":"https://api.github.com/users/crimsonfaith91/gists{/gist_id}","starred_url":"https://api.github.com/users/crimsonfaith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crimsonfaith91/subscriptions","organizations_url":"https://api.github.com/users/crimsonfaith91/orgs","repos_url":"https://api.github.com/users/crimsonfaith91/repos","events_url":"https://api.github.com/users/crimsonfaith91/events{/privacy}","received_events_url":"https://api.github.com/users/crimsonfaith91/received_events","type":"User","site_admin":false},"repo":{"id":141201783,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMDE3ODM=","name":"metacontroller","full_name":"crimsonfaith91/metacontroller","owner":{"login":"crimsonfaith91","id":13921630,"node_id":"MDQ6VXNlcjEzOTIxNjMw","avatar_url":"https://avatars0.githubusercontent.com/u/13921630?v=4","gravatar_id":"","url":"https://api.github.com/users/crimsonfaith91","html_url":"https://github.com/crimsonfaith91","followers_url":"https://api.github.com/users/crimsonfaith91/followers","following_url":"https://api.github.com/users/crimsonfaith91/following{/other_user}","gists_url":"https://api.github.com/users/crimsonfaith91/gists{/gist_id}","starred_url":"https://api.github.com/users/crimsonfaith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crimsonfaith91/subscriptions","organizations_url":"https://api.github.com/users/crimsonfaith91/orgs","repos_url":"https://api.github.com/users/crimsonfaith91/repos","events_url":"https://api.github.com/users/crimsonfaith91/events{/privacy}","received_events_url":"https://api.github.com/users/crimsonfaith91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crimsonfaith91/metacontroller","description":"Lightweight Kubernetes controllers as a service","fork":true,"url":"https://api.github.com/repos/crimsonfaith91/metacontroller","forks_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/forks","keys_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/teams","hooks_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/hooks","issue_events_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/issues/events{/number}","events_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/events","assignees_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/assignees{/user}","branches_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/branches{/branch}","tags_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/tags","blobs_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/git/refs{/sha}","trees_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/statuses/{sha}","languages_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/languages","stargazers_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/stargazers","contributors_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/contributors","subscribers_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/subscribers","subscription_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/subscription","commits_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/commits{/sha}","git_commits_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/git/commits{/sha}","comments_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/comments{/number}","issue_comment_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/issues/comments{/number}","contents_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/contents/{+path}","compare_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/merges","archive_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/downloads","issues_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/issues{/number}","pulls_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/pulls{/number}","milestones_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/milestones{/number}","notifications_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/labels{/name}","releases_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/releases{/id}","deployments_url":"https://api.github.com/repos/crimsonfaith91/metacontroller/deployments","created_at":"2018-07-16T22:34:34Z","updated_at":"2018-07-16T22:34:37Z","pushed_at":"2018-08-23T00:58:55Z","git_url":"git://github.com/crimsonfaith91/metacontroller.git","ssh_url":"git@github.com:crimsonfaith91/metacontroller.git","clone_url":"https://github.com/crimsonfaith91/metacontroller.git","svn_url":"https://github.com/crimsonfaith91/metacontroller","homepage":"","size":432,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"2a992e2bb526749a6f10cad9b570fbe0510599f5","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":103700907,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM3MDA5MDc=","name":"metacontroller","full_name":"GoogleCloudPlatform/metacontroller","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/metacontroller","description":"Lightweight Kubernetes controllers as a service","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/deployments","created_at":"2017-09-15T20:59:27Z","updated_at":"2018-08-20T20:49:23Z","pushed_at":"2018-08-23T16:01:54Z","git_url":"git://github.com/GoogleCloudPlatform/metacontroller.git","ssh_url":"git@github.com:GoogleCloudPlatform/metacontroller.git","clone_url":"https://github.com/GoogleCloudPlatform/metacontroller.git","svn_url":"https://github.com/GoogleCloudPlatform/metacontroller","homepage":"https://metacontroller.app/","size":426,"stargazers_count":382,"watchers_count":382,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":22,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80"},"html":{"href":"https://github.com/GoogleCloudPlatform/metacontroller/pull/80"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues/80"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/metacontroller/statuses/c3e639d15e17c02a00c43fb8ded751d82779f7b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"crimsonfaith91"}}