{"push_id":3041579594,"size":3,"distinct_size":1,"ref":"refs/heads/master","head":"d7ac39aed78882f206b6bce77156bb8b75849e4d","before":"dc664c557bd670eb36c05e365585bd79a0135c04","commits":[{"sha":"8c95bd97796ea8e60016463e6a3489094cefcb77","author":{"name":"Michael Moussa","email":"fa2bc60f403b0c5e5ee787843caa88ef81bd6e39@gmail.com"},"message":"Fix issues with `constructed_cluster_name` length\n\nIssues were presenting themselves when both the `cluster_name` and\n`cluster_name_version` were _both_ 19 or 20 characters in length.\n\nIf they were both 19 characters in length, `substring_length` would\nevaluate to `0`, meaning that the `substr(var.cluster_name, 0,\nlocal.substring_length))` expression for `constructed_cluster_name`\nwould evaluate to `\"\"` and end up making the `\"-\"` the first character\nof the `constructed_cluster_name`, which is invalid.\n\nIf they were both 20 characters in length, the `substring_length` value\nwould evaluate to `-1`, which makes all `substr(...)` expressions using\nit as the length parameter actually extract _all_ of the string.\n\nThis solution will:\n    1. Use a `replace(...)` call on the first component of\n       the `join(\"-\", list(...))` expression to remove the leading `-` if\n       present.\n    2. Limit the overall length of the `constructed_cluster_name`,\n       post-construction, to a maximum of 20 characters.\n    3. Use `truncated_constructed_cluster_name` to avoid having to apply\n       the truncation on every usage.","distinct":false,"url":"https://api.github.com/repos/rackspace-infrastructure-automation/aws-terraform-elasticache/commits/8c95bd97796ea8e60016463e6a3489094cefcb77"},{"sha":"09aad1db2dbacd24feca379b10cfb5e8e06e4fc2","author":{"name":"Michael Moussa","email":"fa2bc60f403b0c5e5ee787843caa88ef81bd6e39@gmail.com"},"message":"Add tests for the 19/20 char fix","distinct":false,"url":"https://api.github.com/repos/rackspace-infrastructure-automation/aws-terraform-elasticache/commits/09aad1db2dbacd24feca379b10cfb5e8e06e4fc2"},{"sha":"d7ac39aed78882f206b6bce77156bb8b75849e4d","author":{"name":"Michael Cardenas","email":"75bbe3beee090839d3e403673e1b104962166a9a@rackspace.com"},"message":"Merge pull request #8 from rackspace-infrastructure-automation/fix-constructed-cluster-name-length\n\nFix constructed cluster name length","distinct":true,"url":"https://api.github.com/repos/rackspace-infrastructure-automation/aws-terraform-elasticache/commits/d7ac39aed78882f206b6bce77156bb8b75849e4d"}]}
{"actor":{"display_login":"mjcmtb"}}