{"action":"created","issue":{"url":"https://api.github.com/repos/seeleteam/go-seele/issues/117","repository_url":"https://api.github.com/repos/seeleteam/go-seele","labels_url":"https://api.github.com/repos/seeleteam/go-seele/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/seeleteam/go-seele/issues/117/comments","events_url":"https://api.github.com/repos/seeleteam/go-seele/issues/117/events","html_url":"https://github.com/seeleteam/go-seele/pull/117","id":313188041,"number":117,"title":"Download: fix some bugs and add some logs","user":{"login":"qiaozhigang","id":35721349,"avatar_url":"https://avatars1.githubusercontent.com/u/35721349?v=4","gravatar_id":"","url":"https://api.github.com/users/qiaozhigang","html_url":"https://github.com/qiaozhigang","followers_url":"https://api.github.com/users/qiaozhigang/followers","following_url":"https://api.github.com/users/qiaozhigang/following{/other_user}","gists_url":"https://api.github.com/users/qiaozhigang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiaozhigang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiaozhigang/subscriptions","organizations_url":"https://api.github.com/users/qiaozhigang/orgs","repos_url":"https://api.github.com/users/qiaozhigang/repos","events_url":"https://api.github.com/users/qiaozhigang/events{/privacy}","received_events_url":"https://api.github.com/users/qiaozhigang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-11T06:23:10Z","updated_at":"2018-04-11T06:42:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/seeleteam/go-seele/pulls/117","html_url":"https://github.com/seeleteam/go-seele/pull/117","diff_url":"https://github.com/seeleteam/go-seele/pull/117.diff","patch_url":"https://github.com/seeleteam/go-seele/pull/117.patch"},"body":"Fix some bugs and add some logs\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/seeleteam/go-seele/117)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/seeleteam/go-seele/issues/comments/380344712","html_url":"https://github.com/seeleteam/go-seele/pull/117#issuecomment-380344712","issue_url":"https://api.github.com/repos/seeleteam/go-seele/issues/117","id":380344712,"user":{"login":"lucusfly","id":4971353,"avatar_url":"https://avatars2.githubusercontent.com/u/4971353?v=4","gravatar_id":"","url":"https://api.github.com/users/lucusfly","html_url":"https://github.com/lucusfly","followers_url":"https://api.github.com/users/lucusfly/followers","following_url":"https://api.github.com/users/lucusfly/following{/other_user}","gists_url":"https://api.github.com/users/lucusfly/gists{/gist_id}","starred_url":"https://api.github.com/users/lucusfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucusfly/subscriptions","organizations_url":"https://api.github.com/users/lucusfly/orgs","repos_url":"https://api.github.com/users/lucusfly/repos","events_url":"https://api.github.com/users/lucusfly/events{/privacy}","received_events_url":"https://api.github.com/users/lucusfly/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T06:42:59Z","updated_at":"2018-04-11T06:42:59Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 5 files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[seele/peer.go, line 159 at r1](https://beta.reviewable.io/reviews/seeleteam/go-seele/117#-L9nRDPo7hfm55pKT5Br:-L9nRDPo7hfm55pKT5Bs:b72ly7c) ([raw file](https://github.com/seeleteam/go-seele/blob/56b15b233c57f7cab6e5ff3a935ea0ede102993d/seele/peer.go#L159)):*\n> ```Go\n> // RequestHeadersByHashOrNumber fetches a batch of blocks' headers corresponding to the\n> // specified header query, based on the hash of an origin block.\n> func (p *peer) RequestHeadersByHashOrNumber(origin common.Hash, num uint64, amount int, reverse bool) error {\n> ```\n\nchange parameter amount to uint64?\n\n---\n\n*[seele/seeleprotocol.go, line 130 at r1](https://beta.reviewable.io/reviews/seeleteam/go-seele/117#-L9nQIGhAoDwAZHHEzys:-L9nQIGhAoDwAZHHEzyt:b-fy00yf) ([raw file](https://github.com/seeleteam/go-seele/blob/56b15b233c57f7cab6e5ff3a935ea0ede102993d/seele/seeleprotocol.go#L130)):*\n> ```Go\n> \tpHead, pTd := p.Head()\n> \n> \tfmt.Println(\"SeeleProtocol.synchronise\", localTD, pTd)\n> ```\n\nmove to log\n\n---\n\n*[seele/seeleprotocol.go, line 396 at r1](https://beta.reviewable.io/reviews/seeleteam/go-seele/117#-L9nQZBv7RynKwC2RV93:-L9nQZBv7RynKwC2RV94:b-2q4854) ([raw file](https://github.com/seeleteam/go-seele/blob/56b15b233c57f7cab6e5ff3a935ea0ede102993d/seele/seeleprotocol.go#L396)):*\n> ```Go\n> \t\t\tvar head *types.BlockHeader\n> \t\t\torgNum := query.Number\n> \t\t\tfmt.Println(query)\n> ```\n\nremove or move to log\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/seeleteam/go-seele/117)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lucusfly"}}