{"action":"created","comment":{"url":"https://api.github.com/repos/nToggle/ota-external/pulls/comments/190030903","pull_request_review_id":122325598,"id":190030903,"diff_hunk":"@@ -0,0 +1,48 @@\n+syntax = \"proto3\";\n+\n+import \"optimization.proto\";\n+\n+package impressionresult;\n+\n+option java_package = \"com.rubiconproject.dt.ota.impressionresult.java\";\n+\n+option java_multiple_files = true;\n+\n+import \"scalapb/scalapb.proto\";\n+\n+option (scalapb.options) = {\n+  package_name: \"com.rubiconproject.dt.ota.impressionresult.skala\"\n+};\n+\n+message ImpressionResult {\n+    uint64 timestampMs = 1;\n+    string auctionId = 2;\n+    optimization.OptimizationAttributes attributes = 3;\n+    AuctionInfo auctionInfo = 4;\n+    WinInfo winInfo = 5;\n+    AtariInfo atariInfo = 6;\n+}\n+\n+message WinInfo {\n+    uint64 timestamp = 1;\n+    uint32 nid = 2;\n+    double priceCpm = 3;\n+}\n+\n+message AuctionInfo {\n+    repeated uint32 auctionParticipants = 1;\n+    uint32 auctionWinner = 2;\n+    double winningBidCpm = 3;\n+    double clearingCpm = 4;\n+}\n+\n+message AtariInfo {","path":"src/main/protobuf/impressionResult.proto","position":39,"original_position":39,"commit_id":"8dce5b6567c540b520e667faa69be228e567ffd2","original_commit_id":"8dce5b6567c540b520e667faa69be228e567ffd2","user":{"login":"michaeldiamant","id":740256,"avatar_url":"https://avatars0.githubusercontent.com/u/740256?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeldiamant","html_url":"https://github.com/michaeldiamant","followers_url":"https://api.github.com/users/michaeldiamant/followers","following_url":"https://api.github.com/users/michaeldiamant/following{/other_user}","gists_url":"https://api.github.com/users/michaeldiamant/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeldiamant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeldiamant/subscriptions","organizations_url":"https://api.github.com/users/michaeldiamant/orgs","repos_url":"https://api.github.com/users/michaeldiamant/repos","events_url":"https://api.github.com/users/michaeldiamant/events{/privacy}","received_events_url":"https://api.github.com/users/michaeldiamant/received_events","type":"User","site_admin":false},"body":"I had a verbal with @jchaiy and will summarize thinking here:\r\n* Current policy is to copy all members of `OptimizationInfo` into some analog in `ImpressionResult`. i.e. the ask for this PR on my end is to do a pass through `OptimizationInfo` and reflect any missed fields (e.g. `OptimizationResult`.\r\n* If we could refactor `OptimizationInfo` into a structure that more closely represents `ImpressionResult` (where objects are logically grouped), ota / ota-external could just copy the single parent level member and the class of error (i.e. missing fields) would be removed (or largely eliminated).  As a concrete example, imagine if `AtariInfo` was defined in optimization repo and the reference to `AtariInfo` was simply copied from `OptimizationInfo` to `OptimizationResult`.  I plan to open a PR against optimization repo with this proposal for feedback (likely tomorrow).","created_at":"2018-05-22T19:50:03Z","updated_at":"2018-05-22T19:50:03Z","html_url":"https://github.com/nToggle/ota-external/pull/1#discussion_r190030903","pull_request_url":"https://api.github.com/repos/nToggle/ota-external/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nToggle/ota-external/pulls/comments/190030903"},"html":{"href":"https://github.com/nToggle/ota-external/pull/1#discussion_r190030903"},"pull_request":{"href":"https://api.github.com/repos/nToggle/ota-external/pulls/1"}},"in_reply_to_id":190023212},"pull_request":{"url":"https://api.github.com/repos/nToggle/ota-external/pulls/1","id":189157099,"html_url":"https://github.com/nToggle/ota-external/pull/1","diff_url":"https://github.com/nToggle/ota-external/pull/1.diff","patch_url":"https://github.com/nToggle/ota-external/pull/1.patch","issue_url":"https://api.github.com/repos/nToggle/ota-external/issues/1","number":1,"state":"open","locked":false,"title":"DSPT-2300: ota-external","user":{"login":"saharMlowell","id":26151167,"avatar_url":"https://avatars2.githubusercontent.com/u/26151167?v=4","gravatar_id":"","url":"https://api.github.com/users/saharMlowell","html_url":"https://github.com/saharMlowell","followers_url":"https://api.github.com/users/saharMlowell/followers","following_url":"https://api.github.com/users/saharMlowell/following{/other_user}","gists_url":"https://api.github.com/users/saharMlowell/gists{/gist_id}","starred_url":"https://api.github.com/users/saharMlowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saharMlowell/subscriptions","organizations_url":"https://api.github.com/users/saharMlowell/orgs","repos_url":"https://api.github.com/users/saharMlowell/repos","events_url":"https://api.github.com/users/saharMlowell/events{/privacy}","received_events_url":"https://api.github.com/users/saharMlowell/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-18T23:42:26Z","updated_at":"2018-05-22T19:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"487ad87ef0691cee99acc9fe97eada09fdcb8e57","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jchaiy","id":13626407,"avatar_url":"https://avatars3.githubusercontent.com/u/13626407?v=4","gravatar_id":"","url":"https://api.github.com/users/jchaiy","html_url":"https://github.com/jchaiy","followers_url":"https://api.github.com/users/jchaiy/followers","following_url":"https://api.github.com/users/jchaiy/following{/other_user}","gists_url":"https://api.github.com/users/jchaiy/gists{/gist_id}","starred_url":"https://api.github.com/users/jchaiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchaiy/subscriptions","organizations_url":"https://api.github.com/users/jchaiy/orgs","repos_url":"https://api.github.com/users/jchaiy/repos","events_url":"https://api.github.com/users/jchaiy/events{/privacy}","received_events_url":"https://api.github.com/users/jchaiy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nToggle/ota-external/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nToggle/ota-external/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nToggle/ota-external/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nToggle/ota-external/issues/1/comments","statuses_url":"https://api.github.com/repos/nToggle/ota-external/statuses/8dce5b6567c540b520e667faa69be228e567ffd2","head":{"label":"nToggle:feature/DSPT-2300","ref":"feature/DSPT-2300","sha":"8dce5b6567c540b520e667faa69be228e567ffd2","user":{"login":"nToggle","id":8260741,"avatar_url":"https://avatars1.githubusercontent.com/u/8260741?v=4","gravatar_id":"","url":"https://api.github.com/users/nToggle","html_url":"https://github.com/nToggle","followers_url":"https://api.github.com/users/nToggle/followers","following_url":"https://api.github.com/users/nToggle/following{/other_user}","gists_url":"https://api.github.com/users/nToggle/gists{/gist_id}","starred_url":"https://api.github.com/users/nToggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nToggle/subscriptions","organizations_url":"https://api.github.com/users/nToggle/orgs","repos_url":"https://api.github.com/users/nToggle/repos","events_url":"https://api.github.com/users/nToggle/events{/privacy}","received_events_url":"https://api.github.com/users/nToggle/received_events","type":"Organization","site_admin":false},"repo":{"id":134002887,"name":"ota-external","full_name":"nToggle/ota-external","owner":{"login":"nToggle","id":8260741,"avatar_url":"https://avatars1.githubusercontent.com/u/8260741?v=4","gravatar_id":"","url":"https://api.github.com/users/nToggle","html_url":"https://github.com/nToggle","followers_url":"https://api.github.com/users/nToggle/followers","following_url":"https://api.github.com/users/nToggle/following{/other_user}","gists_url":"https://api.github.com/users/nToggle/gists{/gist_id}","starred_url":"https://api.github.com/users/nToggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nToggle/subscriptions","organizations_url":"https://api.github.com/users/nToggle/orgs","repos_url":"https://api.github.com/users/nToggle/repos","events_url":"https://api.github.com/users/nToggle/events{/privacy}","received_events_url":"https://api.github.com/users/nToggle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nToggle/ota-external","description":null,"fork":false,"url":"https://api.github.com/repos/nToggle/ota-external","forks_url":"https://api.github.com/repos/nToggle/ota-external/forks","keys_url":"https://api.github.com/repos/nToggle/ota-external/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nToggle/ota-external/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nToggle/ota-external/teams","hooks_url":"https://api.github.com/repos/nToggle/ota-external/hooks","issue_events_url":"https://api.github.com/repos/nToggle/ota-external/issues/events{/number}","events_url":"https://api.github.com/repos/nToggle/ota-external/events","assignees_url":"https://api.github.com/repos/nToggle/ota-external/assignees{/user}","branches_url":"https://api.github.com/repos/nToggle/ota-external/branches{/branch}","tags_url":"https://api.github.com/repos/nToggle/ota-external/tags","blobs_url":"https://api.github.com/repos/nToggle/ota-external/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nToggle/ota-external/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nToggle/ota-external/git/refs{/sha}","trees_url":"https://api.github.com/repos/nToggle/ota-external/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nToggle/ota-external/statuses/{sha}","languages_url":"https://api.github.com/repos/nToggle/ota-external/languages","stargazers_url":"https://api.github.com/repos/nToggle/ota-external/stargazers","contributors_url":"https://api.github.com/repos/nToggle/ota-external/contributors","subscribers_url":"https://api.github.com/repos/nToggle/ota-external/subscribers","subscription_url":"https://api.github.com/repos/nToggle/ota-external/subscription","commits_url":"https://api.github.com/repos/nToggle/ota-external/commits{/sha}","git_commits_url":"https://api.github.com/repos/nToggle/ota-external/git/commits{/sha}","comments_url":"https://api.github.com/repos/nToggle/ota-external/comments{/number}","issue_comment_url":"https://api.github.com/repos/nToggle/ota-external/issues/comments{/number}","contents_url":"https://api.github.com/repos/nToggle/ota-external/contents/{+path}","compare_url":"https://api.github.com/repos/nToggle/ota-external/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nToggle/ota-external/merges","archive_url":"https://api.github.com/repos/nToggle/ota-external/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nToggle/ota-external/downloads","issues_url":"https://api.github.com/repos/nToggle/ota-external/issues{/number}","pulls_url":"https://api.github.com/repos/nToggle/ota-external/pulls{/number}","milestones_url":"https://api.github.com/repos/nToggle/ota-external/milestones{/number}","notifications_url":"https://api.github.com/repos/nToggle/ota-external/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nToggle/ota-external/labels{/name}","releases_url":"https://api.github.com/repos/nToggle/ota-external/releases{/id}","deployments_url":"https://api.github.com/repos/nToggle/ota-external/deployments","created_at":"2018-05-18T20:49:47Z","updated_at":"2018-05-18T20:50:36Z","pushed_at":"2018-05-22T00:22:45Z","git_url":"git://github.com/nToggle/ota-external.git","ssh_url":"git@github.com:nToggle/ota-external.git","clone_url":"https://github.com/nToggle/ota-external.git","svn_url":"https://github.com/nToggle/ota-external","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nToggle:master","ref":"master","sha":"6aadfb027c588a8e35294d2c616ce742f1b20642","user":{"login":"nToggle","id":8260741,"avatar_url":"https://avatars1.githubusercontent.com/u/8260741?v=4","gravatar_id":"","url":"https://api.github.com/users/nToggle","html_url":"https://github.com/nToggle","followers_url":"https://api.github.com/users/nToggle/followers","following_url":"https://api.github.com/users/nToggle/following{/other_user}","gists_url":"https://api.github.com/users/nToggle/gists{/gist_id}","starred_url":"https://api.github.com/users/nToggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nToggle/subscriptions","organizations_url":"https://api.github.com/users/nToggle/orgs","repos_url":"https://api.github.com/users/nToggle/repos","events_url":"https://api.github.com/users/nToggle/events{/privacy}","received_events_url":"https://api.github.com/users/nToggle/received_events","type":"Organization","site_admin":false},"repo":{"id":134002887,"name":"ota-external","full_name":"nToggle/ota-external","owner":{"login":"nToggle","id":8260741,"avatar_url":"https://avatars1.githubusercontent.com/u/8260741?v=4","gravatar_id":"","url":"https://api.github.com/users/nToggle","html_url":"https://github.com/nToggle","followers_url":"https://api.github.com/users/nToggle/followers","following_url":"https://api.github.com/users/nToggle/following{/other_user}","gists_url":"https://api.github.com/users/nToggle/gists{/gist_id}","starred_url":"https://api.github.com/users/nToggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nToggle/subscriptions","organizations_url":"https://api.github.com/users/nToggle/orgs","repos_url":"https://api.github.com/users/nToggle/repos","events_url":"https://api.github.com/users/nToggle/events{/privacy}","received_events_url":"https://api.github.com/users/nToggle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nToggle/ota-external","description":null,"fork":false,"url":"https://api.github.com/repos/nToggle/ota-external","forks_url":"https://api.github.com/repos/nToggle/ota-external/forks","keys_url":"https://api.github.com/repos/nToggle/ota-external/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nToggle/ota-external/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nToggle/ota-external/teams","hooks_url":"https://api.github.com/repos/nToggle/ota-external/hooks","issue_events_url":"https://api.github.com/repos/nToggle/ota-external/issues/events{/number}","events_url":"https://api.github.com/repos/nToggle/ota-external/events","assignees_url":"https://api.github.com/repos/nToggle/ota-external/assignees{/user}","branches_url":"https://api.github.com/repos/nToggle/ota-external/branches{/branch}","tags_url":"https://api.github.com/repos/nToggle/ota-external/tags","blobs_url":"https://api.github.com/repos/nToggle/ota-external/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nToggle/ota-external/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nToggle/ota-external/git/refs{/sha}","trees_url":"https://api.github.com/repos/nToggle/ota-external/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nToggle/ota-external/statuses/{sha}","languages_url":"https://api.github.com/repos/nToggle/ota-external/languages","stargazers_url":"https://api.github.com/repos/nToggle/ota-external/stargazers","contributors_url":"https://api.github.com/repos/nToggle/ota-external/contributors","subscribers_url":"https://api.github.com/repos/nToggle/ota-external/subscribers","subscription_url":"https://api.github.com/repos/nToggle/ota-external/subscription","commits_url":"https://api.github.com/repos/nToggle/ota-external/commits{/sha}","git_commits_url":"https://api.github.com/repos/nToggle/ota-external/git/commits{/sha}","comments_url":"https://api.github.com/repos/nToggle/ota-external/comments{/number}","issue_comment_url":"https://api.github.com/repos/nToggle/ota-external/issues/comments{/number}","contents_url":"https://api.github.com/repos/nToggle/ota-external/contents/{+path}","compare_url":"https://api.github.com/repos/nToggle/ota-external/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nToggle/ota-external/merges","archive_url":"https://api.github.com/repos/nToggle/ota-external/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nToggle/ota-external/downloads","issues_url":"https://api.github.com/repos/nToggle/ota-external/issues{/number}","pulls_url":"https://api.github.com/repos/nToggle/ota-external/pulls{/number}","milestones_url":"https://api.github.com/repos/nToggle/ota-external/milestones{/number}","notifications_url":"https://api.github.com/repos/nToggle/ota-external/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nToggle/ota-external/labels{/name}","releases_url":"https://api.github.com/repos/nToggle/ota-external/releases{/id}","deployments_url":"https://api.github.com/repos/nToggle/ota-external/deployments","created_at":"2018-05-18T20:49:47Z","updated_at":"2018-05-18T20:50:36Z","pushed_at":"2018-05-22T00:22:45Z","git_url":"git://github.com/nToggle/ota-external.git","ssh_url":"git@github.com:nToggle/ota-external.git","clone_url":"https://github.com/nToggle/ota-external.git","svn_url":"https://github.com/nToggle/ota-external","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nToggle/ota-external/pulls/1"},"html":{"href":"https://github.com/nToggle/ota-external/pull/1"},"issue":{"href":"https://api.github.com/repos/nToggle/ota-external/issues/1"},"comments":{"href":"https://api.github.com/repos/nToggle/ota-external/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nToggle/ota-external/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nToggle/ota-external/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nToggle/ota-external/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nToggle/ota-external/statuses/8dce5b6567c540b520e667faa69be228e567ffd2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michaeldiamant"}}