{"action":"created","comment":{"url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/comments/170601342","pull_request_review_id":99310534,"id":170601342,"diff_hunk":"@@ -1759,15 +1759,15 @@ def close(self, alias):\n \n         sock.close(linger=get_linger())\n \n-    def close_all(self):\n+    def close_all(self, linger=get_linger()):\n         \"\"\"\n         Close all non-internal zmq sockets.\n         \"\"\"\n         # Each socket might be pointed by different keys\n         sockets_to_delete = []\n         for sock in self._get_unique_external_zmq_sockets():\n             sockets_to_delete.append(sock)\n-            sock.close(linger=get_linger())\n+            sock.close(linger)","path":"osbrain/agent.py","position":50,"original_position":50,"commit_id":"1daa0dde89ca4e73bb9398060eeddd9c18979cb1","original_commit_id":"0d47583d62e396dbad3ae29c2a2f1ee1a412431b","user":{"login":"ocaballeror","id":20464046,"avatar_url":"https://avatars3.githubusercontent.com/u/20464046?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaballeror","html_url":"https://github.com/ocaballeror","followers_url":"https://api.github.com/users/ocaballeror/followers","following_url":"https://api.github.com/users/ocaballeror/following{/other_user}","gists_url":"https://api.github.com/users/ocaballeror/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaballeror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaballeror/subscriptions","organizations_url":"https://api.github.com/users/ocaballeror/orgs","repos_url":"https://api.github.com/users/ocaballeror/repos","events_url":"https://api.github.com/users/ocaballeror/events{/privacy}","received_events_url":"https://api.github.com/users/ocaballeror/received_events","type":"User","site_admin":false},"body":"Oh. I didn't know that happened. What about something like this:\r\n```python\r\nconf = dict(linger=1)\r\n\r\n\r\ndef get_linger():\r\n    return conf['linger']\r\n\r\n\r\ndef default_conf(linger=None):\r\n    if linger is None:\r\n        linger = get_linger()\r\n    return linger\r\n\r\n\r\nif __name__ == '__main__':\r\n    print(default_conf())\r\n    conf['linger'] = 2\r\n    print(default_conf())\r\n```","created_at":"2018-02-26T14:09:08Z","updated_at":"2018-02-26T14:09:08Z","html_url":"https://github.com/opensistemas-hub/osbrain/pull/252#discussion_r170601342","pull_request_url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/comments/170601342"},"html":{"href":"https://github.com/opensistemas-hub/osbrain/pull/252#discussion_r170601342"},"pull_request":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252"}},"in_reply_to_id":170532879},"pull_request":{"url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252","id":170213282,"html_url":"https://github.com/opensistemas-hub/osbrain/pull/252","diff_url":"https://github.com/opensistemas-hub/osbrain/pull/252.diff","patch_url":"https://github.com/opensistemas-hub/osbrain/pull/252.patch","issue_url":"https://api.github.com/repos/opensistemas-hub/osbrain/issues/252","number":252,"state":"open","locked":false,"title":"Make tests compatible with windows","user":{"login":"ocaballeror","id":20464046,"avatar_url":"https://avatars3.githubusercontent.com/u/20464046?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaballeror","html_url":"https://github.com/ocaballeror","followers_url":"https://api.github.com/users/ocaballeror/followers","following_url":"https://api.github.com/users/ocaballeror/following{/other_user}","gists_url":"https://api.github.com/users/ocaballeror/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaballeror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaballeror/subscriptions","organizations_url":"https://api.github.com/users/ocaballeror/orgs","repos_url":"https://api.github.com/users/ocaballeror/repos","events_url":"https://api.github.com/users/ocaballeror/events{/privacy}","received_events_url":"https://api.github.com/users/ocaballeror/received_events","type":"User","site_admin":false},"body":"Continuing the discussion from #147 .\r\n\r\nAlso, just to be clear, I don't intend to merge this yet, so there may be some weird comments and print statements around the code.","created_at":"2018-02-20T14:50:34Z","updated_at":"2018-02-26T14:09:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"280db2695d1a4314cdae8610ba022bd424430c14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/opensistemas-hub/osbrain/milestones/11","html_url":"https://github.com/opensistemas-hub/osbrain/milestone/11","labels_url":"https://api.github.com/repos/opensistemas-hub/osbrain/milestones/11/labels","id":3089472,"number":11,"title":"0.7.0","description":null,"creator":{"login":"Peque","id":526577,"avatar_url":"https://avatars1.githubusercontent.com/u/526577?v=4","gravatar_id":"","url":"https://api.github.com/users/Peque","html_url":"https://github.com/Peque","followers_url":"https://api.github.com/users/Peque/followers","following_url":"https://api.github.com/users/Peque/following{/other_user}","gists_url":"https://api.github.com/users/Peque/gists{/gist_id}","starred_url":"https://api.github.com/users/Peque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peque/subscriptions","organizations_url":"https://api.github.com/users/Peque/orgs","repos_url":"https://api.github.com/users/Peque/repos","events_url":"https://api.github.com/users/Peque/events{/privacy}","received_events_url":"https://api.github.com/users/Peque/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":1,"state":"open","created_at":"2018-02-05T13:14:19Z","updated_at":"2018-02-20T15:37:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252/commits","review_comments_url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252/comments","review_comment_url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensistemas-hub/osbrain/issues/252/comments","statuses_url":"https://api.github.com/repos/opensistemas-hub/osbrain/statuses/1daa0dde89ca4e73bb9398060eeddd9c18979cb1","head":{"label":"ocaballeror:windows_ipc","ref":"windows_ipc","sha":"1daa0dde89ca4e73bb9398060eeddd9c18979cb1","user":{"login":"ocaballeror","id":20464046,"avatar_url":"https://avatars3.githubusercontent.com/u/20464046?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaballeror","html_url":"https://github.com/ocaballeror","followers_url":"https://api.github.com/users/ocaballeror/followers","following_url":"https://api.github.com/users/ocaballeror/following{/other_user}","gists_url":"https://api.github.com/users/ocaballeror/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaballeror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaballeror/subscriptions","organizations_url":"https://api.github.com/users/ocaballeror/orgs","repos_url":"https://api.github.com/users/ocaballeror/repos","events_url":"https://api.github.com/users/ocaballeror/events{/privacy}","received_events_url":"https://api.github.com/users/ocaballeror/received_events","type":"User","site_admin":false},"repo":{"id":117568773,"name":"osbrain","full_name":"ocaballeror/osbrain","owner":{"login":"ocaballeror","id":20464046,"avatar_url":"https://avatars3.githubusercontent.com/u/20464046?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaballeror","html_url":"https://github.com/ocaballeror","followers_url":"https://api.github.com/users/ocaballeror/followers","following_url":"https://api.github.com/users/ocaballeror/following{/other_user}","gists_url":"https://api.github.com/users/ocaballeror/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaballeror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaballeror/subscriptions","organizations_url":"https://api.github.com/users/ocaballeror/orgs","repos_url":"https://api.github.com/users/ocaballeror/repos","events_url":"https://api.github.com/users/ocaballeror/events{/privacy}","received_events_url":"https://api.github.com/users/ocaballeror/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ocaballeror/osbrain","description":"osBrain - A general-purpose multi-agent system module written in Python","fork":true,"url":"https://api.github.com/repos/ocaballeror/osbrain","forks_url":"https://api.github.com/repos/ocaballeror/osbrain/forks","keys_url":"https://api.github.com/repos/ocaballeror/osbrain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaballeror/osbrain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaballeror/osbrain/teams","hooks_url":"https://api.github.com/repos/ocaballeror/osbrain/hooks","issue_events_url":"https://api.github.com/repos/ocaballeror/osbrain/issues/events{/number}","events_url":"https://api.github.com/repos/ocaballeror/osbrain/events","assignees_url":"https://api.github.com/repos/ocaballeror/osbrain/assignees{/user}","branches_url":"https://api.github.com/repos/ocaballeror/osbrain/branches{/branch}","tags_url":"https://api.github.com/repos/ocaballeror/osbrain/tags","blobs_url":"https://api.github.com/repos/ocaballeror/osbrain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaballeror/osbrain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaballeror/osbrain/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaballeror/osbrain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaballeror/osbrain/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaballeror/osbrain/languages","stargazers_url":"https://api.github.com/repos/ocaballeror/osbrain/stargazers","contributors_url":"https://api.github.com/repos/ocaballeror/osbrain/contributors","subscribers_url":"https://api.github.com/repos/ocaballeror/osbrain/subscribers","subscription_url":"https://api.github.com/repos/ocaballeror/osbrain/subscription","commits_url":"https://api.github.com/repos/ocaballeror/osbrain/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaballeror/osbrain/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaballeror/osbrain/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaballeror/osbrain/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaballeror/osbrain/contents/{+path}","compare_url":"https://api.github.com/repos/ocaballeror/osbrain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaballeror/osbrain/merges","archive_url":"https://api.github.com/repos/ocaballeror/osbrain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaballeror/osbrain/downloads","issues_url":"https://api.github.com/repos/ocaballeror/osbrain/issues{/number}","pulls_url":"https://api.github.com/repos/ocaballeror/osbrain/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaballeror/osbrain/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaballeror/osbrain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaballeror/osbrain/labels{/name}","releases_url":"https://api.github.com/repos/ocaballeror/osbrain/releases{/id}","deployments_url":"https://api.github.com/repos/ocaballeror/osbrain/deployments","created_at":"2018-01-15T16:27:44Z","updated_at":"2018-01-15T16:27:46Z","pushed_at":"2018-02-26T12:59:15Z","git_url":"git://github.com/ocaballeror/osbrain.git","ssh_url":"git@github.com:ocaballeror/osbrain.git","clone_url":"https://github.com/ocaballeror/osbrain.git","svn_url":"https://github.com/ocaballeror/osbrain","homepage":"https://osbrain.readthedocs.io/en/stable/","size":778,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opensistemas-hub:master","ref":"master","sha":"6e3e96a1df83e51b2da51174b31f8a3c93c3a394","user":{"login":"opensistemas-hub","id":2923350,"avatar_url":"https://avatars3.githubusercontent.com/u/2923350?v=4","gravatar_id":"","url":"https://api.github.com/users/opensistemas-hub","html_url":"https://github.com/opensistemas-hub","followers_url":"https://api.github.com/users/opensistemas-hub/followers","following_url":"https://api.github.com/users/opensistemas-hub/following{/other_user}","gists_url":"https://api.github.com/users/opensistemas-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/opensistemas-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensistemas-hub/subscriptions","organizations_url":"https://api.github.com/users/opensistemas-hub/orgs","repos_url":"https://api.github.com/users/opensistemas-hub/repos","events_url":"https://api.github.com/users/opensistemas-hub/events{/privacy}","received_events_url":"https://api.github.com/users/opensistemas-hub/received_events","type":"Organization","site_admin":false},"repo":{"id":63174113,"name":"osbrain","full_name":"opensistemas-hub/osbrain","owner":{"login":"opensistemas-hub","id":2923350,"avatar_url":"https://avatars3.githubusercontent.com/u/2923350?v=4","gravatar_id":"","url":"https://api.github.com/users/opensistemas-hub","html_url":"https://github.com/opensistemas-hub","followers_url":"https://api.github.com/users/opensistemas-hub/followers","following_url":"https://api.github.com/users/opensistemas-hub/following{/other_user}","gists_url":"https://api.github.com/users/opensistemas-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/opensistemas-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensistemas-hub/subscriptions","organizations_url":"https://api.github.com/users/opensistemas-hub/orgs","repos_url":"https://api.github.com/users/opensistemas-hub/repos","events_url":"https://api.github.com/users/opensistemas-hub/events{/privacy}","received_events_url":"https://api.github.com/users/opensistemas-hub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensistemas-hub/osbrain","description":"osBrain - A general-purpose multi-agent system module written in Python","fork":false,"url":"https://api.github.com/repos/opensistemas-hub/osbrain","forks_url":"https://api.github.com/repos/opensistemas-hub/osbrain/forks","keys_url":"https://api.github.com/repos/opensistemas-hub/osbrain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensistemas-hub/osbrain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensistemas-hub/osbrain/teams","hooks_url":"https://api.github.com/repos/opensistemas-hub/osbrain/hooks","issue_events_url":"https://api.github.com/repos/opensistemas-hub/osbrain/issues/events{/number}","events_url":"https://api.github.com/repos/opensistemas-hub/osbrain/events","assignees_url":"https://api.github.com/repos/opensistemas-hub/osbrain/assignees{/user}","branches_url":"https://api.github.com/repos/opensistemas-hub/osbrain/branches{/branch}","tags_url":"https://api.github.com/repos/opensistemas-hub/osbrain/tags","blobs_url":"https://api.github.com/repos/opensistemas-hub/osbrain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensistemas-hub/osbrain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensistemas-hub/osbrain/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensistemas-hub/osbrain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensistemas-hub/osbrain/statuses/{sha}","languages_url":"https://api.github.com/repos/opensistemas-hub/osbrain/languages","stargazers_url":"https://api.github.com/repos/opensistemas-hub/osbrain/stargazers","contributors_url":"https://api.github.com/repos/opensistemas-hub/osbrain/contributors","subscribers_url":"https://api.github.com/repos/opensistemas-hub/osbrain/subscribers","subscription_url":"https://api.github.com/repos/opensistemas-hub/osbrain/subscription","commits_url":"https://api.github.com/repos/opensistemas-hub/osbrain/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensistemas-hub/osbrain/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensistemas-hub/osbrain/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensistemas-hub/osbrain/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensistemas-hub/osbrain/contents/{+path}","compare_url":"https://api.github.com/repos/opensistemas-hub/osbrain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensistemas-hub/osbrain/merges","archive_url":"https://api.github.com/repos/opensistemas-hub/osbrain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensistemas-hub/osbrain/downloads","issues_url":"https://api.github.com/repos/opensistemas-hub/osbrain/issues{/number}","pulls_url":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls{/number}","milestones_url":"https://api.github.com/repos/opensistemas-hub/osbrain/milestones{/number}","notifications_url":"https://api.github.com/repos/opensistemas-hub/osbrain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensistemas-hub/osbrain/labels{/name}","releases_url":"https://api.github.com/repos/opensistemas-hub/osbrain/releases{/id}","deployments_url":"https://api.github.com/repos/opensistemas-hub/osbrain/deployments","created_at":"2016-07-12T16:25:13Z","updated_at":"2018-02-26T00:37:39Z","pushed_at":"2018-02-26T11:32:41Z","git_url":"git://github.com/opensistemas-hub/osbrain.git","ssh_url":"git@github.com:opensistemas-hub/osbrain.git","clone_url":"https://github.com/opensistemas-hub/osbrain.git","svn_url":"https://github.com/opensistemas-hub/osbrain","homepage":"https://osbrain.readthedocs.io/en/stable/","size":646,"stargazers_count":64,"watchers_count":64,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":43,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252"},"html":{"href":"https://github.com/opensistemas-hub/osbrain/pull/252"},"issue":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/issues/252"},"comments":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/opensistemas-hub/osbrain/statuses/1daa0dde89ca4e73bb9398060eeddd9c18979cb1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ocaballeror"}}