{"action":"created","issue":{"url":"https://api.github.com/repos/drud/ddev/issues/693","repository_url":"https://api.github.com/repos/drud/ddev","labels_url":"https://api.github.com/repos/drud/ddev/issues/693/labels{/name}","comments_url":"https://api.github.com/repos/drud/ddev/issues/693/comments","events_url":"https://api.github.com/repos/drud/ddev/issues/693/events","html_url":"https://github.com/drud/ddev/pull/693","id":300986457,"number":693,"title":"Create settings file when configuring project, fixes #692","user":{"login":"mglaman","id":3698644,"avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mglaman","id":3698644,"avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false},"assignees":[{"login":"mglaman","id":3698644,"avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":37,"created_at":"2018-02-28T11:20:14Z","updated_at":"2018-03-16T16:50:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/drud/ddev/pulls/693","html_url":"https://github.com/drud/ddev/pull/693","diff_url":"https://github.com/drud/ddev/pull/693.diff","patch_url":"https://github.com/drud/ddev/pull/693.patch"},"body":"## The Problem/Issue/Bug:\r\n\r\nSee issue #692\r\n\r\n## How this PR Solves The Problem:\r\n\r\nAfter writing the project config, also write a settings files via `app.CreateSettingsFile()`\r\n\r\n## Manual Testing Instructions:\r\n\r\n## Automated Testing Overview:\r\n<!-- Please provide an overview of tests introduced by this PR, or an explanation for why no tests are needed. -->\r\n\r\n## Related Issue Link(s):\r\n\r\n#692\r\n\r\n## Release/Deployment notes:\r\n\r\n* No obvious break changes come to mind.\r\n\r\n## Remaining Tasks\r\n* [x] Error Messages: As discussed in [the following review ](https://github.com/drud/ddev/pull/693#pullrequestreview-101537297), there are syntax errors when attempting to output the message beginning with “Could not write settings file” for Drupal 6, 7, 8, Backdrop, and TYPO3.\r\n* [ ]  WordPress Local Settings:\r\n\t* [ ] We need to replicate the pattern used for Drupal by defaulting to wp-config.php if it doesn’t exist and falling back to generating wp-config-local.php if #ddev-generated is not found in wp-config.php.\r\n\t* [x] We need to fix the 500 error for WP by correcting the require_once() [syntax described here](https://github.com/drud/ddev/pull/693#issuecomment-370833403) .\r\n\t* [ ]  We need to append an inclusion of wp-config-local.php within the wp-config.php template [similar to how D8 does it]([https://github.com/drupal/drupal/blob/8.5.x/sites/default/default.settings.php#L785).\r\n* [x] Backdrop: We need to ensure the error message for Backdrop doesn’t state Drupal.\r\n* [ ] TYPO3:\r\n  * [x]  Convert Error to Warning: It's not an error to not have LocalConfiguration.php (but we should util.Warning() it.\r\n  * [ ] If AdditionalConfiguration.php does not exist, create the typo3conf directory if it doesn't exist and add our AdditionalConfiguration.php to it.\r\n  * [ ] If typo3conf/LocalConfiguration.php didn't already exist, util.Warning() them that they have to do an install manually.\r\n* [ ] Documentation: Any end-user documentation necessary to instruct users on this new workflow (@rickmanelius can address).\r\n* [ ] Config => Start: File an issue to address [this use case](https://github.com/drud/ddev/pull/693#issuecomment-370893215) where an end-user may need the settings file generated at `ddev start` (@rickmanelius)\r\n"},"comment":{"url":"https://api.github.com/repos/drud/ddev/issues/comments/373775671","html_url":"https://github.com/drud/ddev/pull/693#issuecomment-373775671","issue_url":"https://api.github.com/repos/drud/ddev/issues/693","id":373775671,"user":{"login":"mglaman","id":3698644,"avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T16:50:39Z","updated_at":"2018-03-16T16:50:39Z","author_association":"CONTRIBUTOR","body":"👍 here"}}
{"actor":{"display_login":"mglaman"}}