{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/173327552","pull_request_review_id":102502388,"id":173327552,"diff_hunk":"@@ -161,28 +162,24 @@ public void run() {\n         }\n         try {\n           InetSocketAddress destination = InetSocketAddress.createUnresolved(host, port);\n-          ProxyParameters proxy = proxyDetector.proxyFor(destination);\n+          final ProxyParameters proxy;\n+          try {\n+            proxy = proxyDetector.proxyFor(destination);\n+          } catch (Exception e) {","path":"core/src/main/java/io/grpc/internal/DnsNameResolver.java","position":null,"original_position":16,"commit_id":"2ac1eeae934d2355402f5e9ca4a2357575c38596","original_commit_id":"f8fac1eb43547549f77b69295bea1a036fa5277e","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-03-08T23:42:41Z","updated_at":"2018-03-08T23:42:41Z","html_url":"https://github.com/grpc/grpc-java/pull/4137#discussion_r173327552","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4137","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/173327552"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4137#discussion_r173327552"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4137"}},"in_reply_to_id":171639505},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4137","id":171145225,"html_url":"https://github.com/grpc/grpc-java/pull/4137","diff_url":"https://github.com/grpc/grpc-java/pull/4137.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4137.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4137","number":4137,"state":"open","locked":false,"title":"core,okhttp,netty,alts,testing: Plumb proxy resolved addr to transports","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"This PR has two commits, and the second commit has a lot of low\r\nimpact code churn due to an internal API cleanup.\r\n\r\nFirst commit:\r\n    ProxyDetector should resolve proxy address and plumb results\r\n    \r\n    ProxyDetector is now responsible for resolving the proxy's\r\n    `InetSocketAddress`, and `ProxyParameters` asserts that the address is\r\n    resolved. The results are plumbed through using a special subclass of\r\n    `SocketAddress`.\r\n    \r\n    If a proxy should be used but the proxy can not be resolved, the\r\n    `DnsNameResolver` will re-attempt the resolution later.\r\n    \r\n    Remove the unit test testing for unresolved proxy addresses, since\r\n    it's no longer applicable.\r\n\r\nSecond commit:\r\n    Plumb `ProxiedInetSocketAddress` down to transports\r\n    \r\n    Do not extract the `ProxyParameters` field and pass it into\r\n    `ClientTransportFactory.newClientTransport`.\r\n\r\n\r\nfixes #4029","created_at":"2018-02-24T00:07:30Z","updated_at":"2018-03-08T23:42:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64db4bf2da3dd0fc4a2d71d009dade655a0af144","assignee":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"assignees":[{"login":"ejona86","id":2811396,"avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4137/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4137/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4137/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/2ac1eeae934d2355402f5e9ca4a2357575c38596","head":{"label":"zpencer:plumb-proxy-resolved-addr","ref":"plumb-proxy-resolved-addr","sha":"2ac1eeae934d2355402f5e9ca4a2357575c38596","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"repo":{"id":89497167,"name":"grpc-java","full_name":"zpencer/grpc-java","owner":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zpencer/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/zpencer/grpc-java","forks_url":"https://api.github.com/repos/zpencer/grpc-java/forks","keys_url":"https://api.github.com/repos/zpencer/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zpencer/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zpencer/grpc-java/teams","hooks_url":"https://api.github.com/repos/zpencer/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/zpencer/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/zpencer/grpc-java/events","assignees_url":"https://api.github.com/repos/zpencer/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/zpencer/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/zpencer/grpc-java/tags","blobs_url":"https://api.github.com/repos/zpencer/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zpencer/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zpencer/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/zpencer/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zpencer/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/zpencer/grpc-java/languages","stargazers_url":"https://api.github.com/repos/zpencer/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/zpencer/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/zpencer/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/zpencer/grpc-java/subscription","commits_url":"https://api.github.com/repos/zpencer/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/zpencer/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/zpencer/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/zpencer/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/zpencer/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/zpencer/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zpencer/grpc-java/merges","archive_url":"https://api.github.com/repos/zpencer/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zpencer/grpc-java/downloads","issues_url":"https://api.github.com/repos/zpencer/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/zpencer/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/zpencer/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/zpencer/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zpencer/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/zpencer/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/zpencer/grpc-java/deployments","created_at":"2017-04-26T15:28:10Z","updated_at":"2017-04-26T15:28:13Z","pushed_at":"2018-03-08T23:42:27Z","git_url":"git://github.com/zpencer/grpc-java.git","ssh_url":"git@github.com:zpencer/grpc-java.git","clone_url":"https://github.com/zpencer/grpc-java.git","svn_url":"https://github.com/zpencer/grpc-java","homepage":"http://grpc.io","size":20521,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"f0eb6d2102c5d09e887c1eefd563985c1d702273","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-03-08T21:33:01Z","pushed_at":"2018-03-08T23:42:29Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":22300,"stargazers_count":3861,"watchers_count":3861,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1234,"mirror_url":null,"archived":false,"open_issues_count":367,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1234,"open_issues":367,"watchers":3861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4137"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4137"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4137"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4137/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4137/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4137/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/2ac1eeae934d2355402f5e9ca4a2357575c38596"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zpencer"}}