{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/191353841","pull_request_review_id":123907169,"id":191353841,"diff_hunk":"@@ -383,8 +383,8 @@ fileprivate extension URLSession {\n         case url(URL)\n     }\n     func createConfiguredRequest(from request: URLSession._Request) -> URLRequest {\n-        let r = request.createMutableURLRequest()\n-        _configuration.configure(request: r)\n+        var r = request.createMutableURLRequest()\n+        r = _configuration.configure(request: r)","path":"Foundation/URLSession/URLSession.swift","position":16,"original_position":16,"commit_id":"e9201e1c85eb34106c4504aedbc5909be8b6ac27","original_commit_id":"e9201e1c85eb34106c4504aedbc5909be8b6ac27","user":{"login":"ianpartridge","id":1423497,"avatar_url":"https://avatars3.githubusercontent.com/u/1423497?v=4","gravatar_id":"","url":"https://api.github.com/users/ianpartridge","html_url":"https://github.com/ianpartridge","followers_url":"https://api.github.com/users/ianpartridge/followers","following_url":"https://api.github.com/users/ianpartridge/following{/other_user}","gists_url":"https://api.github.com/users/ianpartridge/gists{/gist_id}","starred_url":"https://api.github.com/users/ianpartridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianpartridge/subscriptions","organizations_url":"https://api.github.com/users/ianpartridge/orgs","repos_url":"https://api.github.com/users/ianpartridge/repos","events_url":"https://api.github.com/users/ianpartridge/events{/privacy}","received_events_url":"https://api.github.com/users/ianpartridge/received_events","type":"User","site_admin":false},"body":"Why not just `return _configuration.configure(request: r)`?","created_at":"2018-05-29T09:11:25Z","updated_at":"2018-05-29T09:14:06Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1542#discussion_r191353841","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/191353841"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1542#discussion_r191353841"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542","id":184892312,"html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1542","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/1542.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/1542.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1542","number":1542,"state":"open","locked":false,"title":"[SR-7338] Handle cookies in URLSession","user":{"login":"mamabusi","id":17544665,"avatar_url":"https://avatars1.githubusercontent.com/u/17544665?v=4","gravatar_id":"","url":"https://api.github.com/users/mamabusi","html_url":"https://github.com/mamabusi","followers_url":"https://api.github.com/users/mamabusi/followers","following_url":"https://api.github.com/users/mamabusi/following{/other_user}","gists_url":"https://api.github.com/users/mamabusi/gists{/gist_id}","starred_url":"https://api.github.com/users/mamabusi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamabusi/subscriptions","organizations_url":"https://api.github.com/users/mamabusi/orgs","repos_url":"https://api.github.com/users/mamabusi/repos","events_url":"https://api.github.com/users/mamabusi/events{/privacy}","received_events_url":"https://api.github.com/users/mamabusi/received_events","type":"User","site_admin":false},"body":"This PR implements storage of HTTP cookies received as part of the response from the server and setting of appropriate cookies on the URLRequest of the URLSession.  ","created_at":"2018-04-30T07:20:08Z","updated_at":"2018-05-29T09:14:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c926188ef2b24016fef87f687aee243332abc070","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1542/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/e9201e1c85eb34106c4504aedbc5909be8b6ac27","head":{"label":"mamabusi:urlSessionCookies-branch","ref":"urlSessionCookies-branch","sha":"e9201e1c85eb34106c4504aedbc5909be8b6ac27","user":{"login":"mamabusi","id":17544665,"avatar_url":"https://avatars1.githubusercontent.com/u/17544665?v=4","gravatar_id":"","url":"https://api.github.com/users/mamabusi","html_url":"https://github.com/mamabusi","followers_url":"https://api.github.com/users/mamabusi/followers","following_url":"https://api.github.com/users/mamabusi/following{/other_user}","gists_url":"https://api.github.com/users/mamabusi/gists{/gist_id}","starred_url":"https://api.github.com/users/mamabusi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamabusi/subscriptions","organizations_url":"https://api.github.com/users/mamabusi/orgs","repos_url":"https://api.github.com/users/mamabusi/repos","events_url":"https://api.github.com/users/mamabusi/events{/privacy}","received_events_url":"https://api.github.com/users/mamabusi/received_events","type":"User","site_admin":false},"repo":{"id":53564035,"name":"swift-corelibs-foundation","full_name":"mamabusi/swift-corelibs-foundation","owner":{"login":"mamabusi","id":17544665,"avatar_url":"https://avatars1.githubusercontent.com/u/17544665?v=4","gravatar_id":"","url":"https://api.github.com/users/mamabusi","html_url":"https://github.com/mamabusi","followers_url":"https://api.github.com/users/mamabusi/followers","following_url":"https://api.github.com/users/mamabusi/following{/other_user}","gists_url":"https://api.github.com/users/mamabusi/gists{/gist_id}","starred_url":"https://api.github.com/users/mamabusi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamabusi/subscriptions","organizations_url":"https://api.github.com/users/mamabusi/orgs","repos_url":"https://api.github.com/users/mamabusi/repos","events_url":"https://api.github.com/users/mamabusi/events{/privacy}","received_events_url":"https://api.github.com/users/mamabusi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mamabusi/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/mamabusi/swift-corelibs-foundation/deployments","created_at":"2016-03-10T07:21:08Z","updated_at":"2018-04-30T04:29:19Z","pushed_at":"2018-04-30T07:08:11Z","git_url":"git://github.com/mamabusi/swift-corelibs-foundation.git","ssh_url":"git@github.com:mamabusi/swift-corelibs-foundation.git","clone_url":"https://github.com/mamabusi/swift-corelibs-foundation.git","svn_url":"https://github.com/mamabusi/swift-corelibs-foundation","homepage":"swift.org","size":12468,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"387259544134c533a3af10b84ec9f031aa011d02","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2018-05-28T16:54:26Z","pushed_at":"2018-05-29T01:11:14Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":12822,"stargazers_count":2941,"watchers_count":2941,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":707,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":707,"open_issues":33,"watchers":2941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1542"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1542"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1542/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1542/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/e9201e1c85eb34106c4504aedbc5909be8b6ac27"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ianpartridge"}}