{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-R/protoloads/pulls/comments/193458671","pull_request_review_id":126435395,"id":193458671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ1ODY3MQ==","diff_hunk":"@@ -60,9 +62,11 @@ prep_inputs <- function(\n     EGRET::populateDaily(qConvert=q_divisor, verbose = FALSE)\n   #Daily <- readNWISDaily(\"06934500\",\"00060\",\"1979-10-01\",\"2010-09-30\")\n   if(any(is.na(flow$Q)) || any(is.na(flow$LogQ))) {\n+    noQ_dates <- filter(flow_conc, is.na(Q) | is.na(LogQ)) %>% pull(Date)","path":"3_forecast/src/prep_inputs.R","position":65,"original_position":65,"commit_id":"30c2346e8e94340e9c042a1efec1a760c58f30e9","original_commit_id":"30c2346e8e94340e9c042a1efec1a760c58f30e9","user":{"login":"jzwart","id":4825431,"node_id":"MDQ6VXNlcjQ4MjU0MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4825431?v=4","gravatar_id":"","url":"https://api.github.com/users/jzwart","html_url":"https://github.com/jzwart","followers_url":"https://api.github.com/users/jzwart/followers","following_url":"https://api.github.com/users/jzwart/following{/other_user}","gists_url":"https://api.github.com/users/jzwart/gists{/gist_id}","starred_url":"https://api.github.com/users/jzwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzwart/subscriptions","organizations_url":"https://api.github.com/users/jzwart/orgs","repos_url":"https://api.github.com/users/jzwart/repos","events_url":"https://api.github.com/users/jzwart/events{/privacy}","received_events_url":"https://api.github.com/users/jzwart/received_events","type":"User","site_admin":false},"body":"could you specify `dplyr::filter` ","created_at":"2018-06-06T15:40:51Z","updated_at":"2018-06-06T15:40:51Z","html_url":"https://github.com/USGS-R/protoloads/pull/66#discussion_r193458671","pull_request_url":"https://api.github.com/repos/USGS-R/protoloads/pulls/66","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/USGS-R/protoloads/pulls/comments/193458671"},"html":{"href":"https://github.com/USGS-R/protoloads/pull/66#discussion_r193458671"},"pull_request":{"href":"https://api.github.com/repos/USGS-R/protoloads/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-R/protoloads/pulls/66","id":192891370,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODkxMzcw","html_url":"https://github.com/USGS-R/protoloads/pull/66","diff_url":"https://github.com/USGS-R/protoloads/pull/66.diff","patch_url":"https://github.com/USGS-R/protoloads/pull/66.patch","issue_url":"https://api.github.com/repos/USGS-R/protoloads/issues/66","number":66,"state":"open","locked":false,"title":"reaggregate, launch rerun of models","user":{"login":"aappling-usgs","id":12039957,"node_id":"MDQ6VXNlcjEyMDM5OTU3","avatar_url":"https://avatars0.githubusercontent.com/u/12039957?v=4","gravatar_id":"","url":"https://api.github.com/users/aappling-usgs","html_url":"https://github.com/aappling-usgs","followers_url":"https://api.github.com/users/aappling-usgs/followers","following_url":"https://api.github.com/users/aappling-usgs/following{/other_user}","gists_url":"https://api.github.com/users/aappling-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/aappling-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aappling-usgs/subscriptions","organizations_url":"https://api.github.com/users/aappling-usgs/orgs","repos_url":"https://api.github.com/users/aappling-usgs/repos","events_url":"https://api.github.com/users/aappling-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/aappling-usgs/received_events","type":"User","site_admin":false},"body":"models are running now. did some checks - the aggregated data look like i expected\r\n\r\nretro:\r\n![image](https://user-images.githubusercontent.com/12039957/41015644-0f23bb78-6900-11e8-90ef-bf6fd7ebeea5.png)\r\n\r\nanalysis:\r\n![image](https://user-images.githubusercontent.com/12039957/41015650-15a86d0e-6900-11e8-8106-44117a823ff0.png)\r\n\r\nmed:\r\n![image](https://user-images.githubusercontent.com/12039957/41015632-01cff8ba-6900-11e8-8ecd-f6dbacf619d3.png)\r\n\r\na long:\r\n![image](https://user-images.githubusercontent.com/12039957/41015626-f7836f54-68ff-11e8-9127-2ef7b6792174.png)\r\n","created_at":"2018-06-06T03:36:38Z","updated_at":"2018-06-06T15:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"348a02f68fb2f55b681ed01f2572ab715bf2149e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/protoloads/pulls/66/commits","review_comments_url":"https://api.github.com/repos/USGS-R/protoloads/pulls/66/comments","review_comment_url":"https://api.github.com/repos/USGS-R/protoloads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/protoloads/issues/66/comments","statuses_url":"https://api.github.com/repos/USGS-R/protoloads/statuses/30c2346e8e94340e9c042a1efec1a760c58f30e9","head":{"label":"aappling-usgs:rerun-models","ref":"rerun-models","sha":"30c2346e8e94340e9c042a1efec1a760c58f30e9","user":{"login":"aappling-usgs","id":12039957,"node_id":"MDQ6VXNlcjEyMDM5OTU3","avatar_url":"https://avatars0.githubusercontent.com/u/12039957?v=4","gravatar_id":"","url":"https://api.github.com/users/aappling-usgs","html_url":"https://github.com/aappling-usgs","followers_url":"https://api.github.com/users/aappling-usgs/followers","following_url":"https://api.github.com/users/aappling-usgs/following{/other_user}","gists_url":"https://api.github.com/users/aappling-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/aappling-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aappling-usgs/subscriptions","organizations_url":"https://api.github.com/users/aappling-usgs/orgs","repos_url":"https://api.github.com/users/aappling-usgs/repos","events_url":"https://api.github.com/users/aappling-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/aappling-usgs/received_events","type":"User","site_admin":false},"repo":{"id":131647878,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2NDc4Nzg=","name":"protoloads","full_name":"aappling-usgs/protoloads","owner":{"login":"aappling-usgs","id":12039957,"node_id":"MDQ6VXNlcjEyMDM5OTU3","avatar_url":"https://avatars0.githubusercontent.com/u/12039957?v=4","gravatar_id":"","url":"https://api.github.com/users/aappling-usgs","html_url":"https://github.com/aappling-usgs","followers_url":"https://api.github.com/users/aappling-usgs/followers","following_url":"https://api.github.com/users/aappling-usgs/following{/other_user}","gists_url":"https://api.github.com/users/aappling-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/aappling-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aappling-usgs/subscriptions","organizations_url":"https://api.github.com/users/aappling-usgs/orgs","repos_url":"https://api.github.com/users/aappling-usgs/repos","events_url":"https://api.github.com/users/aappling-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/aappling-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aappling-usgs/protoloads","description":"Prototyping and exploring options for broad-scale load forecasting","fork":true,"url":"https://api.github.com/repos/aappling-usgs/protoloads","forks_url":"https://api.github.com/repos/aappling-usgs/protoloads/forks","keys_url":"https://api.github.com/repos/aappling-usgs/protoloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aappling-usgs/protoloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aappling-usgs/protoloads/teams","hooks_url":"https://api.github.com/repos/aappling-usgs/protoloads/hooks","issue_events_url":"https://api.github.com/repos/aappling-usgs/protoloads/issues/events{/number}","events_url":"https://api.github.com/repos/aappling-usgs/protoloads/events","assignees_url":"https://api.github.com/repos/aappling-usgs/protoloads/assignees{/user}","branches_url":"https://api.github.com/repos/aappling-usgs/protoloads/branches{/branch}","tags_url":"https://api.github.com/repos/aappling-usgs/protoloads/tags","blobs_url":"https://api.github.com/repos/aappling-usgs/protoloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aappling-usgs/protoloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aappling-usgs/protoloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/aappling-usgs/protoloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aappling-usgs/protoloads/statuses/{sha}","languages_url":"https://api.github.com/repos/aappling-usgs/protoloads/languages","stargazers_url":"https://api.github.com/repos/aappling-usgs/protoloads/stargazers","contributors_url":"https://api.github.com/repos/aappling-usgs/protoloads/contributors","subscribers_url":"https://api.github.com/repos/aappling-usgs/protoloads/subscribers","subscription_url":"https://api.github.com/repos/aappling-usgs/protoloads/subscription","commits_url":"https://api.github.com/repos/aappling-usgs/protoloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/aappling-usgs/protoloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/aappling-usgs/protoloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/aappling-usgs/protoloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/aappling-usgs/protoloads/contents/{+path}","compare_url":"https://api.github.com/repos/aappling-usgs/protoloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aappling-usgs/protoloads/merges","archive_url":"https://api.github.com/repos/aappling-usgs/protoloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aappling-usgs/protoloads/downloads","issues_url":"https://api.github.com/repos/aappling-usgs/protoloads/issues{/number}","pulls_url":"https://api.github.com/repos/aappling-usgs/protoloads/pulls{/number}","milestones_url":"https://api.github.com/repos/aappling-usgs/protoloads/milestones{/number}","notifications_url":"https://api.github.com/repos/aappling-usgs/protoloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aappling-usgs/protoloads/labels{/name}","releases_url":"https://api.github.com/repos/aappling-usgs/protoloads/releases{/id}","deployments_url":"https://api.github.com/repos/aappling-usgs/protoloads/deployments","created_at":"2018-04-30T21:21:42Z","updated_at":"2018-06-03T21:41:22Z","pushed_at":"2018-06-06T03:34:02Z","git_url":"git://github.com/aappling-usgs/protoloads.git","ssh_url":"git@github.com:aappling-usgs/protoloads.git","clone_url":"https://github.com/aappling-usgs/protoloads.git","svn_url":"https://github.com/aappling-usgs/protoloads","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:master","ref":"master","sha":"760c1790e9114d91476da4f1fe0916e00e77172a","user":{"login":"USGS-R","id":3188813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODg4MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3188813?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":131645426,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2NDU0MjY=","name":"protoloads","full_name":"USGS-R/protoloads","owner":{"login":"USGS-R","id":3188813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODg4MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3188813?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-R/protoloads","description":"Prototyping and exploring options for broad-scale load forecasting","fork":false,"url":"https://api.github.com/repos/USGS-R/protoloads","forks_url":"https://api.github.com/repos/USGS-R/protoloads/forks","keys_url":"https://api.github.com/repos/USGS-R/protoloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/protoloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/protoloads/teams","hooks_url":"https://api.github.com/repos/USGS-R/protoloads/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/protoloads/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/protoloads/events","assignees_url":"https://api.github.com/repos/USGS-R/protoloads/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/protoloads/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/protoloads/tags","blobs_url":"https://api.github.com/repos/USGS-R/protoloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/protoloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/protoloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/protoloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/protoloads/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/protoloads/languages","stargazers_url":"https://api.github.com/repos/USGS-R/protoloads/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/protoloads/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/protoloads/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/protoloads/subscription","commits_url":"https://api.github.com/repos/USGS-R/protoloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/protoloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/protoloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/protoloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/protoloads/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/protoloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/protoloads/merges","archive_url":"https://api.github.com/repos/USGS-R/protoloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/protoloads/downloads","issues_url":"https://api.github.com/repos/USGS-R/protoloads/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/protoloads/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/protoloads/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/protoloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/protoloads/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/protoloads/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/protoloads/deployments","created_at":"2018-04-30T20:52:33Z","updated_at":"2018-06-06T01:05:11Z","pushed_at":"2018-06-06T03:36:39Z","git_url":"git://github.com/USGS-R/protoloads.git","ssh_url":"git@github.com:USGS-R/protoloads.git","clone_url":"https://github.com/USGS-R/protoloads.git","svn_url":"https://github.com/USGS-R/protoloads","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":4,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/protoloads/pulls/66"},"html":{"href":"https://github.com/USGS-R/protoloads/pull/66"},"issue":{"href":"https://api.github.com/repos/USGS-R/protoloads/issues/66"},"comments":{"href":"https://api.github.com/repos/USGS-R/protoloads/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/protoloads/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/protoloads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/protoloads/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/protoloads/statuses/30c2346e8e94340e9c042a1efec1a760c58f30e9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jzwart"}}