{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69941","id":371247819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzM4MzI1","number":69941,"title":"Fix golint issues in plugin/pkg/admission","user":{"login":"miguelbernadi","id":731219,"node_id":"MDQ6VXNlcjczMTIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/731219?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbernadi","html_url":"https://github.com/miguelbernadi","followers_url":"https://api.github.com/users/miguelbernadi/followers","following_url":"https://api.github.com/users/miguelbernadi/following{/other_user}","gists_url":"https://api.github.com/users/miguelbernadi/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbernadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbernadi/subscriptions","organizations_url":"https://api.github.com/users/miguelbernadi/orgs","repos_url":"https://api.github.com/users/miguelbernadi/repos","events_url":"https://api.github.com/users/miguelbernadi/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbernadi/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":617149945,"node_id":"MDU6TGFiZWw2MTcxNDk5NDU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-17T20:11:50Z","updated_at":"2018-10-18T04:33:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69941","html_url":"https://github.com/kubernetes/kubernetes/pull/69941","diff_url":"https://github.com/kubernetes/kubernetes/pull/69941.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69941.patch"},"body":"**What this PR does / why we need it**:\r\nFix golint violations in plugin/pkg/admission tree, as reported in #68026 \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nThis is still WIP. I'm doing a commit per package for now, with the option to eventually squash the result.\r\n\r\nI've added some comments were guidance would be welcome regarding how to tackle some issues, or if to ignore them in this PR.\r\n\r\n**Release note**:\r\n```\r\nNONE\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/430872115","html_url":"https://github.com/kubernetes/kubernetes/pull/69941#issuecomment-430872115","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941","id":430872115,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDg3MjExNQ==","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T04:33:41Z","updated_at":"2018-10-18T04:33:41Z","author_association":"CONTRIBUTOR","body":"> golint suggest the same for podNodeSelector, podPreset, podTolerations and serviceAccount as for nodePlugin. Once the types are exported there will probably be some stutter complaint.\r\n\r\nexporting these will be fine i suppose. renaming them to `Plugin`"}}
{"actor":{"display_login":"yue9944882"}}