{"action":"created","comment":{"url":"https://api.github.com/repos/proper-testing/proper/pulls/comments/195940787","pull_request_review_id":129400425,"id":195940787,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk0MDc4Nw==","diff_hunk":"@@ -35,9 +37,22 @@\n {erl_opts, [debug_info,\n \t    report_warnings, {warn_format,1}, warn_export_vars,\n \t    warn_obsolete_guard, warn_unused_import,\n-\t    warn_missing_spec, warn_untyped_record]}.\n+\t    warn_missing_spec, warn_untyped_record,\n+\t    warn_unused_vars,\n+\t    {platform_define, \"^17\", 'USE_ERL_SCAN_LINE'},\n+\t    {platform_define, \"^19|^2\", 'AT_LEAST_19'},\n+\t    {platform_define, \"^2\", 'AT_LEAST_20'},\n+\t    {platform_define, \"^2[1-9]\", 'AT_LEAST_21'}]}.\n \n-{pre_hooks, [{\"(linux|darwin|gnu)\", compile, \"make include/compile_flags.hrl\"},\n-             {\"(freebsd|netbsd|openbsd|solaris|dragonfly)\", compile, \"gmake include/compile_flags.hrl\"},\n-\t     {\"win32\", compile, \"escript.exe write_compile_flags include/compile_flags.hrl\"}]}.\n {post_hooks, [{clean, \"./clean_doc.sh\"}]}.\n+\n+{dialyzer, [{warnings, [unmatched_returns\n+                       ]}\n+           ,{plt_extra_apps, [erts, kernel, stdlib, compiler, crypto, syntax_tools]}","path":"rebar.config","position":28,"original_position":28,"commit_id":"91de7f8b40ce6de280c0c0b6b6b3d8333f4b42a0","original_commit_id":"91de7f8b40ce6de280c0c0b6b6b3d8333f4b42a0","user":{"login":"kostis","id":165033,"node_id":"MDQ6VXNlcjE2NTAzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/165033?v=4","gravatar_id":"","url":"https://api.github.com/users/kostis","html_url":"https://github.com/kostis","followers_url":"https://api.github.com/users/kostis/followers","following_url":"https://api.github.com/users/kostis/following{/other_user}","gists_url":"https://api.github.com/users/kostis/gists{/gist_id}","starred_url":"https://api.github.com/users/kostis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostis/subscriptions","organizations_url":"https://api.github.com/users/kostis/orgs","repos_url":"https://api.github.com/users/kostis/repos","events_url":"https://api.github.com/users/kostis/events{/privacy}","received_events_url":"https://api.github.com/users/kostis/received_events","type":"User","site_admin":false},"body":"Please follow the style of the rest of the file.","created_at":"2018-06-17T20:44:29Z","updated_at":"2018-06-17T20:44:29Z","html_url":"https://github.com/proper-testing/proper/pull/173#discussion_r195940787","pull_request_url":"https://api.github.com/repos/proper-testing/proper/pulls/173","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/proper-testing/proper/pulls/comments/195940787"},"html":{"href":"https://github.com/proper-testing/proper/pull/173#discussion_r195940787"},"pull_request":{"href":"https://api.github.com/repos/proper-testing/proper/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/proper-testing/proper/pulls/173","id":195390448,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzkwNDQ4","html_url":"https://github.com/proper-testing/proper/pull/173","diff_url":"https://github.com/proper-testing/proper/pull/173.diff","patch_url":"https://github.com/proper-testing/proper/pull/173.patch","issue_url":"https://api.github.com/repos/proper-testing/proper/issues/173","number":173,"state":"open","locked":false,"title":"r3: simplify build","user":{"login":"fenollp","id":278727,"node_id":"MDQ6VXNlcjI3ODcyNw==","avatar_url":"https://avatars3.githubusercontent.com/u/278727?v=4","gravatar_id":"","url":"https://api.github.com/users/fenollp","html_url":"https://github.com/fenollp","followers_url":"https://api.github.com/users/fenollp/followers","following_url":"https://api.github.com/users/fenollp/following{/other_user}","gists_url":"https://api.github.com/users/fenollp/gists{/gist_id}","starred_url":"https://api.github.com/users/fenollp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenollp/subscriptions","organizations_url":"https://api.github.com/users/fenollp/orgs","repos_url":"https://api.github.com/users/fenollp/repos","events_url":"https://api.github.com/users/fenollp/events{/privacy}","received_events_url":"https://api.github.com/users/fenollp/received_events","type":"User","site_admin":false},"body":"This is the build system simplification extracted from #168 \r\nIt makes use of the rebar `platform_define` to not require writing an HRL to the filesystem. This option is supported by rebar, rebar3 and the custom patched rebar that is bundled in this repo.\r\n\r\nThe idea is to simplify/standardize the build process so that one day a custom patched rebar would not need to be part of this repo as well as making development easier long term for contributors that use rebar3.","created_at":"2018-06-17T19:00:32Z","updated_at":"2018-06-17T20:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28280498c4c4da213d41c55fa2fa6dce815de65e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/proper-testing/proper/pulls/173/commits","review_comments_url":"https://api.github.com/repos/proper-testing/proper/pulls/173/comments","review_comment_url":"https://api.github.com/repos/proper-testing/proper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/proper-testing/proper/issues/173/comments","statuses_url":"https://api.github.com/repos/proper-testing/proper/statuses/91de7f8b40ce6de280c0c0b6b6b3d8333f4b42a0","head":{"label":"fenollp:r3","ref":"r3","sha":"91de7f8b40ce6de280c0c0b6b6b3d8333f4b42a0","user":{"login":"fenollp","id":278727,"node_id":"MDQ6VXNlcjI3ODcyNw==","avatar_url":"https://avatars3.githubusercontent.com/u/278727?v=4","gravatar_id":"","url":"https://api.github.com/users/fenollp","html_url":"https://github.com/fenollp","followers_url":"https://api.github.com/users/fenollp/followers","following_url":"https://api.github.com/users/fenollp/following{/other_user}","gists_url":"https://api.github.com/users/fenollp/gists{/gist_id}","starred_url":"https://api.github.com/users/fenollp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenollp/subscriptions","organizations_url":"https://api.github.com/users/fenollp/orgs","repos_url":"https://api.github.com/users/fenollp/repos","events_url":"https://api.github.com/users/fenollp/events{/privacy}","received_events_url":"https://api.github.com/users/fenollp/received_events","type":"User","site_admin":false},"repo":{"id":55360932,"node_id":"MDEwOlJlcG9zaXRvcnk1NTM2MDkzMg==","name":"proper","full_name":"fenollp/proper","owner":{"login":"fenollp","id":278727,"node_id":"MDQ6VXNlcjI3ODcyNw==","avatar_url":"https://avatars3.githubusercontent.com/u/278727?v=4","gravatar_id":"","url":"https://api.github.com/users/fenollp","html_url":"https://github.com/fenollp","followers_url":"https://api.github.com/users/fenollp/followers","following_url":"https://api.github.com/users/fenollp/following{/other_user}","gists_url":"https://api.github.com/users/fenollp/gists{/gist_id}","starred_url":"https://api.github.com/users/fenollp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenollp/subscriptions","organizations_url":"https://api.github.com/users/fenollp/orgs","repos_url":"https://api.github.com/users/fenollp/repos","events_url":"https://api.github.com/users/fenollp/events{/privacy}","received_events_url":"https://api.github.com/users/fenollp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fenollp/proper","description":"PropEr: a QuickCheck-inspired property-based testing tool for Erlang","fork":true,"url":"https://api.github.com/repos/fenollp/proper","forks_url":"https://api.github.com/repos/fenollp/proper/forks","keys_url":"https://api.github.com/repos/fenollp/proper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fenollp/proper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fenollp/proper/teams","hooks_url":"https://api.github.com/repos/fenollp/proper/hooks","issue_events_url":"https://api.github.com/repos/fenollp/proper/issues/events{/number}","events_url":"https://api.github.com/repos/fenollp/proper/events","assignees_url":"https://api.github.com/repos/fenollp/proper/assignees{/user}","branches_url":"https://api.github.com/repos/fenollp/proper/branches{/branch}","tags_url":"https://api.github.com/repos/fenollp/proper/tags","blobs_url":"https://api.github.com/repos/fenollp/proper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fenollp/proper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fenollp/proper/git/refs{/sha}","trees_url":"https://api.github.com/repos/fenollp/proper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fenollp/proper/statuses/{sha}","languages_url":"https://api.github.com/repos/fenollp/proper/languages","stargazers_url":"https://api.github.com/repos/fenollp/proper/stargazers","contributors_url":"https://api.github.com/repos/fenollp/proper/contributors","subscribers_url":"https://api.github.com/repos/fenollp/proper/subscribers","subscription_url":"https://api.github.com/repos/fenollp/proper/subscription","commits_url":"https://api.github.com/repos/fenollp/proper/commits{/sha}","git_commits_url":"https://api.github.com/repos/fenollp/proper/git/commits{/sha}","comments_url":"https://api.github.com/repos/fenollp/proper/comments{/number}","issue_comment_url":"https://api.github.com/repos/fenollp/proper/issues/comments{/number}","contents_url":"https://api.github.com/repos/fenollp/proper/contents/{+path}","compare_url":"https://api.github.com/repos/fenollp/proper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fenollp/proper/merges","archive_url":"https://api.github.com/repos/fenollp/proper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fenollp/proper/downloads","issues_url":"https://api.github.com/repos/fenollp/proper/issues{/number}","pulls_url":"https://api.github.com/repos/fenollp/proper/pulls{/number}","milestones_url":"https://api.github.com/repos/fenollp/proper/milestones{/number}","notifications_url":"https://api.github.com/repos/fenollp/proper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fenollp/proper/labels{/name}","releases_url":"https://api.github.com/repos/fenollp/proper/releases{/id}","deployments_url":"https://api.github.com/repos/fenollp/proper/deployments","created_at":"2016-04-03T18:05:59Z","updated_at":"2018-06-17T18:37:46Z","pushed_at":"2018-06-17T18:54:53Z","git_url":"git://github.com/fenollp/proper.git","ssh_url":"git@github.com:fenollp/proper.git","clone_url":"https://github.com/fenollp/proper.git","svn_url":"https://github.com/fenollp/proper","homepage":"http://proper.softlab.ntua.gr/","size":2819,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"proper-testing:master","ref":"master","sha":"070622b576a9fe1212cab4ea2efe57d4de79c9b0","user":{"login":"proper-testing","id":39092335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDkyMzM1","avatar_url":"https://avatars0.githubusercontent.com/u/39092335?v=4","gravatar_id":"","url":"https://api.github.com/users/proper-testing","html_url":"https://github.com/proper-testing","followers_url":"https://api.github.com/users/proper-testing/followers","following_url":"https://api.github.com/users/proper-testing/following{/other_user}","gists_url":"https://api.github.com/users/proper-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/proper-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proper-testing/subscriptions","organizations_url":"https://api.github.com/users/proper-testing/orgs","repos_url":"https://api.github.com/users/proper-testing/repos","events_url":"https://api.github.com/users/proper-testing/events{/privacy}","received_events_url":"https://api.github.com/users/proper-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":697866,"node_id":"MDEwOlJlcG9zaXRvcnk2OTc4NjY=","name":"proper","full_name":"proper-testing/proper","owner":{"login":"proper-testing","id":39092335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDkyMzM1","avatar_url":"https://avatars0.githubusercontent.com/u/39092335?v=4","gravatar_id":"","url":"https://api.github.com/users/proper-testing","html_url":"https://github.com/proper-testing","followers_url":"https://api.github.com/users/proper-testing/followers","following_url":"https://api.github.com/users/proper-testing/following{/other_user}","gists_url":"https://api.github.com/users/proper-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/proper-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proper-testing/subscriptions","organizations_url":"https://api.github.com/users/proper-testing/orgs","repos_url":"https://api.github.com/users/proper-testing/repos","events_url":"https://api.github.com/users/proper-testing/events{/privacy}","received_events_url":"https://api.github.com/users/proper-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/proper-testing/proper","description":"PropEr: a QuickCheck-inspired property-based testing tool for Erlang","fork":false,"url":"https://api.github.com/repos/proper-testing/proper","forks_url":"https://api.github.com/repos/proper-testing/proper/forks","keys_url":"https://api.github.com/repos/proper-testing/proper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proper-testing/proper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proper-testing/proper/teams","hooks_url":"https://api.github.com/repos/proper-testing/proper/hooks","issue_events_url":"https://api.github.com/repos/proper-testing/proper/issues/events{/number}","events_url":"https://api.github.com/repos/proper-testing/proper/events","assignees_url":"https://api.github.com/repos/proper-testing/proper/assignees{/user}","branches_url":"https://api.github.com/repos/proper-testing/proper/branches{/branch}","tags_url":"https://api.github.com/repos/proper-testing/proper/tags","blobs_url":"https://api.github.com/repos/proper-testing/proper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proper-testing/proper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proper-testing/proper/git/refs{/sha}","trees_url":"https://api.github.com/repos/proper-testing/proper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proper-testing/proper/statuses/{sha}","languages_url":"https://api.github.com/repos/proper-testing/proper/languages","stargazers_url":"https://api.github.com/repos/proper-testing/proper/stargazers","contributors_url":"https://api.github.com/repos/proper-testing/proper/contributors","subscribers_url":"https://api.github.com/repos/proper-testing/proper/subscribers","subscription_url":"https://api.github.com/repos/proper-testing/proper/subscription","commits_url":"https://api.github.com/repos/proper-testing/proper/commits{/sha}","git_commits_url":"https://api.github.com/repos/proper-testing/proper/git/commits{/sha}","comments_url":"https://api.github.com/repos/proper-testing/proper/comments{/number}","issue_comment_url":"https://api.github.com/repos/proper-testing/proper/issues/comments{/number}","contents_url":"https://api.github.com/repos/proper-testing/proper/contents/{+path}","compare_url":"https://api.github.com/repos/proper-testing/proper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proper-testing/proper/merges","archive_url":"https://api.github.com/repos/proper-testing/proper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proper-testing/proper/downloads","issues_url":"https://api.github.com/repos/proper-testing/proper/issues{/number}","pulls_url":"https://api.github.com/repos/proper-testing/proper/pulls{/number}","milestones_url":"https://api.github.com/repos/proper-testing/proper/milestones{/number}","notifications_url":"https://api.github.com/repos/proper-testing/proper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proper-testing/proper/labels{/name}","releases_url":"https://api.github.com/repos/proper-testing/proper/releases{/id}","deployments_url":"https://api.github.com/repos/proper-testing/proper/deployments","created_at":"2010-06-01T19:41:33Z","updated_at":"2018-06-15T15:46:08Z","pushed_at":"2018-06-17T19:00:33Z","git_url":"git://github.com/proper-testing/proper.git","ssh_url":"git@github.com:proper-testing/proper.git","clone_url":"https://github.com/proper-testing/proper.git","svn_url":"https://github.com/proper-testing/proper","homepage":"http://proper-testing.github.io","size":2795,"stargazers_count":580,"watchers_count":580,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":122,"open_issues":34,"watchers":580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/proper-testing/proper/pulls/173"},"html":{"href":"https://github.com/proper-testing/proper/pull/173"},"issue":{"href":"https://api.github.com/repos/proper-testing/proper/issues/173"},"comments":{"href":"https://api.github.com/repos/proper-testing/proper/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/proper-testing/proper/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/proper-testing/proper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/proper-testing/proper/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/proper-testing/proper/statuses/91de7f8b40ce6de280c0c0b6b6b3d8333f4b42a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kostis"}}