{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64471","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64471/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64471/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64471/events","html_url":"https://github.com/kubernetes/kubernetes/pull/64471","id":327460549,"number":64471,"title":"Allow for mixed UDP/TCP ports on LoadBalancer Services","user":{"login":"Miouge1","id":13647208,"avatar_url":"https://avatars0.githubusercontent.com/u/13647208?v=4","gravatar_id":"","url":"https://api.github.com/users/Miouge1","html_url":"https://github.com/Miouge1","followers_url":"https://api.github.com/users/Miouge1/followers","following_url":"https://api.github.com/users/Miouge1/following{/other_user}","gists_url":"https://api.github.com/users/Miouge1/gists{/gist_id}","starred_url":"https://api.github.com/users/Miouge1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miouge1/subscriptions","organizations_url":"https://api.github.com/users/Miouge1/orgs","repos_url":"https://api.github.com/users/Miouge1/repos","events_url":"https://api.github.com/users/Miouge1/events{/privacy}","received_events_url":"https://api.github.com/users/Miouge1/received_events","type":"User","site_admin":false},"labels":[{"id":573014062,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-29T19:43:37Z","updated_at":"2018-05-29T19:43:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64471","html_url":"https://github.com/kubernetes/kubernetes/pull/64471","diff_url":"https://github.com/kubernetes/kubernetes/pull/64471.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/64471.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAllows for LoadBalancer Services to have both TCP and UDP ports.\r\n\r\nSome LoadBalancer implementations support mixed TCP and UDP services on a single Service of type=LoadBalancer, like [metallb](https://metallb.universe.tf/usage/).\r\n\r\nSo far users are forced to workaround this by creating 2 services like so:\r\n```\r\napiVersion: v1\r\nkind: Service\r\nmetadata:\r\n  name: example-tcp\r\n  annotations:\r\n    metallb.universe.tf/allow-shared-ip: mykey\r\nspec:\r\n  ports:\r\n  - port: 1234\r\n    targetPort: 1234\r\n    protocol: TCP\r\n  selector:\r\n    app: example\r\n  type: LoadBalancer\r\n  loadBalancerIP: 192.168.1.240\r\n\r\n---\r\napiVersion: v1\r\nkind: Service\r\nmetadata:\r\n  name: example-udp\r\n  annotations:\r\n    metallb.universe.tf/allow-shared-ip: mykey\r\nspec:\r\n  ports:\r\n  - port: 1234\r\n    targetPort: 1234\r\n    protocol: UDP\r\n  selector:\r\n    app: example\r\n  type: LoadBalancer\r\n  loadBalancerIP: 192.168.1.240\r\n```\r\nInstead of a clearer service manifest:\r\n```\r\napiVersion: v1\r\nkind: Service\r\nmetadata:\r\n  name: example-app\r\nspec:\r\n  ports:\r\n  - port: 1234\r\n    targetPort: 1234\r\n    protocol: TCP\r\n  - port: 1234\r\n    targetPort: 1234\r\n    protocol: UDP\r\n  selector:\r\n    app: example\r\n  type: LoadBalancer\r\n  loadBalancerIP: 192.168.1.240\r\n```\r\n\r\n**Which issue(s) this PR fixes**\r\nFixes #23880, #35752\r\n\r\n**Special notes for your reviewer**:\r\nThis is kind of like if the `Ingress` manifests didn't allow for mixed HTTP and HTTPS Ingress because not all Ingress controller implementation supported it.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAllow for mixed UDP/TCP ports on type=LoadBalancer Services\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/392918003","html_url":"https://github.com/kubernetes/kubernetes/pull/64471#issuecomment-392918003","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64471","id":392918003,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T19:43:44Z","updated_at":"2018-05-29T19:43:44Z","author_association":"COLLABORATOR","body":"Hi @Miouge1. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}