{"action":"opened","issue":{"url":"https://api.github.com/repos/Microsoft/omi/issues/496","repository_url":"https://api.github.com/repos/Microsoft/omi","labels_url":"https://api.github.com/repos/Microsoft/omi/issues/496/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/omi/issues/496/comments","events_url":"https://api.github.com/repos/Microsoft/omi/issues/496/events","html_url":"https://github.com/Microsoft/omi/issues/496","id":306331004,"number":496,"title":"Header naming conflict causes build failures","user":{"login":"lf-","id":6652840,"avatar_url":"https://avatars0.githubusercontent.com/u/6652840?v=4","gravatar_id":"","url":"https://api.github.com/users/lf-","html_url":"https://github.com/lf-","followers_url":"https://api.github.com/users/lf-/followers","following_url":"https://api.github.com/users/lf-/following{/other_user}","gists_url":"https://api.github.com/users/lf-/gists{/gist_id}","starred_url":"https://api.github.com/users/lf-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lf-/subscriptions","organizations_url":"https://api.github.com/users/lf-/orgs","repos_url":"https://api.github.com/users/lf-/repos","events_url":"https://api.github.com/users/lf-/events{/privacy}","received_events_url":"https://api.github.com/users/lf-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-19T04:35:38Z","updated_at":"2018-03-19T04:35:38Z","closed_at":null,"author_association":"NONE","body":"On my system, omi is failing to build because of some header include issues. It is evident that these are caused by a name conflict from strings.h in /usr/include and the strings.h from this project.\r\n\r\nLine 431 of /usr/include/string.h is: `# include <strings.h>`.\r\n\r\nSo, due to `palcommon.h` including `string.h`, which in turn includes `strings.h`, which gets incorrectly resolved as the one in this project's directory, the build fails.\r\n\r\nThis is an Arch Linux system, with gcc 7.3.0. This bug also affects psl-omi-provider as far as I can tell.\r\n\r\n```\r\nsrc/omi-1.1.0-0 » cd Unix \r\nomi-1.1.0-0/Unix » make\r\n========================= Performing Building OMI\r\n( cd /home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix; make -f build.mak )\r\nmake[1]: Entering directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix'\r\nmake[2]: Entering directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/chkshlib'\r\nmake[2]: Nothing to be done for 'all'.\r\nmake[2]: Leaving directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/chkshlib'\r\nmake[2]: Entering directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/tools'\r\nmake[3]: Entering directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/tools/mkdep'\r\nmake[3]: Nothing to be done for 'all'.\r\nmake[3]: Leaving directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/tools/mkdep'\r\nmake[2]: Leaving directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/tools'\r\nmake[2]: Entering directory '/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/pal'\r\ngcc -c -o /home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/output/obj/pal/atomic.o -g -O2 -fPIC -Wall -fvisibility=hidden -fno-strict-aliasing -D_GNU_SOURCE -D_XOPEN_SOURCE=600 -D_BSD_SOURCE  -I/home/lf/.cache/aursync/omi/src/omi-1.1.0-0/Unix/output/include -I. -I.. -I../common -DHOOK_BUILD atomic.c \r\nIn file included from /usr/include/bits/libc-header-start.h:33:0,\r\n                 from /usr/include/stdlib.h:25,\r\n                 from ../pal/palcommon.h:15,\r\n                 from atomic.h:22,\r\n                 from atomic.c:10:\r\n/usr/include/features.h:183:3: warning: #warning \"_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE\" [-Wcpp]\r\n # warning \"_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE\"\r\n   ^~~~~~~\r\nIn file included from /usr/include/string.h:431:0,\r\n                 from ../pal/palcommon.h:16,\r\n                 from atomic.h:22,\r\n                 from atomic.c:10:\r\n./strings.h:66:1: error: unknown type name ‘PAL_BEGIN_EXTERNC’\r\n```"}}
{"actor":{"display_login":"lf-"}}