{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/215817606","pull_request_review_id":153170386,"id":215817606,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgxNzYwNg==","diff_hunk":"@@ -357,12 +357,14 @@ export default Ember.Component.extend(\n     var sortedGroupObjs = groupObjs.sort(this.get('groupSortFunction'));\n     var result = Ember.A();\n     sortedGroupObjs.forEach(function(groupObj) {\n-      result.pushObject(\n-        Ember.Object.create({\n-          isGroupOption: true,\n-          name: groupObj.name\n-        })\n-      );\n+      if (groupObj.name) {","path":"addon/components/select-component.js","position":10,"original_position":10,"commit_id":"76d12259e37ddb4c81cef1db9390259f1670317d","original_commit_id":"76d12259e37ddb4c81cef1db9390259f1670317d","user":{"login":"twokul","id":1131196,"node_id":"MDQ6VXNlcjExMzExOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1131196?v=4","gravatar_id":"","url":"https://api.github.com/users/twokul","html_url":"https://github.com/twokul","followers_url":"https://api.github.com/users/twokul/followers","following_url":"https://api.github.com/users/twokul/following{/other_user}","gists_url":"https://api.github.com/users/twokul/gists{/gist_id}","starred_url":"https://api.github.com/users/twokul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twokul/subscriptions","organizations_url":"https://api.github.com/users/twokul/orgs","repos_url":"https://api.github.com/users/twokul/repos","events_url":"https://api.github.com/users/twokul/events{/privacy}","received_events_url":"https://api.github.com/users/twokul/received_events","type":"User","site_admin":false},"body":"should we add a test?","created_at":"2018-09-07T00:41:50Z","updated_at":"2018-09-07T00:41:50Z","html_url":"https://github.com/Addepar/ember-widgets/pull/270#discussion_r215817606","pull_request_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/215817606"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/270#discussion_r215817606"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270","id":213777546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzc3NTQ2","html_url":"https://github.com/Addepar/ember-widgets/pull/270","diff_url":"https://github.com/Addepar/ember-widgets/pull/270.diff","patch_url":"https://github.com/Addepar/ember-widgets/pull/270.patch","issue_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/270","number":270,"state":"open","locked":false,"title":"Don't create select rows for empty grouping names","user":{"login":"embooglement","id":2358927,"node_id":"MDQ6VXNlcjIzNTg5Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/2358927?v=4","gravatar_id":"","url":"https://api.github.com/users/embooglement","html_url":"https://github.com/embooglement","followers_url":"https://api.github.com/users/embooglement/followers","following_url":"https://api.github.com/users/embooglement/following{/other_user}","gists_url":"https://api.github.com/users/embooglement/gists{/gist_id}","starred_url":"https://api.github.com/users/embooglement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embooglement/subscriptions","organizations_url":"https://api.github.com/users/embooglement/orgs","repos_url":"https://api.github.com/users/embooglement/repos","events_url":"https://api.github.com/users/embooglement/events{/privacy}","received_events_url":"https://api.github.com/users/embooglement/received_events","type":"User","site_admin":false},"body":"Currently there's no way to have some rows in a select dropdown show up under groupings, but others don't. If an option has an `optionGroupPath` of an empty string, it results in a bunch of whitespace in the dropdown. This PR just makes it so grouping rows with an empty name are ignored, which leads to the height of the dropdown calculating correctly, and no weird whitespace appearing.","created_at":"2018-09-06T23:26:58Z","updated_at":"2018-09-07T00:41:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3c9e60df69f25ff7be85a27b529179121da90ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/270/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/76d12259e37ddb4c81cef1db9390259f1670317d","head":{"label":"Addepar:kevin/select/ignore-empty-group-names","ref":"kevin/select/ignore-empty-group-names","sha":"76d12259e37ddb4c81cef1db9390259f1670317d","user":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MzYzNA==","name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":null,"fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/Addepar/ember-widgets/deployments","created_at":"2013-10-23T04:39:36Z","updated_at":"2018-08-29T16:55:19Z","pushed_at":"2018-09-06T23:26:59Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":9935,"stargazers_count":304,"watchers_count":304,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":84,"open_issues":32,"watchers":304,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"469204a21947319a2d96d0adcc0eb2e4b774b25a","user":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MzYzNA==","name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":null,"fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/Addepar/ember-widgets/deployments","created_at":"2013-10-23T04:39:36Z","updated_at":"2018-08-29T16:55:19Z","pushed_at":"2018-09-06T23:26:59Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":9935,"stargazers_count":304,"watchers_count":304,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":84,"open_issues":32,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/270"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/270"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-widgets/statuses/76d12259e37ddb4c81cef1db9390259f1670317d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twokul"}}