{"action":"opened","number":374,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/374","id":238385602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Mzg1NjAy","html_url":"https://github.com/wordpress-mobile/gutenberg-mobile/pull/374","diff_url":"https://github.com/wordpress-mobile/gutenberg-mobile/pull/374.diff","patch_url":"https://github.com/wordpress-mobile/gutenberg-mobile/pull/374.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/374","number":374,"state":"open","locked":false,"title":"Scroll to new block","user":{"login":"pinarol","id":5032900,"node_id":"MDQ6VXNlcjUwMzI5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5032900?v=4","gravatar_id":"","url":"https://api.github.com/users/pinarol","html_url":"https://github.com/pinarol","followers_url":"https://api.github.com/users/pinarol/followers","following_url":"https://api.github.com/users/pinarol/following{/other_user}","gists_url":"https://api.github.com/users/pinarol/gists{/gist_id}","starred_url":"https://api.github.com/users/pinarol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinarol/subscriptions","organizations_url":"https://api.github.com/users/pinarol/orgs","repos_url":"https://api.github.com/users/pinarol/repos","events_url":"https://api.github.com/users/pinarol/events{/privacy}","received_events_url":"https://api.github.com/users/pinarol/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/wordpress-mobile/gutenberg-mobile/issues/197\r\n\r\nThis change makes editor focus on the recently added block.\r\n\r\nThere are some inconsistencies that are still need to be addressed:\r\n\r\n- Sometimes when we add a block the page is re-rendered all over again, we don't normally expect this to happen, when this happens scroll is set to the beginning and the recently created block is not viewable by user, with this PR it scrolls back to the recently created block after the re-render, but, the ideal solution would be preventing the unnecessary re-render first, because currently the scroll goes to the top and back and it doesn't look good enough I think. But I didn't have chance to prevent the re-render.\r\n\r\n- scrollToIndex method is not working consistently, although we provide the correct scrolling position to scrollToIndex it isn't scrolling to the exact same position every time. This is another issue but I had no luck to make this work better, even if I tried to set viewPosition=0(top of the page) and viewOffset = 0 it doesn't always scroll to the top of the page. I can really use other point of views on this.\r\n\r\n**To Test:**\r\n\r\n- Add a new block to a position that is not viewable currently\r\n- Verify that it becomes viewable\r\n","created_at":"2018-12-13T13:15:08Z","updated_at":"2018-12-13T13:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"pinarol","id":5032900,"node_id":"MDQ6VXNlcjUwMzI5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5032900?v=4","gravatar_id":"","url":"https://api.github.com/users/pinarol","html_url":"https://github.com/pinarol","followers_url":"https://api.github.com/users/pinarol/followers","following_url":"https://api.github.com/users/pinarol/following{/other_user}","gists_url":"https://api.github.com/users/pinarol/gists{/gist_id}","starred_url":"https://api.github.com/users/pinarol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinarol/subscriptions","organizations_url":"https://api.github.com/users/pinarol/orgs","repos_url":"https://api.github.com/users/pinarol/repos","events_url":"https://api.github.com/users/pinarol/events{/privacy}","received_events_url":"https://api.github.com/users/pinarol/received_events","type":"User","site_admin":false},"assignees":[{"login":"pinarol","id":5032900,"node_id":"MDQ6VXNlcjUwMzI5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5032900?v=4","gravatar_id":"","url":"https://api.github.com/users/pinarol","html_url":"https://github.com/pinarol","followers_url":"https://api.github.com/users/pinarol/followers","following_url":"https://api.github.com/users/pinarol/following{/other_user}","gists_url":"https://api.github.com/users/pinarol/gists{/gist_id}","starred_url":"https://api.github.com/users/pinarol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinarol/subscriptions","organizations_url":"https://api.github.com/users/pinarol/orgs","repos_url":"https://api.github.com/users/pinarol/repos","events_url":"https://api.github.com/users/pinarol/events{/privacy}","received_events_url":"https://api.github.com/users/pinarol/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/milestones/4","html_url":"https://github.com/wordpress-mobile/gutenberg-mobile/milestone/4","labels_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/milestones/4/labels","id":3738550,"node_id":"MDk6TWlsZXN0b25lMzczODU1MA==","number":4,"title":"Alpha","description":"We will have an alpha release at the end of the year that will showcase the editing flow with some selected basic blocks. We will have a basic integration with the apps, enough to be able to experience Gutenberg (via secret opt-in or special builds), but won’t be showing this to users. Being able to use early versions of Gutenberg directly in the apps will make it easier to gather feedback and do user testing.","creator":{"login":"koke","id":8739,"node_id":"MDQ6VXNlcjg3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8739?v=4","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":60,"state":"open","created_at":"2018-10-15T08:59:36Z","updated_at":"2018-12-13T13:15:09Z","due_on":"2018-12-14T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/374/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/374/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/374/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/statuses/956dde6a7755c6b568a5171f5f44d05af7b717cb","head":{"label":"wordpress-mobile:issue/scroll-to-newblock","ref":"issue/scroll-to-newblock","sha":"956dde6a7755c6b568a5171f5f44d05af7b717cb","user":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":124846371,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4NDYzNzE=","name":"gutenberg-mobile","full_name":"wordpress-mobile/gutenberg-mobile","private":false,"owner":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wordpress-mobile/gutenberg-mobile","description":"Mobile version of Gutenberg - native iOS and Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile","forks_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/deployments","created_at":"2018-03-12T06:53:51Z","updated_at":"2018-12-13T08:55:09Z","pushed_at":"2018-12-13T13:00:39Z","git_url":"git://github.com/wordpress-mobile/gutenberg-mobile.git","ssh_url":"git@github.com:wordpress-mobile/gutenberg-mobile.git","clone_url":"https://github.com/wordpress-mobile/gutenberg-mobile.git","svn_url":"https://github.com/wordpress-mobile/gutenberg-mobile","homepage":null,"size":12583,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":5,"open_issues":58,"watchers":30,"default_branch":"master"}},"base":{"label":"wordpress-mobile:master","ref":"master","sha":"5cfe37c6f4986a8d0e8fc0744b38e2e4375e3631","user":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":124846371,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4NDYzNzE=","name":"gutenberg-mobile","full_name":"wordpress-mobile/gutenberg-mobile","private":false,"owner":{"login":"wordpress-mobile","id":1306301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wordpress-mobile/gutenberg-mobile","description":"Mobile version of Gutenberg - native iOS and Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile","forks_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/deployments","created_at":"2018-03-12T06:53:51Z","updated_at":"2018-12-13T08:55:09Z","pushed_at":"2018-12-13T13:00:39Z","git_url":"git://github.com/wordpress-mobile/gutenberg-mobile.git","ssh_url":"git@github.com:wordpress-mobile/gutenberg-mobile.git","clone_url":"https://github.com/wordpress-mobile/gutenberg-mobile.git","svn_url":"https://github.com/wordpress-mobile/gutenberg-mobile","homepage":null,"size":12583,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":5,"open_issues":58,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/374"},"html":{"href":"https://github.com/wordpress-mobile/gutenberg-mobile/pull/374"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/374"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/statuses/956dde6a7755c6b568a5171f5f44d05af7b717cb"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":40,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"pinarol"}}