{"action":"created","comment":{"url":"https://api.github.com/repos/serverless/components/pulls/comments/233360114","pull_request_review_id":174752648,"id":233360114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzM2MDExNA==","diff_hunk":"@@ -85,9 +113,7 @@ const AwsIamRole = async (SuperClass, superContext) => {\n       await super.construct(inputs, context)\n \n       // HACK BRN: Temporary workaround until we add property type/default support\n-      const defaultPolicy = {\n-        arn: 'arn:aws:iam::aws:policy/AdministratorAccess'\n-      }\n+      const defaultPolicy = {}","path":"registry/AwsIamRole/src/index.js","position":85,"original_position":85,"commit_id":"72c9ab1a66a6bdc99176b287bfabe759e9b4cb25","original_commit_id":"72c9ab1a66a6bdc99176b287bfabe759e9b4cb25","user":{"login":"pmuens","id":1606004,"node_id":"MDQ6VXNlcjE2MDYwMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1606004?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"body":"Should we have a \"sane\" default here? In case it should we fail if no policy / policy arn is provided might want to move the validation into the `serverless.yml` via RAML.","created_at":"2018-11-14T09:00:54Z","updated_at":"2018-11-14T09:06:17Z","html_url":"https://github.com/serverless/components/pull/352#discussion_r233360114","pull_request_url":"https://api.github.com/repos/serverless/components/pulls/352","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/serverless/components/pulls/comments/233360114"},"html":{"href":"https://github.com/serverless/components/pull/352#discussion_r233360114"},"pull_request":{"href":"https://api.github.com/repos/serverless/components/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/serverless/components/pulls/352","id":230557914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTU3OTE0","html_url":"https://github.com/serverless/components/pull/352","diff_url":"https://github.com/serverless/components/pull/352.diff","patch_url":"https://github.com/serverless/components/pull/352.patch","issue_url":"https://api.github.com/repos/serverless/components/issues/352","number":352,"state":"open","locked":false,"title":"Inline IamRole Policies & better default creation for lambdas","user":{"login":"dschep","id":667763,"node_id":"MDQ6VXNlcjY2Nzc2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/667763?v=4","gravatar_id":"","url":"https://api.github.com/users/dschep","html_url":"https://github.com/dschep","followers_url":"https://api.github.com/users/dschep/followers","following_url":"https://api.github.com/users/dschep/following{/other_user}","gists_url":"https://api.github.com/users/dschep/gists{/gist_id}","starred_url":"https://api.github.com/users/dschep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschep/subscriptions","organizations_url":"https://api.github.com/users/dschep/orgs","repos_url":"https://api.github.com/users/dschep/repos","events_url":"https://api.github.com/users/dschep/events{/privacy}","received_events_url":"https://api.github.com/users/dschep/received_events","type":"User","site_admin":false},"body":"## What has been implemented?\r\n\r\n* AwsIamRole now supports being given an inline policy in addition to one with an ARN\r\n* AwsIamRole no longer defaults to attaching the admin policy\r\n* AwsLambdaCompute now specifies the minimum inline role that a lambda needs\r\n  * doesn't currently set account Id in the ARN, not sure if that's available in this context?\r\n\r\n## Steps to verify\r\n\r\n* run `components deploy` in a service using AwsLambdaCompute without roles specified\r\n* in the AWS console check that the roles created have an inline policy granting perms to create & write to a the right cloudwatch log group and not have the managed AdministratorAccess policy attached.\r\n\r\n## Todos:\r\n\r\n* [x] Write tests\r\n* [x] Write / update documentation\r\n* [x] Run Prettier\r\n","created_at":"2018-11-13T17:15:40Z","updated_at":"2018-11-14T09:06:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f4228eae77f6d16f33aff6b285ce1ab3abd6932","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brianneisler","id":1471972,"node_id":"MDQ6VXNlcjE0NzE5NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1471972?v=4","gravatar_id":"","url":"https://api.github.com/users/brianneisler","html_url":"https://github.com/brianneisler","followers_url":"https://api.github.com/users/brianneisler/followers","following_url":"https://api.github.com/users/brianneisler/following{/other_user}","gists_url":"https://api.github.com/users/brianneisler/gists{/gist_id}","starred_url":"https://api.github.com/users/brianneisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianneisler/subscriptions","organizations_url":"https://api.github.com/users/brianneisler/orgs","repos_url":"https://api.github.com/users/brianneisler/repos","events_url":"https://api.github.com/users/brianneisler/events{/privacy}","received_events_url":"https://api.github.com/users/brianneisler/received_events","type":"User","site_admin":false},{"login":"eahefnawy","id":2312463,"node_id":"MDQ6VXNlcjIzMTI0NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2312463?v=4","gravatar_id":"","url":"https://api.github.com/users/eahefnawy","html_url":"https://github.com/eahefnawy","followers_url":"https://api.github.com/users/eahefnawy/followers","following_url":"https://api.github.com/users/eahefnawy/following{/other_user}","gists_url":"https://api.github.com/users/eahefnawy/gists{/gist_id}","starred_url":"https://api.github.com/users/eahefnawy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eahefnawy/subscriptions","organizations_url":"https://api.github.com/users/eahefnawy/orgs","repos_url":"https://api.github.com/users/eahefnawy/repos","events_url":"https://api.github.com/users/eahefnawy/events{/privacy}","received_events_url":"https://api.github.com/users/eahefnawy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/components/pulls/352/commits","review_comments_url":"https://api.github.com/repos/serverless/components/pulls/352/comments","review_comment_url":"https://api.github.com/repos/serverless/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/components/issues/352/comments","statuses_url":"https://api.github.com/repos/serverless/components/statuses/72c9ab1a66a6bdc99176b287bfabe759e9b4cb25","head":{"label":"serverless:iam-role-fixes","ref":"iam-role-fixes","sha":"72c9ab1a66a6bdc99176b287bfabe759e9b4cb25","user":{"login":"serverless","id":13742415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzQyNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":117983079,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5ODMwNzk=","name":"components","full_name":"serverless/components","private":false,"owner":{"login":"serverless","id":13742415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzQyNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/serverless/components","description":"An easier way to build applications with serverless services –","fork":false,"url":"https://api.github.com/repos/serverless/components","forks_url":"https://api.github.com/repos/serverless/components/forks","keys_url":"https://api.github.com/repos/serverless/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/components/teams","hooks_url":"https://api.github.com/repos/serverless/components/hooks","issue_events_url":"https://api.github.com/repos/serverless/components/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/components/events","assignees_url":"https://api.github.com/repos/serverless/components/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/components/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/components/tags","blobs_url":"https://api.github.com/repos/serverless/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/components/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/components/languages","stargazers_url":"https://api.github.com/repos/serverless/components/stargazers","contributors_url":"https://api.github.com/repos/serverless/components/contributors","subscribers_url":"https://api.github.com/repos/serverless/components/subscribers","subscription_url":"https://api.github.com/repos/serverless/components/subscription","commits_url":"https://api.github.com/repos/serverless/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/components/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/components/merges","archive_url":"https://api.github.com/repos/serverless/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/components/downloads","issues_url":"https://api.github.com/repos/serverless/components/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/components/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/components/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/components/labels{/name}","releases_url":"https://api.github.com/repos/serverless/components/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/components/deployments","created_at":"2018-01-18T12:57:56Z","updated_at":"2018-11-13T00:38:54Z","pushed_at":"2018-11-14T05:49:09Z","git_url":"git://github.com/serverless/components.git","ssh_url":"git@github.com:serverless/components.git","clone_url":"https://github.com/serverless/components.git","svn_url":"https://github.com/serverless/components","homepage":"https://www.serverless.com","size":11160,"stargazers_count":729,"watchers_count":729,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":64,"open_issues":74,"watchers":729,"default_branch":"master"}},"base":{"label":"serverless:type-system","ref":"type-system","sha":"573ec00b8902bf1a04820133453252590291d3d1","user":{"login":"serverless","id":13742415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzQyNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":117983079,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5ODMwNzk=","name":"components","full_name":"serverless/components","private":false,"owner":{"login":"serverless","id":13742415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzQyNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/serverless/components","description":"An easier way to build applications with serverless services –","fork":false,"url":"https://api.github.com/repos/serverless/components","forks_url":"https://api.github.com/repos/serverless/components/forks","keys_url":"https://api.github.com/repos/serverless/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/components/teams","hooks_url":"https://api.github.com/repos/serverless/components/hooks","issue_events_url":"https://api.github.com/repos/serverless/components/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/components/events","assignees_url":"https://api.github.com/repos/serverless/components/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/components/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/components/tags","blobs_url":"https://api.github.com/repos/serverless/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/components/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/components/languages","stargazers_url":"https://api.github.com/repos/serverless/components/stargazers","contributors_url":"https://api.github.com/repos/serverless/components/contributors","subscribers_url":"https://api.github.com/repos/serverless/components/subscribers","subscription_url":"https://api.github.com/repos/serverless/components/subscription","commits_url":"https://api.github.com/repos/serverless/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/components/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/components/merges","archive_url":"https://api.github.com/repos/serverless/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/components/downloads","issues_url":"https://api.github.com/repos/serverless/components/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/components/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/components/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/components/labels{/name}","releases_url":"https://api.github.com/repos/serverless/components/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/components/deployments","created_at":"2018-01-18T12:57:56Z","updated_at":"2018-11-13T00:38:54Z","pushed_at":"2018-11-14T05:49:09Z","git_url":"git://github.com/serverless/components.git","ssh_url":"git@github.com:serverless/components.git","clone_url":"https://github.com/serverless/components.git","svn_url":"https://github.com/serverless/components","homepage":"https://www.serverless.com","size":11160,"stargazers_count":729,"watchers_count":729,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":64,"open_issues":74,"watchers":729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/components/pulls/352"},"html":{"href":"https://github.com/serverless/components/pull/352"},"issue":{"href":"https://api.github.com/repos/serverless/components/issues/352"},"comments":{"href":"https://api.github.com/repos/serverless/components/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/components/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/components/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/components/statuses/72c9ab1a66a6bdc99176b287bfabe759e9b4cb25"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pmuens"}}