{"action":"closed","number":30719,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30719","id":232694850,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjk0ODUw","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30719","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30719.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30719.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30719","number":30719,"state":"closed","locked":false,"title":"Refine types for npm package \"ini\"","user":{"login":"carnesen","id":5756743,"node_id":"MDQ6VXNlcjU3NTY3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5756743?v=4","gravatar_id":"","url":"https://api.github.com/users/carnesen","html_url":"https://github.com/carnesen","followers_url":"https://api.github.com/users/carnesen/followers","following_url":"https://api.github.com/users/carnesen/following{/other_user}","gists_url":"https://api.github.com/users/carnesen/gists{/gist_id}","starred_url":"https://api.github.com/users/carnesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carnesen/subscriptions","organizations_url":"https://api.github.com/users/carnesen/orgs","repos_url":"https://api.github.com/users/carnesen/repos","events_url":"https://api.github.com/users/carnesen/events{/privacy}","received_events_url":"https://api.github.com/users/carnesen/received_events","type":"User","site_admin":false},"body":"- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: \r\nhttps://github.com/npm/ini/blob/738eca59d77d8cfdddf5c477c17a0d8f8fbfe0fd/ini.js#L15 shows that the second argument of `encode` can be a string. As for the return type of `decode` (alias `parse`), the \"out\" variable is initialized as an empty object and never reassigned. String-keyed properties are subsequently added based on the contents of the blob being parsed. https://github.com/npm/ini/blob/738eca59d77d8cfdddf5c477c17a0d8f8fbfe0fd/ini.js#L70\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-11-21T15:01:08Z","updated_at":"2018-11-29T03:33:12Z","closed_at":"2018-11-29T03:33:12Z","merged_at":"2018-11-29T03:33:12Z","merge_commit_sha":"a5396e81ab659f031deea2a1ba855066d1adf961","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":644095236,"node_id":"MDU6TGFiZWw2NDQwOTUyMzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:Express","name":"Merge:Express","color":"00AA00","default":false},{"id":905334095,"node_id":"MDU6TGFiZWw5MDUzMzQwOTU=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Owner%20Approved","name":"Owner Approved","color":"0e8a16","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30719/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30719/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30719/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8809b6a41bb6b2c95ecdbd13b41c2b09c8bc7a8a","head":{"label":"carnesen:ini","ref":"ini","sha":"8809b6a41bb6b2c95ecdbd13b41c2b09c8bc7a8a","user":{"login":"carnesen","id":5756743,"node_id":"MDQ6VXNlcjU3NTY3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5756743?v=4","gravatar_id":"","url":"https://api.github.com/users/carnesen","html_url":"https://github.com/carnesen","followers_url":"https://api.github.com/users/carnesen/followers","following_url":"https://api.github.com/users/carnesen/following{/other_user}","gists_url":"https://api.github.com/users/carnesen/gists{/gist_id}","starred_url":"https://api.github.com/users/carnesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carnesen/subscriptions","organizations_url":"https://api.github.com/users/carnesen/orgs","repos_url":"https://api.github.com/users/carnesen/repos","events_url":"https://api.github.com/users/carnesen/events{/privacy}","received_events_url":"https://api.github.com/users/carnesen/received_events","type":"User","site_admin":false},"repo":{"id":158489541,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0ODk1NDE=","name":"DefinitelyTyped","full_name":"carnesen/DefinitelyTyped","private":false,"owner":{"login":"carnesen","id":5756743,"node_id":"MDQ6VXNlcjU3NTY3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5756743?v=4","gravatar_id":"","url":"https://api.github.com/users/carnesen","html_url":"https://github.com/carnesen","followers_url":"https://api.github.com/users/carnesen/followers","following_url":"https://api.github.com/users/carnesen/following{/other_user}","gists_url":"https://api.github.com/users/carnesen/gists{/gist_id}","starred_url":"https://api.github.com/users/carnesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carnesen/subscriptions","organizations_url":"https://api.github.com/users/carnesen/orgs","repos_url":"https://api.github.com/users/carnesen/repos","events_url":"https://api.github.com/users/carnesen/events{/privacy}","received_events_url":"https://api.github.com/users/carnesen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carnesen/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/carnesen/DefinitelyTyped","forks_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/carnesen/DefinitelyTyped/deployments","created_at":"2018-11-21T04:12:16Z","updated_at":"2018-11-28T03:31:40Z","pushed_at":"2018-11-28T08:29:46Z","git_url":"git://github.com/carnesen/DefinitelyTyped.git","ssh_url":"git@github.com:carnesen/DefinitelyTyped.git","clone_url":"https://github.com/carnesen/DefinitelyTyped.git","svn_url":"https://github.com/carnesen/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":384473,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"28e745f92dfa682e673a012d23ed0b4950d27d27","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-11-29T03:32:08Z","pushed_at":"2018-11-29T03:33:12Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":382505,"stargazers_count":18773,"watchers_count":18773,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15539,"mirror_url":null,"archived":false,"open_issues_count":2581,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15539,"open_issues":2581,"watchers":18773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30719"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30719"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30719"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30719/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30719/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30719/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8809b6a41bb6b2c95ecdbd13b41c2b09c8bc7a8a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"minestarks","id":16928427,"node_id":"MDQ6VXNlcjE2OTI4NDI3","avatar_url":"https://avatars1.githubusercontent.com/u/16928427?v=4","gravatar_id":"","url":"https://api.github.com/users/minestarks","html_url":"https://github.com/minestarks","followers_url":"https://api.github.com/users/minestarks/followers","following_url":"https://api.github.com/users/minestarks/following{/other_user}","gists_url":"https://api.github.com/users/minestarks/gists{/gist_id}","starred_url":"https://api.github.com/users/minestarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minestarks/subscriptions","organizations_url":"https://api.github.com/users/minestarks/orgs","repos_url":"https://api.github.com/users/minestarks/repos","events_url":"https://api.github.com/users/minestarks/events{/privacy}","received_events_url":"https://api.github.com/users/minestarks/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"minestarks"}}