{"action":"created","comment":{"url":"https://api.github.com/repos/libretro/tyrquake/pulls/comments/183209542","pull_request_review_id":114172490,"id":183209542,"diff_hunk":"@@ -273,11 +273,6 @@ int Sys_FileTime(const char *path)\n    return buf.st_mtime;\n }\n \n-void Sys_mkdir(const char *path)","path":"common/libretro.c","position":4,"original_position":4,"commit_id":"330f190164053c5ffe231477dba98cc12aaeae5e","original_commit_id":"9171c7e86a795f0442da85377720e2e403da61e8","user":{"login":"twinaphex","id":1075274,"avatar_url":"https://avatars3.githubusercontent.com/u/1075274?v=4","gravatar_id":"","url":"https://api.github.com/users/twinaphex","html_url":"https://github.com/twinaphex","followers_url":"https://api.github.com/users/twinaphex/followers","following_url":"https://api.github.com/users/twinaphex/following{/other_user}","gists_url":"https://api.github.com/users/twinaphex/gists{/gist_id}","starred_url":"https://api.github.com/users/twinaphex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinaphex/subscriptions","organizations_url":"https://api.github.com/users/twinaphex/orgs","repos_url":"https://api.github.com/users/twinaphex/repos","events_url":"https://api.github.com/users/twinaphex/events{/privacy}","received_events_url":"https://api.github.com/users/twinaphex/received_events","type":"User","site_admin":false},"body":"Why did you do this though? Now it doesn't compile anymore for several platforms, such as iOS and Windows.\r\n\r\niOS -\r\nhttp://p.0bl.net/738\r\n\r\nWindows -\r\nhttp://p.0bl.net/739","created_at":"2018-04-21T13:14:05Z","updated_at":"2018-04-21T13:14:12Z","html_url":"https://github.com/libretro/tyrquake/pull/58#discussion_r183209542","pull_request_url":"https://api.github.com/repos/libretro/tyrquake/pulls/58","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/libretro/tyrquake/pulls/comments/183209542"},"html":{"href":"https://github.com/libretro/tyrquake/pull/58#discussion_r183209542"},"pull_request":{"href":"https://api.github.com/repos/libretro/tyrquake/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/libretro/tyrquake/pulls/58","id":183027312,"html_url":"https://github.com/libretro/tyrquake/pull/58","diff_url":"https://github.com/libretro/tyrquake/pull/58.diff","patch_url":"https://github.com/libretro/tyrquake/pull/58.patch","issue_url":"https://api.github.com/repos/libretro/tyrquake/issues/58","number":58,"state":"closed","locked":false,"title":"Move core-generated files (config + saves) to frontend-defined save directory","user":{"login":"jdgleaver","id":38211560,"avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"body":"The existing core writes the Quake 'config.cfg' + save files to the actual game directory. This is *not good*, for the following reasons:\r\n\r\n- It doesn't follow the RetroArch standard of writing save files to the frontend-defined save directory.\r\n\r\n- It makes it a nuisance to backup/restore game saves. With other cores, all saves are in one place and can easily be archived and shared across different machines. With the current tyrquake core, one has to grub around in individual game directories and pick out specific files.\r\n\r\n- It means the game data has to be kept on writeable storage. This is a significant problem on Android devices, where internal storage is limited and it is often desirable to place large roms on an 'external' micro SD card - which in many cases cannot be written to by user apps. (Every Android device I own has this problem...)\r\n\r\nThis pull request very simply modifies the core such that the 'config.cfg' + save files are written to an appropriate subdirectory (named after the game folder) inside the frontend-defined save directory. It makes things tidy, and the game data can be set read-only without issue.","created_at":"2018-04-20T10:53:46Z","updated_at":"2018-04-21T13:14:12Z","closed_at":"2018-04-21T12:55:56Z","merged_at":"2018-04-21T12:55:56Z","merge_commit_sha":"74a986f01a13d98a47108482dad234cffb9439df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libretro/tyrquake/pulls/58/commits","review_comments_url":"https://api.github.com/repos/libretro/tyrquake/pulls/58/comments","review_comment_url":"https://api.github.com/repos/libretro/tyrquake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libretro/tyrquake/issues/58/comments","statuses_url":"https://api.github.com/repos/libretro/tyrquake/statuses/330f190164053c5ffe231477dba98cc12aaeae5e","head":{"label":"jdgleaver:save-relocation","ref":"save-relocation","sha":"330f190164053c5ffe231477dba98cc12aaeae5e","user":{"login":"jdgleaver","id":38211560,"avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"repo":{"id":129908812,"name":"tyrquake","full_name":"jdgleaver/tyrquake","owner":{"login":"jdgleaver","id":38211560,"avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdgleaver/tyrquake","description":"Libretro port of Tyrquake (Quake 1 engine)","fork":true,"url":"https://api.github.com/repos/jdgleaver/tyrquake","forks_url":"https://api.github.com/repos/jdgleaver/tyrquake/forks","keys_url":"https://api.github.com/repos/jdgleaver/tyrquake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdgleaver/tyrquake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdgleaver/tyrquake/teams","hooks_url":"https://api.github.com/repos/jdgleaver/tyrquake/hooks","issue_events_url":"https://api.github.com/repos/jdgleaver/tyrquake/issues/events{/number}","events_url":"https://api.github.com/repos/jdgleaver/tyrquake/events","assignees_url":"https://api.github.com/repos/jdgleaver/tyrquake/assignees{/user}","branches_url":"https://api.github.com/repos/jdgleaver/tyrquake/branches{/branch}","tags_url":"https://api.github.com/repos/jdgleaver/tyrquake/tags","blobs_url":"https://api.github.com/repos/jdgleaver/tyrquake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdgleaver/tyrquake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdgleaver/tyrquake/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdgleaver/tyrquake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdgleaver/tyrquake/statuses/{sha}","languages_url":"https://api.github.com/repos/jdgleaver/tyrquake/languages","stargazers_url":"https://api.github.com/repos/jdgleaver/tyrquake/stargazers","contributors_url":"https://api.github.com/repos/jdgleaver/tyrquake/contributors","subscribers_url":"https://api.github.com/repos/jdgleaver/tyrquake/subscribers","subscription_url":"https://api.github.com/repos/jdgleaver/tyrquake/subscription","commits_url":"https://api.github.com/repos/jdgleaver/tyrquake/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdgleaver/tyrquake/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdgleaver/tyrquake/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdgleaver/tyrquake/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdgleaver/tyrquake/contents/{+path}","compare_url":"https://api.github.com/repos/jdgleaver/tyrquake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdgleaver/tyrquake/merges","archive_url":"https://api.github.com/repos/jdgleaver/tyrquake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdgleaver/tyrquake/downloads","issues_url":"https://api.github.com/repos/jdgleaver/tyrquake/issues{/number}","pulls_url":"https://api.github.com/repos/jdgleaver/tyrquake/pulls{/number}","milestones_url":"https://api.github.com/repos/jdgleaver/tyrquake/milestones{/number}","notifications_url":"https://api.github.com/repos/jdgleaver/tyrquake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdgleaver/tyrquake/labels{/name}","releases_url":"https://api.github.com/repos/jdgleaver/tyrquake/releases{/id}","deployments_url":"https://api.github.com/repos/jdgleaver/tyrquake/deployments","created_at":"2018-04-17T13:28:11Z","updated_at":"2018-04-18T09:01:54Z","pushed_at":"2018-04-20T10:18:29Z","git_url":"git://github.com/jdgleaver/tyrquake.git","ssh_url":"git@github.com:jdgleaver/tyrquake.git","clone_url":"https://github.com/jdgleaver/tyrquake.git","svn_url":"https://github.com/jdgleaver/tyrquake","homepage":"","size":6156,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libretro:master","ref":"master","sha":"d886031fe32908bf35df1292419e371eed9fbc92","user":{"login":"libretro","id":1812827,"avatar_url":"https://avatars1.githubusercontent.com/u/1812827?v=4","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"repo":{"id":8296366,"name":"tyrquake","full_name":"libretro/tyrquake","owner":{"login":"libretro","id":1812827,"avatar_url":"https://avatars1.githubusercontent.com/u/1812827?v=4","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libretro/tyrquake","description":"Libretro port of Tyrquake (Quake 1 engine)","fork":false,"url":"https://api.github.com/repos/libretro/tyrquake","forks_url":"https://api.github.com/repos/libretro/tyrquake/forks","keys_url":"https://api.github.com/repos/libretro/tyrquake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libretro/tyrquake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libretro/tyrquake/teams","hooks_url":"https://api.github.com/repos/libretro/tyrquake/hooks","issue_events_url":"https://api.github.com/repos/libretro/tyrquake/issues/events{/number}","events_url":"https://api.github.com/repos/libretro/tyrquake/events","assignees_url":"https://api.github.com/repos/libretro/tyrquake/assignees{/user}","branches_url":"https://api.github.com/repos/libretro/tyrquake/branches{/branch}","tags_url":"https://api.github.com/repos/libretro/tyrquake/tags","blobs_url":"https://api.github.com/repos/libretro/tyrquake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libretro/tyrquake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libretro/tyrquake/git/refs{/sha}","trees_url":"https://api.github.com/repos/libretro/tyrquake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libretro/tyrquake/statuses/{sha}","languages_url":"https://api.github.com/repos/libretro/tyrquake/languages","stargazers_url":"https://api.github.com/repos/libretro/tyrquake/stargazers","contributors_url":"https://api.github.com/repos/libretro/tyrquake/contributors","subscribers_url":"https://api.github.com/repos/libretro/tyrquake/subscribers","subscription_url":"https://api.github.com/repos/libretro/tyrquake/subscription","commits_url":"https://api.github.com/repos/libretro/tyrquake/commits{/sha}","git_commits_url":"https://api.github.com/repos/libretro/tyrquake/git/commits{/sha}","comments_url":"https://api.github.com/repos/libretro/tyrquake/comments{/number}","issue_comment_url":"https://api.github.com/repos/libretro/tyrquake/issues/comments{/number}","contents_url":"https://api.github.com/repos/libretro/tyrquake/contents/{+path}","compare_url":"https://api.github.com/repos/libretro/tyrquake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libretro/tyrquake/merges","archive_url":"https://api.github.com/repos/libretro/tyrquake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libretro/tyrquake/downloads","issues_url":"https://api.github.com/repos/libretro/tyrquake/issues{/number}","pulls_url":"https://api.github.com/repos/libretro/tyrquake/pulls{/number}","milestones_url":"https://api.github.com/repos/libretro/tyrquake/milestones{/number}","notifications_url":"https://api.github.com/repos/libretro/tyrquake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libretro/tyrquake/labels{/name}","releases_url":"https://api.github.com/repos/libretro/tyrquake/releases{/id}","deployments_url":"https://api.github.com/repos/libretro/tyrquake/deployments","created_at":"2013-02-19T18:20:04Z","updated_at":"2018-04-21T12:55:58Z","pushed_at":"2018-04-21T12:55:56Z","git_url":"git://github.com/libretro/tyrquake.git","ssh_url":"git@github.com:libretro/tyrquake.git","clone_url":"https://github.com/libretro/tyrquake.git","svn_url":"https://github.com/libretro/tyrquake","homepage":"","size":6141,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":18,"open_issues":10,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libretro/tyrquake/pulls/58"},"html":{"href":"https://github.com/libretro/tyrquake/pull/58"},"issue":{"href":"https://api.github.com/repos/libretro/tyrquake/issues/58"},"comments":{"href":"https://api.github.com/repos/libretro/tyrquake/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/libretro/tyrquake/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/libretro/tyrquake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libretro/tyrquake/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/libretro/tyrquake/statuses/330f190164053c5ffe231477dba98cc12aaeae5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twinaphex"}}