{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/17445","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/17445/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/17445/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/17445/events","html_url":"https://github.com/openshift/origin/issues/17445","id":276404687,"number":17445,"title":"deployer_controller doesn't copy tolerations to deployer pod","user":{"login":"polaru","id":968452,"avatar_url":"https://avatars2.githubusercontent.com/u/968452?v=4","gravatar_id":"","url":"https://api.github.com/users/polaru","html_url":"https://github.com/polaru","followers_url":"https://api.github.com/users/polaru/followers","following_url":"https://api.github.com/users/polaru/following{/other_user}","gists_url":"https://api.github.com/users/polaru/gists{/gist_id}","starred_url":"https://api.github.com/users/polaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polaru/subscriptions","organizations_url":"https://api.github.com/users/polaru/orgs","repos_url":"https://api.github.com/users/polaru/repos","events_url":"https://api.github.com/users/polaru/events{/privacy}","received_events_url":"https://api.github.com/users/polaru/received_events","type":"User","site_admin":false},"labels":[{"id":210155386,"url":"https://api.github.com/repos/openshift/origin/labels/component/apps","name":"component/apps","color":"0052cc","default":false},{"id":118251699,"url":"https://api.github.com/repos/openshift/origin/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":826745876,"url":"https://api.github.com/repos/openshift/origin/labels/lifecycle/stale","name":"lifecycle/stale","color":"795548","default":false},{"id":210151912,"url":"https://api.github.com/repos/openshift/origin/labels/priority/P2","name":"priority/P2","color":"fbca04","default":false},{"id":683887368,"url":"https://api.github.com/repos/openshift/origin/labels/sig/master","name":"sig/master","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-11-23T15:02:59Z","updated_at":"2018-02-26T14:28:36Z","closed_at":null,"author_association":"NONE","body":"When creating a DeploymentConfig that includes tolerations, the deployer pod get's created w/o the tolerations. Because it uses the same nodes as the regular pods, it fails to start (because the nodes were tainted, that's why we included the tolerations in the config in the first place).\r\n\r\n##### Version\r\n```\r\n$ oc version\r\noc v3.6.0+c4dd4cf\r\nkubernetes v1.6.1+5115d708d7\r\nfeatures: Basic-Auth GSSAPI Kerberos SPNEGO\r\n\r\nServer https://localhost:443\r\nopenshift v3.6.0+c4dd4cf\r\nkubernetes v1.6.1+5115d708d7\r\n```\r\n##### Steps To Reproduce\r\n1. Taint nodes\r\n2. Create a DeploymentConfig using those nodes in NodeSelector and include a toleration for the taint on the nodes\r\n3. Observe:\r\n- deploy pod stuck in pendig\r\n`router-external-8-deploy   0/1       Pending   0          1h        <none>           `\r\n- deploy pod missing tolerations\r\n```\r\n$ oc describe po/router-external-8-deploy | grep Tolerations:\r\nTolerations:\t<none>\r\n```\r\n- rc gets created and has the right tolerations:\r\n`rc/router-external-8    0         0         0         1h`\r\n```\r\n$ oc export rc/router-external-8 | grep -A 3 \" tolerations\"\r\n      tolerations:\r\n      - key: role\r\n        operator: Equal\r\n        value: gateway\r\n```\r\nSo if I edit the deploy pod to add the tolerations, it gets scheduled and the regular pods have no issue running.\r\n\r\n##### Current Result\r\nDeploy pod is stuck in pending because it doesn't match tolerations/tains\r\n```\r\n$ oc describe po/router-external-8-deploy | grep FailedScheduling | tail -n 1\r\n  22s\t\t7s\t\t5\tdefault-scheduler\t\t\tWarning\t\tFailedScheduling\tNo nodes are available that match all of the following predicates:: MatchNodeSelector (52), PodToleratesNodeTaints (7).\r\n```\r\n##### Expected Result\r\nDeploy pod should get the tolerations mentioned in the DeploymentConfig.\r\n\r\n##### Additional Information\r\nAlthough I'm running 3.6, the code is the same in master, so I don't expect it to be different with a newer version: https://github.com/openshift/origin/blob/master/pkg/apps/controller/deployer/deployer_controller.go#L378"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/368520388","html_url":"https://github.com/openshift/origin/issues/17445#issuecomment-368520388","issue_url":"https://api.github.com/repos/openshift/origin/issues/17445","id":368520388,"user":{"login":"danielkucera","id":1734256,"avatar_url":"https://avatars3.githubusercontent.com/u/1734256?v=4","gravatar_id":"","url":"https://api.github.com/users/danielkucera","html_url":"https://github.com/danielkucera","followers_url":"https://api.github.com/users/danielkucera/followers","following_url":"https://api.github.com/users/danielkucera/following{/other_user}","gists_url":"https://api.github.com/users/danielkucera/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkucera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkucera/subscriptions","organizations_url":"https://api.github.com/users/danielkucera/orgs","repos_url":"https://api.github.com/users/danielkucera/repos","events_url":"https://api.github.com/users/danielkucera/events{/privacy}","received_events_url":"https://api.github.com/users/danielkucera/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T14:28:36Z","updated_at":"2018-02-26T14:28:36Z","author_association":"NONE","body":"/remove-lifecycle stale"}}
{"actor":{"display_login":"danielkucera"}}