{"action":"created","comment":{"url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/comments/208944092","pull_request_review_id":144857370,"id":208944092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODk0NDA5Mg==","diff_hunk":"@@ -1,106 +1,99 @@\n-import { Component, OnInit } from '@angular/core';\n+import { Component, OnDestroy, OnInit } from '@angular/core';\n import map from 'lodash-es/map';\n import * as moment from 'moment';\n-import { NgProgress } from 'ngx-progressbar';\n+import { Observable } from 'rxjs/Rx';\n+import { AnonymousSubscription } from 'rxjs/Subscription';\n \n-import { AlertService, StatisticsService } from '../../../services';\n-import { MAX_INT_SIZE } from '../../../utils';\n+import { AlertService, StatisticsService, PingService } from '../../../services';\n+import { GRAPH_REFRESH_INTERVAL } from '../../../utils';\n \n @Component({\n   selector: 'app-dashboard',\n   templateUrl: './dashboard.component.html',\n   styleUrls: ['./dashboard.component.css']\n })\n \n-export class DashboardComponent implements OnInit {\n+export class DashboardComponent implements OnInit, OnDestroy {\n   // Filtered array of received statistics data (having objects except key @FOGBENCH).\n   statistics = [];\n \n   // Array of Statistics Keys ([\"BUFFERED\", \"DISCARDED\", \"PURGED\", ....])\n   statisticsKeys = [];\n \n-  selectedKeys = [];\n-\n-  // Object of dropdown setting\n-  dropdownSettings = {};\n-\n-  selectedItems = [];\n+  selectedKeys = [] = [{ key: 'READINGS', checked: true },\n+  { key: 'PURGED', checked: true },\n+  { key: 'North Readings to PI', checked: true }];","path":"src/app/components/core/dashboard/dashboard.component.ts","position":36,"original_position":36,"commit_id":"327e3b985c28a456d25d0849068c4328b30a1e1a","original_commit_id":"327e3b985c28a456d25d0849068c4328b30a1e1a","user":{"login":"praveen-garg","id":1974003,"node_id":"MDQ6VXNlcjE5NzQwMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1974003?v=4","gravatar_id":"","url":"https://api.github.com/users/praveen-garg","html_url":"https://github.com/praveen-garg","followers_url":"https://api.github.com/users/praveen-garg/followers","following_url":"https://api.github.com/users/praveen-garg/following{/other_user}","gists_url":"https://api.github.com/users/praveen-garg/gists{/gist_id}","starred_url":"https://api.github.com/users/praveen-garg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveen-garg/subscriptions","organizations_url":"https://api.github.com/users/praveen-garg/orgs","repos_url":"https://api.github.com/users/praveen-garg/repos","events_url":"https://api.github.com/users/praveen-garg/events{/privacy}","received_events_url":"https://api.github.com/users/praveen-garg/received_events","type":"User","site_admin":false},"body":"format this please","created_at":"2018-08-09T14:10:56Z","updated_at":"2018-08-09T14:15:19Z","html_url":"https://github.com/foglamp/foglamp-gui/pull/227#discussion_r208944092","pull_request_url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/comments/208944092"},"html":{"href":"https://github.com/foglamp/foglamp-gui/pull/227#discussion_r208944092"},"pull_request":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227","id":207305522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzA1NTIy","html_url":"https://github.com/foglamp/foglamp-gui/pull/227","diff_url":"https://github.com/foglamp/foglamp-gui/pull/227.diff","patch_url":"https://github.com/foglamp/foglamp-gui/pull/227.patch","issue_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues/227","number":227,"state":"open","locked":false,"title":"FOGL-1636 : GUI Dashboard changes","user":{"login":"mshariq-nerd","id":16384273,"node_id":"MDQ6VXNlcjE2Mzg0Mjcz","avatar_url":"https://avatars0.githubusercontent.com/u/16384273?v=4","gravatar_id":"","url":"https://api.github.com/users/mshariq-nerd","html_url":"https://github.com/mshariq-nerd","followers_url":"https://api.github.com/users/mshariq-nerd/followers","following_url":"https://api.github.com/users/mshariq-nerd/following{/other_user}","gists_url":"https://api.github.com/users/mshariq-nerd/gists{/gist_id}","starred_url":"https://api.github.com/users/mshariq-nerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshariq-nerd/subscriptions","organizations_url":"https://api.github.com/users/mshariq-nerd/orgs","repos_url":"https://api.github.com/users/mshariq-nerd/repos","events_url":"https://api.github.com/users/mshariq-nerd/events{/privacy}","received_events_url":"https://api.github.com/users/mshariq-nerd/received_events","type":"User","site_admin":false},"body":"### POINTS COMPLETED:\r\n\r\n1. Showing default graphs of `READINGS` `North Readings to PI` and `PURGED`.\r\n2. Dashboard automatically refresh every 5 seconds (this value is configurable in the `Settings` page).\r\n3. All 3 default graphs displaing above the fold side by side.\r\n4. Removed search/select box used to select graphs. Instead, haveing a button in the top right, which has a dropdown with list of graphs.\r\n\r\n### TODO \r\n5. In graphs, User should select based on time, and default should be last 5 minutes. (should not be select by readings count). Should have choices of last 5 mins, last hour, and last day. (later, we’ll add more flexible options)","created_at":"2018-08-09T12:51:24Z","updated_at":"2018-08-09T14:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c78696e98b3cf8eca4247ed574f8d4c1376446f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"monika-Dianomic","id":29797330,"node_id":"MDQ6VXNlcjI5Nzk3MzMw","avatar_url":"https://avatars2.githubusercontent.com/u/29797330?v=4","gravatar_id":"","url":"https://api.github.com/users/monika-Dianomic","html_url":"https://github.com/monika-Dianomic","followers_url":"https://api.github.com/users/monika-Dianomic/followers","following_url":"https://api.github.com/users/monika-Dianomic/following{/other_user}","gists_url":"https://api.github.com/users/monika-Dianomic/gists{/gist_id}","starred_url":"https://api.github.com/users/monika-Dianomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monika-Dianomic/subscriptions","organizations_url":"https://api.github.com/users/monika-Dianomic/orgs","repos_url":"https://api.github.com/users/monika-Dianomic/repos","events_url":"https://api.github.com/users/monika-Dianomic/events{/privacy}","received_events_url":"https://api.github.com/users/monika-Dianomic/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227/commits","review_comments_url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227/comments","review_comment_url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues/227/comments","statuses_url":"https://api.github.com/repos/foglamp/foglamp-gui/statuses/327e3b985c28a456d25d0849068c4328b30a1e1a","head":{"label":"foglamp:FOGL-1636","ref":"FOGL-1636","sha":"327e3b985c28a456d25d0849068c4328b30a1e1a","user":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"repo":{"id":115501178,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU1MDExNzg=","name":"foglamp-gui","full_name":"foglamp/foglamp-gui","owner":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foglamp/foglamp-gui","description":"This is a GUI for FogLAMP","fork":false,"url":"https://api.github.com/repos/foglamp/foglamp-gui","forks_url":"https://api.github.com/repos/foglamp/foglamp-gui/forks","keys_url":"https://api.github.com/repos/foglamp/foglamp-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foglamp/foglamp-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foglamp/foglamp-gui/teams","hooks_url":"https://api.github.com/repos/foglamp/foglamp-gui/hooks","issue_events_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues/events{/number}","events_url":"https://api.github.com/repos/foglamp/foglamp-gui/events","assignees_url":"https://api.github.com/repos/foglamp/foglamp-gui/assignees{/user}","branches_url":"https://api.github.com/repos/foglamp/foglamp-gui/branches{/branch}","tags_url":"https://api.github.com/repos/foglamp/foglamp-gui/tags","blobs_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foglamp/foglamp-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/foglamp/foglamp-gui/languages","stargazers_url":"https://api.github.com/repos/foglamp/foglamp-gui/stargazers","contributors_url":"https://api.github.com/repos/foglamp/foglamp-gui/contributors","subscribers_url":"https://api.github.com/repos/foglamp/foglamp-gui/subscribers","subscription_url":"https://api.github.com/repos/foglamp/foglamp-gui/subscription","commits_url":"https://api.github.com/repos/foglamp/foglamp-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/foglamp/foglamp-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/foglamp/foglamp-gui/contents/{+path}","compare_url":"https://api.github.com/repos/foglamp/foglamp-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foglamp/foglamp-gui/merges","archive_url":"https://api.github.com/repos/foglamp/foglamp-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foglamp/foglamp-gui/downloads","issues_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues{/number}","pulls_url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/foglamp/foglamp-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/foglamp/foglamp-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foglamp/foglamp-gui/labels{/name}","releases_url":"https://api.github.com/repos/foglamp/foglamp-gui/releases{/id}","deployments_url":"https://api.github.com/repos/foglamp/foglamp-gui/deployments","created_at":"2017-12-27T08:48:36Z","updated_at":"2018-08-06T08:45:31Z","pushed_at":"2018-08-09T13:37:40Z","git_url":"git://github.com/foglamp/foglamp-gui.git","ssh_url":"git@github.com:foglamp/foglamp-gui.git","clone_url":"https://github.com/foglamp/foglamp-gui.git","svn_url":"https://github.com/foglamp/foglamp-gui","homepage":null,"size":1753,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":9,"watchers":1,"default_branch":"develop"}},"base":{"label":"foglamp:develop","ref":"develop","sha":"114c7a8dd80425da0fadaacdf2827e29923f8118","user":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"repo":{"id":115501178,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU1MDExNzg=","name":"foglamp-gui","full_name":"foglamp/foglamp-gui","owner":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foglamp/foglamp-gui","description":"This is a GUI for FogLAMP","fork":false,"url":"https://api.github.com/repos/foglamp/foglamp-gui","forks_url":"https://api.github.com/repos/foglamp/foglamp-gui/forks","keys_url":"https://api.github.com/repos/foglamp/foglamp-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foglamp/foglamp-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foglamp/foglamp-gui/teams","hooks_url":"https://api.github.com/repos/foglamp/foglamp-gui/hooks","issue_events_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues/events{/number}","events_url":"https://api.github.com/repos/foglamp/foglamp-gui/events","assignees_url":"https://api.github.com/repos/foglamp/foglamp-gui/assignees{/user}","branches_url":"https://api.github.com/repos/foglamp/foglamp-gui/branches{/branch}","tags_url":"https://api.github.com/repos/foglamp/foglamp-gui/tags","blobs_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foglamp/foglamp-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/foglamp/foglamp-gui/languages","stargazers_url":"https://api.github.com/repos/foglamp/foglamp-gui/stargazers","contributors_url":"https://api.github.com/repos/foglamp/foglamp-gui/contributors","subscribers_url":"https://api.github.com/repos/foglamp/foglamp-gui/subscribers","subscription_url":"https://api.github.com/repos/foglamp/foglamp-gui/subscription","commits_url":"https://api.github.com/repos/foglamp/foglamp-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/foglamp/foglamp-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/foglamp/foglamp-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/foglamp/foglamp-gui/contents/{+path}","compare_url":"https://api.github.com/repos/foglamp/foglamp-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foglamp/foglamp-gui/merges","archive_url":"https://api.github.com/repos/foglamp/foglamp-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foglamp/foglamp-gui/downloads","issues_url":"https://api.github.com/repos/foglamp/foglamp-gui/issues{/number}","pulls_url":"https://api.github.com/repos/foglamp/foglamp-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/foglamp/foglamp-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/foglamp/foglamp-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foglamp/foglamp-gui/labels{/name}","releases_url":"https://api.github.com/repos/foglamp/foglamp-gui/releases{/id}","deployments_url":"https://api.github.com/repos/foglamp/foglamp-gui/deployments","created_at":"2017-12-27T08:48:36Z","updated_at":"2018-08-06T08:45:31Z","pushed_at":"2018-08-09T13:37:40Z","git_url":"git://github.com/foglamp/foglamp-gui.git","ssh_url":"git@github.com:foglamp/foglamp-gui.git","clone_url":"https://github.com/foglamp/foglamp-gui.git","svn_url":"https://github.com/foglamp/foglamp-gui","homepage":null,"size":1753,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":9,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227"},"html":{"href":"https://github.com/foglamp/foglamp-gui/pull/227"},"issue":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/issues/227"},"comments":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/foglamp/foglamp-gui/statuses/327e3b985c28a456d25d0849068c4328b30a1e1a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"praveen-garg"}}