{"action":"created","issue":{"url":"https://api.github.com/repos/larsgk/webbluetooth-tester/issues/2","repository_url":"https://api.github.com/repos/larsgk/webbluetooth-tester","labels_url":"https://api.github.com/repos/larsgk/webbluetooth-tester/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/larsgk/webbluetooth-tester/issues/2/comments","events_url":"https://api.github.com/repos/larsgk/webbluetooth-tester/issues/2/events","html_url":"https://github.com/larsgk/webbluetooth-tester/pull/2","id":384948329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDMwOTQ5","number":2,"title":"Port to official LitElement","user":{"login":"filipbech","id":1720790,"node_id":"MDQ6VXNlcjE3MjA3OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1720790?v=4","gravatar_id":"","url":"https://api.github.com/users/filipbech","html_url":"https://github.com/filipbech","followers_url":"https://api.github.com/users/filipbech/followers","following_url":"https://api.github.com/users/filipbech/following{/other_user}","gists_url":"https://api.github.com/users/filipbech/gists{/gist_id}","starred_url":"https://api.github.com/users/filipbech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipbech/subscriptions","organizations_url":"https://api.github.com/users/filipbech/orgs","repos_url":"https://api.github.com/users/filipbech/repos","events_url":"https://api.github.com/users/filipbech/events{/privacy}","received_events_url":"https://api.github.com/users/filipbech/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-27T19:22:24Z","updated_at":"2018-11-28T18:12:08Z","closed_at":"2018-11-28T11:02:37Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/larsgk/webbluetooth-tester/pulls/2","html_url":"https://github.com/larsgk/webbluetooth-tester/pull/2","diff_url":"https://github.com/larsgk/webbluetooth-tester/pull/2.diff","patch_url":"https://github.com/larsgk/webbluetooth-tester/pull/2.patch"},"body":"This is basically just a test of how a port to the real LitElement of a bigger project could be... the module-resolution stuff is a bitch - because lit-element and lit-html no longer ships functioning javascript in the bundle (I dont understand why this is the case). \r\nI build (and committed) some files into this PR, but for ease of use (and further updates) I think we should switch to a hosted version using unpkg... like this instead... (or go all typescript and include a simple build setup)\r\n\r\n´´´ts\r\nimport { html, LitElement } from 'https://unpkg.com/@polymer/lit-element@latest/lit-element.js?module';\r\nimport { repeat } from 'https://unpkg.com/lit-html@0.13.0/directives/repeat.js?module';\r\n```\r\n\r\nAlso... I haven't testet the bluetooth stuff as I haven't really changed anything there, but stuff renders to the page without runtime errors now (my bluetooth device is at work)... \r\n\r\nWhat do you think @larsgk ?"},"comment":{"url":"https://api.github.com/repos/larsgk/webbluetooth-tester/issues/comments/442548714","html_url":"https://github.com/larsgk/webbluetooth-tester/pull/2#issuecomment-442548714","issue_url":"https://api.github.com/repos/larsgk/webbluetooth-tester/issues/2","id":442548714,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjU0ODcxNA==","user":{"login":"justinfagnani","id":522948,"node_id":"MDQ6VXNlcjUyMjk0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/522948?v=4","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T18:12:08Z","updated_at":"2018-11-28T18:12:08Z","author_association":"NONE","body":"Many tools support re-writing bare module specifiers to URLs - Polymer tools, unpkg, WebPack, Rollup Parcel... We use them because there's really no other way to do it. With npm we do not know where dependencies will be installed relative to our package.\r\n\r\nre unpkg.com, it's great to serve demos and samples from, but I wouldn't ever hard-code unpkg URLs into a package. It forces unpkg on transitive dependants and users."}}
{"actor":{"display_login":"justinfagnani"}}