{"action":"created","comment":{"url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/comments/218746871","pull_request_review_id":156749432,"id":218746871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc0Njg3MQ==","diff_hunk":"@@ -131,47 +131,36 @@ public function handle(CommandInterface $command)\n             return false;\n         }\n \n-        $variantRepository = $this->entityManager->getRepository(Detail::class);\n-\n-        /**\n-         * @var null|Detail $mainVariation\n-         */\n-        $mainVariation = $variantRepository->findOneBy(['number' => $product->getNumber()]);\n-\n         $resouce = $this->getArticleResource();\n \n-        if (null === $mainVariation) {\n-            $productModel = $resouce->create($params);\n-        } else {\n-            $this->correctMainDetailAssignment($mainVariation);\n-\n-            $productModel = $resouce->update($mainVariation->getArticleId(), $params);\n-        }\n-\n-        $identities = $this->identityService->findBy([","path":"Adapter/ShopwareAdapter/ServiceBus/CommandHandler/Product/HandleProductCommandHandler.php","position":21,"original_position":21,"commit_id":"653b867e60d26d32f6cc58037fd78a0af7211ea6","original_commit_id":"653b867e60d26d32f6cc58037fd78a0af7211ea6","user":{"login":"jochenmanz","id":116965,"node_id":"MDQ6VXNlcjExNjk2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116965?v=4","gravatar_id":"","url":"https://api.github.com/users/jochenmanz","html_url":"https://github.com/jochenmanz","followers_url":"https://api.github.com/users/jochenmanz/followers","following_url":"https://api.github.com/users/jochenmanz/following{/other_user}","gists_url":"https://api.github.com/users/jochenmanz/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenmanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenmanz/subscriptions","organizations_url":"https://api.github.com/users/jochenmanz/orgs","repos_url":"https://api.github.com/users/jochenmanz/repos","events_url":"https://api.github.com/users/jochenmanz/events{/privacy}","received_events_url":"https://api.github.com/users/jochenmanz/received_events","type":"User","site_admin":false},"body":"Der Weg wurde gewählt um bestehende Artikel ohne Mapping mit der Artikel Nummer zu aktualisieren. Ähnliches machen auch die anderen command Händler (Oder sollten es). Alles für den Fall das ein bestehendes shopware an ein neues plenty angeschlossen werden soll. Könntest du den Check hier mit integrieren?","created_at":"2018-09-19T10:14:55Z","updated_at":"2018-09-19T10:15:53Z","html_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/364#discussion_r218746871","pull_request_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/comments/218746871"},"html":{"href":"https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/364#discussion_r218746871"},"pull_request":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364","id":216579536,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTc5NTM2","html_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/364","diff_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/364.diff","patch_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/364.patch","issue_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues/364","number":364,"state":"open","locked":false,"title":"fix article duplicates","user":{"login":"lacodimizer","id":6031484,"node_id":"MDQ6VXNlcjYwMzE0ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6031484?v=4","gravatar_id":"","url":"https://api.github.com/users/lacodimizer","html_url":"https://github.com/lacodimizer","followers_url":"https://api.github.com/users/lacodimizer/followers","following_url":"https://api.github.com/users/lacodimizer/following{/other_user}","gists_url":"https://api.github.com/users/lacodimizer/gists{/gist_id}","starred_url":"https://api.github.com/users/lacodimizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacodimizer/subscriptions","organizations_url":"https://api.github.com/users/lacodimizer/orgs","repos_url":"https://api.github.com/users/lacodimizer/repos","events_url":"https://api.github.com/users/lacodimizer/events{/privacy}","received_events_url":"https://api.github.com/users/lacodimizer/received_events","type":"User","site_admin":false},"body":"| Q                         | A\r\n| ------------------------- | ---\r\n| issue or Enhancement      | issue\r\n| Changelog updated?        | yes\r\n| License                   | MIT\r\n\r\n\r\n#### What's in this PR?\r\n\r\nThis PR should fix the article duplicates.\r\n\r\n\r\n#### Checklist\r\n\r\n- [x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix","created_at":"2018-09-19T09:54:34Z","updated_at":"2018-09-19T10:15:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5facf295eb93d407f1762c6eaf9eb1577798995a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364/commits","review_comments_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364/comments","review_comment_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues/364/comments","statuses_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/statuses/653b867e60d26d32f6cc58037fd78a0af7211ea6","head":{"label":"lacodimizer:fix-article-duplicates","ref":"fix-article-duplicates","sha":"653b867e60d26d32f6cc58037fd78a0af7211ea6","user":{"login":"lacodimizer","id":6031484,"node_id":"MDQ6VXNlcjYwMzE0ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6031484?v=4","gravatar_id":"","url":"https://api.github.com/users/lacodimizer","html_url":"https://github.com/lacodimizer","followers_url":"https://api.github.com/users/lacodimizer/followers","following_url":"https://api.github.com/users/lacodimizer/following{/other_user}","gists_url":"https://api.github.com/users/lacodimizer/gists{/gist_id}","starred_url":"https://api.github.com/users/lacodimizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacodimizer/subscriptions","organizations_url":"https://api.github.com/users/lacodimizer/orgs","repos_url":"https://api.github.com/users/lacodimizer/repos","events_url":"https://api.github.com/users/lacodimizer/events{/privacy}","received_events_url":"https://api.github.com/users/lacodimizer/received_events","type":"User","site_admin":false},"repo":{"id":145822897,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MjI4OTc=","name":"plentymarkets-shopware-connector","full_name":"lacodimizer/plentymarkets-shopware-connector","private":false,"owner":{"login":"lacodimizer","id":6031484,"node_id":"MDQ6VXNlcjYwMzE0ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6031484?v=4","gravatar_id":"","url":"https://api.github.com/users/lacodimizer","html_url":"https://github.com/lacodimizer","followers_url":"https://api.github.com/users/lacodimizer/followers","following_url":"https://api.github.com/users/lacodimizer/following{/other_user}","gists_url":"https://api.github.com/users/lacodimizer/gists{/gist_id}","starred_url":"https://api.github.com/users/lacodimizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacodimizer/subscriptions","organizations_url":"https://api.github.com/users/lacodimizer/orgs","repos_url":"https://api.github.com/users/lacodimizer/repos","events_url":"https://api.github.com/users/lacodimizer/events{/privacy}","received_events_url":"https://api.github.com/users/lacodimizer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lacodimizer/plentymarkets-shopware-connector","description":"plentymarkets shopware connector plugin","fork":true,"url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector","forks_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/forks","keys_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/teams","hooks_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/hooks","issue_events_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/issues/events{/number}","events_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/events","assignees_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/assignees{/user}","branches_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/branches{/branch}","tags_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/tags","blobs_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/languages","stargazers_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/stargazers","contributors_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/contributors","subscribers_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/subscribers","subscription_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/subscription","commits_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/contents/{+path}","compare_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/merges","archive_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/downloads","issues_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/issues{/number}","pulls_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/labels{/name}","releases_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/releases{/id}","deployments_url":"https://api.github.com/repos/lacodimizer/plentymarkets-shopware-connector/deployments","created_at":"2018-08-23T08:15:52Z","updated_at":"2018-09-19T10:06:19Z","pushed_at":"2018-09-19T10:06:15Z","git_url":"git://github.com/lacodimizer/plentymarkets-shopware-connector.git","ssh_url":"git@github.com:lacodimizer/plentymarkets-shopware-connector.git","clone_url":"https://github.com/lacodimizer/plentymarkets-shopware-connector.git","svn_url":"https://github.com/lacodimizer/plentymarkets-shopware-connector","homepage":"http://www.plentymarkets.eu/shopware/","size":5704,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plentymarkets:master","ref":"master","sha":"b80950c32808f3453f2c9f6f7d4c5d780f85fbe7","user":{"login":"plentymarkets","id":3379035,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzkwMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3379035?v=4","gravatar_id":"","url":"https://api.github.com/users/plentymarkets","html_url":"https://github.com/plentymarkets","followers_url":"https://api.github.com/users/plentymarkets/followers","following_url":"https://api.github.com/users/plentymarkets/following{/other_user}","gists_url":"https://api.github.com/users/plentymarkets/gists{/gist_id}","starred_url":"https://api.github.com/users/plentymarkets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plentymarkets/subscriptions","organizations_url":"https://api.github.com/users/plentymarkets/orgs","repos_url":"https://api.github.com/users/plentymarkets/repos","events_url":"https://api.github.com/users/plentymarkets/events{/privacy}","received_events_url":"https://api.github.com/users/plentymarkets/received_events","type":"Organization","site_admin":false},"repo":{"id":11275138,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NTEzOA==","name":"plentymarkets-shopware-connector","full_name":"plentymarkets/plentymarkets-shopware-connector","private":false,"owner":{"login":"plentymarkets","id":3379035,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzkwMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3379035?v=4","gravatar_id":"","url":"https://api.github.com/users/plentymarkets","html_url":"https://github.com/plentymarkets","followers_url":"https://api.github.com/users/plentymarkets/followers","following_url":"https://api.github.com/users/plentymarkets/following{/other_user}","gists_url":"https://api.github.com/users/plentymarkets/gists{/gist_id}","starred_url":"https://api.github.com/users/plentymarkets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plentymarkets/subscriptions","organizations_url":"https://api.github.com/users/plentymarkets/orgs","repos_url":"https://api.github.com/users/plentymarkets/repos","events_url":"https://api.github.com/users/plentymarkets/events{/privacy}","received_events_url":"https://api.github.com/users/plentymarkets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector","description":"plentymarkets shopware connector plugin","fork":false,"url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector","forks_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/forks","keys_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/teams","hooks_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/hooks","issue_events_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues/events{/number}","events_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/events","assignees_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/assignees{/user}","branches_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/branches{/branch}","tags_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/tags","blobs_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/languages","stargazers_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/stargazers","contributors_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/contributors","subscribers_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/subscribers","subscription_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/subscription","commits_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/contents/{+path}","compare_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/merges","archive_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/downloads","issues_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues{/number}","pulls_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/labels{/name}","releases_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/releases{/id}","deployments_url":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/deployments","created_at":"2013-07-09T06:50:27Z","updated_at":"2018-09-18T15:52:55Z","pushed_at":"2018-09-19T10:00:09Z","git_url":"git://github.com/plentymarkets/plentymarkets-shopware-connector.git","ssh_url":"git@github.com:plentymarkets/plentymarkets-shopware-connector.git","clone_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector.git","svn_url":"https://github.com/plentymarkets/plentymarkets-shopware-connector","homepage":"http://www.plentymarkets.eu/shopware/","size":5657,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":44,"open_issues":5,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364"},"html":{"href":"https://github.com/plentymarkets/plentymarkets-shopware-connector/pull/364"},"issue":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues/364"},"comments":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/plentymarkets/plentymarkets-shopware-connector/statuses/653b867e60d26d32f6cc58037fd78a0af7211ea6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jochenmanz"}}