{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/225510419","pull_request_review_id":165123237,"id":225510419,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUxMDQxOQ==","diff_hunk":"@@ -104,8 +104,6 @@ def test_cross_compile(self, mock_download):\n         )\n \n         plugin.build()\n-        self.assertThat(os.path.join(plugin._cargo_dir, \"config\"), FileExists())","path":"tests/unit/plugins/test_rust.py","position":13,"original_position":13,"commit_id":"29fc6331c4f6f0d35983fd9c102cf828896ef0e9","original_commit_id":"29fc6331c4f6f0d35983fd9c102cf828896ef0e9","user":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"Given the recent changes, do you mind adding this check back?","created_at":"2018-10-16T12:07:54Z","updated_at":"2018-10-16T12:07:55Z","html_url":"https://github.com/snapcore/snapcraft/pull/2264#discussion_r225510419","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/225510419"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2264#discussion_r225510419"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264","id":214833961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODMzOTYx","html_url":"https://github.com/snapcore/snapcraft/pull/2264","diff_url":"https://github.com/snapcore/snapcraft/pull/2264.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/2264.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2264","number":2264,"state":"open","locked":false,"title":"Fix issue where Rust cross compile target is ignored","user":{"login":"eberkund","id":4555959,"node_id":"MDQ6VXNlcjQ1NTU5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4555959?v=4","gravatar_id":"","url":"https://api.github.com/users/eberkund","html_url":"https://github.com/eberkund","followers_url":"https://api.github.com/users/eberkund/followers","following_url":"https://api.github.com/users/eberkund/following{/other_user}","gists_url":"https://api.github.com/users/eberkund/gists{/gist_id}","starred_url":"https://api.github.com/users/eberkund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eberkund/subscriptions","organizations_url":"https://api.github.com/users/eberkund/orgs","repos_url":"https://api.github.com/users/eberkund/repos","events_url":"https://api.github.com/users/eberkund/events{/privacy}","received_events_url":"https://api.github.com/users/eberkund/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [x] Have you successfully run `./runtests.sh tests/unit`?\r\n\r\nI have tested that I can still compile the snap for my native arch and as well as fixing the issue I was having. Please see https://forum.snapcraft.io/t/bug-rust-plugin-not-using-correct-pkg-config-path/7302/4 for more information.\r\n\r\n","created_at":"2018-09-12T04:40:37Z","updated_at":"2018-10-16T12:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98cef6d22a8c2fb54e13b6bea77f09a222a9f9e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2264/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/29fc6331c4f6f0d35983fd9c102cf828896ef0e9","head":{"label":"eberkund:master","ref":"master","sha":"29fc6331c4f6f0d35983fd9c102cf828896ef0e9","user":{"login":"eberkund","id":4555959,"node_id":"MDQ6VXNlcjQ1NTU5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4555959?v=4","gravatar_id":"","url":"https://api.github.com/users/eberkund","html_url":"https://github.com/eberkund","followers_url":"https://api.github.com/users/eberkund/followers","following_url":"https://api.github.com/users/eberkund/following{/other_user}","gists_url":"https://api.github.com/users/eberkund/gists{/gist_id}","starred_url":"https://api.github.com/users/eberkund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eberkund/subscriptions","organizations_url":"https://api.github.com/users/eberkund/orgs","repos_url":"https://api.github.com/users/eberkund/repos","events_url":"https://api.github.com/users/eberkund/events{/privacy}","received_events_url":"https://api.github.com/users/eberkund/received_events","type":"User","site_admin":false},"repo":{"id":148268307,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyNjgzMDc=","name":"snapcraft","full_name":"eberkund/snapcraft","private":false,"owner":{"login":"eberkund","id":4555959,"node_id":"MDQ6VXNlcjQ1NTU5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4555959?v=4","gravatar_id":"","url":"https://api.github.com/users/eberkund","html_url":"https://github.com/eberkund","followers_url":"https://api.github.com/users/eberkund/followers","following_url":"https://api.github.com/users/eberkund/following{/other_user}","gists_url":"https://api.github.com/users/eberkund/gists{/gist_id}","starred_url":"https://api.github.com/users/eberkund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eberkund/subscriptions","organizations_url":"https://api.github.com/users/eberkund/orgs","repos_url":"https://api.github.com/users/eberkund/repos","events_url":"https://api.github.com/users/eberkund/events{/privacy}","received_events_url":"https://api.github.com/users/eberkund/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eberkund/snapcraft","description":"Package, distribute, and update any app for Linux and IoT.","fork":true,"url":"https://api.github.com/repos/eberkund/snapcraft","forks_url":"https://api.github.com/repos/eberkund/snapcraft/forks","keys_url":"https://api.github.com/repos/eberkund/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eberkund/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eberkund/snapcraft/teams","hooks_url":"https://api.github.com/repos/eberkund/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/eberkund/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/eberkund/snapcraft/events","assignees_url":"https://api.github.com/repos/eberkund/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/eberkund/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/eberkund/snapcraft/tags","blobs_url":"https://api.github.com/repos/eberkund/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eberkund/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eberkund/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/eberkund/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eberkund/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/eberkund/snapcraft/languages","stargazers_url":"https://api.github.com/repos/eberkund/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/eberkund/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/eberkund/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/eberkund/snapcraft/subscription","commits_url":"https://api.github.com/repos/eberkund/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/eberkund/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/eberkund/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/eberkund/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/eberkund/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/eberkund/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eberkund/snapcraft/merges","archive_url":"https://api.github.com/repos/eberkund/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eberkund/snapcraft/downloads","issues_url":"https://api.github.com/repos/eberkund/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/eberkund/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/eberkund/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/eberkund/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eberkund/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/eberkund/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/eberkund/snapcraft/deployments","created_at":"2018-09-11T06:04:03Z","updated_at":"2018-10-12T05:10:24Z","pushed_at":"2018-10-12T05:10:22Z","git_url":"git://github.com/eberkund/snapcraft.git","ssh_url":"git@github.com:eberkund/snapcraft.git","clone_url":"https://github.com/eberkund/snapcraft.git","svn_url":"https://github.com/eberkund/snapcraft","homepage":"","size":21483,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"024c63453a244c36f931db5579d652538c75f5ab","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE5OTEzNg==","name":"snapcraft","full_name":"snapcore/snapcraft","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapcraft","description":"Package, distribute, and update any app for Linux and IoT.","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2018-10-16T04:17:12Z","pushed_at":"2018-10-16T11:30:00Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":"https://snapcraft.io","size":21514,"stargazers_count":675,"watchers_count":675,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":263,"open_issues":62,"watchers":675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2264"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2264"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2264/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2264/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/29fc6331c4f6f0d35983fd9c102cf828896ef0e9"}},"author_association":"NONE"}}
{"actor":{"display_login":"sergiusens"}}