{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/190353934","pull_request_review_id":122712189,"id":190353934,"diff_hunk":"@@ -114,6 +113,10 @@ def static calculateBuildCommands(def os, def configuration, def scenario, def i\n         if (configuration == 'Debug')\n         {\n             if (scenario == 'coreclr'){\n+                // Run multimodule tests only under CoreCLR mode\n+                buildCommands += \"tests\\\\runtest.cmd ${configuration} /multimodule\"","path":"netci.groovy","position":15,"original_position":15,"commit_id":"246637f02ecb402d80240bd0b700a87a31b55412","original_commit_id":"246637f02ecb402d80240bd0b700a87a31b55412","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"body":"It would be easier to read/understand this if line 110 got changed to always pass `skiptests` and an extra `tests\\\\runtest.cmd ${configuration}` and `tests\\\\runtest.cmd ${configuration} /multimodule` command was added if scenario == coreclr.\r\n\r\n(Also, line 112 currently still adds a multimodule test pass for the corefx scenario leg.)","created_at":"2018-05-23T18:29:05Z","updated_at":"2018-05-23T18:29:06Z","html_url":"https://github.com/dotnet/corert/pull/5846#discussion_r190353934","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/5846","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/190353934"},"html":{"href":"https://github.com/dotnet/corert/pull/5846#discussion_r190353934"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5846"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/5846","id":190063504,"html_url":"https://github.com/dotnet/corert/pull/5846","diff_url":"https://github.com/dotnet/corert/pull/5846.diff","patch_url":"https://github.com/dotnet/corert/pull/5846.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/5846","number":5846,"state":"open","locked":false,"title":"Skip simple tests and multimodule tests under CoreFX","user":{"login":"A-And","id":6618580,"avatar_url":"https://avatars3.githubusercontent.com/u/6618580?v=4","gravatar_id":"","url":"https://api.github.com/users/A-And","html_url":"https://github.com/A-And","followers_url":"https://api.github.com/users/A-And/followers","following_url":"https://api.github.com/users/A-And/following{/other_user}","gists_url":"https://api.github.com/users/A-And/gists{/gist_id}","starred_url":"https://api.github.com/users/A-And/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A-And/subscriptions","organizations_url":"https://api.github.com/users/A-And/orgs","repos_url":"https://api.github.com/users/A-And/repos","events_url":"https://api.github.com/users/A-And/events{/privacy}","received_events_url":"https://api.github.com/users/A-And/received_events","type":"User","site_admin":false},"body":"This should have been merged along with #5823 - adding it now so we save on some CI machine time.","created_at":"2018-05-23T18:20:08Z","updated_at":"2018-05-23T18:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"221fcb805c31aaf9ab84c0af8330ae8345d044ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/5846/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/5846/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/5846/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/246637f02ecb402d80240bd0b700a87a31b55412","head":{"label":"A-And:NetCISkipSimple","ref":"NetCISkipSimple","sha":"246637f02ecb402d80240bd0b700a87a31b55412","user":{"login":"A-And","id":6618580,"avatar_url":"https://avatars3.githubusercontent.com/u/6618580?v=4","gravatar_id":"","url":"https://api.github.com/users/A-And","html_url":"https://github.com/A-And","followers_url":"https://api.github.com/users/A-And/followers","following_url":"https://api.github.com/users/A-And/following{/other_user}","gists_url":"https://api.github.com/users/A-And/gists{/gist_id}","starred_url":"https://api.github.com/users/A-And/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A-And/subscriptions","organizations_url":"https://api.github.com/users/A-And/orgs","repos_url":"https://api.github.com/users/A-And/repos","events_url":"https://api.github.com/users/A-And/events{/privacy}","received_events_url":"https://api.github.com/users/A-And/received_events","type":"User","site_admin":false},"repo":{"id":62669886,"name":"corert","full_name":"A-And/corert","owner":{"login":"A-And","id":6618580,"avatar_url":"https://avatars3.githubusercontent.com/u/6618580?v=4","gravatar_id":"","url":"https://api.github.com/users/A-And","html_url":"https://github.com/A-And","followers_url":"https://api.github.com/users/A-And/followers","following_url":"https://api.github.com/users/A-And/following{/other_user}","gists_url":"https://api.github.com/users/A-And/gists{/gist_id}","starred_url":"https://api.github.com/users/A-And/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A-And/subscriptions","organizations_url":"https://api.github.com/users/A-And/orgs","repos_url":"https://api.github.com/users/A-And/repos","events_url":"https://api.github.com/users/A-And/events{/privacy}","received_events_url":"https://api.github.com/users/A-And/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/A-And/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/A-And/corert","forks_url":"https://api.github.com/repos/A-And/corert/forks","keys_url":"https://api.github.com/repos/A-And/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/A-And/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/A-And/corert/teams","hooks_url":"https://api.github.com/repos/A-And/corert/hooks","issue_events_url":"https://api.github.com/repos/A-And/corert/issues/events{/number}","events_url":"https://api.github.com/repos/A-And/corert/events","assignees_url":"https://api.github.com/repos/A-And/corert/assignees{/user}","branches_url":"https://api.github.com/repos/A-And/corert/branches{/branch}","tags_url":"https://api.github.com/repos/A-And/corert/tags","blobs_url":"https://api.github.com/repos/A-And/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/A-And/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/A-And/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/A-And/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/A-And/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/A-And/corert/languages","stargazers_url":"https://api.github.com/repos/A-And/corert/stargazers","contributors_url":"https://api.github.com/repos/A-And/corert/contributors","subscribers_url":"https://api.github.com/repos/A-And/corert/subscribers","subscription_url":"https://api.github.com/repos/A-And/corert/subscription","commits_url":"https://api.github.com/repos/A-And/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/A-And/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/A-And/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/A-And/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/A-And/corert/contents/{+path}","compare_url":"https://api.github.com/repos/A-And/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/A-And/corert/merges","archive_url":"https://api.github.com/repos/A-And/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/A-And/corert/downloads","issues_url":"https://api.github.com/repos/A-And/corert/issues{/number}","pulls_url":"https://api.github.com/repos/A-And/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/A-And/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/A-And/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/A-And/corert/labels{/name}","releases_url":"https://api.github.com/repos/A-And/corert/releases{/id}","deployments_url":"https://api.github.com/repos/A-And/corert/deployments","created_at":"2016-07-05T21:10:37Z","updated_at":"2018-05-22T23:23:21Z","pushed_at":"2018-05-23T18:26:37Z","git_url":"git://github.com/A-And/corert.git","ssh_url":"git@github.com:A-And/corert.git","clone_url":"https://github.com/A-And/corert.git","svn_url":"https://github.com/A-And/corert","homepage":"http://dotnet.github.io/","size":27418,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4aeeb6a582156f52d1d25912e8819c50ea9e5917","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2018-05-23T08:59:48Z","pushed_at":"2018-05-23T18:26:39Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":27382,"stargazers_count":1255,"watchers_count":1255,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":308,"mirror_url":null,"archived":false,"open_issues_count":258,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":308,"open_issues":258,"watchers":1255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5846"},"html":{"href":"https://github.com/dotnet/corert/pull/5846"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/5846"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/5846/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5846/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5846/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/246637f02ecb402d80240bd0b700a87a31b55412"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MichalStrehovsky"}}