{"push_id":2758869513,"size":28,"distinct_size":28,"ref":"refs/heads/basicCredsOnly2","head":"12e5bf27e166727b9c9ce80b51d76f86d57d7611","before":"ebd8d89f2ca311bcc76aeab22f0c09cf86cd8628","commits":[{"sha":"ce45c0840697a0d357911e5ef6afd690215519c4","author":{"name":"Ashish Jain","email":"507d8e4f2dcf3de7d46162618a8ebec3b9da9222@microsoft.com"},"message":"Added solution packages folder value in IVsPathContext api (#2326)\n\n* Added solution packages folder value in IVsPathContext api\r\n\r\n* Add another variation of TryCreateSolutionContext to accept SolutionDirectory\r\n\r\n* Addressed comments\r\n\r\n* Fixed failing tests","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/ce45c0840697a0d357911e5ef6afd690215519c4"},{"sha":"82dec5d7ef12975184891a7e0cfe6447bcc40c5e","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":" [Test] Adding xunit logs to flaky test in NuGetPackageManagerTests\n\nWorking towards https://github.com/NuGet/Home/issues/7105\r\n\r\nThe test ` TestPacMan_PreviewInstallPackage_BuildIntegrate_RaiseTelemetryEventsWithWarningCode` is flaky and does not fail locally. So this PR adds `xunit` logs to the test to allow better debugging on the CI.","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/82dec5d7ef12975184891a7e0cfe6447bcc40c5e"},{"sha":"6e2a37b0f420e67d775a68f5124d46c3e2b69599","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"Removing dead code from NuGet.Packaging.Rules (#2335)\n\nWhile investigating the pack error codes and corresponding documentation, I found some dead code in `NuGet.Packaging.Rules`. This PR removes that.","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/6e2a37b0f420e67d775a68f5124d46c3e2b69599"},{"sha":"1123779dd300afb48ae6d6d61fc69eaf9469aec1","author":{"name":"Patricio Beltran","email":"1bc427a4c27325713d55246da67e09780f5328a3@gmail.com"},"message":"Rebranding to 5.0.0preview1 (#2338)","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/1123779dd300afb48ae6d6d61fc69eaf9469aec1"},{"sha":"a71a96c6ec648309270918b338349b090dfcc3da","author":{"name":"Zhi Li","email":"fc066f4502679b4ae87e0ebdd8967a250211fd1a@outlook.com"},"message":"Restore Fix: allow project reference to override package dependency","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/a71a96c6ec648309270918b338349b090dfcc3da"},{"sha":"e679f55e69551ec2dbb900780e1a5e0488211af6","author":{"name":"Ashish Jain","email":"507d8e4f2dcf3de7d46162618a8ebec3b9da9222@microsoft.com"},"message":"As per XAML request, we'll always return SolutionPackagesFolder in IVsPathContext2. (#2343)\n\nIt will resolve XAML create new project scenario where folder doesn't exists yet.","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/e679f55e69551ec2dbb900780e1a5e0488211af6"},{"sha":"e11391f03331ac3cfa520bfd83d38acd472fc302","author":{"name":"Rohit Agrawal","email":"364a434a7b1ef8765788d9d743e042349165ddf9@microsoft.com"},"message":"fix broken e2e test (#2346)","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/e11391f03331ac3cfa520bfd83d38acd472fc302"},{"sha":"4277fadddd8b17c551f57c9688abbd34d604f61f","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"Refactoring ErrorList into NuGet.VisualStudio.Common (#2340)\n\nFollow up to https://github.com/NuGet/NuGet.Client/pull/2313\r\n\r\nAs requested by @nkolev92, I have refactored the code to move `ErrorListTableEntry.cs` and `ErrorListTableDataSource.cs` from `NuGet.SolutionRestoreManager` to `NuGet.VisualStudio.Common` and removed the dependency from `NuGet.Tools` to `NuGet.SolutionRestoreManager`\r\n\r\nAlso updating the guid for test projects based off of this [comment](https://github.com/dotnet/project-system/issues/3079#issuecomment-354180353).","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/4277fadddd8b17c551f57c9688abbd34d604f61f"},{"sha":"f82a7ac6b54719225cda5f3317e3c31d5843279d","author":{"name":"Vincent","email":"d938b21f23f02a39eb2ed88cb2e03b4523d8462f@users.noreply.github.com"},"message":"Fix InitializeResourceAsync() throttling (#2258)","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/f82a7ac6b54719225cda5f3317e3c31d5843279d"},{"sha":"008e00cc1c259a9108e05cec1953562d0a22fd90","author":{"name":"Rohit Agrawal","email":"364a434a7b1ef8765788d9d743e042349165ddf9@microsoft.com"},"message":" make vsix installable in dev15 and dev16 (#2350)","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/008e00cc1c259a9108e05cec1953562d0a22fd90"},{"sha":"e9486ba6235ddf4f11608d70a6e17de7eeba86cc","author":{"name":"Rohit Agrawal","email":"364a434a7b1ef8765788d9d743e042349165ddf9@microsoft.com"},"message":"apex stability and remove flaky tests (#2347)","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/e9486ba6235ddf4f11608d70a6e17de7eeba86cc"},{"sha":"cae087c24b90a708da0417179fe04d17367f0a66","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"[WIP][Test] Adding lock on telemetryEvents in Packagemanager test (#2345)\n\nFollowup to https://github.com/NuGet/NuGet.Client/pull/2333\r\n\r\nSeems that `NuGetPackageManager.PreviewInstallPackageAsync` leaves tasks running in case of a failure which is still adding events to `telemetryEvents`. To prevent that, this PR adds a test telemetry service `TestNuGetVSTelemetryService` which locks on the logger to make the logging serial.","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/cae087c24b90a708da0417179fe04d17367f0a66"},{"sha":"5e43cd94734830254f76751e29c00eaebcc5f74f","author":{"name":"Ashish Jain","email":"507d8e4f2dcf3de7d46162618a8ebec3b9da9222@microsoft.com"},"message":"Extending PumpingJTF from DelegatingJoinableTaskFactory instead of JoinableTaskFactory to resolve CPS deadlock (#2351)\n\nUnfortunately, what CPS needs is the callback to OnTransitioningToMainThread which is on the JoinableTaskFactory (and a switch to main thread calls that only for the ambient jobs owner, which in this case is the PumpingJTF and not the CPS JTF). So using the context is not enough, the full JTF must be used. The solution is to wrap and delegate to an inner JTF, which is why we've moved to DelegatingJoinableTaskFactory which allows passing a full JTF instead of just context.","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/5e43cd94734830254f76751e29c00eaebcc5f74f"},{"sha":"7dec8e2bcbda2f7478f66a2c7f8095f845d98c79","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"Removing NU5006 and falling back to NU5000 (#2352)\n\nAfter talking to @rohit21agrawal we realized there was no clear scenario that would hit this error. So this removes the dedicated error code for it. If the scenario is hit, we will report it as `NU5000`.","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/7dec8e2bcbda2f7478f66a2c7f8095f845d98c79"},{"sha":"eea78616699c84f153d3687cd0b69c0c767568dc","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"Display signing warnings on package install in VS (#2353)\n\n## Bug\r\nFixes: https://github.com/NuGet/Home/issues/6318  \r\nRegression: No\r\n\r\n## Fix\r\nDetails: This PR adds support, in `INuGetProjectContext` and all of its child types, to log/error using `ILogMessage`. This primarily improves package install scenarios into classic csproj, where warnings were logged into the output console but not displayed in the VS error list.\r\n\r\nFurther, this fixes a regression caused by https://github.com/NuGet/NuGet.Client/commit/d0f97b53c1850d7209723afc7aa85986beabe3b8 where the error list would not clear on solution close and build.\r\n\r\n## Testing/Validation\r\nTests Added: No  \r\nReason for not adding tests:  UI change\r\nValidation done:  manual validation","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/eea78616699c84f153d3687cd0b69c0c767568dc"},{"sha":"1588078e2a06e44bd2050a4ef1d42cde01ded3cd","author":{"name":"Ashish Jain","email":"507d8e4f2dcf3de7d46162618a8ebec3b9da9222@microsoft.com"},"message":"Updated NU1105 error message to be more helpful. (#2356)","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/1588078e2a06e44bd2050a4ef1d42cde01ded3cd"},{"sha":"bd9167095f8e45872877cf9cee275feef38690dc","author":{"name":"Zhi Li","email":"fc066f4502679b4ae87e0ebdd8967a250211fd1a@outlook.com"},"message":"Error/Warning: Improve NU1107 error message","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/bd9167095f8e45872877cf9cee275feef38690dc"},{"sha":"9e7b092f9af6f0998e4b30aba6be01c7d059dde4","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"Adding package id and source prefix to signing logs (#2360)\n\n## Bug\r\nFixes: https://github.com/NuGet/Home/issues/6944\r\nRegression: No\r\n\r\n## Fix\r\nDetails: This PR fixes signing logs by adding a prefix indicating the package id, version and source for the error or warning.\r\n\r\n## Testing/Validation\r\nTests Added: Yes\r\nValidation done:  Manual validation","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/9e7b092f9af6f0998e4b30aba6be01c7d059dde4"},{"sha":"3d5731ae04d603674cf9b07613007e715662527a","author":{"name":"Ashish Jain","email":"507d8e4f2dcf3de7d46162618a8ebec3b9da9222@microsoft.com"},"message":"Moved from SemaphoreSlim to ReentrantSemaphore so that we don't block UI thread while waiting for semaphore inside InfiniteScrollListBoxAutomationPeer (#2334)\n\nMoved from SemaphoreSlim to ReentrantSemaphore to fix UI hang","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/3d5731ae04d603674cf9b07613007e715662527a"},{"sha":"c76681f6400c0b2883543ba6a911abcbc9e7bfc8","author":{"name":"Ankit Mishra","email":"06d13c68d5b44599045c0636ee4cc0cb99ebef24@microsoft.com"},"message":"Adding submodule checkout to Apex test step in the yaml file (#2363)\n\nBased on an email discussion with VSTS folks, it seems that VSTS has stopped checking out submodules by default. This PR fixes that by adding the following step to the Apex test step - \r\n\r\n```\r\n- checkout: self\r\n    clean: true\r\n    submodules: true\r\n```","distinct":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits/c76681f6400c0b2883543ba6a911abcbc9e7bfc8"}]}
{"actor":{"display_login":"jmyersmsft"}}