{"action":"created","issue":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/5890","repository_url":"https://api.github.com/repos/habitat-sh/habitat","labels_url":"https://api.github.com/repos/habitat-sh/habitat/issues/5890/labels{/name}","comments_url":"https://api.github.com/repos/habitat-sh/habitat/issues/5890/comments","events_url":"https://api.github.com/repos/habitat-sh/habitat/issues/5890/events","html_url":"https://github.com/habitat-sh/habitat/pull/5890","id":385869284,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzQxODc3","number":5890,"title":"WIP [svc health check] allow configurable interval between checks. WIP","user":{"login":"jeremymv2","id":1991696,"node_id":"MDQ6VXNlcjE5OTE2OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1991696?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymv2","html_url":"https://github.com/jeremymv2","followers_url":"https://api.github.com/users/jeremymv2/followers","following_url":"https://api.github.com/users/jeremymv2/following{/other_user}","gists_url":"https://api.github.com/users/jeremymv2/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymv2/subscriptions","organizations_url":"https://api.github.com/users/jeremymv2/orgs","repos_url":"https://api.github.com/users/jeremymv2/repos","events_url":"https://api.github.com/users/jeremymv2/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymv2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-29T18:32:26Z","updated_at":"2018-11-29T18:36:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/habitat-sh/habitat/pulls/5890","html_url":"https://github.com/habitat-sh/habitat/pull/5890","diff_url":"https://github.com/habitat-sh/habitat/pull/5890.diff","patch_url":"https://github.com/habitat-sh/habitat/pull/5890.patch"},"body":"### :nut_and_bolt: Description\r\n\r\nResolves https://github.com/habitat-sh/habitat/issues/5466\r\n\r\nThis change will allow users to specify a health check interval at service load time by storing a `health_check_interval_seconds` in the `Spec` file for the service such as:\r\n\r\n```\r\n$ sudo cat /hab/sup/default/specs/elasticsearch.spec\r\nident = \"core/elasticsearch\"\r\ngroup = \"default\"\r\nbldr_url = \"https://bldr.habitat.sh\"\r\nchannel = \"stable\"\r\ntopology = \"standalone\"\r\nupdate_strategy = \"none\"\r\nbinds = []\r\nbinding_mode = \"strict\"\r\ndesired_state = \"up\"\r\nhealth_check_interval_seconds = 35\r\n```\r\n\r\nFeatures of the PR:\r\n- add `--health-check-interval` to `hab svc load ..`\r\n- validation enforces a u32 value between 1 and 86400 seconds\r\n- Service or census changes will trigger all Services to re-run Health Check within 30s regardless if their configured interval is > 30s.\r\n\r\n**Note** I will follow up with test and doc updates, but first, I wanted to open this up for discussion before moving forward.\r\n\r\nRelated https://github.com/habitat-sh/habitat/issues/5326\r\nRelated https://github.com/habitat-sh/habitat/issues/5584\r\n\r\n@christophermaier @mwrock @baumanj @raskchanky What are your thoughts on this implementation as a preliminary step to adding more usefulness to our Service Health Check feature? \r\n\r\nSigned-off-by: Jeremy J. Miller <jm@chef.io>\r\n\r\n### :white_check_mark: Checklist\r\n- [ ] Necessary tests added/updated?\r\n- [ ] Necessary docs added/updated?\r\n- [x] Code actually executed?\r\n- [x] Vetting performed (unit tests, lint, etc.)?\r\n"},"comment":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/comments/442944266","html_url":"https://github.com/habitat-sh/habitat/pull/5890#issuecomment-442944266","issue_url":"https://api.github.com/repos/habitat-sh/habitat/issues/5890","id":442944266,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjk0NDI2Ng==","user":{"login":"baumanj","id":5906042,"node_id":"MDQ6VXNlcjU5MDYwNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5906042?v=4","gravatar_id":"","url":"https://api.github.com/users/baumanj","html_url":"https://github.com/baumanj","followers_url":"https://api.github.com/users/baumanj/followers","following_url":"https://api.github.com/users/baumanj/following{/other_user}","gists_url":"https://api.github.com/users/baumanj/gists{/gist_id}","starred_url":"https://api.github.com/users/baumanj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baumanj/subscriptions","organizations_url":"https://api.github.com/users/baumanj/orgs","repos_url":"https://api.github.com/users/baumanj/repos","events_url":"https://api.github.com/users/baumanj/events{/privacy}","received_events_url":"https://api.github.com/users/baumanj/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T18:36:35Z","updated_at":"2018-11-29T18:36:35Z","author_association":"MEMBER","body":"I'm planning to look at this tomorrow and hope to have feedback for you by Monday."}}
{"actor":{"display_login":"baumanj"}}