{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/26679","repository_url":"https://api.github.com/repos/laravel/framework","labels_url":"https://api.github.com/repos/laravel/framework/issues/26679/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/26679/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/26679/events","html_url":"https://github.com/laravel/framework/pull/26679","id":386054805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODg0NTMy","number":26679,"title":"[5.8] Improved naming convention consistency","user":{"login":"yaquawa","id":13927101,"node_id":"MDQ6VXNlcjEzOTI3MTAx","avatar_url":"https://avatars3.githubusercontent.com/u/13927101?v=4","gravatar_id":"","url":"https://api.github.com/users/yaquawa","html_url":"https://github.com/yaquawa","followers_url":"https://api.github.com/users/yaquawa/followers","following_url":"https://api.github.com/users/yaquawa/following{/other_user}","gists_url":"https://api.github.com/users/yaquawa/gists{/gist_id}","starred_url":"https://api.github.com/users/yaquawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaquawa/subscriptions","organizations_url":"https://api.github.com/users/yaquawa/orgs","repos_url":"https://api.github.com/users/yaquawa/repos","events_url":"https://api.github.com/users/yaquawa/events{/privacy}","received_events_url":"https://api.github.com/users/yaquawa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-30T06:25:46Z","updated_at":"2018-11-30T13:41:31Z","closed_at":"2018-11-30T13:41:31Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/26679","html_url":"https://github.com/laravel/framework/pull/26679","diff_url":"https://github.com/laravel/framework/pull/26679.diff","patch_url":"https://github.com/laravel/framework/pull/26679.patch"},"body":"This is similar to #26374\r\n> Added `Name` as the suffix to clarify that it's the \"key\" but not the \"value\" of the \"key\".\r\n\r\nit should align to:\r\nhttps://github.com/laravel/framework/blob/5.7/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php#L1069-L1072\r\n\r\nAlso, the method `relation` actually override it's parent's one, which can cause problem when some one wants to call it's parent's `relation` method.\r\n\r\nI'm not sure if the `relationName` should be implemented in all the Relation classes, but at least it should keep the naming convention consistency.\r\nBy the way, I have a use case when calling the `\\Illuminate\\Database\\Eloquent\\Builder::whereHas` method, because I'm getting the relation name programmatically if all Relation classes implement this `relationName` can be very helpful(it's really tricky to get the relation name from the relation object itself)."},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/443206659","html_url":"https://github.com/laravel/framework/pull/26679#issuecomment-443206659","issue_url":"https://api.github.com/repos/laravel/framework/issues/26679","id":443206659,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzIwNjY1OQ==","user":{"login":"taylorotwell","id":463230,"node_id":"MDQ6VXNlcjQ2MzIzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/463230?v=4","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T13:41:31Z","updated_at":"2018-11-30T13:41:31Z","author_association":"MEMBER","body":"No plans on introducing this breaking change for this reason."}}
{"actor":{"display_login":"taylorotwell"}}