{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/175750782","pull_request_review_id":105329568,"id":175750782,"diff_hunk":"@@ -423,6 +431,9 @@ public void terminateCluster(ApplicationId applicationId) throws FlinkException\n \t\t\t@Nullable JobGraph jobGraph,\n \t\t\tboolean detached) throws Exception {\n \n+\t\t// ------------------ Check if configuration is valid --------------------\n+\t\tcheckConfig(clusterSpecification);","path":"flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java","position":27,"original_position":27,"commit_id":"c984370228e6d6960eb521f76c849973c3ced2ee","original_commit_id":"c984370228e6d6960eb521f76c849973c3ced2ee","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"let's not abbreviate and name it `validateClusterSpecification`","created_at":"2018-03-20T12:45:06Z","updated_at":"2018-03-20T12:54:04Z","html_url":"https://github.com/apache/flink/pull/5726#discussion_r175750782","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/5726","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/175750782"},"html":{"href":"https://github.com/apache/flink/pull/5726#discussion_r175750782"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/5726"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5726","id":176125807,"html_url":"https://github.com/apache/flink/pull/5726","diff_url":"https://github.com/apache/flink/pull/5726.diff","patch_url":"https://github.com/apache/flink/pull/5726.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/5726","number":5726,"state":"open","locked":false,"title":"[FLINK-9028][flip6] perform parameters checking before starting cluster","user":{"login":"sihuazhou","id":7480427,"avatar_url":"https://avatars2.githubusercontent.com/u/7480427?v=4","gravatar_id":"","url":"https://api.github.com/users/sihuazhou","html_url":"https://github.com/sihuazhou","followers_url":"https://api.github.com/users/sihuazhou/followers","following_url":"https://api.github.com/users/sihuazhou/following{/other_user}","gists_url":"https://api.github.com/users/sihuazhou/gists{/gist_id}","starred_url":"https://api.github.com/users/sihuazhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihuazhou/subscriptions","organizations_url":"https://api.github.com/users/sihuazhou/orgs","repos_url":"https://api.github.com/users/sihuazhou/repos","events_url":"https://api.github.com/users/sihuazhou/events{/privacy}","received_events_url":"https://api.github.com/users/sihuazhou/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nPerform parameters checking before starting cluster to prevent to setup a problematic cluster.\r\n\r\n## Brief change log\r\n\r\n- perform parameters checking before starting cluster\r\n\r\n## Verifying this change\r\n\r\nThis change is a trivial rework / code cleanup without any test coverage.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\nno\r\n","created_at":"2018-03-20T09:06:37Z","updated_at":"2018-03-20T12:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8522f539f8206b285ef78393d6e1b6fbd81dbe2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/5726/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/5726/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/5726/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/c984370228e6d6960eb521f76c849973c3ced2ee","head":{"label":"sihuazhou:flip6_check_parameter_before_start_cluster","ref":"flip6_check_parameter_before_start_cluster","sha":"c984370228e6d6960eb521f76c849973c3ced2ee","user":{"login":"sihuazhou","id":7480427,"avatar_url":"https://avatars2.githubusercontent.com/u/7480427?v=4","gravatar_id":"","url":"https://api.github.com/users/sihuazhou","html_url":"https://github.com/sihuazhou","followers_url":"https://api.github.com/users/sihuazhou/followers","following_url":"https://api.github.com/users/sihuazhou/following{/other_user}","gists_url":"https://api.github.com/users/sihuazhou/gists{/gist_id}","starred_url":"https://api.github.com/users/sihuazhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihuazhou/subscriptions","organizations_url":"https://api.github.com/users/sihuazhou/orgs","repos_url":"https://api.github.com/users/sihuazhou/repos","events_url":"https://api.github.com/users/sihuazhou/events{/privacy}","received_events_url":"https://api.github.com/users/sihuazhou/received_events","type":"User","site_admin":false},"repo":{"id":97116559,"name":"flink","full_name":"sihuazhou/flink","owner":{"login":"sihuazhou","id":7480427,"avatar_url":"https://avatars2.githubusercontent.com/u/7480427?v=4","gravatar_id":"","url":"https://api.github.com/users/sihuazhou","html_url":"https://github.com/sihuazhou","followers_url":"https://api.github.com/users/sihuazhou/followers","following_url":"https://api.github.com/users/sihuazhou/following{/other_user}","gists_url":"https://api.github.com/users/sihuazhou/gists{/gist_id}","starred_url":"https://api.github.com/users/sihuazhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihuazhou/subscriptions","organizations_url":"https://api.github.com/users/sihuazhou/orgs","repos_url":"https://api.github.com/users/sihuazhou/repos","events_url":"https://api.github.com/users/sihuazhou/events{/privacy}","received_events_url":"https://api.github.com/users/sihuazhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sihuazhou/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/sihuazhou/flink","forks_url":"https://api.github.com/repos/sihuazhou/flink/forks","keys_url":"https://api.github.com/repos/sihuazhou/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sihuazhou/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sihuazhou/flink/teams","hooks_url":"https://api.github.com/repos/sihuazhou/flink/hooks","issue_events_url":"https://api.github.com/repos/sihuazhou/flink/issues/events{/number}","events_url":"https://api.github.com/repos/sihuazhou/flink/events","assignees_url":"https://api.github.com/repos/sihuazhou/flink/assignees{/user}","branches_url":"https://api.github.com/repos/sihuazhou/flink/branches{/branch}","tags_url":"https://api.github.com/repos/sihuazhou/flink/tags","blobs_url":"https://api.github.com/repos/sihuazhou/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sihuazhou/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sihuazhou/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/sihuazhou/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sihuazhou/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/sihuazhou/flink/languages","stargazers_url":"https://api.github.com/repos/sihuazhou/flink/stargazers","contributors_url":"https://api.github.com/repos/sihuazhou/flink/contributors","subscribers_url":"https://api.github.com/repos/sihuazhou/flink/subscribers","subscription_url":"https://api.github.com/repos/sihuazhou/flink/subscription","commits_url":"https://api.github.com/repos/sihuazhou/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/sihuazhou/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/sihuazhou/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/sihuazhou/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/sihuazhou/flink/contents/{+path}","compare_url":"https://api.github.com/repos/sihuazhou/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sihuazhou/flink/merges","archive_url":"https://api.github.com/repos/sihuazhou/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sihuazhou/flink/downloads","issues_url":"https://api.github.com/repos/sihuazhou/flink/issues{/number}","pulls_url":"https://api.github.com/repos/sihuazhou/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/sihuazhou/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/sihuazhou/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sihuazhou/flink/labels{/name}","releases_url":"https://api.github.com/repos/sihuazhou/flink/releases{/id}","deployments_url":"https://api.github.com/repos/sihuazhou/flink/deployments","created_at":"2017-07-13T11:46:13Z","updated_at":"2018-03-20T08:00:24Z","pushed_at":"2018-03-20T11:42:30Z","git_url":"git://github.com/sihuazhou/flink.git","ssh_url":"git@github.com:sihuazhou/flink.git","clone_url":"https://github.com/sihuazhou/flink.git","svn_url":"https://github.com/sihuazhou/flink","homepage":null,"size":149134,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4536e9cbe1925c0a6dd24f74c2b73a675afb2625","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-03-20T11:08:50Z","pushed_at":"2018-03-20T12:13:09Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":150219,"stargazers_count":3430,"watchers_count":3430,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2343,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2343,"open_issues":335,"watchers":3430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/5726"},"html":{"href":"https://github.com/apache/flink/pull/5726"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/5726"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/5726/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/5726/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/5726/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/c984370228e6d6960eb521f76c849973c3ced2ee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tillrohrmann"}}