{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/180097161","pull_request_review_id":110457617,"id":180097161,"diff_hunk":"@@ -32,8 +32,8 @@ public KafkaSetOperator(Vertx vertx, KubernetesClient client) {\n     protected Future<ReconcileResult<Boolean>> internalPatch(String namespace, String name, StatefulSet current, StatefulSet desired) {\n         StatefulSetDiff diff = new StatefulSetDiff(current, desired);\n         if (diff.changesVolumeClaimTemplates()) {\n-            log.warn(\"Ignoring change to volumeClaim\");\n-            desired.getSpec().setVolumeClaimTemplates(current.getSpec().getVolumeClaimTemplates());\n+            log.warn(\"Changing storage type or size is not possible.\");","path":"cluster-controller/src/main/java/io/strimzi/controller/cluster/operator/resource/KafkaSetOperator.java","position":6,"original_position":6,"commit_id":"a4a49fcb40086a7254fa2a2d24b0251931017e76","original_commit_id":"7bce797a95ebea07a072761ea4bf37da31a54672","user":{"login":"tombentley","id":879487,"avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"body":"I wonder if we should store the storage configs as annotations on the cluster CM, rather that trusting the state of the SS. That would mean it was more resilient to the SS being changed or deleted directly by the user, and it would be available to `fromConfigMap()` to compute the desired state right at the start of reconciliation. This is also a solution for #348.\r\n","created_at":"2018-04-09T13:40:34Z","updated_at":"2018-04-09T13:40:35Z","html_url":"https://github.com/strimzi/strimzi/pull/367#discussion_r180097161","pull_request_url":"https://api.github.com/repos/strimzi/strimzi/pulls/367","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/180097161"},"html":{"href":"https://github.com/strimzi/strimzi/pull/367#discussion_r180097161"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/367"}},"in_reply_to_id":180025886},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/367","id":180128718,"html_url":"https://github.com/strimzi/strimzi/pull/367","diff_url":"https://github.com/strimzi/strimzi/pull/367.diff","patch_url":"https://github.com/strimzi/strimzi/pull/367.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi/issues/367","number":367,"state":"open","locked":false,"title":"Changes to storage need to be reverted also in Volumes","user":{"login":"scholzj","id":5658439,"avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\n- Bugfix\r\n- ~~Enhancement / new feature~~\r\n- ~~Refactoring~~\r\n\r\n### Description\r\n\r\nWhen changing between ephemeral and persistent storage of running cluster, it is not sufficient to just revert the PersistentVolumeClaim change. Also the Volumes list has to be patched. Otherwise a rolling update will still be triggered and the Cluster will get into strange state with two volumes using the same name (Volume and PVC).","created_at":"2018-04-07T22:42:10Z","updated_at":"2018-04-09T13:40:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55047bb30be8171a02882dad27e9ed7a6672da1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strimzi/strimzi/pulls/367/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi/pulls/367/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi/issues/367/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/a4a49fcb40086a7254fa2a2d24b0251931017e76","head":{"label":"strimzi:revert-storage-changes","ref":"revert-storage-changes","sha":"a4a49fcb40086a7254fa2a2d24b0251931017e76","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Kafka as a Service running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-04-09T08:32:43Z","pushed_at":"2018-04-09T11:21:40Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"http://strimzi.io/","size":2236,"stargazers_count":143,"watchers_count":143,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":68,"watchers":143,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"dc7aca9e9423002a2b72bda4634eb5b2fbf6c19c","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Kafka as a Service running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-04-09T08:32:43Z","pushed_at":"2018-04-09T11:21:40Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"http://strimzi.io/","size":2236,"stargazers_count":143,"watchers_count":143,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":68,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/367"},"html":{"href":"https://github.com/strimzi/strimzi/pull/367"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/367"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi/statuses/a4a49fcb40086a7254fa2a2d24b0251931017e76"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tombentley"}}