{"action":"created","comment":{"url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/comments/172404139","pull_request_review_id":101413226,"id":172404139,"diff_hunk":"@@ -16,12 +16,12 @@\n \n from django.conf.urls import url, include\n from django.contrib import admin\n-from django.contrib.auth import views as auth_views\n+\n+\n urlpatterns = [\n     url(r'^admin/', admin.site.urls),\n-    url(r'^login/$', auth_views.login , name='login'),\n+    url(r'^accounts/', include('accounts.urls')),","path":"webapp/geek_text/urls.py","position":10,"original_position":10,"commit_id":"119310ec23ef02858b9e727ff7ac7c02da36abbc","original_commit_id":"119310ec23ef02858b9e727ff7ac7c02da36abbc","user":{"login":"loksonarius","id":7764106,"avatar_url":"https://avatars1.githubusercontent.com/u/7764106?v=4","gravatar_id":"","url":"https://api.github.com/users/loksonarius","html_url":"https://github.com/loksonarius","followers_url":"https://api.github.com/users/loksonarius/followers","following_url":"https://api.github.com/users/loksonarius/following{/other_user}","gists_url":"https://api.github.com/users/loksonarius/gists{/gist_id}","starred_url":"https://api.github.com/users/loksonarius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loksonarius/subscriptions","organizations_url":"https://api.github.com/users/loksonarius/orgs","repos_url":"https://api.github.com/users/loksonarius/repos","events_url":"https://api.github.com/users/loksonarius/events{/privacy}","received_events_url":"https://api.github.com/users/loksonarius/received_events","type":"User","site_admin":false},"body":"Why are we creating an accounts app for this functionality?","created_at":"2018-03-06T04:04:21Z","updated_at":"2018-03-06T04:05:12Z","html_url":"https://github.com/cen4010/geek-text-webapp/pull/21#discussion_r172404139","pull_request_url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/comments/172404139"},"html":{"href":"https://github.com/cen4010/geek-text-webapp/pull/21#discussion_r172404139"},"pull_request":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21","id":173037371,"html_url":"https://github.com/cen4010/geek-text-webapp/pull/21","diff_url":"https://github.com/cen4010/geek-text-webapp/pull/21.diff","patch_url":"https://github.com/cen4010/geek-text-webapp/pull/21.patch","issue_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/21","number":21,"state":"open","locked":false,"title":"Fixed the Login View","user":{"login":"codeTony22","id":23109068,"avatar_url":"https://avatars3.githubusercontent.com/u/23109068?v=4","gravatar_id":"","url":"https://api.github.com/users/codeTony22","html_url":"https://github.com/codeTony22","followers_url":"https://api.github.com/users/codeTony22/followers","following_url":"https://api.github.com/users/codeTony22/following{/other_user}","gists_url":"https://api.github.com/users/codeTony22/gists{/gist_id}","starred_url":"https://api.github.com/users/codeTony22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeTony22/subscriptions","organizations_url":"https://api.github.com/users/codeTony22/orgs","repos_url":"https://api.github.com/users/codeTony22/repos","events_url":"https://api.github.com/users/codeTony22/events{/privacy}","received_events_url":"https://api.github.com/users/codeTony22/received_events","type":"User","site_admin":false},"body":"I created an accounts app to self contain all the features that have to do with accounts and authorizations. Also, note I changed to the class Login View, instead of the login function base view.","created_at":"2018-03-06T01:52:40Z","updated_at":"2018-03-06T04:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a41e483795b773aff269c88d2554151417597fd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fhern077","id":22156241,"avatar_url":"https://avatars3.githubusercontent.com/u/22156241?v=4","gravatar_id":"","url":"https://api.github.com/users/fhern077","html_url":"https://github.com/fhern077","followers_url":"https://api.github.com/users/fhern077/followers","following_url":"https://api.github.com/users/fhern077/following{/other_user}","gists_url":"https://api.github.com/users/fhern077/gists{/gist_id}","starred_url":"https://api.github.com/users/fhern077/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhern077/subscriptions","organizations_url":"https://api.github.com/users/fhern077/orgs","repos_url":"https://api.github.com/users/fhern077/repos","events_url":"https://api.github.com/users/fhern077/events{/privacy}","received_events_url":"https://api.github.com/users/fhern077/received_events","type":"User","site_admin":false},{"login":"FreakoNico","id":26678718,"avatar_url":"https://avatars1.githubusercontent.com/u/26678718?v=4","gravatar_id":"","url":"https://api.github.com/users/FreakoNico","html_url":"https://github.com/FreakoNico","followers_url":"https://api.github.com/users/FreakoNico/followers","following_url":"https://api.github.com/users/FreakoNico/following{/other_user}","gists_url":"https://api.github.com/users/FreakoNico/gists{/gist_id}","starred_url":"https://api.github.com/users/FreakoNico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreakoNico/subscriptions","organizations_url":"https://api.github.com/users/FreakoNico/orgs","repos_url":"https://api.github.com/users/FreakoNico/repos","events_url":"https://api.github.com/users/FreakoNico/events{/privacy}","received_events_url":"https://api.github.com/users/FreakoNico/received_events","type":"User","site_admin":false},{"login":"ogonz110","id":35462333,"avatar_url":"https://avatars0.githubusercontent.com/u/35462333?v=4","gravatar_id":"","url":"https://api.github.com/users/ogonz110","html_url":"https://github.com/ogonz110","followers_url":"https://api.github.com/users/ogonz110/followers","following_url":"https://api.github.com/users/ogonz110/following{/other_user}","gists_url":"https://api.github.com/users/ogonz110/gists{/gist_id}","starred_url":"https://api.github.com/users/ogonz110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogonz110/subscriptions","organizations_url":"https://api.github.com/users/ogonz110/orgs","repos_url":"https://api.github.com/users/ogonz110/repos","events_url":"https://api.github.com/users/ogonz110/events{/privacy}","received_events_url":"https://api.github.com/users/ogonz110/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21/commits","review_comments_url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21/comments","review_comment_url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/21/comments","statuses_url":"https://api.github.com/repos/cen4010/geek-text-webapp/statuses/119310ec23ef02858b9e727ff7ac7c02da36abbc","head":{"label":"cen4010:feature/login","ref":"feature/login","sha":"119310ec23ef02858b9e727ff7ac7c02da36abbc","user":{"login":"cen4010","id":35458229,"avatar_url":"https://avatars1.githubusercontent.com/u/35458229?v=4","gravatar_id":"","url":"https://api.github.com/users/cen4010","html_url":"https://github.com/cen4010","followers_url":"https://api.github.com/users/cen4010/followers","following_url":"https://api.github.com/users/cen4010/following{/other_user}","gists_url":"https://api.github.com/users/cen4010/gists{/gist_id}","starred_url":"https://api.github.com/users/cen4010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cen4010/subscriptions","organizations_url":"https://api.github.com/users/cen4010/orgs","repos_url":"https://api.github.com/users/cen4010/repos","events_url":"https://api.github.com/users/cen4010/events{/privacy}","received_events_url":"https://api.github.com/users/cen4010/received_events","type":"Organization","site_admin":false},"repo":{"id":120383291,"name":"geek-text-webapp","full_name":"cen4010/geek-text-webapp","owner":{"login":"cen4010","id":35458229,"avatar_url":"https://avatars1.githubusercontent.com/u/35458229?v=4","gravatar_id":"","url":"https://api.github.com/users/cen4010","html_url":"https://github.com/cen4010","followers_url":"https://api.github.com/users/cen4010/followers","following_url":"https://api.github.com/users/cen4010/following{/other_user}","gists_url":"https://api.github.com/users/cen4010/gists{/gist_id}","starred_url":"https://api.github.com/users/cen4010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cen4010/subscriptions","organizations_url":"https://api.github.com/users/cen4010/orgs","repos_url":"https://api.github.com/users/cen4010/repos","events_url":"https://api.github.com/users/cen4010/events{/privacy}","received_events_url":"https://api.github.com/users/cen4010/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cen4010/geek-text-webapp","description":"The actual webapp for the Geek Text site","fork":false,"url":"https://api.github.com/repos/cen4010/geek-text-webapp","forks_url":"https://api.github.com/repos/cen4010/geek-text-webapp/forks","keys_url":"https://api.github.com/repos/cen4010/geek-text-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cen4010/geek-text-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cen4010/geek-text-webapp/teams","hooks_url":"https://api.github.com/repos/cen4010/geek-text-webapp/hooks","issue_events_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/cen4010/geek-text-webapp/events","assignees_url":"https://api.github.com/repos/cen4010/geek-text-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/cen4010/geek-text-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/cen4010/geek-text-webapp/tags","blobs_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cen4010/geek-text-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/cen4010/geek-text-webapp/languages","stargazers_url":"https://api.github.com/repos/cen4010/geek-text-webapp/stargazers","contributors_url":"https://api.github.com/repos/cen4010/geek-text-webapp/contributors","subscribers_url":"https://api.github.com/repos/cen4010/geek-text-webapp/subscribers","subscription_url":"https://api.github.com/repos/cen4010/geek-text-webapp/subscription","commits_url":"https://api.github.com/repos/cen4010/geek-text-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cen4010/geek-text-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cen4010/geek-text-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/cen4010/geek-text-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cen4010/geek-text-webapp/merges","archive_url":"https://api.github.com/repos/cen4010/geek-text-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cen4010/geek-text-webapp/downloads","issues_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/cen4010/geek-text-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/cen4010/geek-text-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cen4010/geek-text-webapp/labels{/name}","releases_url":"https://api.github.com/repos/cen4010/geek-text-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/cen4010/geek-text-webapp/deployments","created_at":"2018-02-06T01:12:27Z","updated_at":"2018-02-15T23:53:43Z","pushed_at":"2018-03-06T02:05:01Z","git_url":"git://github.com/cen4010/geek-text-webapp.git","ssh_url":"git@github.com:cen4010/geek-text-webapp.git","clone_url":"https://github.com/cen4010/geek-text-webapp.git","svn_url":"https://github.com/cen4010/geek-text-webapp","homepage":null,"size":1017,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"cen4010:master","ref":"master","sha":"afff077f262171c7eb03311859efbf198d0f6e3e","user":{"login":"cen4010","id":35458229,"avatar_url":"https://avatars1.githubusercontent.com/u/35458229?v=4","gravatar_id":"","url":"https://api.github.com/users/cen4010","html_url":"https://github.com/cen4010","followers_url":"https://api.github.com/users/cen4010/followers","following_url":"https://api.github.com/users/cen4010/following{/other_user}","gists_url":"https://api.github.com/users/cen4010/gists{/gist_id}","starred_url":"https://api.github.com/users/cen4010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cen4010/subscriptions","organizations_url":"https://api.github.com/users/cen4010/orgs","repos_url":"https://api.github.com/users/cen4010/repos","events_url":"https://api.github.com/users/cen4010/events{/privacy}","received_events_url":"https://api.github.com/users/cen4010/received_events","type":"Organization","site_admin":false},"repo":{"id":120383291,"name":"geek-text-webapp","full_name":"cen4010/geek-text-webapp","owner":{"login":"cen4010","id":35458229,"avatar_url":"https://avatars1.githubusercontent.com/u/35458229?v=4","gravatar_id":"","url":"https://api.github.com/users/cen4010","html_url":"https://github.com/cen4010","followers_url":"https://api.github.com/users/cen4010/followers","following_url":"https://api.github.com/users/cen4010/following{/other_user}","gists_url":"https://api.github.com/users/cen4010/gists{/gist_id}","starred_url":"https://api.github.com/users/cen4010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cen4010/subscriptions","organizations_url":"https://api.github.com/users/cen4010/orgs","repos_url":"https://api.github.com/users/cen4010/repos","events_url":"https://api.github.com/users/cen4010/events{/privacy}","received_events_url":"https://api.github.com/users/cen4010/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cen4010/geek-text-webapp","description":"The actual webapp for the Geek Text site","fork":false,"url":"https://api.github.com/repos/cen4010/geek-text-webapp","forks_url":"https://api.github.com/repos/cen4010/geek-text-webapp/forks","keys_url":"https://api.github.com/repos/cen4010/geek-text-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cen4010/geek-text-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cen4010/geek-text-webapp/teams","hooks_url":"https://api.github.com/repos/cen4010/geek-text-webapp/hooks","issue_events_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/cen4010/geek-text-webapp/events","assignees_url":"https://api.github.com/repos/cen4010/geek-text-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/cen4010/geek-text-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/cen4010/geek-text-webapp/tags","blobs_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cen4010/geek-text-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/cen4010/geek-text-webapp/languages","stargazers_url":"https://api.github.com/repos/cen4010/geek-text-webapp/stargazers","contributors_url":"https://api.github.com/repos/cen4010/geek-text-webapp/contributors","subscribers_url":"https://api.github.com/repos/cen4010/geek-text-webapp/subscribers","subscription_url":"https://api.github.com/repos/cen4010/geek-text-webapp/subscription","commits_url":"https://api.github.com/repos/cen4010/geek-text-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cen4010/geek-text-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cen4010/geek-text-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cen4010/geek-text-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/cen4010/geek-text-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cen4010/geek-text-webapp/merges","archive_url":"https://api.github.com/repos/cen4010/geek-text-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cen4010/geek-text-webapp/downloads","issues_url":"https://api.github.com/repos/cen4010/geek-text-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/cen4010/geek-text-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/cen4010/geek-text-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cen4010/geek-text-webapp/labels{/name}","releases_url":"https://api.github.com/repos/cen4010/geek-text-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/cen4010/geek-text-webapp/deployments","created_at":"2018-02-06T01:12:27Z","updated_at":"2018-02-15T23:53:43Z","pushed_at":"2018-03-06T02:05:01Z","git_url":"git://github.com/cen4010/geek-text-webapp.git","ssh_url":"git@github.com:cen4010/geek-text-webapp.git","clone_url":"https://github.com/cen4010/geek-text-webapp.git","svn_url":"https://github.com/cen4010/geek-text-webapp","homepage":null,"size":1017,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21"},"html":{"href":"https://github.com/cen4010/geek-text-webapp/pull/21"},"issue":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/21"},"comments":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/cen4010/geek-text-webapp/statuses/119310ec23ef02858b9e727ff7ac7c02da36abbc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"loksonarius"}}