{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/189423096","pull_request_review_id":121607063,"id":189423096,"diff_hunk":"@@ -267,6 +267,8 @@ public TableDataMap getDataMap(CarbonTable table, DataMapSchema dataMapSchema) {\n           }\n         }\n       }\n+    } else {\n+      dataMap.clear();","path":"core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java","position":5,"original_position":5,"commit_id":"3bcd4a03e09f8c90464b9f25dddc331c2c457a50","original_commit_id":"3bcd4a03e09f8c90464b9f25dddc331c2c457a50","user":{"login":"ravipesala","id":8134086,"avatar_url":"https://avatars2.githubusercontent.com/u/8134086?v=4","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"body":"I think it loses the purpose of cache if you clear for every retrieval. clear should be called only flush the cache. why do you need to flush cache for every call?","created_at":"2018-05-19T02:59:28Z","updated_at":"2018-05-19T02:59:28Z","html_url":"https://github.com/apache/carbondata/pull/2318#discussion_r189423096","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2318","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/189423096"},"html":{"href":"https://github.com/apache/carbondata/pull/2318#discussion_r189423096"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2318"}},"in_reply_to_id":189421068},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2318","id":188945873,"html_url":"https://github.com/apache/carbondata/pull/2318","diff_url":"https://github.com/apache/carbondata/pull/2318.diff","patch_url":"https://github.com/apache/carbondata/pull/2318.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2318","number":2318,"state":"open","locked":false,"title":" [CARBONDATA-2491] Fix the error when reader read twice with SDK carbonReader","user":{"login":"xubo245","id":8759816,"avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"body":"    [CARBONDATA-2491] Fix the error when reader read twice with SDK carbonReader\r\n1.Fix the error out of bound when reader read twice with SDK carbonReader\r\n2.Fix the java.lang.NegativeArraySizeException\r\n3.Add timestamp and  bad record test case\r\nThis PR dependency on https://github.com/apache/carbondata/pull/2246\r\n\r\nHow to fix the error:\r\nCarbon throw the exception because the fileName is \"\" in org.apache.carbondata.core.util.path.CarbonTablePath.DataFileUtil#getTaskNo, I find the filePath is \"\" in prunedBlocklets of org.apache.carbondata.hadoop.api.CarbonInputFormat#getDataBlocksOfSegment. So it should the data map issue.\r\nIt'S UNSAFE issue\r\n \r\nCarbon throw the second exception  because the length less than 0 in org.apache.carbondata.core.indexstore.row.UnsafeDataMapRow#convertToSafeRow\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [x] Any interfaces changed?\r\n No\r\n - [x] Any backward compatibility impacted?\r\n No\r\n - [x] Document update required?\r\nNo\r\n - [x] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n       No\r\n - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\nNo","created_at":"2018-05-18T07:45:29Z","updated_at":"2018-05-19T02:59:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9140e8e3f88cec94fadfccd22a2f2c254422edd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2318/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2318/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2318/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/3bcd4a03e09f8c90464b9f25dddc331c2c457a50","head":{"label":"xubo245:CARBONDATA-2491-OutOfBoundAndBadRecord","ref":"CARBONDATA-2491-OutOfBoundAndBadRecord","sha":"3bcd4a03e09f8c90464b9f25dddc331c2c457a50","user":{"login":"xubo245","id":8759816,"avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"repo":{"id":99896462,"name":"carbondata","full_name":"xubo245/carbondata","owner":{"login":"xubo245","id":8759816,"avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xubo245/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/xubo245/carbondata","forks_url":"https://api.github.com/repos/xubo245/carbondata/forks","keys_url":"https://api.github.com/repos/xubo245/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xubo245/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xubo245/carbondata/teams","hooks_url":"https://api.github.com/repos/xubo245/carbondata/hooks","issue_events_url":"https://api.github.com/repos/xubo245/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/xubo245/carbondata/events","assignees_url":"https://api.github.com/repos/xubo245/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/xubo245/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/xubo245/carbondata/tags","blobs_url":"https://api.github.com/repos/xubo245/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xubo245/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xubo245/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/xubo245/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xubo245/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/xubo245/carbondata/languages","stargazers_url":"https://api.github.com/repos/xubo245/carbondata/stargazers","contributors_url":"https://api.github.com/repos/xubo245/carbondata/contributors","subscribers_url":"https://api.github.com/repos/xubo245/carbondata/subscribers","subscription_url":"https://api.github.com/repos/xubo245/carbondata/subscription","commits_url":"https://api.github.com/repos/xubo245/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/xubo245/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/xubo245/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/xubo245/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/xubo245/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/xubo245/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xubo245/carbondata/merges","archive_url":"https://api.github.com/repos/xubo245/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xubo245/carbondata/downloads","issues_url":"https://api.github.com/repos/xubo245/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/xubo245/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/xubo245/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/xubo245/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xubo245/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/xubo245/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/xubo245/carbondata/deployments","created_at":"2017-08-10T07:50:07Z","updated_at":"2018-04-18T12:40:01Z","pushed_at":"2018-05-18T16:03:51Z","git_url":"git://github.com/xubo245/carbondata.git","ssh_url":"git@github.com:xubo245/carbondata.git","clone_url":"https://github.com/xubo245/carbondata.git","svn_url":"https://github.com/xubo245/carbondata","homepage":"","size":58127,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b88c097075b2ef859d25db27da08435d66a814a2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-05-19T02:44:51Z","pushed_at":"2018-05-19T02:44:36Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":58194,"stargazers_count":663,"watchers_count":663,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":416,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":416,"open_issues":98,"watchers":663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2318"},"html":{"href":"https://github.com/apache/carbondata/pull/2318"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2318"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2318/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2318/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2318/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/3bcd4a03e09f8c90464b9f25dddc331c2c457a50"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ravipesala"}}