{"action":"closed","number":18146,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18146","id":228120618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTIwNjE4","html_url":"https://github.com/home-assistant/home-assistant/pull/18146","diff_url":"https://github.com/home-assistant/home-assistant/pull/18146.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/18146.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18146","number":18146,"state":"closed","locked":false,"title":"Add new sun triggers and conditions","user":{"login":"emontnemery","id":14281572,"node_id":"MDQ6VXNlcjE0MjgxNTcy","avatar_url":"https://avatars1.githubusercontent.com/u/14281572?v=4","gravatar_id":"","url":"https://api.github.com/users/emontnemery","html_url":"https://github.com/emontnemery","followers_url":"https://api.github.com/users/emontnemery/followers","following_url":"https://api.github.com/users/emontnemery/following{/other_user}","gists_url":"https://api.github.com/users/emontnemery/gists{/gist_id}","starred_url":"https://api.github.com/users/emontnemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emontnemery/subscriptions","organizations_url":"https://api.github.com/users/emontnemery/orgs","repos_url":"https://api.github.com/users/emontnemery/repos","events_url":"https://api.github.com/users/emontnemery/events{/privacy}","received_events_url":"https://api.github.com/users/emontnemery/received_events","type":"User","site_admin":false},"body":"## Description:\r\nAdd new sun triggers and conditions, This is Step1 proposed in home-assistant/architecture#98\r\n\r\n**Add triggers:**\r\n- `astronomical_dawn`: sun rising above -18° solar elevation\r\n- `nautical_dawn`: sun rising above -12° solar elevation\r\n- `civil_dawn`: sun rising above -6°  solar elevation\r\n- `civil_dusk`: sun setting below -6°  solar elevation\r\n- `nautical_dusk`: sun setting below -12° solar elevation\r\n- `astronomical_dusk`: sun setting below -18° solar elevation\r\n\r\n**Add conditions:**\r\n- `from`: any sun trigger + `until`: any sun trigger, e.g.:\r\n   ```\r\n   from: 'civil_dusk'\r\n   until: 'sunrise'\r\n   ```\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io):** home-assistant/home-assistant.io#TODO\r\n\r\n## Example entry for `configuration.yaml`:\r\n```yaml\r\nautomation:\r\n  trigger:\r\n    platform: sun\r\n    event: nautical_dawn\r\n    # Optional time offset. This example is 45 minutes earlier.\r\n    offset: '-00:45:00'\r\n```\r\n\r\n```yaml\r\n# Valid entire day, from nautical dawn until nautical dusk\r\ncondition:\r\n  condition: sun\r\n  from: 'nautical_dawn'\r\n  until: 'nautical_dusk'\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Tests have been added to verify that the new code works.\r\n","created_at":"2018-11-03T14:15:44Z","updated_at":"2018-12-14T18:05:51Z","closed_at":"2018-12-14T18:05:51Z","merged_at":null,"merge_commit_sha":"ae8fc69bb3a409a33ed983aba6837b5442b7450b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Core","id":2410391,"node_id":"MDQ6VGVhbTI0MTAzOTE=","slug":"core","description":"Developers with knowledge of the Home Assistant core","privacy":"closed","url":"https://api.github.com/teams/2410391","members_url":"https://api.github.com/teams/2410391/members{/member}","repositories_url":"https://api.github.com/teams/2410391/repos","permission":"pull"}],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":532174777,"node_id":"MDU6TGFiZWw1MzIxNzQ3Nzc=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20sun","name":"component: sun","color":"ededed","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":805697812,"node_id":"MDU6TGFiZWw4MDU2OTc4MTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/docs-missing","name":"docs-missing","color":"83f26f","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":1114847386,"node_id":"MDU6TGFiZWwxMTE0ODQ3Mzg2","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20automation.sun","name":"platform: automation.sun","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18146/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18146/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18146/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/b6b345d97e9034a635e0ca427beb0ae2058fe4eb","head":{"label":"emontnemery:sun_add_triggers_conditions","ref":"sun_add_triggers_conditions","sha":"b6b345d97e9034a635e0ca427beb0ae2058fe4eb","user":{"login":"emontnemery","id":14281572,"node_id":"MDQ6VXNlcjE0MjgxNTcy","avatar_url":"https://avatars1.githubusercontent.com/u/14281572?v=4","gravatar_id":"","url":"https://api.github.com/users/emontnemery","html_url":"https://github.com/emontnemery","followers_url":"https://api.github.com/users/emontnemery/followers","following_url":"https://api.github.com/users/emontnemery/following{/other_user}","gists_url":"https://api.github.com/users/emontnemery/gists{/gist_id}","starred_url":"https://api.github.com/users/emontnemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emontnemery/subscriptions","organizations_url":"https://api.github.com/users/emontnemery/orgs","repos_url":"https://api.github.com/users/emontnemery/repos","events_url":"https://api.github.com/users/emontnemery/events{/privacy}","received_events_url":"https://api.github.com/users/emontnemery/received_events","type":"User","site_admin":false},"repo":{"id":148376885,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzNzY4ODU=","name":"home-assistant","full_name":"emontnemery/home-assistant","private":false,"owner":{"login":"emontnemery","id":14281572,"node_id":"MDQ6VXNlcjE0MjgxNTcy","avatar_url":"https://avatars1.githubusercontent.com/u/14281572?v=4","gravatar_id":"","url":"https://api.github.com/users/emontnemery","html_url":"https://github.com/emontnemery","followers_url":"https://api.github.com/users/emontnemery/followers","following_url":"https://api.github.com/users/emontnemery/following{/other_user}","gists_url":"https://api.github.com/users/emontnemery/gists{/gist_id}","starred_url":"https://api.github.com/users/emontnemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emontnemery/subscriptions","organizations_url":"https://api.github.com/users/emontnemery/orgs","repos_url":"https://api.github.com/users/emontnemery/repos","events_url":"https://api.github.com/users/emontnemery/events{/privacy}","received_events_url":"https://api.github.com/users/emontnemery/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emontnemery/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":true,"url":"https://api.github.com/repos/emontnemery/home-assistant","forks_url":"https://api.github.com/repos/emontnemery/home-assistant/forks","keys_url":"https://api.github.com/repos/emontnemery/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emontnemery/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emontnemery/home-assistant/teams","hooks_url":"https://api.github.com/repos/emontnemery/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/emontnemery/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/emontnemery/home-assistant/events","assignees_url":"https://api.github.com/repos/emontnemery/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/emontnemery/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/emontnemery/home-assistant/tags","blobs_url":"https://api.github.com/repos/emontnemery/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emontnemery/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emontnemery/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/emontnemery/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emontnemery/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/emontnemery/home-assistant/languages","stargazers_url":"https://api.github.com/repos/emontnemery/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/emontnemery/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/emontnemery/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/emontnemery/home-assistant/subscription","commits_url":"https://api.github.com/repos/emontnemery/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/emontnemery/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/emontnemery/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/emontnemery/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/emontnemery/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/emontnemery/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emontnemery/home-assistant/merges","archive_url":"https://api.github.com/repos/emontnemery/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emontnemery/home-assistant/downloads","issues_url":"https://api.github.com/repos/emontnemery/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/emontnemery/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/emontnemery/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/emontnemery/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emontnemery/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/emontnemery/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/emontnemery/home-assistant/deployments","created_at":"2018-09-11T20:34:56Z","updated_at":"2018-11-25T15:30:53Z","pushed_at":"2018-12-12T15:49:25Z","git_url":"git://github.com/emontnemery/home-assistant.git","ssh_url":"git@github.com:emontnemery/home-assistant.git","clone_url":"https://github.com/emontnemery/home-assistant.git","svn_url":"https://github.com/emontnemery/home-assistant","homepage":"https://home-assistant.io","size":95319,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"0009e7bde9b48b565c8496e1a7f57732a35c50ec","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-12-14T16:59:21Z","pushed_at":"2018-12-14T17:37:35Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":95471,"stargazers_count":19259,"watchers_count":19259,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5653,"mirror_url":null,"archived":false,"open_issues_count":897,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5653,"open_issues":897,"watchers":19259,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18146"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/18146"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/18146"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/18146/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18146/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18146/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/b6b345d97e9034a635e0ca427beb0ae2058fe4eb"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":466,"deletions":132,"changed_files":8}}
{"actor":{"display_login":"emontnemery"}}