{"action":"created","issue":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2319","repository_url":"https://api.github.com/repos/Minecolonies/minecolonies","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2319/labels{/name}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2319/comments","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2319/events","html_url":"https://github.com/Minecolonies/minecolonies/pull/2319","id":305927909,"number":2319,"title":"Hotfix/cnb","user":{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-16T13:29:15Z","updated_at":"2018-03-16T13:35:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/2319","html_url":"https://github.com/Minecolonies/minecolonies/pull/2319","diff_url":"https://github.com/Minecolonies/minecolonies/pull/2319.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/2319.patch"},"body":"\r\n\r\n# Changes proposed in this pull request:\r\n- Fixes NPE with chisel and bits\r\n- Fixes bug where too many items get sent to the worker.\r\n\r\nReview please\r\n"},"comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments/373714714","html_url":"https://github.com/Minecolonies/minecolonies/pull/2319#issuecomment-373714714","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/2319","id":373714714,"user":{"login":"BuildTeamLinter","id":30551110,"avatar_url":"https://avatars0.githubusercontent.com/u/30551110?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildTeamLinter","html_url":"https://github.com/BuildTeamLinter","followers_url":"https://api.github.com/users/BuildTeamLinter/followers","following_url":"https://api.github.com/users/BuildTeamLinter/following{/other_user}","gists_url":"https://api.github.com/users/BuildTeamLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildTeamLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildTeamLinter/subscriptions","organizations_url":"https://api.github.com/users/BuildTeamLinter/orgs","repos_url":"https://api.github.com/users/BuildTeamLinter/repos","events_url":"https://api.github.com/users/BuildTeamLinter/events{/privacy}","received_events_url":"https://api.github.com/users/BuildTeamLinter/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T13:35:25Z","updated_at":"2018-03-16T13:35:25Z","author_association":"NONE","body":"SonarQube analysis reported 61 issues\n* ![MAJOR][MAJOR] 58 major\n* ![MINOR][MINOR] 3 minor\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [blocks#](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/blocks#): Add a 'package-info.java' file to document the 'blocks' package [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1228)\n1. ![MAJOR][MAJOR] [gui#](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/gui#): Add a 'package-info.java' file to document the 'gui' package [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1228)\n1. ![MAJOR][MAJOR] [WindowCitizen.java#L364](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/gui/WindowCitizen.java#L364): Refactor this method to reduce its Cognitive Complexity from 23 to the 20 allowed. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS3776)\n1. ![MAJOR][MAJOR] [WindowCitizen.java#L373](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/gui/WindowCitizen.java#L373): Reduce this anonymous class number of lines from 65 to at most 40, or make it a named class. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1188)\n1. ![MAJOR][MAJOR] [WindowCitizen.java#L395](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/gui/WindowCitizen.java#L395): Assign this magic number 10 to a well-named constant, and use the constant instead. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS109)\n1. ![MAJOR][MAJOR] [WindowCitizen.java#L396](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/gui/WindowCitizen.java#L396): Assign this magic number 10 to a well-named constant, and use the constant instead. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS109)\n1. ![MAJOR][MAJOR] [WindowCitizen.java#L599](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/gui/WindowCitizen.java#L599): Split this 183 characters long line (which is greater than 180 authorized). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS00103)\n1. ![MAJOR][MAJOR] [render#](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/client/render#): Add a 'package-info.java' file to document the 'render' package [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1228)\n1. ![MAJOR][MAJOR] [colony#](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/colony#): Add a 'package-info.java' file to document the 'colony' package [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1228)\n1. ![MAJOR][MAJOR] [buildings#](https://github.com/Minecolonies/minecolonies/blob/465501a03921dd64ff6f0e162b9194ffa9118e6f/src/main/java/com/minecolonies/coremod/colony/buildings#): Add a 'package-info.java' file to document the 'buildings' package [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1228)\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"BuildTeamLinter"}}