{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/171160834","pull_request_review_id":99963868,"id":171160834,"diff_hunk":"@@ -67,7 +67,7 @@ struct signv {\n   { \"PIPE\",     SIGPIPE },      /* 13 */\n   { \"ALRM\",     SIGALRM },      /* 14 */\n   { \"TERM\",     SIGTERM },      /* 15 */\n-#ifndef _MIPS_ARCH\n+#if !defined(__alpha__) && !defined(__mips__) && !defined(__sparc__)","path":"src/common/cockpitunixsignal.c","position":5,"original_position":5,"commit_id":"5939d96788032f73c00cded18f0f25a3ac958986","original_commit_id":"5939d96788032f73c00cded18f0f25a3ac958986","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"body":"Actually, I wonder if this could simply use `#ifdef SIGSTKFLT` instead of hardcoding the architectures?","created_at":"2018-02-28T07:29:48Z","updated_at":"2018-02-28T07:29:54Z","html_url":"https://github.com/cockpit-project/cockpit/pull/8728#discussion_r171160834","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/171160834"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/8728#discussion_r171160834"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728","id":171828563,"html_url":"https://github.com/cockpit-project/cockpit/pull/8728","diff_url":"https://github.com/cockpit-project/cockpit/pull/8728.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/8728.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/8728","number":8728,"state":"open","locked":false,"title":"common: Don't use unsupported SIGSTKFLT on alpha and sparc","user":{"login":"glaubitz","id":1647645,"avatar_url":"https://avatars1.githubusercontent.com/u/1647645?v=4","gravatar_id":"","url":"https://api.github.com/users/glaubitz","html_url":"https://github.com/glaubitz","followers_url":"https://api.github.com/users/glaubitz/followers","following_url":"https://api.github.com/users/glaubitz/following{/other_user}","gists_url":"https://api.github.com/users/glaubitz/gists{/gist_id}","starred_url":"https://api.github.com/users/glaubitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glaubitz/subscriptions","organizations_url":"https://api.github.com/users/glaubitz/orgs","repos_url":"https://api.github.com/users/glaubitz/repos","events_url":"https://api.github.com/users/glaubitz/events{/privacy}","received_events_url":"https://api.github.com/users/glaubitz/received_events","type":"User","site_admin":false},"body":"Currently, cockpit fails to build from source on alpha and sparc* in Debian as SIGSTKFLT is not defined on these architectures:\r\n\r\n```bash\r\ngcc -DHAVE_CONFIG_H -I.  -I. -I./src -I. -I./src -DSRCDIR=\\\"/<<PKGBUILDDIR>>\\\" -DBUILDDIR=\\\"/<<PKGBUILDDIR>>\\\" -DDATADIR=\\\"/usr/share\\\" -DPACKAGE_LIBEXEC_DIR=\\\"\"/usr/lib/cockpit\"\\\" -DPACKAGE_SYSCONF_DIR=\\\"\"/etc\"\\\" -DPACKAGE_BIN_DIR=\\\"\"/usr/bin\"\\\" -DPACKAGE_LOCALSTATE_DIR=\\\"\"/var/lib/cockpit\"\\\" -DPACKAGE_LIB_DIR=\\\"\"/usr/lib/sparc64-linux-gnu\"\\\" -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT  -Wdate-time -D_FORTIFY_SOURCE=2 -DG_LOG_DOMAIN=\\\"cockpit-protocol\\\" -pthread -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/sparc64-linux-gnu/glib-2.0/include -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_34 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_34 -pthread -I/usr/include/json-glib-1.0 -I/usr/include/glib-2.0 -I/usr/lib/sparc64-linux-gnu/glib-2.0/include   -Wall           -Werror=strict-prototypes -Werror=missing-prototypes           -Werror=implicit-function-declaration           -Werror=pointer-arith -Werror=init-self           -Werror=format=2           -Werror=return-type           -Werror=missing-include-dirs -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -g -c -o src/common/libcockpit_common_a-cockpitunixsignal.o `test -f 'src/common/cockpitunixsignal.c' || echo './'`src/common/cockpitunixsignal.c\r\nsrc/common/cockpitunixsignal.c:71:17: error: 'SIGSTKFLT' undeclared here (not in a function); did you mean 'SIGSTKSZ'?\r\n   { \"STKFLT\",   SIGSTKFLT },    /* 16 (arm,i386,m68k,ppc) */\r\n                 ^~~~~~~~~\r\n                 SIGSTKSZ\r\nmake[2]: *** [Makefile:4770: src/common/libcockpit_common_a-cockpitunixsignal.o] Error 1\r\nmake[2]: Leaving directory '/<<PKGBUILDDIR>>'\r\nmake[1]: *** [Makefile:2886: all] Error 2\r\nmake[1]: Leaving directory '/<<PKGBUILDDIR>>'\r\ndh_auto_build: make -j1 returned exit code 2\r\nmake: *** [debian/rules:12: build-arch] Error 2\r\n```\r\n\r\nSee: https://buildd.debian.org/status/fetch.php?pkg=cockpit&arch=sparc64&ver=162-1&stamp=1519233181&raw=0\r\n\r\nHence, disable it on these architectures, too. Also, use the more common ```__mips__``` for MIPS targets.","created_at":"2018-02-28T00:58:12Z","updated_at":"2018-02-28T07:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7bcd60a2f84761303c245b6be41ae37ad867aeb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/8728/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/5939d96788032f73c00cded18f0f25a3ac958986","head":{"label":"glaubitz:alpha-sparc","ref":"alpha-sparc","sha":"5939d96788032f73c00cded18f0f25a3ac958986","user":{"login":"glaubitz","id":1647645,"avatar_url":"https://avatars1.githubusercontent.com/u/1647645?v=4","gravatar_id":"","url":"https://api.github.com/users/glaubitz","html_url":"https://github.com/glaubitz","followers_url":"https://api.github.com/users/glaubitz/followers","following_url":"https://api.github.com/users/glaubitz/following{/other_user}","gists_url":"https://api.github.com/users/glaubitz/gists{/gist_id}","starred_url":"https://api.github.com/users/glaubitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glaubitz/subscriptions","organizations_url":"https://api.github.com/users/glaubitz/orgs","repos_url":"https://api.github.com/users/glaubitz/repos","events_url":"https://api.github.com/users/glaubitz/events{/privacy}","received_events_url":"https://api.github.com/users/glaubitz/received_events","type":"User","site_admin":false},"repo":{"id":123207364,"name":"cockpit","full_name":"glaubitz/cockpit","owner":{"login":"glaubitz","id":1647645,"avatar_url":"https://avatars1.githubusercontent.com/u/1647645?v=4","gravatar_id":"","url":"https://api.github.com/users/glaubitz","html_url":"https://github.com/glaubitz","followers_url":"https://api.github.com/users/glaubitz/followers","following_url":"https://api.github.com/users/glaubitz/following{/other_user}","gists_url":"https://api.github.com/users/glaubitz/gists{/gist_id}","starred_url":"https://api.github.com/users/glaubitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glaubitz/subscriptions","organizations_url":"https://api.github.com/users/glaubitz/orgs","repos_url":"https://api.github.com/users/glaubitz/repos","events_url":"https://api.github.com/users/glaubitz/events{/privacy}","received_events_url":"https://api.github.com/users/glaubitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glaubitz/cockpit","description":"There's code a goin' on","fork":true,"url":"https://api.github.com/repos/glaubitz/cockpit","forks_url":"https://api.github.com/repos/glaubitz/cockpit/forks","keys_url":"https://api.github.com/repos/glaubitz/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glaubitz/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glaubitz/cockpit/teams","hooks_url":"https://api.github.com/repos/glaubitz/cockpit/hooks","issue_events_url":"https://api.github.com/repos/glaubitz/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/glaubitz/cockpit/events","assignees_url":"https://api.github.com/repos/glaubitz/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/glaubitz/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/glaubitz/cockpit/tags","blobs_url":"https://api.github.com/repos/glaubitz/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glaubitz/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glaubitz/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/glaubitz/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glaubitz/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/glaubitz/cockpit/languages","stargazers_url":"https://api.github.com/repos/glaubitz/cockpit/stargazers","contributors_url":"https://api.github.com/repos/glaubitz/cockpit/contributors","subscribers_url":"https://api.github.com/repos/glaubitz/cockpit/subscribers","subscription_url":"https://api.github.com/repos/glaubitz/cockpit/subscription","commits_url":"https://api.github.com/repos/glaubitz/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/glaubitz/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/glaubitz/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/glaubitz/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/glaubitz/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/glaubitz/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glaubitz/cockpit/merges","archive_url":"https://api.github.com/repos/glaubitz/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glaubitz/cockpit/downloads","issues_url":"https://api.github.com/repos/glaubitz/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/glaubitz/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/glaubitz/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/glaubitz/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glaubitz/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/glaubitz/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/glaubitz/cockpit/deployments","created_at":"2018-02-28T00:47:56Z","updated_at":"2018-02-28T00:48:02Z","pushed_at":"2018-02-28T00:56:05Z","git_url":"git://github.com/glaubitz/cockpit.git","ssh_url":"git@github.com:glaubitz/cockpit.git","clone_url":"https://github.com/glaubitz/cockpit.git","svn_url":"https://github.com/glaubitz/cockpit","homepage":"http://www.cockpit-project.org/","size":43938,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"1b7bed05a763cb277103c6e62f6186e8ed8560b5","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2018-02-28T06:33:51Z","pushed_at":"2018-02-28T00:58:13Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":43938,"stargazers_count":2983,"watchers_count":2983,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"open_issues_count":551,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":386,"open_issues":551,"watchers":2983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/8728"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/8728"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/8728/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8728/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/5939d96788032f73c00cded18f0f25a3ac958986"}},"author_association":"NONE"}}
{"actor":{"display_login":"martinpitt"}}