{"action":"created","issue":{"url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/issues/3478","repository_url":"https://api.github.com/repos/arendst/Sonoff-Tasmota","labels_url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/issues/3478/labels{/name}","comments_url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/issues/3478/comments","events_url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/issues/3478/events","html_url":"https://github.com/arendst/Sonoff-Tasmota/pull/3478","id":350222488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTI2MjQw","number":3478,"title":"update mcp230xx to allow inverted output","user":{"login":"MadDoct","id":32080323,"node_id":"MDQ6VXNlcjMyMDgwMzIz","avatar_url":"https://avatars3.githubusercontent.com/u/32080323?v=4","gravatar_id":"","url":"https://api.github.com/users/MadDoct","html_url":"https://github.com/MadDoct","followers_url":"https://api.github.com/users/MadDoct/followers","following_url":"https://api.github.com/users/MadDoct/following{/other_user}","gists_url":"https://api.github.com/users/MadDoct/gists{/gist_id}","starred_url":"https://api.github.com/users/MadDoct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadDoct/subscriptions","organizations_url":"https://api.github.com/users/MadDoct/orgs","repos_url":"https://api.github.com/users/MadDoct/repos","events_url":"https://api.github.com/users/MadDoct/events{/privacy}","received_events_url":"https://api.github.com/users/MadDoct/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-13T22:55:37Z","updated_at":"2018-08-14T14:33:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/pulls/3478","html_url":"https://github.com/arendst/Sonoff-Tasmota/pull/3478","diff_url":"https://github.com/arendst/Sonoff-Tasmota/pull/3478.diff","patch_url":"https://github.com/arendst/Sonoff-Tasmota/pull/3478.patch"},"body":"Created pinmode 6 to allow setting inverted output, so it can easily be used with active low relay boards... Also changerd some of the output to make it more readable..."},"comment":{"url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/issues/comments/412893280","html_url":"https://github.com/arendst/Sonoff-Tasmota/pull/3478#issuecomment-412893280","issue_url":"https://api.github.com/repos/arendst/Sonoff-Tasmota/issues/3478","id":412893280,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjg5MzI4MA==","user":{"login":"MadDoct","id":32080323,"node_id":"MDQ6VXNlcjMyMDgwMzIz","avatar_url":"https://avatars3.githubusercontent.com/u/32080323?v=4","gravatar_id":"","url":"https://api.github.com/users/MadDoct","html_url":"https://github.com/MadDoct","followers_url":"https://api.github.com/users/MadDoct/followers","following_url":"https://api.github.com/users/MadDoct/following{/other_user}","gists_url":"https://api.github.com/users/MadDoct/gists{/gist_id}","starred_url":"https://api.github.com/users/MadDoct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadDoct/subscriptions","organizations_url":"https://api.github.com/users/MadDoct/orgs","repos_url":"https://api.github.com/users/MadDoct/repos","events_url":"https://api.github.com/users/MadDoct/events{/privacy}","received_events_url":"https://api.github.com/users/MadDoct/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T14:33:20Z","updated_at":"2018-08-14T14:33:20Z","author_association":"CONTRIBUTOR","body":"Well, unfortunately I had problems with the \"-\" in home assistant, so have\nchanger from using \"-\" to \"_\" in my version of the code.. I'll do a pull\nrequest today and will also change it in the output you referenced...\nDid you try my implementation of pinmode 6? What did you think of the\ncoding? (I'm in no way related to IT... I work in health services... ;) LOL)\n\nA terça, 14/08/2018, 14:52, andrethomas <notifications@github.com> escreveu:\n\n> @MadDoct <https://github.com/MadDoct> Question\n>\n> Do you know if the rules cares about the -'s you added to make it easier\n> for humans to read?\n>\n> I ask because there's one value which could still be changed\n>\n> snprintf_P(mqtt_data,sizeof(mqtt_data),\n> PSTR(\"%s\"OUTD%i\":%s,\"),mqtt_data,pinx,stt);\n> TO\n> snprintf_P(mqtt_data,sizeof(mqtt_data),\n> PSTR(\"%s\"OUT-D%i\":%s,\"),mqtt_data,pinx,stt);\n>\n> Of course that would mean something like\n>\n> on MCP230_OUT#D0 do xxx endon (its current form)\n>\n> Should work as\n>\n> on MCP230_OUT#D-0 do xxx endon\n>\n> Makes it easier to read, provided the rules code doesnt care about the \"-\"\n> in the variable name\n>\n> I'd test it but have no way of doing that from where I am now\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/arendst/Sonoff-Tasmota/pull/3478#issuecomment-412878802>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AemBw4N2n1iYm5ZIpW9rXBWKzhhmEldYks5uQtYFgaJpZM4V7iCH>\n> .\n>\n"}}
{"actor":{"display_login":"MadDoct"}}