{"action":"created","issue":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1484","repository_url":"https://api.github.com/repos/pyfa-org/Pyfa","labels_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1484/labels{/name}","comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1484/comments","events_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1484/events","html_url":"https://github.com/pyfa-org/Pyfa/issues/1484","id":304196748,"number":1484,"title":"Numerous modules have no active state but should show cap use.","user":{"login":"Neugeniko","id":8612720,"avatar_url":"https://avatars2.githubusercontent.com/u/8612720?v=4","gravatar_id":"","url":"https://api.github.com/users/Neugeniko","html_url":"https://github.com/Neugeniko","followers_url":"https://api.github.com/users/Neugeniko/followers","following_url":"https://api.github.com/users/Neugeniko/following{/other_user}","gists_url":"https://api.github.com/users/Neugeniko/gists{/gist_id}","starred_url":"https://api.github.com/users/Neugeniko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neugeniko/subscriptions","organizations_url":"https://api.github.com/users/Neugeniko/orgs","repos_url":"https://api.github.com/users/Neugeniko/repos","events_url":"https://api.github.com/users/Neugeniko/events{/privacy}","received_events_url":"https://api.github.com/users/Neugeniko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-03-11T21:39:33Z","updated_at":"2018-03-22T01:17:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"\r\n## Bug Report\r\n\r\n\r\n### Expected behavior:\r\nModules like the reaper, lance, gtfo, bosonic, mjfg etc use cap.\r\n\r\n### Actual behavior:\r\nModules dont use cap since they can't be activated.\r\n\r\n### Detailed steps to reproduce:\r\n\r\n\r\n### Fits involved in EFT format (Edit > To Clipboard > EFT):\r\n\r\n\r\n### Release or development git branch? Please note the release version or commit hash:\r\n1.35.2 or py3\r\n\r\n### Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):\r\nwin 10\r\n\r\n### Other relevant information:\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/comments/375146960","html_url":"https://github.com/pyfa-org/Pyfa/issues/1484#issuecomment-375146960","issue_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1484","id":375146960,"user":{"login":"blitzmann","id":3904767,"avatar_url":"https://avatars1.githubusercontent.com/u/3904767?v=4","gravatar_id":"","url":"https://api.github.com/users/blitzmann","html_url":"https://github.com/blitzmann","followers_url":"https://api.github.com/users/blitzmann/followers","following_url":"https://api.github.com/users/blitzmann/following{/other_user}","gists_url":"https://api.github.com/users/blitzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/blitzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blitzmann/subscriptions","organizations_url":"https://api.github.com/users/blitzmann/orgs","repos_url":"https://api.github.com/users/blitzmann/repos","events_url":"https://api.github.com/users/blitzmann/events{/privacy}","received_events_url":"https://api.github.com/users/blitzmann/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T01:17:58Z","updated_at":"2018-03-22T01:17:58Z","author_association":"COLLABORATOR","body":"Thanks @Neugeniko! I'll look into making a script that can be run to find other modules that have cap usage but don't have an effect file - could be run during updates as a quick check to ensure things like this don't get missed in the future. :)\r\n\r\nAs noted, the `online` fix suggested is unfortunately not a proper fix. I knew I had looked into it previously because it really does seem like it would work (although, the method Ebag came up with was much simplier, just creating an `online` effect file - I was thinking of something more complicated with checking the list of effects for \"online\" and blah blah blah). pyfa will continue to use the standard method of determination a per effect basis which modules can be in an `active` state. Thanks all!"}}
{"actor":{"display_login":"blitzmann"}}