{"action":"closed","number":4380,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/4380","id":226321339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzIxMzM5","html_url":"https://github.com/buildbot/buildbot/pull/4380","diff_url":"https://github.com/buildbot/buildbot/pull/4380.diff","patch_url":"https://github.com/buildbot/buildbot/pull/4380.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/4380","number":4380,"state":"closed","locked":false,"title":"smokes: Use older chromedriver for old Chrome","user":{"login":"p12tic","id":1056711,"node_id":"MDQ6VXNlcjEwNTY3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1056711?v=4","gravatar_id":"","url":"https://api.github.com/users/p12tic","html_url":"https://github.com/p12tic","followers_url":"https://api.github.com/users/p12tic/followers","following_url":"https://api.github.com/users/p12tic/following{/other_user}","gists_url":"https://api.github.com/users/p12tic/gists{/gist_id}","starred_url":"https://api.github.com/users/p12tic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p12tic/subscriptions","organizations_url":"https://api.github.com/users/p12tic/orgs","repos_url":"https://api.github.com/users/p12tic/repos","events_url":"https://api.github.com/users/p12tic/events{/privacy}","received_events_url":"https://api.github.com/users/p12tic/received_events","type":"User","site_admin":false},"body":"Currently we always download newest chromedriver. Unfortunately it usually supports only a couple of latest releases of Chrome which is problematic as they get released each month.\r\n\r\nTo work around this we parse the chromedriver release notes, extract the chrome releases that each chromedriver release supports and use the newest for the version of Chrome on the system.\r\n\r\nHopefully this fixes recent e2e failures on buildbot CI. The other solution is to update Chrome there every few months which would result in forgotten updates time to time.","created_at":"2018-10-27T20:24:19Z","updated_at":"2018-10-28T08:32:34Z","closed_at":"2018-10-28T08:32:34Z","merged_at":"2018-10-28T08:32:34Z","merge_commit_sha":"80f2dd64c074f52d9e54f90b6774b41f6adbe577","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/4380/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/4380/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/4380/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/96bd2a4a3e90346776b985da4e9a2bc8e3d917d9","head":{"label":"p12tic:protractor-use-older-chromedriver-on-old-chrome","ref":"protractor-use-older-chromedriver-on-old-chrome","sha":"96bd2a4a3e90346776b985da4e9a2bc8e3d917d9","user":{"login":"p12tic","id":1056711,"node_id":"MDQ6VXNlcjEwNTY3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1056711?v=4","gravatar_id":"","url":"https://api.github.com/users/p12tic","html_url":"https://github.com/p12tic","followers_url":"https://api.github.com/users/p12tic/followers","following_url":"https://api.github.com/users/p12tic/following{/other_user}","gists_url":"https://api.github.com/users/p12tic/gists{/gist_id}","starred_url":"https://api.github.com/users/p12tic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p12tic/subscriptions","organizations_url":"https://api.github.com/users/p12tic/orgs","repos_url":"https://api.github.com/users/p12tic/repos","events_url":"https://api.github.com/users/p12tic/events{/privacy}","received_events_url":"https://api.github.com/users/p12tic/received_events","type":"User","site_admin":false},"repo":{"id":103315141,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMzMTUxNDE=","name":"buildbot","full_name":"p12tic/buildbot","private":false,"owner":{"login":"p12tic","id":1056711,"node_id":"MDQ6VXNlcjEwNTY3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1056711?v=4","gravatar_id":"","url":"https://api.github.com/users/p12tic","html_url":"https://github.com/p12tic","followers_url":"https://api.github.com/users/p12tic/followers","following_url":"https://api.github.com/users/p12tic/following{/other_user}","gists_url":"https://api.github.com/users/p12tic/gists{/gist_id}","starred_url":"https://api.github.com/users/p12tic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p12tic/subscriptions","organizations_url":"https://api.github.com/users/p12tic/orgs","repos_url":"https://api.github.com/users/p12tic/repos","events_url":"https://api.github.com/users/p12tic/events{/privacy}","received_events_url":"https://api.github.com/users/p12tic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/p12tic/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":true,"url":"https://api.github.com/repos/p12tic/buildbot","forks_url":"https://api.github.com/repos/p12tic/buildbot/forks","keys_url":"https://api.github.com/repos/p12tic/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p12tic/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p12tic/buildbot/teams","hooks_url":"https://api.github.com/repos/p12tic/buildbot/hooks","issue_events_url":"https://api.github.com/repos/p12tic/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/p12tic/buildbot/events","assignees_url":"https://api.github.com/repos/p12tic/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/p12tic/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/p12tic/buildbot/tags","blobs_url":"https://api.github.com/repos/p12tic/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p12tic/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p12tic/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/p12tic/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p12tic/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/p12tic/buildbot/languages","stargazers_url":"https://api.github.com/repos/p12tic/buildbot/stargazers","contributors_url":"https://api.github.com/repos/p12tic/buildbot/contributors","subscribers_url":"https://api.github.com/repos/p12tic/buildbot/subscribers","subscription_url":"https://api.github.com/repos/p12tic/buildbot/subscription","commits_url":"https://api.github.com/repos/p12tic/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/p12tic/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/p12tic/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/p12tic/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/p12tic/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/p12tic/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p12tic/buildbot/merges","archive_url":"https://api.github.com/repos/p12tic/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p12tic/buildbot/downloads","issues_url":"https://api.github.com/repos/p12tic/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/p12tic/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/p12tic/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/p12tic/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p12tic/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/p12tic/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/p12tic/buildbot/deployments","created_at":"2017-09-12T20:02:26Z","updated_at":"2017-09-12T20:02:33Z","pushed_at":"2018-10-27T20:45:45Z","git_url":"git://github.com/p12tic/buildbot.git","ssh_url":"git@github.com:p12tic/buildbot.git","clone_url":"https://github.com/p12tic/buildbot.git","svn_url":"https://github.com/p12tic/buildbot","homepage":"http://buildbot.net","size":47649,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"505902bdf1bd0849e9671321a6f540ae9f085229","user":{"login":"buildbot","id":324515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDUxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/324515?v=4","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"node_id":"MDEwOlJlcG9zaXRvcnk3NjAxNjU=","name":"buildbot","full_name":"buildbot/buildbot","private":false,"owner":{"login":"buildbot","id":324515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDUxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/324515?v=4","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2018-10-27T22:15:37Z","pushed_at":"2018-10-28T08:32:34Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":47666,"stargazers_count":3641,"watchers_count":3641,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1283,"mirror_url":null,"archived":false,"open_issues_count":476,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1283,"open_issues":476,"watchers":3641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/4380"},"html":{"href":"https://github.com/buildbot/buildbot/pull/4380"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/4380"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/4380/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/4380/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/4380/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/96bd2a4a3e90346776b985da4e9a2bc8e3d917d9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tardyp","id":109859,"node_id":"MDQ6VXNlcjEwOTg1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/109859?v=4","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":127,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"tardyp"}}