{"action":"created","comment":{"url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/comments/204887759","pull_request_review_id":140050654,"id":204887759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg4Nzc1OQ==","diff_hunk":"@@ -0,0 +1,39 @@\n+defmodule JsRoutesExampleWeb.Router do\n+  use JsRoutesExampleWeb, :router\n+\n+  pipeline :browser do\n+    plug(:accepts, [\"html\"])\n+    plug(:fetch_session)\n+    plug(:fetch_flash)\n+    plug(:protect_from_forgery)\n+    plug(:put_secure_browser_headers)\n+  end\n+\n+  pipeline :api do\n+    plug(:accepts, [\"json\"])\n+  end\n+\n+  scope \"/\", JsRoutesExampleWeb do\n+    # Use the default browser stack\n+    pipe_through(:browser)\n+\n+    get(\"/\", PageController, :index)\n+  end\n+\n+  scope \"/api\", JsRoutesExampleWeb do\n+    # Use the default browser stack\n+    pipe_through(:api)\n+\n+    post(\"/page/:id/:name\", ApiController, :page)\n+    put(\"/test/:name/fixed/:arg\", ApiController, :test)\n+  end\n+\n+  scope \"/test\", JsRoutesExampleWeb do\n+    # TEST-PLACEHOLDER#","path":"example/lib/js_routes_example_web/router.ex","position":32,"original_position":32,"commit_id":"fd9abb77189da2e29a35f2cf74ed261350ebcc02","original_commit_id":"fd9abb77189da2e29a35f2cf74ed261350ebcc02","user":{"login":"tiagoengel","id":1457263,"node_id":"MDQ6VXNlcjE0NTcyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1457263?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagoengel","html_url":"https://github.com/tiagoengel","followers_url":"https://api.github.com/users/tiagoengel/followers","following_url":"https://api.github.com/users/tiagoengel/following{/other_user}","gists_url":"https://api.github.com/users/tiagoengel/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoengel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoengel/subscriptions","organizations_url":"https://api.github.com/users/tiagoengel/orgs","repos_url":"https://api.github.com/users/tiagoengel/repos","events_url":"https://api.github.com/users/tiagoengel/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoengel/received_events","type":"User","site_admin":false},"body":"tests are failing because of this. it should be `#TEST-PLACEHOLDER#`","created_at":"2018-07-24T19:47:19Z","updated_at":"2018-07-24T20:00:25Z","html_url":"https://github.com/tiagoengel/phoenix-jsroutes/pull/8#discussion_r204887759","pull_request_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/comments/204887759"},"html":{"href":"https://github.com/tiagoengel/phoenix-jsroutes/pull/8#discussion_r204887759"},"pull_request":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8","id":203018225,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDE4MjI1","html_url":"https://github.com/tiagoengel/phoenix-jsroutes/pull/8","diff_url":"https://github.com/tiagoengel/phoenix-jsroutes/pull/8.diff","patch_url":"https://github.com/tiagoengel/phoenix-jsroutes/pull/8.patch","issue_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues/8","number":8,"state":"open","locked":false,"title":"Update for compatibility with Phoenix 1.3 and latest elixir.","user":{"login":"tokafish","id":56414,"node_id":"MDQ6VXNlcjU2NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/56414?v=4","gravatar_id":"","url":"https://api.github.com/users/tokafish","html_url":"https://github.com/tokafish","followers_url":"https://api.github.com/users/tokafish/followers","following_url":"https://api.github.com/users/tokafish/following{/other_user}","gists_url":"https://api.github.com/users/tokafish/gists{/gist_id}","starred_url":"https://api.github.com/users/tokafish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokafish/subscriptions","organizations_url":"https://api.github.com/users/tokafish/orgs","repos_url":"https://api.github.com/users/tokafish/repos","events_url":"https://api.github.com/users/tokafish/events{/privacy}","received_events_url":"https://api.github.com/users/tokafish/received_events","type":"User","site_admin":false},"body":"First off, thanks for the work on this package!\r\n\r\nI attempted to use this with a brand new Phoenix app. I found some issues which I believe I've corrected:\r\n\r\n* I made `:router` configurable via the application env, since the new default in Phoenix 1.3 is AppName**Web**.Router, rather than `AppName.Router`.\r\n* I fixed a deprecation on `Mix.Utils.camelize`\r\n* Formatted and fixed warnings.\r\n\r\nIt works now on my app, and I believe it's still compatible with older versions.\r\n","created_at":"2018-07-21T17:05:19Z","updated_at":"2018-07-24T20:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c35259444fa6db7b6bfc8d03b4b29a0456edf69b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8/commits","review_comments_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8/comments","review_comment_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues/8/comments","statuses_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/statuses/fd9abb77189da2e29a35f2cf74ed261350ebcc02","head":{"label":"tokafish:master","ref":"master","sha":"fd9abb77189da2e29a35f2cf74ed261350ebcc02","user":{"login":"tokafish","id":56414,"node_id":"MDQ6VXNlcjU2NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/56414?v=4","gravatar_id":"","url":"https://api.github.com/users/tokafish","html_url":"https://github.com/tokafish","followers_url":"https://api.github.com/users/tokafish/followers","following_url":"https://api.github.com/users/tokafish/following{/other_user}","gists_url":"https://api.github.com/users/tokafish/gists{/gist_id}","starred_url":"https://api.github.com/users/tokafish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokafish/subscriptions","organizations_url":"https://api.github.com/users/tokafish/orgs","repos_url":"https://api.github.com/users/tokafish/repos","events_url":"https://api.github.com/users/tokafish/events{/privacy}","received_events_url":"https://api.github.com/users/tokafish/received_events","type":"User","site_admin":false},"repo":{"id":141822777,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4MjI3Nzc=","name":"phoenix-jsroutes","full_name":"tokafish/phoenix-jsroutes","owner":{"login":"tokafish","id":56414,"node_id":"MDQ6VXNlcjU2NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/56414?v=4","gravatar_id":"","url":"https://api.github.com/users/tokafish","html_url":"https://github.com/tokafish","followers_url":"https://api.github.com/users/tokafish/followers","following_url":"https://api.github.com/users/tokafish/following{/other_user}","gists_url":"https://api.github.com/users/tokafish/gists{/gist_id}","starred_url":"https://api.github.com/users/tokafish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokafish/subscriptions","organizations_url":"https://api.github.com/users/tokafish/orgs","repos_url":"https://api.github.com/users/tokafish/repos","events_url":"https://api.github.com/users/tokafish/events{/privacy}","received_events_url":"https://api.github.com/users/tokafish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tokafish/phoenix-jsroutes","description":"Javascript routing for the phoenix framework","fork":true,"url":"https://api.github.com/repos/tokafish/phoenix-jsroutes","forks_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/forks","keys_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/teams","hooks_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/hooks","issue_events_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/issues/events{/number}","events_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/events","assignees_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/assignees{/user}","branches_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/branches{/branch}","tags_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/tags","blobs_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/git/refs{/sha}","trees_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/statuses/{sha}","languages_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/languages","stargazers_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/stargazers","contributors_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/contributors","subscribers_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/subscribers","subscription_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/subscription","commits_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/commits{/sha}","git_commits_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/git/commits{/sha}","comments_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/comments{/number}","issue_comment_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/issues/comments{/number}","contents_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/contents/{+path}","compare_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/merges","archive_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/downloads","issues_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/issues{/number}","pulls_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/pulls{/number}","milestones_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/milestones{/number}","notifications_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/labels{/name}","releases_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/releases{/id}","deployments_url":"https://api.github.com/repos/tokafish/phoenix-jsroutes/deployments","created_at":"2018-07-21T15:02:17Z","updated_at":"2018-07-24T05:39:41Z","pushed_at":"2018-07-24T05:39:39Z","git_url":"git://github.com/tokafish/phoenix-jsroutes.git","ssh_url":"git@github.com:tokafish/phoenix-jsroutes.git","clone_url":"https://github.com/tokafish/phoenix-jsroutes.git","svn_url":"https://github.com/tokafish/phoenix-jsroutes","homepage":null,"size":207,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tiagoengel:master","ref":"master","sha":"a491769ceb761ac63a18460122b0e056915fa5a6","user":{"login":"tiagoengel","id":1457263,"node_id":"MDQ6VXNlcjE0NTcyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1457263?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagoengel","html_url":"https://github.com/tiagoengel","followers_url":"https://api.github.com/users/tiagoengel/followers","following_url":"https://api.github.com/users/tiagoengel/following{/other_user}","gists_url":"https://api.github.com/users/tiagoengel/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoengel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoengel/subscriptions","organizations_url":"https://api.github.com/users/tiagoengel/orgs","repos_url":"https://api.github.com/users/tiagoengel/repos","events_url":"https://api.github.com/users/tiagoengel/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoengel/received_events","type":"User","site_admin":false},"repo":{"id":60302538,"node_id":"MDEwOlJlcG9zaXRvcnk2MDMwMjUzOA==","name":"phoenix-jsroutes","full_name":"tiagoengel/phoenix-jsroutes","owner":{"login":"tiagoengel","id":1457263,"node_id":"MDQ6VXNlcjE0NTcyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1457263?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagoengel","html_url":"https://github.com/tiagoengel","followers_url":"https://api.github.com/users/tiagoengel/followers","following_url":"https://api.github.com/users/tiagoengel/following{/other_user}","gists_url":"https://api.github.com/users/tiagoengel/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagoengel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagoengel/subscriptions","organizations_url":"https://api.github.com/users/tiagoengel/orgs","repos_url":"https://api.github.com/users/tiagoengel/repos","events_url":"https://api.github.com/users/tiagoengel/events{/privacy}","received_events_url":"https://api.github.com/users/tiagoengel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiagoengel/phoenix-jsroutes","description":"Javascript routing for the phoenix framework","fork":false,"url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes","forks_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/forks","keys_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/teams","hooks_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/hooks","issue_events_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues/events{/number}","events_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/events","assignees_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/assignees{/user}","branches_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/branches{/branch}","tags_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/tags","blobs_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/statuses/{sha}","languages_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/languages","stargazers_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/stargazers","contributors_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/contributors","subscribers_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/subscribers","subscription_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/subscription","commits_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/contents/{+path}","compare_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/merges","archive_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/downloads","issues_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues{/number}","pulls_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls{/number}","milestones_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/milestones{/number}","notifications_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/labels{/name}","releases_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/releases{/id}","deployments_url":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/deployments","created_at":"2016-06-02T22:52:02Z","updated_at":"2017-12-27T03:27:45Z","pushed_at":"2018-07-24T05:39:41Z","git_url":"git://github.com/tiagoengel/phoenix-jsroutes.git","ssh_url":"git@github.com:tiagoengel/phoenix-jsroutes.git","clone_url":"https://github.com/tiagoengel/phoenix-jsroutes.git","svn_url":"https://github.com/tiagoengel/phoenix-jsroutes","homepage":null,"size":98,"stargazers_count":19,"watchers_count":19,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8"},"html":{"href":"https://github.com/tiagoengel/phoenix-jsroutes/pull/8"},"issue":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues/8"},"comments":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/tiagoengel/phoenix-jsroutes/statuses/fd9abb77189da2e29a35f2cf74ed261350ebcc02"}},"author_association":"NONE"}}
{"actor":{"display_login":"tiagoengel"}}