{"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-Server/pulls/comments/226286722","pull_request_review_id":166069767,"id":226286722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI4NjcyMg==","diff_hunk":"@@ -33,23 +33,25 @@\n import redis.clients.jedis.JedisPool;\n import redis.clients.jedis.JedisPoolConfig;\n import redis.clients.jedis.Protocol;\n+import redis.clients.util.JedisURIHelper;\n \n public class RedisClientFactory implements RedisPubSubConnectionFactory {\n \n   private final Logger logger = LoggerFactory.getLogger(RedisClientFactory.class);\n \n   private final String    host;\n   private final int       port;\n+  private final String    password;\n   private final ReplicatedJedisPool jedisPool;\n \n   public RedisClientFactory(String url, List<String> replicaUrls) throws URISyntaxException {\n     JedisPoolConfig poolConfig = new JedisPoolConfig();\n     poolConfig.setTestOnBorrow(true);\n \n     URI redisURI = new URI(url);\n-\n     this.host      = redisURI.getHost();\n     this.port      = redisURI.getPort();\n+    this.password  = JedisURIHelper.getPassword(redisURI);\n \n     JedisPool       masterPool   = new JedisPool(poolConfig, host, port, Protocol.DEFAULT_TIMEOUT, null);","path":"src/main/java/org/whispersystems/textsecuregcm/providers/RedisClientFactory.java","position":null,"original_position":25,"commit_id":"607cc240b9e8f64d0f33ff5fccf0d8b1ffcc9605","original_commit_id":"9bc1ea501dc7f9177153f4d5150c3d2178be2f04","user":{"login":"mronus","id":2014677,"node_id":"MDQ6VXNlcjIwMTQ2Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2014677?v=4","gravatar_id":"","url":"https://api.github.com/users/mronus","html_url":"https://github.com/mronus","followers_url":"https://api.github.com/users/mronus/followers","following_url":"https://api.github.com/users/mronus/following{/other_user}","gists_url":"https://api.github.com/users/mronus/gists{/gist_id}","starred_url":"https://api.github.com/users/mronus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mronus/subscriptions","organizations_url":"https://api.github.com/users/mronus/orgs","repos_url":"https://api.github.com/users/mronus/repos","events_url":"https://api.github.com/users/mronus/events{/privacy}","received_events_url":"https://api.github.com/users/mronus/received_events","type":"User","site_admin":false},"body":"Sorry I messed up this branch :) I created a new one to not loose much time, and added password to JedisPool constructors too.","created_at":"2018-10-18T12:37:20Z","updated_at":"2018-10-18T12:37:20Z","html_url":"https://github.com/signalapp/Signal-Server/pull/92#discussion_r226286722","pull_request_url":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-Server/pulls/comments/226286722"},"html":{"href":"https://github.com/signalapp/Signal-Server/pull/92#discussion_r226286722"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92"}},"in_reply_to_id":225138629},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92","id":212980459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTgwNDU5","html_url":"https://github.com/signalapp/Signal-Server/pull/92","diff_url":"https://github.com/signalapp/Signal-Server/pull/92.diff","patch_url":"https://github.com/signalapp/Signal-Server/pull/92.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-Server/issues/92","number":92,"state":"open","locked":false,"title":"Redis authentication","user":{"login":"mronus","id":2014677,"node_id":"MDQ6VXNlcjIwMTQ2Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2014677?v=4","gravatar_id":"","url":"https://api.github.com/users/mronus","html_url":"https://github.com/mronus","followers_url":"https://api.github.com/users/mronus/followers","following_url":"https://api.github.com/users/mronus/following{/other_user}","gists_url":"https://api.github.com/users/mronus/gists{/gist_id}","starred_url":"https://api.github.com/users/mronus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mronus/subscriptions","organizations_url":"https://api.github.com/users/mronus/orgs","repos_url":"https://api.github.com/users/mronus/repos","events_url":"https://api.github.com/users/mronus/events{/privacy}","received_events_url":"https://api.github.com/users/mronus/received_events","type":"User","site_admin":false},"body":"- Authenticate redis if password is provided","created_at":"2018-09-04T13:40:40Z","updated_at":"2018-10-18T12:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e444c95e4ab7c112d8e1382886f38cb7fb24fb14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-Server/issues/92/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-Server/statuses/607cc240b9e8f64d0f33ff5fccf0d8b1ffcc9605","head":{"label":"mronus:bugfix/redis-auth","ref":"bugfix/redis-auth","sha":"607cc240b9e8f64d0f33ff5fccf0d8b1ffcc9605","user":{"login":"mronus","id":2014677,"node_id":"MDQ6VXNlcjIwMTQ2Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2014677?v=4","gravatar_id":"","url":"https://api.github.com/users/mronus","html_url":"https://github.com/mronus","followers_url":"https://api.github.com/users/mronus/followers","following_url":"https://api.github.com/users/mronus/following{/other_user}","gists_url":"https://api.github.com/users/mronus/gists{/gist_id}","starred_url":"https://api.github.com/users/mronus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mronus/subscriptions","organizations_url":"https://api.github.com/users/mronus/orgs","repos_url":"https://api.github.com/users/mronus/repos","events_url":"https://api.github.com/users/mronus/events{/privacy}","received_events_url":"https://api.github.com/users/mronus/received_events","type":"User","site_admin":false},"repo":{"id":147233286,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMzMyODY=","name":"Signal-Server","full_name":"mronus/Signal-Server","private":false,"owner":{"login":"mronus","id":2014677,"node_id":"MDQ6VXNlcjIwMTQ2Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2014677?v=4","gravatar_id":"","url":"https://api.github.com/users/mronus","html_url":"https://github.com/mronus","followers_url":"https://api.github.com/users/mronus/followers","following_url":"https://api.github.com/users/mronus/following{/other_user}","gists_url":"https://api.github.com/users/mronus/gists{/gist_id}","starred_url":"https://api.github.com/users/mronus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mronus/subscriptions","organizations_url":"https://api.github.com/users/mronus/orgs","repos_url":"https://api.github.com/users/mronus/repos","events_url":"https://api.github.com/users/mronus/events{/privacy}","received_events_url":"https://api.github.com/users/mronus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mronus/Signal-Server","description":null,"fork":true,"url":"https://api.github.com/repos/mronus/Signal-Server","forks_url":"https://api.github.com/repos/mronus/Signal-Server/forks","keys_url":"https://api.github.com/repos/mronus/Signal-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mronus/Signal-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mronus/Signal-Server/teams","hooks_url":"https://api.github.com/repos/mronus/Signal-Server/hooks","issue_events_url":"https://api.github.com/repos/mronus/Signal-Server/issues/events{/number}","events_url":"https://api.github.com/repos/mronus/Signal-Server/events","assignees_url":"https://api.github.com/repos/mronus/Signal-Server/assignees{/user}","branches_url":"https://api.github.com/repos/mronus/Signal-Server/branches{/branch}","tags_url":"https://api.github.com/repos/mronus/Signal-Server/tags","blobs_url":"https://api.github.com/repos/mronus/Signal-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mronus/Signal-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mronus/Signal-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mronus/Signal-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mronus/Signal-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/mronus/Signal-Server/languages","stargazers_url":"https://api.github.com/repos/mronus/Signal-Server/stargazers","contributors_url":"https://api.github.com/repos/mronus/Signal-Server/contributors","subscribers_url":"https://api.github.com/repos/mronus/Signal-Server/subscribers","subscription_url":"https://api.github.com/repos/mronus/Signal-Server/subscription","commits_url":"https://api.github.com/repos/mronus/Signal-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mronus/Signal-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mronus/Signal-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mronus/Signal-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mronus/Signal-Server/contents/{+path}","compare_url":"https://api.github.com/repos/mronus/Signal-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mronus/Signal-Server/merges","archive_url":"https://api.github.com/repos/mronus/Signal-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mronus/Signal-Server/downloads","issues_url":"https://api.github.com/repos/mronus/Signal-Server/issues{/number}","pulls_url":"https://api.github.com/repos/mronus/Signal-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/mronus/Signal-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/mronus/Signal-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mronus/Signal-Server/labels{/name}","releases_url":"https://api.github.com/repos/mronus/Signal-Server/releases{/id}","deployments_url":"https://api.github.com/repos/mronus/Signal-Server/deployments","created_at":"2018-09-03T17:11:26Z","updated_at":"2018-09-04T14:25:36Z","pushed_at":"2018-10-18T12:35:16Z","git_url":"git://github.com/mronus/Signal-Server.git","ssh_url":"git@github.com:mronus/Signal-Server.git","clone_url":"https://github.com/mronus/Signal-Server.git","svn_url":"https://github.com/mronus/Signal-Server","homepage":null,"size":1159,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"signalapp:master","ref":"master","sha":"15cf010e449e61d06fed1387abd01d64c5e6ea82","user":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":15040596,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MDU5Ng==","name":"Signal-Server","full_name":"signalapp/Signal-Server","private":false,"owner":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/signalapp/Signal-Server","description":null,"fork":false,"url":"https://api.github.com/repos/signalapp/Signal-Server","forks_url":"https://api.github.com/repos/signalapp/Signal-Server/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-Server/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-Server/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-Server/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-Server/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-Server/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-Server/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-Server/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-Server/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-Server/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-Server/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-Server/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-Server/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-Server/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-Server/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-Server/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-Server/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-Server/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-Server/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-Server/deployments","created_at":"2013-12-09T07:10:36Z","updated_at":"2018-10-17T13:01:17Z","pushed_at":"2018-10-18T12:35:50Z","git_url":"git://github.com/signalapp/Signal-Server.git","ssh_url":"git@github.com:signalapp/Signal-Server.git","clone_url":"https://github.com/signalapp/Signal-Server.git","svn_url":"https://github.com/signalapp/Signal-Server","homepage":null,"size":1184,"stargazers_count":1328,"watchers_count":1328,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":487,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":487,"open_issues":21,"watchers":1328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92"},"html":{"href":"https://github.com/signalapp/Signal-Server/pull/92"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-Server/issues/92"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-Server/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-Server/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-Server/statuses/607cc240b9e8f64d0f33ff5fccf0d8b1ffcc9605"}},"author_association":"NONE"}}
{"actor":{"display_login":"mronus"}}