{"action":"created","issue":{"url":"https://api.github.com/repos/codeforboston/cliff-effects/issues/923","repository_url":"https://api.github.com/repos/codeforboston/cliff-effects","labels_url":"https://api.github.com/repos/codeforboston/cliff-effects/issues/923/labels{/name}","comments_url":"https://api.github.com/repos/codeforboston/cliff-effects/issues/923/comments","events_url":"https://api.github.com/repos/codeforboston/cliff-effects/issues/923/events","html_url":"https://github.com/codeforboston/cliff-effects/issues/923","id":374689790,"node_id":"MDU6SXNzdWUzNzQ2ODk3OTA=","number":923,"title":"List of weak/unclear variable names to improve (some may need discussion)","user":{"login":"knod","id":4466164,"node_id":"MDQ6VXNlcjQ0NjYxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4466164?v=4","gravatar_id":"","url":"https://api.github.com/users/knod","html_url":"https://github.com/knod","followers_url":"https://api.github.com/users/knod/followers","following_url":"https://api.github.com/users/knod/following{/other_user}","gists_url":"https://api.github.com/users/knod/gists{/gist_id}","starred_url":"https://api.github.com/users/knod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knod/subscriptions","organizations_url":"https://api.github.com/users/knod/orgs","repos_url":"https://api.github.com/users/knod/repos","events_url":"https://api.github.com/users/knod/events{/privacy}","received_events_url":"https://api.github.com/users/knod/received_events","type":"User","site_admin":false},"labels":[{"id":679366058,"node_id":"MDU6TGFiZWw2NzkzNjYwNTg=","url":"https://api.github.com/repos/codeforboston/cliff-effects/labels/discussion%20needed","name":"discussion needed","color":"cc317c","default":false},{"id":703865206,"node_id":"MDU6TGFiZWw3MDM4NjUyMDY=","url":"https://api.github.com/repos/codeforboston/cliff-effects/labels/infrastructure","name":"infrastructure","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"pporfilio","id":530116,"node_id":"MDQ6VXNlcjUzMDExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/530116?v=4","gravatar_id":"","url":"https://api.github.com/users/pporfilio","html_url":"https://github.com/pporfilio","followers_url":"https://api.github.com/users/pporfilio/followers","following_url":"https://api.github.com/users/pporfilio/following{/other_user}","gists_url":"https://api.github.com/users/pporfilio/gists{/gist_id}","starred_url":"https://api.github.com/users/pporfilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pporfilio/subscriptions","organizations_url":"https://api.github.com/users/pporfilio/orgs","repos_url":"https://api.github.com/users/pporfilio/repos","events_url":"https://api.github.com/users/pporfilio/events{/privacy}","received_events_url":"https://api.github.com/users/pporfilio/received_events","type":"User","site_admin":false},"assignees":[{"login":"pporfilio","id":530116,"node_id":"MDQ6VXNlcjUzMDExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/530116?v=4","gravatar_id":"","url":"https://api.github.com/users/pporfilio","html_url":"https://github.com/pporfilio","followers_url":"https://api.github.com/users/pporfilio/followers","following_url":"https://api.github.com/users/pporfilio/following{/other_user}","gists_url":"https://api.github.com/users/pporfilio/gists{/gist_id}","starred_url":"https://api.github.com/users/pporfilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pporfilio/subscriptions","organizations_url":"https://api.github.com/users/pporfilio/orgs","repos_url":"https://api.github.com/users/pporfilio/repos","events_url":"https://api.github.com/users/pporfilio/events{/privacy}","received_events_url":"https://api.github.com/users/pporfilio/received_events","type":"User","site_admin":false},{"login":"knod","id":4466164,"node_id":"MDQ6VXNlcjQ0NjYxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4466164?v=4","gravatar_id":"","url":"https://api.github.com/users/knod","html_url":"https://github.com/knod","followers_url":"https://api.github.com/users/knod/followers","following_url":"https://api.github.com/users/knod/following{/other_user}","gists_url":"https://api.github.com/users/knod/gists{/gist_id}","starred_url":"https://api.github.com/users/knod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knod/subscriptions","organizations_url":"https://api.github.com/users/knod/orgs","repos_url":"https://api.github.com/users/knod/repos","events_url":"https://api.github.com/users/knod/events{/privacy}","received_events_url":"https://api.github.com/users/knod/received_events","type":"User","site_admin":false},{"login":"turnerhayes","id":6371670,"node_id":"MDQ6VXNlcjYzNzE2NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6371670?v=4","gravatar_id":"","url":"https://api.github.com/users/turnerhayes","html_url":"https://github.com/turnerhayes","followers_url":"https://api.github.com/users/turnerhayes/followers","following_url":"https://api.github.com/users/turnerhayes/following{/other_user}","gists_url":"https://api.github.com/users/turnerhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/turnerhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turnerhayes/subscriptions","organizations_url":"https://api.github.com/users/turnerhayes/orgs","repos_url":"https://api.github.com/users/turnerhayes/repos","events_url":"https://api.github.com/users/turnerhayes/events{/privacy}","received_events_url":"https://api.github.com/users/turnerhayes/received_events","type":"User","site_admin":false},{"login":"jlangevin","id":11415084,"node_id":"MDQ6VXNlcjExNDE1MDg0","avatar_url":"https://avatars3.githubusercontent.com/u/11415084?v=4","gravatar_id":"","url":"https://api.github.com/users/jlangevin","html_url":"https://github.com/jlangevin","followers_url":"https://api.github.com/users/jlangevin/followers","following_url":"https://api.github.com/users/jlangevin/following{/other_user}","gists_url":"https://api.github.com/users/jlangevin/gists{/gist_id}","starred_url":"https://api.github.com/users/jlangevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlangevin/subscriptions","organizations_url":"https://api.github.com/users/jlangevin/orgs","repos_url":"https://api.github.com/users/jlangevin/repos","events_url":"https://api.github.com/users/jlangevin/events{/privacy}","received_events_url":"https://api.github.com/users/jlangevin/received_events","type":"User","site_admin":false},{"login":"dylanesque","id":13280874,"node_id":"MDQ6VXNlcjEzMjgwODc0","avatar_url":"https://avatars0.githubusercontent.com/u/13280874?v=4","gravatar_id":"","url":"https://api.github.com/users/dylanesque","html_url":"https://github.com/dylanesque","followers_url":"https://api.github.com/users/dylanesque/followers","following_url":"https://api.github.com/users/dylanesque/following{/other_user}","gists_url":"https://api.github.com/users/dylanesque/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanesque/subscriptions","organizations_url":"https://api.github.com/users/dylanesque/orgs","repos_url":"https://api.github.com/users/dylanesque/repos","events_url":"https://api.github.com/users/dylanesque/events{/privacy}","received_events_url":"https://api.github.com/users/dylanesque/received_events","type":"User","site_admin":false},{"login":"MRLmic","id":30061432,"node_id":"MDQ6VXNlcjMwMDYxNDMy","avatar_url":"https://avatars1.githubusercontent.com/u/30061432?v=4","gravatar_id":"","url":"https://api.github.com/users/MRLmic","html_url":"https://github.com/MRLmic","followers_url":"https://api.github.com/users/MRLmic/followers","following_url":"https://api.github.com/users/MRLmic/following{/other_user}","gists_url":"https://api.github.com/users/MRLmic/gists{/gist_id}","starred_url":"https://api.github.com/users/MRLmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRLmic/subscriptions","organizations_url":"https://api.github.com/users/MRLmic/orgs","repos_url":"https://api.github.com/users/MRLmic/repos","events_url":"https://api.github.com/users/MRLmic/events{/privacy}","received_events_url":"https://api.github.com/users/MRLmic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-10-27T21:15:57Z","updated_at":"2018-11-15T13:48:08Z","closed_at":null,"author_association":"COLLABORATOR","body":"Include the variable name and the file path in which it appears. You can also add notes explaining yourself. Feel free to add them below or in new comments! Please don't get rid of or change something that someone else put down, though you can certainly add to the conversation surrounding it.\r\n\r\n- [ ] 1. `activeID` GraphTimeButtons.js\r\n- [ ] 2. `client` Everywhere. There are two `client`s. One for a client's account and one for the client data. Even without that, I'm not sure `client` is a great name for that data as it grows. The latter is complicated by the fact that it has the `current` and `future` props. Options:\r\n      1. `account` or `accountData` for... account data.\r\n      2. `answers` for form data. Then it can be all form data, not just client data. E.g. whether the client wants to fill in extra expense amounts. Is that something we want? `current` and `future` don't really fit into that model.\r\n      3. `responses` (similar, though with problems)\r\n      4. `benefitData` or `dataForBenefits` 😕\r\n      5. `household` for client data, since it really is the household we're collecting info about. This may change if we start to calculate individual benefits, such as with MassHealth. We'd have to talk to SMEs about that.\r\n- [ ] 3. `predictions` Predictions.js and it's associated stuff. Not sure about this. We may need to keep it as it is since it indicates the future. It's partly a 'plain language' thing. Maybe `report` would work, but it's not as specific.\r\n- [ ] 4. `timeClient` or whatever it is. I have to go. I'll find it later.\r\n\r\nThis may not be the best format for doing this. What would be better? Something with a reddit-like commenting system? We can discuss."},"comment":{"url":"https://api.github.com/repos/codeforboston/cliff-effects/issues/comments/439045409","html_url":"https://github.com/codeforboston/cliff-effects/issues/923#issuecomment-439045409","issue_url":"https://api.github.com/repos/codeforboston/cliff-effects/issues/923","id":439045409,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTA0NTQwOQ==","user":{"login":"knod","id":4466164,"node_id":"MDQ6VXNlcjQ0NjYxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4466164?v=4","gravatar_id":"","url":"https://api.github.com/users/knod","html_url":"https://github.com/knod","followers_url":"https://api.github.com/users/knod/followers","following_url":"https://api.github.com/users/knod/following{/other_user}","gists_url":"https://api.github.com/users/knod/gists{/gist_id}","starred_url":"https://api.github.com/users/knod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knod/subscriptions","organizations_url":"https://api.github.com/users/knod/orgs","repos_url":"https://api.github.com/users/knod/repos","events_url":"https://api.github.com/users/knod/events{/privacy}","received_events_url":"https://api.github.com/users/knod/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T13:48:08Z","updated_at":"2018-11-15T13:48:08Z","author_association":"COLLABORATOR","body":"- [ ] `toMoneyStr` also isn't descriptive. I'm not sure what else to call it. It takes a number, adds to decimal points if needed, otherwise rounds a number to the first two decimal points, then returns a string of that. It's basically just a wrapper for `.toFixed(2)`, but means we don't have to remember that functionality everywhere."}}
{"actor":{"display_login":"knod"}}