{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/182209330","pull_request_review_id":112971657,"id":182209330,"diff_hunk":"@@ -47,37 +47,32 @@ var (\n \tkeySize        = flag.Int(\"key-size\", 2048, \"Size of the generated private key\")\n )\n \n-func fatalf(template string, args ...interface{}) {\n-\tlog.Errorf(template, args)\n-\tos.Exit(-1)\n-}\n-\n func checkCmdLine() {\n \tflag.Parse()\n \n \thasCert, hasPriv := len(*signerCertFile) != 0, len(*signerPrivFile) != 0\n \tif *isSelfSigned {\n \t\tif hasCert || hasPriv {\n-\t\t\tfatalf(\"--self-signed is incompatible with --signer-cert or --signer-priv.\")\n+\t\t\tlog.Fatalf(\"--self-signed is incompatible with --signer-cert or --signer-priv.\")","path":"security/cmd/generate_cert/main.go","position":16,"original_position":16,"commit_id":"878e9ef83d9dd4f955ecd7fecc64c9aad6548c36","original_commit_id":"878e9ef83d9dd4f955ecd7fecc64c9aad6548c36","user":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"body":"We don't want command-line tools to be using logging for their primary output to the user. It produces a terrible interactive experience.\r\n","created_at":"2018-04-17T20:08:07Z","updated_at":"2018-04-17T20:08:07Z","html_url":"https://github.com/istio/istio/pull/4821#discussion_r182209330","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/4821","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/182209330"},"html":{"href":"https://github.com/istio/istio/pull/4821#discussion_r182209330"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/4821"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4821","id":180246862,"html_url":"https://github.com/istio/istio/pull/4821","diff_url":"https://github.com/istio/istio/pull/4821.diff","patch_url":"https://github.com/istio/istio/pull/4821.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/4821","number":4821,"state":"open","locked":false,"title":"Add Fatalf function for log and use it in security","user":{"login":"ping035627","id":17894459,"avatar_url":"https://avatars0.githubusercontent.com/u/17894459?v=4","gravatar_id":"","url":"https://api.github.com/users/ping035627","html_url":"https://github.com/ping035627","followers_url":"https://api.github.com/users/ping035627/followers","following_url":"https://api.github.com/users/ping035627/following{/other_user}","gists_url":"https://api.github.com/users/ping035627/gists{/gist_id}","starred_url":"https://api.github.com/users/ping035627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ping035627/subscriptions","organizations_url":"https://api.github.com/users/ping035627/orgs","repos_url":"https://api.github.com/users/ping035627/repos","events_url":"https://api.github.com/users/ping035627/events{/privacy}","received_events_url":"https://api.github.com/users/ping035627/received_events","type":"User","site_admin":false},"body":"The fatalf function has been defined many times in security. I think we should define the Fatalf function in pkg/log so that other modules can invoke it.","created_at":"2018-04-09T08:50:23Z","updated_at":"2018-04-17T20:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14493c25ca9645cc516f223910fd6a9ff4c74afb","assignee":{"login":"myidpt","id":102881,"avatar_url":"https://avatars2.githubusercontent.com/u/102881?v=4","gravatar_id":"","url":"https://api.github.com/users/myidpt","html_url":"https://github.com/myidpt","followers_url":"https://api.github.com/users/myidpt/followers","following_url":"https://api.github.com/users/myidpt/following{/other_user}","gists_url":"https://api.github.com/users/myidpt/gists{/gist_id}","starred_url":"https://api.github.com/users/myidpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myidpt/subscriptions","organizations_url":"https://api.github.com/users/myidpt/orgs","repos_url":"https://api.github.com/users/myidpt/repos","events_url":"https://api.github.com/users/myidpt/events{/privacy}","received_events_url":"https://api.github.com/users/myidpt/received_events","type":"User","site_admin":false},"assignees":[{"login":"myidpt","id":102881,"avatar_url":"https://avatars2.githubusercontent.com/u/102881?v=4","gravatar_id":"","url":"https://api.github.com/users/myidpt","html_url":"https://github.com/myidpt","followers_url":"https://api.github.com/users/myidpt/followers","following_url":"https://api.github.com/users/myidpt/following{/other_user}","gists_url":"https://api.github.com/users/myidpt/gists{/gist_id}","starred_url":"https://api.github.com/users/myidpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myidpt/subscriptions","organizations_url":"https://api.github.com/users/myidpt/orgs","repos_url":"https://api.github.com/users/myidpt/repos","events_url":"https://api.github.com/users/myidpt/events{/privacy}","received_events_url":"https://api.github.com/users/myidpt/received_events","type":"User","site_admin":false},{"login":"wattli","id":24381542,"avatar_url":"https://avatars1.githubusercontent.com/u/24381542?v=4","gravatar_id":"","url":"https://api.github.com/users/wattli","html_url":"https://github.com/wattli","followers_url":"https://api.github.com/users/wattli/followers","following_url":"https://api.github.com/users/wattli/following{/other_user}","gists_url":"https://api.github.com/users/wattli/gists{/gist_id}","starred_url":"https://api.github.com/users/wattli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattli/subscriptions","organizations_url":"https://api.github.com/users/wattli/orgs","repos_url":"https://api.github.com/users/wattli/repos","events_url":"https://api.github.com/users/wattli/events{/privacy}","received_events_url":"https://api.github.com/users/wattli/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/4821/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/4821/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/4821/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/878e9ef83d9dd4f955ecd7fecc64c9aad6548c36","head":{"label":"ping035627:istio-180409","ref":"istio-180409","sha":"878e9ef83d9dd4f955ecd7fecc64c9aad6548c36","user":{"login":"ping035627","id":17894459,"avatar_url":"https://avatars0.githubusercontent.com/u/17894459?v=4","gravatar_id":"","url":"https://api.github.com/users/ping035627","html_url":"https://github.com/ping035627","followers_url":"https://api.github.com/users/ping035627/followers","following_url":"https://api.github.com/users/ping035627/following{/other_user}","gists_url":"https://api.github.com/users/ping035627/gists{/gist_id}","starred_url":"https://api.github.com/users/ping035627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ping035627/subscriptions","organizations_url":"https://api.github.com/users/ping035627/orgs","repos_url":"https://api.github.com/users/ping035627/repos","events_url":"https://api.github.com/users/ping035627/events{/privacy}","received_events_url":"https://api.github.com/users/ping035627/received_events","type":"User","site_admin":false},"repo":{"id":126259372,"name":"istio","full_name":"ping035627/istio","owner":{"login":"ping035627","id":17894459,"avatar_url":"https://avatars0.githubusercontent.com/u/17894459?v=4","gravatar_id":"","url":"https://api.github.com/users/ping035627","html_url":"https://github.com/ping035627","followers_url":"https://api.github.com/users/ping035627/followers","following_url":"https://api.github.com/users/ping035627/following{/other_user}","gists_url":"https://api.github.com/users/ping035627/gists{/gist_id}","starred_url":"https://api.github.com/users/ping035627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ping035627/subscriptions","organizations_url":"https://api.github.com/users/ping035627/orgs","repos_url":"https://api.github.com/users/ping035627/repos","events_url":"https://api.github.com/users/ping035627/events{/privacy}","received_events_url":"https://api.github.com/users/ping035627/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ping035627/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/ping035627/istio","forks_url":"https://api.github.com/repos/ping035627/istio/forks","keys_url":"https://api.github.com/repos/ping035627/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ping035627/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ping035627/istio/teams","hooks_url":"https://api.github.com/repos/ping035627/istio/hooks","issue_events_url":"https://api.github.com/repos/ping035627/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ping035627/istio/events","assignees_url":"https://api.github.com/repos/ping035627/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ping035627/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ping035627/istio/tags","blobs_url":"https://api.github.com/repos/ping035627/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ping035627/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ping035627/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ping035627/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ping035627/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ping035627/istio/languages","stargazers_url":"https://api.github.com/repos/ping035627/istio/stargazers","contributors_url":"https://api.github.com/repos/ping035627/istio/contributors","subscribers_url":"https://api.github.com/repos/ping035627/istio/subscribers","subscription_url":"https://api.github.com/repos/ping035627/istio/subscription","commits_url":"https://api.github.com/repos/ping035627/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ping035627/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ping035627/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ping035627/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ping035627/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ping035627/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ping035627/istio/merges","archive_url":"https://api.github.com/repos/ping035627/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ping035627/istio/downloads","issues_url":"https://api.github.com/repos/ping035627/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ping035627/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ping035627/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ping035627/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ping035627/istio/labels{/name}","releases_url":"https://api.github.com/repos/ping035627/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ping035627/istio/deployments","created_at":"2018-03-22T00:59:26Z","updated_at":"2018-04-17T02:33:35Z","pushed_at":"2018-04-17T04:23:56Z","git_url":"git://github.com/ping035627/istio.git","ssh_url":"git@github.com:ping035627/istio.git","clone_url":"https://github.com/ping035627/istio.git","svn_url":"https://github.com/ping035627/istio","homepage":"https://istio.io","size":19993,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"f4f9d640eeca1d92a489dc1e409c88b25d239310","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-04-17T19:42:39Z","pushed_at":"2018-04-17T20:01:28Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":20303,"stargazers_count":7274,"watchers_count":7274,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":959,"mirror_url":null,"archived":false,"open_issues_count":786,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":959,"open_issues":786,"watchers":7274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/4821"},"html":{"href":"https://github.com/istio/istio/pull/4821"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/4821"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/4821/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/4821/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/4821/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/878e9ef83d9dd4f955ecd7fecc64c9aad6548c36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"geeknoid"}}