{"action":"created","issue":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839","repository_url":"https://api.github.com/repos/ArduPilot/ardupilot","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839/labels{/name}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839/comments","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839/events","html_url":"https://github.com/ArduPilot/ardupilot/pull/8839","id":338793866,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjM2ODk1","number":8839,"title":"Move handling of DO_SET_HOME via command_int up","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"labels":[{"id":547273148,"node_id":"MDU6TGFiZWw1NDcyNzMxNDg=","url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/DevCallTopic","name":"DevCallTopic","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-06T03:33:33Z","updated_at":"2018-11-12T14:10:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8839","html_url":"https://github.com/ArduPilot/ardupilot/pull/8839","diff_url":"https://github.com/ArduPilot/ardupilot/pull/8839.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/8839.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments/437894834","html_url":"https://github.com/ArduPilot/ardupilot/pull/8839#issuecomment-437894834","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8839","id":437894834,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg5NDgzNA==","user":{"login":"OXINARF","id":1778527,"node_id":"MDQ6VXNlcjE3Nzg1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1778527?v=4","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T14:10:52Z","updated_at":"2018-11-12T14:10:52Z","author_association":"MEMBER","body":"> ... however, one of the rationales is that by doing the memset we save\r\nflash wherever we'd otherwise initialise-via-assignment.\r\n\r\nDoes it really save that much flash? Also, have you tested that memset doesn't give warnings on GCC 7 or 8? Pretty sure that's one of the new warnings.\r\n\r\n> Yes, as a future PR :-)\r\n\r\nWhy only as a future PR? You are adding it to Copter, Plane and Rover, I'm not understanding why not add Sub now...\r\n\r\n> With AP_AHRS_NavEKF, quote possibly.  With (the imaginary)\r\nAP_AHRS_External - possibly not.\r\n\r\nI'm very confused by that. Are you saying that a AP_AHRS_External wouldn't follow the same rule of \"if position not available return false\"? That would break ArduPilot everywhere...\r\n\r\n> Well - I've run build_binaries and it works as in master.\r\n\r\nSo just SITL? Did it had previously saved missions and did they work?\r\n\r\n> Removing the packing was my assumption.\r\n\r\nSame as mine, but that shows there could be a problem."}}
{"actor":{"display_login":"OXINARF"}}