{"action":"created","issue":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/816","repository_url":"https://api.github.com/repos/ethersphere/go-ethereum","labels_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/816/labels{/name}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/816/comments","events_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/816/events","html_url":"https://github.com/ethersphere/go-ethereum/pull/816","id":344865153,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTU4Njgw","number":816,"title":"swarm: Added lightnode flag","user":{"login":"agazso","id":230163,"node_id":"MDQ6VXNlcjIzMDE2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/230163?v=4","gravatar_id":"","url":"https://api.github.com/users/agazso","html_url":"https://github.com/agazso","followers_url":"https://api.github.com/users/agazso/followers","following_url":"https://api.github.com/users/agazso/following{/other_user}","gists_url":"https://api.github.com/users/agazso/gists{/gist_id}","starred_url":"https://api.github.com/users/agazso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agazso/subscriptions","organizations_url":"https://api.github.com/users/agazso/orgs","repos_url":"https://api.github.com/users/agazso/repos","events_url":"https://api.github.com/users/agazso/events{/privacy}","received_events_url":"https://api.github.com/users/agazso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-26T14:20:38Z","updated_at":"2018-08-07T13:59:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/816","html_url":"https://github.com/ethersphere/go-ethereum/pull/816","diff_url":"https://github.com/ethersphere/go-ethereum/pull/816.diff","patch_url":"https://github.com/ethersphere/go-ethereum/pull/816.patch"},"body":"Added --lightnode command line parameter\r\nAdded LightNode to Handshake message\r\n\r\nThis is the Task0 of the Light Node implementation.\r\nFor more details see https://hackmd.io/O5PvHQVhQnaNCbhJbAJVog?view"},"comment":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/comments/411066197","html_url":"https://github.com/ethersphere/go-ethereum/pull/816#issuecomment-411066197","issue_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/816","id":411066197,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTA2NjE5Nw==","user":{"login":"nonsense","id":50459,"node_id":"MDQ6VXNlcjUwNDU5","avatar_url":"https://avatars0.githubusercontent.com/u/50459?v=4","gravatar_id":"","url":"https://api.github.com/users/nonsense","html_url":"https://github.com/nonsense","followers_url":"https://api.github.com/users/nonsense/followers","following_url":"https://api.github.com/users/nonsense/following{/other_user}","gists_url":"https://api.github.com/users/nonsense/gists{/gist_id}","starred_url":"https://api.github.com/users/nonsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonsense/subscriptions","organizations_url":"https://api.github.com/users/nonsense/orgs","repos_url":"https://api.github.com/users/nonsense/repos","events_url":"https://api.github.com/users/nonsense/events{/privacy}","received_events_url":"https://api.github.com/users/nonsense/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T13:59:44Z","updated_at":"2018-08-07T13:59:44Z","author_association":"MEMBER","body":"@agazso We are getting a lot of errors in the open cluster, which includes this PR:\r\n\r\n```\r\n\r\nswarm_30399 DEBUG[08-07\\|13:54:42.104\\|p2p/server.go:703] Adding p2p peer name=swarm/v0.3.1-225171a... addr=137.117.226.225:57364 peers=4\r\n--\r\nswarm_30399 WARN [08-07\\|13:54:42.104\\|swarm/network/protocol.go:254] 27991d4d: handshake failed with remote peer fb24c2c5: Handshake error: Invalid message (RLP error): <= msg #0 (203 bytes): rlp: too few elements for network.HandshakeMsg\r\nswarm_30399 DEBUG[08-07\\|13:54:42.104\\|p2p/server.go:721] Removing p2p peer id=daca9ff0c3176045 conn=inbound duration=444.603µs peers=3 req=false err=\"27991d4d: stream protocol closed: Handshake error: Invalid message (RLP error): <= msg #0 (203 bytes): rlp: too few elements for network.HandshakeMsg\"\r\n\r\n\r\n```\r\n\r\nThis is the backward-incompatible change I mentioned, and this is why I wanted to bump up the protocol version.\r\n\r\nHow did you test this to come to the conclusion that RLP can handle both versions of the HandshakeMsg?"}}
{"actor":{"display_login":"nonsense"}}