{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/14394","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/14394/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/14394/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/14394/events","html_url":"https://github.com/highfidelity/hifi/pull/14394","id":380502300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjg1NTA0","number":14394,"title":"(case 19302) Create HFMSerializer interface for model loaders","user":{"login":"sabrina-shanman","id":39919756,"node_id":"MDQ6VXNlcjM5OTE5NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/39919756?v=4","gravatar_id":"","url":"https://api.github.com/users/sabrina-shanman","html_url":"https://github.com/sabrina-shanman","followers_url":"https://api.github.com/users/sabrina-shanman/followers","following_url":"https://api.github.com/users/sabrina-shanman/following{/other_user}","gists_url":"https://api.github.com/users/sabrina-shanman/gists{/gist_id}","starred_url":"https://api.github.com/users/sabrina-shanman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabrina-shanman/subscriptions","organizations_url":"https://api.github.com/users/sabrina-shanman/orgs","repos_url":"https://api.github.com/users/sabrina-shanman/repos","events_url":"https://api.github.com/users/sabrina-shanman/events{/privacy}","received_events_url":"https://api.github.com/users/sabrina-shanman/received_events","type":"User","site_admin":false},"labels":[{"id":675876856,"node_id":"MDU6TGFiZWw2NzU4NzY4NTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-14T01:56:57Z","updated_at":"2018-11-14T02:36:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/14394","html_url":"https://github.com/highfidelity/hifi/pull/14394","diff_url":"https://github.com/highfidelity/hifi/pull/14394.diff","patch_url":"https://github.com/highfidelity/hifi/pull/14394.patch"},"body":"https://highfidelity.manuscript.com/f/cases/19302/improve-model-loading-tool-chain-project-Phase-1\r\n\r\nAs part of Part 1 of the Model Improvement Project, this PR streamlines the inputs/outputs to the model loading classes as seen by ModelCache, though a new universal interface called HFMSerializer (typedefd from hfm::Serializer). FBXReader and similar classes are re-named to fit this interface, for example FBXReader becomes FBXSerializer, and so on. This PR is a follow-up to https://github.com/highfidelity/hifi/pull/14348, which created the HFM library.\r\n\r\n## TEST PLAN\r\n- Run these automatic tests:\r\n  - https://github.com/highfidelity/hifi_tests/tree/master/tests/content/entity/model/modelReaders\r\n- In this PR, verify collision models work as expected for \"Basic\" and \"Good\" collision types\r\n  - Note: This test is different from the one in https://github.com/highfidelity/hifi/pull/14156\r\n  - For both \"Basic\" and \"Good\" collision types:\r\n    - Use this model url: https://gist.githubusercontent.com/sabrina-shanman/457b40f2a66b517b0dc41196bf6ab96e/raw/bf5405a23cefe3662e30d14edf4d3386a406e128/wamConsole_hull_2_grouptest.obj\r\n    - Create the model. In a domain with edit rights, open Create Tools. Under Create tab, select Model, paste the model url into the Model URL field, then select either \"Basic\" or \"Good\" from the Automatic Collisions dropdown. Click \"Add\"\r\n    - Resize the model if needed so it is near the scale of the avatar. The model should look like a grey, chair-shaped object. Then, make the avatar attempt to stand on the seat area of the model.\r\n  - For \"Basic\" collision, the avatar should fail to stand on the seat area as there is an invisible sloped barrier in the way\r\n  - For \"Good\" collision, the avatar should be able to stand on the seat area."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/438516131","html_url":"https://github.com/highfidelity/hifi/pull/14394#issuecomment-438516131","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/14394","id":438516131,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODUxNjEzMQ==","user":{"login":"hifi-gustavo","id":4554450,"node_id":"MDQ6VXNlcjQ1NTQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T02:36:52Z","updated_at":"2018-11-14T02:36:52Z","author_association":"NONE","body":"Windows build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dwindows/15132/HighFidelity-Beta-PR14394-e08bc72.exe"}}
{"actor":{"display_login":"hifi-gustavo"}}