{"action":"created","issue":{"url":"https://api.github.com/repos/coredns/coredns/issues/2104","repository_url":"https://api.github.com/repos/coredns/coredns","labels_url":"https://api.github.com/repos/coredns/coredns/issues/2104/labels{/name}","comments_url":"https://api.github.com/repos/coredns/coredns/issues/2104/comments","events_url":"https://api.github.com/repos/coredns/coredns/issues/2104/events","html_url":"https://github.com/coredns/coredns/pull/2104","id":361607040,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTM0MzI3","number":2104,"title":"Better naming","user":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-19T07:04:27Z","updated_at":"2018-09-19T07:12:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coredns/coredns/pulls/2104","html_url":"https://github.com/coredns/coredns/pull/2104","diff_url":"https://github.com/coredns/coredns/pull/2104.diff","patch_url":"https://github.com/coredns/coredns/pull/2104.patch"},"body":"    Move functions from pkg/transport to pkg/parse\r\n    \r\n    Although \"parse\" is a fairly generic name I believe this is somewhat\r\n    better named. pkg/transport keeps a few constants that are uses\r\n    throughout for the rest is is renaming a bunch (and the fallout from\r\n    there to make things compile again).\r\n    \r\n    Signed-off-by: Miek Gieben <miek@miek.nl>\r\n"},"comment":{"url":"https://api.github.com/repos/coredns/coredns/issues/comments/422683876","html_url":"https://github.com/coredns/coredns/pull/2104#issuecomment-422683876","issue_url":"https://api.github.com/repos/coredns/coredns/issues/2104","id":422683876,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjY4Mzg3Ng==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T07:12:50Z","updated_at":"2018-09-19T07:12:50Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=h1) Report\n> Merging [#2104](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=desc) into [master](https://codecov.io/gh/coredns/coredns/commit/c349446a23440b336f4ca21900cce4d6a031cdf5?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `96.42%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/coredns/coredns/pull/2104/graphs/tree.svg?width=650&token=Ji3zZaIzpC&height=150&src=pr)](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2104      +/-   ##\n==========================================\n+ Coverage   55.49%   55.51%   +0.02%     \n==========================================\n  Files         202      202              \n  Lines        9933     9933              \n==========================================\n+ Hits         5512     5514       +2     \n+ Misses       3997     3996       -1     \n+ Partials      424      423       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [core/dnsserver/register.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-Y29yZS9kbnNzZXJ2ZXIvcmVnaXN0ZXIuZ28=) | `23.42% <0%> (ø)` | :arrow_up: |\n| [plugin/normalize.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL25vcm1hbGl6ZS5nbw==) | `84.61% <100%> (ø)` | :arrow_up: |\n| [plugin/forward/setup.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL2ZvcndhcmQvc2V0dXAuZ28=) | `57.93% <100%> (ø)` | :arrow_up: |\n| [core/dnsserver/address.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-Y29yZS9kbnNzZXJ2ZXIvYWRkcmVzcy5nbw==) | `100% <100%> (ø)` | :arrow_up: |\n| [plugin/pkg/parse/parse.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL3BrZy9wYXJzZS9wYXJzZS5nbw==) | `84.61% <100%> (ø)` | :arrow_up: |\n| [plugin/pkg/parse/transport.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL3BrZy9wYXJzZS90cmFuc3BvcnQuZ28=) | `100% <100%> (ø)` | |\n| [plugin/proxy/upstream.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL3Byb3h5L3Vwc3RyZWFtLmdv) | `86.66% <100%> (ø)` | :arrow_up: |\n| [plugin/dnstap/setup.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL2Ruc3RhcC9zZXR1cC5nbw==) | `37.5% <100%> (ø)` | :arrow_up: |\n| [plugin/pkg/parse/host.go](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree#diff-cGx1Z2luL3BrZy9wYXJzZS9ob3N0Lmdv) | `75.47% <100%> (ø)` | |\n| ... and [1 more](https://codecov.io/gh/coredns/coredns/pull/2104/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=footer). Last update [c349446...730a91b](https://codecov.io/gh/coredns/coredns/pull/2104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}