{"action":"created","comment":{"url":"https://api.github.com/repos/exercism/rust/pulls/comments/175238460","pull_request_review_id":104746116,"id":175238460,"diff_hunk":"@@ -96,20 +102,20 @@ impl BowlingGame {\n         BowlingGame { frames: vec![Frame::new()] }\n     }\n \n-    pub fn roll(&mut self, pins: u16) -> Result<(), &'static str> {\n+    pub fn roll(&mut self, pins: u16) -> Result<(), Error> {\n         if pins > 10 {\n-            Err(\"Greater than 10 pins\")\n+            Err(Error::NotEnoughPinsLeft)","path":"exercises/bowling/example.rs","position":21,"original_position":21,"commit_id":"99f90448e642004c9b0d184f73749e5837c2acac","original_commit_id":"99f90448e642004c9b0d184f73749e5837c2acac","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"discussion: I do not favour making a separate error variant for `GreaterThanTenPins` since I don't really find it useful to distinguish between a roll that is always invalid and a roll that is sometimes valid but currently invalid given the game state. What does the caller do differently if it were able to distinguish this information?","created_at":"2018-03-16T23:55:53Z","updated_at":"2018-03-16T23:55:54Z","html_url":"https://github.com/exercism/rust/pull/471#discussion_r175238460","pull_request_url":"https://api.github.com/repos/exercism/rust/pulls/471","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exercism/rust/pulls/comments/175238460"},"html":{"href":"https://github.com/exercism/rust/pull/471#discussion_r175238460"},"pull_request":{"href":"https://api.github.com/repos/exercism/rust/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/rust/pulls/471","id":175670107,"html_url":"https://github.com/exercism/rust/pull/471","diff_url":"https://github.com/exercism/rust/pull/471.diff","patch_url":"https://github.com/exercism/rust/pull/471.patch","issue_url":"https://api.github.com/repos/exercism/rust/issues/471","number":471,"state":"open","locked":false,"title":"bowling: Use Option for score and specific errors for roll; add stub","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"see individual commit messages","created_at":"2018-03-16T23:53:40Z","updated_at":"2018-03-16T23:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e8a7ded0dd96435988e4ab73d30d6f5dc4f6ba2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/rust/pulls/471/commits","review_comments_url":"https://api.github.com/repos/exercism/rust/pulls/471/comments","review_comment_url":"https://api.github.com/repos/exercism/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/rust/issues/471/comments","statuses_url":"https://api.github.com/repos/exercism/rust/statuses/99f90448e642004c9b0d184f73749e5837c2acac","head":{"label":"petertseng:bowling","ref":"bowling","sha":"99f90448e642004c9b0d184f73749e5837c2acac","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"repo":{"id":53189871,"name":"exercism-rust","full_name":"petertseng/exercism-rust","owner":{"login":"petertseng","id":346181,"avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petertseng/exercism-rust","description":"Exercism Exercises in Rust.","fork":true,"url":"https://api.github.com/repos/petertseng/exercism-rust","forks_url":"https://api.github.com/repos/petertseng/exercism-rust/forks","keys_url":"https://api.github.com/repos/petertseng/exercism-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petertseng/exercism-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petertseng/exercism-rust/teams","hooks_url":"https://api.github.com/repos/petertseng/exercism-rust/hooks","issue_events_url":"https://api.github.com/repos/petertseng/exercism-rust/issues/events{/number}","events_url":"https://api.github.com/repos/petertseng/exercism-rust/events","assignees_url":"https://api.github.com/repos/petertseng/exercism-rust/assignees{/user}","branches_url":"https://api.github.com/repos/petertseng/exercism-rust/branches{/branch}","tags_url":"https://api.github.com/repos/petertseng/exercism-rust/tags","blobs_url":"https://api.github.com/repos/petertseng/exercism-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petertseng/exercism-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petertseng/exercism-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/petertseng/exercism-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petertseng/exercism-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/petertseng/exercism-rust/languages","stargazers_url":"https://api.github.com/repos/petertseng/exercism-rust/stargazers","contributors_url":"https://api.github.com/repos/petertseng/exercism-rust/contributors","subscribers_url":"https://api.github.com/repos/petertseng/exercism-rust/subscribers","subscription_url":"https://api.github.com/repos/petertseng/exercism-rust/subscription","commits_url":"https://api.github.com/repos/petertseng/exercism-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/petertseng/exercism-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/petertseng/exercism-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/petertseng/exercism-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/petertseng/exercism-rust/contents/{+path}","compare_url":"https://api.github.com/repos/petertseng/exercism-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petertseng/exercism-rust/merges","archive_url":"https://api.github.com/repos/petertseng/exercism-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petertseng/exercism-rust/downloads","issues_url":"https://api.github.com/repos/petertseng/exercism-rust/issues{/number}","pulls_url":"https://api.github.com/repos/petertseng/exercism-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/petertseng/exercism-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/petertseng/exercism-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petertseng/exercism-rust/labels{/name}","releases_url":"https://api.github.com/repos/petertseng/exercism-rust/releases{/id}","deployments_url":"https://api.github.com/repos/petertseng/exercism-rust/deployments","created_at":"2016-03-05T07:40:56Z","updated_at":"2018-03-16T23:11:16Z","pushed_at":"2018-03-16T23:53:05Z","git_url":"git://github.com/petertseng/exercism-rust.git","ssh_url":"git@github.com:petertseng/exercism-rust.git","clone_url":"https://github.com/petertseng/exercism-rust.git","svn_url":"https://github.com/petertseng/exercism-rust","homepage":"http://exercism.io/languages/rust","size":852,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"aee3d5d9a7d22f20c082e7ed53d85ae287e97665","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17276332,"name":"rust","full_name":"exercism/rust","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/rust","description":"Exercism exercises in Rust.","fork":false,"url":"https://api.github.com/repos/exercism/rust","forks_url":"https://api.github.com/repos/exercism/rust/forks","keys_url":"https://api.github.com/repos/exercism/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/rust/teams","hooks_url":"https://api.github.com/repos/exercism/rust/hooks","issue_events_url":"https://api.github.com/repos/exercism/rust/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/rust/events","assignees_url":"https://api.github.com/repos/exercism/rust/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/rust/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/rust/tags","blobs_url":"https://api.github.com/repos/exercism/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/rust/languages","stargazers_url":"https://api.github.com/repos/exercism/rust/stargazers","contributors_url":"https://api.github.com/repos/exercism/rust/contributors","subscribers_url":"https://api.github.com/repos/exercism/rust/subscribers","subscription_url":"https://api.github.com/repos/exercism/rust/subscription","commits_url":"https://api.github.com/repos/exercism/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/rust/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/rust/merges","archive_url":"https://api.github.com/repos/exercism/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/rust/downloads","issues_url":"https://api.github.com/repos/exercism/rust/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/rust/labels{/name}","releases_url":"https://api.github.com/repos/exercism/rust/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/rust/deployments","created_at":"2014-02-28T05:33:52Z","updated_at":"2018-03-16T18:33:21Z","pushed_at":"2018-03-16T23:53:41Z","git_url":"git://github.com/exercism/rust.git","ssh_url":"git@github.com:exercism/rust.git","clone_url":"https://github.com/exercism/rust.git","svn_url":"https://github.com/exercism/rust","homepage":"http://exercism.io/languages/rust","size":817,"stargazers_count":195,"watchers_count":195,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":117,"open_issues":24,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/rust/pulls/471"},"html":{"href":"https://github.com/exercism/rust/pull/471"},"issue":{"href":"https://api.github.com/repos/exercism/rust/issues/471"},"comments":{"href":"https://api.github.com/repos/exercism/rust/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/rust/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/rust/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/rust/statuses/99f90448e642004c9b0d184f73749e5837c2acac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"petertseng"}}