{"action":"created","comment":{"url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/comments/195654290","pull_request_review_id":129066038,"id":195654290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTY1NDI5MA==","diff_hunk":"@@ -69,19 +69,26 @@ class ZR300 {\n   image_transport::CameraPublisher infrared_publisher_;\n   image_transport::CameraPublisher infrared_2_publisher_;\n   image_transport::CameraPublisher depth_publisher_;\n+\n+  // Used to publish color and depth camera info if depth and color is disabled\n+  // but pointclouds are enabled.\n+  ros::Publisher color_camera_info_publisher_;\n+  ros::Publisher depth_camera_info_publisher_;\n+\n   ros::Publisher imu_publisher_;\n   ros::Publisher pointcloud_publisher_;\n \n-  rs::extrinsics T_infrared_fisheye_;\n+  rs::extrinsics T_imu_fisheye_;\n+  rs::extrinsics T_fisheye_fisheye_;\n   sensor_msgs::CameraInfo fisheye_camera_info_;\n-  rs::extrinsics T_infrared_depth_;\n+  rs::extrinsics T_fisheye_depth_;","path":"include/maplab-realsense/zr300.h","position":18,"original_position":18,"commit_id":"77106a6c0b3a33c03a9bea532fed1ec5f8dfe3f5","original_commit_id":"77106a6c0b3a33c03a9bea532fed1ec5f8dfe3f5","user":{"login":"schneith","id":5337083,"node_id":"MDQ6VXNlcjUzMzcwODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5337083?v=4","gravatar_id":"","url":"https://api.github.com/users/schneith","html_url":"https://github.com/schneith","followers_url":"https://api.github.com/users/schneith/followers","following_url":"https://api.github.com/users/schneith/following{/other_user}","gists_url":"https://api.github.com/users/schneith/gists{/gist_id}","starred_url":"https://api.github.com/users/schneith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneith/subscriptions","organizations_url":"https://api.github.com/users/schneith/orgs","repos_url":"https://api.github.com/users/schneith/repos","events_url":"https://api.github.com/users/schneith/events{/privacy}","received_events_url":"https://api.github.com/users/schneith/received_events","type":"User","site_admin":false},"body":"is the infrared is captured on the fisheye camera?","created_at":"2018-06-15T07:39:35Z","updated_at":"2018-06-15T07:46:55Z","html_url":"https://github.com/ethz-asl/maplab_realsense/pull/4#discussion_r195654290","pull_request_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/comments/195654290"},"html":{"href":"https://github.com/ethz-asl/maplab_realsense/pull/4#discussion_r195654290"},"pull_request":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4","id":175400150,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1NDAwMTUw","html_url":"https://github.com/ethz-asl/maplab_realsense/pull/4","diff_url":"https://github.com/ethz-asl/maplab_realsense/pull/4.diff","patch_url":"https://github.com/ethz-asl/maplab_realsense/pull/4.patch","issue_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/4","number":4,"state":"open","locked":false,"title":"Fix tf tree, add IMU frame, enable publishing only fisheye + depth","user":{"login":"mfehr","id":5071588,"node_id":"MDQ6VXNlcjUwNzE1ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5071588?v=4","gravatar_id":"","url":"https://api.github.com/users/mfehr","html_url":"https://github.com/mfehr","followers_url":"https://api.github.com/users/mfehr/followers","following_url":"https://api.github.com/users/mfehr/following{/other_user}","gists_url":"https://api.github.com/users/mfehr/gists{/gist_id}","starred_url":"https://api.github.com/users/mfehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfehr/subscriptions","organizations_url":"https://api.github.com/users/mfehr/orgs","repos_url":"https://api.github.com/users/mfehr/repos","events_url":"https://api.github.com/users/mfehr/events{/privacy}","received_events_url":"https://api.github.com/users/mfehr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-15T22:55:10Z","updated_at":"2018-06-15T07:46:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e7d98b331193f8f35c89490cecbd44bbc9ccaa4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ffurrer","id":917816,"node_id":"MDQ6VXNlcjkxNzgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/917816?v=4","gravatar_id":"","url":"https://api.github.com/users/ffurrer","html_url":"https://github.com/ffurrer","followers_url":"https://api.github.com/users/ffurrer/followers","following_url":"https://api.github.com/users/ffurrer/following{/other_user}","gists_url":"https://api.github.com/users/ffurrer/gists{/gist_id}","starred_url":"https://api.github.com/users/ffurrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffurrer/subscriptions","organizations_url":"https://api.github.com/users/ffurrer/orgs","repos_url":"https://api.github.com/users/ffurrer/repos","events_url":"https://api.github.com/users/ffurrer/events{/privacy}","received_events_url":"https://api.github.com/users/ffurrer/received_events","type":"User","site_admin":false},{"login":"dymczykm","id":6044558,"node_id":"MDQ6VXNlcjYwNDQ1NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/6044558?v=4","gravatar_id":"","url":"https://api.github.com/users/dymczykm","html_url":"https://github.com/dymczykm","followers_url":"https://api.github.com/users/dymczykm/followers","following_url":"https://api.github.com/users/dymczykm/following{/other_user}","gists_url":"https://api.github.com/users/dymczykm/gists{/gist_id}","starred_url":"https://api.github.com/users/dymczykm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dymczykm/subscriptions","organizations_url":"https://api.github.com/users/dymczykm/orgs","repos_url":"https://api.github.com/users/dymczykm/repos","events_url":"https://api.github.com/users/dymczykm/events{/privacy}","received_events_url":"https://api.github.com/users/dymczykm/received_events","type":"User","site_admin":false},{"login":"fabianbl","id":14781925,"node_id":"MDQ6VXNlcjE0NzgxOTI1","avatar_url":"https://avatars2.githubusercontent.com/u/14781925?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianbl","html_url":"https://github.com/fabianbl","followers_url":"https://api.github.com/users/fabianbl/followers","following_url":"https://api.github.com/users/fabianbl/following{/other_user}","gists_url":"https://api.github.com/users/fabianbl/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianbl/subscriptions","organizations_url":"https://api.github.com/users/fabianbl/orgs","repos_url":"https://api.github.com/users/fabianbl/repos","events_url":"https://api.github.com/users/fabianbl/events{/privacy}","received_events_url":"https://api.github.com/users/fabianbl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/4/comments","statuses_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/statuses/77106a6c0b3a33c03a9bea532fed1ec5f8dfe3f5","head":{"label":"ethz-asl:feature/get_imu_to_camera_transform","ref":"feature/get_imu_to_camera_transform","sha":"77106a6c0b3a33c03a9bea532fed1ec5f8dfe3f5","user":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":112775441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NzU0NDE=","name":"maplab_realsense","full_name":"ethz-asl/maplab_realsense","owner":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/maplab_realsense","description":"Simple ROS wrapper for the Intel RealSense driver with a focus on the ZR300.","fork":false,"url":"https://api.github.com/repos/ethz-asl/maplab_realsense","forks_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/forks","keys_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/teams","hooks_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/events","assignees_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/tags","blobs_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/subscription","commits_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/merges","archive_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/downloads","issues_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/deployments","created_at":"2017-12-01T18:53:05Z","updated_at":"2018-06-12T09:55:51Z","pushed_at":"2018-06-14T10:32:37Z","git_url":"git://github.com/ethz-asl/maplab_realsense.git","ssh_url":"git@github.com:ethz-asl/maplab_realsense.git","clone_url":"https://github.com/ethz-asl/maplab_realsense.git","svn_url":"https://github.com/ethz-asl/maplab_realsense","homepage":"","size":59,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"ethz-asl:master","ref":"master","sha":"a1b7bc958f517f1ce137ea8a0dfbfae393d02d0f","user":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":112775441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NzU0NDE=","name":"maplab_realsense","full_name":"ethz-asl/maplab_realsense","owner":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/maplab_realsense","description":"Simple ROS wrapper for the Intel RealSense driver with a focus on the ZR300.","fork":false,"url":"https://api.github.com/repos/ethz-asl/maplab_realsense","forks_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/forks","keys_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/teams","hooks_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/events","assignees_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/tags","blobs_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/subscription","commits_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/merges","archive_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/downloads","issues_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/maplab_realsense/deployments","created_at":"2017-12-01T18:53:05Z","updated_at":"2018-06-12T09:55:51Z","pushed_at":"2018-06-14T10:32:37Z","git_url":"git://github.com/ethz-asl/maplab_realsense.git","ssh_url":"git@github.com:ethz-asl/maplab_realsense.git","clone_url":"https://github.com/ethz-asl/maplab_realsense.git","svn_url":"https://github.com/ethz-asl/maplab_realsense","homepage":"","size":59,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4"},"html":{"href":"https://github.com/ethz-asl/maplab_realsense/pull/4"},"issue":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/4"},"comments":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ethz-asl/maplab_realsense/statuses/77106a6c0b3a33c03a9bea532fed1ec5f8dfe3f5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"schneith"}}