{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/44","id":187586208,"html_url":"https://github.com/Clever/kinesis-to-firehose/pull/44","diff_url":"https://github.com/Clever/kinesis-to-firehose/pull/44.diff","patch_url":"https://github.com/Clever/kinesis-to-firehose/pull/44.patch","issue_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/44","number":44,"state":"closed","locked":false,"title":"Drop logs when behind","user":{"login":"xavi-","id":75434,"avatar_url":"https://avatars2.githubusercontent.com/u/75434?v=4","gravatar_id":"","url":"https://api.github.com/users/xavi-","html_url":"https://github.com/xavi-","followers_url":"https://api.github.com/users/xavi-/followers","following_url":"https://api.github.com/users/xavi-/following{/other_user}","gists_url":"https://api.github.com/users/xavi-/gists{/gist_id}","starred_url":"https://api.github.com/users/xavi-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavi-/subscriptions","organizations_url":"https://api.github.com/users/xavi-/orgs","repos_url":"https://api.github.com/users/xavi-/repos","events_url":"https://api.github.com/users/xavi-/events{/privacy}","received_events_url":"https://api.github.com/users/xavi-/received_events","type":"User","site_admin":false},"body":"When logs are delayed, the kinesis-to-firehose-log-search consumer will probabilistically drop logs based on their delay and log level.  The more the delayed the log, the more likely it is to be dropped.  Similarly, the lower the log level (ex: debug vs warning), the more likely it is to be dropped.\r\n\r\nLog with less than 2 minutes of delay are not dropped.\r\nLog with level \"critical\" are not dropped either.\r\n\r\nThis code also includes a go routine that logs stats about dropped logs every minute.\r\n\r\nFor more info:\r\nSpec: https://docs.google.com/document/d/1LXJVQwRDL7nnHxpc25BquaPUwNz03ryyofgjTlSiUWA/edit#\r\nJira: https://clever.atlassian.net/browse/INFRA-2961","created_at":"2018-05-11T22:51:10Z","updated_at":"2018-05-11T23:36:42Z","closed_at":"2018-05-11T23:36:42Z","merged_at":"2018-05-11T23:36:42Z","merge_commit_sha":"fd8cae28fcc3c067f59ad2b5aa0dd0e0bc6704db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alsmola","id":653310,"avatar_url":"https://avatars0.githubusercontent.com/u/653310?v=4","gravatar_id":"","url":"https://api.github.com/users/alsmola","html_url":"https://github.com/alsmola","followers_url":"https://api.github.com/users/alsmola/followers","following_url":"https://api.github.com/users/alsmola/following{/other_user}","gists_url":"https://api.github.com/users/alsmola/gists{/gist_id}","starred_url":"https://api.github.com/users/alsmola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alsmola/subscriptions","organizations_url":"https://api.github.com/users/alsmola/orgs","repos_url":"https://api.github.com/users/alsmola/repos","events_url":"https://api.github.com/users/alsmola/events{/privacy}","received_events_url":"https://api.github.com/users/alsmola/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/44/comments","statuses_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/statuses/c6207831c6d270f40f707702db59f1ae7fcc1d39","head":{"label":"Clever:drop-logs-when-behind","ref":"drop-logs-when-behind","sha":"c6207831c6d270f40f707702db59f1ae7fcc1d39","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":85356601,"name":"kinesis-to-firehose","full_name":"Clever/kinesis-to-firehose","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/kinesis-to-firehose","description":"Consumes records from Kinesis and writes to Firehose","fork":false,"url":"https://api.github.com/repos/Clever/kinesis-to-firehose","forks_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/forks","keys_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/teams","hooks_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/hooks","issue_events_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/events","assignees_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/tags","blobs_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/languages","stargazers_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/stargazers","contributors_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/contributors","subscribers_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/subscribers","subscription_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/subscription","commits_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/merges","archive_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/downloads","issues_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/labels{/name}","releases_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/deployments","created_at":"2017-03-17T21:35:48Z","updated_at":"2018-05-09T23:39:58Z","pushed_at":"2018-05-11T23:36:42Z","git_url":"git://github.com/Clever/kinesis-to-firehose.git","ssh_url":"git@github.com:Clever/kinesis-to-firehose.git","clone_url":"https://github.com/Clever/kinesis-to-firehose.git","svn_url":"https://github.com/Clever/kinesis-to-firehose","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Clever:master","ref":"master","sha":"53f466793b43dd0931cf6a5e3f48879afe5bd305","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":85356601,"name":"kinesis-to-firehose","full_name":"Clever/kinesis-to-firehose","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/kinesis-to-firehose","description":"Consumes records from Kinesis and writes to Firehose","fork":false,"url":"https://api.github.com/repos/Clever/kinesis-to-firehose","forks_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/forks","keys_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/teams","hooks_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/hooks","issue_events_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/events","assignees_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/tags","blobs_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/languages","stargazers_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/stargazers","contributors_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/contributors","subscribers_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/subscribers","subscription_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/subscription","commits_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/merges","archive_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/downloads","issues_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/labels{/name}","releases_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/kinesis-to-firehose/deployments","created_at":"2017-03-17T21:35:48Z","updated_at":"2018-05-09T23:39:58Z","pushed_at":"2018-05-11T23:36:42Z","git_url":"git://github.com/Clever/kinesis-to-firehose.git","ssh_url":"git@github.com:Clever/kinesis-to-firehose.git","clone_url":"https://github.com/Clever/kinesis-to-firehose.git","svn_url":"https://github.com/Clever/kinesis-to-firehose","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/44"},"html":{"href":"https://github.com/Clever/kinesis-to-firehose/pull/44"},"issue":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/44"},"comments":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Clever/kinesis-to-firehose/statuses/c6207831c6d270f40f707702db59f1ae7fcc1d39"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"xavi-","id":75434,"avatar_url":"https://avatars2.githubusercontent.com/u/75434?v=4","gravatar_id":"","url":"https://api.github.com/users/xavi-","html_url":"https://github.com/xavi-","followers_url":"https://api.github.com/users/xavi-/followers","following_url":"https://api.github.com/users/xavi-/following{/other_user}","gists_url":"https://api.github.com/users/xavi-/gists{/gist_id}","starred_url":"https://api.github.com/users/xavi-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavi-/subscriptions","organizations_url":"https://api.github.com/users/xavi-/orgs","repos_url":"https://api.github.com/users/xavi-/repos","events_url":"https://api.github.com/users/xavi-/events{/privacy}","received_events_url":"https://api.github.com/users/xavi-/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":11,"additions":211,"deletions":65,"changed_files":7}}
{"actor":{"display_login":"xavi-"}}