{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/server/pulls/comments/234754954","pull_request_review_id":176464585,"id":234754954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc1NDk1NA==","diff_hunk":"@@ -0,0 +1,148 @@\n+<?php\n+declare(strict_types=1);\n+/**\n+ * @copyright Copyright (c) 2018, ownCloud, Inc.","path":"lib/private/Net/AbstractIpAddress.php","position":4,"original_position":4,"commit_id":"29488ec0d8d2d7259154aa74bcaf8318b8d5e50a","original_commit_id":"29488ec0d8d2d7259154aa74bcaf8318b8d5e50a","user":{"login":"olivermg","id":986278,"node_id":"MDQ6VXNlcjk4NjI3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/986278?v=4","gravatar_id":"","url":"https://api.github.com/users/olivermg","html_url":"https://github.com/olivermg","followers_url":"https://api.github.com/users/olivermg/followers","following_url":"https://api.github.com/users/olivermg/following{/other_user}","gists_url":"https://api.github.com/users/olivermg/gists{/gist_id}","starred_url":"https://api.github.com/users/olivermg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivermg/subscriptions","organizations_url":"https://api.github.com/users/olivermg/orgs","repos_url":"https://api.github.com/users/olivermg/repos","events_url":"https://api.github.com/users/olivermg/events{/privacy}","received_events_url":"https://api.github.com/users/olivermg/received_events","type":"User","site_admin":false},"body":"Okay, I'll adjust this","created_at":"2018-11-19T19:39:24Z","updated_at":"2018-11-19T19:39:25Z","html_url":"https://github.com/nextcloud/server/pull/12535#discussion_r234754954","pull_request_url":"https://api.github.com/repos/nextcloud/server/pulls/12535","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments/234754954"},"html":{"href":"https://github.com/nextcloud/server/pull/12535#discussion_r234754954"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12535"}},"in_reply_to_id":234703724},"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/12535","id":232040381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDQwMzgx","html_url":"https://github.com/nextcloud/server/pull/12535","diff_url":"https://github.com/nextcloud/server/pull/12535.diff","patch_url":"https://github.com/nextcloud/server/pull/12535.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/12535","number":12535,"state":"open","locked":false,"title":"Implementing trusted_proxies CIDR notation capability for IPv6","user":{"login":"olivermg","id":986278,"node_id":"MDQ6VXNlcjk4NjI3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/986278?v=4","gravatar_id":"","url":"https://api.github.com/users/olivermg","html_url":"https://github.com/olivermg","followers_url":"https://api.github.com/users/olivermg/followers","following_url":"https://api.github.com/users/olivermg/following{/other_user}","gists_url":"https://api.github.com/users/olivermg/gists{/gist_id}","starred_url":"https://api.github.com/users/olivermg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivermg/subscriptions","organizations_url":"https://api.github.com/users/olivermg/orgs","repos_url":"https://api.github.com/users/olivermg/repos","events_url":"https://api.github.com/users/olivermg/events{/privacy}","received_events_url":"https://api.github.com/users/olivermg/received_events","type":"User","site_admin":false},"body":"This PR aims to enhance the capabilities for specifying IP addresses in CIDR notation in the `trusted_proxies` config param (refer to issue #6550 and PR #12036 for more info):\r\n\r\n- implement CIDR notation for IPv6\r\n- introduce an abstraction layer for representation of IP addresses/ranges and CIDR notation handling, so other classes than just `Request` might benefit in the future\r\n- update `config.sample.php` to reflect the new capabilities","created_at":"2018-11-19T16:43:31Z","updated_at":"2018-11-19T19:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7165b10de3278a97c1fd2548603ce29299c881a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rullzer","id":45821,"node_id":"MDQ6VXNlcjQ1ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/45821?v=4","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},{"login":"nickvergessen","id":213943,"node_id":"MDQ6VXNlcjIxMzk0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/213943?v=4","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},{"login":"MorrisJobke","id":245432,"node_id":"MDQ6VXNlcjI0NTQzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/245432?v=4","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":389003733,"node_id":"MDU6TGFiZWwzODkwMDM3MzM=","url":"https://api.github.com/repos/nextcloud/server/labels/3.%20to%20review","name":"3. to review","color":"0052cc","default":false},{"id":386379233,"node_id":"MDU6TGFiZWwzODYzNzkyMzM=","url":"https://api.github.com/repos/nextcloud/server/labels/enhancement","name":"enhancement","color":"0e8a16","default":true}],"milestone":{"url":"https://api.github.com/repos/nextcloud/server/milestones/59","html_url":"https://github.com/nextcloud/server/milestone/59","labels_url":"https://api.github.com/repos/nextcloud/server/milestones/59/labels","id":3749267,"node_id":"MDk6TWlsZXN0b25lMzc0OTI2Nw==","number":59,"title":"Nextcloud 16","description":null,"creator":{"login":"jancborchardt","id":925062,"node_id":"MDQ6VXNlcjkyNTA2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/925062?v=4","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"open_issues":93,"closed_issues":0,"state":"open","created_at":"2018-10-18T12:54:37Z","updated_at":"2018-11-19T17:04:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/12535/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/12535/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/12535/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/29488ec0d8d2d7259154aa74bcaf8318b8d5e50a","head":{"label":"nextcloud:feature/6550/trusted-proxies-ipv6-cidr","ref":"feature/6550/trusted-proxies-ipv6-cidr","sha":"29488ec0d8d2d7259154aa74bcaf8318b8d5e50a","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-11-19T15:06:06Z","pushed_at":"2018-11-19T19:19:57Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":333873,"stargazers_count":5766,"watchers_count":5766,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1018,"mirror_url":null,"archived":false,"open_issues_count":1595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1018,"open_issues":1595,"watchers":5766,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"1d8f7e7806aaa05daca39a98c174e4eff04e3e36","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-11-19T15:06:06Z","pushed_at":"2018-11-19T19:19:57Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":333873,"stargazers_count":5766,"watchers_count":5766,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1018,"mirror_url":null,"archived":false,"open_issues_count":1595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1018,"open_issues":1595,"watchers":5766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12535"},"html":{"href":"https://github.com/nextcloud/server/pull/12535"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/12535"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/12535/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12535/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12535/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/29488ec0d8d2d7259154aa74bcaf8318b8d5e50a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"olivermg"}}