{"action":"created","comment":{"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/comments/243743024","pull_request_review_id":187599338,"id":243743024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc0MzAyNA==","diff_hunk":"@@ -61,4 +61,22 @@ public function registerContainerConfiguration(LoaderInterface $loader)\n             ]);\n         });\n     }\n+\n+    public function getCacheDir()\n+    {\n+        if (method_exists($this, 'getProjectDir')) {\n+            return $this->getProjectDir() . '/tests/app/cache/' . $this->getEnvironment();\n+        }\n+\n+        return parent::getCacheDir();\n+    }\n+\n+    public function getLogDir()\n+    {\n+        if (method_exists($this, 'getProjectDir')) {\n+            return $this->getProjectDir() . '/tests/app/cache/' . $this->getEnvironment();\n+        }\n+\n+        return parent::getLogDir();\n+    }","path":"tests/app/TestKernel.php","position":21,"original_position":21,"commit_id":"a2d0ae9ba3c6897170c58ca67a8a6993036d6fd9","original_commit_id":"a2d0ae9ba3c6897170c58ca67a8a6993036d6fd9","user":{"login":"weaverryan","id":121003,"node_id":"MDQ6VXNlcjEyMTAwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/121003?v=4","gravatar_id":"","url":"https://api.github.com/users/weaverryan","html_url":"https://github.com/weaverryan","followers_url":"https://api.github.com/users/weaverryan/followers","following_url":"https://api.github.com/users/weaverryan/following{/other_user}","gists_url":"https://api.github.com/users/weaverryan/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverryan/subscriptions","organizations_url":"https://api.github.com/users/weaverryan/orgs","repos_url":"https://api.github.com/users/weaverryan/repos","events_url":"https://api.github.com/users/weaverryan/events{/privacy}","received_events_url":"https://api.github.com/users/weaverryan/received_events","type":"User","site_admin":false},"body":"I assume this fixes some deprecation? Can you explain a bit more?","created_at":"2018-12-22T18:18:56Z","updated_at":"2018-12-22T18:20:02Z","html_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/151#discussion_r243743024","pull_request_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/comments/243743024"},"html":{"href":"https://github.com/knpuniversity/oauth2-client-bundle/pull/151#discussion_r243743024"},"pull_request":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151","id":238772220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzcyMjIw","html_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/151","diff_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/151.diff","patch_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/151.patch","issue_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/151","number":151,"state":"open","locked":false,"title":"added ability to configure default http_client","user":{"login":"sadikoff","id":213810,"node_id":"MDQ6VXNlcjIxMzgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/213810?v=4","gravatar_id":"","url":"https://api.github.com/users/sadikoff","html_url":"https://github.com/sadikoff","followers_url":"https://api.github.com/users/sadikoff/followers","following_url":"https://api.github.com/users/sadikoff/following{/other_user}","gists_url":"https://api.github.com/users/sadikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sadikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadikoff/subscriptions","organizations_url":"https://api.github.com/users/sadikoff/orgs","repos_url":"https://api.github.com/users/sadikoff/repos","events_url":"https://api.github.com/users/sadikoff/events{/privacy}","received_events_url":"https://api.github.com/users/sadikoff/received_events","type":"User","site_admin":false},"body":"Added to config new options\r\n```yaml\r\nhttp_client_options:\r\n    timeout: '30' # seconds \r\n    proxy: 'proxy_url' # proxy url string\r\n    verify: true|false # verify or not ssl certificate\r\n```\r\n\r\nFixed some bugs\r\n* symfony 4.2 deprecation\r\n* wrong cache & log dirs in tests\r\n* missed `%s` in `InvalidConfigurationException` message","created_at":"2018-12-14T16:19:23Z","updated_at":"2018-12-22T18:20:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec3651da2fcf2f06249d3622401039ea037b380e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151/commits","review_comments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151/comments","review_comment_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/151/comments","statuses_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/statuses/a2d0ae9ba3c6897170c58ca67a8a6993036d6fd9","head":{"label":"knpuniversity:issue_145","ref":"issue_145","sha":"a2d0ae9ba3c6897170c58ca67a8a6993036d6fd9","user":{"login":"knpuniversity","id":4474785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzQ3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/4474785?v=4","gravatar_id":"","url":"https://api.github.com/users/knpuniversity","html_url":"https://github.com/knpuniversity","followers_url":"https://api.github.com/users/knpuniversity/followers","following_url":"https://api.github.com/users/knpuniversity/following{/other_user}","gists_url":"https://api.github.com/users/knpuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/knpuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knpuniversity/subscriptions","organizations_url":"https://api.github.com/users/knpuniversity/orgs","repos_url":"https://api.github.com/users/knpuniversity/repos","events_url":"https://api.github.com/users/knpuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/knpuniversity/received_events","type":"Organization","site_admin":false},"repo":{"id":45807205,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNzIwNQ==","name":"oauth2-client-bundle","full_name":"knpuniversity/oauth2-client-bundle","private":false,"owner":{"login":"knpuniversity","id":4474785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzQ3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/4474785?v=4","gravatar_id":"","url":"https://api.github.com/users/knpuniversity","html_url":"https://github.com/knpuniversity","followers_url":"https://api.github.com/users/knpuniversity/followers","following_url":"https://api.github.com/users/knpuniversity/following{/other_user}","gists_url":"https://api.github.com/users/knpuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/knpuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knpuniversity/subscriptions","organizations_url":"https://api.github.com/users/knpuniversity/orgs","repos_url":"https://api.github.com/users/knpuniversity/repos","events_url":"https://api.github.com/users/knpuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/knpuniversity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knpuniversity/oauth2-client-bundle","description":"Easily talk to an OAuth2 server for social functionality in Symfony","fork":false,"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle","forks_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/forks","keys_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/teams","hooks_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/hooks","issue_events_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/events","assignees_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/tags","blobs_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/languages","stargazers_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/stargazers","contributors_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/contributors","subscribers_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/subscribers","subscription_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/subscription","commits_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/merges","archive_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/downloads","issues_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/labels{/name}","releases_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/deployments","created_at":"2015-11-09T01:13:02Z","updated_at":"2018-12-21T10:05:20Z","pushed_at":"2018-12-14T16:29:08Z","git_url":"git://github.com/knpuniversity/oauth2-client-bundle.git","ssh_url":"git@github.com:knpuniversity/oauth2-client-bundle.git","clone_url":"https://github.com/knpuniversity/oauth2-client-bundle.git","svn_url":"https://github.com/knpuniversity/oauth2-client-bundle","homepage":"","size":352,"stargazers_count":233,"watchers_count":233,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":13,"watchers":233,"default_branch":"master"}},"base":{"label":"knpuniversity:master","ref":"master","sha":"d570bbd464e2cbacc04687754e5479b17ad519d8","user":{"login":"knpuniversity","id":4474785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzQ3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/4474785?v=4","gravatar_id":"","url":"https://api.github.com/users/knpuniversity","html_url":"https://github.com/knpuniversity","followers_url":"https://api.github.com/users/knpuniversity/followers","following_url":"https://api.github.com/users/knpuniversity/following{/other_user}","gists_url":"https://api.github.com/users/knpuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/knpuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knpuniversity/subscriptions","organizations_url":"https://api.github.com/users/knpuniversity/orgs","repos_url":"https://api.github.com/users/knpuniversity/repos","events_url":"https://api.github.com/users/knpuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/knpuniversity/received_events","type":"Organization","site_admin":false},"repo":{"id":45807205,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNzIwNQ==","name":"oauth2-client-bundle","full_name":"knpuniversity/oauth2-client-bundle","private":false,"owner":{"login":"knpuniversity","id":4474785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzQ3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/4474785?v=4","gravatar_id":"","url":"https://api.github.com/users/knpuniversity","html_url":"https://github.com/knpuniversity","followers_url":"https://api.github.com/users/knpuniversity/followers","following_url":"https://api.github.com/users/knpuniversity/following{/other_user}","gists_url":"https://api.github.com/users/knpuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/knpuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knpuniversity/subscriptions","organizations_url":"https://api.github.com/users/knpuniversity/orgs","repos_url":"https://api.github.com/users/knpuniversity/repos","events_url":"https://api.github.com/users/knpuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/knpuniversity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knpuniversity/oauth2-client-bundle","description":"Easily talk to an OAuth2 server for social functionality in Symfony","fork":false,"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle","forks_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/forks","keys_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/teams","hooks_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/hooks","issue_events_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/events","assignees_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/tags","blobs_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/languages","stargazers_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/stargazers","contributors_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/contributors","subscribers_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/subscribers","subscription_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/subscription","commits_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/merges","archive_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/downloads","issues_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/labels{/name}","releases_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/deployments","created_at":"2015-11-09T01:13:02Z","updated_at":"2018-12-21T10:05:20Z","pushed_at":"2018-12-14T16:29:08Z","git_url":"git://github.com/knpuniversity/oauth2-client-bundle.git","ssh_url":"git@github.com:knpuniversity/oauth2-client-bundle.git","clone_url":"https://github.com/knpuniversity/oauth2-client-bundle.git","svn_url":"https://github.com/knpuniversity/oauth2-client-bundle","homepage":"","size":352,"stargazers_count":233,"watchers_count":233,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":13,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151"},"html":{"href":"https://github.com/knpuniversity/oauth2-client-bundle/pull/151"},"issue":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/151"},"comments":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/statuses/a2d0ae9ba3c6897170c58ca67a8a6993036d6fd9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"weaverryan"}}