{"action":"created","issue":{"url":"https://api.github.com/repos/mherrmann/fbs/issues/33","repository_url":"https://api.github.com/repos/mherrmann/fbs","labels_url":"https://api.github.com/repos/mherrmann/fbs/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/mherrmann/fbs/issues/33/comments","events_url":"https://api.github.com/repos/mherrmann/fbs/issues/33/events","html_url":"https://github.com/mherrmann/fbs/issues/33","id":366747327,"node_id":"MDU6SXNzdWUzNjY3NDczMjc=","number":33,"title":"Problem building installer (following the tutorial)","user":{"login":"hellbe","id":4107500,"node_id":"MDQ6VXNlcjQxMDc1MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4107500?v=4","gravatar_id":"","url":"https://api.github.com/users/hellbe","html_url":"https://github.com/hellbe","followers_url":"https://api.github.com/users/hellbe/followers","following_url":"https://api.github.com/users/hellbe/following{/other_user}","gists_url":"https://api.github.com/users/hellbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hellbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellbe/subscriptions","organizations_url":"https://api.github.com/users/hellbe/orgs","repos_url":"https://api.github.com/users/hellbe/repos","events_url":"https://api.github.com/users/hellbe/events{/privacy}","received_events_url":"https://api.github.com/users/hellbe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-04T11:35:33Z","updated_at":"2018-10-04T14:35:36Z","closed_at":null,"author_association":"NONE","body":"Followed tutorial to the point. \r\n\r\n- Windows 10\r\n- Python 3.6 x64\r\n- NSIS 3.03\r\n\r\n**Output:**\r\n```\r\n(venv) C:\\Users\\myuser\\code\\testapp>python -m fbs installer\r\nProcessing config: C:\\Program Files (x86)\\NSIS\\nsisconf.nsh\r\nProcessing script file: \"Installer.nsi\" (ACP)\r\nFile: \"..\\TestApp\\*\" -> no files found.\r\nUsage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |\r\n   /oname=outfile one_file_only)\r\nError in script \"Installer.nsi\" on line 70 -- aborting creation process\r\nTraceback (most recent call last):\r\n  File \"c:\\users\\myuser\\appdata\\local\\programs\\python\\python36\\Lib\\runpy.py\", line 193, in _run_module_as_main\r\n    \"__main__\", mod_spec)\r\n  File \"c:\\users\\myuser\\appdata\\local\\programs\\python\\python36\\Lib\\runpy.py\", line 85, in _run_code\r\n    exec(code, run_globals)\r\n  File \"C:\\Users\\myuser\\code\\testapp\\venv\\lib\\site-packages\\fbs\\__main__.py\", line 4, in <module>\r\n    main()\r\n  File \"C:\\Users\\myuser\\code\\testapp\\venv\\lib\\site-packages\\fbs\\cmdline.py\", line 25, in main\r\n    args.fn(*fn_args)\r\n  File \"C:\\Users\\myuser\\code\\testapp\\venv\\lib\\site-packages\\fbs\\builtin_commands\\__init__.py\", line 94, in installer\r\n    create_installer_windows()\r\n  File \"C:\\Users\\myuser\\code\\testapp\\venv\\lib\\site-packages\\fbs\\installer\\windows.py\", line 19, in create_installer_windows\r\n    run(['makensis', 'Installer.nsi'], cwd=path('target/NSIS'), check=True)\r\n  File \"c:\\users\\myuser\\appdata\\local\\programs\\python\\python36\\Lib\\subprocess.py\", line 418, in run\r\n    output=stdout, stderr=stderr)\r\nsubprocess.CalledProcessError: Command '['makensis', 'Installer.nsi']' returned non-zero exit status 1.\r\n```\r\n\r\n**Installer.nsi:**\r\n```\r\n!include MUI2.nsh\r\n!include FileFunc.nsh\r\n\r\n;--------------------------------\r\n;Perform Machine-level install, if possible\r\n\r\n!define MULTIUSER_EXECUTIONLEVEL Highest\r\n;Add support for command-line args that let uninstaller know whether to\r\n;uninstall machine- or user installation:\r\n!define MULTIUSER_INSTALLMODE_COMMANDLINE\r\n!include MultiUser.nsh\r\n!include LogicLib.nsh\r\n\r\nFunction .onInit\r\n  !insertmacro MULTIUSER_INIT\r\n  ;Do not use InstallDir at all so we can detect empty $InstDir!\r\n  ${If} $InstDir == \"\" ; /D not used\r\n      ${If} $MultiUser.InstallMode == \"AllUsers\"\r\n          StrCpy $InstDir \"$PROGRAMFILES\\TestApp\"\r\n      ${Else}\r\n          StrCpy $InstDir \"$LOCALAPPDATA\\TestApp\"\r\n      ${EndIf}\r\n  ${EndIf}\r\nFunctionEnd\r\n\r\nFunction un.onInit\r\n  !insertmacro MULTIUSER_UNINIT\r\nFunctionEnd\r\n\r\n;--------------------------------\r\n;General\r\n\r\n  Name \"TestApp\"\r\n  OutFile \"..\\TestAppSetup.exe\"\r\n\r\n;--------------------------------\r\n;Interface Settings\r\n\r\n  !define MUI_ABORTWARNING\r\n\r\n;--------------------------------\r\n;Pages\r\n\r\n  !define MUI_WELCOMEPAGE_TEXT \"This wizard will guide you through the installation of TestApp.$\\r$\\n$\\r$\\n$\\r$\\nClick Next to continue.\"\r\n  !insertmacro MUI_PAGE_WELCOME\r\n  !insertmacro MUI_PAGE_DIRECTORY\r\n  !insertmacro MUI_PAGE_INSTFILES\r\n    !define MUI_FINISHPAGE_NOAUTOCLOSE\r\n    !define MUI_FINISHPAGE_RUN\r\n    !define MUI_FINISHPAGE_RUN_CHECKED\r\n    !define MUI_FINISHPAGE_RUN_TEXT \"Run TestApp\"\r\n    !define MUI_FINISHPAGE_RUN_FUNCTION \"LaunchLink\"\r\n  !insertmacro MUI_PAGE_FINISH\r\n\r\n  !insertmacro MUI_UNPAGE_CONFIRM\r\n  !insertmacro MUI_UNPAGE_INSTFILES\r\n\r\n;--------------------------------\r\n;Languages\r\n\r\n  !insertmacro MUI_LANGUAGE \"English\"\r\n\r\n;--------------------------------\r\n;Installer Sections\r\n\r\n!define UNINST_KEY \\\r\n  \"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\TestApp\"\r\nSection\r\n  SetOutPath \"$InstDir\"\r\n  File /r \"..\\TestApp\\*\"\r\n  WriteRegStr SHCTX \"Software\\TestApp\" \"\" $InstDir\r\n  WriteUninstaller \"$InstDir\\uninstall.exe\"\r\n  CreateShortCut \"$SMPROGRAMS\\TestApp.lnk\" \"$InstDir\\TestApp.exe\"\r\n  WriteRegStr SHCTX \"${UNINST_KEY}\" \"DisplayName\" \"TestApp\"\r\n  WriteRegStr SHCTX \"${UNINST_KEY}\" \"UninstallString\" \\\r\n    \"$\\\"$InstDir\\uninstall.exe$\\\" /$MultiUser.InstallMode\"\r\n  WriteRegStr SHCTX \"${UNINST_KEY}\" \"QuietUninstallString\" \\\r\n    \"$\\\"$InstDir\\uninstall.exe$\\\" /$MultiUser.InstallMode /S\"\r\n  WriteRegStr SHCTX \"${UNINST_KEY}\" \"Publisher\" \"Simon Hellbe\"\r\n  ${GetSize} \"$InstDir\" \"/S=0K\" $0 $1 $2\r\n  IntFmt $0 \"0x%08X\" $0\r\n  WriteRegDWORD SHCTX \"${UNINST_KEY}\" \"EstimatedSize\" \"$0\"\r\n\r\nSectionEnd\r\n\r\n;--------------------------------\r\n;Uninstaller Section\r\n\r\nSection \"Uninstall\"\r\n\r\n  RMDir /r \"$InstDir\"\r\n  Delete \"$SMPROGRAMS\\TestApp.lnk\"\r\n  DeleteRegKey /ifempty SHCTX \"Software\\TestApp\"\r\n  DeleteRegKey SHCTX \"${UNINST_KEY}\"\r\n\r\nSectionEnd\r\n\r\nFunction LaunchLink\r\n  !addplugindir \".\"\r\n  ShellExecAsUser::ShellExecAsUser \"open\" \"$SMPROGRAMS\\TestApp.lnk\"\r\nFunctionEnd\r\n```"},"comment":{"url":"https://api.github.com/repos/mherrmann/fbs/issues/comments/427042976","html_url":"https://github.com/mherrmann/fbs/issues/33#issuecomment-427042976","issue_url":"https://api.github.com/repos/mherrmann/fbs/issues/33","id":427042976,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzA0Mjk3Ng==","user":{"login":"hellbe","id":4107500,"node_id":"MDQ6VXNlcjQxMDc1MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4107500?v=4","gravatar_id":"","url":"https://api.github.com/users/hellbe","html_url":"https://github.com/hellbe","followers_url":"https://api.github.com/users/hellbe/followers","following_url":"https://api.github.com/users/hellbe/following{/other_user}","gists_url":"https://api.github.com/users/hellbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hellbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellbe/subscriptions","organizations_url":"https://api.github.com/users/hellbe/orgs","repos_url":"https://api.github.com/users/hellbe/repos","events_url":"https://api.github.com/users/hellbe/events{/privacy}","received_events_url":"https://api.github.com/users/hellbe/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T14:35:36Z","updated_at":"2018-10-04T14:35:36Z","author_association":"NONE","body":"New error:\r\n```\r\n....\r\n....\r\n[17992] LOADER: Running main.py\r\nTraceback (most recent call last):\r\n  File \"site-packages\\fbs_runtime\\_signal.py\", line 2, in <module>\r\n  File \"c:\\users\\sihel7\\code\\testapp\\venv\\lib\\site-packages\\PyInstaller\\loader\\pyimod03_importers.py\", line 714, in load_module\r\n    module = loader.load_module(fullname)\r\nImportError: No module named 'PyQt5.sip'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"main.py\", line 1, in <module>\r\n  File \"c:\\users\\sihel7\\code\\testapp\\venv\\lib\\site-packages\\PyInstaller\\loader\\pyimod03_importers.py\", line 631, in exec_module\r\n    exec(bytecode, module.__dict__)\r\n  File \"site-packages\\fbs_runtime\\application_context.py\", line 2, in <module>\r\n  File \"c:\\users\\sihel7\\code\\testapp\\venv\\lib\\site-packages\\PyInstaller\\loader\\pyimod03_importers.py\", line 631, in exec_module\r\n    exec(bytecode, module.__dict__)\r\n  File \"site-packages\\fbs_runtime\\_signal.py\", line 4, in <module>\r\nImportError: No module named 'PySide2'\r\n[17992] Failed to execute script main\r\n[17992] LOADER: OK.\r\n[17992] LOADER: Cleaning up Python interpreter.\r\n```"}}
{"actor":{"display_login":"hellbe"}}