{"action":"created","comment":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/comments/192764928","pull_request_review_id":125603240,"id":192764928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc2NDkyOA==","diff_hunk":"@@ -0,0 +1,21 @@\n+import { colours, fonts, fontSizes } from \"@times-components/styleguide\";\n+\n+const styles = {\n+  button: {\n+    alignItems: \"center\",\n+    backgroundColor: colours.functional.action,\n+    borderRadius: 2,\n+    height: 45,\n+    justifyContent: \"center\",\n+    minWidth: 100,\n+    width: \"100%\"\n+  },\n+  textStyle: {\n+    color: \"#FFF\",\n+    fontFamily: fonts.supporting,\n+    fontSize: fontSizes.button,\n+    paddingTop: 5","path":"packages/button/src/styles/shared.js","position":17,"original_position":17,"commit_id":"e6540ec8d13c277a47cb28e1b5e09a41fc1ce240","original_commit_id":"e6540ec8d13c277a47cb28e1b5e09a41fc1ce240","user":{"login":"aronshamash","id":1736782,"node_id":"MDQ6VXNlcjE3MzY3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1736782?v=4","gravatar_id":"","url":"https://api.github.com/users/aronshamash","html_url":"https://github.com/aronshamash","followers_url":"https://api.github.com/users/aronshamash/followers","following_url":"https://api.github.com/users/aronshamash/following{/other_user}","gists_url":"https://api.github.com/users/aronshamash/gists{/gist_id}","starred_url":"https://api.github.com/users/aronshamash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronshamash/subscriptions","organizations_url":"https://api.github.com/users/aronshamash/orgs","repos_url":"https://api.github.com/users/aronshamash/repos","events_url":"https://api.github.com/users/aronshamash/events{/privacy}","received_events_url":"https://api.github.com/users/aronshamash/received_events","type":"User","site_admin":false},"body":"`spacing(1)`","created_at":"2018-06-04T14:41:25Z","updated_at":"2018-06-04T14:43:08Z","html_url":"https://github.com/newsuk/times-components/pull/978#discussion_r192764928","pull_request_url":"https://api.github.com/repos/newsuk/times-components/pulls/978","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments/192764928"},"html":{"href":"https://github.com/newsuk/times-components/pull/978#discussion_r192764928"},"pull_request":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/978"}}},"pull_request":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/978","id":191466656,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDY2NjU2","html_url":"https://github.com/newsuk/times-components/pull/978","diff_url":"https://github.com/newsuk/times-components/pull/978.diff","patch_url":"https://github.com/newsuk/times-components/pull/978.patch","issue_url":"https://api.github.com/repos/newsuk/times-components/issues/978","number":978,"state":"open","locked":false,"title":"feat: add button package to article list error states","user":{"login":"colincclark","id":5456015,"node_id":"MDQ6VXNlcjU0NTYwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5456015?v=4","gravatar_id":"","url":"https://api.github.com/users/colincclark","html_url":"https://github.com/colincclark","followers_url":"https://api.github.com/users/colincclark/followers","following_url":"https://api.github.com/users/colincclark/following{/other_user}","gists_url":"https://api.github.com/users/colincclark/gists{/gist_id}","starred_url":"https://api.github.com/users/colincclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colincclark/subscriptions","organizations_url":"https://api.github.com/users/colincclark/orgs","repos_url":"https://api.github.com/users/colincclark/repos","events_url":"https://api.github.com/users/colincclark/events{/privacy}","received_events_url":"https://api.github.com/users/colincclark/received_events","type":"User","site_admin":false},"body":"- added `button` package (android has a drop shadow)\r\n- moved the android letter spacing hack to `utils` so it can be reused (until removed in the `react-native` upgrade)\r\n- added `article-list` package button layout\r\n- `button` stories, tests and layout from design review\r\n- remove `selectV2` as explicit import as it is included in react storybook knobs now\r\n\r\nNote: this is part of https://nidigitalsolutions.jira.com/browse/REPLAT-2571\r\n\r\nNext steps are adding an onPress and \"visited\" state for the button, and fix the rest of the article list error page layout on native, after getting the error image to work\r\n\r\n## SCREENSHOTS\r\n\r\n### Android\r\n\r\n<img width=\"186\" alt=\"android\" src=\"https://user-images.githubusercontent.com/5456015/40726198-270f0aa4-641d-11e8-850a-70c128ce1c77.png\">\r\n\r\n### iOS\r\n\r\n<img width=\"162\" alt=\"ios\" src=\"https://user-images.githubusercontent.com/5456015/40726219-33b7c7e6-641d-11e8-9ff9-6b3c176a4202.png\">\r\n<img width=\"286\" alt=\"ios-in-action\" src=\"https://user-images.githubusercontent.com/5456015/40726227-388c6c54-641d-11e8-8cb3-53be7e4370a5.png\">\r\n\r\n### Web\r\n\r\n<img width=\"207\" alt=\"web\" src=\"https://user-images.githubusercontent.com/5456015/40726247-411c83ea-641d-11e8-9b31-6d67673cac70.png\">\r\n<img width=\"569\" alt=\"web-in-action\" src=\"https://user-images.githubusercontent.com/5456015/40726255-4540e51a-641d-11e8-8520-ee67ceca4996.png\">\r\n\r\n\r\n","created_at":"2018-05-30T14:09:51Z","updated_at":"2018-06-04T14:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ad0daab172809057f0311ecc99812e6e776e0dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-components/pulls/978/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-components/pulls/978/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-components/issues/978/comments","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/e6540ec8d13c277a47cb28e1b5e09a41fc1ce240","head":{"label":"newsuk:fix/article-list-error-styling","ref":"fix/article-list-error-styling","sha":"e6540ec8d13c277a47cb28e1b5e09a41fc1ce240","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-06-04T12:39:45Z","pushed_at":"2018-06-04T13:49:36Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":46845,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":9,"open_issues":18,"watchers":63,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"075e64a707091b4916ffba29ed773cfb7d8263cd","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-06-04T12:39:45Z","pushed_at":"2018-06-04T13:49:36Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":46845,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":9,"open_issues":18,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/978"},"html":{"href":"https://github.com/newsuk/times-components/pull/978"},"issue":{"href":"https://api.github.com/repos/newsuk/times-components/issues/978"},"comments":{"href":"https://api.github.com/repos/newsuk/times-components/issues/978/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/978/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/978/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-components/statuses/e6540ec8d13c277a47cb28e1b5e09a41fc1ce240"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aronshamash"}}