{"action":"created","issue":{"url":"https://api.github.com/repos/narrowspark/http-emitter/issues/15","repository_url":"https://api.github.com/repos/narrowspark/http-emitter","labels_url":"https://api.github.com/repos/narrowspark/http-emitter/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/narrowspark/http-emitter/issues/15/comments","events_url":"https://api.github.com/repos/narrowspark/http-emitter/issues/15/events","html_url":"https://github.com/narrowspark/http-emitter/pull/15","id":373956462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzY2Mjkx","number":15,"title":"flush output buffers and disconnect","user":{"login":"mindplay-dk","id":103348,"node_id":"MDQ6VXNlcjEwMzM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/103348?v=4","gravatar_id":"","url":"https://api.github.com/users/mindplay-dk","html_url":"https://github.com/mindplay-dk","followers_url":"https://api.github.com/users/mindplay-dk/followers","following_url":"https://api.github.com/users/mindplay-dk/following{/other_user}","gists_url":"https://api.github.com/users/mindplay-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/mindplay-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindplay-dk/subscriptions","organizations_url":"https://api.github.com/users/mindplay-dk/orgs","repos_url":"https://api.github.com/users/mindplay-dk/repos","events_url":"https://api.github.com/users/mindplay-dk/events{/privacy}","received_events_url":"https://api.github.com/users/mindplay-dk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-25T13:47:37Z","updated_at":"2018-10-28T22:36:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/narrowspark/http-emitter/pulls/15","html_url":"https://github.com/narrowspark/http-emitter/pull/15","diff_url":"https://github.com/narrowspark/http-emitter/pull/15.diff","patch_url":"https://github.com/narrowspark/http-emitter/pull/15.patch"},"body":"Fixes #12 \r\n\r\nI didn't implement this *quite* as proposed - two minor differences:\r\n\r\n1. Your reference code either flushed output buffers or closed the connection - I believe it needs to do both. (closing the connection would be problematic if there's still content waiting in the buffer.)\r\n\r\n2. Placement of the `closeConnection()` calls is a bit different than I proposed - I had missed a `return` statement. (I unrolled an `if/return` to an `if/else` to make sure `closeConnection()` gets called in either case.)\r\n"},"comment":{"url":"https://api.github.com/repos/narrowspark/http-emitter/issues/comments/433748444","html_url":"https://github.com/narrowspark/http-emitter/pull/15#issuecomment-433748444","issue_url":"https://api.github.com/repos/narrowspark/http-emitter/issues/15","id":433748444,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzc0ODQ0NA==","user":{"login":"prisis","id":2716058,"node_id":"MDQ6VXNlcjI3MTYwNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2716058?v=4","gravatar_id":"","url":"https://api.github.com/users/prisis","html_url":"https://github.com/prisis","followers_url":"https://api.github.com/users/prisis/followers","following_url":"https://api.github.com/users/prisis/following{/other_user}","gists_url":"https://api.github.com/users/prisis/gists{/gist_id}","starred_url":"https://api.github.com/users/prisis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prisis/subscriptions","organizations_url":"https://api.github.com/users/prisis/orgs","repos_url":"https://api.github.com/users/prisis/repos","events_url":"https://api.github.com/users/prisis/events{/privacy}","received_events_url":"https://api.github.com/users/prisis/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T22:36:38Z","updated_at":"2018-10-28T22:36:38Z","author_association":"MEMBER","body":"Fixed the master, now you need to do a composer update and run composer cs and composer phpstan"}}
{"actor":{"display_login":"prisis"}}