{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/202579054","pull_request_review_id":137305718,"id":202579054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU3OTA1NA==","diff_hunk":"@@ -240,7 +240,7 @@ func (w *GCWorker) leaderTick(ctx context.Context) error {\n \treturn nil\n }\n \n-// prepare checks required conditions for starting a GC job. It returns a bool\n+// prepare checks preconditions for starting a GC job. It returns a bool","path":"store/tikv/gcworker/gc_worker.go","position":5,"original_position":5,"commit_id":"f3c8a3f06a6290c64acd2fc36cb19f645d0dd57a","original_commit_id":"f3c8a3f06a6290c64acd2fc36cb19f645d0dd57a","user":{"login":"zhexuany","id":13320708,"node_id":"MDQ6VXNlcjEzMzIwNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/13320708?v=4","gravatar_id":"","url":"https://api.github.com/users/zhexuany","html_url":"https://github.com/zhexuany","followers_url":"https://api.github.com/users/zhexuany/followers","following_url":"https://api.github.com/users/zhexuany/following{/other_user}","gists_url":"https://api.github.com/users/zhexuany/gists{/gist_id}","starred_url":"https://api.github.com/users/zhexuany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhexuany/subscriptions","organizations_url":"https://api.github.com/users/zhexuany/orgs","repos_url":"https://api.github.com/users/zhexuany/repos","events_url":"https://api.github.com/users/zhexuany/events{/privacy}","received_events_url":"https://api.github.com/users/zhexuany/received_events","type":"User","site_admin":false},"body":"No. It has nothing to do with dst issue. I change it mainly becuase `GCoworker` already has `session` as its variable so we do not need access such info with passing it as parameter around. \r\n\r\nI found this on the way fixing dst, it should be done via another PR. I will be carefully next time. ","created_at":"2018-07-16T06:05:16Z","updated_at":"2018-07-16T06:05:16Z","html_url":"https://github.com/pingcap/tidb/pull/6823#discussion_r202579054","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/6823","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/202579054"},"html":{"href":"https://github.com/pingcap/tidb/pull/6823#discussion_r202579054"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6823"}},"in_reply_to_id":202578592},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/6823","id":194341390,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzQxMzkw","html_url":"https://github.com/pingcap/tidb/pull/6823","diff_url":"https://github.com/pingcap/tidb/pull/6823.diff","patch_url":"https://github.com/pingcap/tidb/pull/6823.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/6823","number":6823,"state":"open","locked":false,"title":"executor, store: fixed daylight saving time issue","user":{"login":"zhexuany","id":13320708,"node_id":"MDQ6VXNlcjEzMzIwNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/13320708?v=4","gravatar_id":"","url":"https://api.github.com/users/zhexuany","html_url":"https://github.com/zhexuany","followers_url":"https://api.github.com/users/zhexuany/followers","following_url":"https://api.github.com/users/zhexuany/following{/other_user}","gists_url":"https://api.github.com/users/zhexuany/gists{/gist_id}","starred_url":"https://api.github.com/users/zhexuany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhexuany/subscriptions","organizations_url":"https://api.github.com/users/zhexuany/orgs","repos_url":"https://api.github.com/users/zhexuany/repos","events_url":"https://api.github.com/users/zhexuany/events{/privacy}","received_events_url":"https://api.github.com/users/zhexuany/received_events","type":"User","site_admin":false},"body":"Thank you for working on TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n\r\n## What have you changed? (mandatory)\r\n\r\nDuring coprocessor dag task,  it first uses timezone `name`, if non-empty, to get legitimate timezone variable. To achieve this, we need push down such data into tikv which leads to change the logic of building pushdown request. The logic I mentioned mainly resides in `executor` package. \r\n\r\nI change `timeZoneOffset` to `zone` and add second return parameter `name string`.  The intentioned of doing this to adopt the convention of `time` package. \r\n\r\nFor the same purpose, I change `GetTimeZone` to `Location`. As you can see, in `time` package, timezone was bind to `Location`. \r\n\r\n\r\n## What are the type of the changes (mandatory)?\r\n- Bug fix (non-breaking change which fixes an issue)\r\n- Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## How has this PR been tested (mandatory)?\r\n\r\n","created_at":"2018-06-12T16:39:27Z","updated_at":"2018-07-16T06:05:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a894b3942d13900fe3db1e0f5e012c245495986","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":578476531,"node_id":"MDU6TGFiZWw1Nzg0NzY1MzE=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/coprocessor","name":"component/coprocessor","color":"bfd4f2","default":false},{"id":564574080,"node_id":"MDU6TGFiZWw1NjQ1NzQwODA=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/LGT1","name":"status/LGT1","color":"d4c5f9","default":false},{"id":770872605,"node_id":"MDU6TGFiZWw3NzA4NzI2MDU=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/all%20tests%20passed","name":"status/all tests passed","color":"2cbe4e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/6823/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/6823/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/6823/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/f3c8a3f06a6290c64acd2fc36cb19f645d0dd57a","head":{"label":"zhexuany:fix_daylight_saving_time_issue","ref":"fix_daylight_saving_time_issue","sha":"f3c8a3f06a6290c64acd2fc36cb19f645d0dd57a","user":{"login":"zhexuany","id":13320708,"node_id":"MDQ6VXNlcjEzMzIwNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/13320708?v=4","gravatar_id":"","url":"https://api.github.com/users/zhexuany","html_url":"https://github.com/zhexuany","followers_url":"https://api.github.com/users/zhexuany/followers","following_url":"https://api.github.com/users/zhexuany/following{/other_user}","gists_url":"https://api.github.com/users/zhexuany/gists{/gist_id}","starred_url":"https://api.github.com/users/zhexuany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhexuany/subscriptions","organizations_url":"https://api.github.com/users/zhexuany/orgs","repos_url":"https://api.github.com/users/zhexuany/repos","events_url":"https://api.github.com/users/zhexuany/events{/privacy}","received_events_url":"https://api.github.com/users/zhexuany/received_events","type":"User","site_admin":false},"repo":{"id":79155321,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE1NTMyMQ==","name":"tidb","full_name":"zhexuany/tidb","owner":{"login":"zhexuany","id":13320708,"node_id":"MDQ6VXNlcjEzMzIwNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/13320708?v=4","gravatar_id":"","url":"https://api.github.com/users/zhexuany","html_url":"https://github.com/zhexuany","followers_url":"https://api.github.com/users/zhexuany/followers","following_url":"https://api.github.com/users/zhexuany/following{/other_user}","gists_url":"https://api.github.com/users/zhexuany/gists{/gist_id}","starred_url":"https://api.github.com/users/zhexuany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhexuany/subscriptions","organizations_url":"https://api.github.com/users/zhexuany/orgs","repos_url":"https://api.github.com/users/zhexuany/repos","events_url":"https://api.github.com/users/zhexuany/events{/privacy}","received_events_url":"https://api.github.com/users/zhexuany/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhexuany/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/zhexuany/tidb","forks_url":"https://api.github.com/repos/zhexuany/tidb/forks","keys_url":"https://api.github.com/repos/zhexuany/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhexuany/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhexuany/tidb/teams","hooks_url":"https://api.github.com/repos/zhexuany/tidb/hooks","issue_events_url":"https://api.github.com/repos/zhexuany/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/zhexuany/tidb/events","assignees_url":"https://api.github.com/repos/zhexuany/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/zhexuany/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/zhexuany/tidb/tags","blobs_url":"https://api.github.com/repos/zhexuany/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhexuany/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhexuany/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhexuany/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhexuany/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/zhexuany/tidb/languages","stargazers_url":"https://api.github.com/repos/zhexuany/tidb/stargazers","contributors_url":"https://api.github.com/repos/zhexuany/tidb/contributors","subscribers_url":"https://api.github.com/repos/zhexuany/tidb/subscribers","subscription_url":"https://api.github.com/repos/zhexuany/tidb/subscription","commits_url":"https://api.github.com/repos/zhexuany/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhexuany/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhexuany/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhexuany/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhexuany/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/zhexuany/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhexuany/tidb/merges","archive_url":"https://api.github.com/repos/zhexuany/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhexuany/tidb/downloads","issues_url":"https://api.github.com/repos/zhexuany/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/zhexuany/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/zhexuany/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/zhexuany/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhexuany/tidb/labels{/name}","releases_url":"https://api.github.com/repos/zhexuany/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/zhexuany/tidb/deployments","created_at":"2017-01-16T20:11:14Z","updated_at":"2017-01-16T20:11:19Z","pushed_at":"2018-07-16T04:50:01Z","git_url":"git://github.com/zhexuany/tidb.git","ssh_url":"git@github.com:zhexuany/tidb.git","clone_url":"https://github.com/zhexuany/tidb.git","svn_url":"https://github.com/zhexuany/tidb","homepage":"","size":50887,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"c1b4490365d97b7a619d48b52e3eb895e619af36","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-07-16T03:42:23Z","pushed_at":"2018-07-16T05:05:25Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":76845,"stargazers_count":14040,"watchers_count":14040,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1921,"mirror_url":null,"archived":false,"open_issues_count":460,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1921,"open_issues":460,"watchers":14040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6823"},"html":{"href":"https://github.com/pingcap/tidb/pull/6823"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/6823"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/6823/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6823/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6823/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/f3c8a3f06a6290c64acd2fc36cb19f645d0dd57a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zhexuany"}}