{"action":"created","issue":{"url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/issues/1217","repository_url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot","labels_url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/issues/1217/labels{/name}","comments_url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/issues/1217/comments","events_url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/issues/1217/events","html_url":"https://github.com/python-telegram-bot/python-telegram-bot/pull/1217","id":359223995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzY2NzQ0","number":1217,"title":"Cannot handle timeout by callback in ConversationHandler #1136","user":{"login":"simonvorobjev","id":33030001,"node_id":"MDQ6VXNlcjMzMDMwMDAx","avatar_url":"https://avatars0.githubusercontent.com/u/33030001?v=4","gravatar_id":"","url":"https://api.github.com/users/simonvorobjev","html_url":"https://github.com/simonvorobjev","followers_url":"https://api.github.com/users/simonvorobjev/followers","following_url":"https://api.github.com/users/simonvorobjev/following{/other_user}","gists_url":"https://api.github.com/users/simonvorobjev/gists{/gist_id}","starred_url":"https://api.github.com/users/simonvorobjev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonvorobjev/subscriptions","organizations_url":"https://api.github.com/users/simonvorobjev/orgs","repos_url":"https://api.github.com/users/simonvorobjev/repos","events_url":"https://api.github.com/users/simonvorobjev/events{/privacy}","received_events_url":"https://api.github.com/users/simonvorobjev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/milestones/13","html_url":"https://github.com/python-telegram-bot/python-telegram-bot/milestone/13","labels_url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/milestones/13/labels","id":3688044,"node_id":"MDk6TWlsZXN0b25lMzY4ODA0NA==","number":13,"title":"V12","description":null,"creator":{"login":"jsmnbom","id":3002987,"node_id":"MDQ6VXNlcjMwMDI5ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/3002987?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmnbom","html_url":"https://github.com/jsmnbom","followers_url":"https://api.github.com/users/jsmnbom/followers","following_url":"https://api.github.com/users/jsmnbom/following{/other_user}","gists_url":"https://api.github.com/users/jsmnbom/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmnbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmnbom/subscriptions","organizations_url":"https://api.github.com/users/jsmnbom/orgs","repos_url":"https://api.github.com/users/jsmnbom/repos","events_url":"https://api.github.com/users/jsmnbom/events{/privacy}","received_events_url":"https://api.github.com/users/jsmnbom/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2018-09-25T17:56:58Z","updated_at":"2018-09-25T17:57:17Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-09-11T21:06:37Z","updated_at":"2018-10-04T06:58:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/pulls/1217","html_url":"https://github.com/python-telegram-bot/python-telegram-bot/pull/1217","diff_url":"https://github.com/python-telegram-bot/python-telegram-bot/pull/1217.diff","patch_url":"https://github.com/python-telegram-bot/python-telegram-bot/pull/1217.patch"},"body":"https://github.com/python-telegram-bot/python-telegram-bot/issues/1136\r\n\r\nMet same issue, if conversation ended by timeout, we cannot handle it and make some finalization like clearing data, stopping threads etc. Now we can add handler for ConversationHandler.END, for example:\r\n\r\n```python\r\nconv_handler = ConversationHandler(\r\n        entry_points=[CommandHandler('find', begin)],\r\n        states={\r\n            PRODUCT_CHOOSE: [MessageHandler(Filters.text,\r\n                                           product_reply,\r\n                                           pass_user_data=True),\r\n                            ],\r\n            ConversationHandler.END: [MessageHandler(Filters.text,\r\n                                         conversation_timeout,\r\n                                         pass_user_data=True),\r\n                            ]\r\n        }\r\n```"},"comment":{"url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/issues/comments/426906446","html_url":"https://github.com/python-telegram-bot/python-telegram-bot/pull/1217#issuecomment-426906446","issue_url":"https://api.github.com/repos/python-telegram-bot/python-telegram-bot/issues/1217","id":426906446,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjkwNjQ0Ng==","user":{"login":"Eldinnie","id":1409173,"node_id":"MDQ6VXNlcjE0MDkxNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1409173?v=4","gravatar_id":"","url":"https://api.github.com/users/Eldinnie","html_url":"https://github.com/Eldinnie","followers_url":"https://api.github.com/users/Eldinnie/followers","following_url":"https://api.github.com/users/Eldinnie/following{/other_user}","gists_url":"https://api.github.com/users/Eldinnie/gists{/gist_id}","starred_url":"https://api.github.com/users/Eldinnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eldinnie/subscriptions","organizations_url":"https://api.github.com/users/Eldinnie/orgs","repos_url":"https://api.github.com/users/Eldinnie/repos","events_url":"https://api.github.com/users/Eldinnie/events{/privacy}","received_events_url":"https://api.github.com/users/Eldinnie/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T06:58:04Z","updated_at":"2018-10-04T06:58:04Z","author_association":"MEMBER","body":"Merging.\r\nThanks for the startup on this @simonvorobjev "}}
{"actor":{"display_login":"Eldinnie"}}