{"action":"opened","number":1753,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1753","id":185396759,"html_url":"https://github.com/ocaml/ocaml/pull/1753","diff_url":"https://github.com/ocaml/ocaml/pull/1753.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1753.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1753","number":1753,"state":"open","locked":false,"title":"debugger: avoid off-by-one overflow in debugger socket path","user":{"login":"avsm","id":53164,"avatar_url":"https://avatars3.githubusercontent.com/u/53164?v=4","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"body":"Modern gcc have a `-Werror=stringop-truncation` warning that tells us that the strncpy used to copy the CAML_DEBUG_SOCKET value from the environment misses out the space for a terminating NUL.\r\n\r\nRather than silently truncate the path, this patch raises an exception if the path is too long, and also fixes the off-by-one in the strncpy invocation.\r\n\r\nThis (along with #1752) fix compilation on Fedora 28 with trunk.","created_at":"2018-05-02T10:28:41Z","updated_at":"2018-05-02T10:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1753/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1753/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1753/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/483e4c4d1e380bd49e277c1af0d48fcb8039928b","head":{"label":"avsm:debug-socket-len","ref":"debug-socket-len","sha":"483e4c4d1e380bd49e277c1af0d48fcb8039928b","user":{"login":"avsm","id":53164,"avatar_url":"https://avatars3.githubusercontent.com/u/53164?v=4","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"repo":{"id":6918856,"name":"ocaml","full_name":"avsm/ocaml","owner":{"login":"avsm","id":53164,"avatar_url":"https://avatars3.githubusercontent.com/u/53164?v=4","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avsm/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/avsm/ocaml","forks_url":"https://api.github.com/repos/avsm/ocaml/forks","keys_url":"https://api.github.com/repos/avsm/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avsm/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avsm/ocaml/teams","hooks_url":"https://api.github.com/repos/avsm/ocaml/hooks","issue_events_url":"https://api.github.com/repos/avsm/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/avsm/ocaml/events","assignees_url":"https://api.github.com/repos/avsm/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/avsm/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/avsm/ocaml/tags","blobs_url":"https://api.github.com/repos/avsm/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avsm/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avsm/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/avsm/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avsm/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/avsm/ocaml/languages","stargazers_url":"https://api.github.com/repos/avsm/ocaml/stargazers","contributors_url":"https://api.github.com/repos/avsm/ocaml/contributors","subscribers_url":"https://api.github.com/repos/avsm/ocaml/subscribers","subscription_url":"https://api.github.com/repos/avsm/ocaml/subscription","commits_url":"https://api.github.com/repos/avsm/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/avsm/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/avsm/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/avsm/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/avsm/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/avsm/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avsm/ocaml/merges","archive_url":"https://api.github.com/repos/avsm/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avsm/ocaml/downloads","issues_url":"https://api.github.com/repos/avsm/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/avsm/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/avsm/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/avsm/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avsm/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/avsm/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/avsm/ocaml/deployments","created_at":"2012-11-29T10:11:34Z","updated_at":"2014-05-07T22:28:00Z","pushed_at":"2018-05-02T10:27:50Z","git_url":"git://github.com/avsm/ocaml.git","ssh_url":"git@github.com:avsm/ocaml.git","clone_url":"https://github.com/avsm/ocaml.git","svn_url":"https://github.com/avsm/ocaml","homepage":null,"size":167512,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"58f23cc4355a419d1c701351cb7962776be4e6de","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2018-05-02T08:48:24Z","pushed_at":"2018-05-02T09:53:41Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":168644,"stargazers_count":1789,"watchers_count":1789,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":452,"mirror_url":null,"archived":false,"open_issues_count":161,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":452,"open_issues":161,"watchers":1789,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1753"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1753"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1753"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1753/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1753/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1753/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/483e4c4d1e380bd49e277c1af0d48fcb8039928b"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"avsm"}}