{"action":"created","comment":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments/176240465","pull_request_review_id":105910217,"id":176240465,"diff_hunk":"@@ -127,7 +127,7 @@\n     // Base flex properties\n     @include xy-cell-base($size);\n \n-    @if($gutter-type == 'margin') {\n+    @if($gutter-output == true && $gutter-type == 'margin') {","path":"scss/xy-grid/_cell.scss","position":5,"original_position":5,"commit_id":"565c77d5dcb80852271c7f769721979629e6d0df","original_commit_id":"565c77d5dcb80852271c7f769721979629e6d0df","user":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"body":"This does not prevent the gutter to be output. This set the external margin to 0, this reset them. See the `-xy-cell-properties` mixin:\r\n\r\nhttps://github.com/zurb/foundation-sites/blob/69e3a68abc2649f84c97a047473fb9ed1152dcef/scss/xy-grid/_cell.scss#L91\r\n\r\nI guess this is part of the big problem they got with margin gutters while working on the XY grid. Poke @kball. As the width _is_ the gutter I don't see any way to set one or the other with margin gutters. Maybe all we can do is update the documentation ?","created_at":"2018-03-21T21:14:41Z","updated_at":"2018-03-21T21:14:57Z","html_url":"https://github.com/zurb/foundation-sites/pull/11081#discussion_r176240465","pull_request_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments/176240465"},"html":{"href":"https://github.com/zurb/foundation-sites/pull/11081#discussion_r176240465"},"pull_request":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081"}}},"pull_request":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081","id":176494191,"html_url":"https://github.com/zurb/foundation-sites/pull/11081","diff_url":"https://github.com/zurb/foundation-sites/pull/11081.diff","patch_url":"https://github.com/zurb/foundation-sites/pull/11081.patch","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/11081","number":11081,"state":"open","locked":false,"title":"fix: respect $gutter-output in the -xy-cell-properties mixin","user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"body":"Currently the gutters are included in the width calculation even if `$gutter-output` is set to `false`.\r\nThis should not be the case.\r\n\r\nCloses https://github.com/zurb/foundation-sites/issues/11059","created_at":"2018-03-21T14:29:40Z","updated_at":"2018-03-21T21:14:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f66c97e4ad98b1aedb7cdc84bbd20e6af854053","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":425273058,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/Sass%20Mixins","name":"Sass Mixins","color":"1197eb","default":false},{"id":618520978,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/XY%20Grid","name":"XY Grid","color":"1197eb","default":false},{"id":67281231,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/scss","name":"scss","color":"c6538c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081/commits","review_comments_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081/comments","review_comment_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/11081/comments","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/565c77d5dcb80852271c7f769721979629e6d0df","head":{"label":"DanielRuf:fix/xy-grid-gutter-output-11059","ref":"fix/xy-grid-gutter-output-11059","sha":"565c77d5dcb80852271c7f769721979629e6d0df","user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"repo":{"id":107110298,"name":"foundation-sites","full_name":"DanielRuf/foundation-sites","owner":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielRuf/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":true,"url":"https://api.github.com/repos/DanielRuf/foundation-sites","forks_url":"https://api.github.com/repos/DanielRuf/foundation-sites/forks","keys_url":"https://api.github.com/repos/DanielRuf/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielRuf/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielRuf/foundation-sites/teams","hooks_url":"https://api.github.com/repos/DanielRuf/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/DanielRuf/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/DanielRuf/foundation-sites/events","assignees_url":"https://api.github.com/repos/DanielRuf/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/DanielRuf/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/DanielRuf/foundation-sites/tags","blobs_url":"https://api.github.com/repos/DanielRuf/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielRuf/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielRuf/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielRuf/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielRuf/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielRuf/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/DanielRuf/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/DanielRuf/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/DanielRuf/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/DanielRuf/foundation-sites/subscription","commits_url":"https://api.github.com/repos/DanielRuf/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielRuf/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielRuf/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielRuf/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielRuf/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/DanielRuf/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielRuf/foundation-sites/merges","archive_url":"https://api.github.com/repos/DanielRuf/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielRuf/foundation-sites/downloads","issues_url":"https://api.github.com/repos/DanielRuf/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/DanielRuf/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielRuf/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielRuf/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielRuf/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/DanielRuf/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/DanielRuf/foundation-sites/deployments","created_at":"2017-10-16T10:01:24Z","updated_at":"2018-03-17T22:39:45Z","pushed_at":"2018-03-21T14:20:11Z","git_url":"git://github.com/DanielRuf/foundation-sites.git","ssh_url":"git@github.com:DanielRuf/foundation-sites.git","clone_url":"https://github.com/DanielRuf/foundation-sites.git","svn_url":"https://github.com/DanielRuf/foundation-sites","homepage":"http://foundation.zurb.com","size":129839,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zurb:develop","ref":"develop","sha":"69e3a68abc2649f84c97a047473fb9ed1152dcef","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars2.githubusercontent.com/u/156122?v=4","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2573058,"name":"foundation-sites","full_name":"zurb/foundation-sites","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars2.githubusercontent.com/u/156122?v=4","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":false,"url":"https://api.github.com/repos/zurb/foundation-sites","forks_url":"https://api.github.com/repos/zurb/foundation-sites/forks","keys_url":"https://api.github.com/repos/zurb/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation-sites/teams","hooks_url":"https://api.github.com/repos/zurb/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation-sites/events","assignees_url":"https://api.github.com/repos/zurb/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation-sites/tags","blobs_url":"https://api.github.com/repos/zurb/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation-sites/subscription","commits_url":"https://api.github.com/repos/zurb/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation-sites/merges","archive_url":"https://api.github.com/repos/zurb/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation-sites/downloads","issues_url":"https://api.github.com/repos/zurb/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/foundation-sites/deployments","created_at":"2011-10-13T23:05:42Z","updated_at":"2018-03-21T19:03:56Z","pushed_at":"2018-03-21T20:53:16Z","git_url":"git://github.com/zurb/foundation-sites.git","ssh_url":"git@github.com:zurb/foundation-sites.git","clone_url":"https://github.com/zurb/foundation-sites.git","svn_url":"https://github.com/zurb/foundation-sites","homepage":"http://foundation.zurb.com","size":129886,"stargazers_count":27139,"watchers_count":27139,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5800,"mirror_url":null,"archived":false,"open_issues_count":372,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5800,"open_issues":372,"watchers":27139,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081"},"html":{"href":"https://github.com/zurb/foundation-sites/pull/11081"},"issue":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/11081"},"comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/11081/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/11081/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/foundation-sites/statuses/565c77d5dcb80852271c7f769721979629e6d0df"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ncoden"}}