{"action":"created","comment":{"url":"https://api.github.com/repos/nteract/nteract/pulls/comments/233593204","pull_request_review_id":175045290,"id":233593204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzU5MzIwNA==","diff_hunk":"@@ -8,17 +8,7 @@ describe(\"HTMLDisplay\", () => {\n     const component = mount(<HTMLDisplay data={\"<b>woo</b>\"} />);\n     expect(component.html()).toEqual(\"<div><b>woo</b></div>\");\n   });\n-  it(\"correctly chooses to update with data changing\", () => {\n-    const wrapper = mount(<HTMLDisplay data={\"<b>woo</b>\"} />);\n-\n-    const component = wrapper.instance();\n-    expect(component.shouldComponentUpdate({ data: \"<b>woo</b>\" })).toBeFalsy();","path":"packages/transforms/__tests__/html-spec.js","position":8,"original_position":8,"commit_id":"8bd9b1185fa06a671cdeafadeb925c54f176fade","original_commit_id":"8bd9b1185fa06a671cdeafadeb925c54f176fade","user":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"body":"I can't figure out a good way to test whether a component re-renders or not using enzyme/jest. Now that these components are using `React.PureComponent`, we know that they won't re-render unless the new props or state do not equal the previous. \r\n\r\n> React.PureComponent’s shouldComponentUpdate() only shallowly compares the objects. If these contain complex data structures, it may produce false-negatives for deeper differences. Only extend PureComponent when you expect to have simple props and state, or use forceUpdate() when you know deep data structures have changed. Or, consider using immutable objects to facilitate fast comparisons of nested data.\r\n\r\nhttps://reactjs.org/docs/react-api.html#reactpurecomponent","created_at":"2018-11-14T19:44:07Z","updated_at":"2018-11-14T19:44:07Z","html_url":"https://github.com/nteract/nteract/pull/3657#discussion_r233593204","pull_request_url":"https://api.github.com/repos/nteract/nteract/pulls/3657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments/233593204"},"html":{"href":"https://github.com/nteract/nteract/pull/3657#discussion_r233593204"},"pull_request":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3657"}}},"pull_request":{"url":"https://api.github.com/repos/nteract/nteract/pulls/3657","id":230928843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTI4ODQz","html_url":"https://github.com/nteract/nteract/pull/3657","diff_url":"https://github.com/nteract/nteract/pull/3657.diff","patch_url":"https://github.com/nteract/nteract/pull/3657.patch","issue_url":"https://api.github.com/repos/nteract/nteract/issues/3657","number":3657,"state":"open","locked":false,"title":"Add default props to transform components to be compatible with new output components in @ntearct/outputs","user":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"body":"I was playing with the new output components (`Output`, `DisplayData`, `RichMedia`) and although @nteract/outputs exports new \"media\" components that may be meant to replace the components in @nteract/transforms, the only thing preventing the transforms components from working with these new output components is a default `mediaType` prop. This adds default props to the transform components and also clean up both the transforms and media components to be more consistent with each other and prefer `React.PureComponent` over `shouldComponentUpdate`.","created_at":"2018-11-14T17:59:45Z","updated_at":"2018-11-14T19:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62c67227b8d653142944bbf69fe13b6b8e38999c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/nteract/pulls/3657/commits","review_comments_url":"https://api.github.com/repos/nteract/nteract/pulls/3657/comments","review_comment_url":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/nteract/issues/3657/comments","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/8bd9b1185fa06a671cdeafadeb925c54f176fade","head":{"label":"gnestor:tranforms-mediatype","ref":"tranforms-mediatype","sha":"8bd9b1185fa06a671cdeafadeb925c54f176fade","user":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"repo":{"id":73866976,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg2Njk3Ng==","name":"nteract","full_name":"gnestor/nteract","private":false,"owner":{"login":"gnestor","id":512354,"node_id":"MDQ6VXNlcjUxMjM1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/512354?v=4","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gnestor/nteract","description":":notebook: Interactive literate coding notebook!","fork":true,"url":"https://api.github.com/repos/gnestor/nteract","forks_url":"https://api.github.com/repos/gnestor/nteract/forks","keys_url":"https://api.github.com/repos/gnestor/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnestor/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnestor/nteract/teams","hooks_url":"https://api.github.com/repos/gnestor/nteract/hooks","issue_events_url":"https://api.github.com/repos/gnestor/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/gnestor/nteract/events","assignees_url":"https://api.github.com/repos/gnestor/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/gnestor/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/gnestor/nteract/tags","blobs_url":"https://api.github.com/repos/gnestor/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnestor/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnestor/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnestor/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnestor/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/gnestor/nteract/languages","stargazers_url":"https://api.github.com/repos/gnestor/nteract/stargazers","contributors_url":"https://api.github.com/repos/gnestor/nteract/contributors","subscribers_url":"https://api.github.com/repos/gnestor/nteract/subscribers","subscription_url":"https://api.github.com/repos/gnestor/nteract/subscription","commits_url":"https://api.github.com/repos/gnestor/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnestor/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnestor/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnestor/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnestor/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/gnestor/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnestor/nteract/merges","archive_url":"https://api.github.com/repos/gnestor/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnestor/nteract/downloads","issues_url":"https://api.github.com/repos/gnestor/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/gnestor/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/gnestor/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/gnestor/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnestor/nteract/labels{/name}","releases_url":"https://api.github.com/repos/gnestor/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/gnestor/nteract/deployments","created_at":"2016-11-16T00:14:11Z","updated_at":"2016-11-16T00:14:13Z","pushed_at":"2018-11-14T19:40:01Z","git_url":"git://github.com/gnestor/nteract.git","ssh_url":"git@github.com:gnestor/nteract.git","clone_url":"https://github.com/gnestor/nteract.git","svn_url":"https://github.com/gnestor/nteract","homepage":"","size":18994,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"544cf09737e164dfacb421d9711d4da7ab3ce2ac","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ5NjUyMQ==","name":"nteract","full_name":"nteract/nteract","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/nteract","description":"📘 The interactive computing suite for you!  ✨","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2018-11-14T15:02:46Z","pushed_at":"2018-11-14T19:40:02Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":20317,"stargazers_count":3302,"watchers_count":3302,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":321,"mirror_url":null,"archived":false,"open_issues_count":373,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":321,"open_issues":373,"watchers":3302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3657"},"html":{"href":"https://github.com/nteract/nteract/pull/3657"},"issue":{"href":"https://api.github.com/repos/nteract/nteract/issues/3657"},"comments":{"href":"https://api.github.com/repos/nteract/nteract/issues/3657/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3657/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3657/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/nteract/statuses/8bd9b1185fa06a671cdeafadeb925c54f176fade"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gnestor"}}