{"action":"created","issue":{"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1253","repository_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS","labels_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1253/labels{/name}","comments_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1253/comments","events_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1253/events","html_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1253","id":374113248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODg4NzQ0","number":1253,"title":"UI Filters (Implementation)","user":{"login":"alex40724","id":1221841,"node_id":"MDQ6VXNlcjEyMjE4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1221841?v=4","gravatar_id":"","url":"https://api.github.com/users/alex40724","html_url":"https://github.com/alex40724","followers_url":"https://api.github.com/users/alex40724/followers","following_url":"https://api.github.com/users/alex40724/following{/other_user}","gists_url":"https://api.github.com/users/alex40724/gists{/gist_id}","starred_url":"https://api.github.com/users/alex40724/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex40724/subscriptions","organizations_url":"https://api.github.com/users/alex40724/orgs","repos_url":"https://api.github.com/users/alex40724/repos","events_url":"https://api.github.com/users/alex40724/events{/privacy}","received_events_url":"https://api.github.com/users/alex40724/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Amstutz","id":1866896,"node_id":"MDQ6VXNlcjE4NjY4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1866896?v=4","gravatar_id":"","url":"https://api.github.com/users/Amstutz","html_url":"https://github.com/Amstutz","followers_url":"https://api.github.com/users/Amstutz/followers","following_url":"https://api.github.com/users/Amstutz/following{/other_user}","gists_url":"https://api.github.com/users/Amstutz/gists{/gist_id}","starred_url":"https://api.github.com/users/Amstutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amstutz/subscriptions","organizations_url":"https://api.github.com/users/Amstutz/orgs","repos_url":"https://api.github.com/users/Amstutz/repos","events_url":"https://api.github.com/users/Amstutz/events{/privacy}","received_events_url":"https://api.github.com/users/Amstutz/received_events","type":"User","site_admin":false},"assignees":[{"login":"Amstutz","id":1866896,"node_id":"MDQ6VXNlcjE4NjY4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1866896?v=4","gravatar_id":"","url":"https://api.github.com/users/Amstutz","html_url":"https://github.com/Amstutz","followers_url":"https://api.github.com/users/Amstutz/followers","following_url":"https://api.github.com/users/Amstutz/following{/other_user}","gists_url":"https://api.github.com/users/Amstutz/gists{/gist_id}","starred_url":"https://api.github.com/users/Amstutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amstutz/subscriptions","organizations_url":"https://api.github.com/users/Amstutz/orgs","repos_url":"https://api.github.com/users/Amstutz/repos","events_url":"https://api.github.com/users/Amstutz/events{/privacy}","received_events_url":"https://api.github.com/users/Amstutz/received_events","type":"User","site_admin":false},{"login":"klees","id":10611082,"node_id":"MDQ6VXNlcjEwNjExMDgy","avatar_url":"https://avatars0.githubusercontent.com/u/10611082?v=4","gravatar_id":"","url":"https://api.github.com/users/klees","html_url":"https://github.com/klees","followers_url":"https://api.github.com/users/klees/followers","following_url":"https://api.github.com/users/klees/following{/other_user}","gists_url":"https://api.github.com/users/klees/gists{/gist_id}","starred_url":"https://api.github.com/users/klees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klees/subscriptions","organizations_url":"https://api.github.com/users/klees/orgs","repos_url":"https://api.github.com/users/klees/repos","events_url":"https://api.github.com/users/klees/events{/privacy}","received_events_url":"https://api.github.com/users/klees/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-25T20:13:06Z","updated_at":"2018-10-29T09:03:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/pulls/1253","html_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1253","diff_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1253.diff","patch_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1253.patch"},"body":"This is a follow up on #1193 which needed rebasing. The old PR included the toggle button and other cherry-picks which made it hard to read.\r\n\r\nOpen (at least)\r\n\r\n- [ ] Writing tests\r\n- [x] Cleanup less\r\n\r\nThere is some similar code in forms and filters now. Most obviously `PostDataFromServerRequest` which could be moved one directory level up. The `FilterContextRenderer` is another example. We could introduce some traits here, but personally I am not sure how much this will differ in the future."},"comment":{"url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/comments/433834770","html_url":"https://github.com/ILIAS-eLearning/ILIAS/pull/1253#issuecomment-433834770","issue_url":"https://api.github.com/repos/ILIAS-eLearning/ILIAS/issues/1253","id":433834770,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzgzNDc3MA==","user":{"login":"alex40724","id":1221841,"node_id":"MDQ6VXNlcjEyMjE4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1221841?v=4","gravatar_id":"","url":"https://api.github.com/users/alex40724","html_url":"https://github.com/alex40724","followers_url":"https://api.github.com/users/alex40724/followers","following_url":"https://api.github.com/users/alex40724/following{/other_user}","gists_url":"https://api.github.com/users/alex40724/gists{/gist_id}","starred_url":"https://api.github.com/users/alex40724/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex40724/subscriptions","organizations_url":"https://api.github.com/users/alex40724/orgs","repos_url":"https://api.github.com/users/alex40724/repos","events_url":"https://api.github.com/users/alex40724/events{/privacy}","received_events_url":"https://api.github.com/users/alex40724/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T09:03:09Z","updated_at":"2018-10-29T09:03:09Z","author_association":"MEMBER","body":"@Amstutz We are done with less.\r\n@tfamula Introduced lots of less variables."}}
{"actor":{"display_login":"alex40724"}}