{"action":"closed","number":157,"pull_request":{"url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/157","id":172659288,"html_url":"https://github.com/Team488/SeriouslyCommonLib/pull/157","diff_url":"https://github.com/Team488/SeriouslyCommonLib/pull/157.diff","patch_url":"https://github.com/Team488/SeriouslyCommonLib/pull/157.patch","issue_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/157","number":157,"state":"closed","locked":false,"title":"Allow accessing internal HID in joystick objects","user":{"login":"WasabiFan","id":3310349,"avatar_url":"https://avatars0.githubusercontent.com/u/3310349?v=4","gravatar_id":"","url":"https://api.github.com/users/WasabiFan","html_url":"https://github.com/WasabiFan","followers_url":"https://api.github.com/users/WasabiFan/followers","following_url":"https://api.github.com/users/WasabiFan/following{/other_user}","gists_url":"https://api.github.com/users/WasabiFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WasabiFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WasabiFan/subscriptions","organizations_url":"https://api.github.com/users/WasabiFan/orgs","repos_url":"https://api.github.com/users/WasabiFan/repos","events_url":"https://api.github.com/users/WasabiFan/events{/privacy}","received_events_url":"https://api.github.com/users/WasabiFan/received_events","type":"User","site_admin":false},"body":"This is intended to allow rumbling of devices we use as plain joysticks but know in reality are rumble-able controllers. This is pretty much a hack. For the alternative (which I want to look at _after_ competition as it makes some code cleaner), see https://github.com/Team488/SeriouslyCommonLib/tree/xbox-controller-rumble-dpad and https://github.com/Team488/TeamXbot2018/tree/adopt-xbox-controller-class. The primary issue here is that the Xbox controller class's inheritance tree is entirely separate from our other HIDs.","created_at":"2018-03-03T09:36:23Z","updated_at":"2018-03-03T15:19:17Z","closed_at":"2018-03-03T15:19:17Z","merged_at":"2018-03-03T15:19:17Z","merge_commit_sha":"0647da895b1dcf567657cfd76fdf7d888de296fb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JohnGilb","id":3423606,"avatar_url":"https://avatars3.githubusercontent.com/u/3423606?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnGilb","html_url":"https://github.com/JohnGilb","followers_url":"https://api.github.com/users/JohnGilb/followers","following_url":"https://api.github.com/users/JohnGilb/following{/other_user}","gists_url":"https://api.github.com/users/JohnGilb/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnGilb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnGilb/subscriptions","organizations_url":"https://api.github.com/users/JohnGilb/orgs","repos_url":"https://api.github.com/users/JohnGilb/repos","events_url":"https://api.github.com/users/JohnGilb/events{/privacy}","received_events_url":"https://api.github.com/users/JohnGilb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/157/commits","review_comments_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/157/comments","review_comment_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/157/comments","statuses_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/statuses/39d291109481a3973e4997ec05cdcb298d01394d","head":{"label":"Team488:public-internal-HID","ref":"public-internal-HID","sha":"39d291109481a3973e4997ec05cdcb298d01394d","user":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"repo":{"id":34178182,"name":"SeriouslyCommonLib","full_name":"Team488/SeriouslyCommonLib","owner":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team488/SeriouslyCommonLib","description":"A framework which aims to make programming FRC robots easier.","fork":false,"url":"https://api.github.com/repos/Team488/SeriouslyCommonLib","forks_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/forks","keys_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/teams","hooks_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/hooks","issue_events_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/events{/number}","events_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/events","assignees_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/assignees{/user}","branches_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/branches{/branch}","tags_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/tags","blobs_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/statuses/{sha}","languages_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/languages","stargazers_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/stargazers","contributors_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/contributors","subscribers_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/subscribers","subscription_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/subscription","commits_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/contents/{+path}","compare_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/merges","archive_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/downloads","issues_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues{/number}","pulls_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls{/number}","milestones_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/milestones{/number}","notifications_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/labels{/name}","releases_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/releases{/id}","deployments_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/deployments","created_at":"2015-04-18T18:47:14Z","updated_at":"2018-02-27T21:25:32Z","pushed_at":"2018-03-03T15:19:17Z","git_url":"git://github.com/Team488/SeriouslyCommonLib.git","ssh_url":"git@github.com:Team488/SeriouslyCommonLib.git","clone_url":"https://github.com/Team488/SeriouslyCommonLib.git","svn_url":"https://github.com/Team488/SeriouslyCommonLib","homepage":"","size":51741,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":5,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"Team488:master","ref":"master","sha":"b58844a589045bd843e191cced41e545dfd95a09","user":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"repo":{"id":34178182,"name":"SeriouslyCommonLib","full_name":"Team488/SeriouslyCommonLib","owner":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team488/SeriouslyCommonLib","description":"A framework which aims to make programming FRC robots easier.","fork":false,"url":"https://api.github.com/repos/Team488/SeriouslyCommonLib","forks_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/forks","keys_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/teams","hooks_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/hooks","issue_events_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/events{/number}","events_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/events","assignees_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/assignees{/user}","branches_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/branches{/branch}","tags_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/tags","blobs_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/statuses/{sha}","languages_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/languages","stargazers_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/stargazers","contributors_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/contributors","subscribers_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/subscribers","subscription_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/subscription","commits_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/contents/{+path}","compare_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/merges","archive_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/downloads","issues_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues{/number}","pulls_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls{/number}","milestones_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/milestones{/number}","notifications_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/labels{/name}","releases_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/releases{/id}","deployments_url":"https://api.github.com/repos/Team488/SeriouslyCommonLib/deployments","created_at":"2015-04-18T18:47:14Z","updated_at":"2018-02-27T21:25:32Z","pushed_at":"2018-03-03T15:19:17Z","git_url":"git://github.com/Team488/SeriouslyCommonLib.git","ssh_url":"git@github.com:Team488/SeriouslyCommonLib.git","clone_url":"https://github.com/Team488/SeriouslyCommonLib.git","svn_url":"https://github.com/Team488/SeriouslyCommonLib","homepage":"","size":51741,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":5,"open_issues":0,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/157"},"html":{"href":"https://github.com/Team488/SeriouslyCommonLib/pull/157"},"issue":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/157"},"comments":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/Team488/SeriouslyCommonLib/statuses/39d291109481a3973e4997ec05cdcb298d01394d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"JohnGilb","id":3423606,"avatar_url":"https://avatars3.githubusercontent.com/u/3423606?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnGilb","html_url":"https://github.com/JohnGilb","followers_url":"https://api.github.com/users/JohnGilb/followers","following_url":"https://api.github.com/users/JohnGilb/following{/other_user}","gists_url":"https://api.github.com/users/JohnGilb/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnGilb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnGilb/subscriptions","organizations_url":"https://api.github.com/users/JohnGilb/orgs","repos_url":"https://api.github.com/users/JohnGilb/repos","events_url":"https://api.github.com/users/JohnGilb/events{/privacy}","received_events_url":"https://api.github.com/users/JohnGilb/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":0,"changed_files":6}}
{"actor":{"display_login":"JohnGilb"}}