{"action":"created","comment":{"url":"https://api.github.com/repos/3scale/apicast/pulls/comments/183328254","pull_request_review_id":114304221,"id":183328254,"diff_hunk":"@@ -11,29 +11,54 @@\n         \"description\": \"List of limiters to be applied\",\n         \"type\": \"array\",\n         \"items\": {\n-          \"oneOf\": [{\n+          \"anyOf\": [{\n             \"type\": \"object\",\n             \"properties\": {\n               \"name\": {\n                 \"type\": \"string\",\n                 \"enum\": [\"connections\"],\n-                \"description\": \"limiting request concurrency (or concurrent connections)\"\n+                \"description\": \"Limiting request concurrency (or concurrent connections)\"\n               },\n               \"key\": {\n-                \"description\": \"Key of limiter\",\n-                \"type\": \"string\"\n+                \"description\": \"The key corresponding to the limiter object\",\n+                \"type\": \"object\",\n+                \"properties\": {\n+                  \"name\": {\n+                    \"type\": \"string\",\n+                    \"description\": \"The name of the key, must be unique in the scope\"\n+                  },\n+                  \"scope\": {","path":"gateway/src/apicast/policy/rate_limit/apicast-policy.json","position":24,"original_position":24,"commit_id":"4ab2ac80d1bd6f952de4a0068932b5a992619e0b","original_commit_id":"4ab2ac80d1bd6f952de4a0068932b5a992619e0b","user":{"login":"mikz","id":154571,"avatar_url":"https://avatars3.githubusercontent.com/u/154571?v=4","gravatar_id":"","url":"https://api.github.com/users/mikz","html_url":"https://github.com/mikz","followers_url":"https://api.github.com/users/mikz/followers","following_url":"https://api.github.com/users/mikz/following{/other_user}","gists_url":"https://api.github.com/users/mikz/gists{/gist_id}","starred_url":"https://api.github.com/users/mikz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikz/subscriptions","organizations_url":"https://api.github.com/users/mikz/orgs","repos_url":"https://api.github.com/users/mikz/repos","events_url":"https://api.github.com/users/mikz/events{/privacy}","received_events_url":"https://api.github.com/users/mikz/received_events","type":"User","site_admin":false},"body":"I think we could extract this into shared definition in this schema an reuse it so it is not duplicated 3 times. \r\n\r\nSee an example: \r\nhttps://github.com/3scale/apicast/blob/4ab2ac80d1bd6f952de4a0068932b5a992619e0b/gateway/src/apicast/policy/manifest-schema.json#L11-L21","created_at":"2018-04-23T09:27:27Z","updated_at":"2018-04-23T09:27:27Z","html_url":"https://github.com/3scale/apicast/pull/665#discussion_r183328254","pull_request_url":"https://api.github.com/repos/3scale/apicast/pulls/665","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/3scale/apicast/pulls/comments/183328254"},"html":{"href":"https://github.com/3scale/apicast/pull/665#discussion_r183328254"},"pull_request":{"href":"https://api.github.com/repos/3scale/apicast/pulls/665"}}},"pull_request":{"url":"https://api.github.com/repos/3scale/apicast/pulls/665","id":180487945,"html_url":"https://github.com/3scale/apicast/pull/665","diff_url":"https://github.com/3scale/apicast/pull/665.diff","patch_url":"https://github.com/3scale/apicast/pull/665.patch","issue_url":"https://api.github.com/repos/3scale/apicast/issues/665","number":665,"state":"open","locked":false,"title":"Improve rate limit policy","user":{"login":"y-tabata","id":34849594,"avatar_url":"https://avatars2.githubusercontent.com/u/34849594?v=4","gravatar_id":"","url":"https://api.github.com/users/y-tabata","html_url":"https://github.com/y-tabata","followers_url":"https://api.github.com/users/y-tabata/followers","following_url":"https://api.github.com/users/y-tabata/following{/other_user}","gists_url":"https://api.github.com/users/y-tabata/gists{/gist_id}","starred_url":"https://api.github.com/users/y-tabata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-tabata/subscriptions","organizations_url":"https://api.github.com/users/y-tabata/orgs","repos_url":"https://api.github.com/users/y-tabata/repos","events_url":"https://api.github.com/users/y-tabata/events{/privacy}","received_events_url":"https://api.github.com/users/y-tabata/received_events","type":"User","site_admin":false},"body":"This PR improves the rate limit policy according to the comments of [PR #648](https://github.com/3scale/apicast/pull/648).","created_at":"2018-04-10T04:38:55Z","updated_at":"2018-04-23T09:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fc3136abd3139e22d7fec72adeaea245048aa79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":815117485,"url":"https://api.github.com/repos/3scale/apicast/labels/skip-changelog","name":"skip-changelog","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/3scale/apicast/pulls/665/commits","review_comments_url":"https://api.github.com/repos/3scale/apicast/pulls/665/comments","review_comment_url":"https://api.github.com/repos/3scale/apicast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3scale/apicast/issues/665/comments","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/4ab2ac80d1bd6f952de4a0068932b5a992619e0b","head":{"label":"Hitachi:rate_limiting_to_service_policy","ref":"rate_limiting_to_service_policy","sha":"4ab2ac80d1bd6f952de4a0068932b5a992619e0b","user":{"login":"Hitachi","id":9561292,"avatar_url":"https://avatars3.githubusercontent.com/u/9561292?v=4","gravatar_id":"","url":"https://api.github.com/users/Hitachi","html_url":"https://github.com/Hitachi","followers_url":"https://api.github.com/users/Hitachi/followers","following_url":"https://api.github.com/users/Hitachi/following{/other_user}","gists_url":"https://api.github.com/users/Hitachi/gists{/gist_id}","starred_url":"https://api.github.com/users/Hitachi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hitachi/subscriptions","organizations_url":"https://api.github.com/users/Hitachi/orgs","repos_url":"https://api.github.com/users/Hitachi/repos","events_url":"https://api.github.com/users/Hitachi/events{/privacy}","received_events_url":"https://api.github.com/users/Hitachi/received_events","type":"Organization","site_admin":false},"repo":{"id":124348219,"name":"apicast","full_name":"Hitachi/apicast","owner":{"login":"Hitachi","id":9561292,"avatar_url":"https://avatars3.githubusercontent.com/u/9561292?v=4","gravatar_id":"","url":"https://api.github.com/users/Hitachi","html_url":"https://github.com/Hitachi","followers_url":"https://api.github.com/users/Hitachi/followers","following_url":"https://api.github.com/users/Hitachi/following{/other_user}","gists_url":"https://api.github.com/users/Hitachi/gists{/gist_id}","starred_url":"https://api.github.com/users/Hitachi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hitachi/subscriptions","organizations_url":"https://api.github.com/users/Hitachi/orgs","repos_url":"https://api.github.com/users/Hitachi/repos","events_url":"https://api.github.com/users/Hitachi/events{/privacy}","received_events_url":"https://api.github.com/users/Hitachi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Hitachi/apicast","description":"3scale api gateway reloaded","fork":true,"url":"https://api.github.com/repos/Hitachi/apicast","forks_url":"https://api.github.com/repos/Hitachi/apicast/forks","keys_url":"https://api.github.com/repos/Hitachi/apicast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hitachi/apicast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hitachi/apicast/teams","hooks_url":"https://api.github.com/repos/Hitachi/apicast/hooks","issue_events_url":"https://api.github.com/repos/Hitachi/apicast/issues/events{/number}","events_url":"https://api.github.com/repos/Hitachi/apicast/events","assignees_url":"https://api.github.com/repos/Hitachi/apicast/assignees{/user}","branches_url":"https://api.github.com/repos/Hitachi/apicast/branches{/branch}","tags_url":"https://api.github.com/repos/Hitachi/apicast/tags","blobs_url":"https://api.github.com/repos/Hitachi/apicast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hitachi/apicast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hitachi/apicast/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hitachi/apicast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hitachi/apicast/statuses/{sha}","languages_url":"https://api.github.com/repos/Hitachi/apicast/languages","stargazers_url":"https://api.github.com/repos/Hitachi/apicast/stargazers","contributors_url":"https://api.github.com/repos/Hitachi/apicast/contributors","subscribers_url":"https://api.github.com/repos/Hitachi/apicast/subscribers","subscription_url":"https://api.github.com/repos/Hitachi/apicast/subscription","commits_url":"https://api.github.com/repos/Hitachi/apicast/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hitachi/apicast/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hitachi/apicast/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hitachi/apicast/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hitachi/apicast/contents/{+path}","compare_url":"https://api.github.com/repos/Hitachi/apicast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hitachi/apicast/merges","archive_url":"https://api.github.com/repos/Hitachi/apicast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hitachi/apicast/downloads","issues_url":"https://api.github.com/repos/Hitachi/apicast/issues{/number}","pulls_url":"https://api.github.com/repos/Hitachi/apicast/pulls{/number}","milestones_url":"https://api.github.com/repos/Hitachi/apicast/milestones{/number}","notifications_url":"https://api.github.com/repos/Hitachi/apicast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hitachi/apicast/labels{/name}","releases_url":"https://api.github.com/repos/Hitachi/apicast/releases{/id}","deployments_url":"https://api.github.com/repos/Hitachi/apicast/deployments","created_at":"2018-03-08T06:36:29Z","updated_at":"2018-04-20T02:12:50Z","pushed_at":"2018-04-20T03:51:56Z","git_url":"git://github.com/Hitachi/apicast.git","ssh_url":"git@github.com:Hitachi/apicast.git","clone_url":"https://github.com/Hitachi/apicast.git","svn_url":"https://github.com/Hitachi/apicast","homepage":"","size":2614,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"3scale:master","ref":"master","sha":"869aa91a3e435cdb1f30cdc5fac698d3adba83f5","user":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":53965666,"name":"apicast","full_name":"3scale/apicast","owner":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3scale/apicast","description":"3scale api gateway reloaded","fork":false,"url":"https://api.github.com/repos/3scale/apicast","forks_url":"https://api.github.com/repos/3scale/apicast/forks","keys_url":"https://api.github.com/repos/3scale/apicast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/apicast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/apicast/teams","hooks_url":"https://api.github.com/repos/3scale/apicast/hooks","issue_events_url":"https://api.github.com/repos/3scale/apicast/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/apicast/events","assignees_url":"https://api.github.com/repos/3scale/apicast/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/apicast/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/apicast/tags","blobs_url":"https://api.github.com/repos/3scale/apicast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/apicast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/apicast/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/apicast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/apicast/languages","stargazers_url":"https://api.github.com/repos/3scale/apicast/stargazers","contributors_url":"https://api.github.com/repos/3scale/apicast/contributors","subscribers_url":"https://api.github.com/repos/3scale/apicast/subscribers","subscription_url":"https://api.github.com/repos/3scale/apicast/subscription","commits_url":"https://api.github.com/repos/3scale/apicast/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/apicast/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/apicast/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/apicast/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/apicast/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/apicast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/apicast/merges","archive_url":"https://api.github.com/repos/3scale/apicast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/apicast/downloads","issues_url":"https://api.github.com/repos/3scale/apicast/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/apicast/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/apicast/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/apicast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/apicast/labels{/name}","releases_url":"https://api.github.com/repos/3scale/apicast/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/apicast/deployments","created_at":"2016-03-15T17:41:51Z","updated_at":"2018-04-23T09:06:17Z","pushed_at":"2018-04-23T09:11:25Z","git_url":"git://github.com/3scale/apicast.git","ssh_url":"git@github.com:3scale/apicast.git","clone_url":"https://github.com/3scale/apicast.git","svn_url":"https://github.com/3scale/apicast","homepage":"","size":2664,"stargazers_count":81,"watchers_count":81,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":54,"open_issues":58,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3scale/apicast/pulls/665"},"html":{"href":"https://github.com/3scale/apicast/pull/665"},"issue":{"href":"https://api.github.com/repos/3scale/apicast/issues/665"},"comments":{"href":"https://api.github.com/repos/3scale/apicast/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/3scale/apicast/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/3scale/apicast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3scale/apicast/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/3scale/apicast/statuses/4ab2ac80d1bd6f952de4a0068932b5a992619e0b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikz"}}