{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/190576348","pull_request_review_id":122980147,"id":190576348,"diff_hunk":"@@ -0,0 +1,81 @@\n+<?php\n+/**\n+ * 2007-2018 PrestaShop\n+ *\n+ * NOTICE OF LICENSE\n+ *\n+ * This source file is subject to the Open Software License (OSL 3.0)\n+ * that is bundled with this package in the file LICENSE.txt.\n+ * It is also available through the world-wide-web at this URL:\n+ * https://opensource.org/licenses/OSL-3.0\n+ * If you did not receive a copy of the license and are unable to\n+ * obtain it through the world-wide-web, please send an email\n+ * to license@prestashop.com so we can send you a copy immediately.\n+ *\n+ * DISCLAIMER\n+ *\n+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer\n+ * versions in the future. If you wish to customize PrestaShop for your\n+ * needs please refer to http://www.prestashop.com for more information.\n+ *\n+ * @author    PrestaShop SA <contact@prestashop.com>\n+ * @copyright 2007-2018 PrestaShop SA\n+ * @license   https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)\n+ * International Registered Trademark & Property of PrestaShop SA\n+ */\n+\n+namespace PrestaShop\\PrestaShop\\Adapter\\Carrier;\n+\n+use PrestaShop\\PrestaShop\\Adapter\\Configuration;\n+use PrestaShop\\PrestaShop\\Core\\Configuration\\DataConfigurationInterface;\n+\n+class HandlingConfiguration implements DataConfigurationInterface","path":"src/Adapter/Carrier/HandlingConfiguration.php","position":32,"original_position":32,"commit_id":"90b46f12ebd0fb028d4de384d7acab62cd04ba79","original_commit_id":"90b46f12ebd0fb028d4de384d7acab62cd04ba79","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars2.githubusercontent.com/u/1247388?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"miss PHPDoc","created_at":"2018-05-24T13:01:43Z","updated_at":"2018-05-24T13:01:43Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9094#discussion_r190576348","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/190576348"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9094#discussion_r190576348"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094","id":189035716,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/9094","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/9094.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/9094.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9094","number":9094,"state":"open","locked":false,"title":"Migrate Improve > Shipping > Preferences controller","user":{"login":"rokaszygmantas","id":6286794,"avatar_url":"https://avatars0.githubusercontent.com/u/6286794?v=4","gravatar_id":"","url":"https://api.github.com/users/rokaszygmantas","html_url":"https://github.com/rokaszygmantas","followers_url":"https://api.github.com/users/rokaszygmantas/followers","following_url":"https://api.github.com/users/rokaszygmantas/following{/other_user}","gists_url":"https://api.github.com/users/rokaszygmantas/gists{/gist_id}","starred_url":"https://api.github.com/users/rokaszygmantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokaszygmantas/subscriptions","organizations_url":"https://api.github.com/users/rokaszygmantas/orgs","repos_url":"https://api.github.com/users/rokaszygmantas/repos","events_url":"https://api.github.com/users/rokaszygmantas/events{/privacy}","received_events_url":"https://api.github.com/users/rokaszygmantas/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information: -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | Migration of Shipping > Preferences controller (legacy AdminShipping)\r\n| Type?         | new feature\r\n| Category?     | CO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed ticket? | n/a\r\n| How to test?  | Compare to the legacy controller.\r\n\r\n<!-- Click the form's \"Preview button\" to make sure the table is functional in GitHub. Thank you! -->\r\nNote: I'm concerned about the code in AdminShippingController::postProcess(). It looks like the code in that method is never used - the if condition is never satisfied ```if (Tools::isSubmit('submitFees'.$this->table)) {``` the post key is 'submitFeesdelivery' and there is no such key in html or in other files.\r\nThe code I'm referring to:\r\nhttps://github.com/PrestaShop/PrestaShop/blob/70b7e25a902ebdcb91e8a9463d12480a3f2827c9/controllers/admin/AdminShippingController.php#L126\r\nWould be great to get some input on that.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/9094)\n<!-- Reviewable:end -->\n","created_at":"2018-05-18T14:01:03Z","updated_at":"2018-05-24T13:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c820f963ca5274522eda51c8ebd9796cc3c00a6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":904910825,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"3ce091","default":false},{"id":630442847,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/feature","name":"feature","color":"b9d854","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9094/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/90b46f12ebd0fb028d4de384d7acab62cd04ba79","head":{"label":"rokaszygmantas:migration/shipping-preferences","ref":"migration/shipping-preferences","sha":"90b46f12ebd0fb028d4de384d7acab62cd04ba79","user":{"login":"rokaszygmantas","id":6286794,"avatar_url":"https://avatars0.githubusercontent.com/u/6286794?v=4","gravatar_id":"","url":"https://api.github.com/users/rokaszygmantas","html_url":"https://github.com/rokaszygmantas","followers_url":"https://api.github.com/users/rokaszygmantas/followers","following_url":"https://api.github.com/users/rokaszygmantas/following{/other_user}","gists_url":"https://api.github.com/users/rokaszygmantas/gists{/gist_id}","starred_url":"https://api.github.com/users/rokaszygmantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokaszygmantas/subscriptions","organizations_url":"https://api.github.com/users/rokaszygmantas/orgs","repos_url":"https://api.github.com/users/rokaszygmantas/repos","events_url":"https://api.github.com/users/rokaszygmantas/events{/privacy}","received_events_url":"https://api.github.com/users/rokaszygmantas/received_events","type":"User","site_admin":false},"repo":{"id":126335407,"name":"PrestaShop","full_name":"rokaszygmantas/PrestaShop","owner":{"login":"rokaszygmantas","id":6286794,"avatar_url":"https://avatars0.githubusercontent.com/u/6286794?v=4","gravatar_id":"","url":"https://api.github.com/users/rokaszygmantas","html_url":"https://github.com/rokaszygmantas","followers_url":"https://api.github.com/users/rokaszygmantas/followers","following_url":"https://api.github.com/users/rokaszygmantas/following{/other_user}","gists_url":"https://api.github.com/users/rokaszygmantas/gists{/gist_id}","starred_url":"https://api.github.com/users/rokaszygmantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokaszygmantas/subscriptions","organizations_url":"https://api.github.com/users/rokaszygmantas/orgs","repos_url":"https://api.github.com/users/rokaszygmantas/repos","events_url":"https://api.github.com/users/rokaszygmantas/events{/privacy}","received_events_url":"https://api.github.com/users/rokaszygmantas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rokaszygmantas/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/rokaszygmantas/PrestaShop","forks_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/forks","keys_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/teams","hooks_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/events","assignees_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/tags","blobs_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/subscription","commits_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/merges","archive_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/downloads","issues_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/rokaszygmantas/PrestaShop/deployments","created_at":"2018-03-22T12:57:41Z","updated_at":"2018-05-24T07:29:18Z","pushed_at":"2018-05-24T10:34:00Z","git_url":"git://github.com/rokaszygmantas/PrestaShop.git","ssh_url":"git@github.com:rokaszygmantas/PrestaShop.git","clone_url":"https://github.com/rokaszygmantas/PrestaShop.git","svn_url":"https://github.com/rokaszygmantas/PrestaShop","homepage":"http://www.prestashop.com/","size":320777,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"c38afb55c6c658b73c492f336bd0cf1eb3a066d7","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-05-24T10:25:44Z","pushed_at":"2018-05-24T12:33:54Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":337161,"stargazers_count":3037,"watchers_count":3037,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2758,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2758,"open_issues":331,"watchers":3037,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9094"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9094"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9094/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9094/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/90b46f12ebd0fb028d4de384d7acab62cd04ba79"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mickaelandrieu"}}