{"action":"closed","issue":{"url":"https://api.github.com/repos/danielyxie/bitburner/issues/454","repository_url":"https://api.github.com/repos/danielyxie/bitburner","labels_url":"https://api.github.com/repos/danielyxie/bitburner/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/danielyxie/bitburner/issues/454/comments","events_url":"https://api.github.com/repos/danielyxie/bitburner/issues/454/events","html_url":"https://github.com/danielyxie/bitburner/issues/454","id":358311503,"node_id":"MDU6SXNzdWUzNTgzMTE1MDM=","number":454,"title":"Netscript: tprint deals damage for using html when html is not present","user":{"login":"RabidGuy","id":2200160,"node_id":"MDQ6VXNlcjIyMDAxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2200160?v=4","gravatar_id":"","url":"https://api.github.com/users/RabidGuy","html_url":"https://github.com/RabidGuy","followers_url":"https://api.github.com/users/RabidGuy/followers","following_url":"https://api.github.com/users/RabidGuy/following{/other_user}","gists_url":"https://api.github.com/users/RabidGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/RabidGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RabidGuy/subscriptions","organizations_url":"https://api.github.com/users/RabidGuy/orgs","repos_url":"https://api.github.com/users/RabidGuy/repos","events_url":"https://api.github.com/users/RabidGuy/events{/privacy}","received_events_url":"https://api.github.com/users/RabidGuy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-08T16:59:18Z","updated_at":"2018-10-09T16:56:35Z","closed_at":"2018-10-09T16:56:35Z","author_association":"NONE","body":"I use angle brackets in script arguments and documentation in order to be consistent with my coding practices outside of the game. `tprint` deals damage any time a user attempts to print html elements but also interprets my more general use of angle brackets as html. For now, I'm adjusting my coding practices.\r\n\r\n\r\n`tprint` checks whether a string contains html by passing the string to `isHTML`, which is found in `utils/StringHelperFunctions.ts`. This function catches both escaped and non-escaped angle brackets.\r\n\r\nPotential solutions:\r\n* An alternative might look specifically for known html elements.\r\n* If `tprint` dumped raw-looking strings, html tags would fail to enter the DOM, instead being printed verbosely. `\"thingy <foo bar>\"` would become `\"thingy &lt;foo bar&gt;\"`, which would print `\"my.script: thingy <foo bar>\"`. This would discourage unintended player behavior while allowing the use of angle brackets in terminal output."}}
{"actor":{"display_login":"danielyxie"}}