{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/9126","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/9126/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/9126/comments","events_url":"https://api.github.com/repos/istio/istio/issues/9126/events","html_url":"https://github.com/istio/istio/pull/9126","id":366540913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTg5MDEy","number":9126,"title":"Changes to command line params in upgrade test script","user":{"login":"ostromart","id":30089849,"node_id":"MDQ6VXNlcjMwMDg5ODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/30089849?v=4","gravatar_id":"","url":"https://api.github.com/users/ostromart","html_url":"https://github.com/ostromart","followers_url":"https://api.github.com/users/ostromart/followers","following_url":"https://api.github.com/users/ostromart/following{/other_user}","gists_url":"https://api.github.com/users/ostromart/gists{/gist_id}","starred_url":"https://api.github.com/users/ostromart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostromart/subscriptions","organizations_url":"https://api.github.com/users/ostromart/orgs","repos_url":"https://api.github.com/users/ostromart/repos","events_url":"https://api.github.com/users/ostromart/events{/privacy}","received_events_url":"https://api.github.com/users/ostromart/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"hklai","id":31747472,"node_id":"MDQ6VXNlcjMxNzQ3NDcy","avatar_url":"https://avatars3.githubusercontent.com/u/31747472?v=4","gravatar_id":"","url":"https://api.github.com/users/hklai","html_url":"https://github.com/hklai","followers_url":"https://api.github.com/users/hklai/followers","following_url":"https://api.github.com/users/hklai/following{/other_user}","gists_url":"https://api.github.com/users/hklai/gists{/gist_id}","starred_url":"https://api.github.com/users/hklai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hklai/subscriptions","organizations_url":"https://api.github.com/users/hklai/orgs","repos_url":"https://api.github.com/users/hklai/repos","events_url":"https://api.github.com/users/hklai/events{/privacy}","received_events_url":"https://api.github.com/users/hklai/received_events","type":"User","site_admin":false},"assignees":[{"login":"hklai","id":31747472,"node_id":"MDQ6VXNlcjMxNzQ3NDcy","avatar_url":"https://avatars3.githubusercontent.com/u/31747472?v=4","gravatar_id":"","url":"https://api.github.com/users/hklai","html_url":"https://github.com/hklai","followers_url":"https://api.github.com/users/hklai/followers","following_url":"https://api.github.com/users/hklai/following{/other_user}","gists_url":"https://api.github.com/users/hklai/gists{/gist_id}","starred_url":"https://api.github.com/users/hklai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hklai/subscriptions","organizations_url":"https://api.github.com/users/hklai/orgs","repos_url":"https://api.github.com/users/hklai/repos","events_url":"https://api.github.com/users/hklai/events{/privacy}","received_events_url":"https://api.github.com/users/hklai/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-03T21:41:09Z","updated_at":"2018-10-03T22:51:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/9126","html_url":"https://github.com/istio/istio/pull/9126","diff_url":"https://github.com/istio/istio/pull/9126.diff","patch_url":"https://github.com/istio/istio/pull/9126.patch"},"body":"A bunch of fixes for bugs @hklai discovered and changing the invocation per his suggestion to specify both source and destination hub/tag from flags rather than env variable, and pointing to downloaded release rather than git checkout from repo to target releases.\r\nAlso removing the makefile upgrade_test target since the script now requires a release to be created to work (git integration has been removed so it won't work from local changes anymore)."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/426829605","html_url":"https://github.com/istio/istio/pull/9126#issuecomment-426829605","issue_url":"https://api.github.com/repos/istio/istio/issues/9126","id":426829605,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjgyOTYwNQ==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T22:51:35Z","updated_at":"2018-10-03T22:51:35Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/9126#issuecomment-426829597\" title=\"LGTM\">hklai</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/istio/istio/blob/master/OWNERS)~~ [hklai]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"istio-testing"}}