{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/200808100","pull_request_review_id":135199702,"id":200808100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgwODEwMA==","diff_hunk":"@@ -17,13 +17,12 @@\n  limitations under the License.\n -%>\n const config = {\n-  VERSION: process.env.VERSION,\n-  SERVER_API_URL: process.env.SERVER_API_URL\n+  VERSION: process.env.VERSION\n };\n \n export default config;\n \n-export const SERVER_API_URL = '';","path":"generators/client/templates/react/src/main/webapp/app/config/constants.ts.ejs","position":11,"original_position":11,"commit_id":"be891b392635aeedaa3931bbd4d274de84a9eeb7","original_commit_id":"be891b392635aeedaa3931bbd4d274de84a9eeb7","user":{"login":"deepu105","id":1107223,"node_id":"MDQ6VXNlcjExMDcyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1107223?v=4","gravatar_id":"","url":"https://api.github.com/users/deepu105","html_url":"https://github.com/deepu105","followers_url":"https://api.github.com/users/deepu105/followers","following_url":"https://api.github.com/users/deepu105/following{/other_user}","gists_url":"https://api.github.com/users/deepu105/gists{/gist_id}","starred_url":"https://api.github.com/users/deepu105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepu105/subscriptions","organizations_url":"https://api.github.com/users/deepu105/orgs","repos_url":"https://api.github.com/users/deepu105/repos","events_url":"https://api.github.com/users/deepu105/events{/privacy}","received_events_url":"https://api.github.com/users/deepu105/received_events","type":"User","site_admin":false},"body":"its ok","created_at":"2018-07-07T09:55:36Z","updated_at":"2018-07-07T09:58:59Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/7936#discussion_r200808100","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/200808100"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/7936#discussion_r200808100"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936"}},"in_reply_to_id":200785806},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936","id":199860665,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODYwNjY1","html_url":"https://github.com/jhipster/generator-jhipster/pull/7936","diff_url":"https://github.com/jhipster/generator-jhipster/pull/7936.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/7936.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7936","number":7936,"state":"open","locked":false,"title":"React UAA paths and SERVER_API_URL","user":{"login":"ruddell","id":4294623,"node_id":"MDQ6VXNlcjQyOTQ2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4294623?v=4","gravatar_id":"","url":"https://api.github.com/users/ruddell","html_url":"https://github.com/ruddell","followers_url":"https://api.github.com/users/ruddell/followers","following_url":"https://api.github.com/users/ruddell/following{/other_user}","gists_url":"https://api.github.com/users/ruddell/gists{/gist_id}","starred_url":"https://api.github.com/users/ruddell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruddell/subscriptions","organizations_url":"https://api.github.com/users/ruddell/orgs","repos_url":"https://api.github.com/users/ruddell/repos","events_url":"https://api.github.com/users/ruddell/events{/privacy}","received_events_url":"https://api.github.com/users/ruddell/received_events","type":"User","site_admin":false},"body":"This PR does the following:\r\n - Fix React Gateway UAA paths (currently can't register or use user-management)\r\n - Implements `SERVER_API_URL` for all requests in the React client (through Axios Interceptor)\r\n - Fixes React app when running on a context-path other than `/`\r\n - Fixes error notifications on 401 when running on a context-path other than `/`\r\n - Removes unused/empty register.ts file\r\n\r\nPlease make sure the below checklist is followed for Pull Requests.\r\n\r\n- [ ] [Travis tests](https://travis-ci.org/jhipster/generator-jhipster/pull_requests) are green\r\n- [x] Tests are added where necessary\r\n- [x] Documentation is added/updated where necessary\r\n- [x] Coding Rules & Commit Guidelines as per our [CONTRIBUTING.md document](https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md) are followed\r\n\r\n<!--\r\nPlease also reference the issue number in a commit message to [automatically close the related Github issue](https://help.github.com/articles/closing-issues-via-commit-messages/)\r\n\r\nNote: It is also possible to add `[skip ci]` to your commit message to skip Travis tests\r\n-->\r\n","created_at":"2018-07-06T22:34:33Z","updated_at":"2018-07-07T09:58:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99cafe3409800c8e55739188f05e8567cbef61dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7936/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/be891b392635aeedaa3931bbd4d274de84a9eeb7","head":{"label":"ruddell:react-uaa-and-relative-paths","ref":"react-uaa-and-relative-paths","sha":"be891b392635aeedaa3931bbd4d274de84a9eeb7","user":{"login":"ruddell","id":4294623,"node_id":"MDQ6VXNlcjQyOTQ2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4294623?v=4","gravatar_id":"","url":"https://api.github.com/users/ruddell","html_url":"https://github.com/ruddell","followers_url":"https://api.github.com/users/ruddell/followers","following_url":"https://api.github.com/users/ruddell/following{/other_user}","gists_url":"https://api.github.com/users/ruddell/gists{/gist_id}","starred_url":"https://api.github.com/users/ruddell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruddell/subscriptions","organizations_url":"https://api.github.com/users/ruddell/orgs","repos_url":"https://api.github.com/users/ruddell/repos","events_url":"https://api.github.com/users/ruddell/events{/privacy}","received_events_url":"https://api.github.com/users/ruddell/received_events","type":"User","site_admin":false},"repo":{"id":49409828,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQwOTgyOA==","name":"generator-jhipster","full_name":"ruddell/generator-jhipster","owner":{"login":"ruddell","id":4294623,"node_id":"MDQ6VXNlcjQyOTQ2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4294623?v=4","gravatar_id":"","url":"https://api.github.com/users/ruddell","html_url":"https://github.com/ruddell","followers_url":"https://api.github.com/users/ruddell/followers","following_url":"https://api.github.com/users/ruddell/following{/other_user}","gists_url":"https://api.github.com/users/ruddell/gists{/gist_id}","starred_url":"https://api.github.com/users/ruddell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruddell/subscriptions","organizations_url":"https://api.github.com/users/ruddell/orgs","repos_url":"https://api.github.com/users/ruddell/repos","events_url":"https://api.github.com/users/ruddell/events{/privacy}","received_events_url":"https://api.github.com/users/ruddell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruddell/generator-jhipster","description":"Hipster stack for Java developers. Yeoman + Maven + Spring + AngularJS in one handy generator.","fork":true,"url":"https://api.github.com/repos/ruddell/generator-jhipster","forks_url":"https://api.github.com/repos/ruddell/generator-jhipster/forks","keys_url":"https://api.github.com/repos/ruddell/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruddell/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruddell/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/ruddell/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/ruddell/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/ruddell/generator-jhipster/events","assignees_url":"https://api.github.com/repos/ruddell/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/ruddell/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/ruddell/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruddell/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/ruddell/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/ruddell/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/ruddell/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/ruddell/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/ruddell/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/ruddell/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruddell/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruddell/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruddell/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/ruddell/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruddell/generator-jhipster/merges","archive_url":"https://api.github.com/repos/ruddell/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruddell/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/ruddell/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/ruddell/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/ruddell/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/ruddell/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruddell/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/ruddell/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/ruddell/generator-jhipster/deployments","created_at":"2016-01-11T07:35:45Z","updated_at":"2018-07-04T03:18:10Z","pushed_at":"2018-07-06T21:24:51Z","git_url":"git://github.com/ruddell/generator-jhipster.git","ssh_url":"git@github.com:ruddell/generator-jhipster.git","clone_url":"https://github.com/ruddell/generator-jhipster.git","svn_url":"https://github.com/ruddell/generator-jhipster","homepage":"http://jhipster.github.io","size":32055,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"9776d588afe84a908a342935066a17fefdf25748","user":{"login":"jhipster","id":6059488,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTk0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MzYzNg==","name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTk0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular/React projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2018-07-07T06:42:59Z","pushed_at":"2018-07-06T22:34:33Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"https://www.jhipster.tech","size":32159,"stargazers_count":10895,"watchers_count":10895,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2326,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2326,"open_issues":55,"watchers":10895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/7936"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7936"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7936/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7936/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/be891b392635aeedaa3931bbd4d274de84a9eeb7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"deepu105"}}