{"comment":{"url":"https://api.github.com/repos/scummvm/scummvm/comments/31578930","html_url":"https://github.com/scummvm/scummvm/commit/e3da5e043c873c241d142b688a646b268371a852#commitcomment-31578930","id":31578930,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMTU3ODkzMA==","user":{"login":"zeldin","id":411296,"node_id":"MDQ6VXNlcjQxMTI5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/411296?v=4","gravatar_id":"","url":"https://api.github.com/users/zeldin","html_url":"https://github.com/zeldin","followers_url":"https://api.github.com/users/zeldin/followers","following_url":"https://api.github.com/users/zeldin/following{/other_user}","gists_url":"https://api.github.com/users/zeldin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeldin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeldin/subscriptions","organizations_url":"https://api.github.com/users/zeldin/orgs","repos_url":"https://api.github.com/users/zeldin/repos","events_url":"https://api.github.com/users/zeldin/events{/privacy}","received_events_url":"https://api.github.com/users/zeldin/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"e3da5e043c873c241d142b688a646b268371a852","created_at":"2018-12-06T08:47:57Z","updated_at":"2018-12-06T08:47:57Z","author_association":"MEMBER","body":"\nKirben <notifications@github.com> writes:\n\n> It would be best to revert these changes, and look at an alternative method.\n> The failures are due to including SDL in test programs that make no use of\n> SDL, which always results in problems on the Windows side.\n\nI've reverted the commits for now, and \"solved\" the immediate problem of\nDreamcast builds not getting zlib and MAD by putting back the hardcoded\nenablers which were removed in 7557f17.\n\nGoing forward I think it would be better if the auto-detection worked\ncorrectly, i.e. would detect libraries which can be used in the actual\napplication, and not detect those which can't.  :-)  In this specific\ninstance it fails to find header files in directories added to INCLUDES\nby the port, while these can be found just fine by the application\n(which honors INCLUDES).\n\n\n  // Marcus\n\n\n-- \n--------------------------------------------------------------------------\nMarcus Comstedt                          Lysator Academic Computer Society\nmarcus@lysator.liu.se                    Linköping University, Sweden   //\n----------------------------------------------------------------------\\X/-\n"}}
{"actor":{"display_login":"zeldin"}}