{"action":"created","comment":{"url":"https://api.github.com/repos/uber/cadence/pulls/comments/190013225","pull_request_review_id":122304093,"id":190013225,"diff_hunk":"@@ -2076,15 +2076,23 @@ func (wh *WorkflowHandler) validateTaskList(t *gen.TaskList, scope int) error {\n \treturn nil\n }\n \n-func (wh *WorkflowHandler) validateExecution(w *gen.WorkflowExecution, scope int) error {\n+func (wh *WorkflowHandler) validateExecutionAndEmitMetrics(w *gen.WorkflowExecution, scope int) error {\n+\terr := validateExecution(w)\n+\tif err != nil {\n+\t\twh.error(err, scope)","path":"service/frontend/workflowHandler.go","position":62,"original_position":62,"commit_id":"1e255f71b99de5ddeb5ebb041a367fd8b4d5bb24","original_commit_id":"1e255f71b99de5ddeb5ebb041a367fd8b4d5bb24","user":{"login":"vancexu","id":1283368,"avatar_url":"https://avatars0.githubusercontent.com/u/1283368?v=4","gravatar_id":"","url":"https://api.github.com/users/vancexu","html_url":"https://github.com/vancexu","followers_url":"https://api.github.com/users/vancexu/followers","following_url":"https://api.github.com/users/vancexu/following{/other_user}","gists_url":"https://api.github.com/users/vancexu/gists{/gist_id}","starred_url":"https://api.github.com/users/vancexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancexu/subscriptions","organizations_url":"https://api.github.com/users/vancexu/orgs","repos_url":"https://api.github.com/users/vancexu/repos","events_url":"https://api.github.com/users/vancexu/events{/privacy}","received_events_url":"https://api.github.com/users/vancexu/received_events","type":"User","site_admin":false},"body":"did you forget `return wh.error`","created_at":"2018-05-22T18:49:10Z","updated_at":"2018-05-22T18:49:10Z","html_url":"https://github.com/uber/cadence/pull/762#discussion_r190013225","pull_request_url":"https://api.github.com/repos/uber/cadence/pulls/762","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/cadence/pulls/comments/190013225"},"html":{"href":"https://github.com/uber/cadence/pull/762#discussion_r190013225"},"pull_request":{"href":"https://api.github.com/repos/uber/cadence/pulls/762"}}},"pull_request":{"url":"https://api.github.com/repos/uber/cadence/pulls/762","id":189162605,"html_url":"https://github.com/uber/cadence/pull/762","diff_url":"https://github.com/uber/cadence/pull/762.diff","patch_url":"https://github.com/uber/cadence/pull/762.patch","issue_url":"https://api.github.com/repos/uber/cadence/issues/762","number":762,"state":"open","locked":false,"title":"Add first admin API: InquiryWorkflowExecution","user":{"login":"longquanzheng","id":4523955,"avatar_url":"https://avatars0.githubusercontent.com/u/4523955?v=4","gravatar_id":"","url":"https://api.github.com/users/longquanzheng","html_url":"https://github.com/longquanzheng","followers_url":"https://api.github.com/users/longquanzheng/followers","following_url":"https://api.github.com/users/longquanzheng/following{/other_user}","gists_url":"https://api.github.com/users/longquanzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/longquanzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longquanzheng/subscriptions","organizations_url":"https://api.github.com/users/longquanzheng/orgs","repos_url":"https://api.github.com/users/longquanzheng/repos","events_url":"https://api.github.com/users/longquanzheng/events{/privacy}","received_events_url":"https://api.github.com/users/longquanzheng/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-19T00:56:20Z","updated_at":"2018-05-22T18:49:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"433e53223fcba8a66cadd0a3f51861d3ddc3528b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samarabbas","id":1766515,"avatar_url":"https://avatars1.githubusercontent.com/u/1766515?v=4","gravatar_id":"","url":"https://api.github.com/users/samarabbas","html_url":"https://github.com/samarabbas","followers_url":"https://api.github.com/users/samarabbas/followers","following_url":"https://api.github.com/users/samarabbas/following{/other_user}","gists_url":"https://api.github.com/users/samarabbas/gists{/gist_id}","starred_url":"https://api.github.com/users/samarabbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samarabbas/subscriptions","organizations_url":"https://api.github.com/users/samarabbas/orgs","repos_url":"https://api.github.com/users/samarabbas/repos","events_url":"https://api.github.com/users/samarabbas/events{/privacy}","received_events_url":"https://api.github.com/users/samarabbas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/cadence/pulls/762/commits","review_comments_url":"https://api.github.com/repos/uber/cadence/pulls/762/comments","review_comment_url":"https://api.github.com/repos/uber/cadence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/cadence/issues/762/comments","statuses_url":"https://api.github.com/repos/uber/cadence/statuses/1e255f71b99de5ddeb5ebb041a367fd8b4d5bb24","head":{"label":"longquanzheng:admin-dev","ref":"admin-dev","sha":"1e255f71b99de5ddeb5ebb041a367fd8b4d5bb24","user":{"login":"longquanzheng","id":4523955,"avatar_url":"https://avatars0.githubusercontent.com/u/4523955?v=4","gravatar_id":"","url":"https://api.github.com/users/longquanzheng","html_url":"https://github.com/longquanzheng","followers_url":"https://api.github.com/users/longquanzheng/followers","following_url":"https://api.github.com/users/longquanzheng/following{/other_user}","gists_url":"https://api.github.com/users/longquanzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/longquanzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longquanzheng/subscriptions","organizations_url":"https://api.github.com/users/longquanzheng/orgs","repos_url":"https://api.github.com/users/longquanzheng/repos","events_url":"https://api.github.com/users/longquanzheng/events{/privacy}","received_events_url":"https://api.github.com/users/longquanzheng/received_events","type":"User","site_admin":false},"repo":{"id":104277777,"name":"cadence","full_name":"longquanzheng/cadence","owner":{"login":"longquanzheng","id":4523955,"avatar_url":"https://avatars0.githubusercontent.com/u/4523955?v=4","gravatar_id":"","url":"https://api.github.com/users/longquanzheng","html_url":"https://github.com/longquanzheng","followers_url":"https://api.github.com/users/longquanzheng/followers","following_url":"https://api.github.com/users/longquanzheng/following{/other_user}","gists_url":"https://api.github.com/users/longquanzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/longquanzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longquanzheng/subscriptions","organizations_url":"https://api.github.com/users/longquanzheng/orgs","repos_url":"https://api.github.com/users/longquanzheng/repos","events_url":"https://api.github.com/users/longquanzheng/events{/privacy}","received_events_url":"https://api.github.com/users/longquanzheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/longquanzheng/cadence","description":"Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.","fork":true,"url":"https://api.github.com/repos/longquanzheng/cadence","forks_url":"https://api.github.com/repos/longquanzheng/cadence/forks","keys_url":"https://api.github.com/repos/longquanzheng/cadence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/longquanzheng/cadence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/longquanzheng/cadence/teams","hooks_url":"https://api.github.com/repos/longquanzheng/cadence/hooks","issue_events_url":"https://api.github.com/repos/longquanzheng/cadence/issues/events{/number}","events_url":"https://api.github.com/repos/longquanzheng/cadence/events","assignees_url":"https://api.github.com/repos/longquanzheng/cadence/assignees{/user}","branches_url":"https://api.github.com/repos/longquanzheng/cadence/branches{/branch}","tags_url":"https://api.github.com/repos/longquanzheng/cadence/tags","blobs_url":"https://api.github.com/repos/longquanzheng/cadence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/longquanzheng/cadence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/longquanzheng/cadence/git/refs{/sha}","trees_url":"https://api.github.com/repos/longquanzheng/cadence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/longquanzheng/cadence/statuses/{sha}","languages_url":"https://api.github.com/repos/longquanzheng/cadence/languages","stargazers_url":"https://api.github.com/repos/longquanzheng/cadence/stargazers","contributors_url":"https://api.github.com/repos/longquanzheng/cadence/contributors","subscribers_url":"https://api.github.com/repos/longquanzheng/cadence/subscribers","subscription_url":"https://api.github.com/repos/longquanzheng/cadence/subscription","commits_url":"https://api.github.com/repos/longquanzheng/cadence/commits{/sha}","git_commits_url":"https://api.github.com/repos/longquanzheng/cadence/git/commits{/sha}","comments_url":"https://api.github.com/repos/longquanzheng/cadence/comments{/number}","issue_comment_url":"https://api.github.com/repos/longquanzheng/cadence/issues/comments{/number}","contents_url":"https://api.github.com/repos/longquanzheng/cadence/contents/{+path}","compare_url":"https://api.github.com/repos/longquanzheng/cadence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/longquanzheng/cadence/merges","archive_url":"https://api.github.com/repos/longquanzheng/cadence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/longquanzheng/cadence/downloads","issues_url":"https://api.github.com/repos/longquanzheng/cadence/issues{/number}","pulls_url":"https://api.github.com/repos/longquanzheng/cadence/pulls{/number}","milestones_url":"https://api.github.com/repos/longquanzheng/cadence/milestones{/number}","notifications_url":"https://api.github.com/repos/longquanzheng/cadence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/longquanzheng/cadence/labels{/name}","releases_url":"https://api.github.com/repos/longquanzheng/cadence/releases{/id}","deployments_url":"https://api.github.com/repos/longquanzheng/cadence/deployments","created_at":"2017-09-20T23:25:52Z","updated_at":"2018-05-18T23:19:46Z","pushed_at":"2018-05-22T18:38:13Z","git_url":"git://github.com/longquanzheng/cadence.git","ssh_url":"git@github.com:longquanzheng/cadence.git","clone_url":"https://github.com/longquanzheng/cadence.git","svn_url":"https://github.com/longquanzheng/cadence","homepage":"","size":13664,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"898ff2b7c40120495d9e0a09b579de1550a65b16","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":82700090,"name":"cadence","full_name":"uber/cadence","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/cadence","description":"Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.","fork":false,"url":"https://api.github.com/repos/uber/cadence","forks_url":"https://api.github.com/repos/uber/cadence/forks","keys_url":"https://api.github.com/repos/uber/cadence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/cadence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/cadence/teams","hooks_url":"https://api.github.com/repos/uber/cadence/hooks","issue_events_url":"https://api.github.com/repos/uber/cadence/issues/events{/number}","events_url":"https://api.github.com/repos/uber/cadence/events","assignees_url":"https://api.github.com/repos/uber/cadence/assignees{/user}","branches_url":"https://api.github.com/repos/uber/cadence/branches{/branch}","tags_url":"https://api.github.com/repos/uber/cadence/tags","blobs_url":"https://api.github.com/repos/uber/cadence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/cadence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/cadence/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/cadence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/cadence/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/cadence/languages","stargazers_url":"https://api.github.com/repos/uber/cadence/stargazers","contributors_url":"https://api.github.com/repos/uber/cadence/contributors","subscribers_url":"https://api.github.com/repos/uber/cadence/subscribers","subscription_url":"https://api.github.com/repos/uber/cadence/subscription","commits_url":"https://api.github.com/repos/uber/cadence/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/cadence/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/cadence/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/cadence/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/cadence/contents/{+path}","compare_url":"https://api.github.com/repos/uber/cadence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/cadence/merges","archive_url":"https://api.github.com/repos/uber/cadence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/cadence/downloads","issues_url":"https://api.github.com/repos/uber/cadence/issues{/number}","pulls_url":"https://api.github.com/repos/uber/cadence/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/cadence/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/cadence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/cadence/labels{/name}","releases_url":"https://api.github.com/repos/uber/cadence/releases{/id}","deployments_url":"https://api.github.com/repos/uber/cadence/deployments","created_at":"2017-02-21T16:10:18Z","updated_at":"2018-05-21T23:27:50Z","pushed_at":"2018-05-22T18:38:14Z","git_url":"git://github.com/uber/cadence.git","ssh_url":"git@github.com:uber/cadence.git","clone_url":"https://github.com/uber/cadence.git","svn_url":"https://github.com/uber/cadence","homepage":"","size":13745,"stargazers_count":334,"watchers_count":334,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":42,"open_issues":135,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/cadence/pulls/762"},"html":{"href":"https://github.com/uber/cadence/pull/762"},"issue":{"href":"https://api.github.com/repos/uber/cadence/issues/762"},"comments":{"href":"https://api.github.com/repos/uber/cadence/issues/762/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/cadence/pulls/762/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/cadence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/cadence/pulls/762/commits"},"statuses":{"href":"https://api.github.com/repos/uber/cadence/statuses/1e255f71b99de5ddeb5ebb041a367fd8b4d5bb24"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vancexu"}}