{"action":"opened","issue":{"url":"https://api.github.com/repos/laravel/ideas/issues/1391","repository_url":"https://api.github.com/repos/laravel/ideas","labels_url":"https://api.github.com/repos/laravel/ideas/issues/1391/labels{/name}","comments_url":"https://api.github.com/repos/laravel/ideas/issues/1391/comments","events_url":"https://api.github.com/repos/laravel/ideas/issues/1391/events","html_url":"https://github.com/laravel/ideas/issues/1391","id":381362391,"node_id":"MDU6SXNzdWUzODEzNjIzOTE=","number":1391,"title":"Deprecate/remove Arr::sortRecursive() and array_sort_recursive()","user":{"login":"vlakoff","id":544424,"node_id":"MDQ6VXNlcjU0NDQyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/544424?v=4","gravatar_id":"","url":"https://api.github.com/users/vlakoff","html_url":"https://github.com/vlakoff","followers_url":"https://api.github.com/users/vlakoff/followers","following_url":"https://api.github.com/users/vlakoff/following{/other_user}","gists_url":"https://api.github.com/users/vlakoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vlakoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlakoff/subscriptions","organizations_url":"https://api.github.com/users/vlakoff/orgs","repos_url":"https://api.github.com/users/vlakoff/repos","events_url":"https://api.github.com/users/vlakoff/events{/privacy}","received_events_url":"https://api.github.com/users/vlakoff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-15T22:14:48Z","updated_at":"2018-11-15T22:14:48Z","closed_at":null,"author_association":"NONE","body":"See https://github.com/laravel/framework/pull/26526, and in particular https://github.com/laravel/framework/pull/26526#issuecomment-439200067:\r\n\r\n> Another thing, I don't like much `Arr::sortRecursive` because it sorts indexed arrays by values, and associative arrays by keys... This is quite a specific behaviour, and was designed specifically for this `assertExactJson` method.\r\n> \r\n> Same goes for this new `Arr::sortAssocRecursive` method.\r\n> \r\n> I think we may consider:\r\n> \r\n> * deprecate/remove `Arr::sortRecursive` (and `array_sort_recursive`) as they would now be unused by Laravel,\r\n> \r\n> * and move `Arr::sortAssocRecursive` to a protected method `TestResponse::sortAssocRecursive`\r\n> \r\n> \r\n> If you agree on the principle, this could be posted on [laravel/ideas](https://github.com/laravel/ideas), or if there is a clear consensus, just directly submit a PR."}}
{"actor":{"display_login":"vlakoff"}}