{"action":"created","issue":{"url":"https://api.github.com/repos/fallahn/xygine/issues/78","repository_url":"https://api.github.com/repos/fallahn/xygine","labels_url":"https://api.github.com/repos/fallahn/xygine/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/fallahn/xygine/issues/78/comments","events_url":"https://api.github.com/repos/fallahn/xygine/issues/78/events","html_url":"https://github.com/fallahn/xygine/pull/78","id":306290700,"number":78,"title":"In game editor implementation","user":{"login":"JonnyPtn","id":8862274,"avatar_url":"https://avatars0.githubusercontent.com/u/8862274?v=4","gravatar_id":"","url":"https://api.github.com/users/JonnyPtn","html_url":"https://github.com/JonnyPtn","followers_url":"https://api.github.com/users/JonnyPtn/followers","following_url":"https://api.github.com/users/JonnyPtn/following{/other_user}","gists_url":"https://api.github.com/users/JonnyPtn/gists{/gist_id}","starred_url":"https://api.github.com/users/JonnyPtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonnyPtn/subscriptions","organizations_url":"https://api.github.com/users/JonnyPtn/orgs","repos_url":"https://api.github.com/users/JonnyPtn/repos","events_url":"https://api.github.com/users/JonnyPtn/events{/privacy}","received_events_url":"https://api.github.com/users/JonnyPtn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-18T22:29:40Z","updated_at":"2018-03-18T23:27:08Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fallahn/xygine/pulls/78","html_url":"https://github.com/fallahn/xygine/pull/78","diff_url":"https://github.com/fallahn/xygine/pull/78.diff","patch_url":"https://github.com/fallahn/xygine/pull/78.patch"},"body":"Disclaimer: Most of this happened accidentally, at various levels of sobriety, without any real plan.\r\n\r\nThe biggest change is xy::App::getRenderTarget() replaces getRenderWindow(). This allows the editor to show the game viewport by switching out from a RenderWindow to a RenderTexture, without any change to the end users code. I also removed the RenderWindow* from State::Context, as it didn't seem necessary, and will enforce the use of getRenderTarget() instead\r\n\r\nI also added an Editable base class, so other classes can inherit this then implement the editorDraw() method to show their own windows in the editor. I'm not entirely convinced this is the best way to allow classes to interface with the editor, it just happens to be the implementation I ended up doing.\r\n\r\nI've updated the demo to work with the editor, So have a play around and let me know what you think. It's mostly a proof of concept at this point, so radical suggestions are certainly welcome.\r\n\r\nThis may be a longer term project, so if you want to set up a separate branch for it feel free, and I'll re-target this PR."},"comment":{"url":"https://api.github.com/repos/fallahn/xygine/issues/comments/374066150","html_url":"https://github.com/fallahn/xygine/pull/78#issuecomment-374066150","issue_url":"https://api.github.com/repos/fallahn/xygine/issues/78","id":374066150,"user":{"login":"JonnyPtn","id":8862274,"avatar_url":"https://avatars0.githubusercontent.com/u/8862274?v=4","gravatar_id":"","url":"https://api.github.com/users/JonnyPtn","html_url":"https://github.com/JonnyPtn","followers_url":"https://api.github.com/users/JonnyPtn/followers","following_url":"https://api.github.com/users/JonnyPtn/following{/other_user}","gists_url":"https://api.github.com/users/JonnyPtn/gists{/gist_id}","starred_url":"https://api.github.com/users/JonnyPtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonnyPtn/subscriptions","organizations_url":"https://api.github.com/users/JonnyPtn/orgs","repos_url":"https://api.github.com/users/JonnyPtn/repos","events_url":"https://api.github.com/users/JonnyPtn/events{/privacy}","received_events_url":"https://api.github.com/users/JonnyPtn/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T23:27:08Z","updated_at":"2018-03-18T23:27:08Z","author_association":"COLLABORATOR","body":"CI is failing as sf::RenderTarget::setActive wasn't implmented in 2.4.2 seemingly... so you'll need to use latest SFML until I can solve that one"}}
{"actor":{"display_login":"JonnyPtn"}}