{"action":"created","comment":{"url":"https://api.github.com/repos/HuwCampbell/icicle/pulls/comments/172038122","pull_request_review_id":100995747,"id":172038122,"diff_hunk":"@@ -108,17 +107,36 @@ convertExpQ q\n  $ case contexts q of\n     []\n      -> convertExp $ final q\n-    (Let _ b d:cs)\n+    (Let _ PatDefault _:cs)\n+     ->     -- A pattern with no binding doesn't need to inspect its arguments\n+            convertExpQ $ Query cs $ final q\n+    (Let _ (PatVariable b) d:cs)\n      -> do  d' <- convertExp d\n             -- NB: because it's non-recursive let, the freshen must be done after the definition\n             b' <- convertFreshenAdd b\n             x' <- convertExpQ $ Query cs $ final q\n             return $ CE.XLet () b' d' x'\n+    -- (Let ann (PatCon ConTuple [PatVariable na, PatVariable nb]) bound:cs)","path":"icicle-source/src/Icicle/Source/ToCore/Exp.hs","position":31,"original_position":31,"commit_id":"f0f93359258cd401e386c2493c51c0a2280d0555","original_commit_id":"f0f93359258cd401e386c2493c51c0a2280d0555","user":{"login":"HuwCampbell","id":5205457,"avatar_url":"https://avatars0.githubusercontent.com/u/5205457?v=4","gravatar_id":"","url":"https://api.github.com/users/HuwCampbell","html_url":"https://github.com/HuwCampbell","followers_url":"https://api.github.com/users/HuwCampbell/followers","following_url":"https://api.github.com/users/HuwCampbell/following{/other_user}","gists_url":"https://api.github.com/users/HuwCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/HuwCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuwCampbell/subscriptions","organizations_url":"https://api.github.com/users/HuwCampbell/orgs","repos_url":"https://api.github.com/users/HuwCampbell/repos","events_url":"https://api.github.com/users/HuwCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/HuwCampbell/received_events","type":"User","site_admin":false},"body":"Yeah, I tried to do the translation here first, but it was a bit subtle. I had it working for `let`, but then some possibilities code was breaking.","created_at":"2018-03-04T05:58:01Z","updated_at":"2018-03-04T05:58:01Z","html_url":"https://github.com/HuwCampbell/icicle/pull/1#discussion_r172038122","pull_request_url":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/HuwCampbell/icicle/pulls/comments/172038122"},"html":{"href":"https://github.com/HuwCampbell/icicle/pull/1#discussion_r172038122"},"pull_request":{"href":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1"}},"in_reply_to_id":172028943},"pull_request":{"url":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1","id":172645921,"html_url":"https://github.com/HuwCampbell/icicle/pull/1","diff_url":"https://github.com/HuwCampbell/icicle/pull/1.diff","patch_url":"https://github.com/HuwCampbell/icicle/pull/1.patch","issue_url":"https://api.github.com/repos/HuwCampbell/icicle/issues/1","number":1,"state":"open","locked":false,"title":"Topic/let patterns","user":{"login":"HuwCampbell","id":5205457,"avatar_url":"https://avatars0.githubusercontent.com/u/5205457?v=4","gravatar_id":"","url":"https://api.github.com/users/HuwCampbell","html_url":"https://github.com/HuwCampbell","followers_url":"https://api.github.com/users/HuwCampbell/followers","following_url":"https://api.github.com/users/HuwCampbell/following{/other_user}","gists_url":"https://api.github.com/users/HuwCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/HuwCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuwCampbell/subscriptions","organizations_url":"https://api.github.com/users/HuwCampbell/orgs","repos_url":"https://api.github.com/users/HuwCampbell/repos","events_url":"https://api.github.com/users/HuwCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/HuwCampbell/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-03T02:44:45Z","updated_at":"2018-03-04T05:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db878012f62640b49477315736b4d1cf7d3870c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1/commits","review_comments_url":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1/comments","review_comment_url":"https://api.github.com/repos/HuwCampbell/icicle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HuwCampbell/icicle/issues/1/comments","statuses_url":"https://api.github.com/repos/HuwCampbell/icicle/statuses/f0f93359258cd401e386c2493c51c0a2280d0555","head":{"label":"HuwCampbell:topic/let-patterns","ref":"topic/let-patterns","sha":"f0f93359258cd401e386c2493c51c0a2280d0555","user":{"login":"HuwCampbell","id":5205457,"avatar_url":"https://avatars0.githubusercontent.com/u/5205457?v=4","gravatar_id":"","url":"https://api.github.com/users/HuwCampbell","html_url":"https://github.com/HuwCampbell","followers_url":"https://api.github.com/users/HuwCampbell/followers","following_url":"https://api.github.com/users/HuwCampbell/following{/other_user}","gists_url":"https://api.github.com/users/HuwCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/HuwCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuwCampbell/subscriptions","organizations_url":"https://api.github.com/users/HuwCampbell/orgs","repos_url":"https://api.github.com/users/HuwCampbell/repos","events_url":"https://api.github.com/users/HuwCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/HuwCampbell/received_events","type":"User","site_admin":false},"repo":{"id":107489225,"name":"icicle","full_name":"HuwCampbell/icicle","owner":{"login":"HuwCampbell","id":5205457,"avatar_url":"https://avatars0.githubusercontent.com/u/5205457?v=4","gravatar_id":"","url":"https://api.github.com/users/HuwCampbell","html_url":"https://github.com/HuwCampbell","followers_url":"https://api.github.com/users/HuwCampbell/followers","following_url":"https://api.github.com/users/HuwCampbell/following{/other_user}","gists_url":"https://api.github.com/users/HuwCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/HuwCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuwCampbell/subscriptions","organizations_url":"https://api.github.com/users/HuwCampbell/orgs","repos_url":"https://api.github.com/users/HuwCampbell/repos","events_url":"https://api.github.com/users/HuwCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/HuwCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HuwCampbell/icicle","description":"A streaming query language.","fork":true,"url":"https://api.github.com/repos/HuwCampbell/icicle","forks_url":"https://api.github.com/repos/HuwCampbell/icicle/forks","keys_url":"https://api.github.com/repos/HuwCampbell/icicle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuwCampbell/icicle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuwCampbell/icicle/teams","hooks_url":"https://api.github.com/repos/HuwCampbell/icicle/hooks","issue_events_url":"https://api.github.com/repos/HuwCampbell/icicle/issues/events{/number}","events_url":"https://api.github.com/repos/HuwCampbell/icicle/events","assignees_url":"https://api.github.com/repos/HuwCampbell/icicle/assignees{/user}","branches_url":"https://api.github.com/repos/HuwCampbell/icicle/branches{/branch}","tags_url":"https://api.github.com/repos/HuwCampbell/icicle/tags","blobs_url":"https://api.github.com/repos/HuwCampbell/icicle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuwCampbell/icicle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuwCampbell/icicle/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuwCampbell/icicle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuwCampbell/icicle/statuses/{sha}","languages_url":"https://api.github.com/repos/HuwCampbell/icicle/languages","stargazers_url":"https://api.github.com/repos/HuwCampbell/icicle/stargazers","contributors_url":"https://api.github.com/repos/HuwCampbell/icicle/contributors","subscribers_url":"https://api.github.com/repos/HuwCampbell/icicle/subscribers","subscription_url":"https://api.github.com/repos/HuwCampbell/icicle/subscription","commits_url":"https://api.github.com/repos/HuwCampbell/icicle/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuwCampbell/icicle/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuwCampbell/icicle/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuwCampbell/icicle/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuwCampbell/icicle/contents/{+path}","compare_url":"https://api.github.com/repos/HuwCampbell/icicle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuwCampbell/icicle/merges","archive_url":"https://api.github.com/repos/HuwCampbell/icicle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuwCampbell/icicle/downloads","issues_url":"https://api.github.com/repos/HuwCampbell/icicle/issues{/number}","pulls_url":"https://api.github.com/repos/HuwCampbell/icicle/pulls{/number}","milestones_url":"https://api.github.com/repos/HuwCampbell/icicle/milestones{/number}","notifications_url":"https://api.github.com/repos/HuwCampbell/icicle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuwCampbell/icicle/labels{/name}","releases_url":"https://api.github.com/repos/HuwCampbell/icicle/releases{/id}","deployments_url":"https://api.github.com/repos/HuwCampbell/icicle/deployments","created_at":"2017-10-19T02:39:22Z","updated_at":"2017-10-19T02:39:25Z","pushed_at":"2018-03-03T02:44:46Z","git_url":"git://github.com/HuwCampbell/icicle.git","ssh_url":"git@github.com:HuwCampbell/icicle.git","clone_url":"https://github.com/HuwCampbell/icicle.git","svn_url":"https://github.com/HuwCampbell/icicle","homepage":null,"size":14044,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"HuwCampbell:master","ref":"master","sha":"62fe9cc6138b563c66c600ba5609d6391b6d477f","user":{"login":"HuwCampbell","id":5205457,"avatar_url":"https://avatars0.githubusercontent.com/u/5205457?v=4","gravatar_id":"","url":"https://api.github.com/users/HuwCampbell","html_url":"https://github.com/HuwCampbell","followers_url":"https://api.github.com/users/HuwCampbell/followers","following_url":"https://api.github.com/users/HuwCampbell/following{/other_user}","gists_url":"https://api.github.com/users/HuwCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/HuwCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuwCampbell/subscriptions","organizations_url":"https://api.github.com/users/HuwCampbell/orgs","repos_url":"https://api.github.com/users/HuwCampbell/repos","events_url":"https://api.github.com/users/HuwCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/HuwCampbell/received_events","type":"User","site_admin":false},"repo":{"id":107489225,"name":"icicle","full_name":"HuwCampbell/icicle","owner":{"login":"HuwCampbell","id":5205457,"avatar_url":"https://avatars0.githubusercontent.com/u/5205457?v=4","gravatar_id":"","url":"https://api.github.com/users/HuwCampbell","html_url":"https://github.com/HuwCampbell","followers_url":"https://api.github.com/users/HuwCampbell/followers","following_url":"https://api.github.com/users/HuwCampbell/following{/other_user}","gists_url":"https://api.github.com/users/HuwCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/HuwCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuwCampbell/subscriptions","organizations_url":"https://api.github.com/users/HuwCampbell/orgs","repos_url":"https://api.github.com/users/HuwCampbell/repos","events_url":"https://api.github.com/users/HuwCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/HuwCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HuwCampbell/icicle","description":"A streaming query language.","fork":true,"url":"https://api.github.com/repos/HuwCampbell/icicle","forks_url":"https://api.github.com/repos/HuwCampbell/icicle/forks","keys_url":"https://api.github.com/repos/HuwCampbell/icicle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuwCampbell/icicle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuwCampbell/icicle/teams","hooks_url":"https://api.github.com/repos/HuwCampbell/icicle/hooks","issue_events_url":"https://api.github.com/repos/HuwCampbell/icicle/issues/events{/number}","events_url":"https://api.github.com/repos/HuwCampbell/icicle/events","assignees_url":"https://api.github.com/repos/HuwCampbell/icicle/assignees{/user}","branches_url":"https://api.github.com/repos/HuwCampbell/icicle/branches{/branch}","tags_url":"https://api.github.com/repos/HuwCampbell/icicle/tags","blobs_url":"https://api.github.com/repos/HuwCampbell/icicle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuwCampbell/icicle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuwCampbell/icicle/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuwCampbell/icicle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuwCampbell/icicle/statuses/{sha}","languages_url":"https://api.github.com/repos/HuwCampbell/icicle/languages","stargazers_url":"https://api.github.com/repos/HuwCampbell/icicle/stargazers","contributors_url":"https://api.github.com/repos/HuwCampbell/icicle/contributors","subscribers_url":"https://api.github.com/repos/HuwCampbell/icicle/subscribers","subscription_url":"https://api.github.com/repos/HuwCampbell/icicle/subscription","commits_url":"https://api.github.com/repos/HuwCampbell/icicle/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuwCampbell/icicle/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuwCampbell/icicle/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuwCampbell/icicle/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuwCampbell/icicle/contents/{+path}","compare_url":"https://api.github.com/repos/HuwCampbell/icicle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuwCampbell/icicle/merges","archive_url":"https://api.github.com/repos/HuwCampbell/icicle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuwCampbell/icicle/downloads","issues_url":"https://api.github.com/repos/HuwCampbell/icicle/issues{/number}","pulls_url":"https://api.github.com/repos/HuwCampbell/icicle/pulls{/number}","milestones_url":"https://api.github.com/repos/HuwCampbell/icicle/milestones{/number}","notifications_url":"https://api.github.com/repos/HuwCampbell/icicle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuwCampbell/icicle/labels{/name}","releases_url":"https://api.github.com/repos/HuwCampbell/icicle/releases{/id}","deployments_url":"https://api.github.com/repos/HuwCampbell/icicle/deployments","created_at":"2017-10-19T02:39:22Z","updated_at":"2017-10-19T02:39:25Z","pushed_at":"2018-03-03T02:44:46Z","git_url":"git://github.com/HuwCampbell/icicle.git","ssh_url":"git@github.com:HuwCampbell/icicle.git","clone_url":"https://github.com/HuwCampbell/icicle.git","svn_url":"https://github.com/HuwCampbell/icicle","homepage":null,"size":14044,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1"},"html":{"href":"https://github.com/HuwCampbell/icicle/pull/1"},"issue":{"href":"https://api.github.com/repos/HuwCampbell/icicle/issues/1"},"comments":{"href":"https://api.github.com/repos/HuwCampbell/icicle/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/HuwCampbell/icicle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HuwCampbell/icicle/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/HuwCampbell/icicle/statuses/f0f93359258cd401e386c2493c51c0a2280d0555"}},"author_association":"OWNER"}}
{"actor":{"display_login":"HuwCampbell"}}