{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/princjef/font-ligatures/pulls/11","id":187861833,"html_url":"https://github.com/princjef/font-ligatures/pull/11","diff_url":"https://github.com/princjef/font-ligatures/pull/11.diff","patch_url":"https://github.com/princjef/font-ligatures/pull/11.patch","issue_url":"https://api.github.com/repos/princjef/font-ligatures/issues/11","number":11,"state":"closed","locked":false,"title":"test(benchmark): prime cache before cached tests and increase iterations","user":{"login":"princjef","id":3675357,"avatar_url":"https://avatars2.githubusercontent.com/u/3675357?v=4","gravatar_id":"","url":"https://api.github.com/users/princjef","html_url":"https://github.com/princjef","followers_url":"https://api.github.com/users/princjef/followers","following_url":"https://api.github.com/users/princjef/following{/other_user}","gists_url":"https://api.github.com/users/princjef/gists{/gist_id}","starred_url":"https://api.github.com/users/princjef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princjef/subscriptions","organizations_url":"https://api.github.com/users/princjef/orgs","repos_url":"https://api.github.com/users/princjef/repos","events_url":"https://api.github.com/users/princjef/events{/privacy}","received_events_url":"https://api.github.com/users/princjef/received_events","type":"User","site_admin":false},"body":"This fully primes the cache before cached test runs so that the test isn't impacted by the uncached times of the first pass through the input and doesn't vary as much with varying numbers of iterations.\r\n\r\nThis also bumps the number of iterations per test up from 1k to 10k to reduce the impact of the first call, which is quite slow (presumably because it's unoptimized).\r\n\r\nUpdated benchmark numbers:\r\n\r\nNAME                              | AVG    | 50%    | 95%    | AVG (CHAR) | MEM START | MEM INCREASE\r\n--------------------------------- | ------ | ------ | ------ | ---------- | --------- | ------------\r\nFira Code: code                   | 0.0365 | 0.0190 | 0.1225 | 0.0008904  | 18.1 MB   | 7.26 MB\r\nFira Code: no-ligatures           | 0.0270 | 0.0240 | 0.0500 | 0.0002920  | 25.4 MB   | 9.9 MB\r\nFira Code: code (cache)           | 0.0020 | 0.0020 | 0.0030 | 0.0000487  | 35.4 MB   | -9.82 MB\r\nFira Code: no-ligatures (cache)   | 0.0018 | 0.0020 | 0.0020 | 0.0000197  | 25.6 MB   | 9.87 MB\r\nIosevka: code                     | 0.0106 | 0.0060 | 0.0300 | 0.0002596  | 21.4 MB   | 7.33 MB\r\nIosevka: no-ligatures             | 0.0103 | 0.0070 | 0.0160 | 0.0001113  | 21.3 MB   | 17.2 MB\r\nIosevka: code (cache)             | 0.0019 | 0.0020 | 0.0020 | 0.0000452  | 21.5 MB   | 7.2 MB\r\nIosevka: no-ligatures (cache)     | 0.0019 | 0.0020 | 0.0030 | 0.0000210  | 21.5 MB   | 17.2 MB\r\nMonoid: code                      | 0.0071 | 0.0050 | 0.0160 | 0.0001728  | 12.9 MB   | 6.79 MB\r\nMonoid: no-ligatures              | 0.0101 | 0.0090 | 0.0170 | 0.0001098  | 12.7 MB   | 16.8 MB\r\nMonoid: code (cache)              | 0.0016 | 0.0010 | 0.0020 | 0.0000392  | 12.8 MB   | 6.99 MB\r\nMonoid: no-ligatures (cache)      | 0.0023 | 0.0020 | 0.0040 | 0.0000252  | 12.8 MB   | 16.8 MB\r\nUbuntu Mono: code                 | 0.0016 | 0.0010 | 0.0020 | 0.0000386  | 13.7 MB   | 6.58 MB\r\nUbuntu Mono: no-ligatures         | 0.0015 | 0.0010 | 0.0020 | 0.0000164  | 13.5 MB   | 16.6 MB\r\nUbuntu Mono: code (cache)         | 0.0018 | 0.0020 | 0.0030 | 0.0000445  | 13.5 MB   | 6.75 MB\r\nUbuntu Mono: no-ligatures (cache) | 0.0016 | 0.0010 | 0.0020 | 0.0000169  | 13.6 MB   | 16.6 MB","created_at":"2018-05-14T15:17:05Z","updated_at":"2018-05-14T15:26:08Z","closed_at":"2018-05-14T15:26:08Z","merged_at":"2018-05-14T15:26:08Z","merge_commit_sha":"c86d0c303cca2a89ad8e4c91ffde41f550dcb08f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/princjef/font-ligatures/pulls/11/commits","review_comments_url":"https://api.github.com/repos/princjef/font-ligatures/pulls/11/comments","review_comment_url":"https://api.github.com/repos/princjef/font-ligatures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/princjef/font-ligatures/issues/11/comments","statuses_url":"https://api.github.com/repos/princjef/font-ligatures/statuses/f5fd05ac9186387f575a2ee95730b1ea001ef815","head":{"label":"princjef:benchmark-improvements","ref":"benchmark-improvements","sha":"f5fd05ac9186387f575a2ee95730b1ea001ef815","user":{"login":"princjef","id":3675357,"avatar_url":"https://avatars2.githubusercontent.com/u/3675357?v=4","gravatar_id":"","url":"https://api.github.com/users/princjef","html_url":"https://github.com/princjef","followers_url":"https://api.github.com/users/princjef/followers","following_url":"https://api.github.com/users/princjef/following{/other_user}","gists_url":"https://api.github.com/users/princjef/gists{/gist_id}","starred_url":"https://api.github.com/users/princjef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princjef/subscriptions","organizations_url":"https://api.github.com/users/princjef/orgs","repos_url":"https://api.github.com/users/princjef/repos","events_url":"https://api.github.com/users/princjef/events{/privacy}","received_events_url":"https://api.github.com/users/princjef/received_events","type":"User","site_admin":false},"repo":{"id":131680508,"name":"font-ligatures","full_name":"princjef/font-ligatures","owner":{"login":"princjef","id":3675357,"avatar_url":"https://avatars2.githubusercontent.com/u/3675357?v=4","gravatar_id":"","url":"https://api.github.com/users/princjef","html_url":"https://github.com/princjef","followers_url":"https://api.github.com/users/princjef/followers","following_url":"https://api.github.com/users/princjef/following{/other_user}","gists_url":"https://api.github.com/users/princjef/gists{/gist_id}","starred_url":"https://api.github.com/users/princjef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princjef/subscriptions","organizations_url":"https://api.github.com/users/princjef/orgs","repos_url":"https://api.github.com/users/princjef/repos","events_url":"https://api.github.com/users/princjef/events{/privacy}","received_events_url":"https://api.github.com/users/princjef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/princjef/font-ligatures","description":"Find ligature replacements for any system font","fork":false,"url":"https://api.github.com/repos/princjef/font-ligatures","forks_url":"https://api.github.com/repos/princjef/font-ligatures/forks","keys_url":"https://api.github.com/repos/princjef/font-ligatures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/princjef/font-ligatures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/princjef/font-ligatures/teams","hooks_url":"https://api.github.com/repos/princjef/font-ligatures/hooks","issue_events_url":"https://api.github.com/repos/princjef/font-ligatures/issues/events{/number}","events_url":"https://api.github.com/repos/princjef/font-ligatures/events","assignees_url":"https://api.github.com/repos/princjef/font-ligatures/assignees{/user}","branches_url":"https://api.github.com/repos/princjef/font-ligatures/branches{/branch}","tags_url":"https://api.github.com/repos/princjef/font-ligatures/tags","blobs_url":"https://api.github.com/repos/princjef/font-ligatures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/princjef/font-ligatures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/princjef/font-ligatures/git/refs{/sha}","trees_url":"https://api.github.com/repos/princjef/font-ligatures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/princjef/font-ligatures/statuses/{sha}","languages_url":"https://api.github.com/repos/princjef/font-ligatures/languages","stargazers_url":"https://api.github.com/repos/princjef/font-ligatures/stargazers","contributors_url":"https://api.github.com/repos/princjef/font-ligatures/contributors","subscribers_url":"https://api.github.com/repos/princjef/font-ligatures/subscribers","subscription_url":"https://api.github.com/repos/princjef/font-ligatures/subscription","commits_url":"https://api.github.com/repos/princjef/font-ligatures/commits{/sha}","git_commits_url":"https://api.github.com/repos/princjef/font-ligatures/git/commits{/sha}","comments_url":"https://api.github.com/repos/princjef/font-ligatures/comments{/number}","issue_comment_url":"https://api.github.com/repos/princjef/font-ligatures/issues/comments{/number}","contents_url":"https://api.github.com/repos/princjef/font-ligatures/contents/{+path}","compare_url":"https://api.github.com/repos/princjef/font-ligatures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/princjef/font-ligatures/merges","archive_url":"https://api.github.com/repos/princjef/font-ligatures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/princjef/font-ligatures/downloads","issues_url":"https://api.github.com/repos/princjef/font-ligatures/issues{/number}","pulls_url":"https://api.github.com/repos/princjef/font-ligatures/pulls{/number}","milestones_url":"https://api.github.com/repos/princjef/font-ligatures/milestones{/number}","notifications_url":"https://api.github.com/repos/princjef/font-ligatures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/princjef/font-ligatures/labels{/name}","releases_url":"https://api.github.com/repos/princjef/font-ligatures/releases{/id}","deployments_url":"https://api.github.com/repos/princjef/font-ligatures/deployments","created_at":"2018-05-01T05:41:47Z","updated_at":"2018-05-12T19:12:52Z","pushed_at":"2018-05-14T15:26:08Z","git_url":"git://github.com/princjef/font-ligatures.git","ssh_url":"git@github.com:princjef/font-ligatures.git","clone_url":"https://github.com/princjef/font-ligatures.git","svn_url":"https://github.com/princjef/font-ligatures","homepage":null,"size":1137,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"princjef:master","ref":"master","sha":"68e4fd8607af45229ce78ed84072dd9c57469ecd","user":{"login":"princjef","id":3675357,"avatar_url":"https://avatars2.githubusercontent.com/u/3675357?v=4","gravatar_id":"","url":"https://api.github.com/users/princjef","html_url":"https://github.com/princjef","followers_url":"https://api.github.com/users/princjef/followers","following_url":"https://api.github.com/users/princjef/following{/other_user}","gists_url":"https://api.github.com/users/princjef/gists{/gist_id}","starred_url":"https://api.github.com/users/princjef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princjef/subscriptions","organizations_url":"https://api.github.com/users/princjef/orgs","repos_url":"https://api.github.com/users/princjef/repos","events_url":"https://api.github.com/users/princjef/events{/privacy}","received_events_url":"https://api.github.com/users/princjef/received_events","type":"User","site_admin":false},"repo":{"id":131680508,"name":"font-ligatures","full_name":"princjef/font-ligatures","owner":{"login":"princjef","id":3675357,"avatar_url":"https://avatars2.githubusercontent.com/u/3675357?v=4","gravatar_id":"","url":"https://api.github.com/users/princjef","html_url":"https://github.com/princjef","followers_url":"https://api.github.com/users/princjef/followers","following_url":"https://api.github.com/users/princjef/following{/other_user}","gists_url":"https://api.github.com/users/princjef/gists{/gist_id}","starred_url":"https://api.github.com/users/princjef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princjef/subscriptions","organizations_url":"https://api.github.com/users/princjef/orgs","repos_url":"https://api.github.com/users/princjef/repos","events_url":"https://api.github.com/users/princjef/events{/privacy}","received_events_url":"https://api.github.com/users/princjef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/princjef/font-ligatures","description":"Find ligature replacements for any system font","fork":false,"url":"https://api.github.com/repos/princjef/font-ligatures","forks_url":"https://api.github.com/repos/princjef/font-ligatures/forks","keys_url":"https://api.github.com/repos/princjef/font-ligatures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/princjef/font-ligatures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/princjef/font-ligatures/teams","hooks_url":"https://api.github.com/repos/princjef/font-ligatures/hooks","issue_events_url":"https://api.github.com/repos/princjef/font-ligatures/issues/events{/number}","events_url":"https://api.github.com/repos/princjef/font-ligatures/events","assignees_url":"https://api.github.com/repos/princjef/font-ligatures/assignees{/user}","branches_url":"https://api.github.com/repos/princjef/font-ligatures/branches{/branch}","tags_url":"https://api.github.com/repos/princjef/font-ligatures/tags","blobs_url":"https://api.github.com/repos/princjef/font-ligatures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/princjef/font-ligatures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/princjef/font-ligatures/git/refs{/sha}","trees_url":"https://api.github.com/repos/princjef/font-ligatures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/princjef/font-ligatures/statuses/{sha}","languages_url":"https://api.github.com/repos/princjef/font-ligatures/languages","stargazers_url":"https://api.github.com/repos/princjef/font-ligatures/stargazers","contributors_url":"https://api.github.com/repos/princjef/font-ligatures/contributors","subscribers_url":"https://api.github.com/repos/princjef/font-ligatures/subscribers","subscription_url":"https://api.github.com/repos/princjef/font-ligatures/subscription","commits_url":"https://api.github.com/repos/princjef/font-ligatures/commits{/sha}","git_commits_url":"https://api.github.com/repos/princjef/font-ligatures/git/commits{/sha}","comments_url":"https://api.github.com/repos/princjef/font-ligatures/comments{/number}","issue_comment_url":"https://api.github.com/repos/princjef/font-ligatures/issues/comments{/number}","contents_url":"https://api.github.com/repos/princjef/font-ligatures/contents/{+path}","compare_url":"https://api.github.com/repos/princjef/font-ligatures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/princjef/font-ligatures/merges","archive_url":"https://api.github.com/repos/princjef/font-ligatures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/princjef/font-ligatures/downloads","issues_url":"https://api.github.com/repos/princjef/font-ligatures/issues{/number}","pulls_url":"https://api.github.com/repos/princjef/font-ligatures/pulls{/number}","milestones_url":"https://api.github.com/repos/princjef/font-ligatures/milestones{/number}","notifications_url":"https://api.github.com/repos/princjef/font-ligatures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/princjef/font-ligatures/labels{/name}","releases_url":"https://api.github.com/repos/princjef/font-ligatures/releases{/id}","deployments_url":"https://api.github.com/repos/princjef/font-ligatures/deployments","created_at":"2018-05-01T05:41:47Z","updated_at":"2018-05-12T19:12:52Z","pushed_at":"2018-05-14T15:26:08Z","git_url":"git://github.com/princjef/font-ligatures.git","ssh_url":"git@github.com:princjef/font-ligatures.git","clone_url":"https://github.com/princjef/font-ligatures.git","svn_url":"https://github.com/princjef/font-ligatures","homepage":null,"size":1137,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/princjef/font-ligatures/pulls/11"},"html":{"href":"https://github.com/princjef/font-ligatures/pull/11"},"issue":{"href":"https://api.github.com/repos/princjef/font-ligatures/issues/11"},"comments":{"href":"https://api.github.com/repos/princjef/font-ligatures/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/princjef/font-ligatures/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/princjef/font-ligatures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/princjef/font-ligatures/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/princjef/font-ligatures/statuses/f5fd05ac9186387f575a2ee95730b1ea001ef815"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"princjef","id":3675357,"avatar_url":"https://avatars2.githubusercontent.com/u/3675357?v=4","gravatar_id":"","url":"https://api.github.com/users/princjef","html_url":"https://github.com/princjef","followers_url":"https://api.github.com/users/princjef/followers","following_url":"https://api.github.com/users/princjef/following{/other_user}","gists_url":"https://api.github.com/users/princjef/gists{/gist_id}","starred_url":"https://api.github.com/users/princjef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princjef/subscriptions","organizations_url":"https://api.github.com/users/princjef/orgs","repos_url":"https://api.github.com/users/princjef/repos","events_url":"https://api.github.com/users/princjef/events{/privacy}","received_events_url":"https://api.github.com/users/princjef/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":89,"deletions":25,"changed_files":1}}
{"actor":{"display_login":"princjef"}}