{"action":"created","issue":{"url":"https://api.github.com/repos/grafana/grafana/issues/12253","repository_url":"https://api.github.com/repos/grafana/grafana","labels_url":"https://api.github.com/repos/grafana/grafana/issues/12253/labels{/name}","comments_url":"https://api.github.com/repos/grafana/grafana/issues/12253/comments","events_url":"https://api.github.com/repos/grafana/grafana/issues/12253/events","html_url":"https://github.com/grafana/grafana/issues/12253","id":331854346,"node_id":"MDU6SXNzdWUzMzE4NTQzNDY=","number":12253,"title":"Feature Request: support label completion with required_matchers in Prometheus datasource","user":{"login":"mtanda","id":224552,"node_id":"MDQ6VXNlcjIyNDU1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/224552?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanda","html_url":"https://github.com/mtanda","followers_url":"https://api.github.com/users/mtanda/followers","following_url":"https://api.github.com/users/mtanda/following{/other_user}","gists_url":"https://api.github.com/users/mtanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanda/subscriptions","organizations_url":"https://api.github.com/users/mtanda/orgs","repos_url":"https://api.github.com/users/mtanda/repos","events_url":"https://api.github.com/users/mtanda/events{/privacy}","received_events_url":"https://api.github.com/users/mtanda/received_events","type":"User","site_admin":false},"labels":[{"id":274350203,"node_id":"MDU6TGFiZWwyNzQzNTAyMDM=","url":"https://api.github.com/repos/grafana/grafana/labels/datasource:%20Prometheus","name":"datasource: Prometheus","color":"85c92c","default":false}],"state":"open","locked":false,"assignee":{"login":"davkal","id":859729,"node_id":"MDQ6VXNlcjg1OTcyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/859729?v=4","gravatar_id":"","url":"https://api.github.com/users/davkal","html_url":"https://github.com/davkal","followers_url":"https://api.github.com/users/davkal/followers","following_url":"https://api.github.com/users/davkal/following{/other_user}","gists_url":"https://api.github.com/users/davkal/gists{/gist_id}","starred_url":"https://api.github.com/users/davkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkal/subscriptions","organizations_url":"https://api.github.com/users/davkal/orgs","repos_url":"https://api.github.com/users/davkal/repos","events_url":"https://api.github.com/users/davkal/events{/privacy}","received_events_url":"https://api.github.com/users/davkal/received_events","type":"User","site_admin":false},"assignees":[{"login":"davkal","id":859729,"node_id":"MDQ6VXNlcjg1OTcyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/859729?v=4","gravatar_id":"","url":"https://api.github.com/users/davkal","html_url":"https://github.com/davkal","followers_url":"https://api.github.com/users/davkal/followers","following_url":"https://api.github.com/users/davkal/following{/other_user}","gists_url":"https://api.github.com/users/davkal/gists{/gist_id}","starred_url":"https://api.github.com/users/davkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkal/subscriptions","organizations_url":"https://api.github.com/users/davkal/orgs","repos_url":"https://api.github.com/users/davkal/repos","events_url":"https://api.github.com/users/davkal/events{/privacy}","received_events_url":"https://api.github.com/users/davkal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-13T06:11:24Z","updated_at":"2018-06-27T12:49:06Z","closed_at":null,"author_association":"COLLABORATOR","body":"Current implementation only send metric name without required labels.\r\nhttps://github.com/grafana/grafana/blob/v5.1.3/public/app/plugins/datasource/prometheus/completer.ts#L111\r\nhttps://github.com/grafana/grafana/blob/v5.1.3/public/app/plugins/datasource/prometheus/completer.ts#L277\r\n\r\nDue to this behavior, we can't use completion for remote_read with required_matchers option.\r\n\r\nhttps://github.com/prometheus/prometheus/pull/3453"},"comment":{"url":"https://api.github.com/repos/grafana/grafana/issues/comments/400659757","html_url":"https://github.com/grafana/grafana/issues/12253#issuecomment-400659757","issue_url":"https://api.github.com/repos/grafana/grafana/issues/12253","id":400659757,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDY1OTc1Nw==","user":{"login":"davkal","id":859729,"node_id":"MDQ6VXNlcjg1OTcyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/859729?v=4","gravatar_id":"","url":"https://api.github.com/users/davkal","html_url":"https://github.com/davkal","followers_url":"https://api.github.com/users/davkal/followers","following_url":"https://api.github.com/users/davkal/following{/other_user}","gists_url":"https://api.github.com/users/davkal/gists{/gist_id}","starred_url":"https://api.github.com/users/davkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkal/subscriptions","organizations_url":"https://api.github.com/users/davkal/orgs","repos_url":"https://api.github.com/users/davkal/repos","events_url":"https://api.github.com/users/davkal/events{/privacy}","received_events_url":"https://api.github.com/users/davkal/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T12:49:06Z","updated_at":"2018-06-27T12:49:06Z","author_association":"CONTRIBUTOR","body":"> Do we reuse the completer with the slate editor?\r\n\r\nNope, those are not compatible. I'm taking a closer look at tab completion components next week.\r\n\r\nRegarding this issue, are you using required matchers @mtanda ? AFAIK this feature is not really used.\r\nBesides, there is no API on the Promtheus side to query for them, i.e., a client cant find out which of the labels of a remote series are required for the routing. The labels simply show up in the series API as normal labels."}}
{"actor":{"display_login":"davkal"}}