{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/8013","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/8013/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/8013/comments","events_url":"https://api.github.com/repos/helm/charts/issues/8013/events","html_url":"https://github.com/helm/charts/pull/8013","id":364495286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjY3NDU5","number":8013,"title":"logstash: volumes fix","user":{"login":"CharlieC3","id":2747302,"node_id":"MDQ6VXNlcjI3NDczMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/2747302?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlieC3","html_url":"https://github.com/CharlieC3","followers_url":"https://api.github.com/users/CharlieC3/followers","following_url":"https://api.github.com/users/CharlieC3/following{/other_user}","gists_url":"https://api.github.com/users/CharlieC3/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlieC3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlieC3/subscriptions","organizations_url":"https://api.github.com/users/CharlieC3/orgs","repos_url":"https://api.github.com/users/CharlieC3/repos","events_url":"https://api.github.com/users/CharlieC3/events{/privacy}","received_events_url":"https://api.github.com/users/CharlieC3/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":764227863,"node_id":"MDU6TGFiZWw3NjQyMjc4NjM=","url":"https://api.github.com/repos/helm/charts/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":352669720,"node_id":"MDU6TGFiZWwzNTI2Njk3MjA=","url":"https://api.github.com/repos/helm/charts/labels/lgtm","name":"lgtm","color":"15dd18","default":false}],"state":"closed","locked":false,"assignee":{"login":"rendhalver","id":1026337,"node_id":"MDQ6VXNlcjEwMjYzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1026337?v=4","gravatar_id":"","url":"https://api.github.com/users/rendhalver","html_url":"https://github.com/rendhalver","followers_url":"https://api.github.com/users/rendhalver/followers","following_url":"https://api.github.com/users/rendhalver/following{/other_user}","gists_url":"https://api.github.com/users/rendhalver/gists{/gist_id}","starred_url":"https://api.github.com/users/rendhalver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rendhalver/subscriptions","organizations_url":"https://api.github.com/users/rendhalver/orgs","repos_url":"https://api.github.com/users/rendhalver/repos","events_url":"https://api.github.com/users/rendhalver/events{/privacy}","received_events_url":"https://api.github.com/users/rendhalver/received_events","type":"User","site_admin":false},"assignees":[{"login":"rendhalver","id":1026337,"node_id":"MDQ6VXNlcjEwMjYzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1026337?v=4","gravatar_id":"","url":"https://api.github.com/users/rendhalver","html_url":"https://github.com/rendhalver","followers_url":"https://api.github.com/users/rendhalver/followers","following_url":"https://api.github.com/users/rendhalver/following{/other_user}","gists_url":"https://api.github.com/users/rendhalver/gists{/gist_id}","starred_url":"https://api.github.com/users/rendhalver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rendhalver/subscriptions","organizations_url":"https://api.github.com/users/rendhalver/orgs","repos_url":"https://api.github.com/users/rendhalver/repos","events_url":"https://api.github.com/users/rendhalver/events{/privacy}","received_events_url":"https://api.github.com/users/rendhalver/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-09-27T14:10:19Z","updated_at":"2018-09-27T16:21:06Z","closed_at":"2018-09-27T16:20:22Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/8013","html_url":"https://github.com/helm/charts/pull/8013","diff_url":"https://github.com/helm/charts/pull/8013.diff","patch_url":"https://github.com/helm/charts/pull/8013.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR implements a fix in the Logstash chart in which there are two defined `volumes` blocks in the statefulset, causing the defined volumes in the `values.yaml` to be ignored. This PR combines the two blocks into one, allowing user-added volumes to be acknowledged.\r\n\r\nThis is ultimately an oversight from a previous PR I submitted (#7778). After building and testing the new chart, I can confirm this successfully allows users to add new volumes and functions as originally intended.\r\n\r\n**Which issue this PR fixes**:\r\nNone\r\n\r\n**kubectl describe pod output**\r\nThe below output shows I was able to configure 2 extra volumes in the pod (tls and certificate-authorities) on top of the default volumes (data, patterns, pipeline).\r\n```\r\nVolumes:\r\n  data:\r\n    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)\r\n    ClaimName:  data-logstash-1\r\n    ReadOnly:   false\r\n  patterns:\r\n    Type:      ConfigMap (a volume populated by a ConfigMap)\r\n    Name:      logstash-patterns\r\n    Optional:  false\r\n  pipeline:\r\n    Type:      ConfigMap (a volume populated by a ConfigMap)\r\n    Name:      logstash-pipeline\r\n    Optional:  false\r\n  tls:\r\n    Type:        Secret (a volume populated by a Secret)\r\n    SecretName:  tls\r\n    Optional:    false\r\n  certificate-authorities:\r\n    Type:        Secret (a volume populated by a Secret)\r\n    SecretName:  certificate-authorities\r\n    Optional:    false\r\n  default-token-qslrm:\r\n    Type:        Secret (a volume populated by a Secret)\r\n    SecretName:  default-token-qslrm\r\n    Optional:    false\r\n```"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/425155241","html_url":"https://github.com/helm/charts/pull/8013#issuecomment-425155241","issue_url":"https://api.github.com/repos/helm/charts/issues/8013","id":425155241,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE1NTI0MQ==","user":{"login":"CharlieC3","id":2747302,"node_id":"MDQ6VXNlcjI3NDczMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/2747302?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlieC3","html_url":"https://github.com/CharlieC3","followers_url":"https://api.github.com/users/CharlieC3/followers","following_url":"https://api.github.com/users/CharlieC3/following{/other_user}","gists_url":"https://api.github.com/users/CharlieC3/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlieC3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlieC3/subscriptions","organizations_url":"https://api.github.com/users/CharlieC3/orgs","repos_url":"https://api.github.com/users/CharlieC3/repos","events_url":"https://api.github.com/users/CharlieC3/events{/privacy}","received_events_url":"https://api.github.com/users/CharlieC3/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T16:21:06Z","updated_at":"2018-09-27T16:21:06Z","author_association":"CONTRIBUTOR","body":"Thanks @rendhalver for the quick turnaround!"}}
{"actor":{"display_login":"CharlieC3"}}