{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/17327","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/17327/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/17327/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/17327/events","html_url":"https://github.com/magento/magento2/pull/17327","id":346985210,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzEzNzU1","number":17327,"title":"fix: add missing data-th selector for tables","user":{"login":"DanielRuf","id":827205,"node_id":"MDQ6VXNlcjgyNzIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"labels":[{"id":956032057,"node_id":"MDU6TGFiZWw5NTYwMzIwNTc=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Design/Frontend","name":"Area: Design/Frontend","color":"1d76db","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-02T12:14:08Z","updated_at":"2018-08-02T12:14:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/17327","html_url":"https://github.com/magento/magento2/pull/17327","diff_url":"https://github.com/magento/magento2/pull/17327.diff","patch_url":"https://github.com/magento/magento2/pull/17327.patch"},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\nThis improves the specifity and prevents cases where the `data-th` attribute is not set and could cause issues.\r\n\r\n#16517\r\nhttps://github.com/magento/magento2/commit/370cef6b3644751e284b25e0b14cfc0b73c4ca6e was just a partly fix. We also have to check more parts where `attr` is used on elements but the needed attributes do not exist.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n1. ...\r\n2. ...\r\n\r\n### Manual testing scenarios\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. ...\r\n2. ...\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/409905437","html_url":"https://github.com/magento/magento2/pull/17327#issuecomment-409905437","issue_url":"https://api.github.com/repos/magento/magento2/issues/17327","id":409905437,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTkwNTQzNw==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T12:14:13Z","updated_at":"2018-08-02T12:14:13Z","author_association":"CONTRIBUTOR","body":"Hi @DanielRuf. Thank you for your contribution \nHere is some useful tips how you can test your changes using Magento test environment.\nAdd the comment under your pull request to deploy test or vanilla Magento instance:\n- `@magento-engcom-team give me test instance` - deploy test instance based on PR changes\n- `@magento-engcom-team give me {$VERSION} instance` - deploy vanilla Magento instance\n\nFor more details, please, review the [Magento Contributor Assistant](https://github.com/magento/magento2/wiki/Magento-Contributor-Assistant) documentation"}}
{"actor":{"display_login":"magento-engcom-team"}}