{"action":"created","comment":{"url":"https://api.github.com/repos/singer-io/knots/pulls/comments/242632298","pull_request_review_id":186182460,"id":242632298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjYzMjI5OA==","diff_hunk":"@@ -43,15 +48,18 @@ import type {\n import {\n   formValid,\n   showValidation,\n-  validateFields\n+  validateFields,\n+  openLink\n } from '../../../../utils/handlers';\n+import Checkbox from '../Checkbox';\n \n type Props = {\n   tapsStore: {\n     'tap-postgres': TapPostgres\n   },\n   updateTapField: UpdateTapField,\n-  updateFormValidation: UpdateFormValidation\n+  updateFormValidation: UpdateFormValidation,\n+  updateLogBaseRepMethod: (usesLogBaseRepMethod: boolean) => void\n };\n \n export default class Postgres extends Component<Props, PostgresState> {","path":"app/components/Taps/TapConfiguration/Postgres/index.js","position":34,"original_position":34,"commit_id":"627e980ce98eec6a9c792c8fd43a64c8c5fa2fcc","original_commit_id":"627e980ce98eec6a9c792c8fd43a64c8c5fa2fcc","user":{"login":"rflprr","id":1487471,"node_id":"MDQ6VXNlcjE0ODc0NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1487471?v=4","gravatar_id":"","url":"https://api.github.com/users/rflprr","html_url":"https://github.com/rflprr","followers_url":"https://api.github.com/users/rflprr/followers","following_url":"https://api.github.com/users/rflprr/following{/other_user}","gists_url":"https://api.github.com/users/rflprr/gists{/gist_id}","starred_url":"https://api.github.com/users/rflprr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rflprr/subscriptions","organizations_url":"https://api.github.com/users/rflprr/orgs","repos_url":"https://api.github.com/users/rflprr/repos","events_url":"https://api.github.com/users/rflprr/events{/privacy}","received_events_url":"https://api.github.com/users/rflprr/received_events","type":"User","site_admin":false},"body":"Same comments form Mysql version apply to Postgres.","created_at":"2018-12-18T17:29:13Z","updated_at":"2018-12-18T17:31:02Z","html_url":"https://github.com/singer-io/knots/pull/172#discussion_r242632298","pull_request_url":"https://api.github.com/repos/singer-io/knots/pulls/172","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/singer-io/knots/pulls/comments/242632298"},"html":{"href":"https://github.com/singer-io/knots/pull/172#discussion_r242632298"},"pull_request":{"href":"https://api.github.com/repos/singer-io/knots/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/singer-io/knots/pulls/172","id":212679841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjc5ODQx","html_url":"https://github.com/singer-io/knots/pull/172","diff_url":"https://github.com/singer-io/knots/pull/172.diff","patch_url":"https://github.com/singer-io/knots/pull/172.patch","issue_url":"https://api.github.com/repos/singer-io/knots/issues/172","number":172,"state":"open","locked":false,"title":"Support log based","user":{"login":"gbolly","id":9654881,"node_id":"MDQ6VXNlcjk2NTQ4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/9654881?v=4","gravatar_id":"","url":"https://api.github.com/users/gbolly","html_url":"https://github.com/gbolly","followers_url":"https://api.github.com/users/gbolly/followers","following_url":"https://api.github.com/users/gbolly/following{/other_user}","gists_url":"https://api.github.com/users/gbolly/gists{/gist_id}","starred_url":"https://api.github.com/users/gbolly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbolly/subscriptions","organizations_url":"https://api.github.com/users/gbolly/orgs","repos_url":"https://api.github.com/users/gbolly/repos","events_url":"https://api.github.com/users/gbolly/events{/privacy}","received_events_url":"https://api.github.com/users/gbolly/received_events","type":"User","site_admin":false},"body":"This PR adds support for LOG_BASED replication method.\r\n\r\n**Updates made:**\r\n- Added a modal to display special configuration message.\r\n- Added an extra property `usesLogBased ` to `specImplementation` to signify tap needs a special configuration to support log base.\r\n- Update test case.\r\n- Small refactoring.\r\n\r\nTaps like MySQL and Postgres uses LOG_BASED replication and require special configurations on the server end for the tap to work. So, a pop-up is shown to the user that tells them what is needed to be configured and the user can go on to select between using a default replication method or continue with LOG_BASED method if they have completed the configuration.\r\n\r\nDepending on the existence of a replication key or not, once a user chooses to use a default replication method, KNOTS uses either INCREMENTAL or FULL_TABLE as its default method.\r\n\r\n#147 ","created_at":"2018-09-03T08:48:43Z","updated_at":"2018-12-18T17:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed4c4f230e56852a3b134deec9396ca91370907d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/singer-io/knots/pulls/172/commits","review_comments_url":"https://api.github.com/repos/singer-io/knots/pulls/172/comments","review_comment_url":"https://api.github.com/repos/singer-io/knots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singer-io/knots/issues/172/comments","statuses_url":"https://api.github.com/repos/singer-io/knots/statuses/627e980ce98eec6a9c792c8fd43a64c8c5fa2fcc","head":{"label":"singer-io:support-log-based","ref":"support-log-based","sha":"627e980ce98eec6a9c792c8fd43a64c8c5fa2fcc","user":{"login":"singer-io","id":25538203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM4MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":118515001,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MTUwMDE=","name":"knots","full_name":"singer-io/knots","private":false,"owner":{"login":"singer-io","id":25538203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM4MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/singer-io/knots","description":"KNOTS is an intuitive desktop application built to simplify the configuration of Singer pipelines","fork":false,"url":"https://api.github.com/repos/singer-io/knots","forks_url":"https://api.github.com/repos/singer-io/knots/forks","keys_url":"https://api.github.com/repos/singer-io/knots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singer-io/knots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singer-io/knots/teams","hooks_url":"https://api.github.com/repos/singer-io/knots/hooks","issue_events_url":"https://api.github.com/repos/singer-io/knots/issues/events{/number}","events_url":"https://api.github.com/repos/singer-io/knots/events","assignees_url":"https://api.github.com/repos/singer-io/knots/assignees{/user}","branches_url":"https://api.github.com/repos/singer-io/knots/branches{/branch}","tags_url":"https://api.github.com/repos/singer-io/knots/tags","blobs_url":"https://api.github.com/repos/singer-io/knots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singer-io/knots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singer-io/knots/git/refs{/sha}","trees_url":"https://api.github.com/repos/singer-io/knots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singer-io/knots/statuses/{sha}","languages_url":"https://api.github.com/repos/singer-io/knots/languages","stargazers_url":"https://api.github.com/repos/singer-io/knots/stargazers","contributors_url":"https://api.github.com/repos/singer-io/knots/contributors","subscribers_url":"https://api.github.com/repos/singer-io/knots/subscribers","subscription_url":"https://api.github.com/repos/singer-io/knots/subscription","commits_url":"https://api.github.com/repos/singer-io/knots/commits{/sha}","git_commits_url":"https://api.github.com/repos/singer-io/knots/git/commits{/sha}","comments_url":"https://api.github.com/repos/singer-io/knots/comments{/number}","issue_comment_url":"https://api.github.com/repos/singer-io/knots/issues/comments{/number}","contents_url":"https://api.github.com/repos/singer-io/knots/contents/{+path}","compare_url":"https://api.github.com/repos/singer-io/knots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singer-io/knots/merges","archive_url":"https://api.github.com/repos/singer-io/knots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singer-io/knots/downloads","issues_url":"https://api.github.com/repos/singer-io/knots/issues{/number}","pulls_url":"https://api.github.com/repos/singer-io/knots/pulls{/number}","milestones_url":"https://api.github.com/repos/singer-io/knots/milestones{/number}","notifications_url":"https://api.github.com/repos/singer-io/knots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singer-io/knots/labels{/name}","releases_url":"https://api.github.com/repos/singer-io/knots/releases{/id}","deployments_url":"https://api.github.com/repos/singer-io/knots/deployments","created_at":"2018-01-22T21:04:11Z","updated_at":"2018-12-04T06:56:51Z","pushed_at":"2018-12-18T16:12:21Z","git_url":"git://github.com/singer-io/knots.git","ssh_url":"git@github.com:singer-io/knots.git","clone_url":"https://github.com/singer-io/knots.git","svn_url":"https://github.com/singer-io/knots","homepage":"","size":70183,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":11,"watchers":16,"default_branch":"master"}},"base":{"label":"singer-io:master","ref":"master","sha":"501407456fa9b096da108eca7ee23f7db92972a4","user":{"login":"singer-io","id":25538203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM4MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":118515001,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MTUwMDE=","name":"knots","full_name":"singer-io/knots","private":false,"owner":{"login":"singer-io","id":25538203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM4MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/singer-io/knots","description":"KNOTS is an intuitive desktop application built to simplify the configuration of Singer pipelines","fork":false,"url":"https://api.github.com/repos/singer-io/knots","forks_url":"https://api.github.com/repos/singer-io/knots/forks","keys_url":"https://api.github.com/repos/singer-io/knots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singer-io/knots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singer-io/knots/teams","hooks_url":"https://api.github.com/repos/singer-io/knots/hooks","issue_events_url":"https://api.github.com/repos/singer-io/knots/issues/events{/number}","events_url":"https://api.github.com/repos/singer-io/knots/events","assignees_url":"https://api.github.com/repos/singer-io/knots/assignees{/user}","branches_url":"https://api.github.com/repos/singer-io/knots/branches{/branch}","tags_url":"https://api.github.com/repos/singer-io/knots/tags","blobs_url":"https://api.github.com/repos/singer-io/knots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singer-io/knots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singer-io/knots/git/refs{/sha}","trees_url":"https://api.github.com/repos/singer-io/knots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singer-io/knots/statuses/{sha}","languages_url":"https://api.github.com/repos/singer-io/knots/languages","stargazers_url":"https://api.github.com/repos/singer-io/knots/stargazers","contributors_url":"https://api.github.com/repos/singer-io/knots/contributors","subscribers_url":"https://api.github.com/repos/singer-io/knots/subscribers","subscription_url":"https://api.github.com/repos/singer-io/knots/subscription","commits_url":"https://api.github.com/repos/singer-io/knots/commits{/sha}","git_commits_url":"https://api.github.com/repos/singer-io/knots/git/commits{/sha}","comments_url":"https://api.github.com/repos/singer-io/knots/comments{/number}","issue_comment_url":"https://api.github.com/repos/singer-io/knots/issues/comments{/number}","contents_url":"https://api.github.com/repos/singer-io/knots/contents/{+path}","compare_url":"https://api.github.com/repos/singer-io/knots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singer-io/knots/merges","archive_url":"https://api.github.com/repos/singer-io/knots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singer-io/knots/downloads","issues_url":"https://api.github.com/repos/singer-io/knots/issues{/number}","pulls_url":"https://api.github.com/repos/singer-io/knots/pulls{/number}","milestones_url":"https://api.github.com/repos/singer-io/knots/milestones{/number}","notifications_url":"https://api.github.com/repos/singer-io/knots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singer-io/knots/labels{/name}","releases_url":"https://api.github.com/repos/singer-io/knots/releases{/id}","deployments_url":"https://api.github.com/repos/singer-io/knots/deployments","created_at":"2018-01-22T21:04:11Z","updated_at":"2018-12-04T06:56:51Z","pushed_at":"2018-12-18T16:12:21Z","git_url":"git://github.com/singer-io/knots.git","ssh_url":"git@github.com:singer-io/knots.git","clone_url":"https://github.com/singer-io/knots.git","svn_url":"https://github.com/singer-io/knots","homepage":"","size":70183,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":11,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singer-io/knots/pulls/172"},"html":{"href":"https://github.com/singer-io/knots/pull/172"},"issue":{"href":"https://api.github.com/repos/singer-io/knots/issues/172"},"comments":{"href":"https://api.github.com/repos/singer-io/knots/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/singer-io/knots/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/singer-io/knots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singer-io/knots/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/singer-io/knots/statuses/627e980ce98eec6a9c792c8fd43a64c8c5fa2fcc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rflprr"}}