{"action":"created","comment":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/comments/187424150","pull_request_review_id":119203564,"id":187424150,"diff_hunk":"@@ -968,8 +968,13 @@ class GeneralGenerator : public BaseGenerator {\n               if (lang_.language != IDLOptions::kCSharp)\n                 code += type_name + \" obj, \";\n               getter = obj + \".__assign\";\n+            } else if (vectortype.base_type == BASE_TYPE_UNION) {\n+              if (lang_.language != IDLOptions::kCSharp)","path":"src/idl_gen_general.cpp","position":5,"original_position":5,"commit_id":"5b172b081c320d09b82d6e39a18b4b4ded3a9d52","original_commit_id":"5b172b081c320d09b82d6e39a18b4b4ded3a9d52","user":{"login":"aardappel","id":4663648,"avatar_url":"https://avatars2.githubusercontent.com/u/4663648?v=4","gravatar_id":"","url":"https://api.github.com/users/aardappel","html_url":"https://github.com/aardappel","followers_url":"https://api.github.com/users/aardappel/followers","following_url":"https://api.github.com/users/aardappel/following{/other_user}","gists_url":"https://api.github.com/users/aardappel/gists{/gist_id}","starred_url":"https://api.github.com/users/aardappel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardappel/subscriptions","organizations_url":"https://api.github.com/users/aardappel/orgs","repos_url":"https://api.github.com/users/aardappel/repos","events_url":"https://api.github.com/users/aardappel/events{/privacy}","received_events_url":"https://api.github.com/users/aardappel/received_events","type":"User","site_admin":false},"body":"Thanks :)","created_at":"2018-05-10T18:50:48Z","updated_at":"2018-05-10T18:50:48Z","html_url":"https://github.com/google/flatbuffers/pull/4735#discussion_r187424150","pull_request_url":"https://api.github.com/repos/google/flatbuffers/pulls/4735","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/comments/187424150"},"html":{"href":"https://github.com/google/flatbuffers/pull/4735#discussion_r187424150"},"pull_request":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4735"}},"in_reply_to_id":187414407},"pull_request":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/4735","id":186916579,"html_url":"https://github.com/google/flatbuffers/pull/4735","diff_url":"https://github.com/google/flatbuffers/pull/4735.diff","patch_url":"https://github.com/google/flatbuffers/pull/4735.patch","issue_url":"https://api.github.com/repos/google/flatbuffers/issues/4735","number":4735,"state":"open","locked":false,"title":"Vector of unions support for java","user":{"login":"krojew","id":1268573,"avatar_url":"https://avatars2.githubusercontent.com/u/1268573?v=4","gravatar_id":"","url":"https://api.github.com/users/krojew","html_url":"https://github.com/krojew","followers_url":"https://api.github.com/users/krojew/followers","following_url":"https://api.github.com/users/krojew/following{/other_user}","gists_url":"https://api.github.com/users/krojew/gists{/gist_id}","starred_url":"https://api.github.com/users/krojew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krojew/subscriptions","organizations_url":"https://api.github.com/users/krojew/orgs","repos_url":"https://api.github.com/users/krojew/repos","events_url":"https://api.github.com/users/krojew/events{/privacy}","received_events_url":"https://api.github.com/users/krojew/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-09T13:09:14Z","updated_at":"2018-05-10T18:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"546df508dd4d0d0559dfeb79351c03edcb23afad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/flatbuffers/pulls/4735/commits","review_comments_url":"https://api.github.com/repos/google/flatbuffers/pulls/4735/comments","review_comment_url":"https://api.github.com/repos/google/flatbuffers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/flatbuffers/issues/4735/comments","statuses_url":"https://api.github.com/repos/google/flatbuffers/statuses/5b172b081c320d09b82d6e39a18b4b4ded3a9d52","head":{"label":"krojew:master","ref":"master","sha":"5b172b081c320d09b82d6e39a18b4b4ded3a9d52","user":{"login":"krojew","id":1268573,"avatar_url":"https://avatars2.githubusercontent.com/u/1268573?v=4","gravatar_id":"","url":"https://api.github.com/users/krojew","html_url":"https://github.com/krojew","followers_url":"https://api.github.com/users/krojew/followers","following_url":"https://api.github.com/users/krojew/following{/other_user}","gists_url":"https://api.github.com/users/krojew/gists{/gist_id}","starred_url":"https://api.github.com/users/krojew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krojew/subscriptions","organizations_url":"https://api.github.com/users/krojew/orgs","repos_url":"https://api.github.com/users/krojew/repos","events_url":"https://api.github.com/users/krojew/events{/privacy}","received_events_url":"https://api.github.com/users/krojew/received_events","type":"User","site_admin":false},"repo":{"id":85196551,"name":"flatbuffers","full_name":"krojew/flatbuffers","owner":{"login":"krojew","id":1268573,"avatar_url":"https://avatars2.githubusercontent.com/u/1268573?v=4","gravatar_id":"","url":"https://api.github.com/users/krojew","html_url":"https://github.com/krojew","followers_url":"https://api.github.com/users/krojew/followers","following_url":"https://api.github.com/users/krojew/following{/other_user}","gists_url":"https://api.github.com/users/krojew/gists{/gist_id}","starred_url":"https://api.github.com/users/krojew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krojew/subscriptions","organizations_url":"https://api.github.com/users/krojew/orgs","repos_url":"https://api.github.com/users/krojew/repos","events_url":"https://api.github.com/users/krojew/events{/privacy}","received_events_url":"https://api.github.com/users/krojew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krojew/flatbuffers","description":"Memory Efficient Serialization Library","fork":true,"url":"https://api.github.com/repos/krojew/flatbuffers","forks_url":"https://api.github.com/repos/krojew/flatbuffers/forks","keys_url":"https://api.github.com/repos/krojew/flatbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krojew/flatbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krojew/flatbuffers/teams","hooks_url":"https://api.github.com/repos/krojew/flatbuffers/hooks","issue_events_url":"https://api.github.com/repos/krojew/flatbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/krojew/flatbuffers/events","assignees_url":"https://api.github.com/repos/krojew/flatbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/krojew/flatbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/krojew/flatbuffers/tags","blobs_url":"https://api.github.com/repos/krojew/flatbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krojew/flatbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krojew/flatbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/krojew/flatbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krojew/flatbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/krojew/flatbuffers/languages","stargazers_url":"https://api.github.com/repos/krojew/flatbuffers/stargazers","contributors_url":"https://api.github.com/repos/krojew/flatbuffers/contributors","subscribers_url":"https://api.github.com/repos/krojew/flatbuffers/subscribers","subscription_url":"https://api.github.com/repos/krojew/flatbuffers/subscription","commits_url":"https://api.github.com/repos/krojew/flatbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/krojew/flatbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/krojew/flatbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/krojew/flatbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/krojew/flatbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/krojew/flatbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krojew/flatbuffers/merges","archive_url":"https://api.github.com/repos/krojew/flatbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krojew/flatbuffers/downloads","issues_url":"https://api.github.com/repos/krojew/flatbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/krojew/flatbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/krojew/flatbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/krojew/flatbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krojew/flatbuffers/labels{/name}","releases_url":"https://api.github.com/repos/krojew/flatbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/krojew/flatbuffers/deployments","created_at":"2017-03-16T13:02:49Z","updated_at":"2018-05-10T05:20:21Z","pushed_at":"2018-05-10T05:20:17Z","git_url":"git://github.com/krojew/flatbuffers.git","ssh_url":"git@github.com:krojew/flatbuffers.git","clone_url":"https://github.com/krojew/flatbuffers.git","svn_url":"https://github.com/krojew/flatbuffers","homepage":"http://google.github.io/flatbuffers/","size":6266,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"66214243082a1ba6156da8c3f562595ab175f035","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19953044,"name":"flatbuffers","full_name":"google/flatbuffers","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/flatbuffers","description":"Memory Efficient Serialization Library","fork":false,"url":"https://api.github.com/repos/google/flatbuffers","forks_url":"https://api.github.com/repos/google/flatbuffers/forks","keys_url":"https://api.github.com/repos/google/flatbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/flatbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/flatbuffers/teams","hooks_url":"https://api.github.com/repos/google/flatbuffers/hooks","issue_events_url":"https://api.github.com/repos/google/flatbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/google/flatbuffers/events","assignees_url":"https://api.github.com/repos/google/flatbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/google/flatbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/google/flatbuffers/tags","blobs_url":"https://api.github.com/repos/google/flatbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/flatbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/flatbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/flatbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/flatbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/google/flatbuffers/languages","stargazers_url":"https://api.github.com/repos/google/flatbuffers/stargazers","contributors_url":"https://api.github.com/repos/google/flatbuffers/contributors","subscribers_url":"https://api.github.com/repos/google/flatbuffers/subscribers","subscription_url":"https://api.github.com/repos/google/flatbuffers/subscription","commits_url":"https://api.github.com/repos/google/flatbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/flatbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/flatbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/flatbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/flatbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/google/flatbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/flatbuffers/merges","archive_url":"https://api.github.com/repos/google/flatbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/flatbuffers/downloads","issues_url":"https://api.github.com/repos/google/flatbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/google/flatbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/google/flatbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/google/flatbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/flatbuffers/labels{/name}","releases_url":"https://api.github.com/repos/google/flatbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/google/flatbuffers/deployments","created_at":"2014-05-19T18:33:01Z","updated_at":"2018-05-10T17:34:30Z","pushed_at":"2018-05-10T18:44:16Z","git_url":"git://github.com/google/flatbuffers.git","ssh_url":"git@github.com:google/flatbuffers.git","clone_url":"https://github.com/google/flatbuffers.git","svn_url":"https://github.com/google/flatbuffers","homepage":"http://google.github.io/flatbuffers/","size":6517,"stargazers_count":9376,"watchers_count":9376,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1468,"mirror_url":null,"archived":false,"open_issues_count":237,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1468,"open_issues":237,"watchers":9376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4735"},"html":{"href":"https://github.com/google/flatbuffers/pull/4735"},"issue":{"href":"https://api.github.com/repos/google/flatbuffers/issues/4735"},"comments":{"href":"https://api.github.com/repos/google/flatbuffers/issues/4735/comments"},"review_comments":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4735/comments"},"review_comment":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4735/commits"},"statuses":{"href":"https://api.github.com/repos/google/flatbuffers/statuses/5b172b081c320d09b82d6e39a18b4b4ded3a9d52"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aardappel"}}