{"action":"created","comment":{"url":"https://api.github.com/repos/spack/spack/pulls/comments/201738815","pull_request_review_id":136299188,"id":201738815,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTczODgxNQ==","diff_hunk":"@@ -0,0 +1,23 @@\n+--- libmatheval-1.1.11/configure.in\t2013-08-14 22:22:08.000000000 +0200\n++++ libmatheval-1.1.11/configure.ac\t2018-06-26 10:26:46.364866000 +0200","path":"var/spack/repos/builtin/packages/libmatheval/guile-2.0.patch","position":2,"original_position":2,"commit_id":"2c02421af5b76e8ecd0b45e4b14d28111be32204","original_commit_id":"2c02421af5b76e8ecd0b45e4b14d28111be32204","user":{"login":"adamjstewart","id":12021217,"node_id":"MDQ6VXNlcjEyMDIxMjE3","avatar_url":"https://avatars2.githubusercontent.com/u/12021217?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"This filename change is confusing. I usually like to diff two different directories, like `a/configure.in` and `b/configure.in`.","created_at":"2018-07-11T15:34:51Z","updated_at":"2018-07-11T15:39:45Z","html_url":"https://github.com/spack/spack/pull/8680#discussion_r201738815","pull_request_url":"https://api.github.com/repos/spack/spack/pulls/8680","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/comments/201738815"},"html":{"href":"https://github.com/spack/spack/pull/8680#discussion_r201738815"},"pull_request":{"href":"https://api.github.com/repos/spack/spack/pulls/8680"}}},"pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/8680","id":200703677,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzAzNjc3","html_url":"https://github.com/spack/spack/pull/8680","diff_url":"https://github.com/spack/spack/pull/8680.diff","patch_url":"https://github.com/spack/spack/pull/8680.patch","issue_url":"https://api.github.com/repos/spack/spack/issues/8680","number":8680,"state":"open","locked":false,"title":"fix to build libmatheval with guile@2.0:","user":{"login":"g-mathias","id":40861554,"node_id":"MDQ6VXNlcjQwODYxNTU0","avatar_url":"https://avatars3.githubusercontent.com/u/40861554?v=4","gravatar_id":"","url":"https://api.github.com/users/g-mathias","html_url":"https://github.com/g-mathias","followers_url":"https://api.github.com/users/g-mathias/followers","following_url":"https://api.github.com/users/g-mathias/following{/other_user}","gists_url":"https://api.github.com/users/g-mathias/gists{/gist_id}","starred_url":"https://api.github.com/users/g-mathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-mathias/subscriptions","organizations_url":"https://api.github.com/users/g-mathias/orgs","repos_url":"https://api.github.com/users/g-mathias/repos","events_url":"https://api.github.com/users/g-mathias/events{/privacy}","received_events_url":"https://api.github.com/users/g-mathias/received_events","type":"User","site_admin":false},"body":"With guile 2.0 the naming scheme of the library has changed and libmatheval will not build against it.\r\nPrevious builds may have worked if a local guile@1.X version was installed.\r\n\r\nI patch the configure.in of libmatheval using the appropriate guile macros.\r\nAn empty config.rpath has been added (seems obligatory for autotools).\r\nIn the package file the patch is applied and an autoreconf is forced if guile@2.0:\r\n","created_at":"2018-07-11T13:39:58Z","updated_at":"2018-07-11T15:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"554fa38384b405b242b12da991a96145b28a66f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620268714,"node_id":"MDU6TGFiZWw2MjAyNjg3MTQ=","url":"https://api.github.com/repos/spack/spack/labels/patch","name":"patch","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spack/spack/pulls/8680/commits","review_comments_url":"https://api.github.com/repos/spack/spack/pulls/8680/comments","review_comment_url":"https://api.github.com/repos/spack/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spack/spack/issues/8680/comments","statuses_url":"https://api.github.com/repos/spack/spack/statuses/2c02421af5b76e8ecd0b45e4b14d28111be32204","head":{"label":"g-mathias:libmatheval_fix_guile2.0","ref":"libmatheval_fix_guile2.0","sha":"2c02421af5b76e8ecd0b45e4b14d28111be32204","user":{"login":"g-mathias","id":40861554,"node_id":"MDQ6VXNlcjQwODYxNTU0","avatar_url":"https://avatars3.githubusercontent.com/u/40861554?v=4","gravatar_id":"","url":"https://api.github.com/users/g-mathias","html_url":"https://github.com/g-mathias","followers_url":"https://api.github.com/users/g-mathias/followers","following_url":"https://api.github.com/users/g-mathias/following{/other_user}","gists_url":"https://api.github.com/users/g-mathias/gists{/gist_id}","starred_url":"https://api.github.com/users/g-mathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-mathias/subscriptions","organizations_url":"https://api.github.com/users/g-mathias/orgs","repos_url":"https://api.github.com/users/g-mathias/repos","events_url":"https://api.github.com/users/g-mathias/events{/privacy}","received_events_url":"https://api.github.com/users/g-mathias/received_events","type":"User","site_admin":false},"repo":{"id":140575982,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NzU5ODI=","name":"spack","full_name":"g-mathias/spack","owner":{"login":"g-mathias","id":40861554,"node_id":"MDQ6VXNlcjQwODYxNTU0","avatar_url":"https://avatars3.githubusercontent.com/u/40861554?v=4","gravatar_id":"","url":"https://api.github.com/users/g-mathias","html_url":"https://github.com/g-mathias","followers_url":"https://api.github.com/users/g-mathias/followers","following_url":"https://api.github.com/users/g-mathias/following{/other_user}","gists_url":"https://api.github.com/users/g-mathias/gists{/gist_id}","starred_url":"https://api.github.com/users/g-mathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-mathias/subscriptions","organizations_url":"https://api.github.com/users/g-mathias/orgs","repos_url":"https://api.github.com/users/g-mathias/repos","events_url":"https://api.github.com/users/g-mathias/events{/privacy}","received_events_url":"https://api.github.com/users/g-mathias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/g-mathias/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/g-mathias/spack","forks_url":"https://api.github.com/repos/g-mathias/spack/forks","keys_url":"https://api.github.com/repos/g-mathias/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g-mathias/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g-mathias/spack/teams","hooks_url":"https://api.github.com/repos/g-mathias/spack/hooks","issue_events_url":"https://api.github.com/repos/g-mathias/spack/issues/events{/number}","events_url":"https://api.github.com/repos/g-mathias/spack/events","assignees_url":"https://api.github.com/repos/g-mathias/spack/assignees{/user}","branches_url":"https://api.github.com/repos/g-mathias/spack/branches{/branch}","tags_url":"https://api.github.com/repos/g-mathias/spack/tags","blobs_url":"https://api.github.com/repos/g-mathias/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g-mathias/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g-mathias/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/g-mathias/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g-mathias/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/g-mathias/spack/languages","stargazers_url":"https://api.github.com/repos/g-mathias/spack/stargazers","contributors_url":"https://api.github.com/repos/g-mathias/spack/contributors","subscribers_url":"https://api.github.com/repos/g-mathias/spack/subscribers","subscription_url":"https://api.github.com/repos/g-mathias/spack/subscription","commits_url":"https://api.github.com/repos/g-mathias/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/g-mathias/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/g-mathias/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/g-mathias/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/g-mathias/spack/contents/{+path}","compare_url":"https://api.github.com/repos/g-mathias/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g-mathias/spack/merges","archive_url":"https://api.github.com/repos/g-mathias/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g-mathias/spack/downloads","issues_url":"https://api.github.com/repos/g-mathias/spack/issues{/number}","pulls_url":"https://api.github.com/repos/g-mathias/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/g-mathias/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/g-mathias/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g-mathias/spack/labels{/name}","releases_url":"https://api.github.com/repos/g-mathias/spack/releases{/id}","deployments_url":"https://api.github.com/repos/g-mathias/spack/deployments","created_at":"2018-07-11T13:02:35Z","updated_at":"2018-07-11T13:02:46Z","pushed_at":"2018-07-11T14:05:57Z","git_url":"git://github.com/g-mathias/spack.git","ssh_url":"git@github.com:g-mathias/spack.git","clone_url":"https://github.com/g-mathias/spack.git","svn_url":"https://github.com/g-mathias/spack","homepage":"https://spack.io","size":40603,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"spack:develop","ref":"develop","sha":"391d89a8534afd3fdd06b385542a02d1feae6ee1","user":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMDg2NQ==","name":"spack","full_name":"spack/spack","owner":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2018-07-11T15:34:39Z","pushed_at":"2018-07-11T15:33:45Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":40677,"stargazers_count":595,"watchers_count":595,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":454,"mirror_url":null,"archived":false,"open_issues_count":998,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":454,"open_issues":998,"watchers":595,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/8680"},"html":{"href":"https://github.com/spack/spack/pull/8680"},"issue":{"href":"https://api.github.com/repos/spack/spack/issues/8680"},"comments":{"href":"https://api.github.com/repos/spack/spack/issues/8680/comments"},"review_comments":{"href":"https://api.github.com/repos/spack/spack/pulls/8680/comments"},"review_comment":{"href":"https://api.github.com/repos/spack/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spack/spack/pulls/8680/commits"},"statuses":{"href":"https://api.github.com/repos/spack/spack/statuses/2c02421af5b76e8ecd0b45e4b14d28111be32204"}},"author_association":"NONE"}}
{"actor":{"display_login":"adamjstewart"}}