{"action":"created","issue":{"url":"https://api.github.com/repos/usemarkup/NeedleBundle/issues/79","repository_url":"https://api.github.com/repos/usemarkup/NeedleBundle","labels_url":"https://api.github.com/repos/usemarkup/NeedleBundle/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/usemarkup/NeedleBundle/issues/79/comments","events_url":"https://api.github.com/repos/usemarkup/NeedleBundle/issues/79/events","html_url":"https://github.com/usemarkup/NeedleBundle/pull/79","id":309357980,"number":79,"title":"fix: Add delete queries to corpus indexing","user":{"login":"ChrisDBrown","id":3877652,"avatar_url":"https://avatars3.githubusercontent.com/u/3877652?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisDBrown","html_url":"https://github.com/ChrisDBrown","followers_url":"https://api.github.com/users/ChrisDBrown/followers","following_url":"https://api.github.com/users/ChrisDBrown/following{/other_user}","gists_url":"https://api.github.com/users/ChrisDBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisDBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisDBrown/subscriptions","organizations_url":"https://api.github.com/users/ChrisDBrown/orgs","repos_url":"https://api.github.com/users/ChrisDBrown/repos","events_url":"https://api.github.com/users/ChrisDBrown/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisDBrown/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-28T13:04:14Z","updated_at":"2018-03-28T13:52:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/usemarkup/NeedleBundle/pulls/79","html_url":"https://github.com/usemarkup/NeedleBundle/pull/79","diff_url":"https://github.com/usemarkup/NeedleBundle/pull/79.diff","patch_url":"https://github.com/usemarkup/NeedleBundle/pull/79.patch"},"body":"Setting delete queries on the corpus indexing command currently doesn't appear to be working. Seems to be multiple issues here:\r\n\r\n1) The delete queries are only added to the command when a full delete is set. In reality this would cause a full delete to be requested, but only the delete query set to be ran.\r\n2) Setting these delete queries doesn't appear to actually delete the entries from solr.\r\n\r\nFirst commit here addresses the first issue - separating the full deletions from the more focussed delete queries. Will continue to look into the second issue and add to this PR."},"comment":{"url":"https://api.github.com/repos/usemarkup/NeedleBundle/issues/comments/376894527","html_url":"https://github.com/usemarkup/NeedleBundle/pull/79#issuecomment-376894527","issue_url":"https://api.github.com/repos/usemarkup/NeedleBundle/issues/79","id":376894527,"user":{"login":"ChrisDBrown","id":3877652,"avatar_url":"https://avatars3.githubusercontent.com/u/3877652?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisDBrown","html_url":"https://github.com/ChrisDBrown","followers_url":"https://api.github.com/users/ChrisDBrown/followers","following_url":"https://api.github.com/users/ChrisDBrown/following{/other_user}","gists_url":"https://api.github.com/users/ChrisDBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisDBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisDBrown/subscriptions","organizations_url":"https://api.github.com/users/ChrisDBrown/orgs","repos_url":"https://api.github.com/users/ChrisDBrown/repos","events_url":"https://api.github.com/users/ChrisDBrown/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisDBrown/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T13:52:46Z","updated_at":"2018-03-28T13:52:46Z","author_association":"MEMBER","body":"@shieldo updated now"}}
{"actor":{"display_login":"ChrisDBrown"}}