{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/172989826","pull_request_review_id":102103612,"id":172989826,"diff_hunk":"@@ -604,25 +604,27 @@ func (a AnsibleBroker) Provision(instanceUUID uuid.UUID, req *ProvisionRequest,\n \t//\n \t// if err is not nil, we will just bubble that up\n \n-\tif si, err := a.dao.GetServiceInstance(instanceUUID.String()); err == nil {\n-\t\t// This will use the package to make sure that if the type is changed\n-\t\t// away from []byte it can still be evaluated.\n-\t\tif uuid.Equal(si.ID, serviceInstance.ID) {\n-\t\t\tif reflect.DeepEqual(si.Parameters, serviceInstance.Parameters) {\n-\t\t\t\talreadyInProgress, jobToken, err := a.isJobInProgress(serviceInstance, apb.JobMethodProvision)\n-\t\t\t\tif err != nil {\n-\t\t\t\t\treturn nil, fmt.Errorf(\"An error occurred while trying to determine if a provision job is already in progress for instance: %s\", serviceInstance.ID)\n-\t\t\t\t}\n-\t\t\t\tif alreadyInProgress {\n-\t\t\t\t\tlog.Infof(\"Provision requested for instance %s, but job is already in progress\", serviceInstance.ID)\n-\t\t\t\t\treturn &ProvisionResponse{Operation: jobToken}, ErrorProvisionInProgress\n-\t\t\t\t}\n-\t\t\t\tlog.Debug(\"already have this instance returning 200\")\n-\t\t\t\treturn &ProvisionResponse{}, ErrorAlreadyProvisioned\n+\tsi, err := a.dao.GetServiceInstance(instanceUUID.String())\n+\tif err != nil && !a.dao.IsNotFoundError(err) {","path":"pkg/broker/broker.go","position":20,"original_position":20,"commit_id":"e4ed688d5a774b165bd5f4f95b8df1bfe66f94a4","original_commit_id":"e4ed688d5a774b165bd5f4f95b8df1bfe66f94a4","user":{"login":"maleck13","id":304628,"avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},"body":"changed to avoid ignoring other errors","created_at":"2018-03-07T21:26:25Z","updated_at":"2018-03-07T21:26:26Z","html_url":"https://github.com/openshift/ansible-service-broker/pull/821#discussion_r172989826","pull_request_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/172989826"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/821#discussion_r172989826"},"pull_request":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821","id":173577579,"html_url":"https://github.com/openshift/ansible-service-broker/pull/821","diff_url":"https://github.com/openshift/ansible-service-broker/pull/821.diff","patch_url":"https://github.com/openshift/ansible-service-broker/pull/821.patch","issue_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/821","number":821,"state":"open","locked":false,"title":"pass provision credentials during deprovision","user":{"login":"maleck13","id":304628,"avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},"body":"**Describe what this PR does and why we need it**:\r\n\r\nChanges proposed in this pull request\r\n - pass provision credentials during deprovision\r\n - add a make generate target for generating upto date mocks easily\r\n - change the logic in broker.go provision to check if the error is a not found error\r\n\r\n**Which issue this PR fixes (This will close that issue when PR gets merged)**\r\nfixes https://github.com/openshift/ansible-service-broker/issues/818\r\n","created_at":"2018-03-07T21:24:53Z","updated_at":"2018-03-07T21:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ff4d83d775b6229b6445fb2fd430f9c05c64fbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711624007,"url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821/commits","review_comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821/comments","review_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/821/comments","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/e4ed688d5a774b165bd5f4f95b8df1bfe66f94a4","head":{"label":"maleck13:pass-credentials-during-deprovision","ref":"pass-credentials-during-deprovision","sha":"e4ed688d5a774b165bd5f4f95b8df1bfe66f94a4","user":{"login":"maleck13","id":304628,"avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},"repo":{"id":95462824,"name":"ansible-service-broker","full_name":"maleck13/ansible-service-broker","owner":{"login":"maleck13","id":304628,"avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maleck13/ansible-service-broker","description":"Ansible Service Broker","fork":true,"url":"https://api.github.com/repos/maleck13/ansible-service-broker","forks_url":"https://api.github.com/repos/maleck13/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/maleck13/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maleck13/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maleck13/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/maleck13/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/maleck13/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/maleck13/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/maleck13/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/maleck13/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/maleck13/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/maleck13/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maleck13/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maleck13/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/maleck13/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maleck13/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/maleck13/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/maleck13/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/maleck13/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/maleck13/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/maleck13/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/maleck13/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/maleck13/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/maleck13/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/maleck13/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/maleck13/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/maleck13/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maleck13/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/maleck13/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maleck13/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/maleck13/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/maleck13/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/maleck13/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/maleck13/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maleck13/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/maleck13/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/maleck13/ansible-service-broker/deployments","created_at":"2017-06-26T15:44:14Z","updated_at":"2017-06-26T15:44:16Z","pushed_at":"2018-03-07T21:20:34Z","git_url":"git://github.com/maleck13/ansible-service-broker.git","ssh_url":"git@github.com:maleck13/ansible-service-broker.git","clone_url":"https://github.com/maleck13/ansible-service-broker.git","svn_url":"https://github.com/maleck13/ansible-service-broker","homepage":null,"size":77351,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f811bfb4238481cf7368051674404e29dbc0de01","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":79371528,"name":"ansible-service-broker","full_name":"openshift/ansible-service-broker","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/ansible-service-broker","description":"Ansible Service Broker","fork":false,"url":"https://api.github.com/repos/openshift/ansible-service-broker","forks_url":"https://api.github.com/repos/openshift/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/openshift/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/openshift/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/openshift/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/openshift/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/openshift/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/openshift/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/openshift/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/ansible-service-broker/deployments","created_at":"2017-01-18T18:40:49Z","updated_at":"2018-03-05T14:26:14Z","pushed_at":"2018-03-07T21:24:53Z","git_url":"git://github.com/openshift/ansible-service-broker.git","ssh_url":"git@github.com:openshift/ansible-service-broker.git","clone_url":"https://github.com/openshift/ansible-service-broker.git","svn_url":"https://github.com/openshift/ansible-service-broker","homepage":null,"size":93142,"stargazers_count":92,"watchers_count":92,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":47,"open_issues":41,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/821"},"issue":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/821"},"comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/e4ed688d5a774b165bd5f4f95b8df1bfe66f94a4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maleck13"}}