{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11998","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11998/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11998/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11998/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11998","id":366536646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTg1Nzcx","number":11998,"title":"[2.0.x] Support TMC2660","user":{"login":"teemuatlut","id":7762686,"node_id":"MDQ6VXNlcjc3NjI2ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/7762686?v=4","gravatar_id":"","url":"https://api.github.com/users/teemuatlut","html_url":"https://github.com/teemuatlut","followers_url":"https://api.github.com/users/teemuatlut/followers","following_url":"https://api.github.com/users/teemuatlut/following{/other_user}","gists_url":"https://api.github.com/users/teemuatlut/gists{/gist_id}","starred_url":"https://api.github.com/users/teemuatlut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemuatlut/subscriptions","organizations_url":"https://api.github.com/users/teemuatlut/orgs","repos_url":"https://api.github.com/users/teemuatlut/repos","events_url":"https://api.github.com/users/teemuatlut/events{/privacy}","received_events_url":"https://api.github.com/users/teemuatlut/received_events","type":"User","site_admin":false},"labels":[{"id":848340248,"node_id":"MDU6TGFiZWw4NDgzNDAyNDg=","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/F:%20Trinamic","name":"F: Trinamic","color":"3cc9c9","default":false},{"id":92052497,"node_id":"MDU6TGFiZWw5MjA1MjQ5Nw==","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Improvement","name":"PR: Improvement","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-03T21:27:50Z","updated_at":"2018-10-06T17:56:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11998","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11998","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/11998.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/11998.patch"},"body":"Add support for Trinamic `TMC2660`. Basically this means the Panucatt BSD2660 drivers.\r\nNot every feature is written yet but I'd like to get the basic support going for a broader audience.\r\nThe drivers do not have an EN pin so the function is implemented in software through SPI, very similar to how TMC26x is not at the moment. The TMC2660 is based on 26x after all.\r\nThis functionality can/will be expanded to other drivers as well and all (newer) TMC drivers will be supported. This will also allow for manufacturers and board designers to completely leave out the EN lines on MCUs that may not have many pins available.\r\n\r\n---\r\n\r\nTouch up on some of the issues from #11943\r\n* `M122 S[1, 0]` now requires both `MONITOR_DRIVER_STATUS` and `TMC_DEBUG`.\r\n\r\n---\r\nHere's a general plan for the rest of the year.\r\nTicked boxes mark the changes introduced in this PR and the ones that have already been merged in.\r\n- [x] Move to new universal TMCStepper library\r\n- [x] Implement inherited Marlin TMC classes\r\n- [x] Support TMC2660\r\n- [ ] Support TMC5160\r\n- [ ] Add sanity checking for driver errors\r\n- [ ] Greatly reduce communication attempts for monitoring\r\n- [ ] Improve TMC error verbosity with better error messages\r\n- [ ] Add communication checking on boot\r\n- [ ] Add the ability to change chopper timings (spreadCycle)\r\n- [ ] Tweak default chopper settings for quieter spreadCycle operation\r\n- [ ] Support Trinamic coolStep technology\r\n- [ ] Improve `M122` with fetching raw register data\r\n- [ ] Add TMC section to the LCD\r\n- [ ] Support TMC5130\r\n- [ ] Support TMC2224\r\n- [ ] Add `SOFTWARE_ENABLE` for all smart drivers (Request from Panucatt)"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/427594007","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11998#issuecomment-427594007","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11998","id":427594007,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzU5NDAwNw==","user":{"login":"thinkyhead","id":698003,"node_id":"MDQ6VXNlcjY5ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T17:56:42Z","updated_at":"2018-10-06T17:56:42Z","author_association":"MEMBER","body":"> It'll become more relevant when we add TMC5160, so we can add it now or later.\r\n\r\nI figure it's good to be expressive and make it so that we only have to change it in one place as new drivers are introduced, even though we might end up adding to the \"conditional overload.\" But then, I suppose we crossed that bridge a while ago."}}
{"actor":{"display_login":"thinkyhead"}}