{"action":"created","issue":{"url":"https://api.github.com/repos/toggl/mobileapp/issues/3536","repository_url":"https://api.github.com/repos/toggl/mobileapp","labels_url":"https://api.github.com/repos/toggl/mobileapp/issues/3536/labels{/name}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/3536/comments","events_url":"https://api.github.com/repos/toggl/mobileapp/issues/3536/events","html_url":"https://github.com/toggl/mobileapp/issues/3536","id":373084044,"node_id":"MDU6SXNzdWUzNzMwODQwNDQ=","number":3536,"title":"Drop Action suffixes from UIActions and InputActions","user":{"login":"willsb","id":7688727,"node_id":"MDQ6VXNlcjc2ODg3Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/7688727?v=4","gravatar_id":"","url":"https://api.github.com/users/willsb","html_url":"https://github.com/willsb","followers_url":"https://api.github.com/users/willsb/followers","following_url":"https://api.github.com/users/willsb/following{/other_user}","gists_url":"https://api.github.com/users/willsb/gists{/gist_id}","starred_url":"https://api.github.com/users/willsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsb/subscriptions","organizations_url":"https://api.github.com/users/willsb/orgs","repos_url":"https://api.github.com/users/willsb/repos","events_url":"https://api.github.com/users/willsb/events{/privacy}","received_events_url":"https://api.github.com/users/willsb/received_events","type":"User","site_admin":false},"labels":[{"id":831152836,"node_id":"MDU6TGFiZWw4MzExNTI4MzY=","url":"https://api.github.com/repos/toggl/mobileapp/labels/foundation","name":"foundation","color":"646490","default":false},{"id":829930771,"node_id":"MDU6TGFiZWw4Mjk5MzA3NzE=","url":"https://api.github.com/repos/toggl/mobileapp/labels/refactoring","name":"refactoring","color":"ffe787","default":false}],"state":"open","locked":false,"assignee":{"login":"Odrakir","id":724743,"node_id":"MDQ6VXNlcjcyNDc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/724743?v=4","gravatar_id":"","url":"https://api.github.com/users/Odrakir","html_url":"https://github.com/Odrakir","followers_url":"https://api.github.com/users/Odrakir/followers","following_url":"https://api.github.com/users/Odrakir/following{/other_user}","gists_url":"https://api.github.com/users/Odrakir/gists{/gist_id}","starred_url":"https://api.github.com/users/Odrakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odrakir/subscriptions","organizations_url":"https://api.github.com/users/Odrakir/orgs","repos_url":"https://api.github.com/users/Odrakir/repos","events_url":"https://api.github.com/users/Odrakir/events{/privacy}","received_events_url":"https://api.github.com/users/Odrakir/received_events","type":"User","site_admin":false},"assignees":[{"login":"Odrakir","id":724743,"node_id":"MDQ6VXNlcjcyNDc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/724743?v=4","gravatar_id":"","url":"https://api.github.com/users/Odrakir","html_url":"https://github.com/Odrakir","followers_url":"https://api.github.com/users/Odrakir/followers","following_url":"https://api.github.com/users/Odrakir/following{/other_user}","gists_url":"https://api.github.com/users/Odrakir/gists{/gist_id}","starred_url":"https://api.github.com/users/Odrakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odrakir/subscriptions","organizations_url":"https://api.github.com/users/Odrakir/orgs","repos_url":"https://api.github.com/users/Odrakir/repos","events_url":"https://api.github.com/users/Odrakir/events{/privacy}","received_events_url":"https://api.github.com/users/Odrakir/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-23T16:16:49Z","updated_at":"2018-10-30T11:59:20Z","closed_at":null,"author_association":"MEMBER","body":"### The problem\r\nSome UI/Input Actions have the `Action` suffix and some do not. We need consistency here.\r\n\r\n### The solution\r\nI say we drop all `Action` suffixes, similar to what we did with Observables, unless someone has a good case as to why we shouldn't do so. \r\n\r\nEither way, please consider the decision made here before working on #3533"},"comment":{"url":"https://api.github.com/repos/toggl/mobileapp/issues/comments/434273100","html_url":"https://github.com/toggl/mobileapp/issues/3536#issuecomment-434273100","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/3536","id":434273100,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDI3MzEwMA==","user":{"login":"Odrakir","id":724743,"node_id":"MDQ6VXNlcjcyNDc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/724743?v=4","gravatar_id":"","url":"https://api.github.com/users/Odrakir","html_url":"https://github.com/Odrakir","followers_url":"https://api.github.com/users/Odrakir/followers","following_url":"https://api.github.com/users/Odrakir/following{/other_user}","gists_url":"https://api.github.com/users/Odrakir/gists{/gist_id}","starred_url":"https://api.github.com/users/Odrakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odrakir/subscriptions","organizations_url":"https://api.github.com/users/Odrakir/orgs","repos_url":"https://api.github.com/users/Odrakir/repos","events_url":"https://api.github.com/users/Odrakir/events{/privacy}","received_events_url":"https://api.github.com/users/Odrakir/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T11:59:20Z","updated_at":"2018-10-30T11:59:20Z","author_association":"CONTRIBUTOR","body":"This is simple enough.\r\n\r\nAlso, how about things like: `CloseButtonTapped = UIAction.FromObservable(cancel);`\r\n\r\nShould the Action be called as the UI event triggering it?"}}
{"actor":{"display_login":"Odrakir"}}