{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/589","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/589/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/589/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/589/events","html_url":"https://github.com/StrikeNP/trac_test/issues/589","id":332197736,"node_id":"MDU6SXNzdWUzMzIxOTc3MzY=","number":589,"title":"Move -Dnooverlap and -Dradoffline to compile.bash (Trac #589)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":963997231,"node_id":"MDU6TGFiZWw5NjM5OTcyMzE=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":963997516,"node_id":"MDU6TGFiZWw5NjM5OTc1MTY=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":963997043,"node_id":"MDU6TGFiZWw5NjM5OTcwNDM=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":964076735,"node_id":"MDU6TGFiZWw5NjQwNzY3MzU=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/raut@uwm.edu","name":"raut@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4","html_url":"https://github.com/StrikeNP/trac_test/milestone/4","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4/labels","id":3423155,"node_id":"MDk6TWlsZXN0b25lMzQyMzE1NQ==","number":4,"title":"3. Refactor CLUBB","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":95,"state":"open","created_at":"2018-06-13T20:01:14Z","updated_at":"2018-06-15T13:35:11Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-06-13T23:14:40Z","updated_at":"2018-06-15T13:36:59Z","closed_at":null,"author_association":"OWNER","body":"\n**Technical spec**\n\nCurrently, the BUGSrad preprocessor options -Dnooverlap and -Dradoffline are included in all our configure files.  This duplication could be avoided by moving -Dnooverlap and -Dradoffline to compile.bash.  The only drawback is that then all users have to compile BUGSrad radiation code, but I think in the majority of cases we'll want to be able to use the BUGSrad code, and so I think we should move the preprocessor flags.\n\n**Tests**\n\nWe want to make sure we have bit-for-bit identical results when we compile and run all cases.  In addition, we want to make sure that SAM-CLUBB, WRF-CLUBB, and CAM-CLUBB can compile.  \n\nAttachments:\n\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/589\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2013-07-19T14:03:32\", \n    \"description\": \"\\n'''Technical spec'''\\n\\nCurrently, the BUGSrad preprocessor options -Dnooverlap and -Dradoffline are included in all our configure files.  This duplication could be avoided by moving -Dnooverlap and -Dradoffline to compile.bash.  The only drawback is that then all users have to compile BUGSrad radiation code, but I think in the majority of cases we'll want to be able to use the BUGSrad code, and so I think we should move the preprocessor flags.\\n\\n'''Tests'''\\n\\nWe want to make sure we have bit-for-bit identical results when we compile and run all cases.  In addition, we want to make sure that SAM-CLUBB, WRF-CLUBB, and CAM-CLUBB can compile.  \", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, dschanen@uwm.edu, charlass@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1374242612105881\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Move -Dnooverlap and -Dradoffline to compile.bash\", \n    \"priority\": \"minor\", \n    \"keywords\": \"\", \n    \"time\": \"2013-07-17T14:28:35\", \n    \"milestone\": \"3. Refactor CLUBB\", \n    \"owner\": \"raut@uwm.edu\", \n    \"type\": \"enhancement\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/397622453","html_url":"https://github.com/StrikeNP/trac_test/issues/589#issuecomment-397622453","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/589","id":397622453,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzYyMjQ1Mw==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T13:36:59Z","updated_at":"2018-06-15T13:36:59Z","author_association":"OWNER","body":"**Trac update on 2013/07/18 at 17:49**\n**raut@uwm.edu commented:**\n\nIn [wrf:browser:/trunk/WRF/phys/Makefile?rev=430 WRF/phys/Makefile], I see:\n\n```text\nclubb/output_grads.o : \\\n                clubb/output_grads.F90 \\\n                clubb/clubb_precision.o \\\n                clubb/stat_file_module.o \\\n                clubb/calendar.o \\\n                clubb/endian.o \\\n                clubb/constants_clubb.o \\\n                clubb/model_flags.o \\\n                clubb/recl.inc\nclubb/output_netcdf.o : \\\n                clubb/output_netcdf.F90 \\\n                clubb/parameter_indices.o \\\n                clubb/parameters_tunable.o \\\n                clubb/clubb_precision.o \\\n                clubb/stat_file_module.o \\\n                clubb/calendar.o \\\n                clubb/parameters_radiation.o \\\n                clubb/constants_clubb.o \\\n                clubb/parameters_model.o \\\n                clubb/model_flags.o \\\n                clubb/parameters_microphys.o\n```\nI wonder if I just add `clubb/stats_variables.o` to these.\n\nCarsten similarly cleaned up after me in wrf:r407.\n\n"}}
{"actor":{"display_login":"StrikeNP"}}