{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/238041626","pull_request_review_id":180498277,"id":238041626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA0MTYyNg==","diff_hunk":"@@ -61,5 +61,5 @@ <h1>{{_('Sign up, sign in, stay in sync.')}}</h1>\n {% endblock %}\n \n {% block js %}\n-  {{ js_bundle('firefox_accounts') }}\n+  {{ js_bundle('firefox_accounts_2018') }}","path":"bedrock/firefox/templates/firefox/accounts.html","position":5,"original_position":5,"commit_id":"b2d7a063cfc1c15171be0296ed4a1b690673ab31","original_commit_id":"dc85ad371b2c698a94312671cb85be2d210cf3f1","user":{"login":"stephaniehobson","id":854701,"node_id":"MDQ6VXNlcjg1NDcwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/854701?v=4","gravatar_id":"","url":"https://api.github.com/users/stephaniehobson","html_url":"https://github.com/stephaniehobson","followers_url":"https://api.github.com/users/stephaniehobson/followers","following_url":"https://api.github.com/users/stephaniehobson/following{/other_user}","gists_url":"https://api.github.com/users/stephaniehobson/gists{/gist_id}","starred_url":"https://api.github.com/users/stephaniehobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephaniehobson/subscriptions","organizations_url":"https://api.github.com/users/stephaniehobson/orgs","repos_url":"https://api.github.com/users/stephaniehobson/repos","events_url":"https://api.github.com/users/stephaniehobson/events{/privacy}","received_events_url":"https://api.github.com/users/stephaniehobson/received_events","type":"User","site_admin":false},"body":"So this needs to be switched back?","created_at":"2018-12-01T00:39:54Z","updated_at":"2018-12-01T00:54:54Z","html_url":"https://github.com/mozilla/bedrock/pull/6503#discussion_r238041626","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/6503","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/238041626"},"html":{"href":"https://github.com/mozilla/bedrock/pull/6503#discussion_r238041626"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6503"}},"in_reply_to_id":237304616},"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/6503","id":232832552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODMyNTUy","html_url":"https://github.com/mozilla/bedrock/pull/6503","diff_url":"https://github.com/mozilla/bedrock/pull/6503.diff","patch_url":"https://github.com/mozilla/bedrock/pull/6503.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/6503","number":6503,"state":"open","locked":false,"title":"[#6339] New Firefox Accounts page","user":{"login":"craigcook","id":205591,"node_id":"MDQ6VXNlcjIwNTU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/205591?v=4","gravatar_id":"","url":"https://api.github.com/users/craigcook","html_url":"https://github.com/craigcook","followers_url":"https://api.github.com/users/craigcook/followers","following_url":"https://api.github.com/users/craigcook/following{/other_user}","gists_url":"https://api.github.com/users/craigcook/gists{/gist_id}","starred_url":"https://api.github.com/users/craigcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigcook/subscriptions","organizations_url":"https://api.github.com/users/craigcook/orgs","repos_url":"https://api.github.com/users/craigcook/repos","events_url":"https://api.github.com/users/craigcook/events{/privacy}","received_events_url":"https://api.github.com/users/craigcook/received_events","type":"User","site_admin":false},"body":"## Description\r\nRedesigns the page at /firefox/accounts/ and removes the old Accounts Benefits page, as well as the Sync and Send Tabs feature pages.\r\n\r\n## Issue / Bugzilla link\r\n#6339 \r\n\r\n## Testing\r\nhttps://www-demo3.allizom.org/firefox/accounts/\r\n\r\n- [x] If on desktop, product cta's will open modal with QR code & app store buttons.\r\n- [x] If on mobile, product cta's will be app store buttons.\r\n\r\n![features user flow secondary](https://user-images.githubusercontent.com/30483988/49116744-6e356300-f253-11e8-8b4b-f73abf89937b.png)\r\n\r\n**NOT DOING CUSTOM DOWNLOAD/THANKS (ignore on chart)**\r\n\r\n- [x] if using browser other than firefox, user gets download firefox button.\r\n- [x] if using firefox, user gets sign up for fxa cta. Bottom banner is form, hero is button.\r\n- [x] if using firefox & signed into firefox accounts, user gets firefox mobile app ctas. (Modal with QR code for hero for desktop, app store buttons for mobile & bottom banner.)\r\n\r\n![features user flow main](https://user-images.githubusercontent.com/30483988/49116966-164b2c00-f254-11e8-9a49-ee08d6107e65.png)\r\n\r\n","created_at":"2018-11-22T00:53:32Z","updated_at":"2018-12-01T00:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fe704db8e2ee73e34ea7829045ba1b7bcc7008e","assignee":{"login":"stephaniehobson","id":854701,"node_id":"MDQ6VXNlcjg1NDcwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/854701?v=4","gravatar_id":"","url":"https://api.github.com/users/stephaniehobson","html_url":"https://github.com/stephaniehobson","followers_url":"https://api.github.com/users/stephaniehobson/followers","following_url":"https://api.github.com/users/stephaniehobson/following{/other_user}","gists_url":"https://api.github.com/users/stephaniehobson/gists{/gist_id}","starred_url":"https://api.github.com/users/stephaniehobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephaniehobson/subscriptions","organizations_url":"https://api.github.com/users/stephaniehobson/orgs","repos_url":"https://api.github.com/users/stephaniehobson/repos","events_url":"https://api.github.com/users/stephaniehobson/events{/privacy}","received_events_url":"https://api.github.com/users/stephaniehobson/received_events","type":"User","site_admin":false},"assignees":[{"login":"stephaniehobson","id":854701,"node_id":"MDQ6VXNlcjg1NDcwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/854701?v=4","gravatar_id":"","url":"https://api.github.com/users/stephaniehobson","html_url":"https://github.com/stephaniehobson","followers_url":"https://api.github.com/users/stephaniehobson/followers","following_url":"https://api.github.com/users/stephaniehobson/following{/other_user}","gists_url":"https://api.github.com/users/stephaniehobson/gists{/gist_id}","starred_url":"https://api.github.com/users/stephaniehobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephaniehobson/subscriptions","organizations_url":"https://api.github.com/users/stephaniehobson/orgs","repos_url":"https://api.github.com/users/stephaniehobson/repos","events_url":"https://api.github.com/users/stephaniehobson/events{/privacy}","received_events_url":"https://api.github.com/users/stephaniehobson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118505096,"node_id":"MDU6TGFiZWwxMTg1MDUwOTY=","url":"https://api.github.com/repos/mozilla/bedrock/labels/Do%20Not%20Merge%20:warning:","name":"Do Not Merge :warning:","color":"e10c02","default":false},{"id":269331505,"node_id":"MDU6TGFiZWwyNjkzMzE1MDU=","url":"https://api.github.com/repos/mozilla/bedrock/labels/L10N%20-%20Localization%20Started","name":"L10N - Localization Started","color":"fef2c0","default":false},{"id":929358074,"node_id":"MDU6TGFiZWw5MjkzNTgwNzQ=","url":"https://api.github.com/repos/mozilla/bedrock/labels/Needs%20Review","name":"Needs Review","color":"fbca04","default":false},{"id":645440477,"node_id":"MDU6TGFiZWw2NDU0NDA0Nzc=","url":"https://api.github.com/repos/mozilla/bedrock/labels/P1","name":"P1","color":"5319e7","default":false},{"id":1111274006,"node_id":"MDU6TGFiZWwxMTExMjc0MDA2","url":"https://api.github.com/repos/mozilla/bedrock/labels/Review:%20L","name":"Review: L","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/6503/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/6503/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/6503/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/b2d7a063cfc1c15171be0296ed4a1b690673ab31","head":{"label":"mozilla:6339-fxa-benefits","ref":"6339-fxa-benefits","sha":"b2d7a063cfc1c15171be0296ed4a1b690673ab31","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2NjY1","name":"bedrock","full_name":"mozilla/bedrock","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2018-11-30T23:39:42Z","pushed_at":"2018-12-01T00:16:10Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":494889,"stargazers_count":751,"watchers_count":751,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":756,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":756,"open_issues":171,"watchers":751,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4632f646d9dc116c0e46a1d94f8b1cbb0c0d37ee","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2NjY1","name":"bedrock","full_name":"mozilla/bedrock","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2018-11-30T23:39:42Z","pushed_at":"2018-12-01T00:16:10Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":494889,"stargazers_count":751,"watchers_count":751,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":756,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":756,"open_issues":171,"watchers":751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6503"},"html":{"href":"https://github.com/mozilla/bedrock/pull/6503"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/6503"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/6503/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6503/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6503/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/b2d7a063cfc1c15171be0296ed4a1b690673ab31"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stephaniehobson"}}