{"action":"created","comment":{"url":"https://api.github.com/repos/Kong/kong/pulls/comments/225632111","pull_request_review_id":165272962,"id":225632111,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTYzMjExMQ==","diff_hunk":"@@ -26,7 +28,7 @@ return {\n           return endpoints.handle_error(err_t)\n         end\n         if not consumer then\n-          return responses.send_HTTP_NOT_FOUND()\n+          return kong.response.exit(HTTP_NOT_FOUND, { Message = \"Not found\" })","path":"kong/plugins/key-auth/api.lua","position":20,"original_position":20,"commit_id":"57b29a409d613b605f3ea78b83d89f5a2cfe7e0d","original_commit_id":"57b29a409d613b605f3ea78b83d89f5a2cfe7e0d","user":{"login":"bungle","id":983257,"node_id":"MDQ6VXNlcjk4MzI1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/983257?v=4","gravatar_id":"","url":"https://api.github.com/users/bungle","html_url":"https://github.com/bungle","followers_url":"https://api.github.com/users/bungle/followers","following_url":"https://api.github.com/users/bungle/following{/other_user}","gists_url":"https://api.github.com/users/bungle/gists{/gist_id}","starred_url":"https://api.github.com/users/bungle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bungle/subscriptions","organizations_url":"https://api.github.com/users/bungle/orgs","repos_url":"https://api.github.com/users/bungle/repos","events_url":"https://api.github.com/users/bungle/events{/privacy}","received_events_url":"https://api.github.com/users/bungle/received_events","type":"User","site_admin":false},"body":"is the capital `Message` a mistake, shouldn't it be `message`? ","created_at":"2018-10-16T17:14:43Z","updated_at":"2018-10-16T17:14:50Z","html_url":"https://github.com/Kong/kong/pull/3844#discussion_r225632111","pull_request_url":"https://api.github.com/repos/Kong/kong/pulls/3844","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Kong/kong/pulls/comments/225632111"},"html":{"href":"https://github.com/Kong/kong/pull/3844#discussion_r225632111"},"pull_request":{"href":"https://api.github.com/repos/Kong/kong/pulls/3844"}}},"pull_request":{"url":"https://api.github.com/repos/Kong/kong/pulls/3844","id":221864801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODY0ODAx","html_url":"https://github.com/Kong/kong/pull/3844","diff_url":"https://github.com/Kong/kong/pull/3844.diff","patch_url":"https://github.com/Kong/kong/pull/3844.patch","issue_url":"https://api.github.com/repos/Kong/kong/issues/3844","number":3844,"state":"open","locked":false,"title":"feat(plugins) convert more plugins away from deprecated functions","user":{"login":"hishamhm","id":245621,"node_id":"MDQ6VXNlcjI0NTYyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/245621?v=4","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"body":"This converts a number of plugins reducing their dependence on deprecated `kong.tools.*` functions and raw `ngx.*` calls, switching those to PDK calls as much as possible.\r\n\r\nCovered in this PR:\r\n\r\n* aws-lambda\r\n* bot-detection\r\n* cors\r\n* key-auth\r\n* ip-restriction\r\n* oauth2\r\n* request-size-limiting\r\n* response-ratelimiting\r\n   * this one includes a couple of fixes: improved test suite (still flaky but more usable); an update to perform a pg 9.5+ upsert on increment (which fixes a race-condition in the old implementation); fixed inverted arguments in the base migration.\r\n\r\nChanges to the PDK:\r\n\r\n* `kong.request.get_body` decodes JSON using the array metatable\r\n* `kong.response.exit` respects `enabled_headers`\r\n* add `kong.table.merge`\r\n* add `admin_api` phase, to indincate which PDK functions are usable from a plugin's `api.lua` file\r\n* minor doc fix in `kong.request.get_header`\r\n","created_at":"2018-10-10T17:03:03Z","updated_at":"2018-10-16T17:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b9ad259681dc98e176f2d0d94092ec03113e6c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kong/kong/pulls/3844/commits","review_comments_url":"https://api.github.com/repos/Kong/kong/pulls/3844/comments","review_comment_url":"https://api.github.com/repos/Kong/kong/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kong/kong/issues/3844/comments","statuses_url":"https://api.github.com/repos/Kong/kong/statuses/57b29a409d613b605f3ea78b83d89f5a2cfe7e0d","head":{"label":"Kong:feat/plugins-update-new-apis","ref":"feat/plugins-update-new-apis","sha":"57b29a409d613b605f3ea78b83d89f5a2cfe7e0d","user":{"login":"Kong","id":962416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MjQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"repo":{"id":26783295,"node_id":"MDEwOlJlcG9zaXRvcnkyNjc4MzI5NQ==","name":"kong","full_name":"Kong/kong","private":false,"owner":{"login":"Kong","id":962416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MjQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Kong/kong","description":":gorilla: The Cloud-Native API Gateway","fork":false,"url":"https://api.github.com/repos/Kong/kong","forks_url":"https://api.github.com/repos/Kong/kong/forks","keys_url":"https://api.github.com/repos/Kong/kong/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kong/kong/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kong/kong/teams","hooks_url":"https://api.github.com/repos/Kong/kong/hooks","issue_events_url":"https://api.github.com/repos/Kong/kong/issues/events{/number}","events_url":"https://api.github.com/repos/Kong/kong/events","assignees_url":"https://api.github.com/repos/Kong/kong/assignees{/user}","branches_url":"https://api.github.com/repos/Kong/kong/branches{/branch}","tags_url":"https://api.github.com/repos/Kong/kong/tags","blobs_url":"https://api.github.com/repos/Kong/kong/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kong/kong/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kong/kong/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kong/kong/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kong/kong/statuses/{sha}","languages_url":"https://api.github.com/repos/Kong/kong/languages","stargazers_url":"https://api.github.com/repos/Kong/kong/stargazers","contributors_url":"https://api.github.com/repos/Kong/kong/contributors","subscribers_url":"https://api.github.com/repos/Kong/kong/subscribers","subscription_url":"https://api.github.com/repos/Kong/kong/subscription","commits_url":"https://api.github.com/repos/Kong/kong/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kong/kong/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kong/kong/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kong/kong/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kong/kong/contents/{+path}","compare_url":"https://api.github.com/repos/Kong/kong/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kong/kong/merges","archive_url":"https://api.github.com/repos/Kong/kong/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kong/kong/downloads","issues_url":"https://api.github.com/repos/Kong/kong/issues{/number}","pulls_url":"https://api.github.com/repos/Kong/kong/pulls{/number}","milestones_url":"https://api.github.com/repos/Kong/kong/milestones{/number}","notifications_url":"https://api.github.com/repos/Kong/kong/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kong/kong/labels{/name}","releases_url":"https://api.github.com/repos/Kong/kong/releases{/id}","deployments_url":"https://api.github.com/repos/Kong/kong/deployments","created_at":"2014-11-17T23:56:08Z","updated_at":"2018-10-16T17:14:19Z","pushed_at":"2018-10-16T17:05:13Z","git_url":"git://github.com/Kong/kong.git","ssh_url":"git@github.com:Kong/kong.git","clone_url":"https://github.com/Kong/kong.git","svn_url":"https://github.com/Kong/kong","homepage":"https://konghq.com/install","size":10369,"stargazers_count":18241,"watchers_count":18241,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2134,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2134,"open_issues":309,"watchers":18241,"default_branch":"master"}},"base":{"label":"Kong:next","ref":"next","sha":"c0c11cf285de2223c0f6b6fdf8776d88b5f97e6c","user":{"login":"Kong","id":962416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MjQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"repo":{"id":26783295,"node_id":"MDEwOlJlcG9zaXRvcnkyNjc4MzI5NQ==","name":"kong","full_name":"Kong/kong","private":false,"owner":{"login":"Kong","id":962416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MjQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Kong/kong","description":":gorilla: The Cloud-Native API Gateway","fork":false,"url":"https://api.github.com/repos/Kong/kong","forks_url":"https://api.github.com/repos/Kong/kong/forks","keys_url":"https://api.github.com/repos/Kong/kong/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kong/kong/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kong/kong/teams","hooks_url":"https://api.github.com/repos/Kong/kong/hooks","issue_events_url":"https://api.github.com/repos/Kong/kong/issues/events{/number}","events_url":"https://api.github.com/repos/Kong/kong/events","assignees_url":"https://api.github.com/repos/Kong/kong/assignees{/user}","branches_url":"https://api.github.com/repos/Kong/kong/branches{/branch}","tags_url":"https://api.github.com/repos/Kong/kong/tags","blobs_url":"https://api.github.com/repos/Kong/kong/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kong/kong/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kong/kong/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kong/kong/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kong/kong/statuses/{sha}","languages_url":"https://api.github.com/repos/Kong/kong/languages","stargazers_url":"https://api.github.com/repos/Kong/kong/stargazers","contributors_url":"https://api.github.com/repos/Kong/kong/contributors","subscribers_url":"https://api.github.com/repos/Kong/kong/subscribers","subscription_url":"https://api.github.com/repos/Kong/kong/subscription","commits_url":"https://api.github.com/repos/Kong/kong/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kong/kong/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kong/kong/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kong/kong/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kong/kong/contents/{+path}","compare_url":"https://api.github.com/repos/Kong/kong/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kong/kong/merges","archive_url":"https://api.github.com/repos/Kong/kong/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kong/kong/downloads","issues_url":"https://api.github.com/repos/Kong/kong/issues{/number}","pulls_url":"https://api.github.com/repos/Kong/kong/pulls{/number}","milestones_url":"https://api.github.com/repos/Kong/kong/milestones{/number}","notifications_url":"https://api.github.com/repos/Kong/kong/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kong/kong/labels{/name}","releases_url":"https://api.github.com/repos/Kong/kong/releases{/id}","deployments_url":"https://api.github.com/repos/Kong/kong/deployments","created_at":"2014-11-17T23:56:08Z","updated_at":"2018-10-16T17:14:19Z","pushed_at":"2018-10-16T17:05:13Z","git_url":"git://github.com/Kong/kong.git","ssh_url":"git@github.com:Kong/kong.git","clone_url":"https://github.com/Kong/kong.git","svn_url":"https://github.com/Kong/kong","homepage":"https://konghq.com/install","size":10369,"stargazers_count":18241,"watchers_count":18241,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2134,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2134,"open_issues":309,"watchers":18241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kong/kong/pulls/3844"},"html":{"href":"https://github.com/Kong/kong/pull/3844"},"issue":{"href":"https://api.github.com/repos/Kong/kong/issues/3844"},"comments":{"href":"https://api.github.com/repos/Kong/kong/issues/3844/comments"},"review_comments":{"href":"https://api.github.com/repos/Kong/kong/pulls/3844/comments"},"review_comment":{"href":"https://api.github.com/repos/Kong/kong/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kong/kong/pulls/3844/commits"},"statuses":{"href":"https://api.github.com/repos/Kong/kong/statuses/57b29a409d613b605f3ea78b83d89f5a2cfe7e0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bungle"}}