{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/185752470","pull_request_review_id":117203330,"id":185752470,"diff_hunk":"@@ -320,6 +335,48 @@ func BeforeTestSuitSetup() {\n \tCreatePVC(osWindows, defaultWindowsDiskSize)\n }\n \n+func GetListOfManifests(pathToManifestsDir string) []string {\n+\tvar manifests []string\n+\tfiles, err := ioutil.ReadDir(pathToManifestsDir)\n+\tif err != nil {\n+\t\tpanic(err)\n+\t}\n+\tmatchFileName := func(pattern, filename string) bool {\n+\t\tmatch, err := filepath.Match(pattern, filename)\n+\t\tif err != nil {\n+\t\t\tpanic(err)\n+\t\t}\n+\t\treturn match\n+\t}\n+\tfor _, file := range files {\n+\t\tif matchFileName(\"*-for-ocp.yaml\", file.Name()) {\n+\t\t\tif CurrentClusterType.value == OpenShiftClusterType {\n+\t\t\t\tmanifests = append(manifests, file.Name())\n+\t\t\t}\n+\t\t} else if matchFileName(\"*for-k8s.yaml\", file.Name()) {\n+\t\t\tif CurrentClusterType.value == KubernetesClusterType {\n+\t\t\t\tmanifests = append(manifests, file.Name())\n+\t\t\t}\n+\t\t} else if matchFileName(\"*.yaml\", file.Name()) {\n+\t\t\tmanifests = append(manifests, file.Name())\n+\t\t}\n+\t}\n+\treturn manifests\n+}\n+\n+func DeployTestingInfrastructure() {\n+\tfmt.Printf(fmt.Sprintf(\"Manifest dir: %s\\n\", PathToTestingInfrastrucureManifests))\n+\tmanifests := GetListOfManifests(PathToTestingInfrastrucureManifests)\n+\tfor _, manifest := range manifests {\n+\t\t// TODO: Load manifest and send it via AP","path":"tests/utils.go","position":87,"original_position":87,"commit_id":"b673decf89a740d7a30caacdff429278aaa593b5","original_commit_id":"b673decf89a740d7a30caacdff429278aaa593b5","user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"body":"Hm, here we have two options:\r\n\r\n1) copy over SecurityContextContextConstraints from https://github.com/openshift/origin/blob/master/pkg/security/apis/security/types.go#L19 (not so much a bad idea because whateve will change in origin, this is already v1 and will always work) and register it like it is done here: https://github.com/kubevirt/kubevirt/blob/master/pkg/api/v1/types.go#L92.\r\n2) the rest client can do raw requests to arbitrary paths too. So instead of deserializing them first, simply send them directly.","created_at":"2018-05-03T10:15:22Z","updated_at":"2018-05-03T10:15:22Z","html_url":"https://github.com/kubevirt/kubevirt/pull/931#discussion_r185752470","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/185752470"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/931#discussion_r185752470"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931"}},"in_reply_to_id":184465320},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931","id":182830085,"html_url":"https://github.com/kubevirt/kubevirt/pull/931","diff_url":"https://github.com/kubevirt/kubevirt/pull/931.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/931.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/931","number":931,"state":"open","locked":false,"title":"Build container to run tests containerised","user":{"login":"lukas-bednar","id":1505684,"avatar_url":"https://avatars0.githubusercontent.com/u/1505684?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-bednar","html_url":"https://github.com/lukas-bednar","followers_url":"https://api.github.com/users/lukas-bednar/followers","following_url":"https://api.github.com/users/lukas-bednar/following{/other_user}","gists_url":"https://api.github.com/users/lukas-bednar/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-bednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-bednar/subscriptions","organizations_url":"https://api.github.com/users/lukas-bednar/orgs","repos_url":"https://api.github.com/users/lukas-bednar/repos","events_url":"https://api.github.com/users/lukas-bednar/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-bednar/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Lukas Bednar <lbednar@redhat.com>","created_at":"2018-04-19T16:22:00Z","updated_at":"2018-05-03T10:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"117104bcbae1773f4e9bc9fe4c49b8475ac5fad7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/931/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/b673decf89a740d7a30caacdff429278aaa593b5","head":{"label":"lukas-bednar:test-container","ref":"test-container","sha":"b673decf89a740d7a30caacdff429278aaa593b5","user":{"login":"lukas-bednar","id":1505684,"avatar_url":"https://avatars0.githubusercontent.com/u/1505684?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-bednar","html_url":"https://github.com/lukas-bednar","followers_url":"https://api.github.com/users/lukas-bednar/followers","following_url":"https://api.github.com/users/lukas-bednar/following{/other_user}","gists_url":"https://api.github.com/users/lukas-bednar/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-bednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-bednar/subscriptions","organizations_url":"https://api.github.com/users/lukas-bednar/orgs","repos_url":"https://api.github.com/users/lukas-bednar/repos","events_url":"https://api.github.com/users/lukas-bednar/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-bednar/received_events","type":"User","site_admin":false},"repo":{"id":109144306,"name":"kubevirt","full_name":"lukas-bednar/kubevirt","owner":{"login":"lukas-bednar","id":1505684,"avatar_url":"https://avatars0.githubusercontent.com/u/1505684?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-bednar","html_url":"https://github.com/lukas-bednar","followers_url":"https://api.github.com/users/lukas-bednar/followers","following_url":"https://api.github.com/users/lukas-bednar/following{/other_user}","gists_url":"https://api.github.com/users/lukas-bednar/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-bednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-bednar/subscriptions","organizations_url":"https://api.github.com/users/lukas-bednar/orgs","repos_url":"https://api.github.com/users/lukas-bednar/repos","events_url":"https://api.github.com/users/lukas-bednar/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-bednar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukas-bednar/kubevirt","description":"KubeVirt is a virtualization API add-on for Kubernetes.","fork":true,"url":"https://api.github.com/repos/lukas-bednar/kubevirt","forks_url":"https://api.github.com/repos/lukas-bednar/kubevirt/forks","keys_url":"https://api.github.com/repos/lukas-bednar/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukas-bednar/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukas-bednar/kubevirt/teams","hooks_url":"https://api.github.com/repos/lukas-bednar/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/lukas-bednar/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/lukas-bednar/kubevirt/events","assignees_url":"https://api.github.com/repos/lukas-bednar/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/lukas-bednar/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/lukas-bednar/kubevirt/tags","blobs_url":"https://api.github.com/repos/lukas-bednar/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukas-bednar/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukas-bednar/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukas-bednar/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukas-bednar/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/lukas-bednar/kubevirt/languages","stargazers_url":"https://api.github.com/repos/lukas-bednar/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/lukas-bednar/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/lukas-bednar/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/lukas-bednar/kubevirt/subscription","commits_url":"https://api.github.com/repos/lukas-bednar/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukas-bednar/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukas-bednar/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukas-bednar/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukas-bednar/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/lukas-bednar/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukas-bednar/kubevirt/merges","archive_url":"https://api.github.com/repos/lukas-bednar/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukas-bednar/kubevirt/downloads","issues_url":"https://api.github.com/repos/lukas-bednar/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/lukas-bednar/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/lukas-bednar/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/lukas-bednar/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukas-bednar/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/lukas-bednar/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/lukas-bednar/kubevirt/deployments","created_at":"2017-11-01T14:50:46Z","updated_at":"2017-11-01T14:50:49Z","pushed_at":"2018-05-03T09:31:39Z","git_url":"git://github.com/lukas-bednar/kubevirt.git","ssh_url":"git@github.com:lukas-bednar/kubevirt.git","clone_url":"https://github.com/lukas-bednar/kubevirt.git","svn_url":"https://github.com/lukas-bednar/kubevirt","homepage":"","size":64760,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"74fa13e6b08e126997eb3f3ee74997b702f1d1b9","user":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-05-02T21:01:40Z","pushed_at":"2018-05-03T09:32:24Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":64818,"stargazers_count":580,"watchers_count":580,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":122,"open_issues":107,"watchers":580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/931"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/931"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/931/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/931/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/b673decf89a740d7a30caacdff429278aaa593b5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rmohr"}}