{"action":"closed","issue":{"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/issues/153","repository_url":"https://api.github.com/repos/eqcorrscan/EQcorrscan","labels_url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/issues/153/comments","events_url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/issues/153/events","html_url":"https://github.com/eqcorrscan/EQcorrscan/issues/153","id":256084846,"number":153,"title":"Template_gen should be refactored to reduce overlapping code, and simplify function calls","user":{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false},"labels":[{"id":752621017,"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/labels/Cleaning","name":"Cleaning","color":"fbca04","default":false},{"id":444913764,"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/labels/docs","name":"docs","color":"5319e7","default":false},{"id":213667378,"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":256974616,"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/labels/pythonic","name":"pythonic","color":"fbca04","default":false},{"id":650130757,"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/labels/ready","name":"ready","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false},"assignees":[{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/milestones/14","html_url":"https://github.com/eqcorrscan/EQcorrscan/milestone/14","labels_url":"https://api.github.com/repos/eqcorrscan/EQcorrscan/milestones/14/labels","id":2747134,"number":14,"title":"0.3.0","description":"This release should have more efficient compiled routines for normalised cross-correlation, including frequency-domain and time-domain","creator":{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":27,"state":"open","created_at":"2017-09-06T05:17:56Z","updated_at":"2018-03-18T23:43:08Z","due_on":"2018-04-01T07:00:00Z","closed_at":null},"comments":6,"created_at":"2017-09-07T22:07:32Z","updated_at":"2018-03-18T23:43:08Z","closed_at":"2018-03-18T23:43:08Z","author_association":"OWNER","body":"Almost all functions in `eqcorrscan.core.template_gen` do essentially the same thing:\r\n- Get a catalog (either from a file, from a client, or from a object in memory);\r\n- Get a stream;\r\n- Work out what events are within the stream and trim to useful lengths;\r\n- Process stream chunks;\r\n- Generate template and return a list of templates\r\n\r\nCurrently there are seven separate functions that do essentially that and have duplicated code within each function.  This should be stream-lined to make it easier to maintain and test these functions. It might be worth implementing something similar to #139?\r\n\r\nIt is also worth noting for `from_sfile` that this won't be supported soon because sfile reading is now in ObsPy (for version 1.1.0, not yet released), and some fixes have been made upstream to ObsPy that have not been made here.\r\n\r\nI'm really looking forward to removing `utils.sfile_utils` at some point too..."}}
{"actor":{"display_login":"calum-chamberlain"}}