{"comment":{"url":"https://api.github.com/repos/OpenPLi/openpli-oe-core/comments/27500603","html_url":"https://github.com/OpenPLi/openpli-oe-core/commit/8aec0666281cadb6e33d4cf988520bec58c030fb#commitcomment-27500603","id":27500603,"user":{"login":"fairbird","id":1761779,"avatar_url":"https://avatars1.githubusercontent.com/u/1761779?v=4","gravatar_id":"","url":"https://api.github.com/users/fairbird","html_url":"https://github.com/fairbird","followers_url":"https://api.github.com/users/fairbird/followers","following_url":"https://api.github.com/users/fairbird/following{/other_user}","gists_url":"https://api.github.com/users/fairbird/gists{/gist_id}","starred_url":"https://api.github.com/users/fairbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairbird/subscriptions","organizations_url":"https://api.github.com/users/fairbird/orgs","repos_url":"https://api.github.com/users/fairbird/repos","events_url":"https://api.github.com/users/fairbird/events{/privacy}","received_events_url":"https://api.github.com/users/fairbird/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"8aec0666281cadb6e33d4cf988520bec58c030fb","created_at":"2018-02-12T08:24:16Z","updated_at":"2018-02-12T08:24:16Z","author_association":"CONTRIBUTOR","body":"I'm sorry ..\r\nNo I see different version of samba and I have fixed issue to edit patch like this..\r\n\r\n> @@ -55,13 +55,16 @@ def configure(conf):\r\n         maxversion = \"1.1.99\"\r\n         version_blacklist = [\"1.1.30\", \"1.1.31\"]\r\n \r\n-        if conf.CHECK_BUNDLED_SYSTEM_PKG('pyldb-util',\r\n-                                     minversion=VERSION,\r\n-                                     maxversion=maxversion,\r\n-                                     version_blacklist=version_blacklist,\r\n+        if conf.env.disable_python:\r\n+            if conf.CHECK_BUNDLED_SYSTEM_PKG('ldb', minversion=VERSION,\r\n+                                         onlyif='talloc tdb tevent',\r\n+                                         implied_deps='replace talloc tdb tevent'):\r\n+                conf.define('USING_SYSTEM_LDB', 1)\r\n+        else:\r\n+            if conf.CHECK_BUNDLED_SYSTEM_PKG('pyldb-util', minversion=VERSION,\r\n                                      onlyif='talloc tdb tevent',\r\n                                      implied_deps='replace talloc tdb tevent ldb'):\r\n-            conf.define('USING_SYSTEM_PYLDB_UTIL', 1)\r\n+                conf.define('USING_SYSTEM_PYLDB_UTIL', 1)\r\n             if conf.CHECK_BUNDLED_SYSTEM_PKG('ldb',\r\n                                          minversion=VERSION,\r\n                                          maxversion=maxversion,"}}
{"actor":{"display_login":"fairbird"}}