{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/force/pulls/comments/227168693","pull_request_review_id":167146628,"id":227168693,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE2ODY5Mw==","diff_hunk":"@@ -0,0 +1,138 @@\n+// Forked and modified from UXM: https://github.com/treosh/uxm\n+\n+declare let PerformancePaintTiming: any\n+\n+const perf = typeof window !== \"undefined\" ? window.performance : null\n+\n+const sanitizedMetrics = (start, end) =>\n+  start > 0 && end > 0 && end - start > 0 ? end - start : null\n+\n+// user timing helpers\n+\n+export function mark(markName) {\n+  if (perf && perf.mark) {\n+    perf.mark(markName)\n+  }\n+}\n+\n+export function measure(measureName, startMarkName) {\n+  if (perf && perf.measure) {\n+    try {\n+      perf.measure(measureName, startMarkName)\n+    } catch (err) {","path":"src/lib/user-performance-metrics.ts","position":50,"original_position":22,"commit_id":"63be366fb5e0a12284befdd05d2ed34999063a17","original_commit_id":"21838bf350797071380a946afe0cda77eafaad6a","user":{"login":"zephraph","id":3087225,"node_id":"MDQ6VXNlcjMwODcyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3087225?v=4","gravatar_id":"","url":"https://api.github.com/users/zephraph","html_url":"https://github.com/zephraph","followers_url":"https://api.github.com/users/zephraph/followers","following_url":"https://api.github.com/users/zephraph/following{/other_user}","gists_url":"https://api.github.com/users/zephraph/gists{/gist_id}","starred_url":"https://api.github.com/users/zephraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephraph/subscriptions","organizations_url":"https://api.github.com/users/zephraph/orgs","repos_url":"https://api.github.com/users/zephraph/repos","events_url":"https://api.github.com/users/zephraph/events{/privacy}","received_events_url":"https://api.github.com/users/zephraph/received_events","type":"User","site_admin":false},"body":"Yeah, I can add some comments here. If the markNames specified don't exist (i.e. the mark hasn't been created) then it'll throw an exception. ","created_at":"2018-10-22T23:08:37Z","updated_at":"2018-10-22T23:08:37Z","html_url":"https://github.com/artsy/force/pull/3015#discussion_r227168693","pull_request_url":"https://api.github.com/repos/artsy/force/pulls/3015","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/comments/227168693"},"html":{"href":"https://github.com/artsy/force/pull/3015#discussion_r227168693"},"pull_request":{"href":"https://api.github.com/repos/artsy/force/pulls/3015"}},"in_reply_to_id":227086387},"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/3015","id":224764285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzY0Mjg1","html_url":"https://github.com/artsy/force/pull/3015","diff_url":"https://github.com/artsy/force/pull/3015.diff","patch_url":"https://github.com/artsy/force/pull/3015.patch","issue_url":"https://api.github.com/repos/artsy/force/issues/3015","number":3015,"state":"open","locked":false,"title":"Add first paint, first contentful paint metrics","user":{"login":"zephraph","id":3087225,"node_id":"MDQ6VXNlcjMwODcyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3087225?v=4","gravatar_id":"","url":"https://api.github.com/users/zephraph","html_url":"https://github.com/zephraph","followers_url":"https://api.github.com/users/zephraph/followers","following_url":"https://api.github.com/users/zephraph/following{/other_user}","gists_url":"https://api.github.com/users/zephraph/gists{/gist_id}","starred_url":"https://api.github.com/users/zephraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephraph/subscriptions","organizations_url":"https://api.github.com/users/zephraph/orgs","repos_url":"https://api.github.com/users/zephraph/repos","events_url":"https://api.github.com/users/zephraph/events{/privacy}","received_events_url":"https://api.github.com/users/zephraph/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\n- Add separate user performance timing api\r\n- Simplify volley api to reduce duplicate logic\r\n\r\n## Todo\r\n\r\n- [x] Update volley test to support new api\r\n- [x] Fix ignored ts errors\r\n- [x] Add comments","created_at":"2018-10-22T18:08:22Z","updated_at":"2018-10-22T23:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29392c9fd7b36ef22d61190d5b24018ef442cca8","assignee":{"login":"alloy","id":2320,"node_id":"MDQ6VXNlcjIzMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"node_id":"MDQ6VXNlcjIzMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"joeyAghion","id":28120,"node_id":"MDQ6VXNlcjI4MTIw","avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/force/pulls/3015/commits","review_comments_url":"https://api.github.com/repos/artsy/force/pulls/3015/comments","review_comment_url":"https://api.github.com/repos/artsy/force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/force/issues/3015/comments","statuses_url":"https://api.github.com/repos/artsy/force/statuses/63be366fb5e0a12284befdd05d2ed34999063a17","head":{"label":"artsy:performance-metrics","ref":"performance-metrics","sha":"63be366fb5e0a12284befdd05d2ed34999063a17","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzQwNA==","name":"force","full_name":"artsy/force","private":false,"owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-10-22T22:32:17Z","pushed_at":"2018-10-22T23:07:14Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":131158,"stargazers_count":253,"watchers_count":253,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":89,"open_issues":45,"watchers":253,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"1b31d202be6e271c234b06b989ec559dabdf6f16","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzQwNA==","name":"force","full_name":"artsy/force","private":false,"owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-10-22T22:32:17Z","pushed_at":"2018-10-22T23:07:14Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":131158,"stargazers_count":253,"watchers_count":253,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":89,"open_issues":45,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/3015"},"html":{"href":"https://github.com/artsy/force/pull/3015"},"issue":{"href":"https://api.github.com/repos/artsy/force/issues/3015"},"comments":{"href":"https://api.github.com/repos/artsy/force/issues/3015/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/force/pulls/3015/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/force/pulls/3015/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/force/statuses/63be366fb5e0a12284befdd05d2ed34999063a17"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zephraph"}}