{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/178193775","pull_request_review_id":108216727,"id":178193775,"diff_hunk":"@@ -416,6 +417,53 @@ var _ = SIGDescribe(\"Loadbalancing: L7\", func() {\n \t\t\tif pollErr != nil {\n \t\t\t\tframework.ExpectNoError(fmt.Errorf(\"Timed out waiting for ingress %s to get %s annotation\", name, instanceGroupAnnotation))\n \t\t\t}\n+\n+\t\t\t// Verify that the ingress does not get other annotations like url-map, target-proxy, backends, etc.\n+\t\t\t// Note: All resources except the firewall rule have an annotation.\n+\t\t\tumKey := fmt.Sprintf(\"%v/url-map\", statusPrefix)\n+\t\t\tfwKey := fmt.Sprintf(\"%v/forwarding-rule\", statusPrefix)\n+\t\t\ttpKey := fmt.Sprintf(\"%v/target-proxy\", statusPrefix)\n+\t\t\tfwsKey := fmt.Sprintf(\"%v/https-forwarding-rule\", statusPrefix)\n+\t\t\ttpsKey := fmt.Sprintf(\"%v/https-target-proxy\", statusPrefix)\n+\t\t\tscKey := fmt.Sprintf(\"%v/ssl-cert\", statusPrefix)\n+\t\t\tbeKey := fmt.Sprintf(\"%v/backends\", statusPrefix)","path":"test/e2e/network/ingress.go","position":30,"original_position":30,"commit_id":"5d00535433ab4a84c5f876a4eda8fea73cfc98b4","original_commit_id":"5d00535433ab4a84c5f876a4eda8fea73cfc98b4","user":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"body":"Maybe define these in ingress_utils.go as well?","created_at":"2018-03-29T22:04:27Z","updated_at":"2018-03-29T22:04:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/61909#discussion_r178193775","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/178193775"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61909#discussion_r178193775"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909","id":178419880,"html_url":"https://github.com/kubernetes/kubernetes/pull/61909","diff_url":"https://github.com/kubernetes/kubernetes/pull/61909.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61909.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909","number":61909,"state":"open","locked":false,"title":"Updating multicluster e2e test to ensure that controller only creates instance groups","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"Ref https://github.com/kubernetes/ingress-gce/issues/182\r\n\r\nUpdating the multicluster ingress e2e test to also verify that the controller does not create any other resource than instance group.\r\n\r\nI was planning to do that using annotations first, but turns out that we have the right check for annotations: https://github.com/kubernetes/ingress-gce/blob/61d574a2c74fbb6f47e1aec0fae385cf2ca97aaf/pkg/controller/controller.go#L317 :)\r\n\r\nAm using `length(ListResource) == 0` now but have still kept the annotation check.\r\n\r\ncc @nicksardo @MrHohn @G-Harmon\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-03-29T19:28:36Z","updated_at":"2018-03-29T22:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c26eef7cec0d9f14058428934b246eec8c22198","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danwinship","id":96040,"avatar_url":"https://avatars0.githubusercontent.com/u/96040?v=4","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5d00535433ab4a84c5f876a4eda8fea73cfc98b4","head":{"label":"nikhiljindal:testMCI","ref":"testMCI","sha":"5d00535433ab4a84c5f876a4eda8fea73cfc98b4","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"repo":{"id":29988055,"name":"kubernetes","full_name":"nikhiljindal/kubernetes","owner":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhiljindal/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/nikhiljindal/kubernetes","forks_url":"https://api.github.com/repos/nikhiljindal/kubernetes/forks","keys_url":"https://api.github.com/repos/nikhiljindal/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhiljindal/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhiljindal/kubernetes/teams","hooks_url":"https://api.github.com/repos/nikhiljindal/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nikhiljindal/kubernetes/events","assignees_url":"https://api.github.com/repos/nikhiljindal/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nikhiljindal/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nikhiljindal/kubernetes/tags","blobs_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhiljindal/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhiljindal/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nikhiljindal/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nikhiljindal/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nikhiljindal/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nikhiljindal/kubernetes/subscription","commits_url":"https://api.github.com/repos/nikhiljindal/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhiljindal/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhiljindal/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nikhiljindal/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhiljindal/kubernetes/merges","archive_url":"https://api.github.com/repos/nikhiljindal/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhiljindal/kubernetes/downloads","issues_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nikhiljindal/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhiljindal/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhiljindal/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhiljindal/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nikhiljindal/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/nikhiljindal/kubernetes/deployments","created_at":"2015-01-28T21:01:50Z","updated_at":"2015-01-28T21:01:53Z","pushed_at":"2018-03-29T20:59:13Z","git_url":"git://github.com/nikhiljindal/kubernetes.git","ssh_url":"git@github.com:nikhiljindal/kubernetes.git","clone_url":"https://github.com/nikhiljindal/kubernetes.git","svn_url":"https://github.com/nikhiljindal/kubernetes","homepage":"http://kubernetes.io","size":536214,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"cad4385cb07c470833953fbb117a29a584a33762","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-29T22:00:14Z","pushed_at":"2018-03-29T22:03:16Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":767575,"stargazers_count":34419,"watchers_count":34419,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12187,"mirror_url":null,"archived":false,"open_issues_count":3507,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12187,"open_issues":3507,"watchers":34419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61909"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5d00535433ab4a84c5f876a4eda8fea73cfc98b4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MrHohn"}}