{"action":"created","comment":{"url":"https://api.github.com/repos/samvera/hyrax/pulls/comments/168911972","pull_request_review_id":97364830,"id":168911972,"diff_hunk":"@@ -6,7 +6,7 @@\n       Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC =>\n         \"<span class=\\\"label label-success\\\">Public</span>\",\n       Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED =>\n-        \"<span class=\\\"label label-info\\\">%s</span>\",\n+        \"<span class=\\\"label label-info\\\">%<name>s</span>\",","path":"spec/helpers/hyrax/ability_helper_spec.rb","position":5,"original_position":5,"commit_id":"9f1c1470dd6f5fc4927d32117673599a2091fcde","original_commit_id":"ca6dabf2f5370706ec92957251e63b83a0b49603","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars2.githubusercontent.com/u/92044?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"Okay, looks good. ","created_at":"2018-02-17T04:23:25Z","updated_at":"2018-02-17T04:23:26Z","html_url":"https://github.com/samvera/hyrax/pull/2655#discussion_r168911972","pull_request_url":"https://api.github.com/repos/samvera/hyrax/pulls/2655","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/comments/168911972"},"html":{"href":"https://github.com/samvera/hyrax/pull/2655#discussion_r168911972"},"pull_request":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/2655"}},"in_reply_to_id":168789282},"pull_request":{"url":"https://api.github.com/repos/samvera/hyrax/pulls/2655","id":169645881,"html_url":"https://github.com/samvera/hyrax/pull/2655","diff_url":"https://github.com/samvera/hyrax/pull/2655.diff","patch_url":"https://github.com/samvera/hyrax/pull/2655.patch","issue_url":"https://api.github.com/repos/samvera/hyrax/issues/2655","number":2655,"state":"open","locked":false,"title":"Update RuboCop support; use Bixby style guide","user":{"login":"no-reply","id":1361776,"avatar_url":"https://avatars2.githubusercontent.com/u/1361776?v=4","gravatar_id":"","url":"https://api.github.com/users/no-reply","html_url":"https://github.com/no-reply","followers_url":"https://api.github.com/users/no-reply/followers","following_url":"https://api.github.com/users/no-reply/following{/other_user}","gists_url":"https://api.github.com/users/no-reply/gists{/gist_id}","starred_url":"https://api.github.com/users/no-reply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-reply/subscriptions","organizations_url":"https://api.github.com/users/no-reply/orgs","repos_url":"https://api.github.com/users/no-reply/repos","events_url":"https://api.github.com/users/no-reply/events{/privacy}","received_events_url":"https://api.github.com/users/no-reply/received_events","type":"User","site_admin":false},"body":"Bixby is a RuboCop style guide that decouples (to the degree possible) RuboCop\r\nsoftware updates from unrelated style guide updates. Bixby disables all rules by\r\ndefault, and re-enables rules that are adopted in the community in general.\r\n\r\nBixby's promise is to avoid adding rules without bumping major\r\nversion. Pinning to the current v1.0.0 will allow us to update software versions\r\nwith reduced changes (ideally none) to code style. Enforcement of existing rules\r\nmay still change to become more strict based on updates to rule enforcement\r\ncode.\r\n\r\nSeveral rule exceptions and other configurations that I could identify as being\r\ninherited from Bixby are removed from the local `.rubocop.yml`.\r\n\r\nCloses #2568.\r\n\r\nChanges proposed in this pull request:\r\n* Update RuboCop dependency to Bixby\r\n* Fix style violations to align with current style guide\r\n\r\n@samvera/hyrax-code-reviewers\r\n","created_at":"2018-02-16T15:03:18Z","updated_at":"2018-02-17T04:23:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1af2c64176ada23982c1e9efb5266c8cc0ba6ead","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":503705298,"url":"https://api.github.com/repos/samvera/hyrax/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/samvera/hyrax/pulls/2655/commits","review_comments_url":"https://api.github.com/repos/samvera/hyrax/pulls/2655/comments","review_comment_url":"https://api.github.com/repos/samvera/hyrax/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samvera/hyrax/issues/2655/comments","statuses_url":"https://api.github.com/repos/samvera/hyrax/statuses/9f1c1470dd6f5fc4927d32117673599a2091fcde","head":{"label":"samvera:rubocop","ref":"rubocop","sha":"9f1c1470dd6f5fc4927d32117673599a2091fcde","user":{"login":"samvera","id":109426,"avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"repo":{"id":75130658,"name":"hyrax","full_name":"samvera/hyrax","owner":{"login":"samvera","id":109426,"avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samvera/hyrax","description":"Hyrax is a front-end based on the robust Samvera framework, providing a user interface for common repository features","fork":false,"url":"https://api.github.com/repos/samvera/hyrax","forks_url":"https://api.github.com/repos/samvera/hyrax/forks","keys_url":"https://api.github.com/repos/samvera/hyrax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samvera/hyrax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samvera/hyrax/teams","hooks_url":"https://api.github.com/repos/samvera/hyrax/hooks","issue_events_url":"https://api.github.com/repos/samvera/hyrax/issues/events{/number}","events_url":"https://api.github.com/repos/samvera/hyrax/events","assignees_url":"https://api.github.com/repos/samvera/hyrax/assignees{/user}","branches_url":"https://api.github.com/repos/samvera/hyrax/branches{/branch}","tags_url":"https://api.github.com/repos/samvera/hyrax/tags","blobs_url":"https://api.github.com/repos/samvera/hyrax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samvera/hyrax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samvera/hyrax/git/refs{/sha}","trees_url":"https://api.github.com/repos/samvera/hyrax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samvera/hyrax/statuses/{sha}","languages_url":"https://api.github.com/repos/samvera/hyrax/languages","stargazers_url":"https://api.github.com/repos/samvera/hyrax/stargazers","contributors_url":"https://api.github.com/repos/samvera/hyrax/contributors","subscribers_url":"https://api.github.com/repos/samvera/hyrax/subscribers","subscription_url":"https://api.github.com/repos/samvera/hyrax/subscription","commits_url":"https://api.github.com/repos/samvera/hyrax/commits{/sha}","git_commits_url":"https://api.github.com/repos/samvera/hyrax/git/commits{/sha}","comments_url":"https://api.github.com/repos/samvera/hyrax/comments{/number}","issue_comment_url":"https://api.github.com/repos/samvera/hyrax/issues/comments{/number}","contents_url":"https://api.github.com/repos/samvera/hyrax/contents/{+path}","compare_url":"https://api.github.com/repos/samvera/hyrax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samvera/hyrax/merges","archive_url":"https://api.github.com/repos/samvera/hyrax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samvera/hyrax/downloads","issues_url":"https://api.github.com/repos/samvera/hyrax/issues{/number}","pulls_url":"https://api.github.com/repos/samvera/hyrax/pulls{/number}","milestones_url":"https://api.github.com/repos/samvera/hyrax/milestones{/number}","notifications_url":"https://api.github.com/repos/samvera/hyrax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samvera/hyrax/labels{/name}","releases_url":"https://api.github.com/repos/samvera/hyrax/releases{/id}","deployments_url":"https://api.github.com/repos/samvera/hyrax/deployments","created_at":"2016-11-29T23:09:59Z","updated_at":"2018-02-10T01:44:40Z","pushed_at":"2018-02-17T03:50:13Z","git_url":"git://github.com/samvera/hyrax.git","ssh_url":"git@github.com:samvera/hyrax.git","clone_url":"https://github.com/samvera/hyrax.git","svn_url":"https://github.com/samvera/hyrax","homepage":"http://hyr.ax/","size":66297,"stargazers_count":66,"watchers_count":66,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":57,"open_issues":511,"watchers":66,"default_branch":"master"}},"base":{"label":"samvera:master","ref":"master","sha":"931dd36ededde9a7d73e500cd8056eb53edbf92b","user":{"login":"samvera","id":109426,"avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"repo":{"id":75130658,"name":"hyrax","full_name":"samvera/hyrax","owner":{"login":"samvera","id":109426,"avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samvera/hyrax","description":"Hyrax is a front-end based on the robust Samvera framework, providing a user interface for common repository features","fork":false,"url":"https://api.github.com/repos/samvera/hyrax","forks_url":"https://api.github.com/repos/samvera/hyrax/forks","keys_url":"https://api.github.com/repos/samvera/hyrax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samvera/hyrax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samvera/hyrax/teams","hooks_url":"https://api.github.com/repos/samvera/hyrax/hooks","issue_events_url":"https://api.github.com/repos/samvera/hyrax/issues/events{/number}","events_url":"https://api.github.com/repos/samvera/hyrax/events","assignees_url":"https://api.github.com/repos/samvera/hyrax/assignees{/user}","branches_url":"https://api.github.com/repos/samvera/hyrax/branches{/branch}","tags_url":"https://api.github.com/repos/samvera/hyrax/tags","blobs_url":"https://api.github.com/repos/samvera/hyrax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samvera/hyrax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samvera/hyrax/git/refs{/sha}","trees_url":"https://api.github.com/repos/samvera/hyrax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samvera/hyrax/statuses/{sha}","languages_url":"https://api.github.com/repos/samvera/hyrax/languages","stargazers_url":"https://api.github.com/repos/samvera/hyrax/stargazers","contributors_url":"https://api.github.com/repos/samvera/hyrax/contributors","subscribers_url":"https://api.github.com/repos/samvera/hyrax/subscribers","subscription_url":"https://api.github.com/repos/samvera/hyrax/subscription","commits_url":"https://api.github.com/repos/samvera/hyrax/commits{/sha}","git_commits_url":"https://api.github.com/repos/samvera/hyrax/git/commits{/sha}","comments_url":"https://api.github.com/repos/samvera/hyrax/comments{/number}","issue_comment_url":"https://api.github.com/repos/samvera/hyrax/issues/comments{/number}","contents_url":"https://api.github.com/repos/samvera/hyrax/contents/{+path}","compare_url":"https://api.github.com/repos/samvera/hyrax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samvera/hyrax/merges","archive_url":"https://api.github.com/repos/samvera/hyrax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samvera/hyrax/downloads","issues_url":"https://api.github.com/repos/samvera/hyrax/issues{/number}","pulls_url":"https://api.github.com/repos/samvera/hyrax/pulls{/number}","milestones_url":"https://api.github.com/repos/samvera/hyrax/milestones{/number}","notifications_url":"https://api.github.com/repos/samvera/hyrax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samvera/hyrax/labels{/name}","releases_url":"https://api.github.com/repos/samvera/hyrax/releases{/id}","deployments_url":"https://api.github.com/repos/samvera/hyrax/deployments","created_at":"2016-11-29T23:09:59Z","updated_at":"2018-02-10T01:44:40Z","pushed_at":"2018-02-17T03:50:13Z","git_url":"git://github.com/samvera/hyrax.git","ssh_url":"git@github.com:samvera/hyrax.git","clone_url":"https://github.com/samvera/hyrax.git","svn_url":"https://github.com/samvera/hyrax","homepage":"http://hyr.ax/","size":66297,"stargazers_count":66,"watchers_count":66,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":57,"open_issues":511,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/2655"},"html":{"href":"https://github.com/samvera/hyrax/pull/2655"},"issue":{"href":"https://api.github.com/repos/samvera/hyrax/issues/2655"},"comments":{"href":"https://api.github.com/repos/samvera/hyrax/issues/2655/comments"},"review_comments":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/2655/comments"},"review_comment":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/2655/commits"},"statuses":{"href":"https://api.github.com/repos/samvera/hyrax/statuses/9f1c1470dd6f5fc4927d32117673599a2091fcde"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jcoyne"}}