{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/6537","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/6537/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/6537/comments","events_url":"https://api.github.com/repos/python/cpython/issues/6537/events","html_url":"https://github.com/python/cpython/pull/6537","id":315932053,"number":6537,"title":"bpo-33312: Fix clang ubsan out of bounds warnings in dict.","user":{"login":"gpshead","id":68491,"avatar_url":"https://avatars2.githubusercontent.com/u/68491?v=4","gravatar_id":"","url":"https://api.github.com/users/gpshead","html_url":"https://github.com/gpshead","followers_url":"https://api.github.com/users/gpshead/followers","following_url":"https://api.github.com/users/gpshead/following{/other_user}","gists_url":"https://api.github.com/users/gpshead/gists{/gist_id}","starred_url":"https://api.github.com/users/gpshead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpshead/subscriptions","organizations_url":"https://api.github.com/users/gpshead/orgs","repos_url":"https://api.github.com/users/gpshead/repos","events_url":"https://api.github.com/users/gpshead/events{/privacy}","received_events_url":"https://api.github.com/users/gpshead/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":536871770,"url":"https://api.github.com/repos/python/cpython/labels/type-bugfix","name":"type-bugfix","color":"e99695","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-19T15:37:23Z","updated_at":"2018-04-20T05:43:28Z","closed_at":"2018-04-20T05:41:20Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/6537","html_url":"https://github.com/python/cpython/pull/6537","diff_url":"https://github.com/python/cpython/pull/6537.diff","patch_url":"https://github.com/python/cpython/pull/6537.patch"},"body":"Fix clang ubsan (undefined behavior sanitizer) warnings in dictobject.c by\r\nadjusting how the internal struct _dictkeysobject shared keys structure is\r\ndeclared.\r\n\r\nThis remains ABI compatible.  We get rid of the union at the end of the\r\nstruct being used for conveinence to avoid typecasting in favor of a\r\nsimple appropriate minimum size int64_t[1] as [1] length arrays at the\r\nend of a struct are known to clang to be used for variable sized objects.\r\n\r\nA variable length array (VLA) would be more proper and simplify the\r\ndictobject.c code further by not having to subtract the size of the struct\r\nmemeber in the three places it does size calculations, but PEP-007 does not\r\nallow those in CPython's coding standard today.\n\n<!-- issue-number: bpo-33312 -->\nhttps://bugs.python.org/issue33312\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/382984279","html_url":"https://github.com/python/cpython/pull/6537#issuecomment-382984279","issue_url":"https://api.github.com/repos/python/cpython/issues/6537","id":382984279,"user":{"login":"bedevere-bot","id":28579281,"avatar_url":"https://avatars0.githubusercontent.com/u/28579281?v=4","gravatar_id":"","url":"https://api.github.com/users/bedevere-bot","html_url":"https://github.com/bedevere-bot","followers_url":"https://api.github.com/users/bedevere-bot/followers","following_url":"https://api.github.com/users/bedevere-bot/following{/other_user}","gists_url":"https://api.github.com/users/bedevere-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/bedevere-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedevere-bot/subscriptions","organizations_url":"https://api.github.com/users/bedevere-bot/orgs","repos_url":"https://api.github.com/users/bedevere-bot/repos","events_url":"https://api.github.com/users/bedevere-bot/events{/privacy}","received_events_url":"https://api.github.com/users/bedevere-bot/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T05:43:28Z","updated_at":"2018-04-20T05:43:28Z","author_association":"NONE","body":"[GH-6544](https://github.com/python/cpython/pull/6544) is a backport of this pull request to the [3.6 branch](https://github.com/python/cpython/tree/3.6)."}}
{"actor":{"display_login":"bedevere-bot"}}