{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/214479500","pull_request_review_id":151553961,"id":214479500,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ3OTUwMA==","diff_hunk":"@@ -1770,6 +1770,10 @@\n             <groupId>org.apache.hive</groupId>\n             <artifactId>hive-storage-api</artifactId>\n           </exclusion>\n+          <exclusion>\n+            <groupId> com.esotericsoftware</groupId>\n+            <artifactId>kryo-shaded</artifactId>","path":"pom.xml","position":15,"original_position":15,"commit_id":"8c28e078526445a31099ca5f1ae71ce76d782004","original_commit_id":"8c28e078526445a31099ca5f1ae71ce76d782004","user":{"login":"dongjoon-hyun","id":9700541,"node_id":"MDQ6VXNlcjk3MDA1NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9700541?v=4","gravatar_id":"","url":"https://api.github.com/users/dongjoon-hyun","html_url":"https://github.com/dongjoon-hyun","followers_url":"https://api.github.com/users/dongjoon-hyun/followers","following_url":"https://api.github.com/users/dongjoon-hyun/following{/other_user}","gists_url":"https://api.github.com/users/dongjoon-hyun/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjoon-hyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjoon-hyun/subscriptions","organizations_url":"https://api.github.com/users/dongjoon-hyun/orgs","repos_url":"https://api.github.com/users/dongjoon-hyun/repos","events_url":"https://api.github.com/users/dongjoon-hyun/events{/privacy}","received_events_url":"https://api.github.com/users/dongjoon-hyun/received_events","type":"User","site_admin":false},"body":"@srowen  In short, the current Spark always uses the same Kryo version for read/write `SearchArgument` and it's used only on runtime.\r\n\r\n1. Old OrcFileFormat always uses `org.spark-project.hive:hive-exec:1.2.1.spark2` which uses the shaded one in `hive-exec`.\r\n    - `com.esotericsoftware.kryo:kryo:2.21`. \r\n\r\n2. New OrcFileFormat uses `org.apache.orc` which uses the one provided by Spark.\r\n    - `com.esotericsoftware:kryo-shaded:3.0.3`  (All Spark/Orc/Hive uses this version for now)\r\n\r\n3. New OrcFileFormat (in this PR) uses `org.apache.orc` which uses the one provided by Spark.\r\n    - `com.esotericsoftware:kryo-shaded:4.0.2`\r\n\r\nSo, (1) is unchanged by this PR. (2) and (3) also doesn't use a mixed version of Kryo. So, it should be fine because Apache Spark doesn't allow a mixed Spark version(master and executor). BTW, during investigation, there was some performance issue in `createFilter`. I'll file a new JIRA for that.","created_at":"2018-08-31T21:29:31Z","updated_at":"2018-08-31T21:29:31Z","html_url":"https://github.com/apache/spark/pull/22179#discussion_r214479500","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/214479500"},"html":{"href":"https://github.com/apache/spark/pull/22179#discussion_r214479500"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22179"}},"in_reply_to_id":214117831},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22179","id":210000090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDAwMDkw","html_url":"https://github.com/apache/spark/pull/22179","diff_url":"https://github.com/apache/spark/pull/22179.diff","patch_url":"https://github.com/apache/spark/pull/22179.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22179","number":22179,"state":"open","locked":false,"title":"[SPARK-23131][BUILD] Upgrade Kryo to 4.0.2","user":{"login":"wangyum","id":5399861,"node_id":"MDQ6VXNlcjUzOTk4NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5399861?v=4","gravatar_id":"","url":"https://api.github.com/users/wangyum","html_url":"https://github.com/wangyum","followers_url":"https://api.github.com/users/wangyum/followers","following_url":"https://api.github.com/users/wangyum/following{/other_user}","gists_url":"https://api.github.com/users/wangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/wangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangyum/subscriptions","organizations_url":"https://api.github.com/users/wangyum/orgs","repos_url":"https://api.github.com/users/wangyum/repos","events_url":"https://api.github.com/users/wangyum/events{/privacy}","received_events_url":"https://api.github.com/users/wangyum/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nUpgrade chill to 0.9.3, Kryo to 4.0.2, to get bug fixes and improvements.\r\nMore details:\r\nhttps://github.com/twitter/chill/releases/tag/v0.9.3\r\nhttps://github.com/twitter/chill/commit/cc3910d501a844f3c882249fef8fc2560b95b6dd\r\n\r\nRelated tickets:\r\n[SPARK-20389](https://issues.apache.org/jira/browse/SPARK-20389) [SPARK-23131](https://issues.apache.org/jira/browse/SPARK-23131)  [SPARK-25176](https://issues.apache.org/jira/browse/SPARK-25176)\r\n## How was this patch tested?\r\n\r\nExisting tests.\r\n","created_at":"2018-08-22T01:48:11Z","updated_at":"2018-08-31T21:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ffaefc9e0f96159c2890d57210833ed72b5ca24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22179/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22179/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22179/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8c28e078526445a31099ca5f1ae71ce76d782004","head":{"label":"wangyum:SPARK-23131","ref":"SPARK-23131","sha":"8c28e078526445a31099ca5f1ae71ce76d782004","user":{"login":"wangyum","id":5399861,"node_id":"MDQ6VXNlcjUzOTk4NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5399861?v=4","gravatar_id":"","url":"https://api.github.com/users/wangyum","html_url":"https://github.com/wangyum","followers_url":"https://api.github.com/users/wangyum/followers","following_url":"https://api.github.com/users/wangyum/following{/other_user}","gists_url":"https://api.github.com/users/wangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/wangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangyum/subscriptions","organizations_url":"https://api.github.com/users/wangyum/orgs","repos_url":"https://api.github.com/users/wangyum/repos","events_url":"https://api.github.com/users/wangyum/events{/privacy}","received_events_url":"https://api.github.com/users/wangyum/received_events","type":"User","site_admin":false},"repo":{"id":75173456,"node_id":"MDEwOlJlcG9zaXRvcnk3NTE3MzQ1Ng==","name":"spark","full_name":"wangyum/spark","owner":{"login":"wangyum","id":5399861,"node_id":"MDQ6VXNlcjUzOTk4NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5399861?v=4","gravatar_id":"","url":"https://api.github.com/users/wangyum","html_url":"https://github.com/wangyum","followers_url":"https://api.github.com/users/wangyum/followers","following_url":"https://api.github.com/users/wangyum/following{/other_user}","gists_url":"https://api.github.com/users/wangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/wangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangyum/subscriptions","organizations_url":"https://api.github.com/users/wangyum/orgs","repos_url":"https://api.github.com/users/wangyum/repos","events_url":"https://api.github.com/users/wangyum/events{/privacy}","received_events_url":"https://api.github.com/users/wangyum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wangyum/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wangyum/spark","forks_url":"https://api.github.com/repos/wangyum/spark/forks","keys_url":"https://api.github.com/repos/wangyum/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangyum/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangyum/spark/teams","hooks_url":"https://api.github.com/repos/wangyum/spark/hooks","issue_events_url":"https://api.github.com/repos/wangyum/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wangyum/spark/events","assignees_url":"https://api.github.com/repos/wangyum/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wangyum/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wangyum/spark/tags","blobs_url":"https://api.github.com/repos/wangyum/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangyum/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangyum/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangyum/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangyum/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wangyum/spark/languages","stargazers_url":"https://api.github.com/repos/wangyum/spark/stargazers","contributors_url":"https://api.github.com/repos/wangyum/spark/contributors","subscribers_url":"https://api.github.com/repos/wangyum/spark/subscribers","subscription_url":"https://api.github.com/repos/wangyum/spark/subscription","commits_url":"https://api.github.com/repos/wangyum/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangyum/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangyum/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangyum/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wangyum/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wangyum/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangyum/spark/merges","archive_url":"https://api.github.com/repos/wangyum/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangyum/spark/downloads","issues_url":"https://api.github.com/repos/wangyum/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wangyum/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wangyum/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wangyum/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangyum/spark/labels{/name}","releases_url":"https://api.github.com/repos/wangyum/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wangyum/spark/deployments","created_at":"2016-11-30T09:49:08Z","updated_at":"2018-08-29T05:53:28Z","pushed_at":"2018-08-31T16:05:14Z","git_url":"git://github.com/wangyum/spark.git","ssh_url":"git@github.com:wangyum/spark.git","clone_url":"https://github.com/wangyum/spark.git","svn_url":"https://github.com/wangyum/spark","homepage":null,"size":279285,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a998e9d829bd499dd7c65f973ea4389e0401b001","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-31T17:47:40Z","pushed_at":"2018-08-31T21:19:22Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":280551,"stargazers_count":18596,"watchers_count":18596,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16797,"mirror_url":null,"archived":false,"open_issues_count":503,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16797,"open_issues":503,"watchers":18596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22179"},"html":{"href":"https://github.com/apache/spark/pull/22179"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22179"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22179/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22179/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22179/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8c28e078526445a31099ca5f1ae71ce76d782004"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dongjoon-hyun"}}