{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/216136719","pull_request_review_id":153560639,"id":216136719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEzNjcxOQ==","diff_hunk":"@@ -0,0 +1,43 @@\n+/* roboto-regular - latin */\n+@font-face {\n+  font-family: 'Roboto';\n+  font-style: normal;\n+  font-weight: 400;\n+  src: url('../fonts/roboto/roboto-v18-latin-regular.woff2') format('woff2'),\n+  url('../fonts/roboto/roboto-v18-latin-regular.woff') format('woff'),\n+  url('../fonts/roboto/roboto-v18-latin-regular.ttf') format('truetype'), /* Safari, Android, iOS */\n+  url('../fonts/roboto/roboto-v18-latin-regular.svg#Roboto') format('svg'); /* Legacy iOS */\n+}\n+\n+/* roboto-italic - latin */\n+@font-face {\n+  font-family: 'Roboto';\n+  font-style: italic;\n+  font-weight: 400;\n+  src: url('../fonts/roboto/roboto-v18-latin-italic.woff2') format('woff2'),\n+  url('../fonts/roboto/roboto-v18-latin-italic.woff') format('woff'),\n+  url('../fonts/roboto/roboto-v18-latin-italic.ttf') format('truetype'), /* Safari, Android, iOS */","path":"administrator/templates/atum/scss/fonts/roboto/_fontstyle.scss","position":19,"original_position":19,"commit_id":"2d2e78ecc76bc40d8356c4c0377e573cea9dd337","original_commit_id":"2d2e78ecc76bc40d8356c4c0377e573cea9dd337","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings","created_at":"2018-09-08T17:55:39Z","updated_at":"2018-09-08T17:55:39Z","html_url":"https://github.com/joomla/joomla-cms/pull/22075#discussion_r216136719","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/216136719"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/22075#discussion_r216136719"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075","id":214096325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDk2MzI1","html_url":"https://github.com/joomla/joomla-cms/pull/22075","diff_url":"https://github.com/joomla/joomla-cms/pull/22075.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/22075.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/22075","number":22075,"state":"open","locked":false,"title":"[4.0] Change backend font to roboto","user":{"login":"coolcat-creations","id":828371,"node_id":"MDQ6VXNlcjgyODM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/828371?v=4","gravatar_id":"","url":"https://api.github.com/users/coolcat-creations","html_url":"https://github.com/coolcat-creations","followers_url":"https://api.github.com/users/coolcat-creations/followers","following_url":"https://api.github.com/users/coolcat-creations/following{/other_user}","gists_url":"https://api.github.com/users/coolcat-creations/gists{/gist_id}","starred_url":"https://api.github.com/users/coolcat-creations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolcat-creations/subscriptions","organizations_url":"https://api.github.com/users/coolcat-creations/orgs","repos_url":"https://api.github.com/users/coolcat-creations/repos","events_url":"https://api.github.com/users/coolcat-creations/events{/privacy}","received_events_url":"https://api.github.com/users/coolcat-creations/received_events","type":"User","site_admin":false},"body":"This PR changes the backend template font to the font that is used in the backend template draft:\r\nhttps://magazine.joomla.org/item/3289-episode-iv-a-new-user-interface-for-the-joomla-backend\r\n\r\n### Summary of Changes\r\nThe Backend Font is now Roboto\r\n\r\n### Testing Instructions\r\nFont sizes will be fixed in separate PRs just check if the font was arial before and roboto after.\r\n\r\nI created a fonts folder to prepare a structure for other fonts. I think also font-awesome should be moved there in another PR.\r\nThe reason for two scss files is also a consistent structure. In FA you have a whole set of scss files.\r\n\r\n","created_at":"2018-09-08T13:49:09Z","updated_at":"2018-09-08T17:55:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebc24fd8429427623e01b00f944e48509ead35c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/22075/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/2d2e78ecc76bc40d8356c4c0377e573cea9dd337","head":{"label":"coolcat-creations:change-backend-font-to-roboto","ref":"change-backend-font-to-roboto","sha":"2d2e78ecc76bc40d8356c4c0377e573cea9dd337","user":{"login":"coolcat-creations","id":828371,"node_id":"MDQ6VXNlcjgyODM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/828371?v=4","gravatar_id":"","url":"https://api.github.com/users/coolcat-creations","html_url":"https://github.com/coolcat-creations","followers_url":"https://api.github.com/users/coolcat-creations/followers","following_url":"https://api.github.com/users/coolcat-creations/following{/other_user}","gists_url":"https://api.github.com/users/coolcat-creations/gists{/gist_id}","starred_url":"https://api.github.com/users/coolcat-creations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolcat-creations/subscriptions","organizations_url":"https://api.github.com/users/coolcat-creations/orgs","repos_url":"https://api.github.com/users/coolcat-creations/repos","events_url":"https://api.github.com/users/coolcat-creations/events{/privacy}","received_events_url":"https://api.github.com/users/coolcat-creations/received_events","type":"User","site_admin":false},"repo":{"id":37080859,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA4MDg1OQ==","name":"joomla-cms","full_name":"coolcat-creations/joomla-cms","owner":{"login":"coolcat-creations","id":828371,"node_id":"MDQ6VXNlcjgyODM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/828371?v=4","gravatar_id":"","url":"https://api.github.com/users/coolcat-creations","html_url":"https://github.com/coolcat-creations","followers_url":"https://api.github.com/users/coolcat-creations/followers","following_url":"https://api.github.com/users/coolcat-creations/following{/other_user}","gists_url":"https://api.github.com/users/coolcat-creations/gists{/gist_id}","starred_url":"https://api.github.com/users/coolcat-creations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolcat-creations/subscriptions","organizations_url":"https://api.github.com/users/coolcat-creations/orgs","repos_url":"https://api.github.com/users/coolcat-creations/repos","events_url":"https://api.github.com/users/coolcat-creations/events{/privacy}","received_events_url":"https://api.github.com/users/coolcat-creations/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coolcat-creations/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/coolcat-creations/joomla-cms","forks_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/forks","keys_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/teams","hooks_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/events","assignees_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/tags","blobs_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/subscription","commits_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/merges","archive_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/downloads","issues_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/coolcat-creations/joomla-cms/deployments","created_at":"2015-06-08T17:08:10Z","updated_at":"2016-07-23T12:37:58Z","pushed_at":"2018-09-08T17:55:28Z","git_url":"git://github.com/coolcat-creations/joomla-cms.git","ssh_url":"git@github.com:coolcat-creations/joomla-cms.git","clone_url":"https://github.com/coolcat-creations/joomla-cms.git","svn_url":"https://github.com/coolcat-creations/joomla-cms","homepage":"http://joomla.org","size":241977,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"98dd54c7ed703b09490a51377dde8feca66c90b1","user":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY0OTA4","name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-09-08T15:44:58Z","pushed_at":"2018-09-08T17:55:30Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":243239,"stargazers_count":2884,"watchers_count":2884,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2752,"mirror_url":null,"archived":false,"open_issues_count":783,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2752,"open_issues":783,"watchers":2884,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/22075"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/22075"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/22075/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/22075/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/2d2e78ecc76bc40d8356c4c0377e573cea9dd337"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}