{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/198361244","pull_request_review_id":132278552,"id":198361244,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODM2MTI0NA==","diff_hunk":"@@ -378,7 +378,7 @@ bool faction::matches_us(faction_value v) const\n std::string faction::describe() const\n {\n     std::string ret;\n-    ret = desc + \"\\n \\n\" + string_format( _(\"%1$s have the ultimate goal of %2$s.\"), name.c_str(),\n+    ret = string_format( \"%1$s\\n \\n%2$s have the ultimate goal of %3$s.\", _( desc.c_str() ), _( name.c_str() ),","path":"src/faction.cpp","position":5,"original_position":5,"commit_id":"a520abc4ca163437059ccff1377f9c1ddc578955","original_commit_id":"a520abc4ca163437059ccff1377f9c1ddc578955","user":{"login":"BrettDong","id":21075502,"node_id":"MDQ6VXNlcjIxMDc1NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/21075502?v=4","gravatar_id":"","url":"https://api.github.com/users/BrettDong","html_url":"https://github.com/BrettDong","followers_url":"https://api.github.com/users/BrettDong/followers","following_url":"https://api.github.com/users/BrettDong/following{/other_user}","gists_url":"https://api.github.com/users/BrettDong/gists{/gist_id}","starred_url":"https://api.github.com/users/BrettDong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrettDong/subscriptions","organizations_url":"https://api.github.com/users/BrettDong/orgs","repos_url":"https://api.github.com/users/BrettDong/repos","events_url":"https://api.github.com/users/BrettDong/events{/privacy}","received_events_url":"https://api.github.com/users/BrettDong/received_events","type":"User","site_admin":false},"body":"Shouldn't it be `string_format( _( \"%1$s\\n \\n%2$s have the ultimate goal of %3$s.\" ), ... )` ?\r\n\r\nAlso, I'd rather fix the issue like this:\r\n```c++\r\nstd::string ret = _( desc.c_str() );\r\nret = ret + \"\\n\\n\" + string_format( _( \"%1$s have the ultimate goal of %2$s.\" ), _( name.c_str() ), _( facgoal_data[goal].name.c_str() ) );\r\n```","created_at":"2018-06-27T04:04:17Z","updated_at":"2018-06-27T04:04:17Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24103#discussion_r198361244","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/198361244"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24103#discussion_r198361244"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103","id":197494431,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDk0NDMx","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24103","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24103.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24103.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24103","number":24103,"state":"open","locked":false,"title":"Translate faction strings","user":{"login":"AMurkin","id":1931904,"node_id":"MDQ6VXNlcjE5MzE5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1931904?v=4","gravatar_id":"","url":"https://api.github.com/users/AMurkin","html_url":"https://github.com/AMurkin","followers_url":"https://api.github.com/users/AMurkin/followers","following_url":"https://api.github.com/users/AMurkin/following{/other_user}","gists_url":"https://api.github.com/users/AMurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/AMurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMurkin/subscriptions","organizations_url":"https://api.github.com/users/AMurkin/orgs","repos_url":"https://api.github.com/users/AMurkin/repos","events_url":"https://api.github.com/users/AMurkin/events{/privacy}","received_events_url":"https://api.github.com/users/AMurkin/received_events","type":"User","site_admin":false},"body":"Fixes #23482\r\n\r\nAlters one translated string.","created_at":"2018-06-26T17:16:16Z","updated_at":"2018-06-27T04:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afe4682131706ee7cdbbf16b15bf2ae67270a3f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":85403318,"node_id":"MDU6TGFiZWw4NTQwMzMxOA==","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Translation","name":"Translation","color":"02b605","default":false},{"id":659366627,"node_id":"MDU6TGFiZWw2NTkzNjY2Mjc=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[C++]","name":"[C++]","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24103/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/a520abc4ca163437059ccff1377f9c1ddc578955","head":{"label":"AMurkin:translate-faction-names","ref":"translate-faction-names","sha":"a520abc4ca163437059ccff1377f9c1ddc578955","user":{"login":"AMurkin","id":1931904,"node_id":"MDQ6VXNlcjE5MzE5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1931904?v=4","gravatar_id":"","url":"https://api.github.com/users/AMurkin","html_url":"https://github.com/AMurkin","followers_url":"https://api.github.com/users/AMurkin/followers","following_url":"https://api.github.com/users/AMurkin/following{/other_user}","gists_url":"https://api.github.com/users/AMurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/AMurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMurkin/subscriptions","organizations_url":"https://api.github.com/users/AMurkin/orgs","repos_url":"https://api.github.com/users/AMurkin/repos","events_url":"https://api.github.com/users/AMurkin/events{/privacy}","received_events_url":"https://api.github.com/users/AMurkin/received_events","type":"User","site_admin":false},"repo":{"id":87215572,"node_id":"MDEwOlJlcG9zaXRvcnk4NzIxNTU3Mg==","name":"Cataclysm-DDA","full_name":"AMurkin/Cataclysm-DDA","owner":{"login":"AMurkin","id":1931904,"node_id":"MDQ6VXNlcjE5MzE5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1931904?v=4","gravatar_id":"","url":"https://api.github.com/users/AMurkin","html_url":"https://github.com/AMurkin","followers_url":"https://api.github.com/users/AMurkin/followers","following_url":"https://api.github.com/users/AMurkin/following{/other_user}","gists_url":"https://api.github.com/users/AMurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/AMurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMurkin/subscriptions","organizations_url":"https://api.github.com/users/AMurkin/orgs","repos_url":"https://api.github.com/users/AMurkin/repos","events_url":"https://api.github.com/users/AMurkin/events{/privacy}","received_events_url":"https://api.github.com/users/AMurkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AMurkin/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA","forks_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/AMurkin/Cataclysm-DDA/deployments","created_at":"2017-04-04T17:25:48Z","updated_at":"2018-06-21T17:54:44Z","pushed_at":"2018-06-26T18:58:15Z","git_url":"git://github.com/AMurkin/Cataclysm-DDA.git","ssh_url":"git@github.com:AMurkin/Cataclysm-DDA.git","clone_url":"https://github.com/AMurkin/Cataclysm-DDA.git","svn_url":"https://github.com/AMurkin/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1223924,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"98e5ce33ed82c481ffbb1f20efe62a7323d1567b","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-06-27T03:11:16Z","pushed_at":"2018-06-27T03:10:51Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1228815,"stargazers_count":1904,"watchers_count":1904,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1321,"mirror_url":null,"archived":false,"open_issues_count":850,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1321,"open_issues":850,"watchers":1904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24103"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24103"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24103/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24103/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/a520abc4ca163437059ccff1377f9c1ddc578955"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BrettDong"}}