{"action":"created","issue":{"url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1143","repository_url":"https://api.github.com/repos/vulkano-rs/vulkano","labels_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1143/labels{/name}","comments_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1143/comments","events_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1143/events","html_url":"https://github.com/vulkano-rs/vulkano/issues/1143","id":394475379,"node_id":"MDU6SXNzdWUzOTQ0NzUzNzk=","number":1143,"title":"Incorrect use of `deprecated` attribute","user":{"login":"estebank","id":1606434,"node_id":"MDQ6VXNlcjE2MDY0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-27T19:50:49Z","updated_at":"2018-12-27T22:07:20Z","closed_at":null,"author_association":"NONE","body":"rust-lang/rust#56896 is making the correct use of deprecated mandatory in `rustc`. We can't apply this as a hard error due to the following use in `vk-sys`:\r\n\r\n```\r\n[INFO] [stderr]     Checking vk-sys v0.2.7\r\n[INFO] [stderr]     Checking vk v0.0.1\r\n[INFO] [stderr]    Compiling spirv-utils v0.2.1\r\n[INFO] [stderr] error: expected meta item sequence\r\n[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:918:1\r\n[INFO] [stderr]     |\r\n[INFO] [stderr] 918 | #[deprecated = \"Renamed to COLOR_SPACE_SRGB_NONLINEAR_KHR\"]\r\n[INFO] [stderr]     | ^^--------------------------------------------------------^\r\n[INFO] [stderr]     |   |\r\n[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = \"Renamed to COLOR_SPACE_SRGB_NONLINEAR_KHR\")`\r\n[INFO] [stderr] \r\n[INFO] [stderr] error: expected meta item sequence\r\n[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:920:1\r\n[INFO] [stderr]     |\r\n[INFO] [stderr] 920 | #[deprecated = \"Magically disappeared from the Vulkan specs\"]\r\n[INFO] [stderr]     | ^^----------------------------------------------------------^\r\n[INFO] [stderr]     |   |\r\n[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = \"Magically disappeared from the Vulkan specs\")`\r\n[INFO] [stderr] \r\n[INFO] [stderr] error: expected meta item sequence\r\n[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:922:1\r\n[INFO] [stderr]     |\r\n[INFO] [stderr] 922 | #[deprecated = \"Magically disappeared from the Vulkan specs\"]\r\n[INFO] [stderr]     | ^^----------------------------------------------------------^\r\n[INFO] [stderr]     |   |\r\n[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = \"Magically disappeared from the Vulkan specs\")`\r\n[INFO] [stderr] \r\n[INFO] [stderr] error: expected meta item sequence\r\n[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:924:1\r\n[INFO] [stderr]     |\r\n[INFO] [stderr] 924 | #[deprecated = \"Magically disappeared from the Vulkan specs\"]\r\n[INFO] [stderr]     | ^^----------------------------------------------------------^\r\n[INFO] [stderr]     |   |\r\n[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = \"Magically disappeared from the Vulkan specs\")`\r\n[INFO] [stderr] \r\n[INFO] [stderr] error: expected meta item sequence\r\n[INFO] [stderr]    --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/vk-sys-0.2.7/src/lib.rs:926:1\r\n[INFO] [stderr]     |\r\n[INFO] [stderr] 926 | #[deprecated = \"Magically disappeared from the Vulkan specs\"]\r\n[INFO] [stderr]     | ^^----------------------------------------------------------^\r\n[INFO] [stderr]     |   |\r\n[INFO] [stderr]     |   help: use the `note` key: `deprecated(note = \"Magically disappeared from the Vulkan specs\")`\r\n[INFO] [stderr] \r\n```"},"comment":{"url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/comments/450239514","html_url":"https://github.com/vulkano-rs/vulkano/issues/1143#issuecomment-450239514","issue_url":"https://api.github.com/repos/vulkano-rs/vulkano/issues/1143","id":450239514,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDIzOTUxNA==","user":{"login":"rukai","id":5120858,"node_id":"MDQ6VXNlcjUxMjA4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5120858?v=4","gravatar_id":"","url":"https://api.github.com/users/rukai","html_url":"https://github.com/rukai","followers_url":"https://api.github.com/users/rukai/followers","following_url":"https://api.github.com/users/rukai/following{/other_user}","gists_url":"https://api.github.com/users/rukai/gists{/gist_id}","starred_url":"https://api.github.com/users/rukai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rukai/subscriptions","organizations_url":"https://api.github.com/users/rukai/orgs","repos_url":"https://api.github.com/users/rukai/repos","events_url":"https://api.github.com/users/rukai/events{/privacy}","received_events_url":"https://api.github.com/users/rukai/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T22:07:20Z","updated_at":"2018-12-27T22:07:20Z","author_association":"MEMBER","body":"The error you have posted is for vk-sys `0.2.7` which is much older than the current release of `0.4.0`.\r\nI suspect something is using an older version of vk-sys as a dependency here, so not much I can do in this specific case. Looks like you've already decided to change it to a warning, which is good because that's clearly the only way to not break everything here.\r\n\r\nHowever the issue still exists in current vulkano so I'll fix it there. PR incoming."}}
{"actor":{"display_login":"rukai"}}