{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/18795","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/18795/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/18795/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/18795/events","html_url":"https://github.com/openshift/origin/pull/18795","id":301555103,"number":18795,"title":"add controller to maintain default SA permissions","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":223479084,"url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":683887368,"url":"https://api.github.com/repos/openshift/origin/labels/sig/master","name":"sig/master","color":"f9d0c4","default":false},{"id":640548612,"url":"https://api.github.com/repos/openshift/origin/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"enj","id":7001223,"avatar_url":"https://avatars0.githubusercontent.com/u/7001223?v=4","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},"assignees":[{"login":"enj","id":7001223,"avatar_url":"https://avatars0.githubusercontent.com/u/7001223?v=4","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},{"login":"simo5","id":8332609,"avatar_url":"https://avatars2.githubusercontent.com/u/8332609?v=4","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-03-01T20:51:56Z","updated_at":"2018-03-09T22:47:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/18795","html_url":"https://github.com/openshift/origin/pull/18795","diff_url":"https://github.com/openshift/origin/pull/18795.diff","patch_url":"https://github.com/openshift/origin/pull/18795.patch"},"body":"We \"normally\" maintain permissions for image pusher, image puller, and deployer using new-project templates and post-start hooks, but as we add automated components that are not openshift aware and still want features like deploymentconfigs to work, the added maintenance burden seems unnecessary.\r\n\r\nThis pull introduces a controller which does our bindings for SAs to pull images in their project, allows the builder SA to push images in the project, and allows the deployer SA to create pods and RCs.  It is still possible to opt out if you really want to break openshift features in your project by removing the subjects from the binding (I only match on name).\r\n\r\nNo tests yet.  Let's agree in concept first, then I'll add them before we merge.\r\n\r\n@openshift/sig-master "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/371967417","html_url":"https://github.com/openshift/origin/pull/18795#issuecomment-371967417","issue_url":"https://api.github.com/repos/openshift/origin/issues/18795","id":371967417,"user":{"login":"openshift-ci-robot","id":30189103,"avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T22:47:56Z","updated_at":"2018-03-09T22:47:56Z","author_association":"NONE","body":"@deads2k: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/unit | da3c28ae1d1865c6beabb6ce7e07a7168ca706f6 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18795/test_pull_request_origin_unit/10584/) | `/test unit`\nci/openshift-jenkins/cmd | da3c28ae1d1865c6beabb6ce7e07a7168ca706f6 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18795/test_pull_request_origin_cmd/11153/) | `/test cmd`\nci/openshift-jenkins/extended_conformance_install | da3c28ae1d1865c6beabb6ce7e07a7168ca706f6 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18795/test_pull_request_origin_extended_conformance_install/8854/) | `/test extended_conformance_install`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/18795). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/deads2k). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/origin/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}