{"action":"created","comment":{"url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/comments/245488068","pull_request_review_id":189608070,"id":245488068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ4ODA2OA==","diff_hunk":"@@ -131,6 +136,13 @@ public static function parseArguments(array $arguments)\n             }\n         }\n         $setting->functionsToCheck = array_unique($setting->functionsToCheck);\n+\n+        // Any custom function is given\n+        if (count($customFunctions) > 0) {","path":"src/Settings.php","position":29,"original_position":29,"commit_id":"73dcc404a58d81f1dc25df7132b4caf1d6e312e2","original_commit_id":"39403499ef04ba7f48b43d4c5c683e9a5b238a64","user":{"login":"umutphp","id":3245166,"node_id":"MDQ6VXNlcjMyNDUxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3245166?v=4","gravatar_id":"","url":"https://api.github.com/users/umutphp","html_url":"https://github.com/umutphp","followers_url":"https://api.github.com/users/umutphp/followers","following_url":"https://api.github.com/users/umutphp/following{/other_user}","gists_url":"https://api.github.com/users/umutphp/gists{/gist_id}","starred_url":"https://api.github.com/users/umutphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umutphp/subscriptions","organizations_url":"https://api.github.com/users/umutphp/orgs","repos_url":"https://api.github.com/users/umutphp/repos","events_url":"https://api.github.com/users/umutphp/events{/privacy}","received_events_url":"https://api.github.com/users/umutphp/received_events","type":"User","site_admin":false},"body":"empty is used instead of count($customFunctions) > 0","created_at":"2019-01-05T20:42:24Z","updated_at":"2019-01-05T20:42:24Z","html_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check/pull/32#discussion_r245488068","pull_request_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/comments/245488068"},"html":{"href":"https://github.com/JakubOnderka/PHP-Var-Dump-Check/pull/32#discussion_r245488068"},"pull_request":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32"}},"in_reply_to_id":245487766},"pull_request":{"url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32","id":237660811,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjYwODEx","html_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check/pull/32","diff_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check/pull/32.diff","patch_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check/pull/32.patch","issue_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues/32","number":32,"state":"open","locked":false,"title":"Add --custom-function parameter to check.","user":{"login":"umutphp","id":3245166,"node_id":"MDQ6VXNlcjMyNDUxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3245166?v=4","gravatar_id":"","url":"https://api.github.com/users/umutphp","html_url":"https://github.com/umutphp","followers_url":"https://api.github.com/users/umutphp/followers","following_url":"https://api.github.com/users/umutphp/following{/other_user}","gists_url":"https://api.github.com/users/umutphp/gists{/gist_id}","starred_url":"https://api.github.com/users/umutphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umutphp/subscriptions","organizations_url":"https://api.github.com/users/umutphp/orgs","repos_url":"https://api.github.com/users/umutphp/repos","events_url":"https://api.github.com/users/umutphp/events{/privacy}","received_events_url":"https://api.github.com/users/umutphp/received_events","type":"User","site_admin":false},"body":"In one of the projects that I have been working for a while, there are some legacy dump functions created and used frequently by the team. A sample function is;\r\n\r\n`\r\nfunction pre_dump( $var ) {\r\n\techo '<pre>';\r\n\tvar_dump( $var );\r\n\techo '</pre>';\r\n}\r\n`\r\n\r\nThe check can not be able to find the usage of this kind of functions. With this pull request, user can give the names of such kind of custom debug functions to the check function with \"--custom-function\" parameter.","created_at":"2018-12-11T12:27:35Z","updated_at":"2019-01-05T20:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ef31335e5397195273b7cbd1e43243b1155168","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32/commits","review_comments_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32/comments","review_comment_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues/32/comments","statuses_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/statuses/73dcc404a58d81f1dc25df7132b4caf1d6e312e2","head":{"label":"umutphp:master","ref":"master","sha":"73dcc404a58d81f1dc25df7132b4caf1d6e312e2","user":{"login":"umutphp","id":3245166,"node_id":"MDQ6VXNlcjMyNDUxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3245166?v=4","gravatar_id":"","url":"https://api.github.com/users/umutphp","html_url":"https://github.com/umutphp","followers_url":"https://api.github.com/users/umutphp/followers","following_url":"https://api.github.com/users/umutphp/following{/other_user}","gists_url":"https://api.github.com/users/umutphp/gists{/gist_id}","starred_url":"https://api.github.com/users/umutphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umutphp/subscriptions","organizations_url":"https://api.github.com/users/umutphp/orgs","repos_url":"https://api.github.com/users/umutphp/repos","events_url":"https://api.github.com/users/umutphp/events{/privacy}","received_events_url":"https://api.github.com/users/umutphp/received_events","type":"User","site_admin":false},"repo":{"id":161167823,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExNjc4MjM=","name":"PHP-Var-Dump-Check","full_name":"umutphp/PHP-Var-Dump-Check","private":false,"owner":{"login":"umutphp","id":3245166,"node_id":"MDQ6VXNlcjMyNDUxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3245166?v=4","gravatar_id":"","url":"https://api.github.com/users/umutphp","html_url":"https://github.com/umutphp","followers_url":"https://api.github.com/users/umutphp/followers","following_url":"https://api.github.com/users/umutphp/following{/other_user}","gists_url":"https://api.github.com/users/umutphp/gists{/gist_id}","starred_url":"https://api.github.com/users/umutphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umutphp/subscriptions","organizations_url":"https://api.github.com/users/umutphp/orgs","repos_url":"https://api.github.com/users/umutphp/repos","events_url":"https://api.github.com/users/umutphp/events{/privacy}","received_events_url":"https://api.github.com/users/umutphp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/umutphp/PHP-Var-Dump-Check","description":"Find forgotten variables dump in PHP source code.","fork":true,"url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check","forks_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/forks","keys_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/teams","hooks_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/hooks","issue_events_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/issues/events{/number}","events_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/events","assignees_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/assignees{/user}","branches_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/branches{/branch}","tags_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/tags","blobs_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/git/refs{/sha}","trees_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/statuses/{sha}","languages_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/languages","stargazers_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/stargazers","contributors_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/contributors","subscribers_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/subscribers","subscription_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/subscription","commits_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/commits{/sha}","git_commits_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/git/commits{/sha}","comments_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/comments{/number}","issue_comment_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/issues/comments{/number}","contents_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/contents/{+path}","compare_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/merges","archive_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/downloads","issues_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/issues{/number}","pulls_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/pulls{/number}","milestones_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/milestones{/number}","notifications_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/labels{/name}","releases_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/releases{/id}","deployments_url":"https://api.github.com/repos/umutphp/PHP-Var-Dump-Check/deployments","created_at":"2018-12-10T11:57:08Z","updated_at":"2019-01-05T20:33:30Z","pushed_at":"2019-01-05T20:33:28Z","git_url":"git://github.com/umutphp/PHP-Var-Dump-Check.git","ssh_url":"git@github.com:umutphp/PHP-Var-Dump-Check.git","clone_url":"https://github.com/umutphp/PHP-Var-Dump-Check.git","svn_url":"https://github.com/umutphp/PHP-Var-Dump-Check","homepage":"","size":61,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JakubOnderka:master","ref":"master","sha":"1f62bf9eef630943219f9b24371f44f9b7f749aa","user":{"login":"JakubOnderka","id":163343,"node_id":"MDQ6VXNlcjE2MzM0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/163343?v=4","gravatar_id":"","url":"https://api.github.com/users/JakubOnderka","html_url":"https://github.com/JakubOnderka","followers_url":"https://api.github.com/users/JakubOnderka/followers","following_url":"https://api.github.com/users/JakubOnderka/following{/other_user}","gists_url":"https://api.github.com/users/JakubOnderka/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubOnderka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubOnderka/subscriptions","organizations_url":"https://api.github.com/users/JakubOnderka/orgs","repos_url":"https://api.github.com/users/JakubOnderka/repos","events_url":"https://api.github.com/users/JakubOnderka/events{/privacy}","received_events_url":"https://api.github.com/users/JakubOnderka/received_events","type":"User","site_admin":false},"repo":{"id":9239478,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM5NDc4","name":"PHP-Var-Dump-Check","full_name":"JakubOnderka/PHP-Var-Dump-Check","private":false,"owner":{"login":"JakubOnderka","id":163343,"node_id":"MDQ6VXNlcjE2MzM0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/163343?v=4","gravatar_id":"","url":"https://api.github.com/users/JakubOnderka","html_url":"https://github.com/JakubOnderka","followers_url":"https://api.github.com/users/JakubOnderka/followers","following_url":"https://api.github.com/users/JakubOnderka/following{/other_user}","gists_url":"https://api.github.com/users/JakubOnderka/gists{/gist_id}","starred_url":"https://api.github.com/users/JakubOnderka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakubOnderka/subscriptions","organizations_url":"https://api.github.com/users/JakubOnderka/orgs","repos_url":"https://api.github.com/users/JakubOnderka/repos","events_url":"https://api.github.com/users/JakubOnderka/events{/privacy}","received_events_url":"https://api.github.com/users/JakubOnderka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check","description":"Find forgotten variables dump in PHP source code.","fork":false,"url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check","forks_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/forks","keys_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/teams","hooks_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/hooks","issue_events_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues/events{/number}","events_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/events","assignees_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/assignees{/user}","branches_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/branches{/branch}","tags_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/tags","blobs_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/statuses/{sha}","languages_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/languages","stargazers_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/stargazers","contributors_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/contributors","subscribers_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/subscribers","subscription_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/subscription","commits_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues/comments{/number}","contents_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/contents/{+path}","compare_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/merges","archive_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/downloads","issues_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues{/number}","pulls_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls{/number}","milestones_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/milestones{/number}","notifications_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/labels{/name}","releases_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/releases{/id}","deployments_url":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/deployments","created_at":"2013-04-05T11:10:51Z","updated_at":"2019-01-05T20:22:15Z","pushed_at":"2019-01-05T20:33:30Z","git_url":"git://github.com/JakubOnderka/PHP-Var-Dump-Check.git","ssh_url":"git@github.com:JakubOnderka/PHP-Var-Dump-Check.git","clone_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check.git","svn_url":"https://github.com/JakubOnderka/PHP-Var-Dump-Check","homepage":"","size":64,"stargazers_count":16,"watchers_count":16,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":3,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32"},"html":{"href":"https://github.com/JakubOnderka/PHP-Var-Dump-Check/pull/32"},"issue":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues/32"},"comments":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/JakubOnderka/PHP-Var-Dump-Check/statuses/73dcc404a58d81f1dc25df7132b4caf1d6e312e2"}},"author_association":"NONE"}}
{"actor":{"display_login":"umutphp"}}