{"action":"created","issue":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/4089","repository_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL","labels_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/4089/labels{/name}","comments_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/4089/comments","events_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/4089/events","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/4089","id":307488136,"number":4089,"title":"Settler Logic","user":{"login":"LoneGazebo","id":7849458,"avatar_url":"https://avatars2.githubusercontent.com/u/7849458?v=4","gravatar_id":"","url":"https://api.github.com/users/LoneGazebo","html_url":"https://github.com/LoneGazebo","followers_url":"https://api.github.com/users/LoneGazebo/followers","following_url":"https://api.github.com/users/LoneGazebo/following{/other_user}","gists_url":"https://api.github.com/users/LoneGazebo/gists{/gist_id}","starred_url":"https://api.github.com/users/LoneGazebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoneGazebo/subscriptions","organizations_url":"https://api.github.com/users/LoneGazebo/orgs","repos_url":"https://api.github.com/users/LoneGazebo/repos","events_url":"https://api.github.com/users/LoneGazebo/events{/privacy}","received_events_url":"https://api.github.com/users/LoneGazebo/received_events","type":"User","site_admin":false},"labels":[{"id":283762012,"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/labels/Paging%20Dr.%20Ilteroi","name":"Paging Dr. Ilteroi","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-22T02:54:36Z","updated_at":"2018-03-22T09:02:08Z","closed_at":null,"author_association":"OWNER","body":"@ilteroi ,\r\n\r\nI spent a little while walking the stack in the plot evaluator for settling, and here are some things I observed:\r\n\r\n1.) Area found values are in the millions and billions. Huge, huge numbers. Perhaps we should deflate values for tiles overall to get more sane numbers? I think the large values are causing any of the % modifiers (such as strategic modifiers) to grossly throw site evaluation out of whack.\r\n2.) the function GetCityDistanceInEstimatedTurns seems to return erratic values, most often 42 (meaning of life?). I can't figure out why, but it doesn't seem to be working correctly.\r\n3.) the m_iRingModifier array has uninitialized values in it that are max int values. They don't seem accessible, but we should probably init them to 0.\r\n4.) the // where is our personal sweet spot? section is fine, but it doesn't penalize plots outside of our sweet zone. I think it should, scaling with distance. This will probably help deflate area values as well.\r\n\r\nCheers,\r\nG"},"comment":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/comments/375224729","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/4089#issuecomment-375224729","issue_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/4089","id":375224729,"user":{"login":"ilteroi","id":1358966,"avatar_url":"https://avatars0.githubusercontent.com/u/1358966?v=4","gravatar_id":"","url":"https://api.github.com/users/ilteroi","html_url":"https://github.com/ilteroi","followers_url":"https://api.github.com/users/ilteroi/followers","following_url":"https://api.github.com/users/ilteroi/following{/other_user}","gists_url":"https://api.github.com/users/ilteroi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilteroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilteroi/subscriptions","organizations_url":"https://api.github.com/users/ilteroi/orgs","repos_url":"https://api.github.com/users/ilteroi/repos","events_url":"https://api.github.com/users/ilteroi/events{/privacy}","received_events_url":"https://api.github.com/users/ilteroi/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T09:02:08Z","updated_at":"2018-03-22T09:02:08Z","author_association":"COLLABORATOR","body":"anyway, regarding the points from the forum discussion\r\n\r\n* distance check: don't see any necessity for changes in the distance calculation (bugs notwithstanding). forward settling can be a smart move, but maybe should correlate to AI personality more closely. which flavor is relevant here? \r\n* development level / economic power of neighboring cities -> what is the reference? don't do this. look at military instead.\r\n* cooldown for plot buying -> what's your opinion? could you implement this? maybe an exception for washington? also disable plot buying for pop 1 cities in general?\r\n* failing to expand -> did you do anything about this?\r\n* failing to defend -> there should already be a temporary tactical zone around a new settled city, but it's unclear what good it does. could also create a more heavily escorted settle operation, but what we really need is a permanent military presence. i'll look at the threat calculation.\r\n* bad cities -> there is already a min hammers/min food check, i can increase that a little bit. also penalize plots adjacent to enemy territory. should we require at least one resource within ring 2 or so?"}}
{"actor":{"display_login":"ilteroi"}}