{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/197535448","pull_request_review_id":131305592,"id":197535448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzUzNTQ0OA==","diff_hunk":"@@ -211,6 +262,20 @@ export class ApexReplayDebug extends LoggingDebugSession {\n     this.printToDebugConsole(\n       nls.localize('session_started_text', this.logContext.getLogFileName())\n     );\n+    // If the projectPath isn't set then don't bother with heap dump processing\n+    if (this.projectPath) {\n+      if (this.logContext.scanLogForHeapDumpLines()) {\n+        if (\n+          !await this.logContext.fetchOverlayResultsForApexHeapDumps(","path":"packages/salesforcedx-apex-replay-debugger/src/adapter/apexReplayDebug.ts","position":95,"original_position":95,"commit_id":"68568b3ba21319c3a789d32080306274265b4e66","original_commit_id":"68568b3ba21319c3a789d32080306274265b4e66","user":{"login":"DatGuyJonathan","id":7286437,"node_id":"MDQ6VXNlcjcyODY0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/7286437?v=4","gravatar_id":"","url":"https://api.github.com/users/DatGuyJonathan","html_url":"https://github.com/DatGuyJonathan","followers_url":"https://api.github.com/users/DatGuyJonathan/followers","following_url":"https://api.github.com/users/DatGuyJonathan/following{/other_user}","gists_url":"https://api.github.com/users/DatGuyJonathan/gists{/gist_id}","starred_url":"https://api.github.com/users/DatGuyJonathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatGuyJonathan/subscriptions","organizations_url":"https://api.github.com/users/DatGuyJonathan/orgs","repos_url":"https://api.github.com/users/DatGuyJonathan/repos","events_url":"https://api.github.com/users/DatGuyJonathan/events{/privacy}","received_events_url":"https://api.github.com/users/DatGuyJonathan/received_events","type":"User","site_admin":false},"body":"Could you collapse these all into one if statement?","created_at":"2018-06-22T18:42:56Z","updated_at":"2018-06-22T18:42:56Z","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/500#discussion_r197535448","pull_request_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/197535448"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/500#discussion_r197535448"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500"}},"in_reply_to_id":197252093},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500","id":196550941,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTUwOTQx","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/500","diff_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/500.diff","patch_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/500.patch","issue_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/500","number":500,"state":"open","locked":false,"title":"Rest call to get heapdumps, initial","user":{"login":"JimSuplizio","id":13556087,"node_id":"MDQ6VXNlcjEzNTU2MDg3","avatar_url":"https://avatars3.githubusercontent.com/u/13556087?v=4","gravatar_id":"","url":"https://api.github.com/users/JimSuplizio","html_url":"https://github.com/JimSuplizio","followers_url":"https://api.github.com/users/JimSuplizio/followers","following_url":"https://api.github.com/users/JimSuplizio/following{/other_user}","gists_url":"https://api.github.com/users/JimSuplizio/gists{/gist_id}","starred_url":"https://api.github.com/users/JimSuplizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimSuplizio/subscriptions","organizations_url":"https://api.github.com/users/JimSuplizio/orgs","repos_url":"https://api.github.com/users/JimSuplizio/repos","events_url":"https://api.github.com/users/JimSuplizio/events{/privacy}","received_events_url":"https://api.github.com/users/JimSuplizio/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nThis PR contains the necessary changes to scan the log for heap_dump lines and make the necessary calls, on initialize request, to pull the heap dumps to the client.\r\n\r\n### What issues does this PR fix or reference?\r\n@W-5068047@","created_at":"2018-06-21T19:20:54Z","updated_at":"2018-06-22T18:42:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a31cfa35c03981b310c40b27f9e6bf5c16ae179d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vazexqi","id":54414,"node_id":"MDQ6VXNlcjU0NDE0","avatar_url":"https://avatars1.githubusercontent.com/u/54414?v=4","gravatar_id":"","url":"https://api.github.com/users/vazexqi","html_url":"https://github.com/vazexqi","followers_url":"https://api.github.com/users/vazexqi/followers","following_url":"https://api.github.com/users/vazexqi/following{/other_user}","gists_url":"https://api.github.com/users/vazexqi/gists{/gist_id}","starred_url":"https://api.github.com/users/vazexqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vazexqi/subscriptions","organizations_url":"https://api.github.com/users/vazexqi/orgs","repos_url":"https://api.github.com/users/vazexqi/repos","events_url":"https://api.github.com/users/vazexqi/events{/privacy}","received_events_url":"https://api.github.com/users/vazexqi/received_events","type":"User","site_admin":false},{"login":"Sweetman","id":4503716,"node_id":"MDQ6VXNlcjQ1MDM3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4503716?v=4","gravatar_id":"","url":"https://api.github.com/users/Sweetman","html_url":"https://github.com/Sweetman","followers_url":"https://api.github.com/users/Sweetman/followers","following_url":"https://api.github.com/users/Sweetman/following{/other_user}","gists_url":"https://api.github.com/users/Sweetman/gists{/gist_id}","starred_url":"https://api.github.com/users/Sweetman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sweetman/subscriptions","organizations_url":"https://api.github.com/users/Sweetman/orgs","repos_url":"https://api.github.com/users/Sweetman/repos","events_url":"https://api.github.com/users/Sweetman/events{/privacy}","received_events_url":"https://api.github.com/users/Sweetman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/500/comments","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/68568b3ba21319c3a789d32080306274265b4e66","head":{"label":"forcedotcom:jsuplizio/RESTCallToGetHeapDumps","ref":"jsuplizio/RESTCallToGetHeapDumps","sha":"68568b3ba21319c3a789d32080306274265b4e66","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-06-22T06:26:13Z","pushed_at":"2018-06-21T21:55:00Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":98314,"stargazers_count":160,"watchers_count":160,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":32,"open_issues":35,"watchers":160,"default_branch":"develop"}},"base":{"label":"forcedotcom:develop","ref":"develop","sha":"fc53c11569ab33516b6a7d0d594caa71811ed022","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-06-22T06:26:13Z","pushed_at":"2018-06-21T21:55:00Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":98314,"stargazers_count":160,"watchers_count":160,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":32,"open_issues":35,"watchers":160,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/500"},"issue":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/500"},"comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/68568b3ba21319c3a789d32080306274265b4e66"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DatGuyJonathan"}}