{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/194913950","pull_request_review_id":128178916,"id":194913950,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDkxMzk1MA==","diff_hunk":"@@ -371,7 +372,8 @@ func resolvePackages(numWorkers int, set bundleSet, packagerCmd []string, emptyD\n \t\t\t// status. This exit status is 1, which is the same as any other dnf install\n \t\t\t// error. Fortunately if this is a different error than we expect, it should\n \t\t\t// fail in the actual install to the full chroot.\n-\t\t\toutBuf, _ := helpers.RunCommandOutput(queryString[0], queryString[1:]...)\n+\t\t\ttimeout := 0\n+\t\t\toutBuf, _ := helpers.RunCommandOutput(timeout, queryString[0], queryString[1:]...)","path":"builder/bundles.go","position":16,"original_position":16,"commit_id":"f41a3dd2610e6c376140b90e4c379ecbe0e2102d","original_commit_id":"f41a3dd2610e6c376140b90e4c379ecbe0e2102d","user":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"body":"People (including me) hated on using magic numbers in these kinds of cases. Was just trying to make it more clear, but I'm thinking of how to re-write.","created_at":"2018-06-12T23:01:31Z","updated_at":"2018-06-12T23:01:31Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/346#discussion_r194913950","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/194913950"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/346#discussion_r194913950"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346"}},"in_reply_to_id":194912907},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346","id":194429259,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDI5MjU5","html_url":"https://github.com/clearlinux/mixer-tools/pull/346","diff_url":"https://github.com/clearlinux/mixer-tools/pull/346.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/346.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/346","number":346,"state":"open","locked":false,"title":"Set timeout on bsdiff delta creation","user":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"body":"Set timeout to 1 minute for bsdiff. The majority of all delta creations\r\ntake significantly less than 1 minute to run, which signifies that bsdiff\r\nis working on a delta that may be very large, or very difficult to diff. In\r\nall the cases where bsdiff took multiple minutes to finish, the delta ended\r\nup not being used because it was larger than the compressed fullfile. This\r\nattempts to skip those cases and improve delta creation time.\r\n\r\nSigned-off-by: Tudor Marcu <tudor.marcu@intel.com>","created_at":"2018-06-12T22:52:14Z","updated_at":"2018-06-12T23:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bab7305dd495b0dc4e9bbe95d86186488584886a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/346/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/f41a3dd2610e6c376140b90e4c379ecbe0e2102d","head":{"label":"tmarcu:FASTDELTA","ref":"FASTDELTA","sha":"f41a3dd2610e6c376140b90e4c379ecbe0e2102d","user":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"repo":{"id":120857933,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4NTc5MzM=","name":"mixer-tools","full_name":"tmarcu/mixer-tools","owner":{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmarcu/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/tmarcu/mixer-tools","forks_url":"https://api.github.com/repos/tmarcu/mixer-tools/forks","keys_url":"https://api.github.com/repos/tmarcu/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmarcu/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmarcu/mixer-tools/teams","hooks_url":"https://api.github.com/repos/tmarcu/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/tmarcu/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/tmarcu/mixer-tools/events","assignees_url":"https://api.github.com/repos/tmarcu/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/tmarcu/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/tmarcu/mixer-tools/tags","blobs_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmarcu/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/tmarcu/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/tmarcu/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/tmarcu/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/tmarcu/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/tmarcu/mixer-tools/subscription","commits_url":"https://api.github.com/repos/tmarcu/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmarcu/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmarcu/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmarcu/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmarcu/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/tmarcu/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmarcu/mixer-tools/merges","archive_url":"https://api.github.com/repos/tmarcu/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmarcu/mixer-tools/downloads","issues_url":"https://api.github.com/repos/tmarcu/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/tmarcu/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/tmarcu/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/tmarcu/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmarcu/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/tmarcu/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/tmarcu/mixer-tools/deployments","created_at":"2018-02-09T04:49:32Z","updated_at":"2018-02-09T04:49:34Z","pushed_at":"2018-06-12T22:51:46Z","git_url":"git://github.com/tmarcu/mixer-tools.git","ssh_url":"git@github.com:tmarcu/mixer-tools.git","clone_url":"https://github.com/tmarcu/mixer-tools.git","svn_url":"https://github.com/tmarcu/mixer-tools","homepage":null,"size":1251,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"38bbbce8b308795bda0368a42b2895e0c15e21fa","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQzOTQ3NA==","name":"mixer-tools","full_name":"clearlinux/mixer-tools","owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2018-06-11T22:38:34Z","pushed_at":"2018-06-12T22:52:15Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":1283,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":44,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/346"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/346"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/f41a3dd2610e6c376140b90e4c379ecbe0e2102d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tmarcu"}}