{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments/210528310","pull_request_review_id":146759864,"id":210528310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDUyODMxMA==","diff_hunk":"@@ -177,17 +178,76 @@ func (h *Host) CreateNamespace(ns string) error {\n \treturn nil\n }\n \n-func (h *Host) DeleteGuestCluster(name, cr, logEntry string) error {\n-\tif err := runCmd(fmt.Sprintf(\"kubectl delete %s %s\", cr, h.clusterID)); err != nil {\n-\t\treturn microerror.Mask(err)\n+func (h *Host) DeleteGuestCluster(ctx context.Context, provider string) error {","path":"pkg/framework/host.go","position":15,"original_position":15,"commit_id":"10f1c8e23d033714640eb227cb2aa376c49f2085","original_commit_id":"0314e4250eb36e95b0588e98455a0c73bd36fc31","user":{"login":"MarcelMue","id":9303709,"node_id":"MDQ6VXNlcjkzMDM3MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/9303709?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelMue","html_url":"https://github.com/MarcelMue","followers_url":"https://api.github.com/users/MarcelMue/followers","following_url":"https://api.github.com/users/MarcelMue/following{/other_user}","gists_url":"https://api.github.com/users/MarcelMue/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelMue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelMue/subscriptions","organizations_url":"https://api.github.com/users/MarcelMue/orgs","repos_url":"https://api.github.com/users/MarcelMue/repos","events_url":"https://api.github.com/users/MarcelMue/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelMue/received_events","type":"User","site_admin":false},"body":"Kind of, we have e2e tests that don't need a guest cluster (e.g. operatorkit or chart-operator)","created_at":"2018-08-16T09:15:24Z","updated_at":"2018-08-16T09:15:24Z","html_url":"https://github.com/giantswarm/e2e-harness/pull/117#discussion_r210528310","pull_request_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments/210528310"},"html":{"href":"https://github.com/giantswarm/e2e-harness/pull/117#discussion_r210528310"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117"}},"in_reply_to_id":210525449},"pull_request":{"url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117","id":208791034,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzkxMDM0","html_url":"https://github.com/giantswarm/e2e-harness/pull/117","diff_url":"https://github.com/giantswarm/e2e-harness/pull/117.diff","patch_url":"https://github.com/giantswarm/e2e-harness/pull/117.patch","issue_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/117","number":117,"state":"open","locked":false,"title":"framework: improve guest cluster deletion","user":{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-16T09:04:12Z","updated_at":"2018-08-16T09:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cbad474a062ecb2bc4d3aca40f742f3e1930c18","assignee":{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"assignees":[{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"sig-operator","id":2690126,"node_id":"MDQ6VGVhbTI2OTAxMjY=","slug":"sig-operator","description":"Driver: @xh3b4sd","privacy":"closed","url":"https://api.github.com/teams/2690126","members_url":"https://api.github.com/teams/2690126/members{/member}","repositories_url":"https://api.github.com/teams/2690126/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117/commits","review_comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117/comments","review_comment_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/117/comments","statuses_url":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/10f1c8e23d033714640eb227cb2aa376c49f2085","head":{"label":"giantswarm:delete-guest","ref":"delete-guest","sha":"10f1c8e23d033714640eb227cb2aa376c49f2085","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":107268623,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyNjg2MjM=","name":"e2e-harness","full_name":"giantswarm/e2e-harness","owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/e2e-harness","description":"Harness for custom kubernetes e2e testing.","fork":false,"url":"https://api.github.com/repos/giantswarm/e2e-harness","forks_url":"https://api.github.com/repos/giantswarm/e2e-harness/forks","keys_url":"https://api.github.com/repos/giantswarm/e2e-harness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/e2e-harness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/e2e-harness/teams","hooks_url":"https://api.github.com/repos/giantswarm/e2e-harness/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/e2e-harness/events","assignees_url":"https://api.github.com/repos/giantswarm/e2e-harness/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/e2e-harness/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/tags","blobs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/e2e-harness/languages","stargazers_url":"https://api.github.com/repos/giantswarm/e2e-harness/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/e2e-harness/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscription","commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/e2e-harness/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/e2e-harness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/e2e-harness/merges","archive_url":"https://api.github.com/repos/giantswarm/e2e-harness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/e2e-harness/downloads","issues_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/e2e-harness/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/e2e-harness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/e2e-harness/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/e2e-harness/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/e2e-harness/deployments","created_at":"2017-10-17T12:56:25Z","updated_at":"2018-08-14T08:37:03Z","pushed_at":"2018-08-16T09:06:18Z","git_url":"git://github.com/giantswarm/e2e-harness.git","ssh_url":"git@github.com:giantswarm/e2e-harness.git","clone_url":"https://github.com/giantswarm/e2e-harness.git","svn_url":"https://github.com/giantswarm/e2e-harness","homepage":"","size":20389,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"e4b3a2c22571076a898e46873b392382507bd223","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":107268623,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyNjg2MjM=","name":"e2e-harness","full_name":"giantswarm/e2e-harness","owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/e2e-harness","description":"Harness for custom kubernetes e2e testing.","fork":false,"url":"https://api.github.com/repos/giantswarm/e2e-harness","forks_url":"https://api.github.com/repos/giantswarm/e2e-harness/forks","keys_url":"https://api.github.com/repos/giantswarm/e2e-harness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/e2e-harness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/e2e-harness/teams","hooks_url":"https://api.github.com/repos/giantswarm/e2e-harness/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/e2e-harness/events","assignees_url":"https://api.github.com/repos/giantswarm/e2e-harness/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/e2e-harness/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/tags","blobs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/e2e-harness/languages","stargazers_url":"https://api.github.com/repos/giantswarm/e2e-harness/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/e2e-harness/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/e2e-harness/subscription","commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/e2e-harness/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/e2e-harness/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/e2e-harness/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/e2e-harness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/e2e-harness/merges","archive_url":"https://api.github.com/repos/giantswarm/e2e-harness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/e2e-harness/downloads","issues_url":"https://api.github.com/repos/giantswarm/e2e-harness/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/e2e-harness/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/e2e-harness/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/e2e-harness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/e2e-harness/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/e2e-harness/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/e2e-harness/deployments","created_at":"2017-10-17T12:56:25Z","updated_at":"2018-08-14T08:37:03Z","pushed_at":"2018-08-16T09:06:18Z","git_url":"git://github.com/giantswarm/e2e-harness.git","ssh_url":"git@github.com:giantswarm/e2e-harness.git","clone_url":"https://github.com/giantswarm/e2e-harness.git","svn_url":"https://github.com/giantswarm/e2e-harness","homepage":"","size":20389,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117"},"html":{"href":"https://github.com/giantswarm/e2e-harness/pull/117"},"issue":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/issues/117"},"comments":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/e2e-harness/statuses/10f1c8e23d033714640eb227cb2aa376c49f2085"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MarcelMue"}}