{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/comments/185750154","pull_request_review_id":117200537,"id":185750154,"diff_hunk":"@@ -244,15 +250,27 @@ def setup(self):\n             'clarificationQuestionsOpen': False,\n             'lots': ['saas', 'paas', 'iaas', 'scs'],\n             'applicationCloseDate': '2023-04-11T16:00:00.000000Z',\n+            'applicationsCloseAtUTC': '2023-04-11T16:00:00.000000Z',\n+            'intentionToAwardAtUTC': '2023-04-25T00:00:00.000000Z',\n+            'clarificationsCloseAtUTC': '2023-03-30T17:00:00.000000Z',\n+            'clarificationsPublishAtUTC': '2023-04-04T17:00:00.000000Z',\n+            'frameworkLiveAtUTC': '2023-05-01T00:00:00.000000Z',\n+            'frameworkExpiresAtUTC': '2000-06-06T00:00:00.000000Z',","path":"tests/main/views/test_frameworks.py","position":39,"original_position":39,"commit_id":"51b4122a566931aab37cd625fe092ff70f2d56b7","original_commit_id":"51b4122a566931aab37cd625fe092ff70f2d56b7","user":{"login":"Wynndow","id":13836290,"avatar_url":"https://avatars1.githubusercontent.com/u/13836290?v=4","gravatar_id":"","url":"https://api.github.com/users/Wynndow","html_url":"https://github.com/Wynndow","followers_url":"https://api.github.com/users/Wynndow/followers","following_url":"https://api.github.com/users/Wynndow/following{/other_user}","gists_url":"https://api.github.com/users/Wynndow/gists{/gist_id}","starred_url":"https://api.github.com/users/Wynndow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wynndow/subscriptions","organizations_url":"https://api.github.com/users/Wynndow/orgs","repos_url":"https://api.github.com/users/Wynndow/repos","events_url":"https://api.github.com/users/Wynndow/events{/privacy}","received_events_url":"https://api.github.com/users/Wynndow/received_events","type":"User","site_admin":false},"body":"Slightly irrelevant, but did you mean to put `'2023-06-06T00:00:00.000000Z'`","created_at":"2018-05-03T10:04:57Z","updated_at":"2018-05-03T10:04:57Z","html_url":"https://github.com/alphagov/digitalmarketplace-api/pull/776#discussion_r185750154","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/comments/185750154"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-api/pull/776#discussion_r185750154"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776","id":183749813,"html_url":"https://github.com/alphagov/digitalmarketplace-api/pull/776","diff_url":"https://github.com/alphagov/digitalmarketplace-api/pull/776.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-api/pull/776.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/776","number":776,"state":"open","locked":false,"title":"Store framework dates in DB","user":{"login":"samuelhwilliams","id":2920760,"avatar_url":"https://avatars1.githubusercontent.com/u/2920760?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelhwilliams","html_url":"https://github.com/samuelhwilliams","followers_url":"https://api.github.com/users/samuelhwilliams/followers","following_url":"https://api.github.com/users/samuelhwilliams/following{/other_user}","gists_url":"https://api.github.com/users/samuelhwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelhwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelhwilliams/subscriptions","organizations_url":"https://api.github.com/users/samuelhwilliams/orgs","repos_url":"https://api.github.com/users/samuelhwilliams/repos","events_url":"https://api.github.com/users/samuelhwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/samuelhwilliams/received_events","type":"User","site_admin":false},"body":" ## Summary\r\nAt the moment we have strings describing dates for important events in\r\nthe framework lifecycle stored in the dm-frameworks repository in a YAML\r\nfile. We also duplicate one of these dates on the framework records in\r\nthe API (frameworkCloseDate). This leads to some duplication and the\r\npossibility for these to get out of sync, or for one or the other to not\r\nget populated (which indeed happened recently for G-Cloud 9).\r\n\r\nWe will store the dates in UTC, so changing it to a local timezone\r\nformat will be a job for the frontends. This feels like the safest\r\napproach but does mean we need to be considerate around setting dates\r\nduring British Summer Time as we'll need to remove an hour from the\r\ntime that we want to save. I've named the new fields with a `UTC`\r\nsuffix to make this apparent, and temporarily duplicated the\r\n`applicationCloseDate` field under `applicationCloseDateUTC` to be\r\nconsistent.\r\n\r\nBy storing these dates solely on the API, we can return to a single\r\nsource of truth and by storing them as datetimestamps rather than\r\nstrings, we can easily convert them into whatever format we need on the\r\nfrontend. It also leads us towards being able to submit these days e.g.\r\nvia the admin frontend, leading to management of more framework\r\nconfiguration by non-devs.\r\n\r\nWe will remove `dates.yml` files eventually, as the fields added here\r\nreplace all of the dates we store. See:\r\nhttps://github.com/alphagov/digitalmarketplace-frameworks/blob/e1f8e5c4a1a98d817e1bc9ff90ace85c1a0762c6/frameworks/g-cloud-10/messages/dates.yml\r\n\r\nFollow-up PRs intend to make these non-nullable fields. We can enter\r\nprovisional dates before we pin down a timetable, as we currently do in\r\nthe frameworks repository, but as things in the frontend depend on dates\r\nbeing available, it feels far safer to require that *some* date is\r\nprovided rather than not.","created_at":"2018-04-24T14:10:07Z","updated_at":"2018-05-03T10:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7af6cfa434d321aaddbd6a128c7b885dcc1422ac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benvand","id":3469840,"avatar_url":"https://avatars0.githubusercontent.com/u/3469840?v=4","gravatar_id":"","url":"https://api.github.com/users/benvand","html_url":"https://github.com/benvand","followers_url":"https://api.github.com/users/benvand/followers","following_url":"https://api.github.com/users/benvand/following{/other_user}","gists_url":"https://api.github.com/users/benvand/gists{/gist_id}","starred_url":"https://api.github.com/users/benvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvand/subscriptions","organizations_url":"https://api.github.com/users/benvand/orgs","repos_url":"https://api.github.com/users/benvand/repos","events_url":"https://api.github.com/users/benvand/events{/privacy}","received_events_url":"https://api.github.com/users/benvand/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/776/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/statuses/51b4122a566931aab37cd625fe092ff70f2d56b7","head":{"label":"alphagov:shw-add-framework-dates","ref":"shw-add-framework-dates","sha":"51b4122a566931aab37cd625fe092ff70f2d56b7","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":26963583,"name":"digitalmarketplace-api","full_name":"alphagov/digitalmarketplace-api","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-api","description":"Digital Marketplace API.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/deployments","created_at":"2014-11-21T14:41:36Z","updated_at":"2018-04-26T07:54:08Z","pushed_at":"2018-05-03T09:09:25Z","git_url":"git://github.com/alphagov/digitalmarketplace-api.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-api.git","clone_url":"https://github.com/alphagov/digitalmarketplace-api.git","svn_url":"https://github.com/alphagov/digitalmarketplace-api","homepage":null,"size":3737,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":4,"watchers":12,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a7f7d2adbcb7af7d51d5eba3da259f819c9108ad","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":26963583,"name":"digitalmarketplace-api","full_name":"alphagov/digitalmarketplace-api","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-api","description":"Digital Marketplace API.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/deployments","created_at":"2014-11-21T14:41:36Z","updated_at":"2018-04-26T07:54:08Z","pushed_at":"2018-05-03T09:09:25Z","git_url":"git://github.com/alphagov/digitalmarketplace-api.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-api.git","clone_url":"https://github.com/alphagov/digitalmarketplace-api.git","svn_url":"https://github.com/alphagov/digitalmarketplace-api","homepage":null,"size":3737,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-api/pull/776"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/776"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/776/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/776/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-api/statuses/51b4122a566931aab37cd625fe092ff70f2d56b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Wynndow"}}