{"action":"opened","number":325,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/325","id":238567039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTY3MDM5","html_url":"https://github.com/KhronosGroup/UnityGLTF/pull/325","diff_url":"https://github.com/KhronosGroup/UnityGLTF/pull/325.diff","patch_url":"https://github.com/KhronosGroup/UnityGLTF/pull/325.patch","issue_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/325","number":325,"state":"open","locked":false,"title":"Add error handling to scene loading, refactor WebRequestLoader","user":{"login":"stevenvergenz","id":1882376,"node_id":"MDQ6VXNlcjE4ODIzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1882376?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenvergenz","html_url":"https://github.com/stevenvergenz","followers_url":"https://api.github.com/users/stevenvergenz/followers","following_url":"https://api.github.com/users/stevenvergenz/following{/other_user}","gists_url":"https://api.github.com/users/stevenvergenz/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenvergenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenvergenz/subscriptions","organizations_url":"https://api.github.com/users/stevenvergenz/orgs","repos_url":"https://api.github.com/users/stevenvergenz/repos","events_url":"https://api.github.com/users/stevenvergenz/events{/privacy}","received_events_url":"https://api.github.com/users/stevenvergenz/received_events","type":"User","site_admin":false},"body":"This PR adds an exception argument to the LoadScene callbacks, which are invoked even if the load/parse/import process fails.\r\n\r\nIt also refactors WebRequestLoader to use System.Net.Http instead of UnityWebRequest. This way we don't have to convert to and from Coroutines, but run directly with Tasks. It has the added benefit of playing better with the above exception handling system.","created_at":"2018-12-13T23:34:13Z","updated_at":"2018-12-13T23:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/325/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/325/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/325/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/cf57ea5c48d0b66a9905c6239cacecdf3707b52e","head":{"label":"KhronosGroup:fix/load-failure-handling","ref":"fix/load-failure-handling","sha":"cf57ea5c48d0b66a9905c6239cacecdf3707b52e","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":84389723,"node_id":"MDEwOlJlcG9zaXRvcnk4NDM4OTcyMw==","name":"UnityGLTF","full_name":"KhronosGroup/UnityGLTF","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/UnityGLTF","description":"Runtime GLTF Loader for Unity3D","fork":false,"url":"https://api.github.com/repos/KhronosGroup/UnityGLTF","forks_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/forks","keys_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/events","assignees_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/merges","archive_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/deployments","created_at":"2017-03-09T02:40:28Z","updated_at":"2018-12-13T08:14:07Z","pushed_at":"2018-12-13T23:31:21Z","git_url":"git://github.com/KhronosGroup/UnityGLTF.git","ssh_url":"git@github.com:KhronosGroup/UnityGLTF.git","clone_url":"https://github.com/KhronosGroup/UnityGLTF.git","svn_url":"https://github.com/KhronosGroup/UnityGLTF","homepage":null,"size":181730,"stargazers_count":320,"watchers_count":320,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":115,"open_issues":122,"watchers":320,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"4446a51aab4d34e71599c0b4edad8ac87267ad86","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":84389723,"node_id":"MDEwOlJlcG9zaXRvcnk4NDM4OTcyMw==","name":"UnityGLTF","full_name":"KhronosGroup/UnityGLTF","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/UnityGLTF","description":"Runtime GLTF Loader for Unity3D","fork":false,"url":"https://api.github.com/repos/KhronosGroup/UnityGLTF","forks_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/forks","keys_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/events","assignees_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/merges","archive_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/UnityGLTF/deployments","created_at":"2017-03-09T02:40:28Z","updated_at":"2018-12-13T08:14:07Z","pushed_at":"2018-12-13T23:31:21Z","git_url":"git://github.com/KhronosGroup/UnityGLTF.git","ssh_url":"git@github.com:KhronosGroup/UnityGLTF.git","clone_url":"https://github.com/KhronosGroup/UnityGLTF.git","svn_url":"https://github.com/KhronosGroup/UnityGLTF","homepage":null,"size":181730,"stargazers_count":320,"watchers_count":320,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":115,"open_issues":122,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/325"},"html":{"href":"https://github.com/KhronosGroup/UnityGLTF/pull/325"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/325"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/UnityGLTF/statuses/cf57ea5c48d0b66a9905c6239cacecdf3707b52e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":52,"deletions":46,"changed_files":8}}
{"actor":{"display_login":"stevenvergenz"}}