{"action":"created","issue":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1079","repository_url":"https://api.github.com/repos/uktrade/data-hub-leeloo","labels_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1079/labels{/name}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1079/comments","events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1079/events","html_url":"https://github.com/uktrade/data-hub-leeloo/pull/1079","id":352300726,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjQ2OTkx","number":1079,"title":"Fix streaming to AV service and use of V2 API.","user":{"login":"elcct","id":5889630,"node_id":"MDQ6VXNlcjU4ODk2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5889630?v=4","gravatar_id":"","url":"https://api.github.com/users/elcct","html_url":"https://github.com/elcct","followers_url":"https://api.github.com/users/elcct/followers","following_url":"https://api.github.com/users/elcct/following{/other_user}","gists_url":"https://api.github.com/users/elcct/gists{/gist_id}","starred_url":"https://api.github.com/users/elcct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elcct/subscriptions","organizations_url":"https://api.github.com/users/elcct/orgs","repos_url":"https://api.github.com/users/elcct/repos","events_url":"https://api.github.com/users/elcct/events{/privacy}","received_events_url":"https://api.github.com/users/elcct/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-20T21:20:10Z","updated_at":"2018-08-20T21:20:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1079","html_url":"https://github.com/uktrade/data-hub-leeloo/pull/1079","diff_url":"https://github.com/uktrade/data-hub-leeloo/pull/1079.diff","patch_url":"https://github.com/uktrade/data-hub-leeloo/pull/1079.patch"},"body":"### Description of change\r\n\r\nThis fixes streaming of the file to AV service. `StreamingIterator` was incorrectly used as it is apparently doesn't update its `len` property. A custom wrapper is being used instead with an added test to check if the file is being encoded correctly.\r\nThis update also contains a change to use V2 version of the AV API.\r\n\r\n### Checklist\r\n\r\n* [X] Has the README been updated (if needed)?\r\n"},"comment":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/comments/414467047","html_url":"https://github.com/uktrade/data-hub-leeloo/pull/1079#issuecomment-414467047","issue_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1079","id":414467047,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQ2NzA0Nw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T21:20:18Z","updated_at":"2018-08-20T21:20:18Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=h1) Report\n> Merging [#1079](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=desc) into [develop](https://codecov.io/gh/uktrade/data-hub-leeloo/commit/503fe0b575e3e1be8e9ad75f10750dea602239b2?src=pr&el=desc) will **decrease** coverage by `0.04%`.\n> The diff coverage is `91.66%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079/graphs/tree.svg?width=650&height=150&src=pr&token=z6j0orunPK)](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           develop   #1079      +/-   ##\n==========================================\n- Coverage    96.45%   96.4%   -0.05%     \n==========================================\n  Files          220     218       -2     \n  Lines         6227    6210      -17     \n  Branches       593     591       -2     \n==========================================\n- Hits          6006    5987      -19     \n- Misses         153     154       +1     \n- Partials        68      69       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [datahub/documents/av\\_scan.py](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079/diff?src=pr&el=tree#diff-ZGF0YWh1Yi9kb2N1bWVudHMvYXZfc2Nhbi5weQ==) | `92.45% <91.66%> (+1.97%)` | :arrow_up: |\n| [datahub/search/views.py](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079/diff?src=pr&el=tree#diff-ZGF0YWh1Yi9zZWFyY2gvdmlld3MucHk=) | `94.81% <0%> (-1.49%)` | :arrow_down: |\n| [datahub/search/investment/views.py](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079/diff?src=pr&el=tree#diff-ZGF0YWh1Yi9zZWFyY2gvaW52ZXN0bWVudC92aWV3cy5weQ==) | `100% <0%> (ø)` | :arrow_up: |\n| [datahub/investment/query\\_utils.py](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079/diff?src=pr&el=tree#diff-ZGF0YWh1Yi9pbnZlc3RtZW50L3F1ZXJ5X3V0aWxzLnB5) | | |\n| [datahub/core/query\\_utils.py](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079/diff?src=pr&el=tree#diff-ZGF0YWh1Yi9jb3JlL3F1ZXJ5X3V0aWxzLnB5) | | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=footer). Last update [503fe0b...cfb5570](https://codecov.io/gh/uktrade/data-hub-leeloo/pull/1079?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}