{"action":"created","comment":{"url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/comments/213895866","pull_request_review_id":150828218,"id":213895866,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzg5NTg2Ng==","diff_hunk":"@@ -11,18 +11,27 @@ public static class ConfigurationService\n     {\n         private static IConfigurationProvider _configurationProvider;\n         private static TemplateWriterSettings templateWriterSettings = null;\n-\n-        public static void Initialize(IConfigurationProvider configurationProvider)\n+        private static string targetLanguage = null;\n+        public static void Initialize(IConfigurationProvider configurationProvider, string targetLanguage = null)\n         {\n             _configurationProvider = configurationProvider;\n+            if (!String.IsNullOrEmpty(targetLanguage))\n+            {\n+                ConfigurationService.targetLanguage = targetLanguage;\n+            }\n         }\n \n         private static TemplateWriterSettings LoadSettingsForLanguage()\n         {\n             TemplateWriterSettings mainTWS = _configurationProvider.GetConfiguration<TemplateWriterSettings>();","path":"src/GraphODataTemplateWriter/Settings/ConfigurationService.cs","position":18,"original_position":18,"commit_id":"53ea1ce8ce34ac11f6af764b05356f08dd0cd74e","original_commit_id":"53ea1ce8ce34ac11f6af764b05356f08dd0cd74e","user":{"login":"darrelmiller","id":447694,"node_id":"MDQ6VXNlcjQ0NzY5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/447694?v=4","gravatar_id":"","url":"https://api.github.com/users/darrelmiller","html_url":"https://github.com/darrelmiller","followers_url":"https://api.github.com/users/darrelmiller/followers","following_url":"https://api.github.com/users/darrelmiller/following{/other_user}","gists_url":"https://api.github.com/users/darrelmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/darrelmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrelmiller/subscriptions","organizations_url":"https://api.github.com/users/darrelmiller/orgs","repos_url":"https://api.github.com/users/darrelmiller/repos","events_url":"https://api.github.com/users/darrelmiller/events{/privacy}","received_events_url":"https://api.github.com/users/darrelmiller/received_events","type":"User","site_admin":false},"body":"The options class has the default of CSharp so targetLanguage should never be empty.  So we should never use the value in the settings file.","created_at":"2018-08-30T03:42:54Z","updated_at":"2018-08-30T03:42:55Z","html_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/143#discussion_r213895866","pull_request_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/comments/213895866"},"html":{"href":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/143#discussion_r213895866"},"pull_request":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143"}},"in_reply_to_id":213519137},"pull_request":{"url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143","id":208452973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDUyOTcz","html_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/143","diff_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/143.diff","patch_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/143.patch","issue_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues/143","number":143,"state":"open","locked":false,"title":"Added new command line exe for SDK generation","user":{"login":"darrelmiller","id":447694,"node_id":"MDQ6VXNlcjQ0NzY5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/447694?v=4","gravatar_id":"","url":"https://api.github.com/users/darrelmiller","html_url":"https://github.com/darrelmiller","followers_url":"https://api.github.com/users/darrelmiller/followers","following_url":"https://api.github.com/users/darrelmiller/following{/other_user}","gists_url":"https://api.github.com/users/darrelmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/darrelmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrelmiller/subscriptions","organizations_url":"https://api.github.com/users/darrelmiller/orgs","repos_url":"https://api.github.com/users/darrelmiller/repos","events_url":"https://api.github.com/users/darrelmiller/events{/privacy}","received_events_url":"https://api.github.com/users/darrelmiller/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-15T01:37:41Z","updated_at":"2018-08-30T03:42:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90a2bcec428b8bcef71f7305b8463dcb96af9c86","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rohitramu","id":8553814,"node_id":"MDQ6VXNlcjg1NTM4MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8553814?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitramu","html_url":"https://github.com/rohitramu","followers_url":"https://api.github.com/users/rohitramu/followers","following_url":"https://api.github.com/users/rohitramu/following{/other_user}","gists_url":"https://api.github.com/users/rohitramu/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitramu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitramu/subscriptions","organizations_url":"https://api.github.com/users/rohitramu/orgs","repos_url":"https://api.github.com/users/rohitramu/repos","events_url":"https://api.github.com/users/rohitramu/events{/privacy}","received_events_url":"https://api.github.com/users/rohitramu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1024615867,"node_id":"MDU6TGFiZWwxMDI0NjE1ODY3","url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143/commits","review_comments_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143/comments","review_comment_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues/143/comments","statuses_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/statuses/53ea1ce8ce34ac11f6af764b05356f08dd0cd74e","head":{"label":"darrelmiller:dev","ref":"dev","sha":"53ea1ce8ce34ac11f6af764b05356f08dd0cd74e","user":{"login":"darrelmiller","id":447694,"node_id":"MDQ6VXNlcjQ0NzY5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/447694?v=4","gravatar_id":"","url":"https://api.github.com/users/darrelmiller","html_url":"https://github.com/darrelmiller","followers_url":"https://api.github.com/users/darrelmiller/followers","following_url":"https://api.github.com/users/darrelmiller/following{/other_user}","gists_url":"https://api.github.com/users/darrelmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/darrelmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrelmiller/subscriptions","organizations_url":"https://api.github.com/users/darrelmiller/orgs","repos_url":"https://api.github.com/users/darrelmiller/repos","events_url":"https://api.github.com/users/darrelmiller/events{/privacy}","received_events_url":"https://api.github.com/users/darrelmiller/received_events","type":"User","site_admin":false},"repo":{"id":142693894,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2OTM4OTQ=","name":"MSGraph-SDK-Code-Generator","full_name":"darrelmiller/MSGraph-SDK-Code-Generator","owner":{"login":"darrelmiller","id":447694,"node_id":"MDQ6VXNlcjQ0NzY5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/447694?v=4","gravatar_id":"","url":"https://api.github.com/users/darrelmiller","html_url":"https://github.com/darrelmiller","followers_url":"https://api.github.com/users/darrelmiller/followers","following_url":"https://api.github.com/users/darrelmiller/following{/other_user}","gists_url":"https://api.github.com/users/darrelmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/darrelmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrelmiller/subscriptions","organizations_url":"https://api.github.com/users/darrelmiller/orgs","repos_url":"https://api.github.com/users/darrelmiller/repos","events_url":"https://api.github.com/users/darrelmiller/events{/privacy}","received_events_url":"https://api.github.com/users/darrelmiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrelmiller/MSGraph-SDK-Code-Generator","description":"MSGraph SDK Code Generator","fork":true,"url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator","forks_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/forks","keys_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/teams","hooks_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/hooks","issue_events_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/issues/events{/number}","events_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/events","assignees_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/assignees{/user}","branches_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/branches{/branch}","tags_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/tags","blobs_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/statuses/{sha}","languages_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/languages","stargazers_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/stargazers","contributors_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/contributors","subscribers_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/subscribers","subscription_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/subscription","commits_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/contents/{+path}","compare_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/merges","archive_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/downloads","issues_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/issues{/number}","pulls_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/pulls{/number}","milestones_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/milestones{/number}","notifications_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/labels{/name}","releases_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/releases{/id}","deployments_url":"https://api.github.com/repos/darrelmiller/MSGraph-SDK-Code-Generator/deployments","created_at":"2018-07-28T16:45:27Z","updated_at":"2018-08-28T04:28:24Z","pushed_at":"2018-08-28T04:28:22Z","git_url":"git://github.com/darrelmiller/MSGraph-SDK-Code-Generator.git","ssh_url":"git@github.com:darrelmiller/MSGraph-SDK-Code-Generator.git","clone_url":"https://github.com/darrelmiller/MSGraph-SDK-Code-Generator.git","svn_url":"https://github.com/darrelmiller/MSGraph-SDK-Code-Generator","homepage":"","size":5065,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"microsoftgraph:dev","ref":"dev","sha":"503f2007bc21051412348bc6c58e52636309ad78","user":{"login":"microsoftgraph","id":17304259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzA0MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/17304259?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoftgraph","html_url":"https://github.com/microsoftgraph","followers_url":"https://api.github.com/users/microsoftgraph/followers","following_url":"https://api.github.com/users/microsoftgraph/following{/other_user}","gists_url":"https://api.github.com/users/microsoftgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftgraph/subscriptions","organizations_url":"https://api.github.com/users/microsoftgraph/orgs","repos_url":"https://api.github.com/users/microsoftgraph/repos","events_url":"https://api.github.com/users/microsoftgraph/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":54446046,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQ0NjA0Ng==","name":"MSGraph-SDK-Code-Generator","full_name":"microsoftgraph/MSGraph-SDK-Code-Generator","owner":{"login":"microsoftgraph","id":17304259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzA0MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/17304259?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoftgraph","html_url":"https://github.com/microsoftgraph","followers_url":"https://api.github.com/users/microsoftgraph/followers","following_url":"https://api.github.com/users/microsoftgraph/following{/other_user}","gists_url":"https://api.github.com/users/microsoftgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftgraph/subscriptions","organizations_url":"https://api.github.com/users/microsoftgraph/orgs","repos_url":"https://api.github.com/users/microsoftgraph/repos","events_url":"https://api.github.com/users/microsoftgraph/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator","description":"MSGraph SDK Code Generator","fork":false,"url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator","forks_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/forks","keys_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/teams","hooks_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/hooks","issue_events_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues/events{/number}","events_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/events","assignees_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/assignees{/user}","branches_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/branches{/branch}","tags_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/tags","blobs_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/languages","stargazers_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/stargazers","contributors_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/contributors","subscribers_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/subscribers","subscription_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/subscription","commits_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/contents/{+path}","compare_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/merges","archive_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/downloads","issues_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues{/number}","pulls_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/labels{/name}","releases_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/releases{/id}","deployments_url":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/deployments","created_at":"2016-03-22T04:51:25Z","updated_at":"2018-08-29T07:45:03Z","pushed_at":"2018-08-29T07:45:01Z","git_url":"git://github.com/microsoftgraph/MSGraph-SDK-Code-Generator.git","ssh_url":"git@github.com:microsoftgraph/MSGraph-SDK-Code-Generator.git","clone_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator.git","svn_url":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator","homepage":"","size":5161,"stargazers_count":22,"watchers_count":22,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":6,"watchers":22,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143"},"html":{"href":"https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/143"},"issue":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues/143"},"comments":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/microsoftgraph/MSGraph-SDK-Code-Generator/statuses/53ea1ce8ce34ac11f6af764b05356f08dd0cd74e"}},"author_association":"NONE"}}
{"actor":{"display_login":"darrelmiller"}}