{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/222035332","pull_request_review_id":160827545,"id":222035332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjAzNTMzMg==","diff_hunk":"@@ -122,18 +123,20 @@ separator nonempty Case \"\" ;\n -- Name Declarations.\n -- Eventually will have IOPairs.\n NameDeclSimpl. NameDecl ::= Var ;\n-NameDeclUrn. NameDecl ::= Var \"(\" Uri \")\" ;\n+NameDeclUrn. NameDecl ::= Var \"(\" UriLiteral \")\" ;\n separator nonempty NameDecl \",\" ;\n \n -- Booleans:\n-BoolTrue.   Bool ::= \"true\" ;\n-BoolFalse.  Bool ::= \"false\" ;\n+BoolTrue.   BoolLiteral ::= \"true\" ;\n+BoolFalse.  BoolLiteral ::= \"false\" ;\n -- Ground types:\n-GroundBool.    Ground ::= Bool ;\n-GroundInt.     Ground ::= Long ;\n-GroundString.  Ground ::= String ;\n-GroundUri.     Ground ::= Uri ;\n-token Uri ('`' ((char - [\"\\\\`\"]) | ('\\\\' [\"`\\\\\"]))* '`') ;\n+-- The \"Literal\" suffix avoids collisions with Simple Types\n+GroundBool.    Ground ::= BoolLiteral ;\n+GroundInt.     Ground ::= LongLiteral ;\n+GroundString.  Ground ::= StringLiteral ;\n+GroundUri.     Ground ::= UriLiteral ;\n+token StringLiteral ( '\"' ((char - [\"\\\"\\\\\"]) | ('\\\\' [\"\\\"\\\\nt\"]))* '\"' );","path":"rholang/src/main/bnfc/rholang_mercury.cf","position":34,"original_position":34,"commit_id":"607de1d7ddce140ddee6d5258f0e9d703567ffdd","original_commit_id":"607de1d7ddce140ddee6d5258f0e9d703567ffdd","user":{"login":"goral09","id":5120801,"node_id":"MDQ6VXNlcjUxMjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false},"body":"`StringLiteral` is not the same as `UriLiteral`.","created_at":"2018-10-02T17:08:15Z","updated_at":"2018-10-02T17:08:15Z","html_url":"https://github.com/rchain/rchain/pull/1600#discussion_r222035332","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/1600","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/222035332"},"html":{"href":"https://github.com/rchain/rchain/pull/1600#discussion_r222035332"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1600"}}},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1600","id":219774894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Nzc0ODk0","html_url":"https://github.com/rchain/rchain/pull/1600","diff_url":"https://github.com/rchain/rchain/pull/1600.diff","patch_url":"https://github.com/rchain/rchain/pull/1600.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1600","number":1600,"state":"open","locked":false,"title":"renamed some symbols in rholang bnfc","user":{"login":"justinmeiners","id":3220045,"node_id":"MDQ6VXNlcjMyMjAwNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3220045?v=4","gravatar_id":"","url":"https://api.github.com/users/justinmeiners","html_url":"https://github.com/justinmeiners","followers_url":"https://api.github.com/users/justinmeiners/followers","following_url":"https://api.github.com/users/justinmeiners/following{/other_user}","gists_url":"https://api.github.com/users/justinmeiners/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmeiners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmeiners/subscriptions","organizations_url":"https://api.github.com/users/justinmeiners/orgs","repos_url":"https://api.github.com/users/justinmeiners/repos","events_url":"https://api.github.com/users/justinmeiners/events{/privacy}","received_events_url":"https://api.github.com/users/justinmeiners/received_events","type":"User","site_admin":false},"body":"## Overview\r\nCryptofex needs a C++ parser generated from BNFC. Unfortunately there is a bug with this backend. This bug is caused by having Token symbols with the same content as non-terminal symbol names.\r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nThis is not an Rchain issue. This is a cryptofex issue. I [filed a bug with BNFC](https://github.com/BNFC/bnfc/issues/235)\r\n\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] You assigned one person to review this PR\r\n\r\n### If you are not a member of the core development team, please confirm:\r\n- [x] You signed the commit. Merging requires a signature. Please see the [developer wiki](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain) for instructions.\r\n- [x] Your GitHub account is also an account with [Travis CI](https://travis-ci.org). Unit tests will not run on your PR unless you have an account with Travis. Merge requires passed unit tests.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n\r\nIf this disrupts Rchain, we can always maintain our own version until the bug is fixed by BNFC.\r\n","created_at":"2018-10-02T16:55:02Z","updated_at":"2018-10-02T17:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"521c05c4ce8d6c9c6129139a06e79ba634963758","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/1600/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/1600/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1600/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/607de1d7ddce140ddee6d5258f0e9d703567ffdd","head":{"label":"justinmeiners:dev","ref":"dev","sha":"607de1d7ddce140ddee6d5258f0e9d703567ffdd","user":{"login":"justinmeiners","id":3220045,"node_id":"MDQ6VXNlcjMyMjAwNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3220045?v=4","gravatar_id":"","url":"https://api.github.com/users/justinmeiners","html_url":"https://github.com/justinmeiners","followers_url":"https://api.github.com/users/justinmeiners/followers","following_url":"https://api.github.com/users/justinmeiners/following{/other_user}","gists_url":"https://api.github.com/users/justinmeiners/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmeiners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmeiners/subscriptions","organizations_url":"https://api.github.com/users/justinmeiners/orgs","repos_url":"https://api.github.com/users/justinmeiners/repos","events_url":"https://api.github.com/users/justinmeiners/events{/privacy}","received_events_url":"https://api.github.com/users/justinmeiners/received_events","type":"User","site_admin":false},"repo":{"id":145472104,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0NzIxMDQ=","name":"rchain","full_name":"justinmeiners/rchain","private":false,"owner":{"login":"justinmeiners","id":3220045,"node_id":"MDQ6VXNlcjMyMjAwNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3220045?v=4","gravatar_id":"","url":"https://api.github.com/users/justinmeiners","html_url":"https://github.com/justinmeiners","followers_url":"https://api.github.com/users/justinmeiners/followers","following_url":"https://api.github.com/users/justinmeiners/following{/other_user}","gists_url":"https://api.github.com/users/justinmeiners/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmeiners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmeiners/subscriptions","organizations_url":"https://api.github.com/users/justinmeiners/orgs","repos_url":"https://api.github.com/users/justinmeiners/repos","events_url":"https://api.github.com/users/justinmeiners/events{/privacy}","received_events_url":"https://api.github.com/users/justinmeiners/received_events","type":"User","site_admin":false},"html_url":"https://github.com/justinmeiners/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/justinmeiners/rchain","forks_url":"https://api.github.com/repos/justinmeiners/rchain/forks","keys_url":"https://api.github.com/repos/justinmeiners/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinmeiners/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinmeiners/rchain/teams","hooks_url":"https://api.github.com/repos/justinmeiners/rchain/hooks","issue_events_url":"https://api.github.com/repos/justinmeiners/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/justinmeiners/rchain/events","assignees_url":"https://api.github.com/repos/justinmeiners/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/justinmeiners/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/justinmeiners/rchain/tags","blobs_url":"https://api.github.com/repos/justinmeiners/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinmeiners/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinmeiners/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinmeiners/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinmeiners/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/justinmeiners/rchain/languages","stargazers_url":"https://api.github.com/repos/justinmeiners/rchain/stargazers","contributors_url":"https://api.github.com/repos/justinmeiners/rchain/contributors","subscribers_url":"https://api.github.com/repos/justinmeiners/rchain/subscribers","subscription_url":"https://api.github.com/repos/justinmeiners/rchain/subscription","commits_url":"https://api.github.com/repos/justinmeiners/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinmeiners/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinmeiners/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinmeiners/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinmeiners/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/justinmeiners/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinmeiners/rchain/merges","archive_url":"https://api.github.com/repos/justinmeiners/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinmeiners/rchain/downloads","issues_url":"https://api.github.com/repos/justinmeiners/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/justinmeiners/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/justinmeiners/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/justinmeiners/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinmeiners/rchain/labels{/name}","releases_url":"https://api.github.com/repos/justinmeiners/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/justinmeiners/rchain/deployments","created_at":"2018-08-20T21:25:38Z","updated_at":"2018-10-02T16:50:41Z","pushed_at":"2018-10-02T16:50:40Z","git_url":"git://github.com/justinmeiners/rchain.git","ssh_url":"git@github.com:justinmeiners/rchain.git","clone_url":"https://github.com/justinmeiners/rchain.git","svn_url":"https://github.com/justinmeiners/rchain","homepage":null,"size":14687,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"rchain:dev","ref":"dev","sha":"24e1a277de0e30e499fa22e1e0e67698cbeda264","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","private":false,"owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-10-02T15:05:55Z","pushed_at":"2018-10-02T16:55:02Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":17377,"stargazers_count":449,"watchers_count":449,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":125,"open_issues":23,"watchers":449,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1600"},"html":{"href":"https://github.com/rchain/rchain/pull/1600"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/1600"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/1600/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1600/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1600/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/607de1d7ddce140ddee6d5258f0e9d703567ffdd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"goral09"}}