{"action":"created","issue":{"url":"https://api.github.com/repos/lzybkr/PSReadLine/issues/590","repository_url":"https://api.github.com/repos/lzybkr/PSReadLine","labels_url":"https://api.github.com/repos/lzybkr/PSReadLine/issues/590/labels{/name}","comments_url":"https://api.github.com/repos/lzybkr/PSReadLine/issues/590/comments","events_url":"https://api.github.com/repos/lzybkr/PSReadLine/issues/590/events","html_url":"https://github.com/lzybkr/PSReadLine/issues/590","id":275955388,"node_id":"MDU6SXNzdWUyNzU5NTUzODg=","number":590,"title":"Sample smart quote won't insert quotes when sitting on parentheses/braces","user":{"login":"vr8hub","id":19378955,"node_id":"MDQ6VXNlcjE5Mzc4OTU1","avatar_url":"https://avatars1.githubusercontent.com/u/19378955?v=4","gravatar_id":"","url":"https://api.github.com/users/vr8hub","html_url":"https://github.com/vr8hub","followers_url":"https://api.github.com/users/vr8hub/followers","following_url":"https://api.github.com/users/vr8hub/following{/other_user}","gists_url":"https://api.github.com/users/vr8hub/gists{/gist_id}","starred_url":"https://api.github.com/users/vr8hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vr8hub/subscriptions","organizations_url":"https://api.github.com/users/vr8hub/orgs","repos_url":"https://api.github.com/users/vr8hub/repos","events_url":"https://api.github.com/users/vr8hub/events{/privacy}","received_events_url":"https://api.github.com/users/vr8hub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-22T06:12:28Z","updated_at":"2018-06-12T04:15:07Z","closed_at":null,"author_association":"NONE","body":"Environment data\r\n------------------\r\nPS version: 5.1.16299.19\r\nPSReadline version: 1.2\r\nos: 10.0.16299.15 (WinBuild.160101.0800)\r\nPS file version: 10.0.16299.15 (WinBuild.160101.0800)\r\n\r\nSteps to Reproduce\r\n--------------------\r\nThis may be WAD, but I thought I would ask. I searched all of the tickets that mentioned \"quote,\" but didn't see anything related to this.\r\n\r\nUsing the smart quote function in the sample profile (I'm testing with the sample profile as is, this time with the two using's, I promise :) ), it won't insert quotes when the cursor is setting on a parenthesis/brace. But sitting on one of those is pretty common, especially since the function itself often inserts a matching one.\r\n\r\nFor example, typing \"@{n=\" results in\r\n```\r\n@{n=}\r\n```\r\nwith the cursor sitting on the closing (right) brace. The next thing to type is a single quote, with the idea of having n='somename'. But, with the cursor hovering over that closing brace, the quote key does nothing (single or double, i.e. unshifted or shifted).\r\n\r\nI'm not sure if there's a reason for not inserting a quote (or pair of quotes) in that situation, or if it's just a bug. If it's a bug, no problem, I'll wait for the fix, but if it's considered WAD, could you give a bit more information on the logic of why that shouldn't work? It's a bit inconvenient to have to type a space and then left-arrow just to be able to type the quote. And this situation happens a *lot*, at least to me.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/lzybkr/PSReadLine/issues/comments/396460389","html_url":"https://github.com/lzybkr/PSReadLine/issues/590#issuecomment-396460389","issue_url":"https://api.github.com/repos/lzybkr/PSReadLine/issues/590","id":396460389,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjQ2MDM4OQ==","user":{"login":"felixfbecker","id":10532611,"node_id":"MDQ6VXNlcjEwNTMyNjEx","avatar_url":"https://avatars0.githubusercontent.com/u/10532611?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T04:15:07Z","updated_at":"2018-06-12T04:15:07Z","author_association":"NONE","body":"@vr8hub your fix doesn't work for me, or maybe I am applying it wrong. Could you give a full patch of what range you replaced?"}}
{"actor":{"display_login":"felixfbecker"}}