{"action":"opened","number":963,"pull_request":{"url":"https://api.github.com/repos/angular/tsickle/pulls/963","id":242235400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMjM1NDAw","html_url":"https://github.com/angular/tsickle/pull/963","diff_url":"https://github.com/angular/tsickle/pull/963.diff","patch_url":"https://github.com/angular/tsickle/pull/963.patch","issue_url":"https://api.github.com/repos/angular/tsickle/issues/963","number":963,"state":"open","locked":false,"title":"Emit types for arrow/function expressions.","user":{"login":"mprobst","id":7208,"node_id":"MDQ6VXNlcjcyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"Previously, tsickle did not emit types for arrow functions and function\r\nexpressions, mostly because it was too hard to correctly pipe the\r\ncomments through the parse-emit-parse again pipeline, before tsickle was\r\na proper transformer.\r\n\r\nThis change adds appropriate comments, and makes sure to parenthesize\r\nthe function expressions, to avoid triggering automatic semicolon\r\ninsertion.","created_at":"2019-01-04T11:15:30Z","updated_at":"2019-01-04T11:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/tsickle/pulls/963/commits","review_comments_url":"https://api.github.com/repos/angular/tsickle/pulls/963/comments","review_comment_url":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/tsickle/issues/963/comments","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/054f8af380eca941acb46fe753509ff37c661678","head":{"label":"angular:arrows-typed","ref":"arrows-typed","sha":"054f8af380eca941acb46fe753509ff37c661678","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-12-25T00:18:46Z","pushed_at":"2019-01-04T11:15:11Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":3217,"stargazers_count":547,"watchers_count":547,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":77,"open_issues":148,"watchers":547,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"06b1bfb93970884876131ade3e378c719bb4a5dc","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-12-25T00:18:46Z","pushed_at":"2019-01-04T11:15:11Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":3217,"stargazers_count":547,"watchers_count":547,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":77,"open_issues":148,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/963"},"html":{"href":"https://github.com/angular/tsickle/pull/963"},"issue":{"href":"https://api.github.com/repos/angular/tsickle/issues/963"},"comments":{"href":"https://api.github.com/repos/angular/tsickle/issues/963/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/tsickle/pulls/963/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/tsickle/pulls/963/commits"},"statuses":{"href":"https://api.github.com/repos/angular/tsickle/statuses/054f8af380eca941acb46fe753509ff37c661678"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":161,"deletions":28,"changed_files":16}}
{"actor":{"display_login":"mprobst"}}