{"action":"created","comment":{"url":"https://api.github.com/repos/gaul/s3proxy/pulls/comments/182119684","pull_request_review_id":112868381,"id":182119684,"diff_hunk":"@@ -373,6 +398,21 @@\n       <artifactId>jclouds-allblobstore</artifactId>\n       <version>${jclouds.version}</version>\n     </dependency>\n+    <dependency>","path":"pom.xml","position":62,"original_position":62,"commit_id":"416e8c8049698f4080052955b3de572bdafdab49","original_commit_id":"416e8c8049698f4080052955b3de572bdafdab49","user":{"login":"patduin","id":2090136,"avatar_url":"https://avatars3.githubusercontent.com/u/2090136?v=4","gravatar_id":"","url":"https://api.github.com/users/patduin","html_url":"https://github.com/patduin","followers_url":"https://api.github.com/users/patduin/followers","following_url":"https://api.github.com/users/patduin/following{/other_user}","gists_url":"https://api.github.com/users/patduin/gists{/gist_id}","starred_url":"https://api.github.com/users/patduin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patduin/subscriptions","organizations_url":"https://api.github.com/users/patduin/orgs","repos_url":"https://api.github.com/users/patduin/repos","events_url":"https://api.github.com/users/patduin/events{/privacy}","received_events_url":"https://api.github.com/users/patduin/received_events","type":"User","site_admin":false},"body":"had to add these otherwise I can't reference them in the shade plugin","created_at":"2018-04-17T15:38:47Z","updated_at":"2018-04-17T15:38:47Z","html_url":"https://github.com/gaul/s3proxy/pull/273#discussion_r182119684","pull_request_url":"https://api.github.com/repos/gaul/s3proxy/pulls/273","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gaul/s3proxy/pulls/comments/182119684"},"html":{"href":"https://github.com/gaul/s3proxy/pull/273#discussion_r182119684"},"pull_request":{"href":"https://api.github.com/repos/gaul/s3proxy/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/gaul/s3proxy/pulls/273","id":182207405,"html_url":"https://github.com/gaul/s3proxy/pull/273","diff_url":"https://github.com/gaul/s3proxy/pull/273.diff","patch_url":"https://github.com/gaul/s3proxy/pull/273.patch","issue_url":"https://api.github.com/repos/gaul/s3proxy/issues/273","number":273,"state":"open","locked":false,"title":"shading guava/jclouds","user":{"login":"patduin","id":2090136,"avatar_url":"https://avatars3.githubusercontent.com/u/2090136?v=4","gravatar_id":"","url":"https://api.github.com/users/patduin","html_url":"https://github.com/patduin","followers_url":"https://api.github.com/users/patduin/followers","following_url":"https://api.github.com/users/patduin/following{/other_user}","gists_url":"https://api.github.com/users/patduin/gists{/gist_id}","starred_url":"https://api.github.com/users/patduin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patduin/subscriptions","organizations_url":"https://api.github.com/users/patduin/orgs","repos_url":"https://api.github.com/users/patduin/repos","events_url":"https://api.github.com/users/patduin/events{/privacy}","received_events_url":"https://api.github.com/users/patduin/received_events","type":"User","site_admin":false},"body":"Hi :)\r\nFollowing discussions here: https://issues.apache.org/jira/browse/JCLOUDS-1225 and here: https://github.com/gaul/s3proxy/issues/209\r\nI made this PR that shades jclouds and shades/relocates guava. Our issue, as @massdosage described in JCLOUDS-1225, is that we got a dependency on hadoop which is on a rather old guava version conflicting with what s3proxy pulls in.\r\n\r\nFollowing the Jetty shading I've went for a similar solution with guava. I'll add some inline comments with explanations.\r\n\r\nHappy to have a discussion or make any changes.\r\n","created_at":"2018-04-17T15:35:57Z","updated_at":"2018-04-17T15:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b9a641a27d2f0f10e44db5fa231ba1a83080ff1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gaul/s3proxy/pulls/273/commits","review_comments_url":"https://api.github.com/repos/gaul/s3proxy/pulls/273/comments","review_comment_url":"https://api.github.com/repos/gaul/s3proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gaul/s3proxy/issues/273/comments","statuses_url":"https://api.github.com/repos/gaul/s3proxy/statuses/416e8c8049698f4080052955b3de572bdafdab49","head":{"label":"HotelsDotCom:guava-jclouds-shading","ref":"guava-jclouds-shading","sha":"416e8c8049698f4080052955b3de572bdafdab49","user":{"login":"HotelsDotCom","id":8900689,"avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"repo":{"id":121764219,"name":"s3proxy","full_name":"HotelsDotCom/s3proxy","owner":{"login":"HotelsDotCom","id":8900689,"avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HotelsDotCom/s3proxy","description":"Access other storage backends via the S3 API","fork":true,"url":"https://api.github.com/repos/HotelsDotCom/s3proxy","forks_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/forks","keys_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/teams","hooks_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/hooks","issue_events_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/issues/events{/number}","events_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/events","assignees_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/assignees{/user}","branches_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/branches{/branch}","tags_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/tags","blobs_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/languages","stargazers_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/stargazers","contributors_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/contributors","subscribers_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/subscribers","subscription_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/subscription","commits_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/contents/{+path}","compare_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/merges","archive_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/downloads","issues_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/issues{/number}","pulls_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/labels{/name}","releases_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/releases{/id}","deployments_url":"https://api.github.com/repos/HotelsDotCom/s3proxy/deployments","created_at":"2018-02-16T15:08:10Z","updated_at":"2018-04-17T13:55:31Z","pushed_at":"2018-04-17T14:11:57Z","git_url":"git://github.com/HotelsDotCom/s3proxy.git","ssh_url":"git@github.com:HotelsDotCom/s3proxy.git","clone_url":"https://github.com/HotelsDotCom/s3proxy.git","svn_url":"https://github.com/HotelsDotCom/s3proxy","homepage":"","size":1396,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gaul:master","ref":"master","sha":"8460bdea046895de378c0a2aff610a913f3d694d","user":{"login":"gaul","id":848247,"avatar_url":"https://avatars1.githubusercontent.com/u/848247?v=4","gravatar_id":"","url":"https://api.github.com/users/gaul","html_url":"https://github.com/gaul","followers_url":"https://api.github.com/users/gaul/followers","following_url":"https://api.github.com/users/gaul/following{/other_user}","gists_url":"https://api.github.com/users/gaul/gists{/gist_id}","starred_url":"https://api.github.com/users/gaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaul/subscriptions","organizations_url":"https://api.github.com/users/gaul/orgs","repos_url":"https://api.github.com/users/gaul/repos","events_url":"https://api.github.com/users/gaul/events{/privacy}","received_events_url":"https://api.github.com/users/gaul/received_events","type":"User","site_admin":false},"repo":{"id":22321368,"name":"s3proxy","full_name":"gaul/s3proxy","owner":{"login":"gaul","id":848247,"avatar_url":"https://avatars1.githubusercontent.com/u/848247?v=4","gravatar_id":"","url":"https://api.github.com/users/gaul","html_url":"https://github.com/gaul","followers_url":"https://api.github.com/users/gaul/followers","following_url":"https://api.github.com/users/gaul/following{/other_user}","gists_url":"https://api.github.com/users/gaul/gists{/gist_id}","starred_url":"https://api.github.com/users/gaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaul/subscriptions","organizations_url":"https://api.github.com/users/gaul/orgs","repos_url":"https://api.github.com/users/gaul/repos","events_url":"https://api.github.com/users/gaul/events{/privacy}","received_events_url":"https://api.github.com/users/gaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaul/s3proxy","description":"Access other storage backends via the S3 API","fork":false,"url":"https://api.github.com/repos/gaul/s3proxy","forks_url":"https://api.github.com/repos/gaul/s3proxy/forks","keys_url":"https://api.github.com/repos/gaul/s3proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaul/s3proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaul/s3proxy/teams","hooks_url":"https://api.github.com/repos/gaul/s3proxy/hooks","issue_events_url":"https://api.github.com/repos/gaul/s3proxy/issues/events{/number}","events_url":"https://api.github.com/repos/gaul/s3proxy/events","assignees_url":"https://api.github.com/repos/gaul/s3proxy/assignees{/user}","branches_url":"https://api.github.com/repos/gaul/s3proxy/branches{/branch}","tags_url":"https://api.github.com/repos/gaul/s3proxy/tags","blobs_url":"https://api.github.com/repos/gaul/s3proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaul/s3proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaul/s3proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaul/s3proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaul/s3proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/gaul/s3proxy/languages","stargazers_url":"https://api.github.com/repos/gaul/s3proxy/stargazers","contributors_url":"https://api.github.com/repos/gaul/s3proxy/contributors","subscribers_url":"https://api.github.com/repos/gaul/s3proxy/subscribers","subscription_url":"https://api.github.com/repos/gaul/s3proxy/subscription","commits_url":"https://api.github.com/repos/gaul/s3proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaul/s3proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaul/s3proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaul/s3proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaul/s3proxy/contents/{+path}","compare_url":"https://api.github.com/repos/gaul/s3proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaul/s3proxy/merges","archive_url":"https://api.github.com/repos/gaul/s3proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaul/s3proxy/downloads","issues_url":"https://api.github.com/repos/gaul/s3proxy/issues{/number}","pulls_url":"https://api.github.com/repos/gaul/s3proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/gaul/s3proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/gaul/s3proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaul/s3proxy/labels{/name}","releases_url":"https://api.github.com/repos/gaul/s3proxy/releases{/id}","deployments_url":"https://api.github.com/repos/gaul/s3proxy/deployments","created_at":"2014-07-27T20:32:24Z","updated_at":"2018-04-17T13:40:05Z","pushed_at":"2018-04-17T15:35:58Z","git_url":"git://github.com/gaul/s3proxy.git","ssh_url":"git@github.com:gaul/s3proxy.git","clone_url":"https://github.com/gaul/s3proxy.git","svn_url":"https://github.com/gaul/s3proxy","homepage":"","size":1391,"stargazers_count":604,"watchers_count":604,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":86,"open_issues":44,"watchers":604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gaul/s3proxy/pulls/273"},"html":{"href":"https://github.com/gaul/s3proxy/pull/273"},"issue":{"href":"https://api.github.com/repos/gaul/s3proxy/issues/273"},"comments":{"href":"https://api.github.com/repos/gaul/s3proxy/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/gaul/s3proxy/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/gaul/s3proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gaul/s3proxy/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/gaul/s3proxy/statuses/416e8c8049698f4080052955b3de572bdafdab49"}},"author_association":"NONE"}}
{"actor":{"display_login":"patduin"}}