{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/ecs/pulls/comments/229222168","pull_request_review_id":169665763,"id":229222168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTIyMjE2OA==","diff_hunk":"@@ -64,11 +64,11 @@ file.size,long,extended,\n file.target_path,keyword,extended,\n file.type,keyword,extended,\n file.uid,keyword,extended,\n-geo.city_name,keyword,core,\n-geo.continent_name,keyword,core,\n-geo.country_iso_code,keyword,core,\n-geo.location,geo_point,core,\n-geo.region_name,keyword,core,\n+geo.city_name,keyword,core,Montreal","path":"schema.csv","position":9,"original_position":9,"commit_id":"bb5ab0ce29965abde4ba17bb294441b1d7ce2292","original_commit_id":"bb5ab0ce29965abde4ba17bb294441b1d7ce2292","user":{"login":"ruflin","id":244900,"node_id":"MDQ6VXNlcjI0NDkwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/244900?v=4","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"Thanks for adding the example. Perhaps in the future make separate PR's for these changes as then we can get them in quickly and it becomes more obvious which parts in the auto generated files are affected by this PR.","created_at":"2018-10-30T09:03:02Z","updated_at":"2018-10-30T09:06:10Z","html_url":"https://github.com/elastic/ecs/pull/152#discussion_r229222168","pull_request_url":"https://api.github.com/repos/elastic/ecs/pulls/152","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/ecs/pulls/comments/229222168"},"html":{"href":"https://github.com/elastic/ecs/pull/152#discussion_r229222168"},"pull_request":{"href":"https://api.github.com/repos/elastic/ecs/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/ecs/pulls/152","id":225884870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODg0ODcw","html_url":"https://github.com/elastic/ecs/pull/152","diff_url":"https://github.com/elastic/ecs/pull/152.diff","patch_url":"https://github.com/elastic/ecs/pull/152.patch","issue_url":"https://api.github.com/repos/elastic/ecs/issues/152","number":152,"state":"open","locked":false,"title":"WIP Reuseable objects","user":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"body":"This PR aims at documenting which sets of fields are expected to be reused, and\r\nwhere. It's not complete yet, but it's taking shape:\r\n\r\n- [x] Add attributes in the YML files declaring which objects are meant to be\r\n  reused and where.\r\n- [x] Output text to that effect in the README. You can check it out on\r\n  [my branch here](https://github.com/webmat/ecs/tree/reuseable-objects#-geo-fields)\r\n- [ ] Maybe add a paragraph to `implementing.md` explaining the concept of object reuse?\r\n\r\nTo be done in a separate PR\r\n\r\n- Generate `template.json` according to where these objects are meant to be\r\n  reused.\r\n  - Nest everywhere it's expected.\r\n  - Remove from the top level for field sets where `top_level: false`\r\n- Add support for this in `use-cases.py` only when we need it.\r\n\r\nCloses #94","created_at":"2018-10-25T19:59:15Z","updated_at":"2018-10-30T09:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbc13c03f4f235f0436908ec4562b23cab09d148","assignee":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"assignees":[{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/ecs/pulls/152/commits","review_comments_url":"https://api.github.com/repos/elastic/ecs/pulls/152/comments","review_comment_url":"https://api.github.com/repos/elastic/ecs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/ecs/issues/152/comments","statuses_url":"https://api.github.com/repos/elastic/ecs/statuses/bb5ab0ce29965abde4ba17bb294441b1d7ce2292","head":{"label":"webmat:reuseable-objects","ref":"reuseable-objects","sha":"bb5ab0ce29965abde4ba17bb294441b1d7ce2292","user":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"repo":{"id":137914483,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MTQ0ODM=","name":"ecs","full_name":"webmat/ecs","private":false,"owner":{"login":"webmat","id":2300,"node_id":"MDQ6VXNlcjIzMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2300?v=4","gravatar_id":"","url":"https://api.github.com/users/webmat","html_url":"https://github.com/webmat","followers_url":"https://api.github.com/users/webmat/followers","following_url":"https://api.github.com/users/webmat/following{/other_user}","gists_url":"https://api.github.com/users/webmat/gists{/gist_id}","starred_url":"https://api.github.com/users/webmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmat/subscriptions","organizations_url":"https://api.github.com/users/webmat/orgs","repos_url":"https://api.github.com/users/webmat/repos","events_url":"https://api.github.com/users/webmat/events{/privacy}","received_events_url":"https://api.github.com/users/webmat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/webmat/ecs","description":"Elastic Common Schema","fork":true,"url":"https://api.github.com/repos/webmat/ecs","forks_url":"https://api.github.com/repos/webmat/ecs/forks","keys_url":"https://api.github.com/repos/webmat/ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmat/ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmat/ecs/teams","hooks_url":"https://api.github.com/repos/webmat/ecs/hooks","issue_events_url":"https://api.github.com/repos/webmat/ecs/issues/events{/number}","events_url":"https://api.github.com/repos/webmat/ecs/events","assignees_url":"https://api.github.com/repos/webmat/ecs/assignees{/user}","branches_url":"https://api.github.com/repos/webmat/ecs/branches{/branch}","tags_url":"https://api.github.com/repos/webmat/ecs/tags","blobs_url":"https://api.github.com/repos/webmat/ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmat/ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmat/ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmat/ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmat/ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/webmat/ecs/languages","stargazers_url":"https://api.github.com/repos/webmat/ecs/stargazers","contributors_url":"https://api.github.com/repos/webmat/ecs/contributors","subscribers_url":"https://api.github.com/repos/webmat/ecs/subscribers","subscription_url":"https://api.github.com/repos/webmat/ecs/subscription","commits_url":"https://api.github.com/repos/webmat/ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmat/ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmat/ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmat/ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmat/ecs/contents/{+path}","compare_url":"https://api.github.com/repos/webmat/ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmat/ecs/merges","archive_url":"https://api.github.com/repos/webmat/ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmat/ecs/downloads","issues_url":"https://api.github.com/repos/webmat/ecs/issues{/number}","pulls_url":"https://api.github.com/repos/webmat/ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/webmat/ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/webmat/ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmat/ecs/labels{/name}","releases_url":"https://api.github.com/repos/webmat/ecs/releases{/id}","deployments_url":"https://api.github.com/repos/webmat/ecs/deployments","created_at":"2018-06-19T16:00:57Z","updated_at":"2018-10-16T20:27:54Z","pushed_at":"2018-10-29T15:08:48Z","git_url":"git://github.com/webmat/ecs.git","ssh_url":"git@github.com:webmat/ecs.git","clone_url":"https://github.com/webmat/ecs.git","svn_url":"https://github.com/webmat/ecs","homepage":null,"size":297,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"b1f31ebc2a229438dc046e0c9e1906ba4be10aad","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":134683798,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2ODM3OTg=","name":"ecs","full_name":"elastic/ecs","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/ecs","description":"Elastic Common Schema","fork":false,"url":"https://api.github.com/repos/elastic/ecs","forks_url":"https://api.github.com/repos/elastic/ecs/forks","keys_url":"https://api.github.com/repos/elastic/ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/ecs/teams","hooks_url":"https://api.github.com/repos/elastic/ecs/hooks","issue_events_url":"https://api.github.com/repos/elastic/ecs/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/ecs/events","assignees_url":"https://api.github.com/repos/elastic/ecs/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/ecs/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/ecs/tags","blobs_url":"https://api.github.com/repos/elastic/ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/ecs/languages","stargazers_url":"https://api.github.com/repos/elastic/ecs/stargazers","contributors_url":"https://api.github.com/repos/elastic/ecs/contributors","subscribers_url":"https://api.github.com/repos/elastic/ecs/subscribers","subscription_url":"https://api.github.com/repos/elastic/ecs/subscription","commits_url":"https://api.github.com/repos/elastic/ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/ecs/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/ecs/merges","archive_url":"https://api.github.com/repos/elastic/ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/ecs/downloads","issues_url":"https://api.github.com/repos/elastic/ecs/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/ecs/labels{/name}","releases_url":"https://api.github.com/repos/elastic/ecs/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/ecs/deployments","created_at":"2018-05-24T08:16:29Z","updated_at":"2018-10-29T20:20:46Z","pushed_at":"2018-10-29T20:20:43Z","git_url":"git://github.com/elastic/ecs.git","ssh_url":"git@github.com:elastic/ecs.git","clone_url":"https://github.com/elastic/ecs.git","svn_url":"https://github.com/elastic/ecs","homepage":null,"size":199,"stargazers_count":90,"watchers_count":90,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":67,"license":null,"forks":26,"open_issues":67,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/ecs/pulls/152"},"html":{"href":"https://github.com/elastic/ecs/pull/152"},"issue":{"href":"https://api.github.com/repos/elastic/ecs/issues/152"},"comments":{"href":"https://api.github.com/repos/elastic/ecs/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/ecs/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/ecs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/ecs/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/ecs/statuses/bb5ab0ce29965abde4ba17bb294441b1d7ce2292"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ruflin"}}