{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rfcs/issues/2451","repository_url":"https://api.github.com/repos/rust-lang/rfcs","labels_url":"https://api.github.com/repos/rust-lang/rfcs/issues/2451/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rfcs/issues/2451/comments","events_url":"https://api.github.com/repos/rust-lang/rfcs/issues/2451/events","html_url":"https://github.com/rust-lang/rfcs/pull/2451","id":327885274,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTcwMTA2","number":2451,"title":"Re-Rebalancing Coherence","user":{"login":"sgrif","id":1529387,"node_id":"MDQ6VXNlcjE1MjkzODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1529387?v=4","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"labels":[{"id":302201869,"node_id":"MDU6TGFiZWwzMDIyMDE4Njk=","url":"https://api.github.com/repos/rust-lang/rfcs/labels/I-nominated","name":"I-nominated","color":"e11d21","default":false},{"id":211667886,"node_id":"MDU6TGFiZWwyMTE2Njc4ODY=","url":"https://api.github.com/repos/rust-lang/rfcs/labels/T-lang","name":"T-lang","color":"bfd4f2","default":false},{"id":921950520,"node_id":"MDU6TGFiZWw5MjE5NTA1MjA=","url":"https://api.github.com/repos/rust-lang/rfcs/labels/disposition-merge","name":"disposition-merge","color":"008800","default":false},{"id":631618415,"node_id":"MDU6TGFiZWw2MzE2MTg0MTU=","url":"https://api.github.com/repos/rust-lang/rfcs/labels/proposed-final-comment-period","name":"proposed-final-comment-period","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":47,"created_at":"2018-05-30T20:23:55Z","updated_at":"2018-09-20T13:47:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rfcs/pulls/2451","html_url":"https://github.com/rust-lang/rfcs/pull/2451","diff_url":"https://github.com/rust-lang/rfcs/pull/2451.diff","patch_url":"https://github.com/rust-lang/rfcs/pull/2451.patch"},"body":"RFC #1023 introduced rules that exclude impls which should clearly be\r\nvalid. It also used some ambiguous language around what is a breaking\r\nchange, that ended up being completely ignored and contradicted by #1105.\r\nThis RFC seeks to clarify what is or isn't a breaking change when it\r\ncomes to implementing an existing trait, and conservatively expands the\r\norphan rules to allow impls which do not violate coherence, and fit\r\nwithin the original goals of #1023.\r\n\r\n[Rendered](https://github.com/sgrif/rfcs/blob/sg-re-re-balancing-coherence/text/0000-re-rebalancing-coherence.md)"},"comment":{"url":"https://api.github.com/repos/rust-lang/rfcs/issues/comments/423189435","html_url":"https://github.com/rust-lang/rfcs/pull/2451#issuecomment-423189435","issue_url":"https://api.github.com/repos/rust-lang/rfcs/issues/2451","id":423189435,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzE4OTQzNQ==","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T13:47:18Z","updated_at":"2018-09-20T13:47:18Z","author_association":"CONTRIBUTOR","body":"@rfcbot concern clarify-semver\r\n\r\nIt's a minor thing, but I think we should clarify the changes that must be considered semver breaking, [as described in this comment](https://github.com/rust-lang/rfcs/pull/2451#issuecomment-423188235)."}}
{"actor":{"display_login":"nikomatsakis"}}