{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/prepack/issues/1945","repository_url":"https://api.github.com/repos/facebook/prepack","labels_url":"https://api.github.com/repos/facebook/prepack/issues/1945/labels{/name}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/1945/comments","events_url":"https://api.github.com/repos/facebook/prepack/issues/1945/events","html_url":"https://github.com/facebook/prepack/issues/1945","id":322453822,"node_id":"MDU6SXNzdWUzMjI0NTM4MjI=","number":1945,"title":"Try a simpler _generatorOfEffects approach","user":{"login":"NTillmann","id":6457462,"node_id":"MDQ6VXNlcjY0NTc0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6457462?v=4","gravatar_id":"","url":"https://api.github.com/users/NTillmann","html_url":"https://github.com/NTillmann","followers_url":"https://api.github.com/users/NTillmann/followers","following_url":"https://api.github.com/users/NTillmann/following{/other_user}","gists_url":"https://api.github.com/users/NTillmann/gists{/gist_id}","starred_url":"https://api.github.com/users/NTillmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTillmann/subscriptions","organizations_url":"https://api.github.com/users/NTillmann/orgs","repos_url":"https://api.github.com/users/NTillmann/repos","events_url":"https://api.github.com/users/NTillmann/events{/privacy}","received_events_url":"https://api.github.com/users/NTillmann/received_events","type":"User","site_admin":false},"labels":[{"id":279345227,"node_id":"MDU6TGFiZWwyNzkzNDUyMjc=","url":"https://api.github.com/repos/facebook/prepack/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-11T22:39:01Z","updated_at":"2018-06-26T18:36:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Collapse the effects tree of an optimized function similar to what happens at the program level;\r\nonly emit property/binding modifications for objects not created in the optimized function.\r\n\r\nWith the recent change to how the exceptional code path is emitted (#1889), the resulting code might not be too bad. We might need to do more work to reduce conditional expressions with common conditions to condition statements (#1946) to make it really shine.\r\n\r\nIf the visitor and serializer would no longer have to deal with applying and undoing effects, then that would Prepack's backend much simpler and more reliable."},"comment":{"url":"https://api.github.com/repos/facebook/prepack/issues/comments/400419313","html_url":"https://github.com/facebook/prepack/issues/1945#issuecomment-400419313","issue_url":"https://api.github.com/repos/facebook/prepack/issues/1945","id":400419313,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQxOTMxMw==","user":{"login":"NTillmann","id":6457462,"node_id":"MDQ6VXNlcjY0NTc0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6457462?v=4","gravatar_id":"","url":"https://api.github.com/users/NTillmann","html_url":"https://github.com/NTillmann","followers_url":"https://api.github.com/users/NTillmann/followers","following_url":"https://api.github.com/users/NTillmann/following{/other_user}","gists_url":"https://api.github.com/users/NTillmann/gists{/gist_id}","starred_url":"https://api.github.com/users/NTillmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTillmann/subscriptions","organizations_url":"https://api.github.com/users/NTillmann/orgs","repos_url":"https://api.github.com/users/NTillmann/repos","events_url":"https://api.github.com/users/NTillmann/events{/privacy}","received_events_url":"https://api.github.com/users/NTillmann/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T18:36:31Z","updated_at":"2018-06-26T18:36:31Z","author_association":"CONTRIBUTOR","body":"I am not sure how #1093 is relevant here. Unreferenced values should not be visited by anyone ever."}}
{"actor":{"display_login":"NTillmann"}}