{"action":"created","issue":{"url":"https://api.github.com/repos/josdejong/mathjs/issues/1146","repository_url":"https://api.github.com/repos/josdejong/mathjs","labels_url":"https://api.github.com/repos/josdejong/mathjs/issues/1146/labels{/name}","comments_url":"https://api.github.com/repos/josdejong/mathjs/issues/1146/comments","events_url":"https://api.github.com/repos/josdejong/mathjs/issues/1146/events","html_url":"https://github.com/josdejong/mathjs/issues/1146","id":335679850,"node_id":"MDU6SXNzdWUzMzU2Nzk4NTA=","number":1146,"title":"rationalize() throws exception for some input with decimals","user":{"login":"maruta","id":486675,"node_id":"MDQ6VXNlcjQ4NjY3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/486675?v=4","gravatar_id":"","url":"https://api.github.com/users/maruta","html_url":"https://github.com/maruta","followers_url":"https://api.github.com/users/maruta/followers","following_url":"https://api.github.com/users/maruta/following{/other_user}","gists_url":"https://api.github.com/users/maruta/gists{/gist_id}","starred_url":"https://api.github.com/users/maruta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maruta/subscriptions","organizations_url":"https://api.github.com/users/maruta/orgs","repos_url":"https://api.github.com/users/maruta/repos","events_url":"https://api.github.com/users/maruta/events{/privacy}","received_events_url":"https://api.github.com/users/maruta/received_events","type":"User","site_admin":false},"labels":[{"id":28569306,"node_id":"MDU6TGFiZWwyODU2OTMwNg==","url":"https://api.github.com/repos/josdejong/mathjs/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-06-26T06:45:26Z","updated_at":"2018-07-14T08:50:52Z","closed_at":"2018-07-07T11:09:22Z","author_association":"NONE","body":"rationalize() seems to fail for some input with decimals. \r\nSo far, I tested\r\n`math.rationalize('1/(0.1x+1)+1').toString()` \r\n-> throws exception\r\n`math.rationalize('1/(1.0x+1)+1').toString()`\r\n -> \"(x + 2) / (x + 1)\" OK  \r\n`math.rationalize('1/(0.1x+1)').toString()`\r\n -> \"10 / (x + 10)\" OK\r\nwith version 5.0.0.\r\n\r\nThanks!\r\n"},"comment":{"url":"https://api.github.com/repos/josdejong/mathjs/issues/comments/405009628","html_url":"https://github.com/josdejong/mathjs/issues/1146#issuecomment-405009628","issue_url":"https://api.github.com/repos/josdejong/mathjs/issues/1146","id":405009628,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTAwOTYyOA==","user":{"login":"josdejong","id":568626,"node_id":"MDQ6VXNlcjU2ODYyNg==","avatar_url":"https://avatars1.githubusercontent.com/u/568626?v=4","gravatar_id":"","url":"https://api.github.com/users/josdejong","html_url":"https://github.com/josdejong","followers_url":"https://api.github.com/users/josdejong/followers","following_url":"https://api.github.com/users/josdejong/following{/other_user}","gists_url":"https://api.github.com/users/josdejong/gists{/gist_id}","starred_url":"https://api.github.com/users/josdejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josdejong/subscriptions","organizations_url":"https://api.github.com/users/josdejong/orgs","repos_url":"https://api.github.com/users/josdejong/repos","events_url":"https://api.github.com/users/josdejong/events{/privacy}","received_events_url":"https://api.github.com/users/josdejong/received_events","type":"User","site_admin":false},"created_at":"2018-07-14T08:50:52Z","updated_at":"2018-07-14T08:50:52Z","author_association":"OWNER","body":"Thanks for your input @paulobuchsbaum . I don't fully understand all your points but if you can turn it into a PR it would be great!\r\n\r\n> @josdejong, can I make a new pull request? What branch?\r\n\r\nTo the `develop` branch. Note that there has been quite some refactoring going in v4 and v5, so please make sure your `develop` branch is up to date before implementing your suggested improvements."}}
{"actor":{"display_login":"josdejong"}}