{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/comments/168233522","pull_request_review_id":96567550,"id":168233522,"diff_hunk":"@@ -3,11 +3,30 @@\n RSpec.describe RummagerSearch, type: :model do\n   include ServicesRequestHelpers\n \n+  let(:content_id) { \"12345\" }\n+  let(:document_type) { \"guide\" }\n+  let(:search_all_content) { described_class.new(:content_id) }\n+  let(:search_document_type) { described_class.new(:content_id, :document_type) }\n+\n+  describe \"#initialize\" do\n+    it \"should be able initialize with only 1 parameter\" do\n+      expect(search_all_content).to be_instance_of(RummagerSearch)\n+      expect(search_all_content.content_id).to eq(:content_id)\n+      expect(search_all_content.document_type).to eq(nil)\n+    end\n+\n+    it \"should be able initialize with 2 parameter\" do","path":"spec/model/rummager_search_spec.rb","position":16,"original_position":16,"commit_id":"f38fd4409f80a79144c1ba0b5d932a19d6208272","original_commit_id":"cb58e7ce061c4529bcdbfedea35676a149ce4bb6","user":{"login":"fmlharrison","id":20514501,"avatar_url":"https://avatars1.githubusercontent.com/u/20514501?v=4","gravatar_id":"","url":"https://api.github.com/users/fmlharrison","html_url":"https://github.com/fmlharrison","followers_url":"https://api.github.com/users/fmlharrison/followers","following_url":"https://api.github.com/users/fmlharrison/following{/other_user}","gists_url":"https://api.github.com/users/fmlharrison/gists{/gist_id}","starred_url":"https://api.github.com/users/fmlharrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmlharrison/subscriptions","organizations_url":"https://api.github.com/users/fmlharrison/orgs","repos_url":"https://api.github.com/users/fmlharrison/repos","events_url":"https://api.github.com/users/fmlharrison/events{/privacy}","received_events_url":"https://api.github.com/users/fmlharrison/received_events","type":"User","site_admin":false},"body":"As discussed, I will remove these tests as it is testing the functionality of the framework, rather than our code. 😄  ","created_at":"2018-02-14T16:35:29Z","updated_at":"2018-02-14T16:35:29Z","html_url":"https://github.com/alphagov/govuk-topic-pages-prototype/pull/17#discussion_r168233522","pull_request_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/comments/168233522"},"html":{"href":"https://github.com/alphagov/govuk-topic-pages-prototype/pull/17#discussion_r168233522"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17"}},"in_reply_to_id":168224326},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17","id":169068545,"html_url":"https://github.com/alphagov/govuk-topic-pages-prototype/pull/17","diff_url":"https://github.com/alphagov/govuk-topic-pages-prototype/pull/17.diff","patch_url":"https://github.com/alphagov/govuk-topic-pages-prototype/pull/17.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/17","number":17,"state":"open","locked":false,"title":"Tagged content list page","user":{"login":"fmlharrison","id":20514501,"avatar_url":"https://avatars1.githubusercontent.com/u/20514501?v=4","gravatar_id":"","url":"https://api.github.com/users/fmlharrison","html_url":"https://github.com/fmlharrison","followers_url":"https://api.github.com/users/fmlharrison/followers","following_url":"https://api.github.com/users/fmlharrison/following{/other_user}","gists_url":"https://api.github.com/users/fmlharrison/gists{/gist_id}","starred_url":"https://api.github.com/users/fmlharrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmlharrison/subscriptions","organizations_url":"https://api.github.com/users/fmlharrison/orgs","repos_url":"https://api.github.com/users/fmlharrison/repos","events_url":"https://api.github.com/users/fmlharrison/events{/privacy}","received_events_url":"https://api.github.com/users/fmlharrison/received_events","type":"User","site_admin":false},"body":"https://govuk-topic-pages-protot-pr-17.herokuapp.com/\r\n\r\n![screen shot 2018-02-14 at 10 10 50](https://user-images.githubusercontent.com/20514501/36198791-79cf246e-116f-11e8-8d1f-0c7ffb55f9ed.png)\r\n\r\nThis is the PR for the work I did on creating tagged content list pages. These can be navigated to from a topic page after clicking on a \"See more\" link that each group of tagged content has. \r\n\r\nI was able to use routing constraints to keep make the decided url structure work.\r\n\r\nhttps://trello.com/c/58FxDRQk/59-add-a-see-all-link-that-takes-users-to-a-list-page-of-the-rest-of-the-content-in-each-supergroup","created_at":"2018-02-14T10:14:42Z","updated_at":"2018-02-14T16:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"762d6d3d5789f1674fcd376ec99e39c281a8d742","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/17/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/statuses/f38fd4409f80a79144c1ba0b5d932a19d6208272","head":{"label":"alphagov:tagged-content-list-page","ref":"tagged-content-list-page","sha":"f38fd4409f80a79144c1ba0b5d932a19d6208272","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":118772251,"name":"govuk-topic-pages-prototype","full_name":"alphagov/govuk-topic-pages-prototype","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-topic-pages-prototype","description":"The topic pages prototype","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype","forks_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/deployments","created_at":"2018-01-24T13:55:57Z","updated_at":"2018-01-24T14:56:43Z","pushed_at":"2018-02-14T14:33:27Z","git_url":"git://github.com/alphagov/govuk-topic-pages-prototype.git","ssh_url":"git@github.com:alphagov/govuk-topic-pages-prototype.git","clone_url":"https://github.com/alphagov/govuk-topic-pages-prototype.git","svn_url":"https://github.com/alphagov/govuk-topic-pages-prototype","homepage":"https://govuk-topic-pages-prototype.herokuapp.com.","size":2131,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f36985fea2141e7420922d08edd81186125f872d","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":118772251,"name":"govuk-topic-pages-prototype","full_name":"alphagov/govuk-topic-pages-prototype","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-topic-pages-prototype","description":"The topic pages prototype","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype","forks_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/deployments","created_at":"2018-01-24T13:55:57Z","updated_at":"2018-01-24T14:56:43Z","pushed_at":"2018-02-14T14:33:27Z","git_url":"git://github.com/alphagov/govuk-topic-pages-prototype.git","ssh_url":"git@github.com:alphagov/govuk-topic-pages-prototype.git","clone_url":"https://github.com/alphagov/govuk-topic-pages-prototype.git","svn_url":"https://github.com/alphagov/govuk-topic-pages-prototype","homepage":"https://govuk-topic-pages-prototype.herokuapp.com.","size":2131,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17"},"html":{"href":"https://github.com/alphagov/govuk-topic-pages-prototype/pull/17"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/17"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-topic-pages-prototype/statuses/f38fd4409f80a79144c1ba0b5d932a19d6208272"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fmlharrison"}}