{"action":"created","comment":{"url":"https://api.github.com/repos/ni/nimi-python/pulls/comments/189647242","pull_request_review_id":121860909,"id":189647242,"diff_hunk":"@@ -27,5 +27,6 @@\n     'repeated_capabilities': [\n         {'python_name': 'channels', 'prefix': '', },\n     ],\n+    'use_session_lock': True,","path":"src/nidcpower/metadata/config.py","position":4,"original_position":4,"commit_id":"742e785ab0dbba3896e9b58020c0dc2946884681","original_commit_id":"742e785ab0dbba3896e9b58020c0dc2946884681","user":{"login":"marcoskirsch","id":8085768,"avatar_url":"https://avatars0.githubusercontent.com/u/8085768?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoskirsch","html_url":"https://github.com/marcoskirsch","followers_url":"https://api.github.com/users/marcoskirsch/followers","following_url":"https://api.github.com/users/marcoskirsch/following{/other_user}","gists_url":"https://api.github.com/users/marcoskirsch/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoskirsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoskirsch/subscriptions","organizations_url":"https://api.github.com/users/marcoskirsch/orgs","repos_url":"https://api.github.com/users/marcoskirsch/repos","events_url":"https://api.github.com/users/marcoskirsch/events{/privacy}","received_events_url":"https://api.github.com/users/marcoskirsch/received_events","type":"User","site_admin":false},"body":"I don't think this is being used. Would be better not to have an extra piece of global metadata unless there's no better way.","created_at":"2018-05-21T16:47:27Z","updated_at":"2018-05-21T16:52:08Z","html_url":"https://github.com/ni/nimi-python/pull/846#discussion_r189647242","pull_request_url":"https://api.github.com/repos/ni/nimi-python/pulls/846","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/comments/189647242"},"html":{"href":"https://github.com/ni/nimi-python/pull/846#discussion_r189647242"},"pull_request":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/ni/nimi-python/pulls/846","id":185842092,"html_url":"https://github.com/ni/nimi-python/pull/846","diff_url":"https://github.com/ni/nimi-python/pull/846.diff","patch_url":"https://github.com/ni/nimi-python/pull/846.patch","issue_url":"https://api.github.com/repos/ni/nimi-python/issues/846","number":846,"state":"open","locked":false,"title":"Add and use session lock/unlock","user":{"login":"texasaggie97","id":11483903,"avatar_url":"https://avatars1.githubusercontent.com/u/11483903?v=4","gravatar_id":"","url":"https://api.github.com/users/texasaggie97","html_url":"https://github.com/texasaggie97","followers_url":"https://api.github.com/users/texasaggie97/followers","following_url":"https://api.github.com/users/texasaggie97/following{/other_user}","gists_url":"https://api.github.com/users/texasaggie97/gists{/gist_id}","starred_url":"https://api.github.com/users/texasaggie97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texasaggie97/subscriptions","organizations_url":"https://api.github.com/users/texasaggie97/orgs","repos_url":"https://api.github.com/users/texasaggie97/repos","events_url":"https://api.github.com/users/texasaggie97/events{/privacy}","received_events_url":"https://api.github.com/users/texasaggie97/received_events","type":"User","site_admin":false},"body":"- [X] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md).\r\n- [X] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.\r\n- [X] I've added tests applicable for this pull request\r\n### What does this Pull Request accomplish?\r\n* Add `session.lock()` and `session.unlock()`\r\n  * Uses `lock_session()` and `unlock_session()` internally\r\n* `session.lock()` return a context manager that can be used to unlock\r\n### List issues fixed by this Pull Request below, if any.\r\n* Fix #141 \r\n\r\n### What testing has been done?\r\n* Unit\r\n* System","created_at":"2018-05-03T21:24:07Z","updated_at":"2018-05-21T16:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8391bb8278ad7695b1fb9896fb8543764bf6b9cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":656403030,"url":"https://api.github.com/repos/ni/nimi-python/labels/API","name":"API","color":"fbca04","default":false},{"id":603245017,"url":"https://api.github.com/repos/ni/nimi-python/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":742577049,"url":"https://api.github.com/repos/ni/nimi-python/labels/nidcpower","name":"nidcpower","color":"363fa0","default":false},{"id":780102262,"url":"https://api.github.com/repos/ni/nimi-python/labels/nidmm","name":"nidmm","color":"6633a0","default":false},{"id":733087933,"url":"https://api.github.com/repos/ni/nimi-python/labels/nifgen","name":"nifgen","color":"ffcccf","default":false},{"id":735743004,"url":"https://api.github.com/repos/ni/nimi-python/labels/niscope","name":"niscope","color":"3f5cc6","default":false},{"id":771497718,"url":"https://api.github.com/repos/ni/nimi-python/labels/niswitch","name":"niswitch","color":"7fe871","default":false}],"milestone":{"url":"https://api.github.com/repos/ni/nimi-python/milestones/16","html_url":"https://github.com/ni/nimi-python/milestone/16","labels_url":"https://api.github.com/repos/ni/nimi-python/milestones/16/labels","id":3361692,"number":16,"title":"nimi-python 0.9 release","description":"","creator":{"login":"Fladolcetta","id":28631682,"avatar_url":"https://avatars1.githubusercontent.com/u/28631682?v=4","gravatar_id":"","url":"https://api.github.com/users/Fladolcetta","html_url":"https://github.com/Fladolcetta","followers_url":"https://api.github.com/users/Fladolcetta/followers","following_url":"https://api.github.com/users/Fladolcetta/following{/other_user}","gists_url":"https://api.github.com/users/Fladolcetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Fladolcetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fladolcetta/subscriptions","organizations_url":"https://api.github.com/users/Fladolcetta/orgs","repos_url":"https://api.github.com/users/Fladolcetta/repos","events_url":"https://api.github.com/users/Fladolcetta/events{/privacy}","received_events_url":"https://api.github.com/users/Fladolcetta/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":25,"state":"open","created_at":"2018-05-21T14:56:40Z","updated_at":"2018-05-21T15:05:17Z","due_on":"2018-05-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ni/nimi-python/pulls/846/commits","review_comments_url":"https://api.github.com/repos/ni/nimi-python/pulls/846/comments","review_comment_url":"https://api.github.com/repos/ni/nimi-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ni/nimi-python/issues/846/comments","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/742e785ab0dbba3896e9b58020c0dc2946884681","head":{"label":"ni:bug141/ivi_lock","ref":"bug141/ivi_lock","sha":"742e785ab0dbba3896e9b58020c0dc2946884681","user":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":91020334,"name":"nimi-python","full_name":"ni/nimi-python","owner":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/nimi-python","description":"Python bindings for NI Modular Instrument drivers.","fork":false,"url":"https://api.github.com/repos/ni/nimi-python","forks_url":"https://api.github.com/repos/ni/nimi-python/forks","keys_url":"https://api.github.com/repos/ni/nimi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/nimi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/nimi-python/teams","hooks_url":"https://api.github.com/repos/ni/nimi-python/hooks","issue_events_url":"https://api.github.com/repos/ni/nimi-python/issues/events{/number}","events_url":"https://api.github.com/repos/ni/nimi-python/events","assignees_url":"https://api.github.com/repos/ni/nimi-python/assignees{/user}","branches_url":"https://api.github.com/repos/ni/nimi-python/branches{/branch}","tags_url":"https://api.github.com/repos/ni/nimi-python/tags","blobs_url":"https://api.github.com/repos/ni/nimi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/nimi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/nimi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/nimi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/nimi-python/languages","stargazers_url":"https://api.github.com/repos/ni/nimi-python/stargazers","contributors_url":"https://api.github.com/repos/ni/nimi-python/contributors","subscribers_url":"https://api.github.com/repos/ni/nimi-python/subscribers","subscription_url":"https://api.github.com/repos/ni/nimi-python/subscription","commits_url":"https://api.github.com/repos/ni/nimi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/nimi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/nimi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/nimi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/nimi-python/contents/{+path}","compare_url":"https://api.github.com/repos/ni/nimi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/nimi-python/merges","archive_url":"https://api.github.com/repos/ni/nimi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/nimi-python/downloads","issues_url":"https://api.github.com/repos/ni/nimi-python/issues{/number}","pulls_url":"https://api.github.com/repos/ni/nimi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/nimi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/nimi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/nimi-python/labels{/name}","releases_url":"https://api.github.com/repos/ni/nimi-python/releases{/id}","deployments_url":"https://api.github.com/repos/ni/nimi-python/deployments","created_at":"2017-05-11T20:24:33Z","updated_at":"2018-05-18T20:30:27Z","pushed_at":"2018-05-21T16:06:44Z","git_url":"git://github.com/ni/nimi-python.git","ssh_url":"git@github.com:ni/nimi-python.git","clone_url":"https://github.com/ni/nimi-python.git","svn_url":"https://github.com/ni/nimi-python","homepage":"","size":6663,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":66,"watchers":22,"default_branch":"master"}},"base":{"label":"ni:master","ref":"master","sha":"d58099d41a06ef02da5340d73596b7873eb4607d","user":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":91020334,"name":"nimi-python","full_name":"ni/nimi-python","owner":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/nimi-python","description":"Python bindings for NI Modular Instrument drivers.","fork":false,"url":"https://api.github.com/repos/ni/nimi-python","forks_url":"https://api.github.com/repos/ni/nimi-python/forks","keys_url":"https://api.github.com/repos/ni/nimi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/nimi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/nimi-python/teams","hooks_url":"https://api.github.com/repos/ni/nimi-python/hooks","issue_events_url":"https://api.github.com/repos/ni/nimi-python/issues/events{/number}","events_url":"https://api.github.com/repos/ni/nimi-python/events","assignees_url":"https://api.github.com/repos/ni/nimi-python/assignees{/user}","branches_url":"https://api.github.com/repos/ni/nimi-python/branches{/branch}","tags_url":"https://api.github.com/repos/ni/nimi-python/tags","blobs_url":"https://api.github.com/repos/ni/nimi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/nimi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/nimi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/nimi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/nimi-python/languages","stargazers_url":"https://api.github.com/repos/ni/nimi-python/stargazers","contributors_url":"https://api.github.com/repos/ni/nimi-python/contributors","subscribers_url":"https://api.github.com/repos/ni/nimi-python/subscribers","subscription_url":"https://api.github.com/repos/ni/nimi-python/subscription","commits_url":"https://api.github.com/repos/ni/nimi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/nimi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/nimi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/nimi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/nimi-python/contents/{+path}","compare_url":"https://api.github.com/repos/ni/nimi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/nimi-python/merges","archive_url":"https://api.github.com/repos/ni/nimi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/nimi-python/downloads","issues_url":"https://api.github.com/repos/ni/nimi-python/issues{/number}","pulls_url":"https://api.github.com/repos/ni/nimi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/nimi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/nimi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/nimi-python/labels{/name}","releases_url":"https://api.github.com/repos/ni/nimi-python/releases{/id}","deployments_url":"https://api.github.com/repos/ni/nimi-python/deployments","created_at":"2017-05-11T20:24:33Z","updated_at":"2018-05-18T20:30:27Z","pushed_at":"2018-05-21T16:06:44Z","git_url":"git://github.com/ni/nimi-python.git","ssh_url":"git@github.com:ni/nimi-python.git","clone_url":"https://github.com/ni/nimi-python.git","svn_url":"https://github.com/ni/nimi-python","homepage":"","size":6663,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":66,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/846"},"html":{"href":"https://github.com/ni/nimi-python/pull/846"},"issue":{"href":"https://api.github.com/repos/ni/nimi-python/issues/846"},"comments":{"href":"https://api.github.com/repos/ni/nimi-python/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/ni/nimi-python/statuses/742e785ab0dbba3896e9b58020c0dc2946884681"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"marcoskirsch"}}