{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/faas-cli/issues/345","repository_url":"https://api.github.com/repos/openfaas/faas-cli","labels_url":"https://api.github.com/repos/openfaas/faas-cli/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas-cli/issues/345/comments","events_url":"https://api.github.com/repos/openfaas/faas-cli/issues/345/events","html_url":"https://github.com/openfaas/faas-cli/issues/345","id":302783162,"number":345,"title":"Consider use of environmental variable for gateway override","user":{"login":"alexellis","id":6358735,"avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-06T16:58:54Z","updated_at":"2018-03-07T15:09:36Z","closed_at":null,"author_association":"OWNER","body":"## Description\r\n\r\nConsider use of environmental variable for gateway URL override.\r\n\r\nOn Kubernetes everyone has to provide an override all the time - whether `-g` 127.0.0.1:31112` or `-g `minikube ip`` or similar.\r\n\r\n## Pros\r\n\r\n* Could allow an override of the default address of `localhost:8080`\r\n* Less typing when the gateway is not localhost:8080 and user doesn't want to update a YAML file\r\n\r\n## Cons/Concerns\r\n\r\n* hard to maintain a flag that has three sources - YAML, argument and ENV\r\n* code change could cause regression for existing users so would need extensive testing\r\n* work-arounds already exist - changing the YAML file or passing `-g`/`--gateway`\r\n* affects several commands: `deploy` / `list` / `invoke` etc etc\r\n"},"comment":{"url":"https://api.github.com/repos/openfaas/faas-cli/issues/comments/371168908","html_url":"https://github.com/openfaas/faas-cli/issues/345#issuecomment-371168908","issue_url":"https://api.github.com/repos/openfaas/faas-cli/issues/345","id":371168908,"user":{"login":"johnmccabe","id":83862,"avatar_url":"https://avatars3.githubusercontent.com/u/83862?v=4","gravatar_id":"","url":"https://api.github.com/users/johnmccabe","html_url":"https://github.com/johnmccabe","followers_url":"https://api.github.com/users/johnmccabe/followers","following_url":"https://api.github.com/users/johnmccabe/following{/other_user}","gists_url":"https://api.github.com/users/johnmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccabe/subscriptions","organizations_url":"https://api.github.com/users/johnmccabe/orgs","repos_url":"https://api.github.com/users/johnmccabe/repos","events_url":"https://api.github.com/users/johnmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccabe/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T15:09:36Z","updated_at":"2018-03-07T15:09:36Z","author_association":"MEMBER","body":"roughly 1.6MB overhead with all the additional functionality you get, agree if `os.Getenv` is all thats wanted here better to roll your own."}}
{"actor":{"display_login":"johnmccabe"}}