{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/237826078","pull_request_review_id":180220717,"id":237826078,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgyNjA3OA==","diff_hunk":"@@ -285,6 +285,23 @@ Messenger\n    ```\n  * The `EncoderInterface` and `DecoderInterface` interfaces have been replaced by a unified `Symfony\\Component\\Messenger\\Transport\\Serialization\\SerializerInterface`.\n    Each interface method have been merged untouched into the `Serializer` interface, so you can simply merge your two implementations together and implement the new interface.\n+ * The `HandlerLocator` class was replaced with `Symfony\\Component\\Messenger\\Handler\\HandlersLocator`:\n+   Before:\n+   ```php\n+   new HandlerLocator([\n+        YourMessage::class => $handlerService,","path":"UPGRADE-4.2.md","position":8,"original_position":8,"commit_id":"ac5f71489842bacb2cbb5e2b545c64908fd20d24","original_commit_id":"ac5f71489842bacb2cbb5e2b545c64908fd20d24","user":{"login":"ro0NL","id":1047696,"node_id":"MDQ6VXNlcjEwNDc2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"i suggest `$handlerCallable`","created_at":"2018-11-30T11:13:22Z","updated_at":"2018-11-30T11:13:22Z","html_url":"https://github.com/symfony/symfony/pull/29381#discussion_r237826078","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/29381","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/237826078"},"html":{"href":"https://github.com/symfony/symfony/pull/29381#discussion_r237826078"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29381"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/29381","id":234912452,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTEyNDUy","html_url":"https://github.com/symfony/symfony/pull/29381","diff_url":"https://github.com/symfony/symfony/pull/29381.diff","patch_url":"https://github.com/symfony/symfony/pull/29381.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/29381","number":29381,"state":"open","locked":false,"title":"Added upgrade to HandlersLocator","user":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 4.2\r\n| Bug fix?      | missing upgrade\r\n| New feature?  | no\r\n| BC breaks?    | no \r\n| Deprecations? | no\r\n| Tests pass?   | no tests\r\n| Fixed tickets | fixes #29367\r\n| License       | MIT\r\n\r\nAdded upgrade to HandlersLocator\r\n","created_at":"2018-11-30T08:49:43Z","updated_at":"2018-11-30T11:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c2c5e4860bb0050abaeaf6a8a278a1161bbd9da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/29381/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/29381/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/29381/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ac5f71489842bacb2cbb5e2b545c64908fd20d24","head":{"label":"alexander-schranz:patch-2","ref":"patch-2","sha":"ac5f71489842bacb2cbb5e2b545c64908fd20d24","user":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"repo":{"id":59123348,"node_id":"MDEwOlJlcG9zaXRvcnk1OTEyMzM0OA==","name":"symfony","full_name":"alexander-schranz/symfony","private":false,"owner":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexander-schranz/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/alexander-schranz/symfony","forks_url":"https://api.github.com/repos/alexander-schranz/symfony/forks","keys_url":"https://api.github.com/repos/alexander-schranz/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexander-schranz/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexander-schranz/symfony/teams","hooks_url":"https://api.github.com/repos/alexander-schranz/symfony/hooks","issue_events_url":"https://api.github.com/repos/alexander-schranz/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/alexander-schranz/symfony/events","assignees_url":"https://api.github.com/repos/alexander-schranz/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/alexander-schranz/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/alexander-schranz/symfony/tags","blobs_url":"https://api.github.com/repos/alexander-schranz/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexander-schranz/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexander-schranz/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexander-schranz/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexander-schranz/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/alexander-schranz/symfony/languages","stargazers_url":"https://api.github.com/repos/alexander-schranz/symfony/stargazers","contributors_url":"https://api.github.com/repos/alexander-schranz/symfony/contributors","subscribers_url":"https://api.github.com/repos/alexander-schranz/symfony/subscribers","subscription_url":"https://api.github.com/repos/alexander-schranz/symfony/subscription","commits_url":"https://api.github.com/repos/alexander-schranz/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexander-schranz/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexander-schranz/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexander-schranz/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexander-schranz/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/alexander-schranz/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexander-schranz/symfony/merges","archive_url":"https://api.github.com/repos/alexander-schranz/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexander-schranz/symfony/downloads","issues_url":"https://api.github.com/repos/alexander-schranz/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/alexander-schranz/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/alexander-schranz/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/alexander-schranz/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexander-schranz/symfony/labels{/name}","releases_url":"https://api.github.com/repos/alexander-schranz/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/alexander-schranz/symfony/deployments","created_at":"2016-05-18T14:31:40Z","updated_at":"2016-05-18T14:31:57Z","pushed_at":"2018-11-30T11:08:23Z","git_url":"git://github.com/alexander-schranz/symfony.git","ssh_url":"git@github.com:alexander-schranz/symfony.git","clone_url":"https://github.com/alexander-schranz/symfony.git","svn_url":"https://github.com/alexander-schranz/symfony","homepage":"symfony.com","size":122490,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:4.2","ref":"4.2","sha":"4ea6f649dc5947940cd996ff17ad2481a1441095","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-11-30T11:06:04Z","pushed_at":"2018-11-30T11:11:13Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":127802,"stargazers_count":19205,"watchers_count":19205,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6540,"mirror_url":null,"archived":false,"open_issues_count":829,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6540,"open_issues":829,"watchers":19205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29381"},"html":{"href":"https://github.com/symfony/symfony/pull/29381"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/29381"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/29381/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29381/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29381/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ac5f71489842bacb2cbb5e2b545c64908fd20d24"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ro0NL"}}