{"action":"created","comment":{"url":"https://api.github.com/repos/kiwicom/mobile/pulls/comments/198487631","pull_request_review_id":132424890,"id":198487631,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ4NzYzMQ==","diff_hunk":"@@ -14,7 +14,7 @@ type PropsWithContext = {|\n \n class DetailShareButton extends React.Component<PropsWithContext> {\n   onPress = () => {\n-    const lang = GetDeviceLocale().split('-')[0] || 'en';\n+    const lang = GetDeviceLocale.getLanguage() || 'en';","path":"app/MMB/src/navigation/DetailShareButton.js","position":5,"original_position":5,"commit_id":"a9377c3bdfdd90093baaa307f46317ae23952ff2","original_commit_id":"a9377c3bdfdd90093baaa307f46317ae23952ff2","user":{"login":"tbergq","id":7705041,"node_id":"MDQ6VXNlcjc3MDUwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7705041?v=4","gravatar_id":"","url":"https://api.github.com/users/tbergq","html_url":"https://github.com/tbergq","followers_url":"https://api.github.com/users/tbergq/followers","following_url":"https://api.github.com/users/tbergq/following{/other_user}","gists_url":"https://api.github.com/users/tbergq/gists{/gist_id}","starred_url":"https://api.github.com/users/tbergq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbergq/subscriptions","organizations_url":"https://api.github.com/users/tbergq/orgs","repos_url":"https://api.github.com/users/tbergq/repos","events_url":"https://api.github.com/users/tbergq/events{/privacy}","received_events_url":"https://api.github.com/users/tbergq/received_events","type":"User","site_admin":false},"body":"Before this file was just about DeviceLocale, but now it is about more. Maybe it would be better to rename it to DeviceInfo\r\n\r\n`DeviceInfo.getLanguage()` makes more sense than `GetDeviceLocale.getLanguage()`","created_at":"2018-06-27T13:08:18Z","updated_at":"2018-06-27T13:08:19Z","html_url":"https://github.com/kiwicom/mobile/pull/780#discussion_r198487631","pull_request_url":"https://api.github.com/repos/kiwicom/mobile/pulls/780","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/comments/198487631"},"html":{"href":"https://github.com/kiwicom/mobile/pull/780#discussion_r198487631"},"pull_request":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/kiwicom/mobile/pulls/780","id":197697074,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Njk3MDc0","html_url":"https://github.com/kiwicom/mobile/pull/780","diff_url":"https://github.com/kiwicom/mobile/pull/780.diff","patch_url":"https://github.com/kiwicom/mobile/pull/780.patch","issue_url":"https://api.github.com/repos/kiwicom/mobile/issues/780","number":780,"state":"open","locked":false,"title":"Avoid appending calendar in device info locale","user":{"login":"lukewalczak","id":22746080,"node_id":"MDQ6VXNlcjIyNzQ2MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/22746080?v=4","gravatar_id":"","url":"https://api.github.com/users/lukewalczak","html_url":"https://github.com/lukewalczak","followers_url":"https://api.github.com/users/lukewalczak/followers","following_url":"https://api.github.com/users/lukewalczak/following{/other_user}","gists_url":"https://api.github.com/users/lukewalczak/gists{/gist_id}","starred_url":"https://api.github.com/users/lukewalczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukewalczak/subscriptions","organizations_url":"https://api.github.com/users/lukewalczak/orgs","repos_url":"https://api.github.com/users/lukewalczak/repos","events_url":"https://api.github.com/users/lukewalczak/events{/privacy}","received_events_url":"https://api.github.com/users/lukewalczak/received_events","type":"User","site_admin":false},"body":"Related to: #738 \r\n\r\nCurrently `GetDeviceLocale` always will return object:\r\n```\r\n{\r\n  Format: {\r\n    Underscored: 'en_US',\r\n    Dashed: 'en-US',\r\n  },\r\n  Language: 'en',\r\n  Territory: 'US',\r\n},\r\n```\r\nwhere `Format.Underscored` and `Format.Dashed` are a combination of `Language` and `Territory`. In that way we are able to avoid appending unnecessary `calendar=gregorian`.","created_at":"2018-06-27T11:12:40Z","updated_at":"2018-06-27T13:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982cc507276c266498c68985fdbc0bf12f4deffb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ferrannp","id":774577,"node_id":"MDQ6VXNlcjc3NDU3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/774577?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwicom/mobile/pulls/780/commits","review_comments_url":"https://api.github.com/repos/kiwicom/mobile/pulls/780/comments","review_comment_url":"https://api.github.com/repos/kiwicom/mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwicom/mobile/issues/780/comments","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/a9377c3bdfdd90093baaa307f46317ae23952ff2","head":{"label":"kiwicom:fix-device-locale","ref":"fix-device-locale","sha":"a9377c3bdfdd90093baaa307f46317ae23952ff2","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":105595148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTUxNDg=","name":"mobile","full_name":"kiwicom/mobile","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/mobile","description":":calling: Kiwi.com mobile app written in React Native","fork":false,"url":"https://api.github.com/repos/kiwicom/mobile","forks_url":"https://api.github.com/repos/kiwicom/mobile/forks","keys_url":"https://api.github.com/repos/kiwicom/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/mobile/teams","hooks_url":"https://api.github.com/repos/kiwicom/mobile/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/mobile/events","assignees_url":"https://api.github.com/repos/kiwicom/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/mobile/tags","blobs_url":"https://api.github.com/repos/kiwicom/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/mobile/languages","stargazers_url":"https://api.github.com/repos/kiwicom/mobile/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/mobile/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/mobile/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/mobile/subscription","commits_url":"https://api.github.com/repos/kiwicom/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/mobile/merges","archive_url":"https://api.github.com/repos/kiwicom/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/mobile/downloads","issues_url":"https://api.github.com/repos/kiwicom/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/mobile/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/mobile/deployments","created_at":"2017-10-02T23:21:42Z","updated_at":"2018-06-27T11:06:05Z","pushed_at":"2018-06-27T12:58:04Z","git_url":"git://github.com/kiwicom/mobile.git","ssh_url":"git@github.com:kiwicom/mobile.git","clone_url":"https://github.com/kiwicom/mobile.git","svn_url":"https://github.com/kiwicom/mobile","homepage":"https://www.kiwi.com/","size":13320,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":20,"watchers":28,"default_branch":"master"}},"base":{"label":"kiwicom:master","ref":"master","sha":"cdabcc9f5682da5b45aa3c54cf6e65a91e08b3bb","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":105595148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTUxNDg=","name":"mobile","full_name":"kiwicom/mobile","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/mobile","description":":calling: Kiwi.com mobile app written in React Native","fork":false,"url":"https://api.github.com/repos/kiwicom/mobile","forks_url":"https://api.github.com/repos/kiwicom/mobile/forks","keys_url":"https://api.github.com/repos/kiwicom/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/mobile/teams","hooks_url":"https://api.github.com/repos/kiwicom/mobile/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/mobile/events","assignees_url":"https://api.github.com/repos/kiwicom/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/mobile/tags","blobs_url":"https://api.github.com/repos/kiwicom/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/mobile/languages","stargazers_url":"https://api.github.com/repos/kiwicom/mobile/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/mobile/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/mobile/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/mobile/subscription","commits_url":"https://api.github.com/repos/kiwicom/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/mobile/merges","archive_url":"https://api.github.com/repos/kiwicom/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/mobile/downloads","issues_url":"https://api.github.com/repos/kiwicom/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/mobile/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/mobile/deployments","created_at":"2017-10-02T23:21:42Z","updated_at":"2018-06-27T11:06:05Z","pushed_at":"2018-06-27T12:58:04Z","git_url":"git://github.com/kiwicom/mobile.git","ssh_url":"git@github.com:kiwicom/mobile.git","clone_url":"https://github.com/kiwicom/mobile.git","svn_url":"https://github.com/kiwicom/mobile","homepage":"https://www.kiwi.com/","size":13320,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":20,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/780"},"html":{"href":"https://github.com/kiwicom/mobile/pull/780"},"issue":{"href":"https://api.github.com/repos/kiwicom/mobile/issues/780"},"comments":{"href":"https://api.github.com/repos/kiwicom/mobile/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/kiwicom/mobile/statuses/a9377c3bdfdd90093baaa307f46317ae23952ff2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tbergq"}}