{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/192562062","pull_request_review_id":125368602,"id":192562062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU2MjA2Mg==","diff_hunk":"@@ -41,7 +41,8 @@ public ApplicationId(byte[] publicKeyToken, string name, Version version, string\n \n         public override string ToString ()\n         {\n-            StringBuilder sb = StringBuilderCache.Acquire();\n+            Span<char> charSpan = stackalloc char[127];","path":"src/System.Runtime.Extensions/src/System/ApplicationId.cs","position":5,"original_position":5,"commit_id":"54c2cbb8e0395b0ad7172192538e5381da44564a","original_commit_id":"54c2cbb8e0395b0ad7172192538e5381da44564a","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"The space on the stack is aligned to pointer sized chunks anyway. If you use 127, there will be one unused byte.\r\n\r\n128 is better.","created_at":"2018-06-02T15:11:57Z","updated_at":"2018-06-02T15:11:57Z","html_url":"https://github.com/dotnet/corefx/pull/30072#discussion_r192562062","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/30072","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/192562062"},"html":{"href":"https://github.com/dotnet/corefx/pull/30072#discussion_r192562062"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30072"}},"in_reply_to_id":192562022},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30072","id":192188472,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTg4NDcy","html_url":"https://github.com/dotnet/corefx/pull/30072","diff_url":"https://github.com/dotnet/corefx/pull/30072.diff","patch_url":"https://github.com/dotnet/corefx/pull/30072.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30072","number":30072,"state":"open","locked":false,"title":"Remove some of usages of StringBuilderCache from System.Runtime.Extensions","user":{"login":"leotsarev","id":909808,"node_id":"MDQ6VXNlcjkwOTgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/909808?v=4","gravatar_id":"","url":"https://api.github.com/users/leotsarev","html_url":"https://github.com/leotsarev","followers_url":"https://api.github.com/users/leotsarev/followers","following_url":"https://api.github.com/users/leotsarev/following{/other_user}","gists_url":"https://api.github.com/users/leotsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/leotsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leotsarev/subscriptions","organizations_url":"https://api.github.com/users/leotsarev/orgs","repos_url":"https://api.github.com/users/leotsarev/repos","events_url":"https://api.github.com/users/leotsarev/events{/privacy}","received_events_url":"https://api.github.com/users/leotsarev/received_events","type":"User","site_admin":false},"body":"fixes #29997\r\nThat's a work in progress to get initial feedback about removing.\r\nChecklist\r\n\r\n- [x] System.ApplicationId\r\n- [x] System.Environment.ExpandEnvironmentVariablesCore()","created_at":"2018-06-02T09:03:46Z","updated_at":"2018-06-02T15:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34df99f2de0bddafd6e9c7f00fc66f03dd849161","assignee":{"login":"leotsarev","id":909808,"node_id":"MDQ6VXNlcjkwOTgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/909808?v=4","gravatar_id":"","url":"https://api.github.com/users/leotsarev","html_url":"https://github.com/leotsarev","followers_url":"https://api.github.com/users/leotsarev/followers","following_url":"https://api.github.com/users/leotsarev/following{/other_user}","gists_url":"https://api.github.com/users/leotsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/leotsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leotsarev/subscriptions","organizations_url":"https://api.github.com/users/leotsarev/orgs","repos_url":"https://api.github.com/users/leotsarev/repos","events_url":"https://api.github.com/users/leotsarev/events{/privacy}","received_events_url":"https://api.github.com/users/leotsarev/received_events","type":"User","site_admin":false},"assignees":[{"login":"leotsarev","id":909808,"node_id":"MDQ6VXNlcjkwOTgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/909808?v=4","gravatar_id":"","url":"https://api.github.com/users/leotsarev","html_url":"https://github.com/leotsarev","followers_url":"https://api.github.com/users/leotsarev/followers","following_url":"https://api.github.com/users/leotsarev/following{/other_user}","gists_url":"https://api.github.com/users/leotsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/leotsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leotsarev/subscriptions","organizations_url":"https://api.github.com/users/leotsarev/orgs","repos_url":"https://api.github.com/users/leotsarev/repos","events_url":"https://api.github.com/users/leotsarev/events{/privacy}","received_events_url":"https://api.github.com/users/leotsarev/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JeremyKuhne","id":8184940,"node_id":"MDQ6VXNlcjgxODQ5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8184940?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":179105931,"node_id":"MDU6TGFiZWwxNzkxMDU5MzE=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Runtime.Extensions","name":"area-System.Runtime.Extensions","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/30072/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/30072/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30072/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/54c2cbb8e0395b0ad7172192538e5381da44564a","head":{"label":"leotsarev:remove-stringbuildercache-from-system-runtime-extensions","ref":"remove-stringbuildercache-from-system-runtime-extensions","sha":"54c2cbb8e0395b0ad7172192538e5381da44564a","user":{"login":"leotsarev","id":909808,"node_id":"MDQ6VXNlcjkwOTgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/909808?v=4","gravatar_id":"","url":"https://api.github.com/users/leotsarev","html_url":"https://github.com/leotsarev","followers_url":"https://api.github.com/users/leotsarev/followers","following_url":"https://api.github.com/users/leotsarev/following{/other_user}","gists_url":"https://api.github.com/users/leotsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/leotsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leotsarev/subscriptions","organizations_url":"https://api.github.com/users/leotsarev/orgs","repos_url":"https://api.github.com/users/leotsarev/repos","events_url":"https://api.github.com/users/leotsarev/events{/privacy}","received_events_url":"https://api.github.com/users/leotsarev/received_events","type":"User","site_admin":false},"repo":{"id":135792156,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3OTIxNTY=","name":"corefx","full_name":"leotsarev/corefx","owner":{"login":"leotsarev","id":909808,"node_id":"MDQ6VXNlcjkwOTgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/909808?v=4","gravatar_id":"","url":"https://api.github.com/users/leotsarev","html_url":"https://github.com/leotsarev","followers_url":"https://api.github.com/users/leotsarev/followers","following_url":"https://api.github.com/users/leotsarev/following{/other_user}","gists_url":"https://api.github.com/users/leotsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/leotsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leotsarev/subscriptions","organizations_url":"https://api.github.com/users/leotsarev/orgs","repos_url":"https://api.github.com/users/leotsarev/repos","events_url":"https://api.github.com/users/leotsarev/events{/privacy}","received_events_url":"https://api.github.com/users/leotsarev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leotsarev/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/leotsarev/corefx","forks_url":"https://api.github.com/repos/leotsarev/corefx/forks","keys_url":"https://api.github.com/repos/leotsarev/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leotsarev/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leotsarev/corefx/teams","hooks_url":"https://api.github.com/repos/leotsarev/corefx/hooks","issue_events_url":"https://api.github.com/repos/leotsarev/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/leotsarev/corefx/events","assignees_url":"https://api.github.com/repos/leotsarev/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/leotsarev/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/leotsarev/corefx/tags","blobs_url":"https://api.github.com/repos/leotsarev/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leotsarev/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leotsarev/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/leotsarev/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leotsarev/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/leotsarev/corefx/languages","stargazers_url":"https://api.github.com/repos/leotsarev/corefx/stargazers","contributors_url":"https://api.github.com/repos/leotsarev/corefx/contributors","subscribers_url":"https://api.github.com/repos/leotsarev/corefx/subscribers","subscription_url":"https://api.github.com/repos/leotsarev/corefx/subscription","commits_url":"https://api.github.com/repos/leotsarev/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/leotsarev/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/leotsarev/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/leotsarev/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/leotsarev/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/leotsarev/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leotsarev/corefx/merges","archive_url":"https://api.github.com/repos/leotsarev/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leotsarev/corefx/downloads","issues_url":"https://api.github.com/repos/leotsarev/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/leotsarev/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/leotsarev/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/leotsarev/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leotsarev/corefx/labels{/name}","releases_url":"https://api.github.com/repos/leotsarev/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/leotsarev/corefx/deployments","created_at":"2018-06-02T06:03:29Z","updated_at":"2018-06-02T06:04:18Z","pushed_at":"2018-06-02T15:04:59Z","git_url":"git://github.com/leotsarev/corefx.git","ssh_url":"git@github.com:leotsarev/corefx.git","clone_url":"https://github.com/leotsarev/corefx.git","svn_url":"https://github.com/leotsarev/corefx","homepage":"https://github.com/dotnet/core","size":178412,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ef0d4171ea29afc03c5098a8fef7c7e3ec11657c","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-06-02T14:20:37Z","pushed_at":"2018-06-02T15:09:05Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":178410,"stargazers_count":14068,"watchers_count":14068,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4078,"mirror_url":null,"archived":false,"open_issues_count":2276,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4078,"open_issues":2276,"watchers":14068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30072"},"html":{"href":"https://github.com/dotnet/corefx/pull/30072"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30072"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30072/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30072/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30072/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/54c2cbb8e0395b0ad7172192538e5381da44564a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jkotas"}}