{"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments/235427345","pull_request_review_id":177281046,"id":235427345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQyNzM0NQ==","diff_hunk":"@@ -272,6 +276,29 @@ void getValueBeforeInit() {\n     );\n   }\n \n+  @Test\n+  void afterCommit() throws CloseFailuresException {\n+    try (MemoryDb db = MemoryDb.newInstance();\n+        Cleaner cleaner = new Cleaner()) {\n+      Fork view = db.createFork(cleaner);\n+      setServiceNode(node);\n+      service.initialize(view);\n+\n+      BlockCommittedEvent event = mock(BlockCommittedEvent.class);","path":"exonum-java-binding-qa-service/src/test/java/com/exonum/binding/qaservice/QaServiceImplIntegrationTest.java","position":59,"original_position":59,"commit_id":"4963ddc52e7498a1c1a26a0891ee01017b61fdc0","original_commit_id":"4963ddc52e7498a1c1a26a0891ee01017b61fdc0","user":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"body":"Why do you mock a value and not just create it? You don't seem to verify any interactions with it","created_at":"2018-11-21T15:17:17Z","updated_at":"2018-11-21T15:18:08Z","html_url":"https://github.com/exonum/exonum-java-binding/pull/567#discussion_r235427345","pull_request_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments/235427345"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/567#discussion_r235427345"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567"}}},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567","id":228540004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTQwMDA0","html_url":"https://github.com/exonum/exonum-java-binding/pull/567","diff_url":"https://github.com/exonum/exonum-java-binding/pull/567.diff","patch_url":"https://github.com/exonum/exonum-java-binding/pull/567.patch","issue_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/567","number":567,"state":"open","locked":false,"title":"Add afterCommit to QaService [ECR-2552]","user":{"login":"MakarovS","id":6428594,"node_id":"MDQ6VXNlcjY0Mjg1OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6428594?v=4","gravatar_id":"","url":"https://api.github.com/users/MakarovS","html_url":"https://github.com/MakarovS","followers_url":"https://api.github.com/users/MakarovS/followers","following_url":"https://api.github.com/users/MakarovS/following{/other_user}","gists_url":"https://api.github.com/users/MakarovS/gists{/gist_id}","starred_url":"https://api.github.com/users/MakarovS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakarovS/subscriptions","organizations_url":"https://api.github.com/users/MakarovS/orgs","repos_url":"https://api.github.com/users/MakarovS/repos","events_url":"https://api.github.com/users/MakarovS/events{/privacy}","received_events_url":"https://api.github.com/users/MakarovS/received_events","type":"User","site_admin":false},"body":"## Overview\r\nAdd afterCommit to QaService.\r\nNow it creates `after_commit_counter` on service initialization. This counter is incremented on every `afterCommit` invocation.\r\n\r\n---\r\nSee: https://jira.bf.local/browse/ECR-2552\r\n\r\n### Definition of Done\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] Change is covered by automated [tests](https://github.com/exonum/exonum-java-binding/blob/master/CONTRIBUTING.md#tests)\r\n- [x] The [coding guidelines](https://github.com/exonum/exonum-java-binding/blob/master/CONTRIBUTING.md#the-code-style) are followed\r\n- [x] Public API has Javadoc\r\n- [x] Method preconditions are checked and documented in the Javadoc of the method\r\n- [x] Changelog is updated if needed (in case of notable or breaking changes)\r\n- [x] The continuous integration build passes\r\n","created_at":"2018-11-06T00:43:01Z","updated_at":"2018-11-21T15:18:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bed4ee24789e55cd15f8f6bf8b77e60a4091537","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dip56","id":4571481,"node_id":"MDQ6VXNlcjQ1NzE0ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4571481?v=4","gravatar_id":"","url":"https://api.github.com/users/dip56","html_url":"https://github.com/dip56","followers_url":"https://api.github.com/users/dip56/followers","following_url":"https://api.github.com/users/dip56/following{/other_user}","gists_url":"https://api.github.com/users/dip56/gists{/gist_id}","starred_url":"https://api.github.com/users/dip56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dip56/subscriptions","organizations_url":"https://api.github.com/users/dip56/orgs","repos_url":"https://api.github.com/users/dip56/repos","events_url":"https://api.github.com/users/dip56/events{/privacy}","received_events_url":"https://api.github.com/users/dip56/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/567/comments","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/4963ddc52e7498a1c1a26a0891ee01017b61fdc0","head":{"label":"exonum:ECR-2552","ref":"ECR-2552","sha":"4963ddc52e7498a1c1a26a0891ee01017b61fdc0","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":92375988,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM3NTk4OA==","name":"exonum-java-binding","full_name":"exonum/exonum-java-binding","private":false,"owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exonum/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":false,"url":"https://api.github.com/repos/exonum/exonum-java-binding","forks_url":"https://api.github.com/repos/exonum/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/exonum/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/exonum/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/exonum/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/exonum/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum-java-binding/deployments","created_at":"2017-05-25T07:12:56Z","updated_at":"2018-11-21T10:43:58Z","pushed_at":"2018-11-21T11:05:13Z","git_url":"git://github.com/exonum/exonum-java-binding.git","ssh_url":"git@github.com:exonum/exonum-java-binding.git","clone_url":"https://github.com/exonum/exonum-java-binding.git","svn_url":"https://github.com/exonum/exonum-java-binding","homepage":"http://exonum.com","size":2793,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":17,"watchers":46,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"bf1838d62a918b9b33f7e6ab19fd716949c725dd","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":92375988,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM3NTk4OA==","name":"exonum-java-binding","full_name":"exonum/exonum-java-binding","private":false,"owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exonum/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":false,"url":"https://api.github.com/repos/exonum/exonum-java-binding","forks_url":"https://api.github.com/repos/exonum/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/exonum/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/exonum/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/exonum/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/exonum/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum-java-binding/deployments","created_at":"2017-05-25T07:12:56Z","updated_at":"2018-11-21T10:43:58Z","pushed_at":"2018-11-21T11:05:13Z","git_url":"git://github.com/exonum/exonum-java-binding.git","ssh_url":"git@github.com:exonum/exonum-java-binding.git","clone_url":"https://github.com/exonum/exonum-java-binding.git","svn_url":"https://github.com/exonum/exonum-java-binding","homepage":"http://exonum.com","size":2793,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":17,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/567"},"issue":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/567"},"comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/4963ddc52e7498a1c1a26a0891ee01017b61fdc0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmitry-timofeev"}}