{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments/221598240","pull_request_review_id":160282357,"id":221598240,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU5ODI0MA==","diff_hunk":"@@ -0,0 +1,42 @@\n+# VM Details\n+\n+Clicking on the name of the Virtual Machine in the list view will take the user into the details view of that VM.\n+\n+![List of VMs](img/UI-VM-list.jpg)\n+\n+\n+The details of the Virtual Machine are separated into tabs:\n+- Overview\n+- YAML\n+- Snapshots\n+- Networks\n+- Disks\n+- Consoles\n+\n+On the overview tab both a general overview and utilization are provided.\n+\n+![Virtual Machine Details](img/UI-VM-details.jpg)\n+\n+Additional information is provided via tooltips for status and boot order.\n+![Virtual Machine Details](img/UI-VM-details-status-tooltip.jpg)\n+\n+The user can then edit the overall details of the VM from the action menu in the top right.\n+\n+![Virtual Machine Details](img/UI-VM-details-action-menu.jpg)\n+\n+Once in Edit mode all available options will show as editable.\n+\n+![Virtual Machine Details](img/UI-VM-details-edit-view.jpg)\n+","path":"ui-design/virtual-machines/vm-details/vm-list.md","position":30,"original_position":30,"commit_id":"efae52d0197701b02914e2a614dfb75048d94385","original_commit_id":"78159841945b5f2c8074d62a5ba10cfd0ff1ed2c","user":{"login":"jelkosz","id":701107,"node_id":"MDQ6VXNlcjcwMTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/701107?v=4","gravatar_id":"","url":"https://api.github.com/users/jelkosz","html_url":"https://github.com/jelkosz","followers_url":"https://api.github.com/users/jelkosz/followers","following_url":"https://api.github.com/users/jelkosz/following{/other_user}","gists_url":"https://api.github.com/users/jelkosz/gists{/gist_id}","starred_url":"https://api.github.com/users/jelkosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelkosz/subscriptions","organizations_url":"https://api.github.com/users/jelkosz/orgs","repos_url":"https://api.github.com/users/jelkosz/repos","events_url":"https://api.github.com/users/jelkosz/events{/privacy}","received_events_url":"https://api.github.com/users/jelkosz/received_events","type":"User","site_admin":false},"body":"\r\n>   Pod shouldn't be editable, I don't know what the user would reasonably change it to.\r\n\r\n+1, it should be a hyperlink to the pod\r\n\r\n>    Project/Namespace shouldn't be editable, there is no action we can reasonably map this to on the backend to actually move objects from namespace to namespace.\r\n\r\n+1, also should be hyperlink\r\n\r\n>    Flavour I'm assuming maps to presets? Something else?\r\n\r\nnope, this one: https://github.com/kubevirt/common-templates/pull/15 - it is a mechanism to utilize the openshift templates to bring common configuration (os/flavor/profile) as well as VM templates (the oVirt like templates).\r\n\r\n>    Not sure it makes sense to be able to toggle cloud-init on off all the time, as it usually would only apply the very first time the guest is booted.\r\n\r\nnot sure. Is re-init not a valid use case?","created_at":"2018-10-01T12:58:26Z","updated_at":"2018-10-01T12:58:27Z","html_url":"https://github.com/kubevirt/web-ui-design/pull/10#discussion_r221598240","pull_request_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments/221598240"},"html":{"href":"https://github.com/kubevirt/web-ui-design/pull/10#discussion_r221598240"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10"}},"in_reply_to_id":220591023},"pull_request":{"url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10","id":218065868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDY1ODY4","html_url":"https://github.com/kubevirt/web-ui-design/pull/10","diff_url":"https://github.com/kubevirt/web-ui-design/pull/10.diff","patch_url":"https://github.com/kubevirt/web-ui-design/pull/10.patch","issue_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/10","number":10,"state":"open","locked":false,"title":"vm details view/edit","user":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"body":"provides screens for the Virtual Machine details, both view and edit screens are included here.","created_at":"2018-09-25T17:49:59Z","updated_at":"2018-10-01T12:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94f7e7d84afd27ada866e37041841fad1d71b1f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10/commits","review_comments_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10/comments","review_comment_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/10/comments","statuses_url":"https://api.github.com/repos/kubevirt/web-ui-design/statuses/efae52d0197701b02914e2a614dfb75048d94385","head":{"label":"matthewcarleton:virtual-machine-details","ref":"virtual-machine-details","sha":"efae52d0197701b02914e2a614dfb75048d94385","user":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"repo":{"id":150272081,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyNzIwODE=","name":"web-ui-design","full_name":"matthewcarleton/web-ui-design","private":false,"owner":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matthewcarleton/web-ui-design","description":" Images and Markdown documenting proposed user workflows for the UI","fork":true,"url":"https://api.github.com/repos/matthewcarleton/web-ui-design","forks_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/forks","keys_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/teams","hooks_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/hooks","issue_events_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/issues/events{/number}","events_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/events","assignees_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/assignees{/user}","branches_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/branches{/branch}","tags_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/tags","blobs_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/languages","stargazers_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/stargazers","contributors_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/contributors","subscribers_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/subscribers","subscription_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/subscription","commits_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/contents/{+path}","compare_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/merges","archive_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/downloads","issues_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/issues{/number}","pulls_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/labels{/name}","releases_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/releases{/id}","deployments_url":"https://api.github.com/repos/matthewcarleton/web-ui-design/deployments","created_at":"2018-09-25T13:44:55Z","updated_at":"2018-09-25T13:44:57Z","pushed_at":"2018-09-27T13:43:39Z","git_url":"git://github.com/matthewcarleton/web-ui-design.git","ssh_url":"git@github.com:matthewcarleton/web-ui-design.git","clone_url":"https://github.com/matthewcarleton/web-ui-design.git","svn_url":"https://github.com/matthewcarleton/web-ui-design","homepage":"","size":1912,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"dd54a414e58155da50a67efa65c0889428d8df90","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":146456816,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0NTY4MTY=","name":"web-ui-design","full_name":"kubevirt/web-ui-design","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/web-ui-design","description":" Images and Markdown documenting proposed user workflows for the UI","fork":false,"url":"https://api.github.com/repos/kubevirt/web-ui-design","forks_url":"https://api.github.com/repos/kubevirt/web-ui-design/forks","keys_url":"https://api.github.com/repos/kubevirt/web-ui-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/web-ui-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/web-ui-design/teams","hooks_url":"https://api.github.com/repos/kubevirt/web-ui-design/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/web-ui-design/events","assignees_url":"https://api.github.com/repos/kubevirt/web-ui-design/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/web-ui-design/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/web-ui-design/tags","blobs_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/web-ui-design/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/web-ui-design/languages","stargazers_url":"https://api.github.com/repos/kubevirt/web-ui-design/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/web-ui-design/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/web-ui-design/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/web-ui-design/subscription","commits_url":"https://api.github.com/repos/kubevirt/web-ui-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/web-ui-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/web-ui-design/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/web-ui-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/web-ui-design/merges","archive_url":"https://api.github.com/repos/kubevirt/web-ui-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/web-ui-design/downloads","issues_url":"https://api.github.com/repos/kubevirt/web-ui-design/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/web-ui-design/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/web-ui-design/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/web-ui-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/web-ui-design/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/web-ui-design/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/web-ui-design/deployments","created_at":"2018-08-28T14:05:32Z","updated_at":"2018-09-26T14:11:36Z","pushed_at":"2018-09-27T14:57:14Z","git_url":"git://github.com/kubevirt/web-ui-design.git","ssh_url":"git@github.com:kubevirt/web-ui-design.git","clone_url":"https://github.com/kubevirt/web-ui-design.git","svn_url":"https://github.com/kubevirt/web-ui-design","homepage":"","size":1618,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10"},"html":{"href":"https://github.com/kubevirt/web-ui-design/pull/10"},"issue":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/issues/10"},"comments":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/web-ui-design/statuses/efae52d0197701b02914e2a614dfb75048d94385"}},"author_association":"NONE"}}
{"actor":{"display_login":"jelkosz"}}