{"action":"created","issue":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/461","repository_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/461/labels{/name}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/461/comments","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/461/events","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/461","id":334017886,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDkyNDQ1","number":461,"title":"Make jaeger-thrift's shaded JAR the default one","user":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"labels":[{"id":711415642,"node_id":"MDU6TGFiZWw3MTE0MTU2NDI=","url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/labels/review","name":"review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"assignees":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-06-20T10:31:22Z","updated_at":"2018-06-21T09:58:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/461","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/461","diff_url":"https://github.com/jaegertracing/jaeger-client-java/pull/461.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-java/pull/461.patch"},"body":"Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>\r\n\r\n## Which problem is this PR solving?\r\n- Resolves #460 \r\n\r\n## Short description of the changes\r\n- Changed classifiers for both the `jar` task and `shadowJar`\r\n- Changed shadowed dependencies to `compileOnly` so that depending projects won't transitively depend on Thrift and OkHttp.\r\n- Changed the README to be accurate with the current situation (plus some minor improvements)\r\n\r\nA project depending on `jaeger-thrift` with this change will have this automatically pulled:\r\n\r\n```\r\n[INFO] +- io.jaegertracing:jaeger-thrift:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |  \\- io.jaegertracing:jaeger-core:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |     +- io.opentracing:opentracing-api:jar:0.31.0:compile\r\n[INFO] |     +- io.opentracing:opentracing-util:jar:0.31.0:compile\r\n[INFO] |     +- com.google.code.gson:gson:jar:2.8.2:compile\r\n[INFO] |     \\- org.slf4j:slf4j-api:jar:1.7.25:compile\r\n```\r\n\r\nAnd without this change:\r\n\r\n```\r\n[INFO] +- io.jaegertracing:jaeger-thrift:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |  +- io.jaegertracing:jaeger-core:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |  |  +- io.opentracing:opentracing-api:jar:0.31.0:compile\r\n[INFO] |  |  +- io.opentracing:opentracing-util:jar:0.31.0:compile\r\n[INFO] |  |  +- com.google.code.gson:gson:jar:2.8.2:compile\r\n[INFO] |  |  \\- org.slf4j:slf4j-api:jar:1.7.25:compile\r\n[INFO] |  +- org.apache.thrift:libthrift:jar:0.11.0:compile\r\n[INFO] |  |  +- org.apache.httpcomponents:httpclient:jar:4.5.3:compile\r\n[INFO] |  |  |  \\- commons-codec:commons-codec:jar:1.10:compile\r\n[INFO] |  |  \\- org.apache.httpcomponents:httpcore:jar:4.4.8:compile\r\n[INFO] |  \\- com.squareup.okhttp3:okhttp:jar:3.9.0:compile\r\n[INFO] |     \\- com.squareup.okio:okio:jar:1.13.0:compile\r\n```"},"comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/comments/399046615","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/461#issuecomment-399046615","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/461","id":399046615,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTA0NjYxNQ==","user":{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T09:58:42Z","updated_at":"2018-06-21T09:58:42Z","author_association":"MEMBER","body":"For the record, I tested this manually by running the `customer` service from the [istio-tutorial](https://github.com/redhat-developer-demos/istio-tutorial) with the following dependencies, after running a `./gradlew clean check install`:\r\n\r\n```xml\r\n        <dependency>\r\n            <groupId>io.jaegertracing</groupId>\r\n            <artifactId>jaeger-thrift</artifactId>\r\n            <version>0.29.1-SNAPSHOT</version>\r\n        </dependency>\r\n        <dependency>\r\n            <groupId>io.jaegertracing</groupId>\r\n            <artifactId>jaeger-tracerresolver</artifactId>\r\n            <version>0.29.1-SNAPSHOT</version>\r\n        </dependency>\r\n```\r\n\r\nThis is the relevant `dependency:tree` section:\r\n\r\n```\r\n[INFO] +- io.jaegertracing:jaeger-thrift:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |  \\- io.jaegertracing:jaeger-core:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |     +- io.opentracing:opentracing-api:jar:0.31.0:compile\r\n[INFO] |     +- io.opentracing:opentracing-util:jar:0.31.0:compile\r\n[INFO] |     +- com.google.code.gson:gson:jar:2.8.2:compile\r\n[INFO] |     \\- org.slf4j:slf4j-api:jar:1.7.25:compile\r\n[INFO] +- io.jaegertracing:jaeger-tracerresolver:jar:0.29.1-SNAPSHOT:compile\r\n[INFO] |  \\- io.opentracing.contrib:opentracing-tracerresolver:jar:0.1.4:compile\r\n```"}}
{"actor":{"display_login":"jpkrohling"}}