{"action":"opened","number":20,"pull_request":{"url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/20","id":231094615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDk0NjE1","html_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize/pull/20","diff_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize/pull/20.diff","patch_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize/pull/20.patch","issue_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/20","number":20,"state":"open","locked":false,"title":"✨ Add \"previousFlowNodeInstanceId\" to FlowNodeHandlers","user":{"login":"ElRaptorus","id":15343316,"node_id":"MDQ6VXNlcjE1MzQzMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/15343316?v=4","gravatar_id":"","url":"https://api.github.com/users/ElRaptorus","html_url":"https://github.com/ElRaptorus","followers_url":"https://api.github.com/users/ElRaptorus/followers","following_url":"https://api.github.com/users/ElRaptorus/following{/other_user}","gists_url":"https://api.github.com/users/ElRaptorus/gists{/gist_id}","starred_url":"https://api.github.com/users/ElRaptorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElRaptorus/subscriptions","organizations_url":"https://api.github.com/users/ElRaptorus/orgs","repos_url":"https://api.github.com/users/ElRaptorus/repos","events_url":"https://api.github.com/users/ElRaptorus/events{/privacy}","received_events_url":"https://api.github.com/users/ElRaptorus/received_events","type":"User","site_admin":false},"body":"**Changes:**\r\n\r\n1. Add `previousFlowNodeInstanceId` to the `persistOnEnter` logic for the `FlowNodeInstanceService`.\r\n2. Add `previousFlowNodeInstanceId` to the `execute` method of the `IFlowNodeHandler` to make it accessible for each FlowNodeHandler.\r\n    * This allows each FlowNodeInstance to get information about the FNI that was executed previously\r\n3. Remove the `flowNode` property from the `IFlowNodeHandler.execute` method and instead use it as a class-property on the `FlowNodeHandler` base class\r\n    * This avoids having to toss around the FlowNode through each and every class method of the FlowNodeHandler. That never made much sense to begin with.\r\n    * Outside components can get a Handlers FlowNode through the `getFlowNode` accessor function\r\n\r\n\r\n**Issues:**\r\n\r\nPrerequisite of #167\r\n\r\nPR: #100\r\n\r\n## How can others test the changes?\r\n\r\nAll should work as before, except that each FNI will now handle the `previousFlowNodeInstance` property.\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [x] You can merge this PR **right now** (if not, please prefix the title with \"WIP: \")\r\n- [x] I've tested **all** changes included in this PR.\r\n- [x] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.).\r\n- [x] I've rebased the `develop` branch with my branch before finishing this PR.\r\n- [x] I've **summarized all changes** in a list above.\r\n- [x] I've mentioned all **PRs, which relate to this one**.\r\n- [x] I've prefixed my Pull Request title is according to [gitmoji guide](https://gitmoji.carloscuesta.me/).\r\n\r\n## Example\r\n\r\n<details>\r\n<summary>\r\n:warning: Before merging please click here to expand and follow the guide.\r\n</summary>\r\n<br>\r\n\r\nPlease use `:twisted_rightwards_arrows:` at the beginning of your merge commit title.\r\n\r\nExample 1:\r\n\r\n<pre>\r\n<code>\r\n:twisted_rightwards_arrows: :bug: Fix Wrong Text Decoration at ...\r\n</code>\r\n</pre>\r\n\r\nTo get your commit message, just copy the first part of this pull request.\r\n\r\nExample 2:\r\n<pre>\r\n<code>\r\n**Changes:**\r\n\r\n- Fixes Wrong Text Decoration at ...\r\n- Fixes some typos\r\n- ...\r\n\r\n**Issues:**\r\n\r\nCloses #NumberOfFixedIssue\r\n\r\nPR: #NumberOfThisPR\r\n</code>\r\n</pre>\r\n</details>\r\n\r\n## Emojis\r\n\r\n<details>\r\n<summary>\r\nExpand for a list of most used Emojis.\r\n</summary>\r\n<br>\r\n\r\nPlease prefix your commit messages with an Emoji.\r\n\r\nRef: https://gitmoji.carloscuesta.me/\r\n\r\n| Description              | Glyphe               | Emoji  |\r\n|--------------------------|----------------------|--------|\r\n| Bugfix                   | `:bug:`              | 🐛     |\r\n| Fixing Security Issues   | `:lock:`             | 🔒     |\r\n| Configuration releated   | `:wrench:`           | 🔧     |\r\n| Cosmetic                 | `:lipstick:`         | 💄     |\r\n| Dependencies Downgrade   | `:arrow_down:`       | ⬇️     |\r\n| Dependencies Upgrade     | `:arrow_up:`         | ⬆️     |\r\n| Formatting               | `:art:`              | 🎨     |\r\n| Improving Performance    | `:zap:`              | ⚡️      |\r\n| Initial commit           | `:tada:`             | 🎉     |\r\n| Linter                   | `:rotating_light:`   | 🚨     |\r\n| Miscellaneous            | `:package:`          | 📦     |\r\n| New Feature              | `:sparkles:`         | ✨     |\r\n| Refactoring Code         | `:recycle:`          | ♻️      |\r\n| Releasing / Version tags | `:bookmark:`         | 🔖     |\r\n| Removing Stuff           | `:fire:`             | 🔥     |\r\n| Tests                    | `:white_check_mark:` | ✅     |\r\n| Work In Progress (WIP)   | `:construction:`     | 🚧     |\r\n\r\n</details>\r\n","created_at":"2018-11-15T07:32:03Z","updated_at":"2018-11-15T07:32:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/20/commits","review_comments_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/20/comments","review_comment_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/20/comments","statuses_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/statuses/d8ffe3b05e31c9428cbac441d1387989bd1c2724","head":{"label":"process-engine:feature/add_previous_fni_id","ref":"feature/add_previous_fni_id","sha":"d8ffe3b05e31c9428cbac441d1387989bd1c2724","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":140286981,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyODY5ODE=","name":"flow_node_instance.repository.sequelize","full_name":"process-engine/flow_node_instance.repository.sequelize","private":false,"owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize","description":"Contains the repository for accessing flow node instance data, by using sequelize. ","fork":false,"url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize","forks_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/forks","keys_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/teams","hooks_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/hooks","issue_events_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/events","assignees_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/tags","blobs_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/languages","stargazers_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/stargazers","contributors_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/contributors","subscribers_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/subscribers","subscription_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/subscription","commits_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/merges","archive_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/downloads","issues_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/deployments","created_at":"2018-07-09T13:07:58Z","updated_at":"2018-11-14T09:58:05Z","pushed_at":"2018-11-15T07:24:18Z","git_url":"git://github.com/process-engine/flow_node_instance.repository.sequelize.git","ssh_url":"git@github.com:process-engine/flow_node_instance.repository.sequelize.git","clone_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize.git","svn_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"19231eb0ab2045b6096f0830451178351efdc97e","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":140286981,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyODY5ODE=","name":"flow_node_instance.repository.sequelize","full_name":"process-engine/flow_node_instance.repository.sequelize","private":false,"owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize","description":"Contains the repository for accessing flow node instance data, by using sequelize. ","fork":false,"url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize","forks_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/forks","keys_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/teams","hooks_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/hooks","issue_events_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/events","assignees_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/tags","blobs_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/languages","stargazers_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/stargazers","contributors_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/contributors","subscribers_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/subscribers","subscription_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/subscription","commits_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/merges","archive_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/downloads","issues_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/deployments","created_at":"2018-07-09T13:07:58Z","updated_at":"2018-11-14T09:58:05Z","pushed_at":"2018-11-15T07:24:18Z","git_url":"git://github.com/process-engine/flow_node_instance.repository.sequelize.git","ssh_url":"git@github.com:process-engine/flow_node_instance.repository.sequelize.git","clone_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize.git","svn_url":"https://github.com/process-engine/flow_node_instance.repository.sequelize","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/20"},"html":{"href":"https://github.com/process-engine/flow_node_instance.repository.sequelize/pull/20"},"issue":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/20"},"comments":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/flow_node_instance.repository.sequelize/statuses/d8ffe3b05e31c9428cbac441d1387989bd1c2724"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":15,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"ElRaptorus"}}