{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/comments/165365730","pull_request_review_id":93291064,"id":165365730,"diff_hunk":"@@ -371,3 +129,12 @@ install(\n   NAMESPACE \"${namespace}\"\n   DESTINATION \"${config_install_dir}\"\n )\n+\n+option(BUILD_TESTING \"Build unit test\" ON)\n+if (BUILD_TESTING)\n+  enable_testing()\n+  add_custom_target(check COMMAND echo \"run make test instead\")","path":"CMakeLists.txt","position":356,"original_position":356,"commit_id":"791c13676047f2ce73860bbc7307f7eeb2d944cf","original_commit_id":"791c13676047f2ce73860bbc7307f7eeb2d944cf","user":{"login":"isaachier","id":2578297,"avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"Cool","created_at":"2018-02-01T14:11:46Z","updated_at":"2018-02-01T14:16:44Z","html_url":"https://github.com/jaegertracing/cpp-client/pull/46#discussion_r165365730","pull_request_url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/comments/165365730"},"html":{"href":"https://github.com/jaegertracing/cpp-client/pull/46#discussion_r165365730"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46","id":165565451,"html_url":"https://github.com/jaegertracing/cpp-client/pull/46","diff_url":"https://github.com/jaegertracing/cpp-client/pull/46.diff","patch_url":"https://github.com/jaegertracing/cpp-client/pull/46.patch","issue_url":"https://api.github.com/repos/jaegertracing/cpp-client/issues/46","number":46,"state":"open","locked":false,"title":"Support building with local dependencies (no Hunter)","user":{"login":"ringerc","id":274337,"avatar_url":"https://avatars2.githubusercontent.com/u/274337?v=4","gravatar_id":"","url":"https://api.github.com/users/ringerc","html_url":"https://github.com/ringerc","followers_url":"https://api.github.com/users/ringerc/followers","following_url":"https://api.github.com/users/ringerc/following{/other_user}","gists_url":"https://api.github.com/users/ringerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ringerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringerc/subscriptions","organizations_url":"https://api.github.com/users/ringerc/orgs","repos_url":"https://api.github.com/users/ringerc/repos","events_url":"https://api.github.com/users/ringerc/events{/privacy}","received_events_url":"https://api.github.com/users/ringerc/received_events","type":"User","site_admin":false},"body":"jaeger-cpp defaults to using Hunter to download its dependencies off the 'net,\r\neven if they exist locally. This is convenient for development but not\r\npractical for some production environments. It also makes life hard for clients\r\nthat want to link to jaeger-cpp since Hunter doesn't install those\r\ndependencies. It's necessary to also use Hunter in apps that use a jaeger-cpp\r\nbuilt this way... and that's not always practical.\r\n\r\nAccordingly, add support for finding jaeger-cpp's dependencies via the normal\r\nCMake package discovery mechanism.\r\n\r\nA sligtly unsightly hack is required for nlohmann json, because its header\r\nmoved from json.hpp to nlohmann/json.hpp in 2.1.0.\r\n\r\nThis introduces support for building with\r\n\r\n   cmake -DHUNTER_ENABLED=0\r\n\r\nWIP:\r\n\r\n  - nothing packages nlohmann json 2.1.0 yet, 2.0.2 is widespread.\r\n    but jaegertracing's code doesn't appear to support 2.0.2. For now you\r\n    should work around it by installing 2.1.x locally from source.\r\n    (no bug opened yet)\r\n\r\n  - will fail to compile tests if the local thrift is 0.9.1 since there are\r\n    committed generated files from 0.9.2 (#45) and there's no mechanism\r\n    to regenerate them.\r\n\r\nThe nlohmann json issue is beyond my C++-fu, but it's easy enough to install 2.1.x and it's just a header. A pain, but manageable.\r\n\r\nThe Thrift issue #45 is a bit more of an issue; I'm on Fedora 25 with 0.9.1 right now, but Fedora Extras for RHEL7 also carries 0.9.1. More to the point, it's probably bad to rely on a code generator's output being compatible across multiple versions of its library.","created_at":"2018-01-28T12:51:24Z","updated_at":"2018-02-01T14:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08cf9d0ff3ac4b19c5c951fa4ecb8c8d88503f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/cpp-client/issues/46/comments","statuses_url":"https://api.github.com/repos/jaegertracing/cpp-client/statuses/791c13676047f2ce73860bbc7307f7eeb2d944cf","head":{"label":"ringerc:local-dependencies-support","ref":"local-dependencies-support","sha":"791c13676047f2ce73860bbc7307f7eeb2d944cf","user":{"login":"ringerc","id":274337,"avatar_url":"https://avatars2.githubusercontent.com/u/274337?v=4","gravatar_id":"","url":"https://api.github.com/users/ringerc","html_url":"https://github.com/ringerc","followers_url":"https://api.github.com/users/ringerc/followers","following_url":"https://api.github.com/users/ringerc/following{/other_user}","gists_url":"https://api.github.com/users/ringerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ringerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringerc/subscriptions","organizations_url":"https://api.github.com/users/ringerc/orgs","repos_url":"https://api.github.com/users/ringerc/repos","events_url":"https://api.github.com/users/ringerc/events{/privacy}","received_events_url":"https://api.github.com/users/ringerc/received_events","type":"User","site_admin":false},"repo":{"id":119056542,"name":"cpp-client","full_name":"ringerc/cpp-client","owner":{"login":"ringerc","id":274337,"avatar_url":"https://avatars2.githubusercontent.com/u/274337?v=4","gravatar_id":"","url":"https://api.github.com/users/ringerc","html_url":"https://github.com/ringerc","followers_url":"https://api.github.com/users/ringerc/followers","following_url":"https://api.github.com/users/ringerc/following{/other_user}","gists_url":"https://api.github.com/users/ringerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ringerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringerc/subscriptions","organizations_url":"https://api.github.com/users/ringerc/orgs","repos_url":"https://api.github.com/users/ringerc/repos","events_url":"https://api.github.com/users/ringerc/events{/privacy}","received_events_url":"https://api.github.com/users/ringerc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ringerc/cpp-client","description":"C++ OpenTracing binding for Jaeger","fork":true,"url":"https://api.github.com/repos/ringerc/cpp-client","forks_url":"https://api.github.com/repos/ringerc/cpp-client/forks","keys_url":"https://api.github.com/repos/ringerc/cpp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ringerc/cpp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ringerc/cpp-client/teams","hooks_url":"https://api.github.com/repos/ringerc/cpp-client/hooks","issue_events_url":"https://api.github.com/repos/ringerc/cpp-client/issues/events{/number}","events_url":"https://api.github.com/repos/ringerc/cpp-client/events","assignees_url":"https://api.github.com/repos/ringerc/cpp-client/assignees{/user}","branches_url":"https://api.github.com/repos/ringerc/cpp-client/branches{/branch}","tags_url":"https://api.github.com/repos/ringerc/cpp-client/tags","blobs_url":"https://api.github.com/repos/ringerc/cpp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ringerc/cpp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ringerc/cpp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ringerc/cpp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ringerc/cpp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ringerc/cpp-client/languages","stargazers_url":"https://api.github.com/repos/ringerc/cpp-client/stargazers","contributors_url":"https://api.github.com/repos/ringerc/cpp-client/contributors","subscribers_url":"https://api.github.com/repos/ringerc/cpp-client/subscribers","subscription_url":"https://api.github.com/repos/ringerc/cpp-client/subscription","commits_url":"https://api.github.com/repos/ringerc/cpp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ringerc/cpp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ringerc/cpp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ringerc/cpp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ringerc/cpp-client/contents/{+path}","compare_url":"https://api.github.com/repos/ringerc/cpp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ringerc/cpp-client/merges","archive_url":"https://api.github.com/repos/ringerc/cpp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ringerc/cpp-client/downloads","issues_url":"https://api.github.com/repos/ringerc/cpp-client/issues{/number}","pulls_url":"https://api.github.com/repos/ringerc/cpp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ringerc/cpp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ringerc/cpp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ringerc/cpp-client/labels{/name}","releases_url":"https://api.github.com/repos/ringerc/cpp-client/releases{/id}","deployments_url":"https://api.github.com/repos/ringerc/cpp-client/deployments","created_at":"2018-01-26T13:47:14Z","updated_at":"2018-01-26T23:48:42Z","pushed_at":"2018-02-01T07:50:53Z","git_url":"git://github.com/ringerc/cpp-client.git","ssh_url":"git@github.com:ringerc/cpp-client.git","clone_url":"https://github.com/ringerc/cpp-client.git","svn_url":"https://github.com/ringerc/cpp-client","homepage":"http://jaegertracing.io/","size":261,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"2e229042d4d7804d07c2f1fcc8c6fe2d256eac64","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":100960701,"name":"cpp-client","full_name":"jaegertracing/cpp-client","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/cpp-client","description":"C++ OpenTracing binding for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/cpp-client","forks_url":"https://api.github.com/repos/jaegertracing/cpp-client/forks","keys_url":"https://api.github.com/repos/jaegertracing/cpp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/cpp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/cpp-client/teams","hooks_url":"https://api.github.com/repos/jaegertracing/cpp-client/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/cpp-client/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/cpp-client/events","assignees_url":"https://api.github.com/repos/jaegertracing/cpp-client/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/cpp-client/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/cpp-client/tags","blobs_url":"https://api.github.com/repos/jaegertracing/cpp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/cpp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/cpp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/cpp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/cpp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/cpp-client/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/cpp-client/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/cpp-client/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/cpp-client/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/cpp-client/subscription","commits_url":"https://api.github.com/repos/jaegertracing/cpp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/cpp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/cpp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/cpp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/cpp-client/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/cpp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/cpp-client/merges","archive_url":"https://api.github.com/repos/jaegertracing/cpp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/cpp-client/downloads","issues_url":"https://api.github.com/repos/jaegertracing/cpp-client/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/cpp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/cpp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/cpp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/cpp-client/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/cpp-client/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/cpp-client/deployments","created_at":"2017-08-21T14:33:13Z","updated_at":"2018-01-19T18:24:47Z","pushed_at":"2018-02-01T14:03:46Z","git_url":"git://github.com/jaegertracing/cpp-client.git","ssh_url":"git@github.com:jaegertracing/cpp-client.git","clone_url":"https://github.com/jaegertracing/cpp-client.git","svn_url":"https://github.com/jaegertracing/cpp-client","homepage":"http://jaegertracing.io/","size":240,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46"},"html":{"href":"https://github.com/jaegertracing/cpp-client/pull/46"},"issue":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/issues/46"},"comments":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/cpp-client/statuses/791c13676047f2ce73860bbc7307f7eeb2d944cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isaachier"}}