{"action":"created","comment":{"url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/comments/202967387","pull_request_review_id":137759148,"id":202967387,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjk2NzM4Nw==","diff_hunk":"@@ -1,38 +1,45 @@\n <domain type='{{ libvirt_vm_engine }}'>\n-  <name>{{ libvirt_vm_name }}</name>\n-  <memory>{{ libvirt_vm_memory_mb | int * 1024 }}</memory>\n-  <vcpu>{{ libvirt_vm_vcpus }}</vcpu>\n+  <name>{{ vm.name }}</name>\n+  <memory>{{ vm.memory_mb | int * 1024 }}</memory>\n+  <vcpu>{{ vm.vcpus }}</vcpu>\n   <clock sync=\"localtime\"/>\n+  <on_poweroff>destroy</on_poweroff>\n+  <on_reboot>restart</on_reboot>\n+  <on_crash>destroy</on_crash>\n   <os>\n-    <type arch='{{ libvirt_vm_arch }}'{% if libvirt_vm_machine is not none %} machine='{{ libvirt_vm_machine }}'{% endif %}>hvm</type>\n+    <type arch='{{ libvirt_vm_arch }}'{% if vm.machine is defined %} machine='{{ vm.machine | default('pc-1.0') }}'{% endif %}>hvm</type>","path":"templates/vm.xml.j2","position":14,"original_position":14,"commit_id":"766989614eb7f3deea931df2a170728f1468bff6","original_commit_id":"766989614eb7f3deea931df2a170728f1468bff6","user":{"login":"markgoddard","id":5795873,"node_id":"MDQ6VXNlcjU3OTU4NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5795873?v=4","gravatar_id":"","url":"https://api.github.com/users/markgoddard","html_url":"https://github.com/markgoddard","followers_url":"https://api.github.com/users/markgoddard/followers","following_url":"https://api.github.com/users/markgoddard/following{/other_user}","gists_url":"https://api.github.com/users/markgoddard/gists{/gist_id}","starred_url":"https://api.github.com/users/markgoddard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markgoddard/subscriptions","organizations_url":"https://api.github.com/users/markgoddard/orgs","repos_url":"https://api.github.com/users/markgoddard/repos","events_url":"https://api.github.com/users/markgoddard/events{/privacy}","received_events_url":"https://api.github.com/users/markgoddard/received_events","type":"User","site_admin":false},"body":"Not sure the logic is quite right here. Docs say:\r\n\r\nDefault is `None` if `engine` is `kvm`, otherwise `pc-1.0`.\r\n\r\nYou can use {% set var=val %} if the logic gets hairy.","created_at":"2018-07-17T10:14:11Z","updated_at":"2018-07-17T10:20:27Z","html_url":"https://github.com/stackhpc/ansible-role-libvirt-vm/pull/1#discussion_r202967387","pull_request_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/comments/202967387"},"html":{"href":"https://github.com/stackhpc/ansible-role-libvirt-vm/pull/1#discussion_r202967387"},"pull_request":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1","id":201872746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODcyNzQ2","html_url":"https://github.com/stackhpc/ansible-role-libvirt-vm/pull/1","diff_url":"https://github.com/stackhpc/ansible-role-libvirt-vm/pull/1.diff","patch_url":"https://github.com/stackhpc/ansible-role-libvirt-vm/pull/1.patch","issue_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues/1","number":1,"state":"open","locked":false,"title":"Allow specification of multiple VMs","user":{"login":"w-miller","id":14925373,"node_id":"MDQ6VXNlcjE0OTI1Mzcz","avatar_url":"https://avatars0.githubusercontent.com/u/14925373?v=4","gravatar_id":"","url":"https://api.github.com/users/w-miller","html_url":"https://github.com/w-miller","followers_url":"https://api.github.com/users/w-miller/followers","following_url":"https://api.github.com/users/w-miller/following{/other_user}","gists_url":"https://api.github.com/users/w-miller/gists{/gist_id}","starred_url":"https://api.github.com/users/w-miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w-miller/subscriptions","organizations_url":"https://api.github.com/users/w-miller/orgs","repos_url":"https://api.github.com/users/w-miller/repos","events_url":"https://api.github.com/users/w-miller/events{/privacy}","received_events_url":"https://api.github.com/users/w-miller/received_events","type":"User","site_admin":false},"body":"Also some other minor fixes.","created_at":"2018-07-17T09:10:15Z","updated_at":"2018-07-17T10:20:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33bf6b7b202235c6644cd0b4c80ba4d040134d13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1/commits","review_comments_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1/comments","review_comment_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues/1/comments","statuses_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/statuses/766989614eb7f3deea931df2a170728f1468bff6","head":{"label":"w-miller:vm_list2","ref":"vm_list2","sha":"766989614eb7f3deea931df2a170728f1468bff6","user":{"login":"w-miller","id":14925373,"node_id":"MDQ6VXNlcjE0OTI1Mzcz","avatar_url":"https://avatars0.githubusercontent.com/u/14925373?v=4","gravatar_id":"","url":"https://api.github.com/users/w-miller","html_url":"https://github.com/w-miller","followers_url":"https://api.github.com/users/w-miller/followers","following_url":"https://api.github.com/users/w-miller/following{/other_user}","gists_url":"https://api.github.com/users/w-miller/gists{/gist_id}","starred_url":"https://api.github.com/users/w-miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w-miller/subscriptions","organizations_url":"https://api.github.com/users/w-miller/orgs","repos_url":"https://api.github.com/users/w-miller/repos","events_url":"https://api.github.com/users/w-miller/events{/privacy}","received_events_url":"https://api.github.com/users/w-miller/received_events","type":"User","site_admin":false},"repo":{"id":140582885,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1ODI4ODU=","name":"ansible-role-libvirt-vm","full_name":"w-miller/ansible-role-libvirt-vm","owner":{"login":"w-miller","id":14925373,"node_id":"MDQ6VXNlcjE0OTI1Mzcz","avatar_url":"https://avatars0.githubusercontent.com/u/14925373?v=4","gravatar_id":"","url":"https://api.github.com/users/w-miller","html_url":"https://github.com/w-miller","followers_url":"https://api.github.com/users/w-miller/followers","following_url":"https://api.github.com/users/w-miller/following{/other_user}","gists_url":"https://api.github.com/users/w-miller/gists{/gist_id}","starred_url":"https://api.github.com/users/w-miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w-miller/subscriptions","organizations_url":"https://api.github.com/users/w-miller/orgs","repos_url":"https://api.github.com/users/w-miller/repos","events_url":"https://api.github.com/users/w-miller/events{/privacy}","received_events_url":"https://api.github.com/users/w-miller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w-miller/ansible-role-libvirt-vm","description":"This role configures and creates VMs on a KVM/QEMU hypervisor.","fork":true,"url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm","forks_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/forks","keys_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/teams","hooks_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/hooks","issue_events_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/issues/events{/number}","events_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/events","assignees_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/assignees{/user}","branches_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/branches{/branch}","tags_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/tags","blobs_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/languages","stargazers_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/stargazers","contributors_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/contributors","subscribers_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/subscribers","subscription_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/subscription","commits_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/contents/{+path}","compare_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/merges","archive_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/downloads","issues_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/issues{/number}","pulls_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/labels{/name}","releases_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/releases{/id}","deployments_url":"https://api.github.com/repos/w-miller/ansible-role-libvirt-vm/deployments","created_at":"2018-07-11T13:58:27Z","updated_at":"2018-07-12T14:26:44Z","pushed_at":"2018-07-16T10:33:12Z","git_url":"git://github.com/w-miller/ansible-role-libvirt-vm.git","ssh_url":"git@github.com:w-miller/ansible-role-libvirt-vm.git","clone_url":"https://github.com/w-miller/ansible-role-libvirt-vm.git","svn_url":"https://github.com/w-miller/ansible-role-libvirt-vm","homepage":"","size":24,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stackhpc:support-virt-engine","ref":"support-virt-engine","sha":"3e886a73fe20d240d1861f0768a8282ed4f39520","user":{"login":"stackhpc","id":22750772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUwNzcy","avatar_url":"https://avatars2.githubusercontent.com/u/22750772?v=4","gravatar_id":"","url":"https://api.github.com/users/stackhpc","html_url":"https://github.com/stackhpc","followers_url":"https://api.github.com/users/stackhpc/followers","following_url":"https://api.github.com/users/stackhpc/following{/other_user}","gists_url":"https://api.github.com/users/stackhpc/gists{/gist_id}","starred_url":"https://api.github.com/users/stackhpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackhpc/subscriptions","organizations_url":"https://api.github.com/users/stackhpc/orgs","repos_url":"https://api.github.com/users/stackhpc/repos","events_url":"https://api.github.com/users/stackhpc/events{/privacy}","received_events_url":"https://api.github.com/users/stackhpc/received_events","type":"Organization","site_admin":false},"repo":{"id":113180256,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxODAyNTY=","name":"ansible-role-libvirt-vm","full_name":"stackhpc/ansible-role-libvirt-vm","owner":{"login":"stackhpc","id":22750772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUwNzcy","avatar_url":"https://avatars2.githubusercontent.com/u/22750772?v=4","gravatar_id":"","url":"https://api.github.com/users/stackhpc","html_url":"https://github.com/stackhpc","followers_url":"https://api.github.com/users/stackhpc/followers","following_url":"https://api.github.com/users/stackhpc/following{/other_user}","gists_url":"https://api.github.com/users/stackhpc/gists{/gist_id}","starred_url":"https://api.github.com/users/stackhpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackhpc/subscriptions","organizations_url":"https://api.github.com/users/stackhpc/orgs","repos_url":"https://api.github.com/users/stackhpc/repos","events_url":"https://api.github.com/users/stackhpc/events{/privacy}","received_events_url":"https://api.github.com/users/stackhpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stackhpc/ansible-role-libvirt-vm","description":"This role configures and creates a VM on a KVM hypervisor.","fork":false,"url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm","forks_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/forks","keys_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/teams","hooks_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/hooks","issue_events_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues/events{/number}","events_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/events","assignees_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/assignees{/user}","branches_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/branches{/branch}","tags_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/tags","blobs_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/languages","stargazers_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/stargazers","contributors_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/contributors","subscribers_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/subscribers","subscription_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/subscription","commits_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/contents/{+path}","compare_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/merges","archive_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/downloads","issues_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues{/number}","pulls_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/labels{/name}","releases_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/releases{/id}","deployments_url":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/deployments","created_at":"2017-12-05T12:37:27Z","updated_at":"2018-03-04T22:04:41Z","pushed_at":"2018-07-17T09:10:15Z","git_url":"git://github.com/stackhpc/ansible-role-libvirt-vm.git","ssh_url":"git@github.com:stackhpc/ansible-role-libvirt-vm.git","clone_url":"https://github.com/stackhpc/ansible-role-libvirt-vm.git","svn_url":"https://github.com/stackhpc/ansible-role-libvirt-vm","homepage":null,"size":10,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1"},"html":{"href":"https://github.com/stackhpc/ansible-role-libvirt-vm/pull/1"},"issue":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues/1"},"comments":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/stackhpc/ansible-role-libvirt-vm/statuses/766989614eb7f3deea931df2a170728f1468bff6"}},"author_association":"NONE"}}
{"actor":{"display_login":"markgoddard"}}