{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/197319357","pull_request_review_id":131042724,"id":197319357,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzMxOTM1Nw==","diff_hunk":"@@ -497,44 +497,40 @@ extension TFState {\n       targetNodeSpecs.append(helperFuncNode)\n     }\n \n-    if returnValues.count > 0 {\n-      if _RuntimeConfig.executionMode.isTPU {\n-        debugLog(\"Enable TPU execution.\")\n-        // When infeed is enabled, run it along with the output tensor nodes\n-        // below.\n-        let infeedEnqueueNode = TF_GraphOperationByName(graph,\n-                                                        \"InfeedEnqueueTuple\")\n-        if let infeedEnqueueNode = infeedEnqueueNode {\n-          targetNodeSpecs.append(infeedEnqueueNode)\n-          debugLog(\"Running enqueue with \\(inputTensors.count) input tensors.\")\n-        }\n+    if returnValues.count == 0 {","path":"stdlib/public/TensorFlow/CompilerRuntime.swift","position":15,"original_position":15,"commit_id":"45b77be671afc886398db5a5fab9818a75c5db9b","original_commit_id":"45b77be671afc886398db5a5fab9818a75c5db9b","user":{"login":"lattner","id":15152540,"node_id":"MDQ6VXNlcjE1MTUyNTQw","avatar_url":"https://avatars0.githubusercontent.com/u/15152540?v=4","gravatar_id":"","url":"https://api.github.com/users/lattner","html_url":"https://github.com/lattner","followers_url":"https://api.github.com/users/lattner/followers","following_url":"https://api.github.com/users/lattner/following{/other_user}","gists_url":"https://api.github.com/users/lattner/gists{/gist_id}","starred_url":"https://api.github.com/users/lattner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lattner/subscriptions","organizations_url":"https://api.github.com/users/lattner/orgs","repos_url":"https://api.github.com/users/lattner/repos","events_url":"https://api.github.com/users/lattner/events{/privacy}","received_events_url":"https://api.github.com/users/lattner/received_events","type":"User","site_admin":false},"body":"Yep, that would be more idiomatic.","created_at":"2018-06-22T01:28:39Z","updated_at":"2018-06-22T01:29:17Z","html_url":"https://github.com/apple/swift/pull/17410#discussion_r197319357","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/17410","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/197319357"},"html":{"href":"https://github.com/apple/swift/pull/17410#discussion_r197319357"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/17410"}},"in_reply_to_id":197307504},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/17410","id":196603566,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjAzNTY2","html_url":"https://github.com/apple/swift/pull/17410","diff_url":"https://github.com/apple/swift/pull/17410.diff","patch_url":"https://github.com/apple/swift/pull/17410.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/17410","number":17410,"state":"open","locked":false,"title":"When a TF program has no result tensors, run the function as a target…","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"body":"… node\r\n\r\ninstead of skipping its execution. This is needed for correctnesss, because the\r\nTF program execution could have side effects such as sending/enqueuing tensors.\r\n\r\nAdded compiler and run-time unit tests on such an example.\r\n\r\n<!-- What's in this pull request? -->\r\nReplace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-NNNN](https://bugs.swift.org/browse/SR-NNNN).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2018-06-21T23:37:07Z","updated_at":"2018-06-22T01:29:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe8c926d222b570933dbda5dbf42a94ef1ccb4aa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bgogul","id":6721579,"node_id":"MDQ6VXNlcjY3MjE1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6721579?v=4","gravatar_id":"","url":"https://api.github.com/users/bgogul","html_url":"https://github.com/bgogul","followers_url":"https://api.github.com/users/bgogul/followers","following_url":"https://api.github.com/users/bgogul/following{/other_user}","gists_url":"https://api.github.com/users/bgogul/gists{/gist_id}","starred_url":"https://api.github.com/users/bgogul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgogul/subscriptions","organizations_url":"https://api.github.com/users/bgogul/orgs","repos_url":"https://api.github.com/users/bgogul/repos","events_url":"https://api.github.com/users/bgogul/events{/privacy}","received_events_url":"https://api.github.com/users/bgogul/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/17410/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/17410/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/17410/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/45b77be671afc886398db5a5fab9818a75c5db9b","head":{"label":"mhong:tf_program_with_no_result_SR-7705","ref":"tf_program_with_no_result_SR-7705","sha":"45b77be671afc886398db5a5fab9818a75c5db9b","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"repo":{"id":119768422,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3Njg0MjI=","name":"swift","full_name":"mhong/swift","owner":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhong/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/mhong/swift","forks_url":"https://api.github.com/repos/mhong/swift/forks","keys_url":"https://api.github.com/repos/mhong/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhong/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhong/swift/teams","hooks_url":"https://api.github.com/repos/mhong/swift/hooks","issue_events_url":"https://api.github.com/repos/mhong/swift/issues/events{/number}","events_url":"https://api.github.com/repos/mhong/swift/events","assignees_url":"https://api.github.com/repos/mhong/swift/assignees{/user}","branches_url":"https://api.github.com/repos/mhong/swift/branches{/branch}","tags_url":"https://api.github.com/repos/mhong/swift/tags","blobs_url":"https://api.github.com/repos/mhong/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhong/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhong/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhong/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhong/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/mhong/swift/languages","stargazers_url":"https://api.github.com/repos/mhong/swift/stargazers","contributors_url":"https://api.github.com/repos/mhong/swift/contributors","subscribers_url":"https://api.github.com/repos/mhong/swift/subscribers","subscription_url":"https://api.github.com/repos/mhong/swift/subscription","commits_url":"https://api.github.com/repos/mhong/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhong/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhong/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhong/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhong/swift/contents/{+path}","compare_url":"https://api.github.com/repos/mhong/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhong/swift/merges","archive_url":"https://api.github.com/repos/mhong/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhong/swift/downloads","issues_url":"https://api.github.com/repos/mhong/swift/issues{/number}","pulls_url":"https://api.github.com/repos/mhong/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/mhong/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/mhong/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhong/swift/labels{/name}","releases_url":"https://api.github.com/repos/mhong/swift/releases{/id}","deployments_url":"https://api.github.com/repos/mhong/swift/deployments","created_at":"2018-02-01T01:57:03Z","updated_at":"2018-02-01T01:57:33Z","pushed_at":"2018-06-22T01:22:34Z","git_url":"git://github.com/mhong/swift.git","ssh_url":"git@github.com:mhong/swift.git","clone_url":"https://github.com/mhong/swift.git","svn_url":"https://github.com/mhong/swift","homepage":"https://swift.org/","size":284767,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"b8b9a302491f0b99b68f8eff5d1df7fe763605be","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-06-22T01:24:02Z","pushed_at":"2018-06-22T01:27:27Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":300036,"stargazers_count":44258,"watchers_count":44258,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6978,"mirror_url":null,"archived":false,"open_issues_count":361,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6978,"open_issues":361,"watchers":44258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/17410"},"html":{"href":"https://github.com/apple/swift/pull/17410"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/17410"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/17410/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/17410/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/17410/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/45b77be671afc886398db5a5fab9818a75c5db9b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lattner"}}