{"action":"created","issue":{"url":"https://api.github.com/repos/brave/brave-browser/issues/1558","repository_url":"https://api.github.com/repos/brave/brave-browser","labels_url":"https://api.github.com/repos/brave/brave-browser/issues/1558/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-browser/issues/1558/comments","events_url":"https://api.github.com/repos/brave/brave-browser/issues/1558/events","html_url":"https://github.com/brave/brave-browser/issues/1558","id":369743036,"node_id":"MDU6SXNzdWUzNjk3NDMwMzY=","number":1558,"title":"Check failed: frame_view->ShouldThrottleRendering() || !Layout_view || !(layout_view->NeedsPaintPropertyUpdate() || layout_view->DescendantNeedsPaintPropertyUpdate())","user":{"login":"garrettr","id":407302,"node_id":"MDQ6VXNlcjQwNzMwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/407302?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettr","html_url":"https://github.com/garrettr","followers_url":"https://api.github.com/users/garrettr/followers","following_url":"https://api.github.com/users/garrettr/following{/other_user}","gists_url":"https://api.github.com/users/garrettr/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettr/subscriptions","organizations_url":"https://api.github.com/users/garrettr/orgs","repos_url":"https://api.github.com/users/garrettr/repos","events_url":"https://api.github.com/users/garrettr/events{/privacy}","received_events_url":"https://api.github.com/users/garrettr/received_events","type":"User","site_admin":false},"labels":[{"id":914757094,"node_id":"MDU6TGFiZWw5MTQ3NTcwOTQ=","url":"https://api.github.com/repos/brave/brave-browser/labels/crash/webview","name":"crash/webview","color":"b60205","default":false},{"id":960953788,"node_id":"MDU6TGFiZWw5NjA5NTM3ODg=","url":"https://api.github.com/repos/brave/brave-browser/labels/debug","name":"debug","color":"e0734c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T23:41:06Z","updated_at":"2018-10-13T00:03:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Description\r\n\r\nOpening `chrome://settings/importData` in a debug build causes the renderer process to crash with the following traceback:\r\n\r\n```\r\n[48969:775:1012/150903.978781:FATAL:intersection_geometry.cc(171)] Check failed: frame_view->ShouldThrottleRendering() || !Layout_view || !(layout_view->NeedsPaintPropertyUpdate() || layout_view->DescendantNeedsPaintPropertyUpdate()).\r\n0   libbase.dylib                       0x000000010734aafe base::debug::StackTrace::StackTrace(unsigned long) + 174\r\n1   libbase.dylib                       0x000000010734abbd base::debug::StackTrace::StackTrace(unsigned long) + 29\r\n2   libbase.dylib                       0x0000000106f22acc base::debug::StackTrace::StackTrace() + 28\r\n3   libbase.dylib                       0x0000000106f9e76c logging::LogMessage::~LogMessage() + 460\r\n4   libbase.dylib                       0x0000000106f9c365 logging::LogMessage::~LogMessage() + 21\r\n5   libblink_core.dylib                 0x000000015143a8ba blink::IntersectionGeometry::ClipToRoot() + 378\r\n6   libblink_core.dylib                 0x000000015143b168 blink::IntersectionGeometry::ComputeGeometry() + 360\r\n7   libblink_core.dylib                 0x0000000151379c5b blink::IntersectionObservation::ComputeIntersectionObservations(double) + 635\r\n8   libblink_core.dylib                 0x000000015137cb21 blink::IntersectionObserver::ComputeIntersectionObservations() + 449\r\n9   libblink_core.dylib                 0x0000000151387b7b blink::IntersectionObserverController::ComputeTrackedIntersectionObservations() + 427\r\n10  libblink_core.dylib                 0x0000000150bfcfa4 blink::LocalFrameView::UpdateViewportIntersectionsForSubtree() + 148\r\n11  libblink_core.dylib                 0x0000000150bfb2e8 blink::LocalFrameView::UpdateLifecyclePhases(blink::DocumentLifecycle::LifecycleState) + 1400\r\n12  libblink_core.dylib                 0x0000000150bfad62 blink::LocalFrameView::UpdateAllLifecyclePhases() + 50\r\n13  libblink_core.dylib                 0x00000001519d8975 blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&) + 85\r\n14  libblink_core.dylib                 0x00000001519e19f0 blink::PageWidgetDelegate::UpdateLifecycle(blink::Page&, blink::LocalFrame&, blink::WebWidget::LifecycleUpdate) + 112\r\n15  libblink_core.dylib                 0x0000000150a33122 blink::WebViewImpl::UpdateLifecycle(blink::WebWidget::LifecycleUpdate) + 386\r\n16  libblink_core.dylib                 0x0000000150cf7ee7 blink::WebViewFrameWidget::UpdateLifecycle(blink::WebWidget::LifecycleUpdate) + 39\r\n17  libcontent.dylib                    0x000000012a5be509 content::RenderWidget::UpdateVisualState(cc::LayerTreeHostClient::VisualStateUpdate) + 105\r\n18  libcontent.dylib                    0x0000000129f747f0 content::LayerTreeView::UpdateLayerTreeHost(cc::LayerTreeHostClient::VisualStateUpdate) + 32\r\n19  libcc.dylib                         0x000000013563eef0 cc::LayerTreeHost::RequestMainFrameUpdate(cc::LayerTreeHostClient::VisualStateUpdate) + 32\r\n20  libcc.dylib                         0x00000001357b3471 cc::ProxyMain::BeginMainFrame(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >) + 3041\r\n21  libcc.dylib                         0x00000001357ae7e0 void base::internal::FunctorTraits<void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), void>::Invoke<void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), base::WeakPtr<cc::ProxyMain>, std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> > >(void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), base::WeakPtr<cc::ProxyMain>&&, std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >&&) + 576\r\n22  libcc.dylib                         0x00000001357ae565 void base::internal::InvokeHelper<true, void>::MakeItSo<void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), base::WeakPtr<cc::ProxyMain>, std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> > >(void (cc::ProxyMain::*&&)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), base::WeakPtr<cc::ProxyMain>&&, std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >&&) + 117\r\n23  libcc.dylib                         0x00000001357ae3e4 void base::internal::Invoker<base::internal::BindState<void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), base::WeakPtr<cc::ProxyMain>, base::internal::PassedWrapper<std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> > > >, void ()>::RunImpl<void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), std::__1::tuple<base::WeakPtr<cc::ProxyMain>, base::internal::PassedWrapper<std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> > > >, 0ul, 1ul>(void (cc::ProxyMain::*&&)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), std::__1::tuple<base::WeakPtr<cc::ProxyMain>, base::internal::PassedWrapper<std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> > > >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 180\r\n24  libcc.dylib                         0x00000001357ae2b9 base::internal::Invoker<base::internal::BindState<void (cc::ProxyMain::*)(std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> >), base::WeakPtr<cc::ProxyMain>, base::internal::PassedWrapper<std::__1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__1::default_delete<cc::BeginMainFrameAndCommitState> > > >, void ()>::RunOnce(base::internal::BindStateBase*) + 57\r\n25  libbase.dylib                       0x0000000106ec83fc base::OnceCallback<void ()>::Run() && + 92\r\n26  libbase.dylib                       0x0000000106f24689 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033\r\n27  libbase.dylib                       0x00000001071c8a27 base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) + 1351\r\n28  libbase.dylib                       0x00000001071cb8d1 void base::internal::FunctorTraits<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), void>::Invoke<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&>(void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&&&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&&&) + 145\r\n29  libbase.dylib                       0x00000001071cb7d5 void base::internal::InvokeHelper<true, void>::MakeItSo<void (base::sequence_manager::internal::ThreadControllerImpl::* const&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&>(void (base::sequence_manager::internal::ThreadControllerImpl::* const&&&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&&&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&&&) + 117\r\n30  libbase.dylib                       0x00000001071cb74d void base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType>, void ()>::RunImpl<void (base::sequence_manager::internal::ThreadControllerImpl::* const&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), std::__1::tuple<base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType> const&, 0ul, 1ul>(void (base::sequence_manager::internal::ThreadControllerImpl::* const&&&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), std::__1::tuple<base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 125\r\n31  libbase.dylib                       0x00000001071cb64c base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType>, void ()>::Run(base::internal::BindStateBase*) + 44\r\n32  libbase.dylib                       0x0000000106ec83fc base::OnceCallback<void ()>::Run() && + 92\r\n33  libbase.dylib                       0x0000000106f24689 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033\r\n34  libbase.dylib                       0x0000000106ff11af base::MessageLoop::RunTask(base::PendingTask*) + 1199\r\n35  libbase.dylib                       0x0000000106ff16af base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 95\r\n36  libbase.dylib                       0x0000000106ff1d0a base::MessageLoop::DoWork() + 490\r\n37  libbase.dylib                       0x00000001070002b2 base::MessagePumpCFRunLoopBase::RunWork() + 98\r\n38  libbase.dylib                       0x000000010700023c ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28\r\n39  libbase.dylib                       0x0000000106fa44ca base::mac::CallWithEHFrame(void () block_pointer) + 10\r\n40  libbase.dylib                       0x0000000106fff115 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101\r\n41  CoreFoundation                      0x00007fff35d8da11 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17\r\n42  CoreFoundation                      0x00007fff35e4742c __CFRunLoopDoSource0 + 108\r\n43  CoreFoundation                      0x00007fff35d70470 __CFRunLoopDoSources0 + 208\r\n44  CoreFoundation                      0x00007fff35d6f8ed __CFRunLoopRun + 1293\r\n45  CoreFoundation                      0x00007fff35d6f153 CFRunLoopRunSpecific + 483\r\n46  Foundation                          0x00007fff37e6bf26 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277\r\n47  libbase.dylib                       0x0000000107000da9 base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 185\r\n48  libbase.dylib                       0x0000000106ffe775 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 101\r\n49  libbase.dylib                       0x0000000106ff082c base::MessageLoop::Run(bool) + 556\r\n50  libbase.dylib                       0x00000001070dbd5e base::RunLoop::Run() + 606\r\n51  libcontent.dylib                    0x000000012a5fd0a7 content::RendererMain(content::MainFunctionParams const&) + 3799\r\n52  libcontent.dylib                    0x000000012a98dde2 content::RunOtherNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 482\r\n53  libcontent.dylib                    0x000000012a991061 content::ContentMainRunnerImpl::Run(bool) + 4369\r\n54  libcontent.dylib                    0x000000012a987c2c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 76\r\n55  libembedder.dylib                   0x0000000106d6e3d9 service_manager::Main(service_manager::MainParams const&) + 3753\r\n56  libcontent.dylib                    0x000000012a98da49 content::ContentMain(content::ContentMainParams const&) + 89\r\n57  libchrome_dll.dylib                 0x000000010d33866e ChromeMain + 270\r\n58  Brave Browser Development Helper    0x000000010487ad62 main + 1538\r\n59  libdyld.dylib                       0x00007fff5dbb6015 start + 1\r\n60  ???                                 0x0000000000000013 0x0 + 19\r\n```\r\n\r\n\r\n## Steps to Reproduce\r\n\r\n   1. `npm run start` to launch a debug build\r\n   2. Navigate to `chrome://settings/importData`\r\n\r\n## Actual result:\r\n\r\nObserve \"Aw, snap!\" error page and traceback in console\r\n\r\n## Expected result:\r\n\r\nRender process does not crash and settings page is displayed without errors.\r\n\r\n## Reproduces how often: \r\n\r\n100%\r\n\r\n### Reproducible on current release:\r\n\r\n- Does it reproduce on brave-browser dev/beta builds?\r\n\r\nDoes not reproduce in brave-browser beta.\r\n"},"comment":{"url":"https://api.github.com/repos/brave/brave-browser/issues/comments/429493192","html_url":"https://github.com/brave/brave-browser/issues/1558#issuecomment-429493192","issue_url":"https://api.github.com/repos/brave/brave-browser/issues/1558","id":429493192,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQ5MzE5Mg==","user":{"login":"garrettr","id":407302,"node_id":"MDQ6VXNlcjQwNzMwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/407302?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettr","html_url":"https://github.com/garrettr","followers_url":"https://api.github.com/users/garrettr/followers","following_url":"https://api.github.com/users/garrettr/following{/other_user}","gists_url":"https://api.github.com/users/garrettr/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettr/subscriptions","organizations_url":"https://api.github.com/users/garrettr/orgs","repos_url":"https://api.github.com/users/garrettr/repos","events_url":"https://api.github.com/users/garrettr/events{/privacy}","received_events_url":"https://api.github.com/users/garrettr/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T00:03:53Z","updated_at":"2018-10-13T00:03:53Z","author_association":"CONTRIBUTOR","body":"Workaround:\r\n\r\n```diff\r\ndiff --git a/third_party/blink/renderer/core/layout/intersection_geometry.cc b/third_party/blink/renderer/core/layout/intersection_geometry.cc\r\nindex 33844bd0a672..8fa552b21c69 100644\r\n--- a/third_party/blink/renderer/core/layout/intersection_geometry.cc\r\n+++ b/third_party/blink/renderer/core/layout/intersection_geometry.cc\r\n@@ -162,7 +162,7 @@ void IntersectionGeometry::ClipToRoot() {\r\n   // date, so we fall back to the slow path. If we're unthrottled, then ensure\r\n   // that prepaint has run and the frame view doesn't need a paint property\r\n   // update.\r\n-#if DCHECK_IS_ON()\r\n+#if 0\r\n   {\r\n     auto* frame_view = target_->GetFrameView();\r\n     auto* layout_view = frame_view->GetLayoutView();\r\n```"}}
{"actor":{"display_login":"garrettr"}}