{"action":"created","issue":{"url":"https://api.github.com/repos/assimp/assimp/issues/2037","repository_url":"https://api.github.com/repos/assimp/assimp","labels_url":"https://api.github.com/repos/assimp/assimp/issues/2037/labels{/name}","comments_url":"https://api.github.com/repos/assimp/assimp/issues/2037/comments","events_url":"https://api.github.com/repos/assimp/assimp/issues/2037/events","html_url":"https://github.com/assimp/assimp/pull/2037","id":335121653,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTE1MjE1","number":2037,"title":"Fix fbx import regression","user":{"login":"aavenel","id":303767,"node_id":"MDQ6VXNlcjMwMzc2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303767?v=4","gravatar_id":"","url":"https://api.github.com/users/aavenel","html_url":"https://github.com/aavenel","followers_url":"https://api.github.com/users/aavenel/followers","following_url":"https://api.github.com/users/aavenel/following{/other_user}","gists_url":"https://api.github.com/users/aavenel/gists{/gist_id}","starred_url":"https://api.github.com/users/aavenel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aavenel/subscriptions","organizations_url":"https://api.github.com/users/aavenel/orgs","repos_url":"https://api.github.com/users/aavenel/repos","events_url":"https://api.github.com/users/aavenel/events{/privacy}","received_events_url":"https://api.github.com/users/aavenel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-23T18:34:32Z","updated_at":"2018-09-11T14:01:59Z","closed_at":"2018-06-25T18:12:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/assimp/assimp/pulls/2037","html_url":"https://github.com/assimp/assimp/pull/2037","diff_url":"https://github.com/assimp/assimp/pull/2037.diff","patch_url":"https://github.com/assimp/assimp/pull/2037.patch"},"body":"Hi Kim,\r\nI noticed that the fbx unit test box.fbx wasn't checking the number of meshes or vertices.\r\nWhen I added this check, it appeared that this was broken and assimp reported 0 mesh.\r\n\r\nUsing git bisect, it seems that the regression appeared with PR #1735.\r\n\r\nI'm not sure if I understand this code completely, but it seems that the check for `HasElement` has been removed when `isDirect` is true, which doesn't seem intended.\r\n"},"comment":{"url":"https://api.github.com/repos/assimp/assimp/issues/comments/420285314","html_url":"https://github.com/assimp/assimp/pull/2037#issuecomment-420285314","issue_url":"https://api.github.com/repos/assimp/assimp/issues/2037","id":420285314,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDI4NTMxNA==","user":{"login":"LoicFr","id":38719983,"node_id":"MDQ6VXNlcjM4NzE5OTgz","avatar_url":"https://avatars2.githubusercontent.com/u/38719983?v=4","gravatar_id":"","url":"https://api.github.com/users/LoicFr","html_url":"https://github.com/LoicFr","followers_url":"https://api.github.com/users/LoicFr/followers","following_url":"https://api.github.com/users/LoicFr/following{/other_user}","gists_url":"https://api.github.com/users/LoicFr/gists{/gist_id}","starred_url":"https://api.github.com/users/LoicFr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoicFr/subscriptions","organizations_url":"https://api.github.com/users/LoicFr/orgs","repos_url":"https://api.github.com/users/LoicFr/repos","events_url":"https://api.github.com/users/LoicFr/events{/privacy}","received_events_url":"https://api.github.com/users/LoicFr/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T14:01:59Z","updated_at":"2018-09-11T14:01:59Z","author_association":"CONTRIBUTOR","body":"Ok I found the problem: the check is necessary but was wrong.\r\nIt was HasElement(source, indexDataElementName)\r\nbut has to be HasElement(source, dataElementName)\r\n\r\nI will create a pull request for that"}}
{"actor":{"display_login":"LoicFr"}}