{"action":"created","issue":{"url":"https://api.github.com/repos/bbc/bbc-a11y/issues/227","repository_url":"https://api.github.com/repos/bbc/bbc-a11y","labels_url":"https://api.github.com/repos/bbc/bbc-a11y/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/bbc/bbc-a11y/issues/227/comments","events_url":"https://api.github.com/repos/bbc/bbc-a11y/issues/227/events","html_url":"https://github.com/bbc/bbc-a11y/pull/227","id":270356104,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUwMDc0MjM3","number":227,"title":"Update test guide","user":{"login":"JamieKnightBBC","id":18007258,"node_id":"MDQ6VXNlcjE4MDA3MjU4","avatar_url":"https://avatars0.githubusercontent.com/u/18007258?v=4","gravatar_id":"","url":"https://api.github.com/users/JamieKnightBBC","html_url":"https://github.com/JamieKnightBBC","followers_url":"https://api.github.com/users/JamieKnightBBC/followers","following_url":"https://api.github.com/users/JamieKnightBBC/following{/other_user}","gists_url":"https://api.github.com/users/JamieKnightBBC/gists{/gist_id}","starred_url":"https://api.github.com/users/JamieKnightBBC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamieKnightBBC/subscriptions","organizations_url":"https://api.github.com/users/JamieKnightBBC/orgs","repos_url":"https://api.github.com/users/JamieKnightBBC/repos","events_url":"https://api.github.com/users/JamieKnightBBC/events{/privacy}","received_events_url":"https://api.github.com/users/JamieKnightBBC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-01T15:54:52Z","updated_at":"2018-06-20T09:18:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bbc/bbc-a11y/pulls/227","html_url":"https://github.com/bbc/bbc-a11y/pull/227","diff_url":"https://github.com/bbc/bbc-a11y/pull/227.diff","patch_url":"https://github.com/bbc/bbc-a11y/pull/227.patch"},"body":"## Summary\r\n\r\n1. Renames the file and removes \"validating\" keyword\r\n2. Adds $ convention to terminal commands.\r\n3. Add sudo to the global install flag to avoid NPM error.\r\n\r\n## Motivation and Context\r\n\r\n1. Validating is confusing due to the W3C cross over. \r\n2. The convention of leading commands with a $ is from unix / linux going back 20 years. Makes the instructions consistent with other *nix things. \r\n3. NPM can't perform a global install without enhanced permissions. Sudo is required to grant NPM the requisite permissions to avoid the following error:\r\n\r\n```\r\nnpm WARN deprecated fs-promise@2.0.1: Use mz or fs-extra^3.0 with Promise Support\r\nnpm WARN checkPermissions Missing write access to /usr/local/lib/node_modules\r\nnpm ERR! path /usr/local/lib/node_modules\r\nnpm ERR! code EACCES\r\nnpm ERR! errno -13\r\nnpm ERR! syscall access\r\nnpm ERR! Error: EACCES: permission denied, access '/usr/local/lib/node_modules'\r\nnpm ERR!  { Error: EACCES: permission denied, access '/usr/local/lib/node_modules'\r\nnpm ERR!   stack: 'Error: EACCES: permission denied, access \\'/usr/local/lib/node_modules\\'',\r\nnpm ERR!   errno: -13,\r\nnpm ERR!   code: 'EACCES',\r\nnpm ERR!   syscall: 'access',\r\nnpm ERR!   path: '/usr/local/lib/node_modules' }\r\nnpm ERR! \r\nnpm ERR! Please try running this command again as root/Administrator.\r\n\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR!     /Users/bbc/.npm/_logs/2017-11-01T15_47_51_529Z-debug.log\r\n```\r\n\r\n## How Has This Been Tested?\r\n\r\nI've run through each command and tested they worked. This is the only command which failed.\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [/] Bug fix (non-breaking change which fixes an issue)\r\n- [] New feature (non-breaking change which adds functionality)\r\n- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bbc/bbc-a11y/issues/comments/398682499","html_url":"https://github.com/bbc/bbc-a11y/pull/227#issuecomment-398682499","issue_url":"https://api.github.com/repos/bbc/bbc-a11y/issues/227","id":398682499,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODY4MjQ5OQ==","user":{"login":"andymsuk","id":8750417,"node_id":"MDQ6VXNlcjg3NTA0MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8750417?v=4","gravatar_id":"","url":"https://api.github.com/users/andymsuk","html_url":"https://github.com/andymsuk","followers_url":"https://api.github.com/users/andymsuk/followers","following_url":"https://api.github.com/users/andymsuk/following{/other_user}","gists_url":"https://api.github.com/users/andymsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/andymsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymsuk/subscriptions","organizations_url":"https://api.github.com/users/andymsuk/orgs","repos_url":"https://api.github.com/users/andymsuk/repos","events_url":"https://api.github.com/users/andymsuk/events{/privacy}","received_events_url":"https://api.github.com/users/andymsuk/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T09:18:23Z","updated_at":"2018-06-20T09:18:23Z","author_association":"COLLABORATOR","body":"@JamieKnightBBC - What are your thoughts on Josh's reply above?"}}
{"actor":{"display_login":"andymsuk"}}