{"action":"created","comment":{"url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments/224420237","pull_request_review_id":163778427,"id":224420237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDQyMDIzNw==","diff_hunk":"@@ -329,6 +329,16 @@ export class GroupsService {\n \t\treturn this.deleteGroups(teamspace, model, groupsToDelete);\n \t}\n \n+\t/**\n+\t * Deletes filtered groups in the current model\n+\t * @param teamspace the teamspace name for the group\n+\t * @param model the model id for the group\n+\t */\n+\n+\tpublic deleteFilteredGroups(teamspace: string, model: string, filteredGroups: any) {","path":"frontend/components/groups/js/groups.service.ts","position":10,"original_position":10,"commit_id":"ef54a4838e3315181ba6727972daa53374455448","original_commit_id":"ef54a4838e3315181ba6727972daa53374455448","user":{"login":"carmenfan","id":11945337,"node_id":"MDQ6VXNlcjExOTQ1MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11945337?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenfan","html_url":"https://github.com/carmenfan","followers_url":"https://api.github.com/users/carmenfan/followers","following_url":"https://api.github.com/users/carmenfan/following{/other_user}","gists_url":"https://api.github.com/users/carmenfan/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenfan/subscriptions","organizations_url":"https://api.github.com/users/carmenfan/orgs","repos_url":"https://api.github.com/users/carmenfan/repos","events_url":"https://api.github.com/users/carmenfan/events{/privacy}","received_events_url":"https://api.github.com/users/carmenfan/received_events","type":"User","site_admin":false},"body":"Instead of creating this function, we should rename `deleteAllGroups` to `deleteAllDisplayedGroups`. We always only want to delete the groups that are currently displayed. If there is no filter, `groups` would be teh same as `groupsToShow`\r\n\r\nSo a new function is unnecessary. (but it would be good to change all the prompts from `delete all` to `delete all displayed` or something","created_at":"2018-10-11T12:02:37Z","updated_at":"2018-10-11T12:02:57Z","html_url":"https://github.com/3drepo/3drepo.io/pull/1196#discussion_r224420237","pull_request_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments/224420237"},"html":{"href":"https://github.com/3drepo/3drepo.io/pull/1196#discussion_r224420237"},"pull_request":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196"}}},"pull_request":{"url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196","id":221836867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODM2ODY3","html_url":"https://github.com/3drepo/3drepo.io/pull/1196","diff_url":"https://github.com/3drepo/3drepo.io/pull/1196.diff","patch_url":"https://github.com/3drepo/3drepo.io/pull/1196.patch","issue_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1196","number":1196,"state":"open","locked":false,"title":"Issue 1158 - Delete Filtered Groups","user":{"login":"niblux","id":6556019,"node_id":"MDQ6VXNlcjY1NTYwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6556019?v=4","gravatar_id":"","url":"https://api.github.com/users/niblux","html_url":"https://github.com/niblux","followers_url":"https://api.github.com/users/niblux/followers","following_url":"https://api.github.com/users/niblux/following{/other_user}","gists_url":"https://api.github.com/users/niblux/gists{/gist_id}","starred_url":"https://api.github.com/users/niblux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niblux/subscriptions","organizations_url":"https://api.github.com/users/niblux/orgs","repos_url":"https://api.github.com/users/niblux/repos","events_url":"https://api.github.com/users/niblux/events{/privacy}","received_events_url":"https://api.github.com/users/niblux/received_events","type":"User","site_admin":false},"body":"This fixes #1158 <!-- Enter issue number here -->\r\n\r\n#### Description\r\nWhen clicking the \"Delete all\" button on the Groups component all groups are deleted.\r\nHowever when a list of groups is filtered and a new list is displayed, when clicking \"Delete all\" this still deletes all the groups.\r\nThe desired functionality was to only delete the filtered groups that are displayed, and not the groups that were filtered out.\r\n\r\n#### Test cases\r\n<!-- Test cases that this pull request expect to pass -->\r\n- Filter a list of groups and click \"Delete all\", this will only delete the filtered list.\r\n- When no filter search query has been provided , and all groups are displayed the \"Delete all\" button will delete all groups in the current model. \r\n\r\n![groupsfilterdelete](https://user-images.githubusercontent.com/6556019/46747772-0aa6a480-ccaa-11e8-897e-307a522efc39.gif)\r\n\r\n","created_at":"2018-10-10T15:33:19Z","updated_at":"2018-10-11T12:02:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ee34c9ada1464021ef298fe800950570749b04f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1196/comments","statuses_url":"https://api.github.com/repos/3drepo/3drepo.io/statuses/ef54a4838e3315181ba6727972daa53374455448","head":{"label":"3drepo:ISSUE_1158","ref":"ISSUE_1158","sha":"ef54a4838e3315181ba6727972daa53374455448","user":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"repo":{"id":23537557,"node_id":"MDEwOlJlcG9zaXRvcnkyMzUzNzU1Nw==","name":"3drepo.io","full_name":"3drepo/3drepo.io","private":false,"owner":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3drepo/3drepo.io","description":"3D Repo web server","fork":false,"url":"https://api.github.com/repos/3drepo/3drepo.io","forks_url":"https://api.github.com/repos/3drepo/3drepo.io/forks","keys_url":"https://api.github.com/repos/3drepo/3drepo.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3drepo/3drepo.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3drepo/3drepo.io/teams","hooks_url":"https://api.github.com/repos/3drepo/3drepo.io/hooks","issue_events_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/events{/number}","events_url":"https://api.github.com/repos/3drepo/3drepo.io/events","assignees_url":"https://api.github.com/repos/3drepo/3drepo.io/assignees{/user}","branches_url":"https://api.github.com/repos/3drepo/3drepo.io/branches{/branch}","tags_url":"https://api.github.com/repos/3drepo/3drepo.io/tags","blobs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3drepo/3drepo.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/3drepo/3drepo.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3drepo/3drepo.io/statuses/{sha}","languages_url":"https://api.github.com/repos/3drepo/3drepo.io/languages","stargazers_url":"https://api.github.com/repos/3drepo/3drepo.io/stargazers","contributors_url":"https://api.github.com/repos/3drepo/3drepo.io/contributors","subscribers_url":"https://api.github.com/repos/3drepo/3drepo.io/subscribers","subscription_url":"https://api.github.com/repos/3drepo/3drepo.io/subscription","commits_url":"https://api.github.com/repos/3drepo/3drepo.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/3drepo/3drepo.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/3drepo/3drepo.io/contents/{+path}","compare_url":"https://api.github.com/repos/3drepo/3drepo.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3drepo/3drepo.io/merges","archive_url":"https://api.github.com/repos/3drepo/3drepo.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3drepo/3drepo.io/downloads","issues_url":"https://api.github.com/repos/3drepo/3drepo.io/issues{/number}","pulls_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls{/number}","milestones_url":"https://api.github.com/repos/3drepo/3drepo.io/milestones{/number}","notifications_url":"https://api.github.com/repos/3drepo/3drepo.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3drepo/3drepo.io/labels{/name}","releases_url":"https://api.github.com/repos/3drepo/3drepo.io/releases{/id}","deployments_url":"https://api.github.com/repos/3drepo/3drepo.io/deployments","created_at":"2014-09-01T09:31:56Z","updated_at":"2018-10-10T13:12:47Z","pushed_at":"2018-10-11T11:52:09Z","git_url":"git://github.com/3drepo/3drepo.io.git","ssh_url":"git@github.com:3drepo/3drepo.io.git","clone_url":"https://github.com/3drepo/3drepo.io.git","svn_url":"https://github.com/3drepo/3drepo.io","homepage":"http://www.3drepo.io","size":610187,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":29,"open_issues":68,"watchers":59,"default_branch":"master"}},"base":{"label":"3drepo:staging","ref":"staging","sha":"2c9752581a1ca4c6b3f68010053e6dc34c1b5161","user":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"repo":{"id":23537557,"node_id":"MDEwOlJlcG9zaXRvcnkyMzUzNzU1Nw==","name":"3drepo.io","full_name":"3drepo/3drepo.io","private":false,"owner":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3drepo/3drepo.io","description":"3D Repo web server","fork":false,"url":"https://api.github.com/repos/3drepo/3drepo.io","forks_url":"https://api.github.com/repos/3drepo/3drepo.io/forks","keys_url":"https://api.github.com/repos/3drepo/3drepo.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3drepo/3drepo.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3drepo/3drepo.io/teams","hooks_url":"https://api.github.com/repos/3drepo/3drepo.io/hooks","issue_events_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/events{/number}","events_url":"https://api.github.com/repos/3drepo/3drepo.io/events","assignees_url":"https://api.github.com/repos/3drepo/3drepo.io/assignees{/user}","branches_url":"https://api.github.com/repos/3drepo/3drepo.io/branches{/branch}","tags_url":"https://api.github.com/repos/3drepo/3drepo.io/tags","blobs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3drepo/3drepo.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/3drepo/3drepo.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3drepo/3drepo.io/statuses/{sha}","languages_url":"https://api.github.com/repos/3drepo/3drepo.io/languages","stargazers_url":"https://api.github.com/repos/3drepo/3drepo.io/stargazers","contributors_url":"https://api.github.com/repos/3drepo/3drepo.io/contributors","subscribers_url":"https://api.github.com/repos/3drepo/3drepo.io/subscribers","subscription_url":"https://api.github.com/repos/3drepo/3drepo.io/subscription","commits_url":"https://api.github.com/repos/3drepo/3drepo.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/3drepo/3drepo.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/3drepo/3drepo.io/contents/{+path}","compare_url":"https://api.github.com/repos/3drepo/3drepo.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3drepo/3drepo.io/merges","archive_url":"https://api.github.com/repos/3drepo/3drepo.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3drepo/3drepo.io/downloads","issues_url":"https://api.github.com/repos/3drepo/3drepo.io/issues{/number}","pulls_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls{/number}","milestones_url":"https://api.github.com/repos/3drepo/3drepo.io/milestones{/number}","notifications_url":"https://api.github.com/repos/3drepo/3drepo.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3drepo/3drepo.io/labels{/name}","releases_url":"https://api.github.com/repos/3drepo/3drepo.io/releases{/id}","deployments_url":"https://api.github.com/repos/3drepo/3drepo.io/deployments","created_at":"2014-09-01T09:31:56Z","updated_at":"2018-10-10T13:12:47Z","pushed_at":"2018-10-11T11:52:09Z","git_url":"git://github.com/3drepo/3drepo.io.git","ssh_url":"git@github.com:3drepo/3drepo.io.git","clone_url":"https://github.com/3drepo/3drepo.io.git","svn_url":"https://github.com/3drepo/3drepo.io","homepage":"http://www.3drepo.io","size":610187,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":29,"open_issues":68,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196"},"html":{"href":"https://github.com/3drepo/3drepo.io/pull/1196"},"issue":{"href":"https://api.github.com/repos/3drepo/3drepo.io/issues/1196"},"comments":{"href":"https://api.github.com/repos/3drepo/3drepo.io/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/3drepo/3drepo.io/statuses/ef54a4838e3315181ba6727972daa53374455448"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carmenfan"}}