{"action":"closed","number":557,"pull_request":{"url":"https://api.github.com/repos/freenas/freenas/pulls/557","id":156818906,"html_url":"https://github.com/freenas/freenas/pull/557","diff_url":"https://github.com/freenas/freenas/pull/557.diff","patch_url":"https://github.com/freenas/freenas/pull/557.patch","issue_url":"https://api.github.com/repos/freenas/freenas/issues/557","number":557,"state":"closed","locked":false,"title":"Have winacl reset set \"inherited\" flag on subdirectories","user":{"login":"anodos325","id":21041515,"avatar_url":"https://avatars3.githubusercontent.com/u/21041515?v=4","gravatar_id":"","url":"https://api.github.com/users/anodos325","html_url":"https://github.com/anodos325","followers_url":"https://api.github.com/users/anodos325/followers","following_url":"https://api.github.com/users/anodos325/following{/other_user}","gists_url":"https://api.github.com/users/anodos325/gists{/gist_id}","starred_url":"https://api.github.com/users/anodos325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anodos325/subscriptions","organizations_url":"https://api.github.com/users/anodos325/orgs","repos_url":"https://api.github.com/users/anodos325/repos","events_url":"https://api.github.com/users/anodos325/events{/privacy}","received_events_url":"https://api.github.com/users/anodos325/received_events","type":"User","site_admin":false},"body":"If we start setting DACL protected on security descriptors in absence of \"Inherited\" flag, then this will cause problems for \"apply default permissions\". Specifically, it will break permissions auto-inheritance because \"winacl -a reset -r -p <path>\" does not set \"inherited\" on subdirectories.\r\n\r\nI have (I think) fixed this behavior, but have not tested all edge cases.","created_at":"2017-12-06T19:31:16Z","updated_at":"2018-02-13T21:55:15Z","closed_at":"2018-02-13T21:55:15Z","merged_at":null,"merge_commit_sha":"b138d4cbd4e0488ce124186a58c12fa428e42c88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freenas/freenas/pulls/557/commits","review_comments_url":"https://api.github.com/repos/freenas/freenas/pulls/557/comments","review_comment_url":"https://api.github.com/repos/freenas/freenas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenas/freenas/issues/557/comments","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/aa64f662e9cb638f8de29447d4eafd511d99b757","head":{"label":"anodos325:master","ref":"master","sha":"aa64f662e9cb638f8de29447d4eafd511d99b757","user":{"login":"anodos325","id":21041515,"avatar_url":"https://avatars3.githubusercontent.com/u/21041515?v=4","gravatar_id":"","url":"https://api.github.com/users/anodos325","html_url":"https://github.com/anodos325","followers_url":"https://api.github.com/users/anodos325/followers","following_url":"https://api.github.com/users/anodos325/following{/other_user}","gists_url":"https://api.github.com/users/anodos325/gists{/gist_id}","starred_url":"https://api.github.com/users/anodos325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anodos325/subscriptions","organizations_url":"https://api.github.com/users/anodos325/orgs","repos_url":"https://api.github.com/users/anodos325/repos","events_url":"https://api.github.com/users/anodos325/events{/privacy}","received_events_url":"https://api.github.com/users/anodos325/received_events","type":"User","site_admin":false},"repo":{"id":113270499,"name":"freenas","full_name":"anodos325/freenas","owner":{"login":"anodos325","id":21041515,"avatar_url":"https://avatars3.githubusercontent.com/u/21041515?v=4","gravatar_id":"","url":"https://api.github.com/users/anodos325","html_url":"https://github.com/anodos325","followers_url":"https://api.github.com/users/anodos325/followers","following_url":"https://api.github.com/users/anodos325/following{/other_user}","gists_url":"https://api.github.com/users/anodos325/gists{/gist_id}","starred_url":"https://api.github.com/users/anodos325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anodos325/subscriptions","organizations_url":"https://api.github.com/users/anodos325/orgs","repos_url":"https://api.github.com/users/anodos325/repos","events_url":"https://api.github.com/users/anodos325/events{/privacy}","received_events_url":"https://api.github.com/users/anodos325/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anodos325/freenas","description":"FreeNAS Git Repository","fork":true,"url":"https://api.github.com/repos/anodos325/freenas","forks_url":"https://api.github.com/repos/anodos325/freenas/forks","keys_url":"https://api.github.com/repos/anodos325/freenas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anodos325/freenas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anodos325/freenas/teams","hooks_url":"https://api.github.com/repos/anodos325/freenas/hooks","issue_events_url":"https://api.github.com/repos/anodos325/freenas/issues/events{/number}","events_url":"https://api.github.com/repos/anodos325/freenas/events","assignees_url":"https://api.github.com/repos/anodos325/freenas/assignees{/user}","branches_url":"https://api.github.com/repos/anodos325/freenas/branches{/branch}","tags_url":"https://api.github.com/repos/anodos325/freenas/tags","blobs_url":"https://api.github.com/repos/anodos325/freenas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anodos325/freenas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anodos325/freenas/git/refs{/sha}","trees_url":"https://api.github.com/repos/anodos325/freenas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anodos325/freenas/statuses/{sha}","languages_url":"https://api.github.com/repos/anodos325/freenas/languages","stargazers_url":"https://api.github.com/repos/anodos325/freenas/stargazers","contributors_url":"https://api.github.com/repos/anodos325/freenas/contributors","subscribers_url":"https://api.github.com/repos/anodos325/freenas/subscribers","subscription_url":"https://api.github.com/repos/anodos325/freenas/subscription","commits_url":"https://api.github.com/repos/anodos325/freenas/commits{/sha}","git_commits_url":"https://api.github.com/repos/anodos325/freenas/git/commits{/sha}","comments_url":"https://api.github.com/repos/anodos325/freenas/comments{/number}","issue_comment_url":"https://api.github.com/repos/anodos325/freenas/issues/comments{/number}","contents_url":"https://api.github.com/repos/anodos325/freenas/contents/{+path}","compare_url":"https://api.github.com/repos/anodos325/freenas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anodos325/freenas/merges","archive_url":"https://api.github.com/repos/anodos325/freenas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anodos325/freenas/downloads","issues_url":"https://api.github.com/repos/anodos325/freenas/issues{/number}","pulls_url":"https://api.github.com/repos/anodos325/freenas/pulls{/number}","milestones_url":"https://api.github.com/repos/anodos325/freenas/milestones{/number}","notifications_url":"https://api.github.com/repos/anodos325/freenas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anodos325/freenas/labels{/name}","releases_url":"https://api.github.com/repos/anodos325/freenas/releases{/id}","deployments_url":"https://api.github.com/repos/anodos325/freenas/deployments","created_at":"2017-12-06T04:55:15Z","updated_at":"2017-12-06T04:55:23Z","pushed_at":"2018-02-07T10:21:53Z","git_url":"git://github.com/anodos325/freenas.git","ssh_url":"git@github.com:anodos325/freenas.git","clone_url":"https://github.com/anodos325/freenas.git","svn_url":"https://github.com/anodos325/freenas","homepage":"http://www.freenas.org","size":496482,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freenas:master","ref":"master","sha":"fadb0a5d5d52bc81cc77613a91b4e3c14259e182","user":{"login":"freenas","id":3792476,"avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":8627760,"name":"freenas","full_name":"freenas/freenas","owner":{"login":"freenas","id":3792476,"avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freenas/freenas","description":"FreeNAS Git Repository","fork":false,"url":"https://api.github.com/repos/freenas/freenas","forks_url":"https://api.github.com/repos/freenas/freenas/forks","keys_url":"https://api.github.com/repos/freenas/freenas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas/teams","hooks_url":"https://api.github.com/repos/freenas/freenas/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas/events","assignees_url":"https://api.github.com/repos/freenas/freenas/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas/tags","blobs_url":"https://api.github.com/repos/freenas/freenas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas/subscription","commits_url":"https://api.github.com/repos/freenas/freenas/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas/merges","archive_url":"https://api.github.com/repos/freenas/freenas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas/downloads","issues_url":"https://api.github.com/repos/freenas/freenas/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas/deployments","created_at":"2013-03-07T13:23:20Z","updated_at":"2018-02-13T19:34:34Z","pushed_at":"2018-02-13T20:33:18Z","git_url":"git://github.com/freenas/freenas.git","ssh_url":"git@github.com:freenas/freenas.git","clone_url":"https://github.com/freenas/freenas.git","svn_url":"https://github.com/freenas/freenas","homepage":"http://www.freenas.org","size":522566,"stargazers_count":891,"watchers_count":891,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":280,"open_issues":4,"watchers":891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas/pulls/557"},"html":{"href":"https://github.com/freenas/freenas/pull/557"},"issue":{"href":"https://api.github.com/repos/freenas/freenas/issues/557"},"comments":{"href":"https://api.github.com/repos/freenas/freenas/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/freenas/freenas/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/freenas/freenas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenas/freenas/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/freenas/freenas/statuses/aa64f662e9cb638f8de29447d4eafd511d99b757"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":5,"maintainer_can_modify":false,"commits":6,"additions":71,"deletions":25,"changed_files":1}}
{"actor":{"display_login":"anodos325"}}