{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/193440485","pull_request_review_id":126413054,"id":193440485,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ0MDQ4NQ==","diff_hunk":"@@ -128,7 +128,7 @@ sub is_caasp {\n     elsif ($filter eq 'VMX') {\n         return get_var('FLAVOR') !~ /DVD/;    # If not DVD it's VMX\n     }\n-    elsif ($filter =~ /^\\d\\.\\d\\+?$/) {\n+    elsif ($filter =~ /\\d\\.\\d\\+?$/) {","path":"lib/version_utils.pm","position":5,"original_position":5,"commit_id":"d32c2612099fcf9912d077630f5ae3c0574bd657","original_commit_id":"d32c2612099fcf9912d077630f5ae3c0574bd657","user":{"login":"drpaneas","id":2141732,"node_id":"MDQ6VXNlcjIxNDE3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2141732?v=4","gravatar_id":"","url":"https://api.github.com/users/drpaneas","html_url":"https://github.com/drpaneas","followers_url":"https://api.github.com/users/drpaneas/followers","following_url":"https://api.github.com/users/drpaneas/following{/other_user}","gists_url":"https://api.github.com/users/drpaneas/gists{/gist_id}","starred_url":"https://api.github.com/users/drpaneas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpaneas/subscriptions","organizations_url":"https://api.github.com/users/drpaneas/orgs","repos_url":"https://api.github.com/users/drpaneas/repos","events_url":"https://api.github.com/users/drpaneas/events{/privacy}","received_events_url":"https://api.github.com/users/drpaneas/received_events","type":"User","site_admin":false},"body":"that was the last thing missing to make the tests work for QAM also. The last verification run is: http://skyrim.qam.suse.de/tests/3314\r\n\r\nThe changes that I need to make to osd are:\r\n\r\n```\r\nQAM-CaaSP-autoyast1 -> hostname=master-api\r\nQAM-CaaSP-autoyast2 -> hostname=master-rm\r\nQAM-CaaSP-autoyast3 -> hostname=mixed\r\nQAM-CaaSP-autoyastmaster -> hostname=master-ay\r\n```\r\n\r\nFor switching QAM to CaaSP 3.0 I might need to also do:\r\n\r\n```\r\nQAM-CaaSP-autoyast4 => hostname=master-add\r\nQAM-CaaSP-autoyast5 => hostname=worker-addrm\r\ncreate another one => hostname=worker-ay1\r\n````\r\n\r\nThank you very much @kravciak  for your patience working with me on this one. LGTM ;)","created_at":"2018-06-06T14:54:00Z","updated_at":"2018-06-06T14:54:13Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5109#discussion_r193440485","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/193440485"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5109#discussion_r193440485"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109","id":189364467,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MzY0NDY3","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5109","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5109.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5109.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5109","number":5109,"state":"open","locked":false,"title":"[WIP] Add & remove cluster nodes","user":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"body":"WIP: need to sync with QAM and merge after RC release\r\n\r\nTo deploy this PR this needs to be changed\r\n - masters: add `master-RM` and `master-ay`, rename `master` to `master-API`\r\n - workers: rename `node1` to `miXed` and `delayed` to `worker-addrm`\r\n - hostnames based on http://dhcp165.suse.cz/tests/5302#step/stack_add_remove/16\r\n - set DELAYED=master|worker variables on `*add*` nodes, remove DELAYED_WORKER\r\n - upload new cloud-configs with VMX setup changes\r\n\r\nNeedles: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/863\r\n\r\nLocal runs\r\n - http://dhcp165.suse.cz/tests/5302#step/stack_add_remove/73 - VMX 3 masters\r\n - http://dhcp165.suse.cz/tests/5329#step/stack_add_remove/69 - DVD 3 masters\r\n - http://dhcp165.suse.cz/tests/5492 - DVD 1 master\r\n\r\nAdd and remove cluster nodes\r\n - node identification with xy needles\r\n - worker node add & remove\r\n - master node replacement (remove & add)\r\n - explicitly select master nodes during bootstrap\r\n - change get_delayed_workers sub into get_delayed\r\n - improve log export logic on cluster workers\r\n\r\nMutex cleanup\r\n - replace DELAYED_NODES_ACCEPTED with AUTOYAST_PW_SET\r\n - replace WORKERS_INSTALLED with NODES_ONLINE\r\n - remove REBOOT_FINISHED\r\n - move DELAYED_WORKER_INSTALLED into barrier\r\n\r\nGeneral cleanup\r\n - rename nodes to match cluster roles (worker/master/node)\r\n - rename of xy needle tags to match hostname\r\n - don't export logs in local dev envs","created_at":"2018-05-21T12:23:54Z","updated_at":"2018-06-06T14:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f17cb3bf9e91b8dfd98bbca8c30d1700431870b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5109/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/d32c2612099fcf9912d077630f5ae3c0574bd657","head":{"label":"kravciak:ar","ref":"ar","sha":"d32c2612099fcf9912d077630f5ae3c0574bd657","user":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"repo":{"id":45985015,"node_id":"MDEwOlJlcG9zaXRvcnk0NTk4NTAxNQ==","name":"openqa-tests","full_name":"kravciak/openqa-tests","owner":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kravciak/openqa-tests","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/kravciak/openqa-tests","forks_url":"https://api.github.com/repos/kravciak/openqa-tests/forks","keys_url":"https://api.github.com/repos/kravciak/openqa-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kravciak/openqa-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kravciak/openqa-tests/teams","hooks_url":"https://api.github.com/repos/kravciak/openqa-tests/hooks","issue_events_url":"https://api.github.com/repos/kravciak/openqa-tests/issues/events{/number}","events_url":"https://api.github.com/repos/kravciak/openqa-tests/events","assignees_url":"https://api.github.com/repos/kravciak/openqa-tests/assignees{/user}","branches_url":"https://api.github.com/repos/kravciak/openqa-tests/branches{/branch}","tags_url":"https://api.github.com/repos/kravciak/openqa-tests/tags","blobs_url":"https://api.github.com/repos/kravciak/openqa-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kravciak/openqa-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kravciak/openqa-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kravciak/openqa-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kravciak/openqa-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kravciak/openqa-tests/languages","stargazers_url":"https://api.github.com/repos/kravciak/openqa-tests/stargazers","contributors_url":"https://api.github.com/repos/kravciak/openqa-tests/contributors","subscribers_url":"https://api.github.com/repos/kravciak/openqa-tests/subscribers","subscription_url":"https://api.github.com/repos/kravciak/openqa-tests/subscription","commits_url":"https://api.github.com/repos/kravciak/openqa-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kravciak/openqa-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kravciak/openqa-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kravciak/openqa-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kravciak/openqa-tests/contents/{+path}","compare_url":"https://api.github.com/repos/kravciak/openqa-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kravciak/openqa-tests/merges","archive_url":"https://api.github.com/repos/kravciak/openqa-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kravciak/openqa-tests/downloads","issues_url":"https://api.github.com/repos/kravciak/openqa-tests/issues{/number}","pulls_url":"https://api.github.com/repos/kravciak/openqa-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kravciak/openqa-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kravciak/openqa-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kravciak/openqa-tests/labels{/name}","releases_url":"https://api.github.com/repos/kravciak/openqa-tests/releases{/id}","deployments_url":"https://api.github.com/repos/kravciak/openqa-tests/deployments","created_at":"2015-11-11T14:01:04Z","updated_at":"2018-05-21T12:13:16Z","pushed_at":"2018-06-06T13:49:29Z","git_url":"git://github.com/kravciak/openqa-tests.git","ssh_url":"git@github.com:kravciak/openqa-tests.git","clone_url":"https://github.com/kravciak/openqa-tests.git","svn_url":"https://github.com/kravciak/openqa-tests","homepage":null,"size":90125,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"736cd2e6b8617a750cb4a1b58f40022633fafb5a","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-06-06T13:11:04Z","pushed_at":"2018-06-06T14:12:44Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":90340,"stargazers_count":30,"watchers_count":30,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":42,"license":null,"forks":128,"open_issues":42,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5109"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5109"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5109/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5109/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/d32c2612099fcf9912d077630f5ae3c0574bd657"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drpaneas"}}