{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/233629555","pull_request_review_id":175090683,"id":233629555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzYyOTU1NQ==","diff_hunk":"@@ -46,57 +55,96 @@\n     @Mock\n     private TrustManagerProvider trustmanagerProvider;\n \n+    @Mock\n+    private ExtensibleTrustManager extensibleTrustManager;\n+\n     @Before\n     public void setup() {\n         initMocks(this);\n         webClientFactory = new WebClientFactoryImpl();\n         webClientFactory.setTrustmanagerProvider(trustmanagerProvider);\n+        webClientFactory.setExtensibleTrustManager(extensibleTrustManager);\n+\n+        webClientFactory.activate(createConfigMap(10, 200, 60, 5, 10, 60));\n+    }\n+\n+    @After\n+    public void tearDown() {\n+        webClientFactory.deactivate();\n     }\n \n     @Test\n     public void testGetClients() throws Exception {\n-        webClientFactory.activate(createConfigMap(10, 200, 60, 5, 10, 60));\n-\n         HttpClient httpClient = webClientFactory.getCommonHttpClient();\n         WebSocketClient webSocketClient = webClientFactory.getCommonWebSocketClient();\n \n         assertThat(httpClient, is(notNullValue()));\n         assertThat(webSocketClient, is(notNullValue()));\n+    }\n \n-        webClientFactory.deactivate();\n+    @Test\n+    public void testCommonClientUsesExtensibleTrustManager() throws Exception {\n+        ArgumentCaptor<X509Certificate[]> certificateChainCaptor = ArgumentCaptor.forClass(X509Certificate[].class);\n+        ArgumentCaptor<SSLEngine> sslEngineCaptor = ArgumentCaptor.forClass(SSLEngine.class);\n+        HttpClient httpClient = webClientFactory.getCommonHttpClient();","path":"bundles/io/org.eclipse.smarthome.io.net.test/src/test/java/org/eclipse/smarthome/io/net/http/internal/WebClientFactoryTest.java","position":71,"original_position":71,"commit_id":"7f97026b1bd6d9dbf6dd165aaff9521bc6851cfc","original_commit_id":"7f97026b1bd6d9dbf6dd165aaff9521bc6851cfc","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"body":"And in one of the commits I attempted to mark this test as ignored, I had the same problem locally sometimes. Depending on the firewalling / security settings of the jdk.","created_at":"2018-11-14T21:38:37Z","updated_at":"2018-11-14T21:38:37Z","html_url":"https://github.com/eclipse/smarthome/pull/6281#discussion_r233629555","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6281","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/233629555"},"html":{"href":"https://github.com/eclipse/smarthome/pull/6281#discussion_r233629555"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6281"}},"in_reply_to_id":233628219},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/6281","id":218428747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDI4NzQ3","html_url":"https://github.com/eclipse/smarthome/pull/6281","diff_url":"https://github.com/eclipse/smarthome/pull/6281.diff","patch_url":"https://github.com/eclipse/smarthome/pull/6281.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/6281","number":6281,"state":"closed","locked":false,"title":"Added ExtensibleTrustManager to be used for the (common) http/websocket client","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"body":"This replaces the TrustManagerProvider\r\n\r\nIts actually a composite TrustManager consisting of other TrustManagers (and the default fallback) and forwarding calls to an implementation based on the common name or subject alternative names.\r\n\r\nFixes: #6196","created_at":"2018-09-26T19:29:28Z","updated_at":"2018-11-14T21:38:37Z","closed_at":"2018-11-07T16:24:06Z","merged_at":"2018-11-07T16:24:06Z","merge_commit_sha":"cb0463b2e37ce2bb1ea195865de6c7aecc13cfb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":294421275,"node_id":"MDU6TGFiZWwyOTQ0MjEyNzU=","url":"https://api.github.com/repos/eclipse/smarthome/labels/Core","name":"Core","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6281/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6281/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/6281/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/7f97026b1bd6d9dbf6dd165aaff9521bc6851cfc","head":{"label":"martinvw:feature/esh-trust-manager","ref":"feature/esh-trust-manager","sha":"7f97026b1bd6d9dbf6dd165aaff9521bc6851cfc","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"repo":{"id":77283982,"node_id":"MDEwOlJlcG9zaXRvcnk3NzI4Mzk4Mg==","name":"smarthome","full_name":"martinvw/smarthome","private":false,"owner":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/martinvw/smarthome","description":"Eclipse SmartHome™ project","fork":true,"url":"https://api.github.com/repos/martinvw/smarthome","forks_url":"https://api.github.com/repos/martinvw/smarthome/forks","keys_url":"https://api.github.com/repos/martinvw/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinvw/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinvw/smarthome/teams","hooks_url":"https://api.github.com/repos/martinvw/smarthome/hooks","issue_events_url":"https://api.github.com/repos/martinvw/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/martinvw/smarthome/events","assignees_url":"https://api.github.com/repos/martinvw/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/martinvw/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/martinvw/smarthome/tags","blobs_url":"https://api.github.com/repos/martinvw/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinvw/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinvw/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinvw/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinvw/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/martinvw/smarthome/languages","stargazers_url":"https://api.github.com/repos/martinvw/smarthome/stargazers","contributors_url":"https://api.github.com/repos/martinvw/smarthome/contributors","subscribers_url":"https://api.github.com/repos/martinvw/smarthome/subscribers","subscription_url":"https://api.github.com/repos/martinvw/smarthome/subscription","commits_url":"https://api.github.com/repos/martinvw/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinvw/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinvw/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinvw/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinvw/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/martinvw/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinvw/smarthome/merges","archive_url":"https://api.github.com/repos/martinvw/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinvw/smarthome/downloads","issues_url":"https://api.github.com/repos/martinvw/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/martinvw/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/martinvw/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/martinvw/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinvw/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/martinvw/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/martinvw/smarthome/deployments","created_at":"2016-12-24T13:21:26Z","updated_at":"2018-03-31T02:30:22Z","pushed_at":"2018-11-14T21:36:35Z","git_url":"git://github.com/martinvw/smarthome.git","ssh_url":"git@github.com:martinvw/smarthome.git","clone_url":"https://github.com/martinvw/smarthome.git","svn_url":"https://github.com/martinvw/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":52935,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d2b37f2470d1a610dfb8ee90086fb278c209ad39","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3ODk4MQ==","name":"smarthome","full_name":"eclipse/smarthome","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2018-11-14T17:18:57Z","pushed_at":"2018-11-14T17:18:36Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":64201,"stargazers_count":773,"watchers_count":773,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":767,"mirror_url":null,"archived":false,"open_issues_count":448,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":767,"open_issues":448,"watchers":773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6281"},"html":{"href":"https://github.com/eclipse/smarthome/pull/6281"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/6281"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/6281/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6281/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6281/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/7f97026b1bd6d9dbf6dd165aaff9521bc6851cfc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martinvw"}}