{"action":"created","issue":{"url":"https://api.github.com/repos/srophe/syriac-corpus-app/issues/68","repository_url":"https://api.github.com/repos/srophe/syriac-corpus-app","labels_url":"https://api.github.com/repos/srophe/syriac-corpus-app/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/srophe/syriac-corpus-app/issues/68/comments","events_url":"https://api.github.com/repos/srophe/syriac-corpus-app/issues/68/events","html_url":"https://github.com/srophe/syriac-corpus-app/issues/68","id":297324295,"number":68,"title":"Poetic text test","user":{"login":"jedwardwalters","id":11543800,"avatar_url":"https://avatars3.githubusercontent.com/u/11543800?v=4","gravatar_id":"","url":"https://api.github.com/users/jedwardwalters","html_url":"https://github.com/jedwardwalters","followers_url":"https://api.github.com/users/jedwardwalters/followers","following_url":"https://api.github.com/users/jedwardwalters/following{/other_user}","gists_url":"https://api.github.com/users/jedwardwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwardwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwardwalters/subscriptions","organizations_url":"https://api.github.com/users/jedwardwalters/orgs","repos_url":"https://api.github.com/users/jedwardwalters/repos","events_url":"https://api.github.com/users/jedwardwalters/events{/privacy}","received_events_url":"https://api.github.com/users/jedwardwalters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-15T04:13:30Z","updated_at":"2018-03-01T20:41:47Z","closed_at":null,"author_association":"COLLABORATOR","body":"@wsalesky I added a poetic text tonight for testing with the display:\r\nhttp://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/259\r\n\r\nLet me know what you think of the structure I used here and if you have any suggestions or corrections (@dlschwartz and @davidamichelson feel free to weigh in on this too)."},"comment":{"url":"https://api.github.com/repos/srophe/syriac-corpus-app/issues/comments/369723991","html_url":"https://github.com/srophe/syriac-corpus-app/issues/68#issuecomment-369723991","issue_url":"https://api.github.com/repos/srophe/syriac-corpus-app/issues/68","id":369723991,"user":{"login":"jedwardwalters","id":11543800,"avatar_url":"https://avatars3.githubusercontent.com/u/11543800?v=4","gravatar_id":"","url":"https://api.github.com/users/jedwardwalters","html_url":"https://github.com/jedwardwalters","followers_url":"https://api.github.com/users/jedwardwalters/followers","following_url":"https://api.github.com/users/jedwardwalters/following{/other_user}","gists_url":"https://api.github.com/users/jedwardwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwardwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwardwalters/subscriptions","organizations_url":"https://api.github.com/users/jedwardwalters/orgs","repos_url":"https://api.github.com/users/jedwardwalters/repos","events_url":"https://api.github.com/users/jedwardwalters/events{/privacy}","received_events_url":"https://api.github.com/users/jedwardwalters/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T20:41:47Z","updated_at":"2018-03-01T20:41:47Z","author_association":"COLLABORATOR","body":"Okay, @wsalesky, here are some thoughts on this feature (Sorry in advance that this is long!):\r\n\r\n1) Title - I don't think we need the number to pop up on any of the titles. So, I have a question: would it be an easy CSS thing to have the text of whatever is marked as a title display in red when this is toggled? If not, can we just remove the title feature as an option to toggle?\r\n\r\nSo, in this example: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/1\r\nIf we toggled the title button, I would want that first line (ܬܚܘܝܬܐ ܗܝܡܢܘܬܐ) to turn red instead of the number popping up next to it.\r\n\r\n2) I think the \"section\" toggle works well (on the same example given above), and I think it should be toggled on by default.\r\n\r\n3) This example doesn't have a \"title\" option: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/26\r\nMaybe something's wrong in my markup.\r\n\r\n4) For this one (and all poetic ones), I do think the \"line\" feature should be toggled on: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/27\r\n\r\n5) In that same example just given, though, I don't know why this one shows up as \"ab\" instead of \"title\"  -- Thoughts?\r\n\r\n6) I have two things on this example: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/100     \r\n\r\n- I'd like for the toggle button to say \"verse\" instead of \"ab\" - so maybe there's a way of specifying the \"type\" associated with the ab element? Also, on this example, the ab/verse toggle isn't showing up at all: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/119\r\n\r\n- The \"chapter\" toggle is a bit odd here. Mostly it's the English title display that is odd. It's showing up at the end of the first line of syriac. It would be great if the English title were offset on its own line (that may be a fix in the TEI--if so, let me know)\r\n\r\n7) The titles show up on this example: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/186 and this one: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/187 differently than other texts (gray text at the top, left justified). I like this display, actually, I'm just pointing out that it is different. Also, these texts don't have any title toggle feature. Don't know if that's related.\r\n\r\n8) This example: http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/188   doesn't have anything in the toggle view box\r\n\r\n"}}
{"actor":{"display_login":"jedwardwalters"}}