{"push_id":2920722960,"size":6,"distinct_size":4,"ref":"refs/heads/this-type","head":"6c750d671d6759c257ee227d4454b34d29cc009a","before":"c64f33cbd6f7d1b56fb21269205e409e37742a00","commits":[{"sha":"19cb2762ff1d0a8426dafcfdc04598b5005f968b","author":{"name":"Evan Martin","email":"8e4c7829956390ca66ad4a9787c5043d687a289d@gmail.com"},"message":"require a rootDir param when generating externs\n\nWe want to maintain the invariant that ts.SourceFile uses absolute\npaths.  Fix some non-absolute path monkeying in generating externs\nby explicitly passing in the rootDir in a case where we care about\nmaking a path relative.\n\nThis is similar to e.g. ts.formatDiagnostics() requiring a rootDir\nto make the emitted file names relative against.  (There's a TODO\nin test_support about fixing exactly this path.)","distinct":false,"url":"https://api.github.com/repos/angular/tsickle/commits/19cb2762ff1d0a8426dafcfdc04598b5005f968b"},{"sha":"364cfdf1db9a058d1b36b1d68dceb244b8754358","author":{"name":"Evan Martin","email":"8e4c7829956390ca66ad4a9787c5043d687a289d@gmail.com"},"message":"consistently use absolute paths\n\nThe TypeScript API wants absolute paths, and fights against you if\nyou don't use them.  This change makes tsickle assert that it has\nabsolute paths in various places and fixes up many of the places\nwhere we accidentally weren't using absolute paths.\n\nThis changes the public API of tsickle in a few places:\n- source files coming in to tsickle must be absolute\n- other path-based attributes like the based type blacklist and externs\n  also work with absolute paths\n\nTo implement this, in the whole test suite we depend on the compiler\noptions always including a rootDir, so the various tests now say\noptions.rootDir! occasionally.  Also each test's path manipulation\nhas been adjusted to be careful to use absolute/relative paths where\nappropriate.\n\nThis change also removes calls to process.cwd() and path.resolve(),\nboth of which depend on the current directory, in favor of reliably\nusing bazel's runfiles.","distinct":false,"url":"https://api.github.com/repos/angular/tsickle/commits/364cfdf1db9a058d1b36b1d68dceb244b8754358"},{"sha":"5a60d15bd799abad5556ef2befbdfa4cb31b66d9","author":{"name":"Martin Probst","email":"54669547a225ff20cba8b75a4adca540eef25858@probst.io"},"message":"Handle `this` return types.\n\nClosure compiler represents these by a method that has an `@template`d\n`@this` type.\n\nTypeScript does not expose the required `isThisType` field, which this\nworks around by casting through `any`.","distinct":true,"url":"https://api.github.com/repos/angular/tsickle/commits/5a60d15bd799abad5556ef2befbdfa4cb31b66d9"},{"sha":"26af4fe38960b74b593c01ef528ee47d1b7f8c41","author":{"name":"Martin Probst","email":"54669547a225ff20cba8b75a4adca540eef25858@probst.io"},"message":"Add a test for overloads together with this.","distinct":true,"url":"https://api.github.com/repos/angular/tsickle/commits/26af4fe38960b74b593c01ef528ee47d1b7f8c41"},{"sha":"e356879e3ac543bbbb701c0ca644284fdf368fd8","author":{"name":"Martin Probst","email":"54669547a225ff20cba8b75a4adca540eef25858@probst.io"},"message":"Insert explicit casts for templated this types.\n\nClosure Compiler cannot type check template types. Inserting casts\navoids an unknown this warning.","distinct":true,"url":"https://api.github.com/repos/angular/tsickle/commits/e356879e3ac543bbbb701c0ca644284fdf368fd8"},{"sha":"6c750d671d6759c257ee227d4454b34d29cc009a","author":{"name":"Martin Probst","email":"54669547a225ff20cba8b75a4adca540eef25858@probst.io"},"message":"Insert a cast on *every* this access.","distinct":true,"url":"https://api.github.com/repos/angular/tsickle/commits/6c750d671d6759c257ee227d4454b34d29cc009a"}]}
{"actor":{"display_login":"mprobst"}}