{"action":"created","comment":{"url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/comments/219477854","pull_request_review_id":157664843,"id":219477854,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQ3Nzg1NA==","diff_hunk":"@@ -110,6 +110,8 @@ spec:\n           env:\n             - name: PYTHONUNBUFFERED\n               value: \"1\"\n+            - name: HELM_RELEASE_NAME\n+              value: {{ .Release.Name | quote }}","path":"jupyterhub/templates/hub/deployment.yaml","position":null,"original_position":5,"commit_id":"bcd6266b85f57f01d3e48d5578420d76dbfdbe29","original_commit_id":"12ed7bb7f4ac03ddcc17079e0cbb51354ee89101","user":{"login":"consideRatio","id":3837114,"node_id":"MDQ6VXNlcjM4MzcxMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3837114?v=4","gravatar_id":"","url":"https://api.github.com/users/consideRatio","html_url":"https://github.com/consideRatio","followers_url":"https://api.github.com/users/consideRatio/followers","following_url":"https://api.github.com/users/consideRatio/following{/other_user}","gists_url":"https://api.github.com/users/consideRatio/gists{/gist_id}","starred_url":"https://api.github.com/users/consideRatio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/consideRatio/subscriptions","organizations_url":"https://api.github.com/users/consideRatio/orgs","repos_url":"https://api.github.com/users/consideRatio/repos","events_url":"https://api.github.com/users/consideRatio/events{/privacy}","received_events_url":"https://api.github.com/users/consideRatio/received_events","type":"User","site_admin":false},"body":"Perhaps we should pass the [built in objects](https://docs.helm.sh/chart_template_guide/#built-in-objects) as well in the configmap?\r\n","created_at":"2018-09-21T12:20:12Z","updated_at":"2018-09-21T12:20:13Z","html_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/941#discussion_r219477854","pull_request_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/comments/219477854"},"html":{"href":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/941#discussion_r219477854"},"pull_request":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941","id":216323881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzIzODgx","html_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/941","diff_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/941.diff","patch_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/941.patch","issue_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues/941","number":941,"state":"open","locked":false,"title":"passthrough values.yaml","user":{"login":"minrk","id":151929,"node_id":"MDQ6VXNlcjE1MTkyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"opened for discussion of #341\n\npassthrough values as-is as a single configmap entry, rather than specifying a mapping of values -> configmap -> jupyterhub config\n\nsecret fields are omitted from the configmap and only secret fields are included in the secret\n\nboth secret and configmap have the same structure, the only difference is in the mutually-exclusive filtering of which fields are included.\n\nAs it stands, the only manual maintenance required of the configmap should be when new secrets are added, because they must be excluded explicitly from the configmap.\n\nThe fiddly bits here are that we need to specifically locate which fields are secret to exclude them from the configmap and include them in the secret. Fortunately, secret values change a lot less often than other values.\n\nAn alternative is to restructure values.yaml so that there is a top-level `secrets` key. This would be a lot more convenient for us, since the splitting logic would be clear and stable, but it would be less convenient for users, who would need to have:\n\n```yaml\nsecrets:\n  proxy:\n    secretToken: ...\nproxy:\n  otherConfig\n```\n\nIt would make much less of a difference for users who are maintaining a best-practices two-file `{config|secret}.yaml` deployment, since the top-level `secrets` key would only mean an increase of indentation by one level in the `secret.yaml` file.\n\nI haven't implemented the hub-side of the configuration, but the yaml->hub config transform now entirely belongs in the hub image's z2jh.py.","created_at":"2018-09-18T14:14:46Z","updated_at":"2018-09-21T12:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e7a712ef485f70d6a7f76d1dfbd5138a08465e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941/commits","review_comments_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941/comments","review_comment_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues/941/comments","statuses_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/statuses/bcd6266b85f57f01d3e48d5578420d76dbfdbe29","head":{"label":"minrk:values-passthrough","ref":"values-passthrough","sha":"bcd6266b85f57f01d3e48d5578420d76dbfdbe29","user":{"login":"minrk","id":151929,"node_id":"MDQ6VXNlcjE1MTkyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":104078552,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQwNzg1NTI=","name":"zero-to-jupyterhub-k8s","full_name":"minrk/zero-to-jupyterhub-k8s","private":false,"owner":{"login":"minrk","id":151929,"node_id":"MDQ6VXNlcjE1MTkyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/minrk/zero-to-jupyterhub-k8s","description":"Resources for deploying JupyterHub to a Kubernetes Cluster","fork":true,"url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s","forks_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/forks","keys_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/teams","hooks_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/hooks","issue_events_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/events","assignees_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/tags","blobs_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/languages","stargazers_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/stargazers","contributors_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/contributors","subscribers_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/subscribers","subscription_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/subscription","commits_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/merges","archive_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/downloads","issues_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/labels{/name}","releases_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/minrk/zero-to-jupyterhub-k8s/deployments","created_at":"2017-09-19T13:29:00Z","updated_at":"2018-08-10T13:14:14Z","pushed_at":"2018-09-21T12:16:27Z","git_url":"git://github.com/minrk/zero-to-jupyterhub-k8s.git","ssh_url":"git@github.com:minrk/zero-to-jupyterhub-k8s.git","clone_url":"https://github.com/minrk/zero-to-jupyterhub-k8s.git","svn_url":"https://github.com/minrk/zero-to-jupyterhub-k8s","homepage":"https://zero-to-jupyterhub.readthedocs.io","size":4921,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyterhub:master","ref":"master","sha":"c0b4dcf38c6b37ac5393a221458e490416b07e5c","user":{"login":"jupyterhub","id":17927519,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTI3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"repo":{"id":87849371,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzg0OTM3MQ==","name":"zero-to-jupyterhub-k8s","full_name":"jupyterhub/zero-to-jupyterhub-k8s","private":false,"owner":{"login":"jupyterhub","id":17927519,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTI3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s","description":"Resources for deploying JupyterHub to a Kubernetes Cluster","fork":false,"url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s","forks_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/forks","keys_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/teams","hooks_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/hooks","issue_events_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/events","assignees_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/tags","blobs_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/languages","stargazers_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/stargazers","contributors_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/contributors","subscribers_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/subscribers","subscription_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/subscription","commits_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/merges","archive_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/downloads","issues_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/labels{/name}","releases_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/deployments","created_at":"2017-04-10T19:25:35Z","updated_at":"2018-09-20T13:50:53Z","pushed_at":"2018-09-21T12:16:29Z","git_url":"git://github.com/jupyterhub/zero-to-jupyterhub-k8s.git","ssh_url":"git@github.com:jupyterhub/zero-to-jupyterhub-k8s.git","clone_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s.git","svn_url":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s","homepage":"https://z2jh.jupyter.org","size":4630,"stargazers_count":259,"watchers_count":259,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":146,"open_issues":132,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941"},"html":{"href":"https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/941"},"issue":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues/941"},"comments":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterhub/zero-to-jupyterhub-k8s/statuses/bcd6266b85f57f01d3e48d5578420d76dbfdbe29"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"consideRatio"}}