{"action":"created","comment":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments/188904340","pull_request_review_id":120974145,"id":188904340,"diff_hunk":"@@ -10,6 +10,11 @@\n   <div class=\"row\">\n     <h1>Register a snap name</h1>","path":"templates/publisher/register-name.html","position":2,"original_position":2,"commit_id":"6c314e2e592e1cb589ead398ea69718a5ddd2687","original_commit_id":"6c314e2e592e1cb589ead398ea69718a5ddd2687","user":{"login":"bartaz","id":83575,"avatar_url":"https://avatars2.githubusercontent.com/u/83575?v=4","gravatar_id":"","url":"https://api.github.com/users/bartaz","html_url":"https://github.com/bartaz","followers_url":"https://api.github.com/users/bartaz/followers","following_url":"https://api.github.com/users/bartaz/following{/other_user}","gists_url":"https://api.github.com/users/bartaz/gists{/gist_id}","starred_url":"https://api.github.com/users/bartaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartaz/subscriptions","organizations_url":"https://api.github.com/users/bartaz/orgs","repos_url":"https://api.github.com/users/bartaz/repos","events_url":"https://api.github.com/users/bartaz/events{/privacy}","received_events_url":"https://api.github.com/users/bartaz/received_events","type":"User","site_admin":false},"body":"`<h1>` seems too large comparing to other headings used around snapcraft.io\r\n\r\n'My snaps' main heading uses: `<h1 class=\"p-heading--three\">My snaps</h1>`, so I guess we should use same sizing here.","created_at":"2018-05-17T10:03:49Z","updated_at":"2018-05-17T10:03:49Z","html_url":"https://github.com/canonical-websites/snapcraft.io/pull/670#discussion_r188904340","pull_request_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments/188904340"},"html":{"href":"https://github.com/canonical-websites/snapcraft.io/pull/670#discussion_r188904340"},"pull_request":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670"}}},"pull_request":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670","id":188682025,"html_url":"https://github.com/canonical-websites/snapcraft.io/pull/670","diff_url":"https://github.com/canonical-websites/snapcraft.io/pull/670.diff","patch_url":"https://github.com/canonical-websites/snapcraft.io/pull/670.patch","issue_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/670","number":670,"state":"open","locked":false,"title":"Add style to reserve name templates","user":{"login":"tbille","id":2707508,"avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"body":"# Summary\r\n\r\nFixes https://github.com/CanonicalLtd/snap-squad/issues/482\r\n- Implement design for reserve name endpoint\r\n- Add template to claime a dispute\r\n\r\nDesigns provided:\r\n\r\n**Register name**\r\n![image](https://github.com/CanonicalLtd/snapcraft-design/blob/master/dashboard%20legacy%20work/01%20-%20Register%20snap.png)\r\n**Name dispute**\r\n![image](https://user-images.githubusercontent.com/2707508/40170389-3710a7d0-59c0-11e8-8c81-7810bd41a1a6.png)\r\n\r\n# QA\r\n\r\n- `./run`\r\n- http://127.0.0.1:8004/account/register-name\r\n- Register a new snap\r\n- Should redirect to `/account`\r\n- http://127.0.0.1:8004/account/register-name\r\n- Register a snap that already exists and that you don't own (I made one for you :heart: `test-register-snap-qa`)\r\n- Should redirect your to: http://127.0.0.1:8004/account/reserve-name?snap_name=test-register-snap-qa&is_private=False\r\n- Claim a dispute\r\n- THERE IS A PROBLEM WITH THE API SO FOR NOW YOU WILL BE REDIRECTED TO THE SAME PAGE: https://bugs.launchpad.net/snapstore/+bug/1771767\r\n- Should redirect you to `/account`\r\n- Access  http://127.0.0.1:8004/account/reserve-name\r\n- Should redirect you to: http://127.0.0.1:8004/account/register-name\r\n\r\nLove and prosperity to you","created_at":"2018-05-17T09:53:51Z","updated_at":"2018-05-17T10:03:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1396fbfe513cd8b86e6ae87b6742c236675e4b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":698999577,"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels/Review:%20Code%20needed","name":"Review: Code needed","color":"cdcdcd","default":false},{"id":698999584,"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels/Review:%20QA%20needed","name":"Review: QA needed","color":"cdcdcd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670/commits","review_comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670/comments","review_comment_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/670/comments","statuses_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/statuses/6c314e2e592e1cb589ead398ea69718a5ddd2687","head":{"label":"tbille:register-template","ref":"register-template","sha":"6c314e2e592e1cb589ead398ea69718a5ddd2687","user":{"login":"tbille","id":2707508,"avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"repo":{"id":109980720,"name":"snapcraft.io","full_name":"tbille/snapcraft.io","owner":{"login":"tbille","id":2707508,"avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbille/snapcraft.io","description":null,"fork":true,"url":"https://api.github.com/repos/tbille/snapcraft.io","forks_url":"https://api.github.com/repos/tbille/snapcraft.io/forks","keys_url":"https://api.github.com/repos/tbille/snapcraft.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbille/snapcraft.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbille/snapcraft.io/teams","hooks_url":"https://api.github.com/repos/tbille/snapcraft.io/hooks","issue_events_url":"https://api.github.com/repos/tbille/snapcraft.io/issues/events{/number}","events_url":"https://api.github.com/repos/tbille/snapcraft.io/events","assignees_url":"https://api.github.com/repos/tbille/snapcraft.io/assignees{/user}","branches_url":"https://api.github.com/repos/tbille/snapcraft.io/branches{/branch}","tags_url":"https://api.github.com/repos/tbille/snapcraft.io/tags","blobs_url":"https://api.github.com/repos/tbille/snapcraft.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbille/snapcraft.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbille/snapcraft.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbille/snapcraft.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbille/snapcraft.io/statuses/{sha}","languages_url":"https://api.github.com/repos/tbille/snapcraft.io/languages","stargazers_url":"https://api.github.com/repos/tbille/snapcraft.io/stargazers","contributors_url":"https://api.github.com/repos/tbille/snapcraft.io/contributors","subscribers_url":"https://api.github.com/repos/tbille/snapcraft.io/subscribers","subscription_url":"https://api.github.com/repos/tbille/snapcraft.io/subscription","commits_url":"https://api.github.com/repos/tbille/snapcraft.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbille/snapcraft.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbille/snapcraft.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbille/snapcraft.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbille/snapcraft.io/contents/{+path}","compare_url":"https://api.github.com/repos/tbille/snapcraft.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbille/snapcraft.io/merges","archive_url":"https://api.github.com/repos/tbille/snapcraft.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbille/snapcraft.io/downloads","issues_url":"https://api.github.com/repos/tbille/snapcraft.io/issues{/number}","pulls_url":"https://api.github.com/repos/tbille/snapcraft.io/pulls{/number}","milestones_url":"https://api.github.com/repos/tbille/snapcraft.io/milestones{/number}","notifications_url":"https://api.github.com/repos/tbille/snapcraft.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbille/snapcraft.io/labels{/name}","releases_url":"https://api.github.com/repos/tbille/snapcraft.io/releases{/id}","deployments_url":"https://api.github.com/repos/tbille/snapcraft.io/deployments","created_at":"2017-11-08T13:39:43Z","updated_at":"2018-02-26T11:46:16Z","pushed_at":"2018-05-17T09:45:25Z","git_url":"git://github.com/tbille/snapcraft.io.git","ssh_url":"git@github.com:tbille/snapcraft.io.git","clone_url":"https://github.com/tbille/snapcraft.io.git","svn_url":"https://github.com/tbille/snapcraft.io","homepage":null,"size":1463,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"canonical-websites:master","ref":"master","sha":"7bded2eeb95db6d18b96d3982db9239b521cdd4e","user":{"login":"canonical-websites","id":26072773,"avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"repo":{"id":100534315,"name":"snapcraft.io","full_name":"canonical-websites/snapcraft.io","owner":{"login":"canonical-websites","id":26072773,"avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-websites/snapcraft.io","description":null,"fork":false,"url":"https://api.github.com/repos/canonical-websites/snapcraft.io","forks_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/forks","keys_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/teams","hooks_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/hooks","issue_events_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/events","assignees_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/tags","blobs_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/languages","stargazers_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/stargazers","contributors_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/contributors","subscribers_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/subscribers","subscription_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/subscription","commits_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/merges","archive_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/downloads","issues_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels{/name}","releases_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/deployments","created_at":"2017-08-16T21:29:29Z","updated_at":"2018-05-17T09:49:44Z","pushed_at":"2018-05-17T09:53:52Z","git_url":"git://github.com/canonical-websites/snapcraft.io.git","ssh_url":"git@github.com:canonical-websites/snapcraft.io.git","clone_url":"https://github.com/canonical-websites/snapcraft.io.git","svn_url":"https://github.com/canonical-websites/snapcraft.io","homepage":null,"size":1204,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":21,"open_issues":70,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670"},"html":{"href":"https://github.com/canonical-websites/snapcraft.io/pull/670"},"issue":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/670"},"comments":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/statuses/6c314e2e592e1cb589ead398ea69718a5ddd2687"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bartaz"}}