{"action":"opened","number":168,"pull_request":{"url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/168","id":212015978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDE1OTc4","html_url":"https://github.com/FirebirdSQL/firebird/pull/168","diff_url":"https://github.com/FirebirdSQL/firebird/pull/168.diff","patch_url":"https://github.com/FirebirdSQL/firebird/pull/168.patch","issue_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/168","number":168,"state":"open","locked":false,"title":"Fix external engine memory leaks","user":{"login":"artyom-smirnov","id":109088,"node_id":"MDQ6VXNlcjEwOTA4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/109088?v=4","gravatar_id":"","url":"https://api.github.com/users/artyom-smirnov","html_url":"https://github.com/artyom-smirnov","followers_url":"https://api.github.com/users/artyom-smirnov/followers","following_url":"https://api.github.com/users/artyom-smirnov/following{/other_user}","gists_url":"https://api.github.com/users/artyom-smirnov/gists{/gist_id}","starred_url":"https://api.github.com/users/artyom-smirnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artyom-smirnov/subscriptions","organizations_url":"https://api.github.com/users/artyom-smirnov/orgs","repos_url":"https://api.github.com/users/artyom-smirnov/repos","events_url":"https://api.github.com/users/artyom-smirnov/events{/privacy}","received_events_url":"https://api.github.com/users/artyom-smirnov/received_events","type":"User","site_admin":false},"body":"Some engine objects never destructing explicitly, but hold resources of external engine which should be released. As I see udr_engine do not affected leaking, but architecture of fbjava prone to leaking if dispose/release never called. I've added straightforward solution to avoid memory leaks from external engine, is it ok? 3.0 have same problem.","created_at":"2018-08-30T09:37:40Z","updated_at":"2018-08-30T09:37:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/168/commits","review_comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/168/comments","review_comment_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/168/comments","statuses_url":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/23843faf25dd69dc8a05a9b02b89757ee8b9d842","head":{"label":"red-soft-ru:master_external_engine_memory_leak","ref":"master_external_engine_memory_leak","sha":"23843faf25dd69dc8a05a9b02b89757ee8b9d842","user":{"login":"red-soft-ru","id":12032110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMyMTEw","avatar_url":"https://avatars3.githubusercontent.com/u/12032110?v=4","gravatar_id":"","url":"https://api.github.com/users/red-soft-ru","html_url":"https://github.com/red-soft-ru","followers_url":"https://api.github.com/users/red-soft-ru/followers","following_url":"https://api.github.com/users/red-soft-ru/following{/other_user}","gists_url":"https://api.github.com/users/red-soft-ru/gists{/gist_id}","starred_url":"https://api.github.com/users/red-soft-ru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-soft-ru/subscriptions","organizations_url":"https://api.github.com/users/red-soft-ru/orgs","repos_url":"https://api.github.com/users/red-soft-ru/repos","events_url":"https://api.github.com/users/red-soft-ru/events{/privacy}","received_events_url":"https://api.github.com/users/red-soft-ru/received_events","type":"Organization","site_admin":false},"repo":{"id":54107123,"node_id":"MDEwOlJlcG9zaXRvcnk1NDEwNzEyMw==","name":"firebird","full_name":"red-soft-ru/firebird","owner":{"login":"red-soft-ru","id":12032110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMyMTEw","avatar_url":"https://avatars3.githubusercontent.com/u/12032110?v=4","gravatar_id":"","url":"https://api.github.com/users/red-soft-ru","html_url":"https://github.com/red-soft-ru","followers_url":"https://api.github.com/users/red-soft-ru/followers","following_url":"https://api.github.com/users/red-soft-ru/following{/other_user}","gists_url":"https://api.github.com/users/red-soft-ru/gists{/gist_id}","starred_url":"https://api.github.com/users/red-soft-ru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-soft-ru/subscriptions","organizations_url":"https://api.github.com/users/red-soft-ru/orgs","repos_url":"https://api.github.com/users/red-soft-ru/repos","events_url":"https://api.github.com/users/red-soft-ru/events{/privacy}","received_events_url":"https://api.github.com/users/red-soft-ru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/red-soft-ru/firebird","description":"Firebird server, client and tools","fork":true,"url":"https://api.github.com/repos/red-soft-ru/firebird","forks_url":"https://api.github.com/repos/red-soft-ru/firebird/forks","keys_url":"https://api.github.com/repos/red-soft-ru/firebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/red-soft-ru/firebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/red-soft-ru/firebird/teams","hooks_url":"https://api.github.com/repos/red-soft-ru/firebird/hooks","issue_events_url":"https://api.github.com/repos/red-soft-ru/firebird/issues/events{/number}","events_url":"https://api.github.com/repos/red-soft-ru/firebird/events","assignees_url":"https://api.github.com/repos/red-soft-ru/firebird/assignees{/user}","branches_url":"https://api.github.com/repos/red-soft-ru/firebird/branches{/branch}","tags_url":"https://api.github.com/repos/red-soft-ru/firebird/tags","blobs_url":"https://api.github.com/repos/red-soft-ru/firebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/red-soft-ru/firebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/red-soft-ru/firebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/red-soft-ru/firebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/red-soft-ru/firebird/statuses/{sha}","languages_url":"https://api.github.com/repos/red-soft-ru/firebird/languages","stargazers_url":"https://api.github.com/repos/red-soft-ru/firebird/stargazers","contributors_url":"https://api.github.com/repos/red-soft-ru/firebird/contributors","subscribers_url":"https://api.github.com/repos/red-soft-ru/firebird/subscribers","subscription_url":"https://api.github.com/repos/red-soft-ru/firebird/subscription","commits_url":"https://api.github.com/repos/red-soft-ru/firebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/red-soft-ru/firebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/red-soft-ru/firebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/red-soft-ru/firebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/red-soft-ru/firebird/contents/{+path}","compare_url":"https://api.github.com/repos/red-soft-ru/firebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/red-soft-ru/firebird/merges","archive_url":"https://api.github.com/repos/red-soft-ru/firebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/red-soft-ru/firebird/downloads","issues_url":"https://api.github.com/repos/red-soft-ru/firebird/issues{/number}","pulls_url":"https://api.github.com/repos/red-soft-ru/firebird/pulls{/number}","milestones_url":"https://api.github.com/repos/red-soft-ru/firebird/milestones{/number}","notifications_url":"https://api.github.com/repos/red-soft-ru/firebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/red-soft-ru/firebird/labels{/name}","releases_url":"https://api.github.com/repos/red-soft-ru/firebird/releases{/id}","deployments_url":"https://api.github.com/repos/red-soft-ru/firebird/deployments","created_at":"2016-03-17T09:53:16Z","updated_at":"2018-08-30T01:01:21Z","pushed_at":"2018-08-30T09:27:39Z","git_url":"git://github.com/red-soft-ru/firebird.git","ssh_url":"git@github.com:red-soft-ru/firebird.git","clone_url":"https://github.com/red-soft-ru/firebird.git","svn_url":"https://github.com/red-soft-ru/firebird","homepage":"http://www.firebirdsql.org/","size":136394,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"FirebirdSQL:master","ref":"master","sha":"dac9493fdd885eec54103d5f34865ad0b050d8f1","user":{"login":"FirebirdSQL","id":6057940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6057940?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebirdSQL","html_url":"https://github.com/FirebirdSQL","followers_url":"https://api.github.com/users/FirebirdSQL/followers","following_url":"https://api.github.com/users/FirebirdSQL/following{/other_user}","gists_url":"https://api.github.com/users/FirebirdSQL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebirdSQL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebirdSQL/subscriptions","organizations_url":"https://api.github.com/users/FirebirdSQL/orgs","repos_url":"https://api.github.com/users/FirebirdSQL/repos","events_url":"https://api.github.com/users/FirebirdSQL/events{/privacy}","received_events_url":"https://api.github.com/users/FirebirdSQL/received_events","type":"Organization","site_admin":false},"repo":{"id":54005538,"node_id":"MDEwOlJlcG9zaXRvcnk1NDAwNTUzOA==","name":"firebird","full_name":"FirebirdSQL/firebird","owner":{"login":"FirebirdSQL","id":6057940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6057940?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebirdSQL","html_url":"https://github.com/FirebirdSQL","followers_url":"https://api.github.com/users/FirebirdSQL/followers","following_url":"https://api.github.com/users/FirebirdSQL/following{/other_user}","gists_url":"https://api.github.com/users/FirebirdSQL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebirdSQL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebirdSQL/subscriptions","organizations_url":"https://api.github.com/users/FirebirdSQL/orgs","repos_url":"https://api.github.com/users/FirebirdSQL/repos","events_url":"https://api.github.com/users/FirebirdSQL/events{/privacy}","received_events_url":"https://api.github.com/users/FirebirdSQL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FirebirdSQL/firebird","description":"Firebird server, client and tools","fork":false,"url":"https://api.github.com/repos/FirebirdSQL/firebird","forks_url":"https://api.github.com/repos/FirebirdSQL/firebird/forks","keys_url":"https://api.github.com/repos/FirebirdSQL/firebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirebirdSQL/firebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirebirdSQL/firebird/teams","hooks_url":"https://api.github.com/repos/FirebirdSQL/firebird/hooks","issue_events_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/events{/number}","events_url":"https://api.github.com/repos/FirebirdSQL/firebird/events","assignees_url":"https://api.github.com/repos/FirebirdSQL/firebird/assignees{/user}","branches_url":"https://api.github.com/repos/FirebirdSQL/firebird/branches{/branch}","tags_url":"https://api.github.com/repos/FirebirdSQL/firebird/tags","blobs_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/{sha}","languages_url":"https://api.github.com/repos/FirebirdSQL/firebird/languages","stargazers_url":"https://api.github.com/repos/FirebirdSQL/firebird/stargazers","contributors_url":"https://api.github.com/repos/FirebirdSQL/firebird/contributors","subscribers_url":"https://api.github.com/repos/FirebirdSQL/firebird/subscribers","subscription_url":"https://api.github.com/repos/FirebirdSQL/firebird/subscription","commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirebirdSQL/firebird/contents/{+path}","compare_url":"https://api.github.com/repos/FirebirdSQL/firebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirebirdSQL/firebird/merges","archive_url":"https://api.github.com/repos/FirebirdSQL/firebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirebirdSQL/firebird/downloads","issues_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues{/number}","pulls_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls{/number}","milestones_url":"https://api.github.com/repos/FirebirdSQL/firebird/milestones{/number}","notifications_url":"https://api.github.com/repos/FirebirdSQL/firebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirebirdSQL/firebird/labels{/name}","releases_url":"https://api.github.com/repos/FirebirdSQL/firebird/releases{/id}","deployments_url":"https://api.github.com/repos/FirebirdSQL/firebird/deployments","created_at":"2016-03-16T06:10:37Z","updated_at":"2018-08-30T01:30:33Z","pushed_at":"2018-08-30T00:05:54Z","git_url":"git://github.com/FirebirdSQL/firebird.git","ssh_url":"git@github.com:FirebirdSQL/firebird.git","clone_url":"https://github.com/FirebirdSQL/firebird.git","svn_url":"https://github.com/FirebirdSQL/firebird","homepage":"http://www.firebirdsql.org/","size":152768,"stargazers_count":258,"watchers_count":258,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":69,"open_issues":23,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/168"},"html":{"href":"https://github.com/FirebirdSQL/firebird/pull/168"},"issue":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/issues/168"},"comments":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/23843faf25dd69dc8a05a9b02b89757ee8b9d842"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":44,"deletions":2,"changed_files":7}}
{"actor":{"display_login":"artyom-smirnov"}}