{"action":"created","comment":{"url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/comments/195959936","pull_request_review_id":129421757,"id":195959936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk1OTkzNg==","diff_hunk":"@@ -62,14 +62,13 @@ namespace Glest {\n \t\tstatic const string CORE_WATER_SOUNDS_PATH = CORE_PATH + \"/water_sounds/\";\n \n \t\t// Sound effects\n-\t\t// These variables are specified in the ini file\n-\t\tconst string PlaySoundClip::sfxAttention = \"PlaySoundAttention\";\n-\t\tconst string PlaySoundClip::sfxHighlight = \"PlaySoundHighlight\";\n-\t\tconst string PlaySoundClip::sfxNewServer = \"PlaySoundNewServer\";\n-\t\tconst string PlaySoundClip::sfxMarker = \"PlaySoundMarker\";\n-\t\tconst string PlaySoundClip::sfxMenuClickA = \"PlaySoundMenuClickA\";\n-\t\tconst string PlaySoundClip::sfxMenuClickB = \"PlaySoundMenuClickB\";\n-\t\tconst string PlaySoundClip::sfxMenuClickC = \"PlaySoundMenuClickC\";\n+\t\tconst string sfxAttention = data_path + CORE_MENU_SOUND_PATH + \"attention.wav\";","path":"source/glest_game/global/core_data.cpp","position":12,"original_position":12,"commit_id":"f2bdfcccc54c14503df5421d738d5c67df8f2c09","original_commit_id":"f2bdfcccc54c14503df5421d738d5c67df8f2c09","user":{"login":"andy5995","id":16764864,"node_id":"MDQ6VXNlcjE2NzY0ODY0","avatar_url":"https://avatars3.githubusercontent.com/u/16764864?v=4","gravatar_id":"","url":"https://api.github.com/users/andy5995","html_url":"https://github.com/andy5995","followers_url":"https://api.github.com/users/andy5995/followers","following_url":"https://api.github.com/users/andy5995/following{/other_user}","gists_url":"https://api.github.com/users/andy5995/gists{/gist_id}","starred_url":"https://api.github.com/users/andy5995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy5995/subscriptions","organizations_url":"https://api.github.com/users/andy5995/orgs","repos_url":"https://api.github.com/users/andy5995/repos","events_url":"https://api.github.com/users/andy5995/events{/privacy}","received_events_url":"https://api.github.com/users/andy5995/received_events","type":"User","site_admin":false},"body":"@mathusummut , data_path is used elsewhere but it's not declared here yet. I'm not sure where to put these 7 assignments.","created_at":"2018-06-18T03:50:50Z","updated_at":"2018-06-18T03:50:50Z","html_url":"https://github.com/ZetaGlest/zetaglest-source/pull/158#discussion_r195959936","pull_request_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/comments/195959936"},"html":{"href":"https://github.com/ZetaGlest/zetaglest-source/pull/158#discussion_r195959936"},"pull_request":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158","id":195416226,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDE2MjI2","html_url":"https://github.com/ZetaGlest/zetaglest-source/pull/158","diff_url":"https://github.com/ZetaGlest/zetaglest-source/pull/158.diff","patch_url":"https://github.com/ZetaGlest/zetaglest-source/pull/158.patch","issue_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues/158","number":158,"state":"open","locked":false,"title":"[wip]replace paths from glest.ini into source code[skip ci][#113]","user":{"login":"andy5995","id":16764864,"node_id":"MDQ6VXNlcjE2NzY0ODY0","avatar_url":"https://avatars3.githubusercontent.com/u/16764864?v=4","gravatar_id":"","url":"https://api.github.com/users/andy5995","html_url":"https://github.com/andy5995","followers_url":"https://api.github.com/users/andy5995/followers","following_url":"https://api.github.com/users/andy5995/following{/other_user}","gists_url":"https://api.github.com/users/andy5995/gists{/gist_id}","starred_url":"https://api.github.com/users/andy5995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy5995/subscriptions","organizations_url":"https://api.github.com/users/andy5995/orgs","repos_url":"https://api.github.com/users/andy5995/repos","events_url":"https://api.github.com/users/andy5995/events{/privacy}","received_events_url":"https://api.github.com/users/andy5995/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-18T03:46:49Z","updated_at":"2018-06-18T03:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc6db86873928b68d693b1e76a1fd0c03ccdcda","assignee":{"login":"andy5995","id":16764864,"node_id":"MDQ6VXNlcjE2NzY0ODY0","avatar_url":"https://avatars3.githubusercontent.com/u/16764864?v=4","gravatar_id":"","url":"https://api.github.com/users/andy5995","html_url":"https://github.com/andy5995","followers_url":"https://api.github.com/users/andy5995/followers","following_url":"https://api.github.com/users/andy5995/following{/other_user}","gists_url":"https://api.github.com/users/andy5995/gists{/gist_id}","starred_url":"https://api.github.com/users/andy5995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy5995/subscriptions","organizations_url":"https://api.github.com/users/andy5995/orgs","repos_url":"https://api.github.com/users/andy5995/repos","events_url":"https://api.github.com/users/andy5995/events{/privacy}","received_events_url":"https://api.github.com/users/andy5995/received_events","type":"User","site_admin":false},"assignees":[{"login":"andy5995","id":16764864,"node_id":"MDQ6VXNlcjE2NzY0ODY0","avatar_url":"https://avatars3.githubusercontent.com/u/16764864?v=4","gravatar_id":"","url":"https://api.github.com/users/andy5995","html_url":"https://github.com/andy5995","followers_url":"https://api.github.com/users/andy5995/followers","following_url":"https://api.github.com/users/andy5995/following{/other_user}","gists_url":"https://api.github.com/users/andy5995/gists{/gist_id}","starred_url":"https://api.github.com/users/andy5995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy5995/subscriptions","organizations_url":"https://api.github.com/users/andy5995/orgs","repos_url":"https://api.github.com/users/andy5995/repos","events_url":"https://api.github.com/users/andy5995/events{/privacy}","received_events_url":"https://api.github.com/users/andy5995/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":817227488,"node_id":"MDU6TGFiZWw4MTcyMjc0ODg=","url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/labels/wip","name":"wip","color":"8a75d8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158/commits","review_comments_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158/comments","review_comment_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues/158/comments","statuses_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/statuses/f2bdfcccc54c14503df5421d738d5c67df8f2c09","head":{"label":"andy5995:issue_113","ref":"issue_113","sha":"f2bdfcccc54c14503df5421d738d5c67df8f2c09","user":{"login":"andy5995","id":16764864,"node_id":"MDQ6VXNlcjE2NzY0ODY0","avatar_url":"https://avatars3.githubusercontent.com/u/16764864?v=4","gravatar_id":"","url":"https://api.github.com/users/andy5995","html_url":"https://github.com/andy5995","followers_url":"https://api.github.com/users/andy5995/followers","following_url":"https://api.github.com/users/andy5995/following{/other_user}","gists_url":"https://api.github.com/users/andy5995/gists{/gist_id}","starred_url":"https://api.github.com/users/andy5995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy5995/subscriptions","organizations_url":"https://api.github.com/users/andy5995/orgs","repos_url":"https://api.github.com/users/andy5995/repos","events_url":"https://api.github.com/users/andy5995/events{/privacy}","received_events_url":"https://api.github.com/users/andy5995/received_events","type":"User","site_admin":false},"repo":{"id":132161233,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxNjEyMzM=","name":"zetaglest-source","full_name":"andy5995/zetaglest-source","owner":{"login":"andy5995","id":16764864,"node_id":"MDQ6VXNlcjE2NzY0ODY0","avatar_url":"https://avatars3.githubusercontent.com/u/16764864?v=4","gravatar_id":"","url":"https://api.github.com/users/andy5995","html_url":"https://github.com/andy5995","followers_url":"https://api.github.com/users/andy5995/followers","following_url":"https://api.github.com/users/andy5995/following{/other_user}","gists_url":"https://api.github.com/users/andy5995/gists{/gist_id}","starred_url":"https://api.github.com/users/andy5995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy5995/subscriptions","organizations_url":"https://api.github.com/users/andy5995/orgs","repos_url":"https://api.github.com/users/andy5995/repos","events_url":"https://api.github.com/users/andy5995/events{/privacy}","received_events_url":"https://api.github.com/users/andy5995/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy5995/zetaglest-source","description":"ZetaGlest is a fork of MegaGlest, a network multi-player cross-platform 3D real-time strategy (RTS) game, where you control the armies of one of eight different factions.","fork":true,"url":"https://api.github.com/repos/andy5995/zetaglest-source","forks_url":"https://api.github.com/repos/andy5995/zetaglest-source/forks","keys_url":"https://api.github.com/repos/andy5995/zetaglest-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy5995/zetaglest-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy5995/zetaglest-source/teams","hooks_url":"https://api.github.com/repos/andy5995/zetaglest-source/hooks","issue_events_url":"https://api.github.com/repos/andy5995/zetaglest-source/issues/events{/number}","events_url":"https://api.github.com/repos/andy5995/zetaglest-source/events","assignees_url":"https://api.github.com/repos/andy5995/zetaglest-source/assignees{/user}","branches_url":"https://api.github.com/repos/andy5995/zetaglest-source/branches{/branch}","tags_url":"https://api.github.com/repos/andy5995/zetaglest-source/tags","blobs_url":"https://api.github.com/repos/andy5995/zetaglest-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy5995/zetaglest-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy5995/zetaglest-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy5995/zetaglest-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy5995/zetaglest-source/statuses/{sha}","languages_url":"https://api.github.com/repos/andy5995/zetaglest-source/languages","stargazers_url":"https://api.github.com/repos/andy5995/zetaglest-source/stargazers","contributors_url":"https://api.github.com/repos/andy5995/zetaglest-source/contributors","subscribers_url":"https://api.github.com/repos/andy5995/zetaglest-source/subscribers","subscription_url":"https://api.github.com/repos/andy5995/zetaglest-source/subscription","commits_url":"https://api.github.com/repos/andy5995/zetaglest-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy5995/zetaglest-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy5995/zetaglest-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy5995/zetaglest-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy5995/zetaglest-source/contents/{+path}","compare_url":"https://api.github.com/repos/andy5995/zetaglest-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy5995/zetaglest-source/merges","archive_url":"https://api.github.com/repos/andy5995/zetaglest-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy5995/zetaglest-source/downloads","issues_url":"https://api.github.com/repos/andy5995/zetaglest-source/issues{/number}","pulls_url":"https://api.github.com/repos/andy5995/zetaglest-source/pulls{/number}","milestones_url":"https://api.github.com/repos/andy5995/zetaglest-source/milestones{/number}","notifications_url":"https://api.github.com/repos/andy5995/zetaglest-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy5995/zetaglest-source/labels{/name}","releases_url":"https://api.github.com/repos/andy5995/zetaglest-source/releases{/id}","deployments_url":"https://api.github.com/repos/andy5995/zetaglest-source/deployments","created_at":"2018-05-04T16:00:59Z","updated_at":"2018-06-15T23:48:25Z","pushed_at":"2018-06-18T03:45:58Z","git_url":"git://github.com/andy5995/zetaglest-source.git","ssh_url":"git@github.com:andy5995/zetaglest-source.git","clone_url":"https://github.com/andy5995/zetaglest-source.git","svn_url":"https://github.com/andy5995/zetaglest-source","homepage":"https://zetaglest.github.io/docs/","size":28497,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ZetaGlest:develop","ref":"develop","sha":"3e8f8f7dd5b7480c9c43fdfb4fb6bfa1c434fe14","user":{"login":"ZetaGlest","id":35409328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDA5MzI4","avatar_url":"https://avatars0.githubusercontent.com/u/35409328?v=4","gravatar_id":"","url":"https://api.github.com/users/ZetaGlest","html_url":"https://github.com/ZetaGlest","followers_url":"https://api.github.com/users/ZetaGlest/followers","following_url":"https://api.github.com/users/ZetaGlest/following{/other_user}","gists_url":"https://api.github.com/users/ZetaGlest/gists{/gist_id}","starred_url":"https://api.github.com/users/ZetaGlest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZetaGlest/subscriptions","organizations_url":"https://api.github.com/users/ZetaGlest/orgs","repos_url":"https://api.github.com/users/ZetaGlest/repos","events_url":"https://api.github.com/users/ZetaGlest/events{/privacy}","received_events_url":"https://api.github.com/users/ZetaGlest/received_events","type":"Organization","site_admin":false},"repo":{"id":117382691,"node_id":"MDEwOlJlcG9zaXRvcnkxMTczODI2OTE=","name":"zetaglest-source","full_name":"ZetaGlest/zetaglest-source","owner":{"login":"ZetaGlest","id":35409328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDA5MzI4","avatar_url":"https://avatars0.githubusercontent.com/u/35409328?v=4","gravatar_id":"","url":"https://api.github.com/users/ZetaGlest","html_url":"https://github.com/ZetaGlest","followers_url":"https://api.github.com/users/ZetaGlest/followers","following_url":"https://api.github.com/users/ZetaGlest/following{/other_user}","gists_url":"https://api.github.com/users/ZetaGlest/gists{/gist_id}","starred_url":"https://api.github.com/users/ZetaGlest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZetaGlest/subscriptions","organizations_url":"https://api.github.com/users/ZetaGlest/orgs","repos_url":"https://api.github.com/users/ZetaGlest/repos","events_url":"https://api.github.com/users/ZetaGlest/events{/privacy}","received_events_url":"https://api.github.com/users/ZetaGlest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZetaGlest/zetaglest-source","description":"ZetaGlest is a fork of MegaGlest, a network multi-player cross-platform 3D real-time strategy (RTS) game, where you create armies of units and battle different factions.","fork":false,"url":"https://api.github.com/repos/ZetaGlest/zetaglest-source","forks_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/forks","keys_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/teams","hooks_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/hooks","issue_events_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues/events{/number}","events_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/events","assignees_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/assignees{/user}","branches_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/branches{/branch}","tags_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/tags","blobs_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/statuses/{sha}","languages_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/languages","stargazers_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/stargazers","contributors_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/contributors","subscribers_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/subscribers","subscription_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/subscription","commits_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/contents/{+path}","compare_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/merges","archive_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/downloads","issues_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues{/number}","pulls_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls{/number}","milestones_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/milestones{/number}","notifications_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/labels{/name}","releases_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/releases{/id}","deployments_url":"https://api.github.com/repos/ZetaGlest/zetaglest-source/deployments","created_at":"2018-01-13T22:15:43Z","updated_at":"2018-06-17T19:11:27Z","pushed_at":"2018-06-18T03:46:50Z","git_url":"git://github.com/ZetaGlest/zetaglest-source.git","ssh_url":"git@github.com:ZetaGlest/zetaglest-source.git","clone_url":"https://github.com/ZetaGlest/zetaglest-source.git","svn_url":"https://github.com/ZetaGlest/zetaglest-source","homepage":"https://zetaglest.github.io/docs/","size":28497,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":56,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158"},"html":{"href":"https://github.com/ZetaGlest/zetaglest-source/pull/158"},"issue":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues/158"},"comments":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/ZetaGlest/zetaglest-source/statuses/f2bdfcccc54c14503df5421d738d5c67df8f2c09"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andy5995"}}