{"action":"created","comment":{"url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/comments/224673979","pull_request_review_id":164100894,"id":224673979,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDY3Mzk3OQ==","diff_hunk":"@@ -38,7 +38,23 @@ below, Bounter uses 31x less memory compared to ``Counter``.\n Bounter is also marginally faster than the built-in ``dict`` and\n ``Counter``, so wherever you can represent your **items as strings**\n (both byte-strings and unicode are fine, and Bounter works in both\n-Python2 and Python3), there's no reason not to use Bounter instead.\n+Python2 and Python3), there's no reason not to use Bounter instead except:\n+\n+When not to use Bounter?\n+------------------------\n+\n+Beware, Bounter is only a probabilistic frequency counter and cannot be relied on for fine counting. (You can't expect a data structure with finite size to hold infinite data.)","path":"README.rst","position":10,"original_position":10,"commit_id":"8405abc12edfdfd68803033e4f7a41ecf49b3964","original_commit_id":"8405abc12edfdfd68803033e4f7a41ecf49b3964","user":{"login":"piskvorky","id":610412,"node_id":"MDQ6VXNlcjYxMDQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/610412?v=4","gravatar_id":"","url":"https://api.github.com/users/piskvorky","html_url":"https://github.com/piskvorky","followers_url":"https://api.github.com/users/piskvorky/followers","following_url":"https://api.github.com/users/piskvorky/following{/other_user}","gists_url":"https://api.github.com/users/piskvorky/gists{/gist_id}","starred_url":"https://api.github.com/users/piskvorky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piskvorky/subscriptions","organizations_url":"https://api.github.com/users/piskvorky/orgs","repos_url":"https://api.github.com/users/piskvorky/repos","events_url":"https://api.github.com/users/piskvorky/events{/privacy}","received_events_url":"https://api.github.com/users/piskvorky/received_events","type":"User","site_admin":false},"body":"Is this file auto-generated? Or why are we keeping two parallel READMEs?\r\n\r\nAnyway, the same changes here please.","created_at":"2018-10-12T05:28:59Z","updated_at":"2018-10-12T05:29:03Z","html_url":"https://github.com/RaRe-Technologies/bounter/pull/37#discussion_r224673979","pull_request_url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/comments/224673979"},"html":{"href":"https://github.com/RaRe-Technologies/bounter/pull/37#discussion_r224673979"},"pull_request":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37","id":222160684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTYwNjg0","html_url":"https://github.com/RaRe-Technologies/bounter/pull/37","diff_url":"https://github.com/RaRe-Technologies/bounter/pull/37.diff","patch_url":"https://github.com/RaRe-Technologies/bounter/pull/37.patch","issue_url":"https://api.github.com/repos/RaRe-Technologies/bounter/issues/37","number":37,"state":"open","locked":false,"title":"Add limitations of Bounter. Addresses #36","user":{"login":"aneesh-joshi","id":14147383,"node_id":"MDQ6VXNlcjE0MTQ3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14147383?v=4","gravatar_id":"","url":"https://api.github.com/users/aneesh-joshi","html_url":"https://github.com/aneesh-joshi","followers_url":"https://api.github.com/users/aneesh-joshi/followers","following_url":"https://api.github.com/users/aneesh-joshi/following{/other_user}","gists_url":"https://api.github.com/users/aneesh-joshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aneesh-joshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneesh-joshi/subscriptions","organizations_url":"https://api.github.com/users/aneesh-joshi/orgs","repos_url":"https://api.github.com/users/aneesh-joshi/repos","events_url":"https://api.github.com/users/aneesh-joshi/events{/privacy}","received_events_url":"https://api.github.com/users/aneesh-joshi/received_events","type":"User","site_admin":false},"body":"Credit goes to the people on [this](https://news.ycombinator.com/item?id=15521177) page.\r\nI merely worded their concerns.\r\n\r\nAddresses: https://github.com/RaRe-Technologies/bounter/issues/36\r\n\r\nCC: @menshikh-iv ","created_at":"2018-10-11T14:30:22Z","updated_at":"2018-10-12T05:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34437eabbb3ad2f31d5011206af4bb02fd8a6c84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37/commits","review_comments_url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37/comments","review_comment_url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RaRe-Technologies/bounter/issues/37/comments","statuses_url":"https://api.github.com/repos/RaRe-Technologies/bounter/statuses/8405abc12edfdfd68803033e4f7a41ecf49b3964","head":{"label":"aneesh-joshi:master","ref":"master","sha":"8405abc12edfdfd68803033e4f7a41ecf49b3964","user":{"login":"aneesh-joshi","id":14147383,"node_id":"MDQ6VXNlcjE0MTQ3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14147383?v=4","gravatar_id":"","url":"https://api.github.com/users/aneesh-joshi","html_url":"https://github.com/aneesh-joshi","followers_url":"https://api.github.com/users/aneesh-joshi/followers","following_url":"https://api.github.com/users/aneesh-joshi/following{/other_user}","gists_url":"https://api.github.com/users/aneesh-joshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aneesh-joshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneesh-joshi/subscriptions","organizations_url":"https://api.github.com/users/aneesh-joshi/orgs","repos_url":"https://api.github.com/users/aneesh-joshi/repos","events_url":"https://api.github.com/users/aneesh-joshi/events{/privacy}","received_events_url":"https://api.github.com/users/aneesh-joshi/received_events","type":"User","site_admin":false},"repo":{"id":124127453,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMjc0NTM=","name":"bounter","full_name":"aneesh-joshi/bounter","private":false,"owner":{"login":"aneesh-joshi","id":14147383,"node_id":"MDQ6VXNlcjE0MTQ3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14147383?v=4","gravatar_id":"","url":"https://api.github.com/users/aneesh-joshi","html_url":"https://github.com/aneesh-joshi","followers_url":"https://api.github.com/users/aneesh-joshi/followers","following_url":"https://api.github.com/users/aneesh-joshi/following{/other_user}","gists_url":"https://api.github.com/users/aneesh-joshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aneesh-joshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneesh-joshi/subscriptions","organizations_url":"https://api.github.com/users/aneesh-joshi/orgs","repos_url":"https://api.github.com/users/aneesh-joshi/repos","events_url":"https://api.github.com/users/aneesh-joshi/events{/privacy}","received_events_url":"https://api.github.com/users/aneesh-joshi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aneesh-joshi/bounter","description":"Efficient Counter that uses a limited (bounded) amount of memory regardless of data size.","fork":true,"url":"https://api.github.com/repos/aneesh-joshi/bounter","forks_url":"https://api.github.com/repos/aneesh-joshi/bounter/forks","keys_url":"https://api.github.com/repos/aneesh-joshi/bounter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aneesh-joshi/bounter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aneesh-joshi/bounter/teams","hooks_url":"https://api.github.com/repos/aneesh-joshi/bounter/hooks","issue_events_url":"https://api.github.com/repos/aneesh-joshi/bounter/issues/events{/number}","events_url":"https://api.github.com/repos/aneesh-joshi/bounter/events","assignees_url":"https://api.github.com/repos/aneesh-joshi/bounter/assignees{/user}","branches_url":"https://api.github.com/repos/aneesh-joshi/bounter/branches{/branch}","tags_url":"https://api.github.com/repos/aneesh-joshi/bounter/tags","blobs_url":"https://api.github.com/repos/aneesh-joshi/bounter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aneesh-joshi/bounter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aneesh-joshi/bounter/git/refs{/sha}","trees_url":"https://api.github.com/repos/aneesh-joshi/bounter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aneesh-joshi/bounter/statuses/{sha}","languages_url":"https://api.github.com/repos/aneesh-joshi/bounter/languages","stargazers_url":"https://api.github.com/repos/aneesh-joshi/bounter/stargazers","contributors_url":"https://api.github.com/repos/aneesh-joshi/bounter/contributors","subscribers_url":"https://api.github.com/repos/aneesh-joshi/bounter/subscribers","subscription_url":"https://api.github.com/repos/aneesh-joshi/bounter/subscription","commits_url":"https://api.github.com/repos/aneesh-joshi/bounter/commits{/sha}","git_commits_url":"https://api.github.com/repos/aneesh-joshi/bounter/git/commits{/sha}","comments_url":"https://api.github.com/repos/aneesh-joshi/bounter/comments{/number}","issue_comment_url":"https://api.github.com/repos/aneesh-joshi/bounter/issues/comments{/number}","contents_url":"https://api.github.com/repos/aneesh-joshi/bounter/contents/{+path}","compare_url":"https://api.github.com/repos/aneesh-joshi/bounter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aneesh-joshi/bounter/merges","archive_url":"https://api.github.com/repos/aneesh-joshi/bounter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aneesh-joshi/bounter/downloads","issues_url":"https://api.github.com/repos/aneesh-joshi/bounter/issues{/number}","pulls_url":"https://api.github.com/repos/aneesh-joshi/bounter/pulls{/number}","milestones_url":"https://api.github.com/repos/aneesh-joshi/bounter/milestones{/number}","notifications_url":"https://api.github.com/repos/aneesh-joshi/bounter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aneesh-joshi/bounter/labels{/name}","releases_url":"https://api.github.com/repos/aneesh-joshi/bounter/releases{/id}","deployments_url":"https://api.github.com/repos/aneesh-joshi/bounter/deployments","created_at":"2018-03-06T19:23:50Z","updated_at":"2018-10-11T15:51:12Z","pushed_at":"2018-10-11T15:51:10Z","git_url":"git://github.com/aneesh-joshi/bounter.git","ssh_url":"git@github.com:aneesh-joshi/bounter.git","clone_url":"https://github.com/aneesh-joshi/bounter.git","svn_url":"https://github.com/aneesh-joshi/bounter","homepage":"","size":386,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RaRe-Technologies:master","ref":"master","sha":"1585aff2afb20dca5bb7115e119497a7c22f1d2b","user":{"login":"RaRe-Technologies","id":12515886,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTE1ODg2","avatar_url":"https://avatars3.githubusercontent.com/u/12515886?v=4","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":97567276,"node_id":"MDEwOlJlcG9zaXRvcnk5NzU2NzI3Ng==","name":"bounter","full_name":"RaRe-Technologies/bounter","private":false,"owner":{"login":"RaRe-Technologies","id":12515886,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTE1ODg2","avatar_url":"https://avatars3.githubusercontent.com/u/12515886?v=4","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RaRe-Technologies/bounter","description":"Efficient Counter that uses a limited (bounded) amount of memory regardless of data size.","fork":false,"url":"https://api.github.com/repos/RaRe-Technologies/bounter","forks_url":"https://api.github.com/repos/RaRe-Technologies/bounter/forks","keys_url":"https://api.github.com/repos/RaRe-Technologies/bounter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaRe-Technologies/bounter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaRe-Technologies/bounter/teams","hooks_url":"https://api.github.com/repos/RaRe-Technologies/bounter/hooks","issue_events_url":"https://api.github.com/repos/RaRe-Technologies/bounter/issues/events{/number}","events_url":"https://api.github.com/repos/RaRe-Technologies/bounter/events","assignees_url":"https://api.github.com/repos/RaRe-Technologies/bounter/assignees{/user}","branches_url":"https://api.github.com/repos/RaRe-Technologies/bounter/branches{/branch}","tags_url":"https://api.github.com/repos/RaRe-Technologies/bounter/tags","blobs_url":"https://api.github.com/repos/RaRe-Technologies/bounter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaRe-Technologies/bounter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaRe-Technologies/bounter/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaRe-Technologies/bounter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaRe-Technologies/bounter/statuses/{sha}","languages_url":"https://api.github.com/repos/RaRe-Technologies/bounter/languages","stargazers_url":"https://api.github.com/repos/RaRe-Technologies/bounter/stargazers","contributors_url":"https://api.github.com/repos/RaRe-Technologies/bounter/contributors","subscribers_url":"https://api.github.com/repos/RaRe-Technologies/bounter/subscribers","subscription_url":"https://api.github.com/repos/RaRe-Technologies/bounter/subscription","commits_url":"https://api.github.com/repos/RaRe-Technologies/bounter/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaRe-Technologies/bounter/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaRe-Technologies/bounter/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaRe-Technologies/bounter/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaRe-Technologies/bounter/contents/{+path}","compare_url":"https://api.github.com/repos/RaRe-Technologies/bounter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaRe-Technologies/bounter/merges","archive_url":"https://api.github.com/repos/RaRe-Technologies/bounter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaRe-Technologies/bounter/downloads","issues_url":"https://api.github.com/repos/RaRe-Technologies/bounter/issues{/number}","pulls_url":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls{/number}","milestones_url":"https://api.github.com/repos/RaRe-Technologies/bounter/milestones{/number}","notifications_url":"https://api.github.com/repos/RaRe-Technologies/bounter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaRe-Technologies/bounter/labels{/name}","releases_url":"https://api.github.com/repos/RaRe-Technologies/bounter/releases{/id}","deployments_url":"https://api.github.com/repos/RaRe-Technologies/bounter/deployments","created_at":"2017-07-18T07:24:15Z","updated_at":"2018-10-10T07:36:19Z","pushed_at":"2018-10-11T15:51:11Z","git_url":"git://github.com/RaRe-Technologies/bounter.git","ssh_url":"git@github.com:RaRe-Technologies/bounter.git","clone_url":"https://github.com/RaRe-Technologies/bounter.git","svn_url":"https://github.com/RaRe-Technologies/bounter","homepage":"","size":382,"stargazers_count":808,"watchers_count":808,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":42,"open_issues":14,"watchers":808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37"},"html":{"href":"https://github.com/RaRe-Technologies/bounter/pull/37"},"issue":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/issues/37"},"comments":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/RaRe-Technologies/bounter/statuses/8405abc12edfdfd68803033e4f7a41ecf49b3964"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"piskvorky"}}