{"action":"created","comment":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/192861322","pull_request_review_id":125719385,"id":192861322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjg2MTMyMg==","diff_hunk":"@@ -21,15 +21,10 @@\n         <version>3.2.2-SNAPSHOT</version>\n     </parent>\n \n-    <groupId>org.jdbi</groupId>\n     <artifactId>jdbi3-bom</artifactId>\n     <packaging>pom</packaging>\n     <name>jdbi3 BOM</name>\n-    <description>Jdbi is designed to provide convenient tabular data access in\n-        Java(tm). It uses the Java collections framework for query\n-        results, provides a convenient means of externalizing sql\n-        statements, and provides named parameter support for any database\n-        being used.</description>\n+    <description>Jdbi is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.</description>","path":"bom/pom.xml","position":13,"original_position":13,"commit_id":"bb162abafe7514d75b907ece29b8ef01c19ad34b","original_commit_id":"bb162abafe7514d75b907ece29b8ef01c19ad34b","user":{"login":"TheRealMarnes","id":3950300,"node_id":"MDQ6VXNlcjM5NTAzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"body":"I guess not, I just thought the source formatting would mess up formatting in displays elsewhere. Guess I should've asked first","created_at":"2018-06-04T19:55:45Z","updated_at":"2018-06-04T19:55:45Z","html_url":"https://github.com/jdbi/jdbi/pull/1162#discussion_r192861322","pull_request_url":"https://api.github.com/repos/jdbi/jdbi/pulls/1162","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/192861322"},"html":{"href":"https://github.com/jdbi/jdbi/pull/1162#discussion_r192861322"},"pull_request":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/1162"}},"in_reply_to_id":192860659},"pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/1162","id":192509963,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTA5OTYz","html_url":"https://github.com/jdbi/jdbi/pull/1162","diff_url":"https://github.com/jdbi/jdbi/pull/1162.diff","patch_url":"https://github.com/jdbi/jdbi/pull/1162.patch","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/1162","number":1162,"state":"open","locked":false,"title":"[housekeeping] pom checkup","user":{"login":"TheRealMarnes","id":3950300,"node_id":"MDQ6VXNlcjM5NTAzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"body":"I'm no maven expert, but I believe it's universally bad form to specify inline versions anywhere but the dependencyManagement section of the parent pom, or the properties section for child poms to refer to for plugin versions.\r\n\r\nAlso moved the checkstyle plugin to what I think is a more correct location and bound it explicitly, along with pmd and sortpom, to a proper lifecycle.\r\n\r\nLike I said though, not a maven pro. Have worked with the thing for over 6 years but some of it still confuses me.","created_at":"2018-06-04T19:50:44Z","updated_at":"2018-06-04T19:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f408c6f1d72c02ee6ae0e9e4163106913afdde6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jdbi/jdbi/pulls/1162/commits","review_comments_url":"https://api.github.com/repos/jdbi/jdbi/pulls/1162/comments","review_comment_url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/1162/comments","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/bb162abafe7514d75b907ece29b8ef01c19ad34b","head":{"label":"TheRealMarnes:cleanpom","ref":"cleanpom","sha":"bb162abafe7514d75b907ece29b8ef01c19ad34b","user":{"login":"TheRealMarnes","id":3950300,"node_id":"MDQ6VXNlcjM5NTAzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"repo":{"id":128832023,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MzIwMjM=","name":"jdbi","full_name":"TheRealMarnes/jdbi","owner":{"login":"TheRealMarnes","id":3950300,"node_id":"MDQ6VXNlcjM5NTAzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheRealMarnes/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":true,"url":"https://api.github.com/repos/TheRealMarnes/jdbi","forks_url":"https://api.github.com/repos/TheRealMarnes/jdbi/forks","keys_url":"https://api.github.com/repos/TheRealMarnes/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheRealMarnes/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheRealMarnes/jdbi/teams","hooks_url":"https://api.github.com/repos/TheRealMarnes/jdbi/hooks","issue_events_url":"https://api.github.com/repos/TheRealMarnes/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/TheRealMarnes/jdbi/events","assignees_url":"https://api.github.com/repos/TheRealMarnes/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/TheRealMarnes/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/TheRealMarnes/jdbi/tags","blobs_url":"https://api.github.com/repos/TheRealMarnes/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheRealMarnes/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheRealMarnes/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheRealMarnes/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheRealMarnes/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/TheRealMarnes/jdbi/languages","stargazers_url":"https://api.github.com/repos/TheRealMarnes/jdbi/stargazers","contributors_url":"https://api.github.com/repos/TheRealMarnes/jdbi/contributors","subscribers_url":"https://api.github.com/repos/TheRealMarnes/jdbi/subscribers","subscription_url":"https://api.github.com/repos/TheRealMarnes/jdbi/subscription","commits_url":"https://api.github.com/repos/TheRealMarnes/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheRealMarnes/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheRealMarnes/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheRealMarnes/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheRealMarnes/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/TheRealMarnes/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheRealMarnes/jdbi/merges","archive_url":"https://api.github.com/repos/TheRealMarnes/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheRealMarnes/jdbi/downloads","issues_url":"https://api.github.com/repos/TheRealMarnes/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/TheRealMarnes/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/TheRealMarnes/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/TheRealMarnes/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheRealMarnes/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/TheRealMarnes/jdbi/releases{/id}","deployments_url":"https://api.github.com/repos/TheRealMarnes/jdbi/deployments","created_at":"2018-04-09T20:49:02Z","updated_at":"2018-04-17T14:58:37Z","pushed_at":"2018-06-04T19:48:06Z","git_url":"git://github.com/TheRealMarnes/jdbi.git","ssh_url":"git@github.com:TheRealMarnes/jdbi.git","clone_url":"https://github.com/TheRealMarnes/jdbi.git","svn_url":"https://github.com/TheRealMarnes/jdbi","homepage":"http://jdbi.org/","size":17540,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdbi:master","ref":"master","sha":"ed37c024fe56b6bf309037b94997c4128a3e7428","user":{"login":"jdbi","id":9668860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2Njg4NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9668860?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"repo":{"id":229738,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk3Mzg=","name":"jdbi","full_name":"jdbi/jdbi","owner":{"login":"jdbi","id":9668860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2Njg4NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9668860?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jdbi/jdbi","description":"jdbi is designed to provide convenient tabular data access in Java; including templated SQL, parameterized and strongly typed queries, and Streams integration","fork":false,"url":"https://api.github.com/repos/jdbi/jdbi","forks_url":"https://api.github.com/repos/jdbi/jdbi/forks","keys_url":"https://api.github.com/repos/jdbi/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbi/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbi/jdbi/teams","hooks_url":"https://api.github.com/repos/jdbi/jdbi/hooks","issue_events_url":"https://api.github.com/repos/jdbi/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/jdbi/jdbi/events","assignees_url":"https://api.github.com/repos/jdbi/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/jdbi/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/jdbi/jdbi/tags","blobs_url":"https://api.github.com/repos/jdbi/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbi/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbi/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbi/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbi/jdbi/languages","stargazers_url":"https://api.github.com/repos/jdbi/jdbi/stargazers","contributors_url":"https://api.github.com/repos/jdbi/jdbi/contributors","subscribers_url":"https://api.github.com/repos/jdbi/jdbi/subscribers","subscription_url":"https://api.github.com/repos/jdbi/jdbi/subscription","commits_url":"https://api.github.com/repos/jdbi/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbi/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbi/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbi/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdbi/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/jdbi/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbi/jdbi/merges","archive_url":"https://api.github.com/repos/jdbi/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbi/jdbi/downloads","issues_url":"https://api.github.com/repos/jdbi/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/jdbi/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbi/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbi/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbi/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/jdbi/jdbi/releases{/id}","deployments_url":"https://api.github.com/repos/jdbi/jdbi/deployments","created_at":"2009-06-17T16:36:36Z","updated_at":"2018-06-04T17:11:38Z","pushed_at":"2018-06-04T19:50:45Z","git_url":"git://github.com/jdbi/jdbi.git","ssh_url":"git@github.com:jdbi/jdbi.git","clone_url":"https://github.com/jdbi/jdbi.git","svn_url":"https://github.com/jdbi/jdbi","homepage":"http://jdbi.org/","size":17615,"stargazers_count":1019,"watchers_count":1019,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":209,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":209,"open_issues":73,"watchers":1019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/1162"},"html":{"href":"https://github.com/jdbi/jdbi/pull/1162"},"issue":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/1162"},"comments":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/1162/comments"},"review_comments":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/1162/comments"},"review_comment":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/1162/commits"},"statuses":{"href":"https://api.github.com/repos/jdbi/jdbi/statuses/bb162abafe7514d75b907ece29b8ef01c19ad34b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TheRealMarnes"}}