{"action":"created","comment":{"url":"https://api.github.com/repos/hhexiy/cocoa/pulls/comments/183222948","pull_request_review_id":114186934,"id":183222948,"diff_hunk":"@@ -216,18 +216,18 @@ def _add_utterance(self, agent, utterance, lf=None):\n         else:\n             lf = []\n \n-        if not new_turn:\n-            self.token_turns[-1].extend(utterance)\n-            self.lfs[-1].extend(lf)\n-            self.entities[-1].extend(entities)\n-        else:\n+        if new_turn:","path":"negotiation/neural/preprocess.py","position":18,"original_position":18,"commit_id":"f95076a6ad3a1dd5b49aebe6e6a07696efa64e01","original_commit_id":"f95076a6ad3a1dd5b49aebe6e6a07696efa64e01","user":{"login":"hhexiy","id":1202342,"avatar_url":"https://avatars0.githubusercontent.com/u/1202342?v=4","gravatar_id":"","url":"https://api.github.com/users/hhexiy","html_url":"https://github.com/hhexiy","followers_url":"https://api.github.com/users/hhexiy/followers","following_url":"https://api.github.com/users/hhexiy/following{/other_user}","gists_url":"https://api.github.com/users/hhexiy/gists{/gist_id}","starred_url":"https://api.github.com/users/hhexiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhexiy/subscriptions","organizations_url":"https://api.github.com/users/hhexiy/orgs","repos_url":"https://api.github.com/users/hhexiy/repos","events_url":"https://api.github.com/users/hhexiy/events{/privacy}","received_events_url":"https://api.github.com/users/hhexiy/received_events","type":"User","site_admin":false},"body":"why did you remove the if not new_turn part?","created_at":"2018-04-22T01:02:26Z","updated_at":"2018-04-22T01:02:26Z","html_url":"https://github.com/hhexiy/cocoa/pull/9#discussion_r183222948","pull_request_url":"https://api.github.com/repos/hhexiy/cocoa/pulls/9","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hhexiy/cocoa/pulls/comments/183222948"},"html":{"href":"https://github.com/hhexiy/cocoa/pull/9#discussion_r183222948"},"pull_request":{"href":"https://api.github.com/repos/hhexiy/cocoa/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/hhexiy/cocoa/pulls/9","id":183202317,"html_url":"https://github.com/hhexiy/cocoa/pull/9","diff_url":"https://github.com/hhexiy/cocoa/pull/9.diff","patch_url":"https://github.com/hhexiy/cocoa/pull/9.patch","issue_url":"https://api.github.com/repos/hhexiy/cocoa/issues/9","number":9,"state":"open","locked":false,"title":"Summarization ability","user":{"login":"derekchen14","id":1191042,"avatar_url":"https://avatars2.githubusercontent.com/u/1191042?v=4","gravatar_id":"","url":"https://api.github.com/users/derekchen14","html_url":"https://github.com/derekchen14","followers_url":"https://api.github.com/users/derekchen14/followers","following_url":"https://api.github.com/users/derekchen14/following{/other_user}","gists_url":"https://api.github.com/users/derekchen14/gists{/gist_id}","starred_url":"https://api.github.com/users/derekchen14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekchen14/subscriptions","organizations_url":"https://api.github.com/users/derekchen14/orgs","repos_url":"https://api.github.com/users/derekchen14/repos","events_url":"https://api.github.com/users/derekchen14/events{/privacy}","received_events_url":"https://api.github.com/users/derekchen14/received_events","type":"User","site_admin":false},"body":"Not quite ready to merge yet, but making PR so we can easily review","created_at":"2018-04-21T02:59:17Z","updated_at":"2018-04-22T01:02:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37f5d362c8a9f6516df6c676b8c0b8fc5f62424e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hhexiy/cocoa/pulls/9/commits","review_comments_url":"https://api.github.com/repos/hhexiy/cocoa/pulls/9/comments","review_comment_url":"https://api.github.com/repos/hhexiy/cocoa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhexiy/cocoa/issues/9/comments","statuses_url":"https://api.github.com/repos/hhexiy/cocoa/statuses/f95076a6ad3a1dd5b49aebe6e6a07696efa64e01","head":{"label":"hhexiy:summary","ref":"summary","sha":"f95076a6ad3a1dd5b49aebe6e6a07696efa64e01","user":{"login":"hhexiy","id":1202342,"avatar_url":"https://avatars0.githubusercontent.com/u/1202342?v=4","gravatar_id":"","url":"https://api.github.com/users/hhexiy","html_url":"https://github.com/hhexiy","followers_url":"https://api.github.com/users/hhexiy/followers","following_url":"https://api.github.com/users/hhexiy/following{/other_user}","gists_url":"https://api.github.com/users/hhexiy/gists{/gist_id}","starred_url":"https://api.github.com/users/hhexiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhexiy/subscriptions","organizations_url":"https://api.github.com/users/hhexiy/orgs","repos_url":"https://api.github.com/users/hhexiy/repos","events_url":"https://api.github.com/users/hhexiy/events{/privacy}","received_events_url":"https://api.github.com/users/hhexiy/received_events","type":"User","site_admin":false},"repo":{"id":89890950,"name":"cocoa","full_name":"hhexiy/cocoa","owner":{"login":"hhexiy","id":1202342,"avatar_url":"https://avatars0.githubusercontent.com/u/1202342?v=4","gravatar_id":"","url":"https://api.github.com/users/hhexiy","html_url":"https://github.com/hhexiy","followers_url":"https://api.github.com/users/hhexiy/followers","following_url":"https://api.github.com/users/hhexiy/following{/other_user}","gists_url":"https://api.github.com/users/hhexiy/gists{/gist_id}","starred_url":"https://api.github.com/users/hhexiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhexiy/subscriptions","organizations_url":"https://api.github.com/users/hhexiy/orgs","repos_url":"https://api.github.com/users/hhexiy/repos","events_url":"https://api.github.com/users/hhexiy/events{/privacy}","received_events_url":"https://api.github.com/users/hhexiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhexiy/cocoa","description":"Framework for learning dialogue agents in a two-player game setting.","fork":true,"url":"https://api.github.com/repos/hhexiy/cocoa","forks_url":"https://api.github.com/repos/hhexiy/cocoa/forks","keys_url":"https://api.github.com/repos/hhexiy/cocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhexiy/cocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhexiy/cocoa/teams","hooks_url":"https://api.github.com/repos/hhexiy/cocoa/hooks","issue_events_url":"https://api.github.com/repos/hhexiy/cocoa/issues/events{/number}","events_url":"https://api.github.com/repos/hhexiy/cocoa/events","assignees_url":"https://api.github.com/repos/hhexiy/cocoa/assignees{/user}","branches_url":"https://api.github.com/repos/hhexiy/cocoa/branches{/branch}","tags_url":"https://api.github.com/repos/hhexiy/cocoa/tags","blobs_url":"https://api.github.com/repos/hhexiy/cocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhexiy/cocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhexiy/cocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhexiy/cocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhexiy/cocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/hhexiy/cocoa/languages","stargazers_url":"https://api.github.com/repos/hhexiy/cocoa/stargazers","contributors_url":"https://api.github.com/repos/hhexiy/cocoa/contributors","subscribers_url":"https://api.github.com/repos/hhexiy/cocoa/subscribers","subscription_url":"https://api.github.com/repos/hhexiy/cocoa/subscription","commits_url":"https://api.github.com/repos/hhexiy/cocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhexiy/cocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhexiy/cocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhexiy/cocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhexiy/cocoa/contents/{+path}","compare_url":"https://api.github.com/repos/hhexiy/cocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhexiy/cocoa/merges","archive_url":"https://api.github.com/repos/hhexiy/cocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhexiy/cocoa/downloads","issues_url":"https://api.github.com/repos/hhexiy/cocoa/issues{/number}","pulls_url":"https://api.github.com/repos/hhexiy/cocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/hhexiy/cocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/hhexiy/cocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhexiy/cocoa/labels{/name}","releases_url":"https://api.github.com/repos/hhexiy/cocoa/releases{/id}","deployments_url":"https://api.github.com/repos/hhexiy/cocoa/deployments","created_at":"2017-05-01T02:15:21Z","updated_at":"2017-05-01T02:15:23Z","pushed_at":"2018-04-21T18:23:34Z","git_url":"git://github.com/hhexiy/cocoa.git","ssh_url":"git@github.com:hhexiy/cocoa.git","clone_url":"https://github.com/hhexiy/cocoa.git","svn_url":"https://github.com/hhexiy/cocoa","homepage":"","size":10507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hhexiy:reinforce","ref":"reinforce","sha":"3d715663eb62d557abcc642781a14caaadff4399","user":{"login":"hhexiy","id":1202342,"avatar_url":"https://avatars0.githubusercontent.com/u/1202342?v=4","gravatar_id":"","url":"https://api.github.com/users/hhexiy","html_url":"https://github.com/hhexiy","followers_url":"https://api.github.com/users/hhexiy/followers","following_url":"https://api.github.com/users/hhexiy/following{/other_user}","gists_url":"https://api.github.com/users/hhexiy/gists{/gist_id}","starred_url":"https://api.github.com/users/hhexiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhexiy/subscriptions","organizations_url":"https://api.github.com/users/hhexiy/orgs","repos_url":"https://api.github.com/users/hhexiy/repos","events_url":"https://api.github.com/users/hhexiy/events{/privacy}","received_events_url":"https://api.github.com/users/hhexiy/received_events","type":"User","site_admin":false},"repo":{"id":89890950,"name":"cocoa","full_name":"hhexiy/cocoa","owner":{"login":"hhexiy","id":1202342,"avatar_url":"https://avatars0.githubusercontent.com/u/1202342?v=4","gravatar_id":"","url":"https://api.github.com/users/hhexiy","html_url":"https://github.com/hhexiy","followers_url":"https://api.github.com/users/hhexiy/followers","following_url":"https://api.github.com/users/hhexiy/following{/other_user}","gists_url":"https://api.github.com/users/hhexiy/gists{/gist_id}","starred_url":"https://api.github.com/users/hhexiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhexiy/subscriptions","organizations_url":"https://api.github.com/users/hhexiy/orgs","repos_url":"https://api.github.com/users/hhexiy/repos","events_url":"https://api.github.com/users/hhexiy/events{/privacy}","received_events_url":"https://api.github.com/users/hhexiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhexiy/cocoa","description":"Framework for learning dialogue agents in a two-player game setting.","fork":true,"url":"https://api.github.com/repos/hhexiy/cocoa","forks_url":"https://api.github.com/repos/hhexiy/cocoa/forks","keys_url":"https://api.github.com/repos/hhexiy/cocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhexiy/cocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhexiy/cocoa/teams","hooks_url":"https://api.github.com/repos/hhexiy/cocoa/hooks","issue_events_url":"https://api.github.com/repos/hhexiy/cocoa/issues/events{/number}","events_url":"https://api.github.com/repos/hhexiy/cocoa/events","assignees_url":"https://api.github.com/repos/hhexiy/cocoa/assignees{/user}","branches_url":"https://api.github.com/repos/hhexiy/cocoa/branches{/branch}","tags_url":"https://api.github.com/repos/hhexiy/cocoa/tags","blobs_url":"https://api.github.com/repos/hhexiy/cocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhexiy/cocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhexiy/cocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhexiy/cocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhexiy/cocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/hhexiy/cocoa/languages","stargazers_url":"https://api.github.com/repos/hhexiy/cocoa/stargazers","contributors_url":"https://api.github.com/repos/hhexiy/cocoa/contributors","subscribers_url":"https://api.github.com/repos/hhexiy/cocoa/subscribers","subscription_url":"https://api.github.com/repos/hhexiy/cocoa/subscription","commits_url":"https://api.github.com/repos/hhexiy/cocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhexiy/cocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhexiy/cocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhexiy/cocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhexiy/cocoa/contents/{+path}","compare_url":"https://api.github.com/repos/hhexiy/cocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhexiy/cocoa/merges","archive_url":"https://api.github.com/repos/hhexiy/cocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhexiy/cocoa/downloads","issues_url":"https://api.github.com/repos/hhexiy/cocoa/issues{/number}","pulls_url":"https://api.github.com/repos/hhexiy/cocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/hhexiy/cocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/hhexiy/cocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhexiy/cocoa/labels{/name}","releases_url":"https://api.github.com/repos/hhexiy/cocoa/releases{/id}","deployments_url":"https://api.github.com/repos/hhexiy/cocoa/deployments","created_at":"2017-05-01T02:15:21Z","updated_at":"2017-05-01T02:15:23Z","pushed_at":"2018-04-21T18:23:34Z","git_url":"git://github.com/hhexiy/cocoa.git","ssh_url":"git@github.com:hhexiy/cocoa.git","clone_url":"https://github.com/hhexiy/cocoa.git","svn_url":"https://github.com/hhexiy/cocoa","homepage":"","size":10507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhexiy/cocoa/pulls/9"},"html":{"href":"https://github.com/hhexiy/cocoa/pull/9"},"issue":{"href":"https://api.github.com/repos/hhexiy/cocoa/issues/9"},"comments":{"href":"https://api.github.com/repos/hhexiy/cocoa/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/hhexiy/cocoa/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/hhexiy/cocoa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhexiy/cocoa/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/hhexiy/cocoa/statuses/f95076a6ad3a1dd5b49aebe6e6a07696efa64e01"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hhexiy"}}