{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/26678","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/26678/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/26678/comments","events_url":"https://api.github.com/repos/golang/go/issues/26678/events","html_url":"https://github.com/golang/go/issues/26678","id":345556347,"node_id":"MDU6SXNzdWUzNDU1NTYzNDc=","number":26678,"title":"x/sys/unix: TestGetwd is improperly written","user":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/22","html_url":"https://github.com/golang/go/milestone/22","labels_url":"https://api.github.com/repos/golang/go/milestones/22/labels","id":1067491,"node_id":"MDk6TWlsZXN0b25lMTA2NzQ5MQ==","number":22,"title":"Unreleased","description":"Issues that do not affect released Go code and binaries.\r\n","creator":{"login":"rsc","id":104030,"node_id":"MDQ6VXNlcjEwNDAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":903,"closed_issues":1515,"state":"open","created_at":"2015-04-14T18:48:22Z","updated_at":"2018-07-29T20:52:16Z","due_on":"2099-12-31T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-07-29T19:32:44Z","updated_at":"2018-07-30T00:49:39Z","closed_at":null,"author_association":"NONE","body":"Please answer these questions before submitting your issue. Thanks!\r\n\r\n\r\n### What version of Go are you using (`go version`)?\r\n\r\n1.11beta2\r\n\r\n### Does this issue reproduce with the latest release?\r\n\r\nunsure\r\n\r\n### What operating system and processor architecture are you using (`go env`)?\r\n\r\nfreebsd/amd64\r\n\r\n### What did you do?\r\n\r\nran `bash all.bash` in the src sub-directory (building from the git repo)\r\n\r\n### What did you expect to see?\r\n\r\nall tests succeeded\r\n\r\n### What did you see instead?\r\n\r\n```\r\n--- FAIL: TestGetwd (0.00s)\r\n    syscall_unix_test.go:493: Getwd returned \"/data/usr/bin\" want \"/usr/bin\"\r\nFAIL\r\nFAIL    cmd/vendor/golang.org/x/sys/unix        0.372s\r\n```\r\n\r\nExtra information: on my machine `/usr` is a symlink to `/data/usr`. This is pretty common on unix systems with multiple filesystems. The test should not be sensitive to this."},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/408718637","html_url":"https://github.com/golang/go/issues/26678#issuecomment-408718637","issue_url":"https://api.github.com/repos/golang/go/issues/26678","id":408718637,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODcxODYzNw==","user":{"login":"robpike","id":4324516,"node_id":"MDQ6VXNlcjQzMjQ1MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4324516?v=4","gravatar_id":"","url":"https://api.github.com/users/robpike","html_url":"https://github.com/robpike","followers_url":"https://api.github.com/users/robpike/followers","following_url":"https://api.github.com/users/robpike/following{/other_user}","gists_url":"https://api.github.com/users/robpike/gists{/gist_id}","starred_url":"https://api.github.com/users/robpike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robpike/subscriptions","organizations_url":"https://api.github.com/users/robpike/orgs","repos_url":"https://api.github.com/users/robpike/repos","events_url":"https://api.github.com/users/robpike/events{/privacy}","received_events_url":"https://api.github.com/users/robpike/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T00:49:39Z","updated_at":"2018-07-30T00:49:39Z","author_association":"CONTRIBUTOR","body":"Of course one can do that, but that depends on mkdir working, which if you think about it is a far higher bar than checking whether getwd is working. It's like proving the circle's circumference is 2πr using calculus.\r\n\r\nAnd the proposed test only tests that it is consistent, not that it is correct. That's a lot of work for almost no information.\r\n\r\nI'm not saying you're wrong, just that it's not a very good test. It may be hard to do better."}}
{"actor":{"display_login":"robpike"}}