{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/192752766","pull_request_review_id":125588059,"id":192752766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc1Mjc2Ng==","diff_hunk":"@@ -181,11 +182,13 @@ std::string SeedingLayerSetsBuilder::LayerSpec::print(const std::vector<std::str\n SeedingLayerSetsBuilder::SeedingLayerSetsBuilder(const edm::ParameterSet & cfg, edm::ConsumesCollector&& iC):\n   SeedingLayerSetsBuilder(cfg, iC)\n {}\n-SeedingLayerSetsBuilder::SeedingLayerSetsBuilder(const edm::ParameterSet & cfg, edm::ConsumesCollector& iC)\n+SeedingLayerSetsBuilder::SeedingLayerSetsBuilder(const edm::ParameterSet & cfg, edm::ConsumesCollector& iC):\n+  isFastSim(cfg.getParameter<bool>(\"isFastSim\"))","path":"RecoTracker/TkSeedingLayers/src/SeedingLayerSetsBuilder.cc","position":null,"original_position":19,"commit_id":"fbbd5a76cb59b920aefce85c361f42ff16b53e9c","original_commit_id":"1b9eea2212f6b52e5e9a91dad7a6cb16859a44d4","user":{"login":"makortel","id":33993,"node_id":"MDQ6VXNlcjMzOTkz","avatar_url":"https://avatars3.githubusercontent.com/u/33993?v=4","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"body":"Yes (although now I think maybe passing the collection name would be more clean and in line with what the `SeedingLayerSetsBuilder` does in standard reco). Note that you can call this constructor first to do it's job, so it should be something along\r\n```cpp\r\nSeedingLayerSetsBuilder::SeedingLayerSetsBuilder(const edm::ParameterSet & cfg, edm::ConsumesCollector& iC, const edm::InputTag& fastsimHitTag):\r\n  SeedingLayerSetsBuilder(cfg, iC),\r\n   fastSimrecHitsToken_(iC.consumes<FastTrackerRecHitCollection>(fastSimHitTag))\r\n{}\r\n```","created_at":"2018-06-04T14:07:23Z","updated_at":"2018-06-04T14:07:23Z","html_url":"https://github.com/cms-sw/cmssw/pull/23363#discussion_r192752766","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/192752766"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23363#discussion_r192752766"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363"}},"in_reply_to_id":191323133},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363","id":191047932,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDQ3OTMy","html_url":"https://github.com/cms-sw/cmssw/pull/23363","diff_url":"https://github.com/cms-sw/cmssw/pull/23363.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23363.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23363","number":23363,"state":"open","locked":false,"title":"Phase1 in FastSim of CMS","user":{"login":"angirar","id":19993232,"node_id":"MDQ6VXNlcjE5OTkzMjMy","avatar_url":"https://avatars3.githubusercontent.com/u/19993232?v=4","gravatar_id":"","url":"https://api.github.com/users/angirar","html_url":"https://github.com/angirar","followers_url":"https://api.github.com/users/angirar/followers","following_url":"https://api.github.com/users/angirar/following{/other_user}","gists_url":"https://api.github.com/users/angirar/gists{/gist_id}","starred_url":"https://api.github.com/users/angirar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angirar/subscriptions","organizations_url":"https://api.github.com/users/angirar/orgs","repos_url":"https://api.github.com/users/angirar/repos","events_url":"https://api.github.com/users/angirar/events{/privacy}","received_events_url":"https://api.github.com/users/angirar/received_events","type":"User","site_admin":false},"body":"New configurable tracker geometry for Phase0 and Phase1. Configurable track reconstruction sequence with new iterations added for Phase1. Iteration specific CA seeding (quadruplets and triplets) also in place.","created_at":"2018-05-29T06:53:07Z","updated_at":"2018-06-04T14:07:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f1afe5f0294a2db2aa2adfc2680469a8766be24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881628,"node_id":"MDU6TGFiZWw1Mjg4MTYyOA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04","default":false},{"id":52881747,"node_id":"MDU6TGFiZWw1Mjg4MTc0Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"node_id":"MDk6TWlsZXN0b25lMzIyNzYzMQ==","number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":474,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-06-04T14:05:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23363/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/fbbd5a76cb59b920aefce85c361f42ff16b53e9c","head":{"label":"angirar:Phase1-Fastsim-CMS","ref":"Phase1-Fastsim-CMS","sha":"fbbd5a76cb59b920aefce85c361f42ff16b53e9c","user":{"login":"angirar","id":19993232,"node_id":"MDQ6VXNlcjE5OTkzMjMy","avatar_url":"https://avatars3.githubusercontent.com/u/19993232?v=4","gravatar_id":"","url":"https://api.github.com/users/angirar","html_url":"https://github.com/angirar","followers_url":"https://api.github.com/users/angirar/followers","following_url":"https://api.github.com/users/angirar/following{/other_user}","gists_url":"https://api.github.com/users/angirar/gists{/gist_id}","starred_url":"https://api.github.com/users/angirar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angirar/subscriptions","organizations_url":"https://api.github.com/users/angirar/orgs","repos_url":"https://api.github.com/users/angirar/repos","events_url":"https://api.github.com/users/angirar/events{/privacy}","received_events_url":"https://api.github.com/users/angirar/received_events","type":"User","site_admin":false},"repo":{"id":73173116,"node_id":"MDEwOlJlcG9zaXRvcnk3MzE3MzExNg==","name":"cmssw","full_name":"angirar/cmssw","owner":{"login":"angirar","id":19993232,"node_id":"MDQ6VXNlcjE5OTkzMjMy","avatar_url":"https://avatars3.githubusercontent.com/u/19993232?v=4","gravatar_id":"","url":"https://api.github.com/users/angirar","html_url":"https://github.com/angirar","followers_url":"https://api.github.com/users/angirar/followers","following_url":"https://api.github.com/users/angirar/following{/other_user}","gists_url":"https://api.github.com/users/angirar/gists{/gist_id}","starred_url":"https://api.github.com/users/angirar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angirar/subscriptions","organizations_url":"https://api.github.com/users/angirar/orgs","repos_url":"https://api.github.com/users/angirar/repos","events_url":"https://api.github.com/users/angirar/events{/privacy}","received_events_url":"https://api.github.com/users/angirar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angirar/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/angirar/cmssw","forks_url":"https://api.github.com/repos/angirar/cmssw/forks","keys_url":"https://api.github.com/repos/angirar/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angirar/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angirar/cmssw/teams","hooks_url":"https://api.github.com/repos/angirar/cmssw/hooks","issue_events_url":"https://api.github.com/repos/angirar/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/angirar/cmssw/events","assignees_url":"https://api.github.com/repos/angirar/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/angirar/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/angirar/cmssw/tags","blobs_url":"https://api.github.com/repos/angirar/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angirar/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angirar/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/angirar/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angirar/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/angirar/cmssw/languages","stargazers_url":"https://api.github.com/repos/angirar/cmssw/stargazers","contributors_url":"https://api.github.com/repos/angirar/cmssw/contributors","subscribers_url":"https://api.github.com/repos/angirar/cmssw/subscribers","subscription_url":"https://api.github.com/repos/angirar/cmssw/subscription","commits_url":"https://api.github.com/repos/angirar/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/angirar/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/angirar/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/angirar/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/angirar/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/angirar/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angirar/cmssw/merges","archive_url":"https://api.github.com/repos/angirar/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angirar/cmssw/downloads","issues_url":"https://api.github.com/repos/angirar/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/angirar/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/angirar/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/angirar/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angirar/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/angirar/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/angirar/cmssw/deployments","created_at":"2016-11-08T10:03:24Z","updated_at":"2018-05-25T07:10:18Z","pushed_at":"2018-06-04T11:15:20Z","git_url":"git://github.com/angirar/cmssw.git","ssh_url":"git@github.com:angirar/cmssw.git","clone_url":"https://github.com/angirar/cmssw.git","svn_url":"https://github.com/angirar/cmssw","homepage":"http://cms-sw.github.io/","size":1000619,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"1956a72e32255430afe29872b553d79f69510ac9","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-06-04T12:39:42Z","pushed_at":"2018-06-04T14:04:57Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1003604,"stargazers_count":554,"watchers_count":554,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2583,"mirror_url":null,"archived":false,"open_issues_count":464,"license":null,"forks":2583,"open_issues":464,"watchers":554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23363"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23363"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23363/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23363/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/fbbd5a76cb59b920aefce85c361f42ff16b53e9c"}},"author_association":"NONE"}}
{"actor":{"display_login":"makortel"}}