{"action":"created","comment":{"url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/comments/215026597","pull_request_review_id":152203036,"id":215026597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTAyNjU5Nw==","diff_hunk":"@@ -12,7 +12,10 @@ var insertionQ = (function () {\n             strictlyNew: true,\n             timeout: 20\n         };\n-\n+    \n+    if( options.timeout > 0 ) {","path":"insQ.js","position":6,"original_position":6,"commit_id":"f82c9c8222bbd58f811d31f83f1e29dc2d479117","original_commit_id":"8786c4995469b91fafba017d3feb63cd2127e01a","user":{"login":"skrauselevy","id":22512246,"node_id":"MDQ6VXNlcjIyNTEyMjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22512246?v=4","gravatar_id":"","url":"https://api.github.com/users/skrauselevy","html_url":"https://github.com/skrauselevy","followers_url":"https://api.github.com/users/skrauselevy/followers","following_url":"https://api.github.com/users/skrauselevy/following{/other_user}","gists_url":"https://api.github.com/users/skrauselevy/gists{/gist_id}","starred_url":"https://api.github.com/users/skrauselevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrauselevy/subscriptions","organizations_url":"https://api.github.com/users/skrauselevy/orgs","repos_url":"https://api.github.com/users/skrauselevy/repos","events_url":"https://api.github.com/users/skrauselevy/events{/privacy}","received_events_url":"https://api.github.com/users/skrauselevy/received_events","type":"User","site_admin":false},"body":"I think you can just make this `const isTimeoutRequired = (options.timeout > 0 )`","created_at":"2018-09-04T18:47:31Z","updated_at":"2018-09-04T18:48:40Z","html_url":"https://github.com/DataSenseAnalytics/insertionQuery/pull/1#discussion_r215026597","pull_request_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/comments/215026597"},"html":{"href":"https://github.com/DataSenseAnalytics/insertionQuery/pull/1#discussion_r215026597"},"pull_request":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1","id":213065306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDY1MzA2","html_url":"https://github.com/DataSenseAnalytics/insertionQuery/pull/1","diff_url":"https://github.com/DataSenseAnalytics/insertionQuery/pull/1.diff","patch_url":"https://github.com/DataSenseAnalytics/insertionQuery/pull/1.patch","issue_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/1","number":1,"state":"open","locked":false,"title":"#3996 joyride race condition fix","user":{"login":"ethsu1","id":32501441,"node_id":"MDQ6VXNlcjMyNTAxNDQx","avatar_url":"https://avatars2.githubusercontent.com/u/32501441?v=4","gravatar_id":"","url":"https://api.github.com/users/ethsu1","html_url":"https://github.com/ethsu1","followers_url":"https://api.github.com/users/ethsu1/followers","following_url":"https://api.github.com/users/ethsu1/following{/other_user}","gists_url":"https://api.github.com/users/ethsu1/gists{/gist_id}","starred_url":"https://api.github.com/users/ethsu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethsu1/subscriptions","organizations_url":"https://api.github.com/users/ethsu1/orgs","repos_url":"https://api.github.com/users/ethsu1/repos","events_url":"https://api.github.com/users/ethsu1/events{/privacy}","received_events_url":"https://api.github.com/users/ethsu1/received_events","type":"User","site_admin":false},"body":"fixes #3396\r\n\r\njoyride will no longer stall because we register the event listener right after the animation is attached. The original issue is with the setTimeout, even if we configure the timeout to 0, if the user clicks the next button at the right time, the engine is busy right after the animation is attached but before the event listener is registered, so then our callback to will not move onto the next step in the joyride because the event listener missed when the animation was attached. By removing the setTimeout, the event listener is immediately registered.","created_at":"2018-09-04T18:30:40Z","updated_at":"2018-09-04T18:48:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49155d2fe881871889aa4b5aacb79877cdb40c7f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AliTajeldin","id":2496103,"node_id":"MDQ6VXNlcjI0OTYxMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2496103?v=4","gravatar_id":"","url":"https://api.github.com/users/AliTajeldin","html_url":"https://github.com/AliTajeldin","followers_url":"https://api.github.com/users/AliTajeldin/followers","following_url":"https://api.github.com/users/AliTajeldin/following{/other_user}","gists_url":"https://api.github.com/users/AliTajeldin/gists{/gist_id}","starred_url":"https://api.github.com/users/AliTajeldin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliTajeldin/subscriptions","organizations_url":"https://api.github.com/users/AliTajeldin/orgs","repos_url":"https://api.github.com/users/AliTajeldin/repos","events_url":"https://api.github.com/users/AliTajeldin/events{/privacy}","received_events_url":"https://api.github.com/users/AliTajeldin/received_events","type":"User","site_admin":false},{"login":"cloudysail","id":25990322,"node_id":"MDQ6VXNlcjI1OTkwMzIy","avatar_url":"https://avatars2.githubusercontent.com/u/25990322?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudysail","html_url":"https://github.com/cloudysail","followers_url":"https://api.github.com/users/cloudysail/followers","following_url":"https://api.github.com/users/cloudysail/following{/other_user}","gists_url":"https://api.github.com/users/cloudysail/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudysail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudysail/subscriptions","organizations_url":"https://api.github.com/users/cloudysail/orgs","repos_url":"https://api.github.com/users/cloudysail/repos","events_url":"https://api.github.com/users/cloudysail/events{/privacy}","received_events_url":"https://api.github.com/users/cloudysail/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1/commits","review_comments_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1/comments","review_comment_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/1/comments","statuses_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/statuses/f82c9c8222bbd58f811d31f83f1e29dc2d479117","head":{"label":"DataSenseAnalytics:i3996-joyride-fix","ref":"i3996-joyride-fix","sha":"f82c9c8222bbd58f811d31f83f1e29dc2d479117","user":{"login":"DataSenseAnalytics","id":17791895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzkxODk1","avatar_url":"https://avatars3.githubusercontent.com/u/17791895?v=4","gravatar_id":"","url":"https://api.github.com/users/DataSenseAnalytics","html_url":"https://github.com/DataSenseAnalytics","followers_url":"https://api.github.com/users/DataSenseAnalytics/followers","following_url":"https://api.github.com/users/DataSenseAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/DataSenseAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/DataSenseAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataSenseAnalytics/subscriptions","organizations_url":"https://api.github.com/users/DataSenseAnalytics/orgs","repos_url":"https://api.github.com/users/DataSenseAnalytics/repos","events_url":"https://api.github.com/users/DataSenseAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/DataSenseAnalytics/received_events","type":"Organization","site_admin":false},"repo":{"id":146955662,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NTU2NjI=","name":"insertionQuery","full_name":"DataSenseAnalytics/insertionQuery","owner":{"login":"DataSenseAnalytics","id":17791895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzkxODk1","avatar_url":"https://avatars3.githubusercontent.com/u/17791895?v=4","gravatar_id":"","url":"https://api.github.com/users/DataSenseAnalytics","html_url":"https://github.com/DataSenseAnalytics","followers_url":"https://api.github.com/users/DataSenseAnalytics/followers","following_url":"https://api.github.com/users/DataSenseAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/DataSenseAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/DataSenseAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataSenseAnalytics/subscriptions","organizations_url":"https://api.github.com/users/DataSenseAnalytics/orgs","repos_url":"https://api.github.com/users/DataSenseAnalytics/repos","events_url":"https://api.github.com/users/DataSenseAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/DataSenseAnalytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataSenseAnalytics/insertionQuery","description":"Non-dom-event way to catch nodes showing up. And it uses selectors.","fork":true,"url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery","forks_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/forks","keys_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/teams","hooks_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/hooks","issue_events_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/events{/number}","events_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/events","assignees_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/assignees{/user}","branches_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/branches{/branch}","tags_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/tags","blobs_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/statuses/{sha}","languages_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/languages","stargazers_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/stargazers","contributors_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/contributors","subscribers_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/subscribers","subscription_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/subscription","commits_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/contents/{+path}","compare_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/merges","archive_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/downloads","issues_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues{/number}","pulls_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls{/number}","milestones_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/milestones{/number}","notifications_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/labels{/name}","releases_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/releases{/id}","deployments_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/deployments","created_at":"2018-09-01T00:57:26Z","updated_at":"2018-09-01T00:57:28Z","pushed_at":"2018-09-04T18:47:24Z","git_url":"git://github.com/DataSenseAnalytics/insertionQuery.git","ssh_url":"git@github.com:DataSenseAnalytics/insertionQuery.git","clone_url":"https://github.com/DataSenseAnalytics/insertionQuery.git","svn_url":"https://github.com/DataSenseAnalytics/insertionQuery","homepage":"","size":46,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"DataSenseAnalytics:master","ref":"master","sha":"0f5ba052d463d3abe1f919a75d9ef8de80b6a2fa","user":{"login":"DataSenseAnalytics","id":17791895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzkxODk1","avatar_url":"https://avatars3.githubusercontent.com/u/17791895?v=4","gravatar_id":"","url":"https://api.github.com/users/DataSenseAnalytics","html_url":"https://github.com/DataSenseAnalytics","followers_url":"https://api.github.com/users/DataSenseAnalytics/followers","following_url":"https://api.github.com/users/DataSenseAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/DataSenseAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/DataSenseAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataSenseAnalytics/subscriptions","organizations_url":"https://api.github.com/users/DataSenseAnalytics/orgs","repos_url":"https://api.github.com/users/DataSenseAnalytics/repos","events_url":"https://api.github.com/users/DataSenseAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/DataSenseAnalytics/received_events","type":"Organization","site_admin":false},"repo":{"id":146955662,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NTU2NjI=","name":"insertionQuery","full_name":"DataSenseAnalytics/insertionQuery","owner":{"login":"DataSenseAnalytics","id":17791895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzkxODk1","avatar_url":"https://avatars3.githubusercontent.com/u/17791895?v=4","gravatar_id":"","url":"https://api.github.com/users/DataSenseAnalytics","html_url":"https://github.com/DataSenseAnalytics","followers_url":"https://api.github.com/users/DataSenseAnalytics/followers","following_url":"https://api.github.com/users/DataSenseAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/DataSenseAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/DataSenseAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataSenseAnalytics/subscriptions","organizations_url":"https://api.github.com/users/DataSenseAnalytics/orgs","repos_url":"https://api.github.com/users/DataSenseAnalytics/repos","events_url":"https://api.github.com/users/DataSenseAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/DataSenseAnalytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataSenseAnalytics/insertionQuery","description":"Non-dom-event way to catch nodes showing up. And it uses selectors.","fork":true,"url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery","forks_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/forks","keys_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/teams","hooks_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/hooks","issue_events_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/events{/number}","events_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/events","assignees_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/assignees{/user}","branches_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/branches{/branch}","tags_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/tags","blobs_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/statuses/{sha}","languages_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/languages","stargazers_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/stargazers","contributors_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/contributors","subscribers_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/subscribers","subscription_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/subscription","commits_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/contents/{+path}","compare_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/merges","archive_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/downloads","issues_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues{/number}","pulls_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls{/number}","milestones_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/milestones{/number}","notifications_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/labels{/name}","releases_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/releases{/id}","deployments_url":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/deployments","created_at":"2018-09-01T00:57:26Z","updated_at":"2018-09-01T00:57:28Z","pushed_at":"2018-09-04T18:47:24Z","git_url":"git://github.com/DataSenseAnalytics/insertionQuery.git","ssh_url":"git@github.com:DataSenseAnalytics/insertionQuery.git","clone_url":"https://github.com/DataSenseAnalytics/insertionQuery.git","svn_url":"https://github.com/DataSenseAnalytics/insertionQuery","homepage":"","size":46,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1"},"html":{"href":"https://github.com/DataSenseAnalytics/insertionQuery/pull/1"},"issue":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/1"},"comments":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/DataSenseAnalytics/insertionQuery/statuses/f82c9c8222bbd58f811d31f83f1e29dc2d479117"}},"author_association":"NONE"}}
{"actor":{"display_login":"skrauselevy"}}