{"action":"created","comment":{"url":"https://api.github.com/repos/unbounce/iidy/pulls/comments/181906450","pull_request_review_id":112614209,"id":181906450,"diff_hunk":"@@ -53,26 +64,104 @@ export type GetParamsByPathArgs = GetParamArgs & {recursive: boolean};\n \n export async function setParam(argv: SetParamArgs): Promise<number> {\n   await configureAWS(argv);\n+  const ssm = new aws.SSM();\n \n-  const Name = argv.path;\n+  const Name = argv.withApproval ? `${argv.path}.pending` : argv.path;\n   const Value = argv.value.toString();\n   const Type = argv.type;\n   const Overwrite = argv.overwrite;\n   const KeyId = Type === 'SecureString' ? await getKMSAliasForParameter(Name) : undefined;\n-  const ssm = new aws.SSM();\n   const res = await ssm.putParameter({Name, Value, Type, KeyId, Overwrite}).promise();\n-  return 0;\n+\n+  if (argv.withApproval) {\n+    console.log('Parameter change is pending approval. Review change with:');\n+    console.log(`  iidy --region ${argv.region} param review ${argv.path}`);","path":"src/params/index.ts","position":49,"original_position":49,"commit_id":"a72ef145217e2e20c79834f3572e8ad6e6a3e499","original_commit_id":"a72ef145217e2e20c79834f3572e8ad6e6a3e499","user":{"login":"tavisrudd","id":236886,"avatar_url":"https://avatars2.githubusercontent.com/u/236886?v=4","gravatar_id":"","url":"https://api.github.com/users/tavisrudd","html_url":"https://github.com/tavisrudd","followers_url":"https://api.github.com/users/tavisrudd/followers","following_url":"https://api.github.com/users/tavisrudd/following{/other_user}","gists_url":"https://api.github.com/users/tavisrudd/gists{/gist_id}","starred_url":"https://api.github.com/users/tavisrudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavisrudd/subscriptions","organizations_url":"https://api.github.com/users/tavisrudd/orgs","repos_url":"https://api.github.com/users/tavisrudd/repos","events_url":"https://api.github.com/users/tavisrudd/events{/privacy}","received_events_url":"https://api.github.com/users/tavisrudd/received_events","type":"User","site_admin":false},"body":"`argv.region` will often be null. Instead, `import getCurrentAWSRegion from '../getCurrentAWSRegion';`...","created_at":"2018-04-16T22:40:16Z","updated_at":"2018-04-16T22:40:27Z","html_url":"https://github.com/unbounce/iidy/pull/104#discussion_r181906450","pull_request_url":"https://api.github.com/repos/unbounce/iidy/pulls/104","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/unbounce/iidy/pulls/comments/181906450"},"html":{"href":"https://github.com/unbounce/iidy/pull/104#discussion_r181906450"},"pull_request":{"href":"https://api.github.com/repos/unbounce/iidy/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/unbounce/iidy/pulls/104","id":181364237,"html_url":"https://github.com/unbounce/iidy/pull/104","diff_url":"https://github.com/unbounce/iidy/pull/104.diff","patch_url":"https://github.com/unbounce/iidy/pull/104.patch","issue_url":"https://api.github.com/repos/unbounce/iidy/issues/104","number":104,"state":"open","locked":false,"title":"Parameter change approval","user":{"login":"jpb","id":752977,"avatar_url":"https://avatars3.githubusercontent.com/u/752977?v=4","gravatar_id":"","url":"https://api.github.com/users/jpb","html_url":"https://github.com/jpb","followers_url":"https://api.github.com/users/jpb/followers","following_url":"https://api.github.com/users/jpb/following{/other_user}","gists_url":"https://api.github.com/users/jpb/gists{/gist_id}","starred_url":"https://api.github.com/users/jpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpb/subscriptions","organizations_url":"https://api.github.com/users/jpb/orgs","repos_url":"https://api.github.com/users/jpb/repos","events_url":"https://api.github.com/users/jpb/events{/privacy}","received_events_url":"https://api.github.com/users/jpb/received_events","type":"User","site_admin":false},"body":"Adds:\r\n- `iidy param set --with-approval`\r\n- `iidy param review ...`\r\n- Metadata to `iidy get-history`\r\n\r\nFixes:\r\n- bug with `iidy get-history` which omitted the first previous value\r\n\r\nCloses #91 ","created_at":"2018-04-13T01:23:21Z","updated_at":"2018-04-16T22:40:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7454321e76750f650f95bf16acbc54c0a8592986","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unbounce/iidy/pulls/104/commits","review_comments_url":"https://api.github.com/repos/unbounce/iidy/pulls/104/comments","review_comment_url":"https://api.github.com/repos/unbounce/iidy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unbounce/iidy/issues/104/comments","statuses_url":"https://api.github.com/repos/unbounce/iidy/statuses/a72ef145217e2e20c79834f3572e8ad6e6a3e499","head":{"label":"unbounce:param-approval","ref":"param-approval","sha":"a72ef145217e2e20c79834f3572e8ad6e6a3e499","user":{"login":"unbounce","id":115120,"avatar_url":"https://avatars1.githubusercontent.com/u/115120?v=4","gravatar_id":"","url":"https://api.github.com/users/unbounce","html_url":"https://github.com/unbounce","followers_url":"https://api.github.com/users/unbounce/followers","following_url":"https://api.github.com/users/unbounce/following{/other_user}","gists_url":"https://api.github.com/users/unbounce/gists{/gist_id}","starred_url":"https://api.github.com/users/unbounce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbounce/subscriptions","organizations_url":"https://api.github.com/users/unbounce/orgs","repos_url":"https://api.github.com/users/unbounce/repos","events_url":"https://api.github.com/users/unbounce/events{/privacy}","received_events_url":"https://api.github.com/users/unbounce/received_events","type":"Organization","site_admin":false},"repo":{"id":99076603,"name":"iidy","full_name":"unbounce/iidy","owner":{"login":"unbounce","id":115120,"avatar_url":"https://avatars1.githubusercontent.com/u/115120?v=4","gravatar_id":"","url":"https://api.github.com/users/unbounce","html_url":"https://github.com/unbounce","followers_url":"https://api.github.com/users/unbounce/followers","following_url":"https://api.github.com/users/unbounce/following{/other_user}","gists_url":"https://api.github.com/users/unbounce/gists{/gist_id}","starred_url":"https://api.github.com/users/unbounce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbounce/subscriptions","organizations_url":"https://api.github.com/users/unbounce/orgs","repos_url":"https://api.github.com/users/unbounce/repos","events_url":"https://api.github.com/users/unbounce/events{/privacy}","received_events_url":"https://api.github.com/users/unbounce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unbounce/iidy","description":"iidy (Is it done yet?) -- CloudFormation with Confidence","fork":false,"url":"https://api.github.com/repos/unbounce/iidy","forks_url":"https://api.github.com/repos/unbounce/iidy/forks","keys_url":"https://api.github.com/repos/unbounce/iidy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unbounce/iidy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unbounce/iidy/teams","hooks_url":"https://api.github.com/repos/unbounce/iidy/hooks","issue_events_url":"https://api.github.com/repos/unbounce/iidy/issues/events{/number}","events_url":"https://api.github.com/repos/unbounce/iidy/events","assignees_url":"https://api.github.com/repos/unbounce/iidy/assignees{/user}","branches_url":"https://api.github.com/repos/unbounce/iidy/branches{/branch}","tags_url":"https://api.github.com/repos/unbounce/iidy/tags","blobs_url":"https://api.github.com/repos/unbounce/iidy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unbounce/iidy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unbounce/iidy/git/refs{/sha}","trees_url":"https://api.github.com/repos/unbounce/iidy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unbounce/iidy/statuses/{sha}","languages_url":"https://api.github.com/repos/unbounce/iidy/languages","stargazers_url":"https://api.github.com/repos/unbounce/iidy/stargazers","contributors_url":"https://api.github.com/repos/unbounce/iidy/contributors","subscribers_url":"https://api.github.com/repos/unbounce/iidy/subscribers","subscription_url":"https://api.github.com/repos/unbounce/iidy/subscription","commits_url":"https://api.github.com/repos/unbounce/iidy/commits{/sha}","git_commits_url":"https://api.github.com/repos/unbounce/iidy/git/commits{/sha}","comments_url":"https://api.github.com/repos/unbounce/iidy/comments{/number}","issue_comment_url":"https://api.github.com/repos/unbounce/iidy/issues/comments{/number}","contents_url":"https://api.github.com/repos/unbounce/iidy/contents/{+path}","compare_url":"https://api.github.com/repos/unbounce/iidy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unbounce/iidy/merges","archive_url":"https://api.github.com/repos/unbounce/iidy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unbounce/iidy/downloads","issues_url":"https://api.github.com/repos/unbounce/iidy/issues{/number}","pulls_url":"https://api.github.com/repos/unbounce/iidy/pulls{/number}","milestones_url":"https://api.github.com/repos/unbounce/iidy/milestones{/number}","notifications_url":"https://api.github.com/repos/unbounce/iidy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unbounce/iidy/labels{/name}","releases_url":"https://api.github.com/repos/unbounce/iidy/releases{/id}","deployments_url":"https://api.github.com/repos/unbounce/iidy/deployments","created_at":"2017-08-02T05:42:54Z","updated_at":"2018-04-16T17:55:56Z","pushed_at":"2018-04-16T22:06:03Z","git_url":"git://github.com/unbounce/iidy.git","ssh_url":"git@github.com:unbounce/iidy.git","clone_url":"https://github.com/unbounce/iidy.git","svn_url":"https://github.com/unbounce/iidy","homepage":"","size":598,"stargazers_count":21,"watchers_count":21,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":5,"watchers":21,"default_branch":"master"}},"base":{"label":"unbounce:master","ref":"master","sha":"dd4763a4e323dbe4a09b7dbaf216d5311212fd0e","user":{"login":"unbounce","id":115120,"avatar_url":"https://avatars1.githubusercontent.com/u/115120?v=4","gravatar_id":"","url":"https://api.github.com/users/unbounce","html_url":"https://github.com/unbounce","followers_url":"https://api.github.com/users/unbounce/followers","following_url":"https://api.github.com/users/unbounce/following{/other_user}","gists_url":"https://api.github.com/users/unbounce/gists{/gist_id}","starred_url":"https://api.github.com/users/unbounce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbounce/subscriptions","organizations_url":"https://api.github.com/users/unbounce/orgs","repos_url":"https://api.github.com/users/unbounce/repos","events_url":"https://api.github.com/users/unbounce/events{/privacy}","received_events_url":"https://api.github.com/users/unbounce/received_events","type":"Organization","site_admin":false},"repo":{"id":99076603,"name":"iidy","full_name":"unbounce/iidy","owner":{"login":"unbounce","id":115120,"avatar_url":"https://avatars1.githubusercontent.com/u/115120?v=4","gravatar_id":"","url":"https://api.github.com/users/unbounce","html_url":"https://github.com/unbounce","followers_url":"https://api.github.com/users/unbounce/followers","following_url":"https://api.github.com/users/unbounce/following{/other_user}","gists_url":"https://api.github.com/users/unbounce/gists{/gist_id}","starred_url":"https://api.github.com/users/unbounce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbounce/subscriptions","organizations_url":"https://api.github.com/users/unbounce/orgs","repos_url":"https://api.github.com/users/unbounce/repos","events_url":"https://api.github.com/users/unbounce/events{/privacy}","received_events_url":"https://api.github.com/users/unbounce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unbounce/iidy","description":"iidy (Is it done yet?) -- CloudFormation with Confidence","fork":false,"url":"https://api.github.com/repos/unbounce/iidy","forks_url":"https://api.github.com/repos/unbounce/iidy/forks","keys_url":"https://api.github.com/repos/unbounce/iidy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unbounce/iidy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unbounce/iidy/teams","hooks_url":"https://api.github.com/repos/unbounce/iidy/hooks","issue_events_url":"https://api.github.com/repos/unbounce/iidy/issues/events{/number}","events_url":"https://api.github.com/repos/unbounce/iidy/events","assignees_url":"https://api.github.com/repos/unbounce/iidy/assignees{/user}","branches_url":"https://api.github.com/repos/unbounce/iidy/branches{/branch}","tags_url":"https://api.github.com/repos/unbounce/iidy/tags","blobs_url":"https://api.github.com/repos/unbounce/iidy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unbounce/iidy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unbounce/iidy/git/refs{/sha}","trees_url":"https://api.github.com/repos/unbounce/iidy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unbounce/iidy/statuses/{sha}","languages_url":"https://api.github.com/repos/unbounce/iidy/languages","stargazers_url":"https://api.github.com/repos/unbounce/iidy/stargazers","contributors_url":"https://api.github.com/repos/unbounce/iidy/contributors","subscribers_url":"https://api.github.com/repos/unbounce/iidy/subscribers","subscription_url":"https://api.github.com/repos/unbounce/iidy/subscription","commits_url":"https://api.github.com/repos/unbounce/iidy/commits{/sha}","git_commits_url":"https://api.github.com/repos/unbounce/iidy/git/commits{/sha}","comments_url":"https://api.github.com/repos/unbounce/iidy/comments{/number}","issue_comment_url":"https://api.github.com/repos/unbounce/iidy/issues/comments{/number}","contents_url":"https://api.github.com/repos/unbounce/iidy/contents/{+path}","compare_url":"https://api.github.com/repos/unbounce/iidy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unbounce/iidy/merges","archive_url":"https://api.github.com/repos/unbounce/iidy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unbounce/iidy/downloads","issues_url":"https://api.github.com/repos/unbounce/iidy/issues{/number}","pulls_url":"https://api.github.com/repos/unbounce/iidy/pulls{/number}","milestones_url":"https://api.github.com/repos/unbounce/iidy/milestones{/number}","notifications_url":"https://api.github.com/repos/unbounce/iidy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unbounce/iidy/labels{/name}","releases_url":"https://api.github.com/repos/unbounce/iidy/releases{/id}","deployments_url":"https://api.github.com/repos/unbounce/iidy/deployments","created_at":"2017-08-02T05:42:54Z","updated_at":"2018-04-16T17:55:56Z","pushed_at":"2018-04-16T22:06:03Z","git_url":"git://github.com/unbounce/iidy.git","ssh_url":"git@github.com:unbounce/iidy.git","clone_url":"https://github.com/unbounce/iidy.git","svn_url":"https://github.com/unbounce/iidy","homepage":"","size":598,"stargazers_count":21,"watchers_count":21,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":5,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unbounce/iidy/pulls/104"},"html":{"href":"https://github.com/unbounce/iidy/pull/104"},"issue":{"href":"https://api.github.com/repos/unbounce/iidy/issues/104"},"comments":{"href":"https://api.github.com/repos/unbounce/iidy/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/unbounce/iidy/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/unbounce/iidy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unbounce/iidy/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/unbounce/iidy/statuses/a72ef145217e2e20c79834f3572e8ad6e6a3e499"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tavisrudd"}}