{"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/196901474","pull_request_review_id":130539300,"id":196901474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkwMTQ3NA==","diff_hunk":"@@ -1065,6 +1065,7 @@ - (void)viewDidAppear:(BOOL)animated\n     [self startReadTimer];\n     [self updateNavigationBarSubtitleLabel];\n     [self updateBackButtonUnreadCount];\n+    [self autoLoadMoreIfNecessary];","path":"Signal/src/ViewControllers/ConversationView/ConversationViewController.m","position":4,"original_position":4,"commit_id":"b5a836bf281ca623c430cdbc61761e1f47173efc","original_commit_id":"b5a836bf281ca623c430cdbc61761e1f47173efc","user":{"login":"charlesmchen-signal","id":36971147,"node_id":"MDQ6VXNlcjM2OTcxMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/36971147?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen-signal","html_url":"https://github.com/charlesmchen-signal","followers_url":"https://api.github.com/users/charlesmchen-signal/followers","following_url":"https://api.github.com/users/charlesmchen-signal/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen-signal/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen-signal/orgs","repos_url":"https://api.github.com/users/charlesmchen-signal/repos","events_url":"https://api.github.com/users/charlesmchen-signal/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen-signal/received_events","type":"User","site_admin":false},"body":"> What's wrong with waiting until we scroll to load more?\r\n\r\nThere are common scenarios (e.g. more than a load page of unread messages) where we'll load messages up to the unread indicator and then auto-scroll so that the unread-indicator is near the top of the screen.  In these scenarios, the \"load more messages\" indicator is often visible above the unread indicator.  The rule is: auto-load more messages if we're \"near\" the \"load more messages\" indicator so that users don't see it.  That's a courtesy to the user so that the conversation feels infinite and the user doesn't notice loading.  There's another reason too: it avoids a nasty issue wherein it's hard to preserve scroll state if auto-loading occurs while the user is scrolling.\r\n\r\nAnyway, performing `autoLoadMoreIfNecessary` here shouldn't do anything most of the time, since most of the time we're not \"near enough\" to the \"load more messages\" indicator - and when it does load more, it's for a good reason.","created_at":"2018-06-20T18:42:27Z","updated_at":"2018-06-20T18:42:28Z","html_url":"https://github.com/signalapp/Signal-iOS/pull/3559#discussion_r196901474","pull_request_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/196901474"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3559#discussion_r196901474"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559"}},"in_reply_to_id":195780547},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559","id":195212492,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjEyNDky","html_url":"https://github.com/signalapp/Signal-iOS/pull/3559","diff_url":"https://github.com/signalapp/Signal-iOS/pull/3559.diff","patch_url":"https://github.com/signalapp/Signal-iOS/pull/3559.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3559","number":3559,"state":"closed","locked":false,"title":"Shared ui db connection v. auto load more.","user":{"login":"charlesmchen-signal","id":36971147,"node_id":"MDQ6VXNlcjM2OTcxMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/36971147?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen-signal","html_url":"https://github.com/charlesmchen-signal","followers_url":"https://api.github.com/users/charlesmchen-signal/followers","following_url":"https://api.github.com/users/charlesmchen-signal/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen-signal/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen-signal/orgs","repos_url":"https://api.github.com/users/charlesmchen-signal/repos","events_url":"https://api.github.com/users/charlesmchen-signal/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen-signal/received_events","type":"User","site_admin":false},"body":"PTAL @michaelkirk ","created_at":"2018-06-15T15:39:34Z","updated_at":"2018-06-20T18:42:28Z","closed_at":"2018-06-15T15:47:36Z","merged_at":"2018-06-15T15:47:35Z","merge_commit_sha":"b5a836bf281ca623c430cdbc61761e1f47173efc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3559/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/b5a836bf281ca623c430cdbc61761e1f47173efc","head":{"label":"signalapp:charlesmchen/autoLoadMoreOnAppear","ref":"charlesmchen/autoLoadMoreOnAppear","sha":"b5a836bf281ca623c430cdbc61761e1f47173efc","user":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyOTY5OA==","name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-06-20T18:36:48Z","pushed_at":"2018-06-20T18:36:38Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":476979,"stargazers_count":3507,"watchers_count":3507,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":825,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":825,"open_issues":387,"watchers":3507,"default_branch":"master"}},"base":{"label":"signalapp:master","ref":"master","sha":"74358b73f500a2c9e499f17565d9111c2561b1f1","user":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyOTY5OA==","name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-06-20T18:36:48Z","pushed_at":"2018-06-20T18:36:38Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":476979,"stargazers_count":3507,"watchers_count":3507,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":825,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":825,"open_issues":387,"watchers":3507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3559"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3559"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3559/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3559/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/b5a836bf281ca623c430cdbc61761e1f47173efc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"charlesmchen-signal"}}