{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/ceph/pulls/comments/231250413","pull_request_review_id":172180387,"id":231250413,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI1MDQxMw==","diff_hunk":"@@ -227,18 +227,22 @@ def start_minions(self):\n         \"\"\"Starts salt-minion.service on all cluster nodes\"\"\"\n         self.__systemctl_cluster(subcommand=\"start\", service=\"salt-minion\")\n \n-    # FIXME: run in a try-wait loop, because it sometimes does this:\n-    # Running: \"sudo sh -c 'salt \\\\* saltutil.sync_all 2>/dev/null'\"\n-    # stdout:target192168000035.teuthology:\n-    # stdout:    Minion did not return. [No response]\n-    # (which means capturing the stdout and parsing it to ensure that\n-    # the string \"Minion did not return\" did not appear after any of\n-    # the minion names)\n     def sync_pillar_data(self, quiet=True):\n         cmd = \"sudo salt \\\\* saltutil.sync_all\"\n         if quiet:\n             cmd += \" 2>/dev/null\"\n-        self.master_remote.run(args=cmd)\n+        with safe_while(sleep=15, tries=10,\n+                        action=cmd) as proceed:\n+            while proceed():\n+                output = StringIO()\n+                self.master_remote.run(args=cmd, stdout=output)","path":"qa/tasks/salt_manager.py","position":20,"original_position":20,"commit_id":"9bccace4a02eddcd4da803f09471fba98f4c50a3","original_commit_id":"9bccace4a02eddcd4da803f09471fba98f4c50a3","user":{"login":"kshtsk","id":5054477,"node_id":"MDQ6VXNlcjUwNTQ0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5054477?v=4","gravatar_id":"","url":"https://api.github.com/users/kshtsk","html_url":"https://github.com/kshtsk","followers_url":"https://api.github.com/users/kshtsk/followers","following_url":"https://api.github.com/users/kshtsk/following{/other_user}","gists_url":"https://api.github.com/users/kshtsk/gists{/gist_id}","starred_url":"https://api.github.com/users/kshtsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshtsk/subscriptions","organizations_url":"https://api.github.com/users/kshtsk/orgs","repos_url":"https://api.github.com/users/kshtsk/repos","events_url":"https://api.github.com/users/kshtsk/events{/privacy}","received_events_url":"https://api.github.com/users/kshtsk/received_events","type":"User","site_admin":false},"body":"btw, you can now use:\r\n```\r\nif len(re.findall('Minion did not return', self.master_remote.sh(cmd))):\r\n  log.info(\"Not all minions responded. Retrying...\")\r\nelse:\r\n  return None\r\n```","created_at":"2018-11-06T19:00:45Z","updated_at":"2018-11-06T19:00:45Z","html_url":"https://github.com/SUSE/ceph/pull/228#discussion_r231250413","pull_request_url":"https://api.github.com/repos/SUSE/ceph/pulls/228","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SUSE/ceph/pulls/comments/231250413"},"html":{"href":"https://github.com/SUSE/ceph/pull/228#discussion_r231250413"},"pull_request":{"href":"https://api.github.com/repos/SUSE/ceph/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/ceph/pulls/228","id":228728186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzI4MTg2","html_url":"https://github.com/SUSE/ceph/pull/228","diff_url":"https://github.com/SUSE/ceph/pull/228.diff","patch_url":"https://github.com/SUSE/ceph/pull/228.patch","issue_url":"https://api.github.com/repos/SUSE/ceph/issues/228","number":228,"state":"open","locked":false,"title":"qa/tasks/deepsea: implement validation subtask with sample test case","user":{"login":"smithfarm","id":3974844,"node_id":"MDQ6VXNlcjM5NzQ4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3974844?v=4","gravatar_id":"","url":"https://api.github.com/users/smithfarm","html_url":"https://github.com/smithfarm","followers_url":"https://api.github.com/users/smithfarm/followers","following_url":"https://api.github.com/users/smithfarm/following{/other_user}","gists_url":"https://api.github.com/users/smithfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/smithfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithfarm/subscriptions","organizations_url":"https://api.github.com/users/smithfarm/orgs","repos_url":"https://api.github.com/users/smithfarm/repos","events_url":"https://api.github.com/users/smithfarm/events{/privacy}","received_events_url":"https://api.github.com/users/smithfarm/received_events","type":"User","site_admin":false},"body":"- [x] passes `--suite deepsea/test/dummy`\r\n- [ ] passes `--suite deepsea/tier0`\r\n- [ ] passes `--suite suse`","created_at":"2018-11-06T15:20:11Z","updated_at":"2018-11-06T19:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9898343ab6f159cfdd13efdb69c7e011e0cc95a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jschmid1","id":6840312,"node_id":"MDQ6VXNlcjY4NDAzMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6840312?v=4","gravatar_id":"","url":"https://api.github.com/users/jschmid1","html_url":"https://github.com/jschmid1","followers_url":"https://api.github.com/users/jschmid1/followers","following_url":"https://api.github.com/users/jschmid1/following{/other_user}","gists_url":"https://api.github.com/users/jschmid1/gists{/gist_id}","starred_url":"https://api.github.com/users/jschmid1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschmid1/subscriptions","organizations_url":"https://api.github.com/users/jschmid1/orgs","repos_url":"https://api.github.com/users/jschmid1/repos","events_url":"https://api.github.com/users/jschmid1/events{/privacy}","received_events_url":"https://api.github.com/users/jschmid1/received_events","type":"User","site_admin":false},{"login":"markostanojlovic","id":20202473,"node_id":"MDQ6VXNlcjIwMjAyNDcz","avatar_url":"https://avatars0.githubusercontent.com/u/20202473?v=4","gravatar_id":"","url":"https://api.github.com/users/markostanojlovic","html_url":"https://github.com/markostanojlovic","followers_url":"https://api.github.com/users/markostanojlovic/followers","following_url":"https://api.github.com/users/markostanojlovic/following{/other_user}","gists_url":"https://api.github.com/users/markostanojlovic/gists{/gist_id}","starred_url":"https://api.github.com/users/markostanojlovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markostanojlovic/subscriptions","organizations_url":"https://api.github.com/users/markostanojlovic/orgs","repos_url":"https://api.github.com/users/markostanojlovic/repos","events_url":"https://api.github.com/users/markostanojlovic/events{/privacy}","received_events_url":"https://api.github.com/users/markostanojlovic/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/SUSE/ceph/milestones/4","html_url":"https://github.com/SUSE/ceph/milestone/4","labels_url":"https://api.github.com/repos/SUSE/ceph/milestones/4/labels","id":3162027,"node_id":"MDk6TWlsZXN0b25lMzE2MjAyNw==","number":4,"title":"ses6","description":null,"creator":{"login":"l-mb","id":1162196,"node_id":"MDQ6VXNlcjExNjIxOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1162196?v=4","gravatar_id":"","url":"https://api.github.com/users/l-mb","html_url":"https://github.com/l-mb","followers_url":"https://api.github.com/users/l-mb/followers","following_url":"https://api.github.com/users/l-mb/following{/other_user}","gists_url":"https://api.github.com/users/l-mb/gists{/gist_id}","starred_url":"https://api.github.com/users/l-mb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-mb/subscriptions","organizations_url":"https://api.github.com/users/l-mb/orgs","repos_url":"https://api.github.com/users/l-mb/repos","events_url":"https://api.github.com/users/l-mb/events{/privacy}","received_events_url":"https://api.github.com/users/l-mb/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":13,"state":"open","created_at":"2018-03-05T13:52:44Z","updated_at":"2018-11-06T15:20:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/SUSE/ceph/pulls/228/commits","review_comments_url":"https://api.github.com/repos/SUSE/ceph/pulls/228/comments","review_comment_url":"https://api.github.com/repos/SUSE/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/ceph/issues/228/comments","statuses_url":"https://api.github.com/repos/SUSE/ceph/statuses/9bccace4a02eddcd4da803f09471fba98f4c50a3","head":{"label":"SUSE:wip-qa-storage-roles","ref":"wip-qa-storage-roles","sha":"9bccace4a02eddcd4da803f09471fba98f4c50a3","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":20325897,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMyNTg5Nw==","name":"ceph","full_name":"SUSE/ceph","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/SUSE/ceph","forks_url":"https://api.github.com/repos/SUSE/ceph/forks","keys_url":"https://api.github.com/repos/SUSE/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/ceph/teams","hooks_url":"https://api.github.com/repos/SUSE/ceph/hooks","issue_events_url":"https://api.github.com/repos/SUSE/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/ceph/events","assignees_url":"https://api.github.com/repos/SUSE/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/ceph/tags","blobs_url":"https://api.github.com/repos/SUSE/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/ceph/languages","stargazers_url":"https://api.github.com/repos/SUSE/ceph/stargazers","contributors_url":"https://api.github.com/repos/SUSE/ceph/contributors","subscribers_url":"https://api.github.com/repos/SUSE/ceph/subscribers","subscription_url":"https://api.github.com/repos/SUSE/ceph/subscription","commits_url":"https://api.github.com/repos/SUSE/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/ceph/merges","archive_url":"https://api.github.com/repos/SUSE/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/ceph/downloads","issues_url":"https://api.github.com/repos/SUSE/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/ceph/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/ceph/deployments","created_at":"2014-05-30T10:29:18Z","updated_at":"2018-11-06T11:16:06Z","pushed_at":"2018-11-06T18:35:47Z","git_url":"git://github.com/SUSE/ceph.git","ssh_url":"git@github.com:SUSE/ceph.git","clone_url":"https://github.com/SUSE/ceph.git","svn_url":"https://github.com/SUSE/ceph","homepage":"http://ceph.com","size":405054,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":7,"watchers":12,"default_branch":"master"}},"base":{"label":"SUSE:ses6","ref":"ses6","sha":"98e19f7c5fef6340156b692945b778ecb9b59573","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":20325897,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMyNTg5Nw==","name":"ceph","full_name":"SUSE/ceph","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/SUSE/ceph","forks_url":"https://api.github.com/repos/SUSE/ceph/forks","keys_url":"https://api.github.com/repos/SUSE/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/ceph/teams","hooks_url":"https://api.github.com/repos/SUSE/ceph/hooks","issue_events_url":"https://api.github.com/repos/SUSE/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/ceph/events","assignees_url":"https://api.github.com/repos/SUSE/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/ceph/tags","blobs_url":"https://api.github.com/repos/SUSE/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/ceph/languages","stargazers_url":"https://api.github.com/repos/SUSE/ceph/stargazers","contributors_url":"https://api.github.com/repos/SUSE/ceph/contributors","subscribers_url":"https://api.github.com/repos/SUSE/ceph/subscribers","subscription_url":"https://api.github.com/repos/SUSE/ceph/subscription","commits_url":"https://api.github.com/repos/SUSE/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/ceph/merges","archive_url":"https://api.github.com/repos/SUSE/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/ceph/downloads","issues_url":"https://api.github.com/repos/SUSE/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/ceph/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/ceph/deployments","created_at":"2014-05-30T10:29:18Z","updated_at":"2018-11-06T11:16:06Z","pushed_at":"2018-11-06T18:35:47Z","git_url":"git://github.com/SUSE/ceph.git","ssh_url":"git@github.com:SUSE/ceph.git","clone_url":"https://github.com/SUSE/ceph.git","svn_url":"https://github.com/SUSE/ceph","homepage":"http://ceph.com","size":405054,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/ceph/pulls/228"},"html":{"href":"https://github.com/SUSE/ceph/pull/228"},"issue":{"href":"https://api.github.com/repos/SUSE/ceph/issues/228"},"comments":{"href":"https://api.github.com/repos/SUSE/ceph/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/ceph/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/ceph/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/ceph/statuses/9bccace4a02eddcd4da803f09471fba98f4c50a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"kshtsk"}}