{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/18950","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/18950/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/18950/comments","events_url":"https://api.github.com/repos/apple/swift/issues/18950/events","html_url":"https://github.com/apple/swift/pull/18950","id":353811118,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzYwNjA3","number":18950,"title":"[Diagnostics] Adding assignments directly to CS and diagnosing from there.","user":{"login":"gregomni","id":15795449,"node_id":"MDQ6VXNlcjE1Nzk1NDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15795449?v=4","gravatar_id":"","url":"https://api.github.com/users/gregomni","html_url":"https://github.com/gregomni","followers_url":"https://api.github.com/users/gregomni/followers","following_url":"https://api.github.com/users/gregomni/following{/other_user}","gists_url":"https://api.github.com/users/gregomni/gists{/gist_id}","starred_url":"https://api.github.com/users/gregomni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregomni/subscriptions","organizations_url":"https://api.github.com/users/gregomni/orgs","repos_url":"https://api.github.com/users/gregomni/repos","events_url":"https://api.github.com/users/gregomni/events{/privacy}","received_events_url":"https://api.github.com/users/gregomni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-08-24T14:40:36Z","updated_at":"2018-08-25T19:52:16Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18950","html_url":"https://github.com/apple/swift/pull/18950","diff_url":"https://github.com/apple/swift/pull/18950.diff","patch_url":"https://github.com/apple/swift/pull/18950.patch"},"body":"Always CSGen assignment statements by making a typeVar, binding the dest to @lvalue-typeVar and binding the source to convertible-to-typeVar, and then let the CS figure things out, rather than the previous implementation, which was trying to eagerly figure out types. This makes most assignment failures now TreatRValueAsLValue FixConstraints, which can be figured out via the new diagnostics system and in some cases produce better, more specific errors.\r\n\r\nWIP:\r\n- Assignments via key path diagnoses are more specific, but are right now misleadingly so in some cases: need to add a specific non-writable keyPath diagnostic.\r\n- Recomputing assignment dest type in CSApply should be unnecessary now, need to rip that out.\r\n- Bunch of assignment-related code in old CSDiag is now dead, but not all of it, need to figure out how much I can rip out."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/415992624","html_url":"https://github.com/apple/swift/pull/18950#issuecomment-415992624","issue_url":"https://api.github.com/repos/apple/swift/issues/18950","id":415992624,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTk5MjYyNA==","user":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T19:52:16Z","updated_at":"2018-08-25T19:52:16Z","author_association":"MEMBER","body":"@swift-ci please test source compatibility"}}
{"actor":{"display_login":"xedin"}}