{"action":"created","comment":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/244622873","pull_request_review_id":188541463,"id":244622873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDYyMjg3Mw==","diff_hunk":"@@ -56,7 +57,7 @@ public int passes(final Prerequisite prereq, final CharacterDisplay display, CDO\n \t\t\t\t{\n \n \t\t\t\t\tString stripped = desiredType.substring(Constants.SUBSTRING_LENGTH_FIVE);\n-\t\t\t\t\tStringTokenizer tok = new StringTokenizer(stripped.toUpperCase(), \".\");\n+\t\t\t\t\tStringTokenizer tok = new StringTokenizer(stripped.toUpperCase(Locale.ENGLISH), \".\");","path":"code/src/java/plugin/pretokens/test/PreArmorTypeTester.java","position":13,"original_position":13,"commit_id":"86ddeeb898aca97c67fd4098741d9616abdc667a","original_commit_id":"86ddeeb898aca97c67fd4098741d9616abdc667a","user":{"login":"thpr","id":8837174,"node_id":"MDQ6VXNlcjg4MzcxNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8837174?v=4","gravatar_id":"","url":"https://api.github.com/users/thpr","html_url":"https://github.com/thpr","followers_url":"https://api.github.com/users/thpr/followers","following_url":"https://api.github.com/users/thpr/following{/other_user}","gists_url":"https://api.github.com/users/thpr/gists{/gist_id}","starred_url":"https://api.github.com/users/thpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thpr/subscriptions","organizations_url":"https://api.github.com/users/thpr/orgs","repos_url":"https://api.github.com/users/thpr/repos","events_url":"https://api.github.com/users/thpr/events{/privacy}","received_events_url":"https://api.github.com/users/thpr/received_events","type":"User","site_admin":false},"body":"Types are data controlled\r\n...I think in this case we need to check if caps is reqlly necessary?  Is eq.isType already case insensitive?  Should it be?","created_at":"2018-12-31T23:00:14Z","updated_at":"2018-12-31T23:00:34Z","html_url":"https://github.com/PCGen/pcgen/pull/4774#discussion_r244622873","pull_request_url":"https://api.github.com/repos/PCGen/pcgen/pulls/4774","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/244622873"},"html":{"href":"https://github.com/PCGen/pcgen/pull/4774#discussion_r244622873"},"pull_request":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/4774"}}},"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/4774","id":241464541,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDY0NTQx","html_url":"https://github.com/PCGen/pcgen/pull/4774","diff_url":"https://github.com/PCGen/pcgen/pull/4774.diff","patch_url":"https://github.com/PCGen/pcgen/pull/4774.patch","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/4774","number":4774,"state":"open","locked":false,"title":"CODE-3200: add Locale.ENGLISH to computer-read values (id: 7:18244)","user":{"login":"grimreaper","id":433817,"node_id":"MDQ6VXNlcjQzMzgxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/433817?v=4","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-12-29T21:20:33Z","updated_at":"2018-12-31T23:00:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95ab84134a85594bf60771406e6f650e84297b54","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PCGen/pcgen/pulls/4774/commits","review_comments_url":"https://api.github.com/repos/PCGen/pcgen/pulls/4774/comments","review_comment_url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/4774/comments","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/86ddeeb898aca97c67fd4098741d9616abdc667a","head":{"label":"grimreaper:eax/english-tokens/54d3b8e662","ref":"eax/english-tokens/54d3b8e662","sha":"86ddeeb898aca97c67fd4098741d9616abdc667a","user":{"login":"grimreaper","id":433817,"node_id":"MDQ6VXNlcjQzMzgxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/433817?v=4","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"repo":{"id":43053313,"node_id":"MDEwOlJlcG9zaXRvcnk0MzA1MzMxMw==","name":"pcgen","full_name":"grimreaper/pcgen","private":false,"owner":{"login":"grimreaper","id":433817,"node_id":"MDQ6VXNlcjQzMzgxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/433817?v=4","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/grimreaper/pcgen","description":"Main code and data development for pcgen program release","fork":true,"url":"https://api.github.com/repos/grimreaper/pcgen","forks_url":"https://api.github.com/repos/grimreaper/pcgen/forks","keys_url":"https://api.github.com/repos/grimreaper/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grimreaper/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grimreaper/pcgen/teams","hooks_url":"https://api.github.com/repos/grimreaper/pcgen/hooks","issue_events_url":"https://api.github.com/repos/grimreaper/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/grimreaper/pcgen/events","assignees_url":"https://api.github.com/repos/grimreaper/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/grimreaper/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/grimreaper/pcgen/tags","blobs_url":"https://api.github.com/repos/grimreaper/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grimreaper/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grimreaper/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/grimreaper/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grimreaper/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/grimreaper/pcgen/languages","stargazers_url":"https://api.github.com/repos/grimreaper/pcgen/stargazers","contributors_url":"https://api.github.com/repos/grimreaper/pcgen/contributors","subscribers_url":"https://api.github.com/repos/grimreaper/pcgen/subscribers","subscription_url":"https://api.github.com/repos/grimreaper/pcgen/subscription","commits_url":"https://api.github.com/repos/grimreaper/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/grimreaper/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/grimreaper/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/grimreaper/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/grimreaper/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/grimreaper/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grimreaper/pcgen/merges","archive_url":"https://api.github.com/repos/grimreaper/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grimreaper/pcgen/downloads","issues_url":"https://api.github.com/repos/grimreaper/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/grimreaper/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/grimreaper/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/grimreaper/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grimreaper/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/grimreaper/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/grimreaper/pcgen/deployments","created_at":"2015-09-24T08:01:43Z","updated_at":"2018-12-31T20:25:48Z","pushed_at":"2018-12-31T20:26:51Z","git_url":"git://github.com/grimreaper/pcgen.git","ssh_url":"git@github.com:grimreaper/pcgen.git","clone_url":"https://github.com/grimreaper/pcgen.git","svn_url":"https://github.com/grimreaper/pcgen","homepage":"http://pcgen.org","size":289310,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCGen:master","ref":"master","sha":"c8f60e7e542f9b294f122e5ceecce1a4bcde2306","user":{"login":"PCGen","id":2158677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTg2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2158677?v=4","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"repo":{"id":28585874,"node_id":"MDEwOlJlcG9zaXRvcnkyODU4NTg3NA==","name":"pcgen","full_name":"PCGen/pcgen","private":false,"owner":{"login":"PCGen","id":2158677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTg2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2158677?v=4","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PCGen/pcgen","description":"Main code and data development for pcgen program release","fork":false,"url":"https://api.github.com/repos/PCGen/pcgen","forks_url":"https://api.github.com/repos/PCGen/pcgen/forks","keys_url":"https://api.github.com/repos/PCGen/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCGen/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCGen/pcgen/teams","hooks_url":"https://api.github.com/repos/PCGen/pcgen/hooks","issue_events_url":"https://api.github.com/repos/PCGen/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/PCGen/pcgen/events","assignees_url":"https://api.github.com/repos/PCGen/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/PCGen/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/PCGen/pcgen/tags","blobs_url":"https://api.github.com/repos/PCGen/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCGen/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCGen/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCGen/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/PCGen/pcgen/languages","stargazers_url":"https://api.github.com/repos/PCGen/pcgen/stargazers","contributors_url":"https://api.github.com/repos/PCGen/pcgen/contributors","subscribers_url":"https://api.github.com/repos/PCGen/pcgen/subscribers","subscription_url":"https://api.github.com/repos/PCGen/pcgen/subscription","commits_url":"https://api.github.com/repos/PCGen/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCGen/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCGen/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCGen/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCGen/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/PCGen/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCGen/pcgen/merges","archive_url":"https://api.github.com/repos/PCGen/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCGen/pcgen/downloads","issues_url":"https://api.github.com/repos/PCGen/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/PCGen/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/PCGen/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/PCGen/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCGen/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/PCGen/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/PCGen/pcgen/deployments","created_at":"2014-12-29T08:41:04Z","updated_at":"2018-12-31T22:57:10Z","pushed_at":"2018-12-31T22:57:03Z","git_url":"git://github.com/PCGen/pcgen.git","ssh_url":"git@github.com:PCGen/pcgen.git","clone_url":"https://github.com/PCGen/pcgen.git","svn_url":"https://github.com/PCGen/pcgen","homepage":"http://pcgen.org","size":279668,"stargazers_count":218,"watchers_count":218,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":52,"license":null,"forks":183,"open_issues":52,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/4774"},"html":{"href":"https://github.com/PCGen/pcgen/pull/4774"},"issue":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/4774"},"comments":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/4774/comments"},"review_comments":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/4774/comments"},"review_comment":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/4774/commits"},"statuses":{"href":"https://api.github.com/repos/PCGen/pcgen/statuses/86ddeeb898aca97c67fd4098741d9616abdc667a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thpr"}}