{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/comments/234481835","pull_request_review_id":176129110,"id":234481835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ4MTgzNQ==","diff_hunk":"@@ -305,12 +305,22 @@ protected void Stop()\n                 var sb = new StringBuilder();\n                 for (int i = 0; i < launchParams.Args.Length; i++)","path":"src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs","position":2,"original_position":2,"commit_id":"70da88a89a452ee5cc1c26995f9c9533859e6705","original_commit_id":"70da88a89a452ee5cc1c26995f9c9533859e6705","user":{"login":"rjmholt","id":7009879,"node_id":"MDQ6VXNlcjcwMDk4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7009879?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmholt","html_url":"https://github.com/rjmholt","followers_url":"https://api.github.com/users/rjmholt/followers","following_url":"https://api.github.com/users/rjmholt/following{/other_user}","gists_url":"https://api.github.com/users/rjmholt/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmholt/subscriptions","organizations_url":"https://api.github.com/users/rjmholt/orgs","repos_url":"https://api.github.com/users/rjmholt/repos","events_url":"https://api.github.com/users/rjmholt/events{/privacy}","received_events_url":"https://api.github.com/users/rjmholt/received_events","type":"User","site_admin":false},"body":"I vote we replace all this logic with `arguments = string.Join(launchParams.Args, \" \")`","created_at":"2018-11-19T02:51:25Z","updated_at":"2018-11-19T02:51:25Z","html_url":"https://github.com/PowerShell/PowerShellEditorServices/pull/794#discussion_r234481835","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/comments/234481835"},"html":{"href":"https://github.com/PowerShell/PowerShellEditorServices/pull/794#discussion_r234481835"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794","id":231815804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODE1ODA0","html_url":"https://github.com/PowerShell/PowerShellEditorServices/pull/794","diff_url":"https://github.com/PowerShell/PowerShellEditorServices/pull/794.diff","patch_url":"https://github.com/PowerShell/PowerShellEditorServices/pull/794.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/794","number":794,"state":"open","locked":false,"title":"Fix Pester CodeLens run/debug by not quoting params/already quoted args","user":{"login":"rkeithhill","id":5177512,"node_id":"MDQ6VXNlcjUxNzc1MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5177512?v=4","gravatar_id":"","url":"https://api.github.com/users/rkeithhill","html_url":"https://github.com/rkeithhill","followers_url":"https://api.github.com/users/rkeithhill/followers","following_url":"https://api.github.com/users/rkeithhill/following{/other_user}","gists_url":"https://api.github.com/users/rkeithhill/gists{/gist_id}","starred_url":"https://api.github.com/users/rkeithhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkeithhill/subscriptions","organizations_url":"https://api.github.com/users/rkeithhill/orgs","repos_url":"https://api.github.com/users/rkeithhill/repos","events_url":"https://api.github.com/users/rkeithhill/events{/privacy}","received_events_url":"https://api.github.com/users/rkeithhill/received_events","type":"User","site_admin":false},"body":"Requires a corresponding PR in vscode-powershell.\r\n\r\nWe should look this one over good as it has potential to break folks.\r\n\r\nI think the odds are low.  Essentially we added the QuoteEscapString\r\nmethod because we get raw paths from VSCode when debugging\r\nthe current file.  Those paths are quoted because they may contain\r\nspaces and because we use single quotes, existing single quotes\r\nhave to be doubled e.g C:\\Don'tUseQuotesInPaths to\r\n'C:\\Don''tUseQuotesInPaths'.\r\n\r\nThis unfortunately was always being invoked on args. Now we\r\ncheck if the arg is a parameter (starts with '-') or is already quoted.  The thinking is if the users is specifying a quoted arg, it's on them\r\nto handle any necessary escaping.\r\n\r\nBTW is there another char that can act as the start of a parameter -\r\nlike the longer dash - whatever that is called.\r\n\r\nLonger term, we need a better solution for how to handle paths\r\nfrom VSCode.  Maybe we handle them there and eliminate the\r\nescaping logic in PSES?","created_at":"2018-11-18T21:37:55Z","updated_at":"2018-11-19T02:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95ffc382e7faa6baf9b43d750b7da78e46f8e0e7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TylerLeonhardt","id":2644648,"node_id":"MDQ6VXNlcjI2NDQ2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2644648?v=4","gravatar_id":"","url":"https://api.github.com/users/TylerLeonhardt","html_url":"https://github.com/TylerLeonhardt","followers_url":"https://api.github.com/users/TylerLeonhardt/followers","following_url":"https://api.github.com/users/TylerLeonhardt/following{/other_user}","gists_url":"https://api.github.com/users/TylerLeonhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerLeonhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerLeonhardt/subscriptions","organizations_url":"https://api.github.com/users/TylerLeonhardt/orgs","repos_url":"https://api.github.com/users/TylerLeonhardt/repos","events_url":"https://api.github.com/users/TylerLeonhardt/events{/privacy}","received_events_url":"https://api.github.com/users/TylerLeonhardt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/794/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/statuses/70da88a89a452ee5cc1c26995f9c9533859e6705","head":{"label":"PowerShell:rkeithhill/fix-debug-pester-codelens","ref":"rkeithhill/fix-debug-pester-codelens","sha":"70da88a89a452ee5cc1c26995f9c9533859e6705","user":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":36031537,"node_id":"MDEwOlJlcG9zaXRvcnkzNjAzMTUzNw==","name":"PowerShellEditorServices","full_name":"PowerShell/PowerShellEditorServices","private":false,"owner":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerShell/PowerShellEditorServices","description":"A common platform for PowerShell development support in any editor or application!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices","forks_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/deployments","created_at":"2015-05-21T18:54:08Z","updated_at":"2018-11-15T01:24:30Z","pushed_at":"2018-11-18T21:37:56Z","git_url":"git://github.com/PowerShell/PowerShellEditorServices.git","ssh_url":"git@github.com:PowerShell/PowerShellEditorServices.git","clone_url":"https://github.com/PowerShell/PowerShellEditorServices.git","svn_url":"https://github.com/PowerShell/PowerShellEditorServices","homepage":"","size":3872,"stargazers_count":254,"watchers_count":254,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":74,"open_issues":132,"watchers":254,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"19d5c5bd98c519c4466ff7aa1c297fe9f0b986a8","user":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":36031537,"node_id":"MDEwOlJlcG9zaXRvcnkzNjAzMTUzNw==","name":"PowerShellEditorServices","full_name":"PowerShell/PowerShellEditorServices","private":false,"owner":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerShell/PowerShellEditorServices","description":"A common platform for PowerShell development support in any editor or application!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices","forks_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/deployments","created_at":"2015-05-21T18:54:08Z","updated_at":"2018-11-15T01:24:30Z","pushed_at":"2018-11-18T21:37:56Z","git_url":"git://github.com/PowerShell/PowerShellEditorServices.git","ssh_url":"git@github.com:PowerShell/PowerShellEditorServices.git","clone_url":"https://github.com/PowerShell/PowerShellEditorServices.git","svn_url":"https://github.com/PowerShell/PowerShellEditorServices","homepage":"","size":3872,"stargazers_count":254,"watchers_count":254,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":74,"open_issues":132,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794"},"html":{"href":"https://github.com/PowerShell/PowerShellEditorServices/pull/794"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/794"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/issues/794/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/pulls/794/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShellEditorServices/statuses/70da88a89a452ee5cc1c26995f9c9533859e6705"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rjmholt"}}