{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/200950831","pull_request_review_id":135356129,"id":200950831,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk1MDgzMQ==","diff_hunk":"@@ -108,7 +108,9 @@ namespace <#= qualifiedNamespace #>\n                 Unity.Entities.Entity entity;\n                 if (!view.TryGetEntity(op.EntityId.Id, out entity))\n                 {\n-                    Debug.LogErrorFormat(TranslationErrors.OpReceivedButNoEntity, op.GetType().Name, op.EntityId.Id);\n+                    view.LogDispatcher.HandleLog(new LogEvent(\"Entity not found during OnAddComponent in <#= componentDetails.ComponentName #>Translation.\", LogType.Error)","path":"code_generator/Templates/UnityComponentConversionGenerator.tt","position":null,"original_position":5,"commit_id":"80666c66a004fcd9f0b45ceaafd5ec03c70c99dc","original_commit_id":"43306090b5789adf2aa1b0a5e833561d115b175b","user":{"login":"martinzlocha","id":6172074,"node_id":"MDQ6VXNlcjYxNzIwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6172074?v=4","gravatar_id":"","url":"https://api.github.com/users/martinzlocha","html_url":"https://github.com/martinzlocha","followers_url":"https://api.github.com/users/martinzlocha/followers","following_url":"https://api.github.com/users/martinzlocha/following{/other_user}","gists_url":"https://api.github.com/users/martinzlocha/gists{/gist_id}","starred_url":"https://api.github.com/users/martinzlocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinzlocha/subscriptions","organizations_url":"https://api.github.com/users/martinzlocha/orgs","repos_url":"https://api.github.com/users/martinzlocha/repos","events_url":"https://api.github.com/users/martinzlocha/events{/privacy}","received_events_url":"https://api.github.com/users/martinzlocha/received_events","type":"User","site_admin":false},"body":"I don't think so given that its possible for users to create their own LogDispatcher for each worker for example.","created_at":"2018-07-09T10:15:43Z","updated_at":"2018-07-09T10:15:43Z","html_url":"https://github.com/spatialos/UnityGDK/pull/53#discussion_r200950831","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/200950831"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/53#discussion_r200950831"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53"}},"in_reply_to_id":200938942},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53","id":198732239,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzMyMjM5","html_url":"https://github.com/spatialos/UnityGDK/pull/53","diff_url":"https://github.com/spatialos/UnityGDK/pull/53.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/53.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/53","number":53,"state":"open","locked":false,"title":"UTY-309: Remove LogError and replace by a dispatcher and error objects.","user":{"login":"martinzlocha","id":6172074,"node_id":"MDQ6VXNlcjYxNzIwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6172074?v=4","gravatar_id":"","url":"https://api.github.com/users/martinzlocha","html_url":"https://github.com/martinzlocha","followers_url":"https://api.github.com/users/martinzlocha/followers","following_url":"https://api.github.com/users/martinzlocha/following{/other_user}","gists_url":"https://api.github.com/users/martinzlocha/gists{/gist_id}","starred_url":"https://api.github.com/users/martinzlocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinzlocha/subscriptions","organizations_url":"https://api.github.com/users/martinzlocha/orgs","repos_url":"https://api.github.com/users/martinzlocha/repos","events_url":"https://api.github.com/users/martinzlocha/events{/privacy}","received_events_url":"https://api.github.com/users/martinzlocha/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nWe are using `Debug.LogError` in a few places in the GDK. This has been replaced by an ErrorDispatcher and in some cases by returning ConnectionError object.\r\n\r\nDesign doc: https://brevi.link/unity-gdk-log-error-replacement \r\n\r\n#### Tests\r\nRan the game sucessfully.\r\n\r\n#### Documentation\r\nN/A\r\n\r\n#### Primary reviewers\r\n@jessicafalk @samiwh ","created_at":"2018-07-02T16:36:34Z","updated_at":"2018-07-09T10:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba1258ffcf5ab435b67cd2e9ec82bde9e952782c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/53/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/80666c66a004fcd9f0b45ceaafd5ec03c70c99dc","head":{"label":"spatialos:feature/UTY-309-change-log-error","ref":"feature/UTY-309-change-log-error","sha":"80666c66a004fcd9f0b45ceaafd5ec03c70c99dc","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-07-09T09:57:54Z","pushed_at":"2018-07-09T10:15:14Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":57111,"stargazers_count":57,"watchers_count":57,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":19,"watchers":57,"default_branch":"master"}},"base":{"label":"spatialos:master","ref":"master","sha":"6c98daa5c96f71efdc196857225c78ccd278170f","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-07-09T09:57:54Z","pushed_at":"2018-07-09T10:15:14Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":57111,"stargazers_count":57,"watchers_count":57,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":19,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/53"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/53"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/80666c66a004fcd9f0b45ceaafd5ec03c70c99dc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martinzlocha"}}