{"action":"created","issue":{"url":"https://api.github.com/repos/MycroftAI/docs-rewrite/issues/57","repository_url":"https://api.github.com/repos/MycroftAI/docs-rewrite","labels_url":"https://api.github.com/repos/MycroftAI/docs-rewrite/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/MycroftAI/docs-rewrite/issues/57/comments","events_url":"https://api.github.com/repos/MycroftAI/docs-rewrite/issues/57/events","html_url":"https://github.com/MycroftAI/docs-rewrite/pull/57","id":316807562,"number":57,"title":"Update conversational-context.md","user":{"login":"Quinn2017","id":32936713,"avatar_url":"https://avatars2.githubusercontent.com/u/32936713?v=4","gravatar_id":"","url":"https://api.github.com/users/Quinn2017","html_url":"https://github.com/Quinn2017","followers_url":"https://api.github.com/users/Quinn2017/followers","following_url":"https://api.github.com/users/Quinn2017/following{/other_user}","gists_url":"https://api.github.com/users/Quinn2017/gists{/gist_id}","starred_url":"https://api.github.com/users/Quinn2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quinn2017/subscriptions","organizations_url":"https://api.github.com/users/Quinn2017/orgs","repos_url":"https://api.github.com/users/Quinn2017/repos","events_url":"https://api.github.com/users/Quinn2017/events{/privacy}","received_events_url":"https://api.github.com/users/Quinn2017/received_events","type":"User","site_admin":false},"labels":[{"id":715594927,"url":"https://api.github.com/repos/MycroftAI/docs-rewrite/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"KathyReid","id":114158,"avatar_url":"https://avatars2.githubusercontent.com/u/114158?v=4","gravatar_id":"","url":"https://api.github.com/users/KathyReid","html_url":"https://github.com/KathyReid","followers_url":"https://api.github.com/users/KathyReid/followers","following_url":"https://api.github.com/users/KathyReid/following{/other_user}","gists_url":"https://api.github.com/users/KathyReid/gists{/gist_id}","starred_url":"https://api.github.com/users/KathyReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KathyReid/subscriptions","organizations_url":"https://api.github.com/users/KathyReid/orgs","repos_url":"https://api.github.com/users/KathyReid/repos","events_url":"https://api.github.com/users/KathyReid/events{/privacy}","received_events_url":"https://api.github.com/users/KathyReid/received_events","type":"User","site_admin":false},"assignees":[{"login":"KathyReid","id":114158,"avatar_url":"https://avatars2.githubusercontent.com/u/114158?v=4","gravatar_id":"","url":"https://api.github.com/users/KathyReid","html_url":"https://github.com/KathyReid","followers_url":"https://api.github.com/users/KathyReid/followers","following_url":"https://api.github.com/users/KathyReid/following{/other_user}","gists_url":"https://api.github.com/users/KathyReid/gists{/gist_id}","starred_url":"https://api.github.com/users/KathyReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KathyReid/subscriptions","organizations_url":"https://api.github.com/users/KathyReid/orgs","repos_url":"https://api.github.com/users/KathyReid/repos","events_url":"https://api.github.com/users/KathyReid/events{/privacy}","received_events_url":"https://api.github.com/users/KathyReid/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-04-23T13:15:14Z","updated_at":"2018-05-03T15:55:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MycroftAI/docs-rewrite/pulls/57","html_url":"https://github.com/MycroftAI/docs-rewrite/pull/57","diff_url":"https://github.com/MycroftAI/docs-rewrite/pull/57.diff","patch_url":"https://github.com/MycroftAI/docs-rewrite/pull/57.patch"},"body":"All the recommended changes are for the \"Using context to enable Intents\" part of the \"conversational-context.md\" guide. \r\n\r\n**Recommendation 1: The speech for def handle_yes_honey_intent**\r\nSince self.milk = False, milk must return False in the def handle_yes_honey_intent when one refuses Milk. I also tried it out in practice and the speech needed to be flipped in this handle so that everything lines up with the correct answer at the end. I think what happened is that a mix-up occurred when writing the instructions originally as the handle_no_milk_intent is placed under the YesMilkIntent and vice versa, which might have caused things to get turned around. For the sake of simplicity, I did not modify this in my pull request.\r\n\r\n**Recommendation 2: The single apostrophe in the speech**\r\nThe single apostrophes in both the def handle_no_honey_intent and def handle_yes_honey_intent for the part of the phrase \"Here's\" was causing problems in python. Nothing would work until I changed the \"Here's\" to \"Heres\" while still maintaining single apostrophe throughout. I thought it simpler just to remove the single apostrophe here, but perhaps the convention should be double apostrophes for the self.speak so that \"here's\" doesn't cause problems. \r\n\r\n**Recommendation 3: The import library**\r\nI thought it would be useful to have the necessary library import for contexts included in the guide. Simply invoking adds_context or removes_context without the import library did not work for me. I was able to find it however in the Mycroft-Core (if I recall correctly), but that was difficult as a newbie.\r\n\r\n**Note:**\r\nI also had an issue with the order of the adds_context and removes_context, but as I already mentioned it to Kathy (in the Chat Room), I'll just open an issue in Github for that one. I had to reverse the order, placing adds_context first and removes_context second for it to work. \r\n\r\n**Mycroft Version**\r\nUsing Picroft, Mycroft Core ver. 18.2.4 beta"},"comment":{"url":"https://api.github.com/repos/MycroftAI/docs-rewrite/issues/comments/386344478","html_url":"https://github.com/MycroftAI/docs-rewrite/pull/57#issuecomment-386344478","issue_url":"https://api.github.com/repos/MycroftAI/docs-rewrite/issues/57","id":386344478,"user":{"login":"KathyReid","id":114158,"avatar_url":"https://avatars2.githubusercontent.com/u/114158?v=4","gravatar_id":"","url":"https://api.github.com/users/KathyReid","html_url":"https://github.com/KathyReid","followers_url":"https://api.github.com/users/KathyReid/followers","following_url":"https://api.github.com/users/KathyReid/following{/other_user}","gists_url":"https://api.github.com/users/KathyReid/gists{/gist_id}","starred_url":"https://api.github.com/users/KathyReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KathyReid/subscriptions","organizations_url":"https://api.github.com/users/KathyReid/orgs","repos_url":"https://api.github.com/users/KathyReid/repos","events_url":"https://api.github.com/users/KathyReid/events{/privacy}","received_events_url":"https://api.github.com/users/KathyReid/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T15:55:11Z","updated_at":"2018-05-03T15:55:11Z","author_association":"MEMBER","body":"Hi @Quinn2017, unfortunately we had a minor issue with our CLA form last week, and your submission hasn't come through - my apologies. Could I please get you to fill out the form again? Sorry for the inconvenience. \r\n\r\nhttps://mycroft.ai/cla"}}
{"actor":{"display_login":"KathyReid"}}