{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/comments/199775204","pull_request_review_id":133958176,"id":199775204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTc3NTIwNA==","diff_hunk":"@@ -0,0 +1,91 @@\n+/*\n+ * ProActive Parallel Suite(TM):\n+ * The Open Source library for parallel and distributed\n+ * Workflows & Scheduling, Orchestration, Cloud Automation\n+ * and Big Data Analysis on Enterprise Grids & Clouds.\n+ *\n+ * Copyright (c) 2007 - 2017 ActiveEon\n+ * Contact: contact@activeeon.com\n+ *\n+ * This library is free software: you can redistribute it and/or\n+ * modify it under the terms of the GNU Affero General Public License\n+ * as published by the Free Software Foundation: version 3 of\n+ * the License.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License\n+ * along with this program. If not, see <http://www.gnu.org/licenses/>.\n+ *\n+ * If needed, contact us to obtain a release under GPL Version 2 or 3\n+ * or a different license than the AGPL.\n+ */\n+package jsr223.kubernetes.utils;\n+\n+import java.util.Collection;\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import javax.script.ScriptContext;\n+\n+import lombok.Getter;\n+import lombok.NoArgsConstructor;\n+\n+\n+@NoArgsConstructor\n+public class BindingUtils {\n+\n+    // GI, bindings and variables\n+    @Getter\n+    Map<String, String> environment;\n+\n+    private void addMapBindingAsEnvironmentVariable(String bindingKey, Map<?, ?> bindingValue,","path":"src/main/java/jsr223/kubernetes/utils/BindingUtils.java","position":45,"original_position":45,"commit_id":"555581b0545cabad7afad9921b3590920cfa88bd","original_commit_id":"555581b0545cabad7afad9921b3590920cfa88bd","user":{"login":"fviale","id":3063713,"node_id":"MDQ6VXNlcjMwNjM3MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3063713?v=4","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"body":"please rename these methods, for example to addMapBindingToReplacementMap(String bindingKey, Map<?, ?> mapBindingValue, Map<String, String> replacementMap)\r\n\r\netc...","created_at":"2018-07-03T11:40:23Z","updated_at":"2018-07-03T11:40:24Z","html_url":"https://github.com/ow2-proactive/jsr223-kubernetes/pull/2#discussion_r199775204","pull_request_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/comments/199775204"},"html":{"href":"https://github.com/ow2-proactive/jsr223-kubernetes/pull/2#discussion_r199775204"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2","id":198669591,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjY5NTkx","html_url":"https://github.com/ow2-proactive/jsr223-kubernetes/pull/2","diff_url":"https://github.com/ow2-proactive/jsr223-kubernetes/pull/2.diff","patch_url":"https://github.com/ow2-proactive/jsr223-kubernetes/pull/2.patch","issue_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues/2","number":2,"state":"open","locked":false,"title":"Variables support","user":{"login":"gheon","id":26597721,"node_id":"MDQ6VXNlcjI2NTk3NzIx","avatar_url":"https://avatars3.githubusercontent.com/u/26597721?v=4","gravatar_id":"","url":"https://api.github.com/users/gheon","html_url":"https://github.com/gheon","followers_url":"https://api.github.com/users/gheon/followers","following_url":"https://api.github.com/users/gheon/following{/other_user}","gists_url":"https://api.github.com/users/gheon/gists{/gist_id}","starred_url":"https://api.github.com/users/gheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheon/subscriptions","organizations_url":"https://api.github.com/users/gheon/orgs","repos_url":"https://api.github.com/users/gheon/repos","events_url":"https://api.github.com/users/gheon/events{/privacy}","received_events_url":"https://api.github.com/users/gheon/received_events","type":"User","site_admin":false},"body":"This feature enables end-users to use ProActive workflow/task variables inside the kubernetes manifest file.","created_at":"2018-07-02T12:50:27Z","updated_at":"2018-07-03T11:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cca5a1c586914b511fd1760537ec73e834444bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues/2/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/statuses/555581b0545cabad7afad9921b3590920cfa88bd","head":{"label":"gheon:variables-support","ref":"variables-support","sha":"555581b0545cabad7afad9921b3590920cfa88bd","user":{"login":"gheon","id":26597721,"node_id":"MDQ6VXNlcjI2NTk3NzIx","avatar_url":"https://avatars3.githubusercontent.com/u/26597721?v=4","gravatar_id":"","url":"https://api.github.com/users/gheon","html_url":"https://github.com/gheon","followers_url":"https://api.github.com/users/gheon/followers","following_url":"https://api.github.com/users/gheon/following{/other_user}","gists_url":"https://api.github.com/users/gheon/gists{/gist_id}","starred_url":"https://api.github.com/users/gheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheon/subscriptions","organizations_url":"https://api.github.com/users/gheon/orgs","repos_url":"https://api.github.com/users/gheon/repos","events_url":"https://api.github.com/users/gheon/events{/privacy}","received_events_url":"https://api.github.com/users/gheon/received_events","type":"User","site_admin":false},"repo":{"id":139442646,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NDI2NDY=","name":"jsr223-kubernetes","full_name":"gheon/jsr223-kubernetes","owner":{"login":"gheon","id":26597721,"node_id":"MDQ6VXNlcjI2NTk3NzIx","avatar_url":"https://avatars3.githubusercontent.com/u/26597721?v=4","gravatar_id":"","url":"https://api.github.com/users/gheon","html_url":"https://github.com/gheon","followers_url":"https://api.github.com/users/gheon/followers","following_url":"https://api.github.com/users/gheon/following{/other_user}","gists_url":"https://api.github.com/users/gheon/gists{/gist_id}","starred_url":"https://api.github.com/users/gheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheon/subscriptions","organizations_url":"https://api.github.com/users/gheon/orgs","repos_url":"https://api.github.com/users/gheon/repos","events_url":"https://api.github.com/users/gheon/events{/privacy}","received_events_url":"https://api.github.com/users/gheon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gheon/jsr223-kubernetes","description":"Kubernetes script engine for ProActive Node & Server","fork":true,"url":"https://api.github.com/repos/gheon/jsr223-kubernetes","forks_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/forks","keys_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/teams","hooks_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/events","assignees_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/tags","blobs_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/languages","stargazers_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/subscription","commits_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/merges","archive_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/downloads","issues_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/gheon/jsr223-kubernetes/deployments","created_at":"2018-07-02T12:45:39Z","updated_at":"2018-07-02T12:45:41Z","pushed_at":"2018-07-03T11:34:26Z","git_url":"git://github.com/gheon/jsr223-kubernetes.git","ssh_url":"git@github.com:gheon/jsr223-kubernetes.git","clone_url":"https://github.com/gheon/jsr223-kubernetes.git","svn_url":"https://github.com/gheon/jsr223-kubernetes","homepage":null,"size":122,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"edd1d0fc61c9e89a9b66922263082604e5f9a279","user":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":133975806,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5NzU4MDY=","name":"jsr223-kubernetes","full_name":"ow2-proactive/jsr223-kubernetes","owner":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/jsr223-kubernetes","description":"Kubernetes script engine for ProActive Node & Server","fork":false,"url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes","forks_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/forks","keys_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/events","assignees_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/merges","archive_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/deployments","created_at":"2018-05-18T15:57:52Z","updated_at":"2018-06-11T10:32:41Z","pushed_at":"2018-07-03T11:34:27Z","git_url":"git://github.com/ow2-proactive/jsr223-kubernetes.git","ssh_url":"git@github.com:ow2-proactive/jsr223-kubernetes.git","clone_url":"https://github.com/ow2-proactive/jsr223-kubernetes.git","svn_url":"https://github.com/ow2-proactive/jsr223-kubernetes","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2"},"html":{"href":"https://github.com/ow2-proactive/jsr223-kubernetes/pull/2"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues/2"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/jsr223-kubernetes/statuses/555581b0545cabad7afad9921b3590920cfa88bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fviale"}}