{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/comments/242158916","pull_request_review_id":185604034,"id":242158916,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjE1ODkxNg==","diff_hunk":"@@ -1,5 +1,6 @@\n #!/usr/bin/env bash\n set -e\n+set -x\n cd \"$(dirname \"$0\")\"","path":"scripts/test.sh","position":4,"original_position":4,"commit_id":"61670d46c71d6d5585c49fe4e6c7f51db6b53069","original_commit_id":"61670d46c71d6d5585c49fe4e6c7f51db6b53069","user":{"login":"krzkaczor","id":1814312,"node_id":"MDQ6VXNlcjE4MTQzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1814312?v=4","gravatar_id":"","url":"https://api.github.com/users/krzkaczor","html_url":"https://github.com/krzkaczor","followers_url":"https://api.github.com/users/krzkaczor/followers","following_url":"https://api.github.com/users/krzkaczor/following{/other_user}","gists_url":"https://api.github.com/users/krzkaczor/gists{/gist_id}","starred_url":"https://api.github.com/users/krzkaczor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzkaczor/subscriptions","organizations_url":"https://api.github.com/users/krzkaczor/orgs","repos_url":"https://api.github.com/users/krzkaczor/repos","events_url":"https://api.github.com/users/krzkaczor/events{/privacy}","received_events_url":"https://api.github.com/users/krzkaczor/received_events","type":"User","site_admin":false},"body":"Can we just revert those? I use `-x` only for debugging purposes, I don't leave that in prod code (and this is how all other scripts are written). ","created_at":"2018-12-17T14:07:06Z","updated_at":"2018-12-17T14:07:06Z","html_url":"https://github.com/ethereum-ts/TypeChain/pull/130#discussion_r242158916","pull_request_url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/comments/242158916"},"html":{"href":"https://github.com/ethereum-ts/TypeChain/pull/130#discussion_r242158916"},"pull_request":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130"}},"in_reply_to_id":242153878},"pull_request":{"url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130","id":239147979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTQ3OTc5","html_url":"https://github.com/ethereum-ts/TypeChain/pull/130","diff_url":"https://github.com/ethereum-ts/TypeChain/pull/130.diff","patch_url":"https://github.com/ethereum-ts/TypeChain/pull/130.patch","issue_url":"https://api.github.com/repos/ethereum-ts/TypeChain/issues/130","number":130,"state":"open","locked":false,"title":"[legacy] correctly pass boolean arguments in methods","user":{"login":"quezak","id":666206,"node_id":"MDQ6VXNlcjY2NjIwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/666206?v=4","gravatar_id":"","url":"https://api.github.com/users/quezak","html_url":"https://github.com/quezak","followers_url":"https://api.github.com/users/quezak/followers","following_url":"https://api.github.com/users/quezak/following{/other_user}","gists_url":"https://api.github.com/users/quezak/gists{/gist_id}","starred_url":"https://api.github.com/users/quezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quezak/subscriptions","organizations_url":"https://api.github.com/users/quezak/orgs","repos_url":"https://api.github.com/users/quezak/repos","events_url":"https://api.github.com/users/quezak/events{/privacy}","received_events_url":"https://api.github.com/users/quezak/received_events","type":"User","site_admin":false},"body":"Fixes #120 \r\n\r\n * updated code generation for passing boolean arguments in methods\r\n * updated code generation for passing arrays, so nested boolean arguments work too\r\n * updated tests for the legacy target, to verify that boolean values are passed correctly","created_at":"2018-12-17T13:40:16Z","updated_at":"2018-12-17T14:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc02af54b9ad22bbd4c775a2f2dbc820b7ce9d6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130/commits","review_comments_url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130/comments","review_comment_url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum-ts/TypeChain/issues/130/comments","statuses_url":"https://api.github.com/repos/ethereum-ts/TypeChain/statuses/61670d46c71d6d5585c49fe4e6c7f51db6b53069","head":{"label":"quezak:master","ref":"master","sha":"61670d46c71d6d5585c49fe4e6c7f51db6b53069","user":{"login":"quezak","id":666206,"node_id":"MDQ6VXNlcjY2NjIwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/666206?v=4","gravatar_id":"","url":"https://api.github.com/users/quezak","html_url":"https://github.com/quezak","followers_url":"https://api.github.com/users/quezak/followers","following_url":"https://api.github.com/users/quezak/following{/other_user}","gists_url":"https://api.github.com/users/quezak/gists{/gist_id}","starred_url":"https://api.github.com/users/quezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quezak/subscriptions","organizations_url":"https://api.github.com/users/quezak/orgs","repos_url":"https://api.github.com/users/quezak/repos","events_url":"https://api.github.com/users/quezak/events{/privacy}","received_events_url":"https://api.github.com/users/quezak/received_events","type":"User","site_admin":false},"repo":{"id":162111588,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxMTE1ODg=","name":"TypeChain","full_name":"quezak/TypeChain","private":false,"owner":{"login":"quezak","id":666206,"node_id":"MDQ6VXNlcjY2NjIwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/666206?v=4","gravatar_id":"","url":"https://api.github.com/users/quezak","html_url":"https://github.com/quezak","followers_url":"https://api.github.com/users/quezak/followers","following_url":"https://api.github.com/users/quezak/following{/other_user}","gists_url":"https://api.github.com/users/quezak/gists{/gist_id}","starred_url":"https://api.github.com/users/quezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quezak/subscriptions","organizations_url":"https://api.github.com/users/quezak/orgs","repos_url":"https://api.github.com/users/quezak/repos","events_url":"https://api.github.com/users/quezak/events{/privacy}","received_events_url":"https://api.github.com/users/quezak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/quezak/TypeChain","description":"🔌 Typescript bindings for Ethereum smartcontracts","fork":true,"url":"https://api.github.com/repos/quezak/TypeChain","forks_url":"https://api.github.com/repos/quezak/TypeChain/forks","keys_url":"https://api.github.com/repos/quezak/TypeChain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quezak/TypeChain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quezak/TypeChain/teams","hooks_url":"https://api.github.com/repos/quezak/TypeChain/hooks","issue_events_url":"https://api.github.com/repos/quezak/TypeChain/issues/events{/number}","events_url":"https://api.github.com/repos/quezak/TypeChain/events","assignees_url":"https://api.github.com/repos/quezak/TypeChain/assignees{/user}","branches_url":"https://api.github.com/repos/quezak/TypeChain/branches{/branch}","tags_url":"https://api.github.com/repos/quezak/TypeChain/tags","blobs_url":"https://api.github.com/repos/quezak/TypeChain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quezak/TypeChain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quezak/TypeChain/git/refs{/sha}","trees_url":"https://api.github.com/repos/quezak/TypeChain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quezak/TypeChain/statuses/{sha}","languages_url":"https://api.github.com/repos/quezak/TypeChain/languages","stargazers_url":"https://api.github.com/repos/quezak/TypeChain/stargazers","contributors_url":"https://api.github.com/repos/quezak/TypeChain/contributors","subscribers_url":"https://api.github.com/repos/quezak/TypeChain/subscribers","subscription_url":"https://api.github.com/repos/quezak/TypeChain/subscription","commits_url":"https://api.github.com/repos/quezak/TypeChain/commits{/sha}","git_commits_url":"https://api.github.com/repos/quezak/TypeChain/git/commits{/sha}","comments_url":"https://api.github.com/repos/quezak/TypeChain/comments{/number}","issue_comment_url":"https://api.github.com/repos/quezak/TypeChain/issues/comments{/number}","contents_url":"https://api.github.com/repos/quezak/TypeChain/contents/{+path}","compare_url":"https://api.github.com/repos/quezak/TypeChain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quezak/TypeChain/merges","archive_url":"https://api.github.com/repos/quezak/TypeChain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quezak/TypeChain/downloads","issues_url":"https://api.github.com/repos/quezak/TypeChain/issues{/number}","pulls_url":"https://api.github.com/repos/quezak/TypeChain/pulls{/number}","milestones_url":"https://api.github.com/repos/quezak/TypeChain/milestones{/number}","notifications_url":"https://api.github.com/repos/quezak/TypeChain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quezak/TypeChain/labels{/name}","releases_url":"https://api.github.com/repos/quezak/TypeChain/releases{/id}","deployments_url":"https://api.github.com/repos/quezak/TypeChain/deployments","created_at":"2018-12-17T10:11:42Z","updated_at":"2018-12-17T13:36:34Z","pushed_at":"2018-12-17T13:36:32Z","git_url":"git://github.com/quezak/TypeChain.git","ssh_url":"git@github.com:quezak/TypeChain.git","clone_url":"https://github.com/quezak/TypeChain.git","svn_url":"https://github.com/quezak/TypeChain","homepage":null,"size":550,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum-ts:master","ref":"master","sha":"7e06b15d60a4d1aba8e450daa9e32ccdffeb153d","user":{"login":"ethereum-ts","id":42468078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDY4MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/42468078?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum-ts","html_url":"https://github.com/ethereum-ts","followers_url":"https://api.github.com/users/ethereum-ts/followers","following_url":"https://api.github.com/users/ethereum-ts/following{/other_user}","gists_url":"https://api.github.com/users/ethereum-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum-ts/subscriptions","organizations_url":"https://api.github.com/users/ethereum-ts/orgs","repos_url":"https://api.github.com/users/ethereum-ts/repos","events_url":"https://api.github.com/users/ethereum-ts/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum-ts/received_events","type":"Organization","site_admin":false},"repo":{"id":102210005,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIyMTAwMDU=","name":"TypeChain","full_name":"ethereum-ts/TypeChain","private":false,"owner":{"login":"ethereum-ts","id":42468078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDY4MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/42468078?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum-ts","html_url":"https://github.com/ethereum-ts","followers_url":"https://api.github.com/users/ethereum-ts/followers","following_url":"https://api.github.com/users/ethereum-ts/following{/other_user}","gists_url":"https://api.github.com/users/ethereum-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum-ts/subscriptions","organizations_url":"https://api.github.com/users/ethereum-ts/orgs","repos_url":"https://api.github.com/users/ethereum-ts/repos","events_url":"https://api.github.com/users/ethereum-ts/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum-ts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum-ts/TypeChain","description":"🔌 Typescript bindings for Ethereum smartcontracts","fork":false,"url":"https://api.github.com/repos/ethereum-ts/TypeChain","forks_url":"https://api.github.com/repos/ethereum-ts/TypeChain/forks","keys_url":"https://api.github.com/repos/ethereum-ts/TypeChain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum-ts/TypeChain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum-ts/TypeChain/teams","hooks_url":"https://api.github.com/repos/ethereum-ts/TypeChain/hooks","issue_events_url":"https://api.github.com/repos/ethereum-ts/TypeChain/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum-ts/TypeChain/events","assignees_url":"https://api.github.com/repos/ethereum-ts/TypeChain/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum-ts/TypeChain/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum-ts/TypeChain/tags","blobs_url":"https://api.github.com/repos/ethereum-ts/TypeChain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum-ts/TypeChain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum-ts/TypeChain/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum-ts/TypeChain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum-ts/TypeChain/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum-ts/TypeChain/languages","stargazers_url":"https://api.github.com/repos/ethereum-ts/TypeChain/stargazers","contributors_url":"https://api.github.com/repos/ethereum-ts/TypeChain/contributors","subscribers_url":"https://api.github.com/repos/ethereum-ts/TypeChain/subscribers","subscription_url":"https://api.github.com/repos/ethereum-ts/TypeChain/subscription","commits_url":"https://api.github.com/repos/ethereum-ts/TypeChain/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum-ts/TypeChain/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum-ts/TypeChain/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum-ts/TypeChain/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum-ts/TypeChain/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum-ts/TypeChain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum-ts/TypeChain/merges","archive_url":"https://api.github.com/repos/ethereum-ts/TypeChain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum-ts/TypeChain/downloads","issues_url":"https://api.github.com/repos/ethereum-ts/TypeChain/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum-ts/TypeChain/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum-ts/TypeChain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum-ts/TypeChain/labels{/name}","releases_url":"https://api.github.com/repos/ethereum-ts/TypeChain/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum-ts/TypeChain/deployments","created_at":"2017-09-02T16:42:54Z","updated_at":"2018-12-13T20:20:30Z","pushed_at":"2018-12-17T13:40:17Z","git_url":"git://github.com/ethereum-ts/TypeChain.git","ssh_url":"git@github.com:ethereum-ts/TypeChain.git","clone_url":"https://github.com/ethereum-ts/TypeChain.git","svn_url":"https://github.com/ethereum-ts/TypeChain","homepage":null,"size":550,"stargazers_count":343,"watchers_count":343,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":19,"watchers":343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130"},"html":{"href":"https://github.com/ethereum-ts/TypeChain/pull/130"},"issue":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/issues/130"},"comments":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum-ts/TypeChain/statuses/61670d46c71d6d5585c49fe4e6c7f51db6b53069"}},"author_association":"NONE"}}
{"actor":{"display_login":"krzkaczor"}}