{"action":"opened","number":1338,"pull_request":{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/1338","id":168425085,"html_url":"https://github.com/videojs/videojs-contrib-hls/pull/1338","diff_url":"https://github.com/videojs/videojs-contrib-hls/pull/1338.diff","patch_url":"https://github.com/videojs/videojs-contrib-hls/pull/1338.patch","issue_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/1338","number":1338,"state":"open","locked":false,"title":"Fix tech.play() throwing unresolved promise errors on Chrome","user":{"login":"grobolom","id":445806,"avatar_url":"https://avatars2.githubusercontent.com/u/445806?v=4","gravatar_id":"","url":"https://api.github.com/users/grobolom","html_url":"https://github.com/grobolom","followers_url":"https://api.github.com/users/grobolom/followers","following_url":"https://api.github.com/users/grobolom/following{/other_user}","gists_url":"https://api.github.com/users/grobolom/gists{/gist_id}","starred_url":"https://api.github.com/users/grobolom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grobolom/subscriptions","organizations_url":"https://api.github.com/users/grobolom/orgs","repos_url":"https://api.github.com/users/grobolom/repos","events_url":"https://api.github.com/users/grobolom/events{/privacy}","received_events_url":"https://api.github.com/users/grobolom/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is an enhancement that fixes errors being thrown by videojs-contrib-hls on Chrome. While the error does not impact player functionality, it pollutes the console log, which may result in confusion or time wasted during manual/automated testing. The error is caused by the media `.play()` event returning a Promise in Chrome, which throws the error `The play() request was interrupted by a call to pause()`.\r\n\r\nThe fix is mirrored from [a similar fix in the video.js core repo](https://github.com/videojs/video.js/pull/3518), which simply wraps the return value of `.play()` in a promise if necessary.\r\n\r\n## Specific Changes proposed\r\nThis fix proposes to wrap the `this.tech_.play()` call in `handleSourceOpen_()` in the `master-playlist-controller` with a `.then()`, so that Chrome does not show a Promise-based error.\r\n\r\n## Requirements Checklist\r\n- [ ] Feature implemented / Bug fixed\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [ ] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](http://jsbin.com/liwecukasi/edit?html,output))\r\n- [ ] Reviewed by Two Core Contributors\r\n","created_at":"2018-02-10T22:44:08Z","updated_at":"2018-02-10T22:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/1338/commits","review_comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/1338/comments","review_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/1338/comments","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/fb872591015de55356b62348732d50d13f3423c7","head":{"label":"grobolom:master","ref":"master","sha":"fb872591015de55356b62348732d50d13f3423c7","user":{"login":"grobolom","id":445806,"avatar_url":"https://avatars2.githubusercontent.com/u/445806?v=4","gravatar_id":"","url":"https://api.github.com/users/grobolom","html_url":"https://github.com/grobolom","followers_url":"https://api.github.com/users/grobolom/followers","following_url":"https://api.github.com/users/grobolom/following{/other_user}","gists_url":"https://api.github.com/users/grobolom/gists{/gist_id}","starred_url":"https://api.github.com/users/grobolom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grobolom/subscriptions","organizations_url":"https://api.github.com/users/grobolom/orgs","repos_url":"https://api.github.com/users/grobolom/repos","events_url":"https://api.github.com/users/grobolom/events{/privacy}","received_events_url":"https://api.github.com/users/grobolom/received_events","type":"User","site_admin":false},"repo":{"id":118732428,"name":"videojs-contrib-hls","full_name":"grobolom/videojs-contrib-hls","owner":{"login":"grobolom","id":445806,"avatar_url":"https://avatars2.githubusercontent.com/u/445806?v=4","gravatar_id":"","url":"https://api.github.com/users/grobolom","html_url":"https://github.com/grobolom","followers_url":"https://api.github.com/users/grobolom/followers","following_url":"https://api.github.com/users/grobolom/following{/other_user}","gists_url":"https://api.github.com/users/grobolom/gists{/gist_id}","starred_url":"https://api.github.com/users/grobolom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grobolom/subscriptions","organizations_url":"https://api.github.com/users/grobolom/orgs","repos_url":"https://api.github.com/users/grobolom/repos","events_url":"https://api.github.com/users/grobolom/events{/privacy}","received_events_url":"https://api.github.com/users/grobolom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grobolom/videojs-contrib-hls","description":"HLS library for video.js","fork":true,"url":"https://api.github.com/repos/grobolom/videojs-contrib-hls","forks_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/forks","keys_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/teams","hooks_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/hooks","issue_events_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/issues/events{/number}","events_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/events","assignees_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/assignees{/user}","branches_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/branches{/branch}","tags_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/tags","blobs_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/languages","stargazers_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/stargazers","contributors_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/contributors","subscribers_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/subscribers","subscription_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/subscription","commits_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/contents/{+path}","compare_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/merges","archive_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/downloads","issues_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/issues{/number}","pulls_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/labels{/name}","releases_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/releases{/id}","deployments_url":"https://api.github.com/repos/grobolom/videojs-contrib-hls/deployments","created_at":"2018-01-24T07:58:04Z","updated_at":"2018-01-24T07:58:06Z","pushed_at":"2018-02-10T22:36:47Z","git_url":"git://github.com/grobolom/videojs-contrib-hls.git","ssh_url":"git@github.com:grobolom/videojs-contrib-hls.git","clone_url":"https://github.com/grobolom/videojs-contrib-hls.git","svn_url":"https://github.com/grobolom/videojs-contrib-hls","homepage":"http://videojs.github.io/videojs-contrib-hls/","size":17021,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"11987cc1cf987d1c17da86cc2e22f7a763b9174a","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":14029328,"name":"videojs-contrib-hls","full_name":"videojs/videojs-contrib-hls","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-contrib-hls","description":"HLS library for video.js","fork":false,"url":"https://api.github.com/repos/videojs/videojs-contrib-hls","forks_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/forks","keys_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/events","assignees_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/merges","archive_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/deployments","created_at":"2013-10-31T21:55:21Z","updated_at":"2018-02-08T08:29:48Z","pushed_at":"2018-02-06T16:23:08Z","git_url":"git://github.com/videojs/videojs-contrib-hls.git","ssh_url":"git@github.com:videojs/videojs-contrib-hls.git","clone_url":"https://github.com/videojs/videojs-contrib-hls.git","svn_url":"https://github.com/videojs/videojs-contrib-hls","homepage":"http://videojs.github.io/videojs-contrib-hls/","size":17091,"stargazers_count":1781,"watchers_count":1781,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":590,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":590,"open_issues":130,"watchers":1781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/1338"},"html":{"href":"https://github.com/videojs/videojs-contrib-hls/pull/1338"},"issue":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/1338"},"comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/1338/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/1338/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/1338/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/fb872591015de55356b62348732d50d13f3423c7"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":22,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"grobolom"}}