{"action":"closed","number":2800,"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2800","id":236383133,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzgzMTMz","html_url":"https://github.com/mesosphere/dcos-commons/pull/2800","diff_url":"https://github.com/mesosphere/dcos-commons/pull/2800.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/2800.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2800","number":2800,"state":"closed","locked":false,"title":"[DCOS-45987] Always publish x86-64 compatible builds for CLI","user":{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false},"body":"we added `GOARCH` as `386` when we first added `tools/build_go_exe.sh` in [Jan 2017](https://github.com/mesosphere/dcos-commons/commit/a3a90ccda4d949ab48cf017f67ec390396170159#diff-6f6fe33cd5affd9513259ffffd6cc88bR64). Considering that is relatively recent, i am going to assume no one has faced a problem with using `386` arch builds in 64 bit systems _so far_. Recently, a customer was using a `Ubuntu` in `windows` subsystem and they were not able to execute the binary ([DCOS-45987](https://jira.mesosphere.com/browse/DCOS-45987)). This is the error one gets when tried to execute the `386` binary in a `ubuntu running in 64-bit Windows` : \r\n```\r\n<filename>: cannot execute binary file: Exec format error.\r\n```\r\nWe have two standards that we can comply with:\r\n- Our universe spec says the CLI binaries have to be `x86-64` compatible (See [universe repo spec](https://github.com/mesosphere/universe/blob/850b6d0ec63fb5acd48ea7680ec9d59a58dff09c/repo/meta/schema/vX-repo-definitions.json#L187) and [hw resource.json#L31](https://github.com/mesosphere/universe/blob/version-3.x/repo/packages/H/hello-world/300/resource.json#L31)).\r\n- DC/OS CLI uses `amd64` as the value of `GOARCH` (See [Makefile](https://github.com/dcos/dcos-cli/blob/99ea9368690b953849f1d98e7814e393dfc373c3/Makefile#L17-L20) - It uses the docker image which inherits from `FROM golang:1.11.0` and it has `GOARCH` defaulted to `amd64` ) \r\n- Without going in the entire argument of 386 vs x86-64, currently there is no supported / documented case of `dcos-commons` CLI being used as a standalone CLI for managing frameworks. So we can just say, whenever core cli works, `dcos-commons` CLI works too.\r\n- If we decide to support other architectures, we need to make changes to `CLI`, `cosmos` etc.. and that requires a bigger discussion.","created_at":"2018-12-06T01:55:29Z","updated_at":"2018-12-12T10:34:06Z","closed_at":"2018-12-12T10:34:06Z","merged_at":"2018-12-12T10:34:06Z","merge_commit_sha":"b07c44bce85154dc81c38c7536719f7e90838d6a","assignee":{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false},"assignees":[{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kaiwalyajoshi","id":4153518,"node_id":"MDQ6VXNlcjQxNTM1MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4153518?v=4","gravatar_id":"","url":"https://api.github.com/users/kaiwalyajoshi","html_url":"https://github.com/kaiwalyajoshi","followers_url":"https://api.github.com/users/kaiwalyajoshi/followers","following_url":"https://api.github.com/users/kaiwalyajoshi/following{/other_user}","gists_url":"https://api.github.com/users/kaiwalyajoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiwalyajoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiwalyajoshi/subscriptions","organizations_url":"https://api.github.com/users/kaiwalyajoshi/orgs","repos_url":"https://api.github.com/users/kaiwalyajoshi/repos","events_url":"https://api.github.com/users/kaiwalyajoshi/events{/privacy}","received_events_url":"https://api.github.com/users/kaiwalyajoshi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2800/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2800/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2800/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/e0c04ac061cd1de1c541e2d25736858b37e067de","head":{"label":"mesosphere:tga/fix-cli-publishing","ref":"tga/fix-cli-publishing","sha":"e0c04ac061cd1de1c541e2d25736858b37e067de","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NjQ5Nw==","name":"dcos-commons","full_name":"mesosphere/dcos-commons","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-12-08T01:52:55Z","pushed_at":"2018-12-12T10:34:06Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":79112,"stargazers_count":144,"watchers_count":144,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":158,"open_issues":91,"watchers":144,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"42717c86f689b8912e4bb2289158c42472063e5d","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NjQ5Nw==","name":"dcos-commons","full_name":"mesosphere/dcos-commons","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-12-08T01:52:55Z","pushed_at":"2018-12-12T10:34:06Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":79112,"stargazers_count":144,"watchers_count":144,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":158,"open_issues":91,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2800"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2800"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2800"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2800/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2800/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2800/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/e0c04ac061cd1de1c541e2d25736858b37e067de"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"takirala"}}