{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/7688","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/7688/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7688/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/7688/events","html_url":"https://github.com/minetest/minetest/pull/7688","id":356215521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTU0MjI1","number":7688,"title":"Add disable_jump to liquids and ladders","user":{"login":"SmallJoker","id":1497498,"node_id":"MDQ6VXNlcjE0OTc0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"labels":[{"id":780836613,"node_id":"MDU6TGFiZWw3ODA4MzY2MTM=","url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Controls%20/%20Input","name":"@ Client / Controls / Input","color":"0e8a16","default":false},{"id":73368983,"node_id":"MDU6TGFiZWw3MzM2ODk4Mw==","url":"https://api.github.com/repos/minetest/minetest/labels/@%20Script%20API","name":"@ Script API","color":"0e8a16","default":false},{"id":471238548,"node_id":"MDU6TGFiZWw0NzEyMzg1NDg=","url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-09-01T16:34:13Z","updated_at":"2018-10-26T17:03:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7688","html_url":"https://github.com/minetest/minetest/pull/7688","diff_url":"https://github.com/minetest/minetest/pull/7688.diff","patch_url":"https://github.com/minetest/minetest/pull/7688.patch"},"body":"Implements feature requested in #4494\r\n\r\nJumping is now no longer possible when the group `disable_jump = 1` is set. Jumping at the bottom of liquids may look a bit weird, but is actually because the node below can be used to jump.\r\n\r\n**Testing code**\r\n```Lua\r\n-- river water for comparison\r\ncore.override_item(\"default:water_source\", {\r\n\tgroups = {\r\n\t\tdisable_jump = 1,\r\n\t\twater = 3, liquid = 3, puts_out_fire = 1, cools_lava = 1\r\n\t}\r\n})\r\n\r\ncore.override_item(\"default:water_flowing\", {\r\n\tgroups = {\r\n\t\tdisable_jump = 1,\r\n\t\twater = 3, liquid = 3, puts_out_fire = 1,\r\n\t\tnot_in_creative_inventory = 1, cools_lava = 1\r\n\t}\r\n})\r\n\r\ncore.override_item(\"default:leaves\", {\r\n\tgroups = {\r\n\t\tdisable_jump = 1,\r\n\t\tcracky = 3\r\n\t}\r\n})\r\n-- steel ladder for comparison\r\ncore.override_item(\"default:ladder_wood\", {\r\n\tgroups = {\r\n\t\tdisable_jump = 1,\r\n\t\tcracky = 3\r\n\t}\r\n})\r\n```"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/433476841","html_url":"https://github.com/minetest/minetest/pull/7688#issuecomment-433476841","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7688","id":433476841,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQ3Njg0MQ==","user":{"login":"SmallJoker","id":1497498,"node_id":"MDQ6VXNlcjE0OTc0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T17:03:53Z","updated_at":"2018-10-26T17:03:53Z","author_association":"MEMBER","body":"> i'm a little bemused by the scale of changes being made for such a specialist feature :)\r\n\r\nAfter all it was you who requested these changes indirectly. I'm just coding. If you want fewer changed lines, then please adopt this PR to show me that it's possible. I could also leave the old move code untouched if you tell me so. The feature will then be limited to the new move code only."}}
{"actor":{"display_login":"SmallJoker"}}