{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37928","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37928/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37928/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37928/events","html_url":"https://github.com/NixOS/nixpkgs/pull/37928","id":309098271,"number":37928,"title":"buildRustCrate: fix equality testing","user":{"login":"VShell","id":251028,"avatar_url":"https://avatars1.githubusercontent.com/u/251028?v=4","gravatar_id":"","url":"https://api.github.com/users/VShell","html_url":"https://github.com/VShell","followers_url":"https://api.github.com/users/VShell/followers","following_url":"https://api.github.com/users/VShell/following{/other_user}","gists_url":"https://api.github.com/users/VShell/gists{/gist_id}","starred_url":"https://api.github.com/users/VShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VShell/subscriptions","organizations_url":"https://api.github.com/users/VShell/orgs","repos_url":"https://api.github.com/users/VShell/repos","events_url":"https://api.github.com/users/VShell/events{/privacy}","received_events_url":"https://api.github.com/users/VShell/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":333381548,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20rust","name":"6.topic: rust","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-27T19:15:11Z","updated_at":"2018-03-28T08:41:00Z","closed_at":"2018-03-28T08:34:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/37928","html_url":"https://github.com/NixOS/nixpkgs/pull/37928","diff_url":"https://github.com/NixOS/nixpkgs/pull/37928.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/37928.patch"},"body":"Use string equality instead of integer equality.\r\n\r\n###### Motivation for this change\r\n\r\nCompiling a crate named cargo-watch results in a binary named cargo_watch due to a script error - the logic already existed to name the binary correctly, but used the wrong comparison operator and so failed.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/376808212","html_url":"https://github.com/NixOS/nixpkgs/pull/37928#issuecomment-376808212","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37928","id":376808212,"user":{"login":"GrahamcOfBorg","id":25447658,"avatar_url":"https://avatars2.githubusercontent.com/u/25447658?v=4","gravatar_id":"","url":"https://api.github.com/users/GrahamcOfBorg","html_url":"https://github.com/GrahamcOfBorg","followers_url":"https://api.github.com/users/GrahamcOfBorg/followers","following_url":"https://api.github.com/users/GrahamcOfBorg/following{/other_user}","gists_url":"https://api.github.com/users/GrahamcOfBorg/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamcOfBorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamcOfBorg/subscriptions","organizations_url":"https://api.github.com/users/GrahamcOfBorg/orgs","repos_url":"https://api.github.com/users/GrahamcOfBorg/repos","events_url":"https://api.github.com/users/GrahamcOfBorg/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamcOfBorg/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T08:41:00Z","updated_at":"2018-03-28T08:41:00Z","author_association":"NONE","body":"Success on x86_64-darwin [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.37928&attempt_id=07cf7567-bdf6-4004-a43a-d65dd52627d6)\n\nAttempted: cargo-vendor\n\n<details><summary>Partial log (click to expand)</summary><p>\n\n```\nwarning: redundant linker flag specified for library `ssl`\n\nwarning: redundant linker flag specified for library `z`\n\ninstalling\npost-installation fixup\nstrip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip\nstripping (with command strip and flags -S) in /nix/store/nhrwnp83kabg885h1h7x0h0967lxchr6-rust_cargo-vendor-0.1.13/lib  /nix/store/nhrwnp83kabg885h1h7x0h0967lxchr6-rust_cargo-vendor-0.1.13/bin\npatching script interpreter paths in /nix/store/nhrwnp83kabg885h1h7x0h0967lxchr6-rust_cargo-vendor-0.1.13\n/nix/store/nhrwnp83kabg885h1h7x0h0967lxchr6-rust_cargo-vendor-0.1.13\n```\n</p></details>\n\n"}}
{"actor":{"display_login":"GrahamcOfBorg"}}