{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/8722","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/8722/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/8722/comments","events_url":"https://api.github.com/repos/istio/istio/issues/8722/events","html_url":"https://github.com/istio/istio/pull/8722","id":360390325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjYwOTQx","number":8722,"title":"WIP: Incremental EDS","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":957605109,"node_id":"MDU6TGFiZWw5NTc2MDUxMDk=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-14T17:26:35Z","updated_at":"2018-09-19T04:00:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8722","html_url":"https://github.com/istio/istio/pull/8722","diff_url":"https://github.com/istio/istio/pull/8722.diff","patch_url":"https://github.com/istio/istio/pull/8722.patch"},"body":"- added a mechanism for service discovery to update 'shards' of endpoints\r\n- new data structures optimized for endpoint update ( IstioEndpoint has minimum info needed and allows caching the proto )\r\n- optimized the update path - only affected shard will be changed without triggering a full cache invalidation\r\n- rewrote the EDS tests - which were testing the 0.7 method, no longer used\r\n- added a ADS client mirroring envoy behavior, to simplify testing (the load tester using this will be in separate PR)\r\n- optimized the incremental push update path."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/422643065","html_url":"https://github.com/istio/istio/pull/8722#issuecomment-422643065","issue_url":"https://api.github.com/repos/istio/istio/issues/8722","id":422643065,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjY0MzA2NQ==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T04:00:40Z","updated_at":"2018-09-19T04:00:40Z","author_association":"COLLABORATOR","body":"@costinm: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/istio-unit-tests.sh | 7827a75550361151713bdd7fdcef1584cb684dfe | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8722/istio-unit-tests/13560/) | `/test istio-unit-tests`\nprow/istio-pilot-e2e-envoyv2-v1alpha3.sh | 7827a75550361151713bdd7fdcef1584cb684dfe | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8722/istio-pilot-e2e-envoyv2-v1alpha3/8030/) | `/test istio-pilot-e2e-envoyv2-v1alpha3`\nprow/e2e-dashboard.sh | 7827a75550361151713bdd7fdcef1584cb684dfe | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8722/e2e-dashboard/4820/) | `/test e2e-dashboard`\nprow/e2e-bookInfoTests-v1alpha3.sh | 7827a75550361151713bdd7fdcef1584cb684dfe | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8722/e2e-bookInfoTests-envoyv2-v1alpha3/7222/) | `/test e2e-bookInfo-envoyv2-v1alpha3`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}