{"action":"closed","number":1387,"pull_request":{"url":"https://api.github.com/repos/markedjs/marked/pulls/1387","id":237266309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjY2MzA5","html_url":"https://github.com/markedjs/marked/pull/1387","diff_url":"https://github.com/markedjs/marked/pull/1387.diff","patch_url":"https://github.com/markedjs/marked/pull/1387.patch","issue_url":"https://api.github.com/repos/markedjs/marked/issues/1387","number":1387,"state":"closed","locked":false,"title":"[commonmark] make code fences compliant (+ fix 1058)","user":{"login":"Feder1co5oave","id":1869444,"node_id":"MDQ6VXNlcjE4Njk0NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1869444?v=4","gravatar_id":"","url":"https://api.github.com/users/Feder1co5oave","html_url":"https://github.com/Feder1co5oave","followers_url":"https://api.github.com/users/Feder1co5oave/followers","following_url":"https://api.github.com/users/Feder1co5oave/following{/other_user}","gists_url":"https://api.github.com/users/Feder1co5oave/gists{/gist_id}","starred_url":"https://api.github.com/users/Feder1co5oave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feder1co5oave/subscriptions","organizations_url":"https://api.github.com/users/Feder1co5oave/orgs","repos_url":"https://api.github.com/users/Feder1co5oave/repos","events_url":"https://api.github.com/users/Feder1co5oave/events{/privacy}","received_events_url":"https://api.github.com/users/Feder1co5oave/received_events","type":"User","site_admin":false},"body":"Code fences containing a matching fence **not** on a new line are terminated incorrectly\r\n- fixes #1058 ([comment](https://github.com/markedjs/marked/issues/1058#issuecomment-445346536))\r\n- allow longer closing fences\r\n- require indentation up to 3 spaces\r\n- fixes #1325 \r\n- fixes #1314\r\n\r\nThis gets up to 100% compliance with [commonmark fenced code blocks](https://spec.commonmark.org/0.28/#fenced-code-blocks)\r\n\r\n- [x] Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,\r\n\r\n- [ ] Draft GitHub release notes have been updated.\r\n- [ ] CI is green (no forced merge required).\r\n- [ ] Merge PR\r\n","created_at":"2018-12-10T10:22:02Z","updated_at":"2018-12-10T17:17:45Z","closed_at":"2018-12-10T17:17:45Z","merged_at":"2018-12-10T17:17:44Z","merge_commit_sha":"76d3733ac5023f7f80af3f0d6b234e91ed81d844","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joshbruce","id":15252830,"node_id":"MDQ6VXNlcjE1MjUyODMw","avatar_url":"https://avatars3.githubusercontent.com/u/15252830?v=4","gravatar_id":"","url":"https://api.github.com/users/joshbruce","html_url":"https://github.com/joshbruce","followers_url":"https://api.github.com/users/joshbruce/followers","following_url":"https://api.github.com/users/joshbruce/following{/other_user}","gists_url":"https://api.github.com/users/joshbruce/gists{/gist_id}","starred_url":"https://api.github.com/users/joshbruce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshbruce/subscriptions","organizations_url":"https://api.github.com/users/joshbruce/orgs","repos_url":"https://api.github.com/users/joshbruce/repos","events_url":"https://api.github.com/users/joshbruce/events{/privacy}","received_events_url":"https://api.github.com/users/joshbruce/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":795468291,"node_id":"MDU6TGFiZWw3OTU0NjgyOTE=","url":"https://api.github.com/repos/markedjs/marked/labels/category:%20code%20blocks","name":"category: code blocks","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/markedjs/marked/pulls/1387/commits","review_comments_url":"https://api.github.com/repos/markedjs/marked/pulls/1387/comments","review_comment_url":"https://api.github.com/repos/markedjs/marked/pulls/comments{/number}","comments_url":"https://api.github.com/repos/markedjs/marked/issues/1387/comments","statuses_url":"https://api.github.com/repos/markedjs/marked/statuses/ca52d38899e580050f70aa54973dd944f39d0924","head":{"label":"Feder1co5oave:fix-1058","ref":"fix-1058","sha":"ca52d38899e580050f70aa54973dd944f39d0924","user":{"login":"Feder1co5oave","id":1869444,"node_id":"MDQ6VXNlcjE4Njk0NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1869444?v=4","gravatar_id":"","url":"https://api.github.com/users/Feder1co5oave","html_url":"https://github.com/Feder1co5oave","followers_url":"https://api.github.com/users/Feder1co5oave/followers","following_url":"https://api.github.com/users/Feder1co5oave/following{/other_user}","gists_url":"https://api.github.com/users/Feder1co5oave/gists{/gist_id}","starred_url":"https://api.github.com/users/Feder1co5oave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feder1co5oave/subscriptions","organizations_url":"https://api.github.com/users/Feder1co5oave/orgs","repos_url":"https://api.github.com/users/Feder1co5oave/repos","events_url":"https://api.github.com/users/Feder1co5oave/events{/privacy}","received_events_url":"https://api.github.com/users/Feder1co5oave/received_events","type":"User","site_admin":false},"repo":{"id":15425435,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyNTQzNQ==","name":"marktex","full_name":"Feder1co5oave/marktex","private":false,"owner":{"login":"Feder1co5oave","id":1869444,"node_id":"MDQ6VXNlcjE4Njk0NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1869444?v=4","gravatar_id":"","url":"https://api.github.com/users/Feder1co5oave","html_url":"https://github.com/Feder1co5oave","followers_url":"https://api.github.com/users/Feder1co5oave/followers","following_url":"https://api.github.com/users/Feder1co5oave/following{/other_user}","gists_url":"https://api.github.com/users/Feder1co5oave/gists{/gist_id}","starred_url":"https://api.github.com/users/Feder1co5oave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feder1co5oave/subscriptions","organizations_url":"https://api.github.com/users/Feder1co5oave/orgs","repos_url":"https://api.github.com/users/Feder1co5oave/repos","events_url":"https://api.github.com/users/Feder1co5oave/events{/privacy}","received_events_url":"https://api.github.com/users/Feder1co5oave/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Feder1co5oave/marktex","description":"A markdown2TeX parser. Built for speed?","fork":true,"url":"https://api.github.com/repos/Feder1co5oave/marktex","forks_url":"https://api.github.com/repos/Feder1co5oave/marktex/forks","keys_url":"https://api.github.com/repos/Feder1co5oave/marktex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Feder1co5oave/marktex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Feder1co5oave/marktex/teams","hooks_url":"https://api.github.com/repos/Feder1co5oave/marktex/hooks","issue_events_url":"https://api.github.com/repos/Feder1co5oave/marktex/issues/events{/number}","events_url":"https://api.github.com/repos/Feder1co5oave/marktex/events","assignees_url":"https://api.github.com/repos/Feder1co5oave/marktex/assignees{/user}","branches_url":"https://api.github.com/repos/Feder1co5oave/marktex/branches{/branch}","tags_url":"https://api.github.com/repos/Feder1co5oave/marktex/tags","blobs_url":"https://api.github.com/repos/Feder1co5oave/marktex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Feder1co5oave/marktex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Feder1co5oave/marktex/git/refs{/sha}","trees_url":"https://api.github.com/repos/Feder1co5oave/marktex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Feder1co5oave/marktex/statuses/{sha}","languages_url":"https://api.github.com/repos/Feder1co5oave/marktex/languages","stargazers_url":"https://api.github.com/repos/Feder1co5oave/marktex/stargazers","contributors_url":"https://api.github.com/repos/Feder1co5oave/marktex/contributors","subscribers_url":"https://api.github.com/repos/Feder1co5oave/marktex/subscribers","subscription_url":"https://api.github.com/repos/Feder1co5oave/marktex/subscription","commits_url":"https://api.github.com/repos/Feder1co5oave/marktex/commits{/sha}","git_commits_url":"https://api.github.com/repos/Feder1co5oave/marktex/git/commits{/sha}","comments_url":"https://api.github.com/repos/Feder1co5oave/marktex/comments{/number}","issue_comment_url":"https://api.github.com/repos/Feder1co5oave/marktex/issues/comments{/number}","contents_url":"https://api.github.com/repos/Feder1co5oave/marktex/contents/{+path}","compare_url":"https://api.github.com/repos/Feder1co5oave/marktex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Feder1co5oave/marktex/merges","archive_url":"https://api.github.com/repos/Feder1co5oave/marktex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Feder1co5oave/marktex/downloads","issues_url":"https://api.github.com/repos/Feder1co5oave/marktex/issues{/number}","pulls_url":"https://api.github.com/repos/Feder1co5oave/marktex/pulls{/number}","milestones_url":"https://api.github.com/repos/Feder1co5oave/marktex/milestones{/number}","notifications_url":"https://api.github.com/repos/Feder1co5oave/marktex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Feder1co5oave/marktex/labels{/name}","releases_url":"https://api.github.com/repos/Feder1co5oave/marktex/releases{/id}","deployments_url":"https://api.github.com/repos/Feder1co5oave/marktex/deployments","created_at":"2013-12-24T21:26:43Z","updated_at":"2018-11-21T13:42:23Z","pushed_at":"2018-12-08T17:27:36Z","git_url":"git://github.com/Feder1co5oave/marktex.git","ssh_url":"git@github.com:Feder1co5oave/marktex.git","clone_url":"https://github.com/Feder1co5oave/marktex.git","svn_url":"https://github.com/Feder1co5oave/marktex","homepage":"","size":1663,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"markedjs:master","ref":"master","sha":"86214bbce13ab5f2cd5faac3adb5d31653be782e","user":{"login":"markedjs","id":19886934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODg2OTM0","avatar_url":"https://avatars0.githubusercontent.com/u/19886934?v=4","gravatar_id":"","url":"https://api.github.com/users/markedjs","html_url":"https://github.com/markedjs","followers_url":"https://api.github.com/users/markedjs/followers","following_url":"https://api.github.com/users/markedjs/following{/other_user}","gists_url":"https://api.github.com/users/markedjs/gists{/gist_id}","starred_url":"https://api.github.com/users/markedjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markedjs/subscriptions","organizations_url":"https://api.github.com/users/markedjs/orgs","repos_url":"https://api.github.com/users/markedjs/repos","events_url":"https://api.github.com/users/markedjs/events{/privacy}","received_events_url":"https://api.github.com/users/markedjs/received_events","type":"Organization","site_admin":false},"repo":{"id":2096579,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk2NTc5","name":"marked","full_name":"markedjs/marked","private":false,"owner":{"login":"markedjs","id":19886934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODg2OTM0","avatar_url":"https://avatars0.githubusercontent.com/u/19886934?v=4","gravatar_id":"","url":"https://api.github.com/users/markedjs","html_url":"https://github.com/markedjs","followers_url":"https://api.github.com/users/markedjs/followers","following_url":"https://api.github.com/users/markedjs/following{/other_user}","gists_url":"https://api.github.com/users/markedjs/gists{/gist_id}","starred_url":"https://api.github.com/users/markedjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markedjs/subscriptions","organizations_url":"https://api.github.com/users/markedjs/orgs","repos_url":"https://api.github.com/users/markedjs/repos","events_url":"https://api.github.com/users/markedjs/events{/privacy}","received_events_url":"https://api.github.com/users/markedjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/markedjs/marked","description":"A markdown parser and compiler. Built for speed.","fork":false,"url":"https://api.github.com/repos/markedjs/marked","forks_url":"https://api.github.com/repos/markedjs/marked/forks","keys_url":"https://api.github.com/repos/markedjs/marked/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markedjs/marked/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markedjs/marked/teams","hooks_url":"https://api.github.com/repos/markedjs/marked/hooks","issue_events_url":"https://api.github.com/repos/markedjs/marked/issues/events{/number}","events_url":"https://api.github.com/repos/markedjs/marked/events","assignees_url":"https://api.github.com/repos/markedjs/marked/assignees{/user}","branches_url":"https://api.github.com/repos/markedjs/marked/branches{/branch}","tags_url":"https://api.github.com/repos/markedjs/marked/tags","blobs_url":"https://api.github.com/repos/markedjs/marked/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markedjs/marked/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markedjs/marked/git/refs{/sha}","trees_url":"https://api.github.com/repos/markedjs/marked/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markedjs/marked/statuses/{sha}","languages_url":"https://api.github.com/repos/markedjs/marked/languages","stargazers_url":"https://api.github.com/repos/markedjs/marked/stargazers","contributors_url":"https://api.github.com/repos/markedjs/marked/contributors","subscribers_url":"https://api.github.com/repos/markedjs/marked/subscribers","subscription_url":"https://api.github.com/repos/markedjs/marked/subscription","commits_url":"https://api.github.com/repos/markedjs/marked/commits{/sha}","git_commits_url":"https://api.github.com/repos/markedjs/marked/git/commits{/sha}","comments_url":"https://api.github.com/repos/markedjs/marked/comments{/number}","issue_comment_url":"https://api.github.com/repos/markedjs/marked/issues/comments{/number}","contents_url":"https://api.github.com/repos/markedjs/marked/contents/{+path}","compare_url":"https://api.github.com/repos/markedjs/marked/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markedjs/marked/merges","archive_url":"https://api.github.com/repos/markedjs/marked/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markedjs/marked/downloads","issues_url":"https://api.github.com/repos/markedjs/marked/issues{/number}","pulls_url":"https://api.github.com/repos/markedjs/marked/pulls{/number}","milestones_url":"https://api.github.com/repos/markedjs/marked/milestones{/number}","notifications_url":"https://api.github.com/repos/markedjs/marked/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markedjs/marked/labels{/name}","releases_url":"https://api.github.com/repos/markedjs/marked/releases{/id}","deployments_url":"https://api.github.com/repos/markedjs/marked/deployments","created_at":"2011-07-24T13:15:51Z","updated_at":"2018-12-10T16:49:16Z","pushed_at":"2018-12-10T17:17:44Z","git_url":"git://github.com/markedjs/marked.git","ssh_url":"git@github.com:markedjs/marked.git","clone_url":"https://github.com/markedjs/marked.git","svn_url":"https://github.com/markedjs/marked","homepage":"https://marked.js.org/","size":1585,"stargazers_count":17957,"watchers_count":17957,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2421,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2421,"open_issues":76,"watchers":17957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/markedjs/marked/pulls/1387"},"html":{"href":"https://github.com/markedjs/marked/pull/1387"},"issue":{"href":"https://api.github.com/repos/markedjs/marked/issues/1387"},"comments":{"href":"https://api.github.com/repos/markedjs/marked/issues/1387/comments"},"review_comments":{"href":"https://api.github.com/repos/markedjs/marked/pulls/1387/comments"},"review_comment":{"href":"https://api.github.com/repos/markedjs/marked/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/markedjs/marked/pulls/1387/commits"},"statuses":{"href":"https://api.github.com/repos/markedjs/marked/statuses/ca52d38899e580050f70aa54973dd944f39d0924"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"styfle","id":229881,"node_id":"MDQ6VXNlcjIyOTg4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/229881?v=4","gravatar_id":"","url":"https://api.github.com/users/styfle","html_url":"https://github.com/styfle","followers_url":"https://api.github.com/users/styfle/followers","following_url":"https://api.github.com/users/styfle/following{/other_user}","gists_url":"https://api.github.com/users/styfle/gists{/gist_id}","starred_url":"https://api.github.com/users/styfle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styfle/subscriptions","organizations_url":"https://api.github.com/users/styfle/orgs","repos_url":"https://api.github.com/users/styfle/repos","events_url":"https://api.github.com/users/styfle/events{/privacy}","received_events_url":"https://api.github.com/users/styfle/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"maintainer_can_modify":false,"commits":5,"additions":18,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"styfle"}}