{"action":"created","comment":{"url":"https://api.github.com/repos/TeskaLabs/asab/pulls/comments/202538501","pull_request_review_id":137262181,"id":202538501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUzODUwMQ==","diff_hunk":"@@ -125,6 +125,7 @@ def parse_args(self):\n \t\tparser.add_argument('-c', '--config', help='specify a path to a configuration file')\n \t\tparser.add_argument('-v', '--verbose', action='store_true', help='print more information (enable debug output)')\n \t\tparser.add_argument('-s', '--syslog', action='store_true', help='enable logging to a syslog')\n+\t\tparser.add_argument('-l', '--log', help='specify a path to a log file')","path":"asab/application.py","position":4,"original_position":4,"commit_id":"690ff5b759756fe5de1f31257044f48dc6dbf6f3","original_commit_id":"690ff5b759756fe5de1f31257044f48dc6dbf6f3","user":{"login":"ateska","id":2236975,"node_id":"MDQ6VXNlcjIyMzY5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2236975?v=4","gravatar_id":"","url":"https://api.github.com/users/ateska","html_url":"https://github.com/ateska","followers_url":"https://api.github.com/users/ateska/followers","following_url":"https://api.github.com/users/ateska/following{/other_user}","gists_url":"https://api.github.com/users/ateska/gists{/gist_id}","starred_url":"https://api.github.com/users/ateska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ateska/subscriptions","organizations_url":"https://api.github.com/users/ateska/orgs","repos_url":"https://api.github.com/users/ateska/repos","events_url":"https://api.github.com/users/ateska/events{/privacy}","received_events_url":"https://api.github.com/users/ateska/received_events","type":"User","site_admin":false},"body":"`--log-file`, please instead of `--log`","created_at":"2018-07-15T10:47:50Z","updated_at":"2018-07-15T10:49:19Z","html_url":"https://github.com/TeskaLabs/asab/pull/19#discussion_r202538501","pull_request_url":"https://api.github.com/repos/TeskaLabs/asab/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TeskaLabs/asab/pulls/comments/202538501"},"html":{"href":"https://github.com/TeskaLabs/asab/pull/19#discussion_r202538501"},"pull_request":{"href":"https://api.github.com/repos/TeskaLabs/asab/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/TeskaLabs/asab/pulls/19","id":200951088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTUxMDg4","html_url":"https://github.com/TeskaLabs/asab/pull/19","diff_url":"https://github.com/TeskaLabs/asab/pull/19.diff","patch_url":"https://github.com/TeskaLabs/asab/pull/19.patch","issue_url":"https://api.github.com/repos/TeskaLabs/asab/issues/19","number":19,"state":"open","locked":false,"title":"Add a command line argument for setting a log file path.","user":{"login":"mpavelka","id":9402863,"node_id":"MDQ6VXNlcjk0MDI4NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/9402863?v=4","gravatar_id":"","url":"https://api.github.com/users/mpavelka","html_url":"https://github.com/mpavelka","followers_url":"https://api.github.com/users/mpavelka/followers","following_url":"https://api.github.com/users/mpavelka/following{/other_user}","gists_url":"https://api.github.com/users/mpavelka/gists{/gist_id}","starred_url":"https://api.github.com/users/mpavelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpavelka/subscriptions","organizations_url":"https://api.github.com/users/mpavelka/orgs","repos_url":"https://api.github.com/users/mpavelka/repos","events_url":"https://api.github.com/users/mpavelka/events{/privacy}","received_events_url":"https://api.github.com/users/mpavelka/received_events","type":"User","site_admin":false},"body":"I want to be able to set path to a log file via command line argument like this:\r\n\r\n```\r\n./asab-app.py -l /var/log/asab-app.log\r\n```","created_at":"2018-07-12T10:07:53Z","updated_at":"2018-07-15T10:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07388bf1ddc4642a01bea4226bed83aa256b80b3","assignee":{"login":"mpavelka","id":9402863,"node_id":"MDQ6VXNlcjk0MDI4NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/9402863?v=4","gravatar_id":"","url":"https://api.github.com/users/mpavelka","html_url":"https://github.com/mpavelka","followers_url":"https://api.github.com/users/mpavelka/followers","following_url":"https://api.github.com/users/mpavelka/following{/other_user}","gists_url":"https://api.github.com/users/mpavelka/gists{/gist_id}","starred_url":"https://api.github.com/users/mpavelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpavelka/subscriptions","organizations_url":"https://api.github.com/users/mpavelka/orgs","repos_url":"https://api.github.com/users/mpavelka/repos","events_url":"https://api.github.com/users/mpavelka/events{/privacy}","received_events_url":"https://api.github.com/users/mpavelka/received_events","type":"User","site_admin":false},"assignees":[{"login":"mpavelka","id":9402863,"node_id":"MDQ6VXNlcjk0MDI4NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/9402863?v=4","gravatar_id":"","url":"https://api.github.com/users/mpavelka","html_url":"https://github.com/mpavelka","followers_url":"https://api.github.com/users/mpavelka/followers","following_url":"https://api.github.com/users/mpavelka/following{/other_user}","gists_url":"https://api.github.com/users/mpavelka/gists{/gist_id}","starred_url":"https://api.github.com/users/mpavelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpavelka/subscriptions","organizations_url":"https://api.github.com/users/mpavelka/orgs","repos_url":"https://api.github.com/users/mpavelka/repos","events_url":"https://api.github.com/users/mpavelka/events{/privacy}","received_events_url":"https://api.github.com/users/mpavelka/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":846321556,"node_id":"MDU6TGFiZWw4NDYzMjE1NTY=","url":"https://api.github.com/repos/TeskaLabs/asab/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/TeskaLabs/asab/pulls/19/commits","review_comments_url":"https://api.github.com/repos/TeskaLabs/asab/pulls/19/comments","review_comment_url":"https://api.github.com/repos/TeskaLabs/asab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TeskaLabs/asab/issues/19/comments","statuses_url":"https://api.github.com/repos/TeskaLabs/asab/statuses/690ff5b759756fe5de1f31257044f48dc6dbf6f3","head":{"label":"TeskaLabs:logfile-via-args","ref":"logfile-via-args","sha":"690ff5b759756fe5de1f31257044f48dc6dbf6f3","user":{"login":"TeskaLabs","id":7040852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7040852?v=4","gravatar_id":"","url":"https://api.github.com/users/TeskaLabs","html_url":"https://github.com/TeskaLabs","followers_url":"https://api.github.com/users/TeskaLabs/followers","following_url":"https://api.github.com/users/TeskaLabs/following{/other_user}","gists_url":"https://api.github.com/users/TeskaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TeskaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeskaLabs/subscriptions","organizations_url":"https://api.github.com/users/TeskaLabs/orgs","repos_url":"https://api.github.com/users/TeskaLabs/repos","events_url":"https://api.github.com/users/TeskaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TeskaLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":122644337,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NDQzMzc=","name":"asab","full_name":"TeskaLabs/asab","owner":{"login":"TeskaLabs","id":7040852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7040852?v=4","gravatar_id":"","url":"https://api.github.com/users/TeskaLabs","html_url":"https://github.com/TeskaLabs","followers_url":"https://api.github.com/users/TeskaLabs/followers","following_url":"https://api.github.com/users/TeskaLabs/following{/other_user}","gists_url":"https://api.github.com/users/TeskaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TeskaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeskaLabs/subscriptions","organizations_url":"https://api.github.com/users/TeskaLabs/orgs","repos_url":"https://api.github.com/users/TeskaLabs/repos","events_url":"https://api.github.com/users/TeskaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TeskaLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeskaLabs/asab","description":"Asynchronous Server Application Boilerplate (aka ASAB) for Python","fork":false,"url":"https://api.github.com/repos/TeskaLabs/asab","forks_url":"https://api.github.com/repos/TeskaLabs/asab/forks","keys_url":"https://api.github.com/repos/TeskaLabs/asab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeskaLabs/asab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeskaLabs/asab/teams","hooks_url":"https://api.github.com/repos/TeskaLabs/asab/hooks","issue_events_url":"https://api.github.com/repos/TeskaLabs/asab/issues/events{/number}","events_url":"https://api.github.com/repos/TeskaLabs/asab/events","assignees_url":"https://api.github.com/repos/TeskaLabs/asab/assignees{/user}","branches_url":"https://api.github.com/repos/TeskaLabs/asab/branches{/branch}","tags_url":"https://api.github.com/repos/TeskaLabs/asab/tags","blobs_url":"https://api.github.com/repos/TeskaLabs/asab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeskaLabs/asab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeskaLabs/asab/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeskaLabs/asab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeskaLabs/asab/statuses/{sha}","languages_url":"https://api.github.com/repos/TeskaLabs/asab/languages","stargazers_url":"https://api.github.com/repos/TeskaLabs/asab/stargazers","contributors_url":"https://api.github.com/repos/TeskaLabs/asab/contributors","subscribers_url":"https://api.github.com/repos/TeskaLabs/asab/subscribers","subscription_url":"https://api.github.com/repos/TeskaLabs/asab/subscription","commits_url":"https://api.github.com/repos/TeskaLabs/asab/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeskaLabs/asab/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeskaLabs/asab/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeskaLabs/asab/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeskaLabs/asab/contents/{+path}","compare_url":"https://api.github.com/repos/TeskaLabs/asab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeskaLabs/asab/merges","archive_url":"https://api.github.com/repos/TeskaLabs/asab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeskaLabs/asab/downloads","issues_url":"https://api.github.com/repos/TeskaLabs/asab/issues{/number}","pulls_url":"https://api.github.com/repos/TeskaLabs/asab/pulls{/number}","milestones_url":"https://api.github.com/repos/TeskaLabs/asab/milestones{/number}","notifications_url":"https://api.github.com/repos/TeskaLabs/asab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeskaLabs/asab/labels{/name}","releases_url":"https://api.github.com/repos/TeskaLabs/asab/releases{/id}","deployments_url":"https://api.github.com/repos/TeskaLabs/asab/deployments","created_at":"2018-02-23T16:19:01Z","updated_at":"2018-07-11T11:09:51Z","pushed_at":"2018-07-12T10:07:54Z","git_url":"git://github.com/TeskaLabs/asab.git","ssh_url":"git@github.com:TeskaLabs/asab.git","clone_url":"https://github.com/TeskaLabs/asab.git","svn_url":"https://github.com/TeskaLabs/asab","homepage":"","size":518,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"TeskaLabs:master","ref":"master","sha":"d65b497a40f3f2e047264438ed3756e5cfc27b6c","user":{"login":"TeskaLabs","id":7040852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7040852?v=4","gravatar_id":"","url":"https://api.github.com/users/TeskaLabs","html_url":"https://github.com/TeskaLabs","followers_url":"https://api.github.com/users/TeskaLabs/followers","following_url":"https://api.github.com/users/TeskaLabs/following{/other_user}","gists_url":"https://api.github.com/users/TeskaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TeskaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeskaLabs/subscriptions","organizations_url":"https://api.github.com/users/TeskaLabs/orgs","repos_url":"https://api.github.com/users/TeskaLabs/repos","events_url":"https://api.github.com/users/TeskaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TeskaLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":122644337,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NDQzMzc=","name":"asab","full_name":"TeskaLabs/asab","owner":{"login":"TeskaLabs","id":7040852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7040852?v=4","gravatar_id":"","url":"https://api.github.com/users/TeskaLabs","html_url":"https://github.com/TeskaLabs","followers_url":"https://api.github.com/users/TeskaLabs/followers","following_url":"https://api.github.com/users/TeskaLabs/following{/other_user}","gists_url":"https://api.github.com/users/TeskaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TeskaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeskaLabs/subscriptions","organizations_url":"https://api.github.com/users/TeskaLabs/orgs","repos_url":"https://api.github.com/users/TeskaLabs/repos","events_url":"https://api.github.com/users/TeskaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TeskaLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeskaLabs/asab","description":"Asynchronous Server Application Boilerplate (aka ASAB) for Python","fork":false,"url":"https://api.github.com/repos/TeskaLabs/asab","forks_url":"https://api.github.com/repos/TeskaLabs/asab/forks","keys_url":"https://api.github.com/repos/TeskaLabs/asab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeskaLabs/asab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeskaLabs/asab/teams","hooks_url":"https://api.github.com/repos/TeskaLabs/asab/hooks","issue_events_url":"https://api.github.com/repos/TeskaLabs/asab/issues/events{/number}","events_url":"https://api.github.com/repos/TeskaLabs/asab/events","assignees_url":"https://api.github.com/repos/TeskaLabs/asab/assignees{/user}","branches_url":"https://api.github.com/repos/TeskaLabs/asab/branches{/branch}","tags_url":"https://api.github.com/repos/TeskaLabs/asab/tags","blobs_url":"https://api.github.com/repos/TeskaLabs/asab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeskaLabs/asab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeskaLabs/asab/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeskaLabs/asab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeskaLabs/asab/statuses/{sha}","languages_url":"https://api.github.com/repos/TeskaLabs/asab/languages","stargazers_url":"https://api.github.com/repos/TeskaLabs/asab/stargazers","contributors_url":"https://api.github.com/repos/TeskaLabs/asab/contributors","subscribers_url":"https://api.github.com/repos/TeskaLabs/asab/subscribers","subscription_url":"https://api.github.com/repos/TeskaLabs/asab/subscription","commits_url":"https://api.github.com/repos/TeskaLabs/asab/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeskaLabs/asab/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeskaLabs/asab/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeskaLabs/asab/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeskaLabs/asab/contents/{+path}","compare_url":"https://api.github.com/repos/TeskaLabs/asab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeskaLabs/asab/merges","archive_url":"https://api.github.com/repos/TeskaLabs/asab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeskaLabs/asab/downloads","issues_url":"https://api.github.com/repos/TeskaLabs/asab/issues{/number}","pulls_url":"https://api.github.com/repos/TeskaLabs/asab/pulls{/number}","milestones_url":"https://api.github.com/repos/TeskaLabs/asab/milestones{/number}","notifications_url":"https://api.github.com/repos/TeskaLabs/asab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeskaLabs/asab/labels{/name}","releases_url":"https://api.github.com/repos/TeskaLabs/asab/releases{/id}","deployments_url":"https://api.github.com/repos/TeskaLabs/asab/deployments","created_at":"2018-02-23T16:19:01Z","updated_at":"2018-07-11T11:09:51Z","pushed_at":"2018-07-12T10:07:54Z","git_url":"git://github.com/TeskaLabs/asab.git","ssh_url":"git@github.com:TeskaLabs/asab.git","clone_url":"https://github.com/TeskaLabs/asab.git","svn_url":"https://github.com/TeskaLabs/asab","homepage":"","size":518,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TeskaLabs/asab/pulls/19"},"html":{"href":"https://github.com/TeskaLabs/asab/pull/19"},"issue":{"href":"https://api.github.com/repos/TeskaLabs/asab/issues/19"},"comments":{"href":"https://api.github.com/repos/TeskaLabs/asab/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/TeskaLabs/asab/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/TeskaLabs/asab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TeskaLabs/asab/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/TeskaLabs/asab/statuses/690ff5b759756fe5de1f31257044f48dc6dbf6f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ateska"}}