{"action":"created","comment":{"url":"https://api.github.com/repos/peopledoc/django-formidable/pulls/comments/172116694","pull_request_review_id":101078422,"id":172116694,"diff_hunk":"@@ -200,6 +200,33 @@ Conditions\n \n     if only checkbox-1 is checked, field X will be displayed, even if checkbox-2 is unchecked, and vice-versa. If both are checked, fields X and Y will be displayed. If none is checked, fields X and Y will be hidden.\n \n+Types for conditional rules\n+---------------------------\n+At this moment, we can guarantee only the support of the checkboxes and\n+dropdown lists, but normally you could use it for any type you want.\n+\n+Also, you could specify types allowed for the conditions using settings variable\n+``FORMIDABLE_CONDITION_FIELDS_ALLOWED_TYPES`` By default formidable accept all the types.","path":"docs/source/forms.rst","position":10,"original_position":10,"commit_id":"015c5ffc91894b776aae5547d69fddf676c02afd","original_commit_id":"015c5ffc91894b776aae5547d69fddf676c02afd","user":{"login":"brunobord","id":25185,"avatar_url":"https://avatars1.githubusercontent.com/u/25185?v=4","gravatar_id":"","url":"https://api.github.com/users/brunobord","html_url":"https://github.com/brunobord","followers_url":"https://api.github.com/users/brunobord/followers","following_url":"https://api.github.com/users/brunobord/following{/other_user}","gists_url":"https://api.github.com/users/brunobord/gists{/gist_id}","starred_url":"https://api.github.com/users/brunobord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunobord/subscriptions","organizations_url":"https://api.github.com/users/brunobord/orgs","repos_url":"https://api.github.com/users/brunobord/repos","events_url":"https://api.github.com/users/brunobord/events{/privacy}","received_events_url":"https://api.github.com/users/brunobord/received_events","type":"User","site_admin":false},"body":"\"By default formidable *will* accept *any type*\"","created_at":"2018-03-05T08:37:30Z","updated_at":"2018-03-05T08:44:15Z","html_url":"https://github.com/peopledoc/django-formidable/pull/304#discussion_r172116694","pull_request_url":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/peopledoc/django-formidable/pulls/comments/172116694"},"html":{"href":"https://github.com/peopledoc/django-formidable/pull/304#discussion_r172116694"},"pull_request":{"href":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304","id":171632223,"html_url":"https://github.com/peopledoc/django-formidable/pull/304","diff_url":"https://github.com/peopledoc/django-formidable/pull/304.diff","patch_url":"https://github.com/peopledoc/django-formidable/pull/304.patch","issue_url":"https://api.github.com/repos/peopledoc/django-formidable/issues/304","number":304,"state":"open","locked":false,"title":"Add tests for conditional rules based on dropdown","user":{"login":"syldlb","id":26469767,"avatar_url":"https://avatars0.githubusercontent.com/u/26469767?v=4","gravatar_id":"","url":"https://api.github.com/users/syldlb","html_url":"https://github.com/syldlb","followers_url":"https://api.github.com/users/syldlb/followers","following_url":"https://api.github.com/users/syldlb/following{/other_user}","gists_url":"https://api.github.com/users/syldlb/gists{/gist_id}","starred_url":"https://api.github.com/users/syldlb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syldlb/subscriptions","organizations_url":"https://api.github.com/users/syldlb/orgs","repos_url":"https://api.github.com/users/syldlb/repos","events_url":"https://api.github.com/users/syldlb/events{/privacy}","received_events_url":"https://api.github.com/users/syldlb/received_events","type":"User","site_admin":false},"body":"Conditional rules are tested and documented for usage with checkboxes. We want to make sure it is possible to use conditional rules based on dropdown lists, by testing and documenting it.\r\n\r\n* [x] Tests<!-- mandatory -->\r\n* [x] Docs/comments\r\n* [x] `CHANGELOG.rst` Updated\r\n* [ ] Delete your branch\r\n","created_at":"2018-02-27T11:16:09Z","updated_at":"2018-03-05T08:44:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25c9478942608ca9fcba14498e37a36dc845c22c","assignee":{"login":"alexdashkov","id":6633228,"avatar_url":"https://avatars2.githubusercontent.com/u/6633228?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdashkov","html_url":"https://github.com/alexdashkov","followers_url":"https://api.github.com/users/alexdashkov/followers","following_url":"https://api.github.com/users/alexdashkov/following{/other_user}","gists_url":"https://api.github.com/users/alexdashkov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdashkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdashkov/subscriptions","organizations_url":"https://api.github.com/users/alexdashkov/orgs","repos_url":"https://api.github.com/users/alexdashkov/repos","events_url":"https://api.github.com/users/alexdashkov/events{/privacy}","received_events_url":"https://api.github.com/users/alexdashkov/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexdashkov","id":6633228,"avatar_url":"https://avatars2.githubusercontent.com/u/6633228?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdashkov","html_url":"https://github.com/alexdashkov","followers_url":"https://api.github.com/users/alexdashkov/followers","following_url":"https://api.github.com/users/alexdashkov/following{/other_user}","gists_url":"https://api.github.com/users/alexdashkov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdashkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdashkov/subscriptions","organizations_url":"https://api.github.com/users/alexdashkov/orgs","repos_url":"https://api.github.com/users/alexdashkov/repos","events_url":"https://api.github.com/users/alexdashkov/events{/privacy}","received_events_url":"https://api.github.com/users/alexdashkov/received_events","type":"User","site_admin":false},{"login":"syldlb","id":26469767,"avatar_url":"https://avatars0.githubusercontent.com/u/26469767?v=4","gravatar_id":"","url":"https://api.github.com/users/syldlb","html_url":"https://github.com/syldlb","followers_url":"https://api.github.com/users/syldlb/followers","following_url":"https://api.github.com/users/syldlb/following{/other_user}","gists_url":"https://api.github.com/users/syldlb/gists{/gist_id}","starred_url":"https://api.github.com/users/syldlb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syldlb/subscriptions","organizations_url":"https://api.github.com/users/syldlb/orgs","repos_url":"https://api.github.com/users/syldlb/repos","events_url":"https://api.github.com/users/syldlb/events{/privacy}","received_events_url":"https://api.github.com/users/syldlb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":276581853,"url":"https://api.github.com/repos/peopledoc/django-formidable/labels/3%20-%20Review","name":"3 - Review","color":"CCCCCC","default":false},{"id":276575587,"url":"https://api.github.com/repos/peopledoc/django-formidable/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304/commits","review_comments_url":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304/comments","review_comment_url":"https://api.github.com/repos/peopledoc/django-formidable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/peopledoc/django-formidable/issues/304/comments","statuses_url":"https://api.github.com/repos/peopledoc/django-formidable/statuses/015c5ffc91894b776aae5547d69fddf676c02afd","head":{"label":"peopledoc:form-336-dropdown-conditional-rules","ref":"form-336-dropdown-conditional-rules","sha":"015c5ffc91894b776aae5547d69fddf676c02afd","user":{"login":"peopledoc","id":1080062,"avatar_url":"https://avatars2.githubusercontent.com/u/1080062?v=4","gravatar_id":"","url":"https://api.github.com/users/peopledoc","html_url":"https://github.com/peopledoc","followers_url":"https://api.github.com/users/peopledoc/followers","following_url":"https://api.github.com/users/peopledoc/following{/other_user}","gists_url":"https://api.github.com/users/peopledoc/gists{/gist_id}","starred_url":"https://api.github.com/users/peopledoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peopledoc/subscriptions","organizations_url":"https://api.github.com/users/peopledoc/orgs","repos_url":"https://api.github.com/users/peopledoc/repos","events_url":"https://api.github.com/users/peopledoc/events{/privacy}","received_events_url":"https://api.github.com/users/peopledoc/received_events","type":"Organization","site_admin":false},"repo":{"id":44758575,"name":"django-formidable","full_name":"peopledoc/django-formidable","owner":{"login":"peopledoc","id":1080062,"avatar_url":"https://avatars2.githubusercontent.com/u/1080062?v=4","gravatar_id":"","url":"https://api.github.com/users/peopledoc","html_url":"https://github.com/peopledoc","followers_url":"https://api.github.com/users/peopledoc/followers","following_url":"https://api.github.com/users/peopledoc/following{/other_user}","gists_url":"https://api.github.com/users/peopledoc/gists{/gist_id}","starred_url":"https://api.github.com/users/peopledoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peopledoc/subscriptions","organizations_url":"https://api.github.com/users/peopledoc/orgs","repos_url":"https://api.github.com/users/peopledoc/repos","events_url":"https://api.github.com/users/peopledoc/events{/privacy}","received_events_url":"https://api.github.com/users/peopledoc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/peopledoc/django-formidable","description":"On the way to glory! again!","fork":false,"url":"https://api.github.com/repos/peopledoc/django-formidable","forks_url":"https://api.github.com/repos/peopledoc/django-formidable/forks","keys_url":"https://api.github.com/repos/peopledoc/django-formidable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peopledoc/django-formidable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peopledoc/django-formidable/teams","hooks_url":"https://api.github.com/repos/peopledoc/django-formidable/hooks","issue_events_url":"https://api.github.com/repos/peopledoc/django-formidable/issues/events{/number}","events_url":"https://api.github.com/repos/peopledoc/django-formidable/events","assignees_url":"https://api.github.com/repos/peopledoc/django-formidable/assignees{/user}","branches_url":"https://api.github.com/repos/peopledoc/django-formidable/branches{/branch}","tags_url":"https://api.github.com/repos/peopledoc/django-formidable/tags","blobs_url":"https://api.github.com/repos/peopledoc/django-formidable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peopledoc/django-formidable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peopledoc/django-formidable/git/refs{/sha}","trees_url":"https://api.github.com/repos/peopledoc/django-formidable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peopledoc/django-formidable/statuses/{sha}","languages_url":"https://api.github.com/repos/peopledoc/django-formidable/languages","stargazers_url":"https://api.github.com/repos/peopledoc/django-formidable/stargazers","contributors_url":"https://api.github.com/repos/peopledoc/django-formidable/contributors","subscribers_url":"https://api.github.com/repos/peopledoc/django-formidable/subscribers","subscription_url":"https://api.github.com/repos/peopledoc/django-formidable/subscription","commits_url":"https://api.github.com/repos/peopledoc/django-formidable/commits{/sha}","git_commits_url":"https://api.github.com/repos/peopledoc/django-formidable/git/commits{/sha}","comments_url":"https://api.github.com/repos/peopledoc/django-formidable/comments{/number}","issue_comment_url":"https://api.github.com/repos/peopledoc/django-formidable/issues/comments{/number}","contents_url":"https://api.github.com/repos/peopledoc/django-formidable/contents/{+path}","compare_url":"https://api.github.com/repos/peopledoc/django-formidable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peopledoc/django-formidable/merges","archive_url":"https://api.github.com/repos/peopledoc/django-formidable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peopledoc/django-formidable/downloads","issues_url":"https://api.github.com/repos/peopledoc/django-formidable/issues{/number}","pulls_url":"https://api.github.com/repos/peopledoc/django-formidable/pulls{/number}","milestones_url":"https://api.github.com/repos/peopledoc/django-formidable/milestones{/number}","notifications_url":"https://api.github.com/repos/peopledoc/django-formidable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peopledoc/django-formidable/labels{/name}","releases_url":"https://api.github.com/repos/peopledoc/django-formidable/releases{/id}","deployments_url":"https://api.github.com/repos/peopledoc/django-formidable/deployments","created_at":"2015-10-22T16:31:51Z","updated_at":"2018-02-20T15:56:28Z","pushed_at":"2018-03-02T14:38:23Z","git_url":"git://github.com/peopledoc/django-formidable.git","ssh_url":"git@github.com:peopledoc/django-formidable.git","clone_url":"https://github.com/peopledoc/django-formidable.git","svn_url":"https://github.com/peopledoc/django-formidable","homepage":"http://django-formidable.readthedocs.io","size":17060,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"base":{"label":"peopledoc:master","ref":"master","sha":"90935a78795fa9bf999748e4679cca72797e4c54","user":{"login":"peopledoc","id":1080062,"avatar_url":"https://avatars2.githubusercontent.com/u/1080062?v=4","gravatar_id":"","url":"https://api.github.com/users/peopledoc","html_url":"https://github.com/peopledoc","followers_url":"https://api.github.com/users/peopledoc/followers","following_url":"https://api.github.com/users/peopledoc/following{/other_user}","gists_url":"https://api.github.com/users/peopledoc/gists{/gist_id}","starred_url":"https://api.github.com/users/peopledoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peopledoc/subscriptions","organizations_url":"https://api.github.com/users/peopledoc/orgs","repos_url":"https://api.github.com/users/peopledoc/repos","events_url":"https://api.github.com/users/peopledoc/events{/privacy}","received_events_url":"https://api.github.com/users/peopledoc/received_events","type":"Organization","site_admin":false},"repo":{"id":44758575,"name":"django-formidable","full_name":"peopledoc/django-formidable","owner":{"login":"peopledoc","id":1080062,"avatar_url":"https://avatars2.githubusercontent.com/u/1080062?v=4","gravatar_id":"","url":"https://api.github.com/users/peopledoc","html_url":"https://github.com/peopledoc","followers_url":"https://api.github.com/users/peopledoc/followers","following_url":"https://api.github.com/users/peopledoc/following{/other_user}","gists_url":"https://api.github.com/users/peopledoc/gists{/gist_id}","starred_url":"https://api.github.com/users/peopledoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peopledoc/subscriptions","organizations_url":"https://api.github.com/users/peopledoc/orgs","repos_url":"https://api.github.com/users/peopledoc/repos","events_url":"https://api.github.com/users/peopledoc/events{/privacy}","received_events_url":"https://api.github.com/users/peopledoc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/peopledoc/django-formidable","description":"On the way to glory! again!","fork":false,"url":"https://api.github.com/repos/peopledoc/django-formidable","forks_url":"https://api.github.com/repos/peopledoc/django-formidable/forks","keys_url":"https://api.github.com/repos/peopledoc/django-formidable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peopledoc/django-formidable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peopledoc/django-formidable/teams","hooks_url":"https://api.github.com/repos/peopledoc/django-formidable/hooks","issue_events_url":"https://api.github.com/repos/peopledoc/django-formidable/issues/events{/number}","events_url":"https://api.github.com/repos/peopledoc/django-formidable/events","assignees_url":"https://api.github.com/repos/peopledoc/django-formidable/assignees{/user}","branches_url":"https://api.github.com/repos/peopledoc/django-formidable/branches{/branch}","tags_url":"https://api.github.com/repos/peopledoc/django-formidable/tags","blobs_url":"https://api.github.com/repos/peopledoc/django-formidable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peopledoc/django-formidable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peopledoc/django-formidable/git/refs{/sha}","trees_url":"https://api.github.com/repos/peopledoc/django-formidable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peopledoc/django-formidable/statuses/{sha}","languages_url":"https://api.github.com/repos/peopledoc/django-formidable/languages","stargazers_url":"https://api.github.com/repos/peopledoc/django-formidable/stargazers","contributors_url":"https://api.github.com/repos/peopledoc/django-formidable/contributors","subscribers_url":"https://api.github.com/repos/peopledoc/django-formidable/subscribers","subscription_url":"https://api.github.com/repos/peopledoc/django-formidable/subscription","commits_url":"https://api.github.com/repos/peopledoc/django-formidable/commits{/sha}","git_commits_url":"https://api.github.com/repos/peopledoc/django-formidable/git/commits{/sha}","comments_url":"https://api.github.com/repos/peopledoc/django-formidable/comments{/number}","issue_comment_url":"https://api.github.com/repos/peopledoc/django-formidable/issues/comments{/number}","contents_url":"https://api.github.com/repos/peopledoc/django-formidable/contents/{+path}","compare_url":"https://api.github.com/repos/peopledoc/django-formidable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peopledoc/django-formidable/merges","archive_url":"https://api.github.com/repos/peopledoc/django-formidable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peopledoc/django-formidable/downloads","issues_url":"https://api.github.com/repos/peopledoc/django-formidable/issues{/number}","pulls_url":"https://api.github.com/repos/peopledoc/django-formidable/pulls{/number}","milestones_url":"https://api.github.com/repos/peopledoc/django-formidable/milestones{/number}","notifications_url":"https://api.github.com/repos/peopledoc/django-formidable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peopledoc/django-formidable/labels{/name}","releases_url":"https://api.github.com/repos/peopledoc/django-formidable/releases{/id}","deployments_url":"https://api.github.com/repos/peopledoc/django-formidable/deployments","created_at":"2015-10-22T16:31:51Z","updated_at":"2018-02-20T15:56:28Z","pushed_at":"2018-03-02T14:38:23Z","git_url":"git://github.com/peopledoc/django-formidable.git","ssh_url":"git@github.com:peopledoc/django-formidable.git","clone_url":"https://github.com/peopledoc/django-formidable.git","svn_url":"https://github.com/peopledoc/django-formidable","homepage":"http://django-formidable.readthedocs.io","size":17060,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304"},"html":{"href":"https://github.com/peopledoc/django-formidable/pull/304"},"issue":{"href":"https://api.github.com/repos/peopledoc/django-formidable/issues/304"},"comments":{"href":"https://api.github.com/repos/peopledoc/django-formidable/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/peopledoc/django-formidable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/peopledoc/django-formidable/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/peopledoc/django-formidable/statuses/015c5ffc91894b776aae5547d69fddf676c02afd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brunobord"}}