{"action":"opened","number":167,"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/167","id":216705095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzA1MDk1","html_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers/pull/167","diff_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers/pull/167.diff","patch_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers/pull/167.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/167","number":167,"state":"open","locked":false,"title":"Ticket3551 refl fix individual move","user":{"login":"ThomasLohnert","id":18398579,"node_id":"MDQ6VXNlcjE4Mzk4NTc5","avatar_url":"https://avatars1.githubusercontent.com/u/18398579?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasLohnert","html_url":"https://github.com/ThomasLohnert","followers_url":"https://api.github.com/users/ThomasLohnert/followers","following_url":"https://api.github.com/users/ThomasLohnert/following{/other_user}","gists_url":"https://api.github.com/users/ThomasLohnert/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasLohnert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasLohnert/subscriptions","organizations_url":"https://api.github.com/users/ThomasLohnert/orgs","repos_url":"https://api.github.com/users/ThomasLohnert/repos","events_url":"https://api.github.com/users/ThomasLohnert/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasLohnert/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nIndividual moves now do not apply any other changed setpoints, but simply reset the latest setpoint readback value for following beamline parameters in the mode.\r\nTo achieve this, I have split `update_beamline_parameters` into two methods: \r\n- one that gets called after an individual move and resets the sp_rbvs of subsequent parameters in the mode\r\n- one that gets called on a beamline move and updates all parameters to their latest values\r\n\r\n### To test\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/3551\r\n\r\n### Acceptance criteria\r\n\r\n- Triggering an individual move on a parameter...\r\n    - [ ] Applies its new setpoint\r\n    - [ ] Does not apply any other changed setpoints\r\n    - [ ] Moves following parameters to their sp_rbv value if they are in the mode\r\n    - [ ] Does not move any parameters that are not in the mode\r\n- Other functionality is unchanged.\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Has the author taken into account the multi-threaded nature of the code?\r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev). If so, do they describe the changes appropriately?\r\n- [ ] Has the [manual system tests spreadsheet](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Manual-system-tests) been updated?\r\n\r\n### Functional Tests\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed.\r\n\r\n### Final steps\r\n\r\n- [ ] Reviewer has updated the submodule in the main EPICS repo? See **Reviewing work for the subModules of EPICS** in the [Git workflow](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Git-workflow) page for details.\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n","created_at":"2018-09-19T16:40:32Z","updated_at":"2018-09-19T16:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/167/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/167/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/167/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/statuses/7498b361b6c2d7d7c1a851999dc2d518add17500","head":{"label":"ISISComputingGroup:Ticket3551_refl_fix_individual_move","ref":"Ticket3551_refl_fix_individual_move","sha":"7498b361b6c2d7d7c1a851999dc2d518add17500","user":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":40836703,"node_id":"MDEwOlJlcG9zaXRvcnk0MDgzNjcwMw==","name":"EPICS-inst_servers","full_name":"ISISComputingGroup/EPICS-inst_servers","private":false,"owner":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers","description":null,"fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers","forks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/deployments","created_at":"2015-08-16T19:48:23Z","updated_at":"2018-09-19T10:07:24Z","pushed_at":"2018-09-19T16:31:07Z","git_url":"git://github.com/ISISComputingGroup/EPICS-inst_servers.git","ssh_url":"git@github.com:ISISComputingGroup/EPICS-inst_servers.git","clone_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers.git","svn_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers","homepage":null,"size":2606,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master","ref":"master","sha":"fe38f8a6b2b8dedf8d616c2860f417a0bc497af3","user":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":40836703,"node_id":"MDEwOlJlcG9zaXRvcnk0MDgzNjcwMw==","name":"EPICS-inst_servers","full_name":"ISISComputingGroup/EPICS-inst_servers","private":false,"owner":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers","description":null,"fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers","forks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/deployments","created_at":"2015-08-16T19:48:23Z","updated_at":"2018-09-19T10:07:24Z","pushed_at":"2018-09-19T16:31:07Z","git_url":"git://github.com/ISISComputingGroup/EPICS-inst_servers.git","ssh_url":"git@github.com:ISISComputingGroup/EPICS-inst_servers.git","clone_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers.git","svn_url":"https://github.com/ISISComputingGroup/EPICS-inst_servers","homepage":null,"size":2606,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/167"},"html":{"href":"https://github.com/ISISComputingGroup/EPICS-inst_servers/pull/167"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/167"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/EPICS-inst_servers/statuses/7498b361b6c2d7d7c1a851999dc2d518add17500"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":105,"deletions":22,"changed_files":5}}
{"actor":{"display_login":"ThomasLohnert"}}