{"action":"created","comment":{"url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/comments/217146159","pull_request_review_id":154790715,"id":217146159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE0NjE1OQ==","diff_hunk":"@@ -419,32 +424,32 @@ class FfmpegCommandService {\n         return filter;\n     }\n \n-    _calculateHorizontalPosition(x) {\n+    _calculateHorizontalPosition(x, defaultMargin) {\n         switch (x) {\n             case 'left':\n-                return 0;\n+                return defaultMargin;\n \n             case 'center':\n                 return '(main_w/2-text_w/2)';\n \n             case 'right':\n-                return 'main_w-text_w';\n+                return `main_w-text_w-${defaultMargin}`;\n \n             default:\n                 return x;\n         }\n     }\n \n-    _calculateVerticalPosition(y) {\n+    _calculateVerticalPosition(y, defaultMargin) {","path":"lib/ffmpegCommandService.js","position":47,"original_position":47,"commit_id":"559dff0bd950b78e4688fee7034be6a893a5dfb9","original_commit_id":"559dff0bd950b78e4688fee7034be6a893a5dfb9","user":{"login":"jonathan-fulton","id":4665111,"node_id":"MDQ6VXNlcjQ2NjUxMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4665111?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathan-fulton","html_url":"https://github.com/jonathan-fulton","followers_url":"https://api.github.com/users/jonathan-fulton/followers","following_url":"https://api.github.com/users/jonathan-fulton/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-fulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-fulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-fulton/subscriptions","organizations_url":"https://api.github.com/users/jonathan-fulton/orgs","repos_url":"https://api.github.com/users/jonathan-fulton/repos","events_url":"https://api.github.com/users/jonathan-fulton/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-fulton/received_events","type":"User","site_admin":false},"body":"Same as above.  `margin` instead of `defaultMargin`.","created_at":"2018-09-12T18:43:55Z","updated_at":"2018-09-12T18:43:55Z","html_url":"https://github.com/jonathan-fulton/whipple-video/pull/4#discussion_r217146159","pull_request_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/comments/217146159"},"html":{"href":"https://github.com/jonathan-fulton/whipple-video/pull/4#discussion_r217146159"},"pull_request":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4","id":215005079,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDA1MDc5","html_url":"https://github.com/jonathan-fulton/whipple-video/pull/4","diff_url":"https://github.com/jonathan-fulton/whipple-video/pull/4.diff","patch_url":"https://github.com/jonathan-fulton/whipple-video/pull/4.patch","issue_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/4","number":4,"state":"closed","locked":false,"title":"Added defaultMargin option","user":{"login":"MiniCodeMonkey","id":220535,"node_id":"MDQ6VXNlcjIyMDUzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/220535?v=4","gravatar_id":"","url":"https://api.github.com/users/MiniCodeMonkey","html_url":"https://github.com/MiniCodeMonkey","followers_url":"https://api.github.com/users/MiniCodeMonkey/followers","following_url":"https://api.github.com/users/MiniCodeMonkey/following{/other_user}","gists_url":"https://api.github.com/users/MiniCodeMonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniCodeMonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniCodeMonkey/subscriptions","organizations_url":"https://api.github.com/users/MiniCodeMonkey/orgs","repos_url":"https://api.github.com/users/MiniCodeMonkey/repos","events_url":"https://api.github.com/users/MiniCodeMonkey/events{/privacy}","received_events_url":"https://api.github.com/users/MiniCodeMonkey/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-12T15:31:02Z","updated_at":"2018-09-12T18:43:55Z","closed_at":"2018-09-12T18:36:15Z","merged_at":"2018-09-12T18:36:15Z","merge_commit_sha":"a0b59407a93fb30207ba3f56aa903dfa2a4d02a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4/commits","review_comments_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4/comments","review_comment_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/4/comments","statuses_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/statuses/559dff0bd950b78e4688fee7034be6a893a5dfb9","head":{"label":"jonathan-fulton:feature/text-margin-option","ref":"feature/text-margin-option","sha":"559dff0bd950b78e4688fee7034be6a893a5dfb9","user":{"login":"jonathan-fulton","id":4665111,"node_id":"MDQ6VXNlcjQ2NjUxMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4665111?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathan-fulton","html_url":"https://github.com/jonathan-fulton","followers_url":"https://api.github.com/users/jonathan-fulton/followers","following_url":"https://api.github.com/users/jonathan-fulton/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-fulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-fulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-fulton/subscriptions","organizations_url":"https://api.github.com/users/jonathan-fulton/orgs","repos_url":"https://api.github.com/users/jonathan-fulton/repos","events_url":"https://api.github.com/users/jonathan-fulton/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-fulton/received_events","type":"User","site_admin":false},"repo":{"id":115639964,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU2Mzk5NjQ=","name":"whipple-video","full_name":"jonathan-fulton/whipple-video","owner":{"login":"jonathan-fulton","id":4665111,"node_id":"MDQ6VXNlcjQ2NjUxMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4665111?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathan-fulton","html_url":"https://github.com/jonathan-fulton","followers_url":"https://api.github.com/users/jonathan-fulton/followers","following_url":"https://api.github.com/users/jonathan-fulton/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-fulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-fulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-fulton/subscriptions","organizations_url":"https://api.github.com/users/jonathan-fulton/orgs","repos_url":"https://api.github.com/users/jonathan-fulton/repos","events_url":"https://api.github.com/users/jonathan-fulton/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-fulton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathan-fulton/whipple-video","description":null,"fork":false,"url":"https://api.github.com/repos/jonathan-fulton/whipple-video","forks_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/forks","keys_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/teams","hooks_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/hooks","issue_events_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/events{/number}","events_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/events","assignees_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/assignees{/user}","branches_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/branches{/branch}","tags_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/tags","blobs_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/languages","stargazers_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/stargazers","contributors_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/contributors","subscribers_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/subscribers","subscription_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/subscription","commits_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/contents/{+path}","compare_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/merges","archive_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/downloads","issues_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues{/number}","pulls_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/labels{/name}","releases_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/releases{/id}","deployments_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/deployments","created_at":"2017-12-28T16:17:32Z","updated_at":"2018-09-12T18:38:40Z","pushed_at":"2018-09-12T18:38:39Z","git_url":"git://github.com/jonathan-fulton/whipple-video.git","ssh_url":"git@github.com:jonathan-fulton/whipple-video.git","clone_url":"https://github.com/jonathan-fulton/whipple-video.git","svn_url":"https://github.com/jonathan-fulton/whipple-video","homepage":null,"size":47498,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jonathan-fulton:master","ref":"master","sha":"7760cd22c18d764505a0a5c7a699abe110c509af","user":{"login":"jonathan-fulton","id":4665111,"node_id":"MDQ6VXNlcjQ2NjUxMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4665111?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathan-fulton","html_url":"https://github.com/jonathan-fulton","followers_url":"https://api.github.com/users/jonathan-fulton/followers","following_url":"https://api.github.com/users/jonathan-fulton/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-fulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-fulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-fulton/subscriptions","organizations_url":"https://api.github.com/users/jonathan-fulton/orgs","repos_url":"https://api.github.com/users/jonathan-fulton/repos","events_url":"https://api.github.com/users/jonathan-fulton/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-fulton/received_events","type":"User","site_admin":false},"repo":{"id":115639964,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU2Mzk5NjQ=","name":"whipple-video","full_name":"jonathan-fulton/whipple-video","owner":{"login":"jonathan-fulton","id":4665111,"node_id":"MDQ6VXNlcjQ2NjUxMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4665111?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathan-fulton","html_url":"https://github.com/jonathan-fulton","followers_url":"https://api.github.com/users/jonathan-fulton/followers","following_url":"https://api.github.com/users/jonathan-fulton/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-fulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-fulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-fulton/subscriptions","organizations_url":"https://api.github.com/users/jonathan-fulton/orgs","repos_url":"https://api.github.com/users/jonathan-fulton/repos","events_url":"https://api.github.com/users/jonathan-fulton/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-fulton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathan-fulton/whipple-video","description":null,"fork":false,"url":"https://api.github.com/repos/jonathan-fulton/whipple-video","forks_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/forks","keys_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/teams","hooks_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/hooks","issue_events_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/events{/number}","events_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/events","assignees_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/assignees{/user}","branches_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/branches{/branch}","tags_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/tags","blobs_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/languages","stargazers_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/stargazers","contributors_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/contributors","subscribers_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/subscribers","subscription_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/subscription","commits_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/contents/{+path}","compare_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/merges","archive_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/downloads","issues_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues{/number}","pulls_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/labels{/name}","releases_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/releases{/id}","deployments_url":"https://api.github.com/repos/jonathan-fulton/whipple-video/deployments","created_at":"2017-12-28T16:17:32Z","updated_at":"2018-09-12T18:38:40Z","pushed_at":"2018-09-12T18:38:39Z","git_url":"git://github.com/jonathan-fulton/whipple-video.git","ssh_url":"git@github.com:jonathan-fulton/whipple-video.git","clone_url":"https://github.com/jonathan-fulton/whipple-video.git","svn_url":"https://github.com/jonathan-fulton/whipple-video","homepage":null,"size":47498,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4"},"html":{"href":"https://github.com/jonathan-fulton/whipple-video/pull/4"},"issue":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/4"},"comments":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/jonathan-fulton/whipple-video/statuses/559dff0bd950b78e4688fee7034be6a893a5dfb9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jonathan-fulton"}}