{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/16941","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/16941/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/16941/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/16941/events","html_url":"https://github.com/magento/magento2/pull/16941","id":342726125,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTU3ODAx","number":16941,"title":"Magento_Catalog: gallery - fotorama__caption show/hide","user":{"login":"joe-vortex","id":19905193,"node_id":"MDQ6VXNlcjE5OTA1MTkz","avatar_url":"https://avatars0.githubusercontent.com/u/19905193?v=4","gravatar_id":"","url":"https://api.github.com/users/joe-vortex","html_url":"https://github.com/joe-vortex","followers_url":"https://api.github.com/users/joe-vortex/followers","following_url":"https://api.github.com/users/joe-vortex/following{/other_user}","gists_url":"https://api.github.com/users/joe-vortex/gists{/gist_id}","starred_url":"https://api.github.com/users/joe-vortex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joe-vortex/subscriptions","organizations_url":"https://api.github.com/users/joe-vortex/orgs","repos_url":"https://api.github.com/users/joe-vortex/repos","events_url":"https://api.github.com/users/joe-vortex/events{/privacy}","received_events_url":"https://api.github.com/users/joe-vortex/received_events","type":"User","site_admin":false},"labels":[{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/2.2-develop","name":"2.2-develop","color":"fbca04","default":false},{"id":956032057,"node_id":"MDU6TGFiZWw5NTYwMzIwNTc=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Design/Frontend","name":"Area: Design/Frontend","color":"1d76db","default":false},{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":374038437,"node_id":"MDU6TGFiZWwzNzQwMzg0Mzc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Catalog","name":"Component: Catalog","color":"7fb703","default":false},{"id":998766797,"node_id":"MDU6TGFiZWw5OTg3NjY3OTc=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Vortex","name":"Partner: Vortex","color":"ededed","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"miguelbalparda","id":3997682,"node_id":"MDQ6VXNlcjM5OTc2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3997682?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbalparda","html_url":"https://github.com/miguelbalparda","followers_url":"https://api.github.com/users/miguelbalparda/followers","following_url":"https://api.github.com/users/miguelbalparda/following{/other_user}","gists_url":"https://api.github.com/users/miguelbalparda/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbalparda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbalparda/subscriptions","organizations_url":"https://api.github.com/users/miguelbalparda/orgs","repos_url":"https://api.github.com/users/miguelbalparda/repos","events_url":"https://api.github.com/users/miguelbalparda/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbalparda/received_events","type":"User","site_admin":false},"assignees":[{"login":"miguelbalparda","id":3997682,"node_id":"MDQ6VXNlcjM5OTc2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3997682?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbalparda","html_url":"https://github.com/miguelbalparda","followers_url":"https://api.github.com/users/miguelbalparda/followers","following_url":"https://api.github.com/users/miguelbalparda/following{/other_user}","gists_url":"https://api.github.com/users/miguelbalparda/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbalparda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbalparda/subscriptions","organizations_url":"https://api.github.com/users/miguelbalparda/orgs","repos_url":"https://api.github.com/users/miguelbalparda/repos","events_url":"https://api.github.com/users/miguelbalparda/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbalparda/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/20","html_url":"https://github.com/magento/magento2/milestone/20","labels_url":"https://api.github.com/repos/magento/magento2/milestones/20/labels","id":3383796,"node_id":"MDk6TWlsZXN0b25lMzM4Mzc5Ng==","number":20,"title":"Release: 2.2.6","description":"Community pull requests delivered to Release: 2.2.6 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":212,"state":"open","created_at":"2018-05-29T11:52:10Z","updated_at":"2018-07-23T08:36:10Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-07-19T13:23:06Z","updated_at":"2018-07-23T09:44:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/16941","html_url":"https://github.com/magento/magento2/pull/16941","diff_url":"https://github.com/magento/magento2/pull/16941.diff","patch_url":"https://github.com/magento/magento2/pull/16941.patch"},"body":"### Issue\r\nThe fotorama version in 2.2.5 in includes a parameter for `captions` in addition to `showCaption`, which defaults to true and shows the caption below the gallery image, there is no way to control this in the traditional sense, besides hiding with CSS or adding a plugin using the `setOptions()` function.\r\n\r\n### Testing\r\nWith the blank/luma default view.xml vars:\r\n```\r\n...\r\n    <vars module=\"Magento_Catalog\">\r\n        <var name=\"gallery\">\r\n            <var name=\"captions\">false</var> <!-- Show caption below images -->\r\n        </var>\r\n    </vars>\r\n...\r\n```\r\nThe `fotorama__caption` element should be hidden on screen.\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/407001004","html_url":"https://github.com/magento/magento2/pull/16941#issuecomment-407001004","issue_url":"https://api.github.com/repos/magento/magento2/issues/16941","id":407001004,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzAwMTAwNA==","user":{"login":"joe-vortex","id":19905193,"node_id":"MDQ6VXNlcjE5OTA1MTkz","avatar_url":"https://avatars0.githubusercontent.com/u/19905193?v=4","gravatar_id":"","url":"https://api.github.com/users/joe-vortex","html_url":"https://github.com/joe-vortex","followers_url":"https://api.github.com/users/joe-vortex/followers","following_url":"https://api.github.com/users/joe-vortex/following{/other_user}","gists_url":"https://api.github.com/users/joe-vortex/gists{/gist_id}","starred_url":"https://api.github.com/users/joe-vortex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joe-vortex/subscriptions","organizations_url":"https://api.github.com/users/joe-vortex/orgs","repos_url":"https://api.github.com/users/joe-vortex/repos","events_url":"https://api.github.com/users/joe-vortex/events{/privacy}","received_events_url":"https://api.github.com/users/joe-vortex/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T09:44:24Z","updated_at":"2018-07-23T09:44:24Z","author_association":"MEMBER","body":"@gwharton I noticed this too. The variable default is true and the getvar function would just not output anything. I have tested this by hard setting `showCaption` to false and it's not adding the element in the DOM. The fix you referenced - `\"showCaption\": <?= /* @escapeNotVerified */ $block->getVar(\"gallery/caption\") ? 'true' : 'false'` would prevent the confusion with not set/false.\r\n\r\nIf your PR is going to be included in the next release then we could close my PR. This was my first contribution. Better luck next time I guess :frowning_face: "}}
{"actor":{"display_login":"joe-vortex"}}